Ros-dev December 2017

ros-dev@reactos.org

19 participants
13 discussions

Re: [ros-dev] Merging our x86 HALs
by Alex Ionescu 14 Dec '17

14 Dec '17

I would move to the Win8+ HAL Model -- a single HAL for APIC, ACPI with runtime support for UEFI (if present) and MP (if present). If people still want to run on a PIC VM (why???) or old computer, then we can also maintain the HAL PIC x86 for UP. Hence there would only be 2 HALs. Best regards, Alex Ionescu On Mon, Dec 11, 2017 at 1:07 AM, Colin Finck <colin(a)reactos.org> wrote: > Am 11.12.2017 um 01:18 schrieb Hermès BÉLUSCA-MAÏTO:> If you basically > put all the HALs into one, then you obtain bloated stuff (which remains > in memory for the whole life of the OS). Example: standard HAL is 1MB > vs. ACPI HAL which is few kBHave you actually checked what makes up this > difference? > Hint: hal/halx86/legacy/bus/pci_vendors.ids > > > > Note that if Windows nowadays has only one hal, it's because they now > support basically only one "architecture"/platform, namely, ACPI > multiprocessor (to put it simple). It has its pros, but also a lot of cons. > > That doesn't mean we need to do the same. We can have one HAL for all > (Pentium and newer) x86 platforms. The overhead of additional checks at > boot-up is negligible. That should be a solution for 99% of the people > out there. The rest may still go and trim down our HAL to their needs. > > But let's not pretend we can maintain multiple x86 HALs for all x86 > computers out there. Do you really want to test X HALs with Y different > systems? Ensure that a legacy HAL runs on a modern ACPI system? What > would be the point? > > > > Besides this, I've a question about your observation that in the APIC > hal (not ACPI) there's different implementation of > HalpCalibrateStallExecution and HalpInitializePICs / > HalpInitializeLegacyPIC . Isn't it precisely because these stuff are > completely different from the standard PICs used in platforms for which the > standard HAL (and possibly the ACPI HAL) are used? > > Absolutely not! You need to reprogram the standard PICs also on an APIC > system, and this is precisely what both functions do. Put them into a > diff tool to see for yourself. > > The same goes for timers. Even with the introduction of ACPI Timers, > Local APIC Timers, and Time-Stamp Counters, you still need a traditional > one (like RTC or PIT) for calibration at system startup. Simply because > the newer ones don't run at a known fixed frequency. > The Legacy HAL successfully employs an algorithm based on the RTC while > the APIC HAL unsuccessfully tries to use the PIT. > > > > Actually we should, because the detection might not work (of course in > our simple case "ACPI UP/MP" vs. "Standard", it's simple, but think about > other platforms where there can be subtle differences) > > Tell me about a single one we cannot detect and which is worth to > support. I don't recall that we ever recommended our testers to choose a > different HAL at setup. > > > > And normally it's not the setup that decides about the HAL, but the > bootloader. > > That defies your previous point about the setup initializing the > registry depending on the HAL. > If we can let the user select a Legacy HAL in the boot loader after > installing with an ACPI HAL, it is also technically possible to have one > HAL that encompasses both. > > > - Colin > > _______________________________________________ > Ros-dev mailing list > Ros-dev(a)reactos.org > http://www.reactos.org/mailman/listinfo/ros-dev >

9 15

Re: [ros-dev] [ros-diffs] [reactos] 01/01: [UUID] Add a PCH.
by Thomas Faber 09 Dec '17

09 Dec '17

I'm a bit surprised that this works. Don't we have those big "don't use the PCH for this file" warnings in every guid.c? This library consists only of guid.c's :p On 2017-12-09 13:04, Amine Khaldi wrote: > https://git.reactos.org/?p=reactos.git;a=commitdiff;h=69005963fb4b1378f6a66… > > commit 69005963fb4b1378f6a666c2b8b2483c222740f8 > Author: Amine Khaldi <amine.khaldi(a)reactos.org> > AuthorDate: Sat Dec 9 13:04:23 2017 +0100 > > [UUID] Add a PCH. > --- > sdk/lib/uuid/CMakeLists.txt | 4 +++- > sdk/lib/uuid/precomp.h | 10 ++++++++++ > 2 files changed, 13 insertions(+), 1 deletion(-) > > diff --git a/sdk/lib/uuid/CMakeLists.txt b/sdk/lib/uuid/CMakeLists.txt > index d99bc73a35..09efcd927f 100644 > --- a/sdk/lib/uuid/CMakeLists.txt > +++ b/sdk/lib/uuid/CMakeLists.txt > @@ -219,7 +219,9 @@ list(APPEND SOURCE > # vcguids.c > wdmguids.c > otherguids.c > - undoc.c) > + undoc.c > + precomp.h) > > add_library(uuid ${SOURCE}) > +add_pch(uuid precomp.h SOURCE) > add_dependencies(uuid psdk) > diff --git a/sdk/lib/uuid/precomp.h b/sdk/lib/uuid/precomp.h > new file mode 100644 > index 0000000000..abe35fac5e > --- /dev/null > +++ b/sdk/lib/uuid/precomp.h > @@ -0,0 +1,10 @@ > +#ifndef _UUID_PRECOMP_H_ > +#define _UUID_PRECOMP_H_ > + > +#define WIN32_NO_STATUS > +#define WIN32_LEAN_AND_MEAN > + > +#include <rpc.h> > +#include <rpcndr.h> > + > +#endif /* _UUID_PRECOMP_H_ */ >

1 0

Re: [ros-dev] AHK Bot maintenance in progress
by Sylvain Petreolle 02 Dec '17

02 Dec '17

Test KVM AHK is back on its feet. After a fight with the package update manager (bug in dnf) and a problem with the primary monitor setting,its building and testing the last push from AmineKhaldi Kind regards, Sylvain Petreolle Le Mardi 28 novembre 2017 23h06, Sylvain Petreolle <spetreolle(a)yahoo.fr> a écrit : The AHK bot crashes often these days. I uploaded a crash dump to Fedora and discovered that these crashes are due to the network emulation (SLIRP) used in KVM. For reference, here is the opened issue : https://bugzilla.redhat.com/show_bug.cgi?id=1509589 Since bugs with previous versions of Fedora take time to be resolved, I'm upgrading the bot to Fedora 27. Ideas to overcome the SLIRP problems are welcome. After all, if it crashes the virtual machine, it could also be at the source of other problems. The AHK tests show randomness in the tests that require network,related to nonblocking mode not working, but it could involve KVM too. Kind regards, Sylvain Petreolle

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev December 2017