Ros-dev February 2017

ros-dev@reactos.org

27 participants
25 discussions

FishEye DB being rebuilt
by Colin Finck 14 Feb '17

14 Feb '17

Hi all! As this is taking longer than expected, I should give a notice: In an attempt to restart hanging FishEye yet another time yesterday, its stored database of the reactos SVN repository was corrupted... I'm rebuilding it since yesterday evening, but parsing all the diffs is a long process. Can't give any ETA yet. So far, only commit information without diff is available at code.reactos.org. Cheers, Colin

4 7

Re: [ros-dev] [ros-diffs] [ekohl] 73795: [NTOSKRNL] Implement IopGetDeviceRelations().
by Thomas Faber 14 Feb '17

14 Feb '17

On 2017-02-13 23:38, ekohl(a)svn.reactos.org wrote: > + _SEH2_TRY > + { > + Relations = RelationsData->Relations; > + BufferSize = RelationsData->BufferSize; > + Buffer = RelationsData->Buffer; > + > + ProbeForWrite(RelationsData->Buffer, > + RelationsData->BufferSize, > + sizeof(CHAR)); > + } You need to use the local 'Buffer' and 'BufferSize' variables in the probe or you get a race condition. > + Status = IopInitiatePnpIrp(DeviceObject, > + &IoStatusBlock, > + IRP_MN_QUERY_DEVICE_RELATIONS, > + &Stack); > + if (!NT_SUCCESS(Status) || Status == STATUS_PENDING) > + { > + DPRINT1("IopInitiatePnpIrp() failed (Status 0x%08lx)\n", Status); > + goto done; > + } Failing on STATUS_PENDING seems broken. IoStatusBlock will go out of scope and the DeviceRelations set by the driver will be leaked. > + if (RequiredSize > 0) > + RequiredSize += sizeof(WCHAR); Not sure I understand the >0 condition. Best, Thomas

1 0

UEFI Bootmgr vs. FreeLdr
by Colin Finck 06 Feb '17

06 Feb '17

Hi all! Seeing the recent UEFI Bootmgr work in trunk, I was wondering about its design. Will that be a UEFI-only boot loader or eventually replace/merge with FreeLdr to provide a common boot loader for BIOS and UEFI systems? Will it simply follow all design principles of the NT6+ boot loader or also implement some own ideas or take over those from FreeLdr? For instance, I totally like FreeLdr's configuration through INI files and would prefer that any day over NT6+ BCD registry hives. Cheers, Colin

3 2

Google Summer of Code 2017
by Colin Finck 03 Feb '17

03 Feb '17

Hi all! Google Summer of Code 2017 is fast approaching, with February 9 being the deadline for projects to apply. With our record of successfully completing all 4 ideas (msahci, NTFS, lwIP, USB) last year, we should definitely apply again. Aleksey and Amine have already begun filling out the application form. Based on the 2016 ideas Wiki page, we have also created a new ideas page at https://reactos.org/wiki/Google_Summer_of_Code_2017_Ideas Please share your thoughts on these and add anything that's missing. What we now need are possible mentors. Who would be available for this? Cheers, Colin

4 4

About JIRA Account
by JasonQSY 01 Feb '17

01 Feb '17

Hi, I’m interested in ros dev now and it seems that fixing small bugs could be a good start. Could I have a JIRA account and have a look at the issues? Or any suggestions about jobs could be done by a newcomer? - JasonQSY

2 1

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev February 2017