Ros-dev August 2017

ros-dev@reactos.org

15 participants
16 discussions

Start a nNew thread

"Note: LibreOffice 5.4 will be the last codeline to support Windows XP or Vista"

by Javier Agustìn Fernàndez Arroyo

https://wiki.documentfoundation.org/Releases/5.4.0/RC1 FYI

6 years, 7 months

Status Meeting (August 2017)

by Colin Finck

Hi all! Let me invite you to the monthly status meeting taking place on Thursday, August 31, 19:00 UTC. As always, you will get credentials for our private IRC server shortly before the meeting. Agenda proposals so far include: - Short report from my side regarding the Hackfest - Git/GitHub migration in September/October - Finalizing the 0.4.6 release, possibly planning 0.4.7 Please post any additional agenda proposals here. Also don't forget that we're in the final week of GSoC :) Mentors, now that all code has been submitted, don't forget about evaluating your students! See you on Thursday! Colin

7 years, 3 months

who is the administrator of ReactOS Facebook Group?

by Alexander Rechitskiy

7 years, 3 months

Re: [ros-dev] [ros-diffs] [cfinck] 75630: [FS_REC] - Add a detection routine for CDFS (ISO-9660) volumes that verifies the Primary Volume Descriptor. - Use this to also detect CDFS on disks and load the CDFS driver if it ha...

by Pierre Schweitzer

Hi Colin, Thanks for your work. This commit is likely breaking UDFS recognition when media has a protective CDFS partition with UDFS afterwards, while both FSD are unloaded. You'll first match the CDFS recognizer and not the UDFS recognizer. I would suggest you modify FsRecRegisterFs() so that you can register low priority FS. Cheers, Pierre Le 20/08/2017 à 17:30, cfinck(a)svn.reactos.org a écrit : > Author: cfinck > Date: Sun Aug 20 15:30:59 2017 > New Revision: 75630 > > URL: http://svn.reactos.org/svn/reactos?rev=75630&view=rev > Log: > [FS_REC] > - Add a detection routine for CDFS (ISO-9660) volumes that verifies the Primary Volume Descriptor. > - Use this to also detect CDFS on disks and load the CDFS driver if it has not been loaded yet (e.g. when a bootcd/livecd flashed USB drive is inserted at boot of an installed ReactOS). > - Fix a comment in udfs.c. > > Added: > trunk/reactos/drivers/filesystems/fs_rec/cdfs.h (with props) > Modified: > trunk/reactos/drivers/filesystems/fs_rec/cdfs.c > trunk/reactos/drivers/filesystems/fs_rec/fs_rec.c > trunk/reactos/drivers/filesystems/fs_rec/udfs.c > > Modified: trunk/reactos/drivers/filesystems/fs_rec/cdfs.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/fs_rec… > ============================================================================== > --- trunk/reactos/drivers/filesystems/fs_rec/cdfs.c [iso-8859-1] (original) > +++ trunk/reactos/drivers/filesystems/fs_rec/cdfs.c [iso-8859-1] Sun Aug 20 15:30:59 2017 > @@ -1,10 +1,10 @@ > /* > - * COPYRIGHT: See COPYING in the top level directory > - * PROJECT: ReactOS File System Recognizer > - * FILE: drivers/filesystems/fs_rec/cdfs.c > - * PURPOSE: CDFS Recognizer > - * PROGRAMMER: Alex Ionescu (alex.ionescu(a)reactos.org) > - * Eric Kohl > + * PROJECT: ReactOS File System Recognizer > + * LICENSE: GPL-2.0 (https://spdx.org/licenses/GPL-2.0) > + * PURPOSE: CDFS Recognizer > + * COPYRIGHT: Copyright 2002 Eric Kohl > + * Copyright 2007 Alex Ionescu <alex.ionescu(a)reactos.org> > + * Copyright 2017 Colin Finck <colin(a)reactos.org> > */ > > /* INCLUDES *****************************************************************/ > @@ -14,13 +14,60 @@ > #define NDEBUG > #include <debug.h> > > +#include "cdfs.h" > + > /* FUNCTIONS ****************************************************************/ > + > +BOOLEAN > +NTAPI > +FsRecIsCdfsVolume(IN PDEVICE_OBJECT DeviceObject, > + IN ULONG SectorSize) > +{ > + BOOLEAN bReturnValue = FALSE; > + LARGE_INTEGER Offset; > + PVD_HEADER pVdHeader = NULL; > + PAGED_CODE(); > + > + // Read the Primary Volume Descriptor. > + Offset.QuadPart = VD_HEADER_OFFSET; > + if (!FsRecReadBlock(DeviceObject, &Offset, sizeof(VD_HEADER), SectorSize, (PVOID*)&pVdHeader, NULL)) > + { > + // We cannot read this block, so no reason to let the CDFS driver try it. > + goto Cleanup; > + } > + > + // Verify the fields. > + if (pVdHeader->Type != VD_TYPE_PRIMARY) > + goto Cleanup; > + > + DPRINT("pVdHeader->Type verified!\n"); > + > + if (RtlCompareMemory(pVdHeader->Identifier, VD_IDENTIFIER, VD_IDENTIFIER_LENGTH) != VD_IDENTIFIER_LENGTH) > + goto Cleanup; > + > + DPRINT("pVdHeader->Identifier verified!\n"); > + > + if (pVdHeader->Version != VD_VERSION) > + goto Cleanup; > + > + DPRINT("pVdHeader->Version verified! This is a CDFS volume!\n"); > + > + bReturnValue = TRUE; > + > +Cleanup: > + if (pVdHeader) > + ExFreePool(pVdHeader); > + > + return bReturnValue; > +} > > NTSTATUS > NTAPI > FsRecCdfsFsControl(IN PDEVICE_OBJECT DeviceObject, > IN PIRP Irp) > { > + PDEVICE_OBJECT MountDevice; > + ULONG SectorSize; > PIO_STACK_LOCATION Stack; > NTSTATUS Status; > PAGED_CODE(); > @@ -31,8 +78,21 @@ > { > case IRP_MN_MOUNT_VOLUME: > > - /* We don't validate */ > - Status = STATUS_FS_DRIVER_REQUIRED; > + /* Assume failure */ > + Status = STATUS_UNRECOGNIZED_VOLUME; > + > + /* Get the device object and request the sector size */ > + MountDevice = Stack->Parameters.MountVolume.DeviceObject; > + if (FsRecGetDeviceSectorSize(MountDevice, &SectorSize)) > + { > + /* Check if it's an actual CDFS (ISO-9660) volume */ > + if (FsRecIsCdfsVolume(MountDevice, SectorSize)) > + { > + /* It is! */ > + Status = STATUS_FS_DRIVER_REQUIRED; > + } > + } > + > break; > > case IRP_MN_LOAD_FILE_SYSTEM: > > Added: trunk/reactos/drivers/filesystems/fs_rec/cdfs.h > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/fs_rec… > ============================================================================== > --- trunk/reactos/drivers/filesystems/fs_rec/cdfs.h (added) > +++ trunk/reactos/drivers/filesystems/fs_rec/cdfs.h [iso-8859-1] Sun Aug 20 15:30:59 2017 > @@ -0,0 +1,24 @@ > +/* > + * PROJECT: ReactOS File System Recognizer > + * LICENSE: GPL-2.0 (https://spdx.org/licenses/GPL-2.0+) > + * PURPOSE: CDFS Recognizer > + * COPYRIGHT: Copyright 2017 Colin Finck <colin(a)reactos.org> > + */ > + > +// Information from http://wiki.osdev.org/ISO_9660#Volume_Descriptors > + > +// Structures > +typedef struct _VD_HEADER > +{ > + char Type; > + char Identifier[5]; > + char Version; > +} > +VD_HEADER, *PVD_HEADER; > + > +// Constants > +#define VD_HEADER_OFFSET 32768 // Offset of the VD Header > +#define VD_IDENTIFIER "CD001" // Identifier that must be in the Volume Descriptor > +#define VD_IDENTIFIER_LENGTH 5 // Character count of VD_IDENTIFIER > +#define VD_TYPE_PRIMARY 1 // Type code for Primary Volume Descriptor > +#define VD_VERSION 1 // Volume Descriptor Version > > Propchange: trunk/reactos/drivers/filesystems/fs_rec/cdfs.h > ------------------------------------------------------------------------------ > svn:eol-style = native > > Modified: trunk/reactos/drivers/filesystems/fs_rec/fs_rec.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/fs_rec… > ============================================================================== > --- trunk/reactos/drivers/filesystems/fs_rec/fs_rec.c [iso-8859-1] (original) > +++ trunk/reactos/drivers/filesystems/fs_rec/fs_rec.c [iso-8859-1] Sun Aug 20 15:30:59 2017 > @@ -316,6 +316,7 @@ > { > ULONG DeviceCount = 0; > NTSTATUS Status; > + PDEVICE_OBJECT CdfsObject; > PDEVICE_OBJECT UdfsObject; > PAGED_CODE(); > > @@ -340,14 +341,24 @@ > DriverObject->MajorFunction[IRP_MJ_FILE_SYSTEM_CONTROL] = FsRecFsControl; > DriverObject->DriverUnload = FsRecUnload; > > - /* Register CDFS */ > - Status = FsRecRegisterFs(DriverObject, > - NULL, > - NULL, > + /* Register CDFS for CDs */ > + Status = FsRecRegisterFs(DriverObject, > + NULL, > + &CdfsObject, > L"\\Cdfs", > L"\\FileSystem\\CdfsRecognizer", > FS_TYPE_CDFS, > FILE_DEVICE_CD_ROM_FILE_SYSTEM); > + if (NT_SUCCESS(Status)) DeviceCount++; > + > + /* Register CDFS for HDDs */ > + Status = FsRecRegisterFs(DriverObject, > + CdfsObject, > + NULL, > + L"\\CdfsHdd", > + L"\\FileSystem\\CdfsHddRecognizer", > + FS_TYPE_CDFS, > + FILE_DEVICE_DISK_FILE_SYSTEM); > if (NT_SUCCESS(Status)) DeviceCount++; > > /* Register UDFS for CDs */ > > Modified: trunk/reactos/drivers/filesystems/fs_rec/udfs.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/fs_rec… > ============================================================================== > --- trunk/reactos/drivers/filesystems/fs_rec/udfs.c [iso-8859-1] (original) > +++ trunk/reactos/drivers/filesystems/fs_rec/udfs.c [iso-8859-1] Sun Aug 20 15:30:59 2017 > @@ -125,7 +125,7 @@ > MountDevice = Stack->Parameters.MountVolume.DeviceObject; > if (FsRecGetDeviceSectorSize(MountDevice, &SectorSize)) > { > - /* Check if it's an actual FAT volume */ > + /* Check if it's an actual UDF volume */ > if (FsRecIsUdfsVolume(MountDevice, SectorSize)) > { > /* It is! */ > > -- Pierre Schweitzer <pierre at reactos.org> System & Network Administrator Senior Kernel Developer ReactOS Deutschland e.V.

7 years, 4 months

Re: [ros-dev] undelate

by Magnus Johnsson

1. Send a mail to the list unsubscribe address, which will be of the form LISTNAME-leave@DOMAIN. The subject and body of this message will be ignored, so it doesn't matter what you put there. not sure if you found out this yet. Quick google for mailman, which seems to be what is used :) 2017-08-20 19:39 GMT+02:00 gmusume <gmusume(a)correo.ugr.es>: > > hi I want undelate of the group > thank > > > Enviado desde mi smartphone Samsung Galaxy. > > _______________________________________________ > Ros-dev mailing list > Ros-dev(a)reactos.org > http://www.reactos.org/mailman/listinfo/ros-dev >

7 years, 4 months

Re: [ros-dev] [ros-diffs] [cfinck] 75586: - Add 0x96 as ISO9660 partition type to ntdddisk.h (from https://en.wikipedia.org/wiki/Partition_type) and detect it using IsRecognizedPartition. - Make our isohybrid create an MBR ...

by Alex Ionescu

This is cool work but you do realize that adding non-Windows partition types and changing Windows headers (and Windows macros) to work with them, as well as forking our CDFS from the Windows CDFS... doesn't really help compatibility move forward... It would be nice to discuss about how these changes can be done to keep our 'special' USB livecd boot and CDFS changes, without twisting the system away from its NT roots. My suggestion would be a filter driver on top of CDFS, and a re-definition of this macro to be used by the filter (or whatever code relies on it). This sounds like it would give you the best of both worlds... Best regards, Alex Ionescu On Thu, Aug 17, 2017 at 1:03 PM, <cfinck(a)svn.reactos.org> wrote: > Author: cfinck > Date: Thu Aug 17 11:03:40 2017 > New Revision: 75586 > > URL: http://svn.reactos.org/svn/reactos?rev=75586&view=rev > Log: > - Add 0x96 as ISO9660 partition type to ntdddisk.h (from > https://en.wikipedia.org/wiki/Partition_type) and detect it using > IsRecognizedPartition. > - Make our isohybrid create an MBR with partition type 0x96. > > This properly assigns a drive letter to the Live-CD and lets me boot into > desktop using "qemu -hda livecd.iso". > Fixes CORE-13184 > > Modified: > trunk/reactos/boot/CMakeLists.txt > trunk/reactos/sdk/include/psdk/ntdddisk.h > > Modified: trunk/reactos/boot/CMakeLists.txt > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/ > CMakeLists.txt?rev=75586&r1=75585&r2=75586&view=diff > ============================================================ > ================== > --- trunk/reactos/boot/CMakeLists.txt [iso-8859-1] (original) > +++ trunk/reactos/boot/CMakeLists.txt [iso-8859-1] Thu Aug 17 11:03:40 > 2017 > @@ -68,7 +68,7 @@ > -eltorito-boot loader/isoboot.bin -no-emul-boot -boot-load-size 4 > -eltorito-alt-boot -eltorito-platform efi -eltorito-boot loader/efisys.bin > -no-emul-boot -hide boot.catalog > -sort ${CMAKE_CURRENT_BINARY_DIR}/bootfiles.sort > -no-cache-inodes -graft-points -path-list > ${CMAKE_CURRENT_BINARY_DIR}/bootcd.lst > - COMMAND native-isohybrid -b ${_isombr_file} > ${REACTOS_BINARY_DIR}/bootcd.iso > + COMMAND native-isohybrid -b ${_isombr_file} -t 0x96 > ${REACTOS_BINARY_DIR}/bootcd.iso > DEPENDS isombr native-isohybrid native-mkisofs > VERBATIM) > > @@ -83,7 +83,7 @@ > -eltorito-boot loader/isobtrt.bin -no-emul-boot -boot-load-size 4 > -eltorito-alt-boot -eltorito-platform efi -eltorito-boot loader/efisys.bin > -no-emul-boot -hide boot.catalog > -sort ${CMAKE_CURRENT_BINARY_DIR}/bootfiles.sort > -no-cache-inodes -graft-points -path-list > ${CMAKE_CURRENT_BINARY_DIR}/bootcdregtest.lst > - COMMAND native-isohybrid -b ${_isombr_file} ${REACTOS_BINARY_DIR}/ > bootcdregtest.iso > + COMMAND native-isohybrid -b ${_isombr_file} -t 0x96 > ${REACTOS_BINARY_DIR}/bootcdregtest.iso > DEPENDS isombr native-isohybrid native-mkisofs > VERBATIM) > > @@ -126,7 +126,7 @@ > -eltorito-boot loader/isoboot.bin -no-emul-boot -boot-load-size 4 > -eltorito-alt-boot -eltorito-platform efi -eltorito-boot loader/efisys.bin > -no-emul-boot -hide boot.catalog > -sort ${CMAKE_CURRENT_BINARY_DIR}/bootfiles.sort > -no-cache-inodes -graft-points -path-list > ${CMAKE_CURRENT_BINARY_DIR}/livecd.lst > - COMMAND native-isohybrid -b ${_isombr_file} > ${REACTOS_BINARY_DIR}/livecd.iso > + COMMAND native-isohybrid -b ${_isombr_file} -t 0x96 > ${REACTOS_BINARY_DIR}/livecd.iso > DEPENDS isombr native-isohybrid native-mkisofs > VERBATIM) > > @@ -169,7 +169,7 @@ > -eltorito-boot loader/isoboot.bin -no-emul-boot -boot-load-size 4 > -eltorito-alt-boot -eltorito-platform efi -eltorito-boot loader/efisys.bin > -no-emul-boot -hide boot.catalog > -sort ${CMAKE_CURRENT_BINARY_DIR}/bootfiles.sort > -duplicates-once -no-cache-inodes -graft-points -path-list > ${CMAKE_CURRENT_BINARY_DIR}/hybridcd.lst > - COMMAND native-isohybrid -b ${_isombr_file} ${REACTOS_BINARY_DIR}/ > hybridcd.iso > + COMMAND native-isohybrid -b ${_isombr_file} -t 0x96 > ${REACTOS_BINARY_DIR}/hybridcd.iso > DEPENDS bootcd livecd > VERBATIM) > > > Modified: trunk/reactos/sdk/include/psdk/ntdddisk.h > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/sdk/ > include/psdk/ntdddisk.h?rev=75586&r1=75585&r2=75586&view=diff > ============================================================ > ================== > --- trunk/reactos/sdk/include/psdk/ntdddisk.h [iso-8859-1] (original) > +++ trunk/reactos/sdk/include/psdk/ntdddisk.h [iso-8859-1] Thu Aug 17 > 11:03:40 2017 > @@ -223,6 +223,7 @@ > #ifdef __REACTOS__ > #define PARTITION_OLD_LINUX 0x43 > #define PARTITION_LINUX 0x83 > +#define PARTITION_ISO9660 0x96 > #define PARTITION_FREEBSD 0xA5 > #define PARTITION_OPENBSD 0xA6 > #define PARTITION_NETBSD 0xA9 > @@ -253,6 +254,7 @@ > ((PartitionType) == PARTITION_XINT13) || \ > ((PartitionType) == PARTITION_LINUX) || \ > ((PartitionType) == PARTITION_OLD_LINUX) || \ > + ((PartitionType) == PARTITION_ISO9660) || \ > ((PartitionType) == PARTITION_FREEBSD) || \ > ((PartitionType) == PARTITION_OPENBSD) || \ > ((PartitionType) == PARTITION_NETBSD)) > > >

7 years, 4 months

undelate

by gmusume

hi I want undelate of the group thank Enviado desde mi smartphone Samsung Galaxy.

7 years, 4 months

finish

by gmusume

ni. i don twant more email spam. thank u Enviado desde mi smartphone Samsung Galaxy.

7 years, 4 months

Licensing - Make ReactOS conform again!

by Colin Finck

Hi all! I've held a presentation at Hackfest today regarding Licensing Best Practices, different positions about the GPL and its influence, and ways to improve ReactOS' conformance with all involved licenses. I think we should treat this subject even more seriously than others, given that we are an Open-Source project trying to provide an alternative to a proprietary product. Also licensing questions arise from time to time, which is why we should collect some answers. Please watch the video at https://youtu.be/OTVVz9VLisU or see the slides at https://svn.reactos.org/press-media/trunk/Events/2017%20-%20Hackfest/Licens… Discussions are open now! :) But if there are no objections, let's introduce SPDX license headers, .ABOUT files, and a complete license list as soon as possible. Cheers, Colin

7 years, 4 months

Re: [ros-dev] [ros-diffs] [ekohl] 75611: [STOBJECT] - Add support for the hotplug icon. - Set default menu items in the context menus. - Use a timer to properly distinguish between a single and a double click on an icon. - ...

by Colin Finck

Hey Eric, The Battery icon, Hotplug icon and Quick Launch toolbars are currently developed as part of the Google Summer of Code "Taskbar Shell Extensions for ReactOS" project. Summer of Code ends next week, so you are welcome to join the Code Review at https://code.reactos.org. I guess CR-122 will be shortly updated with the latest changes there. Let's try to not duplicate efforts here ;) Best regards, Colin

7 years, 4 months

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev August 2017