Ros-dev October 2018

ros-dev@reactos.org

11 participants
10 discussions

by Dick

Hi, I think it would be much better to implement accessibillity for visualy impared people when building an os, than having to find ways to make that possible when everything is built and running. Nvda is a good opensource screenreader for windows The only big problem is, it heavily depends on msaa and iaccessible which will not be included in reactos i suppose. So: what would be the way to make this os accessible for the blind? I am not a programmer at all so maybe i say stupid things. The most simple way i could think of is, creating a textmode environment. In this case i do not mean just a command prompt, like dos, but the full functions but without graphical interface(like the browser browsh, www.brow.sh) can do using a headless-firefox to open pages without needing anny graphical interface(in monochrome mode it displays just text, but is able to stream youtube/everything firefox can handle). If something like that can be created in reactos, the only thing needed is to make the windows binaries of brltty work and much of the accessibility would be ready to use, as long as every graphic element is banned from the screen otherwise blrtty will display just lines with ??????????????? on the braille display. I am curious to know if some things can be done to make reactos accesible for the blind. best regards, Dick

6 years, 1 month

DbgCom release note.

by Neo Love

Greetings fellow developers... After a rather long hiatus (I actually came close to death), I went back to the DbgCom source and merged some improvements that are now in the RosIDE I'm working on. Most notably a Preferences settings dialog, but also some improved performance in the message list painting, and various bug fixes. The first time you run DbgCom, be sure to execute the Preferences dialog, and Ok the settings, so they get stored in the registry. I will make the source dependencies available shortly, they just need to be cleaned up a bit, since there is currently some hackery in there that I don't want to publish. I'll notify you on the ROSBE-100 page. You'll find DbgCom here: https://jira.reactos.org/browse/ROSBE-100 Well, that's it I guess. Best Regards / Love

6 years, 1 month

Pen width support

by katahiromz

Can somebody read this codes? https://gist.github.com/katahiromz/36f7135d3afe9fe6d2b7b28816be0f30 Thanks. katahiromz

6 years, 1 month

Re: [ros-dev] [ros-diffs] 03/04: [KERNEL32] Directly use UnhandledExceptionFilter in BaseProcessStartup

by Alex Ionescu

Same here! This will break things. We should not be overriding the proper handling of the exception filters. Best regards, Alex Ionescu On Sun, Oct 28, 2018 at 9:03 AM Mark Jansen <mark.jansen(a)reactos.org> wrote: > > https://git.reactos.org/?p=reactos.git;a=commitdiff;h=824e5dba51aca08204045… > > commit 824e5dba51aca08204045e440be9c253a8469ac2 > Author: Mark Jansen <mark.jansen(a)reactos.org> > AuthorDate: Sat Oct 20 15:38:21 2018 +0200 > Commit: Mark Jansen <mark.jansen(a)reactos.org> > CommitDate: Sun Oct 28 13:01:38 2018 +0100 > > [KERNEL32] Directly use UnhandledExceptionFilter in BaseProcessStartup > --- > dll/win32/kernel32/client/proc.c | 29 +---------------------------- > 1 file changed, 1 insertion(+), 28 deletions(-) > > diff --git a/dll/win32/kernel32/client/proc.c > b/dll/win32/kernel32/client/proc.c > index dbd5c10d0f..f36219457b 100644 > --- a/dll/win32/kernel32/client/proc.c > +++ b/dll/win32/kernel32/client/proc.c > @@ -445,33 +445,6 @@ BasepSxsCloseHandles(IN PBASE_MSG_SXS_HANDLES Handles) > } > } > > -static > -LONG BaseExceptionFilter(EXCEPTION_POINTERS *ExceptionInfo) > -{ > - LONG ExceptionDisposition = EXCEPTION_EXECUTE_HANDLER; > - LPTOP_LEVEL_EXCEPTION_FILTER RealFilter; > - RealFilter = RtlDecodePointer(GlobalTopLevelExceptionFilter); > - > - if (RealFilter != NULL) > - { > - _SEH2_TRY > - { > - ExceptionDisposition = RealFilter(ExceptionInfo); > - } > - _SEH2_EXCEPT(EXCEPTION_EXECUTE_HANDLER) > - { > - } > - _SEH2_END; > - } > - if ((ExceptionDisposition == EXCEPTION_CONTINUE_SEARCH || > ExceptionDisposition == EXCEPTION_EXECUTE_HANDLER) && > - RealFilter != UnhandledExceptionFilter) > - { > - ExceptionDisposition = UnhandledExceptionFilter(ExceptionInfo); > - } > - > - return ExceptionDisposition; > -} > - > VOID > WINAPI > BaseProcessStartup(PPROCESS_START_ROUTINE lpStartAddress) > @@ -489,7 +462,7 @@ BaseProcessStartup(PPROCESS_START_ROUTINE > lpStartAddress) > /* Call the Start Routine */ > ExitThread(lpStartAddress()); > } > - _SEH2_EXCEPT(BaseExceptionFilter(_SEH2_GetExceptionInformation())) > + > _SEH2_EXCEPT(UnhandledExceptionFilter(_SEH2_GetExceptionInformation())) > { > /* Get the Exit code from the SEH Handler */ > if (!BaseRunningInServerProcess) > >

6 years, 1 month

Re: [ros-dev] [ros-diffs] 02/04: [KERNEL32] Use the default UnhandledExceptionFilter in BaseThreadStartup. This should allow unhandled exceptions in a thread to trigger our crash reporter, instead of killing the process directly.

by Alex Ionescu

Uhh, this change is not correct. It overrides the proper handling of exception filtering -- please revert. Best regards, Alex Ionescu On Sun, Oct 28, 2018 at 9:03 AM Mark Jansen <mark.jansen(a)reactos.org> wrote: > > https://git.reactos.org/?p=reactos.git;a=commitdiff;h=40549483f60aa00e9fc95… > > commit 40549483f60aa00e9fc952ba831027028f6df107 > Author: Mark Jansen <mark.jansen(a)reactos.org> > AuthorDate: Thu Oct 18 22:07:37 2018 +0200 > Commit: Mark Jansen <mark.jansen(a)reactos.org> > CommitDate: Sun Oct 28 13:01:38 2018 +0100 > > [KERNEL32] Use the default UnhandledExceptionFilter in > BaseThreadStartup. > This should allow unhandled exceptions in a thread to trigger our > crash reporter, > instead of killing the process directly. > --- > dll/win32/kernel32/client/thread.c | 25 +------------------------ > 1 file changed, 1 insertion(+), 24 deletions(-) > > diff --git a/dll/win32/kernel32/client/thread.c > b/dll/win32/kernel32/client/thread.c > index 8fc5a7ad61..2ff0102483 100644 > --- a/dll/win32/kernel32/client/thread.c > +++ b/dll/win32/kernel32/client/thread.c > @@ -26,29 +26,6 @@ BasepNotifyCsrOfThread(IN HANDLE ThreadHandle, > > /* FUNCTIONS > ******************************************************************/ > > -static > -LONG BaseThreadExceptionFilter(EXCEPTION_POINTERS * ExceptionInfo) > -{ > - LONG ExceptionDisposition = EXCEPTION_EXECUTE_HANDLER; > - LPTOP_LEVEL_EXCEPTION_FILTER RealFilter; > - > - RealFilter = RtlDecodePointer(GlobalTopLevelExceptionFilter); > - if (RealFilter != NULL) > - { > - _SEH2_TRY > - { > - ExceptionDisposition = RealFilter(ExceptionInfo); > - } > - _SEH2_EXCEPT(EXCEPTION_EXECUTE_HANDLER) > - { > - ExceptionDisposition = > UnhandledExceptionFilter(ExceptionInfo); > - } > - _SEH2_END; > - } > - > - return ExceptionDisposition; > -} > - > __declspec(noreturn) > VOID > WINAPI > @@ -68,7 +45,7 @@ BaseThreadStartup(IN LPTHREAD_START_ROUTINE > lpStartAddress, > /* Get the exit code from the Thread Start */ > ExitThread((lpStartAddress)((PVOID)lpParameter)); > } > - > _SEH2_EXCEPT(BaseThreadExceptionFilter(_SEH2_GetExceptionInformation())) > + > _SEH2_EXCEPT(UnhandledExceptionFilter(_SEH2_GetExceptionInformation())) > { > /* Get the Exit code from the SEH Handler */ > if (!BaseRunningInServerProcess) > >

6 years, 1 month

Test_KVM_AHK is temporarily offline

by Sylvain Petreolle

Hello all. My family is at home and I need to shut down the AHK bot until the end of the week. See you later on Ros ;-) Kind regards, Sylvain Petreolle

6 years, 1 month

New member

by Никита

6 years, 2 months

Upcoming Google Summer of Code Mentor Summit

by Colin Finck

Hi all, As announced, I'll be travelling to California this Thursday to attend the Google Summer of Code Mentor Summit from Friday to Sunday. I'll be using this opportunity to spread the word about ReactOS, our experiences with GSoC, and learning from other projects' experiences. I'm especially interested to hear how others are acquiring talented students and managing their list of task ideas over the year. Let's hope this will help us to get more than 1 student next year and efficiently collect a list of GSoC ideas continuously instead of preparing it shortly before the deadline ;) Is there anything else you want me to talk about during the summit? Cheers, Colin

6 years, 2 months

Add InitializeProcThreadAttributeList function

by Biswapriyo Nath

I found that this function `InitializeProcThreadAttributeList()` is added with GetProcAddress but not with the real function. I can provide the real function from Windows 10. The function hasn't any imported function, just conatins some arithmatic operations. I don't know how to contribute and not familiar with ReactOS repo. So, I can only provide a c file.

6 years, 2 months

Re: [ros-dev] [ros-diffs] 01/01: [SERVICES] Fix timeout when a service is stopped

by Pierre Schweitzer

Hey Eric, What's the purpose of that "Sleep(2000);"? Is it a debug leftover? Cheers, Pierre Le 05/10/2018 à 08:43, Eric Kohl a écrit : > https://git.reactos.org/?p=reactos.git;a=commitdiff;h=f6d81f225747e4b1b3716… > > commit f6d81f225747e4b1b3716e9ca8629f77dcc52b1a > Author: Eric Kohl <eric.kohl(a)reactos.org> > AuthorDate: Fri Oct 5 08:41:23 2018 +0200 > Commit: Eric Kohl <eric.kohl(a)reactos.org> > CommitDate: Fri Oct 5 08:41:23 2018 +0200 > > [SERVICES] Fix timeout when a service is stopped > > RSetServiceStatus: Send the stop command for the dispatcher thread from a separate thread. > > Fixes CORE-15064 > --- > base/system/services/rpcserver.c | 59 ++++++++++++++++++++++++++++++++++------ > 1 file changed, 50 insertions(+), 9 deletions(-) > > diff --git a/base/system/services/rpcserver.c b/base/system/services/rpcserver.c > index 7f251c8760..8e383a5bdc 100644 > --- a/base/system/services/rpcserver.c > +++ b/base/system/services/rpcserver.c > @@ -1671,6 +1671,43 @@ ScmIsValidServiceState(DWORD dwCurrentState) > } > > > +static > +DWORD > +WINAPI > +ScmStopThread( > + _In_ PVOID pParam) > +{ > + PSERVICE pService; > + > + DPRINT("ScmStopThread(%p)\n", pParam); > + > + pService = (PSERVICE)pParam; > + > + if (pService->lpImage->dwImageRunCount != 0) > + return 0; > + > + Sleep(2000); > + > + /* Lock the service database exclusively */ > + ScmLockDatabaseExclusive(); > + > + /* Stop the dispatcher thread */ > + ScmControlService(pService->lpImage->hControlPipe, > + L"", > + (SERVICE_STATUS_HANDLE)pService, > + SERVICE_CONTROL_STOP); > + > + /* Remove the service image */ > + ScmRemoveServiceImage(pService->lpImage); > + > + /* Unlock the service database */ > + ScmUnlockDatabase(); > + > + DPRINT("ScmStopThread done!\n"); > + return 0; > +} > + > + > /* Function 7 */ > DWORD > WINAPI > @@ -1683,6 +1720,8 @@ RSetServiceStatus( > DWORD dwPreviousType; > LPCWSTR lpLogStrings[2]; > WCHAR szLogBuffer[80]; > + HANDLE hStopThread = NULL; > + DWORD dwStopThreadId; > UINT uID; > > DPRINT("RSetServiceStatus() called\n"); > @@ -1762,15 +1801,17 @@ RSetServiceStatus( > /* If we just stopped the last running service... */ > if (lpService->lpImage->dwImageRunCount == 0) > { > - /* Stop the dispatcher thread */ > - ScmControlService(lpService->lpImage->hControlPipe, > - L"", > - (SERVICE_STATUS_HANDLE)lpService, > - SERVICE_CONTROL_STOP); > - > - /* Remove the service image */ > - ScmRemoveServiceImage(lpService->lpImage); > - lpService->lpImage = NULL; > + /* Run the stop thread to stop the service dispatcher */ > + hStopThread = CreateThread(NULL, > + 0, > + (LPTHREAD_START_ROUTINE)ScmStopThread, > + (LPVOID)lpService, > + 0, > + &dwStopThreadId); > + if (hStopThread != NULL) > + { > + CloseHandle(hStopThread); > + } > } > } > > -- Pierre Schweitzer <pierre at reactos.org> System & Network Administrator Senior Kernel Developer ReactOS Deutschland e.V.

6 years, 2 months

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev October 2018