Ros-dev December 2018

ros-dev@reactos.org

17 participants
18 discussions

GSOC 2019 - Costin Visan

by costin visan

Hello! I'm really interested in participating this year at gsoc as part of your team. I'm writting you this email to get your attention and maybe to get a hint for this year's project. I'm in my second year at University Politehnica of Bucharest at the Faculty of Automatic Control and Computers and I study for a degree in Computer Science and Information Technology. I wanna start early this year contributing to the project as I wish to show you that I will be a great addition to your team. If I have caught your attention and you want to communicate me anything, I can be contacted on this mail. - Many thanks, Costin Visan <https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campai…> Virus-free. www.avast.com <https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campai…> <#DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2>

5 years, 8 months

Re: [ros-dev] Web services down

by Pierre Schweitzer

We seem to be back to normal state. Please report if some service is still not working properly. Pierre Schweitzer <pierre.schweitzer(a)reactos.org> wrote on Wed, December 26th, 2018, 4:43 PM: > Dear all, > > Due to an unexpected outage touching our hoster infrastructure, our DB server is currently down and it affects all the web services relying on it. So, don't expect Jira, boards, wiki, website, and so on to work properly for now, > I'll keep you informed when I have more information. > > Cheers, > Pierre > > _______________________________________________ > Ros-dev mailing list > Ros-dev(a)reactos.org > http://reactos.org/mailman/listinfo/ros-dev

5 years, 12 months

Web services down

by Pierre Schweitzer

Dear all, Due to an unexpected outage touching our hoster infrastructure, our DB server is currently down and it affects all the web services relying on it. So, don't expect Jira, boards, wiki, website, and so on to work properly for now, I'll keep you informed when I have more information. Cheers, Pierre

5 years, 12 months

Re: [ros-dev] Feature Request CORE-15418 ReactOS Default Media Player - Media Player Classic

by dean beedell

Feature Request CORE-15418 to create a ReactOS Default Media Player using the code from Media Player Classic. This feature request was discussed some time ago on the forum at length and it came to little conclusion, some wanting to bundle VLC, others wanting to bundle classic media player - an open source tool that has recently received some attention. The importance of a media player was noted but one of the main problems was left out. The nub of the problem is this: Windows has a default media player provided as a core part of the system. It is not just a media player, being so tightly integrated into Windows it is used by (some/many?) apps to produce the default sounds and video that emanate from normal program usage. Note that on Windows, ActiveX/COM allows access to system level components and one of those components that is defined as a system level resource is the windows media player (WMP). COM allows programs to make calls to WMP to allow them to play embedded videos or audio tracks within their applications without having to design their own player and bundle their own codecs. The use of WMP means that a far greater range of codecs will be available and the chances of being able to play a particular type of file are increased. *Without such a player these Windows applications will not function as intended.* See the description here: https://docs.microsoft.com/en-us/window ... ject-model <https://docs.microsoft.com/en-us/windows/desktop/wmp/about-the-player-objec…> ReactOS is not a straight o/s without any whizzes or dongles, ie. it already has such bundled apps as games and the ReactOS version of paintbrush. So, the concept of bundling apps is already set, ie. it is perfectly OK to have apps bundled with ReactOS and ReactOS will have them when released. It is just a matter of which applications are bundled. I propose we add Media Player Classic as the default media player. A Windows Media Player type application would be very useful, in fact essential to replace the windows media player that came bundled with Windows, it will need to be a straight drop in replacement for WMP. Indeed, users expect the basic components of an o/s to be present and although RAPPS allows users to install the components they need, some applications are integrated into the o/s far more than others. I would suggest that it is time to re-open this debate and consider using the open source Media Player Classic as ReactOS own embedded version of WMP and to ensure that active X/COM controls can see Media Player Classic just as WMP is disclosed as the default media player in Windows. MPC looks like a media player that ReactOS could use. It is written in C++ and is open source and it supported by the devs at doom9. It seems to me that the only thing missing from Media player classic is the Active X control that allows Windows/ReactOS programs access to its functions. With that control in place it might be a perfect drop-in replacement for WMP and would restore that missing sound functionality to programs giving ReactOS added compatibity. Request raised here in JIRA: https://jira.reactos.org/browse/CORE-15418 Hope this finds you all well this Christmas and that you will consider this feature request for later inclusion. Dean Beedell (dizt3mp3r) --- This email has been checked for viruses by Avast antivirus software. https://www.avast.com/antivirus

6 years

CORE-15474 - Make modern BSOD in ReactOS

by Javier Agustìn Fernàndez Arroyo

Please.... no... i love NT5 style BSoD

6 years

Status Meeting (December 2018)

by Colin Finck

Hi all! With Christmas fast approaching and many people traditionally being unavailable over the holidays (myself included), let me prepone our monthly meeting to tomorrow, Thursday, December 20, 2018, 19:00 UTC. Invited members will again receive their IRC Server credentials shortly before the meeting. Note that due to the recent infra changes, your IRC username will now be based on the Display Name you set in https://reactos.org/roslogin/?p=selfservice (spaces replaced by underscores). Please check that before the meeting. However, as our self-hosted Mattermost server is being set up right now, this may as well be our last meeting on IRC :) I wouldn't mind if it's just about the Status Updates from everybody this time, given that the November meeting was really long and a lot of things should be in progress. Let's also not forget about our preparations for Google Summer of Code! Cheers, Colin

6 years

Re: [ros-dev] CORE-15467 - 1st stage setup freezes when the expected file is missing

by hermes.belusca＠sfr.fr

<span style="font-family:arial,helvetica,sans-serif; font-size:12px">‌</span>Hi,<br> <br> There is in principle (almost) all the infrastructure to implement the Retry/Skip/Abort dialog in usetup.<br> The freezing you encounter is however a bug I should investigate.<br> <br> Cheers,<br> Hermes <div class="gl_quote" style="margin-top: 20px; padding-top: 5px;">De : "Javier Agustìn Fernàndez Arroyo"<br> A : "ReactOS Development List"<br> Envoyé: mercredi 19 décembre 2018 20:17<br> Objet : [ros-dev] CORE-15467 - 1st stage setup freezes when the expected file is missing<br>   <div class="gl_quoted"> <div dir="ltr">An idea, <div> </div> <div>I don´t think its a good idea to "skip" a file during 1st stage, specially core files (in 2nd stage it might be acceptable for some device drivers, for example)</div> <div> </div> <div>So, if "cloning" the Win2k3 behavior, i would set only 2 options: retry or abort installation and reboot.</div> <div> </div> <div>what do you guys think?</div> </div> <br> <br> <br> _______________________________________________<br> Ros-dev mailing list<br> Ros-dev(a)reactos.org<br> http://reactos.org/mailman/listinfo/ros-dev</div> <div class="gl_quoted"> </div> </div>

6 years

CORE-15467 - 1st stage setup freezes when the expected file is missing

by Javier Agustìn Fernàndez Arroyo

An idea, I don´t think its a good idea to "skip" a file during 1st stage, specially core files (in 2nd stage it might be acceptable for some device drivers, for example) So, if "cloning" the Win2k3 behavior, i would set only 2 options: retry or abort installation and reboot. what do you guys think?

6 years

Re: [ros-dev] [ros-diffs] [reactos] 01/01: [DESK][SHELL32] Allow Desk.cpl to run standalone on WinXP/2003 again CORE-15412

by Pierre Schweitzer

Hi, I definitely don't like that commit, nor appreciate the way it was done. If we read CORE-15412 carefully, we have three developers (namely: Thomas, Mark, Giannis) expressing that they are again this revert, and thus this commit. Then, why was it pushed to HEAD? Cheers, Pierre Le 17/12/2018 à 22:02, Joachim Henze a écrit : > https://git.reactos.org/?p=reactos.git;a=commitdiff;h=6f8cb05cad142a8679872… > > commit 6f8cb05cad142a8679872e695f317dc1f9728d55 > Author: Joachim Henze <Joachim.Henze(a)reactos.org> > AuthorDate: Mon Dec 17 22:01:49 2018 +0100 > Commit: Joachim Henze <Joachim.Henze(a)reactos.org> > CommitDate: Mon Dec 17 22:01:49 2018 +0100 > > [DESK][SHELL32] Allow Desk.cpl to run standalone on WinXP/2003 again CORE-15412 > > addendum to 0.4.10-dev-502-g > d559ca9c982f9766acc5db3ea887ef2bc27acdff > > That copy-paste was done once intentionally to keep our imports similar to 2003. > It's worth reading the conversation in PR #748: Getequ seems to be ok with this. > > The ideal solution most likely would be to instead *statically* > link against RegLoadMUIStringW() from advapi32_vista when WINNT=0x502. > For now the stuff runs again at least. > I left the func existing in advapi32_vista.dll. > --- > dll/cpl/desk/CMakeLists.txt | 6 +- > dll/cpl/desk/desk.h | 9 ++ > dll/cpl/desk/muireg.c | 144 ++++++++++++++++++++++++++ > dll/win32/shell32/CMakeLists.txt | 3 +- > dll/win32/shell32/vista.c | 218 +++++++++++++++++++++++++++++++++++++++ > 5 files changed, 375 insertions(+), 5 deletions(-) > > diff --git a/dll/cpl/desk/CMakeLists.txt b/dll/cpl/desk/CMakeLists.txt > index 24d9bb1e60..ae7fb83825 100644 > --- a/dll/cpl/desk/CMakeLists.txt > +++ b/dll/cpl/desk/CMakeLists.txt > @@ -2,9 +2,6 @@ > add_definitions(-D_WIN32) > spec2def(desk.cpl desk.spec) > > -remove_definitions(-D_WIN32_WINNT=0x502) > -add_definitions(-D_WIN32_WINNT=0x600) > - > list(APPEND SOURCE > advmon.c > appearance.c > @@ -23,6 +20,7 @@ list(APPEND SOURCE > general.c > draw.c > theme.c > + muireg.c > desk.h) > > file(GLOB desk_rc_deps resources/*.*) > @@ -36,6 +34,6 @@ add_library(desk SHARED > > set_module_type(desk cpl UNICODE) > target_link_libraries(desk uuid) > -add_importlibs(desk user32 advapi32 advapi32_vista gdi32 comctl32 comdlg32 ole32 setupapi shell32 shlwapi uxtheme gdiplus msvcrt kernel32 ntdll) > +add_importlibs(desk user32 advapi32 gdi32 comctl32 comdlg32 ole32 setupapi shell32 shlwapi uxtheme gdiplus msvcrt kernel32 ntdll) > add_pch(desk desk.h SOURCE) > add_cd_file(TARGET desk DESTINATION reactos/system32 FOR all) > diff --git a/dll/cpl/desk/desk.h b/dll/cpl/desk/desk.h > index 3bb02f3a74..3c479251cf 100644 > --- a/dll/cpl/desk/desk.h > +++ b/dll/cpl/desk/desk.h > @@ -122,4 +122,13 @@ HPSXA WINAPI SHCreatePropSheetExtArrayEx(HKEY,LPCWSTR,UINT,IDataObject*); > INT_PTR CALLBACK > AdvGeneralPageProc(HWND hwndDlg, UINT uMsg, WPARAM wParam, LPARAM lParam); > > +LONG > +RegLoadMUIStringW(IN HKEY hKey, > + IN LPCWSTR pszValue OPTIONAL, > + OUT LPWSTR pszOutBuf, > + IN DWORD cbOutBuf, > + OUT LPDWORD pcbData OPTIONAL, > + IN DWORD Flags, > + IN LPCWSTR pszDirectory OPTIONAL); > + > #endif /* _DESK_H */ > diff --git a/dll/cpl/desk/muireg.c b/dll/cpl/desk/muireg.c > new file mode 100644 > index 0000000000..8754b43655 > --- /dev/null > +++ b/dll/cpl/desk/muireg.c > @@ -0,0 +1,144 @@ > +#include "desk.h" > + > +/****************************************************************************** > + * load_string [Internal] > + * > + * This is basically a copy of user32/resource.c's LoadStringW. Necessary to > + * avoid importing user32, which is higher level than advapi32. Helper for > + * RegLoadMUIString. > + */ > +static int load_string(HINSTANCE hModule, UINT resId, LPWSTR pwszBuffer, INT cMaxChars) > +{ > + HGLOBAL hMemory; > + HRSRC hResource; > + WCHAR *pString; > + int idxString; > + > + /* Negative values have to be inverted. */ > + if (HIWORD(resId) == 0xffff) > + resId = (UINT)(-((INT)resId)); > + > + /* Load the resource into memory and get a pointer to it. */ > + hResource = FindResourceW(hModule, MAKEINTRESOURCEW(LOWORD(resId >> 4) + 1), (LPWSTR)RT_STRING); > + if (!hResource) return 0; > + hMemory = LoadResource(hModule, hResource); > + if (!hMemory) return 0; > + pString = LockResource(hMemory); > + > + /* Strings are length-prefixed. Lowest nibble of resId is an index. */ > + idxString = resId & 0xf; > + while (idxString--) pString += *pString + 1; > + > + /* If no buffer is given, return length of the string. */ > + if (!pwszBuffer) return *pString; > + > + /* Else copy over the string, respecting the buffer size. */ > + cMaxChars = (*pString < cMaxChars) ? *pString : (cMaxChars - 1); > + if (cMaxChars >= 0) > + { > + memcpy(pwszBuffer, pString+1, cMaxChars * sizeof(WCHAR)); > + pwszBuffer[cMaxChars] = L'\0'; > + } > + > + return cMaxChars; > +} > + > + > +/************************************************************************ > + * RegLoadMUIStringW > + * > + * @implemented > + */ > +LONG > +RegLoadMUIStringW(IN HKEY hKey, > + IN LPCWSTR pszValue OPTIONAL, > + OUT LPWSTR pszOutBuf, > + IN DWORD cbOutBuf, > + OUT LPDWORD pcbData OPTIONAL, > + IN DWORD Flags, > + IN LPCWSTR pszDirectory OPTIONAL) > +{ > + DWORD dwValueType, cbData; > + LPWSTR pwszTempBuffer = NULL, pwszExpandedBuffer = NULL; > + LONG result; > + > + /* Parameter sanity checks. */ > + if (!hKey || !pszOutBuf) > + return ERROR_INVALID_PARAMETER; > + > + if (pszDirectory && *pszDirectory) > + { > + //FIXME("BaseDir parameter not yet supported!\n"); > + return ERROR_INVALID_PARAMETER; > + } > + > + /* Check for value existence and correctness of it's type, allocate a buffer and load it. */ > + result = RegQueryValueExW(hKey, pszValue, NULL, &dwValueType, NULL, &cbData); > + if (result != ERROR_SUCCESS) goto cleanup; > + if (!(dwValueType == REG_SZ || dwValueType == REG_EXPAND_SZ) || !cbData) > + { > + result = ERROR_FILE_NOT_FOUND; > + goto cleanup; > + } > + pwszTempBuffer = HeapAlloc(GetProcessHeap(), 0, cbData); > + if (!pwszTempBuffer) > + { > + result = ERROR_NOT_ENOUGH_MEMORY; > + goto cleanup; > + } > + result = RegQueryValueExW(hKey, pszValue, NULL, &dwValueType, (LPBYTE)pwszTempBuffer, &cbData); > + if (result != ERROR_SUCCESS) goto cleanup; > + > + /* Expand environment variables, if appropriate, or copy the original string over. */ > + if (dwValueType == REG_EXPAND_SZ) > + { > + cbData = ExpandEnvironmentStringsW(pwszTempBuffer, NULL, 0) * sizeof(WCHAR); > + if (!cbData) goto cleanup; > + pwszExpandedBuffer = HeapAlloc(GetProcessHeap(), 0, cbData); > + if (!pwszExpandedBuffer) > + { > + result = ERROR_NOT_ENOUGH_MEMORY; > + goto cleanup; > + } > + ExpandEnvironmentStringsW(pwszTempBuffer, pwszExpandedBuffer, cbData); > + } > + else > + { > + pwszExpandedBuffer = HeapAlloc(GetProcessHeap(), 0, cbData); > + memcpy(pwszExpandedBuffer, pwszTempBuffer, cbData); > + } > + > + /* If the value references a resource based string, parse the value and load the string. > + * Else just copy over the original value. */ > + result = ERROR_SUCCESS; > + if (*pwszExpandedBuffer != L'@') /* '@' is the prefix for resource based string entries. */ > + { > + lstrcpynW(pszOutBuf, pwszExpandedBuffer, cbOutBuf / sizeof(WCHAR)); > + } > + else > + { > + WCHAR *pComma = wcsrchr(pwszExpandedBuffer, L','); > + UINT uiStringId; > + HMODULE hModule; > + > + /* Format of the expanded value is 'path_to_dll,-resId' */ > + if (!pComma || pComma[1] != L'-') > + { > + result = ERROR_BADKEY; > + goto cleanup; > + } > + > + uiStringId = _wtoi(pComma+2); > + *pComma = L'\0'; > + > + hModule = LoadLibraryExW(pwszExpandedBuffer + 1, NULL, LOAD_LIBRARY_AS_DATAFILE); > + if (!hModule || !load_string(hModule, uiStringId, pszOutBuf, cbOutBuf / sizeof(WCHAR))) > + result = ERROR_BADKEY; > + FreeLibrary(hModule); > + } > + > +cleanup: > + HeapFree(GetProcessHeap(), 0, pwszTempBuffer); > + HeapFree(GetProcessHeap(), 0, pwszExpandedBuffer); > + return result; > +} > diff --git a/dll/win32/shell32/CMakeLists.txt b/dll/win32/shell32/CMakeLists.txt > index 08933dda35..78ee1af531 100644 > --- a/dll/win32/shell32/CMakeLists.txt > +++ b/dll/win32/shell32/CMakeLists.txt > @@ -102,6 +102,7 @@ add_library(shell32 SHARED > wine/shellstring.c > wine/shlmenu.c > wine/shpolicy.c > + vista.c > shell32.rc > ${CMAKE_CURRENT_BINARY_DIR}/shell32_stubs.c > ${CMAKE_CURRENT_BINARY_DIR}/shell32.def) > @@ -113,7 +114,7 @@ set_source_files_properties(shell32.rc PROPERTIES OBJECT_DEPENDS ${CMAKE_CURRENT > set_module_type(shell32 win32dll UNICODE) > target_link_libraries(shell32 shellmenu shelldesktop atlnew wine uuid recyclebin) > add_delay_importlibs(shell32 powrprof shdocvw devmgr winspool.drv winmm mpr uxtheme ole32 oleaut32 userenv browseui version fmifs) > -add_importlibs(shell32 advapi32 advapi32_vista gdi32 user32 comctl32 comdlg32 shlwapi msvcrt kernel32 ntdll) > +add_importlibs(shell32 advapi32 gdi32 user32 comctl32 comdlg32 shlwapi msvcrt kernel32 ntdll) > add_dependencies(shell32 stdole2) # shell32_shldisp.tlb needs stdole2.tlb > add_pch(shell32 precomp.h SOURCE) > add_cd_file(TARGET shell32 DESTINATION reactos/system32 FOR all) > diff --git a/dll/win32/shell32/vista.c b/dll/win32/shell32/vista.c > new file mode 100644 > index 0000000000..9f1a8335a3 > --- /dev/null > +++ b/dll/win32/shell32/vista.c > @@ -0,0 +1,218 @@ > +/* > + * COPYRIGHT: See COPYING in the top level directory > + * PROJECT: ReactOS system libraries > + * FILE: Copied from advapi32/reg/reg.c > + * PURPOSE: Registry functions > + * PROGRAMMER: Ariadne ( ariadne(a)xs4all.nl) > + * Thomas Weidenmueller <w3seek(a)reactos.com> > + * UPDATE HISTORY: > + * Created 01/11/98 > + * 19990309 EA Stubs > + * 20050502 Fireball imported some stuff from WINE > + */ > + > +#include <stdarg.h> > + > +#define WIN32_NO_STATUS > +#define _INC_WINDOWS > +#define COM_NO_WINDOWS_H > + > +#include <windef.h> > +#include <winbase.h> > +#include <winreg.h> > +#include <winuser.h> > +#define NTOS_MODE_USER > +#include <ndk/rtlfuncs.h> > + > +#include <wine/debug.h> > +#include <wine/unicode.h> > + > +WINE_DEFAULT_DEBUG_CHANNEL(shell); > + > +/****************************************************************************** > + * load_string [Internal] > + * > + * This is basically a copy of user32/resource.c's LoadStringW. Necessary to > + * avoid importing user32, which is higher level than advapi32. Helper for > + * RegLoadMUIString. > + */ > +static int load_string(HINSTANCE hModule, UINT resId, LPWSTR pwszBuffer, INT cMaxChars) > +{ > + HGLOBAL hMemory; > + HRSRC hResource; > + WCHAR *pString; > + int idxString; > + > + /* Negative values have to be inverted. */ > + if (HIWORD(resId) == 0xffff) > + resId = (UINT)(-((INT)resId)); > + > + /* Load the resource into memory and get a pointer to it. */ > + hResource = FindResourceW(hModule, MAKEINTRESOURCEW(LOWORD(resId >> 4) + 1), (LPWSTR)RT_STRING); > + if (!hResource) return 0; > + hMemory = LoadResource(hModule, hResource); > + if (!hMemory) return 0; > + pString = LockResource(hMemory); > + > + /* Strings are length-prefixed. Lowest nibble of resId is an index. */ > + idxString = resId & 0xf; > + while (idxString--) pString += *pString + 1; > + > + /* If no buffer is given, return length of the string. */ > + if (!pwszBuffer) return *pString; > + > + /* Else copy over the string, respecting the buffer size. */ > + cMaxChars = (*pString < cMaxChars) ? *pString : (cMaxChars - 1); > + if (cMaxChars >= 0) > + { > + memcpy(pwszBuffer, pString+1, cMaxChars * sizeof(WCHAR)); > + pwszBuffer[cMaxChars] = L'\0'; > + } > + > + return cMaxChars; > +} > + > +/************************************************************************ > + * RegLoadMUIStringW > + * > + * @implemented > + */ > +LONG WINAPI > +RegLoadMUIStringW(IN HKEY hKey, > + IN LPCWSTR pszValue OPTIONAL, > + OUT LPWSTR pszOutBuf, > + IN DWORD cbOutBuf, > + OUT LPDWORD pcbData OPTIONAL, > + IN DWORD Flags, > + IN LPCWSTR pszDirectory OPTIONAL) > +{ > + DWORD dwValueType, cbData; > + LPWSTR pwszTempBuffer = NULL, pwszExpandedBuffer = NULL; > + LONG result; > + > + /* Parameter sanity checks. */ > + if (!hKey || !pszOutBuf) > + return ERROR_INVALID_PARAMETER; > + > + if (pszDirectory && *pszDirectory) > + { > + FIXME("BaseDir parameter not yet supported!\n"); > + return ERROR_INVALID_PARAMETER; > + } > + > + /* Check for value existence and correctness of it's type, allocate a buffer and load it. */ > + result = RegQueryValueExW(hKey, pszValue, NULL, &dwValueType, NULL, &cbData); > + if (result != ERROR_SUCCESS) goto cleanup; > + if (!(dwValueType == REG_SZ || dwValueType == REG_EXPAND_SZ) || !cbData) > + { > + result = ERROR_FILE_NOT_FOUND; > + goto cleanup; > + } > + pwszTempBuffer = HeapAlloc(GetProcessHeap(), 0, cbData); > + if (!pwszTempBuffer) > + { > + result = ERROR_NOT_ENOUGH_MEMORY; > + goto cleanup; > + } > + result = RegQueryValueExW(hKey, pszValue, NULL, &dwValueType, (LPBYTE)pwszTempBuffer, &cbData); > + if (result != ERROR_SUCCESS) goto cleanup; > + > + /* Expand environment variables, if appropriate, or copy the original string over. */ > + if (dwValueType == REG_EXPAND_SZ) > + { > + cbData = ExpandEnvironmentStringsW(pwszTempBuffer, NULL, 0) * sizeof(WCHAR); > + if (!cbData) goto cleanup; > + pwszExpandedBuffer = HeapAlloc(GetProcessHeap(), 0, cbData); > + if (!pwszExpandedBuffer) > + { > + result = ERROR_NOT_ENOUGH_MEMORY; > + goto cleanup; > + } > + ExpandEnvironmentStringsW(pwszTempBuffer, pwszExpandedBuffer, cbData); > + } > + else > + { > + pwszExpandedBuffer = HeapAlloc(GetProcessHeap(), 0, cbData); > + memcpy(pwszExpandedBuffer, pwszTempBuffer, cbData); > + } > + > + /* If the value references a resource based string, parse the value and load the string. > + * Else just copy over the original value. */ > + result = ERROR_SUCCESS; > + if (*pwszExpandedBuffer != L'@') /* '@' is the prefix for resource based string entries. */ > + { > + lstrcpynW(pszOutBuf, pwszExpandedBuffer, cbOutBuf / sizeof(WCHAR)); > + } > + else > + { > + WCHAR *pComma = wcsrchr(pwszExpandedBuffer, L','); > + UINT uiStringId; > + HMODULE hModule; > + > + /* Format of the expanded value is 'path_to_dll,-resId' */ > + if (!pComma || pComma[1] != L'-') > + { > + result = ERROR_BADKEY; > + goto cleanup; > + } > + > + uiStringId = _wtoi(pComma+2); > + *pComma = L'\0'; > + > + hModule = LoadLibraryExW(pwszExpandedBuffer + 1, NULL, LOAD_LIBRARY_AS_DATAFILE); > + if (!hModule || !load_string(hModule, uiStringId, pszOutBuf, cbOutBuf / sizeof(WCHAR))) > + result = ERROR_BADKEY; > + FreeLibrary(hModule); > + } > + > +cleanup: > + HeapFree(GetProcessHeap(), 0, pwszTempBuffer); > + HeapFree(GetProcessHeap(), 0, pwszExpandedBuffer); > + return result; > +} > + > +/************************************************************************ > + * RegLoadMUIStringA > + * > + * @implemented > + */ > +LONG WINAPI > +RegLoadMUIStringA(IN HKEY hKey, > + IN LPCSTR pszValue OPTIONAL, > + OUT LPSTR pszOutBuf, > + IN DWORD cbOutBuf, > + OUT LPDWORD pcbData OPTIONAL, > + IN DWORD Flags, > + IN LPCSTR pszDirectory OPTIONAL) > +{ > + UNICODE_STRING valueW, baseDirW; > + WCHAR *pwszBuffer; > + DWORD cbData = cbOutBuf * sizeof(WCHAR); > + LONG result; > + > + valueW.Buffer = baseDirW.Buffer = pwszBuffer = NULL; > + if (!RtlCreateUnicodeStringFromAsciiz(&valueW, pszValue) || > + !RtlCreateUnicodeStringFromAsciiz(&baseDirW, pszDirectory) || > + !(pwszBuffer = HeapAlloc(GetProcessHeap(), 0, cbData))) > + { > + result = ERROR_NOT_ENOUGH_MEMORY; > + goto cleanup; > + } > + > + result = RegLoadMUIStringW(hKey, valueW.Buffer, pwszBuffer, cbData, NULL, Flags, > + baseDirW.Buffer); > + > + if (result == ERROR_SUCCESS) > + { > + cbData = WideCharToMultiByte(CP_ACP, 0, pwszBuffer, -1, pszOutBuf, cbOutBuf, NULL, NULL); > + if (pcbData) > + *pcbData = cbData; > + } > + > +cleanup: > + HeapFree(GetProcessHeap(), 0, pwszBuffer); > + RtlFreeUnicodeString(&baseDirW); > + RtlFreeUnicodeString(&valueW); > + > + return result; > +} > -- Pierre Schweitzer <pierre at reactos.org> System & Network Administrator Senior Kernel Developer ReactOS Deutschland e.V.

6 years

BuildBot and irc.reactos.org now using ReactOS.org accounts

by Colin Finck

Hi all! Another important change has just been applied to ReactOS infrastructure: https://build.reactos.org and https://irc.reactos.org now use ReactOS.org accounts. Finally, we have a real global login system where you can access all ReactOS services with the same account! Please let me know if or if not things work for you, as I may have forgotten to add some accounts to the BuildBot group. If everything works well, we are technically ready to launch a Mattermost instance using the same accounts as the next step :) Cheers, Colin

6 years

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev December 2018