Ros-dev February 2018

ros-dev@reactos.org

10 participants
7 discussions

"Note: LibreOffice 5.4 will be the last codeline to support Windows XP or Vista"
by Javier Agustìn Fernàndez Arroyo 06 May '18

06 May '18

https://wiki.documentfoundation.org/Releases/5.4.0/RC1 FYI

11 19

Re: [ros-dev] [ros-diffs] 01/01: improve SHGetFileInfo (#118)
by Pierre Schweitzer 16 Feb '18

16 Feb '18

For the record, the commit doesn't match our contributing rules and should be avoided in the future. Reference: https://github.com/reactos/reactos/blob/master/.gitmessage Le 16/02/2018 à 12:00, Katayama Hirofumi MZ a écrit : > https://git.reactos.org/?p=reactos.git;a=commitdiff;h=338799bf8bf98698f3e4c… > > commit 338799bf8bf98698f3e4c1c2b885d724a9a929da > Author: Katayama Hirofumi MZ <katayama.hirofumi.mz(a)gmail.com> > AuthorDate: Fri Feb 16 20:00:08 2018 +0900 > Commit: Ged Murphy <gedmurphy(a)reactos.org> > CommitDate: Fri Feb 16 11:00:08 2018 +0000 > > improve SHGetFileInfo (#118) > > This patch reduces failures of SHGetFileInfo function. CORE-7159 > * improve WideByteToWideChar calls > * fix bugs related to file attributes and SHGFI_EXETYPE > * SHGFI_USEFILEATTRIBUTES and SHGFI_ICON fix > * s/sizeof(temppsfi)/0/ > --- > dll/win32/shell32/wine/shell32_main.c | 81 +++++++++++++++++++++-------------- > 1 file changed, 49 insertions(+), 32 deletions(-) > > diff --git a/dll/win32/shell32/wine/shell32_main.c b/dll/win32/shell32/wine/shell32_main.c > index b5638f0582..e64ef7f6fb 100644 > --- a/dll/win32/shell32/wine/shell32_main.c > +++ b/dll/win32/shell32/wine/shell32_main.c > @@ -3,6 +3,7 @@ > * > * Copyright 1998 Marcus Meissner > * Copyright 1998 Juergen Schmied (jsch) * <juergen.schmied(a)metronet.de> > + * Copyright 2017 Katayama Hirofumi MZ <katayama.hirofumi.mz(a)gmail.com> > * > * This library is free software; you can redistribute it and/or > * modify it under the terms of the GNU Lesser General Public > @@ -433,7 +434,7 @@ DWORD_PTR WINAPI SHGetFileInfoW(LPCWSTR path,DWORD dwFileAttributes, > { > psfi->szDisplayName[0] = '\0'; > psfi->szTypeName[0] = '\0'; > - psfi->iIcon = 0; > + psfi->hIcon = NULL; > } > > if (!(flags & SHGFI_PIDL)) > @@ -449,12 +450,24 @@ DWORD_PTR WINAPI SHGetFileInfoW(LPCWSTR path,DWORD dwFileAttributes, > lstrcpynW(szFullPath, path, MAX_PATH); > } > } > + else > + { > + SHGetPathFromIDListW((LPITEMIDLIST)path, szFullPath); > + } > > if (flags & SHGFI_EXETYPE) > { > - if (flags != SHGFI_EXETYPE) > - return 0; > - return shgfi_get_exe_type(szFullPath); > + if (!(flags & SHGFI_SYSICONINDEX)) > + { > + if (flags & SHGFI_USEFILEATTRIBUTES) > + { > + return TRUE; > + } > + else if (GetFileAttributesW(szFullPath) != INVALID_FILE_ATTRIBUTES) > + { > + return shgfi_get_exe_type(szFullPath); > + } > + } > } > > /* > @@ -488,6 +501,8 @@ DWORD_PTR WINAPI SHGetFileInfoW(LPCWSTR path,DWORD dwFileAttributes, > (LPCITEMIDLIST*)&pidlLast ); > if (SUCCEEDED(hr)) > pidlLast = ILClone(pidlLast); > + else > + hr = S_OK; > ILFree(pidl); > } > else > @@ -505,8 +520,18 @@ DWORD_PTR WINAPI SHGetFileInfoW(LPCWSTR path,DWORD dwFileAttributes, > psfi->dwAttributes = 0xffffffff; > } > if (psfParent) > - IShellFolder_GetAttributesOf( psfParent, 1, (LPCITEMIDLIST*)&pidlLast, > - &(psfi->dwAttributes) ); > + { > + IShellFolder_GetAttributesOf(psfParent, 1, (LPCITEMIDLIST*)&pidlLast, > + &(psfi->dwAttributes)); > + } > + } > + > + if (flags & SHGFI_USEFILEATTRIBUTES) > + { > + if (flags & SHGFI_ICON) > + { > + psfi->dwAttributes = 0; > + } > } > > /* get the displayname */ > @@ -516,7 +541,7 @@ DWORD_PTR WINAPI SHGetFileInfoW(LPCWSTR path,DWORD dwFileAttributes, > { > lstrcpyW (psfi->szDisplayName, PathFindFileNameW(szFullPath)); > } > - else > + else if (psfParent) > { > STRRET str; > hr = IShellFolder_GetDisplayNameOf( psfParent, pidlLast, > @@ -618,7 +643,7 @@ DWORD_PTR WINAPI SHGetFileInfoW(LPCWSTR path,DWORD dwFileAttributes, > ret = FALSE; > } > } > - else > + else if (psfParent) > { > hr = IShellFolder_GetUIObjectOf(psfParent, 0, 1, > (LPCITEMIDLIST*)&pidlLast, &IID_IExtractIconW, > @@ -694,7 +719,7 @@ DWORD_PTR WINAPI SHGetFileInfoW(LPCWSTR path,DWORD dwFileAttributes, > } > } > } > - else > + else if (psfParent) > { > if (!(PidlToSicIndex(psfParent, pidlLast, !(flags & SHGFI_SMALLICON), > uGilFlags, &(psfi->iIcon)))) > @@ -769,33 +794,25 @@ DWORD_PTR WINAPI SHGetFileInfoA(LPCSTR path,DWORD dwFileAttributes, > pathW = temppath; > } > > - if (psfi && (flags & SHGFI_ATTR_SPECIFIED)) > - temppsfi.dwAttributes=psfi->dwAttributes; > + if (psfi) > + { > + temppsfi.hIcon = psfi->hIcon; > + temppsfi.iIcon = psfi->iIcon; > + temppsfi.dwAttributes = psfi->dwAttributes; > > - if (psfi == NULL) > - ret = SHGetFileInfoW(pathW, dwFileAttributes, NULL, 0, flags); > - else > ret = SHGetFileInfoW(pathW, dwFileAttributes, &temppsfi, sizeof(temppsfi), flags); > + psfi->hIcon = temppsfi.hIcon; > + psfi->iIcon = temppsfi.iIcon; > + psfi->dwAttributes = temppsfi.dwAttributes; > > - if (psfi) > - { > - if(flags & SHGFI_ICON) > - psfi->hIcon=temppsfi.hIcon; > - if(flags & (SHGFI_SYSICONINDEX|SHGFI_ICON|SHGFI_ICONLOCATION)) > - psfi->iIcon=temppsfi.iIcon; > - if(flags & SHGFI_ATTRIBUTES) > - psfi->dwAttributes=temppsfi.dwAttributes; > - if(flags & (SHGFI_DISPLAYNAME|SHGFI_ICONLOCATION)) > - { > - WideCharToMultiByte(CP_ACP, 0, temppsfi.szDisplayName, -1, > - psfi->szDisplayName, sizeof(psfi->szDisplayName), NULL, NULL); > - } > - if(flags & SHGFI_TYPENAME) > - { > - WideCharToMultiByte(CP_ACP, 0, temppsfi.szTypeName, -1, > - psfi->szTypeName, sizeof(psfi->szTypeName), NULL, NULL); > - } > + WideCharToMultiByte(CP_ACP, 0, temppsfi.szDisplayName, -1, > + psfi->szDisplayName, sizeof(psfi->szDisplayName), NULL, NULL); > + > + WideCharToMultiByte(CP_ACP, 0, temppsfi.szTypeName, -1, > + psfi->szTypeName, sizeof(psfi->szTypeName), NULL, NULL); > } > + else > + ret = SHGetFileInfoW(pathW, dwFileAttributes, NULL, 0, flags); > > HeapFree(GetProcessHeap(), 0, temppath); > > -- Pierre Schweitzer <pierre at reactos.org> System & Network Administrator Senior Kernel Developer ReactOS Deutschland e.V.

1 0

Re: [ros-dev] [ros-diffs] 01/01: [NTOS:KE] Replace "Fatal System Error" with "BugCheck"
by Alex Ionescu 11 Feb '18

11 Feb '18

This changes documented/external behavior. What is the point of this change? Best regards, Alex Ionescu On Wed, Feb 7, 2018 at 1:22 PM, Serge Gautherie <reactos-git_serge_171003(a)gautherie.fr> wrote: > https://git.reactos.org/?p=reactos.git;a=commitdiff;h=6ece4e9fc22d664ea2485… > > commit 6ece4e9fc22d664ea2485d04303e8ae10047f21f > Author: Serge Gautherie <reactos-git_serge_171003(a)gautherie.fr> > AuthorDate: Wed Feb 7 06:29:02 2018 +0100 > Commit: Pierre Schweitzer <pierre(a)reactos.org> > CommitDate: Wed Feb 7 22:22:28 2018 +0100 > > [NTOS:KE] Replace "Fatal System Error" with "BugCheck" > --- > ntoskrnl/ke/bug.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/ntoskrnl/ke/bug.c b/ntoskrnl/ke/bug.c > index a92acb1bab..2127d7207c 100644 > --- a/ntoskrnl/ke/bug.c > +++ b/ntoskrnl/ke/bug.c > @@ -1070,8 +1070,8 @@ KeBugCheckWithTf(IN ULONG BugCheckCode, > if ((BugCheckCode != MANUALLY_INITIATED_CRASH) && (KdDebuggerEnabled)) > { > /* Crash on the debugger console */ > - DbgPrint("\n*** Fatal System Error: 0x%08lx\n" > - " (0x%p,0x%p,0x%p,0x%p)\n\n", > + DbgPrint("\n*** BugCheck: 0x%08lx\n" > + " (0x%p,0x%p,0x%p,0x%p)\n\n", > KiBugCheckData[0], > KiBugCheckData[1], > KiBugCheckData[2], >

4 4

Re: [ros-dev] Chemnitz Linux Tage, who will come by and support the booth?
by Daniel Reimer 11 Feb '18

11 Feb '18

Hello once more. Thanks for the single answer I got asking to take part. But I need one more booth supporter, preferred are team members. You have time till today evening to answer, otherwise I am not sure if I should blindly reply with the yes aka we will take part in CLT the team behind it is waiting for. In the end I reply and no one shows up. It is up to you. I got my holidays accepted last year already for being able to take part. What about the rest of the team who did not reply with a good reason not to take part already? Greetings Daniel Daniel Reimer <daniel.reimer(a)reactos.org> schrieb am Sa, 03.02.2018 14:54: > Hey guys, > > as every year, I need volunteers for the booth on Chemnitzer Linux Tage > (https://chemnitzer.linux-tage.de/2018/en). > > This year it's on March 10-11. Anyone who has some spare time for it? I > need at least two ppl for these days, otherwise I have to cancel it. > > Greetings > > Daniel > > > _______________________________________________ > Ros-dev mailing list > Ros-dev(a)reactos.org > http://www.reactos.org/mailman/listinfo/ros-dev

1 0

RFC: Change Rapps 'Size' field
by Mark Jansen 08 Feb '18

08 Feb '18

Hello, I'd like to propose a change for the 'Size' field: Currently this is a localized, pre-formatted field. By changing this to the actual size in bytes: - We can use StrFormatByteSizeW to format it locale dependent (without the need to manually translate it) - We can use this value to display the progress bar, in case the download itself does not provide this value (for example, web.archive does not provide this). For backwards compatibility we should probably add this as another field, so that the 'old' rapps can still read the 'Size' field. Regards, Mark

3 3

Chemnitz Linux Tage, who will come by and support the booth?
by Daniel Reimer 03 Feb '18

03 Feb '18

Hey guys, as every year, I need volunteers for the booth on Chemnitzer Linux Tage (https://chemnitzer.linux-tage.de/2018/en). This year it's on March 10-11. Anyone who has some spare time for it? I need at least two ppl for these days, otherwise I have to cancel it. Greetings Daniel

2 1

Dynamic libxml2/zlib
by Thomas Faber 03 Feb '18

03 Feb '18

Hey Amine, seeing https://jira.reactos.org/browse/CORE-14288 just prompted me to look into static vs dynamic 3rd party libraries, zlib and libxml2 in particular. We use zlib in a bunch of modules these days, and libxml2 is large and used in two, so I'm thinking we should make them dynamic. I just did the experiment for libxml2 and it resulted in at least 0.5MB binary size reduction and 2MB build folder size reduction, so clearly seems worth it.[1] I'll do the test for zlib as well to make sure that's also an improvement. However I was thinking there might be a reason why we build those statically right now. Do you (or anyone else) recall anything that makes switching to dynamic a bad idea? Thanks! -Thomas [1] Raw results: Static libxml2 (MSVC debug with RTC): msxml3.dll - 1887 KB libxslt.dll - 1142 KB libxml2.lib - 4953 KB (build dir only) Dynamic libxml2 (MSVC debug with RTC): msxml3.dll - 799 KB libxslt.dll - 259 KB libxml2.dll - 1592 KB libxml2.lib - 371 KB (build dir only) Static libxml2 (GCC debug with -O1): msxml3.dll - 3856 KB libxslt.dll - 2776 KB liblibxml2.a - 48 KB (build dir only) Dynamic libxml2 (GCC debug with -O1): msxml3.dll - 1505 KB libxslt.dll - 429 KB libxml2.dll - 2553 KB

2 1

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev February 2018