Hi all!
Let me invite you to the June 2018 meeting, taking place this Thursday,
June 28, 2018 at 19:00 UTC.
Invited members will again receive their credentials shortly before the
meeting.
The current agenda is:
1. Status Reports
2. ReactOS Hackfest on August 16 - 21
3. 0.4.9 release on July 14
I'm open for additional proposals.
Best regards,
Colin
This change (on my own code snippet btw, see commit 5a1a35ca5a6) was necessary because otherwise, the StringPrintf call that is done below (which would then use a WindowTitleU.Buffer == NULL) would generate the harderror dialog title: "(null)" (in addition to other strings being appended), instead of just an empty string.
And so the bug is that I forgot to adjust the condition that needs to be checked before freeing the window title string (if it has been allocated).
Hermès
> -----Message d'origine-----
> De : Thomas Faber [mailto:thomas.faber@reactos.org]
> Envoyé : samedi 9 juin 2018 09:21
> À : ros-dev(a)reactos.org; Hermès Bélusca-Maïto
> Objet : Re: [ros-diffs] 01/01: [USERSRV] HardError: Fix compilation warning;
> fix few comments; fix the default empty window title string.
>
> On 2018-04-08 16:17, Hermès Bélusca-Maïto wrote:
> > /* Retrieve the window title of the client, if it has one */
> > - RtlInitEmptyUnicodeString(&WindowTitleU, NULL, 0);
> > + RtlInitEmptyUnicodeString(&WindowTitleU, L"", 0);
>
> This looks like a bug. Can you explain why you think it's necessary please?
>
> In particular, it will break this:
>
> if (WindowTitleU.Buffer) RtlFreeUnicodeString(&WindowTitleU);
>
>
> Thanks,
> Thomas
I've found this mirror repo on GitLab, it was created today:
https://gitlab.com/reactos/reactos
Does it belong to the ReactOS team? If not, we may have problems.
----
Regards,
Stas'M
On 2018-04-08 16:17, Hermès Bélusca-Maïto wrote:
> /* Retrieve the window title of the client, if it has one */
> - RtlInitEmptyUnicodeString(&WindowTitleU, NULL, 0);
> + RtlInitEmptyUnicodeString(&WindowTitleU, L"", 0);
This looks like a bug. Can you explain why you think it's necessary please?
In particular, it will break this:
if (WindowTitleU.Buffer) RtlFreeUnicodeString(&WindowTitleU);
Thanks,
Thomas
Hey there !
Went through the reactOS GSOC’18 page. I am interested in making web interface for reactos which can show all GitHub reactos repos, commits, etc using the GitHub API. (https://www.reactos.org/wiki/Google_Summer_of_Code_2018_Ideas#Developer_Web…)
Looking forward to work on the same idea for GSOC’19 under your mentorship. Need to know more about layout of the web interface. Kindly help!
thanks
Hi all!
It's official now! The ReactOS Hackfest 2018 will take place from
Thursday, 16th August 2018 to Tuesday, 21st August 2018 in Berlin, Germany.
Thanks to Thomas, the event location is already checked out ("definitely
more space than in Cologne") and he has found a hostel nearby.
All information can be found at
https://reactos.org/wiki/ReactOS_Hackfest_2018, with the lists for
registering yourself and collecting ideas at
https://reactos.org/wiki/ReactOS_Hackfest_2018/Lists
Hope to see you in August!
Cheers,
Colin