Ros-dev August 2018

ros-dev@reactos.org

16 participants
14 discussions

by Javier Agustìn Fernàndez Arroyo

i was thinking about Valve's Linux support (Steam play) and i was wondering about asking them to support ReactOS via development... Since Windows XP/2k3 are being abandoned, maybe ReactOS could still run Steam games... if they support it. what do you think?

6 years, 1 month

Broken booting since commit ae11022712db7a5a1e818e33a5f4052eac7e8e3c

by David Quintana (gigaherz)

I believe from the testbot log, that my commit made some DLLs grow out of their assigned memory allocation, but I don't know how to update the dll address mappings. Help appreciated.

6 years, 1 month

Status Meeting (August 2018)

by Colin Finck

Hi all! Let me invite you to the August 2018 meeting, taking place this Thursday, August 30, 2018 at 19:00 UTC. Invited members will again receive their credentials shortly before the meeting. The current agenda is: 1. Status Reports (extended) Note that this is the first meeting after both GSoC and the Hackfest. Participants in either effort are encouraged to also report their related work, what they liked and didn't like about GSoC/ Hackfest, and what we could do better next time. As always, I'm open for additional proposals. I also have to announce that I will definitely be unavailable during the entire September, so someone else has to invite for and lead the September meeting. Best regards, Colin

6 years, 1 month

Test_VBox finally fixed - but a flawed test remains

by Colin Finck

Hi all, I took some time during Hackfest to upgrade our Test_VBox Testbot to Ubuntu 18.04, which finally brings us VirtualBox 5.2.x support for sysreg2. Pierre also worked on the relevant BuildBot scripts to improve their reliability. This has resulted in https://github.com/reactos/buildbot_config/commit/388a831eb5ccf67535d8cbd6d… and since using that script, the infamous "IVirtualBox object is null" bug hasn't occurred again :) The upgrade from VirtualBox 4.3.40 to 5.2.10 also resulted in unbearably slow serial port output at first, but this could be fixed by https://github.com/reactos/sysreg2/commit/a4eb4a4551618b4af4dc1985ad8c55fe0…. Have a look at this commit if you encounter a slow serial port output in one of the latest VirtualBox versions with either operating system. This only leaves a funnily flawed WINE test left, which currently causes the entire regression testing process to come to a standstill: https://jira.reactos.org/browse/CORE-14975 Cheers, Colin

6 years, 1 month

Discussions on ENIW

by Erkin Alp Güney

|My proposed architecture diagram for ENIW: Linux app systemd <> systemd2svchost Windows userland ------ User-mode Linux kernel ------- SVCHOST Windows services ENIW.SYS Windows personalities Kernel-mode drivers for everything -------------------------- NTOSKRNL.EXE ----------------------------------- ENIW is a component to implement WSL-like functionality named after WINE and its bacronym is ENIW never imitated WSL. systemd2svchost is a service translator to run systemd units as svchost services. Forum thread: <https://www.reactos.org/forum/viewtopic.php?f=9&t=17434> JIRA ticket: <https://jira.reactos.org/browse/CORE-13613> Yours, faihfully Erkin Alp |

6 years, 1 month

Re: [ros-dev] [ros-diffs] 01/01: [NTOS:MM] Fix paged pool expansion

by Pierre Schweitzer

Hi Timo et al., To make the issue wider known than just me comment on GitHub. That commit introduced a regression. Le 20/08/2018 à 18:07, Timo Kreuzer a écrit : > https://git.reactos.org/?p=reactos.git;a=commitdiff;h=c219be9409af429909b14… > > commit c219be9409af429909b1433da536516b3c3ab823 > Author: Timo Kreuzer <timo.kreuzer(a)reactos.org> > AuthorDate: Sun Feb 4 19:20:56 2018 +0100 > Commit: Timo Kreuzer <timo.kreuzer(a)reactos.org> > CommitDate: Mon Aug 20 18:07:35 2018 +0200 > > [NTOS:MM] Fix paged pool expansion > --- > ntoskrnl/mm/ARM3/pool.c | 11 ++++++++--- > 1 file changed, 8 insertions(+), 3 deletions(-) > > diff --git a/ntoskrnl/mm/ARM3/pool.c b/ntoskrnl/mm/ARM3/pool.c > index 7cebabe818..113a7aa981 100644 > --- a/ntoskrnl/mm/ARM3/pool.c > +++ b/ntoskrnl/mm/ARM3/pool.c > @@ -561,10 +565,11 @@ MiAllocatePoolPages(IN POOL_TYPE PoolType, > MiInitializePfnForOtherProcess(PageFrameNumber, > (PMMPTE)PointerPde, > MmSystemPageDirectory[(PointerPde - MiAddressToPde(NULL)) / PDE_COUNT]); > +#endif > > /* Write the actual PDE now */ > -// MI_WRITE_VALID_PDE(PointerPde, TempPde); > -#endif > + MI_WRITE_VALID_PDE(PointerPde, TempPde); > + That little change for x86 actually breaks VBox support. It hits an ASSERT during 3rd stage: *** Assertion failed: PointerPde->u.Hard.Valid == 0 *** Source File: /srv/buildbot/Build_GCCLin_x86/build/ntoskrnl/mm/ARM3/miarm.h, line 975 See testbots for instance: https://build.reactos.org/builders/Test%20VBox/builds/8625/steps/test/logs/… Cheers, Pierre -- Pierre Schweitzer <pierre at reactos.org> System & Network Administrator Senior Kernel Developer ReactOS Deutschland e.V.

6 years, 1 month

Re: [ros-dev] [ros-diffs] 01/01: [CONFIGURE] Added support for new VS 19.15.x

by Pierre Schweitzer

Formatting is inconsistent now. Tab vs space issue. Le 16/08/2018 à 17:14, Oleksandr Shaposhnikov a écrit : > https://git.reactos.org/?p=reactos.git;a=commitdiff;h=c8d51bb87a92457f7356f… > > commit c8d51bb87a92457f7356fb6cd3488cd0db3b4b5c > Author: Oleksandr Shaposhnikov <sanchaez(a)hotmail.com> > AuthorDate: Thu Aug 16 18:11:53 2018 +0300 > Commit: Oleksandr Shaposhnikov <sanchaez(a)hotmail.com> > CommitDate: Thu Aug 16 18:13:54 2018 +0300 > > [CONFIGURE] Added support for new VS 19.15.x > --- > configure.cmd | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/configure.cmd b/configure.cmd > index 70b0f48211..bacc75a743 100755 > --- a/configure.cmd > +++ b/configure.cmd > @@ -71,6 +71,7 @@ if defined ROS_ARCH ( > cl 2>&1 | find "19.12." > NUL && set VS_VERSION=15 > cl 2>&1 | find "19.13." > NUL && set VS_VERSION=15 > cl 2>&1 | find "19.14." > NUL && set VS_VERSION=15 > + cl 2>&1 | find "19.15." > NUL && set VS_VERSION=15 > if not defined VS_VERSION ( > echo Error: Visual Studio version too old ^(before 10 ^(2010^)^) or version detection failed. > goto quit > -- Pierre Schweitzer <pierre at reactos.org> System & Network Administrator Senior Kernel Developer ReactOS Deutschland e.V.

6 years, 2 months

Re: [ros-dev] [ros-diffs] 01/01: [HAL] Remove misleading debug prints about USB controllers.

by Alex Ionescu

Why are these misleading? These are checks that Windows does that we are missing. Guys, open PRs for changes like these ffs. Best regards, Alex Ionescu On Wed, Aug 8, 2018 at 7:14 PM Thomas Faber <thomas.faber(a)reactos.org> wrote: > > https://git.reactos.org/?p=reactos.git;a=commitdiff;h=1ed0f9ab576f094b27e11… > > commit 1ed0f9ab576f094b27e11ba374738ecabc00e2e6 > Author: Thomas Faber <thomas.faber(a)reactos.org> > AuthorDate: Wed Aug 8 19:58:56 2018 +0200 > Commit: Thomas Faber <thomas.faber(a)reactos.org> > CommitDate: Wed Aug 8 20:08:38 2018 +0200 > > [HAL] Remove misleading debug prints about USB controllers. > --- > hal/halx86/legacy/bussupp.c | 26 -------------------------- > 1 file changed, 26 deletions(-) > > diff --git a/hal/halx86/legacy/bussupp.c b/hal/halx86/legacy/bussupp.c > index a37d875ede..4d20396560 100644 > --- a/hal/halx86/legacy/bussupp.c > +++ b/hal/halx86/legacy/bussupp.c > @@ -1128,32 +1128,6 @@ HalpInitializePciBus(VOID) > } > } > > - /* Check if this is a USB controller */ > - if ((PciData->BaseClass == PCI_CLASS_SERIAL_BUS_CTLR) && > - (PciData->SubClass == PCI_SUBCLASS_SB_USB)) > - { > - /* Check if this is an OHCI controller */ > - if (PciData->ProgIf == 0x10) > - { > - DbgPrint("\tDevice is an OHCI (USB) PCI Expansion > Card. Turn off Legacy USB in your BIOS!\n\n"); > - continue; > - } > - > - /* Check for Intel UHCI controller */ > - if (PciData->VendorID == 0x8086) > - { > - DbgPrint("\tDevice is an Intel UHCI (USB) > Controller. Turn off Legacy USB in your BIOS!\n\n"); > - continue; > - } > - > - /* Check for VIA UHCI controller */ > - if (PciData->VendorID == 0x1106) > - { > - DbgPrint("\tDevice is a VIA UHCI (USB) > Controller. Turn off Legacy USB in your BIOS!\n\n"); > - continue; > - } > - } > - > /* Now check the registry for chipset hacks */ > Status = HalpGetChipHacks(PciData->VendorID, > PciData->DeviceID, > >

6 years, 2 months

Re: [ros-dev] [ros-diffs] 01/04: [REACTOS] RtlAssert(): use "%lu" as LineNumber format.

by Michael Fritscher

Moin, On 08.08.2018 22:05, Serge Gautherie wrote: > https://git.reactos.org/?p=reactos.git;a=commitdiff;h=97d3b3ce3349fa87d01ee… > > commit 97d3b3ce3349fa87d01ee29d0d08ff2ca8618a7d > Author: Serge Gautherie <reactos-git_serge_171003(a)gautherie.fr> > AuthorDate: Thu Jun 21 05:05:50 2018 +0200 > Commit: Hermès Bélusca-Maïto <hermes.belusca-maito(a)reactos.org> > CommitDate: Wed Aug 8 21:24:07 2018 +0200 > > [REACTOS] RtlAssert(): use "%lu" as LineNumber format. > --- ... > - if (NULL != Message) > - { > - DbgPrint("Assertion \'%s\' failed at %s line %d: %s\n", > - (PCHAR)FailedAssertion, > - (PCHAR)FileName, > - LineNumber, > - Message); > - } > - else > - { > - DbgPrint("Assertion \'%s\' failed at %s line %d\n", > - (PCHAR)FailedAssertion, > - (PCHAR)FileName, > - LineNumber); > - } > - > - //DbgBreakPoint(); > + if (Message != NULL) > + { > + DbgPrint("Assertion \'%s\' failed at %s line %u: %s\n", > + (PCHAR)FailedAssertion, > + (PCHAR)FileName, > + LineNumber, > + Message); > + } > + else > + { > + DbgPrint("Assertion \'%s\' failed at %s line %u\n", > + (PCHAR)FailedAssertion, > + (PCHAR)FileName, > + LineNumber); > + } > + > + //DbgBreakPoint(); > } > > // DECLSPEC_NORETURN > here no %lu, but only %u? Best regards, Michael Fritscher

6 years, 2 months

Re: [ros-dev] [ros-diffs] 01/01: [WLNOTIFY] Add sens service stubs

by Ged Murphy

Hi Eric, Do you plan on implementing sysntfy which sens is dependent upon from win7, or do you plan to stick with the XP way via winlogon? If so, I have some undocumented notes and code on sysntfy which might be of some use. Ged. -----Original Message----- From: Ros-diffs <ros-diffs-bounces(a)reactos.org> On Behalf Of Eric Kohl Sent: Tuesday, 07 August 2018 21:57 To: ros-diffs(a)reactos.org Subject: [ros-diffs] 01/01: [WLNOTIFY] Add sens service stubs https://git.reactos.org/?p=reactos.git;a=commitdiff;h=fb5d5ecd64e1e47701e92… commit fb5d5ecd64e1e47701e922e08fd97b29a1d418be Author: Eric Kohl <eric.kohl(a)reactos.org> AuthorDate: Tue Aug 7 22:56:33 2018 +0200 Commit: Eric Kohl <eric.kohl(a)reactos.org> CommitDate: Tue Aug 7 22:56:33 2018 +0200 [WLNOTIFY] Add sens service stubs --- dll/win32/wlnotify/CMakeLists.txt | 1 + dll/win32/wlnotify/{test.c => senssvc.c} | 56 +++++++++++++++++--------------- dll/win32/wlnotify/test.c | 2 +- dll/win32/wlnotify/wlnotify.spec | 24 +++++++------- 4 files changed, 43 insertions(+), 40 deletions(-) diff --git a/dll/win32/wlnotify/CMakeLists.txt b/dll/win32/wlnotify/CMakeLists.txt index 1db47fffe2..6cbf00ce86 100644 --- a/dll/win32/wlnotify/CMakeLists.txt +++ b/dll/win32/wlnotify/CMakeLists.txt @@ -3,6 +3,7 @@ spec2def(wlnotify.dll wlnotify.spec ADD_IMPORTLIB) list(APPEND SOURCE schedsvc.c + senssvc.c test.c wlnotify.c precomp.h) diff --git a/dll/win32/wlnotify/test.c b/dll/win32/wlnotify/senssvc.c similarity index 86% copy from dll/win32/wlnotify/test.c copy to dll/win32/wlnotify/senssvc.c index e3911d3b75..e238a849a9 100644 --- a/dll/win32/wlnotify/test.c +++ b/dll/win32/wlnotify/senssvc.c @@ -1,12 +1,13 @@ /* * PROJECT: ReactOS system libraries * LICENSE: GPL - See COPYING in the top level directory - * FILE: dll/win32/wlnotify/test.c - * PURPOSE: Winlogon notifications - * PROGRAMMER: Eric Kohl + * FILE: dll/win32/wlnotify/senssvc.c + * PURPOSE: SENS service logon notifications + * PROGRAMMER: Eric Kohl <eric.kohl(a)reactos.org> */ #include "precomp.h" +#include <winsvc.h> #define _NDEBUG #include <debug.h> @@ -14,10 +15,10 @@ VOID WINAPI -TestLogonEvent( +SensDisconnectEvent( PWLX_NOTIFICATION_INFO pInfo) { - DPRINT("TestLogonEvent\n"); + DPRINT("SensDisconnectEvent\n"); DPRINT("Size: %lu\n", pInfo->Size); DPRINT("Flags: %lx\n", pInfo->Flags); DPRINT("UserName: %S\n", pInfo->UserName); @@ -31,10 +32,10 @@ TestLogonEvent( VOID WINAPI -TestLogoffEvent( +SensLockEvent( PWLX_NOTIFICATION_INFO pInfo) { - DPRINT("TestLogoffEvent\n"); + DPRINT("SensLockEvent\n"); DPRINT("Size: %lu\n", pInfo->Size); DPRINT("Flags: %lx\n", pInfo->Flags); DPRINT("UserName: %S\n", pInfo->UserName); @@ -48,10 +49,10 @@ TestLogoffEvent( VOID WINAPI -TestLockEvent( +SensLogoffEvent( PWLX_NOTIFICATION_INFO pInfo) { - DPRINT("TestLockEvent\n"); + DPRINT("SensLogoffEvent\n"); DPRINT("Size: %lu\n", pInfo->Size); DPRINT("Flags: %lx\n", pInfo->Flags); DPRINT("UserName: %S\n", pInfo->UserName); @@ -65,10 +66,10 @@ TestLockEvent( VOID WINAPI -TestUnlockEvent( +SensLogonEvent( PWLX_NOTIFICATION_INFO pInfo) { - DPRINT("TestUnlockEvent\n"); + DPRINT("SensLogonEvent\n"); DPRINT("Size: %lu\n", pInfo->Size); DPRINT("Flags: %lx\n", pInfo->Flags); DPRINT("UserName: %S\n", pInfo->UserName); @@ -82,10 +83,10 @@ TestUnlockEvent( VOID WINAPI -TestStartupEvent( +SensPostShellEvent( PWLX_NOTIFICATION_INFO pInfo) { - DPRINT("TestStartupEvent\n"); + DPRINT("SensPostShellEvent\n"); DPRINT("Size: %lu\n", pInfo->Size); DPRINT("Flags: %lx\n", pInfo->Flags); DPRINT("UserName: %S\n", pInfo->UserName); @@ -99,10 +100,10 @@ TestStartupEvent( VOID WINAPI -TestShutdownEvent( +SensReconnectEvent( PWLX_NOTIFICATION_INFO pInfo) { - DPRINT("TestShutdownEvent\n"); + DPRINT("SensReconnectEvent\n"); DPRINT("Size: %lu\n", pInfo->Size); DPRINT("Flags: %lx\n", pInfo->Flags); DPRINT("UserName: %S\n", pInfo->UserName); @@ -116,10 +117,10 @@ TestShutdownEvent( VOID WINAPI -TestStartScreenSaverEvent( +SensShutdownEvent( PWLX_NOTIFICATION_INFO pInfo) { - DPRINT("TestStartScreenSaverEvent\n"); + DPRINT("SensShutdownEvent\n"); DPRINT("Size: %lu\n", pInfo->Size); DPRINT("Flags: %lx\n", pInfo->Flags); DPRINT("UserName: %S\n", pInfo->UserName); @@ -133,10 +134,10 @@ TestStartScreenSaverEvent( VOID WINAPI -TestStopScreenSaverEvent( +SensStartScreenSaverEvent( PWLX_NOTIFICATION_INFO pInfo) { - DPRINT("TestStopScreenSaverEvent\n"); + DPRINT("SensStartScreenSaverEvent\n"); DPRINT("Size: %lu\n", pInfo->Size); DPRINT("Flags: %lx\n", pInfo->Flags); DPRINT("UserName: %S\n", pInfo->UserName); @@ -150,10 +151,10 @@ TestStopScreenSaverEvent( VOID WINAPI -TestStartShellEvent( +SensStartShellEvent( PWLX_NOTIFICATION_INFO pInfo) { - DPRINT("TestStartShellEvent\n"); + DPRINT("SensStartShellEvent\n"); DPRINT("Size: %lu\n", pInfo->Size); DPRINT("Flags: %lx\n", pInfo->Flags); DPRINT("UserName: %S\n", pInfo->UserName); @@ -167,10 +168,10 @@ TestStartShellEvent( VOID WINAPI -TestPostShellEvent( +SensStartupEvent( PWLX_NOTIFICATION_INFO pInfo) { - DPRINT("TestStartShellEvent\n"); + DPRINT("SensStartupEvent\n"); DPRINT("Size: %lu\n", pInfo->Size); DPRINT("Flags: %lx\n", pInfo->Flags); DPRINT("UserName: %S\n", pInfo->UserName); @@ -181,12 +182,13 @@ TestPostShellEvent( DPRINT("pStatusCallback: %p\n", pInfo->pStatusCallback); } + VOID WINAPI -TestDisconnectEvent( +SensStopScreenSaverEvent( PWLX_NOTIFICATION_INFO pInfo) { - DPRINT("TestDisconnectEvent\n"); + DPRINT("SensStopScreenSaverEvent\n"); DPRINT("Size: %lu\n", pInfo->Size); DPRINT("Flags: %lx\n", pInfo->Flags); DPRINT("UserName: %S\n", pInfo->UserName); @@ -200,10 +202,10 @@ TestDisconnectEvent( VOID WINAPI -TestReconnectEvent( +SensUnlockEvent( PWLX_NOTIFICATION_INFO pInfo) { - DPRINT("TestReconnectEvent\n"); + DPRINT("SensUnlockEvent\n"); DPRINT("Size: %lu\n", pInfo->Size); DPRINT("Flags: %lx\n", pInfo->Flags); DPRINT("UserName: %S\n", pInfo->UserName); diff --git a/dll/win32/wlnotify/test.c b/dll/win32/wlnotify/test.c index e3911d3b75..8f8705547a 100644 --- a/dll/win32/wlnotify/test.c +++ b/dll/win32/wlnotify/test.c @@ -170,7 +170,7 @@ WINAPI TestPostShellEvent( PWLX_NOTIFICATION_INFO pInfo) { - DPRINT("TestStartShellEvent\n"); + DPRINT("TestPostShellEvent\n"); DPRINT("Size: %lu\n", pInfo->Size); DPRINT("Flags: %lx\n", pInfo->Flags); DPRINT("UserName: %S\n", pInfo->UserName); diff --git a/dll/win32/wlnotify/wlnotify.spec b/dll/win32/wlnotify/wlnotify.spec index 737448d4d9..2eb0b647c1 100644 --- a/dll/win32/wlnotify/wlnotify.spec +++ b/dll/win32/wlnotify/wlnotify.spec @@ -5,18 +5,18 @@ ;@ stub SCardSuspendCertProp @ stdcall SchedEventLogoff(ptr) @ stdcall SchedStartShell(ptr) -;@ stub SensDisconnectEvent -;@ stub SensLockEvent -;@ stub SensLogoffEvent -;@ stub SensLogonEvent -;@ stub SensPostShellEvent -;@ stub SensReconnectEvent -;@ stub SensShutdownEvent -;@ stub SensStartScreenSaverEvent -;@ stub SensStartShellEvent -;@ stub SensStartupEvent -;@ stub SensStopScreenSaverEvent -;@ stub SensUnlockEvent +@ stdcall SensDisconnectEvent(ptr) +@ stdcall SensLockEvent(ptr) +@ stdcall SensLogoffEvent(ptr) +@ stdcall SensLogonEvent(ptr) +@ stdcall SensPostShellEvent(ptr) +@ stdcall SensReconnectEvent(ptr) +@ stdcall SensShutdownEvent(ptr) +@ stdcall SensStartScreenSaverEvent(ptr) @ stdcall +SensStartShellEvent(ptr) @ stdcall SensStartupEvent(ptr) @ stdcall +SensStopScreenSaverEvent(ptr) @ stdcall SensUnlockEvent(ptr) ;@ stub ShowNotificationBallonW @ stdcall TestDisconnectEvent(ptr) @ stdcall TestLockEvent(ptr)

6 years, 2 months

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev August 2018