Ros-dev January 2019

ros-dev@reactos.org

11 participants
15 discussions

GSOC 2019 - Costin Visan

by costin visan

Hello! I'm really interested in participating this year at gsoc as part of your team. I'm writting you this email to get your attention and maybe to get a hint for this year's project. I'm in my second year at University Politehnica of Bucharest at the Faculty of Automatic Control and Computers and I study for a degree in Computer Science and Information Technology. I wanna start early this year contributing to the project as I wish to show you that I will be a great addition to your team. If I have caught your attention and you want to communicate me anything, I can be contacted on this mail. - Many thanks, Costin Visan <https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campai…> Virus-free. www.avast.com <https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campai…> <#DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2>

5 years, 6 months

Please avoid merges to master

by Thomas Faber

master has been broken for days. Until this issue is fixed, no test results are going to make it to Testman, which means any regressions are going to be extremely hard to track down. Here's the issue to follow: https://jira.reactos.org/browse/CORE-15642 Unless you have something that might fix this, I would ask that you hold off on merging things until this bug is fixed. Thanks, Thomas

5 years, 8 months

Re: [ros-dev] [ros-diffs] [reactos] 02/02: [MOUNTMGR][MUP] Use global definition of INIT_FUNCTION/INIT_SECTION (Addendum to 71fefa32).

by Michael Fritscher

Moin, this commit causes https://build.reactos.org/builders/Build%20MSVC_x86/builds/13087/steps/comp… : FAILED: C:\PROGRA~2\MICROS~1.0\VC\bin\cl.exe /nologo -D__RELFILE__="&__FILE__[__FILE__[0] == '.' ? sizeof \"C:/Buildslave/Build_MSVC_x86/build\" - 1 : sizeof REACTOS_SOURCE_DIR]" /Ob0 /Od /GF /Gy /X /Zl /GR- /EHs-c- /GS- /arch:IA32 /FS /W3 /wd4244 /wd4290 /wd4800 /wd4200 /wd4214 /wd4018 /we4013 /we4020 /we4022 /we4047 /we4098 /we4113 /we4129 /we4163 /we4229 /we4700 /we4603 /we4716 /we4028 /we4189 /w14115 /Zi /hotpatch -Idrivers\filters\mountmgr -IC:\Buildslave\Build_MSVC_x86\build\drivers\filters\mountmgr -IC:\Buildslave\Build_MSVC_x86\build\sdk\include -IC:\Buildslave\Build_MSVC_x86\build\sdk\include\psdk -IC:\Buildslave\Build_MSVC_x86\build\sdk\include\dxsdk -Isdk\include -Isdk\include\psdk -Isdk\include\dxsdk -Isdk\include\ddk -Isdk\include\reactos -Isdk\include\reactos\mc -IC:\Buildslave\Build_MSVC_x86\build\sdk\include\crt -IC:\Buildslave\Build_MSVC_x86\build\sdk\include\ddk -IC:\Buildslave\Build_MSVC_x86\build\sdk\include\ndk -IC:\Buildslave\Build_MSVC_x86\build\sdk\include\reactos -IC:\Buildslave\Build_MSVC_x86\build\sdk\include\reactos\libs -DREACTOS_SOURCE_DIR="\"C:/Buildslave/Build_MSVC_x86/build\"" -DREACTOS_BINARY_DIR="\"R:/buildbot/output-VS-i386\"" /FIR:/buildbot/output-VS-i386/drivers/filters/mountmgr/mountmgr.pch /YuR:/buildbot/output-VS-i386/drivers/filters/mountmgr/mountmgr.pch /showIncludes -DDBG=1 -DUSE_COMPILER_EXCEPTIONS -DWIN32 -DWINVER=0x502 -D_M_IX86 -D_SEH_ENABLE_TRACE -D_SETUPAPI_VER=0x502 -D_USE_32BIT_TIME_T -D_WIN32_IE=0x600 -D_WIN32_WINDOWS=0x502 -D_WIN32_WINNT=0x502 -D_WINDOWS -D_WINKD_=1 -D_X86_ -D__REACTOS__ -D__STDC__=1 -D__i386__ -Di386 -Dinline=__inline -Dmountmgr_EXPORTS /Fodrivers\filters\mountmgr\CMakeFiles\mountmgr.dir\mountmgr.c.obj /Fddrivers\filters\mountmgr\CMakeFiles\mountmgr.dir\ /FS -c C:\Buildslave\Build_MSVC_x86\build\drivers\filters\mountmgr\mountmgr.c C:\Buildslave\Build_MSVC_x86\build\drivers\filters\mountmgr\mountmgr.c(1810) : error C2983: 'DriverEntry' : all declarations must have an identical __declspec(code_seg(...)) C:\Buildslave\Build_MSVC_x86\build\drivers\filters\mountmgr\mntmgr.h(179) : see declaration of 'DriverEntry' Best regards, Michael Fritscher On 27.01.19 02:37, Hermès Bélusca-Maïto wrote: > https://git.reactos.org/?p=reactos.git;a=commitdiff;h=53abbb06b532fd052d575… > > commit 53abbb06b532fd052d575231a219ca5683e05514 > Author: Hermès Bélusca-Maïto <hermes.belusca-maito(a)reactos.org> > AuthorDate: Sun Jan 27 02:34:20 2019 +0100 > Commit: Hermès Bélusca-Maïto <hermes.belusca-maito(a)reactos.org> > CommitDate: Sun Jan 27 02:40:11 2019 +0100 > > [MOUNTMGR][MUP] Use global definition of INIT_FUNCTION/INIT_SECTION (Addendum to 71fefa32). > --- > drivers/filesystems/mup/dfs.h | 9 +-------- > drivers/filters/mountmgr/mntmgr.h | 9 ++------- > drivers/filters/mountmgr/mountmgr.c | 4 ++-- > 3 files changed, 5 insertions(+), 17 deletions(-) > > diff --git a/drivers/filesystems/mup/dfs.h b/drivers/filesystems/mup/dfs.h > index d158a055ab..49194bdc7f 100644 > --- a/drivers/filesystems/mup/dfs.h > +++ b/drivers/filesystems/mup/dfs.h > @@ -1,14 +1,7 @@ > #ifndef _DFS_PCH_ > #define _DFS_PCH_ > > -#ifndef INIT_SECTION > -#ifdef __GNUC__ > -#define INIT_SECTION __attribute__((section ("INIT"))) > -#else > -#define INIT_SECTION /* Done via alloc_text for MSC */ > -#endif > -#define INIT_FUNCTION INIT_SECTION > -#endif > +#include <section_attribs.h> > > #define DFS_OPEN_CONTEXT 0xFF444653 > #define DFS_DOWNLEVEL_OPEN_CONTEXT 0x11444653 > diff --git a/drivers/filters/mountmgr/mntmgr.h b/drivers/filters/mountmgr/mntmgr.h > index 4153add678..dacbfa7d69 100644 > --- a/drivers/filters/mountmgr/mntmgr.h > +++ b/drivers/filters/mountmgr/mntmgr.h > @@ -8,12 +8,7 @@ > #include <wdmguid.h> > #include <ndk/psfuncs.h> > #include <ntdddisk.h> > - > -#ifdef __GNUC__ > -#define INIT_SECTION __attribute__((section ("INIT"))) > -#else > -#define INIT_SECTION /* Done via alloc_text for MSC */ > -#endif > +#include <section_attribs.h> > > typedef struct _DEVICE_EXTENSION > { > @@ -233,7 +228,7 @@ HasDriveLetter( > IN PDEVICE_INFORMATION DeviceInformation > ); > > -INIT_SECTION > +INIT_FUNCTION > BOOLEAN > MountmgrReadNoAutoMount( > IN PUNICODE_STRING RegistryPath > diff --git a/drivers/filters/mountmgr/mountmgr.c b/drivers/filters/mountmgr/mountmgr.c > index 0e273b3957..0b2fe8e7ba 100644 > --- a/drivers/filters/mountmgr/mountmgr.c > +++ b/drivers/filters/mountmgr/mountmgr.c > @@ -908,7 +908,7 @@ MountMgrUnload(IN struct _DRIVER_OBJECT *DriverObject) > /* > * @implemented > */ > -INIT_SECTION > +INIT_FUNCTION > BOOLEAN > MountmgrReadNoAutoMount(IN PUNICODE_STRING RegistryPath) > { > @@ -1802,7 +1802,7 @@ MountMgrShutdown(IN PDEVICE_OBJECT DeviceObject, > > /* FUNCTIONS ****************************************************************/ > > -INIT_SECTION > +INIT_FUNCTION > NTSTATUS > NTAPI > DriverEntry(IN PDRIVER_OBJECT DriverObject, >

5 years, 8 months

New CI investigation

by Victor Perevertkin

Hi all! I've done some research on what can we do to improve our CI system. First of all, I want to clarify: our CI is consists of two parts: building and testing. I'm assuming here that "build" part is OK for us and doesn't require any improvements in workflow or something like that. So focusing only on "testing" part. I tried to find some solutions similar to our testman, but the things are very bad on this side. - There are some plugins for Jenkins which show a table with test results by each build - Microsoft TFS has functionality for storing tests and doing some analysis on them, but that's a no-go for us - Jetbrains' TeamCity also has this thing and has a license for Open Source I use Jetbrains tools at work and like this company in general :) so I decided make some experiments with it. Some facts: - It has out-of-the-box integration with Jira and Github. It works flawlessly (bonus: you can automatically build and test all PRs from team members, for example) - Integration with GitHub Checks (that green checkmark which for us comes from Travis&Appveyor right now) - Has an interface for filtering test results by module, shows execution time, some statistics etc. - Uses JVM for work :) Both master and slave part - PostgreSQL, MySQL and some built-in DB can be used for storage - Uses own DSL, derived from Kothlin language for configuration (but allows configuring through GUI too) Adopting iso build didn't have any issues, it just works. But testing requires some work: - sysreg2 and rosautotest should be changed to output results in some format which TeamCity understands. It can be jUnit, Google test or teamcity's own format - TeamCity has only three states of test: success, failure or crash. This does not fit with our current scheme based on succeed and failed ok()'s count - TeamCity can't compare test results between random builds like our testman. It only can show "tests which failed in this build, but didn't fail in previous one". But if we want something more, we can use their API While looking into the way how our tests work, I've found that by "test" we mean a function defined my START_TEST macro, which does some reporting to sysreg. But each START_TEST function likely has a couple of further test_* calls, which are not reported in any way. This is a place where the granularity of reporting can be increased :) Attaching some screenshots of how it look like in general. https://drive.google.com/open?id=17r4PSFmsi2tiF97HHbYGiMCOoKR7VMUF So far we have to decide what to do now. An options can be: - Go on with adopting test&build infrastructure to TeamCity - we will migrate to it eventually - We are not going to use TeamCity - somebody should develop a custom web interface to consolidate everything ( https://www.reactos.org/wiki/Google_Summer_of_Code_2019_Ideas#Developer_Web… ) - Just migrate to new BuildBot (can be done with along with previous option) - Don't do anything Looking forward to discuss this on the meeting Cheers, Victor

5 years, 8 months

Re: [ros-dev] [ros-diffs] [reactos] 01/01: [CDFS] Make windows gcc release build compile, regression CORE-15659

by Pierre Schweitzer

Your #endif is misplaced. INLINE is part of the original source code. Le 22/01/2019 à 18:50, Joachim Henze a écrit : > https://git.reactos.org/?p=reactos.git;a=commitdiff;h=bccad87f3ccf266be2179… > > commit bccad87f3ccf266be2179d1322e7a422aeb2f3b7 > Author: Joachim Henze <Joachim.Henze(a)reactos.org> > AuthorDate: Tue Jan 22 18:49:51 2019 +0100 > Commit: Joachim Henze <Joachim.Henze(a)reactos.org> > CommitDate: Tue Jan 22 18:49:51 2019 +0100 > > [CDFS] Make windows gcc release build compile, regression CORE-15659 > --- > drivers/filesystems/cdfs/cdprocs.h | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/filesystems/cdfs/cdprocs.h b/drivers/filesystems/cdfs/cdprocs.h > index 1d788b28e1..4cff63837a 100644 > --- a/drivers/filesystems/cdfs/cdprocs.h > +++ b/drivers/filesystems/cdfs/cdprocs.h > @@ -1836,7 +1836,10 @@ CdRaiseStatusEx ( > > #else > > +#ifdef __REACTOS__ > +static // make windows gcc release build compile > INLINE > +#endif > DECLSPEC_NORETURN > VOID > CdRaiseStatusEx( > -- Pierre Schweitzer <pierre at reactos.org> System & Network Administrator Senior Kernel Developer ReactOS Deutschland e.V.

5 years, 8 months

CLT 2019.... And here he is again, going on your nerves ^^

by Daniel Reimer

Hello and good evening, as some of you might already know, we are close to CLT 2019 again: https://chemnitzer.linux-tage.de/2019/de For lazy ones: 16-17.03. in Chemnitz (YES, germany that is) As every year I need at least two, better three ppl for maintaining the booth. This time I will not wait until we really got accepted just to hear from everyone a nope, or not sure yet way too late in the phase. This resulted in asking the community for help (which is a good thing tbh) and that resulted in some bored and feelin useless supporter in the end. Why? Well, a few days before the whole thing took part I suddently had enough main/core members and thus he just sat there and had nothing to do. STILL A BIG SORRY FROM MY SIDE!! I don't wanna have this happening once more that year. Thus.... check the weekend, ways to get there and back home and then reply to the doodle. Costs to get there are as always a thing we can talk about compensation and stuff. If you need to talk about CLT stuff, feel free to reply here of course ^^ So... lets hope I have the right link: https://doodle.com/poll/krmz8ktt8r85m5y4 Greetings Daniel Reimer

5 years, 8 months

Status Meeting (January 2019) - Now on Mattermost!

by Colin Finck

Hi all! As announced previously (https://reactos.org/pipermail/ros-dev/2019-January/019044.html), we'll be having the January meeting already this Thursday, January 24 in order to have enough time for our GSoC application. The meeting will also take place on our new Mattermost at https://chat.reactos.org for the first time! So let me invite you to this meeting, taking place again at 19:00 UTC. If you haven't tried Mattermost yet, please log in to chat.reactos.org now using your ReactOS.org credentials. Only then I can add you to our new private "Meeting" channel. This one will not be bridged to IRC! I will already start adding people to this channel now, so that the meeting can start on time. If you have the feeling that I forgot about you, please let me know timely. The current agenda is as follows: * Status Updates ============== As always, please have your status report ready before the meeting, so that we can get this done quickly. * Mattermost ========== I need to know your opinion about Mattermost and whether you think that we should continue using it beyond our trial (ending mid- February). This would require an enterprise license for non-profits ($250 per three years). * Google Summer of Code 2019 ========================== The list at https://reactos.org/wiki/Google_Summer_of_Code_2019 still doesn't show a single mentor. And https://reactos.org/wiki/Google_Summer_of_Code_2019_Ideas certainly also needs some polishing. Let's finally make up our minds regarding this year's GSoC, so that we can submit our project application. I would highly appreciate if people updated those Wiki pages before the meeting. This could potentially save us hours of discussions and finding volunteers :) Let me know if you want anything to be added to the agenda. Cheers, Colin

5 years, 9 months

Re: [ros-dev] Ros-dev Digest, Vol 173, Issue 5

by Adam Stachowicz

Message from chat.reactos.org: This team has reached the maximum number of allowed accounts. Contact your systems administrator to set a higher limit. Adam Stachowicz sob., 12 sty 2019, 13:00: <ros-dev-request(a)reactos.org> napisał(a): > Send Ros-dev mailing list submissions to > ros-dev(a)reactos.org > > To subscribe or unsubscribe via the World Wide Web, visit > http://reactos.org/mailman/listinfo/ros-dev > or, via email, send a message with subject or body 'help' to > ros-dev-request(a)reactos.org > > You can reach the person managing the list at > ros-dev-owner(a)reactos.org > > When replying, please edit your Subject line so it is more specific > than "Re: Contents of Ros-dev digest..." > > > Today's Topics: > > 1. Mattermost is live at chat.reactos.org! (Colin Finck) > 2. Reactos participation and Windows source leaked > (Idzwan Nizam b. Jamal) > 3. Re: Reactos participation and Windows source leaked > (Erkin Alp Güney) > > > ---------------------------------------------------------------------- > > Message: 1 > Date: Fri, 11 Jan 2019 13:56:46 +0100 > From: Colin Finck <colin(a)reactos.org> > To: 'ReactOS Development List' <ros-dev(a)reactos.org> > Subject: [ros-dev] Mattermost is live at chat.reactos.org! > Message-ID: <d18f8664-55c9-7eaa-dbcf-6161ee53cfaf(a)reactos.org> > Content-Type: text/plain; charset="utf-8" > > Hi all! > > Our own Mattermost instance is finally live at https://chat.reactos.org! > > Enjoy an infinitely searchable history, offline messages, native picture > support, push notifications, a seamless experience on web and mobile, > and more. > All privately hosted on our own infrastructure and usable with the same > ReactOS.org account you already have! > Time to say goodbye to workarounds like IRC bouncers or third-party > services :) > I believe this can really improve our communication and accelerate > development! > > To make the migration as easy as possible, I have set up a bridge > between our Freenode IRC channels and Mattermost. User "RosBridge" will > transfer all messages from #reactos / #reactos-dev to Town Square / > Development and vice-versa. Let's see how long we're going to need that. > > I hope you're all going to join the fun, so that we can already have the > next meeting in around 2 weeks on Mattermost! > > > Cheers, > > Colin > >

5 years, 9 months

Upload filters and future of ReactOS

by Erkin Alp Güney

Proposed EU copyright directive requires automated upload filters (something like YouTube ContentID) and this can cause a sharp decrease in contributions. It will also make difficult for newcomers as a significant contribution will be required for each commit, because copyright filter is costly to run. Yours, faithfully Erkin Alp

5 years, 9 months

Reactos participation and Windows source leaked

by Idzwan Nizam b. Jamal

Hello, Supposedly someone had an access and seen leaked windows source code few years ago. At the time he/she do not have any idea of the code (due to improficiency in programming and the subject) and had forgotten since about the code, does he/she allowed to contribute to ReactOS development? This is due to the following statement on the participation page (https://www.reactos.org/participation) "Getting involved with ReactOS is easy and straightforward! We only ask that you have not had access to Microsoft source code for the area you want to work on. This includes either having worked at Microsoft, obtaining the source code through an academic program or from the illegal leakage of Windows source code several years ago. Having viewed the source prevents you from contributing to avoid undermining the legality of our source code"

5 years, 9 months

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev January 2019