Ros-dev May 2019

ros-dev@reactos.org

6 participants
6 discussions

Re: [ros-dev] [ros-diffs] [reactos] 01/01: [SYSSETUP] Set registry hostname in WriteComputerSettings (#1589)
by gedmurphy.maillists＠gmail.com 29 May '19

29 May '19

+ /* Now we need to set the Hostname */ + lError = RegOpenKeyExW(HKEY_LOCAL_MACHINE, + L"SYSTEM\\CurrentControlSet\\Services\\Tcpip\\Parameters", + 0, + KEY_SET_VALUE, + &hKey); + if (lError != ERROR_SUCCESS) + { + DPRINT1("RegOpenKeyExW for Tcpip\\Parameters failed (%08lX)\n", lError); + return TRUE; Typo?

1 0

Re: [ros-dev] [ros-diffs] [reactos] 01/02: [BASESVR] Take SessionId into account while creating BNO directory
by gedmurphy.maillists＠gmail.com 08 May '19

08 May '19

Hadn't we decided to default to strsafe apis for all new code? StringCchPrintfW StringCchCopyW -----Original Message----- From: Ros-diffs <ros-diffs-bounces(a)reactos.org> On Behalf Of Pierre Schweitzer Sent: 08 May 2019 19:42 To: ros-diffs(a)reactos.org Subject: [ros-diffs] [reactos] 01/02: [BASESVR] Take SessionId into account while creating BNO directory https://git.reactos.org/?p=reactos.git;a=commitdiff;h=20f57973866eb54d3c282… commit 20f57973866eb54d3c2822a3b62a309a9983c196 Author: Pierre Schweitzer <pierre(a)reactos.org> AuthorDate: Wed May 8 20:35:31 2019 +0200 Commit: Pierre Schweitzer <pierre(a)reactos.org> CommitDate: Wed May 8 20:35:31 2019 +0200 [BASESVR] Take SessionId into account while creating BNO directory --- subsystems/win/basesrv/init.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/subsystems/win/basesrv/init.c b/subsystems/win/basesrv/init.c index ebfe937068..84b24f38db 100644 --- a/subsystems/win/basesrv/init.c +++ b/subsystems/win/basesrv/init.c @@ -353,8 +353,14 @@ BaseInitializeStaticServerData(IN PCSR_SERVER_DLL LoadedServerDll) SystemRootString.Buffer); ASSERT(Success); - /* FIXME: Check Session ID */ - wcscpy(BnoBuffer, L"\\BaseNamedObjects"); + if (SessionId != 0) + { + swprintf(BnoBuffer, L"\\Sessions\\%ld\\BaseNamedObjects", SessionId); + } + else + { + wcscpy(BnoBuffer, L"\\BaseNamedObjects"); + } RtlInitUnicodeString(&BnoString, BnoBuffer); /* Allocate the server data */ @@ -531,7 +537,7 @@ BaseInitializeStaticServerData(IN PCSR_SERVER_DLL LoadedServerDll) Status = NtCreateSymbolicLinkObject(&SymHandle, SYMBOLIC_LINK_ALL_ACCESS, &ObjectAttributes, - &SymlinkName); + &BnoString); if ((NT_SUCCESS(Status)) && SessionId == 0) NtClose(SymHandle); /* Make Session point back to BNOLINKS */

1 0

MS Console/Terminal stuff (was: "RE: Ros-dev Digest, Vol 177, Issue 2")
by Hermès BÉLUSCA-MAÏTO 08 May '19

08 May '19

Hi, I’m trying to answer point by point. 1. Their license is MIT. At least it allows us to borrow ideas from their code for how to implement stuff in ReactOS’ console/terminal. (I suppose that if one wants to copy entire chunks of code, that I wouldn’t do it, I’m not sure how the licensing of the original ReactOS console GPL code would have to change. But “I’m not a lawyer”. Anyway, copy-pasting stuff is never a good idea.) 2. Yes but again you don’t need to care. It allows us to remain “original” in our way of implementing the things. What’s now “documented” however, is the interface between condrv and conhost (and to kernel32 if my quick reading of the shared headers is correct). This is sufficient. Then the internal implementation one can write for ReactOS is left free, this allows one to have original code and note a dull copy-paste. 3. ReactOS doesn’t use C++ in the console, and won’t use ”WinRT” any time soon in its entire code-base. So forget about any direct import of the MS console code into ROS. Regards, Hermès De : Ros-dev [mailto:ros-dev-bounces@reactos.org] De la part de Biswapriyo Nath Envoyé : mardi 7 mai 2019 20:42 À : ros-dev(a)reactos.org Objet : Re: [ros-dev] Ros-dev Digest, Vol 177, Issue 2 Some queries though: 1. There are many restrictions on how the code can be used. Are developers allowed to import the idea to ReactOS? Also with a different license. 2. The half of the codebase of console subsystem implemented in KernelBase and Kernel32. Those are not open source. Also the main magic happens in ConDrv driver. 3. The project has C++/WinRT code. Does ReactOS have that section? Thank you <3

3 2

Re: [ros-dev] Ros-dev Digest, Vol 177, Issue 2
by Biswapriyo Nath 07 May '19

07 May '19

Some queries though: 1. There are many restrictions on how the code can be used. Are developers allowed to import the idea to ReactOS? Also with a different license. 2. The half of the codebase of console subsystem implemented in KernelBase and Kernel32. Those are not open source. Also the main magic happens in ConDrv driver. 3. The project has C++/WinRT code. Does ReactOS have that section? Thank you <3

1 0

Microsoft open-sources its console / terminal code! (MIT-licensed)
by Hermès BÉLUSCA-MAÏTO 07 May '19

07 May '19

Dear All, Yes you've read correctly! Microsoft released the code of its terminal + the Windows console host (conhost.exe) under MIT license at: https://github.com/microsoft/Terminal I think this is a really great move!! This can definitively help us for: * first, allowing us to improve our existing console code, * and in the future, getting our console architecture Win10-compatible (...) This also means that anybody can contribute back to their code via pull-requests, or at least creating issues. For those using Windows 10, they plan releasing official builds starting June 2019 according to their posts: https://devblogs.microsoft.com/commandline/introducing-windows-terminal/ https://www.hanselman.com/blog/ANewConsoleForWindowsItsTheOpenSourceWindowsT erminal.aspx Best, Hermès

1 0

Re: [ros-dev] [ros-diffs] [reactos] 01/01: [POWERCFG] Fix an exception that occurs when the control panel is closed.
by Thomas Faber 04 May '19

04 May '19

This fix seems odd. I thought HeapFree(NULL) was well-defined and did nothing (despite what MSDN says). Pretty sure Wine uses it everywhere. Am I missing something? On 2019-04-27 19:02, Eric Kohl wrote: > https://git.reactos.org/?p=reactos.git;a=commitdiff;h=ce218f70ec8a758ec6d40… > > commit ce218f70ec8a758ec6d4039690bae29c23289b9d > Author: Eric Kohl <eric.kohl(a)reactos.org> > AuthorDate: Sat Apr 27 19:00:33 2019 +0200 > Commit: Eric Kohl <eric.kohl(a)reactos.org> > CommitDate: Sat Apr 27 19:01:35 2019 +0200 > > [POWERCFG] Fix an exception that occurs when the control panel is closed. > --- > dll/cpl/powercfg/powershemes.c | 16 ++++++++++++---- > 1 file changed, 12 insertions(+), 4 deletions(-) > > diff --git a/dll/cpl/powercfg/powershemes.c b/dll/cpl/powercfg/powershemes.c > index 4fff28a279..7d1441a043 100644 > --- a/dll/cpl/powercfg/powershemes.c > +++ b/dll/cpl/powercfg/powershemes.c > @@ -78,8 +78,12 @@ AddPowerScheme( > dwDescription + sizeof(TCHAR)); > if (pScheme->pszName == NULL || pScheme->pszDescription == NULL) > { > - HeapFree(GetProcessHeap(), 0, pScheme->pszName); > - HeapFree(GetProcessHeap(), 0, pScheme->pszDescription); > + if (pScheme->pszName) > + HeapFree(GetProcessHeap(), 0, pScheme->pszName); > + > + if (pScheme->pszDescription) > + HeapFree(GetProcessHeap(), 0, pScheme->pszDescription); > + > HeapFree(GetProcessHeap(), 0, pScheme); > return NULL; > } > @@ -103,8 +107,12 @@ DeletePowerScheme( > { > RemoveEntryList(&pScheme->ListEntry); > > - HeapFree(GetProcessHeap(), 0, pScheme->pszName); > - HeapFree(GetProcessHeap(), 0, pScheme->pszDescription); > + if (pScheme->pszName) > + HeapFree(GetProcessHeap(), 0, pScheme->pszName); > + > + if (pScheme->pszDescription) > + HeapFree(GetProcessHeap(), 0, pScheme->pszDescription); > + > HeapFree(GetProcessHeap(), 0, pScheme); > } > >

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev May 2019