Ros-dev September 2021

ros-dev@reactos.org

4 participants
3 discussions

(no subject)
by Javier Agustìn Fernàndez Arroyo 28 Sep '21

28 Sep '21

hello guys, just detected a typo in HEAD, in device manager "HAR DDISK" instead of "HARD DISK" As this is a very stupid "bug"... should i send a report about it?

1 0

Development request
by Mohamed Atef 26 Sep '21

26 Sep '21

Hello there, We are 6 students from Egypt and now We are in our last year and We need to build a project as a graduation project. And We are interested in the area of runtime systems, operating systems and compilers. We are going to work 40-60 hrs a week Can We help with some tools you need as a graduation project given that We have a professor to mentor us. If not, Can you suggest some tools you need to build and We will work on it. The project takes one academic year Thanks

2 1

Re: [ros-dev] [ros-diffs] [reactos] 01/01: KBDHID: IOCTL_KEYBOARD_QUERY_* calls must return STATUS_BUFFER_TOO_SMALL if the output buffer is too small
by Thomas Faber 12 Sep '21

12 Sep '21

On 2021-09-12 08:34, Eric Kohl wrote: > diff --git a/drivers/hid/kbdhid/kbdhid.c b/drivers/hid/kbdhid/kbdhid.c > index bacf72a0109..b07a7d8445c 100644 > --- a/drivers/hid/kbdhid/kbdhid.c > +++ b/drivers/hid/kbdhid/kbdhid.c > @@ -444,8 +444,8 @@ KbdHid_InternalDeviceControl( > case IOCTL_KEYBOARD_QUERY_INDICATORS: > if (IoStack->Parameters.DeviceIoControl.OutputBufferLength < sizeof(KEYBOARD_INDICATOR_PARAMETERS)) > { > - /* invalid parameter */ > - Irp->IoStatus.Status = STATUS_INVALID_PARAMETER; > + /* buffer too small */ > + Irp->IoStatus.Status = STATUS_BUFFER_TOO_SMALL; > IoCompleteRequest(Irp, IO_NO_INCREMENT); > return STATUS_INVALID_PARAMETER; Shouldn't the dispatch routine's return value change accordingly in these cases? Thanks, Thomas

1 0

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev September 2021