- Ros-dev - ReactOS.org

Silence a warning reported by gcc 4.3.2 (possibly incorrectly, but it's just a stub anyway)
by Dmitry Gorbachev 30 Nov '08

30 Nov '08

Yes, incorrectly. GetTraceLoggerHandle() should return 0xFFFFFFFFFFFFFFFF if it fails, but now it returns 0xFFFFFFFF.

1 0

Re: [ros-dev] [ros-diffs] [sginsberg] 37739: - Kill off ramdrv, it is deprecated since a long time ago. See issue #3422 for more details.
by Steven Edwards 30 Nov '08

30 Nov '08

On Sat, Nov 29, 2008 at 2:35 PM, <sginsberg(a)svn.reactos.org> wrote: > Author: sginsberg > Date: Sat Nov 29 13:35:04 2008 > New Revision: 37739 > > URL: http://svn.reactos.org/svn/reactos?rev=37739&view=rev > Log: > - Kill off ramdrv, it is deprecated since a long time ago. > See issue #3422 for more details. The problem was as far as I can tell not ramdrv but ramdrv/minix. I really think you should revert part of this. -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

1 0

Re: [ros-dev] [ros-diffs] [cgutman] 37713: - Merge aicom-network-fixes up to r37712
by Aleksey Bragin 29 Nov '08

29 Nov '08

Another way of doing this (stylistically) would be: switch (Type) { case NdisWorkItemRequest: if (Adapter->NdisMiniportBlock.PendingRequest || MiniGetFirstWorkItem(Adapter, NdisWorkItemRequest)) Busy = TRUE; break case ...: } On Nov 29, 2008, at 4:51 AM, cgutman(a)svn.reactos.org wrote: > Author: cgutman > Date: Fri Nov 28 19:51:19 2008 > New Revision: 37713 > > +BOOLEAN > +MiniIsBusy( > + PLOGICAL_ADAPTER Adapter, > + NDIS_WORK_ITEM_TYPE Type) > +{ > + BOOLEAN Busy = FALSE; > + KIRQL OldIrql; > + > + KeAcquireSpinLock(&Adapter->NdisMiniportBlock.Lock, &OldIrql); > + > + if (Type == NdisWorkItemRequest && > + (Adapter->NdisMiniportBlock.PendingRequest || > MiniGetFirstWorkItem(Adapter, NdisWorkItemRequest))) > + { > + Busy = TRUE; > + } > + else if (Type == NdisWorkItemSend && > + (Adapter->NdisMiniportBlock.FirstPendingPacket || > MiniGetFirstWorkItem(Adapter, NdisWorkItemSend))) > + { > + Busy = TRUE; > + } > + else if (Type == NdisWorkItemResetRequested && > + (Adapter->NdisMiniportBlock.ResetStatus == > NDIS_STATUS_PENDING || MiniGetFirstWorkItem(Adapter, > NdisWorkItemResetRequested))) > + { > + Busy = TRUE; > + } > + > + KeReleaseSpinLock(&Adapter->NdisMiniportBlock.Lock, OldIrql); > + > + return Busy; > +}

1 0

Win32k Rewrite Status Report
by James Tabor 28 Nov '08

28 Nov '08

Hi Team! First, here is my personal list of last years goals for the rewrite. Most of you already know what I had plan for last year so please bare with me. ___ December 2007: End of previous year rewrite of definition files and structure integration with updates to ntgdibad.h. Housekeeping, test and verify. Add previous years loose ends and carryovers. Thomas help with user window handle support is a great bonus to the year end progress toward win32k rewrite. Timo win32k cross tests. Magnus integration of DDxD support is still in progress and ticking along nicely. January 2008: Miscellaneous Gdi adds, fix ups and cleanup. February 2008: Integration and implementation of Enhanced/Meta/Dc/File support. This is a wine sync/port that I have started during the beginning of the rewrite. Delayed and carryover. May 2008: Gdi/User Win32k DCE cleanup and fixes. 90% complete. One unique test case needing to be integrated in code base. June 2008: Gdi cleanup and verify testing. Integrate simple multi display support. DC and PDEV integration and cleanup. Partial DC and PDEV structures are supported and minor cleanup and testing was meant. No multi display add ons are included. Delayed and carryover. July 2008: Start prerewrite of User32/Win32k. Cleanup headers and add new types and structures. Started and carryover. September 2008: Housecleaning, Gdi testing and verifying. Still in progress. November 2008: Start User32/Win32 Menu rewrite. Still in progress, new structure support is in and working in test tree. December 2008: End of year housekeeping with cross test and verify. Add previous years loose ends and carryovers. Slow integration of known gdi structures have been completed. Attribute support is only for DC's, investigating a more conservative process of allocation and utilization of Brush/Pen /Regon and Font attribute support that is compatible with gdi. Carryover and finish up window handle and integration support. Timo started integration of user process/thread structures and support, leaving win32k initialization bug open for more investigation. Magnus DDxD is back on track. Stefan cleanup of win32 functions was completed. January 2009: Add new members to the rewrite team, start training and information exchange. Setup freelance hacker member list which would include just about everyone with commit access. -------- This is my personal list and included comments about team members progress. I'll add more after January for 2009. Side Note: Please do not post here if you are interested in joining the rewrite team. If you have commit access you are already in. We need to know your specialties, interests and goals which include what you want to learn so this can be carried into your next career. Resume stuffer for the next job and what knots. Thanks, James

1 0

Re: [ros-dev] [ros-diffs] [gschneider] 37695: Update gdi32 winetests, so we don't run out of things to fix.
by Steven Edwards 28 Nov '08

28 Nov '08

On Thu, Nov 27, 2008 at 3:52 PM, <gschneider(a)svn.reactos.org> wrote: > Author: gschneider > Date: Thu Nov 27 14:52:01 2008 > New Revision: 37695 > > URL: http://svn.reactos.org/svn/reactos?rev=37695&view=rev > Log: > Update gdi32 winetests, so we don't run out of things to fix. Best commit message ever. -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

1 0

utf-16 data (e.g. inf files)
by Matthias Kupfer 26 Nov '08

26 Nov '08

Hi folks, due to the perpetual problems with utf-16 files I recommend to change the handling in the following way as long as we don't have another working translation system (mui) and we want to keep a win32 compatible inf file: We should store the files in subversion as utf-8 and convert during make and rbuild in utf-16 (e.g. via small c-programm or new rbuild-command), so we can edit and make diffs in an easy way. Comments are very welcome Matthias -- Matthias Kupfer Telefon +49 (0) 371 236 46 52 Wilhelm-Firl-Straße 21 Mobil +49 (0) 160 859 43 54 09122 Chemnitz

5 5

Migrate ntoskrnl to PSEH 2.0
by Dmitry Gorbachev 24 Nov '08

24 Nov '08

Hi! I have a linking error because GCC-4.4 inserts calls of ___enable_execute_stack() into functions which use PSEH. It seems that this behavior cannot be changed without changing the GCC itself. Or maybe I should provide an empty ___enable_execute_stack() function just to satisfy the linker.

1 0

(no subject)
by Dmitry Gorbachev 22 Nov '08

22 Nov '08

> This is already done, most files which have Wine code are labeled so atop > of the file ("Some parts are taken from Wine project..."). What I see is > that Dmitry Timoshkov says this is not enough. It should be enough if the original copyright notices are kept. No need to research origins of every piece of code. LGPL 2.1: > 1. You may copy and distribute verbatim copies of the Library's complete > source code as you receive it, in any medium, provided that you > conspicuously and appropriately publish on each copy an appropriate > copyright notice and disclaimer of warranty; keep intact all the notices > that refer to this License and to the absence of any warranty; [...] > 2. You may modify your copy or copies of the Library or any portion of > it, thus forming a work based on the Library, and copy and distribute such > modifications or work under the terms of Section 1 above, [...] GPL-HOWTO: > If you have copied code from other programs covered by the same license, > copy their copyright notices too. Put all the copyright notices together, > right near the top of each file.

2 1

Re: [ros-dev] [ros-diffs] [sginsberg] 37523: - winternl.h is deprecated since the NDK was invented, don't use
by Steven Edwards 21 Nov '08

21 Nov '08

On Fri, Nov 21, 2008 at 2:23 PM, <sginsberg(a)svn.reactos.org> wrote: > URL: http://svn.reactos.org/svn/reactos?rev=37523&view=rev > Log: > - winternl.h is deprecated since the NDK was invented, don't use I am sure there are some wine sources somewhere that we have the make use of it but perhaps we could add some sort of check like #ifndef __WINESRC__ #error Don't use winternl.h! #endif or something similar. -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

1 0

Re: [ros-dev] FOSDEM booth/devroom sharing
by François Revol 21 Nov '08

21 Nov '08

Replying to myself... > (sent to AROS (please forward, I'm not on the dev list), ReactOS, > Syllable, CCed to Haiku) Moved from ros-general to ros-dev as the former seems very quiet... > > Hello, > I'm a Haiku developer, <http://haiku-os.org> > and I would like to propose sharing a devroom, eventually a booth at > FOSDEM with some other FOSS OS projects. As I've been told by the orga, other projects should also book the devroom officially: http://fosdem.org/2009/call_for_devrooms_and_stands Just add you are ok to share it. The official deadline is tomorrow... > > I sent to the mailing lists as I couldn't identify a specific > contact, > and I don't know how much centralized each project is. > > Last year we had our own booth at FOSDEM (we it shared with an ERP > software), > I really enjoyed the event, and would like to also get a devroom this > year. > But I'm not sure we will have enough people to animate it all the > time > (currently 3 or 4), plus we'd still have a stand to look after. > > http://www.haiku-os.org/blog/mmu_man/2008-02-25/hello_from_fosdem > > I know we shared a booth at last LinuxWorld with ReactOS and I heard > it > was interesting: > http://www.haiku-os.org/blog/umccullough/2008-08-06/day_1_at_linuxworld_200… > > http://www.haiku-os.org/blog/umccullough/2008-08-07/day_2_at_linuxworld_200… > > > As the deadline for booth and devroom application approaches (it's > before 22 nov.), I was thinking about sharing a devroom that could be > called "alternative OSes", "grep -v GNU/Linux" or alike, with other > projects. > This way we could all get a devroom with fewer people to man it. > > As for our project, we could have talks and hacking sessions on many > subjects, from architecture and design to installation, and specific > things like the using the FreePascal port, porting applications, > using > replicants (like NetSurf). > > We could also have common talks, about the platforms we support, our > design and goals. > > And if needed we could probably also share a booth with another > project > I suppose, last year we shared with a totally different software. > > I'll be mailing a booth and devroom request tomorrow precising it, > before it's too late. > > François. >

3 2

Event invitation [jornadas Imaginática 2009]
by victor martinez 20 Nov '08

20 Nov '08

Ok,marc ;) I have sent u a mail to: marc.piulach(at)live.com. Sure it will be clasified as Spam so give a look there.I have sent the email in perfect Spanish(i guess u are from Spain,or at least you understand Spanish). There are at least 2 Reacters in Seville with time to show Reactos in Imaginatica.Also some other spanish people have shown some interest to help with it. You can contact with me in vicmarcal(at)hotmail.com, so we can begin (if u want) to prepare this Event. Thanks Marc. _________________________________________________________________ Los más de lo más, Especial Rankings http://events.es.msn.com/dinero/listas/default.aspx

1 0

Re: [ros-dev] Job offer: Linux tool to create a valid Windows Registry hive file
by Chris Evans 20 Nov '08

20 Nov '08

1 0

Re: [ros-dev] Event invitation [jornadas Imaginática 2009]
by Marc Piulachs 20 Nov '08

20 Nov '08

Hi Victor, I haven't done any special "negotiations" mainly because anyone expressed interest on participating in the event. In case you or anyone else want to participate feel free to contact me and maybe we can workout something Regards, /Marc From: victor martinez Sent: Thursday, November 20, 2008 4:01 PM To: ros-dev(a)reactos.org Subject: [ros-dev] Re: Event invitation [jornadas Imaginática 2009] Hi All,I have been contacted/invited to participate and give a talk about ReactOS in an event organized by the university of Seville, spain (very beautiful city!) on 2-6 March 2009. It would be great if some of the other spanish based members are also interested on participate, I have been disconnected from the project lately due to offline life but would be willing to participate in this event and help to spread the word about reactos in academic circles.More information here (in spanish): http://imaginatica.org/2009/descargas/Dossier.pdfRegards,/MarcHi Marc, there are spanish people in Seville interested in Imaginatica Event. Does the invitation still available?How goes the "negotiations"?are they still counting on us being at Imaginatica?Thanks in advance. This event mix the most important IT companies,and also there are a lot of skilled developers.This is one of the most important Event in Spain (since SIMO has been cancelled).So being in Imaginatica must be a priority ;)VicmarcalSeville -------------------------------------------------------------------------------- No te aburras más, engánchate a los Juegos de Messenger -------------------------------------------------------------------------------- _______________________________________________ Ros-dev mailing list Ros-dev(a)reactos.org http://www.reactos.org/mailman/listinfo/ros-dev

1 0

Re: Event invitation [jornadas Imaginática 2009]
by victor martinez 20 Nov '08

20 Nov '08

Hi All, I have been contacted/invited to participate and give a talk about ReactOS in an event organized by the university of Seville, spain (very beautiful city!) on 2-6 March 2009. It would be great if some of the other spanish based members are also interested on participate, I have been disconnected from the project lately due to offline life but would be willing to participate in this event and help to spread the word about reactos in academic circles. More information here (in spanish): http://imaginatica.org/2009/descargas/Dossier.pdf Regards, /Marc Hi Marc, there are spanish people in Seville interested in Imaginatica Event. Does the invitation still available?How goes the "negotiations"?are they still counting on us being at Imaginatica? Thanks in advance. This event mix the most important IT companies,and also there are a lot of skilled developers.This is one of the most important Event in Spain (since SIMO has been cancelled). So being in Imaginatica must be a priority ;) Vicmarcal Seville _________________________________________________________________ Los más de lo más, Especial Rankings http://events.es.msn.com/dinero/listas/default.aspx

1 0

Re: [ros-dev] [ros-diffs] [cfinck] 37465: Dmitry Gorbachev - Fix compiler warnings, treated as errors due to our settings, which are emitted when using GCC 4.3.2 See issue #3849 for more details.
by Matthieu Suiche 19 Nov '08

19 Nov '08

char buf[MAX_PATH]; [...] strcat(buf, DIR_SEPARATOR_STRING); strcat(buf, source); strcat(buf, entry->d_name); I'm not sure this is really safe. -- Matthieu Suiche On Wed, Nov 19, 2008 at 8:59 PM, <cfinck(a)svn.reactos.org> wrote: > Author: cfinck > Date: Wed Nov 19 13:59:54 2008 > New Revision: 37465 > > URL: http://svn.reactos.org/svn/reactos?rev=37465&view=rev > Log: > Dmitry Gorbachev > - Fix compiler warnings, treated as errors due to our settings, which are emitted when using GCC 4.3.2 > > See issue #3849 for more details. > > Modified: > trunk/reactos/tools/cabman/cabinet.cxx > trunk/reactos/tools/cdmake/cdmake.c > trunk/reactos/tools/rgenstat/rgenstat.c > > Modified: trunk/reactos/tools/cabman/cabinet.cxx > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/tools/cabman/cabinet.cxx?r… > ============================================================================== > --- trunk/reactos/tools/cabman/cabinet.cxx [iso-8859-1] (original) > +++ trunk/reactos/tools/cabman/cabinet.cxx [iso-8859-1] Wed Nov 19 13:59:54 2008 > @@ -2055,9 +2055,19 @@ > return CAB_STATUS_CANNOT_READ; > } > > - GetFileTimes(SrcFile, FileNode); > - > - GetAttributesOnFile(FileNode); > + if (GetFileTimes(SrcFile, FileNode) != CAB_STATUS_SUCCESS) > + { > + DPRINT(MIN_TRACE, ("Cannot read file times.\n")); > + FreeMemory(NewFileName); > + return CAB_STATUS_CANNOT_READ; > + } > + > + if (GetAttributesOnFile(FileNode) != CAB_STATUS_SUCCESS) > + { > + DPRINT(MIN_TRACE, ("Cannot read file attributes.\n")); > + FreeMemory(NewFileName); > + return CAB_STATUS_CANNOT_READ; > + } > > CloseFile(SrcFile); > > @@ -3646,7 +3656,8 @@ > strcpy(buf, File->FileName); > else > { > - getcwd(buf, sizeof(buf)); > + if (!getcwd(buf, sizeof(buf))) > + return CAB_STATUS_CANNOT_READ; > strcat(buf, DIR_SEPARATOR_STRING); > strcat(buf, File->FileName); > } > @@ -3689,7 +3700,8 @@ > strcpy(buf, File->FileName); > else > { > - getcwd(buf, sizeof(buf)); > + if (!getcwd(buf, sizeof(buf))) > + return CAB_STATUS_CANNOT_READ; > strcat(buf, DIR_SEPARATOR_STRING); > strcat(buf, File->FileName); > } > > Modified: trunk/reactos/tools/cdmake/cdmake.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/tools/cdmake/cdmake.c?rev=… > ============================================================================== > --- trunk/reactos/tools/cdmake/cdmake.c [iso-8859-1] (original) > +++ trunk/reactos/tools/cdmake/cdmake.c [iso-8859-1] Wed Nov 19 13:59:54 2008 > @@ -882,7 +882,8 @@ > } > else > { > - getcwd(buf, sizeof(buf)); > + if (!getcwd(buf, sizeof(buf))) > + error_exit("Can't get CWD: %s\n", strerror(errno)); > strcat(buf, DIR_SEPARATOR_STRING); > strcat(buf, source); > strcat(buf, entry->d_name); > @@ -943,7 +944,8 @@ > } > else > { > - getcwd(buf, sizeof(buf)); > + if (!getcwd(buf, sizeof(buf))) > + error_exit("Can't get CWD: %s\n", strerror(errno)); > strcat(buf, DIR_SEPARATOR_STRING); > strcat(buf, source); > } > @@ -994,7 +996,8 @@ > } > else > { > - getcwd(buf, sizeof(buf)); > + if (!getcwd(buf, sizeof(buf))) > + error_exit("Can't get CWD: %s\n", strerror(errno)); > strcat(buf, DIR_SEPARATOR_STRING); > strcat(buf, source); > strcat(buf, entry->d_name); > > Modified: trunk/reactos/tools/rgenstat/rgenstat.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/tools/rgenstat/rgenstat.c?… > ============================================================================== > --- trunk/reactos/tools/rgenstat/rgenstat.c [iso-8859-1] (original) > +++ trunk/reactos/tools/rgenstat/rgenstat.c [iso-8859-1] Wed Nov 19 13:59:54 2008 > @@ -553,7 +553,11 @@ > } > else > { > - getcwd(buf, sizeof(buf)); > + if (!getcwd(buf, sizeof(buf))) > + { > + printf("Can't get CWD: %s\n", strerror(errno)); > + return; > + } > strcat(buf, DIR_SEPARATOR_STRING); > strcat(buf, path); > strcat(buf, entry->d_name); > @@ -611,7 +615,11 @@ > } > else > { > - getcwd(buf, sizeof(buf)); > + if (!getcwd(buf, sizeof(buf))) > + { > + printf("Can't get CWD: %s\n", strerror(errno)); > + return; > + } > strcat(buf, DIR_SEPARATOR_STRING); > strcat(buf, path); > strcat(buf, entry->d_name); > >

1 0

OpenWatcom.
by Marcin Dalecki 19 Nov '08

19 Nov '08

Has anybody considered to use the openwatcom compiler for ReactOS? http://www.openwatcom.org/index.php/Main_Page At least it provides a proper native SEH implementation and is as free as the GCC is. ➧ Marcin Dalecki ❖

1 0

Re: [ros-dev] [ros-diffs] [jimtabor] 37436: - Fixes bug 3864. While I was at it I fixed most of the gdi max bit max info sizes too. - Added notes for the SEH abuse in win32k dibobj.c. - Tested WinMerge 2.10.2, AbiWord 2.4.1, Firefox 1.5.0.3 and wine
by James Tabor 19 Nov '08

19 Nov '08

These are correct changes. On Tue, Nov 18, 2008 at 10:34 AM, Aleksey Bragin <aleksey(a)reactos.org> wrote: > May I ask why those if (!Info) checks are required? To me it makes no > sense to call those APIs with the cruicial, mandatory working (and in > one case the only) parameter being NULL, and I would put an ASSERT > (Info) there to catch bad callers and fix them. > > WBR, > Aleksey. > > On Nov 18, 2008, at 8:36 AM, jimtabor(a)svn.reactos.org wrote: > >> Author: jimtabor >> Date: Mon Nov 17 23:36:19 2008 >> New Revision: 37436 >> >> UINT >> FASTCALL >> DIB_BitmapMaxBitsSize( PBITMAPINFO Info, UINT ScanLines ) >> { >> UINT MaxBits = 0; >> + >> + if (!Info) return 0; >> >> >> +UINT >> +FASTCALL >> +DIB_BitmapBitsSize( PBITMAPINFO Info ) >> +{ >> + UINT Ret; >> + >> + if (!Info) return 0; >

2 3

[ros-diffs] [jimtabor] 37345: - Add path support for ExtTextOut.
by Dmitry Gorbachev 19 Nov '08

19 Nov '08

gedmurphy wrote: > Let's say you implement a function in our win32k, based on Wine code. How > exactly would you realistically discover which Wine dev wrote that > function, and if the function was merely _based_ on wine code, which parts > of the function would you attribute credit to, and how would you do it? I think if the dev is not known, then all authors should be credited. I.e.: "Parts of this file are Copyright (C) ... ". Or: to gather the original Wine copiright notices into a separate file and put a pointer to it in any file which is based on Wine.

3 2

Re: [ros-dev] [ros-diffs] [jimtabor] 37345: - Add path support for ExtTextOut.
by Steven Edwards 19 Nov '08

19 Nov '08

Dmitry, On Tue, Nov 18, 2008 at 2:22 AM, Dmitry Timoshkov <dmitry(a)codeweavers.com> wrote: > http://www.reactos.org/archives/public/ros-diffs/2008-November/027021.html > > Please stop copying Wine code without any copyright and source > reference into reactos. This became very bad practice from your > side during last years. I have no power with the ReactOS project other than to ask and try to get policy changed in a democratic manner. I've made the case for the ReactOS to do a better job at proper attribution in code that is imported based on feedback from you in the past. In fact, just yesterday I replied to ros-dev proposing some guidelines for how to handle code imported from Wine. There is nothing more I can do. I have CC'd Alexandre and Jeremy for there thoughts on the subject. I welcome feedback from the Software Freedom Law Center or the FSF with reguards to this issue because on one hand I understand the attribution is important but on the other hand ReactOS is persona non-grata with Wine. Given Wine's reluctance to accept any contributions from ReactOS developers, totally based on guilt by assocation I think its in your best interested not to be credited. The Software is still being released under the terms you granted so I don't see a major violation. >From the LGPL preamble: "...Also, if the library is modified by someone else and passed on, the recipients should know that what they have is not the original version, so that the original author's reputation will not be affected by problems that might be introduced by others." Clearly the ReactOS developer is doing you a favor by not hurting your reputation if ReactOS is as Toxic as Wine makes it out to be. Thanks -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

5 6

Southern California Linux Expo
by Zachary Gorden 19 Nov '08

19 Nov '08

So we've been invited to SCALE and I'm wondering whether any of the devs can actually make it. Arty is a logical choice because he's so close and we might be able to pull in some community members who are close by if we can only get one dev there. We'd get a booth on the show floor which includes table, chairs, power, ethernet drop, and 3-5 passes to the show. Are we going to be able to make it this year at all?

2 1

Re: [ros-dev] [ros-diffs] [dchapyshev] 37396: - Implement BindIoCompletionCallback, ReadFileScatter, WriteFileGather (based on Wine) - Move DnsHostnameToComputerNameA/W to computername.c
by gedmurphy 19 Nov '08

19 Nov '08

Steven has repeatedly asked for credit, and I quote: " Please add the appropriate copyright headers to the source file stating the original author when implementing code based on third party sources." Is there a reason for not doing it this time? Secondly, why are things being implemented in stubs? Thirdly, it's worth checking implementations before moving out of stubs. Just because Wine does something, doesn't mean it's correct for us. DnsHostnameToComputerName should call RtlDnsHostNameToComputerName. I stopped checking the rest of the code as soon as I read that, in case someone assumes I looked at everything. Fourthly, I'm willing to bet this email gets ignored too. Please take a little more time over commits. Ged. -----Original Message----- From: ros-diffs-bounces(a)reactos.org [mailto:ros-diffs-bounces@reactos.org] On Behalf Of dchapyshev(a)svn.reactos.org Sent: 17 November 2008 11:54 To: ros-diffs(a)reactos.org Subject: [ros-diffs] [dchapyshev] 37396: - Implement BindIoCompletionCallback, ReadFileScatter, WriteFileGather (based on Wine) - Move DnsHostnameToComputerNameA/W to computername.c Author: dchapyshev Date: Mon Nov 17 05:53:59 2008 New Revision: 37396 URL: http://svn.reactos.org/svn/reactos?rev=37396&view=rev Log: - Implement BindIoCompletionCallback, ReadFileScatter, WriteFileGather (based on Wine) - Move DnsHostnameToComputerNameA/W to computername.c Modified: trunk/reactos/dll/win32/kernel32/misc/computername.c trunk/reactos/dll/win32/kernel32/misc/stubs.c Modified: trunk/reactos/dll/win32/kernel32/misc/computername.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/kernel32/misc/co… ============================================================================== --- trunk/reactos/dll/win32/kernel32/misc/computername.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/kernel32/misc/computername.c [iso-8859-1] Mon Nov 17 05:53:59 2008 @@ -461,4 +461,73 @@ } } + +/* + * @implemented + */ +BOOL +STDCALL +DnsHostnameToComputerNameA(LPCSTR Hostname, + LPSTR ComputerName, + LPDWORD nSize) +{ + DWORD len; + + DPRINT("(%s, %p, %p)\n", Hostname, ComputerName, nSize); + + if (!Hostname || !nSize) + return FALSE; + + len = lstrlenA(Hostname); + + if (len > MAX_COMPUTERNAME_LENGTH) + len = MAX_COMPUTERNAME_LENGTH; + + if (*nSize < len) + { + *nSize = len; + return FALSE; + } + + if (!ComputerName) return FALSE; + + memcpy( ComputerName, Hostname, len ); + ComputerName[len + 1] = 0; + return TRUE; +} + + +/* + * @implemented + */ +BOOL +STDCALL +DnsHostnameToComputerNameW ( + LPCWSTR hostname, + LPWSTR computername, + LPDWORD size + ) +{ + DWORD len; + + DPRINT("(%s, %p, %p): stub\n", hostname, computername, size); + + if (!hostname || !size) return FALSE; + len = lstrlenW(hostname); + + if (len > MAX_COMPUTERNAME_LENGTH) + len = MAX_COMPUTERNAME_LENGTH; + + if (*size < len) + { + *size = len; + return FALSE; + } + if (!computername) return FALSE; + + memcpy( computername, hostname, len * sizeof(WCHAR) ); + computername[len + 1] = 0; + return TRUE; +} + /* EOF */ Modified: trunk/reactos/dll/win32/kernel32/misc/stubs.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/kernel32/misc/st… ============================================================================== --- trunk/reactos/dll/win32/kernel32/misc/stubs.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/kernel32/misc/stubs.c [iso-8859-1] Mon Nov 17 05:53:59 2008 @@ -342,18 +342,29 @@ } /* - * @unimplemented - */ -BOOL -STDCALL -BindIoCompletionCallback ( - HANDLE FileHandle, - LPOVERLAPPED_COMPLETION_ROUTINE Function, - ULONG Flags - ) -{ - STUB; - return 0; + * @implemented + */ +BOOL +STDCALL +BindIoCompletionCallback(HANDLE FileHandle, + LPOVERLAPPED_COMPLETION_ROUTINE Function, + ULONG Flags) +{ + NTSTATUS Status = 0; + + DPRINT("(%p, %p, %d)\n", FileHandle, Function, Flags); + + Status = RtlSetIoCompletionCallback(FileHandle, + (PRTL_OVERLAPPED_COMPLETION_ROUTINE) Function, + Flags); + + if (!NT_SUCCESS(Status)) + { + SetLastError(RtlNtStatusToDosError(Status)); + return FALSE; + } + + return TRUE; } /* @@ -562,20 +573,45 @@ } /* - * @unimplemented - */ -BOOL -STDCALL -ReadFileScatter( - HANDLE hFile, - FILE_SEGMENT_ELEMENT aSegmentArray[], - DWORD nNumberOfBytesToRead, - LPDWORD lpReserved, - LPOVERLAPPED lpOverlapped - ) -{ - STUB; - return 0; + * @implemented + */ +BOOL +STDCALL +ReadFileScatter(HANDLE hFile, + FILE_SEGMENT_ELEMENT aSegmentArray[], + DWORD nNumberOfBytesToRead, + LPDWORD lpReserved, + LPOVERLAPPED lpOverlapped) +{ + PIO_STATUS_BLOCK pIOStatus; + LARGE_INTEGER Offset; + NTSTATUS Status; + + DPRINT("(%p %p %u %p)\n", hFile, aSegmentArray, nNumberOfBytesToRead, lpOverlapped); + + Offset.LowPart = lpOverlapped->Offset; + Offset.HighPart = lpOverlapped->OffsetHigh; + pIOStatus = (PIO_STATUS_BLOCK) lpOverlapped; + pIOStatus->Status = STATUS_PENDING; + pIOStatus->Information = 0; + + Status = NtReadFileScatter(hFile, + NULL, + NULL, + NULL, + pIOStatus, + aSegmentArray, + nNumberOfBytesToRead, + &Offset, + NULL); + + if (!NT_SUCCESS(Status)) + { + SetLastError(RtlNtStatusToDosError(Status)); + return FALSE; + } + + return TRUE; } /* @@ -678,20 +714,45 @@ } /* - * @unimplemented - */ -BOOL -STDCALL -WriteFileGather( - HANDLE hFile, - FILE_SEGMENT_ELEMENT aSegmentArray[], - DWORD nNumberOfBytesToWrite, - LPDWORD lpReserved, - LPOVERLAPPED lpOverlapped - ) -{ - STUB; - return 0; + * @implemented + */ +BOOL +STDCALL +WriteFileGather(HANDLE hFile, + FILE_SEGMENT_ELEMENT aSegmentArray[], + DWORD nNumberOfBytesToWrite, + LPDWORD lpReserved, + LPOVERLAPPED lpOverlapped) +{ + PIO_STATUS_BLOCK IOStatus; + LARGE_INTEGER Offset; + NTSTATUS Status; + + DPRINT("%p %p %u %p\n", hFile, aSegmentArray, nNumberOfBytesToWrite, lpOverlapped); + + Offset.LowPart = lpOverlapped->Offset; + Offset.HighPart = lpOverlapped->OffsetHigh; + IOStatus = (PIO_STATUS_BLOCK) lpOverlapped; + IOStatus->Status = STATUS_PENDING; + IOStatus->Information = 0; + + Status = NtWriteFileGather(hFile, + NULL, + NULL, + NULL, + IOStatus, + aSegmentArray, + nNumberOfBytesToWrite, + &Offset, + NULL); + + if (!NT_SUCCESS(Status)) + { + SetLastError(RtlNtStatusToDosError(Status)); + return FALSE; + } + + return TRUE; } /* @@ -705,39 +766,6 @@ { STUB; return 0; -} - -/* - * @unimplemented - */ -BOOL -STDCALL -DnsHostnameToComputerNameW ( - LPCWSTR hostname, - LPWSTR computername, - LPDWORD size - ) -{ - DWORD len; - - DPRINT("(%s, %p, %p): stub\n", hostname, computername, size); - - if (!hostname || !size) return FALSE; - len = lstrlenW(hostname); - - if (len > MAX_COMPUTERNAME_LENGTH) - len = MAX_COMPUTERNAME_LENGTH; - - if (*size < len) - { - *size = len; - return FALSE; - } - if (!computername) return FALSE; - - memcpy( computername, hostname, len * sizeof(WCHAR) ); - computername[len + 1] = 0; - return TRUE; } /* @@ -919,21 +947,6 @@ /* * @unimplemented */ -BOOL -STDCALL -DnsHostnameToComputerNameA ( - LPCSTR Hostname, - LPSTR ComputerName, - LPDWORD nSize - ) -{ - STUB; - return 0; -} - -/* - * @unimplemented - */ HANDLE STDCALL FindFirstVolumeMountPointA( @@ -947,23 +960,22 @@ } /* - * @unimplemented - */ -BOOL -STDCALL -FindNextVolumeA( - HANDLE handle, - LPSTR volume, - DWORD len - ) -{ - WCHAR *buffer = HeapAlloc( GetProcessHeap(), 0, len * sizeof(WCHAR) ); + * @implemented + */ +BOOL +STDCALL +FindNextVolumeA(HANDLE handle, + LPSTR volume, + DWORD len) +{ + WCHAR *buffer = HeapAlloc(GetProcessHeap(), 0, len * sizeof(WCHAR)); BOOL ret; if ((ret = FindNextVolumeW( handle, buffer, len ))) { if (!WideCharToMultiByte( CP_ACP, 0, buffer, -1, volume, len, NULL, NULL )) ret = FALSE; } + HeapFree( GetProcessHeap(), 0, buffer ); return ret; }

4 5

Re: [ros-dev] [ros-diffs] [jimtabor] 37436: - Fixes bug 3864. While I was at it I fixed most of the gdi max bit max info sizes too. - Added notes for the SEH abuse in win32k dibobj.c. - Tested WinMerge 2.10.2, AbiWord 2.4.1, Firefox 1.5.0.3 and wine gdi32 bitmap cross test. - When testing with gdi cross test in 24 and 32 bit display mode, we have a pixel conversion mismatch. Please fix it!
by Aleksey Bragin 18 Nov '08

18 Nov '08

May I ask why those if (!Info) checks are required? To me it makes no sense to call those APIs with the cruicial, mandatory working (and in one case the only) parameter being NULL, and I would put an ASSERT (Info) there to catch bad callers and fix them. WBR, Aleksey. On Nov 18, 2008, at 8:36 AM, jimtabor(a)svn.reactos.org wrote: > Author: jimtabor > Date: Mon Nov 17 23:36:19 2008 > New Revision: 37436 > > UINT > FASTCALL > DIB_BitmapMaxBitsSize( PBITMAPINFO Info, UINT ScanLines ) > { > UINT MaxBits = 0; > + > + if (!Info) return 0; > > > +UINT > +FASTCALL > +DIB_BitmapBitsSize( PBITMAPINFO Info ) > +{ > + UINT Ret; > + > + if (!Info) return 0;

1 0

Re: [ros-dev] [ros-diffs] [tkreuzer] 37431: forgot this file
by Matthieu Suiche 18 Nov '08

18 Nov '08

+ return !!(Flags & EFLAGS_INTERRUPT_MASK); Why do you donnot use something like that instead ? return (Flags & EFLAGS_INTERRUPT_MASK) ? TRUE: FALSE; -- Matthieu Suiche On Tue, Nov 18, 2008 at 3:27 AM, <tkreuzer(a)svn.reactos.org> wrote: > Author: tkreuzer > Date: Mon Nov 17 20:27:04 2008 > New Revision: 37431 > > URL: http://svn.reactos.org/svn/reactos?rev=37431&view=rev > Log: > forgot this file > > Added: > branches/ros-amd64-bringup/reactos/ntoskrnl/ke/amd64/interrupt.c (with props) > > Added: branches/ros-amd64-bringup/reactos/ntoskrnl/ke/amd64/interrupt.c > URL: http://svn.reactos.org/svn/reactos/branches/ros-amd64-bringup/reactos/ntosk… > ============================================================================== > --- branches/ros-amd64-bringup/reactos/ntoskrnl/ke/amd64/interrupt.c (added) > +++ branches/ros-amd64-bringup/reactos/ntoskrnl/ke/amd64/interrupt.c [iso-8859-1] Mon Nov 17 20:27:04 2008 > @@ -1,0 +1,62 @@ > +/* > + * PROJECT: ReactOS Kernel > + * LICENSE: GPL - See COPYING in the top level directory > + * FILE: ntoskrnl/ke/i386/irq.c > + * PURPOSE: Manages the Kernel's IRQ support for external drivers, > + * for the purpopses of connecting, disconnecting and setting > + * up ISRs for drivers. The backend behind the Io* Interrupt > + * routines. > + * PROGRAMMERS: Timo Kreuzer (timo.kreuzer(a)web.de) > + */ > + > +/* INCLUDES *****************************************************************/ > + > +#include <ntoskrnl.h> > +#define NDEBUG > +#include <debug.h> > + > +/* FUNCTIONS ****************************************************************/ > + > + > + > +BOOLEAN > +NTAPI > +KeDisableInterrupts(VOID) > +{ > + ULONG64 Flags; > + > + /* Get the flags */ > + Flags = __readeflags(); > + > + /* Disable interrupts */ > + _disable(); > + > + return !!(Flags & EFLAGS_INTERRUPT_MASK); > +} > + > + > +BOOLEAN > +NTAPI > +KeDisconnectInterrupt(IN PKINTERRUPT Interrupt) > +{ > + UNIMPLEMENTED; > + return FALSE; > +} > + > +VOID > +NTAPI > +KeInitializeInterrupt(IN PKINTERRUPT Interrupt, > + IN PKSERVICE_ROUTINE ServiceRoutine, > + IN PVOID ServiceContext, > + IN PKSPIN_LOCK SpinLock, > + IN ULONG Vector, > + IN KIRQL Irql, > + IN KIRQL SynchronizeIrql, > + IN KINTERRUPT_MODE InterruptMode, > + IN BOOLEAN ShareVector, > + IN CHAR ProcessorNumber, > + IN BOOLEAN FloatingSave) > +{ > + UNIMPLEMENTED; > +} > + > > Propchange: branches/ros-amd64-bringup/reactos/ntoskrnl/ke/amd64/interrupt.c > ------------------------------------------------------------------------------ > svn:eol-style = native > >

1 0

Another WIDL sync, another build breakage
by Olaf Siejka 17 Nov '08

17 Nov '08

This is just getting repetitive: [WIDL] obj-i386\include\reactos\idl\lsa_c.c include\reactos\idl\lsa.idl:17: Error: NTSTATUS: redefinition error; original definition was at ( ť: 21 mingw32-make: *** [obj-i386\include\reactos\idl\lsa_c.c] Error 1 mingw32-make: *** Waiting for unfinished jobs.... [WIDL] obj-i386\include\reactos\idl\eventlogrpc_c.c include\reactos\idl\eventlogrpc.idl:7: Error: NTSTATUS: redefinition error; original definition was at Ş■.:21 mingw32-make: *** [obj-i386\include\reactos\idl\eventlogrpc_c.c] Error 1 With all due respect, Eric, would you be so kind and test your commits on more OS than your PC/buildbot???

1 0

Re: [ros-dev] [ros-diffs] [greatlrd] 37343: Bugfix : Do not link to LPDDRAWI_DIRECTDRAW_INT->lpLink when we do not have any LPDDRAWI_DIRECTDRAW_INT->lpLcl
by gedmurphy 16 Nov '08

16 Nov '08

Is it not time to start getting rid of IsBadWritePtr and friends? I don't see a good reason for these in our own code, especially when we can just use SEH directly. -----Original Message----- From: ros-diffs-bounces(a)reactos.org [mailto:ros-diffs-bounces@reactos.org] On Behalf Of greatlrd(a)svn.reactos.org Sent: 13 November 2008 19:52 To: ros-diffs(a)reactos.org Subject: [ros-diffs] [greatlrd] 37343: Bugfix : Do not link to LPDDRAWI_DIRECTDRAW_INT->lpLink when we do not have any LPDDRAWI_DIRECTDRAW_INT->lpLcl Author: greatlrd Date: Thu Nov 13 13:52:20 2008 New Revision: 37343 URL: http://svn.reactos.org/svn/reactos?rev=37343&view=rev Log: Bugfix : Do not link to LPDDRAWI_DIRECTDRAW_INT->lpLink when we do not have any LPDDRAWI_DIRECTDRAW_INT->lpLcl Modified: branches/reactx/reactos/dll/directx/ddraw/startup.c Modified: branches/reactx/reactos/dll/directx/ddraw/startup.c URL: http://svn.reactos.org/svn/reactos/branches/reactx/reactos/dll/directx/ddra… ============================================================================== --- branches/reactx/reactos/dll/directx/ddraw/startup.c [iso-8859-1] (original) +++ branches/reactx/reactos/dll/directx/ddraw/startup.c [iso-8859-1] Thu Nov 13 13:52:20 2008 @@ -33,8 +33,8 @@ This = (LPDDRAWI_DIRECTDRAW_INT)*pIface; - /* fixme linking too second link when we shall not doing it */ - if (IsBadReadPtr(This,sizeof(LPDIRECTDRAW))) + if ( (IsBadWritePtr(This,sizeof(LPDDRAWI_DIRECTDRAW_INT)) != 0) || + (IsBadWritePtr(This->lpLcl,sizeof(LPDDRAWI_DIRECTDRAW_LCL)) != 0) ) { /* We do not have a DirectDraw interface, we need alloc it*/ LPDDRAWI_DIRECTDRAW_INT memThis;

5 5

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev