- Ros-dev - ReactOS.org

Re: [ros-dev] [ros-diffs] [sginsberg] 35600: - Remove KEBUGCHECK and KEBUGCHECKEX macros - Replace "KeBugCheck(0)" by ASSERT(FALSE) - Replace deprecated "CPRINT" by DRINT1

by Hervé Poussineau

sginsberg(a)svn.reactos.org a écrit : > Author: sginsberg > Date: Sun Aug 24 10:48:05 2008 > New Revision: 35600 > > URL: http://svn.reactos.org/svn/reactos?rev=35600&view=rev > Log: > - Remove KEBUGCHECK and KEBUGCHECKEX macros > - Replace "KeBugCheck(0)" by ASSERT(FALSE) > - Replace deprecated "CPRINT" by DRINT1 > You probably understand that KEBUGCHECK(0) is *NOT* the same as ASSERT(FALSE) ASSERT(FALSE) is valid only in debug mode, and lets the code continue in release mode. KEBUGCHECK stops the execution also in release mode. For example, in ntoskrnl/dbgk/dbgkobj.c, code now continues even if DbgkpQueueMessage failed. Are you sure it is safe to continue in that case? (same question applies for other locations) Hervé

17 years

2
1
0 0

- In IoAcquire/ReleaseCancelSpinLock, use the queued "IopCancelSpinLock" instead of a ros-specific "CancelSpinLock" standard spinlock - Misc fixes

by Stefan Ginsberg

In the kernel, stdcall IoCallDriver is macroed to the fastcall IofCallDriver. However, for clarification I think that IoCallDriver should be used, and this is what we do everywhere else. >Why this? >> ====================================================================== >> --- trunk/reactos/ntoskrnl/io/iomgr/iofunc.c [iso-8859-1] (original) >> +++ trunk/reactos/ntoskrnl/io/iomgr/iofunc.c [iso-8859-1] Sat Aug 23 >> 11:30:14 2008 >> @@ -682,7 +682,7 @@ >> StackPtr->FileObject = FileObject; >> >> /* Call the Driver */ >> - return IofCallDriver(DeviceObject, Irp); >> + return IoCallDriver(DeviceObject, Irp); >> } >> >> /* >> @@ -732,7 +732,7 @@ >> StackPtr->FileObject = FileObject; >> >> /* Call the Driver */ >> - return IofCallDriver(DeviceObject, Irp); >> + return IoCallDriver(DeviceObject, Irp); >> } >> >> _________________________________________________________________ Discover the new Windows Vista http://search.msn.com/results.aspx?q=windows+vista&mkt=en-US&form=QBRE

17 years

1
0
0 0

Re: [ros-dev] [ros-diffs] [arty] 35581: Catch failure to release the cancel spinlock. Would've spotted my error in tcpip.sys.

by Alex Ionescu

--- Please, please, don't think I'm trying to say "revert this!" --- There are dozens (if not more) places in the kernel where such checks could/should be made. I believe the more correct approach instead of adding them to every function, is to use a similar framework to Microsoft's Driver Verifier, where such functions are hooked and wrapped through similar verifications. I'm not saying this particular assert should be removed, I'm just letting people know that if there's going to be major work on this -- there's a better way. Just my 2c. On 23-Aug-08, at 4:04 PM, arty(a)svn.reactos.org wrote: > Author: arty > Date: Sat Aug 23 18:04:15 2008 > New Revision: 35581 > > URL: http://svn.reactos.org/svn/reactos?rev=35581&view=rev > Log: > Catch failure to release the cancel spinlock. Would've spotted my > error in > tcpip.sys. > > Modified: > trunk/reactos/ntoskrnl/io/iomgr/irp.c > > Modified: trunk/reactos/ntoskrnl/io/iomgr/irp.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/io/iomgr/irp.c?re… > = > = > = > = > = > = > = > = > ====================================================================== > --- trunk/reactos/ntoskrnl/io/iomgr/irp.c [iso-8859-1] (original) > +++ trunk/reactos/ntoskrnl/io/iomgr/irp.c [iso-8859-1] Sat Aug 23 > 18:04:15 2008 > @@ -970,12 +970,14 @@ > IoCancelIrp(IN PIRP Irp) > { > KIRQL OldIrql; > + KIRQL IrqlAtEntry; > PDRIVER_CANCEL CancelRoutine; > IOTRACE(IO_IRP_DEBUG, > "%s - Canceling IRP %p\n", > __FUNCTION__, > Irp); > ASSERT(Irp->Type == IO_TYPE_IRP); > + IrqlAtEntry = KeGetCurrentIrql(); > > /* Acquire the cancel lock and cancel the IRP */ > IoAcquireCancelSpinLock(&OldIrql); > @@ -999,6 +1001,7 @@ > /* Set the cancel IRQL And call the routine */ > Irp->CancelIrql = OldIrql; > CancelRoutine(IoGetCurrentIrpStackLocation(Irp)- > >DeviceObject, Irp); > + ASSERT(IrqlAtEntry == KeGetCurrentIrql()); > return TRUE; > } > > Best regards, Alex Ionescu

17 years

1
0
0 0

Re: [ros-dev] [ros-diffs] [sginsberg] 35565: - In IoAcquire/ReleaseCancelSpinLock, use the queued "IopCancelSpinLock" instead of a ros-specific "CancelSpinLock" standard spinlock - Misc fixes

by Alex Ionescu

Please don't write formatting fixes as "Misc Fixes". It's a pain for reviewers who expect actual functionality fixes, and also for changelog writers, which will try to understand what exactly you fixed. Furthermore, such formatting patches should have [FORMATTING] attached to them. And finally, formatting patches should not be mixed with code patches. I know you're new to trunk, but perhaps you should read over the rules first. I appreciate your patches, but you have a bit of a cowboy attitude with your commits, which is bound to hurt someone in the end. On 23-Aug-08, at 9:30 AM, sginsberg(a)svn.reactos.org wrote: > Author: sginsberg > Date: Sat Aug 23 11:30:14 2008 > New Revision: 35565 > > URL: http://svn.reactos.org/svn/reactos?rev=35565&view=rev > Log: > - In IoAcquire/ReleaseCancelSpinLock, use the queued > "IopCancelSpinLock" instead of a ros-specific "CancelSpinLock" > standard spinlock > - Misc fixes > > Modified: > trunk/reactos/ntoskrnl/io/iomgr/error.c > trunk/reactos/ntoskrnl/io/iomgr/iofunc.c > trunk/reactos/ntoskrnl/io/iomgr/iomgr.c > trunk/reactos/ntoskrnl/io/iomgr/irp.c > trunk/reactos/ntoskrnl/io/iomgr/util.c > > Modified: trunk/reactos/ntoskrnl/io/iomgr/error.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/io/iomgr/error.c?… > = > = > = > = > = > = > = > = > ====================================================================== > --- trunk/reactos/ntoskrnl/io/iomgr/error.c [iso-8859-1] (original) > +++ trunk/reactos/ntoskrnl/io/iomgr/error.c [iso-8859-1] Sat Aug 23 > 11:30:14 2008 > @@ -122,7 +122,7 @@ > NULL); > if (NT_SUCCESS(Status)) > { > - /* Remmeber we're connected */ > + /* Remember we're connected */ > IopLogPortConnected = TRUE; > return TRUE; > } > @@ -583,7 +583,7 @@ > KeAcquireSpinLock(&IopLogListLock, &Irql); > InsertHeadList(&IopErrorLogListHead, &LogEntry->ListEntry); > > - /* Check if the worker is runnign */ > + /* Check if the worker is running */ > if (!IopLogWorkerRunning) > { > #if 0 > @@ -648,7 +648,7 @@ > IN PKTHREAD Thread) > { > UNIMPLEMENTED; > - return(FALSE); > + return FALSE; > } > > /* > @@ -659,14 +659,12 @@ > IoSetThreadHardErrorMode(IN BOOLEAN HardErrorEnabled) > { > PETHREAD Thread = PsGetCurrentThread(); > - BOOLEAN Old; > + BOOLEAN OldMode; > > /* Get the current value */ > - Old = !Thread->HardErrorsAreDisabled; > + OldMode = !Thread->HardErrorsAreDisabled; > > /* Set the new one and return the old */ > Thread->HardErrorsAreDisabled = !HardErrorEnabled; > - return Old; > -} > - > -/* EOF */ > + return OldMode; > +} > > Modified: trunk/reactos/ntoskrnl/io/iomgr/iofunc.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/io/iomgr/iofunc.c… > = > = > = > = > = > = > = > = > ====================================================================== > --- trunk/reactos/ntoskrnl/io/iomgr/iofunc.c [iso-8859-1] (original) > +++ trunk/reactos/ntoskrnl/io/iomgr/iofunc.c [iso-8859-1] Sat Aug 23 > 11:30:14 2008 > @@ -682,7 +682,7 @@ > StackPtr->FileObject = FileObject; > > /* Call the Driver */ > - return IofCallDriver(DeviceObject, Irp); > + return IoCallDriver(DeviceObject, Irp); > } > > /* > @@ -732,7 +732,7 @@ > StackPtr->FileObject = FileObject; > > /* Call the Driver */ > - return IofCallDriver(DeviceObject, Irp); > + return IoCallDriver(DeviceObject, Irp); > } > > /* > @@ -776,7 +776,7 @@ > } > > /* > - * @unimplemented > + * @implemented > */ > NTSTATUS > NTAPI > @@ -2045,7 +2045,7 @@ > CapturedByteOffset = FileObject->CurrentByteOffset; > } > > - /* Rememer we are sync */ > + /* Remember we are sync */ > Synchronous = TRUE; > } > else if (!(ByteOffset) && > @@ -2904,7 +2904,7 @@ > CapturedByteOffset = FileObject->CurrentByteOffset; > } > > - /* Rememer we are sync */ > + /* Remember we are sync */ > Synchronous = TRUE; > } > else if (!(ByteOffset) && > > Modified: trunk/reactos/ntoskrnl/io/iomgr/iomgr.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/io/iomgr/iomgr.c?… > = > = > = > = > = > = > = > = > ====================================================================== > --- trunk/reactos/ntoskrnl/io/iomgr/iomgr.c [iso-8859-1] (original) > +++ trunk/reactos/ntoskrnl/io/iomgr/iomgr.c [iso-8859-1] Sat Aug 23 > 11:30:14 2008 > @@ -68,7 +68,6 @@ > extern LIST_ENTRY IopTimerQueueHead; > extern KDPC IopTimerDpc; > extern KTIMER IopTimer; > -extern KSPIN_LOCK CancelSpinLock; > extern KSPIN_LOCK IoVpbLock; > extern KSPIN_LOCK IoStatisticsLock; > extern KSPIN_LOCK DriverReinitListLock; > @@ -463,7 +462,6 @@ > InitializeListHead(&LastChanceShutdownListHead); > InitializeListHead(&FsChangeNotifyListHead); > InitializeListHead(&IopErrorLogListHead); > - KeInitializeSpinLock(&CancelSpinLock); > KeInitializeSpinLock(&IoVpbLock); > KeInitializeSpinLock(&IoStatisticsLock); > KeInitializeSpinLock(&DriverReinitListLock); > > Modified: trunk/reactos/ntoskrnl/io/iomgr/irp.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/io/iomgr/irp.c?re… > = > = > = > = > = > = > = > = > ====================================================================== > --- trunk/reactos/ntoskrnl/io/iomgr/irp.c [iso-8859-1] (original) > +++ trunk/reactos/ntoskrnl/io/iomgr/irp.c [iso-8859-1] Sat Aug 23 > 11:30:14 2008 > @@ -1,8 +1,7 @@ > - > /* > * PROJECT: ReactOS Kernel > * LICENSE: GPL - See COPYING in the top level directory > - * FILE: ntoskrnl/io/irp.c > + * FILE: ntoskrnl/io/iomgr/irp.c > * PURPOSE: IRP Handling Functions > * PROGRAMMERS: Alex Ionescu (alex.ionescu(a)reactos.org) > * Gunnar Dalsnes > @@ -627,7 +626,7 @@ > > /* Allocate IRP */ > Irp = IoAllocateIrp(DeviceObject->StackSize, FALSE); > - if (!Irp) return Irp; > + if (!Irp) return NULL; > > /* Get the Stack */ > StackPtr = IoGetNextIrpStackLocation(Irp); > @@ -731,7 +730,7 @@ > Irp->UserIosb = IoStatusBlock; > Irp->Tail.Overlay.Thread = PsGetCurrentThread(); > > - /* Set the Status Block after all is done */ > + /* Return the IRP */ > IOTRACE(IO_IRP_DEBUG, > "%s - Built IRP %p with Major, Buffer, DO %lx %p %p\n", > __FUNCTION__, > @@ -763,7 +762,7 @@ > > /* Allocate IRP */ > Irp = IoAllocateIrp(DeviceObject->StackSize, FALSE); > - if (!Irp) return Irp; > + if (!Irp) return NULL; > > /* Get the Stack */ > StackPtr = IoGetNextIrpStackLocation(Irp); > @@ -857,6 +856,7 @@ > } > else > { > + /* Clear the flags */ > Irp->Flags = 0; > } > > @@ -1058,7 +1058,12 @@ > * Don't stay here forever if some broken driver doesn't > complete > * the IRP. > */ > - if (!(Retries--)) IopRemoveThreadIrp(); > + if (!(Retries--)) > + { > + /* Print out a message and remove the IRP */ > + DPRINT1("Broken driver did not complete!\n"); > + IopRemoveThreadIrp(); > + } > > /* Raise the IRQL Again */ > KeRaiseIrql(APC_LEVEL, &OldIrql); > @@ -1076,7 +1081,7 @@ > IoCallDriver(IN PDEVICE_OBJECT DeviceObject, > IN PIRP Irp) > { > - /* Call fast call */ > + /* Call fastcall */ > return IofCallDriver(DeviceObject, Irp); > } > > @@ -1112,7 +1117,7 @@ > IN PIRP Irp) > { > PDRIVER_OBJECT DriverObject; > - PIO_STACK_LOCATION Param; > + PIO_STACK_LOCATION StackPtr; > > /* Get the Driver Object */ > DriverObject = DeviceObject->DriverObject; > @@ -1126,15 +1131,15 @@ > } > > /* Now update the stack location */ > - Param = IoGetNextIrpStackLocation(Irp); > - Irp->Tail.Overlay.CurrentStackLocation = Param; > + StackPtr = IoGetNextIrpStackLocation(Irp); > + Irp->Tail.Overlay.CurrentStackLocation = StackPtr; > > /* Get the Device Object */ > - Param->DeviceObject = DeviceObject; > + StackPtr->DeviceObject = DeviceObject; > > /* Call it */ > - return DriverObject->MajorFunction[Param->MajorFunction] > (DeviceObject, > - Irp); > + return DriverObject->MajorFunction[StackPtr->MajorFunction] > (DeviceObject, > + Irp); > } > > FORCEINLINE > @@ -1417,10 +1422,9 @@ > > NTSTATUS > NTAPI > -IopSynchronousCompletion( > - IN PDEVICE_OBJECT DeviceObject, > - IN PIRP Irp, > - IN PVOID Context) > +IopSynchronousCompletion(IN PDEVICE_OBJECT DeviceObject, > + IN PIRP Irp, > + IN PVOID Context) > { > if (Irp->PendingReturned) > KeSetEvent((PKEVENT)Context, IO_NO_INCREMENT, FALSE); > @@ -1464,6 +1468,7 @@ > KeWaitForSingleObject(&Event, Suspended, KernelMode, FALSE, > NULL); > } > > + /* Return success */ > return TRUE; > } > > @@ -1550,10 +1555,12 @@ > /* > * @implemented > */ > -PEPROCESS NTAPI > +PEPROCESS > +NTAPI > IoGetRequestorProcess(IN PIRP Irp) > { > - return(Irp->Tail.Overlay.Thread->ThreadsProcess); > + /* Return the requestor process */ > + return Irp->Tail.Overlay.Thread->ThreadsProcess; > } > > /* > @@ -1563,6 +1570,7 @@ > NTAPI > IoGetRequestorProcessId(IN PIRP Irp) > { > + /* Return the requestor process' id */ > return (ULONG)(IoGetRequestorProcess(Irp)->UniqueProcessId); > } > > @@ -1586,6 +1594,7 @@ > NTAPI > IoGetTopLevelIrp(VOID) > { > + /* Return the IRP */ > return (PIRP)PsGetCurrentThread()->TopLevelIrp; > } > > @@ -1736,5 +1745,3 @@ > /* Set the IRP */ > PsGetCurrentThread()->TopLevelIrp = (ULONG)Irp; > } > - > -/* EOF */ > > Modified: trunk/reactos/ntoskrnl/io/iomgr/util.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/io/iomgr/util.c?r… > = > = > = > = > = > = > = > = > ====================================================================== > --- trunk/reactos/ntoskrnl/io/iomgr/util.c [iso-8859-1] (original) > +++ trunk/reactos/ntoskrnl/io/iomgr/util.c [iso-8859-1] Sat Aug 23 > 11:30:14 2008 > @@ -1,9 +1,11 @@ > /* > * PROJECT: ReactOS Kernel > * LICENSE: GPL - See COPYING in the top level directory > - * FILE: ntoskrnl/io/util.c > + * FILE: ntoskrnl/io/iomgr/util.c > * PURPOSE: I/O Utility Functions > - * PROGRAMMERS: <UNKNOWN> > + * PROGRAMMERS: Alex Ionescu (alex.ionescu(a)reactos.org) > + * Aleksey Bragin (aleksey(a)reactos.org) > + * Daniel Zimmerman (netzimme(a)aim.com) > */ > > /* INCLUDES > *****************************************************************/ > @@ -17,10 +19,6 @@ > RtlpGetStackLimits(PULONG_PTR StackBase, > PULONG_PTR StackLimit); > > -/* DATA > **********************************************************************/ > - > -KSPIN_LOCK CancelSpinLock; > - > /* FUNCTIONS > *****************************************************************/ > > /* > @@ -28,10 +26,10 @@ > */ > VOID > NTAPI > -IoAcquireCancelSpinLock(PKIRQL Irql) > +IoAcquireCancelSpinLock(OUT PKIRQL Irql) > { > /* Just acquire the internal lock */ > - KeAcquireSpinLock(&CancelSpinLock,Irql); > + *Irql = KeAcquireQueuedSpinLock(LockQueueIoCancelLock); > } > > /* > @@ -113,6 +111,7 @@ > NTAPI > IoGetCurrentProcess(VOID) > { > + /* Return the current thread's process */ > return (PEPROCESS)PsGetCurrentThread()->Tcb.ApcState.Process; > } > > @@ -121,10 +120,10 @@ > */ > VOID > NTAPI > -IoReleaseCancelSpinLock(KIRQL Irql) > +IoReleaseCancelSpinLock(IN KIRQL Irql) > { > /* Release the internal lock */ > - KeReleaseSpinLock(&CancelSpinLock,Irql); > + KeReleaseQueuedSpinLock(LockQueueIoCancelLock, Irql); > } > > /* > @@ -315,4 +314,3 @@ > UNIMPLEMENTED; > return STATUS_NOT_IMPLEMENTED; > } > -/* EOF */ > Best regards, Alex Ionescu

17 years

2
1
0 0

Re: [ros-dev] [ros-diffs] [tkreuzer] 35518: Implement KiSystemStartup in C instead of asm, implement KiSwapStack intrinsic, get rid of KiSetupStackandInitializeKernel, instead do the work in KiSystemStartupReal in C. Move Stack definitions into trap.S and get rid of the whole boot.S file. Comment out the sync loop for the moment and add a comment why it doesn't work (InterlockedBitTestAndSet64 doesn't work correctly).

by Thomas Bluemel

Calling from KiSwapStack from C seems quite scary. C doesn't know anything about you messing with the stack, so any subsequent code may still refer to a now invalid stack. There's a reason this was implemented in asm... tkreuzer(a)svn.reactos.org wrote: > Author: tkreuzer > Date: Thu Aug 21 16:16:57 2008 > New Revision: 35518 > > URL: http://svn.reactos.org/svn/reactos?rev=35518&view=rev > Log: > Implement KiSystemStartup in C instead of asm, implement KiSwapStack intrinsic, get rid of KiSetupStackandInitializeKernel, instead do the work in KiSystemStartupReal in C. Move Stack definitions into trap.S and get rid of the whole boot.S file. Comment out the sync loop for the moment and add a comment why it doesn't work (InterlockedBitTestAndSet64 doesn't work correctly). > > Removed: > branches/ros-amd64-bringup/reactos/ntoskrnl/ke/amd64/boot.S > Modified: > branches/ros-amd64-bringup/reactos/ntoskrnl/include/internal/amd64/intrin_i.h > branches/ros-amd64-bringup/reactos/ntoskrnl/ke/amd64/kiinit.c > branches/ros-amd64-bringup/reactos/ntoskrnl/ke/amd64/trap.S > branches/ros-amd64-bringup/reactos/ntoskrnl/ntoskrnl-amd64hack.rbuild > > Modified: branches/ros-amd64-bringup/reactos/ntoskrnl/include/internal/amd64/intrin_i.h > URL: http://svn.reactos.org/svn/reactos/branches/ros-amd64-bringup/reactos/ntosk… > ============================================================================== > --- branches/ros-amd64-bringup/reactos/ntoskrnl/include/internal/amd64/intrin_i.h [iso-8859-1] (original) > +++ branches/ros-amd64-bringup/reactos/ntoskrnl/include/internal/amd64/intrin_i.h [iso-8859-1] Thu Aug 21 16:16:57 2008 > @@ -10,6 +10,17 @@ > #define KeSetCurrentIrql(x) __writecr8(x) > > #if defined(__GNUC__) > + > +ULONG64 > +FORCEINLINE > +KiSwapStack(ULONG64 NewStack) > +{ > + ULONG64 OldStack; > + asm volatile ("movq %%rsp, %[oldstack]\n movq %[newstack], %%rsp\n" > + : [oldstack] "=rm" (OldStack) > + : [newstack] "rm" (NewStack)); > + return OldStack; > +} > > #define Ke386SetInterruptDescriptorTable(X) \ > __asm__("lidt %0\n\t" \ > > Removed: branches/ros-amd64-bringup/reactos/ntoskrnl/ke/amd64/boot.S > URL: http://svn.reactos.org/svn/reactos/branches/ros-amd64-bringup/reactos/ntosk… > ============================================================================== > --- branches/ros-amd64-bringup/reactos/ntoskrnl/ke/amd64/boot.S [iso-8859-1] (original) > +++ branches/ros-amd64-bringup/reactos/ntoskrnl/ke/amd64/boot.S (removed) > @@ -1,86 +1,0 @@ > -/* > - * FILE: ntoskrnl/ke/i386/boot.S > - * COPYRIGHT: See COPYING in the top level directory > - * PURPOSE: FreeLDR Wrapper Bootstrap Code and Bootstrap Trampoline > - * PROGRAMMERs: Alex Ionescu (alex(a)relsoft.net) > - * Thomas Weidenmueller <w3seek(a)reactos.org> > - */ > - > -/* INCLUDES ******************************************************************/ > - > -#include <asm.h> > -.intel_syntax noprefix > -.code64 > - > -/* GLOBALS *******************************************************************/ > - > -.bss > -.align 16 > - > -/* Kernel Boot Stack */ > -.globl _P0BootStack > -.space KERNEL_STACK_SIZE > -_P0BootStack: > - > -/* Kernel Double-Fault and Temporary DPC Stack */ > -.globl _KiDoubleFaultStack > -.space KERNEL_STACK_SIZE > -_KiDoubleFaultStack: > - > -/* FUNCTIONS *****************************************************************/ > -.global _KiSystemStartup > -.text > -.func KiSystemStartup > -_KiSystemStartup: > - > - /* NTLDR Boot: Call the main kernel initialization */ > - test rcx, 0x80000000 > - jnz _KiSystemStartupReal > - > - /* FREELDR Boot: Cal the FreeLDR wrapper */ > - jmp _KiRosPrepareForSystemStartup > -.endfunc > - > -/** > - * VOID > - * KiSetupStackAndInitializeKernel( > - * esp+4 = ? -> rcx > - * esp+8 = ? -> rdx > - * PVOID pNewstack // esp+12 = new stack -> r8 > - * esp+16 -> r9 > - * esp+20 -> rsp + 8 > - * esp+24 -> rsp + 16? > - */ > -.globl _KiSetupStackAndInitializeKernel > -.func KiSetupStackAndInitializeKernel > -_KiSetupStackAndInitializeKernel: > - > - /* Save current stack */ > - mov rsi, rsp > - > - /* Setup the new stack */ > - mov rsp, r8 > - sub rsp, NPX_FRAME_LENGTH + KTRAP_FRAME_ALIGN + KTRAP_FRAME_LENGTH > - push CR0_EM + CR0_TS + CR0_MP > - > - /* Copy stack parameters to the new stack */ > - push [rsi + 16] > - push [rsi + 8] > - xor rbp, rbp > - call _KiInitializeKernel > - > - /* Set the priority of this thread to 0 */ > - mov rbx, PCR[KPCR_CURRENT_THREAD] > - mov byte ptr [rbx+KTHREAD_PRIORITY], 0 > - > - /* Force interrupts enabled and lower IRQL back to DISPATCH_LEVEL */ > - sti > - mov rcx, DISPATCH_LEVEL > - mov cr8, rcx > - > - /* Set the right wait IRQL */ > - mov byte ptr [rbx+KTHREAD_WAIT_IRQL], DISPATCH_LEVEL; > - > - /* Jump into the idle loop */ > - jmp _KiIdleLoop > -.endfunc > > Modified: branches/ros-amd64-bringup/reactos/ntoskrnl/ke/amd64/kiinit.c > URL: http://svn.reactos.org/svn/reactos/branches/ros-amd64-bringup/reactos/ntosk… > ============================================================================== > --- branches/ros-amd64-bringup/reactos/ntoskrnl/ke/amd64/kiinit.c [iso-8859-1] (original) > +++ branches/ros-amd64-bringup/reactos/ntoskrnl/ke/amd64/kiinit.c [iso-8859-1] Thu Aug 21 16:16:57 2008 > @@ -366,6 +366,7 @@ > > /* Start us out at PASSIVE_LEVEL */ > // Pcr->Irql = PASSIVE_LEVEL; > + KeSetCurrentIrql(PASSIVE_LEVEL); > > /* Set the GDI, IDT, TSS and DPC Stack */ > Pcr->GdtBase = (PVOID)Gdt; > @@ -386,6 +387,7 @@ > IN CCHAR Number, > IN PLOADER_PARAMETER_BLOCK LoaderBlock) > { > + FrLdrDbgPrint("Enter KiInitializeKernel\n"); > #if 0 > BOOLEAN NpxPresent; > ULONG FeatureBits; > @@ -642,6 +644,17 @@ > (ULONG64)TssSelector.BaseUpper << 32); > } > > +// Hack > +VOID KiRosPrepareForSystemStartup(ULONG, PROS_LOADER_PARAMETER_BLOCK); > + > +VOID > +NTAPI > +KiSystemStartup(IN ULONG_PTR Dummy, > + IN PROS_LOADER_PARAMETER_BLOCK LoaderBlock) > +{ > + KiRosPrepareForSystemStartup(Dummy, LoaderBlock); > +} > + > VOID > NTAPI > KiSystemStartupReal(IN PLOADER_PARAMETER_BLOCK LoaderBlock) > @@ -740,13 +753,15 @@ > // RtlCopyMemory(&Idt[8], &DoubleFaultEntry, sizeof(KIDTENTRY)); > } > > - > +#if 0 // FIXME: InterlockedBitTestAndSet64 is broken! It needs to be specified > + // that it should reference an absolute address! > /* Loop until we can release the freeze lock */ > do > { > /* Loop until execution can continue */ > while (*(volatile PKSPIN_LOCK*)&KiFreezeExecutionLock == (PVOID)1); > - } while(InterlockedBitTestAndSet((PLONG)&KiFreezeExecutionLock, 0)); > + } while(InterlockedBitTestAndSet64((PLONG64)&KiFreezeExecutionLock, 0)); > +#endif > > /* Setup CPU-related fields */ > Pcr->Prcb.Number = Cpu; > @@ -773,16 +788,29 @@ > KfRaiseIrql(HIGH_LEVEL); > > /* Align stack and make space for the trap frame and NPX frame */ > - InitialStack &= ~(KTRAP_FRAME_ALIGN - 1); > - > -FrLdrDbgPrint("Before KiSetupStackAndInitializeKernel\n"); > -for(;;); > - > - /* Switch to new kernel stack and start kernel bootstrapping */ > - KiSetupStackAndInitializeKernel(&KiInitialProcess.Pcb, > - InitialThread, > - (PVOID)InitialStack, > - &Pcr->Prcb, > - (CCHAR)Cpu, > - KeLoaderBlock); > + InitialStack &= ~(16 - 1); > + > + /* Switch to new kernel Stack */ > + KiSwapStack(InitialStack); > + > + /* Initialize kernel */ > + KiInitializeKernel(&KiInitialProcess.Pcb, > + InitialThread, > + (PVOID)InitialStack, > + &Pcr->Prcb, > + (CCHAR)Cpu, > + KeLoaderBlock); > + > + /* Set the priority of this thread to 0 */ > + InitialThread->Priority = 0; > + > + /* Force interrupts enabled and lower IRQL back to DISPATCH_LEVEL */ > + _enable(); > + KeLowerIrql(DISPATCH_LEVEL); > + > + /* Set the right wait IRQL */ > + InitialThread->WaitIrql = DISPATCH_LEVEL; > + > + /* Jump into the idle loop */ > + KiIdleLoop(); > } > > Modified: branches/ros-amd64-bringup/reactos/ntoskrnl/ke/amd64/trap.S > URL: http://svn.reactos.org/svn/reactos/branches/ros-amd64-bringup/reactos/ntosk… > ============================================================================== > --- branches/ros-amd64-bringup/reactos/ntoskrnl/ke/amd64/trap.S [iso-8859-1] (original) > +++ branches/ros-amd64-bringup/reactos/ntoskrnl/ke/amd64/trap.S [iso-8859-1] Thu Aug 21 16:16:57 2008 > @@ -13,7 +13,22 @@ > .intel_syntax noprefix > .code64 > > +#define KERNEL_STACK_SIZE 0x6000 > + > /* GLOBALS *******************************************************************/ > + > +.bss > +.align 16 > + > +/* Kernel Boot Stack */ > +.globl _P0BootStack > +.space KERNEL_STACK_SIZE > +_P0BootStack: > + > +/* Kernel Double-Fault and Temporary DPC Stack */ > +.globl _KiDoubleFaultStack > +.space KERNEL_STACK_SIZE > +_KiDoubleFaultStack: > > .data > > > Modified: branches/ros-amd64-bringup/reactos/ntoskrnl/ntoskrnl-amd64hack.rbuild > URL: http://svn.reactos.org/svn/reactos/branches/ros-amd64-bringup/reactos/ntosk… > ============================================================================== > --- branches/ros-amd64-bringup/reactos/ntoskrnl/ntoskrnl-amd64hack.rbuild [iso-8859-1] (original) > +++ branches/ros-amd64-bringup/reactos/ntoskrnl/ntoskrnl-amd64hack.rbuild [iso-8859-1] Thu Aug 21 16:16:57 2008 > @@ -90,7 +90,6 @@ > </if> > <if property="ARCH" value="amd64"> > <directory name="amd64"> > - <file first="true">boot.S</file> > <file>cpu.c</file> > <file>except.c</file> > <file>irql.c</file> > >

17 years

2
1
0 0

Re : Ros-dev Digest, Vol 48, Issue 14

by Sylvain Petreolle

Feel free to open a bug. ----- Message d'origine ---- De : Olaf Siejka <caemyr(a)gmail.com> À : ros-dev(a)reactos.org Envoyé le : Jeudi, 21 Août 2008, 22h47mn 20s Objet : Re: [ros-dev] Ros-dev Digest, Vol 48, Issue 14 Not to mention that makex is not 100% functional, for example i cannot perform makex depends or even makex bootcd on a clean tree. I have to first do make depends, then makex bootcd. 2008/8/21 <ros-dev-request(a)reactos.org> Send Ros-dev mailing list submissions to ros-dev(a)reactos.org To subscribe or unsubscribe via the World Wide Web, visit http://www.reactos.org/mailman/listinfo/ros-dev or, via email, send a message with subject or body 'help' to ros-dev-request(a)reactos.org You can reach the person managing the list at ros-dev-owner(a)reactos.org When replying, please edit your Subject line so it is more specific than "Re: Contents of Ros-dev digest..." Today's Topics: 1. Re: [ros-diffs] [dreimer] 35473: make automatically behaves like makex when there is more then one CPU Core now. makex kept for now to keep compatible. (gedmurphy) 2. Re: [ros-diffs] [dreimer] 35473: make automatically behaves like makex when there is more then one CPU Core now. makex kept for now to keep compatible. (Timo Kreuzer) 3. Re: [ros-diffs] [dreimer] 35473: make automatically behaves like makex when there is more then one CPU Core now. makex kept for now to keep compatible. (Colin Finck) 4. Has anyone given any thought to coding so that the OS can use the GPU (Matthew Therault) 5. Re: Has anyone given any thought to coding so that the OS can use the GPU (Steven Edwards) 6. Re: [ros-diffs] [dreimer] 35473: make automatically behaves like makex when there is more then one CPU Core now. makex kept for now to keep compatible. (Aleksey Bragin) ---------------------------------------------------------------------- Message: 1 Date: Wed, 20 Aug 2008 12:59:42 +0100 From: "gedmurphy" <gedmurphy(a)gmail.com> Subject: Re: [ros-dev] [ros-diffs] [dreimer] 35473: make automatically behaves like makex when there is more then one CPU Core now. makex kept for now to keep compatible. To: <ros-dev(a)reactos.org> Message-ID: <000f01c902bc$3ea137f0$bbe3a7d0$@com> Content-Type: text/plain; charset="utf-8" I don't want make to consume both CPU's. Ged. -----Original Message----- From: ros-diffs-bounces(a)reactos.org [mailto:ros-diffs-bounces@reactos.org] On Behalf Of dreimer(a)svn.reactos.org Sent: 20 August 2008 10:10 To: ros-diffs(a)reactos.org Subject: [ros-diffs] [dreimer] 35473: make automatically behaves like makex when there is more then one CPU Core now. makex kept for now to keep compatible. Author: dreimer Date: Wed Aug 20 04:10:07 2008 New Revision: 35473 URL: http://svn.reactos.org/svn/reactos?rev=35473&view=rev Log: make automatically behaves like makex when there is more then one CPU Core now. makex kept for now to keep compatible. Modified: trunk/tools/RosBE/RosBE-Windows/Root/Build.cmd trunk/tools/RosBE/RosBE-Windows/Root/RosBE.mac

17 years

1
0
0 0

Re: [ros-dev] Ros-dev Digest, Vol 48, Issue 14

by Olaf Siejka

Not to mention that makex is not 100% functional, for example i cannot perform makex depends or even makex bootcd on a clean tree. I have to first do make depends, then makex bootcd. 2008/8/21 <ros-dev-request(a)reactos.org> > Send Ros-dev mailing list submissions to > ros-dev(a)reactos.org > > To subscribe or unsubscribe via the World Wide Web, visit > http://www.reactos.org/mailman/listinfo/ros-dev > or, via email, send a message with subject or body 'help' to > ros-dev-request(a)reactos.org > > You can reach the person managing the list at > ros-dev-owner(a)reactos.org > > When replying, please edit your Subject line so it is more specific > than "Re: Contents of Ros-dev digest..." > > > Today's Topics: > > 1. Re: [ros-diffs] [dreimer] 35473: make automatically behaves > like makex when there is more then one CPU Core now. makex kept > for now to keep compatible. (gedmurphy) > 2. Re: [ros-diffs] [dreimer] 35473: make automatically behaves > like makex when there is more then one CPU Core now. makex kept > for now to keep compatible. (Timo Kreuzer) > 3. Re: [ros-diffs] [dreimer] 35473: make automatically behaves > like makex when there is more then one CPU Core now. makex kept > for now to keep compatible. (Colin Finck) > 4. Has anyone given any thought to coding so that the OS can use > the GPU (Matthew Therault) > 5. Re: Has anyone given any thought to coding so that the OS can > use the GPU (Steven Edwards) > 6. Re: [ros-diffs] [dreimer] 35473: make automatically behaves > like makex when there is more then one CPU Core now. makex kept > for now to keep compatible. (Aleksey Bragin) > > > ---------------------------------------------------------------------- > > Message: 1 > Date: Wed, 20 Aug 2008 12:59:42 +0100 > From: "gedmurphy" <gedmurphy(a)gmail.com> > Subject: Re: [ros-dev] [ros-diffs] [dreimer] 35473: make automatically > behaves like makex when there is more then one CPU Core now. > makex > kept for now to keep compatible. > To: <ros-dev(a)reactos.org> > Message-ID: <000f01c902bc$3ea137f0$bbe3a7d0$@com> > Content-Type: text/plain; charset="utf-8" > > I don't want make to consume both CPU's. > > Ged. > > -----Original Message----- > From: ros-diffs-bounces(a)reactos.org [mailto:ros-diffs-bounces@reactos.org] > On Behalf Of dreimer(a)svn.reactos.org > Sent: 20 August 2008 10:10 > To: ros-diffs(a)reactos.org > Subject: [ros-diffs] [dreimer] 35473: make automatically behaves like makex > when there is more then one CPU Core now. makex kept for now to keep > compatible. > > Author: dreimer > Date: Wed Aug 20 04:10:07 2008 > New Revision: 35473 > > URL: http://svn.reactos.org/svn/reactos?rev=35473&view=rev > Log: > make automatically behaves like makex when there is more then one CPU Core > now. makex kept for now to keep compatible. > > Modified: > trunk/tools/RosBE/RosBE-Windows/Root/Build.cmd > trunk/tools/RosBE/RosBE-Windows/Root/RosBE.mac

17 years

2
1
0 0

Re: [ros-dev] [ros-diffs] [dreimer] 35473: make automatically behaves like makex when there is more then one CPU Core now. makex kept for now to keep compatible.

by gedmurphy

I don't want make to consume both CPU's. Ged. -----Original Message----- From: ros-diffs-bounces(a)reactos.org [mailto:ros-diffs-bounces@reactos.org] On Behalf Of dreimer(a)svn.reactos.org Sent: 20 August 2008 10:10 To: ros-diffs(a)reactos.org Subject: [ros-diffs] [dreimer] 35473: make automatically behaves like makex when there is more then one CPU Core now. makex kept for now to keep compatible. Author: dreimer Date: Wed Aug 20 04:10:07 2008 New Revision: 35473 URL: http://svn.reactos.org/svn/reactos?rev=35473&view=rev Log: make automatically behaves like makex when there is more then one CPU Core now. makex kept for now to keep compatible. Modified: trunk/tools/RosBE/RosBE-Windows/Root/Build.cmd trunk/tools/RosBE/RosBE-Windows/Root/RosBE.mac Modified: trunk/tools/RosBE/RosBE-Windows/Root/Build.cmd URL: http://svn.reactos.org/svn/reactos/trunk/tools/RosBE/RosBE-Windows/Root/Bui… ============================================================================== --- trunk/tools/RosBE/RosBE-Windows/Root/Build.cmd [iso-8859-1] (original) +++ trunk/tools/RosBE/RosBE-Windows/Root/Build.cmd [iso-8859-1] Wed Aug 20 04:10:07 2008 @@ -103,11 +103,20 @@ ) :: +:: Get the number of CPUs in the system so we know how many jobs to execute. +:: To modify the number used alter the options used with cpucount: +:: No Option - Number of CPUs. +:: -x1 - Number of CPUs, plus 1. +:: -x2 - Number of CPUs, doubled. +:: -a - Determine the cpu count based on the inherited process affinity mask. +:: +for /f "usebackq" %%i in (`"%_ROSBE_BASEDIR%\Tools\cpucount.exe" -x1`) do set CPUCOUNT=%%i +:: :: Check if we are using -j or not. :: -if "%1" == "multi" ( - if not "%2" == "" ( - title 'makex %2' parallel build started: %TIMERAW% +if %CPUCOUNT% GTR 2 ( + if not "%1" == "" ( + title 'makex %1' parallel build started: %TIMERAW% ) else ( title 'makex' parallel build started: %TIMERAW% ) @@ -139,27 +148,17 @@ goto :EOF :BUILDMULTI - :: - :: Get the number of CPUs in the system so we know how many jobs to execute. - :: To modify the number used alter the options used with cpucount: - :: No Option - Number of CPUs. - :: -x1 - Number of CPUs, plus 1. - :: -x2 - Number of CPUs, doubled. - :: -a - Determine the cpu count based on the inherited process affinity mask. - :: - for /f "usebackq" %%i in (`"%_ROSBE_BASEDIR%\Tools\cpucount.exe" -x1`) do set CPUCOUNT=%%i - if %_ROSBE_SHOWTIME% == 1 ( if %_ROSBE_WRITELOG% == 1 ( - "%_ROSBE_BASEDIR%\Tools\buildtime.exe" "%_ROSBE_MINGWMAKE%" -j %CPUCOUNT% %2 %3 %4 %5 %6 %7 %8 %9 2>&1 | "%_ROSBE_BASEDIR%\Tools\tee.exe" "%_ROSBE_LOGDIR%\BuildLog-%_ROSBE_GCCVERSION%-%DATENAME%-%TIMENAME%.txt" + "%_ROSBE_BASEDIR%\Tools\buildtime.exe" "%_ROSBE_MINGWMAKE%" -j %CPUCOUNT% %* 2>&1 | "%_ROSBE_BASEDIR%\Tools\tee.exe" "%_ROSBE_LOGDIR%\BuildLog-%_ROSBE_GCCVERSION%-%DATENAME%-%TIMENAME%.txt" ) else ( - "%_ROSBE_BASEDIR%\Tools\buildtime.exe" "%_ROSBE_MINGWMAKE%" -j %CPUCOUNT% %2 %3 %4 %5 %6 %7 %8 %9 + "%_ROSBE_BASEDIR%\Tools\buildtime.exe" "%_ROSBE_MINGWMAKE%" -j %CPUCOUNT% %* ) ) else ( if %_ROSBE_WRITELOG% == 1 ( - "%_ROSBE_MINGWMAKE%" -j %CPUCOUNT% %2 %3 %4 %5 %6 %7 %8 %9 2>&1 | "%_ROSBE_BASEDIR%\Tools\tee.exe" "%_ROSBE_LOGDIR%\BuildLog-%_ROSBE_GCCVERSION%-%DATENAME%-%TIMENAME%.txt" + "%_ROSBE_MINGWMAKE%" -j %CPUCOUNT% %* 2>&1 | "%_ROSBE_BASEDIR%\Tools\tee.exe" "%_ROSBE_LOGDIR%\BuildLog-%_ROSBE_GCCVERSION%-%DATENAME%-%TIMENAME%.txt" ) else ( - "%_ROSBE_MINGWMAKE%" -j %CPUCOUNT% %2 %3 %4 %5 %6 %7 %8 %9 + "%_ROSBE_MINGWMAKE%" -j %CPUCOUNT% %* ) ) goto :EOF Modified: trunk/tools/RosBE/RosBE-Windows/Root/RosBE.mac URL: http://svn.reactos.org/svn/reactos/trunk/tools/RosBE/RosBE-Windows/Root/Ros… ============================================================================== --- trunk/tools/RosBE/RosBE-Windows/Root/RosBE.mac [iso-8859-1] (original) +++ trunk/tools/RosBE/RosBE-Windows/Root/RosBE.mac [iso-8859-1] Wed Aug 20 04:10:07 2008 @@ -7,7 +7,7 @@ ENV = set HELP = "%_ROSBE_BASEDIR%\Help.cmd" $* MAKE = "%_ROSBE_BASEDIR%\Build.cmd" $* -MAKEX = "%_ROSBE_BASEDIR%\Build.cmd" multi $* +MAKEX = "%_ROSBE_BASEDIR%\Build.cmd" $* RADDR2LINE = "%_ROSBE_BASEDIR%\reladdr2line.cmd" $* RENV = for /f "usebackq tokens=*" %i in (`set _ROSBE_`) do @echo %i SCUT = "%_ROSBE_BASEDIR%\scut.cmd" $*

17 years

4
3
0 0

Has anyone given any thought to coding so that the OS can use the GPU

by Matthew Therault

Just a random thought wondering if anyone else has thought about it. They are making great strides into how the GPU can now be used as a processor. -- Two men walk into a bar....... Third one ducks.... Think about it, it will come to you. :P

17 years

2
1
0 0

Re: [ros-dev] [ros-diffs] [tkreuzer] 35458: Move some architecture specific code from KiRosPrepareForSystemStartup into KiArchInitSystem, defined for each architecture. Enable KiRosBuildReservedMemoryMap for _M_AMD64

by Alex Ionescu

Please rename the function to KiFreeLdrHackKiArchHackHack or something like that, and move it away from cpu.c, somewhere like i386/freeldr.c to make clear that this function has NOTHING TO DO with how NT should boot and is a hack because FreeLDR is a piece of shit that nobody seems to want to fix. On 19-Aug-08, at 12:07 PM, tkreuzer(a)svn.reactos.org wrote: > Author: tkreuzer > Date: Tue Aug 19 14:07:13 2008 > New Revision: 35458 > > URL: http://svn.reactos.org/svn/reactos?rev=35458&view=rev > Log: > Move some architecture specific code from > KiRosPrepareForSystemStartup into KiArchInitSystem, defined for each > architecture. Enable KiRosBuildReservedMemoryMap for _M_AMD64 > > Modified: > branches/ros-amd64-bringup/reactos/ntoskrnl/ke/freeldr.c > branches/ros-amd64-bringup/reactos/ntoskrnl/ke/i386/cpu.c > branches/ros-amd64-bringup/reactos/ntoskrnl/ke/powerpc/cpu.c > > Modified: branches/ros-amd64-bringup/reactos/ntoskrnl/ke/freeldr.c > URL: http://svn.reactos.org/svn/reactos/branches/ros-amd64-bringup/reactos/ntosk… > = > = > = > = > = > = > = > = > ====================================================================== > --- branches/ros-amd64-bringup/reactos/ntoskrnl/ke/freeldr.c > [iso-8859-1] (original) > +++ branches/ros-amd64-bringup/reactos/ntoskrnl/ke/freeldr.c > [iso-8859-1] Tue Aug 19 14:07:13 2008 > @@ -949,7 +949,7 @@ > /* Build entries for ReactOS memory ranges, which uses ARC > Descriptors */ > KiRosBuildOsMemoryMap(); > > -#ifdef _M_IX86 > +#if defined(_M_IX86) || defined(_M_AMD64) > /* Build entries for the reserved map, which uses ARC > Descriptors */ > KiRosBuildReservedMemoryMap(); > #endif > @@ -1266,42 +1266,15 @@ > { > PLOADER_PARAMETER_BLOCK NtLoaderBlock; > ULONG size, i = 0, *ent; > -#if defined(_M_IX86) > - PKTSS Tss; > - PKGDTENTRY TssEntry; > - > - /* Load the GDT and IDT */ > - > Ke386SetGlobalDescriptorTable(*(PKDESCRIPTOR)&KiGdtDescriptor.Limit); > - > Ke386SetInterruptDescriptorTable > (*(PKDESCRIPTOR)&KiIdtDescriptor.Limit); > - > - /* Initialize the boot TSS */ > - Tss = &KiBootTss; > - TssEntry = &KiBootGdt[KGDT_TSS / sizeof(KGDTENTRY)]; > - TssEntry->HighWord.Bits.Type = I386_TSS; > - TssEntry->HighWord.Bits.Pres = 1; > - TssEntry->HighWord.Bits.Dpl = 0; > - TssEntry->BaseLow = (USHORT)((ULONG_PTR)Tss & 0xFFFF); > - TssEntry->HighWord.Bytes.BaseMid = (UCHAR)((ULONG_PTR)Tss >> 16); > - TssEntry->HighWord.Bytes.BaseHi = (UCHAR)((ULONG_PTR)Tss >> 24); > -#endif > - > -#if defined(_M_PPC) > - // Zero bats. We might have residual bats set that will > interfere with > - // our mapping of ofwldr. > - for (i = 0; i < 4; i++) > - { > - SetBat(i, 0, 0, 0); SetBat(i, 1, 0, 0); > - } > - KiSetupSyscallHandler(); > - DbgPrint("Kernel Power (%08x)\n", LoaderBlock); > - DbgPrint("ArchExtra (%08x)!\n", LoaderBlock->ArchExtra); > -#endif > > /* Save pointer to ROS Block */ > KeRosLoaderBlock = LoaderBlock; > > /* Get debugging function */ > FrLdrDbgPrint = LoaderBlock->FrLdrDbgPrint; > + > + /* Per architecture initialisazion code */ > + KiArchInitSystem(); > > /* Save memory manager data */ > KeMemoryMapRangeCount = 0; > > Modified: branches/ros-amd64-bringup/reactos/ntoskrnl/ke/i386/cpu.c > URL: http://svn.reactos.org/svn/reactos/branches/ros-amd64-bringup/reactos/ntosk… > = > = > = > = > = > = > = > = > ====================================================================== > --- branches/ros-amd64-bringup/reactos/ntoskrnl/ke/i386/cpu.c > [iso-8859-1] (original) > +++ branches/ros-amd64-bringup/reactos/ntoskrnl/ke/i386/cpu.c > [iso-8859-1] Tue Aug 19 14:07:13 2008 > @@ -1036,3 +1036,24 @@ > /* Capture the control state */ > KiSaveProcessorControlState(State); > } > + > +VOID > +KiArchInitSystem() > +{ > + PKTSS Tss; > + PKGDTENTRY TssEntry; > + > + /* Load the GDT and IDT */ > + > Ke386SetGlobalDescriptorTable(*(PKDESCRIPTOR)&KiGdtDescriptor.Limit); > + > Ke386SetInterruptDescriptorTable > (*(PKDESCRIPTOR)&KiIdtDescriptor.Limit); > + > + /* Initialize the boot TSS */ > + Tss = &KiBootTss; > + TssEntry = &KiBootGdt[KGDT_TSS / sizeof(KGDTENTRY)]; > + TssEntry->HighWord.Bits.Type = I386_TSS; > + TssEntry->HighWord.Bits.Pres = 1; > + TssEntry->HighWord.Bits.Dpl = 0; > + TssEntry->BaseLow = (USHORT)((ULONG_PTR)Tss & 0xFFFF); > + TssEntry->HighWord.Bytes.BaseMid = (UCHAR)((ULONG_PTR)Tss >> 16); > + TssEntry->HighWord.Bytes.BaseHi = (UCHAR)((ULONG_PTR)Tss >> 24); > +} > > Modified: branches/ros-amd64-bringup/reactos/ntoskrnl/ke/powerpc/cpu.c > URL: http://svn.reactos.org/svn/reactos/branches/ros-amd64-bringup/reactos/ntosk… > = > = > = > = > = > = > = > = > ====================================================================== > --- branches/ros-amd64-bringup/reactos/ntoskrnl/ke/powerpc/cpu.c > [iso-8859-1] (original) > +++ branches/ros-amd64-bringup/reactos/ntoskrnl/ke/powerpc/cpu.c > [iso-8859-1] Tue Aug 19 14:07:13 2008 > @@ -275,3 +275,19 @@ > /* Capture the control state */ > KiSaveProcessorControlState(State); > } > + > +VOID > +KiArchInitSystem() > +{ > + ULONG i; > + > + // Zero bats. We might have residual bats set that will > interfere with > + // our mapping of ofwldr. > + for (i = 0; i < 4; i++) > + { > + SetBat(i, 0, 0, 0); SetBat(i, 1, 0, 0); > + } > + KiSetupSyscallHandler(); > + DbgPrint("Kernel Power (%08x)\n", KeRosLoaderBlock); > + DbgPrint("ArchExtra (%08x)!\n", KeRosLoaderBlock->ArchExtra); > +} > Best regards, Alex Ionescu

17 years

1
0
0 0

Re: [ros-dev] [ros-diffs] [cfinck] 34290: Remove the strsafe library, it was imported from a dubious source, which is incompatible with the LGPL

by Gregor Gullwi

I know this is an old changelist, but do we have any plans on re-implementing this lib by hand? -Gregor cfinck(a)svn.reactos.org wrote: > Author: cfinck > Date: Fri Jul 4 03:24:37 2008 > New Revision: 34290 > > URL: http://svn.reactos.org/svn/reactos?rev=34290&view=rev > Log: > Remove the strsafe library, it was imported from a dubious source, which is incompatible with the LGPL > > Removed: > trunk/reactos/include/psdk/strsafe.h > trunk/reactos/lib/sdk/strsafe/ > Modified: > trunk/reactos/lib/sdk/sdk.rbuild > > Removed: trunk/reactos/include/psdk/strsafe.h > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/psdk/strsafe.h?rev… > ============================================================================== > --- trunk/reactos/include/psdk/strsafe.h [iso-8859-1] (original) > +++ trunk/reactos/include/psdk/strsafe.h (removed) > @@ -1,454 +1,0 @@ > -/* > - * STRSAFE > - * > - * Copyright 2007 Dmitry Chapyshev <dmitry(a)reactos.org> > - * > - * This library is free software; you can redistribute it and/or > - * modify it under the terms of the GNU Lesser General Public > - * License as published by the Free Software Foundation; either > - * version 2.1 of the License, or (at your option) any later version. > - * > - * This library is distributed in the hope that it will be useful, > - * but WITHOUT ANY WARRANTY; without even the implied warranty of > - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > - * Lesser General Public License for more details. > - * > - * You should have received a copy of the GNU Lesser General Public > - * License along with this library; if not, write to the Free Software > - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA > - */ > -#ifndef _STRSAFE_H_INCLUDED_ > -#define _STRSAFE_H_INCLUDED_ > - > -#ifdef __cplusplus > -#define _STRSAFE_EXTERN_C extern "C" > -extern "C" { > -#else > -#define _STRSAFE_EXTERN_C extern > -#endif > - > -#include <string.h> > -#include <stdarg.h> > -#include <stdio.h> > -#include <windows.h> > - > -#define STRSAFE_INLINE_API __inline HRESULT __stdcall > -#define STRSAFEAPI _STRSAFE_EXTERN_C HRESULT __stdcall > - > -#ifndef _NTSTRSAFE_H_INCLUDED_ > - > -#define STRSAFE_MAX_CCH 2147483647 > - > -#define STRSAFE_FILL_BEHIND_NULL 0x00000200 > -#define STRSAFE_IGNORE_NULLS 0x00000100 > -#define STRSAFE_FILL_ON_FAILURE 0x00000400 > -#define STRSAFE_NULL_ON_FAILURE 0x00000800 > -#define STRSAFE_NO_TRUNCATION 0x00001000 > -#define STRSAFE_IGNORE_NULL_UNICODE_STRINGS 0x00010000 > -#define STRSAFE_UNICODE_STRING_DEST_NULL_TERMINATED 0x00020000 > - > -#define STRSAFE_VALID_FLAGS (0x000000FF | STRSAFE_IGNORE_NULLS | STRSAFE_FILL_BEHIND_NULL | STRSAFE_FILL_ON_FAILURE | STRSAFE_NULL_ON_FAILURE | STRSAFE_NO_TRUNCATION) > -#define STRSAFE_UNICODE_STRING_VALID_FLAGS (STRSAFE_VALID_FLAGS | STRSAFE_IGNORE_NULL_UNICODE_STRINGS | STRSAFE_UNICODE_STRING_DEST_NULL_TERMINATED) > -#define STRSAFE_FILL_BYTE(x) ((unsigned long)((x & 0x000000FF) | STRSAFE_FILL_BEHIND_NULL)) > -#define STRSAFE_FAILURE_BYTE(x) ((unsigned long)((x & 0x000000FF) | STRSAFE_FILL_ON_FAILURE)) > -#define STRSAFE_GET_FILL_PATTERN(dwFlags) ((int)(dwFlags & 0x000000FF)) > - > -#endif /* _NTSTRSAFE_H_INCLUDED_ */ > - > -#define STRSAFE_E_INSUFFICIENT_BUFFER ((HRESULT)0x8007007AL) > -#define STRSAFE_E_INVALID_PARAMETER ((HRESULT)0x80070057L) > -#define STRSAFE_E_END_OF_FILE ((HRESULT)0x80070026L) > - > -#ifndef STRSAFE_NO_CCH_FUNCTIONS > -STRSAFEAPI > -StringCchCatA(LPTSTR pszDest, > - size_t cchDest, > - LPCTSTR pszSrc); > - > -STRSAFEAPI > -StringCchCatW(LPWSTR pszDest, > - size_t cchDest, > - LPCWSTR pszSrc); > - > -STRSAFEAPI > -StringCchCatExA(LPTSTR pszDest, > - size_t cchDest, > - LPCTSTR pszSrc, > - LPTSTR *ppszDestEnd, > - size_t* pcchRemaining, > - unsigned long dwFlags); > - > -STRSAFEAPI > -StringCchCatExW(LPWSTR pszDest, > - size_t cchDest, > - LPCWSTR pszSrc, > - LPWSTR *ppszDestEnd, > - size_t* pcchRemaining, > - unsigned long dwFlags); > - > -STRSAFEAPI > -StringCchCatNA(LPTSTR pszDest, > - size_t cchDest, > - LPCTSTR pszSrc, > - size_t cchMaxAppend); > - > -STRSAFEAPI > -StringCchCatNW(LPWSTR pszDest, > - size_t cchDest, > - LPCWSTR pszSrc, > - size_t cchMaxAppend); > - > -STRSAFEAPI > -StringCchCatNExA(LPTSTR pszDest, > - size_t cchDest, > - LPCTSTR pszSrc, > - size_t cchMaxAppend, > - LPTSTR *ppszDestEnd, > - size_t* pcchRemaining, > - unsigned long dwFlags); > - > -STRSAFEAPI > -StringCchCatNExW(LPWSTR pszDest, > - size_t cchDest, > - LPCWSTR pszSrc, > - size_t cchMaxAppend, > - LPWSTR *ppszDestEnd, > - size_t* pcchRemaining, > - unsigned long dwFlags); > - > -STRSAFEAPI > -StringCchCopyA(LPTSTR pszDest, > - size_t cchDest, > - LPCTSTR pszSrc); > - > -STRSAFEAPI > -StringCchCopyW(LPWSTR pszDest, > - size_t cchDest, > - LPCWSTR pszSrc); > - > -STRSAFEAPI > -StringCchCopyExA(LPTSTR pszDest, > - size_t cchDest, > - LPCTSTR pszSrc, > - LPTSTR *ppszDestEnd, > - size_t* pcchRemaining, > - unsigned long dwFlags); > - > -STRSAFEAPI > -StringCchCopyExW(LPWSTR pszDest, > - size_t cchDest, > - LPCWSTR pszSrc, > - LPWSTR *ppszDestEnd, > - size_t* pcchRemaining, > - unsigned long dwFlags); > - > -STRSAFEAPI > -StringCchCopyNA(LPTSTR pszDest, > - size_t cchDest, > - LPCTSTR pszSrc, > - size_t cchSrc); > - > -STRSAFEAPI > -StringCchCopyNW(LPWSTR pszDest, > - size_t cchDest, > - LPCWSTR pszSrc, > - size_t cchSrc); > - > -STRSAFEAPI > -StringCchCopyNExA(LPTSTR pszDest, > - size_t cchDest, > - LPCTSTR pszSrc, > - size_t cchSrc, > - LPTSTR *ppszDestEnd, > - size_t* pcchRemaining, > - unsigned long dwFlags); > - > -STRSAFEAPI > -StringCchCopyNExW(LPWSTR pszDest, > - size_t cchDest, > - LPCWSTR pszSrc, > - size_t cchSrc, > - LPWSTR *ppszDestEnd, > - size_t* pcchRemaining, > - unsigned long dwFlags); > - > -STRSAFE_INLINE_API > -StringCchGetsA(LPTSTR pszDest, > - size_t cchDest); > - > -STRSAFE_INLINE_API > -StringCchGetsW(LPWSTR pszDest, > - size_t cchDest); > - > -STRSAFE_INLINE_API > -StringCchGetsExA(LPTSTR pszDest, > - size_t cchDest, > - LPTSTR *ppszDestEnd, > - size_t* pcchRemaining, > - unsigned long dwFlags); > - > -STRSAFE_INLINE_API > -StringCchGetsExW(LPWSTR pszDest, > - size_t cchDest, > - LPWSTR *ppszDestEnd, > - size_t* pcchRemaining, > - unsigned long dwFlags); > - > -STRSAFEAPI > -StringCchVPrintfA(LPTSTR pszDest, > - size_t cchDest, > - LPCTSTR pszFormat, > - va_list argList); > - > -STRSAFEAPI > -StringCchVPrintfW(LPWSTR pszDest, > - size_t cchDest, > - LPCWSTR pszFormat, > - va_list argList); > - > -STRSAFEAPI > -StringCchVPrintfExA(LPTSTR pszDest, > - size_t cchDest, > - LPTSTR *ppszDestEnd, > - size_t* pcchRemaining, > - unsigned long dwFlags, > - LPCTSTR pszFormat, > - va_list argList); > - > -STRSAFEAPI > -StringCchVPrintfExW(LPWSTR pszDest, > - size_t cchDest, > - LPWSTR *ppszDestEnd, > - size_t* pcchRemaining, > - unsigned long dwFlags, > - LPCWSTR pszFormat, > - va_list argList); > - > -STRSAFEAPI > -StringCchLengthA(LPCTSTR psz, > - size_t cchMax, > - size_t* pcch); > - > -STRSAFEAPI > -StringCchLengthW(LPCWSTR psz, > - size_t cchMax, > - size_t* pcch); > -#endif /* STRSAFE_NO_CCH_FUNCTIONS */ > - > -/* CB */ > -#ifndef STRSAFE_NO_CB_FUNCTIONS > -STRSAFEAPI > -StringCbCatA(LPTSTR pszDest, > - size_t cbDest, > - LPCTSTR pszSrc); > - > -STRSAFEAPI > -StringCbCatW(LPWSTR pszDest, > - size_t cbDest, > - LPCWSTR pszSrc); > - > -STRSAFEAPI > -StringCbCatExA(LPTSTR pszDest, > - size_t cbDest, > - LPCTSTR pszSrc, > - LPTSTR *ppszDestEnd, > - size_t* pcbRemaining, > - unsigned long dwFlags); > - > -STRSAFEAPI > -StringCbCatExW(LPWSTR pszDest, > - size_t cbDest, > - LPCWSTR pszSrc, > - LPWSTR *ppszDestEnd, > - size_t* pcbRemaining, > - unsigned long dwFlags); > - > -STRSAFEAPI > -StringCbCopyA(LPTSTR pszDest, > - size_t cbDest, > - LPCTSTR pszSrc); > - > -STRSAFEAPI > -StringCbCopyW(LPWSTR pszDest, > - size_t cbDest, > - LPCWSTR pszSrc); > - > -STRSAFEAPI > -StringCbCopyExA(LPTSTR pszDest, > - size_t cbDest, > - LPCTSTR pszSrc, > - LPTSTR *ppszDestEnd, > - size_t* pcbRemaining, > - unsigned long dwFlags); > - > -STRSAFEAPI > -StringCbCopyExW(LPWSTR pszDest, > - size_t cbDest, > - LPCWSTR pszSrc, > - LPWSTR *ppszDestEnd, > - size_t* pcbRemaining, > - unsigned long dwFlags); > - > -STRSAFEAPI > -StringCbCopyNA(LPTSTR pszDest, > - size_t cbDest, > - LPCTSTR pszSrc, > - size_t cbSrc); > - > -STRSAFEAPI > -StringCbCopyNW(LPWSTR pszDest, > - size_t cbDest, > - LPCWSTR pszSrc, > - size_t cbSrc); > - > -STRSAFEAPI > -StringCbCopyNExA(LPTSTR pszDest, > - size_t cbDest, > - LPCTSTR pszSrc, > - size_t cbSrc, > - LPTSTR *ppszDestEnd, > - size_t* pcbRemaining, > - unsigned long dwFlags); > - > -STRSAFEAPI > -StringCbCopyNExW(LPWSTR pszDest, > - size_t cbDest, > - LPCWSTR pszSrc, > - size_t cbSrc, > - LPWSTR *ppszDestEnd, > - size_t* pcbRemaining, > - unsigned long dwFlags); > - > -STRSAFE_INLINE_API > -StringCbGetsA(LPTSTR pszDest, > - size_t cbDest); > - > -STRSAFE_INLINE_API > -StringCbGetsW(LPWSTR pszDest, > - size_t cbDest); > - > -STRSAFE_INLINE_API > -StringCbGetsExA(LPTSTR pszDest, > - size_t cbDest, > - LPTSTR *ppszDestEnd, > - size_t* pbRemaining, > - unsigned long dwFlags); > - > -STRSAFE_INLINE_API > -StringCbGetsExW(LPWSTR pszDest, > - size_t cbDest, > - LPWSTR *ppszDestEnd, > - size_t* pcbRemaining, > - unsigned long dwFlags); > - > -STRSAFEAPI > -StringCbPrintfA(LPTSTR pszDest, > - size_t cbDest, > - LPCTSTR pszFormat, > - ...); > - > -STRSAFEAPI > -StringCbPrintfW(LPWSTR pszDest, > - size_t cbDest, > - LPCWSTR pszFormat, > - ...); > - > -STRSAFEAPI > -StringCbPrintfExA(LPTSTR pszDest, > - size_t cbDest, > - LPTSTR *ppszDestEnd, > - size_t* pcbRemaining, > - unsigned long dwFlags, > - LPCTSTR pszFormat, > - ...); > - > -STRSAFEAPI > -StringCbPrintfExW(LPWSTR pszDest, > - size_t cbDest, > - LPWSTR *ppszDestEnd, > - size_t* pcbRemaining, > - unsigned long dwFlags, > - LPCWSTR pszFormat, > - ...); > -#endif /* STRSAFE_NO_CB_FUNCTIONS */ > - > -#ifdef UNICODE > -#ifndef STRSAFE_NO_CCH_FUNCTIONS > -#define StringCchCat StringCchCatW > -#define StringCchCatEx StringCchCatExW > -#define StringCchCatN StringCchCatNW > -#define StringCchCatNEx StringCchCatNExW > -#define StringCchCopy StringCchCopyW > -#define StringCchCopyEx StringCchCopyExW > -#define StringCchCopyN StringCchCopyNW > -#define StringCchCopyNEx StringCchCopyNExW > -#define StringCchGets StringCchGetsW > -#define StringCchGetsEx StringCchGetsExW > -#define StringCchPrintf StringCchPrintfW > -#define StringCchPrintfEx StringCchPrintfExW > -#define StringCchVPrintf StringCchVPrintfW > -#define StringCchVPrintfEx StringCchVPrintfExW > -#define StringCchLength StringCchLengthW > -#endif /* STRSAFE_NO_CCH_FUNCTIONS */ > - > -#ifndef STRSAFE_NO_CB_FUNCTIONS > -#define StringCbCat StringCbCatW > -#define StringCbCatEx StringCbCatExW > -#define StringCbCatN StringCbCatNW > -#define StringCbCatNEx StringCbCatNExW > -#define StringCbCopy StringCbCopyW > -#define StringCbCopyEx StringCbCopyExW > -#define StringCbCopyN StringCbCopyNW > -#define StringCbCopyNEx StringCbCopyNExW > -#define StringCbGets StringCbGetsW > -#define StringCbGetsEx StringCbGetsExW > -#define StringCbPrintf StringCbPrintfW > -#define StringCbPrintfEx StringCbPrintfExW > -#define StringCbVPrintf StringCbVPrintfW > -#define StringCbVPrintfEx StringCbVPrintfExW > -#define StringCbLenght StringCbLenghtW > -#endif /* STRSAFE_NO_CB_FUNCTIONS */ > - > -#else > -#ifndef STRSAFE_NO_CCH_FUNCTIONS > -#define StringCchCat StringCchCatA > -#define StringCchCatEx StringCchCatExA > -#define StringCchCatN StringCchCatNA > -#define StringCchCatNEx StringCchCatNExA > -#define StringCchCopy StringCchCopyA > -#define StringCchCopyEx StringCchCopyExA > -#define StringCchCopyN StringCchCopyNA > -#define StringCchCopyNEx StringCchCopyNExA > -#define StringCchGets StringCchGetsA > -#define StringCchGetsEx StringCchGetsExA > -#define StringCchPrintf StringCchPrintfA > -#define StringCchPrintfEx StringCchPrintfExA > -#define StringCchVPrintf StringCchVPrintfA > -#define StringCchVPrintfEx StringCchVPrintfExA > -#define StringCchLength StringCchLengthA > -#endif /* STRSAFE_NO_CCH_FUNCTIONS */ > - > -#ifndef STRSAFE_NO_CB_FUNCTIONS > -#define StringCbCat StringCbCatA > -#define StringCbCatEx StringCbCatExA > -#define StringCbCatN StringCbCatNA > -#define StringCbCatNEx StringCbCatNExA > -#define StringCbCopy StringCbCopyA > -#define StringCbCopyEx StringCbCopyExA > -#define StringCbCopyN StringCbCopyNA > -#define StringCbCopyNEx StringCbCopyNExA > -#define StringCbGets StringCbGetsA > -#define StringCbGetsEx StringCbGetsExA > -#define StringCbPrintf StringCbPrintfA > -#define StringCbPrintfEx StringCbPrintfExA > -#define StringCbVPrintf StringCbVPrintfA > -#define StringCbVPrintfEx StringCbVPrintfExA > -#define StringCbLenght StringCbLenghtA > -#endif /* STRSAFE_NO_CB_FUNCTIONS */ > -#endif /* UNICODE */ > - > -#ifdef __cplusplus > -} > -#endif /* cplusplus */ > - > -#endif /* _STRSAFE_H_INCLUDED_ */ > > Modified: trunk/reactos/lib/sdk/sdk.rbuild > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/sdk/sdk.rbuild?rev=342… > ============================================================================== > --- trunk/reactos/lib/sdk/sdk.rbuild [iso-8859-1] (original) > +++ trunk/reactos/lib/sdk/sdk.rbuild [iso-8859-1] Fri Jul 4 03:24:37 2008 > @@ -23,7 +23,4 @@ > <directory name="scrnsave"> > <xi:include href="scrnsave/scrnsave.rbuild" /> > </directory> > - <directory name="strsafe"> > - <xi:include href="strsafe/strsafe.rbuild" /> > - </directory> > </group> > >

17 years

2
1
0 0

Re: [ros-dev] [ros-diffs] [tkreuzer] 35346: PE symbol dumper. It's not finished, functions don't work and the type output doesn't always look 100% correct. But it does it's job. You need dbghelp.dll and symsrv.dll from windbg.

by Steven Edwards

On Thu, Aug 14, 2008 at 5:35 PM, <tkreuzer(a)svn.reactos.org> wrote: > URL: http://svn.reactos.org/svn/reactos?rev=35346&view=rev > Log: > PE symbol dumper. It's not finished, functions don't work and the type output doesn't always look 100% correct. But it does it's job. You need dbghelp.dll and symsrv.dll from windbg. You could also import winedump. -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

17 years, 1 month

2
2
0 0

Re: [ros-dev] [ros-diffs] [tkreuzer] 35359: The TEB member is called ClientID not Cid on all Windows versions I could check (XP, 2k3, vista).

by Aleksey Bragin

Please merge this change to trunk too, if NDK author does not object. WBR, Aleksey Bragin. On Aug 16, 2008, at 3:40 AM, tkreuzer(a)svn.reactos.org wrote: > Author: tkreuzer > Date: Fri Aug 15 18:40:42 2008 > New Revision: 35359 > > URL: http://svn.reactos.org/svn/reactos?rev=35359&view=rev > Log: > The TEB member is called ClientID not Cid on all Windows versions I > could check (XP, 2k3, vista).

17 years, 1 month

1
0
0 0

Re: [ros-dev] [ros-web] Developer blog

by Zachary Gorden

I'd rather pester you to finish work on your SEH paper and translation of parts of your thesis. On Fri, Aug 15, 2008 at 12:31 AM, KJK::Hyperion <hackbunny(a)reactos.org>wrote: > Zachary Gorden ha scritto: > > However, there may be developers who do not wish to maintain > > their own blog or want to keep their ROS bloggings separate and want to > > make use of the system integrated in the CMS. Any thoughts? > > Do both (aggregator AND blog platform). Then pester me to blog > _______________________________________________ > Ros-web mailing list > Ros-web(a)reactos.org > http://www.reactos.org/mailman/listinfo/ros-web >

17 years, 1 month

3
3
0 0

Developer blog

by Zachary Gorden

Sending this to both mailing lists as I don't know how many developers are actually subscribed to the web list. For some time now, the blog on the ReactOS site hasn't been used. When I asked if Aleksey was against putting up a "preview" of sorts on the front page in an attempt to revive it, some of the developers such as Ged pointed out no one really used it anymore and a few already had their own blogs and didn't want to maintain two. Ged has already moved to remove the link in the quick menu, though no formal decision has been made yet (the link is still there until a refresh occurs, though we might end up restoring it anyways). I personally believe the blog could be quite useful, even if its current form changes. An alternative would be an aggregation of the RSS feeds from the blogs maintained by each ROS developer, assuming they have a blog. However, there may be developers who do not wish to maintain their own blog or want to keep their ROS bloggings separate and want to make use of the system integrated in the CMS. Any thoughts?

17 years, 1 month

4
4
0 0

Re: [ros-dev] [ros-diffs] [sginsberg] 35299: - Reapply the PsTerminateSystemThread typo fix. We do boot fine with this fix. - Note to self: Don't commit after midnight and always test your patches yourself

by Alex Ionescu

Some credit would've been nice ;-) On 13-Aug-08, at 12:56 AM, sginsberg(a)svn.reactos.org wrote: > Author: sginsberg > Date: Wed Aug 13 02:55:59 2008 > New Revision: 35299 > > URL: http://svn.reactos.org/svn/reactos?rev=35299&view=rev > Log: > - Reapply the PsTerminateSystemThread typo fix. We do boot fine with > this fix. > - Note to self: Don't commit after midnight and always test your > patches yourself > > Modified: > trunk/reactos/ntoskrnl/ps/kill.c > > Modified: trunk/reactos/ntoskrnl/ps/kill.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ps/kill.c?rev=352… > = > = > = > = > = > = > = > = > ====================================================================== > --- trunk/reactos/ntoskrnl/ps/kill.c [iso-8859-1] (original) > +++ trunk/reactos/ntoskrnl/ps/kill.c [iso-8859-1] Wed Aug 13 > 02:55:59 2008 > @@ -1086,7 +1086,7 @@ > PETHREAD Thread = PsGetCurrentThread(); > > /* Make sure this is a system thread */ > - if (Thread->SystemThread) return STATUS_INVALID_PARAMETER; > + if (!Thread->SystemThread) return STATUS_INVALID_PARAMETER; > > /* Terminate it for real */ > return PspTerminateThreadByPointer(Thread, ExitStatus, TRUE); > Best regards, Alex Ionescu

17 years, 1 month

1
0
0 0

Re: [ros-dev] [ros-diffs] [sginsberg] 35294: - Temporarily revert my last change. We don't set the SystemThread flag appropriately and it is always zero

by Alex Ionescu

else { /* System Thread */ Thread->StartAddress = StartRoutine; PspSetCrossThreadFlag(Thread, CT_SYSTEM_THREAD_BIT); Looks good to me. And CT_SYSTEM_THREAD_BIT is defined to 0x10 which is correct: union { struct { ULONG Terminated:1; #if (NTDDI_VERSION >= NTDDI_LONGHORN) ULONG ThreadInserted:1; #else ULONG DeadThread:1; #endif ULONG HideFromDebugger:1; ULONG ActiveImpersonationInfo:1; ULONG SystemThread:1; so your patch was correct and should be re-applied. On 12-Aug-08, at 3:22 PM, sginsberg(a)svn.reactos.org wrote: > Author: sginsberg > Date: Tue Aug 12 17:22:51 2008 > New Revision: 35294 > > URL: http://svn.reactos.org/svn/reactos?rev=35294&view=rev > Log: > - Temporarily revert my last change. We don't set the SystemThread > flag appropriately and it is always zero > > Modified: > trunk/reactos/ntoskrnl/ps/kill.c > > Modified: trunk/reactos/ntoskrnl/ps/kill.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ps/kill.c?rev=352… > = > = > = > = > = > = > = > = > ====================================================================== > --- trunk/reactos/ntoskrnl/ps/kill.c [iso-8859-1] (original) > +++ trunk/reactos/ntoskrnl/ps/kill.c [iso-8859-1] Tue Aug 12 > 17:22:51 2008 > @@ -1086,7 +1086,7 @@ > PETHREAD Thread = PsGetCurrentThread(); > > /* Make sure this is a system thread */ > - if (!Thread->SystemThread) return STATUS_INVALID_PARAMETER; > + if (Thread->SystemThread) return STATUS_INVALID_PARAMETER; > > /* Terminate it for real */ > return PspTerminateThreadByPointer(Thread, ExitStatus, TRUE); > Best regards, Alex Ionescu

17 years, 1 month

1
0
0 0

Re: [ros-dev] [ros-priv] ROS information policy...

by Thomas Bluemel

Timo Kreuzer wrote: > And when I have already started moaning about this kind of stuff... what > about the arm guys? They are so secret they can't even make their > changelog themselfs? Why that? And why are they so secret that noone > knows? I mean we keep demanding real name and email from everyone > creating a patch, yet a bunch of people have direct commit access and > they keep hiding their names? What reasons are there I thought it was common knowledge already that Alex is the (only) arm "guys". Isn't it more than obvious? Very same coding style, knowledge, comments, rants, ... How stupid does one have to be not to realize the connection? Prove me otherwise... And since you're complaining about not being open, why do you only post this to the private list? Thomas

17 years, 1 month

2
1
0 0

[ros-diffs] [fireball] 35140: - Add more intrinsic defines. - SVN maintenance.

by Timo Kreuzer

MS defines most of those in the wdk, if NO_INTERLOCKED_INTRINSICS is not defined > +#define InterlockedDecrement _InterlockedDecrement > +#define InterlockedDecrement16 _InterlockedDecrement16 > +#define InterlockedIncrement _InterlockedIncrement > +#define InterlockedIncrement16 _InterlockedIncrement16 > +#define InterlockedCompareExchange _InterlockedCompareExchange > +#define InterlockedCompareExchange16 _InterlockedCompareExchange16 > +#define InterlockedCompareExchange64 _InterlockedCompareExchange64 > +#define InterlockedExchange _InterlockedExchange > +#define InterlockedExchangeAdd _InterlockedExchangeAdd >

17 years, 1 month

2
1
0 0

Re: [ros-dev] [ros-diffs] [dchapyshev] 35127: - Add cred.c from Wine

by Steven Edwards

On Tue, Aug 5, 2008 at 10:45 AM, <dchapyshev(a)svn.reactos.org> wrote: > +#include "../crypt/crypt.h" Minor nitpicking, Do you mind fixing this? Thanks -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

17 years, 1 month

1
0
0 0

Re: [ros-dev] [ros-diffs] [mkupfer] 35050: revert to 35046, sorry for mistake

by Steven Edwards

On Sat, Aug 2, 2008 at 6:33 PM, <mkupfer(a)svn.reactos.org> wrote: > Author: mkupfer > Date: Sat Aug 2 17:33:58 2008 > New Revision: 35050 > > URL: http://svn.reactos.org/svn/reactos?rev=35050&view=rev > Log: > revert to 35046, sorry for mistake Ignore my message, I did not see where you fixed it. Thanks -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

17 years, 1 month

1
0
0 0

Re: [ros-dev] [ros-diffs] [mkupfer] 35047: Reorganize shdocvw: - Moved and renamed language resource files into created 'lang' directory. - Outdated shdocvw_ros.diff removed.

by Steven Edwards

On Sat, Aug 2, 2008 at 5:57 PM, <mkupfer(a)svn.reactos.org> wrote: > Author: mkupfer > Date: Sat Aug 2 16:57:53 2008 > New Revision: 35047 > > URL: http://svn.reactos.org/svn/reactos?rev=35047&view=rev > Log: > Reorganize shdocvw: > - Moved and renamed language resource files into created 'lang' directory. > - Outdated shdocvw_ros.diff removed. This is wrong, shdocvw will keep being synced as soon as the widl bug is fixed so the resources should stay in the dll root to save whoever is doing the sync the trouble of having to move resources around. -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

17 years, 1 month

1
0
0 0

Re: [ros-dev] [ros-diffs] [sginsberg] 35042: - ExpLookupHandleTableEntry: Apply same changes as was done for ExpFreeHandleTable and ExpAllocateHandleTableEntrySlow in 34467 - ExpAllocateHandleTableEntry: Fail if we don't find a handle table entry

by Alex Ionescu

This is broken. Best regards, Alex Ionescu On Sat, Aug 2, 2008 at 11:25 AM, <sginsberg(a)svn.reactos.org> wrote: > Author: sginsberg > Date: Sat Aug 2 13:25:53 2008 > New Revision: 35042 > > URL: http://svn.reactos.org/svn/reactos?rev=35042&view=rev > Log: > - ExpLookupHandleTableEntry: Apply same changes as was done for ExpFreeHandleTable and ExpAllocateHandleTableEntrySlow in 34467 > - ExpAllocateHandleTableEntry: Fail if we don't find a handle table entry > > Modified: > trunk/reactos/ntoskrnl/ex/handle.c > > Modified: trunk/reactos/ntoskrnl/ex/handle.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ex/handle.c?rev=3… > ============================================================================== > --- trunk/reactos/ntoskrnl/ex/handle.c [iso-8859-1] (original) > +++ trunk/reactos/ntoskrnl/ex/handle.c [iso-8859-1] Sat Aug 2 13:25:53 2008 > @@ -35,8 +35,10 @@ > ExpLookupHandleTableEntry(IN PHANDLE_TABLE HandleTable, > IN EXHANDLE LookupHandle) > { > - ULONG i, j, k, TableLevel, NextHandle; > - ULONG_PTR TableBase; > + ULONG i, j, k, NextHandle; > + ULONG_PTR TableCode = HandleTable->TableCode; > + ULONG_PTR TableBase = TableCode & ~3; > + ULONG TableLevel = (ULONG)(TableCode & 3); > PHANDLE_TABLE_ENTRY Entry = NULL; > EXHANDLE Handle = LookupHandle; > PUCHAR Level1, Level2, Level3; > @@ -45,13 +47,6 @@ > Handle.TagBits = 0; > NextHandle = *(volatile ULONG*)&HandleTable->NextHandleNeedingPool; > if (Handle.Value >= NextHandle) return NULL; > - > - /* Get the table code */ > - TableBase = *(volatile ULONG_PTR*)&HandleTable->TableCode; > - > - /* Extract the table level and actual table base */ > - TableLevel = (ULONG)(TableBase & 3); > - TableBase = TableBase - TableLevel; > > /* Check what level we're running at */ > switch (TableLevel) > @@ -210,8 +205,8 @@ > PEPROCESS Process = HandleTable->QuotaProcess; > ULONG i, j; > ULONG_PTR TableCode = HandleTable->TableCode; > - ULONG TableLevel = TableCode & 3; > ULONG_PTR TableBase = TableCode & ~3; > + ULONG TableLevel = (ULONG)(TableCode & 3); > PHANDLE_TABLE_ENTRY Level1, *Level2, **Level3; > PAGED_CODE(); > > @@ -733,6 +728,13 @@ > > /* Lookup the entry for this handle */ > Entry = ExpLookupHandleTableEntry(HandleTable, Handle); > + > + /* Make sure that we found an entry */ > + if (!Entry) > + { > + /* We didn't, fail */ > + return NULL; > + } > > /* Get an available lock and acquire it */ > i = ((OldValue & FREE_HANDLE_MASK) >> 2) % 4; > >

17 years, 1 month

1
0
0 0

Call for participation: ReactOSDbg

by art yerkes

I've written a shell to use with ReactOS' KDBG that gives a more accurate view of what's going on than other methods available to us (it automatically grabs the module list and loads source files as appropriate, shows locals etc) It's not complete yet, and I'm hoping that others will want to participate in working on it. Therefore, I'm asking those with C# experience on windows who want to get involved to lend a hand in adding the remaining features: - abstract pipe implementation for serial ports and windows named pipes - managing breakpoints - type decoding and struct display using the info available from dbghelp - thread and process listing and focus - a 'watch' window and watchpoints - clipboard interaction - annontated disassembly - general features (bugzilla reporting, automatic interaction with rospaste) To work on this, you don't need to be a wizard, just familiar with windows forms development in C# and willing to learn a thing or two along the way, along with a vm to intstall reactos in and beat up on :-) Some day we'll have everything working with windows style kernel debugging, but until then I feel that a superior stopgap is valuable. -- art yerkes <ayerkes(a)speakeasy.net>

17 years, 1 month

3
4
0 0

Re: [ros-dev] [ros-diffs] [tkreuzer] 34970: - update KPCR and KIPCR - add KeGetPcr() and update KeGetCurrentProcessorNumber

by Alex Ionescu

Kinda curious why you have "unknowns" in a documented structure. On 30-Jul-08, at 7:17 PM, tkreuzer(a)svn.reactos.org wrote: > Author: tkreuzer > Date: Wed Jul 30 21:16:59 2008 > New Revision: 34970 > > URL: http://svn.reactos.org/svn/reactos?rev=34970&view=rev > Log: > - update KPCR and KIPCR > - add KeGetPcr() and update KeGetCurrentProcessorNumber > > Modified: > branches/ros-amd64-bringup/reactos/include/ddk/winddk.h > branches/ros-amd64-bringup/reactos/include/ndk/amd64/ketypes.h > > Modified: branches/ros-amd64-bringup/reactos/include/ddk/winddk.h > URL: http://svn.reactos.org/svn/reactos/branches/ros-amd64-bringup/reactos/inclu… > = > = > = > = > = > = > = > = > ====================================================================== > --- branches/ros-amd64-bringup/reactos/include/ddk/winddk.h > [iso-8859-1] (original) > +++ branches/ros-amd64-bringup/reactos/include/ddk/winddk.h > [iso-8859-1] Wed Jul 30 21:16:59 2008 > @@ -5516,23 +5516,38 @@ > > typedef struct _KPCR > { > - NT_TIB NtTib; > - struct _KPRCB *CurrentPrcb; > - ULONG64 SavedRcx; > - ULONG64 SavedR11; > + union > + { > + NT_TIB NtTib; > + struct > + { > + union _KGDTENTRY64 *GdtBase; > + struct _KTSS64 *TssBase; > + ULONG64 UserRsp; > + struct _KPCR *Self; > + struct _KPRCB *CurrentPrcb; > + PKSPIN_LOCK_QUEUE LockArray; > + PVOID Used_Self; > + }; > + }; > + union _KIDTENTRY64 *IdtBase; > + ULONG64 Unused[2]; > KIRQL Irql; > UCHAR SecondLevelCacheAssociativity; > - UCHAR Number; > + UCHAR ObsoleteNumber; > UCHAR Fill0; > - ULONG Irr; > - ULONG IrrActive; > - ULONG Idr; > + ULONG Unused0[3]; > USHORT MajorVersion; > USHORT MinorVersion; > ULONG StallScaleFactor; > - union _KIDTENTRY64 *IdtBase; > - union _KGDTENTRY64 *GdtBase; > - struct _KTSS64 *TssBase; > + PVOID Unused1[3]; > + ULONG KernelReserved[15]; > + ULONG SecondLevelCacheSize; > + ULONG HalReserved[16]; > + ULONG Unused2; > + PVOID KdVersionBlock; > + PVOID Unused3; > + ULONG PcrAlign1[24]; > } KPCR, *PKPCR; > > typedef struct _KFLOATING_SAVE { > @@ -5552,10 +5567,17 @@ > VOID); > > FORCEINLINE > +PKPCR > +KeGetPcr(VOID) > +{ > + return (PKPCR)__readgsqword(FIELD_OFFSET(KPCR, Self)); > +} > + > +FORCEINLINE > ULONG > KeGetCurrentProcessorNumber(VOID) > { > - return (ULONG)__readgsbyte(FIELD_OFFSET(KPCR, Number)); > + return (ULONG)__readgsword(0x184); > } > > #elif defined(__PowerPC__) > > Modified: branches/ros-amd64-bringup/reactos/include/ndk/amd64/ > ketypes.h > URL: http://svn.reactos.org/svn/reactos/branches/ros-amd64-bringup/reactos/inclu… > = > = > = > = > = > = > = > = > ====================================================================== > --- branches/ros-amd64-bringup/reactos/include/ndk/amd64/ketypes.h > [iso-8859-1] (original) > +++ branches/ros-amd64-bringup/reactos/include/ndk/amd64/ketypes.h > [iso-8859-1] Wed Jul 30 21:16:59 2008 > @@ -635,41 +635,42 @@ > NT_TIB NtTib; > struct > { > - struct _EXCEPTION_REGISTRATION_RECORD > *Used_ExceptionList; > - PVOID Used_StackBase; > - PVOID PerfGlobalGroupMask; > - PVOID TssCopy; > - ULONG ContextSwitches; > - KAFFINITY SetMemberCopy; > + union _KGDTENTRY64 *GdtBase; > + struct _KTSS64 *TssBase; > + ULONG64 UserRsp; > + struct _KPCR *Self; > + struct _KPRCB *CurrentPrcb; > + PKSPIN_LOCK_QUEUE LockArray; > PVOID Used_Self; > }; > }; > - struct _KPCR *Self; > - struct _KPRCB *Prcb; > + union _KIDTENTRY64 *IdtBase; > + ULONG64 Unused[2]; > KIRQL Irql; > - ULONG IRR; > - ULONG IrrActive; > - ULONG IDR; > - PVOID KdVersionBlock; > - PKIDTENTRY IDT; > - PKGDTENTRY GDT; > - struct _KTSS *TSS; > + UCHAR SecondLevelCacheAssociativity; > + UCHAR ObsoleteNumber; > + UCHAR Fill0; > + ULONG Unused0[3]; > USHORT MajorVersion; > USHORT MinorVersion; > - KAFFINITY SetMember; > ULONG StallScaleFactor; > - UCHAR SparedUnused; > - UCHAR Number; > - UCHAR Reserved; > - UCHAR L2CacheAssociativity; > - ULONG VdmAlert; > - ULONG KernelReserved[14]; > + PVOID Unused1[3]; > + ULONG KernelReserved[15]; > ULONG SecondLevelCacheSize; > ULONG HalReserved[16]; > - ULONG InterruptMode; > - UCHAR Spare1; > - ULONG KernelReserved2[17]; > - KPRCB PrcbData; > + ULONG Unused2; > + ULONG Fill1; > + PVOID KdVersionBlock; // 0x108 > + PVOID Unused3; > + ULONG PcrAlign1[24]; > + > + ULONG Unknown1; // 0x178 > + ULONG Unknown2; > + ULONG Unknown3; > + USHORT CpuNumber; // 0x184 > + // hack: > + ULONG ContextSwitches; > + > } KIPCR, *PKIPCR; > #pragma pack(pop) > > Best regards, Alex Ionescu

17 years, 1 month

2
3
0 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev