- Ros-dev - ReactOS.org

Re: [ros-dev] ARM Guy Broke BOOT on Real Hardware

by tamlin＠algonet.se

Alex wrote: >It looks like a guarded mutex is being acquired at DPC level. That's >pretty bad. Well, at least it's redundant and useless. :-) >Pushlocks shouldn't be acquired at DPC level either Indeed. If "you" are at DPC level, you have but one synchronization to care about - SMP (i.e. CPU<->CPU). >, but there's no >ASSERTs in the pushlock code that check for that. An oversight that should be fixed, I'm sure (even if it happened to slow down the system by a whole order of magnitude, which it won't). >MMProbeAndLockPages should never be called for paged pool addreses >while at DPC level, Should MmProbeAndLock ever be called at IRQL above APC level? I mean, what if the probing fails? Should the paging executive somehow preempt this call and page in the missing pages (or should it simply throw a "page not present" exception - not too great to do at DPC level I'd say)? >which means the driver probably called it for a >non-paged pool address. If my previous suspicion is correct, I build on that and suspect this is an error in itself. The ProbeAndLock call should be done at APC level (though I may be completely wrong, but do read my finishing line). >In that case, the whole loop about checking if the page is present and >then faulting it in is irrelevant, and won't happen. Right. Page fault at DPC level == Bad Move(tm). -- Mike

17 years, 1 month

2
1
0 0

Re: [ros-dev] [ros-diffs] [hpoussin] 34856: Revert r34848 and r34850, and replace them by a real fix (hinted by Colin Finck)

by Alex Ionescu

This breaks compiling on Mac OS X... I haven't been able to build since this patch, because now it tries to include windows.h. On 27-Jul-08, at 12:39 PM, hpoussin(a)svn.reactos.org wrote: > Author: hpoussin > Date: Sun Jul 27 14:39:05 2008 > New Revision: 34856 > > URL: http://svn.reactos.org/svn/reactos?rev=34856&view=rev > Log: > Revert r34848 and r34850, and replace them by a real fix (hinted by > Colin Finck) > > Modified: > trunk/reactos/Makefile > trunk/reactos/tools/sysreg/namedpipe_reader.cpp > trunk/reactos/tools/sysreg/os_support.cpp > trunk/reactos/tools/sysreg/os_support.h > trunk/reactos/tools/sysreg/rosboot_test.cpp > trunk/reactos/tools/sysreg/rosboot_test.h > trunk/reactos/tools/sysreg/user_types.h > > Modified: trunk/reactos/Makefile > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/Makefile?rev=34856&r1=3485… > = > = > = > = > = > = > = > = > ====================================================================== > --- trunk/reactos/Makefile [iso-8859-1] (original) > +++ trunk/reactos/Makefile [iso-8859-1] Sun Jul 27 14:39:05 2008 > @@ -182,8 +182,8 @@ > endif > else > HOST=mingw32-linux > -HOST_CFLAGS+=-fshort-wchar -D__LINUX__ > -HOST_CPPFLAGS+=-fshort-wchar -D__LINUX__ > +HOST_CFLAGS+=-fshort-wchar > +HOST_CPPFLAGS+=-fshort-wchar > endif > endif > > > Modified: trunk/reactos/tools/sysreg/namedpipe_reader.cpp > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/tools/sysreg/namedpipe_rea… > = > = > = > = > = > = > = > = > ====================================================================== > --- trunk/reactos/tools/sysreg/namedpipe_reader.cpp [iso-8859-1] > (original) > +++ trunk/reactos/tools/sysreg/namedpipe_reader.cpp [iso-8859-1] Sun > Jul 27 14:39:05 2008 > @@ -14,7 +14,7 @@ > { > #define MIN(a, b) (((a) < (b)) ? (a) : (b)) > > -#ifdef __LINUX__ > +#ifdef __linux__ > const char * NamedPipeReader::s_LineBreak = "\x0A\0"; > #else > const char * NamedPipeReader::s_LineBreak = "\x0D\x0A\0"; > @@ -46,7 +46,7 @@ > cerr << "NamedPipeReader::openPipe> pipe already open" > << endl; > return false; > } > -#ifndef __LINUX__ > +#ifndef __linux__ > h_Pipe = CreateFile(PipeCmd.c_str(), > GENERIC_WRITE | GENERIC_READ, > 0, > @@ -105,7 +105,7 @@ > cerr << "NamedPipeReader::closePipe> pipe is not open" > << endl; > return false; > } > -#ifdef __LINUX__ > +#ifdef __linux__ > close(h_Pipe); > #else > DisconnectNamedPipe(h_Pipe); > @@ -274,7 +274,7 @@ > bool NamedPipeReader::readPipe(char * buffer, int bufferlength, > long & bytesread) > { > > -#ifdef __LINUX__ > +#ifdef __linux__ > long cbRead = read(h_Pipe, > buffer, > (bufferlength-1) * sizeof(char)); > > Modified: trunk/reactos/tools/sysreg/os_support.cpp > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/tools/sysreg/os_support.cp… > = > = > = > = > = > = > = > = > ====================================================================== > --- trunk/reactos/tools/sysreg/os_support.cpp [iso-8859-1] (original) > +++ trunk/reactos/tools/sysreg/os_support.cpp [iso-8859-1] Sun Jul > 27 14:39:05 2008 > @@ -38,7 +38,7 @@ > } > } > > -#ifdef __LINUX__ > +#ifdef __linux__ > if (s_Entries.size()) > { > long secs = s_Entries[i]->tm.tv_sec - tm.tv_sec; > @@ -54,7 +54,7 @@ > void OsSupport::cancelAlarms() > { > > -#ifndef __LINUX__ > +#ifndef __linux__ > if (s_hThread) > { > TerminateThread(s_hThread, 0); > @@ -73,7 +73,7 @@ > } > > > -#ifndef __LINUX__ > +#ifndef __linux__ > > HANDLE OsSupport::s_hThread = 0; > static HANDLE hTimer; > > Modified: trunk/reactos/tools/sysreg/os_support.h > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/tools/sysreg/os_support.h?… > = > = > = > = > = > = > = > = > ====================================================================== > --- trunk/reactos/tools/sysreg/os_support.h [iso-8859-1] (original) > +++ trunk/reactos/tools/sysreg/os_support.h [iso-8859-1] Sun Jul 27 > 14:39:05 2008 > @@ -10,7 +10,7 @@ > * PROGRAMMERS: Johannes Anderwald (johannes.anderwald at sbox > tugraz at) > */ > > -#ifndef __LINUX__ > +#ifndef __linux__ > #include <windows.h> > #else > #include <unistd.h> > @@ -140,7 +140,7 @@ > OsSupport() > {} > > -#ifdef __LINUX__ > +#ifdef __linux__ > static struct sigaction s_sact; > #else > static HANDLE s_hThread; > > Modified: trunk/reactos/tools/sysreg/rosboot_test.cpp > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/tools/sysreg/rosboot_test.… > = > = > = > = > = > = > = > = > ====================================================================== > --- trunk/reactos/tools/sysreg/rosboot_test.cpp [iso-8859-1] > (original) > +++ trunk/reactos/tools/sysreg/rosboot_test.cpp [iso-8859-1] Sun Jul > 27 14:39:05 2008 > @@ -46,7 +46,7 @@ > string RosBootTest::XEN_CONFIG_FILE = "XEN_CONFIG_FILE"; > string RosBootTest::XEN_CONFIG_NAME = "XEN_CONFIG_NAME"; > > -#ifdef __LINUX__ > +#ifdef __linux__ > string RosBootTest::ROS_EMU_PATH = "ROS_EMU_PATH_LIN"; > #else > string RosBootTest::ROS_EMU_PATH = "ROS_EMU_PATH_WIN"; > @@ -117,7 +117,7 @@ > img = "output-i386"; > > EnvironmentVariable::getValue("ROS_OUTPUT", img); > -#ifdef __LINUX__ > +#ifdef __linux__ > img += "/ros.hd"; > #else > img += "\\ros.hd"; > @@ -159,7 +159,7 @@ > } > > > -#ifdef __LINUX__ > +#ifdef __linux__ > qemuimgdir += "/qemu-img"; > > #else > @@ -176,7 +176,7 @@ > const char * options[] = {NULL, > "create", > "-f", > -#ifdef __LINUX__ > +#ifdef __linux__ > "raw", > #else > "vmdk", > @@ -241,7 +241,7 @@ > { > string::size_type pos; > > -#ifdef __LINUX__ > +#ifdef __linux__ > pos = m_EmuPath.find_last_of("/"); > #else > pos = m_EmuPath.find_last_of("\\"); > @@ -266,7 +266,7 @@ > m_MaxMem = "64"; > } > > -#ifdef __LINUX__ > +#ifdef __linux__ > > if (mktemp(pipename)) > { > @@ -332,7 +332,7 @@ > return false; > } > > -#ifdef __LINUX__ > +#ifdef __linux__ > /* on linux we need get pid in order to be able > * to terminate the emulator in case of errors > * on windows we can get pid as return of > CreateProcess > @@ -369,7 +369,7 @@ > { > pipe = pipe.substr(0, pos); > } > -#ifdef __LINUX__ > +#ifdef __linux__ > m_Src = pipe; > #else > m_Src = "\\\\.\\pipe\\" + pipe.substr(0, pos); > @@ -577,7 +577,7 @@ > return false; > } > } > -#ifdef __LINUX__ > +#ifdef __linux__ > if (mkfifo(m_Src.c_str(), 400)) > { > /* > @@ -802,7 +802,7 @@ > cleanup(conf_parser); > return false; > } > -#ifdef __LINUX__ > +#ifdef __linux__ > /* > * For linux systems we can only > * check if the emulator runs by > @@ -832,7 +832,7 @@ > } > #endif > OsSupport::cancelAlarms(); > -#ifdef __LINUX__ > +#ifdef __linux__ > // OsSupport::setAlarm (m_MaxTime, m_Pid); > // OsSupport::setAlarm(m_MaxTime, getpid()); > #else > > Modified: trunk/reactos/tools/sysreg/rosboot_test.h > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/tools/sysreg/rosboot_test.… > = > = > = > = > = > = > = > = > ====================================================================== > --- trunk/reactos/tools/sysreg/rosboot_test.h [iso-8859-1] (original) > +++ trunk/reactos/tools/sysreg/rosboot_test.h [iso-8859-1] Sun Jul > 27 14:39:05 2008 > @@ -30,12 +30,12 @@ > #include <cstdlib> > #include <cstring> > #include <ctime> > -#ifndef __LINUX__ > +#ifndef __linux__ > #include <io.h> > #include <errno.h> > #endif > > -#ifdef __LINUX__ > +#ifdef __linux__ > #include <unistd.h> > #include <sys/types.h> > #if defined(__FreeBSD__) || defined(__APPLE__) > > Modified: trunk/reactos/tools/sysreg/user_types.h > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/tools/sysreg/user_types.h?… > = > = > = > = > = > = > = > = > ====================================================================== > --- trunk/reactos/tools/sysreg/user_types.h [iso-8859-1] (original) > +++ trunk/reactos/tools/sysreg/user_types.h [iso-8859-1] Sun Jul 27 > 14:39:05 2008 > @@ -13,7 +13,7 @@ > #include <string> > #include <iostream> > > -#ifndef __LINUX__ > +#ifndef __linux__ > #define popen _popen > #define pclose _pclose > #endif > Best regards, Alex Ionescu

17 years, 1 month

2
3
0 0

ARM Guy Broke BOOT on Real Hardware

by James Tabor

Hi ARMs, Doing a good job BTW~ Thanks, James (ntoskrnl/kd/kdio.c:191) ----------------------------------------------------- (ntoskrnl/kd/kdio.c:192) ReactOS 0.4-SVN (Build 20080728-r34871) (ntoskrnl/kd/kdio.c:193) Command Line: DEBUG DEBUGPORT=COM1 BUADRATE=115200 SOS (ntoskrnl/kd/kdio.c:194) ARC Paths: multi(0)disk(0)rdisk(0)partition(1) \ multi(0)disk(0)rdisk(0)parti tion(1) \ReactOS\ Used memory 1015348Kb (ntoskrnl/mm/mminit.c:295) Start End Type (ntoskrnl/mm/mminit.c:296) 0x80000000 - 0x80800000 Undefined region (ntoskrnl/mm/mminit.c:299) 0x80800000 - 0x80E00000 FreeLDR Kernel mapping region (ntoskrnl/mm/mminit.c:302) 0x80E00000 - 0x815C0000 PFN Database region (ntoskrnl/mm/mminit.c:309) 0x815C0000 - 0x879C0000 Non paged pool region (ntoskrnl/mm/mminit.c:312) 0x879C0000 - 0x8DDC0000 Paged pool region (ntoskrnl/ke/i386/kiinit.c:47) Large Page support detected but not yet taken advantage of! WARNING: KdDebuggerInitialize1 at drivers/base/kdcom/i386/kdbg.c:489 is UNIMPLEMENTED! WARNING: IoReportResourceUsage at ntoskrnl/io/iomgr/iorsrce.c:700 is UNIMPLEMENTED! WARNING: IoReportResourceUsage at ntoskrnl/io/iomgr/iorsrce.c:700 is UNIMPLEMENTED! (ntoskrnl/io/iomgr/driver.c:1356) '\Driver\BUSLOGIC' initialization failed, status (0xc00000c0) (ntoskrnl/io/iomgr/driver.c:1356) '\Driver\Floppy' initialization failed, status (0xc000000e) Assertion 'KeGetCurrentIrql()<=(1)' failed at ntoskrnl/ke/gmutex.c line 201 Entered debugger on embedded INT3 at 0x0008:0x808a8262. kdb:> bt Eip: <NTOSKRNL.EXE:a8263 (lib/rtl/i386/debug_asm.S:33 (DbgBreakPoint@0))> Frames: <NTOSKRNL.EXE:a027 (ntoskrnl/ke/gmutex.c:201 (@KeAcquireGuardedMutex@4))> <NTOSKRNL.EXE:6d3a2 (ntoskrnl/include/internal/mm.h:1556 (MmProbeAndLockPages@12))> <NTOSKRNL.EXE:4f079 (ntoskrnl/io/iomgr/irp.c:694 (IoBuildAsynchronousFsdRequest@24))> <SCSIPORT.SYS:4671 (drivers/storage/scsiport/scsiport.c:3959 (ScsiPortDpcForIsr@16))> <NTOSKRNL.EXE:823a (ntoskrnl/ke/dpc.c:474 (@KiRetireDpcList@4))> <NTOSKRNL.EXE:9fc59 (ntoskrnl/ke/i386/ctxswitch.S:691 (@KiIdleLoop@0))> <00000000> kdb:>

17 years, 1 month

2
1
0 0

Re: [ros-dev] [ros-diffs] [pschweitzer] 34860: Fixed some kernel exports

by Alex Ionescu

I would've hoped the ARM guys made it painfully clear by now that ARM functions do not have @xx appended to their names... Author: ros-arm-bringup Date: Sun Jul 27 00:37:54 2008 New Revision: 34820 URL: http://svn.reactos.org/svn/reactos?rev=34820&view=rev Log: - Stop adding those damn @ decorations to ARM builds. Among many others... On 27-Jul-08, at 2:19 PM, pschweitzer(a)svn.reactos.org wrote: > Author: pschweitzer > Date: Sun Jul 27 16:19:15 2008 > New Revision: 34860 > > URL: http://svn.reactos.org/svn/reactos?rev=34860&view=rev > Log: > Fixed some kernel exports > > Modified: > branches/pierre-fsd/ntoskrnl/ntoskrnl_arm.def > branches/pierre-fsd/ntoskrnl/ntoskrnl_i386.def > > Modified: branches/pierre-fsd/ntoskrnl/ntoskrnl_arm.def > URL: http://svn.reactos.org/svn/reactos/branches/pierre-fsd/ntoskrnl/ntoskrnl_ar… > = > = > = > = > = > = > = > = > ====================================================================== > --- branches/pierre-fsd/ntoskrnl/ntoskrnl_arm.def [iso-8859-1] > (original) > +++ branches/pierre-fsd/ntoskrnl/ntoskrnl_arm.def [iso-8859-1] Sun > Jul 27 16:19:15 2008 > @@ -187,10 +187,10 @@ > FsRtlDeleteKeyFromTunnelCache > FsRtlDeleteTunnelCache > FsRtlDeregisterUncProvider > -FsRtlDissectDbcs > -FsRtlDissectName > -FsRtlDoesDbcsContainWildCards > -FsRtlDoesNameContainWildCards > +FsRtlDissectDbcs@16 > +FsRtlDissectName@16 > +FsRtlDoesDbcsContainWildCards@4 > +FsRtlDoesNameContainWildCards@4 > FsRtlFastCheckLockForRead > FsRtlFastCheckLockForWrite > FsRtlFastUnlockAll > > Modified: branches/pierre-fsd/ntoskrnl/ntoskrnl_i386.def > URL: http://svn.reactos.org/svn/reactos/branches/pierre-fsd/ntoskrnl/ntoskrnl_i3… > = > = > = > = > = > = > = > = > ====================================================================== > --- branches/pierre-fsd/ntoskrnl/ntoskrnl_i386.def [iso-8859-1] > (original) > +++ branches/pierre-fsd/ntoskrnl/ntoskrnl_i386.def [iso-8859-1] Sun > Jul 27 16:19:15 2008 > @@ -204,9 +204,9 @@ > FsRtlDeleteKeyFromTunnelCache > FsRtlDeleteTunnelCache > FsRtlDeregisterUncProvider > -FsRtlDissectDbcs > +FsRtlDissectDbcs@16 > FsRtlDissectName@16 > -FsRtlDoesDbcsContainWildCards > +FsRtlDoesDbcsContainWildCards@4 > FsRtlDoesNameContainWildCards@4 > FsRtlFastCheckLockForRead > FsRtlFastCheckLockForWrite > Best regards, Alex Ionescu

17 years, 1 month

1
0
0 0

[ros-diffs] [jimtabor] 34807: - Attempt to initiate hook set from kernel space.

by James Tabor

Hi, Here is a test program to play with, tell me what is wrong. 8^D James Ref info and download the program: http://www.klenotic.com/pl/null_hhook/ http://www.klenotic.com/pl/null_hhook/HookChainTest100.zip

17 years, 1 month

1
0
0 0

widl problem importing stdole2.tlb

by Steven Edwards

Hi, I've been attempting to sync some of the Wine dlls, namely the IE support dlls and have run in to a bit of a problem which I think is a bug in ReactOS widl. It seems that the import keyword is not working. When trying to build shdocvw.dll it creates a shdocvw_v1.tlb based on shdocvw_v1.idl which imports exdisp.idl from the SDK which in turn does an import ("stdole2.tlb") As you can see from the output below sedwards@mini-gimli:~/source/reactos$ make shdocvw [WIDL] obj-i386/dll/win32/shdocvw/shdocvw_v1.tlb error: Could not open importlib stdole2.tlb. mingw32-make: *** [obj-i386/dll/win32/shdocvw/shdocvw_v1.tlb] Error 2 Total Build Time: 00:00:02 Notice the . at the end of stdole2.tlb? I've tried just renaming the typelib and putting it in several intermediate folders to no effect. If any WIDL Guru can help please find the attached patch which contains an updated shdocvw.rbuild Thanks Steven -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

17 years, 1 month

1
0
0 0

kernel32

by gedmurphy

Yesterday I was playing around with the test suite in HEAD when I moved onto kernel32. It was, without wanting to sound too harsh, a bit of a disgrace, with large failures throughout the whole test range. I suggest a hacking day on it using the test suite, a joint effort to bring this core lib back into line. Perhaps with some emphasis on trying to make it fun. Whoever gets the most fixes is crowned 'king ding-a-ling' and holds the title until the next one, opening the road up to days on ntdll, user32, gdi32 and crt? Ged.

17 years, 1 month

2
2
0 0

Java Install

by James Tabor

Hi, When installing Java or anything with java it hangs and just sit there running. It could be OOo 2.4 or installing java, does not mater, I just left the box running all night and just sits there, still installing.. This bug fault right after I restarted. Is it waiting on a lock? Assertion 'WaitBlock->Signaled' failed at ntoskrnl/ex/pushlock.c line 599 Entered debugger on embedded INT3 at 0x0008:0x808ad242. kdb:> bt Eip: <NTOSKRNL.EXE:ad243 (lib/rtl/i386/debug_asm.S:33 (DbgBreakPoint@0))> Frames: <NTOSKRNL.EXE:2da24 (ntoskrnl/ex/pushlock.c:599 (@ExfAcquirePushLockExclusive@4))> <NTOSKRNL.EXE:6eb00 (ntoskrnl/include/internal/ex.h:715 (MiProtectVirtualMemory@20))> <NTOSKRNL.EXE:6fdbf (ntoskrnl/mm/virtual.c:927 (NtProtectVirtualMemory@20))> <NTOSKRNL.EXE:979ca (ntoskrnl/ke/i386/trap.s:244 (KiFastCallEntry))> <ntdll.dll:5e1a> ntdll/main/i386/dispatch.S:297 (KiFastSystemCallRet@0) <kernel32.dll:e0ce> kernel32/mem/virtual.c:127 (VirtualProtect@16) <jvm.dll:149b27> kdb:>

17 years, 1 month

2
1
0 0

Request for Comment / Setup

by Matthias Kupfer

Hi all, I'm working on first stage gui setup. During the development i reviewed the base/setup directory and the different modules. I suggest following changes: Now: reactos.exe: atm greeting only with disabled first stage setup dialogs setup.exe: switcher for 2nd stage setup (syssetup) or livecd usetup.exe: textmode 1st stage setup vmwinst.exe: don't know exactly, vm-ware driver installation welcome.exe: nice welcome dialog without real functions Future: setup.exe: switcher for 1st stage gui setup, 2nd stage setup, livecd and welcome dialog switched by command line arguments "setup.exe" -> welcome dialog "setup.exe -mini" -> livecd "setup.exe -newsetup1" -> 1st stage gui setup "setup.exe -newsetup2" -> 2nd stage (gui) setup usetup.exe: textmode 1st-stage-setup vmwinst.exe: keeps unchangend reactos.exe, welcome.exe: removed Are there any objections to go this way? If not, so i will change this soon. Matthias -- Matthias Kupfer Telefon +49 (0) 371 236 46 52 Wilhelm-Firl-Straße 21 Mobil +49 (0) 160 859 43 54 09122 Chemnitz

17 years, 1 month

2
1
0 0

Re: [ros-dev] Re : [ros-diffs] [ros-arm-bringup] 34655: - Build vfatfs instead of CDFS. - Load vfatfs instead of CDFS. - Implement code in the ramdisk driver to handle both ISO and FAT ramdisks. Don't know what the big deal with support ISO ramdisks

by Steven Edwards

On Tue, Jul 22, 2008 at 9:56 AM, Sylvain Petreolle <spetreolle(a)yahoo.fr> wrote: > It'sToo bad the header is not in an include directory... Maybe it should go in the NDK then. -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

17 years, 1 month

1
0
0 0

Re : [ros-diffs] [ros-arm-bringup] 34655: - Build vfatfs instead of CDFS. - Load vfatfs instead of CDFS. - Implement code in the ramdisk driver to handle both ISO and FAT ramdisks. Don't know what the big deal with support ISO ramdisks was supposed to

by Sylvain Petreolle

> De : Steven Edwards <winehacker(a)gmail.com> > À : ros-dev(a)reactos.org > Envoyé le : Mardi, 22 Juillet 2008, 11h49mn 04s > Objet : Re: [ros-dev] [ros-diffs] [ros-arm-bringup] 34655: - Build vfatfs instead of CDFS. - Load vfatfs instead of CDFS. - Implement code in the ramdisk driver to handle both ISO and FAT ramdisks. Don't know what the big deal with support ISO ramdisks was supposed to > > On Tue, Jul 22, 2008 at 5:42 AM, Steven Edwards wrote: > > On Tue, Jul 22, 2008 at 1:31 AM, wrote: > >> #include > >> +#include "../../../filesystems/fs_rec/fs_rec.h" > > > > This can cause problems with parallel makes. > > This is what I get for commenting at 5 am...I thought you were > including another .c file directly. ignore the part about parallel > makes. But do try to avoid referencing the header like this. Just set > an include path in the rbuild file and spare my eyes the horror of the > directory traversal. > > -- > Steven Edwards > It'sToo bad the header is not in an include directory... Kind regards, Sylvain Petreolle (aka Usurp) Support artists, not multinationals - http://Iwouldntsteal.net Supportez les artistes, pas les multinationales - http://Iwouldntsteal.net

17 years, 1 month

2
1
0 0

Re: [ros-dev] [ros-diffs] [ros-arm-bringup] 34655: - Build vfatfs instead of CDFS. - Load vfatfs instead of CDFS. - Implement code in the ramdisk driver to handle both ISO and FAT ramdisks. Don't know what the big deal with support ISO ramdisks was supposed to

by Steven Edwards

On Tue, Jul 22, 2008 at 1:31 AM, <ros-arm-bringup(a)svn.reactos.org> wrote: > #include <reactos/drivers/ntddrdsk.h> > +#include "../../../filesystems/fs_rec/fs_rec.h" This can cause problems with parallel makes. -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

17 years, 1 month

1
1
0 0

Re: [ros-dev] [ros-diffs] [ros-arm-bringup] 34615: - Add new CDFSdriver. - Does not compile.

by Heis Spiter

Indeed, that's not conform to EULA that says: "You may not distribute Distributable Code to run on a platform other than the Windows platform;". Moreover, CDFS driver ISN'T listed as a "Distributable Code". Please revert to avoid any problems. P. Schweitzer -------------------------------------------------- From: "Steven Edwards" <winehacker(a)gmail.com> Sent: Monday, July 21, 2008 12:21 AM To: <ros-dev(a)reactos.org> Subject: Re: [ros-dev] [ros-diffs] [ros-arm-bringup] 34615: - Add new CDFSdriver. - Does not compile. > On Sun, Jul 20, 2008 at 3:52 PM, <ros-arm-bringup(a)svn.reactos.org> wrote: >> URL: http://svn.reactos.org/svn/reactos?rev=34615&view=rev >> Log: >> - Add new CDFS driver. >> - Does not compile. > > Ehem...as far as I understand the EULA (unless its changed) you cannot > use the WDK references drivers for a non-windows OS. Please revert > this and write you own. > > -- > Steven Edwards > > "There is one thing stronger than all the armies in the world, and > that is an idea whose time has come." - Victor Hugo > _______________________________________________ > Ros-dev mailing list > Ros-dev(a)reactos.org > http://www.reactos.org/mailman/listinfo/ros-dev >

17 years, 1 month

3
2
0 0

Re: [ros-dev] [ros-diffs] [ros-arm-bringup] 34615: - Add new CDFS driver. - Does not compile.

by Steven Edwards

On Sun, Jul 20, 2008 at 3:52 PM, <ros-arm-bringup(a)svn.reactos.org> wrote: > URL: http://svn.reactos.org/svn/reactos?rev=34615&view=rev > Log: > - Add new CDFS driver. > - Does not compile. Ehem...as far as I understand the EULA (unless its changed) you cannot use the WDK references drivers for a non-windows OS. Please revert this and write you own. -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

17 years, 1 month

1
0
0 0

Changes of inf-files in media/inf

by Matthias Kupfer

Hello, after several commits that leads in broken inf-files (last one 34598 by spetreolle), I invite to take care about following things: 1. The inf files are in UTF-16LE a.k.a. UCS-2LE. 2. All lines ends with CRLF (a single one, no other combination). 3. The files have to start with a bom (byte order mark). 4. There are no more boms allowed anywhere in the file. Please modify that files _very_ carefully, because we can't check changes via diff, due to the lack of utf-16 support in svn. Matthias -- Matthias Kupfer Telefon +49 (0) 371 236 46 52 Wilhelm-Firl-Straße 21 Mobil +49 (0) 160 859 43 54 09122 Chemnitz

17 years, 1 month

1
0
0 0

Re: [ros-dev] [ros-diffs] [ros-arm-bringup] 34603: - Ramdisk doesn't seem to work yet, we're not getting properly initialized yet. - We end up crashing in CcRosTryToInitialzeFileCache because there is no SectionObjectPointer, and it is assumed this always exis

by Steven Edwards

On Sun, Jul 20, 2008 at 12:40 AM, <ros-arm-bringup(a)svn.reactos.org> wrote: > - We end up crashing in CcRosTryToInitialzeFileCache because there is no SectionObjectPointer, and it is assumed this always exists. Ninjas! I don't know if this is related but would it be possible to switch to doing development on NoCC in case you guys run in to more problems like these? I don't know if it would help but I assume your going to run in to more problems with the current Cc and you might be able to save a lot of trouble later on. Thanks -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

17 years, 1 month

1
0
0 0

Re: [ros-dev] [ros-diffs] [mkupfer] 34572: - gui template for 1st stage setup, english only - implemented, but still disabled - it's work in progress

by Marc Piulachs

Shouldn't this code be part of syssetup instead of reactos.exe? IMO reactos.exe should be only a very simple stub application which calls setup.exe with the appropiate parameters (which in turn use syssetup) or show a messagebox in case of any error. In MS Windows second stage setup does most of the install process , even install the files to the hard drive (the files copied during 1st stage setup are uncompressed and copied into a temporal location) . First stage setup does the minimal required steps (load drivers , setup partition and copy files) to be able to start the second stage setup which does most of the job. Installing reactos to a hard drive from a bootcd or installing it form a live cd (in the future) should not make any difference but the second stage wizard should shown the appropiate additional steps to emulate the first stage setup. Regards, /Marc -------------------------------------------------- From: <mkupfer(a)svn.reactos.org> Sent: Friday, July 18, 2008 11:07 AM To: <ros-diffs(a)reactos.org> Subject: [ros-diffs] [mkupfer] 34572: - gui template for 1st stage setup, english only - implemented, but still disabled - it's work in progress > Author: mkupfer > Date: Fri Jul 18 04:07:54 2008 > New Revision: 34572 > > URL: http://svn.reactos.org/svn/reactos?rev=34572&view=rev > Log: > - gui template for 1st stage setup, english only > - implemented, but still disabled - it's work in progress > > Modified: > trunk/reactos/base/setup/reactos/lang/en-US.rc > trunk/reactos/base/setup/reactos/reactos.c > trunk/reactos/base/setup/reactos/reactos.rbuild > trunk/reactos/base/setup/reactos/res/header.bmp > trunk/reactos/base/setup/reactos/resource.h > > Modified: trunk/reactos/base/setup/reactos/lang/en-US.rc > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/base/setup/reactos/lang/en… > ============================================================================== > --- trunk/reactos/base/setup/reactos/lang/en-US.rc [iso-8859-1] (original) > +++ trunk/reactos/base/setup/reactos/lang/en-US.rc [iso-8859-1] Fri Jul 18 > 04:07:54 2008 > @@ -14,4 +14,109 @@ > LTEXT "Click Finish to exit the Setup.", IDC_STATIC, 115, 169, 195, 17 > END > > +IDD_LANGSELPAGE DIALOGEX DISCARDABLE 0, 0, 317, 193 > +STYLE DS_SHELLFONT | DS_MODALFRAME | WS_POPUP | WS_VISIBLE | WS_CAPTION | > WS_SYSMENU > +CAPTION "ReactOS Setup" > +FONT 8, "MS Shell Dlg" > +BEGIN > + LTEXT "Please choose the language used for the installation process." > + , IDC_STATIC, 10, 0, 297, 10 > + LTEXT "The selected language will be the default language for the > final system.", IDC_STATIC, 10, 13, 297, 10 > + LISTBOX IDC_LANGUAGES, 10,28,297,142,LBS_HASSTRINGS | WS_VSCROLL > + LTEXT "Click Next to select the setup type.", IDC_STATIC, 10, 180 > ,297, 10 > +END > + > +IDD_TYPEPAGE DIALOGEX DISCARDABLE 0, 0, 317, 193 > +STYLE DS_SHELLFONT | DS_MODALFRAME | WS_POPUP | WS_VISIBLE | WS_CAPTION | > WS_SYSMENU > +CAPTION "ReactOS Setup" > +FONT 8, "MS Shell Dlg" > +BEGIN > + CONTROL "Type of setup", IDC_STATIC, "Button", BS_GROUPBOX, > 10,0,297,172 > + CONTROL "Install ReactOS", IDC_INSTALL, "Button", BS_AUTORADIOBUTTON > | WS_TABSTOP, 20, 15, 277, 10 > + CONTROL "Repair or update an installed ReactOS", IDC_SETUP, "Button", > BS_AUTORADIOBUTTON | WS_TABSTOP | WS_DISABLED , 20, 30, 277, 10 > + LTEXT "Click Next to setup the devices.", IDC_STATIC, 10, 180 ,297, > 10 > +END > + > +IDD_DEVICEPAGE DIALOGEX DISCARDABLE 0, 0, 317, 193 > +STYLE DS_SHELLFONT | DS_MODALFRAME | WS_POPUP | WS_VISIBLE | WS_CAPTION | > WS_SYSMENU > +CAPTION "ReactOS Setup" > +FONT 8, "MS Shell Dlg" > +BEGIN > + CONTROL "Device settings", IDC_STATIC, "Button", BS_GROUPBOX, > 10,0,297,172 > + LTEXT "Computer:", IDC_STATIC, 20,15, 80, 10 > + CONTROL "", IDC_COMPUTER, "ComboBox", WS_TABSTOP | CBS_DROPDOWNLIST , > 100, 15, 150, 80 > + LTEXT "Display:", IDC_STATIC, 20,35, 80, 10 > + CONTROL "", IDC_DISPLAY, "ComboBox", WS_TABSTOP | CBS_DROPDOWNLIST , > 100, 35, 150, 80 > + LTEXT "Keyboard:", IDC_STATIC, 20,55, 80, 10 > + CONTROL "", IDC_KEYBOARD, "ComboBox", WS_TABSTOP | CBS_DROPDOWNLIST , > 100, 55, 150, 80 > + LTEXT "Keyboard layout:", IDC_STATIC, 20,75, 80, 10 > + CONTROL "", IDC_KEYLAYOUT, "ComboBox", WS_TABSTOP | CBS_DROPDOWNLIST > , 100, 75, 150, 80 > + LTEXT "Click Next setup of the installation device.", IDC_STATIC, 10, > 180 ,277, 20 > +END > + > +IDD_DRIVEPAGE DIALOGEX DISCARDABLE 0, 0, 317, 193 > +STYLE DS_SHELLFONT | DS_MODALFRAME | WS_POPUP | WS_VISIBLE | WS_CAPTION | > WS_SYSMENU > +CAPTION "ReactOS Setup" > +FONT 8, "MS Shell Dlg" > +BEGIN > + CONTROL "Partition for ReactOS installation", IDC_STATIC, "Button", > BS_GROUPBOX, 10,0,297,102 > + LISTBOX IDC_PARTITION, 20,13,277,70,LBS_HASSTRINGS | WS_VSCROLL > + PUSHBUTTON "&Create" ,IDC_PARTCREATE, 20,83,50,15 > + PUSHBUTTON "&Delete" ,IDC_PARTDELETE, 75,83,50,15 > + > + CONTROL "Installation folder", IDC_STATIC, "Button", BS_GROUPBOX, > 10,103,297,30 > + EDITTEXT IDC_PATH, 20,113,277,12, WS_VISIBLE > + > + CONTROL "Boot loader installation", IDC_STATIC, "Button", > BS_GROUPBOX, 10,136,297,40 > + > + CONTROL "Install boot loader on the hard disk (MBR)", > IDC_INSTFREELDR, "Button", BS_AUTORADIOBUTTON | WS_TABSTOP, 20, 147, 277, > 10 > + CONTROL "No installation of bootloader", IDC_NOINSTFREELDR, "Button", > BS_AUTORADIOBUTTON | WS_TABSTOP /* | WS_DISABLED*/ , 20, 159, 277, 10 > + LTEXT "Click Next to start the installation process.", IDC_STATIC, > 10, 180 ,277, 20 > +END > + > +IDD_PROCESSPAGE DIALOGEX 0, 0, 317, 193 > +STYLE DS_SHELLFONT | DS_MODALFRAME | WS_POPUP | WS_VISIBLE | WS_CAPTION | > WS_SYSMENU > +CAPTION "ReactOS Setup" > +FONT 8, "MS Shell Dlg" > +BEGIN > + CONTROL "Setup action", IDC_ACTION, "Button", BS_GROUPBOX, > 10,0,297,172 > + LTEXT "Install files...", IDC_ACTIVITY, 20, 50, 277, 10 > + LTEXT "test.txt", IDC_ITEM, 30, 80, 257, 10 > + CONTROL "", IDC_PROCESSPROGRESS, "msctls_progress32", > + PBS_SMOOTH | WS_CHILD | WS_VISIBLE | WS_BORDER, 20, 120, 277, > 8 > +END > + > + > +IDD_RESTARTPAGE DIALOGEX DISCARDABLE 0, 0, 317, 193 > +STYLE DS_SHELLFONT | DS_MODALFRAME | WS_POPUP | WS_VISIBLE | WS_CAPTION | > WS_SYSMENU > +CAPTION "Completing ReactOS Setup" > +FONT 8, "MS Shell Dlg" > +BEGIN > + CONTROL "Completing the first stage of ReactOS Setup", > IDC_FINISHTITLE, "Button", BS_GROUPBOX, 10,0,297,172 > + LTEXT "You have successfully completed the first stage of ReactOS > Setup.", IDC_STATIC, 20, 50, 277, 10 > + > + LTEXT "When you click Finish, your computer will restart.", > IDC_STATIC, 20, 80, 277, 10 > + CONTROL "", IDC_RESTART_PROGRESS, "msctls_progress32", PBS_SMOOTH | > WS_CHILD | WS_VISIBLE | WS_BORDER, 20, 120, 277, 8 > + LTEXT "If there is a CD in a drive, remove it. Then, to restart "\ > + "your computer, click Finish.", IDC_STATIC, 10, 180, 297, 20 > +END > + > + > +STRINGTABLE > +BEGIN > + IDS_LANGTITLE "Language Selection" > + IDS_LANGSUBTITLE "Choose language for setup and final system." > + IDS_TYPETITLE "Welcome to ReactOS Setup" > + IDS_TYPESUBTITLE "Choose setup type." > + IDS_DEVICETITLE "Setup the basic devices" > + IDS_DEVICESUBTITLE "Set the settings of display and keyboard." > + IDS_DRIVETITLE "Setup the installation partition and system folder" > + IDS_DRIVESUBTITLE "Prepare installation partition, system folder and > boot loader." > + IDS_PROCESSTITLE "Prepare partition, copy files and setup system" > + IDS_PROCESSSUBTITLE "Create and format partition, copy files, install > and setup boot loader" > + IDS_RESTARTTITLE "First stage of setup finished" > + IDS_RESTARTSUBTITLE "The first stage of setup has been completed, > restart to continue with second stage" > + IDS_ABORTSETUP "ReactOS is not completely installed on your computer. If > you quit Setup now, you will need to run Setup again to install Reactos. > Really quit?" > + IDS_ABORTSETUP2 "Abort installation?" > +END > /* EOF */ > > Modified: trunk/reactos/base/setup/reactos/reactos.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/base/setup/reactos/reactos… > ============================================================================== > --- trunk/reactos/base/setup/reactos/reactos.c [iso-8859-1] (original) > +++ trunk/reactos/base/setup/reactos/reactos.c [iso-8859-1] Fri Jul 18 > 04:07:54 2008 > @@ -21,18 +21,38 @@ > * COPYRIGHT: See COPYING in the top level directory > * PROJECT: ReactOS GUI first stage setup application > * FILE: subsys/system/reactos/reactos.c > - * PROGRAMMERS: Eric Kohl, Matthias Kupfer > + * PROGRAMMERS: Eric Kohl > + * Matthias Kupfer > */ > > #include <windows.h> > #include <commctrl.h> > #include <tchar.h> > +#include <setupapi.h> > > #include "resource.h" > > /* GLOBALS > ******************************************************************/ > > HFONT hTitleFont; > + > +struct > +{ > + LONG DestDiskNumber; // physical disk > + LONG DestPartNumber; // partition on disk > + LONG DestPartSize; // if partition doesn't exist, size of partition > + LONG FSType; // file system type on partition > + LONG MBRInstallType; // install bootloader > + LONG FormatPart; // type of format the partition > + WCHAR SelectedLangId[4]; // selected language > + WCHAR InstallationDirectory[MAX_PATH]; // installation directory on hdd > + WCHAR DefaultLang[20]; // default language > + WCHAR DefaultKBLayout[20]; // default keyboard layout > + BOOLEAN RepairUpdateFlag; // flag for update/repair an installed reactos > +} SetupData; > + > +TCHAR abort_msg[512],abort_title[64]; > +BOOL isUnattend; > > /* FUNCTIONS > ****************************************************************/ > > @@ -106,7 +126,7 @@ > SetWindowLong(hwndControl, GWL_STYLE, dwStyle & ~WS_SYSMENU); > > /* Hide and disable the 'Cancel' button at the moment, > - * later we use this button to cancel the setup process > + * we use this button to cancel the setup process > * like F3 in usetup > */ > hwndControl = GetDlgItem(GetParent(hwndDlg), IDCANCEL); > @@ -129,6 +149,7 @@ > { > case PSN_SETACTIVE: // Only "Finish" for closing the App > PropSheet_SetWizButtons(GetParent(hwndDlg), PSWIZB_FINISH); > + //PropSheet_SetWizButtons(GetParent(hwndDlg), PSWIZB_NEXT); > break; > default: > break; > @@ -140,6 +161,384 @@ > > } > return FALSE; > +} > + > +static INT_PTR CALLBACK > +LangSelDlgProc(HWND hwndDlg, > + UINT uMsg, > + WPARAM wParam, > + LPARAM lParam) > +{ > + switch (uMsg) > + { > + case WM_INITDIALOG: > + { > + HWND hwndControl; > + DWORD dwStyle; > + > + hwndControl = GetParent(hwndDlg); > + > + /* Center the wizard window */ > + CenterWindow (hwndControl); > + > + dwStyle = GetWindowLong(hwndControl, GWL_STYLE); > + SetWindowLong(hwndControl, GWL_STYLE, dwStyle & ~WS_SYSMENU); > + > + hwndControl = GetDlgItem(GetParent(hwndDlg), IDCANCEL); > + ShowWindow (hwndControl, SW_SHOW); > + EnableWindow (hwndControl, TRUE); > + > + /* Set title font */ > + /*SendDlgItemMessage(hwndDlg, > + IDC_STARTTITLE, > + WM_SETFONT, > + (WPARAM)hTitleFont, > + (LPARAM)TRUE);*/ > +} > + break; > + case WM_NOTIFY: > + { > + LPNMHDR lpnm = (LPNMHDR)lParam; > + > + switch (lpnm->code) > + { > + case PSN_SETACTIVE: > + PropSheet_SetWizButtons(GetParent(hwndDlg), PSWIZB_NEXT | PSWIZB_BACK); > + break; > + case PSN_QUERYCANCEL: > + SetWindowLong(hwndDlg, > DWL_MSGRESULT,MessageBox(GetParent(hwndDlg), abort_msg, abort_title, > MB_YESNO | MB_ICONQUESTION) != IDYES); > + return TRUE; > + default: > + break; > + } > + break; > + default: > + break; > + } > + > + } > + return FALSE; > +} > + > +static INT_PTR CALLBACK > +TypeDlgProc(HWND hwndDlg, > + UINT uMsg, > + WPARAM wParam, > + LPARAM lParam) > +{ > + switch (uMsg) > + { > + case WM_INITDIALOG: > + { > + HWND hwndControl; > + DWORD dwStyle; > + > + hwndControl = GetParent(hwndDlg); > + > + /* Center the wizard window */ > + CenterWindow (hwndControl); > + > + dwStyle = GetWindowLong(hwndControl, GWL_STYLE); > + SetWindowLong(hwndControl, GWL_STYLE, dwStyle & ~WS_SYSMENU); > + > + CheckDlgButton(hwndDlg, IDC_INSTALL, BST_CHECKED); > + > + /* Set title font */ > + /*SendDlgItemMessage(hwndDlg, > + IDC_STARTTITLE, > + WM_SETFONT, > + (WPARAM)hTitleFont, > + (LPARAM)TRUE);*/ > +} > + break; > + case WM_NOTIFY: > + { > + LPNMHDR lpnm = (LPNMHDR)lParam; > + > + switch (lpnm->code) > + { > + case PSN_SETACTIVE: > + PropSheet_SetWizButtons(GetParent(hwndDlg), PSWIZB_NEXT | PSWIZB_BACK); > + break; > + case PSN_QUERYCANCEL: > + SetWindowLong(hwndDlg, > DWL_MSGRESULT,MessageBox(GetParent(hwndDlg), abort_msg, abort_title, > MB_YESNO | MB_ICONQUESTION) != IDYES); > + return TRUE; > + default: > + break; > + } > + break; > + default: > + break; > + } > + > + } > + return FALSE; > +} > + > +static INT_PTR CALLBACK > +DeviceDlgProc(HWND hwndDlg, > + UINT uMsg, > + WPARAM wParam, > + LPARAM lParam) > +{ > + switch (uMsg) > + { > + case WM_INITDIALOG: > + { > + HWND hwndControl; > + DWORD dwStyle; > + > + hwndControl = GetParent(hwndDlg); > + > + /* Center the wizard window */ > + CenterWindow (hwndControl); > + > + dwStyle = GetWindowLong(hwndControl, GWL_STYLE); > + SetWindowLong(hwndControl, GWL_STYLE, dwStyle & ~WS_SYSMENU); > + > + /* Set title font */ > + /*SendDlgItemMessage(hwndDlg, > + IDC_STARTTITLE, > + WM_SETFONT, > + (WPARAM)hTitleFont, > + (LPARAM)TRUE);*/ > +} > + break; > + case WM_NOTIFY: > + { > + LPNMHDR lpnm = (LPNMHDR)lParam; > + > + switch (lpnm->code) > + { > + case PSN_SETACTIVE: > + PropSheet_SetWizButtons(GetParent(hwndDlg), PSWIZB_NEXT | PSWIZB_BACK); > + break; > + case PSN_QUERYCANCEL: > + SetWindowLong(hwndDlg, > DWL_MSGRESULT,MessageBox(GetParent(hwndDlg), abort_msg, abort_title, > MB_YESNO | MB_ICONQUESTION) != IDYES); > + return TRUE; > + default: > + break; > + } > + break; > + default: > + break; > + } > + > + } > + return FALSE; > +} > + > +static INT_PTR CALLBACK > +DriveDlgProc(HWND hwndDlg, > + UINT uMsg, > + WPARAM wParam, > + LPARAM lParam) > +{ > + switch (uMsg) > + { > + case WM_INITDIALOG: > + { > + HWND hwndControl; > + DWORD dwStyle; > + > + hwndControl = GetParent(hwndDlg); > + > + /* Center the wizard window */ > + CenterWindow (hwndControl); > + > + dwStyle = GetWindowLong(hwndControl, GWL_STYLE); > + SetWindowLong(hwndControl, GWL_STYLE, dwStyle & ~WS_SYSMENU); > + > + CheckDlgButton(hwndDlg, IDC_INSTFREELDR, BST_CHECKED); > + /* Set title font */ > + /*SendDlgItemMessage(hwndDlg, > + IDC_STARTTITLE, > + WM_SETFONT, > + (WPARAM)hTitleFont, > + (LPARAM)TRUE);*/ > +} > + break; > + case WM_NOTIFY: > + { > + LPNMHDR lpnm = (LPNMHDR)lParam; > + > + switch (lpnm->code) > + { > + case PSN_SETACTIVE: > + PropSheet_SetWizButtons(GetParent(hwndDlg), PSWIZB_NEXT | PSWIZB_BACK); > + break; > + case PSN_QUERYCANCEL: > + SetWindowLong(hwndDlg, > DWL_MSGRESULT,MessageBox(GetParent(hwndDlg), abort_msg, abort_title, > MB_YESNO | MB_ICONQUESTION) != IDYES); > + return TRUE; > + default: > + break; > + } > + break; > + default: > + break; > + } > + > + } > + return FALSE; > +} > + > +static INT_PTR CALLBACK > +ProcessDlgProc(HWND hwndDlg, > + UINT uMsg, > + WPARAM wParam, > + LPARAM lParam) > +{ > + switch (uMsg) > + { > + case WM_INITDIALOG: > + { > + HWND hwndControl; > + DWORD dwStyle; > + > + hwndControl = GetParent(hwndDlg); > + > + /* Center the wizard window */ > + CenterWindow (hwndControl); > + > + dwStyle = GetWindowLong(hwndControl, GWL_STYLE); > + SetWindowLong(hwndControl, GWL_STYLE, dwStyle & ~WS_SYSMENU); > + > + hwndControl = GetDlgItem(GetParent(hwndDlg), IDCANCEL); > + ShowWindow (hwndControl, SW_HIDE); > + EnableWindow (hwndControl, FALSE); > + > + /* Set title font */ > + /*SendDlgItemMessage(hwndDlg, > + IDC_STARTTITLE, > + WM_SETFONT, > + (WPARAM)hTitleFont, > + (LPARAM)TRUE);*/ > +} > + break; > + case WM_NOTIFY: > + { > + LPNMHDR lpnm = (LPNMHDR)lParam; > + > + switch (lpnm->code) > + { > + case PSN_SETACTIVE: > + PropSheet_SetWizButtons(GetParent(hwndDlg), PSWIZB_NEXT ); > + break; > + default: > + break; > + } > + break; > + default: > + break; > + } > + > + } > + return FALSE; > +} > + > +static INT_PTR CALLBACK > +RestartDlgProc(HWND hwndDlg, > + UINT uMsg, > + WPARAM wParam, > + LPARAM lParam) > +{ > + switch (uMsg) > + { > + case WM_INITDIALOG: > + { > + HWND hwndControl; > + DWORD dwStyle; > + > + hwndControl = GetParent(hwndDlg); > + > + /* Center the wizard window */ > + CenterWindow (hwndControl); > + > + dwStyle = GetWindowLong(hwndControl, GWL_STYLE); > + SetWindowLong(hwndControl, GWL_STYLE, dwStyle & ~WS_SYSMENU); > + > + /* Set title font */ > + /*SendDlgItemMessage(hwndDlg, > + IDC_STARTTITLE, > + WM_SETFONT, > + (WPARAM)hTitleFont, > + (LPARAM)TRUE);*/ > + } > + break; > + case WM_TIMER: > + { > + INT Position; > + HWND hWndProgress; > + > + hWndProgress = GetDlgItem(hwndDlg, IDC_RESTART_PROGRESS); > + Position = SendMessage(hWndProgress, PBM_GETPOS, 0, 0); > + if (Position == 300) > + { > + KillTimer(hwndDlg, 1); > + PropSheet_PressButton(GetParent(hwndDlg), PSBTN_FINISH); > + } > + else > + { > + SendMessage(hWndProgress, PBM_SETPOS, Position + 1, 0); > + } > + return TRUE; > + } > + case WM_DESTROY: > + return TRUE; > + case WM_NOTIFY: > + { > + LPNMHDR lpnm = (LPNMHDR)lParam; > + > + switch (lpnm->code) > + { > + case PSN_SETACTIVE: // Only "Finish" for closing the App > + PropSheet_SetWizButtons(GetParent(hwndDlg), PSWIZB_FINISH); > + SendDlgItemMessage(hwndDlg, IDC_RESTART_PROGRESS, > PBM_SETRANGE, 0, MAKELPARAM(0, 300)); > + SendDlgItemMessage(hwndDlg, IDC_RESTART_PROGRESS, > PBM_SETPOS, 0, 0); > + SetTimer(hwndDlg, 1, 50, NULL); > + break; > + default: > + break; > + } > + break; > + default: > + break; > + } > + > + } > + return FALSE; > +} > + > +BOOL isUnattendSetup() > +{ > + WCHAR szPath[MAX_PATH]; > + HINF hUnattendedInf; > + INFCONTEXT InfContext; > + TCHAR szValue[MAX_PATH]; > + DWORD LineLength; > + //HKEY hKey; > + BOOL result = 0; > + > + GetCurrentDirectoryW(MAX_PATH, szPath); // FIXME > + > + wcscat(szPath, L"\\unattend.inf"); > + hUnattendedInf = SetupOpenInfFileW(szPath, NULL, INF_STYLE_OLDNT, NULL); > + if (hUnattendedInf != INVALID_HANDLE_VALUE) > + { > + if (SetupFindFirstLine(hUnattendedInf, _T("Unattend"), > + _T("UnattendSetupEnabled"),&InfContext)) > + { > + if (SetupGetStringField(&InfContext, 1, szValue, > + sizeof(szValue) / sizeof(TCHAR), &LineLength) && > + (_tcsicmp(szValue, _T("yes"))==0)) > + { > + result = 1; // unattendSetup enabled > + // read values and store in SetupData > + } > + } > + SetupCloseInfFile(hUnattendedInf); > + } > + return result; > } > > int WINAPI > @@ -149,11 +548,18 @@ > int nCmdShow) > { > PROPSHEETHEADER psh; > - HPROPSHEETPAGE ahpsp[1]; > + HPROPSHEETPAGE ahpsp[7]; > PROPSHEETPAGE psp = {0}; > UINT nPages = 0; > - > - /* Create the Start page */ > + isUnattend = isUnattendSetup(); > + > + if (!isUnattend) > + { > + > + LoadString(hInst,IDS_ABORTSETUP, abort_msg, > sizeof(abort_msg)/sizeof(TCHAR)); > + LoadString(hInst,IDS_ABORTSETUP2, > abort_title,sizeof(abort_title)/sizeof(TCHAR)); > + > + /* Create the Start page, until setup is working */ > psp.dwSize = sizeof(PROPSHEETPAGE); > psp.dwFlags = PSP_DEFAULT | PSP_HIDEHEADER; > psp.hInstance = hInst; > @@ -162,7 +568,77 @@ > psp.pszTemplate = MAKEINTRESOURCE(IDD_STARTPAGE); > ahpsp[nPages++] = CreatePropertySheetPage(&psp); > > - // Here we can add the next pages and switch on later > + /* Create language selection page */ > + psp.dwSize = sizeof(PROPSHEETPAGE); > + psp.dwFlags = PSP_DEFAULT | PSP_USEHEADERTITLE | PSP_USEHEADERSUBTITLE; > + psp.pszHeaderTitle = MAKEINTRESOURCE(IDS_LANGTITLE); > + psp.pszHeaderSubTitle = MAKEINTRESOURCE(IDS_LANGSUBTITLE); > + psp.hInstance = hInst; > + psp.lParam = 0; > + psp.pfnDlgProc = LangSelDlgProc; > + psp.pszTemplate = MAKEINTRESOURCE(IDD_LANGSELPAGE); > + ahpsp[nPages++] = CreatePropertySheetPage(&psp); > + // Change language with "SetThreadLocale(langid)" > + > + /* Create install type selection page */ > + psp.dwSize = sizeof(PROPSHEETPAGE); > + psp.dwFlags = PSP_DEFAULT | PSP_USEHEADERTITLE | PSP_USEHEADERSUBTITLE; > + psp.pszHeaderTitle = MAKEINTRESOURCE(IDS_TYPETITLE); > + psp.pszHeaderSubTitle = MAKEINTRESOURCE(IDS_TYPESUBTITLE); > + psp.hInstance = hInst; > + psp.lParam = 0; > + psp.pfnDlgProc = TypeDlgProc; > + psp.pszTemplate = MAKEINTRESOURCE(IDD_TYPEPAGE); > + ahpsp[nPages++] = CreatePropertySheetPage(&psp); > + > + /* Create device settings page */ > + psp.dwSize = sizeof(PROPSHEETPAGE); > + psp.dwFlags = PSP_DEFAULT | PSP_USEHEADERTITLE | PSP_USEHEADERSUBTITLE; > + psp.pszHeaderTitle = MAKEINTRESOURCE(IDS_DEVICETITLE); > + psp.pszHeaderSubTitle = MAKEINTRESOURCE(IDS_DEVICESUBTITLE); > + psp.hInstance = hInst; > + psp.lParam = 0; > + psp.pfnDlgProc = DeviceDlgProc; > + psp.pszTemplate = MAKEINTRESOURCE(IDD_DEVICEPAGE); > + ahpsp[nPages++] = CreatePropertySheetPage(&psp); > + > + /* Create install device settings page / boot method / install > directory*/ > + psp.dwSize = sizeof(PROPSHEETPAGE); > + psp.dwFlags = PSP_DEFAULT | PSP_USEHEADERTITLE | PSP_USEHEADERSUBTITLE; > + psp.pszHeaderTitle = MAKEINTRESOURCE(IDS_DRIVETITLE); > + psp.pszHeaderSubTitle = MAKEINTRESOURCE(IDS_DRIVESUBTITLE); > + psp.hInstance = hInst; > + psp.lParam = 0; > + psp.pfnDlgProc = DriveDlgProc; > + psp.pszTemplate = MAKEINTRESOURCE(IDD_DRIVEPAGE); > + ahpsp[nPages++] = CreatePropertySheetPage(&psp); > + > + } > + > + /* Create installation progress page */ > + psp.dwSize = sizeof(PROPSHEETPAGE); > + psp.dwFlags = PSP_DEFAULT | PSP_USEHEADERTITLE | PSP_USEHEADERSUBTITLE; > + psp.pszHeaderTitle = MAKEINTRESOURCE(IDS_PROCESSTITLE); > + psp.pszHeaderSubTitle = MAKEINTRESOURCE(IDS_PROCESSSUBTITLE); > + psp.hInstance = hInst; > + psp.lParam = 0; > + psp.pfnDlgProc = ProcessDlgProc; > + psp.pszTemplate = MAKEINTRESOURCE(IDD_PROCESSPAGE); > + ahpsp[nPages++] = CreatePropertySheetPage(&psp); > + > + if (!isUnattend) > + { > + /* Create finish to reboot page */ > + psp.dwSize = sizeof(PROPSHEETPAGE); > + psp.dwFlags = PSP_DEFAULT | PSP_USEHEADERTITLE | PSP_USEHEADERSUBTITLE; > + psp.pszHeaderTitle = MAKEINTRESOURCE(IDS_RESTARTTITLE); > + psp.pszHeaderSubTitle = MAKEINTRESOURCE(IDS_RESTARTSUBTITLE); > + psp.hInstance = hInst; > + psp.lParam = 0; > + psp.pfnDlgProc = RestartDlgProc; > + psp.pszTemplate = MAKEINTRESOURCE(IDD_RESTARTPAGE); > + ahpsp[nPages++] = CreatePropertySheetPage(&psp); > + } > > /* Create the property sheet */ > psh.dwSize = sizeof(PROPSHEETHEADER); > > Modified: trunk/reactos/base/setup/reactos/reactos.rbuild > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/base/setup/reactos/reactos… > ============================================================================== > --- trunk/reactos/base/setup/reactos/reactos.rbuild [iso-8859-1] > (original) > +++ trunk/reactos/base/setup/reactos/reactos.rbuild [iso-8859-1] Fri Jul > 18 04:07:54 2008 > @@ -9,6 +9,7 @@ > <library>gdi32</library> > <library>user32</library> > <library>comctl32</library> > + <library>setupapi</library> > <file>reactos.c</file> > <file>reactos.rc</file> > </module> > > Modified: trunk/reactos/base/setup/reactos/res/header.bmp > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/base/setup/reactos/res/hea… > ============================================================================== > Binary files - no diff available. > > Modified: trunk/reactos/base/setup/reactos/resource.h > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/base/setup/reactos/resourc… > ============================================================================== > --- trunk/reactos/base/setup/reactos/resource.h [iso-8859-1] (original) > +++ trunk/reactos/base/setup/reactos/resource.h [iso-8859-1] Fri Jul 18 > 04:07:54 2008 > @@ -7,8 +7,47 @@ > > #define IDC_STATIC -1 > > -#define IDD_STARTPAGE 2000 > -#define IDC_STARTTITLE 2001 > +#define IDD_STARTPAGE 2000 > +#define IDC_STARTTITLE 2001 > +#define IDD_LANGSELPAGE 2002 > +#define IDS_LANGTITLE 2003 > +#define IDS_LANGSUBTITLE 2004 > +#define IDC_LANGUAGES 2005 > +#define IDD_TYPEPAGE 2006 > +#define IDS_TYPETITLE 2007 > +#define IDS_TYPESUBTITLE 2008 > +#define IDC_INSTALL 2009 > +#define IDC_SETUP 2010 > +#define IDD_DEVICEPAGE 2011 > +#define IDS_DEVICETITLE 2012 > +#define IDS_DEVICESUBTITLE 2013 > +#define IDC_COMPUTER 2014 > +#define IDC_DISPLAY 2015 > +#define IDC_KEYBOARD 2016 > +#define IDC_KEYLAYOUT 2017 > +#define IDD_DRIVEPAGE 2018 > +#define IDS_DRIVETITLE 2019 > +#define IDS_DRIVESUBTITLE 2020 > +#define IDC_PARTITION 2021 > +#define IDC_PARTCREATE 2022 > +#define IDC_PARTDELETE 2023 > +#define IDC_INSTFREELDR 2024 > +#define IDC_NOINSTFREELDR 2025 > +#define IDC_PATH 2026 > +#define IDD_PROCESSPAGE 2027 > +#define IDS_PROCESSTITLE 2028 > +#define IDS_PROCESSSUBTITLE 2029 > +#define IDC_ACTIVITY 2030 > +#define IDC_ITEM 2031 > +#define IDC_PROCESSPROGRESS 2032 > +#define IDD_RESTARTPAGE 2033 > +#define IDS_RESTARTTITLE 2034 > +#define IDS_RESTARTSUBTITLE 2035 > +#define IDC_FINISHTITLE 2036 > +#define IDC_RESTART_PROGRESS 2037 > +#define IDS_ABORTSETUP 2038 > +#define IDS_ABORTSETUP2 2039 > +#define IDC_ACTION 2040 > > #define IDI_MAIN 3000 > > >

17 years, 2 months

1
0
0 0

Haiku and ReactOS "Pair Up" at LinuxWorld Expo 08

by James Tabor

Hi! A show is coming up and we need to look good. Haiku looks good and it has networtking and draws objects very well. Please check our drawing with test apps and look at networking and see where we are on hardware support. I know there are bugs maybe by August 4th we can get back some basic networking with hardware. PCI n2k? or FET? KPANIC! James

17 years, 2 months

6
9
0 0

Re: [ros-dev] [ros-diffs] [cfinck] 34558: Commit my test suite I used for verifying the behaviours of wctomb, wcstombs and WideCharToMultiByte and writing the reimplementations for ReactOS on request of Stefan

by Aleksey Bragin

Maybe it's worth adding these tests to msvcrt test suite and submit to Wine? WBR, Aleksey Bragin. On Jul 17, 2008, at 2:08 AM, cfinck(a)svn.reactos.org wrote: > Author: cfinck > Date: Wed Jul 16 17:08:58 2008 > New Revision: 34558 > > URL: http://svn.reactos.org/svn/reactos?rev=34558&view=rev > Log: > Commit my test suite I used for verifying the behaviours of wctomb, > wcstombs and WideCharToMultiByte and writing the reimplementations > for ReactOS on request of Stefan

17 years, 2 months

1
0
0 0

Re: [ros-dev] [ros-diffs] [pschweitzer] 34524: Updated kernel exports to match with r34517

by Alex Ionescu

Please remember to fix exports for other architectures as well. We really need a spec file for the kernel... Best regards, Alex Ionescu On Tue, Jul 15, 2008 at 6:56 AM, <pschweitzer(a)svn.reactos.org> wrote: > Author: pschweitzer > Date: Tue Jul 15 08:56:54 2008 > New Revision: 34524 > > URL: http://svn.reactos.org/svn/reactos?rev=34524&view=rev > Log: > Updated kernel exports to match with r34517 > > Modified: > branches/pierre-fsd/ntoskrnl/ntoskrnl_i386.def > > Modified: branches/pierre-fsd/ntoskrnl/ntoskrnl_i386.def > URL: http://svn.reactos.org/svn/reactos/branches/pierre-fsd/ntoskrnl/ntoskrnl_i3… > ============================================================================== > --- branches/pierre-fsd/ntoskrnl/ntoskrnl_i386.def [iso-8859-1] (original) > +++ branches/pierre-fsd/ntoskrnl/ntoskrnl_i386.def [iso-8859-1] Tue Jul 15 08:56:54 2008 > @@ -182,7 +182,7 @@ > @ExiReleaseFastMutex@4=@ExReleaseFastMutex@4 > @ExiTryToAcquireFastMutex@4=@ExTryToAcquireFastMutex@4 > FsRtlAcquireFileExclusive > -;FsRtlAddBaseMcbEntry > +FsRtlAddBaseMcbEntry > FsRtlAddLargeMcbEntry > FsRtlAddMcbEntry > FsRtlAddToTunnelCache > @@ -216,7 +216,7 @@ > FsRtlFindInTunnelCache > FsRtlFreeFileLock > FsRtlGetFileSize > -;FsRtlGetNextBaseMcbEntry > +FsRtlGetNextBaseMcbEntry > FsRtlGetNextFileLock > FsRtlGetNextLargeMcbEntry > FsRtlGetNextMcbEntry > @@ -224,7 +224,7 @@ > FsRtlIncrementCcFastReadNotPossible > FsRtlIncrementCcFastReadResourceMiss > FsRtlIncrementCcFastReadWait > -;FsRtlInitializeBaseMcb > +FsRtlInitializeBaseMcb > FsRtlInitializeFileLock@12 > FsRtlInitializeLargeMcb > FsRtlInitializeMcb > @@ -240,10 +240,10 @@ > FsRtlIsPagingFile > FsRtlIsTotalDeviceFailure > FsRtlLegalAnsiCharacterArray=_FsRtlLegalAnsiCharacterArray > -;FsRtlLookupBaseMcbEntry > +FsRtlLookupBaseMcbEntry > FsRtlLookupLargeMcbEntry > -;FsRtlLookupLastBaseMcbEntry > -;FsRtlLookupLastBaseMcbEntryAndIndex > +FsRtlLookupLastBaseMcbEntry > +FsRtlLookupLastBaseMcbEntryAndIndex > FsRtlLookupLastLargeMcbEntry > FsRtlLookupLastLargeMcbEntryAndIndex > FsRtlLookupLastMcbEntry > @@ -267,7 +267,7 @@ > FsRtlNotifyReportChange > FsRtlNotifyUninitializeSync > FsRtlNotifyVolumeEvent > -;FsRtlNumberOfRunsInBaseMcb > +FsRtlNumberOfRunsInBaseMcb > FsRtlNumberOfRunsInLargeMcb > FsRtlNumberOfRunsInMcb > FsRtlOplockFsctrl > @@ -281,21 +281,21 @@ > FsRtlRegisterFileSystemFilterCallbacks > FsRtlRegisterUncProvider > FsRtlReleaseFile > -;FsRtlRemoveBaseMcbEntry > +FsRtlRemoveBaseMcbEntry > FsRtlRemoveLargeMcbEntry > FsRtlRemoveMcbEntry > FsRtlRemovePerFileObjectContext > FsRtlRemovePerStreamContext > -;FsRtlResetBaseMcb > +FsRtlResetBaseMcb > FsRtlResetLargeMcb > -;FsRtlSplitBaseMcb > +FsRtlSplitBaseMcb > FsRtlSplitLargeMcb > FsRtlSyncVolumes > FsRtlTeardownPerStreamContexts > -;FsRtlTruncateBaseMcb > +FsRtlTruncateBaseMcb > FsRtlTruncateLargeMcb > FsRtlTruncateMcb > -;FsRtlUninitializeBaseMcb > +FsRtlUninitializeBaseMcb > FsRtlUninitializeFileLock@4 > FsRtlUninitializeLargeMcb > FsRtlUninitializeMcb > >

17 years, 2 months

1
0
0 0

[ros-diffs] [mpiulachs] 34223: - hackfix unbootable image (part 1/2)

by James Tabor

Hi, Does "make install" work for you by any chance? I get this: bash-3.1# make install mingw32-make: *** No rule to make target `boot/bootdata/i386/hivecls.inf', needed by `reactos/system32/config/default'. Stop.

17 years, 2 months

1
1
0 0

Re: [ros-dev] when will I return Magnus Olsen aka GreatLord (gedmurphy)

by Cameron Gutman

I tested some of GreatLord's regressions and I can see how Aleksey would get angry about all the fixes he has to do to GreatLord's code, but GreatLord has fixed a whole lot more than he has broken and Fireball chasing around 'if (Foo == FALSE)' and changing it to 'if (!Foo)' seems pointless. We've got plenty of code formatted as 'if (Foo == FALSE)' in the kernel that works great. Aleksey is making more work for himself by making needless changes to GreatLord's code. All that is needed is someone with commit access that is willing to correct GreatLord's comments. I don't have a problem with finding a regression of GL's here or there. Sure he should test his code before committing but as far as breakages, but his code usually correct and all coders create breakages one time or another.

17 years, 2 months

7
10
0 0

The ABCs of DCEs

by James Tabor

Hi, I did some research and found something very interesting. I kept thinking about the last DCE commit (34289). I had a guess and modified the user32 test for wine. The results are very clear. Apparently windows does not care for which dc is returned if it is Cached or a bug since hWnd is the same. When DCX_NORESETATTRS is set when calling GetDCEx; "Does not reset the attributes of this DC to the default attributes when this DC is released." We do this correctly in ReleaseDC. So the next GetDCEx should keep the original DC data for the next set of tests. Wine test is completely incorrect. So all of our DCE attributes code is good to go. Windows did not pass the modified "Same hDC" check and we still fail the "ROP" check. See the windows results at the end of this message. //////// Changes to user32/tests/dce.c: ReleaseDC( hwnd_cache, hdc ); hdc = GetDCEx( hwnd_cache, 0, DCX_USESTYLE | DCX_NORESETATTRS ); <------ DCX_NORESETATTRS rop = GetROP2( hdc ); ok( rop == def_rop || rop == R2_WHITE, "wrong ROP2 %d after release\n", rop ); ReleaseDC( hwnd_cache, hdc ); + old_hdc = hdc; hdc = GetDCEx( hwnd_cache, 0, DCX_USESTYLE ); rop = GetROP2( hdc ); + ok( old_hdc == hdc, "didn't get same DC %p/%p\n", old_hdc, hdc ); ok( rop == def_rop, "wrong ROP2 %d after release\n", rop ); ReleaseDC( hwnd_cache, hdc ); /* test own DC */ //////// //////// Results from XP: Microsoft Windows XP [Version 5.1.2600] (C) Copyright 1985-2001 Microsoft Corp. Z:\>e: E:\>user32_crosstest dce dce.c:79: Test failed: didn't get same DC F5010866/FC0107E0 dce: 77 tests executed (0 marked as todo, 1 failure), 0 skipped. E:\> /////////

17 years, 2 months

1
1
0 0

Re: [ros-dev] [ros-diffs] [jimtabor] 34276: GetLastActivePopup is still unimplemented, we return the current window handle if it is valid.

by Aleksey Bragin

It would make sense to add a WARN there or something like that, so it could be seen that it is halfplemented only. WBR, Aleksey. On Jul 3, 2008, at 11:17 AM, jimtabor(a)svn.reactos.org wrote: > Author: jimtabor > Date: Thu Jul 3 02:17:32 2008 > New Revision: 34276 > > URL: http://svn.reactos.org/svn/reactos?rev=34276&view=rev > Log: > GetLastActivePopup is still unimplemented, we return the current > window handle if it is valid. > > Modified: > trunk/reactos/dll/win32/user32/windows/window.c > > Modified: trunk/reactos/dll/win32/user32/windows/window.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/ > user32/windows/window.c?rev=34276&r1=34275&r2=34276&view=diff > ====================================================================== > ======== > --- trunk/reactos/dll/win32/user32/windows/window.c [iso-8859-1] > (original) > +++ trunk/reactos/dll/win32/user32/windows/window.c [iso-8859-1] > Thu Jul 3 02:17:32 2008 > @@ -921,8 +921,24 @@ > HWND STDCALL > GetLastActivePopup(HWND hWnd) > { > - UNIMPLEMENTED; > - return 0; > + PWINDOW Wnd, WndParent; > + HWND Ret = NULL; > + > + Wnd = ValidateHwnd(hWnd); > + if (Wnd != NULL) > + { > + _SEH_TRY > + { > + WndParent = NULL; > + Ret = hWnd; > + } > + _SEH_HANDLE > + { > + /* Do nothing */ > + } > + _SEH_END; > + } > + return Ret; > } > > >

17 years, 2 months

1
0
0 0

Re: [ros-dev] [ros-diffs] [dchapyshev] 34135: - Add fontext.dll

by Heis Spiter

I also agree. About the last point, in Ged's mail, I'm afraid to say I've real difficulties to code with such build time. I'm obliged to work on outdated revisons, and on partial builds. That's really insane. P. Schweitzer -------------------------------------------------- From: "gedmurphy" <gedmurphy(a)gmail.com> Sent: Wednesday, July 02, 2008 5:49 PM To: "'ReactOS Development List'" <ros-dev(a)reactos.org> Subject: Re: [ros-dev] [ros-diffs] [dchapyshev] 34135: - Add fontext.dll > I completely agree, this needs to be clamped down on. Do we really need 78 > different keyboard layouts at this point? > It's fine for the people with mega fast systems and time on their hands, > but > most people don't fall into this category. > > I now try to avoid building as much as possible and I suspect more people > will be following suit if the build time continues to increase. > > Ged > >

17 years, 2 months

5
4
0 0