- Ros-dev - ReactOS.org

gdi object code optimization
by James Tabor 14 Dec '07

14 Dec '07

Hi! Let us start on this now.... It is time to restructure the GDI OBJ Lock Unlock mess! Don't wait for me. I'm working on the DCE issue which is a mess due to gdiobj.c over think object locking system. The new ideas I have will not be compatible with the current system. Thanks, James

3 2

GDI_TABLE_ENTRY structure
by James Tabor 14 Dec '07

14 Dec '07

Hi! Sorry for the delay here,,, This is what we know to be correct sofar. The "Book" section 3.4 GdiTableCell structure is not necessarily correct. typedef struct _GDI_TABLE_ENTRY { PVOID KernelData; SHORT Count:15; Count number of refs. SHORT Lock:1; Does set if locked by process. It also explains why the count shows 1 -> 3 most of the time. SHORT ProcessId; Process Id is here. SHORT nUpper; should match the upper half of the handle. CHAR ObjectType; example-> 0x0401, // not all memdc, dc =1, etc,,, CHAR Flags; --> 0x04 is here, set if memdc, sometimes~. PVOID UserData; } GDI_TABLE_ENTRY, *PGDI_TABLE_ENTRY; Thanks, James

2 1

[ros-diffs] [jimtabor] 31204: Up the handle count to 0x10000, reset adjustment to support change. Add device capabilities to handle table.
by Timo Kreuzer 14 Dec '07

14 Dec '07

why waste the last handle? > author: jimtabor > Date: Thu Dec 13 23:27:28 2007 > New Revision: 31204 > - for ( i = RESERVE_ENTRIES_COUNT; i < GDI_HANDLE_COUNT; i++ ) > + for ( i = RESERVE_ENTRIES_COUNT; i < GDI_HANDLE_COUNT-1; i++ > - if (HandleIndex >= GDI_HANDLE_COUNT) > + if (HandleIndex >= GDI_HANDLE_COUNT-1)

3 3

build error with RoseBE on Fedora 8
by kevin yin 14 Dec '07

14 Dec '07

hello everyone: there some chinese character in the attechment( make.log ),have replaced to english. there is some output on the console below: [root@YINSG664A RosBE-Unix-0.3.6]# ./RosBE-Builder.sh ******************************************************************************* * ReactOS Build Environment for Unix-based Operating Systems * * Builder Tool * * by Colin Finck <mail(a)colinfinck.de> * * * * Version 0.3.6 * ******************************************************************************* This script compiles and installs a complete Build Environment for building ReactOS. Checking for the needed tools... Checking for bison... OK Checking for flex... OK Checking for gcc... OK Checking for g++... OK Checking for grep... OK Checking for makeinfo... OK Checking for GNU Make... OK Installation Directory In which directory do you want to install it? Enter the path to the directory here or simply press ENTER to install it into the default directory. [/usr/RosBE] The directory "/usr/RosBE" does not exist. The installation script will create it for you. Ready to start Ready to build and install the ReactOS Build Environment. Press ENTER to continue or any other key to exit. Building... Extracting mingw-runtime... OK Extracting w32api... OK Extracting binutils... OK Configuring binutils... OK Building binutils... FAILED Please take a look at the log file "/home/enjoyo/RosBE-Unix-0.3.6/make.log" If you did not do something wrong, please save the log file and contact the ReactOS Team. Aborted! make[1]: Entering directory `/home/enjoyo/RosBE-Unix-0.3.6/sources/binutils-build' mkdir -p -- ./intl Configuring in ./intl configure: creating cache ./config.cache checking whether make sets $(MAKE)... yes checking for a BSD-compatible install... /usr/bin/install -c checking whether NLS is requested... no checking for msgfmt... /usr/bin/msgfmt checking for gmsgfmt... /usr/bin/msgfmt checking for xgettext... /usr/bin/xgettext checking for msgmerge... /usr/bin/msgmerge checking for i686-pc-linux-gnu-gcc... gcc checking for C compiler default output file name... a.out checking whether the C compiler works... yes checking whether we are cross compiling... no checking for suffix of executables... checking for suffix of object files... o checking whether we are using the GNU C compiler... yes checking whether gcc accepts -g... yes checking for gcc option to accept ANSI C... none needed checking build system type... i686-pc-linux-gnu checking host system type... i686-pc-linux-gnu checking for i686-pc-linux-gnu-ranlib... ranlib checking for library containing strerror... none required checking how to run the C preprocessor... gcc -E checking for egrep... grep -E checking for ANSI C header files... yes checking for an ANSI C-conforming const... yes checking for inline... inline checking for sys/types.h... yes checking for sys/stat.h... yes checking for stdlib.h... yes checking for string.h... yes checking for memory.h... yes checking for strings.h... yes checking for inttypes.h... yes checking for stdint.h... yes checking for unistd.h... yes checking for off_t... yes checking for size_t... yes checking for working alloca.h... yes checking for alloca... yes checking for stdlib.h... (cached) yes checking for unistd.h... (cached) yes checking for getpagesize... yes checking for working mmap... yes checking whether we are using the GNU C Library 2.1 or newer... yes checking whether integer division by zero raises SIGFPE... yes checking for inttypes.h... yes checking for stdint.h... yes checking for unsigned long long... yes checking for inttypes.h... yes checking whether the inttypes.h PRIxNN macros are broken... no checking for ld used by GCC... ld checking if the linker (ld) is GNU ld... yes checking for shared library run path origin... done checking argz.h usability... yes checking argz.h presence... yes checking for argz.h... yes checking limits.h usability... yes checking limits.h presence... yes checking for limits.h... yes checking locale.h usability... yes checking locale.h presence... yes checking for locale.h... yes checking nl_types.h usability... yes checking nl_types.h presence... yes checking for nl_types.h... yes checking malloc.h usability... yes checking malloc.h presence... yes checking for malloc.h... yes checking stddef.h usability... yes checking stddef.h presence... yes checking for stddef.h... yes checking for stdlib.h... (cached) yes checking for string.h... (cached) yes checking for unistd.h... (cached) yes checking sys/param.h usability... yes checking sys/param.h presence... yes checking for sys/param.h... yes checking for feof_unlocked... yes checking for fgets_unlocked... yes checking for getc_unlocked... yes checking for getcwd... yes checking for getegid... yes checking for geteuid... yes checking for getgid... yes checking for getuid... yes checking for mempcpy... yes checking for munmap... yes checking for putenv... yes checking for setenv... yes checking for setlocale... yes checking for stpcpy... yes checking for strcasecmp... yes checking for strdup... yes checking for strtoul... yes checking for tsearch... yes checking for __argz_count... yes checking for __argz_stringify... yes checking for __argz_next... yes checking for __fsetlocking... yes checking for iconv... yes checking for iconv declaration... extern size_t iconv (iconv_t cd, char * *inbuf, size_t *inbytesleft, char * *outbuf, size_t *outbytesleft); checking for nl_langinfo and CODESET... yes checking for LC_MESSAGES... yes checking for bison... bison checking version of bison... 2.3, ok checking whether NLS is requested... no checking whether to use NLS... no checking for aclocal... aclocal checking for autoconf... autoconf checking for autoheader... autoheader updating cache ./config.cache configure: creating ./config.status config.status: creating Makefile config.status: creating config.intl config.status: creating config.h config.status: executing default-1 commands mkdir -p -- ./libiberty Configuring in ./libiberty configure: creating cache ./config.cache checking whether to enable maintainer-specific portions of Makefiles... no checking for makeinfo... /home/enjoyo/RosBE-Unix-0.3.6/sources/binutils/missing makeinfo --split-size=5000000 configure: WARNING: *** Makeinfo is missing. Info documentation will not be built. checking for perl... perl checking build system type... i686-pc-linux-gnu checking host system type... i686-pc-linux-gnu checking for i686-pc-linux-gnu-ar... ar checking for i686-pc-linux-gnu-ranlib... ranlib checking for i686-pc-linux-gnu-gcc... gcc checking for C compiler default output file name... a.out checking whether the C compiler works... yes checking whether we are cross compiling... no checking for suffix of executables... checking for suffix of object files... o checking whether we are using the GNU C compiler... yes checking whether gcc accepts -g... yes checking for gcc option to accept ANSI C... none needed checking how to run the C preprocessor... gcc -E checking whether gcc accepts -Wc++-compat... yes checking whether gcc and cc understand -c and -o together... yes checking for an ANSI C-conforming const... yes checking for inline... inline checking whether byte ordering is bigendian... no checking for a BSD-compatible install... /usr/bin/install -c checking for sys/file.h... yes checking for sys/param.h... yes checking for limits.h... yes checking for stdlib.h... yes checking for malloc.h... yes checking for string.h... yes checking for unistd.h... yes checking for strings.h... yes checking for sys/time.h... yes checking for time.h... yes checking for sys/resource.h... yes checking for sys/stat.h... yes checking for sys/mman.h... yes checking for fcntl.h... yes checking for alloca.h... yes checking for sys/pstat.h... no checking for sys/sysmp.h... no checking for sys/sysinfo.h... yes checking for machine/hal_sysinfo.h... no checking for sys/table.h... no checking for sys/sysctl.h... yes checking for sys/systemcfg.h... no checking for stdint.h... yes checking for stdio_ext.h... yes checking for sys/wait.h that is POSIX.1 compatible... yes checking whether time.h and sys/time.h may both be included... yes checking whether errno must be declared... no checking for egrep... grep -E checking for ANSI C header files... yes checking for sys/types.h... yes checking for sys/stat.h... (cached) yes checking for stdlib.h... (cached) yes checking for string.h... (cached) yes checking for memory.h... yes checking for strings.h... (cached) yes checking for inttypes.h... yes checking for stdint.h... (cached) yes checking for unistd.h... (cached) yes checking for int... yes checking size of int... 4 checking for uintptr_t... yes checking for a 64-bit type... uint64_t checking for pid_t... yes checking for library containing strerror... none required checking for asprintf... yes checking for atexit... yes checking for basename... yes checking for bcmp... yes checking for bcopy... yes checking for bsearch... yes checking for bzero... yes checking for calloc... yes checking for clock... yes checking for ffs... yes checking for getcwd... yes checking for getpagesize... yes checking for gettimeofday... yes checking for index... yes checking for insque... yes checking for memchr... yes checking for memcmp... yes checking for memcpy... yes checking for memmove... yes checking for mempcpy... yes checking for memset... yes checking for mkstemps... no checking for putenv... yes checking for random... yes checking for rename... yes checking for rindex... yes checking for setenv... yes checking for snprintf... yes checking for sigsetmask... yes checking for stpcpy... yes checking for stpncpy... yes checking for strcasecmp... yes checking for strchr... yes checking for strdup... yes checking for strncasecmp... yes checking for strndup... yes checking for strrchr... yes checking for strstr... yes checking for strtod... yes checking for strtol... yes checking for strtoul... yes checking for strverscmp... yes checking for tmpnam... yes checking for vasprintf... yes checking for vfprintf... yes checking for vprintf... yes checking for vsnprintf... yes checking for vsprintf... yes checking for waitpid... yes checking whether alloca needs Cray hooks... no checking stack direction for C alloca... -1 checking for unistd.h... (cached) yes checking for vfork.h... no checking for fork... yes checking for vfork... yes checking for working fork... yes checking for working vfork... (cached) yes checking for _doprnt... no checking for sys_errlist... yes checking for sys_nerr... yes checking for sys_siglist... yes checking for external symbol _system_configuration... no checking for getrusage... yes checking for on_exit... yes checking for psignal... yes checking for strerror... yes checking for strsignal... yes checking for sysconf... yes checking for times... yes checking for sbrk... yes checking for gettimeofday... (cached) yes checking for realpath... yes checking for canonicalize_file_name... yes checking for pstat_getstatic... no checking for pstat_getdynamic... no checking for sysmp... no checking for getsysinfo... no checking for table... no checking for sysctl... yes checking for wait3... yes checking for wait4... yes checking for __fsetlocking... yes checking whether basename is declared... no checking whether ffs is declared... yes checking whether asprintf is declared... no checking whether vasprintf is declared... no checking whether snprintf is declared... yes checking whether vsnprintf is declared... yes checking whether calloc is declared... yes checking whether getenv is declared... yes checking whether getopt is declared... yes checking whether malloc is declared... yes checking whether realloc is declared... yes checking whether sbrk is declared... yes checking whether strverscmp is declared... no checking whether canonicalize_file_name must be declared... yes checking for stdlib.h... (cached) yes checking for unistd.h... (cached) yes checking for getpagesize... (cached) yes checking for working mmap... yes checking for working strncmp... yes updating cache ./config.cache configure: creating ./config.status config.status: creating Makefile config.status: creating testsuite/Makefile config.status: creating config.h config.status: executing default commands mkdir -p -- ./bfd Configuring in ./bfd configure: creating cache ./config.cache checking build system type... i686-pc-linux-gnu checking host system type... i686-pc-linux-gnu checking target system type... i386-pc-mingw32 checking for i686-pc-linux-gnu-gcc... gcc checking for C compiler default output file name... a.out checking whether the C compiler works... yes checking whether we are cross compiling... no checking for suffix of executables... checking for suffix of object files... o checking whether we are using the GNU C compiler... yes checking whether gcc accepts -g... yes checking for gcc option to accept ANSI C... none needed checking for library containing strerror... none required checking for a BSD-compatible install... /usr/bin/install -c checking whether build environment is sane... yes checking for gawk... gawk checking whether make sets $(MAKE)... yes checking for style of include used by make... GNU checking dependency style of gcc... gcc3 checking for i686-pc-linux-gnu-ar... ar checking for i686-pc-linux-gnu-ranlib... ranlib checking for i686-pc-linux-gnu-gcc... (cached) gcc checking whether we are using the GNU C compiler... (cached) yes checking whether gcc accepts -g... (cached) yes checking for gcc option to accept ANSI C... (cached) none needed checking for ld used by GCC... ld checking if the linker (ld) is GNU ld... yes checking for ld option to reload object files... -r checking for BSD-compatible nm... nm checking whether ln -s works... yes checking how to recognise dependant libraries... pass_all checking the maximum length of command line arguments... none checking for i686-pc-linux-gnu-ranlib... (cached) ranlib checking for i686-pc-linux-gnu-strip... no checking for strip... strip updating cache ./config.cache loading cache ./config.cache within ltconfig checking for objdir... .libs checking for gcc option to produce PIC... -fPIC -DPIC checking if gcc PIC flag -fPIC -DPIC works... yes checking if gcc static flag -static works... yes finding the maximum length of command line arguments... 49153 checking if gcc supports -c -o file.o... yes checking if gcc supports -fno-rtti -fno-exceptions ... no checking whether the linker (ld) supports shared libraries... yes checking how to hardcode library paths into programs... immediate checking whether stripping libraries is possible... yes checking dynamic linker characteristics... GNU/Linux ld.so checking command to parse nm output... ok checking if libtool supports shared libraries... yes checking whether to build shared libraries... no checking whether to build static libraries... yes creating libtool updating cache ./config.cache configure: loading cache ./config.cache Setting warning flags = -W -Wall -Wstrict-prototypes -Wmissing-prototypes -Werror checking whether to enable maintainer-specific portions of Makefiles... no checking whether to install libbfd... no checking whether NLS is requested... no checking whether NLS is requested... no checking for msgfmt... /usr/bin/msgfmt checking for gmsgfmt... /usr/bin/msgfmt checking for xgettext... /usr/bin/xgettext checking for msgmerge... /usr/bin/msgmerge checking for a BSD-compatible install... /usr/bin/install -c checking for long long... yes checking how to run the C preprocessor... gcc -E checking for egrep... grep -E checking for ANSI C header files... yes checking for sys/types.h... yes checking for sys/stat.h... yes checking for stdlib.h... yes checking for string.h... yes checking for memory.h... yes checking for strings.h... yes checking for inttypes.h... yes checking for stdint.h... yes checking for unistd.h... yes checking for long long... yes checking size of long long... 8 checking for long... yes checking size of long... 4 checking stddef.h usability... yes checking stddef.h presence... yes checking for stddef.h... yes checking for string.h... (cached) yes checking for strings.h... (cached) yes checking for stdlib.h... (cached) yes checking time.h usability... yes checking time.h presence... yes checking for time.h... yes checking for unistd.h... (cached) yes checking fcntl.h usability... yes checking fcntl.h presence... yes checking for fcntl.h... yes checking sys/file.h usability... yes checking sys/file.h presence... yes checking for sys/file.h... yes checking sys/time.h usability... yes checking sys/time.h presence... yes checking for sys/time.h... yes checking whether time.h and sys/time.h may both be included... yes checking for dirent.h that defines DIR... yes checking for library containing opendir... none required checking whether string.h and strings.h may both be included... yes checking for fcntl... yes checking for getpagesize... yes checking for setitimer... yes checking for sysconf... yes checking for fdopen... yes checking for getuid... yes checking for getgid... yes checking for strtoull... yes checking whether basename is declared... yes checking whether ftello is declared... yes checking whether ftello64 is declared... yes checking whether fseeko is declared... yes checking whether fseeko64 is declared... yes checking whether ffs is declared... yes checking whether free is declared... yes checking whether getenv is declared... yes checking whether malloc is declared... yes checking whether realloc is declared... yes checking whether stpcpy is declared... yes checking whether strstr is declared... yes checking whether snprintf is declared... yes checking whether vsnprintf is declared... yes checking for ftello... yes checking for ftello64... yes checking for fseeko... yes checking for fseeko64... yes checking for fopen64... yes checking for off_t... yes checking size of off_t... 4 checking file_ptr type... BFD_HOST_64_BIT checking for stdlib.h... (cached) yes checking for unistd.h... (cached) yes checking for getpagesize... (cached) yes checking for working mmap... yes checking for madvise... yes checking for mprotect... yes updating cache ./config.cache configure: creating ./config.status config.status: creating Makefile config.status: creating doc/Makefile config.status: creating bfd-in3.h config.status: creating po/Makefile.in config.status: creating config.h config.status: executing depfiles commands config.status: executing default-1 commands config.status: executing default commands make[2]: Entering directory `/home/enjoyo/RosBE-Unix-0.3.6/sources/binutils-build/libiberty' if [ x"" != x ] && [ ! -d pic ]; then \ mkdir pic; \ else true; fi touch stamp-picdir if [ x"" != x ]; then \ gcc -c -DHAVE_CONFIG_H -O2 -fno-exceptions -I. -I../../binutils/libiberty/../include -W -Wall -pedantic -Wwrite-strings -Wstrict-prototypes -Wc++-compat ../../binutils/libiberty/regex.c -o pic/regex.o; \ else true; fi gcc -c -DHAVE_CONFIG_H -O2 -fno-exceptions -I. -I../../binutils/libiberty/../include -W -Wall -pedantic -Wwrite-strings -Wstrict-prototypes -Wc++-compat ../../binutils/libiberty/regex.c -o regex.o if [ x"" != x ]; then \ gcc -c -DHAVE_CONFIG_H -O2 -fno-exceptions -I. -I../../binutils/libiberty/../include -W -Wall -pedantic -Wwrite-strings -Wstrict-prototypes -Wc++-compat ../../binutils/libiberty/cplus-dem.c -o pic/cplus-dem.o; \ else true; fi gcc -c -DHAVE_CONFIG_H -O2 -fno-exceptions -I. -I../../binutils/libiberty/../include -W -Wall -pedantic -Wwrite-strings -Wstrict-prototypes -Wc++-compat ../../binutils/libiberty/cplus-dem.c -o cplus-dem.o if [ x"" != x ]; then \ gcc -c -DHAVE_CONFIG_H -O2 -fno-exceptions -I. -I../../binutils/libiberty/../include -W -Wall -pedantic -Wwrite-strings -Wstrict-prototypes -Wc++-compat ../../binutils/libiberty/cp-demangle.c -o pic/cp-demangle.o; \ else true; fi gcc -c -DHAVE_CONFIG_H -O2 -fno-exceptions -I. -I../../binutils/libiberty/../include -W -Wall -pedantic -Wwrite-strings -Wstrict-prototypes -Wc++-compat ../../binutils/libiberty/cp-demangle.c -o cp-demangle.o if [ x"" != x ]; then \ gcc -c -DHAVE_CONFIG_H -O2 -fno-exceptions -I. -I../../binutils/libiberty/../include -W -Wall -pedantic -Wwrite-strings -Wstrict-prototypes -Wc++-compat ../../binutils/libiberty/md5.c -o pic/md5.o; \ else true; fi gcc -c -DHAVE_CONFIG_H -O2 -fno-exceptions -I. -I../../binutils/libiberty/../include -W -Wall -pedantic -Wwrite-strings -Wstrict-prototypes -Wc++-compat ../../binutils/libiberty/md5.c -o md5.o if [ x"" != x ]; then \ gcc -c -DHAVE_CONFIG_H -O2 -fno-exceptions -I. -I../../binutils/libiberty/../include -W -Wall -pedantic -Wwrite-strings -Wstrict-prototypes -Wc++-compat ../../binutils/libiberty/alloca.c -o pic/alloca.o; \ else true; fi gcc -c -DHAVE_CONFIG_H -O2 -fno-exceptions -I. -I../../binutils/libiberty/../include -W -Wall -pedantic -Wwrite-strings -Wstrict-prototypes -Wc++-compat ../../binutils/libiberty/alloca.c -o alloca.o if [ x"" != x ]; then \ gcc -c -DHAVE_CONFIG_H -O2 -fno-exceptions -I. -I../../binutils/libiberty/../include -W -Wall -pedantic -Wwrite-strings -Wstrict-prototypes -Wc++-compat ../../binutils/libiberty/argv.c -o pic/argv.o; \ else true; fi gcc -c -DHAVE_CONFIG_H -O2 -fno-exceptions -I. -I../../binutils/libiberty/../include -W -Wall -pedantic -Wwrite-strings -Wstrict-prototypes -Wc++-compat ../../binutils/libiberty/argv.c -o argv.o if [ x"" != x ]; then \ gcc -c -DHAVE_CONFIG_H -O2 -fno-exceptions -I. -I../../binutils/libiberty/../include -W -Wall -pedantic -Wwrite-strings -Wstrict-prototypes -Wc++-compat ../../binutils/libiberty/choose-temp.c -o pic/choose-temp.o; \ else true; fi gcc -c -DHAVE_CONFIG_H -O2 -fno-exceptions -I. -I../../binutils/libiberty/../include -W -Wall -pedantic -Wwrite-strings -Wstrict-prototypes -Wc++-compat ../../binutils/libiberty/choose-temp.c -o choose-temp.o if [ x"" != x ]; then \ gcc -c -DHAVE_CONFIG_H -O2 -fno-exceptions -I. -I../../binutils/libiberty/../include -W -Wall -pedantic -Wwrite-strings -Wstrict-prototypes -Wc++-compat ../../binutils/libiberty/concat.c -o pic/concat.o; \ else true; fi gcc -c -DHAVE_CONFIG_H -O2 -fno-exceptions -I. -I../../binutils/libiberty/../include -W -Wall -pedantic -Wwrite-strings -Wstrict-prototypes -Wc++-compat ../../binutils/libiberty/concat.c -o concat.o if [ x"" != x ]; then \ gcc -c -DHAVE_CONFIG_H -O2 -fno-exceptions -I. -I../../binutils/libiberty/../include -W -Wall -pedantic -Wwrite-strings -Wstrict-prototypes -Wc++-compat ../../binutils/libiberty/cp-demint.c -o pic/cp-demint.o; \ else true; fi gcc -c -DHAVE_CONFIG_H -O2 -fno-exceptions -I. -I../../binutils/libiberty/../include -W -Wall -pedantic -Wwrite-strings -Wstrict-prototypes -Wc++-compat ../../binutils/libiberty/cp-demint.c -o cp-demint.o if [ x"" != x ]; then \ gcc -c -DHAVE_CONFIG_H -O2 -fno-exceptions -I. -I../../binutils/libiberty/../include -W -Wall -pedantic -Wwrite-strings -Wstrict-prototypes -Wc++-compat ../../binutils/libiberty/dyn-string.c -o pic/dyn-string.o; \ else true; fi gcc -c -DHAVE_CONFIG_H -O2 -fno-exceptions -I. -I../../binutils/libiberty/../include -W -Wall -pedantic -Wwrite-strings -Wstrict-prototypes -Wc++-compat ../../binutils/libiberty/dyn-string.c -o dyn-string.o if [ x"" != x ]; then \ gcc -c -DHAVE_CONFIG_H -O2 -fno-exceptions -I. -I../../binutils/libiberty/../include -W -Wall -pedantic -Wwrite-strings -Wstrict-prototypes -Wc++-compat ../../binutils/libiberty/fdmatch.c -o pic/fdmatch.o; \ else true; fi gcc -c -DHAVE_CONFIG_H -O2 -fno-exceptions -I. -I../../binutils/libiberty/../include -W -Wall -pedantic -Wwrite-strings -Wstrict-prototypes -Wc++-compat ../../binutils/libiberty/fdmatch.c -o fdmatch.o if [ x"" != x ]; then \ gcc -c -DHAVE_CONFIG_H -O2 -fno-exceptions -I. -I../../binutils/libiberty/../include -W -Wall -pedantic -Wwrite-strings -Wstrict-prototypes -Wc++-compat ../../binutils/libiberty/fibheap.c -o pic/fibheap.o; \ else true; fi gcc -c -DHAVE_CONFIG_H -O2 -fno-exceptions -I. -I../../binutils/libiberty/../include -W -Wall -pedantic -Wwrite-strings -Wstrict-prototypes -Wc++-compat ../../binutils/libiberty/fibheap.c -o fibheap.o if [ x"" != x ]; then \ gcc -c -DHAVE_CONFIG_H -O2 -fno-exceptions -I. -I../../binutils/libiberty/../include -W -Wall -pedantic -Wwrite-strings -Wstrict-prototypes -Wc++-compat ../../binutils/libiberty/filename_cmp.c -o pic/filename_cmp.o; \ else true; fi gcc -c -DHAVE_CONFIG_H -O2 -fno-exceptions -I. -I../../binutils/libiberty/../include -W -Wall -pedantic -Wwrite-strings -Wstrict-prototypes -Wc++-compat ../../binutils/libiberty/filename_cmp.c -o filename_cmp.o if [ x"" != x ]; then \ gcc -c -DHAVE_CONFIG_H -O2 -fno-exceptions -I. -I../../binutils/libiberty/../include -W -Wall -pedantic -Wwrite-strings -Wstrict-prototypes -Wc++-compat ../../binutils/libiberty/floatformat.c -o pic/floatformat.o; \ else true; fi gcc -c -DHAVE_CONFIG_H -O2 -fno-exceptions -I. -I../../binutils/libiberty/../include -W -Wall -pedantic -Wwrite-strings -Wstrict-prototypes -Wc++-compat ../../binutils/libiberty/floatformat.c -o floatformat.o if [ x"" != x ]; then \ gcc -c -DHAVE_CONFIG_H -O2 -fno-exceptions -I. -I../../binutils/libiberty/../include -W -Wall -pedantic -Wwrite-strings -Wstrict-prototypes -Wc++-compat ../../binutils/libiberty/fnmatch.c -o pic/fnmatch.o; \ else true; fi gcc -c -DHAVE_CONFIG_H -O2 -fno-exceptions -I. -I../../binutils/libiberty/../include -W -Wall -pedantic -Wwrite-strings -Wstrict-prototypes -Wc++-compat ../../binutils/libiberty/fnmatch.c -o fnmatch.o if [ x"" != x ]; then \ gcc -c -DHAVE_CONFIG_H -O2 -fno-exceptions -I. -I../../binutils/libiberty/../include -W -Wall -pedantic -Wwrite-strings -Wstrict-prototypes -Wc++-compat ../../binutils/libiberty/fopen_unlocked.c -o pic/fopen_unlocked.o; \ else true; fi gcc -c -DHAVE_CONFIG_H -O2 -fno-exceptions -I. -I../../binutils/libiberty/../include -W -Wall -pedantic -Wwrite-strings -Wstrict-prototypes -Wc++-compat ../../binutils/libiberty/fopen_unlocked.c -o fopen_unlocked.o if [ x"" != x ]; then \ gcc -c -DHAVE_CONFIG_H -O2 -fno-exceptions -I. -I../../binutils/libiberty/../include -W -Wall -pedantic -Wwrite-strings -Wstrict-prototypes -Wc++-compat ../../binutils/libiberty/getopt.c -o pic/getopt.o; \ else true; fi gcc -c -DHAVE_CONFIG_H -O2 -fno-exceptions -I. -I../../binutils/libiberty/../include -W -Wall -pedantic -Wwrite-strings -Wstrict-prototypes -Wc++-compat ../../binutils/libiberty/getopt.c -o getopt.o if [ x"" != x ]; then \ gcc -c -DHAVE_CONFIG_H -O2 -fno-exceptions -I. -I../../binutils/libiberty/../include -W -Wall -pedantic -Wwrite-strings -Wstrict-prototypes -Wc++-compat ../../binutils/libiberty/getopt1.c -o pic/getopt1.o; \ else true; fi gcc -c -DHAVE_CONFIG_H -O2 -fno-exceptions -I. -I../../binutils/libiberty/../include -W -Wall -pedantic -Wwrite-strings -Wstrict-prototypes -Wc++-compat ../../binutils/libiberty/getopt1.c -o getopt1.o if [ x"" != x ]; then \ gcc -c -DHAVE_CONFIG_H -O2 -fno-exceptions -I. -I../../binutils/libiberty/../include -W -Wall -pedantic -Wwrite-strings -Wstrict-prototypes -Wc++-compat ../../binutils/libiberty/getpwd.c -o pic/getpwd.o; \ else true; fi gcc -c -DHAVE_CONFIG_H -O2 -fno-exceptions -I. -I../../binutils/libiberty/../include -W -Wall -pedantic -Wwrite-strings -Wstrict-prototypes -Wc++-compat ../../binutils/libiberty/getpwd.c -o getpwd.o if [ x"" != x ]; then \ gcc -c -DHAVE_CONFIG_H -O2 -fno-exceptions -I. -I../../binutils/libiberty/../include -W -Wall -pedantic -Wwrite-strings -Wstrict-prototypes -Wc++-compat ../../binutils/libiberty/getruntime.c -o pic/getruntime.o; \ else true; fi gcc -c -DHAVE_CONFIG_H -O2 -fno-exceptions -I. -I../../binutils/libiberty/../include -W -Wall -pedantic -Wwrite-strings -Wstrict-prototypes -Wc++-compat ../../binutils/libiberty/getruntime.c -o getruntime.o if [ x"" != x ]; then \ gcc -c -DHAVE_CONFIG_H -O2 -fno-exceptions -I. -I../../binutils/libiberty/../include -W -Wall -pedantic -Wwrite-strings -Wstrict-prototypes -Wc++-compat ../../binutils/libiberty/hashtab.c -o pic/hashtab.o; \ else true; fi gcc -c -DHAVE_CONFIG_H -O2 -fno-exceptions -I. -I../../binutils/libiberty/../include -W -Wall -pedantic -Wwrite-strings -Wstrict-prototypes -Wc++-compat ../../binutils/libiberty/hashtab.c -o hashtab.o if [ x"" != x ]; then \ gcc -c -DHAVE_CONFIG_H -O2 -fno-exceptions -I. -I../../binutils/libiberty/../include -W -Wall -pedantic -Wwrite-strings -Wstrict-prototypes -Wc++-compat ../../binutils/libiberty/hex.c -o pic/hex.o; \ else true; fi gcc -c -DHAVE_CONFIG_H -O2 -fno-exceptions -I. -I../../binutils/libiberty/../include -W -Wall -pedantic -Wwrite-strings -Wstrict-prototypes -Wc++-compat ../../binutils/libiberty/hex.c -o hex.o if [ x"" != x ]; then \ gcc -c -DHAVE_CONFIG_H -O2 -fno-exceptions -I. -I../../binutils/libiberty/../include -W -Wall -pedantic -Wwrite-strings -Wstrict-prototypes -Wc++-compat ../../binutils/libiberty/lbasename.c -o pic/lbasename.o; \ else true; fi gcc -c -DHAVE_CONFIG_H -O2 -fno-exceptions -I. -I../../binutils/libiberty/../include -W -Wall -pedantic -Wwrite-strings -Wstrict-prototypes -Wc++-compat ../../binutils/libiberty/lbasename.c -o lbasename.o if [ x"" != x ]; then \ gcc -c -DHAVE_CONFIG_H -O2 -fno-exceptions -I. -I../../binutils/libiberty/../include -W -Wall -pedantic -Wwrite-strings -Wstrict-prototypes -Wc++-compat ../../binutils/libiberty/lrealpath.c -o pic/lrealpath.o; \ else true; fi gcc -c -DHAVE_CONFIG_H -O2 -fno-exceptions -I. -I../../binutils/libiberty/../include -W -Wall -pedantic -Wwrite-strings -Wstrict-prototypes -Wc++-compat ../../binutils/libiberty/lrealpath.c -o lrealpath.o if [ x"" != x ]; then \ gcc -c -DHAVE_CONFIG_H -O2 -fno-exceptions -I. -I../../binutils/libiberty/../include -W -Wall -pedantic -Wwrite-strings -Wstrict-prototypes -Wc++-compat ../../binutils/libiberty/make-relative-prefix.c -o pic/make-relative-prefix.o; \ else true; fi gcc -c -DHAVE_CONFIG_H -O2 -fno-exceptions -I. -I../../binutils/libiberty/../include -W -Wall -pedantic -Wwrite-strings -Wstrict-prototypes -Wc++-compat ../../binutils/libiberty/make-relative-prefix.c -o make-relative-prefix.o if [ x"" != x ]; then \ gcc -c -DHAVE_CONFIG_H -O2 -fno-exceptions -I. -I../../binutils/libiberty/../include -W -Wall -pedantic -Wwrite-strings -Wstrict-prototypes -Wc++-compat ../../binutils/libiberty/make-temp-file.c -o pic/make-temp-file.o; \ else true; fi gcc -c -DHAVE_CONFIG_H -O2 -fno-exceptions -I. -I../../binutils/libiberty/../include -W -Wall -pedantic -Wwrite-strings -Wstrict-prototypes -Wc++-compat ../../binutils/libiberty/make-temp-file.c -o make-temp-file.o if [ x"" != x ]; then \ gcc -c -DHAVE_CONFIG_H -O2 -fno-exceptions -I. -I../../binutils/libiberty/../include -W -Wall -pedantic -Wwrite-strings -Wstrict-prototypes -Wc++-compat ../../binutils/libiberty/objalloc.c -o pic/objalloc.o; \ else true; fi gcc -c -DHAVE_CONFIG_H -O2 -fno-exceptions -I. -I../../binutils/libiberty/../include -W -Wall -pedantic -Wwrite-strings -Wstrict-prototypes -Wc++-compat ../../binutils/libiberty/objalloc.c -o objalloc.o if [ x"" != x ]; then \ gcc -c -DHAVE_CONFIG_H -O2 -fno-exceptions -I. -I../../binutils/libiberty/../include -W -Wall -pedantic -Wwrite-strings -Wstrict-prototypes -Wc++-compat ../../binutils/libiberty/obstack.c -o pic/obstack.o; \ else true; fi gcc -c -DHAVE_CONFIG_H -O2 -fno-exceptions -I. -I../../binutils/libiberty/../include -W -Wall -pedantic -Wwrite-strings -Wstrict-prototypes -Wc++-compat ../../binutils/libiberty/obstack.c -o obstack.o if [ x"" != x ]; then \ gcc -c -DHAVE_CONFIG_H -O2 -fno-exceptions -I. -I../../binutils/libiberty/../include -W -Wall -pedantic -Wwrite-strings -Wstrict-prototypes -Wc++-compat ../../binutils/libiberty/partition.c -o pic/partition.o; \ else true; fi gcc -c -DHAVE_CONFIG_H -O2 -fno-exceptions -I. -I../../binutils/libiberty/../include -W -Wall -pedantic -Wwrite-strings -Wstrict-prototypes -Wc++-compat ../../binutils/libiberty/partition.c -o partition.o if [ x"" != x ]; then \ gcc -c -DHAVE_CONFIG_H -O2 -fno-exceptions -I. -I../../binutils/libiberty/../include -W -Wall -pedantic -Wwrite-strings -Wstrict-prototypes -Wc++-compat ../../binutils/libiberty/pexecute.c -o pic/pexecute.o; \ else true; fi gcc -c -DHAVE_CONFIG_H -O2 -fno-exceptions -I. -I../../binutils/libiberty/../include -W -Wall -pedantic -Wwrite-strings -Wstrict-prototypes -Wc++-compat ../../binutils/libiberty/pexecute.c -o pexecute.o if [ x"" != x ]; then \ gcc -c -DHAVE_CONFIG_H -O2 -fno-exceptions -I. -I../../binutils/libiberty/../include -W -Wall -pedantic -Wwrite-strings -Wstrict-prototypes -Wc++-compat ../../binutils/libiberty/physmem.c -o pic/physmem.o; \ else true; fi gcc -c -DHAVE_CONFIG_H -O2 -fno-exceptions -I. -I../../binutils/libiberty/../include -W -Wall -pedantic -Wwrite-strings -Wstrict-prototypes -Wc++-compat ../../binutils/libiberty/physmem.c -o physmem.o if [ x"" != x ]; then \ gcc -c -DHAVE_CONFIG_H -O2 -fno-exceptions -I. -I../../binutils/libiberty/../include -W -Wall -pedantic -Wwrite-strings -Wstrict-prototypes -Wc++-compat ../../binutils/libiberty/pex-common.c -o pic/pex-common.o; \ else true; fi gcc -c -DHAVE_CONFIG_H -O2 -fno-exceptions -I. -I../../binutils/libiberty/../include -W -Wall -pedantic -Wwrite-strings -Wstrict-prototypes -Wc++-compat ../../binutils/libiberty/pex-common.c -o pex-common.o if [ x"" != x ]; then \ gcc -c -DHAVE_CONFIG_H -O2 -fno-exceptions -I. -I../../binutils/libiberty/../include -W -Wall -pedantic -Wwrite-strings -Wstrict-prototypes -Wc++-compat ../../binutils/libiberty/pex-one.c -o pic/pex-one.o; \ else true; fi gcc -c -DHAVE_CONFIG_H -O2 -fno-exceptions -I. -I../../binutils/libiberty/../include -W -Wall -pedantic -Wwrite-strings -Wstrict-prototypes -Wc++-compat ../../binutils/libiberty/pex-one.c -o pex-one.o if [ x"" != x ]; then \ gcc -c -DHAVE_CONFIG_H -O2 -fno-exceptions -I. -I../../binutils/libiberty/../include -W -Wall -pedantic -Wwrite-strings -Wstrict-prototypes -Wc++-compat ../../binutils/libiberty/pex-unix.c -o pic/pex-unix.o; \ else true; fi gcc -c -DHAVE_CONFIG_H -O2 -fno-exceptions -I. -I../../binutils/libiberty/../include -W -Wall -pedantic -Wwrite-strings -Wstrict-prototypes -Wc++-compat ../../binutils/libiberty/pex-unix.c -o pex-unix.o if [ x"" != x ]; then \ gcc -c -DHAVE_CONFIG_H -O2 -fno-exceptions -I. -I../../binutils/libiberty/../include -W -Wall -pedantic -Wwrite-strings -Wstrict-prototypes -Wc++-compat ../../binutils/libiberty/safe-ctype.c -o pic/safe-ctype.o; \ else true; fi gcc -c -DHAVE_CONFIG_H -O2 -fno-exceptions -I. -I../../binutils/libiberty/../include -W -Wall -pedantic -Wwrite-strings -Wstrict-prototypes -Wc++-compat ../../binutils/libiberty/safe-ctype.c -o safe-ctype.o if [ x"" != x ]; then \ gcc -c -DHAVE_CONFIG_H -O2 -fno-exceptions -I. -I../../binutils/libiberty/../include -W -Wall -pedantic -Wwrite-strings -Wstrict-prototypes -Wc++-compat ../../binutils/libiberty/sort.c -o pic/sort.o; \ else true; fi gcc -c -DHAVE_CONFIG_H -O2 -fno-exceptions -I. -I../../binutils/libiberty/../include -W -Wall -pedantic -Wwrite-strings -Wstrict-prototypes -Wc++-compat ../../binutils/libiberty/sort.c -o sort.o if [ x"" != x ]; then \ gcc -c -DHAVE_CONFIG_H -O2 -fno-exceptions -I. -I../../binutils/libiberty/../include -W -Wall -pedantic -Wwrite-strings -Wstrict-prototypes -Wc++-compat ../../binutils/libiberty/spaces.c -o pic/spaces.o; \ else true; fi gcc -c -DHAVE_CONFIG_H -O2 -fno-exceptions -I. -I../../binutils/libiberty/../include -W -Wall -pedantic -Wwrite-strings -Wstrict-prototypes -Wc++-compat ../../binutils/libiberty/spaces.c -o spaces.o if [ x"" != x ]; then \ gcc -c -DHAVE_CONFIG_H -O2 -fno-exceptions -I. -I../../binutils/libiberty/../include -W -Wall -pedantic -Wwrite-strings -Wstrict-prototypes -Wc++-compat ../../binutils/libiberty/splay-tree.c -o pic/splay-tree.o; \ else true; fi gcc -c -DHAVE_CONFIG_H -O2 -fno-exceptions -I. -I../../binutils/libiberty/../include -W -Wall -pedantic -Wwrite-strings -Wstrict-prototypes -Wc++-compat ../../binutils/libiberty/splay-tree.c -o splay-tree.o if [ x"" != x ]; then \ gcc -c -DHAVE_CONFIG_H -O2 -fno-exceptions -I. -I../../binutils/libiberty/../include -W -Wall -pedantic -Wwrite-strings -Wstrict-prototypes -Wc++-compat ../../binutils/libiberty/strerror.c -o pic/strerror.o; \ else true; fi gcc -c -DHAVE_CONFIG_H -O2 -fno-exceptions -I. -I../../binutils/libiberty/../include -W -Wall -pedantic -Wwrite-strings -Wstrict-prototypes -Wc++-compat ../../binutils/libiberty/strerror.c -o strerror.o if [ x"" != x ]; then \ gcc -c -DHAVE_CONFIG_H -O2 -fno-exceptions -I. -I../../binutils/libiberty/../include -W -Wall -pedantic -Wwrite-strings -Wstrict-prototypes -Wc++-compat ../../binutils/libiberty/strsignal.c -o pic/strsignal.o; \ else true; fi gcc -c -DHAVE_CONFIG_H -O2 -fno-exceptions -I. -I../../binutils/libiberty/../include -W -Wall -pedantic -Wwrite-strings -Wstrict-prototypes -Wc++-compat ../../binutils/libiberty/strsignal.c -o strsignal.o if [ x"" != x ]; then \ gcc -c -DHAVE_CONFIG_H -O2 -fno-exceptions -I. -I../../binutils/libiberty/../include -W -Wall -pedantic -Wwrite-strings -Wstrict-prototypes -Wc++-compat ../../binutils/libiberty/ternary.c -o pic/ternary.o; \ else true; fi gcc -c -DHAVE_CONFIG_H -O2 -fno-exceptions -I. -I../../binutils/libiberty/../include -W -Wall -pedantic -Wwrite-strings -Wstrict-prototypes -Wc++-compat ../../binutils/libiberty/ternary.c -o ternary.o if [ x"" != x ]; then \ gcc -c -DHAVE_CONFIG_H -O2 -fno-exceptions -I. -I../../binutils/libiberty/../include -W -Wall -pedantic -Wwrite-strings -Wstrict-prototypes -Wc++-compat ../../binutils/libiberty/unlink-if-ordinary.c -o pic/unlink-if-ordinary.o; \ else true; fi gcc -c -DHAVE_CONFIG_H -O2 -fno-exceptions -I. -I../../binutils/libiberty/../include -W -Wall -pedantic -Wwrite-strings -Wstrict-prototypes -Wc++-compat ../../binutils/libiberty/unlink-if-ordinary.c -o unlink-if-ordinary.o if [ x"" != x ]; then \ gcc -c -DHAVE_CONFIG_H -O2 -fno-exceptions -I. -I../../binutils/libiberty/../include -W -Wall -pedantic -Wwrite-strings -Wstrict-prototypes -Wc++-compat ../../binutils/libiberty/xatexit.c -o pic/xatexit.o; \ else true; fi gcc -c -DHAVE_CONFIG_H -O2 -fno-exceptions -I. -I../../binutils/libiberty/../include -W -Wall -pedantic -Wwrite-strings -Wstrict-prototypes -Wc++-compat ../../binutils/libiberty/xatexit.c -o xatexit.o if [ x"" != x ]; then \ gcc -c -DHAVE_CONFIG_H -O2 -fno-exceptions -I. -I../../binutils/libiberty/../include -W -Wall -pedantic -Wwrite-strings -Wstrict-prototypes -Wc++-compat ../../binutils/libiberty/xexit.c -o pic/xexit.o; \ else true; fi gcc -c -DHAVE_CONFIG_H -O2 -fno-exceptions -I. -I../../binutils/libiberty/../include -W -Wall -pedantic -Wwrite-strings -Wstrict-prototypes -Wc++-compat ../../binutils/libiberty/xexit.c -o xexit.o if [ x"" != x ]; then \ gcc -c -DHAVE_CONFIG_H -O2 -fno-exceptions -I. -I../../binutils/libiberty/../include -W -Wall -pedantic -Wwrite-strings -Wstrict-prototypes -Wc++-compat ../../binutils/libiberty/xmalloc.c -o pic/xmalloc.o; \ else true; fi gcc -c -DHAVE_CONFIG_H -O2 -fno-exceptions -I. -I../../binutils/libiberty/../include -W -Wall -pedantic -Wwrite-strings -Wstrict-prototypes -Wc++-compat ../../binutils/libiberty/xmalloc.c -o xmalloc.o if [ x"" != x ]; then \ gcc -c -DHAVE_CONFIG_H -O2 -fno-exceptions -I. -I../../binutils/libiberty/../include -W -Wall -pedantic -Wwrite-strings -Wstrict-prototypes -Wc++-compat ../../binutils/libiberty/xmemdup.c -o pic/xmemdup.o; \ else true; fi gcc -c -DHAVE_CONFIG_H -O2 -fno-exceptions -I. -I../../binutils/libiberty/../include -W -Wall -pedantic -Wwrite-strings -Wstrict-prototypes -Wc++-compat ../../binutils/libiberty/xmemdup.c -o xmemdup.o if [ x"" != x ]; then \ gcc -c -DHAVE_CONFIG_H -O2 -fno-exceptions -I. -I../../binutils/libiberty/../include -W -Wall -pedantic -Wwrite-strings -Wstrict-prototypes -Wc++-compat ../../binutils/libiberty/xstrdup.c -o pic/xstrdup.o; \ else true; fi gcc -c -DHAVE_CONFIG_H -O2 -fno-exceptions -I. -I../../binutils/libiberty/../include -W -Wall -pedantic -Wwrite-strings -Wstrict-prototypes -Wc++-compat ../../binutils/libiberty/xstrdup.c -o xstrdup.o if [ x"" != x ]; then \ gcc -c -DHAVE_CONFIG_H -O2 -fno-exceptions -I. -I../../binutils/libiberty/../include -W -Wall -pedantic -Wwrite-strings -Wstrict-prototypes -Wc++-compat ../../binutils/libiberty/xstrerror.c -o pic/xstrerror.o; \ else true; fi gcc -c -DHAVE_CONFIG_H -O2 -fno-exceptions -I. -I../../binutils/libiberty/../include -W -Wall -pedantic -Wwrite-strings -Wstrict-prototypes -Wc++-compat ../../binutils/libiberty/xstrerror.c -o xstrerror.o if [ x"" != x ]; then \ gcc -c -DHAVE_CONFIG_H -O2 -fno-exceptions -I. -I../../binutils/libiberty/../include -W -Wall -pedantic -Wwrite-strings -Wstrict-prototypes -Wc++-compat ../../binutils/libiberty/xstrndup.c -o pic/xstrndup.o; \ else true; fi gcc -c -DHAVE_CONFIG_H -O2 -fno-exceptions -I. -I../../binutils/libiberty/../include -W -Wall -pedantic -Wwrite-strings -Wstrict-prototypes -Wc++-compat ../../binutils/libiberty/xstrndup.c -o xstrndup.o if [ x"" != x ]; then \ gcc -c -DHAVE_CONFIG_H -O2 -fno-exceptions -I. -I../../binutils/libiberty/../include -W -Wall -pedantic -Wwrite-strings -Wstrict-prototypes -Wc++-compat ../../binutils/libiberty/mkstemps.c -o pic/mkstemps.o; \ else true; fi gcc -c -DHAVE_CONFIG_H -O2 -fno-exceptions -I. -I../../binutils/libiberty/../include -W -Wall -pedantic -Wwrite-strings -Wstrict-prototypes -Wc++-compat ../../binutils/libiberty/mkstemps.c -o mkstemps.o rm -f ./libiberty.a pic/./libiberty.a ar rc ./libiberty.a \ ./regex.o ./cplus-dem.o ./cp-demangle.o ./md5.o ./alloca.o ./argv.o ./choose-temp.o ./concat.o ./cp-demint.o ./dyn-string.o ./fdmatch.o ./fibheap.o ./filename_cmp.o ./floatformat.o ./fnmatch.o ./fopen_unlocked.o ./getopt.o ./getopt1.o ./getpwd.o ./getruntime.o ./hashtab.o ./hex.o ./lbasename.o ./lrealpath.o ./make-relative-prefix.o ./make-temp-file.o ./objalloc.o ./obstack.o ./partition.o ./pexecute.o ./physmem.o ./pex-common.o ./pex-one.o ./pex-unix.o ./safe-ctype.o ./sort.o ./spaces.o ./splay-tree.o ./strerror.o ./strsignal.o ./ternary.o ./unlink-if-ordinary.o ./xatexit.o ./xexit.o ./xmalloc.o ./xmemdup.o ./xstrdup.o ./xstrerror.o ./xstrndup.o ./mkstemps.o ranlib ./libiberty.a if [ x"" != x ]; then \ cd pic; \ ar rc ./libiberty.a \ ./regex.o ./cplus-dem.o ./cp-demangle.o ./md5.o ./alloca.o ./argv.o ./choose-temp.o ./concat.o ./cp-demint.o ./dyn-string.o ./fdmatch.o ./fibheap.o ./filename_cmp.o ./floatformat.o ./fnmatch.o ./fopen_unlocked.o ./getopt.o ./getopt1.o ./getpwd.o ./getruntime.o ./hashtab.o ./hex.o ./lbasename.o ./lrealpath.o ./make-relative-prefix.o ./make-temp-file.o ./objalloc.o ./obstack.o ./partition.o ./pexecute.o ./physmem.o ./pex-common.o ./pex-one.o ./pex-unix.o ./safe-ctype.o ./sort.o ./spaces.o ./splay-tree.o ./strerror.o ./strsignal.o ./ternary.o ./unlink-if-ordinary.o ./xatexit.o ./xexit.o ./xmalloc.o ./xmemdup.o ./xstrdup.o ./xstrerror.o ./xstrndup.o ./mkstemps.o; \ ranlib ./libiberty.a; \ cd ..; \ else true; fi rm -f needed-list; touch needed-list; \ for f in atexit calloc memchr memcmp memcpy memmove memset rename strchr strerror strncmp strrchr strstr strtol strtoul tmpnam vfprintf vprintf vfork waitpid bcmp bcopy bzero; do \ for g in ./mkstemps.o ; do \ case "$g" in \ *$f*) echo $g >> needed-list ;; \ esac; \ done; \ done echo ./regex.o ./cplus-dem.o ./cp-demangle.o ./md5.o ./alloca.o ./argv.o ./choose-temp.o ./concat.o ./cp-demint.o ./dyn-string.o ./fdmatch.o ./fibheap.o ./filename_cmp.o ./floatformat.o ./fnmatch.o ./fopen_unlocked.o ./getopt.o ./getopt1.o ./getpwd.o ./getruntime.o ./hashtab.o ./hex.o ./lbasename.o ./lrealpath.o ./make-relative-prefix.o ./make-temp-file.o ./objalloc.o ./obstack.o ./partition.o ./pexecute.o ./physmem.o ./pex-common.o ./pex-one.o ./pex-unix.o ./safe-ctype.o ./sort.o ./spaces.o ./splay-tree.o ./strerror.o ./strsignal.o ./ternary.o ./unlink-if-ordinary.o ./xatexit.o ./xexit.o ./xmalloc.o ./xmemdup.o ./xstrdup.o ./xstrerror.o ./xstrndup.o > required-list make[3]: Entering directory `/home/enjoyo/RosBE-Unix-0.3.6/sources/binutils-build/libiberty/testsuite' make[3]: Nothing to be done for `all'. make[3]: Leaving directory `/home/enjoyo/RosBE-Unix-0.3.6/sources/binutils-build/libiberty/testsuite' make[2]: Leaving directory `/home/enjoyo/RosBE-Unix-0.3.6/sources/binutils-build/libiberty' make[2]: Entering directory `/home/enjoyo/RosBE-Unix-0.3.6/sources/binutils-build/intl' make[2]: Nothing to be done for `all'. make[2]: Leaving directory `/home/enjoyo/RosBE-Unix-0.3.6/sources/binutils-build/intl' make[2]: Entering directory `/home/enjoyo/RosBE-Unix-0.3.6/sources/binutils-build/bfd' Making info in doc make[3]: Entering directory `/home/enjoyo/RosBE-Unix-0.3.6/sources/binutils-build/bfd/doc' make chew make[4]: Entering directory `/home/enjoyo/RosBE-Unix-0.3.6/sources/binutils-build/bfd/doc' gcc -o chew.$$ ../../../binutils/bfd/doc/chew.c \ -g -O2 \ -I.. -I../../../binutils/bfd/doc/.. -I../../../binutils/bfd/doc/../../include -I../../../binutils/bfd/doc/../../intl -I../../intl; \ /bin/sh ../../../binutils/bfd/doc/../../move-if-change chew.$$ chew make[4]: Leaving directory `/home/enjoyo/RosBE-Unix-0.3.6/sources/binutils-build/bfd/doc' ./chew -f ../../../binutils/bfd/doc/doc.str <../../../binutils/bfd/doc/../aoutx.h >aoutx.tmp /bin/sh ../../../binutils/bfd/doc/../../move-if-change aoutx.tmp aoutx.texi make chew make[4]: Entering directory `/home/enjoyo/RosBE-Unix-0.3.6/sources/binutils-build/bfd/doc' make[4]: "chew" is the newest. make[4]: Leaving directory `/home/enjoyo/RosBE-Unix-0.3.6/sources/binutils-build/bfd/doc' ./chew -f ../../../binutils/bfd/doc/doc.str <../../../binutils/bfd/doc/../archive.c >archive.tmp /bin/sh ../../../binutils/bfd/doc/../../move-if-change archive.tmp archive.texi make chew make[4]: Entering directory `/home/enjoyo/RosBE-Unix-0.3.6/sources/binutils-build/bfd/doc' make[4]: "chew" is the newest. make[4]: Leaving directory `/home/enjoyo/RosBE-Unix-0.3.6/sources/binutils-build/bfd/doc' ./chew -f ../../../binutils/bfd/doc/doc.str < ../../../binutils/bfd/doc/../archures.c >archures.tmp /bin/sh ../../../binutils/bfd/doc/../../move-if-change archures.tmp archures.texi make chew make[4]: Entering directory `/home/enjoyo/RosBE-Unix-0.3.6/sources/binutils-build/bfd/doc' make[4]: "chew" is the newest. make[4]: Leaving directory `/home/enjoyo/RosBE-Unix-0.3.6/sources/binutils-build/bfd/doc' ./chew -f ../../../binutils/bfd/doc/doc.str < ../../../binutils/bfd/doc/../bfd.c >bfd.tmp /bin/sh ../../../binutils/bfd/doc/../../move-if-change bfd.tmp bfdt.texi make chew make[4]: Entering directory `/home/enjoyo/RosBE-Unix-0.3.6/sources/binutils-build/bfd/doc' make[4]: "chew" is the newest. make[4]: Leaving directory `/home/enjoyo/RosBE-Unix-0.3.6/sources/binutils-build/bfd/doc' ./chew -f ../../../binutils/bfd/doc/doc.str < ../../../binutils/bfd/doc/../cache.c >cache.tmp /bin/sh ../../../binutils/bfd/doc/../../move-if-change cache.tmp cache.texi make chew make[4]: Entering directory `/home/enjoyo/RosBE-Unix-0.3.6/sources/binutils-build/bfd/doc' make[4]: "chew" is the newest. make[4]: Leaving directory `/home/enjoyo/RosBE-Unix-0.3.6/sources/binutils-build/bfd/doc' ./chew -f ../../../binutils/bfd/doc/doc.str <../../../binutils/bfd/doc/../coffcode.h >coffcode.tmp /bin/sh ../../../binutils/bfd/doc/../../move-if-change coffcode.tmp coffcode.texi make chew make[4]: Entering directory `/home/enjoyo/RosBE-Unix-0.3.6/sources/binutils-build/bfd/doc' make[4]: "chew" is the newest. make[4]: Leaving directory `/home/enjoyo/RosBE-Unix-0.3.6/sources/binutils-build/bfd/doc' ./chew -f ../../../binutils/bfd/doc/doc.str <../../../binutils/bfd/doc/../corefile.c >core.tmp /bin/sh ../../../binutils/bfd/doc/../../move-if-change core.tmp core.texi make chew make[4]: Entering directory `/home/enjoyo/RosBE-Unix-0.3.6/sources/binutils-build/bfd/doc' make[4]: "chew" is the newest. make[4]: Leaving directory `/home/enjoyo/RosBE-Unix-0.3.6/sources/binutils-build/bfd/doc' ./chew -f ../../../binutils/bfd/doc/doc.str <../../../binutils/bfd/doc/../elf.c >elf.tmp /bin/sh ../../../binutils/bfd/doc/../../move-if-change elf.tmp elf.texi make chew make[4]: Entering directory `/home/enjoyo/RosBE-Unix-0.3.6/sources/binutils-build/bfd/doc' make[4]: "chew" is the newest. make[4]: Leaving directory `/home/enjoyo/RosBE-Unix-0.3.6/sources/binutils-build/bfd/doc' ./chew -f ../../../binutils/bfd/doc/doc.str <../../../binutils/bfd/doc/../elfcode.h >elfcode.tmp /bin/sh ../../../binutils/bfd/doc/../../move-if-change elfcode.tmp elfcode.texi make chew make[4]: Entering directory `/home/enjoyo/RosBE-Unix-0.3.6/sources/binutils-build/bfd/doc' make[4]: "chew" is the newest. make[4]: Leaving directory `/home/enjoyo/RosBE-Unix-0.3.6/sources/binutils-build/bfd/doc' ./chew -f ../../../binutils/bfd/doc/doc.str <../../../binutils/bfd/doc/../format.c >format.tmp /bin/sh ../../../binutils/bfd/doc/../../move-if-change format.tmp format.texi make chew make[4]: Entering directory `/home/enjoyo/RosBE-Unix-0.3.6/sources/binutils-build/bfd/doc' make[4]: "chew" is the newest. make[4]: Leaving directory `/home/enjoyo/RosBE-Unix-0.3.6/sources/binutils-build/bfd/doc' ./chew -f ../../../binutils/bfd/doc/doc.str < ../../../binutils/bfd/doc/../libbfd.c >libbfd.tmp /bin/sh ../../../binutils/bfd/doc/../../move-if-change libbfd.tmp libbfd.texi make chew make[4]: Entering directory `/home/enjoyo/RosBE-Unix-0.3.6/sources/binutils-build/bfd/doc' make[4]: "chew" is the newest. make[4]: Leaving directory `/home/enjoyo/RosBE-Unix-0.3.6/sources/binutils-build/bfd/doc' ./chew -f ../../../binutils/bfd/doc/doc.str < ../../../binutils/bfd/doc/../bfdwin.c >bfdwin.tmp /bin/sh ../../../binutils/bfd/doc/../../move-if-change bfdwin.tmp bfdwin.texi make chew make[4]: Entering directory `/home/enjoyo/RosBE-Unix-0.3.6/sources/binutils-build/bfd/doc' make[4]: "chew" is the newest. make[4]: Leaving directory `/home/enjoyo/RosBE-Unix-0.3.6/sources/binutils-build/bfd/doc' ./chew -f ../../../binutils/bfd/doc/doc.str < ../../../binutils/bfd/doc/../bfdio.c >bfdio.tmp /bin/sh ../../../binutils/bfd/doc/../../move-if-change bfdio.tmp bfdio.texi make chew make[4]: Entering directory `/home/enjoyo/RosBE-Unix-0.3.6/sources/binutils-build/bfd/doc' make[4]: "chew" is the newest. make[4]: Leaving directory `/home/enjoyo/RosBE-Unix-0.3.6/sources/binutils-build/bfd/doc' ./chew -f ../../../binutils/bfd/doc/doc.str <../../../binutils/bfd/doc/../opncls.c >opncls.tmp /bin/sh ../../../binutils/bfd/doc/../../move-if-change opncls.tmp opncls.texi make chew make[4]: Entering directory `/home/enjoyo/RosBE-Unix-0.3.6/sources/binutils-build/bfd/doc' make[4]: "chew" is the newest. make[4]: Leaving directory `/home/enjoyo/RosBE-Unix-0.3.6/sources/binutils-build/bfd/doc' ./chew -f ../../../binutils/bfd/doc/doc.str <../../../binutils/bfd/doc/../reloc.c >reloc.tmp /bin/sh ../../../binutils/bfd/doc/../../move-if-change reloc.tmp reloc.texi make chew make[4]: Entering directory `/home/enjoyo/RosBE-Unix-0.3.6/sources/binutils-build/bfd/doc' make[4]: "chew" is the newest. make[4]: Leaving directory `/home/enjoyo/RosBE-Unix-0.3.6/sources/binutils-build/bfd/doc' ./chew -f ../../../binutils/bfd/doc/doc.str <../../../binutils/bfd/doc/../section.c >section.tmp /bin/sh ../../../binutils/bfd/doc/../../move-if-change section.tmp section.texi make chew make[4]: Entering directory `/home/enjoyo/RosBE-Unix-0.3.6/sources/binutils-build/bfd/doc' make[4]: "chew" is the newest. make[4]: Leaving directory `/home/enjoyo/RosBE-Unix-0.3.6/sources/binutils-build/bfd/doc' ./chew -f ../../../binutils/bfd/doc/doc.str <../../../binutils/bfd/doc/../syms.c >syms.tmp /bin/sh ../../../binutils/bfd/doc/../../move-if-change syms.tmp syms.texi make chew make[4]: Entering directory `/home/enjoyo/RosBE-Unix-0.3.6/sources/binutils-build/bfd/doc' make[4]: "chew" is the newest. make[4]: Leaving directory `/home/enjoyo/RosBE-Unix-0.3.6/sources/binutils-build/bfd/doc' ./chew -f ../../../binutils/bfd/doc/doc.str <../../../binutils/bfd/doc/../targets.c >targets.tmp /bin/sh ../../../binutils/bfd/doc/../../move-if-change targets.tmp targets.texi make chew make[4]: Entering directory `/home/enjoyo/RosBE-Unix-0.3.6/sources/binutils-build/bfd/doc' make[4]: "chew" is the newest. make[4]: Leaving directory `/home/enjoyo/RosBE-Unix-0.3.6/sources/binutils-build/bfd/doc' ./chew -f ../../../binutils/bfd/doc/doc.str <../../../binutils/bfd/doc/../init.c >init.tmp /bin/sh ../../../binutils/bfd/doc/../../move-if-change init.tmp init.texi make chew make[4]: Entering directory `/home/enjoyo/RosBE-Unix-0.3.6/sources/binutils-build/bfd/doc' make[4]: "chew" is the newest. make[4]: Leaving directory `/home/enjoyo/RosBE-Unix-0.3.6/sources/binutils-build/bfd/doc' ./chew -f ../../../binutils/bfd/doc/doc.str <../../../binutils/bfd/doc/../hash.c >hash.tmp /bin/sh ../../../binutils/bfd/doc/../../move-if-change hash.tmp hash.texi make chew make[4]: Entering directory `/home/enjoyo/RosBE-Unix-0.3.6/sources/binutils-build/bfd/doc' make[4]: "chew" is the newest. make[4]: Leaving directory `/home/enjoyo/RosBE-Unix-0.3.6/sources/binutils-build/bfd/doc' ./chew -f ../../../binutils/bfd/doc/doc.str <../../../binutils/bfd/doc/../linker.c >linker.tmp /bin/sh ../../../binutils/bfd/doc/../../move-if-change linker.tmp linker.texi make chew make[4]: Entering directory `/home/enjoyo/RosBE-Unix-0.3.6/sources/binutils-build/bfd/doc' make[4]: "chew" is the newest. make[4]: Leaving directory `/home/enjoyo/RosBE-Unix-0.3.6/sources/binutils-build/bfd/doc' ./chew -f ../../../binutils/bfd/doc/doc.str <../../../binutils/bfd/doc/../mmo.c >mmo.tmp /bin/sh ../../../binutils/bfd/doc/../../move-if-change mmo.tmp mmo.texi creating bfdver.texi restore=: && backupdir=".am$$" && \ rm -rf $backupdir && mkdir $backupdir && \ if (/home/enjoyo/RosBE-Unix-0.3.6/sources/binutils/missing makeinfo --split-size=5000000 --split-size=5000000 --version) >/dev/null 2>&1; then \ for f in bfd.info bfd.info-[0-9] bfd.info-[0-9][0-9] bfd.i[0-9] bfd.i[0-9][0-9]; do \ if test -f $f; then mv $f $backupdir; restore=mv; else :; fi; \ done; \ else :; fi && \ if /home/enjoyo/RosBE-Unix-0.3.6/sources/binutils/missing makeinfo --split-size=5000000 --split-size=5000000 -I ../../../binutils/bfd/doc \ -o bfd.info `test -f 'bfd.texinfo' || echo '../../../binutils/bfd/doc/'`bfd.texinfo; \ then \ rc=0; \ else \ rc=$?; \ $restore $backupdir/* `echo "./bfd.info" | sed 's|[^/]*$||'`; \ fi; \ rm -rf $backupdir; exit $rc WARNING: `makeinfo' is missing on your system. You should only need it if you modified a `.texi' or `.texinfo' file, or any other file indirectly affecting the aspect of the manual. The spurious call might also be the consequence of using a buggy `make' (AIX, DU, IRIX). You might want to install the `Texinfo' package or the `GNU make' package. Grab either from any GNU archive site. make[3]: *** [bfd.info] ERROR 1 make[3]: Leaving directory `/home/enjoyo/RosBE-Unix-0.3.6/sources/binutils-build/bfd/doc' Making info in po make[3]: Entering directory `/home/enjoyo/RosBE-Unix-0.3.6/sources/binutils-build/bfd/po' ( if test 'x../../../binutils/bfd/po' != 'x.'; then \ posrcprefix='../../../binutils/bfd/'; \ else \ posrcprefix="../"; \ fi; \ rm -f SRC-POTFILES-t SRC-POTFILES \ && (sed -e '/^#/d' \ -e '/^[ ]*$/d' \ -e "s@.*@ $posrcprefix& \\\\@" < ../../../binutils/bfd/po/SRC-POTFILES.in \ | sed -e '$s/\\$//') > SRC-POTFILES-t \ && chmod a-w SRC-POTFILES-t \ && mv SRC-POTFILES-t SRC-POTFILES ) ( rm -f BLD-POTFILES-t BLD-POTFILES \ && (sed -e '/^#/d' \ -e '/^[ ]*$/d' \ -e "s@.*@ ../& \\\\@" < ../../../binutils/bfd/po/BLD-POTFILES.in \ | sed -e '$s/\\$//') > BLD-POTFILES-t \ && chmod a-w BLD-POTFILES-t \ && mv BLD-POTFILES-t BLD-POTFILES ) cd .. \ && CONFIG_FILES=po/Makefile.in:po/Make-in \ CONFIG_HEADERS= /bin/sh ./config.status config.status: creating po/Makefile.in config.status: executing depfiles commands config.status: executing default-1 commands config.status: executing default commands make[3]: Leaving directory `/home/enjoyo/RosBE-Unix-0.3.6/sources/binutils-build/bfd/po' make[3]: Entering directory `/home/enjoyo/RosBE-Unix-0.3.6/sources/binutils-build/bfd/po' make[3]: Nothing to be done for `info'. make[3]: Leaving directory `/home/enjoyo/RosBE-Unix-0.3.6/sources/binutils-build/bfd/po' make[3]: Entering directory `/home/enjoyo/RosBE-Unix-0.3.6/sources/binutils-build/bfd' make[3]: Nothing to be done for `info-am'. make[3]: Leaving directory `/home/enjoyo/RosBE-Unix-0.3.6/sources/binutils-build/bfd' make[2]: *** [info-recursive] ERROR 1 make[2]: Leaving directory `/home/enjoyo/RosBE-Unix-0.3.6/sources/binutils-build/bfd' make[1]: *** [all-bfd] ERROR 2 make[1]: Leaving directory `/home/enjoyo/RosBE-Unix-0.3.6/sources/binutils-build' make: *** [all] ERROR 2

2 2

[ros-diffs] [jimtabor] 31174: A partial implementation of NtGdiCreate/DeleteClientObj.
by Timo Kreuzer 13 Dec '07

13 Dec '07

You probably meant GDI_OBJECT_TYPE_CLIOBJ > Author: jimtabor > Date: Wed Dec 12 05:29:21 2007 > New Revision: 31174 > > > + HANDLE handle = GDIOBJ_AllocObj(GdiHandleTable, GDI_OBJECT_TAG_CLIOBJ); > + return GDIOBJ_FreeObj(GdiHandleTable, h, GDI_OBJECT_TAG_CLIOBJ); >

2 1

Re: [ros-dev] [ros-diffs] [hpoussin] 31182: Remove useless test
by Steven Edwards 12 Dec '07

12 Dec '07

On Dec 12, 2007 7:08 AM, <hpoussin(a)svn.reactos.org> wrote: > Author: hpoussin > Date: Wed Dec 12 15:08:11 2007 > New Revision: 31182 > - * Copyright (C) 2002, 2003, 2004 ReactOS Team > + * Copyright (C) ReactOS Team A proper copyright header needs to show all of the years like * Copyright (C) 2002-2004,2007 ReactOS Team Thanks -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

1 0

Re: [ros-dev] [ros-diffs] [dchapyshev] 31048: - Move all hardcode strings to resource
by Ged Murphy 06 Dec '07

06 Dec '07

dchapyshev(a)svn.reactos.org wrote: > Author: dchapyshev > Date: Thu Dec 6 22:49:12 2007 > New Revision: 31048 > URL: http://svn.reactos.org/svn/reactos?rev=31048&view=rev > Log: > - Move all hardcode strings to resource This isn't actually used. It should be deleted. Ged.

1 0

Re: [ros-dev] [ros-diffs] [fireball] 31043: - Fix Greatlordisms: * Don't try to link *user*mode program to static *kernelmode* libcntpr. msvcrt.dll exists for this. * Fix main()'s declaration and definition. * The above changes fix compiling of rostest module.
by Alex Ionescu 06 Dec '07

06 Dec '07

Something is wrong with your development process if you believe libcntpr is a "kernel-mode" library. I always compile my native programs with it on Windows -- in fact so should ntdll in ReactOS. If it doesn't you may want to check your brains before bashing Greatlord... including msvcrt in a native program is a sure recipe for disaster... -- Best regards, Alex Ionescu On 6-Dec-07, at 10:44 AM, fireball(a)svn.reactos.org wrote: > Author: fireball > Date: Thu Dec 6 18:44:23 2007 > New Revision: 31043 > > URL: http://svn.reactos.org/svn/reactos?rev=31043&view=rev > Log: > - Fix Greatlordisms: > * Don't try to link *user*mode program to static *kernelmode* > libcntpr. msvcrt.dll exists for this. > * Fix main()'s declaration and definition. > * The above changes fix compiling of rostest module. > > Modified: > trunk/rostests/tests/D3DParseUnknownCommand_show/ > D3DParseUnknownCommand_show.rbuild > trunk/rostests/tests/D3DParseUnknownCommand_show/main.c > > Modified: trunk/rostests/tests/D3DParseUnknownCommand_show/ > D3DParseUnknownCommand_show.rbuild > URL: http://svn.reactos.org/svn/reactos/trunk/rostests/tests/ > D3DParseUnknownCommand_show/D3DParseUnknownCommand_show.rbuild? > rev=31043&r1=31042&r2=31043&view=diff > ====================================================================== > ======== > --- trunk/rostests/tests/D3DParseUnknownCommand_show/ > D3DParseUnknownCommand_show.rbuild (original) > +++ trunk/rostests/tests/D3DParseUnknownCommand_show/ > D3DParseUnknownCommand_show.rbuild Thu Dec 6 18:44:23 2007 > @@ -5,7 +5,6 @@ > <library>kernel32</library> > <library>gdi32</library> > <library>ddraw</library> > - <library>libcntpr</library> > <library>user32</library> > <file>main.c</file> > </module> > > Modified: trunk/rostests/tests/D3DParseUnknownCommand_show/main.c > URL: http://svn.reactos.org/svn/reactos/trunk/rostests/tests/ > D3DParseUnknownCommand_show/main.c? > rev=31043&r1=31042&r2=31043&view=diff > ====================================================================== > ======== > --- trunk/rostests/tests/D3DParseUnknownCommand_show/main.c (original) > +++ trunk/rostests/tests/D3DParseUnknownCommand_show/main.c Thu > Dec 6 18:44:23 2007 > @@ -22,10 +22,10 @@ > * > */ > > -INT main(INT argc, CHAR argv[]); > +INT main(INT argc, TCHAR *argv[]); > VOID BuildReturnCode(DWORD * ReturnCode); > > -INT main(INT argc, TCHAR argv[]) > +INT main(INT argc, TCHAR *argv[]) > { > DWORD ReturnCode[256]; > > @@ -44,6 +44,6 @@ > { > dp2command.bCommand = t; > ReturnCode[t] = D3DParseUnknownCommand ( (LPVOID) > &dp2command, (LPVOID *) lplpvReturnedCommand) ; > - printf("D3DParseUnknownCommand return code = %x command %d > \n", ReturnCode[t], t); > + printf("D3DParseUnknownCommand return code = %x command %d > \n", (UINT)ReturnCode[t], t); > } > } > >

1 0

Re: [ros-dev] [ros-diffs] [fireball] 31019: - Fix a bug.
by Ged Murphy 05 Dec '07

05 Dec '07

fireball(a)svn.reactos.org wrote: > Author: fireball > Date: Wed Dec 5 22:07:23 2007 > New Revision: 31019 > > URL: http://svn.reactos.org/svn/reactos?rev=31019&view=rev > Log: > - Fix a bug. janderwald??

1 0

Re: [ros-dev] Autogenerating compiler specific .def files
by Aleksey Bragin 03 Dec '07

03 Dec '07

Marc, I think I haven't been very clear on this. What I mean, is that the .spec format already includes *everything* needed to produce either gcc or msvc-format .def file. So no point in creating yet another format. Nothing more nothing less, that's what I ment. I'm glad to hear disadvantages of that way. WBR, Aleksey Bragin. On Nov 24, 2007, at 7:01 PM, Marc Piulachs wrote: > >> There is absolutely no need to invent yet another format for storing >> export functions. It was invented once by MSVC, it was invented by >> GCC/MinGW, both are incompatible, it was invented by Wine to have >> ability of easy functions stubbing. Should there be another invention >> of the same wheel by ReactOS now? > >> If GCC/MinGW wouldn't be that *strange*, it could stdcall-fixup, and >> then properly link, this way .def could be created in the lowest >> common denominator format. > > That's the problem I'm trying to solve..:) The point on this change > is not > really store them in xml inset of plain text, is not that > important, for me > there are two reasons, first declare this information so rbuild can > manipulate it as objects and apply checking , logic , whatever ... > and the > most important store the information on a neutral , compiler > agnostic and > rich format that allow us to generate (export to) ANY format we > desire out > of it. Currently def files are tided to mingw which is bad. > > At the end the information must be there so what's the difference > between > having it in a file with extension .def or .spec and having it on a > file > with .rbuild extension? IMO It's not reinventing the wheel > > /Marc

6 5

Build is broken as of Eric's change in r30958
by Colin Finck 02 Dec '07

02 Dec '07

Hello, As I don't know how to contact Eric, I post this on the mailing list now: With the change in r30958, the build is broken (at least for the BuildBot, see http://reactos.org:8010/ReactOS_%28Debug%29/builds/5979/step-shell_2/0). LD misses the "NetUserSetInfo" function. I looked into dll/win32/netapi32/netapi32.spec and it's declared there, but only as a stub. Don't know how to properly fix this now. Maybe it requires a real implementation of this function. Regards, Colin

2 2

Re: [ros-dev] [ros-diffs] [tkreuzer] 30929: patch by jimtabor: add GdiBCSelObj to GdiFlushUserBatch
by Aleksey Bragin 01 Dec '07

01 Dec '07

> + if(!dc) break; This additional check is not needed, because dc is checked at the beginning of the function now. WBR, Aleksey Bragin. On Dec 1, 2007, at 5:09 AM, tkreuzer(a)svn.reactos.org wrote: > Author: tkreuzer > Date: Sat Dec 1 05:09:39 2007 > New Revision: 30929 > > URL: http://svn.reactos.org/svn/reactos?rev=30929&view=rev > Log: > patch by jimtabor: add GdiBCSelObj to GdiFlushUserBatch > > Modified: > trunk/reactos/subsystems/win32/win32k/objects/gdibatch.c > > Modified: trunk/reactos/subsystems/win32/win32k/objects/gdibatch.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/ > win32/win32k/objects/gdibatch.c?rev=30929&r1=30928&r2=30929&view=diff > ====================================================================== > ======== > --- trunk/reactos/subsystems/win32/win32k/objects/gdibatch.c > (original) > +++ trunk/reactos/subsystems/win32/win32k/objects/gdibatch.c Sat > Dec 1 05:09:39 2007 > @@ -49,7 +49,13 @@ > case GdiBCExtSelClipRgn: > break; > case GdiBCSelObj: > - break; > + { > + PGDIBSOBJECT pgO; > + if(!dc) break; > + pgO = (PGDIBSOBJECT) pHdr; > + if(NT_SUCCESS(TextIntRealizeFont((HFONT) pgO->hgdiobj))) > + Dc_Attr->hlfntNew = (HFONT) pgO->hgdiobj; > + } > case GdiBCDelObj: > case GdiBCDelRgn: > { > @@ -115,3 +121,4 @@ > return STATUS_SUCCESS; > } > > + > >

2 1

ros-diffs] [cwittich] 30916: revert r28932
by James Tabor 30 Nov '07

30 Nov '07

Hi! That is why I hate CONTAINING_RECORD! It is so cheesy! Thanks Christoph, James

1 0

Re: [ros-dev] [ros-diffs] [cwittich] 30899: remove the const from the DrawShadowText function to be compatible to PSDK
by Steven Edwards 30 Nov '07

30 Nov '07

On Nov 29, 2007 11:04 AM, <cwittich(a)svn.reactos.org> wrote: > Author: cwittich > Date: Thu Nov 29 19:04:38 2007 > New Revision: 30899 > > URL: http://svn.reactos.org/svn/reactos?rev=30899&view=rev > Log: > remove the const from the DrawShadowText function to be compatible to PSDK Please send this on to winehq. Thanks -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

3 2

Re: [ros-dev] [ros-diffs] [cwittich] 30829: translated some DPRINTs from GreatLordish into a human readable format
by Ged Murphy 28 Nov '07

28 Nov '07

Cwittich wrote: > - DPRINT1("Warring no dxg.sys in ReactOS"); > + DPRINT1("Warning: dxg.sys not found\n"); The 'warring' returns, lmao, brilliant :)

1 0

Re: [ros-dev] [ros-diffs] [jimtabor] 30807: Revert 30780 for gdibatch. Size, space and time are very critical in here. If you dont know what your are doing? Do not play in here.
by Aleksey Bragin 27 Nov '07

27 Nov '07

How come size, space and time matter in this particular case of where the variable is declared (it's still defined in the stack, wherever you write it)? In the kernel, there is a rule to allocate all variables at top of the function (not in subsequent {} blocks). It should be extended to win32k too, it's cleaner, gives the developer an overview of all vars used in the function, and prevents possible cases of defining vars with the same name both atop of the function and in some subsequent block of code. Not to mention this is not fully correct to do in a C language. With the best regards, Aleksey Bragin. On Nov 27, 2007, at 4:14 AM, jimtabor(a)svn.reactos.org wrote: > Author: jimtabor > Date: Tue Nov 27 04:14:38 2007 > New Revision: 30807 > > URL: http://svn.reactos.org/svn/reactos?rev=30807&view=rev > Log: > Revert 30780 for gdibatch. Size, space and time are very critical > in here. If you dont know what your are doing? Do not play in here. > > Modified: > trunk/reactos/subsystems/win32/win32k/objects/gdibatch.c > > Modified: trunk/reactos/subsystems/win32/win32k/objects/gdibatch.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/ > win32/win32k/objects/gdibatch.c?rev=30807&r1=30806&r2=30807&view=diff > ====================================================================== > ======== > --- trunk/reactos/subsystems/win32/win32k/objects/gdibatch.c > (original) > +++ trunk/reactos/subsystems/win32/win32k/objects/gdibatch.c Tue > Nov 27 04:14:38 2007 > @@ -20,7 +20,6 @@ > { > PDC dc = NULL; > PDC_ATTR Dc_Attr = NULL; > - PGDIBSSETBRHORG pgSBO; > if (hDC) > { > dc = DC_LockDc(hDC); > @@ -40,6 +39,7 @@ > break; > case GdiBCSetBrushOrg: > { > + PGDIBSSETBRHORG pgSBO; > if (!dc) break; > pgSBO = (PGDIBSSETBRHORG) pHdr; > Dc_Attr->ptlBrushOrigin = pgSBO->ptlBrushOrigin; > >

2 1

Paste service
by Sylvain Petreolle 27 Nov '07

27 Nov '07

Looking at bug #933 in bugzilla, I see the following paste : http://www.reactos.org/paste/index.php/37693cf/ It has been posted on november 14th and set to expire after 7 days. Today is november 27, therefore this paste should have expired. Kind regards, Sylvain Petreolle (aka Usurp) Je ne suis pas d'accord avec ce que vous dites, mais je me battrai jusqu'à la mort pour que vous ayez le droit de le dire. I may disagree with what you have to say, but I shall defend, to the death, your right to say it. - Voltaire Run your favorite Windows apps with free ReactOS : http://www.reactos.org Listen to non-DRMised Music: http://www.jamendo.com

2 1

Re: [ros-dev] Autogenerating compiler specific .def files
by Aleksey Bragin 24 Nov '07

24 Nov '07

Theoretically extending this logic to infinity will lead to creation of a new high level language, stored in xml documents, parsing which rbuild generates source code in C or other language needed. :-). The thing is, .def is rather simple, .spec is a bit more advanced to include more stuff ("stub", what else does reactos use from it?). There is absolutely no need to invent yet another format for storing export functions. It was invented once by MSVC, it was invented by GCC/MinGW, both are incompatible, it was invented by Wine to have ability of easy functions stubbing. Should there be another invention of the same wheel by ReactOS now? If GCC/MinGW wouldn't be that *strange*, it could stdcall-fixup, and then properly link, this way .def could be created in the lowest common denominator format. With the best regards, Aleksey Bragin. On Nov 24, 2007, at 4:36 PM, Marc Piulachs wrote: > I wouldn't use .spec files for several reasons, first of all is > that it > violates the way how rbuild currently works. Rbuild reads xml > documents in a > custom format and produce different outputs depending on various > conditions. > IMO rbuild shouldn't be extended to parse anything else but > just .rbuild > files. > > Also, winebuild from the rbuild point of view is not different from > any > other compiler , so I think the problem is just the opposite , > rbuild should > use the information stored in it's rbuild file to produce the spec > file in > addition to the specific def file (it shouldn't be produced by > winebuild > anymore) as both files are required to compile wine module XYZ. > > Having the information in rbuild files has also other advantages, > the most > important is that it would allow us to use the conditional logic to > export > functions based on a given condition, for example hacks like > /lib/debugsup.rbuild won't be necessary anymore. > > I wouldn't fork winebuild. > > Regards, > Marc

4 8

Autogenerating compiler specific .def files
by Marc Piulachs 24 Nov '07

24 Nov '07

Hi All, I have lately seen a big effort to make more modules compilable under Visual C , one of our current problems when building dlls is that our .def files are mingw/gcc specific not directly compatible with msvc or any other future compiler we may support. Currently we are using not very elegant solutions to archive compatibility with msvc like stripping some information from mingw def files. As Alex suggested I think it's a good idea to move that information to rbuild files and let rbuild generate full compatible compiler def files in the intermediate folder. The advantages are obvious. As I have little experience with mingw def files I would like to request some help from other developers to evaluate/validate my proposal. >From my research on the ros codebase I have found that possible variations: - CcRosInitializeFileCache@8 - FsRtlGetFileSize - @HalExamineMBR@16 - PsChargeProcessNonPagedPoolQuota@4=PsDereferenceImpersonationToken@4 - ConvertSecurityDescriptorToAccessNamedA=ConvertSecurityDescriptorToAccessA@2 8 - GetSecurityDescriptorLength(a)4=NTDLL.RtlLengthSecurityDescriptor - ??1type_info@@UAE@XZ=__thiscall_MSVCRT_type_info_dtor @15 - ChkdskEx=VfatChkdsk@24 My proposed syntax is as following and it should support all of the above cases: <exportfunction name="CcRosInitializeFileCache" ordinal="8" /> (required) (optional) <exportfunction name="CcRosInitializeFileCache" ordinal="8" mappedname="PsDereferenceImpersonationToken" mappedordinal="4"/> (required) (optional) (optional) (optional) <exportfunction name="GetSecurityDescriptorLength" ordinal="4" mappedname="RtlLengthSecurityDescriptor" mappedordinal="4" module="ntdll"/> (required) (optional) (optional) (optional) (optional) With this information rbuild will generate a modulename_gcc.def when you type "make" and modulename_msvc.def on the intermediate folder when you type "make msvc". Opinions, comments? Regards, Marc

3 3

Re: [ros-dev] Autogenerating compiler specific .def files
by Aleksey Bragin 24 Nov '07

24 Nov '07

Hi, why can't .spec be used for this purpose (extended to support msvc files generation)? They are going to stay anyway for wine-shared modules. With the best regards, Aleksey Bragin. On Nov 24, 2007, at 3:04 AM, Marc Piulachs wrote: > Hi All, > > > > I have lately seen a big effort to make more modules compilable > under Visual C , one of our current problems when building dlls is > that our .def files are mingw/gcc specific not directly compatible > with msvc or any other future compiler we may support. Currently we > are using not very elegant solutions to archive compatibility with > msvc like stripping some information from mingw def files. As Alex > suggested I think it’s a good idea to move that information to > rbuild files and let rbuild generate full compatible compiler def > files in the intermediate folder. The advantages are obvious. > > > > As I have little experience with mingw def files I would like to > request some help from other developers to evaluate/validate my > proposal. > > > > From my research on the ros codebase I have found that possible > variations:

3 2

Re: [ros-dev] [ros-diffs] [cwittich] 30460: sync CryptAcquireContext to wine (this fixes some Unicode issues)
by Alex Ionescu 23 Nov '07

23 Nov '07

"HCRYPTHASH hPrivate; /*CSP's handle - Should not be given to application under any circumstances!*/" Are Wine people aware that DLLs load in the same address space as applications? There is no way to protect this handle from the application unless you store it in kernel-mode. On Nov 15, 2007 9:08 AM, <cwittich(a)svn.reactos.org> wrote: > Author: cwittich > Date: Thu Nov 15 17:08:18 2007 > New Revision: 30460 > > URL: http://svn.reactos.org/svn/reactos?rev=30460&view=rev > Log: > sync CryptAcquireContext to wine (this fixes some Unicode issues) > > Modified: > trunk/reactos/dll/win32/advapi32/crypt/crypt.c > trunk/reactos/dll/win32/advapi32/crypt/crypt.h > > Modified: trunk/reactos/dll/win32/advapi32/crypt/crypt.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/advapi32/crypt/c… > > ============================================================================== > --- trunk/reactos/dll/win32/advapi32/crypt/crypt.c (original) > +++ trunk/reactos/dll/win32/advapi32/crypt/crypt.c Thu Nov 15 17:08:18 > 2007 > @@ -55,45 +55,56 @@ > #define CRYPT_Alloc(size) ((LPVOID)LocalAlloc(LMEM_ZEROINIT, size)) > #define CRYPT_Free(buffer) (LocalFree((HLOCAL)buffer)) > > -static inline PSTR CRYPT_GetProvKeyName(PCSTR pProvName) > -{ > - PCSTR KEYSTR = > "Software\\Microsoft\\Cryptography\\Defaults\\Provider\\"; > - PSTR keyname; > - > - keyname = CRYPT_Alloc(strlen(KEYSTR) + strlen(pProvName) +1); > +static inline PWSTR CRYPT_GetProvKeyName(PCWSTR pProvName) > +{ > + static const WCHAR KEYSTR[] = { > + 'S','o','f','t','w','a','r','e','\\', > + 'M','i','c','r','o','s','o','f','t','\\', > + 'C','r','y','p','t','o','g','r','a','p','h','y','\\', > + 'D','e','f','a','u','l','t','s','\\', > + 'P','r','o','v','i','d','e','r','\\',0 > + }; > + PWSTR keyname; > + > + keyname = CRYPT_Alloc((wcslen(KEYSTR) + wcslen(pProvName) > +1)*sizeof(WCHAR)); > if (keyname) > { > - strcpy(keyname, KEYSTR); > - strcpy(keyname + strlen(KEYSTR), pProvName); > - } > - else > - { > + wcscpy(keyname, KEYSTR); > + wcscpy(keyname + wcslen(KEYSTR), pProvName); > + } else > SetLastError(ERROR_NOT_ENOUGH_MEMORY); > - } > - > return keyname; > } > > -static inline PSTR CRYPT_GetTypeKeyName(DWORD dwType, BOOL user) > -{ > - PCSTR MACHINESTR = > "Software\\Microsoft\\Cryptography\\Defaults\\Provider Types\\Type XXX"; > - PCSTR USERSTR = "Software\\Microsoft\\Cryptography\\Provider Type > XXX"; > - PSTR keyname; > - PSTR ptr; > - > - keyname = CRYPT_Alloc( (user ? strlen(USERSTR) : > strlen(MACHINESTR)) +1); > +static inline PWSTR CRYPT_GetTypeKeyName(DWORD dwType, BOOL user) > +{ > + static const WCHAR MACHINESTR[] = { > + 'S','o','f','t','w','a','r','e','\\', > + 'M','i','c','r','o','s','o','f','t','\\', > + 'C','r','y','p','t','o','g','r','a','p','h','y','\\', > + 'D','e','f','a','u','l','t','s','\\', > + 'P','r','o','v','i','d','e','r',' > ','T','y','p','e','s','\\', > + 'T','y','p','e',' ','X','X','X',0 > + }; > + static const WCHAR USERSTR[] = { > + 'S','o','f','t','w','a','r','e','\\', > + 'M','i','c','r','o','s','o','f','t','\\', > + 'C','r','y','p','t','o','g','r','a','p','h','y','\\', > + 'P','r','o','v','i','d','e','r',' ','T','y','p','e',' > ','X','X','X',0 > + }; > + PWSTR keyname; > + PWSTR ptr; > + > + keyname = CRYPT_Alloc( ((user ? wcslen(USERSTR) : > wcslen(MACHINESTR)) +1)*sizeof(WCHAR)); > if (keyname) > { > - user ? strcpy(keyname, USERSTR) : strcpy(keyname, > MACHINESTR); > - ptr = keyname + strlen(keyname); > + user ? wcscpy(keyname, USERSTR) : wcscpy(keyname, > MACHINESTR); > + ptr = keyname + wcslen(keyname); > *(--ptr) = (dwType % 10) + '0'; > *(--ptr) = ((dwType / 10) % 10) + '0'; > *(--ptr) = (dwType / 100) + '0'; > - } > - else > - { > + } else > SetLastError(ERROR_NOT_ENOUGH_MEMORY); > - } > return keyname; > } > > @@ -178,26 +189,23 @@ > > #define CRYPT_GetProvFunc(name) \ > if ( !(provider->pFuncs->p##name = > (void*)GetProcAddress(provider->hModule, #name)) ) goto error > - > #define CRYPT_GetProvFuncOpt(name) \ > provider->pFuncs->p##name = > (void*)GetProcAddress(provider->hModule, #name) > -PCRYPTPROV CRYPT_LoadProvider(PSTR pImage) > +static PCRYPTPROV CRYPT_LoadProvider(PCWSTR pImage) > { > PCRYPTPROV provider; > DWORD errorcode = ERROR_NOT_ENOUGH_MEMORY; > > - if (!(provider = CRYPT_Alloc(sizeof(CRYPTPROV)))) > + if ( !(provider = CRYPT_Alloc(sizeof(CRYPTPROV))) ) goto error; > + if ( !(provider->pFuncs = CRYPT_Alloc(sizeof(PROVFUNCS))) ) goto > error; > + if ( !(provider->pVTable = CRYPT_Alloc(sizeof(VTableProvStruc))) ) > goto error; > + if ( !(provider->hModule = LoadLibraryW(pImage)) ) > + { > + errorcode = (GetLastError() == ERROR_FILE_NOT_FOUND) ? > NTE_PROV_DLL_NOT_FOUND : NTE_PROVIDER_DLL_FAIL; > + DPRINT("Failed to load dll %S\n", pImage); > goto error; > - if (!(provider->pFuncs = CRYPT_Alloc(sizeof(PROVFUNCS)))) > - goto error; > - if (!(provider->pVTable = CRYPT_Alloc(sizeof(VTableProvStruc)))) > - goto error; > - if (!(provider->hModule = LoadLibraryA(pImage))) > - { > - errorcode = (GetLastError() == ERROR_FILE_NOT_FOUND) ? > NTE_PROV_DLL_NOT_FOUND : NTE_PROVIDER_DLL_FAIL; > - DPRINT1("Failed to load dll %s\n", pImage); > - goto error; > - } > + } > + provider->dwMagic = MAGIC_CRYPTPROV; > provider->refcount = 1; > > errorcode = NTE_PROVIDER_DLL_FAIL; > @@ -243,6 +251,7 @@ > SetLastError(errorcode); > if (provider) > { > + provider->dwMagic = 0; > if (provider->hModule) > FreeLibrary(provider->hModule); > CRYPT_Free(provider->pVTable); > @@ -256,30 +265,35 @@ > > > > /****************************************************************************** > - * CryptAcquireContextA (ADVAPI32.@) > + * CryptAcquireContextW (ADVAPI32.@) > + * > * Acquire a crypto provider context handle. > * > * PARAMS > - * phProv: Pointer to HCRYPTPROV for the output. > - * pszContainer: Key Container Name > - * pszProvider: Cryptographic Service Provider Name > - * dwProvType: Crypto provider type to get a handle. > - * dwFlags: flags for the operation > - * > - * RETURNS TRUE on success, FALSE on failure. > - */ > -BOOL WINAPI CryptAcquireContextA (HCRYPTPROV *phProv, LPCSTR > pszContainer, > - LPCSTR pszProvider, DWORD dwProvType, DWORD dwFlags) > + * phProv [O] Pointer to HCRYPTPROV for the output. > + * pszContainer [I] Key Container Name > + * pszProvider [I] Cryptographic Service Provider Name > + * dwProvType [I] Crypto provider type to get a handle. > + * dwFlags [I] flags for the operation > + * > + * RETURNS > + * TRUE on success, FALSE on failure. > + */ > +BOOL WINAPI CryptAcquireContextW (HCRYPTPROV *phProv, LPCWSTR > pszContainer, > + LPCWSTR pszProvider, DWORD dwProvType, DWORD dwFlags) > { > PCRYPTPROV pProv = NULL; > HKEY key; > - PSTR imagepath = NULL, keyname = NULL, provname = NULL, temp = > NULL; > - BYTE* signature; > + PWSTR imagepath = NULL, keyname = NULL, provname = NULL, temp = > NULL; > + PSTR provnameA = NULL, pszContainerA = NULL; > DWORD keytype, type, len; > ULONG r; > - > - DPRINT("(%p, %s, %s, %ld, %08lx)\n", phProv, pszContainer, > - pszProvider, dwProvType, dwFlags); > + static const WCHAR nameW[] = {'N','a','m','e',0}; > + static const WCHAR typeW[] = {'T','y','p','e',0}; > + static const WCHAR imagepathW[] = {'I','m','a','g','e',' > ','P','a','t','h',0}; > + > + DPRINT("(%p, %S, %S, %d, %08x)\n", phProv, pszContainer, > + pszProvider, dwProvType, dwFlags); > > if (dwProvType < 1 || dwProvType > MAXPROVTYPES) > { > @@ -298,26 +312,21 @@ > /* No CSP name specified so try the user default CSP first > * then try the machine default CSP > */ > - if (!(keyname = CRYPT_GetTypeKeyName(dwProvType, TRUE))) > - { > - DPRINT("No provider registered for crypto provider > type %ld.\n", dwProvType); > + if ( !(keyname = CRYPT_GetTypeKeyName(dwProvType, TRUE)) ) > { > + DPRINT("No provider registered for crypto provider > type %d.\n", dwProvType); > SetLastError(NTE_PROV_TYPE_NOT_DEF); > return FALSE; > } > - > - if (RegOpenKeyA(HKEY_CURRENT_USER, keyname, &key)) > + if (RegOpenKeyW(HKEY_CURRENT_USER, keyname, &key)) > { > CRYPT_Free(keyname); > - if (!(keyname = CRYPT_GetTypeKeyName(dwProvType, > FALSE))) > - { > - DPRINT("No type registered for crypto > provider type %ld.\n", dwProvType); > + if ( !(keyname = CRYPT_GetTypeKeyName(dwProvType, > FALSE)) ) { > + DPRINT("No type registered for crypto > provider type %d.\n", dwProvType); > RegCloseKey(key); > SetLastError(NTE_PROV_TYPE_NOT_DEF); > goto error; > } > - > - if (RegOpenKeyA(HKEY_LOCAL_MACHINE, keyname, > &key)) > - { > + if (RegOpenKeyW(HKEY_LOCAL_MACHINE, keyname, > &key)) { > DPRINT("Did not find registry entry of > crypto provider for %S.\n", keyname); > CRYPT_Free(keyname); > RegCloseKey(key); > @@ -325,44 +334,41 @@ > goto error; > } > } > - > CRYPT_Free(keyname); > - r = RegQueryValueExA(key, "Name", NULL, &keytype, NULL, > &len); > - if (r != ERROR_SUCCESS || !len || keytype != REG_SZ) > + r = RegQueryValueExW(key, nameW, NULL, &keytype, NULL, > &len); > + if( r != ERROR_SUCCESS || !len || keytype != REG_SZ) > { > - DPRINT("error %ld reading size of 'Name' from > registry\n", r ); > + DPRINT("error %d reading size of 'Name' from > registry\n", r ); > RegCloseKey(key); > SetLastError(NTE_PROV_TYPE_ENTRY_BAD); > goto error; > } > - if (!(provname = CRYPT_Alloc(len))) > + if(!(provname = CRYPT_Alloc(len))) > { > RegCloseKey(key); > SetLastError(ERROR_NOT_ENOUGH_MEMORY); > goto error; > } > - r = RegQueryValueExA(key, "Name", NULL, NULL, > (LPBYTE)provname, &len); > - if (r != ERROR_SUCCESS) > + r = RegQueryValueExW(key, nameW, NULL, NULL, > (LPBYTE)provname, &len); > + if( r != ERROR_SUCCESS ) > { > - DPRINT("error %ld reading 'Name' from registry\n", > r ); > + DPRINT("error %d reading 'Name' from registry\n", > r ); > RegCloseKey(key); > SetLastError(NTE_PROV_TYPE_ENTRY_BAD); > goto error; > } > RegCloseKey(key); > - } > - else > - { > - if (!(provname = CRYPT_Alloc(strlen(pszProvider) +1))) > + } else { > + if ( !(provname = CRYPT_Alloc((wcslen(pszProvider) > +1)*sizeof(WCHAR))) ) > { > SetLastError(ERROR_NOT_ENOUGH_MEMORY); > goto error; > } > - strcpy(provname, pszProvider); > + wcscpy(provname, pszProvider); > } > > keyname = CRYPT_GetProvKeyName(provname); > - r = RegOpenKeyA(HKEY_LOCAL_MACHINE, keyname, &key); > + r = RegOpenKeyW(HKEY_LOCAL_MACHINE, keyname, &key); > CRYPT_Free(keyname); > if (r != ERROR_SUCCESS) > { > @@ -370,7 +376,7 @@ > goto error; > } > len = sizeof(DWORD); > - r = RegQueryValueExA(key, "Type", NULL, NULL, (BYTE*)&type, &len); > + r = RegQueryValueExW(key, typeW, NULL, NULL, (BYTE*)&type, &len); > if (r != ERROR_SUCCESS) > { > SetLastError(NTE_PROV_TYPE_ENTRY_BAD); > @@ -378,15 +384,15 @@ > } > if (type != dwProvType) > { > - DPRINT("Crypto provider has wrong type (%ld vs expected > %ld).\n", type, dwProvType); > + DPRINT("Crypto provider has wrong type (%d vs expected > %d).\n", type, dwProvType); > SetLastError(NTE_PROV_TYPE_NO_MATCH); > goto error; > } > > - r = RegQueryValueExA(key, "Image Path", NULL, &keytype, NULL, > &len); > + r = RegQueryValueExW(key, imagepathW, NULL, &keytype, NULL, &len); > if ( r != ERROR_SUCCESS || keytype != REG_SZ) > { > - DPRINT("error %ld reading size of 'Image Path' from > registry\n", r ); > + DPRINT("error %d reading size of 'Image Path' from > registry\n", r ); > RegCloseKey(key); > SetLastError(NTE_PROV_TYPE_ENTRY_BAD); > goto error; > @@ -397,90 +403,44 @@ > SetLastError(ERROR_NOT_ENOUGH_MEMORY); > goto error; > } > - r = RegQueryValueExA(key, "Image Path", NULL, NULL, (LPBYTE)temp, > &len); > - if (r != ERROR_SUCCESS) > - { > - DPRINT("error %ld reading 'Image Path' from registry\n", r > ); > + r = RegQueryValueExW(key, imagepathW, NULL, NULL, (LPBYTE)temp, > &len); > + if( r != ERROR_SUCCESS ) > + { > + DPRINT("error %d reading 'Image Path' from registry\n", r > ); > RegCloseKey(key); > SetLastError(NTE_PROV_TYPE_ENTRY_BAD); > goto error; > } > - > - r = RegQueryValueExA(key, "Signature", NULL, &keytype, NULL, > &len); > - if (r == ERROR_SUCCESS && keytype == REG_BINARY) > - { > - if (!(signature = CRYPT_Alloc(len))) > - { > - RegCloseKey(key); > - SetLastError(ERROR_NOT_ENOUGH_MEMORY); > - goto error; > - } > - r = RegQueryValueExA(key, "Signature", NULL, NULL, > signature, &len); > - if (r != ERROR_SUCCESS) > - { > - DPRINT("error %ld reading 'Signature'\n", r ); > - CRYPT_Free(signature); > - RegCloseKey(key); > - SetLastError(NTE_PROV_TYPE_ENTRY_BAD); > - goto error; > - } > - } > - else > - { > - r = RegQueryValueExA(key, "SigInFile", NULL, &keytype, > NULL, &len); > - if (r != ERROR_SUCCESS) > - { > - DPRINT("error %ld reading size of 'SigInFile'\n", > r ); > - RegCloseKey(key); > - SetLastError(NTE_PROV_TYPE_ENTRY_BAD); > - goto error; > - } > - else > - { > - /* FIXME: The presence of the SigInFile value > indicates the > - * provider's signature is in its resources, so > need to read it. > - * But since CRYPT_VerifyImage is stubbed, provide > any old thing > - * for now. > - */ > - if (!(signature = CRYPT_Alloc(1))) > - { > - RegCloseKey(key); > - SetLastError(ERROR_NOT_ENOUGH_MEMORY); > - goto error; > - } > - } > - } > RegCloseKey(key); > - len = ExpandEnvironmentStringsA(temp, NULL, 0); > - if (!(imagepath = CRYPT_Alloc(len))) > - { > - CRYPT_Free(signature); > + len = ExpandEnvironmentStringsW(temp, NULL, 0); > + if ( !(imagepath = CRYPT_Alloc(len*sizeof(WCHAR))) ) > + { > SetLastError(ERROR_NOT_ENOUGH_MEMORY); > goto error; > } > - if (!ExpandEnvironmentStringsA(temp, imagepath, len)) > - { > - CRYPT_Free(signature); > + if (!ExpandEnvironmentStringsW(temp, imagepath, len)) > + { > /* ExpandEnvironmentStrings will call SetLastError */ > goto error; > } > - > - if (!CRYPT_VerifyImage(imagepath, signature)) > - { > - CRYPT_Free(signature); > - SetLastError(NTE_SIGNATURE_FILE_BAD); > - goto error; > - } > pProv = CRYPT_LoadProvider(imagepath); > - CRYPT_Free(signature); > - if (!pProv) > - { > + if (!pProv) { > /* CRYPT_LoadProvider calls SetLastError */ > goto error; > } > pProv->pVTable->dwProvType = dwProvType; > - pProv->pVTable->pszProvName = provname; > - if (pProv->pFuncs->pCPAcquireContext(&pProv->hPrivate, > (CHAR*)pszContainer, dwFlags, pProv->pVTable)) > + if(!CRYPT_UnicodeToANSI(provname, &provnameA, -1)) > + { > + /* CRYPT_UnicodeToANSI calls SetLastError */ > + goto error; > + } > + pProv->pVTable->pszProvName = provnameA; > + if(!CRYPT_UnicodeToANSI(pszContainer, &pszContainerA, -1)) > + { > + /* CRYPT_UnicodeToANSI calls SetLastError */ > + goto error; > + } > + if (pProv->pFuncs->pCPAcquireContext(&pProv->hPrivate, > pszContainerA, dwFlags, pProv->pVTable)) > { > /* MSDN: When this flag is set, the value returned in > phProv is undefined, > * and thus, the CryptReleaseContext function need > not be called afterwards. > @@ -488,15 +448,17 @@ > */ > if (dwFlags & CRYPT_DELETEKEYSET) > { > + pProv->dwMagic = 0; > FreeLibrary(pProv->hModule); > - CRYPT_Free(provname); > + CRYPT_Free(provnameA); > + CRYPT_Free(pProv->pVTable); > CRYPT_Free(pProv->pFuncs); > CRYPT_Free(pProv); > - } > - else > - { > + } else { > *phProv = (HCRYPTPROV)pProv; > } > + CRYPT_Free(pszContainerA); > + CRYPT_Free(provname); > CRYPT_Free(temp); > CRYPT_Free(imagepath); > return TRUE; > @@ -505,51 +467,51 @@ > error: > if (pProv) > { > + pProv->dwMagic = 0; > if (pProv->hModule) > FreeLibrary(pProv->hModule); > - if (pProv->pVTable) > - CRYPT_Free(pProv->pVTable); > - if (pProv->pFuncs) > - CRYPT_Free(pProv->pFuncs); > + CRYPT_Free(pProv->pVTable); > + CRYPT_Free(pProv->pFuncs); > CRYPT_Free(pProv); > } > - if (provname) > - CRYPT_Free(provname); > - if (temp) > - CRYPT_Free(temp); > - if (imagepath) > - CRYPT_Free(imagepath); > + CRYPT_Free(pszContainerA); > + CRYPT_Free(provnameA); > + CRYPT_Free(provname); > + CRYPT_Free(temp); > + CRYPT_Free(imagepath); > return FALSE; > } > > > /****************************************************************************** > - * CryptAcquireContextW (ADVAPI32.@) > - * > - * see CryptAcquireContextA > - */ > -BOOL WINAPI CryptAcquireContextW (HCRYPTPROV *phProv, LPCWSTR > pszContainer, > - LPCWSTR pszProvider, DWORD dwProvType, DWORD dwFlags) > -{ > - PSTR pProvider = NULL, pContainer = NULL; > + * CryptAcquireContextA (ADVAPI32.@) > + * > + * See CryptAcquireContextW. > + */ > +BOOL WINAPI CryptAcquireContextA (HCRYPTPROV *phProv, LPCSTR > pszContainer, > + LPCSTR pszProvider, DWORD dwProvType, DWORD dwFlags) > +{ > + PWSTR pProvider = NULL, pContainer = NULL; > BOOL ret = FALSE; > > - DPRINT("(%p, %S, %S, %ld, %08lx)\n", phProv, pszContainer, > + DPRINT("(%p, %s, %s, %d, %08x)\n", phProv, pszContainer, > pszProvider, dwProvType, dwFlags); > > - if (!CRYPT_UnicodeToANSI(pszContainer, &pContainer, -1)) > - CRYPT_ReturnLastError(ERROR_NOT_ENOUGH_MEMORY); > - if (!CRYPT_UnicodeToANSI(pszProvider, &pProvider, -1)) > + if ( !CRYPT_ANSIToUnicode(pszContainer, &pContainer, -1) ) > + { > + SetLastError(ERROR_NOT_ENOUGH_MEMORY); > + return FALSE; > + } > + if ( !CRYPT_ANSIToUnicode(pszProvider, &pProvider, -1) ) > { > CRYPT_Free(pContainer); > - CRYPT_ReturnLastError(ERROR_NOT_ENOUGH_MEMORY); > - } > - > - ret = CryptAcquireContextA(phProv, pContainer, pProvider, > dwProvType, dwFlags); > - > - if (pContainer) > - CRYPT_Free(pContainer); > - if (pProvider) > - CRYPT_Free(pProvider); > + SetLastError(ERROR_NOT_ENOUGH_MEMORY); > + return FALSE; > + } > + > + ret = CryptAcquireContextW(phProv, pContainer, pProvider, > dwProvType, dwFlags); > + > + CRYPT_Free(pContainer); > + CRYPT_Free(pProvider); > > return ret; > } > @@ -1256,7 +1218,7 @@ > } > > > /****************************************************************************** > - * CryptGetDefaultProviderA (ADVAPI32.@) > + * CryptGetDefaultProviderW (ADVAPI32.@) > * > * Finds the default CSP of a certain provider type. > * > @@ -1275,29 +1237,43 @@ > * If pszProvName is NULL, pcbProvName will hold the size of the buffer > for > * memory allocation purposes on return. > */ > -BOOL WINAPI CryptGetDefaultProviderA (DWORD dwProvType, DWORD > *pdwReserved, > - DWORD dwFlags, LPSTR pszProvName, DWORD *pcbProvName) > +BOOL WINAPI CryptGetDefaultProviderW (DWORD dwProvType, DWORD > *pdwReserved, > + DWORD dwFlags, LPWSTR pszProvName, DWORD *pcbProvName) > { > HKEY hKey; > - PSTR keyname; > + PWSTR keyname; > DWORD result; > + static const WCHAR nameW[] = {'N','a','m','e',0}; > > if (pdwReserved || !pcbProvName) > - CRYPT_ReturnLastError(ERROR_INVALID_PARAMETER); > + { > + SetLastError(ERROR_INVALID_PARAMETER); > + return FALSE; > + } > if (dwFlags & ~(CRYPT_USER_DEFAULT | CRYPT_MACHINE_DEFAULT)) > - CRYPT_ReturnLastError(NTE_BAD_FLAGS); > + { > + SetLastError(NTE_BAD_FLAGS); > + return FALSE; > + } > if (dwProvType > 999) > - CRYPT_ReturnLastError(NTE_BAD_PROV_TYPE); > - if (!(keyname = CRYPT_GetTypeKeyName(dwProvType, dwFlags & > CRYPT_USER_DEFAULT))) > - CRYPT_ReturnLastError(ERROR_NOT_ENOUGH_MEMORY); > - if (RegOpenKeyA((dwFlags & CRYPT_USER_DEFAULT) ? > HKEY_CURRENT_USER : HKEY_LOCAL_MACHINE ,keyname, &hKey)) > + { > + SetLastError(NTE_BAD_PROV_TYPE); > + return FALSE; > + } > + if ( !(keyname = CRYPT_GetTypeKeyName(dwProvType, dwFlags & > CRYPT_USER_DEFAULT)) ) > + { > + SetLastError(ERROR_NOT_ENOUGH_MEMORY); > + return FALSE; > + } > + if (RegOpenKeyW((dwFlags & CRYPT_USER_DEFAULT) ? > HKEY_CURRENT_USER : HKEY_LOCAL_MACHINE ,keyname, &hKey)) > { > CRYPT_Free(keyname); > - CRYPT_ReturnLastError(NTE_PROV_TYPE_NOT_DEF); > + SetLastError(NTE_PROV_TYPE_NOT_DEF); > + return FALSE; > } > CRYPT_Free(keyname); > - > - result = RegQueryValueExA(hKey, "Name", NULL, NULL, > (LPBYTE)pszProvName, pcbProvName); > + > + result = RegQueryValueExW(hKey, nameW, NULL, NULL, > (LPBYTE)pszProvName, pcbProvName); > if (result) > { > if (result != ERROR_MORE_DATA) > @@ -1313,29 +1289,38 @@ > } > > > /****************************************************************************** > - * CryptGetDefaultProviderW (ADVAPI32.@) > - * > - * see CryptGetDefaultProviderA > - */ > -BOOL WINAPI CryptGetDefaultProviderW (DWORD dwProvType, DWORD > *pdwReserved, > - DWORD dwFlags, LPWSTR pszProvName, DWORD *pcbProvName) > -{ > - PSTR str = NULL; > + * CryptGetDefaultProviderA (ADVAPI32.@) > + * > + * See CryptGetDefaultProviderW. > + */ > +BOOL WINAPI CryptGetDefaultProviderA (DWORD dwProvType, DWORD > *pdwReserved, > + DWORD dwFlags, LPSTR pszProvName, DWORD *pcbProvName) > +{ > + PWSTR str = NULL; > DWORD strlen; > BOOL ret = FALSE; > > - DPRINT("(%ld, %p, %08ld, %p, %p)\n", dwProvType, pdwReserved, > dwFlags, pszProvName, pcbProvName); > - > - strlen = *pcbProvName / sizeof(WCHAR); > - if (pszProvName && !(str = CRYPT_Alloc(strlen))) > - CRYPT_ReturnLastError(ERROR_NOT_ENOUGH_MEMORY); > - ret = CryptGetDefaultProviderA(dwProvType, pdwReserved, dwFlags, > str, &strlen); > + DPRINT("(%d, %p, %08x, %p, %p)\n", dwProvType, pdwReserved, > dwFlags, pszProvName, pcbProvName); > + > + CryptGetDefaultProviderW(dwProvType, pdwReserved, dwFlags, NULL, > &strlen); > + if ( pszProvName && !(str = CRYPT_Alloc(strlen)) ) > + { > + SetLastError(ERROR_NOT_ENOUGH_MEMORY); > + return FALSE; > + } > + ret = CryptGetDefaultProviderW(dwProvType, pdwReserved, dwFlags, > str, &strlen); > if (str) > - { > - CRYPT_ANSIToUnicode(str, &pszProvName, *pcbProvName); > + CRYPT_UnicodeToANSI(str, &pszProvName, *pcbProvName); > + *pcbProvName = strlen / sizeof(WCHAR); > + if (str) > + { > CRYPT_Free(str); > - } > - *pcbProvName = strlen * sizeof(WCHAR); > + if (GetLastError() == ERROR_INSUFFICIENT_BUFFER) > + { > + SetLastError(ERROR_MORE_DATA); > + return FALSE; > + } > + } > return ret; > } > > @@ -1726,7 +1711,7 @@ > } > > > /****************************************************************************** > - * CryptSetProviderExA (ADVAPI32.@) > + * CryptSetProviderExW (ADVAPI32.@) > * > * Specifies the default CSP. > * > @@ -1740,58 +1725,75 @@ > * Success: TRUE > * Failure: FALSE > */ > -BOOL WINAPI CryptSetProviderExA (LPCSTR pszProvName, DWORD dwProvType, > DWORD *pdwReserved, DWORD dwFlags) > +BOOL WINAPI CryptSetProviderExW (LPCWSTR pszProvName, DWORD dwProvType, > DWORD *pdwReserved, DWORD dwFlags) > { > HKEY hProvKey, hTypeKey; > - PSTR keyname; > - > - DPRINT("(%s, %ld, %p, %08ld)\n", pszProvName, dwProvType, > pdwReserved, dwFlags); > + PWSTR keyname; > + static const WCHAR nameW[] = {'N','a','m','e',0}; > + > + DPRINT("(%S, %d, %p, %08x)\n", pszProvName, dwProvType, > pdwReserved, dwFlags); > > if (!pszProvName || pdwReserved) > - CRYPT_ReturnLastError(ERROR_INVALID_PARAMETER); > + { > + SetLastError(ERROR_INVALID_PARAMETER); > + return FALSE; > + } > if (dwProvType > MAXPROVTYPES) > - CRYPT_ReturnLastError(NTE_BAD_PROV_TYPE); > + { > + SetLastError(NTE_BAD_PROV_TYPE); > + return FALSE; > + } > if (dwFlags & ~(CRYPT_MACHINE_DEFAULT | CRYPT_USER_DEFAULT | > CRYPT_DELETE_DEFAULT) > || dwFlags == CRYPT_DELETE_DEFAULT) > - CRYPT_ReturnLastError(NTE_BAD_FLAGS); > + { > + SetLastError(NTE_BAD_FLAGS); > + return FALSE; > + } > > if (!(keyname = CRYPT_GetTypeKeyName(dwProvType, dwFlags & > CRYPT_USER_DEFAULT))) > - CRYPT_ReturnLastError(ERROR_NOT_ENOUGH_MEMORY); > - if (RegOpenKeyA((dwFlags & CRYPT_USER_DEFAULT) ? HKEY_CURRENT_USER > : HKEY_LOCAL_MACHINE, > + { > + SetLastError(ERROR_NOT_ENOUGH_MEMORY); > + return FALSE; > + } > + if (RegOpenKeyW((dwFlags & CRYPT_USER_DEFAULT) ? HKEY_CURRENT_USER > : HKEY_LOCAL_MACHINE, > keyname, &hTypeKey)) > { > CRYPT_Free(keyname); > - CRYPT_ReturnLastError(NTE_BAD_PROVIDER); > + SetLastError(NTE_BAD_PROVIDER); > + return FALSE; > } > CRYPT_Free(keyname); > - > + > if (dwFlags & CRYPT_DELETE_DEFAULT) > { > - RegDeleteValueA(hTypeKey, "Name"); > + RegDeleteValueW(hTypeKey, nameW); > } > else > { > if (!(keyname = CRYPT_GetProvKeyName(pszProvName))) > { > RegCloseKey(hTypeKey); > - CRYPT_ReturnLastError(ERROR_NOT_ENOUGH_MEMORY); > + SetLastError(ERROR_NOT_ENOUGH_MEMORY); > + return FALSE; > } > - if (RegOpenKeyA((dwFlags & CRYPT_USER_DEFAULT) ? > HKEY_CURRENT_USER : HKEY_LOCAL_MACHINE, > + if (RegOpenKeyW((dwFlags & CRYPT_USER_DEFAULT) ? > HKEY_CURRENT_USER : HKEY_LOCAL_MACHINE, > keyname, &hProvKey)) > { > CRYPT_Free(keyname); > RegCloseKey(hTypeKey); > - CRYPT_ReturnLastError(NTE_BAD_PROVIDER); > + SetLastError(NTE_BAD_PROVIDER); > + return FALSE; > } > CRYPT_Free(keyname); > - > - if (RegSetValueExA(hTypeKey, "Name", 0, REG_SZ, > (LPBYTE)pszProvName, strlen(pszProvName) + 1)) > + > + if (RegSetValueExW(hTypeKey, nameW, 0, REG_SZ, (const BYTE > *)pszProvName, > + (wcslen(pszProvName) + 1)*sizeof(WCHAR))) > { > RegCloseKey(hTypeKey); > RegCloseKey(hProvKey); > return FALSE; > } > - > + > RegCloseKey(hProvKey); > } > RegCloseKey(hTypeKey); > @@ -1800,20 +1802,20 @@ > } > > > /****************************************************************************** > - * CryptSetProviderExW (ADVAPI32.@) > - * > - * See CryptSetProviderExA > - */ > -BOOL WINAPI CryptSetProviderExW (LPCWSTR pszProvName, DWORD dwProvType, > DWORD *pdwReserved, DWORD dwFlags) > + * CryptSetProviderExA (ADVAPI32.@) > + * > + * See CryptSetProviderExW. > + */ > +BOOL WINAPI CryptSetProviderExA (LPCSTR pszProvName, DWORD dwProvType, > DWORD *pdwReserved, DWORD dwFlags) > { > BOOL ret = FALSE; > - PSTR str = NULL; > - > - DPRINT("(%S, %ld, %p, %08ld)\n", pszProvName, dwProvType, > pdwReserved, dwFlags); > - > - if (CRYPT_UnicodeToANSI(pszProvName, &str, -1)) > - { > - ret = CryptSetProviderExA(str, dwProvType, pdwReserved, > dwFlags); > + PWSTR str = NULL; > + > + DPRINT("(%s, %d, %p, %08x)\n", pszProvName, dwProvType, > pdwReserved, dwFlags); > + > + if (CRYPT_ANSIToUnicode(pszProvName, &str, -1)) > + { > + ret = CryptSetProviderExW(str, dwProvType, pdwReserved, > dwFlags); > CRYPT_Free(str); > } > return ret; > > Modified: trunk/reactos/dll/win32/advapi32/crypt/crypt.h > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/advapi32/crypt/c… > > ============================================================================== > --- trunk/reactos/dll/win32/advapi32/crypt/crypt.h (original) > +++ trunk/reactos/dll/win32/advapi32/crypt/crypt.h Thu Nov 15 17:08:18 > 2007 > @@ -15,7 +15,7 @@ > * > * You should have received a copy of the GNU Lesser General Public > * License along with this library; if not, write to the Free Software > - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 > USA > + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, > USA > */ > > #ifndef __WINE_CRYPT_H > @@ -56,25 +56,28 @@ > BOOL (WINAPI *pCPVerifySignature)(HCRYPTPROV hProv, HCRYPTHASH > hHash, CONST BYTE *pbSignature, DWORD dwSigLen, HCRYPTKEY hPubKey, LPCWSTR > sDescription, DWORD dwFlags); > } PROVFUNCS, *PPROVFUNCS; > > +#define MAGIC_CRYPTPROV 0xA39E741F > + > typedef struct tagCRYPTPROV > { > + DWORD dwMagic; > UINT refcount; > HMODULE hModule; > PPROVFUNCS pFuncs; > - HCRYPTPROV hPrivate; /*CSP's handle - Should not be given to > application under any circumstances!*/ > + HCRYPTPROV hPrivate; /*CSP's handle - Should not be given to > application under any circumstances!*/ > PVTableProvStruc pVTable; > } CRYPTPROV, *PCRYPTPROV; > > typedef struct tagCRYPTKEY > { > PCRYPTPROV pProvider; > - HCRYPTKEY hPrivate; /*CSP's handle - Should not be given to > application under any circumstances!*/ > + HCRYPTKEY hPrivate; /*CSP's handle - Should not be given to > application under any circumstances!*/ > } CRYPTKEY, *PCRYPTKEY; > > typedef struct tagCRYPTHASH > { > PCRYPTPROV pProvider; > - HCRYPTHASH hPrivate; /*CSP's handle - Should not be given to > application under any circumstances!*/ > + HCRYPTHASH hPrivate; /*CSP's handle - Should not be given to > application under any circumstances!*/ > } CRYPTHASH, *PCRYPTHASH; > > #define MAXPROVTYPES 999 > @@ -82,7 +85,17 @@ > extern unsigned char *CRYPT_DESkey8to7( unsigned char *dst, const > unsigned char *key ); > extern unsigned char *CRYPT_DEShash( unsigned char *dst, const unsigned > char *key, > const unsigned char *src ); > +extern unsigned char *CRYPT_DESunhash( unsigned char *dst, const unsigned > char *key, > + const unsigned char *src ); > > extern VOID byteReverse(unsigned char *buf, unsigned longs); > > +struct ustring { > + DWORD Length; > + DWORD MaximumLength; > + unsigned char *Buffer; > +}; > + > +NTSTATUS WINAPI SystemFunction032(struct ustring *data, struct ustring > *key); > + > #endif /* __WINE_CRYPT_H_ */ > > > -- Best regards, Alex Ionescu

3 2

High-side Redzone Overwritten
by James Tabor 15 Nov '07

15 Nov '07

Hi, This does happen often with Qemu Linux and Windows. Very intermittent, one out of 50. Rev is at 30454. (ntoskrnl/kd/kdio.c:191) ----------------------------------------------------- (ntoskrnl/kd/kdio.c:192) ReactOS 0.4-SVN (Build 20071115-rUNKNOWN) (ntoskrnl/kd/kdio.c:193) Command Line: NOGUIBOOT DEBUGPORT=COM1 NOGUIBOOT DEBUGPORT=COM1 (ntoskrnl/kd/kdio.c:194) ARC Paths: multi(0)disk(0)cdrom(224) \ multi(0)disk(0)cdrom(224) \reactos\ (ntoskrnl/mm/mminit.c:266) Base Length Type (ntoskrnl/mm/mminit.c:272) 000000A0 00000060 FirmwarePermanent (ntoskrnl/mm/mminit.c:272) 00000800 0000028E SystemCode (ntoskrnl/mm/mminit.c:272) 00000A8E 0000000E BootDriver (ntoskrnl/mm/mminit.c:272) 00000A9C 0000001A HalCode (ntoskrnl/mm/mminit.c:272) 00000AB6 00000009 BootDriver (ntoskrnl/mm/mminit.c:272) 00000ABF 00000003 RegistryData (ntoskrnl/mm/mminit.c:272) 00000AC2 00000011 NlsData (ntoskrnl/mm/mminit.c:272) 00000AD3 00000011 NlsData (ntoskrnl/mm/mminit.c:272) 00000AE4 00000002 NlsData (ntoskrnl/mm/mminit.c:272) 00000AE6 0000002A BootDriver (ntoskrnl/mm/mminit.c:272) 00000B10 00000015 BootDriver (ntoskrnl/mm/mminit.c:272) 00000B25 00000017 BootDriver (ntoskrnl/mm/mminit.c:272) 00000B3C 0000000D BootDriver (ntoskrnl/mm/mminit.c:272) 00000B49 00000011 BootDriver (ntoskrnl/mm/mminit.c:272) 00000B5A 00000019 BootDriver (ntoskrnl/mm/mminit.c:272) 00000B73 00000012 BootDriver (ntoskrnl/mm/mminit.c:272) 00000B85 00000011 BootDriver (ntoskrnl/mm/mminit.c:272) 00000B96 00000013 BootDriver (ntoskrnl/mm/mminit.c:272) 00000BA9 00000013 BootDriver (ntoskrnl/mm/mminit.c:272) 00000BBC 0000000D BootDriver (ntoskrnl/mm/mminit.c:272) 00000BC9 00000009 BootDriver (ntoskrnl/mm/mminit.c:272) 00000BD2 0000042E Free (ntoskrnl/mm/mminit.c:272) 00000FC0 FFFFF840 SpecialMemory (ntoskrnl/mm/mminit.c:276) Total: 000000A0 (0 MB) Used memory 131008Kb (ntoskrnl/ke/i386/kiinit.c:47) Large Page support detected but not yet taken advantage of! (drivers/storage/scsiport/scsiport.c:1101) SpiCreatePortConfig() failed with Status 0xC00000C0 (drivers/storage/scsiport/scsiport.c:1101) SpiCreatePortConfig() failed with Status 0xC00000C0 WARNING: IoReportResourceUsage at ntoskrnl/io/iomgr/iorsrce.c:701 is UNIMPLEMENTED! WARNING: IoReportResourceUsage at ntoskrnl/io/iomgr/iorsrce.c:701 is UNIMPLEMENTED! (drivers/storage/scsiport/scsiport.c:1101) SpiCreatePortConfig() failed with Status 0xC00000C0 (drivers/storage/scsiport/scsiport.c:1101) SpiCreatePortConfig() failed with Status 0xC00000C0 (drivers/storage/scsiport/scsiport.c:1101) SpiCreatePortConfig() failed with Status 0xC00000C0 (ntoskrnl/io/iomgr/driver.c:1283) '\Driver\BUSLOGIC' initialization failed, status (0xc00000c0) (drivers/storage/class/disk/disk.c:1161) IoReadPartitionTable() status: 0x00000000 (ntoskrnl/io/iomgr/driver.c:1283) '\Driver\FLOPPY' initialization failed, status (0xc000000e) (ntoskrnl/io/iomgr/file.c:414) Using IopParseDevice() hack (ntoskrnl/io/iomgr/file.c:414) Using IopParseDevice() hack (ntoskrnl/io/iomgr/file.c:414) Using IopParseDevice() hack (ntoskrnl/io/iomgr/file.c:414) Using IopParseDevice() hack (ntoskrnl/io/iomgr/file.c:414) Using IopParseDevice() hack NPPOL: High-side redzone overwritten, Block 81281b98, Size 64, Tag 4552414d(ERAM), Caller 80854458 KeBugCheck at ntoskrnl/mm/npool.c:1514 *** Fatal System Error: 0x00000000 (0x00000000,0x00000000,0x00000000,0x00000000) <\SystemRoot\System32\NTOSKRNL.EXE: 2ae0> ke/bug.c:1359 (KeBugCheck@4) <\SystemRoot\System32\NTOSKRNL.EXE: 56c6c> mm/npool.c:1514 (check_redzone_header) <\SystemRoot\System32\NTOSKRNL.EXE: 56d6e> mm/npool.c:1579 (ExFreeNonPagedPool@4) <\SystemRoot\System32\NTOSKRNL.EXE: 59c64> mm/pool.c:239 (ExFreePool@4) <\SystemRoot\System32\NTOSKRNL.EXE: 59ca2> mm/pool.c:249 (ExFreePoolWithTag@8) <\SystemRoot\System32\NTOSKRNL.EXE: 54803> mm/marea.c:854 (MmFreeMemoryArea@16) <\SystemRoot\System32\NTOSKRNL.EXE: dde5> cc/view.c:923 (CcRosInternalFreeCacheSegment) <\SystemRoot\System32\NTOSKRNL.EXE: f350> cc/view.c:381 (CcRosTrimCache) <\SystemRoot\System32\NTOSKRNL.EXE: 51c6d> mm/balance.c:147 (MiTrimMemoryConsumer@4) <\SystemRoot\System32\NTOSKRNL.EXE: 51fc0> mm/balance.c:205 (MmRequestPageMemoryConsumer@12) <\SystemRoot\System32\NTOSKRNL.EXE: ef81> cc/view.c:709 (CcRosCreateCacheSegment) <\SystemRoot\System32\NTOSKRNL.EXE: f0dd> cc/view.c:817 (CcRosGetCacheSegment@24) <\SystemRoot\System32\NTOSKRNL.EXE: f114> cc/view.c:860 (CcRosRequestCacheSegment@20) <\SystemRoot\System32\NTOSKRNL.EXE: da90> cc/pin.c:64 (CcMapData@24) <\SystemRoot\System32\drivers\VFATFS.SYS: 5274> fat.c:415 (CountAvailableClusters) <\SystemRoot\System32\drivers\VFATFS.SYS: ba1c> volume.c:119 (VfatQueryVolumeInformation) <\SystemRoot\System32\drivers\VFATFS.SYS: 97ac> misc.c:121 (VfatDispatchRequest) <\SystemRoot\System32\drivers\VFATFS.SYS: 98ab> misc.c:167 (VfatBuildRequest@8) <\SystemRoot\System32\NTOSKRNL.EXE: 44f96> io/iomgr/irp.c:1134 (@IofCallDriver@8) <\SystemRoot\System32\NTOSKRNL.EXE: 3f924> io/iomgr/iofunc.c:137 (IopPerformSynchronousRequest@28) <\SystemRoot\System32\NTOSKRNL.EXE: 41c2d> io/iomgr/iofunc.c:3157 (NtQueryVolumeInformationFile@20) <\SystemRoot\System32\NTOSKRNL.EXE: 893ba> ke/i386/trap.s:244 (KiFastCallEntry) <\SystemRoot\System32\NTOSKRNL.EXE: 84ab9> ex/zw.S:1694 (ZwQueryVolumeInformationFile) <\SystemRoot\System32\NTOSKRNL.EXE: 18208> config/cmsysini.c:101 (CmpInitHiveFromFile@20) <\SystemRoot\System32\NTOSKRNL.EXE: 1b7d2> cm/regfile.c:38 (CmiLoadHive) <\SystemRoot\System32\NTOSKRNL.EXE: 1ba0d> cm/registry.c:408 (CmiInitHives) <\SystemRoot\System32\NTOSKRNL.EXE: 1a6ae> cm/ntfunc.c:637 (NtInitializeRegistry@4) <\SystemRoot\System32\NTOSKRNL.EXE: 893ba> ntoskrnl/ke/i386/trap.s:244 (KiFastCallEntry)

1 0

[ros-diffs] [weiden] 29670: Tweak the ScrollDC implementation a bit so that it produces a better output. The implementation still is completely incorrect as it should call the driver for this operation instead of doing a BitBlt operation...
by Timo Kreuzer 14 Nov '07

14 Nov '07

NtGdiBitBlt calls IntEngBitBlt, wich calls DrvBitBlt if available. There's no DrvScroll function. Timo > Author: weiden > Date: Fri Oct 19 07:23:04 2007 > New Revision: 29670 > > URL: http://svn.reactos.org/svn/reactos?rev=29670&view=rev <http://svn.reactos.org/svn/reactos?rev=29670&view=rev> > Log: > Tweak the ScrollDC implementation a bit so that it produces a better output. The implementation still is completely incorrect as it should call the driver for this operation instead of doing a BitBlt operation... > > Modified: > trunk/reactos/subsystems/win32/win32k/ntuser/painting.c >

3 2

Re: [ros-dev] About UNICODE<->ASCII support.
by carlo.bramix 14 Nov '07

14 Nov '07

Hello, honestly, your enthusiasm seems a bit to exagerated to me! In the specific case, it looks like that all TCHARs in Taskmgr have been converted to WCHAR because the programme receives from the API some informations that are UNICODE only. I can understand and I agree to that, afterall it can be made working with unicows layer, if someone wants (and infact, I did it). Athough you should also admit that two WideCharToMultiByte() calls are not exactly something we can call "drammatic" code, which is automatically excluded by the presence of the magic UNICODE macro. I also agree with the fact that there could be the source code which interacts with UNICODE-only variables and the direct usage of WCHAR instead of TCHAR is very helpful and clean. But how many functions have this behavior (WCHAR-only)? It is not too difficult to count them and in my opinion this does not justify a refresh of sources for making TCHAR>WCHAR, or MessageBox>MessageBoxW... Last but not last... human beings can do errors, their changes may always introduce new errors, so more time for testing, etc... If I can do a suggestion, I would avoid unnecesary changes for this reason too. Afterall the binary code of the executable won't change by a single bit when TCHARs are converted to WCHARs at compile time, if there are not drawbacks like tons of conversions which will make the source code unreadable (it's also important that people understand the code for contribuiting). But if there are just TCHARs/_tcscpy/... I don't understand the reason. Sincerely, Carlo Bramini. ---------- Initial Header ----------- >From : ros-dev-bounces(a)reactos.org To : "ReactOS Development List" ros-dev(a)reactos.org Cc : Date : Mon, 5 Nov 2007 23:55:35 +0000 Subject : Re: [ros-dev] About UNICODE<->ASCII support. > On Nov 5, 2007 5:53 PM, Colin Finck <mail(a)colinfinck.de> wrote: > > Hi Ged, > > > > > Ged wrote: > > > This is the wrong way to be working. We should be dropping > > > support for ASCII where ever possible now. > > > > Is this really the official course now? > > This has pretty much always been the course. > There is absolutely no reason to use TCHAR, it was relevant 10 years > ago, but not any more. > > (btw, in case anyone thinks I'm contradicting myself with mstsc, TCHAR > is only being used as it's currently a port of an ASCII app) > _______________________________________________ > Ros-dev mailing list > Ros-dev(a)reactos.org > http://www.reactos.org/mailman/listinfo/ros-dev >

4 3

Re: [ros-dev] Introduction
by Aleksey Bragin 13 Nov '07

13 Nov '07

Hi, welcome. The best is to join #reactos on freenode and have a live talk with devs. The language used throughout ReactOS is mostly C, with very few exceptions to C++. And if you have WinAPI knowledge, it would be appreciated. WBR, Aleksey Bragin. On Nov 14, 2007, at 12:16 AM, James Holland wrote: > My name is James Holland. I am interested in helping with the > development of ReactOS. I am fairly adept with C++. I also have used > APL (not very well) and MS Visual Basic at past times. I am currently > using Java in my Computer Science class. > > For background, I am a Student at New Mexico Tech. My major is > Electrical Engineering. > > I am open for any suggestions as to what I should do. > > James Holland

1 0

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev