- Ros-dev - ReactOS.org

Re: [ros-dev] [ros-diffs] [gedmurphy] 28324: - fix the code, untested *note, shouldn't this be in rosapps?
by Aleksey Bragin 14 Aug '07

14 Aug '07

This should go into rosapps, unless it's being used during the setup process for example (which it is not). WBR, Aleksey Bragin. On Aug 14, 2007, at 12:52 AM, gedmurphy(a)svn.reactos.org wrote: > Author: gedmurphy > Date: Tue Aug 14 00:52:47 2007 > New Revision: 28324 > > URL: http://svn.reactos.org/svn/reactos?rev=28324&view=rev > Log: > - fix the code, untested > *note, shouldn't this be in rosapps? > > Modified: > trunk/reactos/base/applications/network/dwnl/dwnl.c > trunk/reactos/base/applications/network/dwnl/dwnl.rbuild >

1 0

disussion from forum
by 3th.voice＠googlemail.com 13 Aug '07

13 Aug '07

Hi ReactOS guy's, are you not able to discuss a topic in your forum or why did you delete my post in http://www.reactos.org/forum/viewtopic.php?t=4307 ? Here is it again: [quote="jimtabor"] The irc meetings, there are two I think. It was voting on how to do the audit. Later if I remember right, we started movie review and joking around with unrelated issues. [/quote] I'm missing something about the meetings. [url= http://www.reactos.org/archives/public/ros-dev/2006-January/007478.html]Ste…'s mail[/url] starts with: [quote="Steven Edwards"] There has been a lot of talk about possible tainted code in ReactOS and or developers that had access to leaked Microsoft source code. [/quote] and later [quote="Steven Edwards"] We know of four developers who have had access to leaked sources prior to working on ReactOS.. [/quote] Depend on the [url=http://www.reactos.org/en/dev_legalreview.html]ReactOSproject development policy[/url] [quote="ReactOS project development policy"] Developers who have had access to proprietary source code that would have originally fallen under trade secret protection (including, for example, the leaked Microsoft Windows source code) are a special case. The copyright issues are unchanged, as are the patent issues, but any developer who has the code is clearly either under an NDA or else does not have a license to possess the code. In the latter case, there is a clear violation of the relevant trade secrets by the developer. As such, this kind of code is unsuitable even for research and understanding. It is the policy of the Project to not take submissions from developers who have or use any such proprietary code in their development efforts for ReactOS. [/quote] this developers have to be banned from the project. Steven's mail or the developer's voting wasn't so restrictive: [quote="Steven Edwards"] 4) any developer that had access to leaked sources is baned from contributing code to the project for any of the modules that are the same as leaked sources they examined. [/quote] The question is, why are the tainted developers not banned? If only a few of the developers had access to the leaked windows source code, it is not a problem to ban them. I think more than four developers had access to the leaked windows source code. In this case it will never get a vote for banning the tainted developers, because they must ban itself. It exists the 'Open letter to all' from Alex. I've got the original mail with all the names from one of the developers. [quote="Alex's 'Open letter to all'"] /*Steven, Aleksey, Mike and myself had leaked windows code and looked at it. KJK, Eric, Filip, Magnus and Marteen had IDA and used it for reverse engineering. 9 developers, and these are only some cases.*/ Herve too, sometimes used IDA to verify some flags (I once helped him understand a weird DEVICE_EXTENSION structure), and Thomas, although against reverse-engineering, also used IDA to verify some implementations, although he said he never used it to actually reverse-engineer, and I believe him, although, once you have seen the taint, it's hard to really psycologically prove how much you were, or were not influenced by it. /*With more then 2/3rds of the entire developer team having broken the law and/or our IP policy, I continued my work in the same way.*/ [/quote] Now the story make sense. The implementation of ReactOS is based on the leaked windows source code and possible more than the four named developers had or have access to this code. [quote="jimtabor"] As you all can see, things have gone on to this project. Money was the key word here. Wine, Casper, GvG, hbirr etc,,, mass manipulation to gain from other peoples work. [/quote] And now it makes sense why you accuse some of the developers, which had left the project, that they have done something for money... The only developer, which has something to do with money, is Alex. In May he was bought by Microsoft.

1 0

When will ROS 0.3.3 comming out ?
by theUser BL 13 Aug '07

13 Aug '07

Hi! When will ROS 0.3.3 comming out? On July, 21th you anounced 0.3.3 RC1 at http://www.reactos.org/archives/public/ros-dev/2007-July/009571.html You have also changed the front-page, that the actual version is 0.3.3 RC1 and on the downloadside there is now also only 0.3.3 RC1. Will 0.3.3 any time really comming or existing now 0.3.3 RC1 for it instead and the next one will be 0.3.4 ? Btw: On the download-side the links to the CD-Booklets don't exists. It showns now to 0.3.3-RC booklets, but the only one which exists are 0.3.1 booklets. Greatings theuserbl _________________________________________________________________ Sie suchen E-Mails, Dokumente oder Fotos? Die neue MSN Suche Toolbar mit Windows-Desktopsuche liefert in sekundenschnelle Ergebnisse. Jetzt neu! http://desktop.msn.de/ Jetzt gratis downloaden!

2 1

RosBE and autogenerated files
by Sylvain Petreolle 13 Aug '07

13 Aug '07

Hi all, I wonder if the RosBE-Windows must be the one which removes autogenerated files. In this case , we have to : - merge the list into RosBE-Unix - publish updated versions when the list changes. - last but not least, the user must have the svn versions of RosBE to get a completely clean tree. Colin suggested we can put it into the Makefile, which would be simpler and more efficient. Kind regards, Sylvain Petreolle (aka Usurp) --- --- --- --- --- --- --- --- --- --- --- --- --- Run your favorite Windows apps with free ReactOS : http://www.reactos.org Listen to non-DRMised Music: http://www.jamendo.com

1 0

Betov is move againts nasm32
by Magnus Olsen 10 Aug '07

10 Aug '07

Hi is betov are moreon or idot or brian dead person I can not longer keep my feeling in shape thanks to him It seam that betov is out damges every good open source project on the market. Let see now which project he is trying damges 1.ReactOS It is well known he dislike us, and my advice we ignore him it seam he does not known what his is talking about, and it seam in my eyes his claim is not vaild 2. Sano ReactOS borro some code from this project and that code betov trying convice it is illage 3. SDL Almost same code can be found in SDL for same part we talking about, the code are almost same as Sano code. That mean Betov trying destor this project as well 4. Nasm32 what he have gone after NASM 32, now and claim it is illage for they do not ship the source code in the binary. or the licen agreemtn, and some other stuff more we can read about his stupied http://groups.google.com/group/alt.lang.asm/browse_thread/thread/35cd7e11ff… it is not wonder people do not take him serius he is like a big moron and trying sabtages opensource project world wide for people do not support his rosasm project. And I have follow now his writting for few month and more I read, more it seam it is something wrong with his brain. he calling people with bad names and attact people when they ask him simple question, it mean he socal skill is bad or is is brain dead, that is my cludtions after reading his vaurs stuff he writitning on the net. Or even better bethov is getting pay leading sabtages agaist opensource project that is well known, He maybe getting pay from MS/DMCA/NOVELL how knowns, but it seam not in this case it seam he is complete brian dead.

1 0

crash in rbuild creating vcproj
by ich 09 Aug '07

09 Aug '07

Hello list, I'm new here, so at first I'd like to greet everyone ;) second: I had some problems running rbuild on WinXP SP2 self compiled with msvc 8.0 (Express) to produce .vcproj files. I've found the problem in vcprojmaker.cpp and another thing, which prevents me from building rbuild in genguid.cpp and I would like to contribute a patch. Kind regards, Michael Sprauer

1 0

Re: [ros-dev] RosBuild Release Build Problem
by Aleksey Bragin 09 Aug '07

09 Aug '07

Fixed in 28257. WBR, Aleksey Bragin. On Aug 9, 2007, at 9:37 AM, James Tabor wrote: > ./include/internal/kd.h:212:KdpKdbgInit( > > obj-i386/ntoskrnl/kd/kdinit.o: In function `KdInitSystem@8': > /mnt/reactos/fullrel/build/ntoskrnl/kd/kdinit.c:(.data+0x24): > undefined reference to `_KdpKdbgInit@8'

1 0

XP, System Call List, Wrong size?
by James Tabor 09 Aug '07

09 Aug '07

From the SDK! Come on! get upto date! W32KAPI BOOL APIENTRY NtGdiAlphaBlend( __in HDC hdcDst, __in LONG DstX, __in LONG DstY, __in LONG DstCx, __in LONG DstCy, __in HDC hdcSrc, __in LONG SrcX, __in LONG SrcY, __in LONG SrcCx, __in LONG SrcCy, __in BLENDFUNCTION BlendFunction, __in HANDLE hcmXform // I saw a zero here. ); We have this in psdk/ntgdi.h W32KAPI BOOL APIENTRY NtGdiSetIcmMode( IN HDC hdc, IN ULONG nCommand, // see below,,,, I saw 1 -> 4 here. IN ULONG ulMode ); /* NtGdiSetIcmMode */ #define ICM_SET_MODE 1 #define ICM_SET_CALIBRATE_MODE 2 #define ICM_SET_COLOR_MODE 3 #define ICM_CHECK_COLOR_MODE 4 Using a good hook and compare eax to the list will set you free. James

1 0

RosBuild Release Build Problem
by James Tabor 09 Aug '07

09 Aug '07

./include/internal/kd.h:212:KdpKdbgInit( obj-i386/ntoskrnl/kd/kdinit.o: In function `KdInitSystem@8': /mnt/reactos/fullrel/build/ntoskrnl/kd/kdinit.c:(.data+0x24): undefined reference to `_KdpKdbgInit@8' ntoskrnl/include/internal/ntoskrnl.h: #include "ldr.h" #ifndef _WINKD_ #include "kd.h" #else #include "kd64.h" #endif #include "fsrtl.h" ntoskrnl.rbuild : snip.... <define name="_IN_KERNEL_" /> <if property="_WINKD_" value="1"> <define name="_WINKD_" /> snip.... <file>pnproot.c</file> </directory> </directory> <if property="_WINKD_" value="0"> <directory name="kdbg"> <if property="ARCH" value="i386"> snip.... <file>kdmain.c</file> </directory> </if> <if property="_WINKD_" value ="1"> <directory name="kd64"> <file>kdapi.c</file> snip.... Does this help in finding the problem? James

1 0

rev 28153 (obhandle.c)
by Timo Kreuzer 08 Aug '07

08 Aug '07

rev 28153 (obhandle.c) breaks bootcd with KDBG = 1 "Assertion 'HandleTable->HandleCount == 0' failed at ntoskrnl\ob\obhandle.c line 2034"

1 0

r28205 : Empty ntoskrnl/ke/i386/init.S in trunk
by Sylvain Petreolle 07 Aug '07

07 Aug '07

After r28205, ntoskrnl/ke/i386/init.S has no more contents and is removed from build. Remove it from trunk too. Kind regards, Sylvain Petreolle (aka Usurp) --- --- --- --- --- --- --- --- --- --- --- --- --- Run your favorite Windows apps with free ReactOS : http://www.reactos.org Listen to non-DRMised Music: http://www.jamendo.com

1 0

Re: [ros-dev] CRT source code issue
by Aleksey Bragin 06 Aug '07

06 Aug '07

Yes, the whole issue is at pushing operands to stack, performing well- documented assembly instructions to perform the asked action (div, mul, shl, shr, etc), and handling some special, though obvious, cases (like if you do a shl of some longlong number by more than 64 bits, you always end up with 0, there is no need to call math instructions in order to compute this). I will let you know results when I speak with SDL. WBR, Aleksey Bragin. On Aug 4, 2007, at 8:52 PM, Daniel Hazelton wrote: > On Saturday 04 August 2007 12:28:09 Aleksey Bragin wrote: > > I can't see where that file has anything to do with the functions > (e.g: > sqrt()/alldiv()) that Betov claims are duplicated. (I've gone > through that > file and can't find any single place where it does any more math than > controlled bit-shifts. No advanced math or anything.) > > While there might be similar code, for, say, memory barriers, that > codes > construction would be dictated by the specification of the target > machine > (and, to some extent, the OS). If the code for sqrt/alldiv is the same > between SDL/ROS I don't see a problem - they are both GNU projects > and "cross > pollination" like that is legal. > > Whats more is that, while assembly is abstract enough to let some > things be > done in more than one way, most of the more complex functionality - > like math > algorithms - are so limited in the possibilities of variation that > I can > easily see two unconnected people arriving at the exact same > solution. QED: > Even if the code appears identical (except for things like variable > names, > et. al) there is a compelling reason for it and it does not mean > the code has > been copied in any way, shape or form. (And if you look at the ROS > commit > history I'm sure the code in question existed before MS released > the SSCLI2.0 > source. Which means that the code can't be an "illegal use of MS > property" - > it was around before said property was available). > > ...Okay, enough of this outsider sticking his neck out. I've said > enough and > it's time to disappear and wait for a really usable version of ROS > to hit. > (though I have compared it to XP under Qemu and ROS rocks!) > > DRH

1 0

Re: [ros-dev] CRT source code issue
by Aleksey Bragin 04 Aug '07

04 Aug '07

Just so people don't build up rumours, this code is located in SSCLI 2.0, in the file clr/src/vm/i386/jithelp.asm . Function names are different, however assembly code is similar. License issues are not fully cleared up, so opinions from people having knowledge in this area are welcome. WBR, Aleksey Bragin. On Aug 4, 2007, at 7:52 PM, Daniel Hazelton wrote: > On Saturday 04 August 2007 04:32:32 Mike Swanson wrote: >> On Friday 03 August 2007 16:28:21 Daniel Hazelton wrote: >>> unless you hold full copyright to the software (ie: you are the >>> one who >>> has released it under the GPL) then there is no way you can >>> distribute it >>> for commercial purposes. (You can make money to cover >>> distribution costs >>> and/or make money from support but not off the software itself.) >>

2 1

CRT source code issue
by Aleksey Bragin 04 Aug '07

04 Aug '07

Hi, Recently Betov made some accusations regarding possible usage of MS's copyrighted code in ReactOS's CRT library (example lib/sdk/libcntpr/ math/i386/sqrt_asm.s, alldiv_asm.s, and other files). Here is my official statement in regarding to this false accusation: This source code originally was imported into ReactOS from SanOS project, where it was said as having GPL license (all original copyrights are kept). After a lot of complains from Betov (aimed at getting attention to his own project, not at improving ReactOS), developers thought it worths looking into the issue deeper. I performed some investigation, and found that SDL project (www.libsdl.org) has the same code in trunk and in v1.2 branch (http://www.libsdl.org/cgi/viewvc.cgi/trunk/SDL/src/stdlib/ SDL_stdlib.c?view=markup). Everyone can compare asm source code with respective functions found in MSVC's CRT source code. It matches up to label names, however numbers have been converted from dec to hex representation. The code in SDL project is marked as "GPL" and author is stated as "Sam Lantinga". It may look like a serious problem, but in reality, the source code of these functions is released by Microsoft in SSCLI 2.0, with a license which allows GPLing of the source code, with one restriction: "You may not use or distribute this Software and any derivative works in any form for commercial purposes.". SSCLI 2.0 can be freely downloaded by everyone, license is also certainly available to read. I'm going to communicate with SDL about this issue, but since ReactOS is not used commercially, it's not a problem for ReactOS now. We are ready to collaborate with SDL on removing this issue, if it's considered a real problem. With the best regards, Aleksey Bragin.

4 4

Re: [ros-dev] ERROR when compiling ROS
by carlo.bramix 03 Aug '07

03 Aug '07

I was finally able to compile and build the boot cd, but setup hangs when doing "Importing hivesys.inf..." But this is another trouble, different from previous one. And I did a complete clean before compiling. Sincerely, Carlo Bramini ---------- Initial Header ----------- >From : ros-dev-bounces(a)reactos.org To : "ros-dev" ros-dev(a)reactos.org Cc : Date : Fri, 3 Aug 2007 18:21:36 +0200 Subject : Re: [ros-dev] ERROR when compiling ROS > It seems that the very last change fixed my problem. > > C:\RosBE>svn up > U tools\rbuild\wineresource.cpp > Aggiornato alla revisione 28138. > > Sincerely, > > Carlo Bramini > > ---------- Initial Header ----------- > > >From : ros-dev-bounces(a)reactos.org > To : "ReactOS Development List" ros-dev(a)reactos.org > Cc : > Date : Fri, 3 Aug 2007 17:55:10 +0200 > Subject : Re: [ros-dev] ERROR when compiling ROS > > > Hi, > > > > There were some changes in the build system today. > > Please first try to update to *latest* trunk and then do a complete clean > > build. > > > > If this doesn't help, you can either try to delete all autogenerated files > > yourself, which were not deleted by the "clean" script or get a complete new > > checkout. > > > > I can build recent trunk (r28138) and our BuildBot has no problems as well > > now. > > > > Regards, > > > > Colin > > > > > > > -----Original Message----- > > > From: ros-dev-bounces(a)reactos.org > > > [mailto:ros-dev-bounces@reactos.org] On Behalf Of carlo.bramix > > > Sent: Friday, August 03, 2007 5:32 PM > > > To: ros-dev > > > Subject: [ros-dev] ERROR when compiling ROS > > > > > > Hello, > > > Today I wasn't able to compile ROS. > > > I got this error: > > > > > > [RBUILD] makefile.auto > > > Processing failed: No such file or directory > > > > > > Sincerely, > > > > > > Carlo Bramini > > > > > > > > > > > > ------------------------------------------------------ > > > Scegli infostrada: ADSL gratis per tutta l'estate e telefoni > > > senza canone Telecom > > > http://click.libero.it/infostrada > > > > > > > > > _______________________________________________ > > > Ros-dev mailing list > > > Ros-dev(a)reactos.org > > > http://www.reactos.org/mailman/listinfo/ros-dev > > > > _______________________________________________ > > Ros-dev mailing list > > Ros-dev(a)reactos.org > > http://www.reactos.org/mailman/listinfo/ros-dev > > > > > ------------------------------------------------------ > Scegli infostrada: ADSL gratis per tutta lestate e telefoni senza canone Telecom > http://click.libero.it/infostrada > > > _______________________________________________ > Ros-dev mailing list > Ros-dev(a)reactos.org > http://www.reactos.org/mailman/listinfo/ros-dev > ------------------------------------------------------ Scegli infostrada: ADSL gratis per tutta lestate e telefoni senza canone Telecom http://click.libero.it/infostrada

2 1

Re: [ros-dev] ERROR when compiling ROS
by carlo.bramix 03 Aug '07

03 Aug '07

It seems that the very last change fixed my problem. C:\RosBE>svn up U tools\rbuild\wineresource.cpp Aggiornato alla revisione 28138. Sincerely, Carlo Bramini ---------- Initial Header ----------- >From : ros-dev-bounces(a)reactos.org To : "ReactOS Development List" ros-dev(a)reactos.org Cc : Date : Fri, 3 Aug 2007 17:55:10 +0200 Subject : Re: [ros-dev] ERROR when compiling ROS > Hi, > > There were some changes in the build system today. > Please first try to update to *latest* trunk and then do a complete clean > build. > > If this doesn't help, you can either try to delete all autogenerated files > yourself, which were not deleted by the "clean" script or get a complete new > checkout. > > I can build recent trunk (r28138) and our BuildBot has no problems as well > now. > > Regards, > > Colin > > > > -----Original Message----- > > From: ros-dev-bounces(a)reactos.org > > [mailto:ros-dev-bounces@reactos.org] On Behalf Of carlo.bramix > > Sent: Friday, August 03, 2007 5:32 PM > > To: ros-dev > > Subject: [ros-dev] ERROR when compiling ROS > > > > Hello, > > Today I wasn't able to compile ROS. > > I got this error: > > > > [RBUILD] makefile.auto > > Processing failed: No such file or directory > > > > Sincerely, > > > > Carlo Bramini > > > > > > > > ------------------------------------------------------ > > Scegli infostrada: ADSL gratis per tutta l'estate e telefoni > > senza canone Telecom > > http://click.libero.it/infostrada > > > > > > _______________________________________________ > > Ros-dev mailing list > > Ros-dev(a)reactos.org > > http://www.reactos.org/mailman/listinfo/ros-dev > > _______________________________________________ > Ros-dev mailing list > Ros-dev(a)reactos.org > http://www.reactos.org/mailman/listinfo/ros-dev > ------------------------------------------------------ Scegli infostrada: ADSL gratis per tutta lestate e telefoni senza canone Telecom http://click.libero.it/infostrada

1 0

ERROR when compiling ROS
by carlo.bramix 03 Aug '07

03 Aug '07

Hello, Today I wasn't able to compile ROS. I got this error: [RBUILD] makefile.auto Processing failed: No such file or directory Sincerely, Carlo Bramini ------------------------------------------------------ Scegli infostrada: ADSL gratis per tutta lestate e telefoni senza canone Telecom http://click.libero.it/infostrada

2 1

Bug #2217 fixed
by carlo.bramix 03 Aug '07

03 Aug '07

The patch (attached into that bug) fixes the signaled defect. Sincerely, Carlo Bramini. ------------------------------------------------------ Scegli infostrada: ADSL gratis per tutta lestate e telefoni senza canone Telecom http://click.libero.it/infostrada

1 0

Fwd: Re: setup's fat32 format
by Paul Dufresne 02 Aug '07

02 Aug '07

On Tue, 31 Jul 2007 05:47:22 +0100 (BST), "CK Raju" <ckraju68(a)yahoo.co.in> said: > But is the process of recognising other partitions > stable ? Can ReactOS be installed in extended > partitions ? Does it recognise extended partitions now > ? These are the questions that will be eliminated with > adoption of a cross-installer. It did break the partition table I had the 2 times I have tried on real hardware. The two times, I had Ubuntu installed in logical partitions. Each times, it see my 10Gb as 4Gb, and give a warning it does not understand correctly my partition table. First time, it did seems to see some unused space (there was probably none in reality) and I let it installed there, stopping just before installing the boot loader (I wanted to use grub to start it). But when I tried to reboot, computer was unable to boot, not even go to the BIOS. Reinitializing CMOS or reflashing BIOS did not help. Finally discover that unplugging the HD fixed the BIOS. Probably a BIOS bug, expecting a correct MBR and partition table. Next time (about 1 week ago), I had made a primary partition for it, and still have Linux on logical one. But it seems to have break the partition table once again (not sure how I convinced myself of that however, I think because I was not able to search for /boot/grub/menu.lst from grub on hd0). I was given on a link in IRC about an unfinished patch on hyperheterodyne, or superheterodyne... that was about the partition manager. Was 1 or 2 years old however. I read it a bit, patch and code for usetup?, but not good enough yet to really understand. So I consider the installer very dangerous right now. -- http://www.fastmail.fm - Send your email first class

3 3

Re: [ros-dev] [ros-diffs] [greatlrd] 28055: user32 cleanup lite redirect the InvalidateRect@12 to NtUserInvalidateRect@12 in the def file nci tools changes (done of timo and me) frist part moving the w32ksvc.db and sysfuncs.lst where they belong
by Aleksey Bragin 01 Aug '07

01 Aug '07

Let's try to calm down the emotions, otherwise people may be offended :-) I know Jim is the one who, I think, *never* commited a patch that breaks something (testing a patch before commiting for one week - easy), but we have to tolerate that other people (including myself) tend to do mistakes from time to time. WBR, Aleksey Bragin. On Aug 1, 2007, at 11:38 PM, Ged wrote: > James Tabor wrote: >> Man! You are right! The newbies are creating more work for me at >> every >> turn! I wish they would stop committing on crack! >> >> Thank you for the extra work! >> > > That's rather harsh and partonising! > These so called 'newbies' have done a great deal of good work > recently. > > > > _______________________________________________ > Ros-dev mailing list > Ros-dev(a)reactos.org > http://www.reactos.org/mailman/listinfo/ros-dev

3 2

Re: [ros-dev] Vacation
by Aleksey Bragin 01 Aug '07

01 Aug '07

Thanks for all wishes, I really had a nice vacation in Montenegro (I'll maybe post some photos soon). Great work on the reactos tree, ros-diffs sounds very promising. I'm fully back into ReactOS by tomorrow. WBR, Aleksey Bragin. On Jul 24, 2007, at 10:08 PM, Aleksey Bragin wrote: > Hello, > I'll be on vacation, starting from tomorrow (25th of July) and > lasting till 1st of August. > > > > Have fun with development while I'm away! > > WBR, > Aleksey Bragin. > _______________________________________________ > Ros-dev mailing list > Ros-dev(a)reactos.org > http://www.reactos.org/mailman/listinfo/ros-dev

1 0

Re: [ros-dev] [ros-diffs] [greatlrd] 28055: user32 cleanup lite redirect the InvalidateRect@12 to NtUserInvalidateRect@12 in the def file nci tools changes (done of timo and me) frist part moving the w32ksvc.db and sysfuncs.lst where they belong
by Aleksey Bragin 01 Aug '07

01 Aug '07

So, is it reverted? iirc, I even marked those files as "shared with Wine" in the README.WINE file. I did the merging of Wine changes once or twice there, and it's not a big fun to go change-by-change, trace revision when it was changed, look up why and was it a necessary change or not. WBR, Aleksey Bragin. On Aug 1, 2007, at 11:05 AM, Thomas Weidenmueller wrote: > No it's not worth the hazzle because those changes result in *NO* > optimizations anyway. The code that was changed were calls to > InvalidateRect to NtUserInvalidateRect. Since InvalidateRect is > already > forwarded to NtUserInvalidateRect this doesn't really improve > anything, > it's the same overhead. These changes should be reverted, not just > because it makes no sense to optimize these function calls even more > because they're absolutely not time-critical. > > Please revert. > > - Thomas > > Steven Edwards wrote: >> On 7/31/07, greatlrd(a)svn.reactos.org <greatlrd(a)svn.reactos.org> >> wrote: >>> user32 cleanup lite >>> redirect the InvalidateRect@12 to NtUserInvalidateRect@12 in the >>> def file >> >>> Modified: >>> trunk/reactos/dll/win32/user32/controls/button.c >>> trunk/reactos/dll/win32/user32/controls/combo.c >>

1 0

Re: [ros-dev] [ros-diffs] [greatlrd] 28055: user32 cleanup lite redirect the InvalidateRect@12 to NtUserInvalidateRect@12 in the def file nci tools changes (done of timo and me) frist part moving the w32ksvc.db and sysfuncs.lst where they belong
by Steven Edwards 01 Aug '07

01 Aug '07

On 7/31/07, greatlrd(a)svn.reactos.org <greatlrd(a)svn.reactos.org> wrote: > user32 cleanup lite > redirect the InvalidateRect@12 to NtUserInvalidateRect@12 in the def file > Modified: > trunk/reactos/dll/win32/user32/controls/button.c > trunk/reactos/dll/win32/user32/controls/combo.c Is it really worth the merge hassle to change it in these two files? They are almost 100% shared with Wine and I doubt the overhead in calling InvalidateRect vs NtUserInvalidateRect is worth the hassle on whoever the maintainer is going to be.... -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

4 3

[ros-diffs] [tkreuzer] 28069: implement Arc, ArcTo, Chord, calling NtGdiArcInternal
by James Tabor 01 Aug '07

01 Aug '07

Hi, Why did you do it like this? Arc, etc,, has already been writing in painting.c. Thanks, James

1 0

Patch to bug #2517
by carlo.bramix 01 Aug '07

01 Aug '07

Hello. This bug contains an useful patch that removes a large amount of duplicated code from taskmgr. Sincerely, Carlo Bramini ------------------------------------------------------ Scegli infostrada: ADSL gratis per tutta lestate e telefoni senza canone Telecom http://click.libero.it/infostrada

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev