- Ros-dev - ReactOS.org

Re: [ros-dev] Re : ReactOS doesn't compile well
by carlo.bramix 10 Jul '07

10 Jul '07

Hello, Yes, you are right, I just checked regedit and it's bugged again. Sincerely, Carlo Bramini ---------- Initial Header ----------- >From : ros-dev-bounces(a)reactos.org To : "ReactOS Development List" ros-dev(a)reactos.org Cc : Date : Tue, 10 Jul 2007 20:17:20 +0200 Subject : Re: [ros-dev] Re : ReactOS doesn't compile well > Please try regedit, compiled unter Windows RosBE. I have the same > problem that carlo.bramix mentioned: no child windows shown, because of > messed up resources. regedit.exe is also smaller with LANGUAGE > LANG_DUTCH, SUBLANG_NEUTRAL. It seems to be a bug in wrc. > > Colin Finck schrieb: > > Hi, > > > > I just tested building latest trunk under Windows and 32-bit Linux (both > > with RosBE 0.3.6) and both builds resulted in correct ISOs. > > Our BuildBot also has no such problems. > > > > I tested your examples "intl.cpl" and "sysdm.cpl" and both are shown in > > english for me. > > When I switch the locale to any german locale, I get german versions of > > these apps, meaning that the whole localization thing works for me. > > > > Maybe you have to do a clean build. > > > > Best regards, > > > > Colin > > > > > > _______________________________________________ > Ros-dev mailing list > Ros-dev(a)reactos.org > http://www.reactos.org/mailman/listinfo/ros-dev > ------------------------------------------------------ Scegli infostrada: ADSL gratis per tutta lestate e telefoni senza canone Telecom http://click.libero.it/infostrada

1 0

Re: [ros-dev] Re : ReactOS doesn't compile well
by carlo.bramix 10 Jul '07

10 Jul '07

Hello, yep, the errors don't interrupt the compilation of ReactOS. But the resources into those coffs seem corrupted to me. For example, if I open the control panel I will see inl.cpl in german language(!) while all others are in english or if I open the system applet I can see some text without sense. Sincerely, Carlo Bramini ---------- Initial Header ----------- >From : ros-dev-bounces(a)reactos.org To : "ReactOS Development List" ros-dev(a)reactos.org Cc : Date : Tue, 10 Jul 2007 15:07:58 +0000 (GMT) Subject : [ros-dev] Re : ReactOS doesn't compile well > hi, > I got some of them but it didnt bother the build. > > Kind regards, > Sylvain Petreolle (aka Usurp) > --- --- --- --- --- --- --- --- --- --- --- --- --- > Run your favorite Windows apps with free ReactOS : http://www.reactos.org > Listen to non-DRMised Music: http://www.jamendo.com > > > > > ----- Message d'origine ---- > De : carlo.bramix <carlo.bramix(a)libero.it> > À : ros-dev <ros-dev(a)reactos.org> > Envoyé le : Mardi, 10 Juillet 2007, 16h52mn 51s > Objet : Re: [ros-dev] ReactOS doesn't compile well > > > Hello, > while regedit compilation was done successfully, some files aren't still generated correctly: > > [WRC] obj-i386\base\shell\cmd\cmd.coff > [WRC] obj-i386\base\system\expand\expand.coff > [WRC] obj-i386\dll\cpl\intl\intl.coff > [WRC] obj-i386\dll\cpl\intl_new\intl.coff > [WRC] obj-i386\dll\cpl\sysdm\sysdm.coff > [WRC] obj-i386\dll\win32\comdlg32\rsrc.coff > [WRC] obj-i386\dll\win32\hhctrl.ocx\hhctrl.coff > [WRC] obj-i386\dll\win32\shdocvw\shdocvw.coff > > <built-in>:0: fatal error: when writing output to : Invalid argument > compilation terminated. > > I hope it could be fixed. > > Sincerely, > > Carlo Bramini > > ---------- Initial Header ----------- > > >From : ros-dev-bounces(a)reactos.org > To : "ros-dev" ros-dev(a)reactos.org > Cc : > Date : Mon, 9 Jul 2007 18:34:34 +0200 > Subject : Re: [ros-dev] ReactOS doesn't compile well > > > Hello, > > problem with compilation of regedit seems to be gone with revision 27541. > > > > Sincerely, > > > > Carlo Bramini > > > > ---------- Initial Header ----------- > > > > >From : ros-dev-bounces(a)reactos.org > > To : "ros-dev" ros-dev(a)reactos.org > > Cc : > > Date : Mon, 9 Jul 2007 11:24:29 +0200 > > Subject : [ros-dev] ReactOS doesn't compile well > > > > > Hello, > > > it looks like something wrong happens when I compile ReactOS. > > > I also did a complete clean and a make for a total rebuild, but I'm still having problems. > > > > > > I saw the first problem when I tried to test Regedit after committed changes. > > > The tree window and the listview window aren't visible (or they aren't created successfully, I didn't check this yet). > > > I tested that executable into WinXP and those child windows aren't visible too. > > > So I did these steps: > > > 1) I compiled Regedit with Visual C and I verified that it worked fine. > > > 2) I grabbed regedit.res and I manually generated regedit.coff with "windres -i regedit.res -o regedit.coff". > > > 3) I launched "make" again and it regenerated regedit.exe. > > > This last regedit.exe works fine and it has all child window controls visible. It's really a problem when generating te coff file from resources. > > > > > > I also saw a possible second problem when compiling. > > > Some compilation of '.coff' files failed. > > > On the console I read some messages like this one: > > > > > > [WRC] obj-i386\dll\win32\comdlg32\rsrc.coff > > > <built-in>:0: fatal error: when writing output to : Invalid argument > > > compilation terminated. > > > > > > Actually I'm using RosBE 0.3.6 but I never got such problems with previouses svn versions of the sources. > > > > > > Sincerely, > > > > > > Carlo Bramini > > > > > > > > > > > > ------------------------------------------------------ > > > Leggi GRATIS le tue mail con il telefonino i-modeTM di Wind > > > http://i-mode.wind.it/ > > > > > > > > > _______________________________________________ > > > Ros-dev mailing list > > > Ros-dev(a)reactos.org > > > http://www.reactos.org/mailman/listinfo/ros-dev > > > > > > > > > ------------------------------------------------------ > > Leggi GRATIS le tue mail con il telefonino i-modeTM di Wind > > http://i-mode.wind.it/ > > > > > > _______________________________________________ > > Ros-dev mailing list > > Ros-dev(a)reactos.org > > http://www.reactos.org/mailman/listinfo/ros-dev > > > > > ------------------------------------------------------ > Scegli infostrada: ADSL gratis per tutta l´estate e telefoni senza canone Telecom > http://click.libero.it/infostrada > > > _______________________________________________ > Ros-dev mailing list > Ros-dev(a)reactos.org > http://www.reactos.org/mailman/listinfo/ros-dev > > _______________________________________________ > Ros-dev mailing list > Ros-dev(a)reactos.org > http://www.reactos.org/mailman/listinfo/ros-dev > ------------------------------------------------------ Scegli infostrada: ADSL gratis per tutta lestate e telefoni senza canone Telecom http://click.libero.it/infostrada

3 2

Re : ReactOS doesn't compile well
by Sylvain Petreolle 10 Jul '07

10 Jul '07

hi, I got some of them but it didnt bother the build. Kind regards, Sylvain Petreolle (aka Usurp) --- --- --- --- --- --- --- --- --- --- --- --- --- Run your favorite Windows apps with free ReactOS : http://www.reactos.org Listen to non-DRMised Music: http://www.jamendo.com ----- Message d'origine ---- De : carlo.bramix <carlo.bramix(a)libero.it> À : ros-dev <ros-dev(a)reactos.org> Envoyé le : Mardi, 10 Juillet 2007, 16h52mn 51s Objet : Re: [ros-dev] ReactOS doesn't compile well Hello, while regedit compilation was done successfully, some files aren't still generated correctly: [WRC] obj-i386\base\shell\cmd\cmd.coff [WRC] obj-i386\base\system\expand\expand.coff [WRC] obj-i386\dll\cpl\intl\intl.coff [WRC] obj-i386\dll\cpl\intl_new\intl.coff [WRC] obj-i386\dll\cpl\sysdm\sysdm.coff [WRC] obj-i386\dll\win32\comdlg32\rsrc.coff [WRC] obj-i386\dll\win32\hhctrl.ocx\hhctrl.coff [WRC] obj-i386\dll\win32\shdocvw\shdocvw.coff <built-in>:0: fatal error: when writing output to : Invalid argument compilation terminated. I hope it could be fixed. Sincerely, Carlo Bramini ---------- Initial Header ----------- >From : ros-dev-bounces(a)reactos.org To : "ros-dev" ros-dev(a)reactos.org Cc : Date : Mon, 9 Jul 2007 18:34:34 +0200 Subject : Re: [ros-dev] ReactOS doesn't compile well > Hello, > problem with compilation of regedit seems to be gone with revision 27541. > > Sincerely, > > Carlo Bramini > > ---------- Initial Header ----------- > > >From : ros-dev-bounces(a)reactos.org > To : "ros-dev" ros-dev(a)reactos.org > Cc : > Date : Mon, 9 Jul 2007 11:24:29 +0200 > Subject : [ros-dev] ReactOS doesn't compile well > > > Hello, > > it looks like something wrong happens when I compile ReactOS. > > I also did a complete clean and a make for a total rebuild, but I'm still having problems. > > > > I saw the first problem when I tried to test Regedit after committed changes. > > The tree window and the listview window aren't visible (or they aren't created successfully, I didn't check this yet). > > I tested that executable into WinXP and those child windows aren't visible too. > > So I did these steps: > > 1) I compiled Regedit with Visual C and I verified that it worked fine. > > 2) I grabbed regedit.res and I manually generated regedit.coff with "windres -i regedit.res -o regedit.coff". > > 3) I launched "make" again and it regenerated regedit.exe. > > This last regedit.exe works fine and it has all child window controls visible. It's really a problem when generating te coff file from resources. > > > > I also saw a possible second problem when compiling. > > Some compilation of '.coff' files failed. > > On the console I read some messages like this one: > > > > [WRC] obj-i386\dll\win32\comdlg32\rsrc.coff > > <built-in>:0: fatal error: when writing output to : Invalid argument > > compilation terminated. > > > > Actually I'm using RosBE 0.3.6 but I never got such problems with previouses svn versions of the sources. > > > > Sincerely, > > > > Carlo Bramini > > > > > > > > ------------------------------------------------------ > > Leggi GRATIS le tue mail con il telefonino i-mode™ di Wind > > http://i-mode.wind.it/ > > > > > > _______________________________________________ > > Ros-dev mailing list > > Ros-dev(a)reactos.org > > http://www.reactos.org/mailman/listinfo/ros-dev > > > > > ------------------------------------------------------ > Leggi GRATIS le tue mail con il telefonino i-mode™ di Wind > http://i-mode.wind.it/ > > > _______________________________________________ > Ros-dev mailing list > Ros-dev(a)reactos.org > http://www.reactos.org/mailman/listinfo/ros-dev > ------------------------------------------------------ Scegli infostrada: ADSL gratis per tutta l’estate e telefoni senza canone Telecom http://click.libero.it/infostrada _______________________________________________ Ros-dev mailing list Ros-dev(a)reactos.org http://www.reactos.org/mailman/listinfo/ros-dev

1 0

Re: [ros-dev] ReactOS doesn't compile well
by carlo.bramix 10 Jul '07

10 Jul '07

Hello, while regedit compilation was done successfully, some files aren't still generated correctly: [WRC] obj-i386\base\shell\cmd\cmd.coff [WRC] obj-i386\base\system\expand\expand.coff [WRC] obj-i386\dll\cpl\intl\intl.coff [WRC] obj-i386\dll\cpl\intl_new\intl.coff [WRC] obj-i386\dll\cpl\sysdm\sysdm.coff [WRC] obj-i386\dll\win32\comdlg32\rsrc.coff [WRC] obj-i386\dll\win32\hhctrl.ocx\hhctrl.coff [WRC] obj-i386\dll\win32\shdocvw\shdocvw.coff <built-in>:0: fatal error: when writing output to : Invalid argument compilation terminated. I hope it could be fixed. Sincerely, Carlo Bramini ---------- Initial Header ----------- >From : ros-dev-bounces(a)reactos.org To : "ros-dev" ros-dev(a)reactos.org Cc : Date : Mon, 9 Jul 2007 18:34:34 +0200 Subject : Re: [ros-dev] ReactOS doesn't compile well > Hello, > problem with compilation of regedit seems to be gone with revision 27541. > > Sincerely, > > Carlo Bramini > > ---------- Initial Header ----------- > > >From : ros-dev-bounces(a)reactos.org > To : "ros-dev" ros-dev(a)reactos.org > Cc : > Date : Mon, 9 Jul 2007 11:24:29 +0200 > Subject : [ros-dev] ReactOS doesn't compile well > > > Hello, > > it looks like something wrong happens when I compile ReactOS. > > I also did a complete clean and a make for a total rebuild, but I'm still having problems. > > > > I saw the first problem when I tried to test Regedit after committed changes. > > The tree window and the listview window aren't visible (or they aren't created successfully, I didn't check this yet). > > I tested that executable into WinXP and those child windows aren't visible too. > > So I did these steps: > > 1) I compiled Regedit with Visual C and I verified that it worked fine. > > 2) I grabbed regedit.res and I manually generated regedit.coff with "windres -i regedit.res -o regedit.coff". > > 3) I launched "make" again and it regenerated regedit.exe. > > This last regedit.exe works fine and it has all child window controls visible. It's really a problem when generating te coff file from resources. > > > > I also saw a possible second problem when compiling. > > Some compilation of '.coff' files failed. > > On the console I read some messages like this one: > > > > [WRC] obj-i386\dll\win32\comdlg32\rsrc.coff > > <built-in>:0: fatal error: when writing output to : Invalid argument > > compilation terminated. > > > > Actually I'm using RosBE 0.3.6 but I never got such problems with previouses svn versions of the sources. > > > > Sincerely, > > > > Carlo Bramini > > > > > > > > ------------------------------------------------------ > > Leggi GRATIS le tue mail con il telefonino i-mode di Wind > > http://i-mode.wind.it/ > > > > > > _______________________________________________ > > Ros-dev mailing list > > Ros-dev(a)reactos.org > > http://www.reactos.org/mailman/listinfo/ros-dev > > > > > ------------------------------------------------------ > Leggi GRATIS le tue mail con il telefonino i-mode di Wind > http://i-mode.wind.it/ > > > _______________________________________________ > Ros-dev mailing list > Ros-dev(a)reactos.org > http://www.reactos.org/mailman/listinfo/ros-dev > ------------------------------------------------------ Scegli infostrada: ADSL gratis per tutta lestate e telefoni senza canone Telecom http://click.libero.it/infostrada

1 0

Re: [ros-dev] Bug #2232 fixed.
by carlo.bramix 10 Jul '07

10 Jul '07

Ouch, sorry but I did a MISTAKE! I don't know why, but the version in my source tree is patched while the SVN one isn't. It's strange, I wonder how I could do this mistake because I use this one only for "svn up" and "make". (Since it's the PC that I use for work, I cannot spend time on it for other jobs, and I compile & debug & diff single applications separately at home, without the entire build system of ReactOS). However, I used this chance for creating a patch with "svn diff" and I posted it into bugzilla. Sincerely (and please excuse me...) Carlo Bramini ---------- Initial Header ----------- >From : ros-dev-bounces(a)reactos.org To : "ros-dev" ros-dev(a)reactos.org Cc : Date : Tue, 10 Jul 2007 11:51:44 +0200 Subject : [ros-dev] Bug #2232 fixed. > I checked the sources of r27553 and I saw that the patch has been applied. > I verified that the signaled bug doesn't happen anymore. > > Sincerely, > > Carlo Bramini. > > > > ------------------------------------------------------ > Scegli infostrada: ADSL gratis per tutta lestate e telefoni senza canone Telecom > http://click.libero.it/infostrada > > > _______________________________________________ > Ros-dev mailing list > Ros-dev(a)reactos.org > http://www.reactos.org/mailman/listinfo/ros-dev > ------------------------------------------------------ Scegli infostrada: ADSL gratis per tutta lestate e telefoni senza canone Telecom http://click.libero.it/infostrada

1 0

Bug #2232 fixed.
by carlo.bramix 10 Jul '07

10 Jul '07

I checked the sources of r27553 and I saw that the patch has been applied. I verified that the signaled bug doesn't happen anymore. Sincerely, Carlo Bramini. ------------------------------------------------------ Scegli infostrada: ADSL gratis per tutta lestate e telefoni senza canone Telecom http://click.libero.it/infostrada

1 0

Fix for few little warnings
by carlo.bramix 10 Jul '07

10 Jul '07

Hello, I would like to suggest to add these includes into these files. It will fix few very little warnings for unknown function. ------------------------------------- dll\win32\advpack\advpack.c: #include <stdlib.h> ------------------------------------- dll\win32\mpr\wnet.c: dll\win32\msi\database.c: dll\win32\msi\dialog.c: dll\win32\msi\table.c: dll\win32\oleaut32\vartype.c: #include <stdio.h> ------------------------------------- Sincerely, Carlo Bramini ------------------------------------------------------ Scegli infostrada: ADSL gratis per tutta lestate e telefoni senza canone Telecom http://click.libero.it/infostrada

1 0

Re: [ros-dev] ReactOS doesn't compile well
by carlo.bramix 09 Jul '07

09 Jul '07

Hello, problem with compilation of regedit seems to be gone with revision 27541. Sincerely, Carlo Bramini ---------- Initial Header ----------- >From : ros-dev-bounces(a)reactos.org To : "ros-dev" ros-dev(a)reactos.org Cc : Date : Mon, 9 Jul 2007 11:24:29 +0200 Subject : [ros-dev] ReactOS doesn't compile well > Hello, > it looks like something wrong happens when I compile ReactOS. > I also did a complete clean and a make for a total rebuild, but I'm still having problems. > > I saw the first problem when I tried to test Regedit after committed changes. > The tree window and the listview window aren't visible (or they aren't created successfully, I didn't check this yet). > I tested that executable into WinXP and those child windows aren't visible too. > So I did these steps: > 1) I compiled Regedit with Visual C and I verified that it worked fine. > 2) I grabbed regedit.res and I manually generated regedit.coff with "windres -i regedit.res -o regedit.coff". > 3) I launched "make" again and it regenerated regedit.exe. > This last regedit.exe works fine and it has all child window controls visible. It's really a problem when generating te coff file from resources. > > I also saw a possible second problem when compiling. > Some compilation of '.coff' files failed. > On the console I read some messages like this one: > > [WRC] obj-i386\dll\win32\comdlg32\rsrc.coff > <built-in>:0: fatal error: when writing output to : Invalid argument > compilation terminated. > > Actually I'm using RosBE 0.3.6 but I never got such problems with previouses svn versions of the sources. > > Sincerely, > > Carlo Bramini > > > > ------------------------------------------------------ > Leggi GRATIS le tue mail con il telefonino i-mode di Wind > http://i-mode.wind.it/ > > > _______________________________________________ > Ros-dev mailing list > Ros-dev(a)reactos.org > http://www.reactos.org/mailman/listinfo/ros-dev > ------------------------------------------------------ Leggi GRATIS le tue mail con il telefonino i-mode di Wind http://i-mode.wind.it/

1 0

Re: [ros-dev] Update patches into BugZilla
by carlo.bramix 09 Jul '07

09 Jul '07

Hello, Patch for bug #2365 has been updated with "svn diff taskmgr". Sincerely, Carlo Bramini ---------- Initial Header ----------- >From : ros-dev-bounces(a)reactos.org To : "ros-dev" ros-dev(a)reactos.org Cc : Date : Fri, 6 Jul 2007 15:04:24 +0200 Subject : [ros-dev] Update patches into BugZilla > Hello, > I updated the patch into bug #2356 and I generated it with "svn diff regedit" instead of using "diff -u" or Winmerge with a local copy. > I should do the same with the other patches that I posted, am I right? > > Sincerely, > > Carlo Bramini. > > ---------- Initial Header ----------- > > >From : ros-dev-bounces(a)reactos.org > To : "ros-dev" ros-dev(a)reactos.org > Cc : > Date : Thu, 5 Jul 2007 13:55:47 +0200 > Subject : [ros-dev] Italian fixes to TaskMgr > > > Hello, > > I posted some fixes to bug #2365. > > It fixes few things into the italian translation and I did a small improvement of the source code into affinity.c > > > > Sincerely, > > > > Carlo Bramini > > > > > > > > ------------------------------------------------------ > > Leggi GRATIS le tue mail con il telefonino i-mode di Wind > > http://i-mode.wind.it/ > > > > > > _______________________________________________ > > Ros-dev mailing list > > Ros-dev(a)reactos.org > > http://www.reactos.org/mailman/listinfo/ros-dev > > > > > ------------------------------------------------------ > Scegli infostrada: ADSL gratis per tutta lestate e telefoni senza canone Telecom > http://click.libero.it/infostrada > > > _______________________________________________ > Ros-dev mailing list > Ros-dev(a)reactos.org > http://www.reactos.org/mailman/listinfo/ros-dev > ------------------------------------------------------ Leggi GRATIS le tue mail con il telefonino i-mode di Wind http://i-mode.wind.it/

1 0

ReactOS doesn't compile well
by carlo.bramix 09 Jul '07

09 Jul '07

Hello, it looks like something wrong happens when I compile ReactOS. I also did a complete clean and a make for a total rebuild, but I'm still having problems. I saw the first problem when I tried to test Regedit after committed changes. The tree window and the listview window aren't visible (or they aren't created successfully, I didn't check this yet). I tested that executable into WinXP and those child windows aren't visible too. So I did these steps: 1) I compiled Regedit with Visual C and I verified that it worked fine. 2) I grabbed regedit.res and I manually generated regedit.coff with "windres -i regedit.res -o regedit.coff". 3) I launched "make" again and it regenerated regedit.exe. This last regedit.exe works fine and it has all child window controls visible. It's really a problem when generating te coff file from resources. I also saw a possible second problem when compiling. Some compilation of '.coff' files failed. On the console I read some messages like this one: [WRC] obj-i386\dll\win32\comdlg32\rsrc.coff <built-in>:0: fatal error: when writing output to : Invalid argument compilation terminated. Actually I'm using RosBE 0.3.6 but I never got such problems with previouses svn versions of the sources. Sincerely, Carlo Bramini ------------------------------------------------------ Leggi GRATIS le tue mail con il telefonino i-mode di Wind http://i-mode.wind.it/

1 0

Re: [ros-dev] Trunk freeze
by Aleksey Bragin 08 Jul '07

08 Jul '07

Trunk unfrozen, guilty revision partially reverted. WBR, Aleksey Bragin.

1 0

Trunk freeze
by Aleksey Bragin 08 Jul '07

08 Jul '07

Hello, trunk is frozen right now due to inability to boot into 2nd stage (it crashes with "Failure rendering glyph"). As soon as the issue is fixed, trunk will be unfrozen. Thanks for your patience. WBR, Aleksey Bragin.

1 0

Re: [ros-dev] [ros-diffs] [ekohl] 27514: - Fix indentation. - Replace tabs by spaces. - Replace STDCALL by WINAPI. - Replace Alex' unreadable single-line statements by readable ones. - No code changes.
by Alex Ionescu 08 Jul '07

08 Jul '07

While I don't mind your other re-formats, what's the purpose of insulting my code (which respected ReactOS Coding Guidelines, (please read them: http://www.reactos.org/wiki/index.php/Coding_Style)) and replacing it with non-ReactOS compliant code? Is a 71-character line so hard to read? -----Original Message----- From: ros-diffs-bounces(a)reactos.org [mailto:ros-diffs-bounces@reactos.org] On Behalf Of ekohl(a)svn.reactos.org Sent: July 8, 2007 1:09 PM To: ros-diffs(a)reactos.org Subject: [ros-diffs] [ekohl] 27514: - Fix indentation. - Replace tabs by spaces. - Replace STDCALL by WINAPI. - Replace Alex' unreadable single-line statements by readable ones. - No code changes. Author: ekohl Date: Mon Jul 9 00:09:22 2007 New Revision: 27514 URL: http://svn.reactos.org/svn/reactos?rev=27514&view=rev Log: - Fix indentation. - Replace tabs by spaces. - Replace STDCALL by WINAPI. - Replace Alex' unreadable single-line statements by readable ones. - No code changes. Modified: trunk/reactos/dll/win32/kernel32/file/npipe.c Modified: trunk/reactos/dll/win32/kernel32/file/npipe.c URL:

1 0

Update patches into BugZilla
by carlo.bramix 07 Jul '07

07 Jul '07

Hello, I updated the patch into bug #2356 and I generated it with "svn diff regedit" instead of using "diff -u" or Winmerge with a local copy. I should do the same with the other patches that I posted, am I right? Sincerely, Carlo Bramini. ---------- Initial Header ----------- >From : ros-dev-bounces(a)reactos.org To : "ros-dev" ros-dev(a)reactos.org Cc : Date : Thu, 5 Jul 2007 13:55:47 +0200 Subject : [ros-dev] Italian fixes to TaskMgr > Hello, > I posted some fixes to bug #2365. > It fixes few things into the italian translation and I did a small improvement of the source code into affinity.c > > Sincerely, > > Carlo Bramini > > > > ------------------------------------------------------ > Leggi GRATIS le tue mail con il telefonino i-mode di Wind > http://i-mode.wind.it/ > > > _______________________________________________ > Ros-dev mailing list > Ros-dev(a)reactos.org > http://www.reactos.org/mailman/listinfo/ros-dev > ------------------------------------------------------ Scegli infostrada: ADSL gratis per tutta lestate e telefoni senza canone Telecom http://click.libero.it/infostrada

2 1

Italian fixes to TaskMgr
by carlo.bramix 05 Jul '07

05 Jul '07

Hello, I posted some fixes to bug #2365. It fixes few things into the italian translation and I did a small improvement of the source code into affinity.c Sincerely, Carlo Bramini ------------------------------------------------------ Leggi GRATIS le tue mail con il telefonino i-mode di Wind http://i-mode.wind.it/

1 0

Re: [ros-dev] [ros-diffs] [cwittich] 27397: ZeroMemory the correct amount of bytes
by Aleksey Bragin 05 Jul '07

05 Jul '07

I think those changes are incorrect, because you're effectively zeroing sizeof(void *) instead of zeroing sizeof(PORT_DEVICE_EXTENSION). WBR, Aleksey Bragin. On Jul 5, 2007, at 5:24 AM, cwittich(a)svn.reactos.org wrote: > Author: cwittich > Date: Thu Jul 5 05:24:57 2007 > New Revision: 27397 > > URL: http://svn.reactos.org/svn/reactos?rev=27397&view=rev > Log: > ZeroMemory the correct amount of bytes > > Modified: > trunk/reactos/drivers/input/kbdclass/kbdclass.c > > Modified: trunk/reactos/drivers/input/kbdclass/kbdclass.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/input/ > kbdclass/kbdclass.c?rev=27397&r1=27396&r2=27397&view=diff > ====================================================================== > ======== > --- trunk/reactos/drivers/input/kbdclass/kbdclass.c (original) > +++ trunk/reactos/drivers/input/kbdclass/kbdclass.c Thu Jul 5 > 05:24:57 2007 > @@ -695,7 +695,7 @@ > } > > DeviceExtension = (PPORT_DEVICE_EXTENSION)Fdo->DeviceExtension; > - RtlZeroMemory(DeviceExtension, sizeof(CLASS_DEVICE_EXTENSION)); > + RtlZeroMemory(DeviceExtension, sizeof(PPORT_DEVICE_EXTENSION)); > DeviceExtension->Common.IsClassDO = FALSE; > DeviceExtension->DeviceObject = Fdo; > DeviceExtension->PnpState = dsStopped; > >

2 1

Re: [ros-dev] BugFixing in RegEdit
by carlo.bramix 04 Jul '07

04 Jul '07

Hello, following the suggestions that I received, I would like put your attention on these patches posted into bugzilla: - patch Posted into bug #2356. It closes these bugs: #982: some languages had IDOK and IDCANCEL in conflict because both declared as DEFPUSHBUTTON. It should be fixed. #1009: Context menu is now fully working. Fixed. - Patch posted into bug #2356. It fixes itself. - Patch posted into bug #2232 It fixes itself and some unsignaled bugs. I hope I didn't mistakes this time. Sincerely, Carlo Bramini. ---------- Initial Header ----------- >From : ros-dev-bounces(a)reactos.org To : "ReactOS Development List" ros-dev(a)reactos.org Cc : Date : Tue, 03 Jul 2007 12:30:36 +0200 Subject : Re: [ros-dev] BugFixing in RegEdit > carlo.bramix ha scritto: > > I'm also wondering why the patches sent to bugzilla aren't replied too. > > I don't know, perhaps I'm just unlucky. > > Just misguided. You post on Bugzilla for the posterity, and then you > post your Bugzilla number on the mailing list for the attention. You > need to get noticed *and* remembered. > _______________________________________________ > Ros-dev mailing list > Ros-dev(a)reactos.org > http://www.reactos.org/mailman/listinfo/ros-dev > ------------------------------------------------------ Scegli infostrada: ADSL gratis per tutta lestate e telefoni senza canone Telecom http://click.libero.it/infostrada

1 0

GPLv3 Migration - flamewar warning
by Steven Edwards 04 Jul '07

04 Jul '07

Hi, I've been inactive for a while and most likely will be so for a while however I thought this would be a good time to bring up the GPLv3 due to its recent release. Does anyone have any objections to license as it stands now? If you've not had a chance to review it I suggest you do so. I am happy to help answer any questions regarding the license as I did take part in early drafting on behalf of the ReactOS and Wine Projects although I am not a lawyer and anything I say should be at least reviewed by the SFLC or your own lawyers. It is my suggestion that if there are no objections then we start to contact each developer requesting them to dual license existing code as GPLv2/GPLv3 and use the same tracking system as the audit system to do the migration. ReactOS has never been really clear on the "or later version" clause in the GPL. The ReactOS license includes the text and the license number is not specified in most of the ReactOS sources, though I don't think it would be fair to simply take all of the source and re-license it without some discussions and a vote. It would also be possible to distribute ReactOS under both licenses via dual licensing as a possible compromise if a dispute arises. This would mean if some third party (Third Party A) wants to take ReactOS enhance it and then resell it, they would not have to worry about another third party (Third Party B) taking their modifications and redistributing them for profit without the patent protections of the GPLv3 and the Anti-Tivoization clauses. The only downside to this is if Third Party A is only making changes under GPLv3 then those changes could not go back in to ReactOS trunk. I don't think this is a major issue, as I expect both third parties to be proprietary vendors making enhancements that the Project might not want/need in the trunk in any case. Third Party A in the interest of keeping forking to a minimal would still send bug fixes back up both licenses. Thanks -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

10 21

Re: [ros-dev] [ros-diffs] [fireball] 27202: - Finally, removing frame pointer was a bad idea (think of exceptions / etc).
by Aleksey Bragin 03 Jul '07

03 Jul '07

No, I reverted all those "funny" things in revision 27367. WBR, Aleksey. On Jul 3, 2007, at 3:47 AM, Alex Ionescu wrote: > Have they been un-separated or are they still under one large file? > > -- > Best regards, > Alex Ionescu

2 1

Re: [ros-dev] BugFixing in RegEdit
by carlo.bramix 03 Jul '07

03 Jul '07

Ciao Gabriel, ti ringrazio per l'offerta, tuttavia non credo di poter accettare. Il PC "potente" e' un computer Pentium 4 3GHz che mi hanno fornito al lavoro per sbrigare una commessa. Spero, ma in realta' e' molto di piu' di una speranza, che possa diventare il mio PC definitivo. Infatti, il "vecchio" Pentium 3 lo rifilero' per svolgere il lavoro in oggetto. Anzi, mi sembra addirittura sovrastimato per quello che deve fare. Il PC che uso a casa e': Pentium 200 MHz con MMX. 48 MB di RAM Scheda video S3 VIRGE DX con 4 MB di ram. Harddisk 6.4GB (con 200 MB liberi). Monitor/tastiera/mouse. Continuo a tenere questo PC per questi motivi: 1) Per quello che devo fare io basta e avanza, ovvero scrivere e compilare codice. Nel caso specifico di ROS, io mi scarico solo i sorgenti delle applicazioni che mi interessano. Ora come ora, le compilo singolarmente e le verifico comodamente anche cosi'. E poi, tutto sommato, e' anche uno stimolo per fare meglio le cose. Se in un programma c'e' qualche cosa di inefficiente, sul mio PC si vede subito! 2) Il mio PC ha lo slot ISA. Di per se' si potrebbe pensare che sia una cavolata, ma io ho un paio di schede (tra cui i gloriosi emulatori per microcontrollore Hitachi H8) che si innestano proprio li'. La Renesas (la societa' che ha comprato e distribuisce i chip della famiglia H8) vende oggi prodotti che fanno la stessa cosa di queste schede, ma che si attaccano all'USB. Anni fa ne avevo fatto comprare uno, ma sono un'autentica porcheria, e' molto meglio quello che aveva fatto la Hitachi, anche se va su bus ISA. 3) Ho una certa linea di pensiero riguardo le applicazioni che girano sui computer. Mi rifiuto di credere che una macchina come la mia, sicuramente vetusta, non sia comunque in grado di far girare decentemente certi tipi di applicazioni. Un esempio di cio' di cui ti sto parlando: non mi era possibile vedere fluidamente i filmati DivX. Cosi' ho lavorato per un tot di tempo con il team dell'Xvid e voila': problema in buona parte risolto (per fortuna!). 4) Ci sono affezionato, l'ho comprato nel Natale del 1997(!) con i soldini guadagnati dal tirocinio fatto in un'azienda per conto del Politecnico di Torino. Il primo computer tutto mio! 5) Il case e' un desktop (di quelli che stanno comodamente sotto il monitor) e non un minitower cosi' tanto in voga oggi (chissa' poi perche'). Non avrei davvero lo spazio per un case diverso. Io abito vicino a Biella. A presto, Carlo. PS: Al momento della scrittura di questo messaggio, non c'e' stato ancora un'anima che mi abbia dato delle risposte. Bugfix su bugzilla: niente risposte. Bugfix direttamente su mailing list: niente risposte. Dannazione! Non ho ancora capito cosa ci vuole per mettere su un paio di varianti da due soldi... Non metto in dubbio il fatto che le varianti vorrebbero comunque provarle e riprovarle prima di dire "ok, chiudiamo il bug" e potrebbero non avere il tempo materiale di fare cio', pero'... il silenzio e' davvero seccante! A proposito, ce l'hai fatta poi a compilare con le mie patch? ---------- Initial Header ----------- >From : ros-dev-bounces(a)reactos.org To : ros-dev(a)reactos.org Cc : Date : Fri, 29 Jun 2007 19:34:09 +0000 Subject : Re: [ros-dev] BugFixing in RegEdit > Ciao Carlo, > > ti faccio qualche domandina? Hai detto che avevi che computer prima? E > adesso hai uno nuovo temporaneo? Di dove sei? Ti chiedo perché eventualmente > penso di aver un PIII da qualche parte, che sarei disposto a regalarti > perché tu possa collaborare in reactos... > Gabriel. > > _________________________________________________________________ > Cinema, Tv, Gossip e OrsoscopoTutto su MSN intrattenimento! > http://intrattenimento.it.msn.com/ > > _______________________________________________ > Ros-dev mailing list > Ros-dev(a)reactos.org > http://www.reactos.org/mailman/listinfo/ros-dev > ------------------------------------------------------ Scegli infostrada: ADSL gratis per tutta lestate e telefoni senza canone Telecom http://click.libero.it/infostrada

3 2

Re: [ros-dev] BugFixing in RegEdit
by carlo.bramix 03 Jul '07

03 Jul '07

Hello, I'm also wondering why the patches sent to bugzilla aren't replied too. I don't know, perhaps I'm just unlucky. I will follow your request I'm going to post also this thing on bugzilla. Sincerely, Carlo Bramini ---------- Initial Header ----------- >From : ros-dev-bounces(a)reactos.org To : "ReactOS Development List" ros-dev(a)reactos.org Cc : Date : Tue, 3 Jul 2007 11:03:50 +0200 Subject : Re: [ros-dev] BugFixing in RegEdit > Hi, > > you should submit your corrections on BugZilla. > > Best regards, > Heis Spiter > > ----- Original Message ----- > From: "carlo.bramix" <carlo.bramix(a)libero.it> > To: "ros-dev" <ros-dev(a)reactos.org> > Sent: Tuesday, July 03, 2007 10:27 AM > Subject: Re: [ros-dev] BugFixing in RegEdit > > Hello, > I'm sorry, I simply forgot to remove "ros-dev(a)reactos.org" from the > destination address. > It also seems there is some people alive here, and so I'm also wondering if > those corrections could be accepted or not. > > Sincerely, > > Carlo Bramini. > > ---------- Initial Header ----------- > > >From : ros-dev-bounces(a)reactos.org > To : "ReactOS Development List" ros-dev(a)reactos.org > Cc : > Date : Tue, 3 Jul 2007 00:08:36 -0400 > Subject : Re: [ros-dev] BugFixing in RegEdit > > > Hey! I feel the love guys but... this is an english/greatlordish ML. > > Thank your for respecting the rest of us. > > > > _______________________________________________ > Ros-dev mailing list > Ros-dev(a)reactos.org > http://www.reactos.org/mailman/listinfo/ros-dev > ------------------------------------------------------ Leggi GRATIS le tue mail con il telefonino i-mode di Wind http://i-mode.wind.it/

2 1

Re: [ros-dev] BugFixing in RegEdit
by carlo.bramix 03 Jul '07

03 Jul '07

Hello, I'm sorry, I simply forgot to remove "ros-dev(a)reactos.org" from the destination address. It also seems there is some people alive here, and so I'm also wondering if those corrections could be accepted or not. Sincerely, Carlo Bramini. ---------- Initial Header ----------- >From : ros-dev-bounces(a)reactos.org To : "ReactOS Development List" ros-dev(a)reactos.org Cc : Date : Tue, 3 Jul 2007 00:08:36 -0400 Subject : Re: [ros-dev] BugFixing in RegEdit > Hey! I feel the love guys but... this is an english/greatlordish ML. > Thank your for respecting the rest of us. > > On 7/2/07, carlo.bramix <carlo.bramix(a)libero.it> wrote: > > Ciao Gabriel, > > ti ringrazio per l'offerta, tuttavia non credo di poter accettare. > > Il PC "potente" e' un computer Pentium 4 3GHz che mi hanno fornito al lavoro per sbrigare una commessa. > > Spero, ma in realta' e' molto di piu' di una speranza, che possa diventare il mio PC definitivo. > > Infatti, il "vecchio" Pentium 3 lo rifilero' per svolgere il lavoro in oggetto. > > Anzi, mi sembra addirittura sovrastimato per quello che deve fare. > > > > Il PC che uso a casa e': > > Pentium 200 MHz con MMX. > > 48 MB di RAM > > Scheda video S3 VIRGE DX con 4 MB di ram. > > Harddisk 6.4GB (con 200 MB liberi). > > Monitor/tastiera/mouse. > > > > Continuo a tenere questo PC per questi motivi: > > 1) Per quello che devo fare io basta e avanza, ovvero scrivere e compilare codice. > > Nel caso specifico di ROS, io mi scarico solo i sorgenti delle applicazioni che mi interessano. > > Ora come ora, le compilo singolarmente e le verifico comodamente anche cosi'. > > E poi, tutto sommato, e' anche uno stimolo per fare meglio le cose. > > Se in un programma c'e' qualche cosa di inefficiente, sul mio PC si vede subito! > > 2) Il mio PC ha lo slot ISA. > > Di per se' si potrebbe pensare che sia una cavolata, ma io ho un paio di schede (tra cui i gloriosi emulatori per microcontrollore Hitachi H8) che si innestano proprio li'. > > La Renesas (la societa' che ha comprato e distribuisce i chip della famiglia H8) vende oggi prodotti che fanno la stessa cosa di queste schede, ma che si attaccano all'USB. > > Anni fa ne avevo fatto comprare uno, ma sono un'autentica porcheria, e' molto meglio quello che aveva fatto la Hitachi, anche se va su bus ISA. > > 3) Ho una certa linea di pensiero riguardo le applicazioni che girano sui computer. > > Mi rifiuto di credere che una macchina come la mia, sicuramente vetusta, non sia comunque in grado di far girare decentemente certi tipi di applicazioni. > > Un esempio di cio' di cui ti sto parlando: non mi era possibile vedere fluidamente i filmati DivX. > > Cosi' ho lavorato per un tot di tempo con il team dell'Xvid e voila': problema in buona parte risolto (per fortuna!). > > 4) Ci sono affezionato, l'ho comprato nel Natale del 1997(!) con i soldini guadagnati dal tirocinio fatto in un'azienda per conto del Politecnico di Torino. > > Il primo computer tutto mio! > > 5) Il case e' un desktop (di quelli che stanno comodamente sotto il monitor) e non un minitower cosi' tanto in voga oggi (chissa' poi perche'). Non avrei davvero lo spazio per un case diverso. > > > > Io abito vicino a Biella. > > > > A presto, > > > > Carlo. > > > > PS: > > Al momento della scrittura di questo messaggio, non c'e' stato ancora un'anima che mi abbia dato delle risposte. > > Bugfix su bugzilla: niente risposte. > > Bugfix direttamente su mailing list: niente risposte. > > Dannazione! > > Non ho ancora capito cosa ci vuole per mettere su un paio di varianti da due soldi... > > Non metto in dubbio il fatto che le varianti vorrebbero comunque provarle e riprovarle prima di dire "ok, chiudiamo il bug" e potrebbero non avere il tempo materiale di fare cio', pero'... il silenzio e' davvero seccante! > > A proposito, ce l'hai fatta poi a compilare con le mie patch? > > > > > > ---------- Initial Header ----------- > > > > >From : ros-dev-bounces(a)reactos.org > > To : ros-dev(a)reactos.org > > Cc : > > Date : Fri, 29 Jun 2007 19:34:09 +0000 > > Subject : Re: [ros-dev] BugFixing in RegEdit > > > > > Ciao Carlo, > > > > > > ti faccio qualche domandina? Hai detto che avevi che computer prima? E > > > adesso hai uno nuovo temporaneo? Di dove sei? Ti chiedo perché eventualmente > > > penso di aver un PIII da qualche parte, che sarei disposto a regalarti > > > perché tu possa collaborare in reactos... > > > Gabriel. > > > > > > _________________________________________________________________ > > > Cinema, Tv, Gossip e Orsoscopo...Tutto su MSN intrattenimento! > > > http://intrattenimento.it.msn.com/ > > > > > > _______________________________________________ > > > Ros-dev mailing list > > > Ros-dev(a)reactos.org > > > http://www.reactos.org/mailman/listinfo/ros-dev > > > > > > > > > ------------------------------------------------------ > > Scegli infostrada: ADSL gratis per tutta l'estate e telefoni senza canone Telecom > > http://click.libero.it/infostrada > > > > > > _______________________________________________ > > Ros-dev mailing list > > Ros-dev(a)reactos.org > > http://www.reactos.org/mailman/listinfo/ros-dev > > > > > -- > encoded > Samuel Serapión Vega > Computer Engineering, Polytechnic University of Puerto Rico. > > _______________________________________________ > Ros-dev mailing list > Ros-dev(a)reactos.org > http://www.reactos.org/mailman/listinfo/ros-dev ------------------------------------------------------ Leggi GRATIS le tue mail con il telefonino i-mode di Wind http://i-mode.wind.it/

2 1

A New Direction
by Alex Ionescu 03 Jul '07

03 Jul '07

It is with great excitement (and a certain amount of nostalgia) that I would like to announce two important changes in my professional life and in the direction in which I will pursue my knowledge and work on Windows Internals. The first of these changes is my debut as an instructor for David Solomon's Expert Seminars <http://www.solsem.com/>, and the second is my departure from ReactOS <http://www.reactos.org/>, effective immediately. These plans do not change in any way my internship at Apple which will take place during the summer. Some time ago, I had the great privilege of being approached by David Solomon, a well-known and highly regarded computer expert, teacher, consultant and co-author of Windows Internals 4th Edition<http://www.microsoft.com/technet/sysinternals/information/windowsinternals.…>(and Inside Windows 2000, 3 rd Edition). For the last couple of years, David had been working with Mark Russinovich, another respected figure in the world of Windows Internals, and co-founder of Winternals and Sysinternals as well as developer of some of the most useful Windows system tools available today. Apart from working on the two books (which Mark was a co-author of), they both provided trainings and seminars on Windows internals under the "David Solomon Expert Seminars" banner. As is widely known, Microsoft realized that Mark's experience and amazing work on the NT platform through his articles and tools could provide a highly beneficial new addition to the company. The company bought Winternals last year, and hired Mark at the highest technical level in the company, Technical Fellow. All this is history of course, and back to the matter at hand, Mark's recent new employment made him unavailable for teaching new classes, which made David Solomon start the search for a new instructor which could take on the responsibility of teaching new classes. I was highly honoured to have been chosen as this person, and accepted this unique opportunity to bring my knowledge out to many more people and to work with one of my most admired Windows experts. With this new job as an added task on top of my already busy life, as well as with the imminent Apple internship, I was already planning to cut back on my involvement with ReactOS. However, since it became clear that my level of contact with Microsoft employees and resources would be in conflict with my work at ReactOS, I made the difficult choice of amicably severing my ties with the project. This decision took some time for me to finalize, but the various motivations behind it had started cropping up since early this year. When I first joined ReactOS 3 years ago, the kernel was – in my opinion – highly disorganized and hodgepodge of Linux, NT 4, Wine and Windows 9x code which was very far from its actual goal of NT Driver compatibility. In fact, the development model seemed to focus on hacking NT drivers to work on ReactOS, and not vice-versa. Coincidentally, I joined the project just as the lead kernel developer, David Welch, had just burnt out and moved to other projects and goals. For the last three years, I rewrote key subsystems such as the thread scheduler, dispatcher, locking and IRQL mechanisms, HAL, executive support, object manager, process manager, I/O manager, basic VDM and 8086 support, and much more, as well as switched the project goals from NT4 to NT 5.2. My ability to do this came from my extensive reverse engineering of the kernel in the past, reading internals books, access to the DDK/IFS, as well as using WinDBG and .pdb type information. In return for all the code and guidance I provided, the project gave me a lot in return as well, including a unique perspective of working on such a project, the ability to work in large and distributed teams, and using open source tools for Windows NT kernel development. With millions of lines of code, ReactOS is the kind of project that an 18 year old could've only dreamt work ing on. I became adept in source control repositories, regression testing, unit testing, team management, IRC administration, as well as a much better coder in C. I also made friendships of all levels with various developers, testers and users, and had a chance to mentor two students during last year's Google Summer of Code. I was able to attend and give talks on ReactOS, exhibit it, and make connections with other people in the industry, and in the open source world. Overall, it's been an exhilarating adventure. After three years however, and with the many new responsibilities that had kept growing, my free time grew short. Additionally, my work in the kernel had almost reached completion. The parts that still need major work, in my opinion, require extremely skilled developers in those areas to ever be as close to NT as needed. They are also some of the most critical: the memory manager, the cache manager, the Power/PnP Manager, the configuration manager and the file system runtime library. With the current differences that exist, most modern WDM drivers as well as IFS drivers can only dream of running properly. Unfortunately, my knowledge in those areas was limited. I had never reverse engineered them as extensively as parts of the executive, and documentation on their guts is limited. In all honesty, they're also not parts of the system that interest me much. I could, of course, have continued working on user-mode parts of the system where my help would still bring a lot of the system forward, such as ntdll, csrss, smss, winsock and kernel32, but my interest in teaching with David Solomon and getting in touch with the developers behind NT outweighed that desire. After three years, I learned a tremendous amount of knowledge and skills while working on ReactOS, now the time has come for me to learn even more by expanding my horizons. In many ways, I had already outgrown the project, focusing more on security research, utilities and tools, articles and non-ReactOS related talks and conferences. It was time for me to step outside and take on a new opportunity with a larger audience and which would bring me many new experiences and teachings. I wish the ReactOS Project all the luck and I know that some significant new changes are on the horizon for them. I will keep watching from a distance, and I thank them for the most fun years of my life.- -- Best regards, Alex Ionescu

2 1

Re: [ros-dev] Ros-dev Digest, Vol 35, Issue 1
by Olaf Siejka 03 Jul '07

03 Jul '07

>Ciao Gabriel, >ti ringrazio per l'offerta, tuttavia non credo di poter accettare. This is english ML and please adhere to that.

1 0

Re: [ros-dev] [ros-diffs] [fireball] 27202: - Finally, removing frame pointer was a bad idea (think of exceptions / etc).
by Alex Ionescu 02 Jul '07

02 Jul '07

You guys are hilarious. Hint: putting all the trig functions into one file is a bad idea too. There's a reason they were made separate. Cookie for whoever finds out why. -- Best regards, Alex Ionescu -----Original Message----- From: ros-diffs-bounces(a)reactos.org [mailto:ros-diffs-bounces@reactos.org] On Behalf Of fireball(a)svn.reactos.org Sent: Saturday, June 16, 2007 5:29 AM To: ros-diffs(a)reactos.org Subject: [ros-diffs] [fireball] 27202: - Finally, removing frame pointer was a bad idea (think of exceptions / etc). Author: fireball Date: Sat Jun 16 16:28:56 2007 New Revision: 27202 URL: http://svn.reactos.org/svn/reactos?rev=27202&view=rev Log: - Finally, removing frame pointer was a bad idea (think of exceptions / etc). Modified: trunk/reactos/lib/sdk/libcntpr/math/i386/fabs_asm.s trunk/reactos/lib/sdk/libcntpr/math/i386/log_asm.s trunk/reactos/lib/sdk/libcntpr/math/i386/sqrt_asm.s trunk/reactos/lib/sdk/libcntpr/math/i386/trig_asm.s Modified: trunk/reactos/lib/sdk/libcntpr/math/i386/fabs_asm.s URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/sdk/libcntpr/math/i386… ============================================================================== --- trunk/reactos/lib/sdk/libcntpr/math/i386/fabs_asm.s (original) +++ trunk/reactos/lib/sdk/libcntpr/math/i386/fabs_asm.s Sat Jun 16 16:28:56 2007 @@ -3,13 +3,47 @@ * PROJECT: ReactOS kernel * PURPOSE: Run-Time Library * FILE: lib/rtl/i386/fabs.S - * PROGRAMER: Magnus Olsen (greatlord(a)greatlord.com) -*/ + * PROGRAMER: Alex Ionescu (alex(a)relsoft.net) + * + * Copyright (C) 2002 Michael Ringgaard. + * All rights reserved. + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions + * are met: + * + * 1. Redistributions of source code must retain the above copyright + * notice, this list of conditions and the following disclaimer. + * 2. Redistributions in binary form must reproduce the above copyright + * notice, this list of conditions and the following disclaimer in the + * documentation and/or other materials provided with the distribution. + * 3. Neither the name of the project nor the names of its contributors + * may be used to endorse or promote products derived from this software + * without specific prior written permission. + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND + * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE + * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE + * ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE + * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL + * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS + * OR SERVICES// LOSS OF USE, DATA, OR PROFITS// OR BUSINESS INTERRUPTION) + * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT + * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY + * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF + * SUCH DAMAGE. + */ + .globl _fabs + .intel_syntax noprefix + +/* FUNCTIONS ***************************************************************/ + _fabs: - - fld qword ptr [esp+8] - fabs + push ebp + mov ebp,esp + fld qword ptr [ebp+8] // Load real from stack + fabs // Take the absolute value + pop ebp ret Modified: trunk/reactos/lib/sdk/libcntpr/math/i386/log_asm.s URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/sdk/libcntpr/math/i386… ============================================================================== --- trunk/reactos/lib/sdk/libcntpr/math/i386/log_asm.s (original) +++ trunk/reactos/lib/sdk/libcntpr/math/i386/log_asm.s Sat Jun 16 16:28:56 2007 @@ -3,14 +3,49 @@ * PROJECT: ReactOS kernel * PURPOSE: Run-Time Library * FILE: lib/rtl/i386/log.S - * PROGRAMER: Magnus Olsen (greatlord(a)greatlord.com) + * PROGRAMER: Alex Ionescu (alex(a)relsoft.net) + * + * Copyright (C) 2002 Michael Ringgaard. + * All rights reserved. + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions + * are met: + * + * 1. Redistributions of source code must retain the above copyright + * notice, this list of conditions and the following disclaimer. + * 2. Redistributions in binary form must reproduce the above copyright + * notice, this list of conditions and the following disclaimer in the + * documentation and/or other materials provided with the distribution. + * 3. Neither the name of the project nor the names of its contributors + * may be used to endorse or promote products derived from this software + * without specific prior written permission. + + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND + * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE + * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE + * ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE + * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL + * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS + * OR SERVICES// LOSS OF USE, DATA, OR PROFITS// OR BUSINESS INTERRUPTION) + * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT + * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY + * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF + * SUCH DAMAGE. */ + .globl _log + .intel_syntax noprefix +/* FUNCTIONS ***************************************************************/ + _log: - fld qword ptr [esp+8] - fldln2 - fxch st(1) - fyl2x + push ebp + mov ebp,esp + fld qword ptr [ebp+8] // Load real from stack + fldln2 // Load log base e of 2 + fxch st(1) // Exchange st, st(1) + fyl2x // Compute the natural log(x) + pop ebp ret Modified: trunk/reactos/lib/sdk/libcntpr/math/i386/sqrt_asm.s URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/sdk/libcntpr/math/i386… ============================================================================== --- trunk/reactos/lib/sdk/libcntpr/math/i386/sqrt_asm.s (original) +++ trunk/reactos/lib/sdk/libcntpr/math/i386/sqrt_asm.s Sat Jun 16 16:28:56 2007 @@ -3,15 +3,47 @@ * PROJECT: ReactOS kernel * PURPOSE: Run-Time Library * FILE: lib/rtl/i386/sqrt.S - * PROGRAMER: Magnus Olsen (greatlord(a)greatlord.com) + * PROGRAMER: Alex Ionescu (alex(a)relsoft.net) + * + * Copyright (C) 2002 Michael Ringgaard. + * All rights reserved. + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions + * are met: + * + * 1. Redistributions of source code must retain the above copyright + * notice, this list of conditions and the following disclaimer. + * 2. Redistributions in binary form must reproduce the above copyright + * notice, this list of conditions and the following disclaimer in the + * documentation and/or other materials provided with the distribution. + * 3. Neither the name of the project nor the names of its contributors + * may be used to endorse or promote products derived from this software + * without specific prior written permission. + + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND + * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE + * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE + * ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE + * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL + * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS + * OR SERVICES// LOSS OF USE, DATA, OR PROFITS// OR BUSINESS INTERRUPTION) + * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT + * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY + * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF + * SUCH DAMAGE. */ - .globl _sqrt .intel_syntax noprefix +/* FUNCTIONS ***************************************************************/ + _sqrt: - fld qword ptr [esp+8] - fsqrt + push ebp + mov ebp,esp + fld qword ptr [ebp+8] // Load real from stack + fsqrt // Take the square root + pop ebp ret Modified: trunk/reactos/lib/sdk/libcntpr/math/i386/trig_asm.s URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/sdk/libcntpr/math/i386… ============================================================================== --- trunk/reactos/lib/sdk/libcntpr/math/i386/trig_asm.s (original) +++ trunk/reactos/lib/sdk/libcntpr/math/i386/trig_asm.s Sat Jun 16 16:28:56 2007 @@ -4,33 +4,49 @@ * PURPOSE: Run-Time Library * FILE: lib/rtl/i386/trig_asm.s * PROGRAMER: Aleksey Bragin (aleksey reactos org) -*/ - + * + */ .globl _atan .globl _cos .globl _sin -.globl _tan - + .intel_syntax noprefix +/* FUNCTIONS ***************************************************************/ + _atan: - fld qword ptr [esp+8] + push ebp + mov ebp,esp + fld qword ptr [ebp+8] fld1 fpatan + pop ebp ret _cos: - fld qword ptr [esp+8] + push ebp + mov ebp,esp + fld qword ptr [ebp+8] fcos + pop ebp ret _sin: - fld qword ptr [esp+8] + push ebp + mov ebp,esp + fld qword ptr [ebp+8] fsin + pop ebp ret _tan: - fld qword ptr [esp+8] + push ebp + mov ebp,esp + sub esp,4 + fld qword ptr [ebp+8] fptan - fstp dword ptr [esp-4] + fstp dword ptr [ebp-4] + mov esp,ebp + pop ebp ret +

2 2

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev