- Ros-dev - ReactOS.org

Re: [ros-diffs] [cwittich] 20095: better stubs for VerLanguageNameA/W (untested)
by Hartmut Birr 12 Dec '05

12 Dec '05

cwittich(a)svn.reactos.com wrote: > better stubs for VerLanguageNameA/W (untested) > Modified: trunk/reactos/lib/kernel32/misc/stubs.c > > ------------------------------------------------------------------------ > *Modified: trunk/reactos/lib/kernel32/misc/stubs.c* > --- trunk/reactos/lib/kernel32/misc/stubs.c 2005-12-11 23:53:23 UTC (rev 20094) > +++ trunk/reactos/lib/kernel32/misc/stubs.c 2005-12-12 00:06:38 UTC (rev 20095) > @@ -355,7 +355,9 @@ > ) > { > STUB; > > - return 0; > > + szLang = "Language Neutral\0"; > + nSize = sizeof(szLang) * sizeof(CHAR); > + return sizeof(szLang) - 1; > > } > > > @@ -371,7 +373,9 @@ > > ) > { > STUB; > > - return 0; > > + szLang = L"Language Neutral\0"; > + nSize = sizeof(szLang) * sizeof(WCHAR); > + return sizeof(szLang) - 1; > > } > > > This change is wrong. szLang is pointer to a buffer, which will receive a string. The return value must be the number of characters (in VerLanguageNameW). - Hartmut

3 2

RE: [ros-dev] BUGCHK when using FTP
by Ge van Geldorp 11 Dec '05

11 Dec '05

> From: Alex Buell > > I just got the following when trying to ftp to my host > machine from ReactOS running in VMware. Are there any > documentation out there that can help me make sense of what's > happening below? Thanks. > > hal/halx86/generic/irql.c:272 CurrentIrql 2 NewIrql 1 > KeBugCheck at hal/halx86/generic/irql.c:273 Yes, this happens with a lot of networking programs at the moment. Art is working on it. GvG

1 0

Re: [ros-dev] zebasoftis - main.cpl
by Sebastian Gasiorek 11 Dec '05

11 Dec '05

2005/12/11, Alex Buell <alex.buell(a)munted.org.uk>: > > The patch that I issued for main.cpl DOES work - if you call control.exe > directly and select either the keyboard and mouse applets you'll notice > the patch works. > > Care to explain why you think the patch I sent in doesn't work? > sorry, that's true.

1 0

screensavers
by Kenneth Armstrong 11 Dec '05

11 Dec '05

I know that this is fluff, but I would like to contribute a good, honest attempt at making a screensaver program for ReactOS. Basically, what I am looking for is how is the API set up for ReactOS to write programs for it? I am familiar with writing programs for Windows, and I know the basic ins and outs of making a screensaver for Windows (including it's registry settings), however there is some API specific code that I need in order to give this a shot. Do you guys have a reference of some kind as to what API functions, constants, etc. that you have implemented in ReactOS that mirror those of Windows? Thanks in advance, and if there isn't enough in ReactOS yet for me to try this out yet, then I'll try to help on something else that I would be capable of. And I must say, and I'm not trying to kiss ass here, but I really appreciate what you guys are working at here. Keep it up. Kenneth Armstrong

6 6

Usage of RtlAllocateHeap
by M Bealby 11 Dec '05

11 Dec '05

Hi, First of all I would like to introduce myself. My name is Martin and I am currently attempting to go through and audit the ReactOS source code for security vulnerabilities. I've been keeping an eye on the project for about a year now and I think as development is now rapidly increasing, security must take more and more of a priority. I started with the kernel32 library on Friday (9th) and have found a number of possible security vulnerabilies. These have been filed with bugzilla and i'm very impressed with the rate that these were fixed. So well done on that count! However, after submitting bugs #1102 and #1103 (now fixed by BrandonTurner) it became apparent that incorrect usage of the RtlAllocateHeap function (and its alias HeapAlloc) is quite common. It may return NULL if memory cannot be allocated and in some parts of the code this is not checked. This would lead to a segmentation fault on reading / writing. Through some judicious use of grep I went through the source code and extracted calls to this function with their context. After going through each one and investigating it I have now found another twenty occurances of the same bug (This is just in the kernel32 library). I am writing this to let all developers know that they must check their return values. Errors can exist, resources may be starved and the call may fail. Make sure your code can cope with this. Finally, as I am fairly new to bugzilla, should I submit each of these twenty bugs individually or should I submit them all as one bug? Cheers, Martin

4 4

Re: [ros-svn] [gvg] 20062: Files to create Mozilla Control installer with correct DLL
by David Hinz 11 Dec '05

11 Dec '05

Can't we include Mozilla Control in ReactOS? So that we build it with our ROS Build Environment or whatever is used to compile ReactOS, put it on bootcd and install it with ReactOS? Greets, David Hinz gvg(a)svn.reactos.com schrieb: > Files to create Mozilla Control installer with correct DLL > > > > Added files: > trunk/tools/ > trunk/tools/MozillaControl/ > trunk/tools/MozillaControl/README.txt > trunk/tools/MozillaControl/control-ros.nsi > trunk/tools/MozillaControl/files.nsh > trunk/tools/MozillaControl/local.nsh > trunk/tools/MozillaControl/redist/ > > _______________________________________________ > Ros-svn mailing list > Ros-svn(a)reactos.org > http://www.reactos.org/mailman/listinfo/ros-svn >

6 10

RE: [ros-svn] [gvg] 20062: Files to create Mozilla Control installerwith correct DLL
by Ge van Geldorp 11 Dec '05

11 Dec '05

> From: gvg(a)svn.reactos.com > > Files to create Mozilla Control installer with correct DLL I've created a "fixed" version of the Mozilla Control installer which includes the correct MSVCP60.DLL and put it in our SourceForge download area. shdocvw.dll will now download/install that fixed version. GvG

1 0

RE: [ros-diffs] [arty] 20055: A little library for making it easier toget to PASSIVE_LEVEL. Just contains
by Casper Hornstrup 11 Dec '05

11 Dec '05

We don't have the REVISIONS section anymore and a copyright notice is missing. Casper _____ From: ros-diffs-bounces(a)reactos.org [mailto:ros-diffs-bounces@reactos.org] On Behalf Of arty(a)svn.reactos.com Sent: 11. december 2005 09:26 To: ros-diffs(a)reactos.com Subject: [ros-diffs] [arty] 20055: A little library for making it easier toget to PASSIVE_LEVEL. Just contains _____ Added: trunk/reactos/drivers/lib/chew/workqueue.c --- trunk/reactos/drivers/lib/chew/workqueue.c 2005-12-11 08:11:21 UTC (rev 20054) +++ trunk/reactos/drivers/lib/chew/workqueue.c 2005-12-11 08:26:16 UTC (rev 20055) @@ -0,0 +1,101 @@ +/* + * COPYRIGHT: See COPYING in the top level directory + * PROJECT: ReactOS TCP/IP protocol driver + * FILE: tcpip/main.c + * PURPOSE: Common Highlevel Executive Worker + * PROGRAMMERS: Art Yerkes + * REVISIONS: + * CSH 10/12-2005 Created + */

1 0

Boch 2.2.1 keyboard buffer overflow with React OS 0.2.8
by Jerry 11 Dec '05

11 Dec '05

I tried to run both the live ISO and the intstall ISO (reactos 0.2.8) in bochs 2.2.1 and I got a keyboard buffer overflow. I don't know what is wrong. Here is apart of the Bochs core dump: 00117791507e[KBD ] keyboard disabled & send of byte f2 to kbd 00117791507i[KBD ] identify keyboard command received 00118580248e[KBD ] keyboard disabled & send of byte f2 to kbd 00118580248i[KBD ] identify keyboard command received 00119368173e[KBD ] keyboard disabled & send of byte f2 to kbd 00119368173i[KBD ] identify keyboard command received 00120156914e[KBD ] keyboard disabled & send of byte f2 to kbd 00120156914i[KBD ] identify keyboard command received 00120946888e[KBD ] keyboard disabled & send of byte f2 to kbd 00120946888i[KBD ] identify keyboard command received 00121734813e[KBD ] keyboard disabled & send of byte f2 to kbd 00121734813i[KBD ] identify keyboard command received 00121734813i[KBD ] internal keyboard buffer full, ignoring scancode.(ab) 00121734813i[KBD ] internal keyboard buffer full, ignoring scancode.(41) 00122523554e[KBD ] keyboard disabled & send of byte f2 to kbd 00122523554i[KBD ] identify keyboard command received 00122523554i[KBD ] internal keyboard buffer full, ignoring scancode.(fa) 00122523554i[KBD ] internal keyboard buffer full, ignoring scancode.(ab) 00122523554i[KBD ] internal keyboard buffer full, ignoring scancode.(41) 00123313528e[KBD ] keyboard disabled & send of byte f2 to kbd 00123313528i[KBD ] identify keyboard command received 00123313528i[KBD ] internal keyboard buffer full, ignoring scancode.(fa) 00123313528i[KBD ] internal keyboard buffer full, ignoring scancode.(ab) 00123313528i[KBD ] internal keyboard buffer full, ignoring scancode.(41) 00124101453e[KBD ] keyboard disabled & send of byte f2 to kbd 00124101453i[KBD ] identify keyboard command received 00124101453i[KBD ] internal keyboard buffer full, ignoring scancode.(fa) 00124101453i[KBD ] internal keyboard buffer full, ignoring scancode.(ab) 00124101453i[KBD ] internal keyboard buffer full, ignoring scancode.(41) 00124891427e[KBD ] keyboard disabled & send of byte f2 to kbd 00124891427i[KBD ] identify keyboard command received 00124891427i[KBD ] internal keyboard buffer full, ignoring scancode.(fa) 00124891427i[KBD ] internal keyboard buffer full, ignoring scancode.(ab) 00124891427i[KBD ] internal keyboard buffer full, ignoring scancode.(41) 00125680168e[KBD ] keyboard disabled & send of byte f2 to kbd 00125680168i[KBD ] identify keyboard command received 00125680168i[KBD ] internal keyboard buffer full, ignoring scancode.(fa) 00125680168i[KBD ] internal keyboard buffer full, ignoring scancode.(ab) 00125680168i[KBD ] internal keyboard buffer full, ignoring scancode.(41) 00126470143e[KBD ] keyboard disabled & send of byte ed to kbd 00126470143p[KBD ] >>PANIC<< internal keyboard buffer full (imm)

2 2

RE: [gvg] 20024: Work around lack of MSG_PEEK
by Ge van Geldorp 10 Dec '05

10 Dec '05

With r20024 I can get ibrowser to actually download the Mozilla webbrowser control. It usually takes a few tries, often the download hangs halfway through. I have the feeling that it helps if you move the mouse constantly during download, but that could just be my imagination. To install the control, you will need a copy of MSVCP60.DLL, which the author forgot to include in the install image (Wine has the same problem). So first copy MSVCP60.DLL from your Windows installation to \ReactOS\System32, then start ibrowser, download the control and install it. After that ibrowser (and the "Web" button in ROSExplorer) becomes functional. GvG

4 5

Industry support
by David Hinz 10 Dec '05

10 Dec '05

When I first throw in the idea, that we could try to get some big companys supporting us, I was amazed by the huge response. A lot of people seem to be very interested in this, but after some days, I noticed that there are nearly no devs who replied to my mail, or the numerous replies on it. So what I'm asking for is how the devs and especially our PC Steven Edwards think about asking some companys like IBM, Intel, AMD, nVIDIA, ATI, Dell,... to support our project. There are a lot of ways, they could support us, either by money, or by developers, or by knowledge/documentations. Every of the mentioned companys would be able to support us, but I think the only person who has the right to ask any of them is our PC, or maybe somebody he authorized to do so. I'm waiting for your replies. Greets, David Hinz BTW, the mail I mentioned above is http://www.reactos.org/archives/public/ros-dev/2005-December/006645.html

5 7

Re: [ros-svn] [gvg] 20026: reactos.org is the preferred name these days
by TwoTailedFox 10 Dec '05

10 Dec '05

Does this fix the reference to 'reactos.com' with the 'ver' command, in the Command Interpreter? On 12/9/05, gvg(a)svn.reactos.com <gvg(a)svn.reactos.com> wrote: > reactos.org is the preferred name these days > > > > Updated files: > trunk/reactos/subsys/system/explorer/shell/mainframe.cpp > > _______________________________________________ > Ros-svn mailing list > Ros-svn(a)reactos.org > http://www.reactos.org/mailman/listinfo/ros-svn > -- "I had a handle on life, but then it broke"

3 2

Compilation error
by David Hinz 09 Dec '05

09 Dec '05

When I try to compile ReactOS on Windows, I get the following error: ./subsys/win32k/objects/path.c: In function `PATH_PathToRegion': ./subsys/win32k/objects/path.c:1024: warning: 'hrgn' might be used uninitialized in this function mingw32-make[1]: *** [obj-i386\subsys\win32k\objects.o] Error 1 Important: I'm compiling with optimisations for amd64 and dbg and kdbg=0. Revision is 20025 If I'm not the only one with these problems, I hope you get that fixed soon, I don't think this is because if my platform optimizations. Greets, David Hinz

1 0

process token problem
by Hartmut Birr 09 Dec '05

09 Dec '05

Hi, after compiling ros on ros, I see over 45000 memory blocks with the tags TOKd, TOKp, TOKu and TOKp. It seems, something is wrong with the referencing/dereferencing of tokens. I've add some debug code in SeDeassignPrimaryToken (only called by PspDeleteProcess), which prints the ref count of the token object. It is always greater than 1. The process token is never deleted. - Hartmut

1 0

[Vote] Top-level source header
by Casper Hornstrup 09 Dec '05

09 Dec '05

The discussion is located here: http://www.reactos.org/archives/public/ros-dev/2005-October/005671.html I will create a vote with the options below. Proposal A from Ged Murphy: /* * ReactOS <place holder> * Copyright (C) 2005 ReactOS Foundation * * LICENCE: <place holder> * PROJECT: <place holder> * FILE: <place holder> * PURPOSE: <place holder> * PROGRAMMERS: <place holder> * REVISIONS: * <place holder> * */ Proposal B from Alex Ionescu: /* * PROJECT: ReactOS Kernel * LICENSE: GPL - See COPYING in the top level directory * FILE: ntoskrnl/ex/mutant.c * PURPOSE: section of the kernel * PROGRAMMERS: Alex Ionescu (alex at reactos.org) * David Welch (welch at cwcom.net) */ Proposal C from Casper Hornstrup/Gé van Geldorp: /* * PROJECT: ReactOS Kernel * LICENSE: GPL - See COPYING in the top level directory * COPYRIGHT: Copyright 2004-2005 John Doe * Copyright 2005 Jane Doe */

12 19

Feature Request
by Rick Langschultz 09 Dec '05

09 Dec '05

XML is actively becoming part of technology and programming. Every major development company has embraced some form of XML in one product or another. I was wondering if ReactOS would be interested in developing some form of application to handle XML-based applications. These applications would be written in XML and bundled in a ZIP file much like the ODF formats that OpenOffice 2.0 is using. XML applications would be allowed to communicate with some processing application protocols and functions. I think something like this would be a great feature that would quickly allow novice programmers to quickly develop applications for ReactOS and share them on the website. Think of it, no compilation time. That would be great. I will try to write a proof-of-concept application for Windows XP and 2000 for trial and testing. My main question is: If something like this is wanted/needed/or if ReactOS members finds interesting would ReactOS think about supporting it in the first production release. Which is still far off, I would imagine.

7 8

RE: [ros-dev] Top-level source header
by Murphy, Ged (Bolton) 09 Dec '05

09 Dec '05

Ge van Geldorp wrote > So in our case something like > > /* > * COPYRIGHT: Copyright 2005 Alex Ionescu (alex(a)reactos.org) > * Copyright 2005 Filip Navara (navaraf(a)reactos.org) > */ I agree with this. We don't have to do another vote though, do we. Can we just agree to this one over the mailing list please? ************************************************************************ The information contained in this message or any of its attachments is confidential and is intended for the exclusive use of the addressee. The information may also be legally privileged. The views expressed may not be company policy, but the personal views of the originator. If you are not the addressee, any disclosure, reproduction, distribution or other dissemination or use of this communication is strictly prohibited. If you have received this message in error, please contact postmaster(a)exideuk.co.uk <mailto:postmaster@exideuk.co.uk> and then delete this message. Exide Technologies is an industrial and transportation battery producer and recycler with operations in 89 countries. Further information can be found at www.exide.com

4 3

0.2.9 changelog
by Murphy, Ged (Bolton) 09 Dec '05

09 Dec '05

The changelog has been created. You can add your changes here : http://www.reactos.org/wiki/index.php/ChangeLog-0.2.9 <http://www.reactos.org/wiki/index.php/ChangeLog-0.2.9> ************************************************************************ The information contained in this message or any of its attachments is confidential and is intended for the exclusive use of the addressee. The information may also be legally privileged. The views expressed may not be company policy, but the personal views of the originator. If you are not the addressee, any disclosure, reproduction, distribution or other dissemination or use of this communication is strictly prohibited. If you have received this message in error, please contact postmaster(a)exideuk.co.uk <mailto:postmaster@exideuk.co.uk> and then delete this message. Exide Technologies is an industrial and transportation battery producer and recycler with operations in 89 countries. Further information can be found at www.exide.com

1 0

RE: [ros-svn] [sedwards] 19980: import libxml2-2.6.20. I did not botherwith a vendor import as I don't care much about trackingchanges and more recent versions don't even build on mingw
by Casper Hornstrup 09 Dec '05

09 Dec '05

Please do it anyway since others may care in the future (for instance for security fixes) and replacing directories in Subversion is troublesome and messes up history (log, blame et al.). Casper > -----Original Message----- > From: ros-svn-bounces(a)reactos.org [mailto:ros-svn-bounces@reactos.org] On Behalf Of > sedwards(a)svn.reactos.com > Sent: 8. december 2005 23:21 > To: ros-svn(a)reactos.com > Subject: [ros-svn] [sedwards] 19980: import libxml2-2.6.20. I did not botherwith a vendor import as > I don't care much about trackingchanges and more recent versions don't even build on mingw > > import libxml2-2.6.20. I did not bother with a vendor import as I don't care much about tracking > changes and more recent versions don't even build on mingw

1 0

RE: [ros-dev] Re: [ros-svn] [sedwards] 19980: import libxml2-2.6. 20. I did not bother with a vendor import as I don't care much about trac king changes and more recent versions don't even build on mingw
by Murphy, Ged (Bolton) 09 Dec '05

09 Dec '05

Christoph von Wittich wrote > Office 2003 > > - - Christoph > > > Thomas Weidenmueller schrieb: > > sedwards(a)svn.reactos.com wrote: > > > >>import libxml2-2.6.20. I did not bother with a vendor > import as I don't care much about tracking changes and more > recent versions don't even build on mingw > > > > > > What do we need it for? It takes several minutes to > download just that > > directory. > > > > - Thomas Can we not trim it down? I believe a lot of it consists of test cases which could be removed, or go in rosapps. ************************************************************************ The information contained in this message or any of its attachments is confidential and is intended for the exclusive use of the addressee. The information may also be legally privileged. The views expressed may not be company policy, but the personal views of the originator. If you are not the addressee, any disclosure, reproduction, distribution or other dissemination or use of this communication is strictly prohibited. If you have received this message in error, please contact postmaster(a)exideuk.co.uk <mailto:postmaster@exideuk.co.uk> and then delete this message. Exide Technologies is an industrial and transportation battery producer and recycler with operations in 89 countries. Further information can be found at www.exide.com

2 1

Re: [ros-svn] [sedwards] 19980: import libxml2-2.6.20. I did not bother with a vendor import as I don't care much about tracking changes and more recent versions don't even build on mingw
by Thomas Weidenmueller 09 Dec '05

09 Dec '05

sedwards(a)svn.reactos.com wrote: > import libxml2-2.6.20. I did not bother with a vendor import as I don't care much about tracking changes and more recent versions don't even build on mingw What do we need it for? It takes several minutes to download just that directory. - Thomas

2 1

Searching for WinLogon, Gina, LSA server, MSV or SAM developers?
by Jasper Huzen 08 Dec '05

08 Dec '05

Dear ReactOS programmers, We are working on login support in ReactOS like Windows NT 4.0 Login (as educational project). Would you contact me/us if you have been worked in the past on WinLogon,Gina, LSA server, MSV1_0 or SAM? We did the last 2.5 month a lot of research to this parts of the system. We have found a lot of information but we need more. Maybe you can give us more information if you have been worked on that parts in the past. Contact me at icq: uin# 51588796 or msn: jhuzen(a)hotmail.com Jasper Huzen

1 0

Re: [ros-dev] Unhandled Exception in kernel32 ReadFile file\rw.c line 233
by Filip Navara 08 Dec '05

08 Dec '05

2 1

Memory Leak, Ros on Ros Building
by James Tabor 08 Dec '05

08 Dec '05

Hi All! In Revision: 19942: K and DBG == 1, (KERNEL32:./lib/kernel32/mem/global.c:412) Memory Load: 23% (KERNEL32:./lib/kernel32/mem/global.c:412) Memory Load: 23% (KERNEL32:./lib/kernel32/mem/global.c:412) Memory Load: 23% (KERNEL32:./lib/kernel32/mem/global.c:412) Memory Load: 23% (MSVCRT:lib/crt/io/open.c:100) not valid fd 0, g_fdend 5, fdinfo 7802f2e0, bucke t 7802f2e0, fdflags 0 (MSVCRT:lib/crt/io/open.c:702) _setmode: inval fd (0) (./ntoskrnl/mm/rpoolmgr.h:822) Trying to allocate 8192 bytes from paged pool - n othing suitable found, returning NULL (lib/rtl/exception.c:75) RtlRaiseStatus(Status 0xc0000005) (./ntoskrnl/mm/rpoolmgr.h:822) Trying to allocate 20160 bytes from paged pool - nothing suitable found, returning NULL Normally it should start at 5 - 7% an end at 16 - 18% even after I start over again. Should there be memory tab text in the debug print outs? Thanks, James

1 1

Unhandled Exception in kernel32 ReadFile file\rw.c line 233
by Steven Edwards 08 Dec '05

08 Dec '05

Hi, I have a 100% reproducible problem at the end of the Office2000 install on the trunk + local patches. I am hitting a usermode exception in ReadFile on line 233. The offending code is here if (NT_SUCCESS(Status)) { /* lpNumberOfBytesRead must not be NULL here, in fact Win doesn't check that case either and crashes (only after the operation completed) */ *lpNumberOfBytesRead = Iosb.Information; } Art suggested using ProbeForWrite to handle the problem. Can someone point me to a example of how to handle this except or even better would someone be willing to look at implementing the check for me? =) Thanks -- Steven Edwards - ReactOS and Wine developer "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

2 1

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev