- Ros-dev - ReactOS.org

Re: [ros-svn] [ion] 18183: - KeRundownThread:
by Witukind 02 Oct '05

02 Oct '05

On Sat, 1 Oct 2005 09:50:08 +0200 <ion(a)svn.reactos.com> wrote: >> which means the mutant has been already freed). omfg! we're all going to die!!! ;)

1 0

Re: [ros-svn] [ion] 18202: - Small semaphore code simplification/optimization.
by Hartmut Birr 02 Oct '05

02 Oct '05

ion(a)svn.reactos.com wrote: >- Small semaphore code simplification/optimization. > > >Updated files: >trunk/reactos/ntoskrnl/ke/kthread.c >trunk/reactos/ntoskrnl/ke/sem.c > >_______________________________________________ >Ros-svn mailing list >Ros-svn(a)reactos.org >http://www.reactos.org/mailman/listinfo/ros-svn > > > Have you tried to compile sem.c before you did commit? - Hartmut

2 1

Plug and Play status - Device installation
by Hervé Poussineau 02 Oct '05

02 Oct '05

Hello, Since some weeks/months, I've done some work in setupapi.dll. I'm now able to install devices using provided .inf files, ie copy needed files and create registry entries. Syntax: rundll32.exe newdev.dll,DevInstall [InstanceID] where InstanceID is something like ACPI\PNP0501\1 or PCI\VEN_8086&DEV_7112&SUBSYS_00000000&REV_01\3&61aaa01&0&3A However, I've still some bugs and some missing features: - OpenSCManagerW freezes ReactOS [1] - CreateServiceW is unimplemented [2] - Service image path provided to CreateServiceW looks like "C:\ReactOS\System32\drivers\driver.sys", instead of "System32\drivers\driver.sys" [3] - You have no way to use a .inf file which is not in ReactOS\Inf directory [4] - Files to be copied are always searched in ReactOS\Inf directory (so they can't be found) [5] - Files to be copied need to be already decompressed (ie not in a .cab file) [6] - A reboot is needed before being able to use the newly installed device [7] - Having multiple times a same device is not supported, if the bus driver can't provide a unique DeviceID [8] - Last, but not least, device installation is not started automatically when a new device is found/plugged [9] [1] See bug #826: http://www.reactos.org/bugzilla/show_bug.cgi?id=826 [2] In lib/advapi32/service/scm.c. It needs to call umpnpmgr.exe by RPC, as in OpenServiceW implementation [3] In lib/setupapi/dirid.c: the value returned by create_system_dirid() is always a full path [4] It's due to missing functionnality in newdev.dll (lib/newdev/*), which should ask the user when no driver is found [5] In lib/setupapi/queue.c. If a file can't be found, SetupCommitFileQueueW should ask the user where to find the file [6] We need to support the [SourceDisksNames] section in .inf files [7] Maybe calling IoInvalidateDeviceRelations() at the end of SetupDiInstallDevice (lib/setupapi/devinst.c) would be enough [8] We need to generate a ParentIdPrefix entry in registry in some(?) cases [9] I suppose it should be initiated by umpnpmgr.exe, when it sees a device for the first time Hervé PS: If someone is interested to work on one of this parts, please answer this email

2 1

Re: [ros-diffs] [weiden] 18213: minor changes (mostly formatting)
by Hartmut Birr 02 Oct '05

02 Oct '05

weiden(a)svn.reactos.com wrote: >minor changes (mostly formatting) > >Modified: trunk/reactos/lib/hid/hid.c >Modified: trunk/reactos/lib/shellext/slayer/slayer.c > > > ------------------------------------------------------------------------ > *Modified: trunk/reactos/lib/hid/hid.c* > >--- trunk/reactos/lib/hid/hid.c 2005-10-02 12:27:54 UTC (rev 18212) >+++ trunk/reactos/lib/hid/hid.c 2005-10-02 12:46:49 UTC (rev 18213) >@@ -368,8 +368,8 @@ > > HidD_Hello(OUT PCHAR Buffer, > IN ULONG BufferLength) > { > > >- const PCHAR HelloString = "Hello\n"; >- ULONG StrSize = (lstrlenA(HelloString) + 1) * sizeof(CHAR); > > >+ const CHAR HelloString[] = "Hello\n"; >+ ULONG StrSize = sizeof(HelloString) + sizeof(HelloString[0]); > > > > if(BufferLength > 0) > { > > > ------------------------------------------------------------------------ Hi, sizeof(HelloString) does already contain the terminating NULL. - Hartmut

2 1

Re: [ros-svn] [ion] 18201: - Add RtlSetProcessCritical
by Hartmut Birr 02 Oct '05

02 Oct '05

ion(a)svn.reactos.com wrote: >- Add RtlSetProcessCritical >- Some fixes. > > >Updated files: >trunk/reactos/include/ndk/ketypes.h >trunk/reactos/include/ndk/pstypes.h >trunk/reactos/include/ndk/rtlfuncs.h >trunk/reactos/include/ndk/rtltypes.h >trunk/reactos/include/ndk/umtypes.h > >_______________________________________________ >Ros-svn mailing list >Ros-svn(a)reactos.org >http://www.reactos.org/mailman/listinfo/ros-svn > > > Hi, the header changes breaks compiling for me: gcc -c boot\freeldr\freeldr\cache\blocklist.c -o .\up\obj-i386\boot\freeldr\freeldr\cache\blocklist.o -nostdlib -ffreestanding -fno-builtin -fno-inline -fno-zero-initialized-in-bss -Os -Iboot\freeldr\freeldr\include -Iboot\freeldr\freeldr\cache -Intoskrnl\include -D__USE_W32API -DDEBUG -Iinclude -Iinclude\reactos -Iinclude\libs -Iinclude\drivers -Iinclude\subsys -Iw32api\include -Iw32api\include\ddk -D_M_IX86 -DDBG -Wall -Os -Wno-strict-aliasing -ftracer -momit-leaf-frame-pointer -mpreferred-stack-boundary=2 -Wpointer-arith -g -pipe In file included from include/ndk/psfuncs.h:13, from include/ndk/ntndk.h:34, from boot/freeldr/freeldr/include/freeldr.h:24, from boot\freeldr\freeldr\cache\blocklist.c:21: include/ndk/pstypes.h:627: error: syntax error before 'PHANDLE_TABLE' include/ndk/pstypes.h:627: warning: no semicolon at end of struct or union include/ndk/pstypes.h:628: warning: type defaults to 'int' in declaration of 'Token' include/ndk/pstypes.h:628: warning: data definition has no type or storage class include/ndk/pstypes.h:655: warning: unnamed struct/union that defines no instances include/ndk/pstypes.h:668: error: syntax error before 'PrefetchTrace' include/ndk/pstypes.h:668: warning: type defaults to 'int' in declaration of 'PrefetchTrace' include/ndk/pstypes.h:668: warning: data definition has no type or storage class include/ndk/pstypes.h:718: warning: unnamed struct/union that defines no instances include/ndk/pstypes.h:730: warning: unnamed struct/union that defines no instances include/ndk/pstypes.h:745: error: syntax error before '}' token include/ndk/pstypes.h:745: warning: type defaults to 'int' in declaration of 'EPROCESS' include/ndk/pstypes.h:745: warning: data definition has no type or storage class _make: *** [.\up\obj-i386\boot\freeldr\freeldr\cache\blocklist.o] Error 1 - Hartmut

1 0

Re: [ros-svn] [ion] 18118: - Some NDK fixes when compiling with PSDK.
by Emanuele Aliberti 02 Oct '05

02 Oct '05

ion(a)svn.reactos.com wrote: >Deleted files: >trunk/reactos/include/subsys/csr/protocol.h >trunk/reactos/subsys/csr/args.c >trunk/reactos/subsys/csr/csr.h >trunk/reactos/subsys/csr/csrsrv/debug.c >trunk/reactos/subsys/csr/csrsrv/dllmain.c > > Well, a bit unfair deleting header files etc. and leaving the subtree not compilable. My working copy depends on those very files. Disabling compilation of csr also forces me to disable the vms module: not a great loss, but we had only two left: os2 and posix are broken. Keeping the whole modules compilable should be a goal, even if they are minimal subsystems (if ROS is just Win32, well, let's rename it back "FreeWin95"). -- :Emanuele Aliberti

2 2

svn: how do I restore a deleted file?
by Emanuele Aliberti 02 Oct '05

02 Oct '05

How do I restore a file deleted at revision xyz? -- :Emanuele Aliberti

2 2

another macro: OPTHDROFFSET
by vit-ros＠att.net 01 Oct '05

01 Oct '05

Hi, I found the OPTHDROFFSET not very useful. I would rather use something lighter like: (PIMAGE_NT_HEADERS)((PBYTE)a + ((PIMAGE_DOS_HEADER)a)->e_lfanew)) , same as RtlImageNtHeader() May i ask someone with write access to remove it?

2 1

Website
by Rick Langschultz 01 Oct '05

01 Oct '05

Hey everyone, The website looks great. Props to the creators and website admin... Rick Langschultz rlangschultz(a)cox.net (Home) rlangschultz(a)ellemaespa.com (Work) rlangschultz(a)email.uophx.edu (School)

8 8

Re: [ros-svn] [ea] 18180: Fix build.
by Thomas Weidenmueller 30 Sep '05

30 Sep '05

ea(a)svn.reactos.com wrote: > Fix build. Oops, sorry about that... Thanks for fixing it. -Thomas

1 0

RE: Ros-dev Digest, Vol 13, Issue 65
by Lucio Diaz 30 Sep '05

30 Sep '05

I want to make a spanish translation of the web page...once i finish, how does i submit it?. Second question: I can not LOG!, i find no sense to the code validator, what the hell imput is it waiting? The code validator is NOT human readable unless you explain how does it work!. Best regards, Lucio Diaz-Flores. ______________________________________________ Renovamos el Correo Yahoo! Nuevos servicios, más seguridad http://correo.yahoo.es

2 1

RE: [ros-dev] Site is down on release day! YAY!
by Murphy, Ged (Bolton) 30 Sep '05

30 Sep '05

Is it just my proxy cache, or does every page load except the homepage? -----Original Message----- From: Ge van Geldorp [mailto:gvg@reactos.org] Sent: 30 September 2005 09:18 To: 'ReactOS Development List' Subject: RE: [ros-dev] Site is down on release day! YAY! > From: Alex Ionescu > > The site has been slow day, some pages not loading, the > screenshots especially (confirmed by over 5 people). Now, as > I write this, it's totally dead for myself, Steven, and some > other users in the channel. It's an unfortunate coincidence. There was a problem in the configuration of the firewall between the internet and the university network to which www.reactos.org is connected. It took the network people a while to track this down and fix it. The slowness of the site was caused by the firewall problem, not by the switch to the new system. The site is quite snappy for me now. Gé van Geldorp. ************************************************************************ The information contained in this message or any of its attachments is confidential and is intended for the exclusive use of the addressee. The information may also be legally privileged. The views expressed may not be company policy, but the personal views of the originator. If you are not the addressee, any disclosure, reproduction, distribution or other dissemination or use of this communication is strictly prohibited. If you have received this message in error, please contact postmaster(a)exideuk.co.uk <mailto:postmaster@exideuk.co.uk> and then delete this message. Exide Technologies is an industrial and transportation battery producer and recycler with operations in 89 countries. Further information can be found at www.exide.com

1 0

Site is down on release day! YAY!
by Alex Ionescu 30 Sep '05

30 Sep '05

Hi, The site has been slow day, some pages not loading, the screenshots especially (confirmed by over 5 people). Now, as I write this, it's totally dead for myself, Steven, and some other users in the channel. I thought the new page was supposed to make things faster? Best regards, Alex Ionescu

2 1

RE: Ros-dev Digest, Vol 13, Issue 64
by Lucio Diaz 29 Sep '05

29 Sep '05

Sorry, i realized my old acount was transfered, that is the motive i could not recreate it. Best regards, Lucio Diaz-Flores. ______________________________________________ Renovamos el Correo Yahoo! Nuevos servicios, más seguridad http://correo.yahoo.es

1 0

installation methods?
by Bernd Blaauw 29 Sep '05

29 Sep '05

Which are current installation methods for ReactOS? so far only an ISO it seems, which for non-emulators requires to write/burn a disk, turn it into a drive that can read burned media (not all cdrom drives can do this), and also requires El-Torito support from the system BIOS. That last part might be worked around, if not supported by the system, by using Smart Boot Manager, which provides its own Eltorito stack. Questions: -why do an installed ROS, a ROS LiveCD and a ROS installCD all have a directory (root_of_drive)\REACTOS ? This makes it complex to have all 3 on 1 drive. WindowsXP/BartPE can use C:\WINDOWS (installed), C:\I386 (setup) , C:\MINIPE (LiveCD) for example -Is it possible to copy the contents of the install CD to a 2nd fat partition, and setup FreeLDR (on diskette for example) to boot that directory? some line like: multi(0)disk(0)rdisk(0)\partition(2)\ReactOS="Install ReactOS from D:\REACTOS to C:\REACTOS" if the ReactOS install CD used any other directory name than a hardcoded '\REACTOS', then 1 partition would have been enough. multi(0)disk(0)rdisk(0)\partition(1)\ROSsetup="Install ReactOS from C:\ROSSETUP to C:\REACTOS" -How do I obtain FreeLDR, other than "installing ReactOS in an emulator first and selecting to install bootloader to A:" ? Can't find the old DOS INSTALL.COM/EXE file along with both FREELDR.SYS/INI -Does installing ReactOS from harddisk actually work? At least it prevents users having to provide controller/cdrom drivers (be it DOS or Win32 drivers). -Anyone tried ROS LiveCD + QEMU (without configuring a harddisk!) ? doesn't bootup, might be a QEMU issue. Vmware + LiveCD works, though C was assigned which isn't nice in case you decide to partition in a GUI Diskmanagement subsystem. In best case, FreeLDR or a minisetup would be able to handle a (zipped) ISO by extracting the files inside it to a temporary location, and start setup from there. Is there any premade FreeLDR diskette image available somewhere? Bernd

1 0

Re: [ros-svn] [gdalsnes] 18113: -reorder InsertXscendingOrder macro argument order and update uses
by Alex Ionescu 29 Sep '05

29 Sep '05

gdalsnes(a)svn.reactos.com wrote: >-reorder InsertXscendingOrder macro argument order and update uses >-start to macrofy list enums in ntoskrnl using LIST_FOR_EACH macros >-use IsListEmpty some places instead of manual coding >-profile.c:KeStartProfile() zero correct buffer in (and not the NULL ptr;-) >-improve LIST_FOR_EACH macros so that the iterator is set to NULL at end of enum >-kthread.c:KiServiceCheck() set the shadowtable before calling the win32k proc/thread init funcs >-apc.c:KiInsertQueueApc() insert special apcs in correct fifo order >-apc.c:KeFlushQueueApc() simplify >-timer.c:KiExpireTimers() calling RemoveEntryList on a possibly empty list is not ok > > >Updated files: >trunk/reactos/include/reactos/helper.h >trunk/reactos/ntoskrnl/io/device.c >trunk/reactos/ntoskrnl/io/driver.c >trunk/reactos/ntoskrnl/io/file.c >trunk/reactos/ntoskrnl/io/fs.c >trunk/reactos/ntoskrnl/io/irp.c >trunk/reactos/ntoskrnl/io/pnpnotify.c >trunk/reactos/ntoskrnl/io/pnproot.c >trunk/reactos/ntoskrnl/ke/apc.c >trunk/reactos/ntoskrnl/ke/bug.c >trunk/reactos/ntoskrnl/ke/kqueue.c >trunk/reactos/ntoskrnl/ke/kthread.c >trunk/reactos/ntoskrnl/ke/profile.c >trunk/reactos/ntoskrnl/ke/queue.c >trunk/reactos/ntoskrnl/ke/timer.c >trunk/reactos/subsys/system/usetup/partlist.c >trunk/reactos/subsys/win32k/ntuser/class.c > >__________________________ > Hi, I'm going to have to voice my extreme outcry against this patch. It is replacing clear and easily debuggable code by non-standard macros which are impossible to debug. It is also going to create problems when people which are not used to them (such as myself): 1) Have no idea what some LIST_FOR_EACH_SAFE thing is doing vs LIST_FOR_EACH vs InsertListLifoSafeMaybeLoopOrWhoKnowsWhat 2) Will never code using these macros, and thus the source will become full of both methods, which is totally ugly. Sometimes, especially in kernel code, it's much better to have an expanded logic then to use a macro. I wrote a great majority of the code that has just been, imho, pollutted with these macros, and I don't appreciate for someone to barge in and change my code for some macro that I don't understand, nor wish to, because it only causes problems. I take great care of the code I write and "own" it (in the programming term) so that if a bug in it arises, I can quickly identify it and be held responsible for it. The addition of these macros hinders that effort. I don't mind someone using them inside his or her own code. I just mind their usage in ntoskrnl, and even more so when it overwrites the clean, clear code that I've written and am used to debugging. Best regards, Alex Ionescu

18 64

IRC Logs
by Rick Langschultz 29 Sep '05

29 Sep '05

Would it be possible to post IRC logs in html format on the website for searching and information? Rick Langschultz rlangschultz(a)cox.net (Home) rlangschultz(a)ellemaespa.com (Work) rlangschultz(a)email.uophx.edu (School)

6 7

software purchase for web forums
by Steven Edwards 29 Sep '05

29 Sep '05

Hello, The web teams has requested that we purchase a software package to handle our forum discussion on the website. The purchase cost is $160 http://www.vbulletin.com/ We have about $90 in paypal donated for misc needs and this seems like a good buy if we really need it. After our hack of the website this may be a good thing. I would like to have a vote up or down about the purchase. If the majority of the project supports this then once we reach the required amount we will purchase. Please reply to me in private, the foundation or general lists only. Do not follow this thread on ros-dev. Thanks Steven __________________________________ Yahoo! Mail - PC Magazine Editors' Choice 2005 http://mail.yahoo.com

1 0

RE: [ros-dev] IRC Logs
by Murphy, Ged (Bolton) 29 Sep '05

29 Sep '05

Royce Mitchell III wrote: > Rick Langschultz wrote: > > > Would it be possible to post IRC logs in html format on the website > > for searching and information? > > Rick Langschultz > > I feel very strongly this would be a bad thing. I was just thinking the same thing. Anyway, #reactos is mainly for arguing, talking garbage and rejoicing cheesecake ..... what can anyone possibly gain from logging that ;) ************************************************************************ The information contained in this message or any of its attachments is confidential and is intended for the exclusive use of the addressee. The information may also be legally privileged. The views expressed may not be company policy, but the personal views of the originator. If you are not the addressee, any disclosure, reproduction, distribution or other dissemination or use of this communication is strictly prohibited. If you have received this message in error, please contact postmaster(a)exideuk.co.uk <mailto:postmaster@exideuk.co.uk> and then delete this message. Exide Technologies is an industrial and transportation battery producer and recycler with operations in 89 countries. Further information can be found at www.exide.com

2 1

Subsystems, how to write one
by crashfourit 29 Sep '05

29 Sep '05

What are the relevent ReactOS API calls for building a dynamicly loadable subsystem? I'm asking this because I can't find the API documentation on the website. (I looks more like the documentation is not yet completed.) Other questions relevent to this: How do I register a new executible file format? I.E. coff. How do I register a new interrupt vector(s). What are the API to control v86 prosses? If y'all want to know what subsystem I want to write, it is DOS. This is because I'm more familar with programing in DOS.

2 2

New website
by Ge van Geldorp 28 Sep '05

28 Sep '05

Thursday afternoon (UTC) the website will be unavailable for some time. We're going to make the switch to the new website design then. At the same time, we're moving to www.reactos.org as the primary name for the website, with www.reactos.com being an alias (you'll be redirected automatically to www.reactos.org if you use the old name). The mailing lists are also going to be moved from reactos.com to reactos.org, so if you have filtering in place please take this into account. Many thanks to Michael Wirth and especially Klemens Friedl who put a lot of effort in the new site. Gé van Geldorp.

1 0

Re: [ros-diffs] [gdalsnes] 18113: -reorder InsertXscendingOrder macro argument order and update uses
by Hartmut Birr 27 Sep '05

27 Sep '05

gdalsnes(a)svn.reactos.com wrote: > *Modified: trunk/reactos/include/reactos/helper.h* > >--- trunk/reactos/include/reactos/helper.h 2005-09-26 22:06:31 UTC (rev 18112) >+++ trunk/reactos/include/reactos/helper.h 2005-09-26 22:57:48 UTC (rev 18113) >@@ -18,17 +18,21 @@ > > #define EXPORTED __declspec(dllexport) > #define IMPORTED __declspec(dllimport) > > > >-/* iterate through the list using a list entry */ > > >+/* iterate through the list using a list entry. >+ * elem is set to NULL if the list is run thru without breaking out or if list is empty. >+ */ > > > #define LIST_FOR_EACH(elem, list, type, field) \ > for ((elem) = CONTAINING_RECORD((list)->Flink, type, field); \ > > >- &(elem)->field != (list); \ > > >+ &(elem)->field != (list) || (elem = NULL); \ > > > (elem) = CONTAINING_RECORD((elem)->field.Flink, type, field)) > > > Hi, IMHO, this is very bad code. You use a macro to hide a 'for' loop, and later in the source you use a 'break', 'continue' or 'goto' statement to leave the loop or to bypass some code. /* Find entry with SortKey greater than or equal to the passed-in SortKey */ LIST_FOR_EACH(ReturnEntry, &DeviceQueue->DeviceListHead, KDEVICE_QUEUE_ENTRY, DeviceListEntry) { /* Check if keys match */ if (ReturnEntry->SortKey >= SortKey) { /* We found it, so just remove it */ RemoveEntryList(&ReturnEntry->DeviceListEntry); break; } } Such a source is simply unreadable. - Hartmut

3 3

Re: [ros-diffs] [navaraf] 18070: Revert r18064 and correctly set the cell size for hash cells.
by Hartmut Birr 26 Sep '05

26 Sep '05

navaraf(a)svn.reactos.com wrote: >Revert r18064 and correctly set the cell size for hash cells. > >Modified: trunk/reactos/ntoskrnl/cm/regfile.c > > > ------------------------------------------------------------------------ > *Modified: trunk/reactos/ntoskrnl/cm/regfile.c* > >--- trunk/reactos/ntoskrnl/cm/regfile.c 2005-09-25 20:46:28 UTC (rev 18069) >+++ trunk/reactos/ntoskrnl/cm/regfile.c 2005-09-25 20:54:40 UTC (rev 18070) >@@ -3033,6 +3033,7 @@ > > else > { > ASSERT(SubKeyCount <= 0xffff); /* should really be USHORT_MAX or similar */ > > >+ NewHashBlock->CellSize = -NewHashSize; > > > NewHashBlock->Id = REG_HASH_TABLE_CELL_ID; > NewHashBlock->HashTableSize = (USHORT)SubKeyCount; > *HashBlock = NewHashBlock; > > Are you sure that this change is correct? I'm not able to install reactos on real hardware. Reactos hangs within CmInitHives at the first boot after the second stage setup. The same boot cd works in qemu. - Hartmut

1 0

Re: [ros-diffs] [ion] 18082: - Fix a bug in CSR Capture APIs
by Thomas Weidenmueller 26 Sep '05

26 Sep '05

ion(a)svn.reactos.com wrote: > + CsrCaptureMessageBuffer(CaptureBuffer, > + NULL, > + Size, > + (PVOID*)&Request.Data.PeekConsoleInputRequest.InputRecord); The last parameter passed to CsrCaptureMessageBuffer in your changes looks horribly wrong. The typecast hides the bug and shouldn't be necessary, the compiler would've warned you that this is most likely wrong. - Thomas

2 2

Re: [ros-diffs] [npwoods] 18056: Lightweight sync with WINE regedit; imported obvious changes such as const correctness, TCHAR string usage etc
by Thomas Weidenmueller 26 Sep '05

26 Sep '05

npwoods(a)svn.reactos.com wrote: > + if (hRootKey == HKEY_DYN_DATA) return _T("HKEY_DYN_DATA"); This key doesn't exist on NT... ;) - Thomas

3 3

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev