- Ros-dev - ReactOS.org

samba tng program compile status
by Luke Kenneth Casson Leighton 10 Sep '05

10 Sep '05

hi, thought people might want to know: rpcclient.exe already was confirmed as working (by elrond) i just successfully compiled and tested smbclient, that works too. rpcclient.exe produces a _beautiful_ blue screen, i fell about when i saw this. elrond has a patch for smbd which removes fork() and i want to try this out and also make the msrpc services do the same thing, that will be fuuun. the sooner someone gets freedce to compile on mingw32 the damn better is all i can say there. i found some example code that uses NamedPipes i intend to add that in at both the client side and the server side and see what breaks, oo that will be fun i've never done nt named pipes programming before. l. -- -- <a href="http://lkcl.net">http://lkcl.net</a> --

1 0

Re: SMSS & LSASS: Service Status
by Luke Kenneth Casson Leighton 10 Sep '05

10 Sep '05

regarding your offer to help with LSASS.... GREAT! because, coincidentally, this is exactly one of the areas required to tie in MSV1_0.DLL which will be a registererer with the LSASS, and MSV1_0.DLL is where all the nt authentication stuff happens. great, great. okay, here's something i found which describes the process, it looks pretty damn good: http://www.coresecurity.com/common/showdoc.php?idx=87&idxseccion=11 now, here's the bit that you _don't_ have to do: you do NOT have to do _any_ of the bits _behind_ "access the sam database". all of that is already written for you - in samba tng. i've had a _brief_ look at the implementation of lsass in reactos, and i believe it to be pretty good. it's just that there are no "registerers" e.g. there is no implementation of MSV1_0.DLL. l. -- -- <a href="http://lkcl.net">http://lkcl.net</a> --

1 0

Can someone send me the MS sound blaster driver example code?
by Andrew "Silver Blade" Greenwood 09 Sep '05

09 Sep '05

Someone sent me this a while back, but I lost it. Basically I believe it was from a MS DDK, and it contained code for MMDRV.DLL and SNDBLST.SYS. At the time I was feeling lazy and just clumsily hacked in whatever I felt like, without any order to what I was doing. I want to have another stab at it, by reviewing the existing code, documenting it for my own understanding, and then writing my own solution. So if someone could send me those files, I'd appreciate it! -Andrew PS: The files in question were NOT obtained from the leaked Windows source code.

1 0

Frequent commits?
by Reuben Perelman 09 Sep '05

09 Sep '05

Lately I've seen a lot of updates to svn. Is it just a lot of work being done, or is there some type of revert war?

3 3

Re: [ros-svn] [hpoussin] 17751: Fix build, by correcting include paths and updating xml files of USB components
by TwoTailedFox 08 Sep '05

08 Sep '05

Corrected, just as I was trying to work out while it wasn't compiling with Mingw ;) On 9/8/05, hpoussin(a)svn.reactos.com <hpoussin(a)svn.reactos.com> wrote: > Fix build, by correcting include paths and updating xml files of USB components > > > Added files: > trunk/reactos/drivers/usb/usbport/usbport.def > > Updated files: > trunk/reactos/drivers/usb/miniport/linux/pci_hal.c > trunk/reactos/drivers/usb/miniport/usbohci/ohci-hcd.c > trunk/reactos/drivers/usb/miniport/usbohci/ohci_main.c > trunk/reactos/drivers/usb/miniport/usbohci/usbohci.xml > trunk/reactos/drivers/usb/miniport/usbuhci/uhci-hcd.c > trunk/reactos/drivers/usb/miniport/usbuhci/uhci.h > trunk/reactos/drivers/usb/miniport/usbuhci/usbuhci.xml > trunk/reactos/drivers/usb/usbhub/usbhub.h > trunk/reactos/drivers/usb/usbhub/usbhub.xml > trunk/reactos/drivers/usb/usbport/buffer_simple.c > trunk/reactos/drivers/usb/usbport/config.c > trunk/reactos/drivers/usb/usbport/core_drivers/usbkey.c > trunk/reactos/drivers/usb/usbport/core_drivers/usbmouse.c > trunk/reactos/drivers/usb/usbport/hcd-pci.c > trunk/reactos/drivers/usb/usbport/hcd.c > trunk/reactos/drivers/usb/usbport/hub.c > trunk/reactos/drivers/usb/usbport/message.c > trunk/reactos/drivers/usb/usbport/urb.c > trunk/reactos/drivers/usb/usbport/usb-debug.c > trunk/reactos/drivers/usb/usbport/usb.c > trunk/reactos/drivers/usb/usbport/usbcore.c > trunk/reactos/drivers/usb/usbport/usbport.xml > > Deleted files: > trunk/reactos/drivers/usb/usbport/usbcore.def > > _______________________________________________ > Ros-svn mailing list > Ros-svn(a)reactos.com > http://reactos.com:8080/mailman/listinfo/ros-svn > -- "I had a handle on life, but then it broke"

1 0

Re: [ros-svn] [ion] 17727: Implement NTDLL's CSR routines in a compatible way. Fix prototypes, argument count, deprecated functions and new functions. Some functions will not work (or are designed not to work) fully until the new CSR is committed, but they keep the same functionality as the previous versions (no regressions found; tested with cmd, cmt, putty, telnet, ps). Also added NtSecureConnectPort.
by Hartmut Birr 08 Sep '05

08 Sep '05

Hi, this changes does break booting for me. I get an error message: (subsys\csrss\api\wapi.c:198) CSR: NtListenPort() failed, status=c0000005 - Hartmut

3 3

Replacement for Bitstream fonts
by Mikhail Y. Zvyozdochkin 08 Sep '05

08 Sep '05

Hi All. I think it's a good idea to use Dejavu fonts http://dejavu.sourceforge.net/ instead Bitstream Vera. Reasons are: - it based on Bitstream fonts (1.10); - it's distributing under SAME license; BUT - it supported MUCH more unicode pages than original Bitstream fonts; it was main goal of Dejavu Projects "to provide a wider range of characters", to support various languages and codepages. In particular, I tried to activate Russian language in ReactOS 0.2.7-REL with Dejavu fonts. It working correctly without any proprietary fonts :). Unicode coverage table: http://cvs.sourceforge.net/viewcvs.py/*checkout*/dejavu/dejavu-fonts/unicov… At this September they want make new release, 1.14. I think, it new version may be integrated with ReactOS 0.3 :) WBR, DarkHobbit

1 0

problem with current svn
by Hartmut Birr 08 Sep '05

08 Sep '05

Hi, I'm trying to compile ros on ros with the current svn tree. It isn't possible. After some time, it fails with a message cannot execute 'bla bla'. The build does corrupt the file system. If I run chkdsk from w2k I get many messages about multiple files like 'wrc.ex'. It seems that something is wrong with the string functions. - Hartmut

3 5

RE: Ros-dev Digest, Vol 13, Issue 14
by Lucio Diaz 08 Sep '05

08 Sep '05

Sorry, but i still cant see the point. 0.2.7 is a release, and thus is oriented to the user (maybe power user or fan at this moment), to test and play around. Users, like me, dont go to bugzilla cause most of us can not make sense of all that techicall information. I knew there was a problem, a blocking problem for anyone trying to install the OS in real hardware and i wrote about it where a user (like me) may find out, in the wiki. I can not understand why you become angry. I am just filling some documentation for the user, and that is the only whay i can colaborate ( i doubt you would apretiate my little pascal and delphy coding skill). Known problems is for that... enumerating the known problems of a determinated version, while 0.2.7 is the last version i consider relevant the fact that it can not be installed in Real Hardware. I wish i could debug and find the problem, but i dont have the experience or the tools to do so. with my best wishes to the team, Lucio Diaz. WaxDragon wrote--> Message: 5 Date: Wed, 7 Sep 2005 13:15:19 -0400 From: WaxDragon <waxdragon(a)gmail.com> Subject: Re: [ros-dev] RE: Ros-dev Digest, Vol 13, Issue 13 To: ReactOS Development List <ros-dev(a)reactos.com> Message-ID: <9b0d5f3205090710157abc163f(a)mail.gmail.com> Content-Type: text/plain; charset=ISO-8859-1 I think you missed the point. I'm talking about http://www.reactos.com/wiki/index.php/Known_Problems When calling things "known problems" I want bugs for them. I'm going to assume you are talking about this known problem: http://www.reactos.com/bugzilla/show_bug.cgi?id=688 Which was even noted on the 0.2.7 changelog page: http://www.reactos.com/wiki/index.php/ChangeLog-0.2.7#Known_Bugs PLEASE, if you write ANYWHERE that ReactOS has a "known bug" please provide a link to the bug in bugzilla. If there is no bug in BugZilla, then there is a great possibility the Testing team doesn't know about it. By filing bugs, we can reduce the amount of duplicate effort required to fix said bug. When filing bugs, please review http://www.reactos.com/wiki/index.php/File_Bugs first. With that out of the way, I know that noone has looked at that bug since 0.2.7 was released. If you can gather any useful info about the hardware (the i8042 controller specifically) that you are experienceing the problem with, update the bug, this may help with getting it resolved. WD PS. I'm very tempted to make the "Know Problems" page go away, or heavily modify it. ______________________________________________ Renovamos el Correo Yahoo! Nuevos servicios, más seguridad http://correo.yahoo.es

1 0

RE: Ros-dev Digest, Vol 13, Issue 13
by Lucio Diaz 07 Sep '05

07 Sep '05

> Message: 1 > Date: Tue, 6 Sep 2005 08:42:13 -0400 > From: WaxDragon <waxdragon(a)gmail.com> > Subject: Re: [ros-dev] Bootcd installation failure > To: ReactOS Development List <ros-dev(a)reactos.com> > Message-ID: > <9b0d5f32050906054215dd322b(a)mail.gmail.com> > Content-Type: text/plain; charset=ISO-8859-1 > > Well, I have no idea what Lucio means by that "known > problem", since > he isn't very specific. 17600 is not even close to > where we forked > 0.2.7. I remember there were some problems around > then. Try 17604, I > personally tested that rev and it seemed to work ok. > > In the future, if you are going to call something a > "known problem" > please link to the bug in Bugzilla. If the "known > problem" isn't in > bugzilla, it isn't "known" as far as I care. > > Thanks > WD > I reported it in both the general and dev mailing lists, it happens in real hardware in two complitely diferent computers, one Intel and one AMD, with completely diferent OSes as base instalation and both with previus sucesfull reactos instalations. In both the instalation CD hangs before installing anything (maybe reading the partitions?) to the Hard drive. Not many people test reactos in Real Hardware, but i was told the problem was already known. I have not tested the SVN since long so i can not say if it is solved. Still it is a KNOW reproducible problem of 0.2.7. With best regards, Lucio Diaz. ______________________________________________ Renovamos el Correo Yahoo! Nuevos servicios, más seguridad http://correo.yahoo.es

3 2

Re: [ros-dev] Re: [ros-svn] [hbirr] 17665: - Copy the map registers to the buffer only, if they are used (in IoFlushAdapterBuffers).
by Filip Navara 07 Sep '05

07 Sep '05

1 0

Re: [ros-diffs] [gdalsnes] 17713: make co_WinPosShowWindow take pWnd, not hWnd
by Royce Mitchell III 07 Sep '05

07 Sep '05

gdalsnes(a)svn.reactos.com wrote: > > > >+ //faxme: temp hack >+ UserDereferenceWindowObjectCo(Window); >+ > > What's your fax #? :P

1 0

Re: [ros-svn] [hbirr] 17665: - Copy the map registers to the buffer only, if they are used (in IoFlushAdapterBuffers).
by Filip Navara 06 Sep '05

06 Sep '05

hbirr(a)svn.reactos.com wrote: >- Copy the map registers to the buffer only, if they are used (in IoFlushAdapterBuffers). >- Do not use the byte offset into the page from a given buffer if the map registers are used, > because the caller didn't request for one additional register in the call to IoAllocateAdapterChannel > and it will not work for a 64k buffer. > > Sorry, but these changes are wrong. I won't argue that there isn't bug, but you're just workarounding it. - At first, the UseMapRegisters variable you added to MAP_REGISTER_ENTRY structure isn't needed. IoFlushAdapterBuffers can determine the information itself and the case was clearly marked as UNIMPLEMENTED and FIXME. - The byte offset is added for a reason. I know the stuff that it is supposed to solve is broken atm, but the rationale is that there can be more IoMapTransfer calls and together with MAP_REGISTER_ENTRY->Counter you can setup more transfers... It's explained in http://download.microsoft.com/download/e/b/a/eba1050f-a31d-436b-9281-92cdfe…. I certainly welcome any help and review of the DMA code and I'll try to add comments where appropriate, but I would like to discuss these changes first on the Mailing List / IRC / mail since this piece of code is pretty complex and any changes are prone to break some feature... - Filip

2 5

RE: [gdalsnes] 17695: naming changes:
by Ge van Geldorp 06 Sep '05

06 Sep '05

> From: gdalsnes(a)svn.reactos.com > > naming changes: > -remove annying "Object" from variables. prepend handles with > "h" instead. > -rename window->Self -> Window->hSelf I hope we're not going to convert everything to Hungarian notation? Personally I think that's both ugly and useless. Gé van Geldorp.

2 1

Bootcd installation failure
by Gge 06 Sep '05

06 Sep '05

In the wiki page related to Known problems for R..2.7 -->> http://www.reactos.com/wiki/index.php?title=Known_Problems&curid=786&diff=0… , it is mentionned that "The install CD wont install reactos in some computers. LiveCD might boot in the same computers without problems" I cannot Boot using Boocd based on svn 17600 and created using the recommended "Built Environment" as indicated in the Wiki -->> http://blight.reactos.at/reactos-be/ReactOS%20Build%20Environment%200.1-3.4… The problem is reproductible on my 2 computers in real hardware , as per debug messages below. => Is it the same problem ? (ntoskrnl\ldr\loader.c:252) Could not open module file: \SystemRoot\system32\drivers\sndblst.sys (ntoskrnl\ldr\loader.c:252) Could not open module file: \SystemRoot\system32\drivers\mpu401.sys (registry.c:220) Can't read registry: c0000034 (registry.c:231) Manually set defaults (ntoskrnl\ldr\loader.c:252) Could not open module file: \SystemRoot\system32\drivers\xboxvmp.sys Packet: DriverEntry (ndis/protocol.c:678)(NdisRegisterProtocol) Called. (ndis/protocol.c:685)(NdisRegisterProtocol) NDIS 3 protocol attempting to register (ndis/protocol.c:764)(NdisRegisterProtocol) Opening configuration key: \Registry\Machine\System\CurrentControlSet\Services\PacketDriver\Linkage (ndis/protocol.c:773)(NdisRegisterProtocol) Unable to open protocol configuration NPF: Failed to register protocol with NDIS (ntoskrnl\ob\object.c:157) Invalid Size: 18 or Attributes: 1 (ntoskrnl\ob\object.c:243) Failed to capture, cleaning up (ntoskrnl\ob\object.c:825) Capture failed (init.c:108) SM: InitSessionManager: failed to create \SmApiPort (Status=c000000d) (ntoskrnl\ob\wait.c:246) Returning: 1 KeBugCheckEx at ntoskrnl\ex\init.c:716 A problem has been detected and ReactOS has been shut down to prevent damage to your computer. Technical information: *** STOP: 0x00000071 (0x00000001,0x00000000,0x00000000,0x00000000) Frames: <ntoskrnl.exe:24c6 (ntoskrnl/ke/bug.c:498 (KeBugCheckEx))> <ntoskrnl.exe:b8a5f (ntoskrnl/ex/init.c:716 (ExpInitializeExecutive))> <ntoskrnl.exe:6706 (ntoskrnl/ke/main.c:100 (KiSystemStartup))> <ntoskrnl.exe:b684e (ntoskrnl/ke/main.c:294 (_main))> <ntoskrnl.exe:104b ({standard input}:47 (_section_alignment__))> Regards Gge

2 1

RE: [gdalsnes] 17671: -surround user part (most of it) with asingle lock (currently a mutex, but will be a resource). other now useless locks will be removednext.
by Ge van Geldorp 06 Sep '05

06 Sep '05

> From: gdalsnes(a)svn.reactos.com > > Updated files: > trunk/reactos/subsys/win32k/include/win32k.h Perhaps you forgot to commit a file? [PCH] obj-i386/subsys/win32k/w32k.h.gch In file included from subsys/win32k/w32k.h:44: subsys/win32k/include/win32k.h:12:28: include/ntuser.h: No such file or directory make[1]: *** [obj-i386/subsys/win32k/w32k.h.gch] Error 1

1 0

Poll Results
by Alex Ionescu 06 Sep '05

06 Sep '05

Hi, I've compiled the results from the poll that I posted on the forum (some of you may know about it, some may not, that's fine, the presentation is quite clear about it) and published it as a slide presentation in four formats: Open Document Format: (For OO 2.0): http://www.relsoft.net/ReactOSResults.odp Adobe Acrobat Format: http://www.relsoft.net/ReactOSResults.pdf Macromedia Flash Format: http://www.relsoft.net/ReactOSResults.swf Microsoft Powerpoint Format: http://www.relsoft.net/ReactOSResults.ppt I hope I've been diverse enough with the formats ;) Best regards, Alex Ionescu

5 4

RE: [ros-svn] [ion] 17650: - Fix kernel32 and ntoskrnl build issues.
by Ge van Geldorp 05 Sep '05

05 Sep '05

> From: ion(a)svn.reactos.com > > - Fix kernel32 and ntoskrnl build issues. > - Define public version of DEVOBJ_EXTENSION in DDK. Ok, I have to wonder, did you bother to do ANY testing on your DEVOBJ_EXTENSION/EXTENDED_DEVOBJ_EXTENSION changes at all? Like, uhm, just trying to boot? 'cause it seems very unlikely to me that you were able to successfully boot. IoCreateDevice allocates only enough room for DEVOBJ_EXTENSION, but the allocated pointer is cast to PEXTENDED_DEVOBJ_EXTENSION (a much larger struct) all over the place, so we're reading/writing outside allocated memory in a zillion places. Gé van Geldorp.

2 2

Re: [ros-svn] [hpoussin] 17639: Implement SetComputerNameExA/W
by Hartmut Birr 04 Sep '05

04 Sep '05

hpoussin(a)svn.reactos.com wrote: >Implement SetComputerNameExA/W > > >Updated files: >trunk/reactos/lib/kernel32/misc/computername.c >trunk/reactos/lib/kernel32/misc/stubs.c >trunk/reactos/w32api/include/winbase.h > >_______________________________________________ >Ros-svn mailing list >Ros-svn(a)reactos.com >http://reactos.com:8080/mailman/listinfo/ros-svn > > > Hi, this implementation breaks installing reactos. It does only accept 3 of 8 types to setting the computer name. The setup uses ComputerNameNetBIOS, which isn't implemented. - Hartmut

1 0

Re: [ros-diffs] [hpoussin] 17641: Allow compilation of fs_rec driver with MSVC
by Alex Ionescu 04 Sep '05

04 Sep '05

hpoussin(a)svn.reactos.com wrote: >Allow compilation of fs_rec driver with MSVC > > > > > >+#ifdef _MSC_VER >+#define STDCALL >+#endif >+ > > This isn't really correct...what are you trying to do? Best regards, Alex Ionescu

1 0

State of the Repository September 2nd 2005
by WaxDragon 04 Sep '05

04 Sep '05

First, some stats: In August there were: * 676 Commits * 49 bugs opened * 139 bugs touched * 44 bugs closed Looking over the logs, here are some of the big and/or highly visible changes: *sedwards bought in some winetests (in regtests/winetests) This resulted in some immediate fixes *navaraf replaced the pesum tool with pefixup *sedwards brought dosfsck in late July, and enabled writing in August. Still needs testing, but seems to work. *brandonturner implemented windows style tab completion, replacing the bash style we had before. I believe this can be toggled. Also, cmd has really been getting attention from brandonturner and greatlord, may little bugs have been fixed. Thanks guys! *ion removed the third-party driver info from the hives and placed them in the wiki. I felt this was a good move, since it will motivate people to fix/implement driver installation. The interim solution was going to be creating .reg files to import or just re-add the info to your local hives. This had the side affect of breaking our vmware video driver installer. After some bugfixes, vmwinst now loads the driver, but ReactOS seems unable to set the resolution. *navaraf fixed the i8042prt detection, partially fixing the AllocConsole bug. This was merged to 0.2.7 and we shipped it as a known bug. We have received just a few reports of the AllocConsole bug on IRC, so it seems to work for most. *navaraf fixed the translation of extended keys, fixing my bug hilighting text with Shift+Arrow keys. Merged to 0.2.7, thanks Filip! *ion twiddled the priority code, fixing some winetests * ea returned to work on subsystem code * gdalsnes fixed ftol, progressing Abiword 2.0.3 * ion corrected the LPC Message Structures * amunger fixed the freeldr.ini Timeout ;0) * hbirr fixed several bugs that were blocking selfhosting (ros-on-ros compilation) I am able to compile ros on ros with the patch from the selfhosting bug. Thanks Hartmut! * We found that release builds of msi.dll allow the VMWare Tools installer to run, several bugs were fixes in relation to this. Thanks everyone! *fireball got USB keyboards working on the XBOX, along with various USB fixes * ion cleaned up the NDK headers * gvg added the autogenerated DIB code for 32 and 8 bpp * navaraf reimplemented the HAL DMA routines * There was some work on the MSVC backend, thanks to sedwards and royce * navaraf fixed some bugs in NDIS * navaraf tweaked the explorer taskbar, fixing the misaligned buttons under windows This exposes a bug in ReactOS, so the taskbar looks a little off now. 17604 seems like a good way to start September: * shutdown bug fixed * Default Abiword 2.2.9 install works * Abiword 2.2.9 runs and opens documents. * 7-Zip 4.23 Installer works * 7-Zip GUI has several issues * 7za.exe (cli) works * OO installer unpacks, but bombs a few pages in * notepad opens and saves files properly * winemine doesn't work * solitare works * ps works * mc seems like it has issues (I'm not a user per se.) * format still doesn't work * calc doesn't even start * cat works * regedit can set values * wallpaper stays if set in registry, not if using desk.cpl Networking: * qemu networking fixed * ftp fixed * ping works * ipconfig has issues * finger works * "route print" works * netstat doesn't work * ncftp has issues * hostname works * arp doesn't work * mIRC installer works, fails creating icons (or start menu I don't remember) * mIRC has several issues, can't get it to connect and the usual implementing new functions, syncing to wine, and bugfixes. Overall 17604 "feels" good and stable. I was able to use the command line without too much trouble, installed many packages, and only saw a few BSODs, mainly in the network code. I think that is a pretty good summary, and since it's been the day of long emails, I won't go any further. Please reply to this email if there is something I forgot, overlooked, got wrong, etc.. WD -- #irc.freenode.net #reactos 01:03PM <filip2307> i don't know about any bug 01:04PM <filip2307> none exist 01:04PM <filip2307> ReactOS is prefect

3 4

ReactOS Revision ISOs
by Sylvain Petreolle 04 Sep '05

04 Sep '05

Hi all, After doing some regression tests with SVN ISOs, it appears some are missing/badly numbered. Here is the updated list. ReactOS-trunk-rxxxxx.iso -> real revision ReactOS-trunk-r17465.iso -> r17560 ReactOS-trunk-r17466.iso -> r17539 ReactOS-trunk-r17468.iso -> r17559 ReactOS-trunk-r17471.iso -> r17567 ReactOS-trunk-r17472.iso -> r17553 ReactOS-trunk-r17473.iso -> r17565 ReactOS-trunk-r17478.iso -> r17552 ReactOS-trunk-r17479.iso -> r17569 ReactOS-trunk-r17490.iso -> r17572 ReactOS-trunk-r17495.iso -> r17553 These files did show the same version (md5sum proved they are different) ReactOS-trunk-r17480.iso -> r17564 ReactOS-trunk-r17482.iso -> r17564 ReactOS-trunk-r17476.iso -> r17566 ReactOS-trunk-r17483.iso -> r17566 ReactOS-trunk-r17489.iso -> r17566 Kind regards, Usurp (aka Sylvain Petreolle) humans are like computers, yesterday the BIOS was all - today its just a word

2 3

SMSS & LSASS: Service Status
by Rick Langschultz 03 Sep '05

03 Sep '05

Hey all, I am thinking about starting, or helping write the SMSS and/or LSASS implementation on ReactOS. I was wondering what I can help with, or help someone to do the work... Rick Langschultz rlangschultz(a)cox.net (Home) rlangschultz(a)ellemaespa.com (Work) rlangschultz(a)email.uophx.edu (School)

6 5

Re: [ros-diffs] [navaraf] 17604: Check for Request == NULL.
by Hartmut Birr 03 Sep '05

03 Sep '05

navaraf(a)svn.reactos.com wrote: >Check for Request == NULL. > >Modified: trunk/reactos/ntoskrnl/lpc/reply.c > > > ------------------------------------------------------------------------ > *Modified: trunk/reactos/ntoskrnl/lpc/reply.c* > >--- trunk/reactos/ntoskrnl/lpc/reply.c 2005-09-02 11:29:40 UTC (rev 17603) >+++ trunk/reactos/ntoskrnl/lpc/reply.c 2005-09-02 13:12:44 UTC (rev 17604) >@@ -263,6 +263,12 @@ > > Request = EiDequeueMessagePort(Port); > KeReleaseSpinLock(&Port->Lock, oldIrql); > > > >+ if (Request == NULL) >+ { >+ ObDereferenceObject(Port); >+ return STATUS_UNSUCCESSFUL; >+ } >+ > > > if (Request->Message.u2.s2.Type == LPC_CONNECTION_REQUEST) > { > PORT_MESSAGE Header; > > Hi, I think that this fix doesn't solve the real problem. The caller waits on a semaphore and the semaphore is only signaled if a message is in the queue. This means, the caller can't get a NULL pointer from EiDequeueMessagePort(). The real problem is anywhere in KeWaitForSingleObject, which does return STATUS_USER_APC for a non alertable wait. That is wrong. - Hartmut

2 1

New Webserver System
by Rick Langschultz 03 Sep '05

03 Sep '05

I was kicking around the idea of installing a jabber server on my companies server to allow instant messaging on the local area network. Would reactos.com be willing to do something like that or is that too far out of the scope of the project. I was going to use OpenLDAP for authentication and save all of the conversations in XML files in both senders and recipients home folders. I also was going to write an XSL to display those messages. I think this would help out both developers and users of reactos. Including future RosMessenger or something like that... Just a though... Rick Langschultz rlangschultz(a)cox.net (Home) rlangschultz(a)ellemaespa.com (Work) rlangschultz(a)email.uophx.edu (School)

14 18

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev