Can't we use "optional" here instead of "o"? I know it will require
two more seconds to write, but it is much more self-documenting than "o".
Casper
________________________________________
From: ros-diffs-bounces(a)reactos.com [mailto:ros-diffs-bounces@reactos.com] On Behalf Of ea(a)svn.reactos.com
Sent: 15. august 2005 19:31
To: ros-diffs(a)reactos.com
Subject: [ros-diffs] [ea] 17400: Add winemine.
Add winemine.
Modified: trunk/reactos/bootdata/packages/reactos.dff
________________________________________
Modified: trunk/reactos/bootdata/packages/reactos.dff
--- trunk/reactos/bootdata/packages/reactos.dff 2005-08-15 17:04:34 UTC (rev 17399)
+++ trunk/reactos/bootdata/packages/reactos.dff 2005-08-15 17:30:20 UTC (rev 17400)
@@ -299,6 +299,7 @@
modules\rosapps\cmdutils\mode\mode.exe 1 o
modules\rosapps\cmdutils\touch\touch.exe 1 o
modules\rosapps\games\solitaire\sol.exe 1 o
+modules\rosapps\games\winemine\winemine.exe 1 o
modules\rosapps\mc\mc.exe 1 o
modules\rosapps\net\ncftp\ncftp.exe 1 o
modules\rosapps\net\niclist\niclist.exe 1 o
greatlrd(a)svn.reactos.com wrote:
> change CMDLINE_LENGTH to 8192 to keep rbuild happy until dymatic alloc are in place
>
>
> Updated files:
> trunk/reactos/subsys/system/cmd/cmd.h
>
Hi!
My problem with building is fix with this patch. I would make sure this setting
is the, no other, only minimum setting. Due to speed of allocating memory every
time cmd is running.
Thanks,
James
It seems you missed a test into your dfp.cxx change.
The change of the series of if() else if() into a switch(){} is ok,
except now it always returns CAB_STATUS_SUCCESS.
+ case CAB_STATUS_NOMEMORY:
+ printf("Insufficient memory to add file: %s.\n", SrcName);
+ break;
+ default:
+ printf("Cannot add file: %s (%lu).\n", SrcName, Status);
+ break;
}
-
return CAB_STATUS_SUCCESS;
}
To restore the correct behaviour, you have to
return Status;
Kind regards,
Usurp (aka Sylvain Petreolle)
humans are like computers,
yesterday the BIOS was all
- today its just a word
I'm curious why we are making this string nul terminated?
IoCreateSymbolicLink() should not care (I'm virtually
certain it doesn't under windows.) And I'm pretty
sure that IoRegisterDeviceInterface isn't expected
to return a nul terminated string either. And I'm also
pretty sure our implementation doesn't actually return
it NUL terminated because the length doesn't include
the NUL termination (rightly so or the symbolic link
would actually have a NUL character as part of it's
name) and the RtlMoveMemory() at the end of the function
is based of off Length().
I'm pretty sure that virtually no windows kernel mode function
taking a UNICODE_STRING structure (or a STRING structure)
expects nul termination...
Thanks,
Joseph
hbirr(a)svn.reactos.com wrote:
> Fixed a terminating NULL in IoRegisterDeviceInterface.
>
> Modified: trunk/reactos/ntoskrnl/io/deviface.c
>
> ------------------------------------------------------------------------
> *Modified: trunk/reactos/ntoskrnl/io/deviface.c*
>
> --- trunk/reactos/ntoskrnl/io/deviface.c 2005-08-15 16:41:43 UTC (rev 17396)
> +++ trunk/reactos/ntoskrnl/io/deviface.c 2005-08-15 16:47:15 UTC (rev 17397)
> @@ -815,7 +815,7 @@
>
> RtlAppendUnicodeToString(SymbolicLinkName, L"\\");
> RtlAppendUnicodeStringToString(SymbolicLinkName, ReferenceString);
> }
>
> - SymbolicLinkName->Buffer[SymbolicLinkName->Length] = '\0';
>
> + SymbolicLinkName->Buffer[SymbolicLinkName->Length/sizeof(WCHAR)] = L'\0';
>
>
> /* Create symbolic link */
> DPRINT("IoRegisterDeviceInterface(): creating symbolic link %wZ -> %wZ\n", SymbolicLinkName, &PdoNameInfo->Name);
>
Hi all,
When running ntdll_test or ntdll_crosstest with rtl selected, it will fail at
the last test, test_HandleTables. Right at first I checked the wine headers and
noticed the handle table structures are not the same as ros.
B^| Wow, -what- -a- -sur- -prise-.
Convert tests to Ros? 8^>
James
James Tabor wrote:
>
> It's not gpl. I do consider this a good test app, but poorly written.
> http://www.smidgeonsoft.prohosting.com/download/PEBrowse.zip
> Haa! It really illustrates some weaknesses in Ros.
>
Hi!
Has anyone bothered to test this application?
Thanks,
James
Hi.
Is there any graphics artist here that can and want to create four icons for our Continuous Integration System?
At http://sin.csh-consult.dk/ there is a table of changes committed to the repository. I want to add a new column "Build type" at
the end containing these icons. The four icons are:
? = Unknown build type
P = Partial build
F = Full build
F (underlined) = Required full build
Casper
Hey, do you know when this started happening or has rbuild always had
lines that are too long for ROS cmd? Should we just change
CMDLINE_LENGTH to something else, because apparently CMDLINE_LENGTH is
not really the max a line can be as rbuild works with MS cmd.
Brandon
ReactOS.Bugzilla(a)reactos.com wrote:
>http://reactos.com/bugzilla/show_bug.cgi?id=708
>
>
>
>
>
>------- Additional Comments From hartmut.birr(a)gmx.de 2005-12-08 16:14 -------
>cmd.exe uses a fixed size command and batch line buffer. 512 characters are
>not enough for our current build system.
>
>
>
> From: hpoussin(a)svn.reactos.com
>
> Implement SetupGetInfFileListW and SetupGetInfInformationW
> Inf file parser now accept UNICODE files with FF FE header
> Return required buffer size when buffer is too small in
> SetupGetLineTextA/W, SetupGetStringFieldA/W
>
>
> Updated files:
> trunk/reactos/lib/setupapi/parser.c
> trunk/reactos/lib/setupapi/setupapi.spec
SetupGetStringFieldW() (and possibly others too) now return failure and set
an error of ERROR_INSUFFICIENT_BUFFER when the passed in buffer and size are
NULL and 0 resp. I think this is not correct. MSDN says:
"If this function is called with a ReturnBuffer of NULL and a
ReturnBufferSize of zero, the function puts the buffer size needed to hold
the specified data into the variable pointed to by RequiredSize. If the
function succeeds in this, the return value is a nonzero value."
So buffer == NULL and size == 0 is a special case. Other code (e.g. the call
in lib/setupapi/install.c line 328) depends on this behaviour and is now
broken too.
Gé van Geldorp.
Is there a way to declare a file 'optional' in reactos.dff?
With 'optional' I mean a file that will go in the ISO image, if present,
otherwise the declaration will be silently ignored.
--
:Emanuele Aliberti
ReactOS.Bugzilla(a)reactos.com wrote:
>
> After successfull
> make depends
> make
> make install
>
> I have copied the files inside the 2.6 hard disk image of ReactOS.
Although I can't answer your initial problem, I can suggest that do a 'make
bootcd' instead of 'make install', and then boot ROS in QEMU using the
generated iso. Then you will have an install better suited to QEMU.
************************************************************************
The information contained in this message or any of its
attachments is confidential and is intended for the exclusive
use of the addressee. The information may also be legally
privileged. The views expressed may not be company policy,
but the personal views of the originator. If you are not the
addressee, any disclosure, reproduction, distribution or other
dissemination or use of this communication is strictly prohibited.
If you have received this message in error, please contact
postmaster(a)exideuk.co.uk
<mailto:postmaster@exideuk.co.uk> and then delete this message.
Exide Technologies is an industrial and transportation battery
producer and recycler with operations in 89 countries.
Further information can be found at www.exide.com
hbirr(a)svn.reactos.com wrote:
>- Removed the hole pool allocation, because it needs to much memory and ros will not boot.
>- Allocate short blocks in one page.
>- Split the used and free header. It makes it easier to implement a red zone check.
>
>
>
Can we use rpoolmgr.h for npool? I wrote it to be useable by both.
Hello,
This commit has broken compiling ROS with ROS cmd.exe. While building
it is rbuild is not deleting all the temp files it is creating(ROS
only). When trying to delete them doing "del *.*aaa" it does not delete
_all_ files it should however running the command again will pick up
what it left before(reported by WD). Make install and make clean are
both effected in some way as well. Here is the output:
C:\Documents and Settings\Brandon\Desktop\ROS>mingw32-make install
[CC] ntoskrnl\se\lsa.c
[CC] ntoskrnl\se\luid.c
[CC] ntoskrnl\se\priv.c
[CC] ntoskrnl\se\sd.c
[CC] ntoskrnl\se\semgr.c
[CC] ntoskrnl\se\sid.c
[CC] ntoskrnl\se\token.c
[WRC] obj-i386\ntoskrnl\ntoskrnl.coff
Bad command or filename
mingw32-make: *** [obj-i386\ntoskrnl\ntoskrnl.coff] Error -1073741819
C:\Documents and Settings\Brandon\Desktop\ROS>mingw32-make clean
[CC] tools\cdmake\cdmake.c
[CC] tools\cdmake\llmosrt.c
[LD] output-i386\tools\cdmake\cdmake.exe
[CC] tools\mkhive\binhive.c
[CC] tools\mkhive\infcache.c
[CC] tools\mkhive\mkhive.c
[CC] tools\mkhive\reginf.c
[CC] tools\mkhive\registry.c
[LD] output-i386\tools\mkhive\mkhive.exe
mingw32-make: [rbuild_clean] Error -1073741819 (ignored)
mingw32-make: [unicode_clean] Error -1073741819 (ignored)
mingw32-make: [freeldr_base64k_clean] Error -1073741819 (ignored)
mingw32-make: [freeldr_base_clean] Error -1073741819 (ignored)
mingw32-make: [freeldr_main_clean] Error -1073741819 (ignored)
mingw32-make: [hal_generic_clean] Error -1073741819 (ignored)
mingw32-make: [glu32_clean] Error -1073741819 (ignored)
mingw32-make: [kernel32_base_clean] Error -1073741819 (ignored)
mingw32-make: [cmd_base_clean] Error -1073741819 (ignored)
mingw32-make: [explorer_clean] Error -1073741819 (ignored)
mingw32-make: [explorer_clean] Error -1073741819 (ignored)
mingw32-make: [win32k_base_clean] Error -1073741819 (ignored)
Gunnar Dalsnes wrote:
> i know, the msg sux. ill create a summary commit msg when/if i merge
> with trunk.
>
> G.
I pretty much disagree with the USER_MESSAGE_QUEUE -> W32THREAD changes.
It would be all nice and correct if there wasn't the AttachThreadInput
function. On Windows there is also a message queue stucture (called
simply "Q"), so why are you trying to make the stuff different and imho
more complicated?
- Filip
royce(a)svn.reactos.com wrote:
>initialize StringBuffer to NULL, as some code paths lead to it being tested without ever being set.
>
>
I forgot to give credit to WaxDragon for the find, I humbly beg your
forgiveness...
Updated and built latest version. It installs ok, but when I try to
boot, I get this ( I enabled some debug messages after the first failure ):
(ntoskrnl\ke\main.c:289)
---------------------------------------------------------------
(ntoskrnl\ke\main.c:290) ReactOS 0.3-SVN (Build 20050809-r17251)
Used memory 65536Kb
(ntoskrnl\mm\mminit.c:375) Kernel Stack Limits. InitTop = 0x800f7000,
Init = 0x800f4000
(ntoskrnl\mm\mm.c:283) No current process
(ntoskrnl\io\driver.c:442) IopLoadServiceModule(Pci, 0x800f6a80)
(ntoskrnl\io\driver.c:518) Initializing boot module
(ntoskrnl\io\driver.c:562) Module loading (Status 0)
Peripheral Component Interconnect Bus Driver
(ntoskrnl\io\driver.c:442) IopLoadServiceModule(PCNet, 0x800f6850)
(ntoskrnl\io\driver.c:541) Loading module
(ntoskrnl\ldr\loader.c:252) Could not open module file:
\SystemRoot\system32\drivers\pcnet.sys
(ntoskrnl\io\driver.c:559) Module loading failed (Status c0000001)
(ntoskrnl\io\driver.c:562) Module loading (Status c0000001)
(ntoskrnl\io\pnpmgr.c:1750) Initialization of service PCNet failed
(Status c0000001)
(ntoskrnl\io\driver.c:442) IopLoadServiceModule(usbuhci, 0x800f6850)
(ntoskrnl\io\driver.c:541) Loading module
(ntoskrnl\ldr\loader.c:252) Could not open module file:
\SystemRoot\System32\DRIVERS\usbuhci.sys
(ntoskrnl\io\driver.c:559) Module loading failed (Status c0000001)
(ntoskrnl\io\driver.c:562) Module loading (Status c0000001)
(ntoskrnl\io\pnpmgr.c:1750) Initialization of service usbuhci failed
(Status c0000001)
(ntoskrnl\io\driver.c:442) IopLoadServiceModule(PCNet, 0x800f6a60)
(ntoskrnl\io\driver.c:541) Loading module
(ntoskrnl\ldr\loader.c:252) Could not open module file:
\SystemRoot\system32\drivers\pcnet.sys
(ntoskrnl\io\driver.c:559) Module loading failed (Status c0000001)
(ntoskrnl\io\driver.c:562) Module loading (Status c0000001)
(ntoskrnl\io\pnpmgr.c:1750) Initialization of service PCNet failed
(Status c0000001)
(ntoskrnl\io\driver.c:442) IopLoadServiceModule(usbuhci, 0x800f6a60)
(ntoskrnl\io\driver.c:541) Loading module
(ntoskrnl\ldr\loader.c:252) Could not open module file:
\SystemRoot\System32\DRIVERS\usbuhci.sys
(ntoskrnl\io\driver.c:559) Module loading failed (Status c0000001)
(ntoskrnl\io\driver.c:562) Module loading (Status c0000001)
(ntoskrnl\io\pnpmgr.c:1750) Initialization of service usbuhci failed
(Status c0000001)
(ntoskrnl\io\driver.c:442) IopLoadServiceModule(Ne2000, 0x800f6a80)
(ntoskrnl\io\driver.c:541) Loading module
(ntoskrnl\ldr\loader.c:252) Could not open module file:
\SystemRoot\system32\drivers\ne2000.sys
(ntoskrnl\io\driver.c:559) Module loading failed (Status c0000001)
(ntoskrnl\io\driver.c:562) Module loading (Status c0000001)
(ntoskrnl\io\pnpmgr.c:1750) Initialization of service Ne2000 failed
(Status c0000001)
Advanced Configuration and Power Interface Bus Driver
ACPI: System firmware supports:
+------------------------------------------------------------
| Sx states: +S0 -S1 -S2 -S3 -S4 +S5
+------------------------------------------------------------
Power Button: found
Sleep Button: found
(ntoskrnl\io\driver.c:442) IopLoadServiceModule(serial, 0x800f6980)
(ntoskrnl\io\driver.c:465) RtlQueryRegistryValues() failed (Status c0000034)
(ntoskrnl\io\pnpmgr.c:1750) Initialization of service serial failed
(Status c0000034)
(ntoskrnl\io\driver.c:442) IopLoadServiceModule(serial, 0x800f6980)
(ntoskrnl\io\driver.c:465) RtlQueryRegistryValues() failed (Status c0000034)
(ntoskrnl\io\pnpmgr.c:1750) Initialization of service serial failed
(Status c0000034)
(ntoskrnl\io\driver.c:442) IopLoadServiceModule(serial, 0x800f6bc0)
(ntoskrnl\io\driver.c:465) RtlQueryRegistryValues() failed (Status c0000034)
(ntoskrnl\io\pnpmgr.c:1750) Initialization of service serial failed
(Status c0000034)
(ntoskrnl\io\driver.c:442) IopLoadServiceModule(serial, 0x800f6bc0)
(ntoskrnl\io\driver.c:465) RtlQueryRegistryValues() failed (Status c0000034)
(ntoskrnl\io\pnpmgr.c:1750) Initialization of service serial failed
(Status c0000034)
(ntoskrnl\io\driver.c:442) IopLoadServiceModule(PCNet, 0x800f6bc0)
(ntoskrnl\io\driver.c:541) Loading module
(ntoskrnl\io\driver.c:562) Module loading (Status 0)
(ntoskrnl\io\driver.c:442) IopLoadServiceModule(usbuhci, 0x800f6bc0)
(ntoskrnl\io\driver.c:541) Loading module
(ntoskrnl\ldr\loader.c:252) Could not open module file:
\SystemRoot\System32\DRIVERS\usbuhci.sys
(ntoskrnl\io\driver.c:559) Module loading failed (Status c0000034)
(ntoskrnl\io\driver.c:562) Module loading (Status c0000034)
(ntoskrnl\io\pnpmgr.c:1750) Initialization of service usbuhci failed
(Status c0000034)
(ntoskrnl\io\driver.c:442) IopLoadServiceModule(Ne2000, 0x800f6be0)
(ntoskrnl\io\driver.c:541) Loading module
(ntoskrnl\io\driver.c:562) Module loading (Status 0)
(ne2000/8390.c:86)(NICCheck) Adapter NOT found!
(ndis/miniport.c:1425)(NdisIPnPStartDevice) MiniportInitialize() failed
for an adapter.
(drivers\input\i8042prt\registry.c:215) Can't read registry: c0000034
(drivers\input\i8042prt\registry.c:226) Manually set defaults
(ntoskrnl\ldr\loader.c:252) Could not open module file:
\SystemRoot\system32\drivers\sndblst.sys
(ntoskrnl\ldr\loader.c:252) Could not open module file:
\SystemRoot\system32\drivers\mpu401.sys
(ntoskrnl\ldr\loader.c:252) Could not open module file:
\SystemRoot\system32\drivers\xboxvmp.sys
NtSetEaFile at ntoskrnl\io\file.c:2873 is unimplemented, have a nice day
greatlrd(a)svn.reactos.com wrote:
>fixing bug 690 by Brandon Turner. note ms only allown start "notepad" or "note"pad not notep"ad or notepad" but we do that, for we think it is a bug in ms cmd that only allowing " at start of a file name to start the apps.
>
>
>Updated files:
>trunk/reactos/subsys/system/cmd/cmd.c
>
>_______________________________________________
>Ros-svn mailing list
>Ros-svn(a)reactos.com
>http://reactos.com:8080/mailman/listinfo/ros-svn
>
>
>
>
This change is broken, because the input strings may be longer than
MAX_PATH. This is always true for compilung ros on ros.
- Hartmut
navaraf(a)svn.reactos.com wrote:
>Fix mutex unlocking in NpfsWaiterThread and add ASSERT.
>
>
>Updated files:
>trunk/reactos/drivers/fs/np/rw.c
>
>_______________________________________________
>Ros-svn mailing list
>Ros-svn(a)reactos.com
>http://reactos.com:8080/mailman/listinfo/ros-svn
>
>
>
>
Something is wrong with this change or r17157. Compiling ros on ros
reports hundreds of errors if pipes are enabled. Reverting npfs to
r17153 does fix this problem.
- Hartmut
hbirr(a)svn.reactos.com wrote:
>- DPRINT("%wZ\n", ObjectAttributes->ObjectName);
>
>
>
>
>
>+ DPRINT1("%wZ\n", ObjectAttributes->ObjectName);
>+
>
>
Do we really need to be verbose? ;-)
- Filip