gdalsnes(a)svn.reactos.com wrote:
>my 1st
>
>
>Added files:
>branches/hardons1stbranch/
>
>Updated files:
>branches/hardons1stbranch/kapi.h
>branches/hardons1stbranch/ntuser.h
>
>Deleted files:
>branches/hardons1stbranch/debug.h
>branches/hardons1stbranch/debug1.h
>
>
>
Hi,
I thought our pre-established branching rules recommend using an actual
meaningful branch name? Not a generic user branch, but a feature branch.
Best regards,
Alex Ionescu
ion(a)svn.reactos.com wrote:
> - Message Queue Fix, resolves a number of application regressions (Total Commander works again, for example). Patch by Hartmut Birr. To be commited into 0.2.7 after more testing.
>
>
>Updated files:
>trunk/reactos/subsys/win32k/ntuser/window.c
>
>
>
Hi,
this fix wasn't for commiting, because it doesn't solve the real
problem. The destroying of the message queues is intitiated by calling
Win32kThreadCallback which calls MsqDestroyMessageQueue. After this
call, it shouldn't exist anymore a window for this thread.
- Hartmut
hbirr(a)svn.reactos.com wrote:
> Lock the handle table if we trying to get a pointer from a handle.
These changes are incorrect. Please revert them.
Actually, a handle lookup requires _no_ locks at all. If you don't
believe me, read up Windows Internals (4th Edition). The algorithms to
allocate subtables are implemented in such a way that it is impossible
to page fault on a lookup. However, it is not allowed to do a lookup in
a table unless attached to the process that owns it (except it is a
global handle table).
Best Regards,
Thomas
Hello all devs, I am running Mozilla-Embedded (same as BartPE) because I can not get the Mozilla Controll to work, usually this is alright, but since some weeks ago Moz-Embedded locks the computer after the shell says "You're embedded man..." and before the mainwindow starts.
It usually took a long time for the mainwindow to start, but it used to work, and I think it takes aproximately the same time for the mouse (and the rest of the system) to lock in r16740.
I do not get any error-messages, someone with debugging skills has to look at this.
Mozilla embedded can be found here:
http://ftp.mozilla.org/pub/mozilla.org/mozilla/releases/mozilla1.6a/mozilla…
Yours sincerely,
Jaix Bly
Hi,
it seems there exist a problem with the message queues. If a process is
terminated (killed) from outside, the thread message queue is deleted
before the last window is deleted. If there is a message (key or mouse)
for this window, the window does access the already freed message queue.
This will crash the system. Possible it is related to the paged pool
memory corruption bug. I've a (dirty) fix for this problem.
- Hartmut
Index: subsys/win32k/ntuser/window.c
===================================================================
--- subsys/win32k/ntuser/window.c (Revision 16707)
+++ subsys/win32k/ntuser/window.c (Arbeitskopie)
@@ -1577,6 +1577,7 @@
IntSetMenu(WindowObject, hMenu, &MenuChanged);
}
WindowObject->MessageQueue = PsGetWin32Thread()->MessageQueue;
+ IntReferenceMessageQueue(WindowObject->MessageQueue);
WindowObject->Parent = (ParentWindow ? ParentWindow->Self : NULL);
if((OwnerWindow = IntGetWindowObject(OwnerWindowHandle)))
{
@@ -2180,7 +2181,7 @@
if (Window->MessageQueue->CaptureWindow == Window->Self)
Window->MessageQueue->CaptureWindow = NULL;
IntUnLockMessageQueue(Window->MessageQueue);
-
+ IntDereferenceMessageQueue(Window->MessageQueue);
/* Call hooks */
#if 0 /* FIXME */
if (HOOK_CallHooks(WH_CBT, HCBT_DESTROYWND, (WPARAM) hwnd, 0, TRUE))
Hey all,
I am hiring an entry level web programmer for the winter and would like to
know what you would suggest to be a good starting salary. We are a small
company that deals with serving users with portal services, such as database
portals, collaboration portals, e-learning portals, web services, and simple
PHP + MySQL websites. What would you want to be paid? Please be reasonable
cause I am going to base someones salary on these statistics.
Also please only respond directly to me, not to this list. No use clogging
it up.
Thanks,
Rick Langschultz
I found that SCM is not started in livecd. This is wrong imho (I use
livecd to debug ROS and I need SCM).
This small patch will fix this.
Index: winlogon.c
===================================================================
--- winlogon.c (revision 16707)
+++ winlogon.c (working copy)
@@ -593,6 +593,8 @@
DbgPrint("WL: Cannot switch to Winlogon desktop (0x%X)\n", GetLastError());
}
+ InitServices();
+
/* Check for pending setup */
if (GetSetupType () != 0)
{
@@ -616,8 +618,6 @@
return 2;
}
- InitServices();
-
#if 0
/* real winlogon uses "Winlogon" */
RtlInitUnicodeString((PUNICODE_STRING)&ProcessName, L"Winlogon");
Agreed. This is a perfect opportunity to bring in the new website.
-----Original Message-----
From: mf [mailto:mf@mufunyo.net]
Sent: 23 July 2005 11:27
To: ros-dev(a)reactos.com
Cc: ros-general(a)reactos.com
Subject: [ros-dev] Re: Reactos.com problems
Ge van Geldorp wrote:
> For the moment, I've moved the mailing lists to a backup box. I am not
> moving the website, since it seems the attack was carried out via the
> website (a vulnerability in one of the php script packages we use).
> I'll put up a dummy page informing visitors.
Am I the only one thinking this is the perfect moment to put up the new
static webpage along with the new design *hint hint* ?
_______________________________________________
Ros-dev mailing list
Ros-dev(a)reactos.com http://reactos.com:8080/mailman/listinfo/ros-dev
************************************************************************
The information contained in this message or any of its
attachments is confidential and is intended for the exclusive
use of the addressee. The information may also be legally
privileged. The views expressed may not be company policy,
but the personal views of the originator. If you are not the
addressee, any disclosure, reproduction, distribution or other
dissemination or use of this communication is strictly prohibited.
If you have received this message in error, please contact
postmaster(a)exideuk.co.uk
<mailto:postmaster@exideuk.co.uk> and then delete this message.
Exide Technologies is an industrial and transportation battery
producer and recycler with operations in 89 countries.
Further information can be found at www.exide.com
--- ion(a)svn.reactos.com wrote:
> - Freetype Update to 2.1.10. Reduces memory usage, increases speed and fixes drawing bugs.
> - Enable Bytecode. Weird_W's fonts finally look humanly readable.
Turn it off.
____________________________________________________
Start your day with Yahoo! - make it your home page
http://www.yahoo.com/r/hs
Hi,
ekohl(a)svn.reactos.com wrote:
> Add parameter checks.
>
>
> Updated files:
> trunk/reactos/lib/setupapi/cfgmgr.c
>
[CC] lib/setupapi/cfgmgr.c
lib/setupapi/cfgmgr.c: In function `CM_Locate_DevNode_ExW':
lib/setupapi/cfgmgr.c:991: error: `CM_LOCATE_DEVNODE_BITS' undeclared (first use in this function)
lib/setupapi/cfgmgr.c:991: error: (Each undeclared identifier is reported only once
lib/setupapi/cfgmgr.c:991: error: for each function it appears in.)
make: *** [obj-i386/lib/setupapi/cfgmgr.o] Error 1
I found /w32api/include/ddk/cfgmgr32.h adding <ddk/cfgmgr32.h> did help,
but it created more problems.
Thanks,
James
There are strong indications that the reactos.com box got cracked.
Unfortunately, I'm on vacation right now and unable to fix things. Since it
is causing problems on the network it will be isolated, meaning no network
traffic in or out. This will mean the website will go down and the mailing
lists will become inactive.
I'm sorry about this, but there is not much I can do for the next week.
Ge van Geldorp.
ekohl(a)svn.reactos.com wrote:
> Add parameter checks.
>
>
> Updated files:
> trunk/reactos/lib/setupapi/cfgmgr.c
>
> _______________________________________________
> Ros-svn mailing list
> Ros-svn(a)reactos.com
> http://reactos.com:8080/mailman/listinfo/ros-svn
>
lib\setupapi\cfgmgr.c: In function `CM_Locate_DevNode_ExW':
lib\setupapi\cfgmgr.c:991: error: `CM_LOCATE_DEVNODE_BITS' undeclared
(first use
in this function)
lib\setupapi\cfgmgr.c:991: error: (Each undeclared identifier is
reported only o
nce
lib\setupapi\cfgmgr.c:991: error: for each function it appears in.)
mingw32-make: *** [obj-i386\lib\setupapi\cfgmgr.o] Error 1
ion(a)svn.reactos.com wrote:
> Dmitry Philippov <shedon(a)mail.ru>:
>
> - Implemented FindFirstFileExW() and have removed InternalFindFirstFile() in /lib/kernel32/file/find.c, now FindFirstFileA (), FindFirstFileExA () and FindFirstFileW called FindFirstFileExW ()
>
>NOTE: Filip has asked revision "16661" (the next one) to be done by him... sorry if this sounds silly, but please respect his wish :)
>
>
>Updated files:
>trunk/reactos/lib/kernel32/file/find.c
>
>_______________________________________________
>Ros-svn mailing list
>Ros-svn(a)reactos.com
>http://reactos.com:8080/mailman/listinfo/ros-svn
>
>
>
>
The implemention of FindFirstFileExW is very buggy. On errors, the
allocated buffers are not cleanup correctly. The fourth parameter is
wrong in the call to RtlDosPathNameToNtPathName_U. It isn't possible to
cast a unicode string to a directory structure. The using of the results
from the call to RtlDosPathNameToNtPathName_U is wrong. The buffer from
the returned directory structure isn't always null terminated.
- Hartmut
Robert k. <rob(a)koepferl.de> wrote:
> Hi,
>
> since there was just one change to the branch 0.2.7 I did not yet
> publish the RC2 version. I decided to wait until monday to publishing
> RC2.
>
It seems RC1 is being forgotten about.
I know this has been discussed a few times before, but can we not look into
the possibility of branching off for releases in a different way.
Although it means changing SVN URL for HEAD, is it not better to follow the
path of branching a new HEAD and freezing the current address for the next
release. This may help people to remember to concentrate more on bugfixes
for the upcoming release and not on implementing new features to HEAD.
I'd hate to see another buggy release like 0.2.6, which was possibly a
regression on 0.2.5
Ged.
************************************************************************
The information contained in this message or any of its
attachments is confidential and is intended for the exclusive
use of the addressee. The information may also be legally
privileged. The views expressed may not be company policy,
but the personal views of the originator. If you are not the
addressee, any disclosure, reproduction, distribution or other
dissemination or use of this communication is strictly prohibited.
If you have received this message in error, please contact
postmaster(a)exideuk.co.uk
<mailto:postmaster@exideuk.co.uk> and then delete this message.
Exide Technologies is an industrial and transportation battery
producer and recycler with operations in 89 countries.
Further information can be found at www.exide.com
Hehe... Bug 666 in 16661... OK, I get the Joke ;)
On 7/20/05, navaraf(a)svn.reactos.com <navaraf(a)svn.reactos.com> wrote:
> Get rid of windows.h include in win32k. Fixes bug #666.
>
>
> Updated files:
> trunk/reactos/include/ndk/extypes.h
> trunk/reactos/include/ndk/i386/ketypes.h
> trunk/reactos/include/subsys/csrss/csrss.h
> trunk/reactos/subsys/win32k/eng/xlate.c
> trunk/reactos/subsys/win32k/ntuser/misc.c
> trunk/reactos/subsys/win32k/ntuser/scrollbar.c
> trunk/reactos/subsys/win32k/objects/text.c
> trunk/reactos/subsys/win32k/w32k.h
> trunk/reactos/w32api/include/basetyps.h
> trunk/reactos/w32api/include/ddk/ddrawi.h
> trunk/reactos/w32api/include/ddk/ddrawint.h
> trunk/reactos/w32api/include/ddraw.h
> trunk/reactos/w32api/include/oleacc.h
> trunk/reactos/w32api/include/winuser.h
>
> _______________________________________________
> Ros-svn mailing list
> Ros-svn(a)reactos.com
> http://reactos.com:8080/mailman/listinfo/ros-svn
>
--
"I had a handle on life, but then it broke"
Hi!
ion(a)svn.reactos.com wrote:
> - Update ASM header file with more offsets.
>
>
> Updated files:
> trunk/reactos/ntoskrnl/include/internal/asm.h
>
[PCH] obj-i386/ntoskrnl/include/ntoskrnl.h.gch
In file included from ntoskrnl/include/internal/ntoskrnl.h:14,
from ntoskrnl/include/ntoskrnl.h:43:
ntoskrnl/include/internal/asm.h:132:1: "CONTEXT_FULL" redefined
In file included from w32api/include/windef.h:249,
from w32api/include/ddk/ntddk.h:35,
from ntoskrnl/include/ntoskrnl.h:18:
w32api/include/winnt.h:1482:1: this is the location of the previous definition
In file included from ntoskrnl/include/internal/ntoskrnl.h:14,
from ntoskrnl/include/ntoskrnl.h:43:
ntoskrnl/include/internal/asm.h:133:1: "CONTEXT_FLOATING_POINT" redefined
In file included from w32api/include/windef.h:249,
from w32api/include/ddk/ntddk.h:35,
from ntoskrnl/include/ntoskrnl.h:18:
w32api/include/winnt.h:1479:1: this is the location of the previous definition
make: *** [obj-i386/ntoskrnl/include/ntoskrnl.h.gch] Error 1
Did I miss a memo or should I delete something to make this work?
Thanks,
James
8^>
greatlrd(a)svn.reactos.com wrote:
>Change some error msg from ConErr to ConOut for they are being pipe so the behover are equal with ms windows cmd
>
>
>
>Updated files:
>trunk/reactos/subsys/system/cmd/error.c
>
>_______________________________________________
>Ros-svn mailing list
>Ros-svn(a)reactos.com
>http://reactos.com:8080/mailman/listinfo/ros-svn
>
>
>
>
Hi,
I think this change is wrong (also some parts from 16579). The error
messages have always to go to the error output (STD_ERROR_HANDLE).
- Hartmut
ion(a)svn.reactos.com wrote:
> - Fix nasty APC delivery bug (in case a Kernel-Mode Special APC still returned with a Normal Routine, the Normal Routine was called with incorrect values (Special Routines take PVOID* arguments, while Normal Routines do not!))
> - Remove APC from list before setting it to non-inserted.
> - Do proper thread termination piggybacking; terminate threads in user-mode as Hartmut correctly fixed.
>
>
>Updated files:
>trunk/reactos/ntoskrnl/ke/apc.c
>trunk/reactos/ntoskrnl/ps/kill.c
>
>
>
Hi,
I do not agree to this changes. For a non system thread, we use a kernel
mode apc first, which uses a second user mode apc. This overhead isn't
necessary. For system threads it isn't possible to use a kernel mode apc
which calls PspExitThread. A system thread must terminate it self. It is
only possible to help by marking a flag, setting an event or unwait the
thread.
- Hartmut