- Ros-dev - ReactOS.org

re: ps/kill.c change
by Alex Ionescu 18 Jul '05

18 Jul '05

Hi, Sorry but I accidentally lost 60 emails including the one I'm supposed to reply to. Hartmut, you have done a recent change in kill.c in which you change the APC inside PspTerminateThreadByPointer to a user-mode APC. This is incorrect and I don't understand why it was done... furthermore, I've even documented a source of information which proves my code was correct (on top of the function header), so why did you change it? Best regards, Alex Ionescu

2 2

Re: web page
by yash 18 Jul '05

18 Jul '05

Website proposal looks good. I don't know if my opinion worth a cent, but I think the lines between left bar menu items make it harder to read and understand. The freebsd.org style is much simpler for brain to acquire and understand, when you only have one bold line around the whole navigation panel, and the items are separated with simple BR tag. Every extra line creates an extra load in your reception systems and occupy brain neuro cycles that can be used for thinking about content or other high abstract concepts instead. Thanks Yash >> http://frik85.fr.funpic.de/reactos/en/index.htm (HTML version) > >Nice and clear design, fresh colors. :) >I'd like to see this proposal as new homepage. > Martin

1 0

Website Design and Layout
by Rick Langschultz 18 Jul '05

18 Jul '05

Hey all, Just a second thought about the website that ReactOS is planning on updating. There are several ideas out there and several layouts. Here are my suggestions: Fedora Core 4 OpenLDAP for user information and Login functions Perl and PHP Apache 2.0.xx POP3 and Imap4 email access NNTP service MySQL for CMS, Wiki, Portal Postgresql for CMS, Portal, Wiki I also believe in sticking with a header, and a three column layout, as well as a footer. The site should be updateable by either database (MySQL or Postgresql) or XML. Should provide login credential system that will allow admins to add news and features. I think users should be allowed or have access to giving detailed system data to allow developers to focus on certain devices, drivers, and applications. This would allow a user to also check the status on a new optimized driver or binary, or any updates that React my want to distribute for download. Later ReactOS.com should integrate with the currently installed software on the users system to alert them of new releases, patches, updates, and information; much like windows update. I also think that the portal system should allow users to check @reactos.com email or provide it in attempts to raise money for the site. Another great thing that I know major OS manufacturers include is a development library/ I think that we should list the source code and allow users to browse it much like webCVS but also to annotate it, and allow a user to chat in a forum type environment if they don't understand a line of the code. Just a few thoughts on color: KISS (Keep it simple stupid). Keep color usage minimal and allow the user to customize it to their liking with templates.

1 0

(no subject)
by reactos 18 Jul '05

18 Jul '05

I wonder how the development of the USB stack is going, the wiki "blog" is kind of old, I tested the USB tool mentioned in the forum some month ago, but it was just info it provided, how is it going with for example keyboard and mouse support? Yours sincerely, Jaix Bly

1 0

Re: [ros-svn] [robertk] 16570: the release branch should be dbg=0
by Emanuele Aliberti 18 Jul '05

18 Jul '05

robertk(a)svn.reactos.com wrote: >the release branch should be dbg=0 > > >Updated files: >branches/ros-branch-0_2_7/reactos/config.template.xml > >_______________________________________________ >Ros-svn mailing list >Ros-svn(a)reactos.com >http://reactos.com:8080/mailman/listinfo/ros-svn > > > Hi Robert, shouldn't the config.template.xml be read only? -- :Emanuele Aliberti

4 6

Re: [ros-svn] [mbosma] 16593: - Build failure
by Gge 17 Jul '05

17 Jul '05

mbosma(a)svn.reactos.com wrote: > HUMA2000: Spanish translation > > > Updated files: > trunk/rosapps/packmgr/lib/es.rc > Building the Rosapps module fails with the following error : D:\Reactos\Svn\rosapps>svn update U packmgr\lib\es.rc Updated to revision 16597. D:\Gerard\Reactos\Svn\rosapps>mingw32-make clean mingw32-make: *** No rule to make target `clean'. Stop. Any idea ? Best regards

3 7

ArrangeIconicWindows
by James Tabor 16 Jul '05

16 Jul '05

Hi All, I'm starting to get a headache. This is a port from wine to win32k/ntuser/winpos.c. It does compile. But it is so butt ugly! I'm in the process of fixing MDI. So far, testing with winefile.exe has come down to this one function. So this is open for peer review. I'm tired. 8^( Thanks, James BOOL FASTCALL IntIsIconic(HWND hWnd) { return (NtUserGetWindowLong( hWnd, GWL_STYLE, FALSE) & WS_MINIMIZE) != 0; } BOOL FASTCALL IntIsWindowEnabled( HWND hWnd) { return (! (NtUserGetWindowLong(hWnd, GWL_STYLE, FALSE) & WS_DISABLED)); } #define MAKEINTATOMW(atom) ((LPCWSTR)((ULONG_PTR)((WORD)(atom)))) #define ICONTITLE_CLASS_ATOM MAKEINTATOMW(32772) static ATOM atomInternalPos; extern HWND FASTCALL IntSetOwner(HWND hWnd, HWND hWndNewOwner); extern HWND STDCALL IntCreateWindowEx(DWORD dwExStyle, PUNICODE_STRING ClassName, PUNICODE_STRING WindowName, DWORD dwStyle, LONG x, LONG y, LONG nWidth, LONG nHeight, HWND hWndParent, HMENU hMenu, HINSTANCE hInstance, LPVOID lpParam, DWORD dwShowMode, BOOL bUnicodeWindow); HWND FASTCALL ICONTITLE_Create( HWND owner ) { HWND hWnd; UNICODE_STRING ClassName; HINSTANCE instance = (HINSTANCE)NtUserGetWindowLong( owner, GWL_HINSTANCE, FALSE ); LONG style = WS_CLIPSIBLINGS; RtlInitUnicodeString(&ClassName, NULL); ClassName.Buffer = (LPWSTR)ICONTITLE_CLASS_ATOM; if (!IntIsWindowEnabled(owner)) style |= WS_DISABLED; if( NtUserGetWindowLong( owner, GWL_STYLE,FALSE ) & WS_CHILD ) hWnd = IntCreateWindowEx( 0, &ClassName, NULL, style | WS_CHILD, 0, 0, 1, 1, NtUserGetParent(owner), 0, instance, NULL,SW_SHOW,TRUE ); else hWnd = IntCreateWindowEx( 0, &ClassName, NULL, style, 0, 0, 1, 1, owner, 0, instance, NULL,SW_SHOW,TRUE ); IntSetOwner( hWnd, owner ); /* MDI depends on this */ NtUserSetWindowLong( hWnd, GWL_STYLE, NtUserGetWindowLong( hWnd, GWL_STYLE,FALSE ) & ~(WS_CAPTION | WS_BORDER), FALSE ); return hWnd; } BOOL FASTCALL WinPosShowIconTitle(HWND hWnd, BOOL bShow) { PWINDOW_OBJECT WindowObject; PINTERNALPOS lpPos; /* This way or??? */ lpPos = (PINTERNALPOS)NtUserGetProp( hWnd, atomInternalPos ); if (!(WindowObject = IntGetWindowObject(hWnd))) { return FALSE; } /* This way? Dont know! */ lpPos = WindowObject->InternalPos; if (lpPos ) { HWND title = 0;//lpPos->hwndIconTitle; if( !title ) // lpPos->hwndIconTitle = title = ICONTITLE_Create( hWnd ); if( bShow ) { if (!IntIsWindowVisible(title)) { IntSendMessage( title, WM_SHOWWINDOW, TRUE, 0 ); WinPosSetWindowPos( title, 0, 0, 0, 0, 0, SWP_NOSIZE | SWP_NOMOVE | SWP_NOACTIVATE | SWP_NOZORDER | SWP_SHOWWINDOW ); } } else WinPosShowWindow( title, SW_HIDE ); } IntReleaseWindowObject(WindowObject); return TRUE; } UINT FASTCALL WinPosArrangeIconicWindows(PWINDOW_OBJECT parent) { RECT rectParent; HWND hwndChild; INT i, x, y, xspacing, yspacing; HWND *List = IntWinListChildren(parent); IntGetClientRect( parent, &rectParent ); x = rectParent.left; y = rectParent.bottom; xspacing = NtUserGetSystemMetrics(SM_CXICONSPACING); yspacing = NtUserGetSystemMetrics(SM_CYICONSPACING); for( i = 0; List[i]; i++) { hwndChild = List[i]; if( IntIsIconic( hwndChild ) ) { WinPosShowIconTitle( hwndChild, FALSE ); WinPosSetWindowPos( hwndChild, 0, x + (xspacing - NtUserGetSystemMetrics(SM_CXICON)) / 2, y - yspacing - NtUserGetSystemMetrics(SM_CYICON)/2, 0, 0, SWP_NOSIZE | SWP_NOZORDER | SWP_NOACTIVATE ); if( IntIsWindow(hwndChild) ) WinPosShowIconTitle(hwndChild , TRUE ); if (x <= rectParent.right - xspacing) x += xspacing; else { x = rectParent.left; y -= yspacing; } } } ExFreePool(List); return yspacing; }

1 0

Patch: GetMenuString
by Jens Collin 16 Jul '05

16 Jul '05

Hello, my old cvs account is no longer working on the new svn server so I'm sending the patch here and hope that someone could take a moment to commit it for me. Thanks, Jens Collin Changelog: GetMenuStringA and GetMenuStringW inverted the MF_BYPOSITION parameter. Buffers were incorrectly copied in and wrong size returned in GetMenuItemInfoA ansi-structures. GetMenuString now works the same on both windows and ROS. Index: lib/user32/windows/menu.c =================================================================== --- lib/user32/windows/menu.c (revision 16591) +++ lib/user32/windows/menu.c (working copy) @@ -3772,7 +3772,7 @@ RtlCopyMemory(mii, &miiW, miiW.cbSize); mii->dwTypeData = AnsiBuffer; - + mii->cch = strlen(AnsiBuffer); return TRUE; } @@ -3864,11 +3864,11 @@ MENUITEMINFOA mii; mii.dwTypeData = lpString; mii.fMask = MIIM_STRING; + mii.fType = MF_STRING; mii.cbSize = sizeof(MENUITEMINFOA); mii.cch = nMaxCount; - UNIMPLEMENTED; - if(!(GetMenuItemInfoA( hMenu, uIDItem, (BOOL)!(MF_BYPOSITION & uFlag),&mii))) + if(!(GetMenuItemInfoA( hMenu, uIDItem, (BOOL)(MF_BYPOSITION & uFlag),&mii))) return 0; else return mii.cch; @@ -3893,10 +3893,9 @@ miiW.cbSize = sizeof(MENUITEMINFOW); miiW.cch = nMaxCount; - UNIMPLEMENTED; - if(!(GetMenuItemInfoW( hMenu, uIDItem, (BOOL)!(MF_BYPOSITION & uFlag),&miiW))) + if(!(GetMenuItemInfoW( hMenu, uIDItem, (BOOL)(MF_BYPOSITION & uFlag),&miiW))) return 0; - else + else return miiW.cch; } @@ -4318,11 +4317,11 @@ mii.fState = MFS_ENABLED; UNIMPLEMENTED; - + if(!GetMenuItemInfoA( hMnu, uPosition, (BOOL)!(MF_BYPOSITION & uFlags), - &mii)) return FALSE; + &mii)) return FALSE; if(uFlags & MF_BITMAP) { @@ -4341,7 +4340,7 @@ if(mii.dwTypeData != NULL) { HeapFree(GetProcessHeap(),0, mii.dwTypeData); - } + } /* Item beginning with a backspace is a help item */ if (*lpNewItem == '\b') { @@ -4352,7 +4351,7 @@ mii.dwTypeData = (LPSTR)lpNewItem; mii.cch = (NULL == lpNewItem ? 0 : strlen(lpNewItem)); } - + if(uFlags & MF_RIGHTJUSTIFY) { mii.fType |= MFT_RIGHTJUSTIFY; @@ -4439,7 +4438,7 @@ if(mii.dwTypeData != NULL) { HeapFree(GetProcessHeap(),0, mii.dwTypeData); - } + } if (*lpNewItem == '\b') { mii.fType |= MF_HELP; @@ -4449,7 +4448,7 @@ mii.dwTypeData = (LPWSTR)lpNewItem; mii.cch = (NULL == lpNewItem ? 0 : wcslen(lpNewItem)); } - + if(uFlags & MF_RIGHTJUSTIFY) { mii.fType |= MFT_RIGHTJUSTIFY;

1 0

Explorer Crash
by James Tabor 15 Jul '05

15 Jul '05

Hi, C:\ReactOS>explorer <cr> no problem runs fine. [-]- My Computer | [+]- (C:) ^ Click here and,,,, (ntoskrnl/io/file.c:125) Failed to mount logical volume (Status c000014f) (ntoskrnl/io/file.c:125) Failed to mount logical volume (Status c000014f) (ntoskrnl/io/file.c:125) Failed to mount logical volume (Status c000014f) (KERNEL32:lib/kernel32/file/file.c:859) Invalid path (lib/shell32/shell32_main.c:393:SHGetFileInfoW) pidl is null! (KERNEL32:lib/kernel32/file/file.c:859) Invalid path (KERNEL32:lib/kernel32/file/file.c:859) Invalid path (subsys/win32k/ntuser/misc.c:753) HWNDLOCK_ROUTINE_DRAWMENUBAR (lib/user32/windows/menu.c:4417)(ModifyMenuW) is unimplemented, please try again later. (lib/shell32/shell32_main.c:465:SHGetFileInfoW) set icon to link, stub (lib/shell32/shell32_main.c:465:SHGetFileInfoW) set icon to link, stub ne2000!NICIndicatePacket: Indicating (64) bytes. (ntoskrnl/io/file.c:125) Failed to mount logical volume (Status c000014f) (ntoskrnl/io/file.c:125) Failed to mount logical volume (Status c000014f) (ntoskrnl/io/file.c:125) Failed to mount logical volume (Status c000014f) (ntoskrnl/io/file.c:125) Failed to mount logical volume (Status c000014f) (ntoskrnl/io/file.c:125) Failed to mount logical volume (Status c000014f) (ntoskrnl/io/file.c:125) Failed to mount logical volume (Status c000014f) (ntoskrnl/io/file.c:125) Failed to mount logical volume (Status c000014f) (ntoskrnl/io/file.c:125) Failed to mount logical volume (Status c000014f) (ntoskrnl/io/file.c:125) Failed to mount logical volume (Status c000014f) (ntoskrnl/io/file.c:125) Failed to mount logical volume (Status c000014f) (ntoskrnl/io/file.c:125) Failed to mount logical volume (Status c000014f) (ntoskrnl/io/file.c:125) Failed to mount logical volume (Status c000014f) (lib/shell32/shell32_main.c:465:SHGetFileInfoW) set icon to link, stub (lib/shell32/shell32_main.c:465:SHGetFileInfoW) set icon to link, stub (lib/shell32/shell32_main.c:465:SHGetFileInfoW) set icon to link, stub (lib/shell32/shell32_main.c:465:SHGetFileInfoW) set icon to link, stub (lib/shell32/shellole.c:237:SHELL32_DllGetClassObject) failed for CLSID= {645ff040-5081-101b-9f08-00aa002f954e} (unknown) (lib/shell32/shellole.c:167:SHCoCreateInstance) LoadFromShell failed for CLSID= {645ff040-5081-101b-9f08-00aa002f954e} (unknown) (lib/shell32/shellole.c:237:SHELL32_DllGetClassObject) failed for CLSID= {645ff040-5081-101b-9f08-00aa002f954e} (unknown) (lib/shell32/shellole.c:167:SHCoCreateInstance) LoadFromShell failed for CLSID= {645ff040-5081-101b-9f08-00aa002f954e} (unknown) (lib/shell32/shellole.c:237:SHELL32_DllGetClassObject) failed for CLSID= {645ff040-5081-101b-9f08-00aa002f954e} (unknown) (lib/shell32/shellole.c:167:SHCoCreateInstance) LoadFromShell failed for CLSID= {645ff040-5081-101b-9f08-00aa002f954e} (unknown) ???????????????? Context: ShellFolder::ShellFolder(IShellFolder*, LPCITEMIDLIST) Location: subsys/system/explorer/utility/shellclasses.cpp:280 Context Trace: - ShellFolder::ShellFolder(IShellFolder*, LPCITEMIDLIST) - ShellDirectory::read_directory() - Entry::read_directory_base() - Entry::smart_scan() - ShellBrowser::InsertSubitems() - ShellBrowser::OnTreeItemExpanding() - explorer_main - WinMain() - main (ntoskrnl/mm/mm.c:344) Address: ffffffff _SEHCallHandler: REG 007fe30c _SEHCallHandler: REG 007fe7d8 _SEHCallHandler: REG 007fe7d8 Unhandled exception Address: 46e0d6 C:\ReactOS\explorer.EXE CS:EIP 1b:46e0d6 DS 23 ES 23 FS 3b GS 23 EAX: 00000000 EBX: 00941e88 ECX: 007feb28 EDX: 00941e58 EBP: 007fecb8 ESI: 00000000 ESP: 007fecb0 EDI: 00000000 EFLAGS: 00010206 Frames: 400000+3aee5 C:\ReactOS\explorer.EXE 400000+81c36 C:\ReactOS\explorer.EXE 400000+106da C:\ReactOS\explorer.EXE 400000+8625 C:\ReactOS\explorer.EXE 400000+8bef C:\ReactOS\explorer.EXE 400000+1e897 C:\ReactOS\explorer.EXE 400000+1e799 C:\ReactOS\explorer.EXE 400000+85f61 C:\ReactOS\explorer.EXE 400000+3e4d9 C:\ReactOS\explorer.EXE 77e50000+5385e C:\ReactOS\system32\user32.dll 77e50000+5450c C:\ReactOS\system32\user32.dll 76160000+6f0ce C:\ReactOS\system32\comctl32.dll 76160000+6f388 C:\ReactOS\system32\comctl32.dll 76160000+735bb C:\ReactOS\system32\comctl32.dll 76160000+73a11 C:\ReactOS\system32\comctl32.dll 76160000+73cc8 C:\ReactOS\system32\comctl32.dll 76160000+7507e C:\ReactOS\system32\comctl32.dll 76160000+781b6 C:\ReactOS\system32\comctl32.dll 77e50000+5385e C:\ReactOS\system32\user32.dll 77e50000+53b83 C:\ReactOS\system32\user32.dll 400000+3f889 C:\ReactOS\explorer.EXE 400000+4a744 C:\ReactOS\explorer.EXE 400000+4af37 C:\ReactOS\explorer.EXE 400000+4a857 C:\ReactOS\explorer.EXE 400000+11e7 C:\ReactOS\explorer.EXE 400000+1258 C:\ReactOS\explorer.EXE 7c800000+2f105 C:\ReactOS\system32\KERNEL32.dll _SEHCallHandler: REG 007fe858 _SEHCallHandler: REG 007fffb8 _SEHCallHandler: REG 007fffb8 (lib/comctl32/toolbar.c:416:TOOLBAR_GetImageListForDrawing) bitmap for ID 0, ind ex 1 is not valid, number of bitmaps in imagelist: 0 (lib/comctl32/toolbar.c:416:TOOLBAR_GetImageListForDrawing) bitmap for ID 0, ind ex 1 is not valid, number of bitmaps in imagelist: 0 BTW, this is happening for a week or so. Thanks, James

1 0

Errors with Building Reactos.
by James Tabor 15 Jul '05

15 Jul '05

Build ros on ros update. Make clean, (lib/rtl/error.c:903) RTL: RtlNtStatusToDosErrorNoTeb(0xc000002f): no valid W32 error mapping And this, (subsys/csrss/win32csr/conio.c:995) Console_Api Ctrl-C (lib/ntdll/ldr/startup.c:405) Failed to access the process parameter block (KERNEL32:lib/kernel32/misc/console.c:2954) GenerateConsoleCtrlEvent(0x0, 0x128) UNIMPLEMENTED! Assertion '*SpinLock < 2' failed at ntoskrnl/ke/spinlock.c line 181 (ntoskrnl/mm/mm.c:319) Page fault at high IRQL was 2, address cccccccc KeBugCheckWithTf at ntoskrnl/ke/catch.c:217 Spinning on spinlock 800ec340 current value 1 KeBugCheckEx at ntoskrnl/ke/spinlock.c:198 Spinning on spinlock 800ec340 current value 1 KeBugCheckEx at ntoskrnl/ke/spinlock.c:198 Spinning on spinlock 800ec340 current value 1 *Snip* Spinning on spinlock 800ec340 current value 1 KeBugCheckEx at ntoskrnl/ke/spinlock.c:198 Stack underflow (tf->esp 9d588fc0 Limit 9d5a9000) Stack Segment Fault Exception: 12(0) CS:EIP 8:80082203 <ntoskrnl.exe:82203 (ntoskrnl/rtl/sprintf.c:77 (number))> cr2 9d588fbc cr3 8b1c000 Proc: 81750210 Pid: 134 <make.exe> Thrd: 81940398 Tid: 158 DS 10 ES 10 FS 30 GS 10 EAX: 9d589105 EBX: 9d5895e8 ECX: 800ec340 EDX: 00000000 EBP: 9d589058 ESI: 0000000e ESP: 9d588fc0 EDI: 81940398 EFLAGS: 00010286 kESP 9d588fc0 kernel stack base 9 d5a9000 Frames: Major lockup! James

2 2

Compilation problem
by Sebastian Gasiorek 14 Jul '05

14 Jul '05

Hi. I Have some problems with compiling ReactOS (for about 3-4 days) using MinGW-Special or current (gcc 3.4.4). here is the output of the compiler: [CC] lib\rtl\ppb.c lib\rtl\ppb.c: In function `RtlCreateProcessParameters': lib\rtl\ppb.c:89: error: structure has no member named `CurrentDirectory' lib\rtl\ppb.c:90: error: structure has no member named `CurrentDirectory' lib\rtl\ppb.c:91: error: structure has no member named `ConsoleHandle' lib\rtl\ppb.c:92: error: structure has no member named `ConsoleFlags' lib\rtl\ppb.c:148: error: structure has no member named `MaximumLength' lib\rtl\ppb.c:149: error: structure has no member named `Length' lib\rtl\ppb.c:152: error: structure has no member named `CurrentDirectory' lib\rtl\ppb.c:153: error: structure has no member named `ConsoleHandle' lib\rtl\ppb.c:154: error: structure has no member named `ConsoleFlags' lib\rtl\ppb.c:160: error: structure has no member named `CurrentDirectory' lib\rtl\ppb.c:165: error: structure has no member named `CurrentDirectory' lib\rtl\ppb.c:169: error: structure has no member named `CurrentDirectory' lib\rtl\ppb.c:170: error: structure has no member named `CurrentDirectory' lib\rtl\ppb.c:172: error: structure has no member named `CurrentDirectory' lib\rtl\ppb.c:173: error: structure has no member named `CurrentDirectory' lib\rtl\ppb.c:174: error: structure has no member named `CurrentDirectory' lib\rtl\ppb.c:216: error: structure has no member named `RuntimeData' lib\rtl\ppb.c: In function `RtlDeNormalizeProcessParams': lib\rtl\ppb.c:251: error: structure has no member named `CurrentDirectory' lib\rtl\ppb.c:251: error: structure has no member named `CurrentDirectory' lib\rtl\ppb.c:251: error: structure has no member named `CurrentDirectory' lib\rtl\ppb.c:258: error: structure has no member named `RuntimeData' lib\rtl\ppb.c:258: error: structure has no member named `RuntimeData' lib\rtl\ppb.c:258: error: structure has no member named `RuntimeData' lib\rtl\ppb.c: In function `RtlNormalizeProcessParams': lib\rtl\ppb.c:276: error: structure has no member named `CurrentDirectory' lib\rtl\ppb.c:276: error: structure has no member named `CurrentDirectory' lib\rtl\ppb.c:276: error: structure has no member named `CurrentDirectory' lib\rtl\ppb.c:283: error: structure has no member named `RuntimeData' lib\rtl\ppb.c:283: error: structure has no member named `RuntimeData' lib\rtl\ppb.c:283: error: structure has no member named `RuntimeData' make: *** [obj-i386\lib\rtl\ppb.o] Error 1 what have I done wrong? thanks, Sebastian

3 3

svn.reactos.com machine down for maintenance
by Casper Hornstrup 14 Jul '05

14 Jul '05

Hi. I'm taking the svn.reactos.com machine down for maintenance. It shouldn't take long. Sorry for the inconvenience. Casper

1 3

Re: [ros-svn] [jimtabor] 16559: Implemented VkKeyScan, GetKeyboardTypeand, GetKeyboardLayout and some Wine ports.
by James Tabor 14 Jul '05

14 Jul '05

jimtabor(a)svn.reactos.com wrote: > Implemented VkKeyScan, GetKeyboardTypeand, GetKeyboardLayout and some Wine ports. > > > Updated files: > trunk/reactos/lib/user32/windows/input.c > FYI, Xp results, VkKeyScan 186, OemKey 39 VkKeyScan A: CapsMode 1 Scan 65 VkKeyScan B: CapsMode 1 Scan 66 VkKeyScan C: CapsMode 1 Scan 67 **snip** VkKeyScan 0: CapsMode 0 Scan 48 VkKeyScan 1: CapsMode 0 Scan 49 VkKeyScan 2: CapsMode 0 Scan 50 VkKeyScan 3: CapsMode 0 Scan 51 VkKeyScan 4: CapsMode 0 Scan 52 VkKeyScan 5: CapsMode 0 Scan 53 VkKeyScan 6: CapsMode 0 Scan 54 VkKeyScan 7: CapsMode 0 Scan 55 VkKeyScan 8: CapsMode 0 Scan 56 VkKeyScan 9: CapsMode 0 Scan 57 VkKeyScan :: CapsMode 1 Scan 186 Wine results, VkKeyScan 186, OemKey 59 VkKeyScan A: CapsMode 1 Scan 65 VkKeyScan B: CapsMode 1 Scan 66 VkKeyScan C: CapsMode 1 Scan 67 **snip** VkKeyScan 0: CapsMode 0 Scan 48 VkKeyScan 1: CapsMode 0 Scan 49 VkKeyScan 2: CapsMode 0 Scan 50 VkKeyScan 3: CapsMode 0 Scan 51 VkKeyScan 4: CapsMode 0 Scan 52 VkKeyScan 5: CapsMode 0 Scan 53 VkKeyScan 6: CapsMode 0 Scan 54 VkKeyScan 7: CapsMode 0 Scan 55 VkKeyScan 8: CapsMode 0 Scan 56 VkKeyScan 9: CapsMode 0 Scan 57 VkKeyScan :: CapsMode 1 Scan 186 ReactOS results, VkKeyScan 186, OemKey 39 VkKeyScan A: CapsMode 1 Scan 65 VkKeyScan B: CapsMode 1 Scan 66 VkKeyScan C: CapsMode 1 Scan 67 **snip** VkKeyScan 0: CapsMode 0 Scan 96 VkKeyScan 1: CapsMode 0 Scan 97 VkKeyScan 2: CapsMode 0 Scan 98 VkKeyScan 3: CapsMode 0 Scan 99 VkKeyScan 4: CapsMode 0 Scan 100 VkKeyScan 5: CapsMode 0 Scan 101 VkKeyScan 6: CapsMode 0 Scan 102 VkKeyScan 7: CapsMode 0 Scan 103 VkKeyScan 8: CapsMode 0 Scan 104 VkKeyScan 9: CapsMode 0 Scan 105 VkKeyScan :: CapsMode 1 Scan 186 Notice anything different? James

1 0

ObjectHeader has invalid reference count Errors
by James Tabor 14 Jul '05

14 Jul '05

Hi all! When running AbiWord this is happening. Everything works, just more of these errors. I think the first clue is this next line, (subsys/win32k/m(subsys/win32k/objects/gdiobj.c:1289) Attempted to change owner isc/object.c:50) ObjectHeader 0x8D0E0140 has invalid reference count (-2) (subsys/win32k/misc/object.c:50) ObjectHeader 0x8D0E6808 has invalid reference c ount (-2) (subsys/win32k/misc/object.c:50) ObjectHeade ship of object 0x2304035f (pid: 0x12c) from pid 0x128!!! (subsys/win32k/objects/gdiobj.c:589) Attempted to free foreign handle: 0x2304035 f Owner: 0x12c from Caller: 0x128 r 0x8D0E65B8 has invalid reference count (-2) (subsys/win32k/misc/object.c:50) ObjectHeader 0x8D0E0140 has invalid reference c ount (-2) (subsys/win32k/misc/object.c:50) ObjectHeader 0x8D0E6808 has invalid reference c ount (-2) (subsys/win32k/misc/object.c:50) ObjectHeader 0x8D0E65B8 has invalid reference c ount (-2) (subsys/win32k/misc/object.c:50) ObjectHeader 0x8D0E0140 has invalid reference c ount (-2) (subsys/win32k/misc/object.c:50) ObjectHeader 0x8D0E6808 has invalid reference c ount (-2) on and on Thanks, James

1 0

Re: [ros-diffs] [greatlrd] 16528: The return size calculation's of GetEnvironmentVariable string was wrong. Thx to <Bizzy_D> to find out cd %windir% did not work. Now it will
by Hartmut Birr 13 Jul '05

13 Jul '05

greatlrd(a)svn.reactos.com wrote: >The return size calculation's of GetEnvironmentVariable string was wrong. Thx to <Bizzy_D> to find out cd %windir% did not work. Now it will > >Modified: trunk/reactos/lib/kernel32/misc/env.c > > > ------------------------------------------------------------------------ > *Modified: trunk/reactos/lib/kernel32/misc/env.c* > >--- trunk/reactos/lib/kernel32/misc/env.c 2005-07-10 22:05:48 UTC (rev 16527) >+++ trunk/reactos/lib/kernel32/misc/env.c 2005-07-10 22:12:07 UTC (rev 16528) >@@ -70,7 +70,7 @@ > >@@ -133,7 +133,7 @@ > > > } > } > > > >- return (VarValue.Length / sizeof(WCHAR)); > > >+ return (VarValue.Length / sizeof(WCHAR) + sizeof(WCHAR)); > > > } > > > > Hi, this change is wrong. The MSDN library says: If the function succeeds, the return value is the number of TCHARs stored into the buffer pointed to by /lpBuffer/, not including the terminating null character. Please revert your change. - Hartmut

3 6

Re: [ros-diffs] [weiden] 16553: handle memory allocation errors in GetEnvironmentVariable() and ensure the string is always null-terminated
by Joseph Galbraith 13 Jul '05

13 Jul '05

> + VarValue.MaximumLength = (nSize != 0 ? (nSize - 1) * sizeof(WCHAR) : 0); > > VarValue.Buffer = lpBuffer; > > Status = RtlQueryEnvironmentVariable_U (NULL, > @@ -125,13 +150,17 @@ > > SetLastErrorByStatus (Status); > if (Status == STATUS_BUFFER_TOO_SMALL) > { > > - return (VarValue.Length / sizeof(WCHAR)) + 1; > > + return (VarValue.Length / sizeof(WCHAR)) + 1; > > } > else > { > return 0; > } > } > > + > + /* make sure the string is NULL-terminated! RtlQueryEnvironmentVariable_U > + only terminates it if MaximumLength < Length */ > + VarValue.Buffer[VarValue.Length / sizeof(WCHAR)] = L'\0'; Is it possible for an environment variable's value to be empty? If it is, RtlQueryEnvironmentVariable_U() could succeeded even if a zero length buffer is passed in. And then, would we crash appending the NUL termination? Since GetEnvironmentVariable has to have a buffer of at least one character to succeed, maybe we should add such a guard to the top of the function... Thanks, Joseph

2 1

Console Csrss Handle Errors
by James Tabor 12 Jul '05

12 Jul '05

Hi all, Bored again, decided to build ros on ros. Getting this, (subsys/csrss/api/handle.c:75) CsrGetObject returning invalid handle (KERNEL32:lib/kernel32/mem/global.c:412) Memory Load: 11 (KERNEL32:lib/kernel32/mem/global.c:412) Memory Load: 11 (subsys/csrss/api/handle.c:75) CsrGetObject returning invalid handle (subsys/csrss/api/handle.c:75) CsrGetObject returning invalid handle Things I noticed may have been fixed, Multi cmd problem, handle count going throw the roof and hangs. Thanks, James

5 11

Something Completely Different!
by James Tabor 12 Jul '05

12 Jul '05

Hi! When compiling ros on ros this happens. The build process, well nothing has changed for more than a year, except cmd and the dlls. make[2]: Entering directory `C:/ros/reactos/apps/utils/rundl32' windres --include-dir ../../../include --include-dir ../../../w32api/include ru ndll32.rc -o rundll32.coff gcc -DUNICODE -Wall -Werror -D__USE_W32API -I. -I../../../include -I../../../w32 api/include -pipe -march=i386 -D_M_IX86 -c rundll32.c -o rundll32.o make[2]: *** No rule to make target `../../../dk/w32/lib/user32.a', needed by `r undll32.nostrip.exe'. Stop. I use a old build to test ros with. It gives ros hell and it is small too. Doesnt use much disk space. Thanks, James

1 0

Branch to 0.2.7 happened tonight
by Robert Köpferl 11 Jul '05

11 Jul '05

Hi a new branch ros-branch-0_2_7 * r16538 exists, now. Please be cautious in terms of to which branch you commit and that this branch remains buildable. The next days there will be a binary distribution as RC1 whilst RC2 or final will follow.

1 0

Re: [ros-diffs] [weiden] 16536: return the length of the string excluding the null-termination character on success in GetEnvironmentVariable(). Thanks to Hartmut.
by Joseph Galbraith 11 Jul '05

11 Jul '05

It seems like there is some uncertainty between this code and RtlQueryEnvironmentVariable_U about who is going to ensure that the string returned from GetEnvironmentVariable() is nul terminated... If I read the code in RtlQueryEnvironmentVariable_U correctly (and I don't swear I have), it is possible for it to return STATUS_SUCCESS and not copy a NUL terminator. This happens if the buffer is large enough to contain the value but not the NUL terminator. This is probably correct for this function since UNICODE_STRINGs (and the Rtl* library) generally have no requirement of a NUL terminator. But then, if I read the code in GetEnvironmentVariable() correctly, I don't believe it takes this situation into account. Probably, it would be best if RtlQueryEnvironmentVariable_U _never_ copied the NUL terminator, and the caller was always responsible for adding NUL termination, if needed. Thanks, Joseph PS. MSDN is slightly unclear (to me) on how it should behave in this case, but it seems unlikely that the real GetEnvironmentVariable() returns success and a non-nul-terminated string. But I haven't written a test program to prove it. weiden(a)svn.reactos.com wrote: > return the length of the string excluding the null-termination character on success in GetEnvironmentVariable(). Thanks to Hartmut. > > Modified: trunk/reactos/lib/kernel32/misc/env.c > > ------------------------------------------------------------------------ > *Modified: trunk/reactos/lib/kernel32/misc/env.c* > > --- trunk/reactos/lib/kernel32/misc/env.c 2005-07-11 18:22:53 UTC (rev 16535) > +++ trunk/reactos/lib/kernel32/misc/env.c 2005-07-11 20:30:33 UTC (rev 16536) > @@ -91,7 +91,7 @@ > > /* free unicode variable name string */ > RtlFreeUnicodeString (&VarNameU); > > > - return (VarValueU.Length / sizeof(WCHAR) + 1); > > + return (VarValueU.Length / sizeof(WCHAR)); > > } > > > @@ -133,7 +133,7 @@ > > } > } > > > - return (VarValue.Length / sizeof(WCHAR) + 1); > > + return (VarValue.Length / sizeof(WCHAR)); > > } > > >

2 1

rbuild feature request
by Hartmut Birr 11 Jul '05

11 Jul '05

Hi, I would like it, if 'make install' does always copy all files. - Hartmut

3 2

Slackware 10 Raddr2line
by James Tabor 11 Jul '05

11 Jul '05

Hi, raddr2line, James

1 0

vga driver problem
by Hartmut Birr 11 Jul '05

11 Jul '05

Hi, it seems that the vga driver doesn't work (qemu and real hardware). - Hartmut

2 1

Re: [ros-dev] Re: [ros-svn] [navaraf] 16445: Put the page tables and hyperspace at the right place in memory (ie. Windows compatible).
by Filip Navara 11 Jul '05

11 Jul '05

4 4

Re: [ros-dev] Re: One more bug
by Quandary 09 Jul '05

09 Jul '05

On Fri, Jul 08, 2005 at 08:38:38AM +0200, Rafal Kupiec wrote: > I think I shoudn't write here this. > Person finds free time to do it and you're doing > problems. I think i'll never more write information > about bugs in your system. I shall refrain from commenting. > BTW. Please download HostiliX Sources from SVN (rev > 42). Make CD Image and boot it in VmWare or on real > hardware. This problems don't occure in HostiliX! Ummm... and please sign up for the bugzilla system to submit your bugs? You, as a full-time employee, can't be bothered to sign up for bugzilla, but you expect all of us to go download the entire HostiliX repo (some on dialup), compile it, and boot it... just to prove/disprove that the bug does or doesn't exist in code that's not even ours? Methinks you're holding a double-standard -- a very self-centered one at that. Your time is -so- precious that you can't be bothered to go through, at most, a 30-minute, one-time process in order to properly report a bug, yet you think our time is soooo expendable that we should go through a process that could easily take some of us over an hour to do. Not only that, but the process you want -us- to go through doesn't even result in work getting done -- it would succeed only in stroking your ego. Look! ReactOS has a bug that HostiliX doesn't! Whoop-de-doo! Now what? We can't re-use your code, since it's considered "tainted," so we don't gain anything by verifying that the HostiliX code does/doesn't work. For the record: How many people on this list have full-time jobs not related to ReactOS? When I joined the ReactOS Bugzilla, I was a full-time college student (15 credits, 22 hours of class/travel a week, another 20+ hours in homework easily). -- Travis __________________________________ Discover Yahoo! Have fun online with music videos, cool games, IM and more. Check it out! http://discover.yahoo.com/online.html

2 1

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev