- Ros-dev - ReactOS.org

Re: [ros-diffs] [chorns] 16520: Don't rebuild the module if a library is changed. Relinking the module is enough.
by Royce Mitchell III 09 Jul '05

09 Jul '05

chorns(a)svn.reactos.com wrote: >Don't rebuild the module if a library is changed. Relinking the module is enough. > >Modified: trunk/reactos/tools/rbuild/backend/mingw/modulehandler.cpp >Modified: trunk/reactos/tools/rbuild/backend/mingw/modulehandler.h > > > ------------------------------------------------------------------------ > *Modified: trunk/reactos/tools/rbuild/backend/mingw/modulehandler.cpp* > >--- trunk/reactos/tools/rbuild/backend/mingw/modulehandler.cpp 2005-07-09 05:21:10 UTC (rev 16519) >+++ trunk/reactos/tools/rbuild/backend/mingw/modulehandler.cpp 2005-07-09 07:50:48 UTC (rev 16520) >@@ -874,7 +874,9 @@ > > dependencies += " " + GetPrecompiledHeaderFilename (); > > /* WIDL generated headers may be used */ > > >- dependencies += " " + GetLinkingDependenciesMacro (); > > >+ vector<string> rpcDependencies; >+ GetRpcHeaderDependencies ( rpcDependencies ); >+ dependencies += " " + v2s ( rpcDependencies, 5 ); > > > dependencies += " " + NormalizeFilename ( module.xmlbuildFile ); > > string objectFilename = GetObjectFilename ( >@@ -1598,7 +1600,7 @@ > > > > void > MingwModuleHandler::GetRpcHeaderDependencies ( > > >- string_list& dependencies ) const > > >+ vector<string>& dependencies ) const > > > { > for ( size_t i = 0; i < module.non_if_data.libraries.size (); i++ ) > { >@@ -1640,7 +1642,7 @@ > > > module.non_if_data, > &module.linkerFlags ); > > > >- string_list s; > > >+ vector<string> s; > > > if ( module.importLibrary ) > { > const vector<File*>& files = module.non_if_data.files; >@@ -1652,7 +1654,6 @@ > > > GetSpecObjectDependencies ( s, file.name ); > } > } > > >- GetRpcHeaderDependencies ( s ); > > > if ( s.size () > 0 ) > { > fprintf ( > > > ------------------------------------------------------------------------ > *Modified: trunk/reactos/tools/rbuild/backend/mingw/modulehandler.h* > >--- trunk/reactos/tools/rbuild/backend/mingw/modulehandler.h 2005-07-09 05:21:10 UTC (rev 16519) >+++ trunk/reactos/tools/rbuild/backend/mingw/modulehandler.h 2005-07-09 07:50:48 UTC (rev 16520) >@@ -179,7 +179,7 @@ > > void GenerateBuildMapCode (); > void GenerateBuildNonSymbolStrippedCode (); > void CleanupFileVector ( std::vector<File*>& sourceFiles ); > > >- void GetRpcHeaderDependencies ( string_list& dependencies ) const; > > >+ void GetRpcHeaderDependencies ( std::vector<std::string>& dependencies ) const; > > > std::string GetRpcServerHeaderFilename ( std::string basename ) const; > std::string GetRpcClientHeaderFilename ( std::string basename ) const; > public: > > I thought string_list was a typedef for vector<string>, why the change?

2 2

Re: [ros-svn] [ekohl] 16524: Fix a string length calculation bug in StringTableDuplicate.
by Thomas Weidenmueller 09 Jul '05

09 Jul '05

ekohl(a)svn.reactos.com wrote: > Fix a string length calculation bug in StringTableDuplicate. Thanks for fixing it properly, that was a really awkward mistake ;) Best Regards, Thomas

1 0

One more bug
by Rafal Kupiec 08 Jul '05

08 Jul '05

When i click right mouse button on menu it freezes system but i can run mouse. Maybe freezes software only?

4 4

RE: [ros-dev] Re: A few bugs
by Murphy, Ged (Bolton) 08 Jul '05

08 Jul '05

Rafal Kupiec wrote: > I won't register there. > Do it yourself. > I've informed you. You really are very rude and disrespectful. Why don't you fix them in the hostilix branch and submit your changes back to ROS? Oh that's right, you want to give code, only take, (and claim as your own) Ged ************************************************************************ The information contained in this message or any of its attachments is confidential and is intended for the exclusive use of the addressee. The information may also be legally privileged. The views expressed may not be company policy, but the personal views of the originator. If you are not the addressee, any disclosure, reproduction, distribution or other dissemination or use of this communication is strictly prohibited. If you have received this message in error, please contact postmaster(a)exideuk.co.uk <mailto:postmaster@exideuk.co.uk> and then delete this message. Exide Technologies is an industrial and transportation battery producer and recycler with operations in 89 countries. Further information can be found at www.exide.com

4 3

DIB code generator
by Ge van Geldorp 08 Jul '05

08 Jul '05

One of the things which has bothered me a bit is the code duplication we have in our DIB engine (subsys/win32k/dib). Most of the BitBlt routines in there are very similar. With the recent interest in optimizations a bunch of new (almost identical) routines were added. Don't get me wrong, I'm not saying that adding those optimizations was a bad idea, I'm just pointing out that we have a lot of code duplication. There are 256 possible ROP codes, we support 1bpp, 4bpp, 8bpp, 16bpp, 24bpp and 32bpp, so in theory there could be 1536 routines with basically the same structure. I've been playing around with the idea to write a code generator which would generate the source code for those routines. That would cut down on the duplicated source code and associated maintenance problems (you only need to change the code generator) while still allowing optimized code for each individual ROP code. Just to give you an idea what such a code generator would look like, I've attached my first attempt. Please note that it doesn't really try to optimize the generated code yet, it's just to give an impression. The code generated (16bpp only atm) is rather large, you can get it from ftp://ftp.geldorp.nl/pub/ReactOS/dib16gen.c if you like (or compile the code generator ("gcc -o gendib gendib.c") and run it). A possible problem is that the generated code is quite large. When using the generated 16bpp code, size of win32k.sys increases by about 350kb. Extrapolating this for all bpps, it would mean that win32k.sys would triple in size. So, I'm wondering what you guys are thinking. Should we basically trade memory for speed? Problem is that I can't quantify the speed increase at the moment. Gé van Geldorp.

8 10

Re: [ros-svn] [navaraf] 16445: Put the page tables and hyperspace at the right place in memory (ie. Windows compatible).
by Hartmut Birr 07 Jul '05

07 Jul '05

navaraf(a)svn.reactos.com wrote: >Put the page tables and hyperspace at the right place in memory (ie. Windows compatible). > > >Updated files: >trunk/reactos/boot/freeldr/freeldr/arch/i386/mb.S >trunk/reactos/boot/freeldr/freeldr/multiboot.c >trunk/reactos/ntoskrnl/mm/i386/page.c > >_______________________________________________ >Ros-svn mailing list >Ros-svn(a)reactos.com >http://reactos.com:8080/mailman/listinfo/ros-svn > > > > Hi, on windows the hyperspace area is always 4MB. If you change the size you have also to change the mapping and initialisation functions. - Hartmut

1 0

A few bugs
by Rafal Kupiec 07 Jul '05

07 Jul '05

1) Task manager displays closed / killed software too. Maybe it cannot kill software? Runned software window disappears but in task manager it on runned application list. There's no info about this software in process tab. 2) In browse window I cannot enter in folders. System want to change its name when I double click on it. 3) In Task Manager there's 2x Windows posision in menu (sometimes).

6 8

ReactOS Website
by Rick Langschultz 07 Jul '05

07 Jul '05

I was wondering what software was being run on the ReactOS machine. I know that it is a version of linux and I guess php and mysql. Are there any others?

2 1

#16452 Bug
by Rafal Kupiec 07 Jul '05

07 Jul '05

Blue screen INACCESSIBLE_BOOT_DEVICE :) Nice work.

3 2

Branch for the 0.2.7-Release approaching
by Robert Köpferl 06 Jul '05

06 Jul '05

Hi, the date of the branch for the 0.2.7-release is fastly approaching. I dated it for Monday, 11.06. So there's still over one week ahead. I please you to stop implementing new features but and finish bigger reorganizations in the code. Keep the checked in code compileable. If you have issues concerning the date of the branch, post a message. More or less for my own (but also from comments on the ml) I decided to do a just normal release with normal names. So there will be no "network preview release" or such kind.

3 3

Website
by Murphy, Ged (Bolton) 06 Jul '05

06 Jul '05

Whats happening with this? It seems to have died a death again. Can we appoint some more people to the web team as there have been some great ideas put forward, but nobody seems to be acting on them. Ged. ************************************************************************ The information contained in this message or any of its attachments is confidential and is intended for the exclusive use of the addressee. The information may also be legally privileged. The views expressed may not be company policy, but the personal views of the originator. If you are not the addressee, any disclosure, reproduction, distribution or other dissemination or use of this communication is strictly prohibited. If you have received this message in error, please contact postmaster(a)exideuk.co.uk <mailto:postmaster@exideuk.co.uk> and then delete this message. Exide Technologies is an industrial and transportation battery producer and recycler with operations in 89 countries. Further information can be found at www.exide.com

1 0

Re: [ros-svn] [ekohl] 16437: Add architecture-specific headers and move I386-specific definitions into them.
by Alex Ionescu 05 Jul '05

05 Jul '05

ekohl(a)svn.reactos.com wrote: >Add architecture-specific headers and move I386-specific definitions into them. > > > Thanks a lot Eric. I did some research on another FIXME that is actually related to your PnP work, which you might want to take a look at. You will notice that DEVICE_NODE has 2 non-NT members. I saw that you had some previous patches concerning this structure that removed some of the ROS-Only fields, and I guess you might want to get rid of the two ones remaning. The first is BusTypeGuid. The correct way it should be handled is through a private array of GUIDs, which is indexed according DeviceNode.ChildBusTypeIndex. When querying, you just return the GUID in IopXxxxx[DeviceNode.ChildBusTypeIndex], and when creating a bus type guid, you just write the index there. I hope that's clear enough. The second is "Address". That field is actually already present in the DDK-documented DEVICE_CAPABILITIES structure. Therefore, when queried for it, simply send an IRP_MJ_QUERY_CAPABILITIES (or whatever the name is) to DeviceNode->PhysicalDeviceObject, and return the DeviceCapabilities.Address. That should be less then 20 lines of code to change, but I don't want to break any PnP features since they aren't my speciality.. Best regards, Alex Ionescu

1 0

PING
by Thomas Weidenmueller 05 Jul '05

05 Jul '05

PING

6 5

Re: [ros-svn] [gdalsnes] 16417: fix premature close og reg key
by TwoTailedFox 04 Jul '05

04 Jul '05

Shouldn't that be 'of reg key'? ;) On 7/4/05, gdalsnes(a)svn.reactos.com <gdalsnes(a)svn.reactos.com> wrote: > fix premature close og reg key > > > Updated files: > trunk/reactos/lib/setupapi/devinst.c > > _______________________________________________ > Ros-svn mailing list > Ros-svn(a)reactos.com > http://reactos.com:8080/mailman/listinfo/ros-svn > -- "I had a handle on life, but then it broke"

1 0

Re: [ros-svn] [ekohl] 16393: - Move definitions from ntpnp.h into NDK and DDK
by Alex Ionescu 04 Jul '05

04 Jul '05

ekohl(a)svn.reactos.com wrote: >- Move definitions from ntpnp.h into NDK and DDK >- Remove ntpnp.h > > >Updated files: >trunk/reactos/include/ndk/zwfuncs.h >trunk/reactos/include/ndk/zwtypes.h >trunk/reactos/lib/wdmguid/wdmguid.c >trunk/reactos/ntoskrnl/include/ntoskrnl.h >trunk/reactos/ntoskrnl/io/plugplay.c >trunk/reactos/services/umpnpmgr/umpnpmgr.c >trunk/reactos/w32api/include/ddk/wdmguid.h > >Deleted files: >trunk/reactos/include/ddk/ntpnp.h > Hi, Heh, you beat me to it! I asked Filip if it was OK to do this and was going to do it myself, thanks for thinking foward. I just have two comments: - I think the GUIDs are undocumented, while wdmguid.h is a DDK header. Therefore, adding them there breaks MS DDK compatibility, since we'll get undefined errors if we build with it. Sorry to nitpick about compatibility again. - To keep size small and to stick with the current way the NDK has been made, I would prefer if there were no coments in it that describe or document structures. The comments should go on top of the actual APIs in the source files. Sorry for nitpicking again ;-). Best regards, Alex Ionescu

2 2

Re: [ros-svn] [mf] 16392: prepare for WINE UNICODE patch
by Thomas Weidenmueller 03 Jul '05

03 Jul '05

mf(a)svn.reactos.com wrote: > prepare for WINE UNICODE patch > > > Updated files: > trunk/reactos/subsys/system/winefile/winefile.c > trunk/reactos/subsys/system/winefile/winefile.h > > _______________________________________________ > Ros-svn mailing list > Ros-svn(a)reactos.com > http://reactos.com:8080/mailman/listinfo/ros-svn > This change broke compiling: subsys\system\winefile\winefile.c: In function `path_from_pidlA': subsys\system\winefile\winefile.c:706: warning: implicit declaration of function `free_strret' subsys\system\winefile\winefile.c: At top level: subsys\system\winefile\winefile.c:716: error: redefinition of 'wcscpyn' subsys\system\winefile\winefile.c:671: error: previous definition of 'wcscpyn' w as here subsys\system\winefile\winefile.c:1096:2: #endif without #if subsys\system\winefile\winefile.c: In function `CheckForFileInfo': subsys\system\winefile\winefile.c:1821: warning: passing arg 1 of `GetFileVersio nInfoSizeW' discards qualifiers from pointer target type subsys\system\winefile\winefile.c:1826: warning: passing arg 1 of `GetFileVersio nInfoW' discards qualifiers from pointer target type subsys\system\winefile\winefile.c: At top level: subsys\system\winefile\winefile.c:671: warning: 'wcscpyn' defined but not used subsys\system\winefile\winefile.c:698: warning: 'path_from_pidlA' defined but no t used mingw32-make[1]: *** [obj-i386\subsys\system\winefile\winefile.o] Error 1

2 1

I'm new to this list
by Jan 03 Jul '05

03 Jul '05

hi, my name is jan, i'm from spain. I'm a vc++ programmer and i want to help. Any sugestions about how to start? jan

2 1

about hostlix again :)
by Saveliy Tretiakov 02 Jul '05

02 Jul '05

Even if hostlix guys wanted to help ReactOS team, they couldn't. From ReactOS Development Policy: 8b) Developers who have had access to proprietary source code that would have originally fallen under trade secret protection (including, for example, the leaked Microsoft Windows source code) are a special case. The copyright issues are unchanged, as are the patent issues, but any developer who has the code is clearly either under an NDA or else does not have a license to possess the code. In the latter case, there is a clear violation of the relevant trade secrets by the developer. As such, this kind of code is unsuitable even for research and understanding. It is the policy of the Project to not take submissions from developers who have or use any such proprietary code in their development efforts for ReactOS. All thouse hostlix guys have seen leaked windows source code and can not contribute to ReactOS. No changes made to hostlix code can be merged back to ReactOS.

1 0

New ReactOS Homepage: ideas, new features, etc.
by Klemens Friedl 02 Jul '05

02 Jul '05

I wrote all my ideas about the new ReactOS page (that came to my mind) together: http://reactosde.re.funpic.de/mediadetail.php?sec=Articles&cat=ideas&mdnr=1… What is your opinion about that? There are two (or more) possible solutions for the static main pages: * wiki system that generate the static pages (HTML/XHTML) (maybe language support problem ?) * selfwritten simple CMS system (very flexible, easy to use, only a few php-scripts so fewer bugs, better integration (design, layout), language support, generate HTML/XHTML, ...) (* CMS system like the current one) What system do you prefer? (wiki, CMS, ...) Compatibility and Package Manager section: * wiki based (like in the current mediawiki only a long list) * php based dynamic list (with filter features and tree structur; mysql database): example: (first alpha page) http://frik85.fr.funpic.de/packmgr/?page=tree&sec=view&sec2=2 * winehq's application database (or something else; redesign it?) What system do you prefer? (wiki, dynamic list (tree structur), ...) I will have time in july/august/sept. to implement the Compatibility-, Package Manager section and the simple CMS system that can generate the static pages, if it is okay for you. But I will wait until I get a "start signal". If someone else want do it alone or want help me, it will be no problem (for me; then I will have more time to code for ReactOS). I wrote this because the current ReactOS page is awful (design and CMS system) and we need a better and more beautiful page to gain more visitors, get a bigger ReactOS community (and more devs). I hope the UI-Team will finalize the layout of the homepage in the next two months. Thanks for reading this, and maybe you find time to write your opinion about that. Best regards, Klemens Friedl (PS: Tomorrow, I will have no time to answer any emails, sorry.) -- Weitersagen: GMX DSL-Flatrates mit Tempo-Garantie! Ab 4,99 Euro/Monat: http://www.gmx.net/de/go/dsl

3 4

Re: [ros-diffs] [ion] 16361: PCH for csrss and win32csr, and remove rosrtl usage
by Hartmut Birr 02 Jul '05

02 Jul '05

ion(a)svn.reactos.com wrote: >PCH for csrss and win32csr, and remove rosrtl usage > >Modified: trunk/reactos/subsys/csrss/api/wapi.c > > > *Modified: trunk/reactos/subsys/csrss/api/wapi.c* > >--- trunk/reactos/subsys/csrss/api/wapi.c 2005-07-01 02:47:15 UTC (rev 16360) >+++ trunk/reactos/subsys/csrss/api/wapi.c 2005-07-01 03:03:06 UTC (rev 16361) >@@ -10,13 +10,8 @@ > > > /* INCLUDES ******************************************************************/ > > > >-#include <windows.h> >-#define NTOS_MODE_USER >-#include <ndk/ntndk.h> >-#include <rosrtl/thread.h> > > >+#include "csrss.h" > > > > > >-#include "api.h" >- > > > #define NDEBUG > #include <debug.h> > >@@ -170,7 +165,7 @@ > > > > /* Close the port and exit the thread */ > NtClose(ServerPort); > > >- RtlRosExitUserThread(STATUS_SUCCESS); > > >+ NtTerminateThread(NtCurrentThread(), STATUS_SUCCESS); > > > } > > > Hi, this change is wrong. If you remove RtlRosExitUserThread, you have to insert the code from RtlRosExitUserThread. With the current code, the user mode stack from the thread isn't freed. Csrss does crash after a short time because csrss isn't able to create a stack for a new thread. This occurs while compiling ros on ros. - Hartmut

2 1

Re: [ros-dev] Re: Copyright notices
by Quandary 01 Jul '05

01 Jul '05

On Wed, Jun 29, 2005 at 01:17:11PM +0200, Rafal Kupiec wrote: > K McI wrote: > > -----BEGIN PGP SIGNED MESSAGE----- > > Hash: SHA1 > > > > Rafal Kupiec wrote: > > > >>I think, now we're not violating the GPL. > >>for eg: > >>http://svn.berlios.de/wsvn/hostilix/trunk/Sources/apps/notepad/dialog.c?op=… > > > > > > I hope Revision 42 isn't the latest because the > > URI is invalid (You lost a "w" somewhere from 1 to > > 42)! > > (...) > > What? > The site. The site that the above link points to. Look at it. * Copyright(C) 1999-2005r. BetaComp Team <http://www.betacomp.info/> becomes * This file is a part of BetaComp Team Project <http://ww.betacomp.info/> Notice the missing W in "ww.betacomp.info". -- Travis ____________________________________________________ Yahoo! Sports Rekindle the Rivalries. Sign up for Fantasy Football http://football.fantasysports.yahoo.com

3 3

Booting problem
by Mike Lerwill 30 Jun '05

30 Jun '05

I have recently acquired some second-hand hardware that will be dedicated to my testing and development of reactos. It will, however, not boot either 0.2.6 release or current SVN and I would appreciate some assistance on how to debug this problem. The output from the two versions is as follows. 0.2.6 Used memory 131072Kb (mm/mminit.c:375) Kernel Stack Limits. InitTop = 0x800bb000, Init = 0x800b8000 (mm/virtual.c:214) FIXME: MEMORY_AREA_SYSTEM case incomplete (or possibly wrong) for NtQueryVirtualMemory() (ke/bug.c:56) Found Bugcheck Resource Data! (ke/bug.c:67) Got Pointer to Bugcheck Resource Data! (ke/clock.c:80) KiInitializeSystemClock() (ke/clock.c:99) Finished KiInitializeSystemClock() (ex/timer.c:172) ExpInitializeTimerImplementation() (io/pnproot.c:676) DeviceID: Root\Ne2000 PDO 80546268 (io/pnproot.c:689) InstanceID: 0000 PDO 80546268 (io/pnproot.c:676) DeviceID: Root\PCI PDO 80546370 (io/pnproot.c:689) InstanceID: 0000 PDO 80546370 DriverBase for \SystemRoot\system32\drivers\pci.sys: 9cdb3000 Peripheral Component Interconnect Bus Driver SVN (actually r16344 despite what it says) (ntoskrnl\ke\main.c:294) --------------------------------------------------- ------------ (ntoskrnl\ke\main.c:295) ReactOS 0.3-SVN (Build 20050624-r16253) Used memory 131072Kb (ntoskrnl\mm\mminit.c:375) Kernel Stack Limits. InitTop = 0x800f2000, Init = 0x800ef000 (ntoskrnl\mm\mm.c:327) No current process In both cases the screen freezes after the line that says loading pci.sys regards Mike Lerwill

1 0

RE: [ros-dev] Re: Copyright notices
by Murphy, Ged (Bolton) 29 Jun '05

29 Jun '05

K McI wrote: > > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > Completely off topic, but a request: > > When you're quoting someone (anyone) who signed/encrypted > their message, can you ax the "----- $% BEGIN PGP SIGNED > MESSAGE $% -----" line, so ppls GPGPs don't wonder where the > sign block is? > > I know I'm like, the only one here who does it, but I wanted > to let everyone know, not just for this list. > > Thanx again > > -uQ > -----BEGIN PGP SIGNATURE----- > Version: GnuPG v1.4.1 (MingW32) > Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org > > iD8DBQFCwolc7mze81O92HkRAvyEAJwK6TLtoISfHFY4L+/7Y5o6pdyb1wCdFs1n > PXsFokONZ4q4DydcS8j1s9Q= > =Asvj > -----END PGP SIGNATURE----- Or even better, could you not turn the PGP sig off for the mailing list? It does make reading your mails a little more complicated than need be. You could always link your public key to a key server in a quick signature if you wanted people to have access. Ged. P.s I know my mails from work have that annoying disclaimer. Unfortunately I can't get rid of it without passing through an external script to remove it (which would be breaking my company rules) ************************************************************************ The information contained in this message or any of its attachments is confidential and is intended for the exclusive use of the addressee. The information may also be legally privileged. The views expressed may not be company policy, but the personal views of the originator. If you are not the addressee, any disclosure, reproduction, distribution or other dissemination or use of this communication is strictly prohibited. If you have received this message in error, please contact postmaster(a)exideuk.co.uk <mailto:postmaster@exideuk.co.uk> and then delete this message. Exide Technologies is an industrial and transportation battery producer and recycler with operations in 89 countries. Further information can be found at www.exide.com

1 0

RE: [ros-dev] Re: Copyright notices
by Murphy, Ged (Bolton) 29 Jun '05

29 Jun '05

Quandary wrote: > > On Wed, Jun 29, 2005 at 01:17:11PM +0200, Rafal Kupiec > wrote: > > K McI wrote: > > > -----BEGIN PGP SIGNED MESSAGE----- > > > Hash: SHA1 > > > > > > Rafal Kupiec wrote: > > > > > >>I think, now we're not violating the GPL. > > >>for eg: > > > >>http://svn.berlios.de/wsvn/hostilix/trunk/Sources/apps/notep > ad/dialog. > > >c?op=diff&rev=0&sc=1 > > > > > > > > > I hope Revision 42 isn't the latest because the > > > URI is invalid (You lost a "w" somewhere from 1 to > > > 42)! > > > (...) > > > > What? > > > > The site. The site that the above link points to. > Look at it. > > * Copyright(C) 1999-2005r. BetaComp Team > <http://www.betacomp.info/> > > becomes > > * This file is a part of BetaComp Team Project > <http://ww.betacomp.info/> > > Notice the missing W in "ww.betacomp.info". > I still don't understand why they have to put their mark on the code at all. Is it some kind of ego boost the hostilix team is a after? Is it because they want people to think they have the skill the ROS devs have? Is it because they want people to think they wrote the code? IMO, if you use code from another project, you leave the code as it is, i.e. no claiming copyright, no adding headers to claim ownership, or to trick people into thinking it's your code, or any other type of header just for the sake of adding it. The only time you should be adding your own mark is when you have altered the code in some way. Your mark should then be added, in addition to the current list of programmers. To be honest, I find it all rather sad and quite pathetic to need to stoop to this level. Just take the damn headers off and all this hostility will end. Ged. ************************************************************************ The information contained in this message or any of its attachments is confidential and is intended for the exclusive use of the addressee. The information may also be legally privileged. The views expressed may not be company policy, but the personal views of the originator. If you are not the addressee, any disclosure, reproduction, distribution or other dissemination or use of this communication is strictly prohibited. If you have received this message in error, please contact postmaster(a)exideuk.co.uk <mailto:postmaster@exideuk.co.uk> and then delete this message. Exide Technologies is an industrial and transportation battery producer and recycler with operations in 89 countries. Further information can be found at www.exide.com

1 0

Re: [ros-dev] Copyright notices
by Quandary 29 Jun '05

29 Jun '05

On Tue, Jun 28, 2005 at 05:16:16PM +0200, Eric Kohl wrote: > Lucio Diaz wrote: > >Third post, but, i downloaded their source code, > >and it seems the original copyright notices are > >there, so they are not violating the GNU licence. > > > >Best regards, > >Lucio Diaz. > > The Hostilix 'developers' are still guilty of > willful misrepresentation of the copyright because > 1) They added their copyright to otherwise unchanged > files and 2) they can only claim a copyright for the > year 2005 but not from 1999 to 2005. > > So they are still violating the GPL. They aren't violating the GPL by misrepresentation (per se); they're (likely) violating the underlying copyright law by making a false claim to ownership. There's a subtle difference ;). -- Travis __________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com

4 5

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev