- Ros-dev - ReactOS.org

Re: [ros-dev] [ros-diffs] [hbelusca] 71829: [CLIPBRD]: Use NULL for null pointer. [EVENTVWR]: Add folder icons (needed for later).
by Thomas Faber 06 Jul '16

06 Jul '16

Can't event viewer load those icons from shell32 (much like regedit should)? On 2016-07-06 01:42, hbelusca(a)svn.reactos.org wrote: > Author: hbelusca > Date: Tue Jul 5 23:42:40 2016 > New Revision: 71829 > > URL: http://svn.reactos.org/svn/reactos?rev=71829&view=rev > Log: > [CLIPBRD]: Use NULL for null pointer. > [EVENTVWR]: Add folder icons (needed for later). > > Added: > trunk/reactos/base/applications/mscutils/eventvwr/res/folder.ico > - copied unchanged from r71828, trunk/reactos/base/applications/regedit/res/folder.ico > trunk/reactos/base/applications/mscutils/eventvwr/res/folderopen.ico > - copied unchanged from r71828, trunk/reactos/base/applications/regedit/res/folderopen.ico > Modified: > trunk/reactos/base/applications/clipbrd/clipbrd.c > > Modified: trunk/reactos/base/applications/clipbrd/clipbrd.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/clipbrd/… > ============================================================================== > --- trunk/reactos/base/applications/clipbrd/clipbrd.c [iso-8859-1] (original) > +++ trunk/reactos/base/applications/clipbrd/clipbrd.c [iso-8859-1] Tue Jul 5 23:42:40 2016 > @@ -256,12 +256,12 @@ > > case CMD_ABOUT: > { > + HICON hIcon; > WCHAR szTitle[MAX_STRING_LEN]; > - HICON hIcon; > > hIcon = LoadIconW(Globals.hInstance, MAKEINTRESOURCE(CLIPBRD_ICON)); > LoadStringW(Globals.hInstance, STRING_CLIPBOARD, szTitle, ARRAYSIZE(szTitle)); > - ShellAboutW(Globals.hMainWnd, szTitle, 0, hIcon); > + ShellAboutW(Globals.hMainWnd, szTitle, NULL, hIcon); > DeleteObject(hIcon); > break; > } > >

1 0

Re: [ros-dev] [ros-diffs] [zhu] 71823: Fixed crash on client and server exit: Corrected some NULL data marking and checking. Moved some cleanup code so they actually execute on function failure (incomplete). Removed redunda...
by Thomas Faber 05 Jul '16

05 Jul '16

Comments inline. On 2016-07-05 20:35, zhu(a)svn.reactos.org wrote: > --- branches/GSoC_2016/lwIP-tcpip/drivers/network/tcpip/address.c [iso-8859-1] (original) > +++ branches/GSoC_2016/lwIP-tcpip/drivers/network/tcpip/address.c [iso-8859-1] Tue Jul 5 18:35:17 2016 > @@ -357,15 +356,15 @@ > > KeReleaseSpinLockFromDpcLevel(&Context->RequestListLock); > > - if (Context->lwip_tcp_pcb != Context->AddressFile->lwip_tcp_pcb) > + if (Context->lwip_tcp_pcb == Context->AddressFile->lwip_tcp_pcb); You really don't want a semicolon here ;) > { > - tcp_close(Context->lwip_tcp_pcb); > + Context->AddressFile->lwip_tcp_pcb = NULL; > } > + if (!p) > + { > + CopiedLength = 0; > + Status = STATUS_ADDRESS_CLOSED; > + goto BAD; > + } > > if (RemainingDestBytes <= p->len) > { > RtlCopyMemory(CurrentDestLocation, p->payload, RemainingDestBytes); > CopiedLength = RemainingDestBytes; > + Status = STATUS_SUCCESS; > goto RETURN; We normally call labels things like "Exit" and "Failure". > @@ -826,23 +846,24 @@ > > tcp_recved(tpcb, CopiedLength); > I find it confusing not to have Entry = Head->Flink right here. I'm not sure where it is, but unless there's a good reason for it to be somewhere else I'd recommend putting it right in front of the loop. > + while (Entry != Head) > + { > + Request = CONTAINING_RECORD(Entry, TCP_REQUEST, ListEntry); Entry = Entry->Flink? ;) > + if (Request->PendingMode == TCP_REQUEST_PENDING_RECEIVE) > + { > + tcp_recv(tpcb, lwip_tcp_receive_callback); > + break; > + } > + } > @@ -1666,6 +1690,21 @@ > if (!(IsListEmpty(&Context->RequestListHead))) > { > DPRINT1("Disassociating context with outstanding requests\n"); > + Head = &Context->RequestListHead; > + Entry = Head->Flink; > + while (Entry != Head) > + { > + Request = CONTAINING_RECORD(Entry, TCP_REQUEST, ListEntry); Entry = Entry->Flink; > + if (Request->PendingIrp) > + { > + IrpSp = IoGetCurrentIrpStackLocation(Request->PendingIrp); > + DPRINT1("Pending IRP Control Code: %08x\n", IrpSp->MinorFunction); > + } > + else > + { > + DPRINT1("IRP is NULL\n"); > + } > + } > } > KeReleaseSpinLockFromDpcLevel(&Context->RequestListLock); > Thanks. -Thomas

1 0

Re: [ros-dev] [ros-diffs] [hbelusca] 71811: [RTL] - Duplicate the standard (input/output/error) handles from the parent process, when creating a new one. - Properly fail RtlCreateUserProcess if any of the ZwWriteVirtualMemo...
by Alex Ionescu 04 Jul '16

04 Jul '16

On Mon, Jul 4, 2016 at 1:28 PM, <hbelusca(a)svn.reactos.org> wrote: > + if (!NT_SUCCESS(Status)) > + _SEH2_LEAVE; > + } > For the love of God can you please follow our coding standards. Also, I'm pretty familiar with this code path -- are you sure that this is the correct place to do this duplication? Best regards, Alex Ionescu

1 0

Tr: Re: Ros-diffs Digest, Vol 150, Issue 29
by Hermès BÉLUSCA - MAÏTO 03 Jul '16

03 Jul '16

Hi Eric, are you sure this will not break compatibility with WIn2k3 applications? For example by quickly googling I've noticed some people rely on this Index value for their Time Zone stuff. Example: https://www.experts-exchange.com/questions/24948382/How-to-get-Time-Zone-in… Also, since http://microsoft.public.win32.programmer.ui.narkive.com/SOU9r3ef/time-zones… clearly says that the "IndexMapping" reg_multi_sz is for doing the mapping with the "Index" values of each time zone, you could have also deleted it! (note that this mapping value is indeed absent on Windows 7 for example). Cheers, Hermès ======================================== Message du : 03/07/2016 20:42 De : ros-diffs-request(a)reactos.org A : ros-diffs(a)reactos.org Copie à : Sujet : Ros-diffs Digest, Vol 150, Issue 29 [...] Today's Topics: [...] 3. [ekohl] 71801: [BOOTDATA] Remove the Index value from the time zone entries. We do not need it any more and it has been removed from Windows Vista. (ekohl(a)svn.reactos.org) ---------------------------------------------------------------------- Message: 3 Date: Sun, 03 Jul 2016 18:40:27 -0000 From: ekohl(a)svn.reactos.org To: ros-diffs(a)reactos.org Subject: [ros-diffs] [ekohl] 71801: [BOOTDATA] Remove the Index value from the time zone entries. We do not need it any more and it has been removed from Windows Vista. Message-ID: Content-Type: text/plain; charset="utf-8" Author: ekohl Date: Sun Jul 3 18:40:27 2016 New Revision: 71801 URL: http://svn.reactos.org/svn/reactos?rev=71801&view=rev Log: [BOOTDATA] Remove the Index value from the time zone entries. We do not need it any more and it has been removed from Windows Vista. Modified: trunk/reactos/boot/bootdata/hivesft.inf Modified: trunk/reactos/boot/bootdata/hivesft.inf URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/bootdata/hivesft.inf?… ============================================================================== --- trunk/reactos/boot/bootdata/hivesft.inf [iso-8859-1] (original) +++ trunk/reactos/boot/bootdata/hivesft.inf [iso-8859-1] Sun Jul 3 18:40:27 2016 @@ -406,7 +406,6 @@ HKLM,"SOFTWARE\Microsoft\Windows NT\CurrentVersion\Time Zones\Dateline Standard Time","Display",0x00000000,"(GMT-12:00) International Date Line West" HKLM,"SOFTWARE\Microsoft\Windows NT\CurrentVersion\Time Zones\Dateline Standard Time","Dlt",0x00000000,"Dateline Daylight Time" HKLM,"SOFTWARE\Microsoft\Windows NT\CurrentVersion\Time Zones\Dateline Standard Time","Std",0x00000000,"Dateline Standard Time" -HKLM,"SOFTWARE\Microsoft\Windows NT\CurrentVersion\Time Zones\Dateline Standard Time","Index",0x00010001,0 HKLM,"SOFTWARE\Microsoft\Windows NT\CurrentVersion\Time Zones\Dateline Standard Time","TZI",0x00000001,\ 0xd0,0x02,0x00,0x00,0x00,0x00,0x00,0x00,0xc4,0xff,0xff,0xff,\ 0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,\ (skipping........) @@ -1125,7 +1046,6 @@ HKLM,"SOFTWARE\Microsoft\Windows NT\CurrentVersion\Time Zones\Tonga Standard Time","Display",0x00000000,"(GMT+13:00) Nuku'alofa" HKLM,"SOFTWARE\Microsoft\Windows NT\CurrentVersion\Time Zones\Tonga Standard Time","Dlt",0x00000000,"Tonga Daylight Time" HKLM,"SOFTWARE\Microsoft\Windows NT\CurrentVersion\Time Zones\Tonga Standard Time","Std",0x00000000,"Tonga Standard Time" -HKLM,"SOFTWARE\Microsoft\Windows NT\CurrentVersion\Time Zones\Tonga Standard Time","Index",0x00010001,300 HKLM,"SOFTWARE\Microsoft\Windows NT\CurrentVersion\Time Zones\Tonga Standard Time","TZI",0x00000001,\ 0xf4,0xfc,0xff,0xff,0x00,0x00,0x00,0x00,0xc4,0xff,0xff,0xff,\ 0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,\ ------------------------------ Subject: Digest Footer _______________________________________________ Ros-diffs mailing list Ros-diffs(a)reactos.org http://www.reactos.org/mailman/listinfo/ros-diffs ------------------------------ End of Ros-diffs Digest, Vol 150, Issue 29 ******************************************

1 0

Re: [ros-dev] [ros-diffs] [hbelusca] 71695: [SUBST] - Update the resource program description. - Convert to full UNICODE. - Use Win32 functions where possible. - Factor-out the usage of QueryDosDevice into a QuerySubstedDri...
by Ged Murphy 30 Jun '16

30 Jun '16

This should probably be moved to \base\applications\cmdutils -----Original Message----- From: Ros-diffs [mailto:ros-diffs-bounces@reactos.org] On Behalf Of hbelusca(a)svn.reactos.org Sent: 29 June 2016 01:39 To: ros-diffs(a)reactos.org Subject: [ros-diffs] [hbelusca] 71695: [SUBST] - Update the resource program description. - Convert to full UNICODE. - Use Win32 functions where possible. - Factor-out the usage of QueryDosDevice into a QuerySubstedDri... Author: hbelusca Date: Wed Jun 29 00:38:51 2016 New Revision: 71695 URL: http://svn.reactos.org/svn/reactos?rev=71695&view=rev Log: [SUBST] - Update the resource program description. - Convert to full UNICODE. - Use Win32 functions where possible. - Factor-out the usage of QueryDosDevice into a QuerySubstedDrive function, that returns error codes according to whether the specified drive is a mapped (substed) drive, or is just an existing drive that is not a mapping, or if the drive does not exist. This allows us to detect attempts to use a drive letter that is not a mapped drive, to define a new mapping, and if so we reject such attempt. This fixes CORE-10681 #resolve #comment Fixed with another patch according to my last remark.

1 0

Re: [ros-dev] [ros-diffs] [hbelusca] 71695: [SUBST] - Update the resource program description. - Convert to full UNICODE. - Use Win32 functions where possible. - Factor-out the usage of QueryDosDevice into a QuerySubstedDri...
by Thomas Faber 29 Jun '16

29 Jun '16

On 2016-06-29 02:38, hbelusca(a)svn.reactos.org wrote: > + if (!CharCount && (Result == ERROR_INSUFFICIENT_BUFFER)) > + { > + /* Reallocate the buffer with double size */ > + dwSize *= 2; > + tmp = (PWSTR)HeapReAlloc(GetProcessHeap(), 0, lpTargetPath, dwSize * sizeof(WCHAR)); Oops, this fixes my previous concern, thanks. The casts are still weird though. > + if (!tmp) > + { > + /* Memory problem, bail out */ > + CharCount = 0; > + Result = ERROR_NOT_ENOUGH_MEMORY; > + } > + else > + { > + /* Retry again */ > + lpTargetPath = tmp; > + goto Retry; > + } > + } > + > + if (CharCount) > + { > + if ( wcsncmp(lpTargetPath, L"\\??\\", 4) == 0 && > + ( (lpTargetPath[4] >= L'A' && lpTargetPath[4] <= L'Z') || > + (lpTargetPath[4] >= L'a' && lpTargetPath[4] <= L'z') ) ) > + { > + /* The drive exists and is SUBSTed */ > + Result = ERROR_IS_SUBSTED; > + } > +#if 0 > + else > + { > + /* The drive exists but is not SUBSTed */ > + Result = ERROR_INVALID_DRIVE; > + } > +#endif > + } > + > + if (!TargetPath) > + { > + /* Free the local buffer */ > + HeapFree(GetProcessHeap(), 0, lpTargetPath); > + } > + else > + { > + /* Update the user-given pointers */ > + *TargetPath = lpTargetPath; > + *Size = dwSize; If the HeapReAlloc above fails you might still get into this code path which is not advisable. It should probably always take the if-branch in that case. > + } > + > + return Result; Thanks. -Thomas

1 0

Re: [ros-dev] [ros-diffs] [hbelusca] 71692: [SUBST]: CORE-10681 #comment Apply part of Peter Hater's patch proposed in CORE-10681, that is, fixing the usage of QueryDosDevice API, but without the new IsDriveUsed functionali...
by Thomas Faber 29 Jun '16

29 Jun '16

On 2016-06-28 21:21, hbelusca(a)svn.reactos.org wrote: > --- trunk/reactos/base/system/subst/subst.c [iso-8859-1] (original) > +++ trunk/reactos/base/system/subst/subst.c [iso-8859-1] Tue Jun 28 19:21:08 2016 > @@ -75,81 +75,71 @@ > if (_tcslen(Drive) > 2) > return FALSE; > > - dwSize = sizeof(TCHAR) * MAX_PATH; > - lpTargetPath = (LPTSTR) malloc(sizeof(TCHAR) * MAX_PATH); > - if ( lpTargetPath) > - { > + dwSize = MAX_PATH; > + lpTargetPath = (LPTSTR)malloc(sizeof(TCHAR) * dwSize); > + if (!lpTargetPath) > + return FALSE; > + > + CharCount = QueryDosDevice(Drive, > + lpTargetPath, > + dwSize); > + while (!CharCount && > + GetLastError() == ERROR_INSUFFICIENT_BUFFER) > + { > + lpTargetPath = (LPTSTR)realloc(lpTargetPath, sizeof(TCHAR) * dwSize); This is not how you use realloc, this causes a memory leak in case of failure. Also, why is there a cast here (also, for malloc above)? Thanks. -Thomas > + if (lpTargetPath) > + { > + CharCount = QueryDosDevice(Drive, > + lpTargetPath, > + dwSize); > + } > + } > + > + if (CharCount) > + { > + Result = _tcsncmp(lpTargetPath, _T("\\??\\"), 4) == 0 && > + ( (lpTargetPath[4] >= _T('A') && > + lpTargetPath[4] <= _T('Z')) || > + (lpTargetPath[4] >= _T('a') && > + lpTargetPath[4] <= _T('z')) ); > + } > + > + free(lpTargetPath); > + > + return Result; > +}

1 0

Status Meeting (June 2016)
by Aleksey Bragin 28 Jun '16

28 Jun '16

Hello, Let me invite you to the monthly status meeting taking place this Thursday, 30rd of June, 19:00 UTC. IRC service will only be started shortly before the meeting. Your participation passwords and server address will be emailed to you shortly before the meeting starts, and they are going to be different once again as they are not stored in any database. Hopefully it's not much of inconvenience. Alternative place for the meeting is #reactos-meeting on Freenode. Please send agenda proposals to me before the meeting. My proposal is to discuss 0.4.2 release plans. Regards, Aleksey Bragin

1 0

Re: [ros-dev] Pale Moon drops ReactOS support
by Love Nystrom 23 Jun '16

23 Jun '16

Correct me if I'm wrong (Alex?), but isn't the biggest difference between kernel 5.2 and 6.x that 6.x is *paging the kernel* ? (A huge design mistake if you ask me. One I bet will bite MS on the a**. If the kernel gets too fat it needs liposuction, not paging.) IMHO, adding new APIs, while keeping the (non-paging) kernel seems ideal. Best Regards // Neo On 2016-05-19 05.43, ros-dev-request(a)reactos.org wrote: > Subject: > Re: [ros-dev] Pale Moon drops ReactOS support > From: > Alex Ionescu <ionucu(a)videotron.ca> > Date: > 2016-05-19 02.33 > > To: > ReactOS Development List <ros-dev(a)reactos.org> > > > I don't believe I said 'let's add random exports to our DLLs'. In > fact, in your old thread, I was totally FOR your idea, I even wrote > that the only sane way of doing it is with the app compat work. > > On Wed, May 18, 2016 at 9:27 PM, Timo Kreuzer<timo.kreuzer(a)web.de> wrote: >> >We have been discussing this before and I wonder that Alex is not heavily >> >opposing the idea of randomly adding new exports to our user mode DLLs. It >> >is a well known fact that applications check for existance of exports to >> >decide how to behave, so ... not going to go over this again. >> > >> >To addess this issue I suggested to implement a compatibility layer. And >> >there was a detailed discussion about that on this mailing list. >> >https://www.reactos.org/pipermail/ros-dev/2015-March/017216.html >> > >> >Please take your time to read the whole thread again so we can avoid wasting >> >time, talking about the same things again. >> > >> >Timo -- There is one thing stronger than all the armies in the world, and that's an idea whose time has come. [Victor Hugo]

3 2

Re: [ros-dev] [ros-diffs] [zhu] 71644: Implemented IRQ cancelling for listen() and connect() calls.
by Thomas Faber 21 Jun '16

21 Jun '16

On 2016-06-15 12:10, zhu(a)svn.reactos.org wrote: > --- branches/GSoC_2016/lwIP/drivers/network/tcpip/main.c [iso-8859-1] (original) > +++ branches/GSoC_2016/lwIP/drivers/network/tcpip/main.c [iso-8859-1] Wed Jun 15 19:10:40 2016 > @@ -384,7 +384,9 @@ > Quickie: > Irp->IoStatus.Status = Status; > > - return Irp->IoStatus.Status; > + IoCompleteRequest(Irp, IO_NETWORK_INCREMENT); > + > + return Irp->IoStatus.Status; > } > > static This is illegal. IoCompleteRequest frees the IRP so you must not access it afterwards, and use the local variable instead.

1 0

I can't debug CoInitialize function
by Yonggang Chen 09 Jun '16

09 Jun '16

Hello developers, After building ReactOS and Rostests successfully, I can't debug CoInitialize function through Visual Studio 2015. It seems Visual Studio thinks I'm using their CoInitialize of Windows kernel. Anybody can help me? Here is the steps I used to compile ReactOS and Rostests: 1. install Build Environment https://reactos.org/wiki/ReactOS_Build_Environment 2. download code to the folder specified when by RosBE during installing code: svn://svn.reactos.org/reactos/trunk/reactos http://svn.reactos.org/reactos/trunk/rostests/ reactOS directory -> E:\Work\reactos rostests directory -> E:\Work\reactos\modules\rostests 3. generate reactos.sln for Visual Stdio (a). Open a Windows DDK/WDK/Visual Studio 2015 command prompt. (b). run the following command in the code root: configure.cmd VSSolution 4. build the huge solutions msbuild reactos.sln /m 5. open the 'ole32_winetest.vcxproj' (E:\Work\reactos\output-VS-i386\modules\rostests\winetests\ole32) Set the command arguments 'ole2', set breakpoint at CoInitialize line, and start beginning by pressing F5, but Visual Studio can't get into CoInitialize funtion Best regards Yonggang Chen

2 1

Re: [ros-dev] [ros-diffs] [apriyadarshi] 71530: Added INF File for driver installation with minimal configuration. Device Detection and Initialization working -- tested on VMware. StorPortAllocatePool not working, so asked ...
by Alex Ionescu 06 Jun '16

06 Jun '16

Hi, Implementing MSAHCI would be "more correct" for the system, however MSAHCI also doesn't use STORPORT, it uses ATAPORT, which requires changing our PCIIDEX model to support that. Which I think would put Aman's work out of scope. Now, MSAHCI would be ported to use STORPORT instead, but then we'd essentially be implementing a legacy component on top of a legacy port driver. At least, by implementing STORAHCI on top of STORPORT, we can implement a 'modern' component on top of the legacy port driver. And for this, I would either recommend doing things like implementing StorPortExtendedFunction if Aman can do it -- or if someone can help him, or, avoiding its use with temporary work/arounds, etc. _as long as those workarounds still work in Windows_. Best regards, Alex Ionescu On Sun, Jun 5, 2016 at 9:10 PM, Thomas Faber <thomas.faber(a)reactos.org> wrote: > I'm not an expert so I'm not sure what way is best. But I see at least > 4 solutions: > * There seems to be a way to get the extended function table through > StorPortNotification/GetExtendedFunctionTable. This would provide > some of the newer functionality even with older storport, but is > potentially an undocumented hack > * Avoid using the modern functionality and implement an old-storport > compatible storahci, which implies using only memory from the adapter > extension, and probably a few more things > * Rely on a "modern" storport and do the testing in a newer Windows > version. Then when ROS gets storport it simply needs to be a "modern" > version > * Do not use storport and implement msahci rather than storahci > > Option 2 would give the greatest compatibility but I can't pretend to > understand what limitations it will imply. > > > On 2016-06-05 21:43, Aman Priyadarshi wrote: > > Yeah msahci is ataport miniport driver. > > Then what would be the best idea? Leave it with the implementation I made > > there. "Allocated memory for all port extension within device extension?" > > ᐧ > > > > > > Regards > > *Aman Priyadarshi* > > *www.atomixos.com <http://www.atomixos.com>* > > > > > > On Mon, Jun 6, 2016 at 1:02 AM, Thomas Faber <thomas.faber(a)reactos.org> > > wrote: > > > >> On 2016-06-05 14:40, apriyadarshi(a)svn.reactos.org wrote: > >>> Author: apriyadarshi > >>> Date: Sun Jun 5 12:40:49 2016 > >>> New Revision: 71530 > >>> > >>> URL: http://svn.reactos.org/svn/reactos?rev=71530&view=rev > >>> Log: > >>> Added INF File for driver installation with minimal configuration. > >>> Device Detection and Initialization working -- tested on VMware. > >>> StorPortAllocatePool not working, so asked Storport to allocate all > >> memory just after loading up the driver -- Bad idea (will change it > later). > >> > >> StorPortAllocatePool uses StorPortExtendedFunction, which indeed is not > >> implemented in Win2003. As you can see in WDK samples, 2003's msahci is > >> not a storport miniport driver. Maybe storport wasn't advanced enough > >> for complex drivers back then? > > > _______________________________________________ > Ros-dev mailing list > Ros-dev(a)reactos.org > http://www.reactos.org/mailman/listinfo/ros-dev >

2 1

Re: [ros-dev] [ros-diffs] [apriyadarshi] 71530: Added INF File for driver installation with minimal configuration. Device Detection and Initialization working -- tested on VMware. StorPortAllocatePool not working, so asked ...
by Thomas Faber 05 Jun '16

05 Jun '16

On 2016-06-05 14:40, apriyadarshi(a)svn.reactos.org wrote: > Author: apriyadarshi > Date: Sun Jun 5 12:40:49 2016 > New Revision: 71530 > > URL: http://svn.reactos.org/svn/reactos?rev=71530&view=rev > Log: > Added INF File for driver installation with minimal configuration. > Device Detection and Initialization working -- tested on VMware. > StorPortAllocatePool not working, so asked Storport to allocate all memory just after loading up the driver -- Bad idea (will change it later). StorPortAllocatePool uses StorPortExtendedFunction, which indeed is not implemented in Win2003. As you can see in WDK samples, 2003's msahci is not a storport miniport driver. Maybe storport wasn't advanced enough for complex drivers back then?

2 2

Re: [ros-dev] [ros-diffs] [hbelusca] 71524: [SHELL32] - Minor stylistic whitespace changes. - Use 'IDA_DESKBROWSER' instead of hardcoding its value. - The shell progman window uses the COLOR_DESKTOP as its hbrBackground: pa...
by Thomas Faber 05 Jun '16

05 Jun '16

On 2016-06-05 01:29, hbelusca(a)svn.reactos.org wrote: > - rcDesk.left = GetSystemMetrics(SM_XVIRTUALSCREEN); > - rcDesk.top = GetSystemMetrics(SM_YVIRTUALSCREEN); > - rcDesk.right = rcDesk.left + GetSystemMetrics(SM_CXVIRTUALSCREEN); > - rcDesk.bottom = rcDesk.top + GetSystemMetrics(SM_CYVIRTUALSCREEN); > + rcDesk.left = GetSystemMetrics(SM_XVIRTUALSCREEN); > + rcDesk.top = GetSystemMetrics(SM_YVIRTUALSCREEN); > + rcDesk.right = GetSystemMetrics(SM_CXVIRTUALSCREEN); > + rcDesk.bottom = GetSystemMetrics(SM_CYVIRTUALSCREEN); Are you sure about this? "CX" normally means width, so right = left + cx seems more logical. And SM_XVIRUTALSCREEN is probably 0 most of the time so it would be hard to notice.

2 3

https://code.reactos.org/ does not show recent revisions
by Alexander Rechitskiy 03 Jun '16

03 Jun '16

1 0

Re: [ros-dev] [ros-diffs] [hbelusca] 71486: [WIN32K] Display a nice ReactOS version desktop watermark (with different fonts) when the corresponding registry values are set. See http://winaero.com/blog/a-new-way-to-display-t...
by Ged Murphy 01 Jun '16

01 Jun '16

There's another one of these when the OS is running in test mode. "Bcdedit -set TESTSIGNING ON" will display the following: Test Mode Windows (n) Build (n) Maybe you can add that one when Alex finishes his UEFI/BCD stuff :) -----Original Message----- From: Ros-diffs [mailto:ros-diffs-bounces@reactos.org] On Behalf Of hbelusca(a)svn.reactos.org Sent: 01 June 2016 16:25 To: ros-diffs(a)reactos.org Subject: [ros-diffs] [hbelusca] 71486: [WIN32K] Display a nice ReactOS version desktop watermark (with different fonts) when the corresponding registry values are set. See http://winaero.com/blog/a-new-way-to-display-t... Author: hbelusca Date: Wed Jun 1 15:24:38 2016 New Revision: 71486 URL: http://svn.reactos.org/svn/reactos?rev=71486&view=rev Log: [WIN32K] Display a nice ReactOS version desktop watermark (with different fonts) when the corresponding registry values are set. See http://winaero.com/blog/a-new-way-to-display-the-windows-version-on-your-de… for more details (which works on Windows 2003 too). CORE-11349 #resolve

1 0

Re: [ros-dev] [ros-diffs] [mjansen] 71439: [APPHELP] Begin shimlib implementation. CORE-11329 Implement some macro's and functions that help when registering shims. These are all written in C, so that wine can use the shim ...
by Ged Murphy 31 May '16

31 May '16

Would it not be better to do all this in C++ and let wine write a C interface around it? When we're trying to move to C++, it seems like a step backwards in order to support wine's insistence on using C -----Original Message----- From: Ros-diffs [mailto:ros-diffs-bounces@reactos.org] On Behalf Of mjansen(a)svn.reactos.org Sent: 28 May 2016 17:43 To: ros-diffs(a)reactos.org Subject: [ros-diffs] [mjansen] 71439: [APPHELP] Begin shimlib implementation. CORE-11329 Implement some macro's and functions that help when registering shims. These are all written in C, so that wine can use the shim ... Author: mjansen Date: Sat May 28 16:42:57 2016 New Revision: 71439 URL: http://svn.reactos.org/svn/reactos?rev=71439&view=rev Log: [APPHELP] Begin shimlib implementation. CORE-11329 Implement some macro's and functions that help when registering shims. These are all written in C, so that wine can use the shim libraries as well.

4 4

Semi-protection of our Wikipedia page
by Jared Smudde 29 May '16

29 May '16

Hello all, It seems that our Wikipedia page seems to have somewhat incorrect information in some sections on the page. Some of it seems to come from IP address which means that they are unregistered. Some of the information could be correct but some of the other information added could be incorrect. I propose that we can see if the wiki page could be Semi-Protected. If the page is Semi-Protected, that means that non-registered users (People logged as IPs in the log) and newly registered users (people that have less than 10 edits and that have been only registered for 4 days). This would mean that people that have been registered for a while and have made edits could edit the page. I hope that this would help with some of the incorrect information on the web page. Not sure what your thoughts are on this but I think it would be nice to have. Jared

1 0

Re: [ros-dev] [ros-diffs] [pschweitzer] 71412: [REISERFSLIB] Stub the ReiserFS lib CORE-11005
by Timo Kreuzer 29 May '16

29 May '16

I thought the idea of the folder reorganization was to get some sense into it. But that doesn't work if people keep adding stuff to the sdk/lib folder, just because it is a lib! I don't see why a file system library would have any reason to go into the SDK. Thanks, Timo Am 26.05.2016 um 20:08 schrieb pschweitzer(a)svn.reactos.org: > Author: pschweitzer > Date: Thu May 26 18:08:42 2016 > New Revision: 71412 > > URL: http://svn.reactos.org/svn/reactos?rev=71412&view=rev > Log: > [REISERFSLIB] > Stub the ReiserFS lib > > CORE-11005 > > Added: > trunk/reactos/sdk/lib/fslib/reiserfslib/ > trunk/reactos/sdk/lib/fslib/reiserfslib/CMakeLists.txt (with props) > trunk/reactos/sdk/lib/fslib/reiserfslib/reiserfslib.c (with props) > trunk/reactos/sdk/lib/fslib/reiserfslib/reiserfslib.h (with props) > Modified: > trunk/reactos/sdk/lib/fslib/CMakeLists.txt > > Modified: trunk/reactos/sdk/lib/fslib/CMakeLists.txt > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/sdk/lib/fslib/CMakeLists.t… > ============================================================================== > --- trunk/reactos/sdk/lib/fslib/CMakeLists.txt [iso-8859-1] (original) > +++ trunk/reactos/sdk/lib/fslib/CMakeLists.txt [iso-8859-1] Thu May 26 18:08:42 2016 > @@ -2,5 +2,6 @@ > add_subdirectory(btrfslib) > add_subdirectory(ext2lib) > add_subdirectory(ntfslib) > +add_subdirectory(reiserfslib) > add_subdirectory(vfatlib) > add_subdirectory(vfatxlib) > > Added: trunk/reactos/sdk/lib/fslib/reiserfslib/CMakeLists.txt > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/sdk/lib/fslib/reiserfslib/… > ============================================================================== > --- trunk/reactos/sdk/lib/fslib/reiserfslib/CMakeLists.txt (added) > +++ trunk/reactos/sdk/lib/fslib/reiserfslib/CMakeLists.txt [iso-8859-1] Thu May 26 18:08:42 2016 > @@ -0,0 +1,3 @@ > + > +add_library(reiserfslib reiserfslib.c) > +add_dependencies(reiserfslib psdk) > > Propchange: trunk/reactos/sdk/lib/fslib/reiserfslib/CMakeLists.txt > ------------------------------------------------------------------------------ > svn:eol-style = native > > Added: trunk/reactos/sdk/lib/fslib/reiserfslib/reiserfslib.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/sdk/lib/fslib/reiserfslib/… > ============================================================================== > --- trunk/reactos/sdk/lib/fslib/reiserfslib/reiserfslib.c (added) > +++ trunk/reactos/sdk/lib/fslib/reiserfslib/reiserfslib.c [iso-8859-1] Thu May 26 18:08:42 2016 > @@ -0,0 +1,36 @@ > +/* > + * COPYRIGHT: See COPYING in the top level directory > + * PROJECT: ReactOS ReiserFS library > + * FILE: lib/fslib/reiserfslib/reiserfslib.c > + * PURPOSE: ReiserFS lib > + * PROGRAMMERS: Pierre Schweitzer > + */ > +#include "reiserfslib.h" > + > +#define NDEBUG > +#include <debug.h> > + > +NTSTATUS NTAPI > +ReiserfsFormat(IN PUNICODE_STRING DriveRoot, > + IN FMIFS_MEDIA_FLAG MediaFlag, > + IN PUNICODE_STRING Label, > + IN BOOLEAN QuickFormat, > + IN ULONG ClusterSize, > + IN PFMIFSCALLBACK Callback) > +{ > + UNIMPLEMENTED; > + return STATUS_SUCCESS; > +} > + > + > +NTSTATUS WINAPI > +ReiserfsChkdsk(IN PUNICODE_STRING DriveRoot, > + IN BOOLEAN FixErrors, > + IN BOOLEAN Verbose, > + IN BOOLEAN CheckOnlyIfDirty, > + IN BOOLEAN ScanDrive, > + IN PFMIFSCALLBACK Callback) > +{ > + UNIMPLEMENTED; > + return STATUS_SUCCESS; > +} > > Propchange: trunk/reactos/sdk/lib/fslib/reiserfslib/reiserfslib.c > ------------------------------------------------------------------------------ > svn:eol-style = native > > Added: trunk/reactos/sdk/lib/fslib/reiserfslib/reiserfslib.h > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/sdk/lib/fslib/reiserfslib/… > ============================================================================== > --- trunk/reactos/sdk/lib/fslib/reiserfslib/reiserfslib.h (added) > +++ trunk/reactos/sdk/lib/fslib/reiserfslib/reiserfslib.h [iso-8859-1] Thu May 26 18:08:42 2016 > @@ -0,0 +1,8 @@ > +/* > + * COPYRIGHT: See COPYING in the top level directory > + * PROJECT: ReactOS ReiserFS library > + * FILE: lib/fslib/reiserfslib/reiserfslib.h > + */ > +#define NTOS_MODE_USER > +#include <ndk/umtypes.h> > +#include <fmifs/fmifs.h> > > Propchange: trunk/reactos/sdk/lib/fslib/reiserfslib/reiserfslib.h > ------------------------------------------------------------------------------ > svn:eol-style = native > > >

1 0

Re: [ros-dev] [ros-diffs] [hbelusca] 71419: [NETSHELL]: Fix french orthograph.
by Pierre Schweitzer 27 May '16

27 May '16

Le 27/05/2016 00:37, hbelusca(a)svn.reactos.org a écrit : > @@ -95,7 +95,7 @@ > FONT 8, "MS Shell Dlg" > BEGIN > LTEXT "Pour le pÃ©riphÃ©rique :", IDC_STATIC, 33, 2, 100, 50 > - LTEXT "s. o.", IDC_NETWORK_DEVICE, 105, 2, 253, 20 > + LTEXT "n/a", IDC_NETWORK_DEVICE, 105, 2, 253, 20 > LTEXT "Les composants sÃ©lectionnÃ©s sont utilisÃ©s par cette connexion :", IDC_STATIC, 33, 12, 253, 20 > CONTROL "", IDC_COMPONENT_LIST, "SysListView32", LVS_REPORT | LVS_SINGLESEL | LVS_SHOWSELALWAYS | LVS_NOCOLUMNHEADER | LVS_NOSORTHEADER | WS_BORDER | WS_TABSTOP, 33, 22, 250, 50 > PUSHBUTTON "&Installer...", IDC_NETWORK_INSTALL, 122, 75, 50, 14, WS_DISABLED | WS_TABSTOP For the record, "n/a" isn't French. n/a means "Not available". "s. o." means "Sans objet" which is the closest. -- Pierre Schweitzer <pierre at reactos.org> System & Network Administrator Senior Kernel Developer ReactOS Deutschland e.V.

1 0

Wiki is under spam attack again
by Alexander Rechitskiy 26 May '16

26 May '16

2 1

Status Meeting (May 2016)
by Aleksey Bragin 26 May '16

26 May '16

Hello, Let me invite you to the monthly status meeting taking place next Thursday, 2nd of June, 19:00 UTC, as I was busy before and general consensuss on the IRC channel was to move it one week further. IRC service will only be started shortly before the meeting. Your participation passwords and server address will be emailed to you shortly before the meeting starts, and they are going to be different once again as they are not stored in any database. Hopefully it's not much of inconvenience. Please send agenda proposals to me before the meeting. Regards, Aleksey Bragin

1 0

Re: [ros-dev] [CORE-11291] Create Windows 7 spec files for core DLLs
by Love Nystrom 26 May '16

26 May '16

On 2016-05-25 19.00, I wrote: > Unfortunately, ntdll.pdb only exports 'SymTagPublicSymbol', no > 'SymTagFunction' symbols, If any of you is rich or fortunate enough to have a full MSDN subscription you ought to be able to use a checked build of Win7SP1 to generate the whole '.spec' enchilada.. I would if I was, but alas I'm not :/ If you could *lend me* ISO's of checked W7SP1 x86/x64, I'll build checked virtual machines and generate the whole shebang (provided SymSrv will fetch checked symbols (which I don't know)). Best Regards // Neo

1 0

Re: [ros-dev] rosapps CreateSpec (Fw: ReactOS versioning)
by Love Nystrom 25 May '16

25 May '16

Forget this issue... It remains, but I've moved on. Thanks anyway. // Neo On 2016-05-24 19.00, Love Nystrom <love.nystrom(a)gmail.com> wrote: > SymSrvIsStore keeps failing with error 0x7E no matter what I do :-/ -- There is one thing stronger than all the armies in the world, and that's an idea whose time has come. [Victor Hugo]

1 0

[CORE-11291] Create Windows 7 spec files for core DLLs
by Love Nystrom 25 May '16

25 May '16

@Timo, I uploaded an ntdll.spec for Win7SP1. Unfortunately, ntdll.pdb only exports 'SymTagPublicSymbol', no 'SymTagFunction' symbols, so it's not possible to generate the parameter lists. If they're needed they'll have to be inserted manually or I'll have to write a tool that gets them from "wInternl.h" :/ ++ At least I was able to resolve the names of the 8 ordinal functions. I won't go into all the skull dredging details of getting thus far.. Suffice to say it involved uttering various sulphur reeking curses in nine different languages and threatening the entire human race with extinction, writing a dummy program and running it in WinDbg to make SymSrv fetch ntdll.pdb, and hacking CreateSpec beyond recognition with various hardcoded path names. Best Regards // Neo

1 0

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev