- Ros-dev - ReactOS.org

Re: Re: Re: [ros-dev] added a proposed patch to bugzilla
by Johannes Olofsson 04 Mar '05

04 Mar '05

Hi! What is the output (with the changed line) when the key is pressed, whithout a modifier key, with shift, with caps lock, with caps lock + shift and with alt gr? Regards Johannes Olofsson > Från: Roman Hoegg <roman.hoegg(a)unisg.ch> > Till: ReactOS Development List <ros-dev(a)reactos.com> > Rubrik: Re: Re: [ros-dev] added a proposed patch to bugzilla > Datum: Wed, 2 Mar 2005 20:58:46 +0100 > Try to change the line : > /* none, shift, ctrl-alt, ctrl, ctrl-shift */ > { VK_OEM_7, NOCAPS, 0xe4, 0xe0, 0x7b, WCH_NONE, 0x00 }, /* ä à { */ > to: > { VK_OEM_7, KCTRL, 'code for ä', 'code for à', 0x7b, 'code for Ä', 'code for À }, /* ä à { */ > in order to use the ctrl and ctrl-shift states for caps lock for this key. thanks for the help. What you suggest here actually works (I've just tested it). However, what it does is it makes Ctrl to behave the way CapsLock should behave and turns CapsLock into AltGr (strange...). That's not how my keyboard acts on other OS'. I really think there should be a way to differentiate between CapsLock and Shift. I'm sure that there will also be other keyboards that need that in the future. thanks! Roman Högg_______________________________________________ Ros-dev mailing list Ros-dev(a)reactos.com http://reactos.com:8080/mailman/listinfo/ros-dev Otur i kärlek - http://www.spray.se/spel Tur i kärlek - http://www.spraydate.com

1 0

Re: [ros-diffs] [arty] 13810: Some warning suppression. Read the<rant/>.
by d_layer 04 Mar '05

04 Mar '05

Hi, Actually this is a designed behavior of -Wconversion and not a bug. http://gcc.gnu.org/ml/gcc/2002-12/msg01431.html -- d_layer arty(a)svn.reactos.com wrote: > + * <rant> > + * These fix the following warning in GCC: > + * warning: passing arg 1 of `ntohs' with different width due to > prototype > + * > + * Even if you declare an unsigned char or unsigned short variable and > pass > + * it to htons or ntohs, this warning will be generated. I believe > this is > + * a gcc bug. You can try to reproduce the bug like this: > + * > + * u_short foo(u_short bar) { > + * return htons(bar); > + * } > + * > + * Using the reactos compiler settings this generates the error. > Unless I'm > + * missing something, the active prototypes for htons and ntohs are: > + * > + * u_short PASCAL htons(u_short); > + * u_short PASCAL ntohs(u_short); > + * > + * From winsock2.h. Since the function above has exactly the same > signature > + * as htons except for the required PASCAL (__stdcall) decoration, gcc > is > + * erroneously detecting a narrowed value. > + * </rant>

2 1

Re: [ros-diffs] [ion] 13813: Fix queue item not being cleaned. Thank you Jim
by Filip Navara 04 Mar '05

04 Mar '05

ion(a)svn.reactos.com wrote: >Fix queue item not being cleaned. Thank you Jim > >Modified: branches/alex_devel_branch/reactos/ntoskrnl/ke/queue.c > > > ------------------------------------------------------------------------ > *Modified: branches/alex_devel_branch/reactos/ntoskrnl/ke/queue.c* > >--- branches/alex_devel_branch/reactos/ntoskrnl/ke/queue.c 2005-03-04 04:10:03 UTC (rev 13812) >+++ branches/alex_devel_branch/reactos/ntoskrnl/ke/queue.c 2005-03-04 04:15:46 UTC (rev 13813) >@@ -207,7 +207,7 @@ > > > /* Remove the Entry */ > RemoveEntryList(ListEntry); > > >- Entry->Flink = NULL; > > >+ ListEntry->Flink = NULL; > > > > /* Nothing to wait on */ > break; > > This looks wrong. You should never clean list item this way, instead you should use "InitializeListHead(ListEntry);". - Filip

2 2

Mission X03-02: Recover Ancient Cutler Artifact
by Alex Ionescu 04 Mar '05

04 Mar '05

2 1

atapi patch for test / review
by Hartmut Birr 04 Mar '05

04 Mar '05

Hi, I've add 48bit support to atapi. I cannot test the 48bit support. Please test it. Be careful. If something is wrong, atapi can corrupt other partitions on the same disk. - Hartmut M:\Sandbox\ros_work\reactos>set SVN_EDITOR=notepad M:\Sandbox\ros_work\reactos>d:\programme\subversion\bin\svn.exe diff drivers\storage\atapi Index: drivers/storage/atapi/atapi.c =================================================================== --- drivers/storage/atapi/atapi.c (revision 13795) +++ drivers/storage/atapi/atapi.c (working copy) @@ -1327,6 +1327,8 @@ DrvParms->TMSectorCountHi, DrvParms->TMSectorCountLo, (ULONG)((DrvParms->TMSectorCountHi << 16) + DrvParms->TMSectorCountLo)); + DPRINT1("SupportedFeatures83: %x, SupportedFeatures84 %x\n", DrvParms->SupportedFeatures83, DrvParms->SupportedFeatures84); + DPRINT1("Max48BitAddress: %I64d\n", *(PULONGLONG)DrvParms->Max48BitAddress); if (DrvParms->TMFieldsValid & 0x0004) { if ((DrvParms->UltraDmaModes >> 8) && (DrvParms->UltraDmaModes & 0xff)) @@ -1952,7 +1954,7 @@ { PREAD_CAPACITY_DATA CapacityData; PIDE_DRIVE_IDENTIFY DeviceParams; - ULONG LastSector; + LARGE_INTEGER LastSector; DPRINT("SCSIOP_READ_CAPACITY: TargetId: %lu\n", Srb->TargetId); CapacityData = (PREAD_CAPACITY_DATA)Srb->DataBuffer; @@ -1964,15 +1966,34 @@ /* Calculate last sector (big-endian). */ if (DeviceParams->Capabilities & IDE_DRID_LBA_SUPPORTED) { - LastSector = (ULONG)((DeviceParams->TMSectorCountHi << 16) + - DeviceParams->TMSectorCountLo) - 1; + if (DeviceExtension->DeviceFlags[Srb->TargetId] & DEVICE_48BIT_ADDRESS) + { + ((PUSHORT)&LastSector)[0] = DeviceParams->Max48BitAddress[0]; + ((PUSHORT)&LastSector)[1] = DeviceParams->Max48BitAddress[1]; + ((PUSHORT)&LastSector)[2] = DeviceParams->Max48BitAddress[2]; + ((PUSHORT)&LastSector)[3] = DeviceParams->Max48BitAddress[3]; + LastSector.QuadPart -= 1; + + } + else + { + LastSector.u.HighPart = 0; + LastSector.u.LowPart = (ULONG)((DeviceParams->TMSectorCountHi << 16) + + DeviceParams->TMSectorCountLo)-1; + } } else { - LastSector = (ULONG)(DeviceParams->LogicalCyls * - DeviceParams->LogicalHeads * - DeviceParams->SectorsPerTrack)-1; + LastSector.u.HighPart = 0; + LastSector.u.LowPart = (ULONG)(DeviceParams->LogicalCyls * + DeviceParams->LogicalHeads * + DeviceParams->SectorsPerTrack)-1; } + if (LastSector.u.HighPart) + { + DPRINT1("Disk is too large for our implementation (%I64d sectors\n", LastSector.QuadPart); + KEBUGCHECK(0); + } CapacityData->LogicalBlockAddress = (((PUCHAR)&LastSector)[0] << 24) | (((PUCHAR)&LastSector)[1] << 16) | @@ -2003,6 +2024,7 @@ UCHAR Command; ULONG Retries; UCHAR Status; + UCHAR Regs[10]; BOOLEAN FASTCALL (*Handler)(PATAPI_MINIPORT_EXTENSION DevExt); DPRINT("AtapiReadWrite() called!\n"); @@ -2027,12 +2049,28 @@ if (DeviceParams->Capabilities & IDE_DRID_LBA_SUPPORTED) { - SectorNumber = StartingSector & 0xff; - CylinderLow = (StartingSector >> 8) & 0xff; - CylinderHigh = (StartingSector >> 16) & 0xff; - DrvHead = ((StartingSector >> 24) & 0x0f) | - (Srb->TargetId ? IDE_DH_DRV1 : 0) | - IDE_DH_LBA; + if (DeviceExtension->DeviceFlags[Srb->TargetId] & DEVICE_48BIT_ADDRESS) + { + Regs[0] = 0; + Regs[1] = 0; + Regs[2] = SectorCount & 0xff; + Regs[3] = (SectorCount >> 8) & 0xff; + Regs[4] = StartingSector & 0xff; + Regs[5] = (StartingSector >> 8) & 0xff; + Regs[6] = (StartingSector >> 16) & 0xff; + Regs[7] = (StartingSector >> 24) & 0xff; + Regs[8] = 0; + Regs[9] = 0; + } + else + { + SectorNumber = StartingSector & 0xff; + CylinderLow = (StartingSector >> 8) & 0xff; + CylinderHigh = (StartingSector >> 16) & 0xff; + DrvHead = ((StartingSector >> 24) & 0x0f) | + (Srb->TargetId ? IDE_DH_DRV1 : 0) | + IDE_DH_LBA; + } } else { @@ -2119,13 +2157,33 @@ #endif /* Setup command parameters */ - IDEWritePrecomp(DeviceExtension->CommandPortBase, 0); - IDEWriteSectorCount(DeviceExtension->CommandPortBase, SectorCount); - IDEWriteSectorNum(DeviceExtension->CommandPortBase, SectorNumber); - IDEWriteCylinderHigh(DeviceExtension->CommandPortBase, CylinderHigh); - IDEWriteCylinderLow(DeviceExtension->CommandPortBase, CylinderLow); - IDEWriteDriveHead(DeviceExtension->CommandPortBase, IDE_DH_FIXED | DrvHead); + if (DeviceExtension->DeviceFlags[Srb->TargetId] & DEVICE_48BIT_ADDRESS) + { + IDEWritePrecomp(DeviceExtension->CommandPortBase, Regs[1]); + IDEWriteSectorCount(DeviceExtension->CommandPortBase, Regs[3]); + IDEWriteSectorNum(DeviceExtension->CommandPortBase, Regs[7]); + IDEWriteCylinderLow(DeviceExtension->CommandPortBase, Regs[8]); + IDEWriteCylinderHigh(DeviceExtension->CommandPortBase, Regs[9]); + IDEWritePrecomp(DeviceExtension->CommandPortBase, Regs[0]); + IDEWriteSectorCount(DeviceExtension->CommandPortBase, Regs[2]); + IDEWriteSectorNum(DeviceExtension->CommandPortBase, Regs[4]); + IDEWriteCylinderLow(DeviceExtension->CommandPortBase, Regs[5]); + IDEWriteCylinderHigh(DeviceExtension->CommandPortBase, Regs[6]); + + IDEWriteDriveHead(DeviceExtension->CommandPortBase, IDE_DH_FIXED); + + } + else + { + IDEWritePrecomp(DeviceExtension->CommandPortBase, 0); + IDEWriteSectorCount(DeviceExtension->CommandPortBase, SectorCount); + IDEWriteSectorNum(DeviceExtension->CommandPortBase, SectorNumber); + IDEWriteCylinderHigh(DeviceExtension->CommandPortBase, CylinderHigh); + IDEWriteCylinderLow(DeviceExtension->CommandPortBase, CylinderLow); + IDEWriteDriveHead(DeviceExtension->CommandPortBase, IDE_DH_FIXED | DrvHead); + } + #ifdef ENABLE_DMA if (DeviceExtension->PRDTable && DeviceExtension->DeviceFlags[Srb->TargetId] & DEVICE_DMA_CMD) @@ -2135,7 +2193,14 @@ if (DeviceExtension->UseDma) { Handler = AtapiDmaInterrupt; - Command = Srb->SrbFlags & SRB_FLAGS_DATA_IN ? IDE_CMD_READ_DMA : IDE_CMD_WRITE_DMA; + if (DeviceExtension->DeviceFlags[Srb->TargetId] & DEVICE_48BIT_ADDRESS) + { + Command = Srb->SrbFlags & SRB_FLAGS_DATA_IN ? IDE_CMD_READ_DMA_EXT : IDE_CMD_WRITE_DMA_EXT; + } + else + { + Command = Srb->SrbFlags & SRB_FLAGS_DATA_IN ? IDE_CMD_READ_DMA : IDE_CMD_WRITE_DMA; + } } else #endif @@ -2143,11 +2208,25 @@ Handler = Srb->SrbFlags & SRB_FLAGS_DATA_IN ? AtapiReadInterrupt : AtapiWriteInterrupt; if (DeviceExtension->DeviceFlags[Srb->TargetId] & DEVICE_MULTI_SECTOR_CMD) { - Command = Srb->SrbFlags & SRB_FLAGS_DATA_IN ? IDE_CMD_READ_MULTIPLE : IDE_CMD_WRITE_MULTIPLE; + if (DeviceExtension->DeviceFlags[Srb->TargetId] & DEVICE_48BIT_ADDRESS) + { + Command = Srb->SrbFlags & SRB_FLAGS_DATA_IN ? IDE_CMD_READ_MULTIPLE_EXT : IDE_CMD_WRITE_MULTIPLE_EXT; + } + else + { + Command = Srb->SrbFlags & SRB_FLAGS_DATA_IN ? IDE_CMD_READ_MULTIPLE : IDE_CMD_WRITE_MULTIPLE; + } } else { - Command = Srb->SrbFlags & SRB_FLAGS_DATA_IN ? IDE_CMD_READ : IDE_CMD_WRITE; + if (DeviceExtension->DeviceFlags[Srb->TargetId] & DEVICE_48BIT_ADDRESS) + { + Command = Srb->SrbFlags & SRB_FLAGS_DATA_IN ? IDE_CMD_READ_EXT : IDE_CMD_WRITE_EXT; + } + else + { + Command = Srb->SrbFlags & SRB_FLAGS_DATA_IN ? IDE_CMD_READ : IDE_CMD_WRITE; + } } } @@ -2274,7 +2353,9 @@ ScsiPortStallExecution(10); /* Issue command to drive */ - AtapiExecuteCommand(DeviceExtension, IDE_CMD_FLUSH_CACHE, AtapiNoDataInterrupt); + AtapiExecuteCommand(DeviceExtension, + DeviceExtension->DeviceFlags[Srb->TargetId] & DEVICE_48BIT_ADDRESS ? IDE_CMD_FLUSH_CACHE_EXT : IDE_CMD_FLUSH_CACHE, + AtapiNoDataInterrupt); /* Wait for controller ready */ for (Retries = 0; Retries < IDE_MAX_WRITE_RETRIES; Retries++) Index: drivers/storage/atapi/atapi.h =================================================================== --- drivers/storage/atapi/atapi.h (revision 13795) +++ drivers/storage/atapi/atapi.h (working copy) @@ -64,21 +64,27 @@ #define IDE_REG_COMMAND 0x0007 /* IDE/ATA commands */ -#define IDE_CMD_RESET 0x08 -#define IDE_CMD_READ 0x20 -#define IDE_CMD_READ_RETRY 0x21 -#define IDE_CMD_WRITE 0x30 -#define IDE_CMD_WRITE_RETRY 0x31 -#define IDE_CMD_PACKET 0xA0 -#define IDE_CMD_READ_MULTIPLE 0xC4 -#define IDE_CMD_WRITE_MULTIPLE 0xC5 -#define IDE_CMD_READ_DMA 0xC8 -#define IDE_CMD_WRITE_DMA 0xCA -#define IDE_CMD_FLUSH_CACHE 0xE7 -#define IDE_CMD_FLUSH_CACHE_EXT 0xEA -#define IDE_CMD_IDENT_ATA_DRV 0xEC -#define IDE_CMD_IDENT_ATAPI_DRV 0xA1 -#define IDE_CMD_GET_MEDIA_STATUS 0xDA +#define IDE_CMD_RESET 0x08 +#define IDE_CMD_READ 0x20 +#define IDE_CMD_READ_ONCE 0x21 +#define IDE_CMD_READ_EXT 0x24 /* 48 bit */ +#define IDE_CMD_READ_DMA_EXT 0x25 /* 48 bit */ +#define IDE_CMD_READ_MULTIPLE_EXT 0x29 /* 48 bit */ +#define IDE_CMD_WRITE 0x30 +#define IDE_CMD_WRITE_ONCE 0x31 +#define IDE_CMD_WRITE_EXT 0x34 /* 48 bit */ +#define IDE_CMD_WRITE_DMA_EXT 0x35 /* 48 bit */ +#define IDE_CMD_WRITE_MULTIPLE_EXT 0x39 /* 48 bit */ +#define IDE_CMD_PACKET 0xA0 +#define IDE_CMD_READ_MULTIPLE 0xC4 +#define IDE_CMD_WRITE_MULTIPLE 0xC5 +#define IDE_CMD_READ_DMA 0xC8 +#define IDE_CMD_WRITE_DMA 0xCA +#define IDE_CMD_FLUSH_CACHE 0xE7 +#define IDE_CMD_FLUSH_CACHE_EXT 0xEA /* 48 bit */ +#define IDE_CMD_IDENT_ATA_DRV 0xEC +#define IDE_CMD_IDENT_ATAPI_DRV 0xA1 +#define IDE_CMD_GET_MEDIA_STATUS 0xDA // // Access macros for command registers

2 5

[Fwd: Re: [ros-dev] atapi patch for test / review - failure]
by Hartmut Birr 04 Mar '05

04 Mar '05

Send it again with the correct date... Hi, I've fixed the problem. Please try it again. - Hartmut Hartmut Birr schrieb: >michael(a)fritscher.net schrieb: > > > >>Seems to be a bug betweeb VMware 4.5.2 and ros, because on real HW it >>works well (almost, because I get a BSOD during the reboot after be second >>stage install, yust after clicking the reboot-botton) >> >> >> >> >> >It's not a bug in vmware. I've made a little mistake. The drive head >register isn't set correctly in 48bit mode. I've update my old vmware >beta. I will send a new patch if it works in vmware. > >- Hartmut > > > >_______________________________________________ >Ros-dev mailing list >Ros-dev(a)reactos.com >http://reactos.com:8080/mailman/listinfo/ros-dev > > > > M:\Sandbox\ros_work\reactos>set SVN_EDITOR=notepad M:\Sandbox\ros_work\reactos>d:\programme\subversion\bin\svn.exe diff drivers\storage\atapi Index: drivers/storage/atapi/atapi.c =================================================================== --- drivers/storage/atapi/atapi.c (revision 13806) +++ drivers/storage/atapi/atapi.c (working copy) @@ -1327,6 +1327,8 @@ DrvParms->TMSectorCountHi, DrvParms->TMSectorCountLo, (ULONG)((DrvParms->TMSectorCountHi << 16) + DrvParms->TMSectorCountLo)); + DPRINT1("SupportedFeatures83: %x, EnabledFeatures86 %x\n", DrvParms->SupportedFeatures83, DrvParms->EnabledFeatures86); + DPRINT1("Max48BitAddress: %I64d\n", *(PULONGLONG)DrvParms->Max48BitAddress); if (DrvParms->TMFieldsValid & 0x0004) { if ((DrvParms->UltraDmaModes >> 8) && (DrvParms->UltraDmaModes & 0xff)) @@ -1952,7 +1954,7 @@ { PREAD_CAPACITY_DATA CapacityData; PIDE_DRIVE_IDENTIFY DeviceParams; - ULONG LastSector; + LARGE_INTEGER LastSector; DPRINT("SCSIOP_READ_CAPACITY: TargetId: %lu\n", Srb->TargetId); CapacityData = (PREAD_CAPACITY_DATA)Srb->DataBuffer; @@ -1964,15 +1966,34 @@ /* Calculate last sector (big-endian). */ if (DeviceParams->Capabilities & IDE_DRID_LBA_SUPPORTED) { - LastSector = (ULONG)((DeviceParams->TMSectorCountHi << 16) + - DeviceParams->TMSectorCountLo) - 1; + if (DeviceExtension->DeviceFlags[Srb->TargetId] & DEVICE_48BIT_ADDRESS) + { + ((PUSHORT)&LastSector)[0] = DeviceParams->Max48BitAddress[0]; + ((PUSHORT)&LastSector)[1] = DeviceParams->Max48BitAddress[1]; + ((PUSHORT)&LastSector)[2] = DeviceParams->Max48BitAddress[2]; + ((PUSHORT)&LastSector)[3] = DeviceParams->Max48BitAddress[3]; + LastSector.QuadPart -= 1; + + } + else + { + LastSector.u.HighPart = 0; + LastSector.u.LowPart = (ULONG)((DeviceParams->TMSectorCountHi << 16) + + DeviceParams->TMSectorCountLo)-1; + } } else { - LastSector = (ULONG)(DeviceParams->LogicalCyls * - DeviceParams->LogicalHeads * - DeviceParams->SectorsPerTrack)-1; + LastSector.u.HighPart = 0; + LastSector.u.LowPart = (ULONG)(DeviceParams->LogicalCyls * + DeviceParams->LogicalHeads * + DeviceParams->SectorsPerTrack)-1; } + if (LastSector.u.HighPart) + { + DPRINT1("Disk is too large for our implementation (%I64d sectors\n", LastSector.QuadPart); + KEBUGCHECK(0); + } CapacityData->LogicalBlockAddress = (((PUCHAR)&LastSector)[0] << 24) | (((PUCHAR)&LastSector)[1] << 16) | @@ -1996,10 +2017,8 @@ PIDE_DRIVE_IDENTIFY DeviceParams; ULONG StartingSector; ULONG SectorCount; - UCHAR CylinderHigh; - UCHAR CylinderLow; UCHAR DrvHead; - UCHAR SectorNumber; + UCHAR Regs[10]; UCHAR Command; ULONG Retries; UCHAR Status; @@ -2027,22 +2046,44 @@ if (DeviceParams->Capabilities & IDE_DRID_LBA_SUPPORTED) { - SectorNumber = StartingSector & 0xff; - CylinderLow = (StartingSector >> 8) & 0xff; - CylinderHigh = (StartingSector >> 16) & 0xff; - DrvHead = ((StartingSector >> 24) & 0x0f) | - (Srb->TargetId ? IDE_DH_DRV1 : 0) | - IDE_DH_LBA; + if (DeviceExtension->DeviceFlags[Srb->TargetId] & DEVICE_48BIT_ADDRESS) + { + Regs[1] = 0; + Regs[2] = SectorCount & 0xff; + Regs[3] = (SectorCount >> 8) & 0xff; + Regs[4] = StartingSector & 0xff; + Regs[5] = (StartingSector >> 8) & 0xff; + Regs[6] = (StartingSector >> 16) & 0xff; + Regs[7] = (StartingSector >> 24) & 0xff; + Regs[8] = 0; + Regs[9] = 0; + DrvHead = ((StartingSector >> 24) & 0x0f) | + (Srb->TargetId ? IDE_DH_DRV1 : 0) | + IDE_DH_LBA; + } + else + { + Regs[0] = 0; + Regs[2] = SectorCount & 0xff; + Regs[4] = StartingSector & 0xff; + Regs[5] = (StartingSector >> 8) & 0xff; + Regs[6] = (StartingSector >> 16) & 0xff; + DrvHead = ((StartingSector >> 24) & 0x0f) | + (Srb->TargetId ? IDE_DH_DRV1 : 0) | + IDE_DH_LBA; + } } else { - SectorNumber = (StartingSector % DeviceParams->SectorsPerTrack) + 1; + Regs[0] = 0; + Regs[2] = SectorCount & 0xff; + Regs[4] = (StartingSector % DeviceParams->SectorsPerTrack) + 1; StartingSector /= DeviceParams->SectorsPerTrack; DrvHead = (StartingSector % DeviceParams->LogicalHeads) | (Srb->TargetId ? IDE_DH_DRV1 : 0); StartingSector /= DeviceParams->LogicalHeads; - CylinderLow = StartingSector & 0xff; - CylinderHigh = StartingSector >> 8; + Regs[5] = StartingSector & 0xff; + Regs[6] = StartingSector >> 8; } if (DrvHead & IDE_DH_LBA) @@ -2052,7 +2093,7 @@ DeviceExtension->CommandPortBase, DrvHead & IDE_DH_DRV1 ? 1 : 0, ((DrvHead & 0x0f) << 24) + - (CylinderHigh << 16) + (CylinderLow << 8) + SectorNumber, + (Regs[6] << 16) + (Regs[5] << 8) + Regs[4], SectorCount, Command); } @@ -2062,10 +2103,10 @@ (Srb->SrbFlags & SRB_FLAGS_DATA_IN) ? "READ" : "WRITE", DeviceExtension->CommandPortBase, DrvHead & IDE_DH_DRV1 ? 1 : 0, - CylinderHigh, - CylinderLow, + Regs[6], + Regs[5], DrvHead & 0x0f, - SectorNumber, + Regs[4], SectorCount, Command); } @@ -2119,13 +2160,23 @@ #endif /* Setup command parameters */ - IDEWritePrecomp(DeviceExtension->CommandPortBase, 0); - IDEWriteSectorCount(DeviceExtension->CommandPortBase, SectorCount); - IDEWriteSectorNum(DeviceExtension->CommandPortBase, SectorNumber); - IDEWriteCylinderHigh(DeviceExtension->CommandPortBase, CylinderHigh); - IDEWriteCylinderLow(DeviceExtension->CommandPortBase, CylinderLow); - IDEWriteDriveHead(DeviceExtension->CommandPortBase, IDE_DH_FIXED | DrvHead); + if (DeviceExtension->DeviceFlags[Srb->TargetId] & DEVICE_48BIT_ADDRESS) + { + IDEWritePrecomp(DeviceExtension->CommandPortBase, Regs[1]); + IDEWriteSectorCount(DeviceExtension->CommandPortBase, Regs[3]); + IDEWriteSectorNum(DeviceExtension->CommandPortBase, Regs[7]); + IDEWriteCylinderLow(DeviceExtension->CommandPortBase, Regs[8]); + IDEWriteCylinderHigh(DeviceExtension->CommandPortBase, Regs[9]); + } + IDEWritePrecomp(DeviceExtension->CommandPortBase, Regs[0]); + IDEWriteSectorCount(DeviceExtension->CommandPortBase, Regs[2]); + IDEWriteSectorNum(DeviceExtension->CommandPortBase, Regs[4]); + IDEWriteCylinderLow(DeviceExtension->CommandPortBase, Regs[5]); + IDEWriteCylinderHigh(DeviceExtension->CommandPortBase, Regs[6]); + + IDEWriteDriveHead(DeviceExtension->CommandPortBase, IDE_DH_FIXED|DrvHead); + #ifdef ENABLE_DMA if (DeviceExtension->PRDTable && DeviceExtension->DeviceFlags[Srb->TargetId] & DEVICE_DMA_CMD) @@ -2135,7 +2186,14 @@ if (DeviceExtension->UseDma) { Handler = AtapiDmaInterrupt; - Command = Srb->SrbFlags & SRB_FLAGS_DATA_IN ? IDE_CMD_READ_DMA : IDE_CMD_WRITE_DMA; + if (DeviceExtension->DeviceFlags[Srb->TargetId] & DEVICE_48BIT_ADDRESS) + { + Command = Srb->SrbFlags & SRB_FLAGS_DATA_IN ? IDE_CMD_READ_DMA_EXT : IDE_CMD_WRITE_DMA_EXT; + } + else + { + Command = Srb->SrbFlags & SRB_FLAGS_DATA_IN ? IDE_CMD_READ_DMA : IDE_CMD_WRITE_DMA; + } } else #endif @@ -2143,11 +2201,25 @@ Handler = Srb->SrbFlags & SRB_FLAGS_DATA_IN ? AtapiReadInterrupt : AtapiWriteInterrupt; if (DeviceExtension->DeviceFlags[Srb->TargetId] & DEVICE_MULTI_SECTOR_CMD) { - Command = Srb->SrbFlags & SRB_FLAGS_DATA_IN ? IDE_CMD_READ_MULTIPLE : IDE_CMD_WRITE_MULTIPLE; + if (DeviceExtension->DeviceFlags[Srb->TargetId] & DEVICE_48BIT_ADDRESS) + { + Command = Srb->SrbFlags & SRB_FLAGS_DATA_IN ? IDE_CMD_READ_MULTIPLE_EXT : IDE_CMD_WRITE_MULTIPLE_EXT; + } + else + { + Command = Srb->SrbFlags & SRB_FLAGS_DATA_IN ? IDE_CMD_READ_MULTIPLE : IDE_CMD_WRITE_MULTIPLE; + } } else { - Command = Srb->SrbFlags & SRB_FLAGS_DATA_IN ? IDE_CMD_READ : IDE_CMD_WRITE; + if (DeviceExtension->DeviceFlags[Srb->TargetId] & DEVICE_48BIT_ADDRESS) + { + Command = Srb->SrbFlags & SRB_FLAGS_DATA_IN ? IDE_CMD_READ_EXT : IDE_CMD_WRITE_EXT; + } + else + { + Command = Srb->SrbFlags & SRB_FLAGS_DATA_IN ? IDE_CMD_READ : IDE_CMD_WRITE; + } } } @@ -2274,7 +2346,9 @@ ScsiPortStallExecution(10); /* Issue command to drive */ - AtapiExecuteCommand(DeviceExtension, IDE_CMD_FLUSH_CACHE, AtapiNoDataInterrupt); + AtapiExecuteCommand(DeviceExtension, + DeviceExtension->DeviceFlags[Srb->TargetId] & DEVICE_48BIT_ADDRESS ? IDE_CMD_FLUSH_CACHE_EXT : IDE_CMD_FLUSH_CACHE, + AtapiNoDataInterrupt); /* Wait for controller ready */ for (Retries = 0; Retries < IDE_MAX_WRITE_RETRIES; Retries++) Index: drivers/storage/atapi/atapi.h =================================================================== --- drivers/storage/atapi/atapi.h (revision 13806) +++ drivers/storage/atapi/atapi.h (working copy) @@ -64,21 +64,27 @@ #define IDE_REG_COMMAND 0x0007 /* IDE/ATA commands */ -#define IDE_CMD_RESET 0x08 -#define IDE_CMD_READ 0x20 -#define IDE_CMD_READ_RETRY 0x21 -#define IDE_CMD_WRITE 0x30 -#define IDE_CMD_WRITE_RETRY 0x31 -#define IDE_CMD_PACKET 0xA0 -#define IDE_CMD_READ_MULTIPLE 0xC4 -#define IDE_CMD_WRITE_MULTIPLE 0xC5 -#define IDE_CMD_READ_DMA 0xC8 -#define IDE_CMD_WRITE_DMA 0xCA -#define IDE_CMD_FLUSH_CACHE 0xE7 -#define IDE_CMD_FLUSH_CACHE_EXT 0xEA -#define IDE_CMD_IDENT_ATA_DRV 0xEC -#define IDE_CMD_IDENT_ATAPI_DRV 0xA1 -#define IDE_CMD_GET_MEDIA_STATUS 0xDA +#define IDE_CMD_RESET 0x08 +#define IDE_CMD_READ 0x20 +#define IDE_CMD_READ_ONCE 0x21 +#define IDE_CMD_READ_EXT 0x24 /* 48 bit */ +#define IDE_CMD_READ_DMA_EXT 0x25 /* 48 bit */ +#define IDE_CMD_READ_MULTIPLE_EXT 0x29 /* 48 bit */ +#define IDE_CMD_WRITE 0x30 +#define IDE_CMD_WRITE_ONCE 0x31 +#define IDE_CMD_WRITE_EXT 0x34 /* 48 bit */ +#define IDE_CMD_WRITE_DMA_EXT 0x35 /* 48 bit */ +#define IDE_CMD_WRITE_MULTIPLE_EXT 0x39 /* 48 bit */ +#define IDE_CMD_PACKET 0xA0 +#define IDE_CMD_READ_MULTIPLE 0xC4 +#define IDE_CMD_WRITE_MULTIPLE 0xC5 +#define IDE_CMD_READ_DMA 0xC8 +#define IDE_CMD_WRITE_DMA 0xCA +#define IDE_CMD_FLUSH_CACHE 0xE7 +#define IDE_CMD_FLUSH_CACHE_EXT 0xEA /* 48 bit */ +#define IDE_CMD_IDENT_ATA_DRV 0xEC +#define IDE_CMD_IDENT_ATAPI_DRV 0xA1 +#define IDE_CMD_GET_MEDIA_STATUS 0xDA // // Access macros for command registers

1 0

RE: [ros-dev] Alex has fixed the laptop problem
by Murphy, Ged (Bolton) 03 Mar '05

03 Mar '05

> -----Original Message----- > From: Casper Hornstrup [mailto:ch@csh-consult.dk] > Sent: 03 March 2005 12:36 > To: 'ReactOS Development List' > Subject: RE: [ros-dev] Alex has fixed the laptop problem > > > > -----Original Message----- > > From: ros-dev-bounces(a)reactos.com > > [mailto:ros-dev-bounces@reactos.com] On Behalf Of Murphy, Ged (Bolton) > > Sent: 3. marts 2005 09:25 > > To: 'ReactOS Development List' > > Subject: RE: [ros-dev] Alex has fixed the laptop problem > > > > Alex Ionescu wrote: > > > > > Do you want to delay 0.2.6 until I merge with tip? Else it > > will be for > > > 0.3.x/0.2.7 > > > > > > Best regards, > > > Alex Ionescu > > > > What is tip ? > > He means trunk. Tip (or HEAD) is the latest revision in the repository. > Alex, when will you be ready to merge ? ************************************************************************ The information contained in this message or any of its attachments is confidential and is intended for the exclusive use of the addressee. The information may also be legally privileged. The views expressed may not be company policy, but the personal views of the originator. If you are not the addressee, any disclosure, reproduction, distribution or other dissemination or use of this communication is strictly prohibited. If you have received this message in error, please contact postmaster(a)exideuk.co.uk <mailto:postmaster@exideuk.co.uk> and then delete this message. Exide Technologies is an industrial and transportation battery producer and recycler with operations in 89 countries. Further information can be found at www.exide.com

2 1

RE: [ros-dev] Alex has fixed the laptop problem
by Murphy, Ged (Bolton) 03 Mar '05

03 Mar '05

Alex Ionescu wrote: > Do you want to delay 0.2.6 until I merge with tip? Else it will be for > 0.3.x/0.2.7 > > Best regards, > Alex Ionescu What is tip ? ************************************************************************ The information contained in this message or any of its attachments is confidential and is intended for the exclusive use of the addressee. The information may also be legally privileged. The views expressed may not be company policy, but the personal views of the originator. If you are not the addressee, any disclosure, reproduction, distribution or other dissemination or use of this communication is strictly prohibited. If you have received this message in error, please contact postmaster(a)exideuk.co.uk <mailto:postmaster@exideuk.co.uk> and then delete this message. Exide Technologies is an industrial and transportation battery producer and recycler with operations in 89 countries. Further information can be found at www.exide.com

2 1

RE: [ros-diffs] [ea] 13792: Fix SM\Subsystems\Required andSM\Subsystems\Optional.
by Casper Hornstrup 03 Mar '05

03 Mar '05

Why is it needed to expand the unicode characters to hex? ________________________________ Modified: trunk/reactos/bootdata/hivesys.inf --- trunk/reactos/bootdata/hivesys.inf 2005-03-01 22:22:56 UTC (rev 13791) +++ trunk/reactos/bootdata/hivesys.inf 2005-03-01 22:56:51 UTC (rev 13792) @@ -257,10 +257,10 @@ ; Subsystems HKLM,"SYSTEM\CurrentControlSet\Control\Session Manager\Subsystems","Debug",0x00020000,"" HKLM,"SYSTEM\CurrentControlSet\Control\Session Manager\Subsystems","Kmode",0x00020000,"%SystemRoot%\system32\win32k.sys" -HKLM,"SYSTEM\CurrentControlSet\Control\Session Manager\Subsystems","Optional",0x00070000,"Posix Os2" +HKLM,"SYSTEM\CurrentControlSet\Control\Session Manager\Subsystems","Optional",0x00070001,50,00,6f,00,73,00,69,00,78,00,00,00,4f,00,73,00,32,00,00,00,00,00 HKLM,"SYSTEM\CurrentControlSet\Control\Session Manager\Subsystems","Os2",0x00020000,"%SystemRoot%\system32\os2ss.exe" HKLM,"SYSTEM\CurrentControlSet\Control\Session Manager\Subsystems","Posix",0x00020000,"%SystemRoot%\system32\psxss.exe" -HKLM,"SYSTEM\CurrentControlSet\Control\Session Manager\Subsystems","Required",0x00070000,"Debug Windows" +HKLM,"SYSTEM\CurrentControlSet\Control\Session Manager\Subsystems","Required",0x00070001,44,00,65,00,62,00,75,00,67,00,00,00,57,00,69,00,6e,00,64,00,6f,00,77,00,73,00,00,00,00,00 HKLM,"SYSTEM\CurrentControlSet\Control\Session Manager\Subsystems","Windows",0x00020000,"%SystemRoot%\system32\csrss.exe" ; 3Com 3c905 Driver

4 5

Changelog 0.2.6 Release.
by Steven Edwards 03 Mar '05

03 Mar '05

Hi, I guess now or never eh? If no one does it in the next few days I will branch and do a build. http://reactos.com/wiki/index.php/ChangeLog-0.2.6 Thanks Steven __________________________________ Do you Yahoo!? Yahoo! Sports - Sign up for Fantasy Baseball. http://baseball.fantasysports.yahoo.com/

4 3

Re: [ros-svn] [navaraf] 13802: Fix W->A conversions in EnumDisplaySettingsExA. This is dedicated to Caroline!
by Alex Ionescu 03 Mar '05

03 Mar '05

navaraf(a)svn.reactos.com wrote: >Fix W->A conversions in EnumDisplaySettingsExA. This is dedicated to Caroline! > > >Updated files: >trunk/reactos/lib/user32/misc/display.c > >_______________________________________________ >Ros-svn mailing list >Ros-svn(a)reactos.com >http://reactos.com:8080/mailman/listinfo/ros-svn > > > http://www.relsoft.net/mplayer.jpg

1 0

win32k crash on shutdown details
by Royce Mitchell III 03 Mar '05

03 Mar '05

FWIW, Alex is also experiencing this problem... Basically while shutting down for reboot, I hit Ctrl+Alt on the keyboard, and it crashed. Here's the dump: (smss.c:85) SM: Process terminated! (ke/error.c:54) Hard error c000021a (ke/catch.c:142) Unhandled UserMode exception, terminating thread KeBugCheckWithTf at ke/catch.c:177 Bug detected (code 1e param 0 0 0 0) KMODE_EXCEPTION_NOT_HANDLED Page Fault Exception: 14(0) Processor: 0 CS:EIP 8:9d5b40ef <win32k.sys: 180ef> cr2 cdcdcef1 cr3 27000 Proc: 8048d8e0 Pid: 4 <System> Thrd: 80670050 Tid: 78 DS 10 ES 10 FS 30 GS 10 EAX: cdcdcdcd EBX: 9d5b3db2 ECX: 80593a50 EDX: 80670084 EBP: 9d70fdd8 ESI: 00000000 ESP: 9d70fcbc EDI: 00000000 EFLAGS: 00000282 kESP 9d70fcbc kernel stack base 9d70d000 Frames: <ntoskrnl.exe: 33f0> here's the assembly instruction where we crashed: <win32k.sys: 180ef> cmpl $0x0,0x124(%eax) here's what addr2line gives: C:\cvs\reactos\subsys\win32k>a 180ef C:/cvs/reactos/subsys/win32k/ntuser/input.c:380 subsys/win32k/ntuser/input.c:380: if (FocusThread && FocusThread->Tcb.Win32Thread && so FocusThread is 0xcdcdcdcd, which means that the FocusQueue holding it is getting deleted out from under us. after initial examination, we aren't ref counting the desktop or the queue when we obtain it via IntGetFocusMessageQueue(). as this bug is occuring on shutdown, I think the most proper solution is to reference the msgqueue until we're done with it there in ntuser/input.c. However, in order to safely reference the msgqueue, it seems we really need to reference the desktop at least long enough to obtain the msgqueue pointer and reference it. This sounds very slow, so I'm wondering if there's a better fix than that... I was thinking we could add a "shutdown hack" for this, by at the very least killing InputDesktop sooner, but it seems that might not help in situations where we're killing one of many desktops. Anyways, I'm not confident what should be done in this case, so I'm passing this information to the list in hopes that someone more familiar with the msgqueue code can fix it. Thanks, Royce Mitchell III <ntoskrnl.exe: 33f0>

1 0

Memory Manager Patch to allow mapping of device memory into UserMode - please review.
by Gregor Anich 03 Mar '05

03 Mar '05

Hi! I have changed the memory manager to allow mapping of sections from \Device\PhysicalMemory which are outside of RAM - this gets NVIDIA OpenGL working. I hope my changes are correct (according to Hartmuts suggestions in this mail: http://reactos.com:8080/archives/public/ros-kernel/2004-August/004444.html) I changed MmProbeAndLockPages to set MDL_IO_SPACE in the MdlFlags of the Mdl if one of the Pfns described in the MDL is outside of the RAM (>= MmPageArraySize) which is then used in MmMapLockedPagesSpecifyCache to decide wether to call MmCreateVirtualMapping or MmCreateVirtualMappingUnsafe (in order to prevent bugchecks in mm/freelist.c when Pfns are checked against MmPageArraySize) - blight Index: include/internal/mm.h =================================================================== --- include/internal/mm.h (revision 13428) +++ include/internal/mm.h (working copy) @@ -626,6 +626,7 @@ VOID MmSetLRULastPage(PFN_TYPE Page); VOID MmLockPage(PFN_TYPE Page); +VOID MmLockPageUnsafe(PFN_TYPE Page); VOID MmUnlockPage(PFN_TYPE Page); @@ -710,6 +711,7 @@ VOID MmDereferencePage(PFN_TYPE Page); VOID MmReferencePage(PFN_TYPE Page); +VOID MmReferencePageUnsafe(PFN_TYPE Page); BOOLEAN MmIsAccessedAndResetAccessPage(struct _EPROCESS* Process, PVOID Address); Index: mm/section.c =================================================================== --- mm/section.c (revision 13428) +++ mm/section.c (working copy) @@ -721,6 +721,9 @@ MmSharePageEntrySectionSegment(Segment, Offset); + /* FIXME: Should we call MmCreateVirtualMappingUnsafe if + * (Section->AllocationAttributes & SEC_PHYSICALMEMORY) is true? + */ Status = MmCreateVirtualMapping(MemoryArea->Process, Address, Attributes, @@ -823,14 +826,14 @@ * Just map the desired physical page */ Page = (Offset + MemoryArea->Data.SectionData.ViewOffset) >> PAGE_SHIFT; - Status = MmCreateVirtualMapping(AddressSpace->Process, - Address, - Region->Protect, - &Page, - 1); + Status = MmCreateVirtualMappingUnsafe(AddressSpace->Process, + Address, + Region->Protect, + &Page, + 1); if (!NT_SUCCESS(Status)) { - DPRINT("MmCreateVirtualMapping failed, not out of memory\n"); + DPRINT("MmCreateVirtualMappingUnsafe failed, not out of memory\n"); KEBUGCHECK(0); return(Status); } @@ -840,7 +843,7 @@ */ if (Locked) { - MmLockPage(Page); + MmLockPageUnsafe(Page); } /* Index: mm/mdl.c =================================================================== --- mm/mdl.c (revision 13428) +++ mm/mdl.c (working copy) @@ -29,7 +29,7 @@ /* MDL Flags desc. -MDL_PAGES_LOCKED MmProbelAndLockPages has been called for this mdl +MDL_PAGES_LOCKED MmProbeAndLockPages has been called for this mdl MDL_SOURCE_IS_NONPAGED_POOL mdl has been build by MmBuildMdlForNonPagedPool MDL_PARTIAL mdl has been built by IoBuildPartialMdl MDL_MAPPING_CAN_FAIL in case of an error, MmMapLockedPages will return NULL instead of to bugcheck @@ -300,7 +300,7 @@ { memcpy(Mdl + 1, Pages, sizeof(PFN_TYPE) * (PAGE_ROUND_UP(Mdl->ByteOffset+Mdl->ByteCount)/PAGE_SIZE)); - //FIXME: this flag should be set by the caller perhaps? + /* FIXME: this flag should be set by the caller perhaps? */ Mdl->MdlFlags |= MDL_IO_PAGE_READ; } @@ -374,8 +374,8 @@ ASSERT(NrPages <= (Mdl->Size - sizeof(MDL))/sizeof(PFN_TYPE)); - if (Mdl->StartVa >= (PVOID)KERNEL_BASE && - MmGetPfnForProcess(NULL, Mdl->StartVa) > MmPageArraySize) + if (Mdl->StartVa >= (PVOID)KERNEL_BASE && + MmGetPfnForProcess(NULL, Mdl->StartVa) >= MmPageArraySize) { /* phys addr is not phys memory so this must be io memory */ @@ -391,13 +391,13 @@ if (Mdl->StartVa >= (PVOID)KERNEL_BASE) { - //FIXME: why isn't AccessMode used? + /* FIXME: why isn't AccessMode used? */ Mode = KernelMode; Mdl->Process = NULL; } else { - //FIXME: why isn't AccessMode used? + /* FIXME: why isn't AccessMode used? */ Mode = UserMode; Mdl->Process = CurrentProcess; } @@ -455,7 +455,10 @@ } Page = MmGetPfnForProcess(NULL, Address); MdlPages[i] = Page; - MmReferencePage(Page); + if (Page >= MmPageArraySize) + Mdl->MdlFlags |= MDL_IO_SPACE; + else + MmReferencePage(Page); } MmUnlockAddressSpace(&CurrentProcess->AddressSpace); @@ -848,11 +851,18 @@ Protect |= PAGE_NOCACHE; else if (CacheType == MmWriteCombined) DPRINT("CacheType MmWriteCombined not supported!\n"); - Status = MmCreateVirtualMapping(CurrentProcess, - Base, - Protect, - MdlPages, - PageCount); + if (Mdl->MdlFlags & MDL_IO_SPACE) + Status = MmCreateVirtualMappingUnsafe(CurrentProcess, + Base, + Protect, + MdlPages, + PageCount); + else + Status = MmCreateVirtualMapping(CurrentProcess, + Base, + Protect, + MdlPages, + PageCount); if (!NT_SUCCESS(Status)) { DbgPrint("Unable to create virtual mapping\n"); Index: mm/freelist.c =================================================================== --- mm/freelist.c (revision 13428) +++ mm/freelist.c (working copy) @@ -612,15 +612,15 @@ } VOID -MmReferencePage(PFN_TYPE Pfn) +MmReferencePageUnsafe(PFN_TYPE Pfn) { KIRQL oldIrql; - DPRINT("MmReferencePage(PysicalAddress %x)\n", Pfn << PAGE_SHIFT); + DPRINT("MmReferencePageUnsafe(PysicalAddress %x)\n", Pfn << PAGE_SHIFT); if (Pfn == 0 || Pfn >= MmPageArraySize) { - KEBUGCHECK(0); + return; } KeAcquireSpinLock(&PageListLock, &oldIrql); @@ -635,6 +635,19 @@ KeReleaseSpinLock(&PageListLock, oldIrql); } +VOID +MmReferencePage(PFN_TYPE Pfn) +{ + DPRINT("MmReferencePage(PysicalAddress %x)\n", Pfn << PAGE_SHIFT); + + if (Pfn == 0 || Pfn >= MmPageArraySize) + { + KEBUGCHECK(0); + } + + MmReferencePageUnsafe(Pfn); +} + ULONG MmGetReferenceCountPage(PFN_TYPE Pfn) { @@ -781,15 +794,15 @@ } VOID -MmLockPage(PFN_TYPE Pfn) +MmLockPageUnsafe(PFN_TYPE Pfn) { KIRQL oldIrql; - DPRINT("MmLockPage(PhysicalAddress %x)\n", Pfn << PAGE_SHIFT); + DPRINT("MmLockPageUnsafe(PhysicalAddress %x)\n", Pfn << PAGE_SHIFT); if (Pfn == 0 || Pfn >= MmPageArraySize) { - KEBUGCHECK(0); + return; } KeAcquireSpinLock(&PageListLock, &oldIrql); @@ -805,6 +818,19 @@ } VOID +MmLockPage(PFN_TYPE Pfn) +{ + DPRINT("MmLockPage(PhysicalAddress %x)\n", Pfn << PAGE_SHIFT); + + if (Pfn == 0 || Pfn >= MmPageArraySize) + { + KEBUGCHECK(0); + } + + MmLockPageUnsafe(Pfn); +} + +VOID MmUnlockPage(PFN_TYPE Pfn) { KIRQL oldIrql;

2 2

Re: Re: [ros-dev] added a proposed patch to bugzilla
by Roman Hoegg 02 Mar '05

02 Mar '05

1 0

Re: Re: [ros-dev] added a proposed patch to bugzilla
by Johannes Olofsson 02 Mar '05

02 Mar '05

Hi! The CAPS constant is defined to be KSHIFT, which if I understand this correct means that the shifted value is used when caps lock is used. Try to change the line : /* none, shift, ctrl-alt, ctrl, ctrl-shift */ { VK_OEM_7, NOCAPS, 0xe4, 0xe0, 0x7b, WCH_NONE, 0x00 }, /* ä à { */ to: { VK_OEM_7, KCTRL, 'code for ä', 'code for à', 0x7b, 'code for Ä', 'code for À }, /* ä à { */ in order to use the ctrl and ctrl-shift states for caps lock for this key. I don't have a test environment set up at the moment to test this, but it is possible that windows uses something like this. Regards Johannes Olofsson > Från: art yerkes <ayerkes(a)speakeasy.net> > Till: ReactOS Development List <ros-dev(a)reactos.com> > Rubrik: Re: [ros-dev] added a proposed patch to bugzilla > Datum: Tue, 1 Mar 2005 12:23:52 -0600 > <pre>On Thu, 24 Feb 2005 15:51:38 +0100 > Roman Hoegg <roman.hoegg(a)unisg.ch> wrote: > > > > > > > > as NOCAPS in your layout file > > > > yes that's true but I did that for a reason. I had two choices. Either > > can't set differentiate between SHIFT and CAPS LOCK. > > I wasn't aware that NOCAPS could be different from SHIFT, so NOCAPS always > implies shift in our current model. I'll try to fix it. > -- 10 Gigabyte Mailbox - http://mail.spray.se

1 0

Re:[ros-dev] RE: [ros-diffs] [ea] 13792: Fix SMSubsystemsRequired andSMSubsystemsOptional.
by ea＠iol.it 02 Mar '05

02 Mar '05

Date : Wed, 2 Mar 2005 12:46:30 +0100 Subject : [ros-dev] RE: [ros-diffs] [ea] 13792: Fix SM\Subsystems\Required andSM\Subsystems\Optional. Casper> Why is it needed to expand the unicode characters to hex? With value type 0x00070000 I get garbage from the SM when I pick up the Required names. If there is a way to make a REG_MULTI_SZ with a string, I'd be happy. ea ____________________________________________________________ Navighi a 2 MEGA e i primi 3 mesi sono GRATIS. Scegli Libero Adsl Flat senza limiti su http://www.libero.it

1 0

SysInternals Process Explorer
by James Tabor 02 Mar '05

02 Mar '05

Hi all! http://www.sysinternals.com/ntw2k/freeware/procexp.shtml Debug output from execution of procexp on ROS, (api/handle.c:71) CsrGetObject returning invalid handle (NTDLL:ldr/utils.c:2092) Relocating (76260000 -> 700000) C:\ReactOS\system32\ole aut32.dll (NTDLL:ldr/utils.c:2092) Relocating (77800000 -> 4e1000) C:\ReactOS\system32\win spool.drv 0 bytes requested - initiating pool verification 0 bytes requested - initiating pool verification FIXME: CopyImage doesn't support IMAGE_ICON correctly! 0 bytes requested - initiating pool verification 0 bytes requested - initiating pool verification (NTDLL:ldr/utils.c:1211) LdrGetExportByName(): failed to find mxdMessage (NTDLL:ldr/utils.c:1211) LdrGetExportByName(): failed to find auxMessage (NTDLL:ldr/utils.c:1211) LdrGetExportByName(): failed to find mxdMessage (NTDLL:ldr/utils.c:1211) LdrGetExportByName(): failed to find midMessage (NTDLL:ldr/utils.c:1211) LdrGetExportByName(): failed to find modMessage (NTDLL:ldr/utils.c:1211) LdrGetExportByName(): failed to find widMessage (NTDLL:ldr/utils.c:1211) LdrGetExportByName(): failed to find wodMessage (NTDLL:ldr/utils.c:1211) LdrGetExportByName(): failed to find auxMessage (NTDLL:ldr/utils.c:1211) LdrGetExportByName(): failed to find mxdMessage (NTDLL:ldr/utils.c:1211) LdrGetExportByName(): failed to find midMessage (NTDLL:ldr/utils.c:1211) LdrGetExportByName(): failed to find widMessage (NTDLL:ldr/utils.c:1211) LdrGetExportByName(): failed to find wodMessage (cm/ntfunc.c:379) NtDeleteKey(KeyHandle dc) called (cm/ntfunc.c:418) PointerCount 1 (NTDLL:ldr/utils.c:1211) LdrGetExportByName(): failed to find AllocateAndGetTcpE xTableFromStack (NTDLL:ldr/utils.c:1211) LdrGetExportByName(): failed to find AllocateAndGetUdpE xTableFromStack (NTDLL:ldr/utils.c:2034) Failed to create or open dll section of '.dll' (Status c0000135) (NTDLL:ldr/utils.c:2092) Relocating (76160000 -> db1000) C:\ReactOS\system32\dbg help.dll (NTDLL:ldr/utils.c:1211) LdrGetExportByName(): failed to find NtSuspendProcess (NTDLL:ldr/utils.c:1211) LdrGetExportByName(): failed to find NtResumeProcess (NTDLL:ldr/utils.c:1211) LdrGetExportByName(): failed to find EnumServicesStatus ExA (NTDLL:ldr/utils.c:1211) LdrGetExportByName(): failed to find QueryServiceConfig 2A (NTDLL:ldr/utils.c:2034) Failed to create or open dll section of 'winsta.dll' (S tatus c0000135) (NTDLL:ldr/utils.c:1091) LdrGetExportByName(): no export directory! (NTDLL:ldr/utils.c:2034) Failed to create or open dll section of 'uxtheme.dll' ( Status c0000135) (NTDLL:ldr/utils.c:1091) LdrGetExportByName(): no export directory! (NTDLL:ldr/utils.c:1091) LdrGetExportByName(): no export directory! (NTDLL:ldr/utils.c:1091) LdrGetExportByName(): no export directory! (fsctl.c:277) SysType (KERNEL32:mem/global.c:412) Memory Load: 4 *My little hack* (ex/sysinfo.c:827) NtQuerySystemInformation - SystemHandleInformation (ex/sysinfo.c:835) SystemHandleInformation 1 (ex/sysinfo.c:854) SystemHandleInformation 2 (ex/sysinfo.c:872) SystemHandleInformation 4 (sec/lsa.c:221) LsaOpenPolicy - stub (sec/lsa.c:32) (ffffffff):LsaClose stub (NTDLL:ldr/utils.c:2034) Failed to create or open dll section of 'Powrprof.dll' (Status c0000135) (NTDLL:ldr/utils.c:1091) LdrGetExportByName(): no export directory! (ex/sysinfo.c:1046) NtQuerySystemInformation - SystemInterruptInformation not im plemented (sec/lsa.c:221) LsaOpenPolicy - stub (sec/lsa.c:32) (ffffffff):LsaClose stub *Here again* (ex/sysinfo.c:827) NtQuerySystemInformation - SystemHandleInformation (ex/sysinfo.c:835) SystemHandleInformation 1 (ex/sysinfo.c:854) SystemHandleInformation 2 (ex/sysinfo.c:872) SystemHandleInformation 4 (sec/lsa.c:221) LsaOpenPolicy - stub (sec/lsa.c:32) (ffffffff):LsaClose stub (KERNEL32:misc/stubs.c:1457) GetLongPathNameA() is UNIMPLEMENTED! (sec/lsa.c:221) LsaOpenPolicy - stub (sec/lsa.c:32) (ffffffff):LsaClose stub (KERNEL32:misc/stubs.c:1457) GetLongPathNameA() is UNIMPLEMENTED! (KERNEL32:misc/stubs.c:1457) GetLongPathNameA() is UNIMPLEMENTED! (KERNEL32:misc/stubs.c:1457) GetLongPathNameA() is UNIMPLEMENTED! (sec/lsa.c:221) LsaOpenPolicy - stub (sec/lsa.c:32) (ffffffff):LsaClose stub (KERNEL32:misc/stubs.c:1457) GetLongPathNameA() is UNIMPLEMENTED! (KERNEL32:misc/stubs.c:1457) GetLongPathNameA() is UNIMPLEMENTED! (KERNEL32:misc/stubs.c:1457) GetLongPathNameA() is UNIMPLEMENTED! (sec/lsa.c:221) LsaOpenPolicy - stub (sec/lsa.c:32) (ffffffff):LsaClose stub (KERNEL32:misc/stubs.c:1457) GetLongPathNameA() is UNIMPLEMENTED! (KERNEL32:misc/stubs.c:1457) GetLongPathNameA() is UNIMPLEMENTED! (KERNEL32:misc/stubs.c:1457) GetLongPathNameA() is UNIMPLEMENTED! (sec/lsa.c:221) LsaOpenPolicy - stub (sec/lsa.c:32) (ffffffff):LsaClose stub (KERNEL32:misc/stubs.c:1457) GetLongPathNameA() is UNIMPLEMENTED! (KERNEL32:misc/stubs.c:1457) GetLongPathNameA() is UNIMPLEMENTED! (KERNEL32:misc/stubs.c:1457) GetLongPathNameA() is UNIMPLEMENTED! (sec/lsa.c:221) LsaOpenPolicy - stub (sec/lsa.c:32) (ffffffff):LsaClose stub (KERNEL32:misc/stubs.c:1457) GetLongPathNameA() is UNIMPLEMENTED! (KERNEL32:misc/stubs.c:1457) GetLongPathNameA() is UNIMPLEMENTED! (KERNEL32:misc/stubs.c:1457) GetLongPathNameA() is UNIMPLEMENTED! (sec/lsa.c:221) LsaOpenPolicy - stub (sec/lsa.c:32) (ffffffff):LsaClose stub (KERNEL32:misc/stubs.c:1457) GetLongPathNameA() is UNIMPLEMENTED! (KERNEL32:misc/stubs.c:1457) GetLongPathNameA() is UNIMPLEMENTED! (KERNEL32:misc/stubs.c:1457) GetLongPathNameA() is UNIMPLEMENTED! (sec/lsa.c:221) LsaOpenPolicy - stub (sec/lsa.c:32) (ffffffff):LsaClose stub (KERNEL32:misc/stubs.c:1457) GetLongPathNameA() is UNIMPLEMENTED! (KERNEL32:misc/stubs.c:1457) GetLongPathNameA() is UNIMPLEMENTED! (KERNEL32:misc/stubs.c:1457) GetLongPathNameA() is UNIMPLEMENTED! (sec/lsa.c:221) LsaOpenPolicy - stub (sec/lsa.c:32) (ffffffff):LsaClose stub (KERNEL32:misc/stubs.c:1457) GetLongPathNameA() is UNIMPLEMENTED! (KERNEL32:misc/stubs.c:1457) GetLongPathNameA() is UNIMPLEMENTED! (KERNEL32:misc/stubs.c:1457) GetLongPathNameA() is UNIMPLEMENTED! (sec/lsa.c:221) LsaOpenPolicy - stub (sec/lsa.c:32) (ffffffff):LsaClose stub KeBugCheckWithTf at ke/catch.c:177 Bug detected (code 1e param 0 0 0 0) KMODE_EXCEPTION_NOT_HANDLED Page Fault Exception: 14(0) Processor: 0 CS:EIP 8:8009f441 <ntoskrnl.exe: 9f441> cr2 4ea000 cr3 3b854000 Proc: 80c246b8 Pid: 130 <procexp.> Thrd: 80cc2af0 Tid: 1 34 DS 10 ES 10 FS 30 GS 23 EAX: 80c246b8 EBX: 0000009b ECX: 00001800 EDX: 00010000 EBP: 9e2d7cf8 ESI: 004ea000 ESP: 9e2d7c7c EDI: 005e8424 EFLAGS: 00010216 kESP 9e2d7c7c kernel stack base 9e2d5000 Frames: <ntoskrnl.exe: 72801> <ntoskrnl.exe: 399b> <7FFE0304>

4 5

Re: [ros-svn] [gdalsnes] 13791: tcharize a couple of routines
by Royce Mitchell III 02 Mar '05

02 Mar '05

shouldn't _tfopen() be a #define?

2 1

Re: [ros-dev] added a proposed patch to bugzilla
by Johannes Olofsson 01 Mar '05

01 Mar '05

Hi! What about the ö and ä keys? Should they behave the same way? (note that these keys and the ü key are marked as NOCAPS in your layout file). Regards Johannes Olofsson > Från: Roman Hoegg <roman.hoegg(a)unisg.ch> > Till: ros-dev(a)reactos.com > Rubrik: [ros-dev] added a proposed patch to bugzilla > Datum: Wed, 23 Feb 2005 22:58:02 +0100 Hello everybody! I've been a long time lurker and have decided to finaly contribute something to this wonderful project. quick introduction: 29, male, research assistent at the University of St. Gallen (Switzerland), some C/C++ knowledge (but not enough for serious contributions to an OS) I'm in the process of creating a keyboard layout (it's nearly finished) and have run into a problem which I posted in bugzilla. I was told on #reactos that this is the way to do it. http://reactos.com/bugzilla/show_bug.cgi?id=509 would be cool if someone with experience with keyboard layouts could give me a tip. thanks! Roman Hoegg (RomanH)_______________________________________________ Ros-dev mailing list Ros-dev(a)reactos.com http://reactos.com:8080/mailman/listinfo/ros-dev Otur i kärlek - http://www.spray.se/spel Tur i kärlek - http://www.spraydate.com

3 2

RE: [ros-svn] [ion] 13776: Test commit. Not official branch release --it will follow shortly in 15 minutes. If this ends up in HEADi will revert immediately (i have svn switched so it shouldn't)
by Casper Hornstrup 28 Feb '05

28 Feb '05

There is no need to commit to check that. You can use "svn info". Casper > -----Original Message----- > From: ros-svn-bounces(a)reactos.com > [mailto:ros-svn-bounces@reactos.com] On Behalf Of ion(a)svn.reactos.com > Sent: 28. februar 2005 17:45 > To: ros-svn(a)reactos.com > Subject: [ros-svn] [ion] 13776: Test commit. Not official > branch release --it will follow shortly in 15 minutes. If > this ends up in HEADi will revert immediately (i have svn > switched so it shouldn't) > > Test commit. Not official branch release -- it will follow > shortly in 15 minutes. If this ends up in HEAD i will revert > immediately (i have svn switched so it shouldn't)

2 1

Uptime.exe
by James Tabor 28 Feb '05

28 Feb '05

Hi, I had this for a long time, Org unknown, Good luck, James

1 0

Explorer in XP and Wallpaper changing...
by Alex Ionescu 28 Feb '05

28 Feb '05

Hi everyone, Firstly, it seems our explorer doesn't load in WXP anymore. Looks like we are directly importing NtGdiBitBlt (undocumented function) instead of relying on BitBlt. I don't see any need to use undocumented native API in explorer... I've also heard that it's impossible to built it with msvc because of numerous (43) template errors. Bizzeh on IRC knows more about this. Secondly, I've tried out the new wallpaper changing, and it crashes on my build, inside win32k. I am running qemu + optimized build...can anyone else repro? I will try other BMPs to make sure mine isn't corrupted (which still means there' s a bug). Best regards, Alex Ionescu

4 3

Re: [ros-svn] [ion] 13776: Test commit. Not official branch release -- it will follow shortly in 15 minutes. If this ends up in HEAD i will revert immediately (i have svn switched so it shouldn't)
by Alex Ionescu 28 Feb '05

28 Feb '05

SVN messed up... do not update to 13776... I will revert. ion(a)svn.reactos.com wrote: >Test commit. Not official branch release -- it will follow shortly in 15 minutes. If this ends up in HEAD i will revert immediately (i have svn switched so it shouldn't) > > >Added files: >trunk/reactos/ntoskrnl/ex/error.c >trunk/reactos/ntoskrnl/ob/wait.c > >Updated files: >trunk/reactos/config >trunk/reactos/drivers/storage/floppy/floppy.c >trunk/reactos/include/ddk/extypes.h >trunk/reactos/include/ddk/iotypes.h >trunk/reactos/include/ddk/ketypes.h >trunk/reactos/include/ntos/zwtypes.h >trunk/reactos/lib/ntdll/def/ntdll.def >trunk/reactos/ntoskrnl/Makefile >trunk/reactos/ntoskrnl/cm/registry.c >trunk/reactos/ntoskrnl/ex/event.c >trunk/reactos/ntoskrnl/ex/evtpair.c >trunk/reactos/ntoskrnl/ex/init.c >trunk/reactos/ntoskrnl/ex/mutant.c >trunk/reactos/ntoskrnl/ex/rundown.c >trunk/reactos/ntoskrnl/ex/sem.c >trunk/reactos/ntoskrnl/ex/sysinfo.c >trunk/reactos/ntoskrnl/ex/timer.c >trunk/reactos/ntoskrnl/ex/work.c >trunk/reactos/ntoskrnl/include/internal/ex.h >trunk/reactos/ntoskrnl/include/internal/id.h >trunk/reactos/ntoskrnl/include/internal/io.h >trunk/reactos/ntoskrnl/include/internal/ke.h >trunk/reactos/ntoskrnl/include/internal/nls.h >trunk/reactos/ntoskrnl/include/internal/ntoskrnl.h >trunk/reactos/ntoskrnl/include/internal/ps.h >trunk/reactos/ntoskrnl/io/bootlog.c >trunk/reactos/ntoskrnl/io/create.c >trunk/reactos/ntoskrnl/io/driver.c >trunk/reactos/ntoskrnl/io/iocomp.c >trunk/reactos/ntoskrnl/io/iomgr.c >trunk/reactos/ntoskrnl/io/wmi.c >trunk/reactos/ntoskrnl/ke/apc.c >trunk/reactos/ntoskrnl/ke/bug.c >trunk/reactos/ntoskrnl/ke/catch.c >trunk/reactos/ntoskrnl/ke/dpc.c >trunk/reactos/ntoskrnl/ke/event.c >trunk/reactos/ntoskrnl/ke/i386/tskswitch.S >trunk/reactos/ntoskrnl/ke/kthread.c >trunk/reactos/ntoskrnl/ke/main.c >trunk/reactos/ntoskrnl/ke/mutex.c >trunk/reactos/ntoskrnl/ke/queue.c >trunk/reactos/ntoskrnl/ke/sem.c >trunk/reactos/ntoskrnl/ke/timer.c >trunk/reactos/ntoskrnl/ke/wait.c >trunk/reactos/ntoskrnl/ntoskrnl.def >trunk/reactos/ntoskrnl/ntoskrnl.mc >trunk/reactos/ntoskrnl/ps/kill.c >trunk/reactos/ntoskrnl/ps/process.c >trunk/reactos/ntoskrnl/ps/thread.c >trunk/reactos/ntoskrnl/rtl/nls.c >trunk/reactos/tools/nci/sysfuncs.lst > >Deleted files: >trunk/reactos/ntoskrnl/ke/alert.c >trunk/reactos/ntoskrnl/ke/critical.c >trunk/reactos/ntoskrnl/ke/error.c > >_______________________________________________ >Ros-svn mailing list >Ros-svn(a)reactos.com >http://reactos.com:8080/mailman/listinfo/ros-svn > > >

1 0

RE: [ros-svn] [sedwards] 13772: merge in Winehq changes to reduce noise
by Casper Hornstrup 28 Feb '05

28 Feb '05

You need to revert that change and merge the wine changes to the vendor branch instead and then merge them back to trunk. This is so we keep wine and ReactOS changes separate from each other. GvG has a tutorial somewhere I believe? Casper > -----Original Message----- > From: ros-svn-bounces(a)reactos.com > [mailto:ros-svn-bounces@reactos.com] On Behalf Of > sedwards(a)svn.reactos.com > Sent: 27. februar 2005 23:56 > To: ros-svn(a)reactos.com > Subject: [ros-svn] [sedwards] 13772: merge in Winehq > changes to reduce noise > > merge in Winehq changes to reduce noise > > > Updated files: > trunk/reactos/tools/widl/ChangeLog > trunk/reactos/tools/widl/parser.y > trunk/reactos/tools/widl/server.c > trunk/reactos/tools/widl/typelib.c > trunk/reactos/tools/widl/widl.c > trunk/reactos/tools/widl/widl.h > trunk/reactos/tools/widl/y.tab.c > > Deleted files: > trunk/reactos/tools/widl/client.h > trunk/reactos/tools/widl/proxy.h > trunk/reactos/tools/widl/server.h > > _______________________________________________ > Ros-svn mailing list > Ros-svn(a)reactos.com > http://reactos.com:8080/mailman/listinfo/ros-svn

2 1

Re: [ros-diffs] [weiden] 13775: German translation fixes by Rouven Wessling
by Hartmut Birr 28 Feb '05

28 Feb '05

Are you sure that this changes are correct? - Hartmut weiden(a)svn.reactos.com schrieb: >German translation fixes by Rouven Wessling > >Modified: trunk/reactos/lib/cpl/desk/de.rc > > > *Modified: trunk/reactos/lib/cpl/desk/de.rc* > >--- trunk/reactos/lib/cpl/desk/de.rc 2005-02-28 04:43:30 UTC (rev 13774) >+++ trunk/reactos/lib/cpl/desk/de.rc 2005-02-28 14:38:02 UTC (rev 13775) >@@ -1,5 +1,46 @@ > > LANGUAGE LANG_GERMAN, SUBLANG_DEFAULT > > > >+IDM_MAINMENU MENU DISCARDABLE >+BEGIN >+ POPUP "&Optionen" >+ BEGIN >+ MENUITEM "&Eigenschaften", IDC_PROPERTIES >+ MENUITEM "Erweiterte Ein&stellungen", IDC_ADVANCED_CONTROLS >+ MENUITEM SEPARATOR >+ MENUITEM "&Beenden", IDC_EXIT >+ END >+ POPUP "&?" >+ BEGIN >+ MENUITEM "&Hilfethemen", IDC_HELP_TOPICS >+ MENUITEM SEPARATOR >+ MENUITEM "&Info", IDC_ABOUT >+ END >+END >+ >+STRINGTABLE DISCARDABLE >+BEGIN >+ IDS_SNDVOL32 "Lautstõrke Einstellungen" >+ IDS_NOMIXERDEVICES "Es sind keine aktivien Mixer vorhanden! Die Anwendung wird jetzt beendet." >+END >+ >+IDD_PREFERENCES DIALOGEX 0, 0, 224, 250 >+STYLE DS_MODALFRAME | DS_CONTEXTHELP | WS_POPUP | WS_VISIBLE | WS_CAPTION | WS_SYSMENU >+CAPTION "Eigenschaften" >+FONT 8, "MS Shell Dlg", 0, 0, 0x0 >+BEGIN >+ LTEXT "&Mixer:", -1, 7,8,48,9 >+ COMBOBOX IDC_MIXERDEVICE, 55,8,162,80, CBS_DROPDOWNLIST | WS_TABSTOP >+ GROUPBOX "Lautstõrke regeln f³r:", -1, 7,25,211,77 >+ PUSHBUTTON "Wie&dergabe", IDC_PLAYBACK, 13,43,47,8, BS_AUTORADIOBUTTON >+ PUSHBUTTON "&Aufnahme", IDC_RECORDING, 13,61,47,8, BS_AUTORADIOBUTTON >+ PUSHBUTTON "A&ndere:", IDC_OTHER, 13,80,42,8, BS_AUTORADIOBUTTON | WS_DISABLED >+ COMBOBOX IDC_LINE, 55,80,155,50, CBS_DROPDOWNLIST | WS_TABSTOP | WS_DISABLED >+ >+ PUSHBUTTON "OK", IDOK, 114,226,50,14 >+ PUSHBUTTON "Abbrechen", IDCANCEL, 168,226,50,14 >+END >+LANGUAGE LANG_GERMAN, SUBLANG_DEFAULT >+ > > > IDD_BACKGROUND DIALOGEX DISCARDABLE 0, 0, 246, 228 > STYLE DS_SHELLFONT | WS_CHILD | WS_DISABLED | WS_CAPTION > CAPTION "Desktop" > > > ------------------------------------------------------------------------

1 0

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev