- Ros-dev - ReactOS.org

Re: [ros-dev] [ros-diffs] [dreimer] 68645: [shell32] Change Trash to Recycle Bin by Lee Schroeder CORE-8391 #resolve #comment Committed the big one with changes to all RC files, because it's the right way to do that. All th...
by Thomas Faber 09 Aug '15

09 Aug '15

Well... since you asked... Really good reason not to: if something's not broken, don't fix it. Really good reason not to: if everything works fine and the user experience is generally Windows-like, we should NOT try to make things more Windows-like. On the contrary. Different is good, both in terms of project philosophy and legally. Really good reason not to: as another non-native speaker... neither of the two terms seems better than the other for any objective reason. Except that 'trash' is something people actually say :p Keep on hacking! ;) On August 9, 2015 9:56:47 AM CEST, dreimer(a)svn.reactos.org wrote: >Author: dreimer >Date: Sun Aug 9 07:56:47 2015 >New Revision: 68645 > >URL: http://svn.reactos.org/svn/reactos?rev=68645&view=rev >Log: >[shell32] >Change Trash to Recycle Bin by Lee Schroeder >CORE-8391 #resolve #comment Committed the big one with changes to all >RC files, because it's the right way to do that. All these strings are >originated from the english resource and NEVER were translated up to >now, so we keep these strings in sync. Second argument. Trash is not >the right word here (YES, a non native dares to say this ^^) We use the >Windows way here, unless someone gives me a REALLY good reason not to >^^ > >Modified: > trunk/reactos/dll/win32/shell32/lang/ca-ES.rc > trunk/reactos/dll/win32/shell32/lang/da-DK.rc > trunk/reactos/dll/win32/shell32/lang/en-US.rc > trunk/reactos/dll/win32/shell32/lang/fi-FI.rc > trunk/reactos/dll/win32/shell32/lang/he-IL.rc > trunk/reactos/dll/win32/shell32/lang/hu-HU.rc > trunk/reactos/dll/win32/shell32/lang/ko-KR.rc > trunk/reactos/dll/win32/shell32/lang/nl-NL.rc > trunk/reactos/dll/win32/shell32/lang/pt-BR.rc > trunk/reactos/dll/win32/shell32/lang/sl-SI.rc > trunk/reactos/dll/win32/shell32/lang/sv-SE.rc > trunk/reactos/dll/win32/shell32/lang/zh-TW.rc > >Modified: trunk/reactos/dll/win32/shell32/lang/ca-ES.rc >URL: >http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shell32/lang/ca-… >============================================================================== >--- trunk/reactos/dll/win32/shell32/lang/ca-ES.rc [iso-8859-1] >(original) >+++ trunk/reactos/dll/win32/shell32/lang/ca-ES.rc [iso-8859-1] Sun Aug >9 07:56:47 2015 >@@ -661,7 +661,7 @@ > /* special folders */ > IDS_DESKTOP "Desktop" > IDS_MYCOMPUTER "My Computer" >- IDS_RECYCLEBIN_FOLDER_NAME "Trash" >+ IDS_RECYCLEBIN_FOLDER_NAME "Recycle Bin" > IDS_CONTROLPANEL "Control Panel" > IDS_ADMINISTRATIVETOOLS "Administrative Tools" > >@@ -689,10 +689,10 @@ > IDS_DELETEITEM_TEXT "Are you sure you want to delete '%1'?" >IDS_DELETEMULTIPLE_TEXT "Are you sure you want to delete these %1 >items?" >IDS_DELETESELECTED_TEXT "Are you sure you want to delete the selected >item(s)?" >- IDS_TRASHITEM_TEXT "Are you sure that you want to send '%1' to the >Trash?" >- IDS_TRASHFOLDER_TEXT "Are you sure that you want to send '%1' and >all its content to the Trash?" >- IDS_TRASHMULTIPLE_TEXT "Are you sure that you want to send these >%1 items to the Trash?" >- IDS_CANTTRASH_TEXT "The item '%1' can't be sent to Trash. Do you >want to delete it instead?" >+ IDS_TRASHITEM_TEXT "Are you sure that you want to send '%1' to the >Recycle Bin?" >+ IDS_TRASHFOLDER_TEXT "Are you sure that you want to send '%1' and >all its content to the Recycle Bin?" >+ IDS_TRASHMULTIPLE_TEXT "Are you sure that you want to send these >%1 items to the Recycle Bin?" >+ IDS_CANTTRASH_TEXT "The item '%1' can't be sent to Recycle Bin. Do >you want to delete it instead?" >IDS_OVERWRITEFILE_TEXT "This folder already contains a file called >'%1'.\n\nDo you want to replace it?" > IDS_OVERWRITEFILE_CAPTION "Confirm file overwrite" >IDS_OVERWRITEFOLDER_TEXT "This folder already contains a folder named >'%1'.\n\nIf the files in the destination folder have the same names as >files in the\nselected folder they will be replaced. Do you still want >to move or copy\nthe folder?" > >Modified: trunk/reactos/dll/win32/shell32/lang/da-DK.rc >URL: >http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shell32/lang/da-… >============================================================================== >--- trunk/reactos/dll/win32/shell32/lang/da-DK.rc [iso-8859-1] >(original) >+++ trunk/reactos/dll/win32/shell32/lang/da-DK.rc [iso-8859-1] Sun Aug >9 07:56:47 2015 >@@ -667,7 +667,7 @@ > /* special folders */ > IDS_DESKTOP "Skrivebord" > IDS_MYCOMPUTER "Min Computer" >- IDS_RECYCLEBIN_FOLDER_NAME "Trash" >+ IDS_RECYCLEBIN_FOLDER_NAME "Recycle Bin" > IDS_CONTROLPANEL "Control Panel" > IDS_ADMINISTRATIVETOOLS "Administrative Tools" > >@@ -695,10 +695,10 @@ > IDS_DELETEITEM_TEXT "Er du sikker pÃ¥ du vil slette '%1'?" >IDS_DELETEMULTIPLE_TEXT "Are you sure you want to delete these %1 >items?" >IDS_DELETESELECTED_TEXT "Are you sure you want to delete the selected >item(s)?" >- IDS_TRASHITEM_TEXT "Are you sure that you want to send '%1' to the >Trash?" >- IDS_TRASHFOLDER_TEXT "Are you sure that you want to send '%1' and >all its content to the Trash?" >- IDS_TRASHMULTIPLE_TEXT "Are you sure that you want to send these >%1 items to the Trash?" >- IDS_CANTTRASH_TEXT "The item '%1' can't be sent to Trash. Do you >want to delete it instead?" >+ IDS_TRASHITEM_TEXT "Are you sure that you want to send '%1' to the >Recycle Bin?" >+ IDS_TRASHFOLDER_TEXT "Are you sure that you want to send '%1' and >all its content to the Recycle Bin?" >+ IDS_TRASHMULTIPLE_TEXT "Are you sure that you want to send these >%1 items to the Recycle Bin?" >+ IDS_CANTTRASH_TEXT "The item '%1' can't be sent to Recycle Bin. Do >you want to delete it instead?" > IDS_OVERWRITEFILE_TEXT "Overskriv fil %1?" > IDS_OVERWRITEFILE_CAPTION "BekrÃ¦ft overskrivelse af fil" >IDS_OVERWRITEFOLDER_TEXT "This folder already contains a folder named >'%1'.\n\nIf the files in the destination folder have the same names as >files in the\nselected folder they will be replaced. Do you still want >to move or copy\nthe folder?" > >Modified: trunk/reactos/dll/win32/shell32/lang/en-US.rc >URL: >http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shell32/lang/en-… >============================================================================== >--- trunk/reactos/dll/win32/shell32/lang/en-US.rc [iso-8859-1] >(original) >+++ trunk/reactos/dll/win32/shell32/lang/en-US.rc [iso-8859-1] Sun Aug >9 07:56:47 2015 >@@ -661,7 +661,7 @@ > /* special folders */ > IDS_DESKTOP "Desktop" > IDS_MYCOMPUTER "My Computer" >- IDS_RECYCLEBIN_FOLDER_NAME "Trash" >+ IDS_RECYCLEBIN_FOLDER_NAME "Recycle Bin" > IDS_CONTROLPANEL "Control Panel" > IDS_ADMINISTRATIVETOOLS "Administrative Tools" > >@@ -689,10 +689,10 @@ > IDS_DELETEITEM_TEXT "Are you sure you want to delete '%1'?" >IDS_DELETEMULTIPLE_TEXT "Are you sure you want to delete these %1 >items?" >IDS_DELETESELECTED_TEXT "Are you sure you want to delete the selected >item(s)?" >- IDS_TRASHITEM_TEXT "Are you sure that you want to send '%1' to the >Trash?" >- IDS_TRASHFOLDER_TEXT "Are you sure that you want to send '%1' and >all its content to the Trash?" >- IDS_TRASHMULTIPLE_TEXT "Are you sure that you want to send these >%1 items to the Trash?" >- IDS_CANTTRASH_TEXT "The item '%1' can't be sent to Trash. Do you >want to delete it instead?" >+ IDS_TRASHITEM_TEXT "Are you sure that you want to send '%1' to the >Recycle Bin?" >+ IDS_TRASHFOLDER_TEXT "Are you sure that you want to send '%1' and >all its content to the Recycle Bin?" >+ IDS_TRASHMULTIPLE_TEXT "Are you sure that you want to send these >%1 items to the Recycle Bin?" >+ IDS_CANTTRASH_TEXT "The item '%1' can't be sent to Recycle Bin. Do >you want to delete it instead?" >IDS_OVERWRITEFILE_TEXT "This folder already contains a file called >'%1'.\n\nDo you want to replace it?" > IDS_OVERWRITEFILE_CAPTION "Confirm file overwrite" >IDS_OVERWRITEFOLDER_TEXT "This folder already contains a folder named >'%1'.\n\nIf the files in the destination folder have the same names as >files in the\nselected folder they will be replaced. Do you still want >to move or copy\nthe folder?" > >Modified: trunk/reactos/dll/win32/shell32/lang/fi-FI.rc >URL: >http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shell32/lang/fi-… >============================================================================== >--- trunk/reactos/dll/win32/shell32/lang/fi-FI.rc [iso-8859-1] >(original) >+++ trunk/reactos/dll/win32/shell32/lang/fi-FI.rc [iso-8859-1] Sun Aug >9 07:56:47 2015 >@@ -661,7 +661,7 @@ > /* special folders */ > IDS_DESKTOP "TyÃ¶pÃ¶ytÃ¤" > IDS_MYCOMPUTER "Oma Tietokone" >- IDS_RECYCLEBIN_FOLDER_NAME "Trash" >+ IDS_RECYCLEBIN_FOLDER_NAME "Recycle Bin" > IDS_CONTROLPANEL "Control Panel" > IDS_ADMINISTRATIVETOOLS "Administrative Tools" > >@@ -689,10 +689,10 @@ > IDS_DELETEITEM_TEXT "Haluatko varmasti tuhota '%1':n?" > IDS_DELETEMULTIPLE_TEXT "Haluatko varmasti tuhota nÃ¤mÃ¤ %1?" >IDS_DELETESELECTED_TEXT "Are you sure you want to delete the selected >item(s)?" >- IDS_TRASHITEM_TEXT "Are you sure that you want to send '%1' to the >Trash?" >- IDS_TRASHFOLDER_TEXT "Are you sure that you want to send '%1' and >all its content to the Trash?" >- IDS_TRASHMULTIPLE_TEXT "Are you sure that you want to send these >%1 items to the Trash?" >- IDS_CANTTRASH_TEXT "The item '%1' can't be sent to Trash. Do you >want to delete it instead?" >+ IDS_TRASHITEM_TEXT "Are you sure that you want to send '%1' to the >Recycle Bin?" >+ IDS_TRASHFOLDER_TEXT "Are you sure that you want to send '%1' and >all its content to the Recycle Bin?" >+ IDS_TRASHMULTIPLE_TEXT "Are you sure that you want to send these >%1 items to the Recycle Bin?" >+ IDS_CANTTRASH_TEXT "The item '%1' can't be sent to Recycle Bin. Do >you want to delete it instead?" >IDS_OVERWRITEFILE_TEXT "This folder already contains a file called >'%1'.\n\nDo you want to replace it?" > IDS_OVERWRITEFILE_CAPTION "Vahvista Tiedoston Ylikirjoitus" >IDS_OVERWRITEFOLDER_TEXT "This folder already contains a folder named >'%1'.\n\nIf the files in the destination folder have the same names as >files in the\nselected folder they will be replaced. Do you still want >to move or copy\nthe folder?" > >Modified: trunk/reactos/dll/win32/shell32/lang/he-IL.rc >URL: >http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shell32/lang/he-… >============================================================================== >--- trunk/reactos/dll/win32/shell32/lang/he-IL.rc [iso-8859-1] >(original) >+++ trunk/reactos/dll/win32/shell32/lang/he-IL.rc [iso-8859-1] Sun Aug >9 07:56:47 2015 >@@ -689,10 +689,10 @@ > IDS_DELETEITEM_TEXT "Are you sure you want to delete '%1'?" >IDS_DELETEMULTIPLE_TEXT "Are you sure you want to delete these %1 >items?" >IDS_DELETESELECTED_TEXT "Are you sure you want to delete the selected >item(s)?" >- IDS_TRASHITEM_TEXT "Are you sure that you want to send '%1' to the >Trash?" >- IDS_TRASHFOLDER_TEXT "Are you sure that you want to send '%1' and >all its content to the Trash?" >- IDS_TRASHMULTIPLE_TEXT "Are you sure that you want to send these >%1 items to the Trash?" >- IDS_CANTTRASH_TEXT "The item '%1' can't be sent to Trash. Do you >want to delete it instead?" >+ IDS_TRASHITEM_TEXT "Are you sure that you want to send '%1' to the >Recycle Bin?" >+ IDS_TRASHFOLDER_TEXT "Are you sure that you want to send '%1' and >all its content to the Recycle Bin?" >+ IDS_TRASHMULTIPLE_TEXT "Are you sure that you want to send these >%1 items to the Recycle Bin?" >+ IDS_CANTTRASH_TEXT "The item '%1' can't be sent to Recycle Bin. Do >you want to delete it instead?" >IDS_OVERWRITEFILE_TEXT "This folder already contains a file called >'%1'.\n\nDo you want to replace it?" > IDS_OVERWRITEFILE_CAPTION "Confirm file overwrite" >IDS_OVERWRITEFOLDER_TEXT "This folder already contains a folder named >'%1'.\n\nIf the files in the destination folder have the same names as >files in the\nselected folder they will be replaced. Do you still want >to move or copy\nthe folder?" > >Modified: trunk/reactos/dll/win32/shell32/lang/hu-HU.rc >URL: >http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shell32/lang/hu-… >============================================================================== >--- trunk/reactos/dll/win32/shell32/lang/hu-HU.rc [iso-8859-1] >(original) >+++ trunk/reactos/dll/win32/shell32/lang/hu-HU.rc [iso-8859-1] Sun Aug >9 07:56:47 2015 >@@ -661,7 +661,7 @@ > /* special folders */ > IDS_DESKTOP "Asztal" > IDS_MYCOMPUTER "SzÃ¡mÃtÃ³gÃ©p" >- IDS_RECYCLEBIN_FOLDER_NAME "Trash" >+ IDS_RECYCLEBIN_FOLDER_NAME "Recycle Bin" > IDS_CONTROLPANEL "Control Panel" > IDS_ADMINISTRATIVETOOLS "Administrative Tools" > >@@ -689,10 +689,10 @@ > IDS_DELETEITEM_TEXT "Biztosan tÃ¶rÃ¶lni szeretnÃ©d?: '%1'?" >IDS_DELETEMULTIPLE_TEXT "Biztosan tÃ¶rÃ¶lni szeretnÃ©d ezt a(z) %1 >elemet?" >IDS_DELETESELECTED_TEXT "Are you sure you want to delete the selected >item(s)?" >- IDS_TRASHITEM_TEXT "Are you sure that you want to send '%1' to the >Trash?" >- IDS_TRASHFOLDER_TEXT "Are you sure that you want to send '%1' and >all its content to the Trash?" >- IDS_TRASHMULTIPLE_TEXT "Are you sure that you want to send these >%1 items to the Trash?" >- IDS_CANTTRASH_TEXT "The item '%1' can't be sent to Trash. Do you >want to delete it instead?" >+ IDS_TRASHITEM_TEXT "Are you sure that you want to send '%1' to the >Recycle Bin?" >+ IDS_TRASHFOLDER_TEXT "Are you sure that you want to send '%1' and >all its content to the Recycle Bin?" >+ IDS_TRASHMULTIPLE_TEXT "Are you sure that you want to send these >%1 items to the Recycle Bin?" >+ IDS_CANTTRASH_TEXT "The item '%1' can't be sent to Recycle Bin. Do >you want to delete it instead?" >IDS_OVERWRITEFILE_TEXT "This folder already contains a file called >'%1'.\n\nDo you want to replace it?" > IDS_OVERWRITEFILE_CAPTION "ÃllomÃ¡ny felÃ¼lÃrÃ¡sa" >IDS_OVERWRITEFOLDER_TEXT "This folder already contains a folder named >'%1'.\n\nIf the files in the destination folder have the same names as >files in the\nselected folder they will be replaced. Do you still want >to move or copy\nthe folder?" > >Modified: trunk/reactos/dll/win32/shell32/lang/ko-KR.rc >URL: >http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shell32/lang/ko-… >============================================================================== >--- trunk/reactos/dll/win32/shell32/lang/ko-KR.rc [iso-8859-1] >(original) >+++ trunk/reactos/dll/win32/shell32/lang/ko-KR.rc [iso-8859-1] Sun Aug >9 07:56:47 2015 >@@ -661,7 +661,7 @@ > /* special folders */ > IDS_DESKTOP "Desktop" > IDS_MYCOMPUTER "My Computer" >- IDS_RECYCLEBIN_FOLDER_NAME "Trash" >+ IDS_RECYCLEBIN_FOLDER_NAME "Recycle Bin" > IDS_CONTROLPANEL "Control Panel" > IDS_ADMINISTRATIVETOOLS "Administrative Tools" > >@@ -689,10 +689,10 @@ > IDS_DELETEITEM_TEXT "Are you sure you want to delete '%1'?" >IDS_DELETEMULTIPLE_TEXT "Are you sure you want to delete these %1 >items?" >IDS_DELETESELECTED_TEXT "Are you sure you want to delete the selected >item(s)?" >- IDS_TRASHITEM_TEXT "Are you sure that you want to send '%1' to the >Trash?" >- IDS_TRASHFOLDER_TEXT "Are you sure that you want to send '%1' and >all its content to the Trash?" >- IDS_TRASHMULTIPLE_TEXT "Are you sure that you want to send these >%1 items to the Trash?" >- IDS_CANTTRASH_TEXT "The item '%1' can't be sent to Trash. Do you >want to delete it instead?" >+ IDS_TRASHITEM_TEXT "Are you sure that you want to send '%1' to the >Recycle Bin?" >+ IDS_TRASHFOLDER_TEXT "Are you sure that you want to send '%1' and >all its content to the Recycle Bin?" >+ IDS_TRASHMULTIPLE_TEXT "Are you sure that you want to send these >%1 items to the Recycle Bin?" >+ IDS_CANTTRASH_TEXT "The item '%1' can't be sent to Recycle Bin. Do >you want to delete it instead?" >IDS_OVERWRITEFILE_TEXT "This folder already contains a file called >'%1'.\n\nDo you want to replace it?" > IDS_OVERWRITEFILE_CAPTION "Confirm file overwrite" >IDS_OVERWRITEFOLDER_TEXT "This folder already contains a folder named >'%1'.\n\nIf the files in the destination folder have the same names as >files in the\nselected folder they will be replaced. Do you still want >to move or copy\nthe folder?" > >Modified: trunk/reactos/dll/win32/shell32/lang/nl-NL.rc >URL: >http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shell32/lang/nl-… >============================================================================== >--- trunk/reactos/dll/win32/shell32/lang/nl-NL.rc [iso-8859-1] >(original) >+++ trunk/reactos/dll/win32/shell32/lang/nl-NL.rc [iso-8859-1] Sun Aug >9 07:56:47 2015 >@@ -661,7 +661,7 @@ > /* special folders */ > IDS_DESKTOP "Desktop" > IDS_MYCOMPUTER "My Computer" >- IDS_RECYCLEBIN_FOLDER_NAME "Trash" >+ IDS_RECYCLEBIN_FOLDER_NAME "Recycle Bin" > IDS_CONTROLPANEL "Control Panel" > IDS_ADMINISTRATIVETOOLS "Administrative Tools" > >@@ -689,10 +689,10 @@ > IDS_DELETEITEM_TEXT "Are you sure you want to delete '%1'?" >IDS_DELETEMULTIPLE_TEXT "Are you sure you want to delete these %1 >items?" >IDS_DELETESELECTED_TEXT "Are you sure you want to delete the selected >item(s)?" >- IDS_TRASHITEM_TEXT "Are you sure that you want to send '%1' to the >Trash?" >- IDS_TRASHFOLDER_TEXT "Are you sure that you want to send '%1' and >all its content to the Trash?" >- IDS_TRASHMULTIPLE_TEXT "Are you sure that you want to send these >%1 items to the Trash?" >- IDS_CANTTRASH_TEXT "The item '%1' can't be sent to Trash. Do you >want to delete it instead?" >+ IDS_TRASHITEM_TEXT "Are you sure that you want to send '%1' to the >Recycle Bin?" >+ IDS_TRASHFOLDER_TEXT "Are you sure that you want to send '%1' and >all its content to the Recycle Bin?" >+ IDS_TRASHMULTIPLE_TEXT "Are you sure that you want to send these >%1 items to the Recycle Bin?" >+ IDS_CANTTRASH_TEXT "The item '%1' can't be sent to Recycle Bin. Do >you want to delete it instead?" >IDS_OVERWRITEFILE_TEXT "This folder already contains a file called >'%1'.\n\nDo you want to replace it?" > IDS_OVERWRITEFILE_CAPTION "Confirm file overwrite" >IDS_OVERWRITEFOLDER_TEXT "This folder already contains a folder named >'%1'.\n\nIf the files in the destination folder have the same names as >files in the\nselected folder they will be replaced. Do you still want >to move or copy\nthe folder?" > >Modified: trunk/reactos/dll/win32/shell32/lang/pt-BR.rc >URL: >http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shell32/lang/pt-… >============================================================================== >--- trunk/reactos/dll/win32/shell32/lang/pt-BR.rc [iso-8859-1] >(original) >+++ trunk/reactos/dll/win32/shell32/lang/pt-BR.rc [iso-8859-1] Sun Aug >9 07:56:47 2015 >@@ -689,10 +689,10 @@ > IDS_DELETEITEM_TEXT "VocÃª tem certeza que deseja excluir '%1'?" >IDS_DELETEMULTIPLE_TEXT "VocÃª tem certeza que deseja excluir estes %1 >arquivos?" >IDS_DELETESELECTED_TEXT "VocÃª tem certeza que deseja excluir o(s) >arquivo(s) selecionado(s)?" >- IDS_TRASHITEM_TEXT "Are you sure that you want to send '%1' to the >Trash?" >- IDS_TRASHFOLDER_TEXT "Are you sure that you want to send '%1' and >all its content to the Trash?" >- IDS_TRASHMULTIPLE_TEXT "Are you sure that you want to send these >%1 items to the Trash?" >- IDS_CANTTRASH_TEXT "The item '%1' can't be sent to Trash. Do you >want to delete it instead?" >+ IDS_TRASHITEM_TEXT "Are you sure that you want to send '%1' to the >Recycle Bin?" >+ IDS_TRASHFOLDER_TEXT "Are you sure that you want to send '%1' and >all its content to the Recycle Bin?" >+ IDS_TRASHMULTIPLE_TEXT "Are you sure that you want to send these >%1 items to the Recycle Bin?" >+ IDS_CANTTRASH_TEXT "The item '%1' can't be sent to Recycle Bin. Do >you want to delete it instead?" >IDS_OVERWRITEFILE_TEXT "This folder already contains a file called >'%1'.\n\nDo you want to replace it?" > IDS_OVERWRITEFILE_CAPTION "Confirmar sobreescrever arquivo" >IDS_OVERWRITEFOLDER_TEXT "This folder already contains a folder named >'%1'.\n\nIf the files in the destination folder have the same names as >files in the\nselected folder they will be replaced. Do you still want >to move or copy\nthe folder?" > >Modified: trunk/reactos/dll/win32/shell32/lang/sl-SI.rc >URL: >http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shell32/lang/sl-… >============================================================================== >--- trunk/reactos/dll/win32/shell32/lang/sl-SI.rc [iso-8859-1] >(original) >+++ trunk/reactos/dll/win32/shell32/lang/sl-SI.rc [iso-8859-1] Sun Aug >9 07:56:47 2015 >@@ -661,7 +661,7 @@ > /* special folders */ > IDS_DESKTOP "Desktop" > IDS_MYCOMPUTER "My Computer" >- IDS_RECYCLEBIN_FOLDER_NAME "Trash" >+ IDS_RECYCLEBIN_FOLDER_NAME "Recycle Bin" > IDS_CONTROLPANEL "Control Panel" > IDS_ADMINISTRATIVETOOLS "Administrative Tools" > >@@ -689,10 +689,10 @@ > IDS_DELETEITEM_TEXT "Are you sure you want to delete '%1'?" >IDS_DELETEMULTIPLE_TEXT "Are you sure you want to delete these %1 >items?" >IDS_DELETESELECTED_TEXT "Are you sure you want to delete the selected >item(s)?" >- IDS_TRASHITEM_TEXT "Are you sure that you want to send '%1' to the >Trash?" >- IDS_TRASHFOLDER_TEXT "Are you sure that you want to send '%1' and >all its content to the Trash?" >- IDS_TRASHMULTIPLE_TEXT "Are you sure that you want to send these >%1 items to the Trash?" >- IDS_CANTTRASH_TEXT "The item '%1' can't be sent to Trash. Do you >want to delete it instead?" >+ IDS_TRASHITEM_TEXT "Are you sure that you want to send '%1' to the >Recycle Bin?" >+ IDS_TRASHFOLDER_TEXT "Are you sure that you want to send '%1' and >all its content to the Recycle Bin?" >+ IDS_TRASHMULTIPLE_TEXT "Are you sure that you want to send these >%1 items to the Recycle Bin?" >+ IDS_CANTTRASH_TEXT "The item '%1' can't be sent to Recycle Bin. Do >you want to delete it instead?" >IDS_OVERWRITEFILE_TEXT "This folder already contains a file called >'%1'.\n\nDo you want to replace it?" > IDS_OVERWRITEFILE_CAPTION "Confirm file overwrite" >IDS_OVERWRITEFOLDER_TEXT "This folder already contains a folder named >'%1'.\n\nIf the files in the destination folder have the same names as >files in the\nselected folder they will be replaced. Do you still want >to move or copy\nthe folder?" > >Modified: trunk/reactos/dll/win32/shell32/lang/sv-SE.rc >URL: >http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shell32/lang/sv-… >============================================================================== >--- trunk/reactos/dll/win32/shell32/lang/sv-SE.rc [iso-8859-1] >(original) >+++ trunk/reactos/dll/win32/shell32/lang/sv-SE.rc [iso-8859-1] Sun Aug >9 07:56:47 2015 >@@ -661,7 +661,7 @@ > /* special folders */ > IDS_DESKTOP "Desktop" > IDS_MYCOMPUTER "My Computer" >- IDS_RECYCLEBIN_FOLDER_NAME "Trash" >+ IDS_RECYCLEBIN_FOLDER_NAME "Recycle Bin" > IDS_CONTROLPANEL "Control Panel" > IDS_ADMINISTRATIVETOOLS "Administrative Tools" > >@@ -689,10 +689,10 @@ > IDS_DELETEITEM_TEXT "Are you sure you want to delete '%1'?" >IDS_DELETEMULTIPLE_TEXT "Are you sure you want to delete these %1 >items?" >IDS_DELETESELECTED_TEXT "Are you sure you want to delete the selected >item(s)?" >- IDS_TRASHITEM_TEXT "Are you sure that you want to send '%1' to the >Trash?" >- IDS_TRASHFOLDER_TEXT "Are you sure that you want to send '%1' and >all its content to the Trash?" >- IDS_TRASHMULTIPLE_TEXT "Are you sure that you want to send these >%1 items to the Trash?" >- IDS_CANTTRASH_TEXT "The item '%1' can't be sent to Trash. Do you >want to delete it instead?" >+ IDS_TRASHITEM_TEXT "Are you sure that you want to send '%1' to the >Recycle Bin?" >+ IDS_TRASHFOLDER_TEXT "Are you sure that you want to send '%1' and >all its content to the Recycle Bin?" >+ IDS_TRASHMULTIPLE_TEXT "Are you sure that you want to send these >%1 items to the Recycle Bin?" >+ IDS_CANTTRASH_TEXT "The item '%1' can't be sent to Recycle Bin. Do >you want to delete it instead?" >IDS_OVERWRITEFILE_TEXT "This folder already contains a file called >'%1'.\n\nDo you want to replace it?" > IDS_OVERWRITEFILE_CAPTION "Confirm file overwrite" >IDS_OVERWRITEFOLDER_TEXT "This folder already contains a folder named >'%1'.\n\nIf the files in the destination folder have the same names as >files in the\nselected folder they will be replaced. Do you still want >to move or copy\nthe folder?" > >Modified: trunk/reactos/dll/win32/shell32/lang/zh-TW.rc >URL: >http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shell32/lang/zh-… >============================================================================== >--- trunk/reactos/dll/win32/shell32/lang/zh-TW.rc [iso-8859-1] >(original) >+++ trunk/reactos/dll/win32/shell32/lang/zh-TW.rc [iso-8859-1] Sun Aug >9 07:56:47 2015 >@@ -697,10 +697,10 @@ > IDS_DELETEITEM_TEXT "Are you sure you want to delete '%1'?" >IDS_DELETEMULTIPLE_TEXT "Are you sure you want to delete these %1 >items?" >IDS_DELETESELECTED_TEXT "Are you sure you want to delete the selected >item(s)?" >- IDS_TRASHITEM_TEXT "Are you sure that you want to send '%1' to the >Trash?" >- IDS_TRASHFOLDER_TEXT "Are you sure that you want to send '%1' and >all its content to the Trash?" >- IDS_TRASHMULTIPLE_TEXT "Are you sure that you want to send these >%1 items to the Trash?" >- IDS_CANTTRASH_TEXT "The item '%1' can't be sent to Trash. Do you >want to delete it instead?" >+ IDS_TRASHITEM_TEXT "Are you sure that you want to send '%1' to the >Recycle Bin?" >+ IDS_TRASHFOLDER_TEXT "Are you sure that you want to send '%1' and >all its content to the Recycle Bin?" >+ IDS_TRASHMULTIPLE_TEXT "Are you sure that you want to send these >%1 items to the Recycle Bin?" >+ IDS_CANTTRASH_TEXT "The item '%1' can't be sent to Recycle Bin. Do >you want to delete it instead?" >IDS_OVERWRITEFILE_TEXT "This folder already contains a file called >'%1'.\n\nDo you want to replace it?" > IDS_OVERWRITEFILE_CAPTION "Confirm file overwrite" >IDS_OVERWRITEFOLDER_TEXT "This folder already contains a folder named >'%1'.\n\nIf the files in the destination folder have the same names as >files in the\nselected folder they will be replaced. Do you still want >to move or copy\nthe folder?" -- Sent from my Android phone with K-9 Mail. Please excuse my brevity.

3 3

Re: [ros-dev] [ros-diffs] [aandrejevic] 68607: [FASTFAT] Irp->UserBuffer being NULL doesn't indicate any error. It could be that the caller really wants the result stored at address NULL (which can be valid, and is valid by...
by Pierre Schweitzer 07 Aug '15

07 Aug '15

This patch, as it, is really dangerous. MS allows null pointer in its Read/Write routines, but they are wrapped inside a SEH block, to prevent nasty things to happen in case of a null pointer dereference. Here we don't, meaning that a null pointer here will cause major damages. Furthermore, your commit regressed ntdll:file: https://reactos.org/sites/all/modules/reactos/testman/compare.php?ids=40042… Regards, On 08/07/2015 05:30 AM, aandrejevic(a)svn.reactos.org wrote: > Author: aandrejevic > Date: Fri Aug 7 03:30:05 2015 > New Revision: 68607 > > URL: http://svn.reactos.org/svn/reactos?rev=68607&view=rev > Log: > [FASTFAT] > Irp->UserBuffer being NULL doesn't indicate any error. It could be that the > caller really wants the result stored at address NULL (which can be valid, > and is valid by default for programs like NTVDM). > > > Modified: > trunk/reactos/drivers/filesystems/fastfat/rw.c > > Modified: trunk/reactos/drivers/filesystems/fastfat/rw.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/fastfa… > ============================================================================== > --- trunk/reactos/drivers/filesystems/fastfat/rw.c [iso-8859-1] (original) > +++ trunk/reactos/drivers/filesystems/fastfat/rw.c [iso-8859-1] Fri Aug 7 03:30:05 2015 > @@ -656,7 +656,7 @@ > } > > Buffer = VfatGetUserBuffer(IrpContext->Irp, BooleanFlagOn(IrpContext->Irp->Flags, IRP_PAGING_IO)); > - if (!Buffer) > + if (!Buffer && IrpContext->Irp->MdlAddress) > { > Status = STATUS_INVALID_USER_BUFFER; > goto ByeBye; > @@ -927,7 +927,7 @@ > OldFileSize = Fcb->RFCB.FileSize; > > Buffer = VfatGetUserBuffer(IrpContext->Irp, BooleanFlagOn(IrpContext->Irp->Flags, IRP_PAGING_IO)); > - if (!Buffer) > + if (!Buffer && IrpContext->Irp->MdlAddress) > { > Status = STATUS_INVALID_USER_BUFFER; > goto ByeBye; > > -- Pierre Schweitzer <pierre(a)reactos.org> System & Network Administrator Senior Kernel Developer ReactOS Deutschland e.V.

2 1

VcXsrv Windows X Server
by Javier Agustìn Fernàndez Arroyo 05 Aug '15

05 Aug '15

Hello, i dont know if this list is the correct place to post this, I found this software some weeks ago, and i thought it would be interesting to have it running in ReactOS. But, according its website, support for Windows XP has been stopped. So question is, what about asking author to reenable XP support via ReactOS? :) http://sourceforge.net/projects/vcxsrv/

1 0

WDM sound drivers question
by Mgr. Janusz Chmiel 31 Jul '15

31 Jul '15

Dear core developers, Is it possible to use Windows XP based WDM sound drivers with Reactos 0.4-CLT2015? Is it possible to make something so specific WDM sound driver can be incorporated to Live CD so it would work out of The box? If there is issues with using various sound drivers, how complex would bew for You to add support for general USB audio device. Last plea. Which dlls would had to be redesigned so NVDA screen reader would be used? Oleacc.dll and other mSAA based libraries? Thank You very much for Yours answers. With kindness regards. Janusz Chmiel

1 0

Unify system icons into one central folder
by Jared Smudde 24 Jul '15

24 Jul '15

Hello. I am Jared Smudde aka. Pi_User5. I propose that we move most of the icons in trunk into a central folder in the media folder. Some icons will need to stay because they might be application specific. The folder can be called icons and it would be organized according to http://standards.freedesktop.org/icon-naming-spec/icon-naming-spec-latest.h…. This way, we can eliminate duplicate icons thus making trunk slightly smaller. It will also make changing ReactOS to a different icon theme much easier. This idea was suggested by gigaherz and I would like to see it done. Thanks! Jared

3 5

Working on partitions
by stack exchange 01 Jul '15

01 Jul '15

Hi On my issue CORE-9641 <https://jira.reactos.org/browse/CORE-9641> Victor Martinez made a comment saying that Eric Kohl is currently working on partitions. If that is the case, what kind of changes are being worked on? Since I created another issue related to that (CORE-9661 <https://jira.reactos.org/browse/CORE-9661>), if this is already worked on, I don't want to look into it either, otherwise this would be what I would fix next. mfg, Gerhard Gruber

1 0

Re: [ros-dev] [ros-diffs] [cfinck] 68253: [SPOOLSS] Halfplement and document the undocumented but exported MarshallDownStructure API. Information about this API was exclusively gained by writing a custom XML file for rohita...
by Alex Ionescu 01 Jul '15

01 Jul '15

On Wed, Jun 24, 2015 at 9:26 AM, <cfinck(a)svn.reactos.org> wrote: > cbSize Well, you may at least want to validate that your dwOffsets are within cbSize? Best regards, Alex Ionescu

3 3

Re: [ros-dev] [ros-diffs] [cwittich] 68305: [BROWSEUI] don't expose some interfaces expose IID_IContextMenu3 from CBandSiteMenu
by Pierre Schweitzer 29 Jun '15

29 Jun '15

This commit regressed (badly) explorer: https://www3.heisspiter.net/explorer.png On 28/06/2015 20:22, cwittich(a)svn.reactos.org wrote: > Author: cwittich > Date: Sun Jun 28 18:22:02 2015 > New Revision: 68305 > > URL: http://svn.reactos.org/svn/reactos?rev=68305&view=rev > Log: > [BROWSEUI] > don't expose some interfaces > expose IID_IContextMenu3 from CBandSiteMenu > > Modified: > trunk/reactos/dll/win32/browseui/addressband.h > trunk/reactos/dll/win32/browseui/addresseditbox.h > trunk/reactos/dll/win32/browseui/bandsitemenu.h > trunk/reactos/dll/win32/browseui/internettoolbar.h > > Modified: trunk/reactos/dll/win32/browseui/addressband.h > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/browseui/address… > ============================================================================== > --- trunk/reactos/dll/win32/browseui/addressband.h [iso-8859-1] (original) > +++ trunk/reactos/dll/win32/browseui/addressband.h [iso-8859-1] Sun Jun 28 18:22:02 2015 > @@ -136,6 +136,5 @@ > COM_INTERFACE_ENTRY_IID(IID_IInputObjectSite, IInputObjectSite) > COM_INTERFACE_ENTRY_IID(IID_IPersist, IPersist) > COM_INTERFACE_ENTRY_IID(IID_IPersistStream, IPersistStream) > - COM_INTERFACE_ENTRY_IID(IID_IDispatch, IDispatch) > END_COM_MAP() > }; > > Modified: trunk/reactos/dll/win32/browseui/addresseditbox.h > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/browseui/address… > ============================================================================== > --- trunk/reactos/dll/win32/browseui/addresseditbox.h [iso-8859-1] (original) > +++ trunk/reactos/dll/win32/browseui/addresseditbox.h [iso-8859-1] Sun Jun 28 18:22:02 2015 > @@ -97,7 +97,6 @@ > COM_INTERFACE_ENTRY_IID(IID_IWinEventHandler, IWinEventHandler) > COM_INTERFACE_ENTRY_IID(IID_IOleCommandTarget, IOleCommandTarget) > COM_INTERFACE_ENTRY_IID(IID_IDispatch, IDispatch) > - COM_INTERFACE_ENTRY_IID(IID_IPersist, IPersist) > COM_INTERFACE_ENTRY_IID(IID_IPersistStream, IPersistStream) > END_COM_MAP() > }; > > Modified: trunk/reactos/dll/win32/browseui/bandsitemenu.h > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/browseui/bandsit… > ============================================================================== > --- trunk/reactos/dll/win32/browseui/bandsitemenu.h [iso-8859-1] (original) > +++ trunk/reactos/dll/win32/browseui/bandsitemenu.h [iso-8859-1] Sun Jun 28 18:22:02 2015 > @@ -55,6 +55,7 @@ > BEGIN_COM_MAP(CBandSiteMenu) > COM_INTERFACE_ENTRY_IID(IID_IShellService, IShellService) > COM_INTERFACE_ENTRY_IID(IID_IContextMenu2, IContextMenu2) > + COM_INTERFACE_ENTRY_IID(IID_IContextMenu3, IContextMenu3) > COM_INTERFACE_ENTRY_IID(IID_IContextMenu, IContextMenu) > END_COM_MAP() > }; > > Modified: trunk/reactos/dll/win32/browseui/internettoolbar.h > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/browseui/interne… > ============================================================================== > --- trunk/reactos/dll/win32/browseui/internettoolbar.h [iso-8859-1] (original) > +++ trunk/reactos/dll/win32/browseui/internettoolbar.h [iso-8859-1] Sun Jun 28 18:22:02 2015 > @@ -228,7 +228,6 @@ > COM_INTERFACE_ENTRY_IID(IID_IInputObject, IInputObject) > COM_INTERFACE_ENTRY_IID(IID_IOleWindow, IOleWindow) > COM_INTERFACE_ENTRY_IID(IID_IDockingWindow, IDockingWindow) > - COM_INTERFACE_ENTRY_IID(IID_IPersist, IPersist) > // COM_INTERFACE_ENTRY_IID(IID_IPersistStream, IPersistStream) > COM_INTERFACE_ENTRY_IID(IID_IPersistStreamInit, IPersistStreamInit) > COM_INTERFACE_ENTRY_IID(IID_IOleCommandTarget, IOleCommandTarget) > @@ -237,7 +236,5 @@ > COM_INTERFACE_ENTRY_IID(IID_IShellChangeNotify, IShellChangeNotify) > COM_INTERFACE_ENTRY_IID(IID_IObjectWithSite, IObjectWithSite) > COM_INTERFACE_ENTRY_IID(IID_IServiceProvider, IServiceProvider) > - COM_INTERFACE_ENTRY_IID(IID_IWinEventHandler, IWinEventHandler) > - COM_INTERFACE_ENTRY_IID(IID_IBandSite, IBandSite) > END_COM_MAP() > }; > > -- Pierre Schweitzer <pierre at reactos.org> System & Network Administrator Senior Kernel Developer ReactOS Deutschland e.V.

2 1

Re: [ros-dev] [ros-diffs] [ekohl] 68313: [NTOSKRNL] Add CmpDestroySecurityCache() and CmpDestroyHiveViewList() stubs and call them in CmpDestroyHive and CmUnloadKey(). CORE-6492 #resolve #comment Thank you Hermes! This is e...
by Thomas Faber 29 Jun '15

29 Jun '15

On 2015-06-29 20:26, ekohl(a)svn.reactos.org wrote: > Modified: trunk/reactos/ntoskrnl/config/cmmapvw.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/config/cmmapvw.c?… > ============================================================================== > --- trunk/reactos/ntoskrnl/config/cmmapvw.c [iso-8859-1] (original) > +++ trunk/reactos/ntoskrnl/config/cmmapvw.c [iso-8859-1] Mon Jun 29 18:26:56 2015 > @@ -29,3 +29,54 @@ > Hive->PinnedViews = 0; > Hive->UseCount = 0; > } > + > +VOID > +NTAPI > +CmpDestroyHiveViewList(IN PCMHIVE Hive) > +{ > + PCM_VIEW_OF_FILE CmView; > + PLIST_ENTRY EntryList; > + > + /* Do NOT destroy the views of read-only hives */ > + ASSERT(Hive->Hive.ReadOnly == FALSE); > + > + /* Free all the views inside the Pinned View List */ > + EntryList = RemoveHeadList(&Hive->PinViewListHead); > + while (EntryList != &Hive->PinViewListHead) In case you haven't found it yourself yet maybe I can speed things up in identifying the test failures here: I made RemoveHeadList on an empty list cause a security check failure a while back because when done unintentionally it can indicate a bug in the code, while OTOH it's super easy to avoid. So I'm guessing this is probably the cause, and should use a while (!IsListEmpty()) RemoveHeadList(); or similar pattern. If you have strong feelings against this check (which MS's headers don't do), let me know. > + { > + CmView = CONTAINING_RECORD(EntryList, CM_VIEW_OF_FILE, PinViewList); > + > + /* FIXME: Unmap the view if it is mapped */ > + > + ExFreePool(CmView); > + > + Hive->PinnedViews--; > + > + EntryList = RemoveHeadList(&Hive->PinViewListHead); > + } > + > + /* The Pinned View List should be empty */ > + ASSERT(IsListEmpty(&Hive->PinViewListHead) == TRUE); > + ASSERT(Hive->PinnedViews == 0); > + > + /* Now, free all the views inside the LRU View List */ > + EntryList = RemoveHeadList(&Hive->LRUViewListHead); > + while (EntryList != &Hive->LRUViewListHead) > + { > + CmView = CONTAINING_RECORD(EntryList, CM_VIEW_OF_FILE, LRUViewList); > + > + /* FIXME: Unmap the view if it is mapped */ > + > + ExFreePool(CmView); > + > + Hive->MappedViews--; > + > + EntryList = RemoveHeadList(&Hive->LRUViewListHead); > + }

2 1

Status Meeting (June 2015)
by Aleksey Bragin 23 Jun '15

23 Jun '15

Hello, Let me invite you to the monthly status meeting taking place 25th of June, 19:00 UTC, as always. IRC service will only be started shortly before the meeting. Your participation passwords and server address will be emailed to you shortly before the meeting starts, and they are going to be different once again as they are not stored in any database. Hopefully it's not much of inconvenience. Please send agenda proposals to me before the meeting. One point for agenda would be discussion of our upcoming Hackfest in Aachen, which is going to be awesome (the Hackfest, and hopefully the discussion too ;)) Regards, Aleksey Bragin

2 1

Re: [ros-dev] [ros-diffs] [hbelusca] 68139: [TOOLS] Improve bin2c by saving in a #define the size of the generated array, and specify this size in the declaration of the array so that doing sizeof(...) becomes possible. Use...
by Steven Edwards 22 Jun '15

22 Jun '15

This causes failures in cross-compiling on OS X [15/6897] Building C object hal/halx86/CMakeFiles/lib_hal_legacy.dir/pci_classes.c.obj FAILED: /usr/local/RosBE/i386/bin/i686-w64-mingw32-gcc -DDBG=1 -DKDBG=1 -DUSE_COMPILER_EXCEPTIONS -DWINVER=0x502 -D_M_IX86 -D_NTHALDLL_ -D_NTHAL_ -D_SEH_ENABLE_TRACE -D_SETUPAPI_VER=0x502 -D_USE_32BIT_TIME_T -D_USE_PSEH3=1 -D_WIN32_IE=0x600 -D_WIN32_WINDOWS=0x502 -D_WIN32_WINNT=0x502 -D_X86_ -D__REACTOS__ -D__i386__ -D_inline=__inline -Di386 -Wa,--compress-debug-sections -pipe -fms-extensions -fno-strict-aliasing -nostdinc -mstackrealign -Wold-style-declaration -Wdeclaration-after-statement -fdebug-prefix-map="/Users/steven.edwards/source/reactos/reactos"=ReactOS -gdwarf-2 -gstrict-dwarf -femit-struct-debug-detailed=none -feliminate-unused-debug-symbols -march=pentium -mtune=i686 -Werror -Wall -Wpointer-arith -Wno-char-subscripts -Wno-multichar -Wno-unused-value -Wno-maybe-uninitialized -O1 -fno-optimize-sibling-calls -fno-omit-frame-pointer -mpreferred-stack-boundary=3 -fno-set-stack-executable -g -Ihal/halx86 -I../../hal/halx86 -I../../include -I../../include/psdk -I../../include/dxsdk -Iinclude -Iinclude/psdk -Iinclude/dxsdk -Iinclude/reactos -I../../include/crt -I../../include/ddk -I../../include/ndk -I../../include/reactos -I../../include/reactos/libs -I../../hal/halx86/include -I../../ntoskrnl/include -MMD -MT hal/halx86/CMakeFiles/lib_hal_legacy.dir/pci_classes.c.obj -MF hal/halx86/CMakeFiles/lib_hal_legacy.dir/pci_classes.c.obj.d -o hal/halx86/CMakeFiles/lib_hal_legacy.dir/pci_classes.c.obj -c hal/halx86/pci_classes.c In file included from hal/halx86/pci_classes.c:4:0: /Users/steven.edwards/source/reactos/reactos/output-MinGW-i386/reactos/hal/halx86/pci_classes.h:4:33: error: 'Iu' undeclared here (not in a function) [15/6897] Building C object hal/halx86/CMakeFiles/lib_hal_legacy.dir/legacy/bussupp.c.obj FAILED: /usr/local/RosBE/i386/bin/i686-w64-mingw32-gcc -DDBG=1 -DKDBG=1 -DUSE_COMPILER_EXCEPTIONS -DWINVER=0x502 -D_M_IX86 -D_NTHALDLL_ -D_NTHAL_ -D_SEH_ENABLE_TRACE -D_SETUPAPI_VER=0x502 -D_USE_32BIT_TIME_T -D_USE_PSEH3=1 -D_WIN32_IE=0x600 -D_WIN32_WINDOWS=0x502 -D_WIN32_WINNT=0x502 -D_X86_ -D__REACTOS__ -D__i386__ -D_inline=__inline -Di386 -Wa,--compress-debug-sections -pipe -fms-extensions -fno-strict-aliasing -nostdinc -mstackrealign -Wold-style-declaration -Wdeclaration-after-statement -fdebug-prefix-map="/Users/steven.edwards/source/reactos/reactos"=ReactOS -gdwarf-2 -gstrict-dwarf -femit-struct-debug-detailed=none -feliminate-unused-debug-symbols -march=pentium -mtune=i686 -Werror -Wall -Wpointer-arith -Wno-char-subscripts -Wno-multichar -Wno-unused-value -Wno-maybe-uninitialized -O1 -fno-optimize-sibling-calls -fno-omit-frame-pointer -mpreferred-stack-boundary=3 -fno-set-stack-executable -g -Ihal/halx86 -I../../hal/halx86 -I../../include -I../../include/psdk -I../../include/dxsdk -Iinclude -Iinclude/psdk -Iinclude/dxsdk -Iinclude/reactos -I../../include/crt -I../../include/ddk -I../../include/ndk -I../../include/reactos -I../../include/reactos/libs -I../../hal/halx86/include -I../../ntoskrnl/include -MMD -MT hal/halx86/CMakeFiles/lib_hal_legacy.dir/legacy/bussupp.c.obj -MF hal/halx86/CMakeFiles/lib_hal_legacy.dir/legacy/bussupp.c.obj.d -o hal/halx86/CMakeFiles/lib_hal_legacy.dir/legacy/bussupp.c.obj -c ../../hal/halx86/legacy/bussupp.c In file included from ../../hal/halx86/legacy/bussupp.c:697:0: hal/halx86/pci_classes.h:4:33: error: 'Iu' undeclared here (not in a function) ../../hal/halx86/legacy/bussupp.c: In function 'HalpDebugPciDumpBus': ../../hal/halx86/legacy/bussupp.c:739:32: error: 'VendorTable' undeclared (first use in this function) ../../hal/halx86/legacy/bussupp.c:739:32: note: each undeclared identifier is reported only once for each function it appears in [15/6897] Building C object lib/3rdparty/adns/CMakeFiles/adns.dir/src/event.c.obj ninja: build stopped: subcommand failed. On Sun, Jun 14, 2015 at 11:13 AM, <hbelusca(a)svn.reactos.org> wrote: > Author: hbelusca > Date: Sun Jun 14 18:13:50 2015 > New Revision: 68139 > > URL: http://svn.reactos.org/svn/reactos?rev=68139&view=rev > Log: > [TOOLS] > Improve bin2c by saving in a #define the size of the generated array, and > specify this size in the declaration of the array so that doing sizeof(...) > becomes possible. Use "unsigned char" as the (portable) type of the > contents of the array. > > [HAL] > Add PCHAR casts where needed to take into account the previous > modifications. > > Modified: > trunk/reactos/hal/halx86/legacy/bussupp.c > trunk/reactos/tools/bin2c.c > > Modified: trunk/reactos/hal/halx86/legacy/bussupp.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/hal/halx86/legacy/bussupp.… > > ============================================================================== > --- trunk/reactos/hal/halx86/legacy/bussupp.c [iso-8859-1] (original) > +++ trunk/reactos/hal/halx86/legacy/bussupp.c [iso-8859-1] Sun Jun 14 > 18:13:50 2015 > @@ -715,7 +715,7 @@ > > /* Isolate the class name */ > sprintf(LookupString, "C %02x ", PciData->BaseClass); > - ClassName = strstr(ClassTable, LookupString); > + ClassName = strstr((PCHAR)ClassTable, LookupString); > if (ClassName) > { > /* Isolate the subclass name */ > @@ -736,7 +736,7 @@ > > /* Isolate the vendor name */ > sprintf(LookupString, "\r\n%04x ", PciData->VendorID); > - VendorName = strstr(VendorTable, LookupString); > + VendorName = strstr((PCHAR)VendorTable, LookupString); > if (VendorName) > { > /* Copy the vendor name into our buffer */ > > Modified: trunk/reactos/tools/bin2c.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/tools/bin2c.c?rev=68139&r1… > > ============================================================================== > --- trunk/reactos/tools/bin2c.c [iso-8859-1] (original) > +++ trunk/reactos/tools/bin2c.c [iso-8859-1] Sun Jun 14 18:13:50 2015 > @@ -13,8 +13,8 @@ > FILE* inFile; > FILE* outCFile; > FILE* outHFile; > + size_t bufLen; > unsigned char ch; > - unsigned char cnt; > > /* Validate the arguments */ > if (argc < 5) > @@ -46,14 +46,6 @@ > return -1; > } > > - /* Generate the header file and close it */ > - fprintf(outHFile, "/* This file is autogenerated, do not edit. > */\n\n"); > - fprintf(outHFile, "#ifndef CHAR\n" > - "#define CHAR char\n" > - "#endif\n\n"); > - fprintf(outHFile, "extern CHAR %s[];\n", argv[4]); > - fclose(outHFile); > - > /* Generate the source file and close it */ > fprintf(outCFile, "/* This file is autogenerated, do not edit. > */\n\n"); > if (argc >= 7) > @@ -69,25 +61,29 @@ > /* Add the array attribute */ > fprintf(outCFile, "%s ", argv[5]); > } > - fprintf(outCFile, "CHAR %s[] =\n{", argv[4]); > + fprintf(outCFile, "unsigned char %s[] =\n{", argv[4]); > > - cnt = 0; > - ch = fgetc(inFile); > + bufLen = 0; > + ch = fgetc(inFile); > while (!feof(inFile)) > { > - if ((cnt % 16) == 0) > - { > + if ((bufLen % 16) == 0) > fprintf(outCFile, "\n "); > - cnt = 0; > - } > + > fprintf(outCFile, " 0x%02x,", (unsigned int)ch); > - ++cnt; > + ++bufLen; > ch = fgetc(inFile); > } > /* Put a final NULL terminator */ > - fprintf(outCFile, "\n 0x00"); > + fprintf(outCFile, "\n 0x00"); ++bufLen; > fprintf(outCFile, "\n};\n"); > fclose(outCFile); > + > + /* Generate the header file and close it */ > + fprintf(outHFile, "/* This file is autogenerated, do not edit. > */\n\n"); > + fprintf(outHFile, "#define %s_SIZE %Iu\n" , argv[4], bufLen); > + fprintf(outHFile, "extern unsigned char %s[%Iu];\n", argv[4], bufLen); > + fclose(outHFile); > > /* Close the input file */ > fclose(inFile); > > > -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

2 1

The first ever ReactOS Hackfest
by Colin Finck 20 Jun '15

20 Jun '15

Join us for the very first ReactOS Hackfest from Friday, 7th August to Wednesday, 13th August 2015, in the German city of Aachen. Discover Germany's most-Western city in the direct neighborhood of Belgium and the Netherlands. Within the historical city center, Aachen offers a scientific environment and a high density of pubs. Let's catch this atmosphere to code the week away and achieve great results as a team! ===> It is now time to plan your trip! <=== Flights and Accommodation won't get cheaper. You find all details on this Wiki page: https://reactos.org/wiki/ReactOS_Hackfest_2015 Don't forget to add your ideas and travelling details to this page: https://reactos.org/wiki/ReactOS_Hackfest_2015/Lists If you have any further questions, just drop me a line by E-Mail or call me on the mobile phone number I sent to ros-priv. Looking forward to meet you! With best regards, Colin Finck

1 0

Re: [ros-dev] [ros-diffs] [akhaldi] 68155: [THEMEUI] Revert r67304 (Leverage add_registry_inf() as suggested by Timo). Figuring out why that doesn't work is left as an exercise for the reader. See CORE-5984 for details.
by Timo Kreuzer 16 Jun '15

16 Jun '15

If you look at the autogenerated file, you'll find this: [AddReg.NTarm] ; RAM Disk class driver HKLM,"SYSTEM\CurrentControlSet\Services\Disk","ErrorControl",0x00010001,0x00000000 HKLM,"SYSTEM\CurrentControlSet\Services\Disk","ImagePath",0x00020000,"system32\drivers\ramdisk.sys" HKLM,"SYSTEM\CurrentControlSet\Services\Disk","Start",0x00010001,0x00000000 HKLM,"SYSTEM\CurrentControlSet\Services\Disk","Type",0x00010001,0x00000001 HKLM,"SYSTEM\CurrentControlSet\Services\fastfat","Start",0x00010001,0x00000003 ; EOF ; MS Styles (Themes) HKCR,".msstyles","",0x00000000,"msstylesfile" HKCR,"msstylesfile","",0x00000000,"Visual Style File" HKCR,"msstylesfile\DefaultIcon","","0x00020000","%SystemRoot%\system32\themeui.dll,-1" HKCR,"msstylesfile\shell\open\command","",0x00000000,"%SystemRoot%\system32\rundll32.exe shell32.dll,Control_RunDLL %SystemRoot%\system32\desk.cpl desk,@Appearance /Action:OpenMSTheme file:""%1""" ; Theme File HKCR,".theme","",0x00000000,"themefile" HKCR,"themefile","",0x00000000,"Theme File" HKCR,"themefile\DefaultIcon","","0x00020000","%SystemRoot%\system32\themeui.dll,-1" HKCR,"themefile\shell\open\command","",0x00000000,"%SystemRoot%\system32\rundll32.exe shell32.dll,Control_RunDLL %SystemRoot%\system32\desk.cpl desk,@Appearance /Action:OpenTheme /file:""%1""" And now figure out, why it didn't work. Am 15.06.2015 um 22:42 schrieb akhaldi(a)svn.reactos.org: > Author: akhaldi > Date: Mon Jun 15 20:42:08 2015 > New Revision: 68155 > > URL: http://svn.reactos.org/svn/reactos?rev=68155&view=rev > Log: > [THEMEUI] Revert r67304 (Leverage add_registry_inf() as suggested by Timo). Figuring out why that doesn't work is left as an exercise for the reader. See CORE-5984 for details. > > Removed: > trunk/reactos/dll/win32/themeui/themeui_reg.inf > Modified: > trunk/reactos/boot/bootdata/hivecls.inf > trunk/reactos/dll/win32/themeui/CMakeLists.txt > > Modified: trunk/reactos/boot/bootdata/hivecls.inf > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/bootdata/hivecls.inf?… > ============================================================================== > --- trunk/reactos/boot/bootdata/hivecls.inf [iso-8859-1] (original) > +++ trunk/reactos/boot/bootdata/hivecls.inf [iso-8859-1] Mon Jun 15 20:42:08 2015 > @@ -284,6 +284,18 @@ > HKCR,"sysfile","NoOpen",0x00000000,"" > HKCR,"sysfile","FriendlyTypeName",0x00020000,"@%SystemRoot%\system32\shell32.dll,-171" > HKCR,"sysfile\DefaultIcon","",0x00020000,"%SystemRoot%\system32\shell32.dll,-154" > + > +; MS Styles (Themes) > +HKCR,".msstyles","",0x00000000,"msstylesfile" > +HKCR,"msstylesfile","",0x00000000,"Visual Style File" > +HKCR,"msstylesfile\DefaultIcon","","0x00020000","%SystemRoot%\system32\themeui.dll,-1" > +HKCR,"msstylesfile\shell\open\command","",0x00000000,"%SystemRoot%\system32\rundll32.exe shell32.dll,Control_RunDLL %SystemRoot%\system32\desk.cpl desk,@Appearance /Action:OpenMSTheme file:""%1""" > + > +; Theme File > +HKCR,".theme","",0x00000000,"themefile" > +HKCR,"themefile","",0x00000000,"Theme File" > +HKCR,"themefile\DefaultIcon","","0x00020000","%SystemRoot%\system32\themeui.dll,-1" > +HKCR,"themefile\shell\open\command","",0x00000000,"%SystemRoot%\system32\rundll32.exe shell32.dll,Control_RunDLL %SystemRoot%\system32\desk.cpl desk,@Appearance /Action:OpenTheme /file:""%1""" > > ; URL shortcuts (e.g. used in favorites folder of IExplorer) > HKCR,".url","",0x00000000,"InternetShortcut" > > Modified: trunk/reactos/dll/win32/themeui/CMakeLists.txt > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/themeui/CMakeLis… > ============================================================================== > --- trunk/reactos/dll/win32/themeui/CMakeLists.txt [iso-8859-1] (original) > +++ trunk/reactos/dll/win32/themeui/CMakeLists.txt [iso-8859-1] Mon Jun 15 20:42:08 2015 > @@ -1,5 +1,4 @@ > > add_library(themeui SHARED themeui.rc) > set_module_type(themeui win32dll ENTRYPOINT 0) > -add_registry_inf(themeui_reg.inf) > add_cd_file(TARGET themeui DESTINATION reactos/system32 FOR all) > > Removed: trunk/reactos/dll/win32/themeui/themeui_reg.inf > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/themeui/themeui_… > ============================================================================== > --- trunk/reactos/dll/win32/themeui/themeui_reg.inf [iso-8859-1] (original) > +++ trunk/reactos/dll/win32/themeui/themeui_reg.inf (removed) > @@ -1,11 +0,0 @@ > -; MS Styles (Themes) > -HKCR,".msstyles","",0x00000000,"msstylesfile" > -HKCR,"msstylesfile","",0x00000000,"Visual Style File" > -HKCR,"msstylesfile\DefaultIcon","","0x00020000","%SystemRoot%\system32\themeui.dll,-1" > -HKCR,"msstylesfile\shell\open\command","",0x00000000,"%SystemRoot%\system32\rundll32.exe shell32.dll,Control_RunDLL %SystemRoot%\system32\desk.cpl desk,@Appearance /Action:OpenMSTheme file:""%1""" > - > -; Theme File > -HKCR,".theme","",0x00000000,"themefile" > -HKCR,"themefile","",0x00000000,"Theme File" > -HKCR,"themefile\DefaultIcon","","0x00020000","%SystemRoot%\system32\themeui.dll,-1" > -HKCR,"themefile\shell\open\command","",0x00000000,"%SystemRoot%\system32\rundll32.exe shell32.dll,Control_RunDLL %SystemRoot%\system32\desk.cpl desk,@Appearance /Action:OpenTheme /file:""%1""" > > >

2 1

VMware Testbots fixed
by Colin Finck 16 Jun '15

16 Jun '15

Hi all, After some attempts yesterday and today, the VMware Testbots are finally fixed. Due to a misconfiguration, they were unfortunately testing the same revision 65663 all the time. I'm going to delete the duplicate testings for r65663 once I have some time. Unless somebody is interested in the most detailed information about randomly failing Wine tests ;) Cheers, Colin

1 0

Re: [ros-dev] [ros-diffs] [pschweitzer] 68137: [KERNEL32] Addendum to r68136: use appropriate define. Spotted by Thomas
by Timo Kreuzer 15 Jun '15

15 Jun '15

Am 14.06.2015 um 18:00 schrieb pschweitzer(a)svn.reactos.org: > Author: pschweitzer > Date: Sun Jun 14 16:00:27 2015 > New Revision: 68137 > > > - Proc = (1ULL << Processor) >> 0x20; > + Proc = (1ULL << Processor) >> MAXIMUM_PROCESSORS; This is effectively the same as "Proc = (Processor == MAXIMUM_PROCESSORS);" which is always 0. Timo

1 1

Re: [ros-dev] [ros-diffs] [cfinck] 68080: [LOCALSPL_APITEST] Write an API-Test for localspl.dll. As the original localspl.dll from Windows Server 2003 relies on proper initialization inside spoolsv.exe, we cannot test it st...
by Thomas Faber 14 Jun '15

14 Jun '15

This looks great, but I hope you're aware of the limitations of DllMain. If the test gets more complex, it might be better to do a separate CreateRemoteThread call on an exported function after the dll has been loaded. Although I guess as long as things work, this is fine ;) (maybe this is related to the SEH issue you mention in the next commit, not sure) On 2015-06-08 19:15, cfinck(a)svn.reactos.org wrote: > [LOCALSPL_APITEST] > Write an API-Test for localspl.dll. As the original localspl.dll from Windows Server 2003 relies on proper initialization inside spoolsv.exe, we cannot test it standalone as usual. > +// Running the tests from the injected DLL and redirecting their output to the pipe. > +BOOL WINAPI > +DllMain(HINSTANCE hinstDLL, DWORD fdwReason, LPVOID lpvReserved) > +{ > + char szTestName[150]; > + DWORD cbRead; > + FILE* fpStdout; > + HANDLE hCommandPipe; > + int iOldStdout; > + > + // We only want to run our test once when the DLL is injected to the process. > + if (fdwReason != DLL_PROCESS_ATTACH) > + return TRUE;

1 0

Re: [ros-dev] [ros-diffs] [akhaldi] 68051: [LAUTUS] Make the text files UTF-8 without BOM, and convert them to UTF-16 LE at compile time. Remove the now unneeded application/octet-stream type property and set native EOL one...
by Thomas Faber 14 Jun '15

14 Jun '15

Quick note: Files that get embedded into binaries or put on the CD should not use native EOL, but CRLF. This applies e.g. to inf files, as well as text files that are resources (which I believe is what these inis are?). The idea is that in a perfect world the CD image build by a Unix builder is identical to the one built by a Windows builder. On 2015-06-06 20:27, akhaldi(a)svn.reactos.org wrote: > [LAUTUS] Make the text files UTF-8 without BOM, and convert them to UTF-16 LE at compile time. Remove the now unneeded application/octet-stream type property and set native EOL one. CORE-9770 > Propchange: trunk/reactos/media/themes/lautus.msstyles/textfiles/NormalNormal.INI > ------------------------------------------------------------------------------ > svn:eol-style = native >

1 0

Name of builders/testers in buildbot
by Timo Kreuzer 14 Jun '15

14 Jun '15

Hi, The names for our builders / testers don't seem to be optimal to me. And since they seem to be sorted in the waterfall display alphabetically now, I suggest renaming them in the following way: Build_GCCLin_Debug Build_GCCLin_Release Build_GCCWin Build_MSVC_x64 Build_MSVC_x86 Test_KVM Test_VBox Test_VMW Test_VMW_Hybrid Test_WHS This way it is much more consistent, limited to actually useful information and would sort them nicely with builders left and testers right. Regards, Timo

4 4

Re: [ros-dev] [ros-diffs] [akhaldi] 68069: [OLE32_APITEST] Add test for IInitializeSpy. By Mark Jansen. See ROSTESTS-175 for more details.
by Thomas Faber 13 Jun '15

13 Jun '15

For future reference: (1) It's a bad idea to move something to a different file and edit it at the same time (2) Those constructor parameters really should be optional. The interface was trivial before, and it's a good idea to keep it that way. (I'm really only saying this because it broke the additional tests I had in my working copy :D) On 2015-06-08 13:05, akhaldi(a)svn.reactos.org wrote: > Added: trunk/rostests/apitests/include/unknownbase.h > URL: http://svn.reactos.org/svn/reactos/trunk/rostests/apitests/include/unknownb… > ============================================================================== > --- trunk/rostests/apitests/include/unknownbase.h (added) > +++ trunk/rostests/apitests/include/unknownbase.h [iso-8859-1] Mon Jun 8 11:05:35 2015 > @@ -0,0 +1,47 @@ > +#ifndef APITESTS_UNKNOWNBASE_H > +#define APITESTS_UNKNOWNBASE_H > + > +template<typename Interface> > +class CUnknownBase : public Interface > +{ > + LONG m_lRef; > + bool m_AutoDelete; > +protected: > + virtual const QITAB* GetQITab() = 0; > +public: > + > + CUnknownBase(bool autoDelete, LONG initialRef) > + : m_lRef(initialRef), > + m_AutoDelete(autoDelete) > + { > + } > + > + ULONG STDMETHODCALLTYPE AddRef () > + { > + return InterlockedIncrement( &m_lRef ); > + } > + > + ULONG STDMETHODCALLTYPE Release() > + { > + long newref = InterlockedDecrement( &m_lRef ); > + if (m_AutoDelete && newref<=0) > + { > + delete this; > + } > + return newref; > + } > + > + HRESULT STDMETHODCALLTYPE QueryInterface(REFIID riid, void** ppv) > + { > + return QISearch(this, GetQITab(), riid, ppv); > + } > + > + virtual ~CUnknownBase() {} > + > + LONG GetRef() const > + { > + return m_lRef; > + } > +}; > + > +#endif // APITESTS_UNKNOWNBASE_H

1 0

Changes in authentication for Jira
by Pierre Schweitzer 11 Jun '15

11 Jun '15

Dear all, We have proceed to a complete reimplementation of authentication server which serves Jira & Fisheye. The purpose is to rely on something maintained and stable. It should not change anything for you on daily usage. 58 accounts have been left out and will not be able to connect to Jira due to incompatible account name (using invalid chars). If you happen to be incapable of log in, please contact me so that I can rename your account. New accounts cannot be created with such invalid chars any longer. As a side note, this was a major blocker for our upgrade to Jira 6. If we do not spot anything wrong with our new authentication mechanism, then, then the upgrade to Jira 6 should happen in the next days. With my best regards, -- Pierre Schweitzer <pierre(a)reactos.org> System & Network Administrator Senior Kernel Developer ReactOS Deutschland e.V.

4 7

PATCH: Get configure and host-tools building on arm again
by Steven Edwards 11 Jun '15

11 Jun '15

-- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

1 0

Writing an API-Test for localspl.dll
by Colin Finck 07 Jun '15

07 Jun '15

Hi all, In order to verify the exact behaviour of localspl.dll on Windows Server 2003, I'm trying to write an API-Test for it. This is no problem for winspool.drv or even the Print Processor functions of localspl.dll, but its Print Provider functions pose some serious problems: * You get a table of function pointers by calling InitializePrintProvidor. * Instead of just handing over the pointers, this function first calls many undocumented ones from spoolss.dll, including CacheAddName, CacheCreateAndAddNode, GetServerPolicy, SplInitializeWinSpoolDrv, SplIsUpgrade. * Out of these undocumented functions, GetServerPolicy is the most problematic one, because it itself relies on a function pointer given by spoolsv.exe to spoolss.dll in an initialization function. My API-Test is not spoolsv.exe, so I don't initialize spoolss.dll the same way. Thus, GetServerPolicy will fail and InitializePrintProvidor as well. * For now, I worked around this problem by stubbing these functions in my spoolss.dll. I.e., GetServerPolicy just returns TRUE there and I get further. * On top of this, InitializePrintProvidor also makes use of RevertToPrinterSelf and ImpersonatePrinterClient. To let these functions succeed, the current thread actually needs to impersonate a user. For now, I worked around this problem by doing: OpenProcessToken(GetCurrentProcess(), TOKEN_DUPLICATE, &hToken); DuplicateToken(hToken, SecurityImpersonation, &hDup); ImpersonateLoggedOnUser(hDup); before calling InitializePrintProvidor. * Finally, this lets InitializePrintProvidor succeed and it gave me the table of function pointers. Unfortunately, even simple query functions like fpEnumPrinters do a RevertToPrinterSelf and then expect to be in the SYSTEM context of spoolsv.exe. When my API-Test was just run in a usual Administrator user context under Windows Server 2003, fpEnumPrinters didn't succeed. For now, I worked around this problem by running my test program as a service in the SYSTEM context. With all these problems presented, can you think of any way how I can now write a reliable API-Test for localspl.dll that could be run regularly under Windows Server 2003 and ReactOS? One idea would be to load the system spoolss.dll and then rewire the GetServerPolicy import to a function that just returns TRUE all the time. Still then, I have the problem that my API-Test would need to be run in the SYSTEM security context. Creative ideas are welcome! :) Cheers, Colin

2 1

Gallium Nine?
by Mohamed MEDIOUNI 06 Jun '15

06 Jun '15

Can Gallium Nine be used instead of WineD3D?

1 0

Vote for removing rapps DB from trunk
by daniel.reimer＠reactos.org 01 Jun '15

01 Jun '15

Hey guys, as some of you might have seen already we now have two copies of the more and more increasing RAPPS DB in trunk. This is: a) Absolutely unnecessary and does only result in one thing, two differing DBs b) Shows even more that it’s not useful to have it in trunk at all. Because of this I start a vote now to get your opinion in completely removing the RAPPS DB from trunk into a subtree like done for many other things, too. What do you think? Greetings Daniel Reimer Gesendet von Windows Mail

4 3

Re: [ros-dev] [ros-diffs] [dquintana] 67976: [DEVMGMT_NEW] At the request of Christoph von Wittich, bring devmgmt_new into the build. * Created CMakeLists.txt and added to parent folder. * Removed some references to CAtlStr...
by Ged Murphy 01 Jun '15

01 Jun '15

Eeek, I was working on this via VS and have quite a few changes in my WC, including CAtlString support for our ATL lib... -----Original Message----- From: Ros-diffs [mailto:ros-diffs-bounces@reactos.org] On Behalf Of dquintana(a)svn.reactos.org Sent: 30 May 2015 20:54 To: ros-diffs(a)reactos.org Subject: [ros-diffs] [dquintana] 67976: [DEVMGMT_NEW] At the request of Christoph von Wittich, bring devmgmt_new into the build. * Created CMakeLists.txt and added to parent folder. * Removed some references to CAtlStr... Author: dquintana Date: Sat May 30 19:53:44 2015 New Revision: 67976 URL: http://svn.reactos.org/svn/reactos?rev=67976&view=rev Log: [DEVMGMT_NEW] At the request of Christoph von Wittich, bring devmgmt_new into the build. * Created CMakeLists.txt and added to parent folder. * Removed some references to CAtlString that were not needed and are not implemented in our headers. * Fixed build with gcc. * Spread all the changes done to the english resources to the other languages. Many languages now contain untranslated strings that will need to be fixed. Note that I made no effort to fix any bugs or improve any features. The app comes as-is, except it now builds with rosbe. Added: trunk/reactos/base/applications/mscutils/devmgmt_new/CMakeLists.txt (with props) trunk/reactos/base/applications/mscutils/devmgmt_new/precomp.h - copied, changed from r67940, trunk/reactos/base/applications/mscutils/devmgmt_new/stdafx.h trunk/reactos/base/applications/mscutils/devmgmt_new/resource.h - copied unchanged from r67940, trunk/reactos/base/applications/mscutils/devmgmt_new/Resource.h Removed: trunk/reactos/base/applications/mscutils/devmgmt_new/Resource.h trunk/reactos/base/applications/mscutils/devmgmt_new/devmgmt.exe.manifest trunk/reactos/base/applications/mscutils/devmgmt_new/devmgmt.h trunk/reactos/base/applications/mscutils/devmgmt_new/devmgmt_new.sln trunk/reactos/base/applications/mscutils/devmgmt_new/devmgmt_new.vcxproj trunk/reactos/base/applications/mscutils/devmgmt_new/devmgmt_new.vcxproj.filters trunk/reactos/base/applications/mscutils/devmgmt_new/rsrc.rc trunk/reactos/base/applications/mscutils/devmgmt_new/stdafx.cpp trunk/reactos/base/applications/mscutils/devmgmt_new/stdafx.h trunk/reactos/base/applications/mscutils/devmgmt_new/targetver.h Modified: trunk/reactos/base/applications/mscutils/CMakeLists.txt trunk/reactos/base/applications/mscutils/devmgmt_new/DeviceView.cpp trunk/reactos/base/applications/mscutils/devmgmt_new/DeviceView.h trunk/reactos/base/applications/mscutils/devmgmt_new/Devices.cpp trunk/reactos/base/applications/mscutils/devmgmt_new/MainWindow.cpp trunk/reactos/base/applications/mscutils/devmgmt_new/MainWindow.h trunk/reactos/base/applications/mscutils/devmgmt_new/devmgmt.cpp trunk/reactos/base/applications/mscutils/devmgmt_new/devmgmt.rc trunk/reactos/base/applications/mscutils/devmgmt_new/lang/bg-BG.rc trunk/reactos/base/applications/mscutils/devmgmt_new/lang/de-DE.rc trunk/reactos/base/applications/mscutils/devmgmt_new/lang/el-GR.rc trunk/reactos/base/applications/mscutils/devmgmt_new/lang/en-US.rc trunk/reactos/base/applications/mscutils/devmgmt_new/lang/es-ES.rc trunk/reactos/base/applications/mscutils/devmgmt_new/lang/fr-FR.rc trunk/reactos/base/applications/mscutils/devmgmt_new/lang/he-IL.rc trunk/reactos/base/applications/mscutils/devmgmt_new/lang/id-ID.rc trunk/reactos/base/applications/mscutils/devmgmt_new/lang/it-IT.rc trunk/reactos/base/applications/mscutils/devmgmt_new/lang/ja-JP.rc trunk/reactos/base/applications/mscutils/devmgmt_new/lang/ko-KR.rc trunk/reactos/base/applications/mscutils/devmgmt_new/lang/no-NO.rc trunk/reactos/base/applications/mscutils/devmgmt_new/lang/pl-PL.rc trunk/reactos/base/applications/mscutils/devmgmt_new/lang/pt-BR.rc trunk/reactos/base/applications/mscutils/devmgmt_new/lang/ro-RO.rc trunk/reactos/base/applications/mscutils/devmgmt_new/lang/ru-RU.rc trunk/reactos/base/applications/mscutils/devmgmt_new/lang/sk-SK.rc trunk/reactos/base/applications/mscutils/devmgmt_new/lang/sq-AL.rc trunk/reactos/base/applications/mscutils/devmgmt_new/lang/sv-SE.rc trunk/reactos/base/applications/mscutils/devmgmt_new/lang/th-TH.rc trunk/reactos/base/applications/mscutils/devmgmt_new/lang/tr-TR.rc trunk/reactos/base/applications/mscutils/devmgmt_new/lang/uk-UA.rc trunk/reactos/base/applications/mscutils/devmgmt_new/lang/zh-CN.rc [This mail would be too long, it was shortened to contain the URLs only.] Modified: trunk/reactos/base/applications/mscutils/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… Added: trunk/reactos/base/applications/mscutils/devmgmt_new/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… Modified: trunk/reactos/base/applications/mscutils/devmgmt_new/DeviceView.cpp URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… Modified: trunk/reactos/base/applications/mscutils/devmgmt_new/DeviceView.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… Modified: trunk/reactos/base/applications/mscutils/devmgmt_new/Devices.cpp URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… Modified: trunk/reactos/base/applications/mscutils/devmgmt_new/MainWindow.cpp URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… Modified: trunk/reactos/base/applications/mscutils/devmgmt_new/MainWindow.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… Removed: trunk/reactos/base/applications/mscutils/devmgmt_new/Resource.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… Modified: trunk/reactos/base/applications/mscutils/devmgmt_new/devmgmt.cpp URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… Removed: trunk/reactos/base/applications/mscutils/devmgmt_new/devmgmt.exe.manifest URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… Removed: trunk/reactos/base/applications/mscutils/devmgmt_new/devmgmt.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… Modified: trunk/reactos/base/applications/mscutils/devmgmt_new/devmgmt.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… Removed: trunk/reactos/base/applications/mscutils/devmgmt_new/devmgmt_new.sln URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… Removed: trunk/reactos/base/applications/mscutils/devmgmt_new/devmgmt_new.vcxproj URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… Removed: trunk/reactos/base/applications/mscutils/devmgmt_new/devmgmt_new.vcxproj.filters URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… Modified: trunk/reactos/base/applications/mscutils/devmgmt_new/lang/bg-BG.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… Modified: trunk/reactos/base/applications/mscutils/devmgmt_new/lang/de-DE.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… Modified: trunk/reactos/base/applications/mscutils/devmgmt_new/lang/el-GR.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… Modified: trunk/reactos/base/applications/mscutils/devmgmt_new/lang/en-US.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… Modified: trunk/reactos/base/applications/mscutils/devmgmt_new/lang/es-ES.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… Modified: trunk/reactos/base/applications/mscutils/devmgmt_new/lang/fr-FR.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… Modified: trunk/reactos/base/applications/mscutils/devmgmt_new/lang/he-IL.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… Modified: trunk/reactos/base/applications/mscutils/devmgmt_new/lang/id-ID.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… Modified: trunk/reactos/base/applications/mscutils/devmgmt_new/lang/it-IT.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… Modified: trunk/reactos/base/applications/mscutils/devmgmt_new/lang/ja-JP.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… Modified: trunk/reactos/base/applications/mscutils/devmgmt_new/lang/ko-KR.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… Modified: trunk/reactos/base/applications/mscutils/devmgmt_new/lang/no-NO.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… Modified: trunk/reactos/base/applications/mscutils/devmgmt_new/lang/pl-PL.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… Modified: trunk/reactos/base/applications/mscutils/devmgmt_new/lang/pt-BR.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… Modified: trunk/reactos/base/applications/mscutils/devmgmt_new/lang/ro-RO.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… Modified: trunk/reactos/base/applications/mscutils/devmgmt_new/lang/ru-RU.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… Modified: trunk/reactos/base/applications/mscutils/devmgmt_new/lang/sk-SK.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… Modified: trunk/reactos/base/applications/mscutils/devmgmt_new/lang/sq-AL.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… Modified: trunk/reactos/base/applications/mscutils/devmgmt_new/lang/sv-SE.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… Modified: trunk/reactos/base/applications/mscutils/devmgmt_new/lang/th-TH.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… Modified: trunk/reactos/base/applications/mscutils/devmgmt_new/lang/tr-TR.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… Modified: trunk/reactos/base/applications/mscutils/devmgmt_new/lang/uk-UA.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… Modified: trunk/reactos/base/applications/mscutils/devmgmt_new/lang/zh-CN.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… Copied: trunk/reactos/base/applications/mscutils/devmgmt_new/precomp.h (from r67940, trunk/reactos/base/applications/mscutils/devmgmt_new/stdafx.h) URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… Removed: trunk/reactos/base/applications/mscutils/devmgmt_new/rsrc.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… Removed: trunk/reactos/base/applications/mscutils/devmgmt_new/stdafx.cpp URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… Removed: trunk/reactos/base/applications/mscutils/devmgmt_new/stdafx.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… Removed: trunk/reactos/base/applications/mscutils/devmgmt_new/targetver.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils…

3 3

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev