- Ros-dev - ReactOS.org

Re: [ros-dev] Status Meeting (June 2020)
by Victor Perevertkin 23 Jun '20

23 Jun '20

I'd like to propose what I have on my mind: - 0.4.14 release status, what's left to do (should be a short one) - Unifying our contribution guidelines. I've found out that we have too many places with instructions for contributors. And if fact they don't quite indicate our expectations of a good pull request. A couple of weeks ago we gathered our ideas for contributor's and reviewer's guidelines and put them in a google doc: https://docs.google.com/document/d/1osRfG0PelNyDAwlwGFrIL-D12WeuxV3BO_GzW0N… I'd like to have a bit of a discussion about all we wrote there and then we will try to compile new guidelines from it. - This partly overlaps with the previous one. We have some pull requests where people with relevant experience are missing in our team. (atm I'm talking mainly about LSASS PR https://github.com/reactos/reactos/pull/2230, but such situation is possible in future) I suggest treating such PRs with a "light" scheme: only check for code style, some obvious mistakes etc. Otherwise they will be stuck forever Colin Finck <colin(a)reactos.org> wrote on Tue, June 23rd, 2020, 8:44 AM: > Short reminder that the meeting is going to take place this week's Thursday. > > Unfortunately, I didn't get a single mail regarding the meeting agenda. > However, I took from Mattermost that some people (Daniel in particular) > want to talk about channel moderation, so I'm putting it on the agenda: > > * Channel moderation (Daniel) > > There may have been other things I missed, which is why I reiterate to > send all agenda proposals by E-Mail. > > See you then, > > Colin > > > Am 04.06.2020 um 09:13 schrieb Colin Finck: > > Hi all! > > > > Let me invite you to the (almost) bi-monthly status meeting, taking > > place Thursday, 25th June, 19:00 UTC, in the Mattermost private channel > > "Meeting". > > > > I missed to announce a meeting last month and also didn't get any > > proposals for the agenda. But apparently there is a need to discuss a > > few things. > > Therefore, please submit your agenda proposals by E-Mail to me now. > > I will then announce the final agenda one week in advance. > > > > Topics I would like to speak about: > > > > * Achievements and Future Outlook (everyone) > > What have you been working on and what are your plans? > > > > * GSoC 2020 Status (org admins and mentors) > > Just a short update on how the GSoC projects are doing > > > > > > Best regards, > > > > Colin > > > > > > _______________________________________________ > > Ros-dev mailing list > > Ros-dev(a)reactos.org > > http://reactos.org/mailman/listinfo/ros-dev > >

1 0

Status Meeting (June 2020)
by Colin Finck 23 Jun '20

23 Jun '20

Hi all! Let me invite you to the (almost) bi-monthly status meeting, taking place Thursday, 25th June, 19:00 UTC, in the Mattermost private channel "Meeting". I missed to announce a meeting last month and also didn't get any proposals for the agenda. But apparently there is a need to discuss a few things. Therefore, please submit your agenda proposals by E-Mail to me now. I will then announce the final agenda one week in advance. Topics I would like to speak about: * Achievements and Future Outlook (everyone) What have you been working on and what are your plans? * GSoC 2020 Status (org admins and mentors) Just a short update on how the GSoC projects are doing Best regards, Colin

1 1

Re: [ros-dev] [QubesOS] Debug first boot
by Victor Perevertkin 15 May '20

15 May '20

Hi Frédéric, Debug logs are being written to a serial port if you select the "ReactOS (Debug)" option in the bootloader. It will help to understand what's going on in the OS. My guess that's some race condition while enumerating devices. As far as I can see, Xen shares some code with QEMU for device emulation in HVM mode. Thus this wiki page (https://reactos.org/wiki/QEMU) may help to tune some settings, because ReactOS doesn't work with all kinds of modes QEMU offers (namely, q35 chipset doesn't work, https://jira.reactos.org/browse/CORE-13346) Checking latest development build may also help, but we haven't made much changes to that part of OS recently. If you will manage to run ReactOS inside Xen, maybe it's worth creating a dedicated wiki page for that along with other virtualization software. Anyway, thanks for your interest in our project :) Victor

2 1

Re: [ros-dev] [ros-diffs] [reactos] 02/02: [NTOS:MM] Get rid of unnecessary MmZeroingPageThreadActive.
by Alex Ionescu 10 May '20

10 May '20

I know I probably don't have much weight anymore but, I re-iterate that one of the goals of the project should be to make things as similar as possible for debugging/troubleshooting and learning as Server 2003... which does have this variable. I don't think it's the end of the world to keep it around. Stuff like this also tends to break kdexts.dll. Best regards, Alex Ionescu On Mon, Apr 6, 2020 at 5:15 AM Thomas Faber <thomas.faber(a)reactos.org> wrote: > > https://git.reactos.org/?p=reactos.git;a=commitdiff;h=25a5aee86f43e9f526d4d… > > commit 25a5aee86f43e9f526d4d360e4e4f35feb9d22b4 > Author: Thomas Faber <thomas.faber(a)reactos.org> > AuthorDate: Sat Feb 22 12:31:54 2020 +0100 > Commit: Thomas Faber <thomas.faber(a)reactos.org> > CommitDate: Mon Apr 6 11:13:55 2020 +0200 > > [NTOS:MM] Get rid of unnecessary MmZeroingPageThreadActive. > --- > ntoskrnl/mm/ARM3/miarm.h | 1 - > ntoskrnl/mm/ARM3/mminit.c | 5 ++--- > ntoskrnl/mm/ARM3/pfnlist.c | 3 +-- > ntoskrnl/mm/ARM3/zeropage.c | 3 +-- > 4 files changed, 4 insertions(+), 8 deletions(-) > > diff --git a/ntoskrnl/mm/ARM3/miarm.h b/ntoskrnl/mm/ARM3/miarm.h > index c242b795af6..9d85c42afff 100644 > --- a/ntoskrnl/mm/ARM3/miarm.h > +++ b/ntoskrnl/mm/ARM3/miarm.h > @@ -639,7 +639,6 @@ extern PMMPDE MiHighestUserPde; > extern PFN_NUMBER MmSystemPageDirectory[PPE_PER_PAGE]; > extern PMMPTE MmSharedUserDataPte; > extern LIST_ENTRY MmProcessList; > -extern BOOLEAN MmZeroingPageThreadActive; > extern KEVENT MmZeroingPageEvent; > extern ULONG MmSystemPageColor; > extern ULONG MmProcessColorSeed; > diff --git a/ntoskrnl/mm/ARM3/mminit.c b/ntoskrnl/mm/ARM3/mminit.c > index 7cd7af10838..d72e7186193 100644 > --- a/ntoskrnl/mm/ARM3/mminit.c > +++ b/ntoskrnl/mm/ARM3/mminit.c > @@ -2181,9 +2181,8 @@ MmArmInitSystem(IN ULONG Phase, > /* Initialize the Loader Lock */ > KeInitializeMutant(&MmSystemLoadLock, FALSE); > > - /* Set the zero page event */ > - KeInitializeEvent(&MmZeroingPageEvent, SynchronizationEvent, FALSE); > - MmZeroingPageThreadActive = FALSE; > + /* Set up the zero page event */ > + KeInitializeEvent(&MmZeroingPageEvent, NotificationEvent, FALSE); > > /* Initialize the dead stack S-LIST */ > InitializeSListHead(&MmDeadStackSListHead); > diff --git a/ntoskrnl/mm/ARM3/pfnlist.c b/ntoskrnl/mm/ARM3/pfnlist.c > index eac3a043418..f175541a500 100644 > --- a/ntoskrnl/mm/ARM3/pfnlist.c > +++ b/ntoskrnl/mm/ARM3/pfnlist.c > @@ -701,10 +701,9 @@ MiInsertPageInFreeList(IN PFN_NUMBER PageFrameIndex) > ColorTable->Count++; > > /* Notify zero page thread if enough pages are on the free list now */ > - if ((ListHead->Total >= 8) && !(MmZeroingPageThreadActive)) > + if (ListHead->Total >= 8) > { > /* Set the event */ > - MmZeroingPageThreadActive = TRUE; > KeSetEvent(&MmZeroingPageEvent, IO_NO_INCREMENT, FALSE); > } > > diff --git a/ntoskrnl/mm/ARM3/zeropage.c b/ntoskrnl/mm/ARM3/zeropage.c > index 6d859f6806f..5fe22294199 100644 > --- a/ntoskrnl/mm/ARM3/zeropage.c > +++ b/ntoskrnl/mm/ARM3/zeropage.c > @@ -17,7 +17,6 @@ > > /* GLOBALS ********************************************************************/ > > -BOOLEAN MmZeroingPageThreadActive; > KEVENT MmZeroingPageEvent; > > /* PRIVATE FUNCTIONS **********************************************************/ > @@ -73,7 +72,7 @@ MmZeroPageThread(VOID) > { > if (!MmFreePageListHead.Total) > { > - MmZeroingPageThreadActive = FALSE; > + KeClearEvent(&MmZeroingPageEvent); > MiReleasePfnLock(OldIrql); > break; > } >

2 1

sumatraPDF
by Javier Agustìn Fernàndez Arroyo 01 May '20

01 May '20

check this link guys! :) (yes, i am the poster) :) https://forum.sumatrapdfreader.org/t/support-reactos/2921

3 5

Status Meeting (March 2020)
by Colin Finck 26 Mar '20

26 Mar '20

Hi all! Let me invite you to the bi-monthly status meeting, taking place *TODAY*, 19:00 UTC, in the Mattermost private channel "Meeting". I know that this announcement comes way too late, but hope that people can manage to join, even if it's just to get some distraction from all the bad news these days. The agenda currently looks as follows, with the main speakers in parentheses: * Achievements and Future Outlook (everyone) What have you been working on and what are your plans? This is also the right time to talk about ReactOS 0.4.13 and RosBE 2.2 again. * GSoC 2020 Status (org admins and mentors) Just a short update on the timeline, promising projects and candidates * Drop one theme from "default" package (Victor) Last release we added two new themes, but they both look unfinished in many aspects. As we have an active maintainer for one of them (Mizu), Victor's suggestion is to either drop the Lunar, or "merge" it with Lautus By the way, we have many times discussed an option to make custom themes be installed from Rapps. What do we need to do for that? And finally, it would be nice to write down some formal criteria for accepting themes. It will make PR reviewers' life easier :) * Hire a developer for dev-web interface and/or a devops for our infrastructure (Victor) Making that a GSoC project required too much effort for a mentor; so in the end the project was not too efficient in terms of time spent/amount of work done ratio (as a GSoC project it is great, but the interface is still far from being usable) Victor thinks it is reasonable to hire some experienced developer for maybe a month or something. Looking forward to see all of you this evening! Colin

1 0

covid-19
by Javier Agustìn Fernàndez Arroyo 18 Mar '20

18 Mar '20

Hi all, This is just to ask for best wishes to all of you. I hope you are all ok and safe.

2 1

Topics for next Meeting
by Victor Perevertkin 17 Mar '20

17 Mar '20

Hi all! I would like to propose some topic to discuss on the next meeting (will it be on March, 26?) * Drop one theme from "default" package. Last release we added two new themes, but they both look unfinished in many aspects. As we have an active maintainer for one of them (Mizu), my suggestion is to either drop the Lunar, or "merge" it with Lautus (I find them quite similar - correct me if I'm wrong) I think it's worth asking cernodile and foxlet about their thoughts. I have a strong opinion that 4 themes is too much for "default" package By the way, we have many times discussed an option to make custom themes be installed from Rapps. What do we need to do for that? And finally, it would be nice to write down some formal criteria for accepting themes. It will make PR reviewers' life easier :) * Hire a developer for dev-web interface and/or a devops for our infrastructure. Making that a GSoC project required too much effort for a mentor; so in the end the project was not too efficient in terms of time spent/amount of work done ratio (as a GSoC project it is great, but the interface is still far from being usable) I think it is reasonable to hire some experienced developer for maybe a month or something (is we have enough funds, ofc). That will probably require a more detailed task from us. Suggestions are welcome here :) We don't have to wait for a meeting, may start discussing that here :) Cheers, Victor

1 0

Application for participation in GSOC 2020
by Chaitanya Gadgil 03 Mar '20

03 Mar '20

Dear Sir/Madam, This is Chaitanya Gadgil from Bengaluru,India. I am a first year under-graduate student pursuing Electronics and Instrumentation Engineering. I am interested to work with your organization for the GSoC 2020. I am interested to work on the end user development project "Application manager RAPPS". Goal setting with the project: Improvising user-system interactions Easier management of installed applications My skills are: 1.Programming knowledge in both C and C++ 2.Data structures and database management systems 3.Basics of MATLAB and Arduino 4. Mathematics 5. SQL Member of: The International Society of Automation The New York Academy of Sciences The Mathematical society of BMSCE Courses enrolled: Cybersecurity DBMS Networking using IOT Projects: Developing Smart Wearables using Integrated Sensor Network Architecture Developing an algorithmic approach to track malnutrition in India It would be a wonderful experience for me to work with your organization and collaborating for the project. It would be helpful if I can contact a mentor immediately so that I can interact and start working as soon as possible on the project. I am also willing to improve my skills if needed. I can guarantee of setting a good time for the project as I will be having vacations. Regards, Chaitanya Gadgil

2 1

32-bit hosts virtualbox EOL
by Javier Agustìn Fernàndez Arroyo 31 Jan '20

31 Jan '20

"Please also use version 5.2 if you still need support for 32-bit hosts, as this has been discontinued in 6.0. Version 5.2 will remain supported until July 2020." FYI That means, ROS will still be usable as guest, but not as host

1 0

Reinstating the ReactOS Meetings
by Colin Finck 28 Jan '20

28 Jan '20

Hi all! We had our annual General Assembly of ReactOS Deutschland e.V. today. Many things were discussed which are better discussed with the entire ReactOS Team, which is why all of us agreed on reinstating the recurring ReactOS Meetings we had until February 2019. Let's try out a bi-monthly schedule, with the first meeting happening on Thursday, January 30, 2020 19:00 UTC Mattermost private channel "Meeting" If you're currently not part of this channel, but think you should be, please contact me. I'm already announcing this, so we can collect topics for the meeting. Current points on the agenda: * Compiling an up-to-date list of tasks to work on, for newcomers, GSoC candidates, and developers to hire. Can already be started now by taking https://reactos.org/wiki/Google_Summer_of_Code_2019_Ideas, copying it to "Google Summer of Code 2020", cleaning it up and adding new stuff. Maybe we also need to manage that with JIRA in the future. * RosBE 2.2, and what's blocking it, if it hasn't happened by then * ReactOS 0.4.13, and what's blocking it, if it hasn't happened by then Just reply if you have anything to add. Cheers, Colin

2 2

wined3d, Mesa for Windows
by Javier Agustìn Fernàndez Arroyo 14 Jan '20

14 Jan '20

Hello guys, Please have a look at this website! https://fdossena.com/?p=articles.php?s=1 Maybe ReactOS can use any of these pieces of FOSS what do you think?

5 5

FOSDEM 2020
by Colin Finck 23 Nov '19

23 Nov '19

Hi all! It took a while but FOSDEM has finally put a list of accepted stands on their website: https://fosdem.org/2020/news/2019-11-19-accepted-stands/ Looks like we only got a stand on Sunday this year, with our friends from Haiku OS having one on Saturday only. Not really what I thought when signing up for a "shared booth as always", but I'm sure we're going to manage that. There are plenty of opportunities for us to fill an entire weekend in Brussels, including * Having a "mini Hackfest" on Saturday in a coworking space in Brussels (or alternatively at FOSDEM itself, but it's going to be crowded there) * Following up on what Victor and me discussed with the FreeBSD, Haiku, NetBSD, and RTEMS people at GSoC Mentor Summit regarding a port of the low-level FreeBSD kernel interfaces to ReactOS, making a vast amount of network and storage drivers available to us. As far as I recall, the FreeBSD people have a conference in Brussels just before FOSDEM and are inviting us to join (Mahdi - correct me if I'm wrong). * Asking the Haiku guys if we shall try to join their booth on Saturday while they join ours on Sunday (Adrien? François?) But first I'd like to know who else is definitely going to make it to Brussels. Please reply to my mail ASAP, then we can have a short meeting on Mattermost soon and come to a decision. Cheers, Colin

2 1

Report from the GSoC Mentor Summit 2019
by Colin Finck 20 Oct '19

20 Oct '19

Hi all! Victor and me are having a good time at this year's GSoC Mentor Summit in Munich, and it's time to get out a first report. Again, I'm getting the impression that all projects here pretty much share the same problems and ReactOS is not doing anything particular wrong. Today, I have attended a session about keeping students involved after GSoC. Most projects are struggling with that and there were some projects where it's usual for all students to just stay for GSoC and immediately leave afterwards. Anyway, I took some insights where we can improve to keep more of our students: * Give students some responsibility early on, so they feel responsible and needed for a project even after GSoC. The ultimate goal should be to turn them into mentors later. We already have a fairly good track record of that, but I think it should be emphasized here. * Invite more students to our Hackfest. We may need to postpone it by a few weeks to not clash with the final days of GSoC. For the MacPorts project, this resulted in all 3 students staying with the project after GSoC. * Talk to students on a personal level (possibly even through audio or video chat) and get them into our community. We had some high-performing students in the past who needed almost no mentoring, but this also resulted in less interactions with the community and we had a hard time to keep them involved after GSoC. * Collect tasks all year long, not just shortly before GSoC. This is important not just for keeping students, but also for enabling our paid development ideas around ReactOS. It's still important to ask a student what he or she wants to work on after GSoC, but we should always have some interesting tasks available. * Advertise our scholarship model early enough during GSoC to keep the people that are also doing it for the money. * Advertise our GSoC participation at universities. Some students managed to declare their GSoC participation as the technical internship required for their studies. All in all, the Mentor Summit again was a great opportunity to meet up with fellow Open-Source developers all around the world and have some interesting discussions. I'm already looking forward to the next one! We even got some ReactOS work done <https://github.com/reactos/reactos/pull/1835> just in sight distance of the Microsoft Germany HQ :D Cheers, Colin

1 0

INVALID OPCODE
by katahiromz . 21 Sep '19

21 Sep '19

An error occurred in FreeLoader v3.0. 0x06: Exception 06: INVALID OPCODE

2 1

why is the project so silent?
by Dick 06 Sep '19

06 Sep '19

Hi, why is the project so silent? Normally there were messages about online meetings, upcomming releases etc. on this list but it became realy silent and the last release is long time ago. what happened to reactos? best regards, dick

2 3

Re: [ros-dev] [ros-diffs] [reactos] 01/01: [NETAPI32] Add the NetpAllocStrFromWStr helper function
by Thomas Faber 04 Sep '19

04 Sep '19

Hey Eric, On 2019-08-24 14:01, Eric Kohl wrote: > +PSTR > +WINAPI > +NetpAllocStrFromWStr( > + _In_ PWSTR InString) > +{ > + UNICODE_STRING UnicodeString; > + OEM_STRING OemString; > + ULONG Size; > + NET_API_STATUS NetStatus; > + NTSTATUS Status; > + > + RtlInitUnicodeString(&UnicodeString, InString); > + > + Size = RtlUnicodeStringToOemSize(&UnicodeString); > + NetStatus = NetApiBufferAllocate(Size, > + (PVOID*)&OemString.Buffer); > + if (NetStatus != NERR_Success) > + return NULL; > + It seems like OemString.MaximumLength should be initialized before calling RtlUnicodeStringToOemString? > + Status = RtlUnicodeStringToOemString(&OemString, > + &UnicodeString, > + FALSE); > + if (!NT_SUCCESS(Status)) > + { > + NetApiBufferFree(OemString.Buffer); > + return NULL; > + } > + > + return OemString.Buffer; > +} Best, Thomas

1 0

Re: [ros-dev] [ros-diffs] [reactos] 01/01: [NETAPI32] Implement DsDeregisterDnsHostRecordsA
by Thomas Faber 25 Aug '19

25 Aug '19

Hey Eric, On 2019-08-24 22:58, Eric Kohl wrote: > diff --git a/dll/win32/netapi32/netlogon.c b/dll/win32/netapi32/netlogon.c > index 2c068dc176b..73a0324f0fa 100644 > --- a/dll/win32/netapi32/netlogon.c > +++ b/dll/win32/netapi32/netlogon.c > @@ -313,10 +313,58 @@ DsDeregisterDnsHostRecordsA( > _In_opt_ GUID *DsaGuid, > _In_ LPSTR DnsHostName) > { [...] > + > + if (DnsDomainName != NULL) > + { > + pDnsDomainNameW = NetpAllocWStrFromAnsiStr((PSTR)DnsDomainName); > + if (pDnsDomainNameW == NULL) > + { > + status = ERROR_NOT_ENOUGH_MEMORY; > + goto done; > + } > + } > + > + pDnsHostNameW = NetpAllocWStrFromAnsiStr((PSTR)DnsDomainName); UserNT points out that you probably meant DnsHostName here rather than DnsDomainName. > + if (pDnsHostNameW == NULL) > + { > + status = ERROR_NOT_ENOUGH_MEMORY; > + goto done; > + } > + Best, Thomas

2 1

Re: [ros-dev] BuildBot Upgrade on Tuesday
by Sylvain Petreolle 08 Jul '19

08 Jul '19

Hello all, Connecting to the new buildbot now shows an avatar picture from www.gravatar.com. What are the legal implications ? What personal data are sent here ? Is it still possible to see online logs as plain text ? https://build.reactos.org/#/builders/9/builds/24976/steps/5/logs/stdio/text comes back to the index now. Looking at a 1 billion lines hung log as HTML won't do anything good, for the client and the server. | | Kind regards, Sylvain Petreolle Le Dimanche 23 juin 2019 23h13, Colin Finck <colin(a)reactos.org> a écrit : Hi all! Our BuildBot at https://build.reactos.org is finally going to be upgraded from the ancient version 0.8.14 to the latest 2.3.1 release this Tuesday evening (CEST). We have postponed this for a very long time due to the fundamental UI changes in newer versions. The UI has been rewritten from scratch and its Waterfall View has been simplified. I used to be a strong opponent of this change. However, in one of the last meetings, it turned out that the current Waterfall View isn't that popular among our developers anyway. You can expect the new BuildBot to look like this: https://lidell.nu/xemacs-buildbot/ BuildBot also doesn't provide a direct migration path from the old to the new version. This means that previous build and log information will be gone after the upgrade. I used to consider this a blocker as well, but current BuildBot already purges old build/log information after some time and apparently it hasn't been missed. We still have all important information in Testman. I will make sure however that build numbers in the new version continue where they ended in the old version. On the plus side, this upgrade brings integrations with GitHub and Mattermost as well as proper Unicode support. Using an up-to-date BuildBot version also allows us to actually enhance it. In fact, this upgrade is a prerequisite for the Developer Web Interface our GSoC student Ayush Sinha is currently working on. Regarding Buildslaves (now called "workers"), the new BuildBot is still compatible with 0.8.x clients, so these don't need an upgrade right away. We just need a small change on workers submitting test results. Kudos go to Victor Perevertkin, who has already begun evaluating the new BuildBot version a long time ago and provided me with an updated master.cfg file, along with other help! I'm glad that the number of people maintaining our BuildBot setup is growing! :) Cheers, Colin _______________________________________________ Ros-dev mailing list Ros-dev(a)reactos.org http://reactos.org/mailman/listinfo/ros-dev

2 1

Hackfest 2019 - Deadline for Merchandising and Financial Assistance
by Colin Finck 04 Jul '19

04 Jul '19

Hi all! The ReactOS Hackfest will take place in about a month and a week. Please revisit https://reactos.org/wiki/ReactOS_Hackfest_2019/Lists and put yourself in all relevant lists if you are going to attend. I've just updated the Shirts/Hoodies section with the final design. Please check that out and add whether you want a shirt or a hoodie. You may also want to check the links regarding the exact sizes again. Deadline for this is THURSDAY, JULY 11 After that, I will move on and buy the merchandising products. If your attendance at the Hackfest needs financial assistance from ReactOS Deutschland e.V., please also get in touch with me before that deadline. You know, flights and accommodation get more expensive the closer we are to the event date ;) Cheers, Colin

1 0

BuildBot Upgrade on Tuesday
by Colin Finck 23 Jun '19

23 Jun '19

Hi all! Our BuildBot at https://build.reactos.org is finally going to be upgraded from the ancient version 0.8.14 to the latest 2.3.1 release this Tuesday evening (CEST). We have postponed this for a very long time due to the fundamental UI changes in newer versions. The UI has been rewritten from scratch and its Waterfall View has been simplified. I used to be a strong opponent of this change. However, in one of the last meetings, it turned out that the current Waterfall View isn't that popular among our developers anyway. You can expect the new BuildBot to look like this: https://lidell.nu/xemacs-buildbot/ BuildBot also doesn't provide a direct migration path from the old to the new version. This means that previous build and log information will be gone after the upgrade. I used to consider this a blocker as well, but current BuildBot already purges old build/log information after some time and apparently it hasn't been missed. We still have all important information in Testman. I will make sure however that build numbers in the new version continue where they ended in the old version. On the plus side, this upgrade brings integrations with GitHub and Mattermost as well as proper Unicode support. Using an up-to-date BuildBot version also allows us to actually enhance it. In fact, this upgrade is a prerequisite for the Developer Web Interface our GSoC student Ayush Sinha is currently working on. Regarding Buildslaves (now called "workers"), the new BuildBot is still compatible with 0.8.x clients, so these don't need an upgrade right away. We just need a small change on workers submitting test results. Kudos go to Victor Perevertkin, who has already begun evaluating the new BuildBot version a long time ago and provided me with an updated master.cfg file, along with other help! I'm glad that the number of people maintaining our BuildBot setup is growing! :) Cheers, Colin

1 0

Coding style fixes/improvements
by Victor Perevertkin 07 Jun '19

07 Jun '19

Hi! Recently I've looked into Doxygen manual for writing documentation and noticed that an example on our Coding style <https://reactos.org/wiki/index.php?title=Coding_Style> page on wiki uses some statements in a wrong way. Namely, @name statement is for defining sections, groups and definitely not for functions/structs/classes etc. Another thing is a function description. Doxygen has two types of them: brief and detailed one. Brief description must be defined by @brief statement, but for detailed one @details can be omitted (which in fact was done in our example). Obviously, brief description should be used in first place (and that would be likely the only one) I've made some changes, to the page (see the latest change in page history) Btw, I think it can be extended to something like this ( http://micro-os-plus.github.io/develop/doxygen-style-guide/) sometime If you have any objections or suggestions, feel free to add them or discuss here. Cheers, Victor

1 0

Re: [ros-dev] [ros-diffs] [reactos] 02/02: [SETUPAPI] Fix a typo in CM_Query_Resource_Conflict_List.
by Thomas Faber 07 Jun '19

07 Jun '19

This does not seem right. On 2019-06-06 19:14, Eric Kohl wrote: > https://git.reactos.org/?p=reactos.git;a=commitdiff;h=c47ad98ff79ad98042ff2… > > commit c47ad98ff79ad98042ff2043d739be58770c2fbc > Author: Eric Kohl <eric.kohl(a)reactos.org> > AuthorDate: Thu Jun 6 19:12:44 2019 +0200 > Commit: Eric Kohl <eric.kohl(a)reactos.org> > CommitDate: Thu Jun 6 19:12:44 2019 +0200 > > [SETUPAPI] Fix a typo in CM_Query_Resource_Conflict_List. > --- > dll/win32/setupapi/cfgmgr.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/dll/win32/setupapi/cfgmgr.c b/dll/win32/setupapi/cfgmgr.c > index 8215d47ac63..d33a6497172 100644 > --- a/dll/win32/setupapi/cfgmgr.c > +++ b/dll/win32/setupapi/cfgmgr.c > @@ -6761,7 +6761,7 @@ CM_Query_Resource_Conflict_List( > if (lpDevInst == NULL) > return CR_INVALID_DEVNODE; > > - pConflictData = MyMalloc(sizeof(CONFLICT_DATA)); > + pConflictData = MyMalloc(sizeof(PCONFLICT_DATA)); > if (pConflictData == NULL) > { > ret = CR_OUT_OF_MEMORY; >

1 0

Re: [ros-dev] [ros-diffs] [reactos] 01/01: [SYSSETUP] Set registry hostname in WriteComputerSettings (#1589)
by gedmurphy.maillists＠gmail.com 29 May '19

29 May '19

+ /* Now we need to set the Hostname */ + lError = RegOpenKeyExW(HKEY_LOCAL_MACHINE, + L"SYSTEM\\CurrentControlSet\\Services\\Tcpip\\Parameters", + 0, + KEY_SET_VALUE, + &hKey); + if (lError != ERROR_SUCCESS) + { + DPRINT1("RegOpenKeyExW for Tcpip\\Parameters failed (%08lX)\n", lError); + return TRUE; Typo?

1 0

Re: [ros-dev] [ros-diffs] [reactos] 01/02: [BASESVR] Take SessionId into account while creating BNO directory
by gedmurphy.maillists＠gmail.com 08 May '19

08 May '19

Hadn't we decided to default to strsafe apis for all new code? StringCchPrintfW StringCchCopyW -----Original Message----- From: Ros-diffs <ros-diffs-bounces(a)reactos.org> On Behalf Of Pierre Schweitzer Sent: 08 May 2019 19:42 To: ros-diffs(a)reactos.org Subject: [ros-diffs] [reactos] 01/02: [BASESVR] Take SessionId into account while creating BNO directory https://git.reactos.org/?p=reactos.git;a=commitdiff;h=20f57973866eb54d3c282… commit 20f57973866eb54d3c2822a3b62a309a9983c196 Author: Pierre Schweitzer <pierre(a)reactos.org> AuthorDate: Wed May 8 20:35:31 2019 +0200 Commit: Pierre Schweitzer <pierre(a)reactos.org> CommitDate: Wed May 8 20:35:31 2019 +0200 [BASESVR] Take SessionId into account while creating BNO directory --- subsystems/win/basesrv/init.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/subsystems/win/basesrv/init.c b/subsystems/win/basesrv/init.c index ebfe937068..84b24f38db 100644 --- a/subsystems/win/basesrv/init.c +++ b/subsystems/win/basesrv/init.c @@ -353,8 +353,14 @@ BaseInitializeStaticServerData(IN PCSR_SERVER_DLL LoadedServerDll) SystemRootString.Buffer); ASSERT(Success); - /* FIXME: Check Session ID */ - wcscpy(BnoBuffer, L"\\BaseNamedObjects"); + if (SessionId != 0) + { + swprintf(BnoBuffer, L"\\Sessions\\%ld\\BaseNamedObjects", SessionId); + } + else + { + wcscpy(BnoBuffer, L"\\BaseNamedObjects"); + } RtlInitUnicodeString(&BnoString, BnoBuffer); /* Allocate the server data */ @@ -531,7 +537,7 @@ BaseInitializeStaticServerData(IN PCSR_SERVER_DLL LoadedServerDll) Status = NtCreateSymbolicLinkObject(&SymHandle, SYMBOLIC_LINK_ALL_ACCESS, &ObjectAttributes, - &SymlinkName); + &BnoString); if ((NT_SUCCESS(Status)) && SessionId == 0) NtClose(SymHandle); /* Make Session point back to BNOLINKS */

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev