- Ros-dev - ReactOS.org

[ros-diffs] [hbelusca] 65569: [OSK] - Fix some coding style (whitespace): this is not win32k!! - Remove unneeded headers.

by James Tabor

Watch OUT! This was from the ORIGINAL patch!!! I did not code it!!!! James

10 years, 9 months

2
1
0 0

silverblade´s wife

by Javier Agustìn Fernàndez Arroyo

Hello guys, I have just read this sad news on facebook Andrew´s wife has passed away this thursday evening. May i ask web developers to put the attached image in the webpage? for those who dont know who Andrew is, he is the first responsable of the audio stack in ReactOS. He is known as silverblade in IRC and the web My condolences to him and families and friends, from here.

10 years, 9 months

1
0
0 0

great chance

by Robert Naumann

Hey guys, I previously talked to daniel and colin about this thing and colin told me to write a mail to this list. I read about a big chance for the preject to show a presentation at the CeBIT, the biggest german IT convention. Sadly, I only have links to german websites but maybe you are satisfied with google translation. Here they are: http://www.golem.de/news/call-for-papers-open-source-forum-sucht-experten-f… http://www.linux-magazin.de/NEWS/Call-for-Papers-Open-Source-Forum-auf-der-… This would be a big chance for the project as there are people from all over the world and a bigger audience than the one of all Linux days together could learn about the project. Best Regards Robert

10 years, 9 months

2
1
0 0

Claim your commits

by Alexander Rechitskiy

10 years, 9 months

2
5
0 0

Re: [ros-dev] [ros-diffs] [hbelusca] 65519: [WIN32K][ROSTESTS] So... ... first of all NtUserQueryInformationThread takes only 4 parameters in Win2k3 so do it as well... ... and since we claim at being compatible with Win2k3...

by Aleksey Bragin

The one who does it - please make sure to stick to the appropriate Service Pack version too. Regards, Aleksey Bragin On 29.11.2014 2:19, hbelusca(a)svn.reactos.org wrote: > Author: hbelusca > Date: Fri Nov 28 23:19:25 2014 > New Revision: 65519 > > URL: http://svn.reactos.org/svn/reactos?rev=65519&view=rev > Log: > [WIN32K][ROSTESTS] > So... > ... first of all NtUserQueryInformationThread takes only 4 parameters in Win2k3 so do it as well... > ... and since we claim at being compatible with Win2k3 (and not XP), one **MUST** review **ALL** our win32k exports, in win32ss/w32ksvc.db database first, and then in our w32kdll apitests !!!!! > But I won't do it ! >

10 years, 9 months

1
0
0 0

Mention of ReactOS in some security book...

by Hermès BÉLUSCA - MAÏTO

Hi ! While searching for something I stumbled upon this : http://books.google.fr/books?id=YjwKAwAAQBAJ <http://books.google.fr/books?id=YjwKAwAAQBAJ&pg=RA1-PA331&lpg=RA1-PA331&dq= reactos+shell+new&source=bl&ots=D1hNcK_QQx&sig=n95n-VyBUgC326b3vbqg6p1QgXU&h l=fr&sa=X&ei=7VZ3VN-5O8viaqbSgSg&ved=0CEgQ6AEwCQ#v=onepage&q=reactos%20shell %20new&f=false> &pg=RA1-PA331&lpg=RA1-PA331&dq=reactos+shell+new&source=bl&ots=D1hNcK_QQx&si g=n95n-VyBUgC326b3vbqg6p1QgXU&hl=fr&sa=X&ei=7VZ3VN-5O8viaqbSgSg&ved=0CEgQ6AE wCQ#v=onepage&q=reactos%20shell%20new&f=false Read section: Creating a Custom Shell. They use ReactOS (and RosBE 1.5, a piece of history ^^) for their purpose :D Hermès.

10 years, 9 months

1
0
0 0

Re: [ros-dev] [ros-diffs] [pschweitzer] 65501: [FASTFAT] Set clean shutdown bit on dismount

by Jérôme Gardou

Hey Pierre! This flag > + if (DeviceExt->VolumeFcb->Flags & VCB_CLEAR_DIRTY) > + { > + /* Set clean shutdown bit */ > + Status = GetNextCluster(DeviceExt, 1, &eocMark); > + if (NT_SUCCESS(Status)) > + { > + eocMark |= DeviceExt->CleanShutBitMask; > + if (NT_SUCCESS(WriteCluster(DeviceExt, 1, eocMark))) and that one > + DeviceExt->VolumeFcb->Flags &= ~VCB_IS_DIRTY; > + } > + } > + > /* Flush volume & files */ > VfatFlushVolume(DeviceExt, (PVFATFCB)FileObject->FsContext); > > > don't really seem to match. Or is the former a part of a OR combination defining the latter ? Cheers. Jérôme.

10 years, 9 months

2
1
0 0

Selling ReactOS CDs

by Hermès BÉLUSCA - MAÏTO

Hi all ! In the forums some spokesperson of an Indian company offering services related to FOSS wants to add us to their online shop, see http://www.reactos.org/forum/viewtopic.php?f=13 <http://www.reactos.org/forum/viewtopic.php?f=13&t=13780> &t=13780 for more information. What do you think about this? How should we react? Should we make clearer our line of conduct about such kind of things? Cheers, Hermès.

10 years, 9 months

5
5
0 0

Re: [ros-dev] [ros-diffs] [pschweitzer] 65462: [NTFS] - In NtfsQueryDirectory(), don't upcase name in dir search pattern, it can conflict with POSIX names. - In CompareFileName(), handle the fact that for Win32 & DOS we do ...

by Thomas Faber

On 2014-11-23 10:49, pschweitzer(a)svn.reactos.org wrote: > + ASSERT(NT_SUCCESS(RtlUpcaseUnicodeString(&IntFileName, FileName, TRUE))); You need NT_VERIFY here or this will break debug builds.

10 years, 9 months

2
1
0 0

Re: [ros-dev] [ros-diffs] [akhaldi] 65249: [SHELL32] * bool => BOOL.

by Timo Kreuzer

There is a difference between a C++ bool and a win32 BOOL. bool is 8 bit and aware of things like (bool Foo = FlagsValue & 0x80000000); BOOLEAN BooleanFlag = Foo;" with BOOL this would fail. I don't really know whether a BOOL is really the right thing to use here. Am 04.11.2014 21:00, schrieb akhaldi(a)svn.reactos.org: > Author: akhaldi > Date: Tue Nov 4 20:00:09 2014 > New Revision: 65249 > > URL: http://svn.reactos.org/svn/reactos?rev=65249&view=rev > Log: > [SHELL32] > * bool => BOOL. > > Modified: > branches/shell-experiments/dll/win32/shell32/folders/CDesktopFolder.cpp > branches/shell-experiments/dll/win32/shell32/folders/CDesktopFolder.h > branches/shell-experiments/dll/win32/shell32/folders/CFSFolder.cpp > branches/shell-experiments/dll/win32/shell32/folders/CFSFolder.h > branches/shell-experiments/dll/win32/shell32/shellfolder.h > > Modified: branches/shell-experiments/dll/win32/shell32/folders/CDesktopFolder.cpp > URL: http://svn.reactos.org/svn/reactos/branches/shell-experiments/dll/win32/she… > ============================================================================== > --- branches/shell-experiments/dll/win32/shell32/folders/CDesktopFolder.cpp [iso-8859-1] (original) > +++ branches/shell-experiments/dll/win32/shell32/folders/CDesktopFolder.cpp [iso-8859-1] Tue Nov 4 20:00:09 2014 > @@ -1189,7 +1189,7 @@ > return ret; > } > > -HRESULT WINAPI CDesktopFolder::CopyItems(IShellFolder *pSFFrom, UINT cidl, LPCITEMIDLIST *apidl, bool bCopy) > +HRESULT WINAPI CDesktopFolder::CopyItems(IShellFolder *pSFFrom, UINT cidl, LPCITEMIDLIST *apidl, BOOL bCopy) > { > CComPtr<IPersistFolder2> ppf2; > WCHAR szSrcPath[MAX_PATH]; > > Modified: branches/shell-experiments/dll/win32/shell32/folders/CDesktopFolder.h > URL: http://svn.reactos.org/svn/reactos/branches/shell-experiments/dll/win32/she… > ============================================================================== > --- branches/shell-experiments/dll/win32/shell32/folders/CDesktopFolder.h [iso-8859-1] (original) > +++ branches/shell-experiments/dll/win32/shell32/folders/CDesktopFolder.h [iso-8859-1] Tue Nov 4 20:00:09 2014 > @@ -88,7 +88,7 @@ > virtual HRESULT WINAPI GetUniqueName(LPWSTR pwszName, UINT uLen); > virtual HRESULT WINAPI AddFolder(HWND hwnd, LPCWSTR pwszName, LPITEMIDLIST *ppidlOut); > virtual HRESULT WINAPI DeleteItems(UINT cidl, LPCITEMIDLIST *apidl); > - virtual HRESULT WINAPI CopyItems(IShellFolder *pSFFrom, UINT cidl, LPCITEMIDLIST *apidl, bool bCopy); > + virtual HRESULT WINAPI CopyItems(IShellFolder *pSFFrom, UINT cidl, LPCITEMIDLIST *apidl, BOOL bCopy); > > DECLARE_REGISTRY_RESOURCEID(IDR_SHELLDESKTOP) > DECLARE_NOT_AGGREGATABLE(CDesktopFolder) > > Modified: branches/shell-experiments/dll/win32/shell32/folders/CFSFolder.cpp > URL: http://svn.reactos.org/svn/reactos/branches/shell-experiments/dll/win32/she… > ============================================================================== > --- branches/shell-experiments/dll/win32/shell32/folders/CFSFolder.cpp [iso-8859-1] (original) > +++ branches/shell-experiments/dll/win32/shell32/folders/CFSFolder.cpp [iso-8859-1] Tue Nov 4 20:00:09 2014 > @@ -1030,7 +1030,7 @@ > * copies items to this folder > */ > HRESULT WINAPI CFSFolder::CopyItems(IShellFolder * pSFFrom, UINT cidl, > - LPCITEMIDLIST * apidl, bool bCopy) > + LPCITEMIDLIST * apidl, BOOL bCopy) > { > CComPtr<IPersistFolder2> ppf2 = NULL; > WCHAR szSrcPath[MAX_PATH]; > > Modified: branches/shell-experiments/dll/win32/shell32/folders/CFSFolder.h > URL: http://svn.reactos.org/svn/reactos/branches/shell-experiments/dll/win32/she… > ============================================================================== > --- branches/shell-experiments/dll/win32/shell32/folders/CFSFolder.h [iso-8859-1] (original) > +++ branches/shell-experiments/dll/win32/shell32/folders/CFSFolder.h [iso-8859-1] Tue Nov 4 20:00:09 2014 > @@ -102,7 +102,7 @@ > virtual HRESULT WINAPI GetUniqueName(LPWSTR pwszName, UINT uLen); > virtual HRESULT WINAPI AddFolder(HWND hwnd, LPCWSTR pwszName, LPITEMIDLIST *ppidlOut); > virtual HRESULT WINAPI DeleteItems(UINT cidl, LPCITEMIDLIST *apidl); > - virtual HRESULT WINAPI CopyItems(IShellFolder *pSFFrom, UINT cidl, LPCITEMIDLIST *apidl, bool bCopy); > + virtual HRESULT WINAPI CopyItems(IShellFolder *pSFFrom, UINT cidl, LPCITEMIDLIST *apidl, BOOL bCopy); > > DECLARE_REGISTRY_RESOURCEID(IDR_SHELLFSFOLDER) > DECLARE_NOT_AGGREGATABLE(CFSFolder) > > Modified: branches/shell-experiments/dll/win32/shell32/shellfolder.h > URL: http://svn.reactos.org/svn/reactos/branches/shell-experiments/dll/win32/she… > ============================================================================== > --- branches/shell-experiments/dll/win32/shell32/shellfolder.h [iso-8859-1] (original) > +++ branches/shell-experiments/dll/win32/shell32/shellfolder.h [iso-8859-1] Tue Nov 4 20:00:09 2014 > @@ -42,7 +42,7 @@ > STDMETHOD(GetUniqueName)(THIS_ LPWSTR lpName, UINT uLen) PURE; > STDMETHOD(AddFolder)(THIS_ HWND hwnd, LPCWSTR lpName, LPITEMIDLIST * ppidlOut) PURE; > STDMETHOD(DeleteItems)(THIS_ UINT cidl, LPCITEMIDLIST * apidl) PURE; > - STDMETHOD(CopyItems)(THIS_ IShellFolder * pSFFrom, UINT cidl, LPCITEMIDLIST * apidl, bool bCopy) PURE; > + STDMETHOD(CopyItems)(THIS_ IShellFolder * pSFFrom, UINT cidl, LPCITEMIDLIST * apidl, BOOL bCopy) PURE; > }; > #undef INTERFACE > > > >

10 years, 9 months

9
32
0 0

Re: [ros-dev] Replacing unsafe TRUE comparisons (Following Re: bool => BOOL)

by Daniel Reimer

Heheh, who could it be... ^^ It was always a event to watch you two arguing. ^^ Am 23.11.2014 21:57 schrieb Alex Ionescu <ionucu(a)videotron.ca>: > > I'm just going to chime in here and confirm that Timo does indeed own a master's diploma on surviving pissing contests, taught by the greatest master there ever was. > > Best regards, > Alex Ionescu > > On Sat, Nov 22, 2014 at 11:47 AM, Timo Kreuzer <timo.kreuzer(a)web.de> wrote: >> >> Am 22.11.2014 11:39, schrieb Love Nystrom: >>> >>> >>> On 2014-11-21 04.00, Timo Kreuzer wrote: >>>> >>>> Am 20.11.2014 14:18, schrieb Love Nystrom: >>>>> >>>>> >>>>> Well... Actually not exactly the same.. ;) >>>>> "if (f != FALSE)" requires an explicit comparison with a second operand, >>>> >>>> No, it does not. It requries the compiler to generate code that executes the following statement, when f is not 0. >>> >>> >>> I suspect we look at it from two different viewpoints here.. >>> Yours is "C centric" and mine is "object code centric". >>> You talk about what the compiler is required to do, >>> and I talk about what comes out at the end of compilation. >> >> And what comes out at the end of the compilation is what the compiler creates. And the compiler is following the rules of the C standard and the rules of logic. >> You claimed '"if (f != FALSE)" requires an explicit comparison with a second operand,' and that is factually wrong. No matter whether you are looking at it from the compiler perspective or from the perspective of an expressionist painter living in a yellow tree house on the bottom of Lake Tanganyika. >> >>> >>> And.. dear friend.. don't turn this into a pissing contest. >> >> Don't even get me started. I battled the grand master and I survived. >> >> >>> Let's check the egos in with the coat check girl at the entrance. >>> May I ask how old you are? >> >> Are we talking about age or maturity? >> >> We better end this discussion, it's not leading anywhere. And you don't want me to turn into the Grinch and steal your Christmas. >> >> Thanks, >> Timo >> >> >> _______________________________________________ >> Ros-dev mailing list >> Ros-dev(a)reactos.org >> http://www.reactos.org/mailman/listinfo/ros-dev >> >

10 years, 9 months

1
0
0 0

Re: [ros-dev] [ros-diffs] [aandrejevic] 65441: [FAST486] Attempt to write the value to the stack before subtracting from the actual ESP register in Fast486StackPush.

by Timo Kreuzer

Are you sure this is the correct order of execution? The instruction is documented as first lowering the stack pointer, then writing to the new location. If a stack exception occurs, you might have esp off by 4. Am 21.11.2014 10:46, schrieb aandrejevic(a)svn.reactos.org: > Author: aandrejevic > Date: Fri Nov 21 09:46:57 2014 > New Revision: 65441 > > URL: http://svn.reactos.org/svn/reactos?rev=65441&view=rev > Log: > [FAST486] > Attempt to write the value to the stack before subtracting from the actual ESP register > in Fast486StackPush. > > > Modified: > trunk/reactos/lib/fast486/common.inl > > Modified: trunk/reactos/lib/fast486/common.inl > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/fast486/common.inl?rev… > ============================================================================== > --- trunk/reactos/lib/fast486/common.inl [iso-8859-1] (original) > +++ trunk/reactos/lib/fast486/common.inl [iso-8859-1] Fri Nov 21 09:46:57 2014 > @@ -317,15 +317,19 @@ > return FALSE; > } > > + /* Store the value in SS:[ESP - 4] */ > + if (!Fast486WriteMemory(State, > + FAST486_REG_SS, > + State->GeneralRegs[FAST486_REG_ESP].Long - sizeof(ULONG), > + &Value, > + sizeof(ULONG))) > + { > + /* Exception occurred */ > + return FALSE; > + } > + > /* Subtract ESP by 4 */ > State->GeneralRegs[FAST486_REG_ESP].Long -= sizeof(ULONG); > - > - /* Store the value in SS:ESP */ > - return Fast486WriteMemory(State, > - FAST486_REG_SS, > - State->GeneralRegs[FAST486_REG_ESP].Long, > - &Value, > - sizeof(ULONG)); > } > else > { > @@ -339,16 +343,22 @@ > return FALSE; > } > > + /* Store the value in SS:[SP - 2] */ > + if (!Fast486WriteMemory(State, > + FAST486_REG_SS, > + LOWORD(State->GeneralRegs[FAST486_REG_ESP].LowWord - sizeof(USHORT)), > + &ShortValue, > + sizeof(USHORT))) > + { > + /* Exception occurred */ > + return FALSE; > + } > + > /* Subtract SP by 2 */ > State->GeneralRegs[FAST486_REG_ESP].LowWord -= sizeof(USHORT); > - > - /* Store the value in SS:SP */ > - return Fast486WriteMemory(State, > - FAST486_REG_SS, > - State->GeneralRegs[FAST486_REG_ESP].LowWord, > - &ShortValue, > - sizeof(USHORT)); > - } > + } > + > + return TRUE; > } > > FORCEINLINE > > >

10 years, 9 months

2
1
0 0

Rant

by Giannis Adamopoulos

I don't know how many times I need to send the same link here but let's say that this is the last time: this is a post about wpf but in the middle there is a paragraph about how win32k in windows processes mouse messages: http://blogs.msdn.com/b/dwayneneed/archive/2008/09/08/transparent-windows-i… And here is the important part: Which HWND is the mouse over? The operating system must respond very quickly to mouse movement. Windows uses a dedicated Raw Input Thread (RIT), running in the kernel, to handle the signals from the mouse hardware. The RIT quickly scans over the HWND hierarchy to see which window the mouse is over. Because the system must be responsive, no application code is invoked. For normal windows, the RIT checks the mouse position against the window's rectangle (or region, if one is set). But for layered windows, the RIT looks in the bitmap that specifies the content for the window and checks the effective transparency at that location (which can be affected by the constant opacity setting, the color key setting, or the per-pixel alpha channel). If the pixel is 100% transparent, the RIT skips the window and keeps looking. Once a window has been located, the mouse move flag is set on the thread that owns the window. This will cause the thread to receive a WM_MOUSEMOVE message the next time it calls GetMessage() and there are no other higher-priority messages. Now let me explain why a flag is needed. The window manager needs to coalesce mouse move messages. If the mouse moves over a window and the system registers 10 positions over it, if the window doesn't process messages fast enough the unprocessed positions are dropped and only the last is kept. Even if another message gets between these mouse move messages get lost. That's why the last mouse position is not stored in a message queue but in a field in the thread info. That's how the window manager worked the last 20 years in windows. I'm sick and tired to see readable and correct code to be rewritten by shitty code, that is not readable and has obvious bugs without any reason why the previous implementation was wrong. I just give up. Do whatever you like with this shitty project of yours. I don't care anymore.

10 years, 9 months

2
1
0 0

Re: [ros-dev] [ros-diffs] [dquintana] 65415: [SHELL32] * Commit the folder location fixes. They are mostly untested due to being unable to boot to desktop, but looking at the contents of the HDD after syssetup runs seems th...

by Thomas Faber

On 2014-11-15 13:34, dquintana(a)svn.reactos.org wrote: > [SHELL32] > * Commit the folder location fixes. They are mostly untested due to being unable to boot to desktop, but looking at the contents of the HDD after syssetup runs seems that the shortcuts are all created in their rightful place. If anyone is able to boot, feel free to test. > > Modified: > branches/shell-experiments/dll/win32/shell32/wine/shellpath.c So which is it; to Wine or not to Wine? If we need to fork this then let's put it in another file? Or at least #ifdef __REACTOS__?

10 years, 9 months

3
2
0 0

Re: [ros-dev] EPIC: ReactOS@Samsung Galaxy S III mini

by Love Nystrom

On 2014-09-29 19.00, ros-dev-request(a)reactos.org wrote: > w0000t > natively? via an emulator??? > what the.... > \o/ @ Javier I just stumbled by and saw it.. Выглядит безумно, но я установил и запустил ReactOS через обертку Qemu - Limbo ARM 7 на своем Samsung Galaxy S III mini. It looks crazy, but I installed and started the ReactOS through wrapper Qemu - Limbo ARM 7 on your Samsung Galaxy S III mini. // It might be interesting to try wedging an ARM build into the S3 though. I was mulling over the possibility to squeeze it into an Maple Native.. Love

10 years, 9 months

3
2
0 0

Re: [ros-dev] [ros-diffs] [tkreuzer] 65390: [WIN32SS] if (BooleanValue == TRUE) -> if (!BooleanValue) Patch by Love Nystrom CORE-8799

by Timo Kreuzer

obviously it was meant to be "if (BooleanValue == TRUE) -> if (BooleanValue)" Am 13.11.2014 11:31, schrieb tkreuzer(a)svn.reactos.org: > Author: tkreuzer > Date: Thu Nov 13 10:31:45 2014 > New Revision: 65390 > > URL: http://svn.reactos.org/svn/reactos?rev=65390&view=rev > Log: > [WIN32SS] > if (BooleanValue == TRUE) -> if (!BooleanValue) > Patch by Love Nystrom > CORE-8799 > > Modified: > trunk/reactos/win32ss/drivers/displays/framebuf/ddenable.c > trunk/reactos/win32ss/drivers/displays/framebuf/pointer.c > trunk/reactos/win32ss/drivers/displays/framebufacc/ddenable.c > trunk/reactos/win32ss/drivers/displays/vga/main/enable.c > trunk/reactos/win32ss/drivers/displays/vga/vgavideo/vgavideo.c > trunk/reactos/win32ss/gdi/dib/floodfill.c > trunk/reactos/win32ss/gdi/gdi32/misc/gdientry.c > trunk/reactos/win32ss/user/ntuser/hotkey.c > trunk/reactos/win32ss/user/ntuser/message.c > trunk/reactos/win32ss/user/ntuser/msgqueue.c > trunk/reactos/win32ss/user/user32/controls/appswitch.c > trunk/reactos/win32ss/user/user32/misc/desktop.c > trunk/reactos/win32ss/user/user32/misc/winsta.c > trunk/reactos/win32ss/user/winsrv/consrv/frontends/gui/conwnd.c > trunk/reactos/win32ss/user/winsrv/consrv_new/frontends/gui/guiterm.c > trunk/reactos/win32ss/user/winsrv/usersrv/register.c > > Modified: trunk/reactos/win32ss/drivers/displays/framebuf/ddenable.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/drivers/displays/f… > ============================================================================== > --- trunk/reactos/win32ss/drivers/displays/framebuf/ddenable.c [iso-8859-1] (original) > +++ trunk/reactos/win32ss/drivers/displays/framebuf/ddenable.c [iso-8859-1] Thu Nov 13 10:31:45 2014 > @@ -38,7 +38,7 @@ > { > PPDEV ppdev = (PPDEV)dhpdev; > > - if (ppdev->bDDInitialized == TRUE) > + if (ppdev->bDDInitialized) > { > return TRUE; > } > @@ -237,7 +237,7 @@ > { > ppdev->pvmList = pvmList; > > - if ( bDDrawHeap == TRUE) > + if (bDDrawHeap) > { > pvmList->dwFlags = VIDMEM_ISLINEAR ; > pvmList->fpStart = ppdev->ScreenHeight * ppdev->ScreenDelta; > > Modified: trunk/reactos/win32ss/drivers/displays/framebuf/pointer.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/drivers/displays/f… > ============================================================================== > --- trunk/reactos/win32ss/drivers/displays/framebuf/pointer.c [iso-8859-1] (original) > +++ trunk/reactos/win32ss/drivers/displays/framebuf/pointer.c [iso-8859-1] Thu Nov 13 10:31:45 2014 > @@ -110,7 +110,7 @@ > VOID FASTCALL > IntShowMousePointer(PPDEV ppdev, SURFOBJ *DestSurface) > { > - if (ppdev->PointerAttributes.Enable == TRUE) > + if (ppdev->PointerAttributes.Enable) > { > return; > } > > Modified: trunk/reactos/win32ss/drivers/displays/framebufacc/ddenable.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/drivers/displays/f… > ============================================================================== > --- trunk/reactos/win32ss/drivers/displays/framebufacc/ddenable.c [iso-8859-1] (original) > +++ trunk/reactos/win32ss/drivers/displays/framebufacc/ddenable.c [iso-8859-1] Thu Nov 13 10:31:45 2014 > @@ -38,7 +38,7 @@ > { > PPDEV ppdev = (PPDEV)dhpdev; > > - if (ppdev->bDDInitialized == TRUE) > + if (ppdev->bDDInitialized) > { > return TRUE; > } > @@ -237,7 +237,7 @@ > { > ppdev->pvmList = pvmList; > > - if ( bDDrawHeap == TRUE) > + if (bDDrawHeap) > { > pvmList->dwFlags = VIDMEM_ISLINEAR ; > pvmList->fpStart = ppdev->ScreenHeight * ppdev->ScreenDelta; > > Modified: trunk/reactos/win32ss/drivers/displays/vga/main/enable.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/drivers/displays/v… > ============================================================================== > --- trunk/reactos/win32ss/drivers/displays/vga/main/enable.c [iso-8859-1] (original) > +++ trunk/reactos/win32ss/drivers/displays/vga/main/enable.c [iso-8859-1] Thu Nov 13 10:31:45 2014 > @@ -302,7 +302,7 @@ > PPDEV ppdev = (PPDEV)DPev; > ULONG returnedDataLength; > > - if(Enable==TRUE) > + if (Enable) > { > /* Reenable our graphics mode */ > if (!InitPointer(ppdev)) > > Modified: trunk/reactos/win32ss/drivers/displays/vga/vgavideo/vgavideo.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/drivers/displays/v… > ============================================================================== > --- trunk/reactos/win32ss/drivers/displays/vga/vgavideo/vgavideo.c [iso-8859-1] (original) > +++ trunk/reactos/win32ss/drivers/displays/vga/vgavideo/vgavideo.c [iso-8859-1] Thu Nov 13 10:31:45 2014 > @@ -560,7 +560,7 @@ > pb++; > } > > - if (edgePixel == TRUE) > + if (edgePixel) > { > b1 = *pb; > if(b1 != trans) vgaPutPixel(x2, j, b1); > > Modified: trunk/reactos/win32ss/gdi/dib/floodfill.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/gdi/dib/floodfill.… > ============================================================================== > --- trunk/reactos/win32ss/gdi/dib/floodfill.c [iso-8859-1] (original) > +++ trunk/reactos/win32ss/gdi/dib/floodfill.c [iso-8859-1] Thu Nov 13 10:31:45 2014 > @@ -61,7 +61,7 @@ > { > if (RECTL_bPointInRect(DstRect,x,y)) > { > - if (isSurf == TRUE && > + if (isSurf && > DibFunctionsForBitmapFormat[DstSurf->iBitmapFormat].DIB_GetPixel(DstSurf, x, y) != Color) > { > return; > > Modified: trunk/reactos/win32ss/gdi/gdi32/misc/gdientry.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/gdi/gdi32/misc/gdi… > ============================================================================== > --- trunk/reactos/win32ss/gdi/gdi32/misc/gdientry.c [iso-8859-1] (original) > +++ trunk/reactos/win32ss/gdi/gdi32/misc/gdientry.c [iso-8859-1] Thu Nov 13 10:31:45 2014 > @@ -1837,7 +1837,7 @@ > { > /* Free it */ > Return = NtGdiDdDeleteDirectDrawObject((HANDLE)pDirectDrawGlobal->hDD); > - if (Return == TRUE) > + if (Return) > { > pDirectDrawGlobal->hDD = 0; > } > @@ -1852,7 +1852,7 @@ > { > /* Delete the object */ > Return = NtGdiDdDeleteDirectDrawObject(ghDirectDraw); > - if (Return == TRUE) > + if (Return) > { > ghDirectDraw = 0; > } > > Modified: trunk/reactos/win32ss/user/ntuser/hotkey.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/user/ntuser/hotkey… > ============================================================================== > --- trunk/reactos/win32ss/user/ntuser/hotkey.c [iso-8859-1] (original) > +++ trunk/reactos/win32ss/user/ntuser/hotkey.c [iso-8859-1] Thu Nov 13 10:31:45 2014 > @@ -212,7 +212,7 @@ > if (!bIsDown) > { > /* WIN and F12 keys are not hardcoded here. See comments on top of this file. */ > - if (pHotKey->id == IDHK_WINKEY && bWinHotkeyActive == TRUE) > + if (pHotKey->id == IDHK_WINKEY && bWinHotkeyActive) > { > pWnd = ValidateHwndNoErr(InputWindowStation->ShellWindow); > if (pWnd) > > Modified: trunk/reactos/win32ss/user/ntuser/message.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/user/ntuser/messag… > ============================================================================== > --- trunk/reactos/win32ss/user/ntuser/message.c [iso-8859-1] (original) > +++ trunk/reactos/win32ss/user/ntuser/message.c [iso-8859-1] Thu Nov 13 10:31:45 2014 > @@ -2087,7 +2087,7 @@ > > UserLeave(); > > - if (Ret == TRUE) > + if (Ret) > { > _SEH2_TRY > { > > Modified: trunk/reactos/win32ss/user/ntuser/msgqueue.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/user/ntuser/msgque… > ============================================================================== > --- trunk/reactos/win32ss/user/ntuser/msgqueue.c [iso-8859-1] (original) > +++ trunk/reactos/win32ss/user/ntuser/msgqueue.c [iso-8859-1] Thu Nov 13 10:31:45 2014 > @@ -805,7 +805,7 @@ > *Message->Result = Result; > } > > - if (Message->HasPackedLParam == TRUE) > + if (Message->HasPackedLParam) > { > if (Message->Msg.lParam) > ExFreePool((PVOID)Message->Msg.lParam); > @@ -887,7 +887,7 @@ > KeSetEvent(SentMessage->CompletionEvent, IO_NO_INCREMENT, FALSE); > } > > - if (SentMessage->HasPackedLParam == TRUE) > + if (SentMessage->HasPackedLParam) > { > if (SentMessage->Msg.lParam) > ExFreePool((PVOID)SentMessage->Msg.lParam); > @@ -1966,7 +1966,7 @@ > KeSetEvent(CurrentSentMessage->CompletionEvent, IO_NO_INCREMENT, FALSE); > } > > - if (CurrentSentMessage->HasPackedLParam == TRUE) > + if (CurrentSentMessage->HasPackedLParam) > { > if (CurrentSentMessage->Msg.lParam) > ExFreePool((PVOID)CurrentSentMessage->Msg.lParam); > @@ -1998,7 +1998,7 @@ > KeSetEvent(CurrentSentMessage->CompletionEvent, IO_NO_INCREMENT, FALSE); > } > > - if (CurrentSentMessage->HasPackedLParam == TRUE) > + if (CurrentSentMessage->HasPackedLParam) > { > if (CurrentSentMessage->Msg.lParam) > ExFreePool((PVOID)CurrentSentMessage->Msg.lParam); > > Modified: trunk/reactos/win32ss/user/user32/controls/appswitch.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/user/user32/contro… > ============================================================================== > --- trunk/reactos/win32ss/user/user32/controls/appswitch.c [iso-8859-1] (original) > +++ trunk/reactos/win32ss/user/user32/controls/appswitch.c [iso-8859-1] Thu Nov 13 10:31:45 2014 > @@ -522,7 +522,7 @@ > return TRUE; > > case WM_SHOWWINDOW: > - if (wParam == TRUE) > + if (wParam) > { > PrepareWindow(); > ati = (PALTTABINFO)GetWindowLongPtrW(hWnd, 0); > > Modified: trunk/reactos/win32ss/user/user32/misc/desktop.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/user/user32/misc/d… > ============================================================================== > --- trunk/reactos/win32ss/user/user32/misc/desktop.c [iso-8859-1] (original) > +++ trunk/reactos/win32ss/user/user32/misc/desktop.c [iso-8859-1] Thu Nov 13 10:31:45 2014 > @@ -610,7 +610,7 @@ > GetProcessWindowStation(), > 0); > > - if( fInherit == TRUE ) > + if( fInherit ) > { > ObjectAttributes.Attributes |= OBJ_INHERIT; > } > > Modified: trunk/reactos/win32ss/user/user32/misc/winsta.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/user/user32/misc/w… > ============================================================================== > --- trunk/reactos/win32ss/user/user32/misc/winsta.c [iso-8859-1] (original) > +++ trunk/reactos/win32ss/user/user32/misc/winsta.c [iso-8859-1] Thu Nov 13 10:31:45 2014 > @@ -372,7 +372,7 @@ > hWindowStationsDir, > 0); > > - if( fInherit == TRUE ) > + if( fInherit ) > { > ObjectAttributes.Attributes |= OBJ_INHERIT; > } > > Modified: trunk/reactos/win32ss/user/winsrv/consrv/frontends/gui/conwnd.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/user/winsrv/consrv… > ============================================================================== > --- trunk/reactos/win32ss/user/winsrv/consrv/frontends/gui/conwnd.c [iso-8859-1] (original) > +++ trunk/reactos/win32ss/user/winsrv/consrv/frontends/gui/conwnd.c [iso-8859-1] Thu Nov 13 10:31:45 2014 > @@ -1784,7 +1784,7 @@ > static VOID > Copy(PGUI_CONSOLE_DATA GuiData) > { > - if (OpenClipboard(GuiData->hWindow) == TRUE) > + if (OpenClipboard(GuiData->hWindow)) > { > PCONSOLE_SCREEN_BUFFER Buffer = GuiData->ActiveBuffer; > > @@ -1814,7 +1814,7 @@ > static VOID > Paste(PGUI_CONSOLE_DATA GuiData) > { > - if (OpenClipboard(GuiData->hWindow) == TRUE) > + if (OpenClipboard(GuiData->hWindow)) > { > PCONSOLE_SCREEN_BUFFER Buffer = GuiData->ActiveBuffer; > > > Modified: trunk/reactos/win32ss/user/winsrv/consrv_new/frontends/gui/guiterm.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/user/winsrv/consrv… > ============================================================================== > --- trunk/reactos/win32ss/user/winsrv/consrv_new/frontends/gui/guiterm.c [iso-8859-1] (original) > +++ trunk/reactos/win32ss/user/winsrv/consrv_new/frontends/gui/guiterm.c [iso-8859-1] Thu Nov 13 10:31:45 2014 > @@ -1336,7 +1336,7 @@ > static VOID > GuiConsoleCopy(PGUI_CONSOLE_DATA GuiData) > { > - if (OpenClipboard(GuiData->hWindow) == TRUE) > + if (OpenClipboard(GuiData->hWindow)) > { > PCONSOLE Console = GuiData->Console; > PCONSOLE_SCREEN_BUFFER Buffer = ConDrvGetActiveScreenBuffer(Console); > @@ -1364,7 +1364,7 @@ > static VOID > GuiConsolePaste(PGUI_CONSOLE_DATA GuiData) > { > - if (OpenClipboard(GuiData->hWindow) == TRUE) > + if (OpenClipboard(GuiData->hWindow)) > { > PCONSOLE Console = GuiData->Console; > PCONSOLE_SCREEN_BUFFER Buffer = ConDrvGetActiveScreenBuffer(Console); > > Modified: trunk/reactos/win32ss/user/winsrv/usersrv/register.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/user/winsrv/usersr… > ============================================================================== > --- trunk/reactos/win32ss/user/winsrv/usersrv/register.c [iso-8859-1] (original) > +++ trunk/reactos/win32ss/user/winsrv/usersrv/register.c [iso-8859-1] Thu Nov 13 10:31:45 2014 > @@ -53,7 +53,7 @@ > { > PUSER_REGISTER_SERVICES_PROCESS RegisterServicesProcessRequest = &((PUSER_API_MESSAGE)ApiMessage)->Data.RegisterServicesProcessRequest; > > - if (ServicesProcessIdValid == TRUE) > + if (ServicesProcessIdValid) > { > /* Only accept a single call */ > return STATUS_INVALID_PARAMETER; > > >

10 years, 10 months

1
0
0 0

NTFS in ReactOS: heise online article

by Thomas Mueller

I saw an article on heise online (German-language website) http://www.heise.de/newsticker/ on ReactOS liest NTFS http://www.heise.de/newsticker/meldung/ReactOS-liest-NTFS-2442615.html Date is 05.11.2014, meaning just yesterday. I subsequently looked on reactos.org and couldn't find any reference to this article. So far, this is only for reading NTFS on ReactOS; writing ability stil has to be worked on. This is the first article I've seen on this subject: looks like progress. Some ReactOS developers must be familiar with this? Tom

10 years, 10 months

3
8
0 0

Re: [ros-dev] [ros-diffs] [jgardou] 65388: [TCPIP] - Comment out an optimisation which doesn't work. Reviews of why would be most appreciated.

by Timo Kreuzer

tcpip.c:264 /* Keep this list sorted */ InsertHeadList(ListEntry, &OutInstance->ListEntry); This should probably be InsertTailList(), since you want to insert before the current ListEntry Am 12.11.2014 12:39, schrieb jgardou(a)svn.reactos.org: > Author: jgardou > Date: Wed Nov 12 11:39:13 2014 > New Revision: 65388 > > URL: http://svn.reactos.org/svn/reactos?rev=65388&view=rev > Log: > [TCPIP] > - Comment out an optimisation which doesn't work. > Reviews of why would be most appreciated. > > Modified: > branches/tcpip_revolution/drivers/network/tcpip/entities.c > > Modified: branches/tcpip_revolution/drivers/network/tcpip/entities.c > URL: http://svn.reactos.org/svn/reactos/branches/tcpip_revolution/drivers/networ… > ============================================================================== > --- branches/tcpip_revolution/drivers/network/tcpip/entities.c [iso-8859-1] (original) > +++ branches/tcpip_revolution/drivers/network/tcpip/entities.c [iso-8859-1] Wed Nov 12 11:39:13 2014 > @@ -309,9 +309,11 @@ > return STATUS_SUCCESS; > } > > +#if 0 > /* The list is sorted, so we can cut the loop a bit */ > if (ID.tei_instance < Instance->InstanceId.tei_instance) > break; > +#endif > > ListEntry = ListEntry->Flink; > } > > >

10 years, 10 months

1
0
0 0

Re: [ros-dev] [ros-diffs] [spetreolle] 65378: [ADVAPI_WINETEST] Make peace^W tests, not war.☮ Wave a hello to sysreg so that it doesn't kill us. ROSTESTS-56

by Thomas Faber

Hmm, my thought behind disabling this was more that this one test doesn't justify increasing our whole test run time by 10%. On 2014-11-11 11:12, spetreolle(a)svn.reactos.org wrote: > Author: spetreolle > Date: Tue Nov 11 16:12:14 2014 > New Revision: 65378 > > URL: http://svn.reactos.org/svn/reactos?rev=65378&view=rev > Log: > [ADVAPI_WINETEST] > Make peace^W tests, not war.☮ > Wave a hello to sysreg so that it doesn't kill us. > ROSTESTS-56 > > Modified: > trunk/rostests/winetests/advapi32/service.c > > Modified: trunk/rostests/winetests/advapi32/service.c > URL: http://svn.reactos.org/svn/reactos/trunk/rostests/winetests/advapi32/servic… > ============================================================================== > --- trunk/rostests/winetests/advapi32/service.c [iso-8859-1] (original) > +++ trunk/rostests/winetests/advapi32/service.c [iso-8859-1] Tue Nov 11 16:12:14 2014 > @@ -2166,6 +2166,9 @@ > DWORD le1, le2; > SERVICE_STATUS status; > > +#ifdef __REACTOS__ > + fprintf(stdout, "ROSTESTS-56: Hello sysreg, I am awake\n"); > +#endif > ret = StartServiceA(svc_handle, 0, NULL); > le1 = GetLastError(); > ok(!ret, "%s: StartServiceA() should have failed\n", name); > @@ -2260,12 +2263,6 @@ > * insanely long timeout: 120s. So skip the rest of the tests. > */ > win_skip("Skip some service start/stop tests on NT4\n"); > - goto cleanup; > - } > - > - if (!winetest_interactive) > - { > - skip("ROSTESTS-56: Skipping service start timeout tests!\n"); > goto cleanup; > } >

10 years, 10 months

1
0
0 0

Re: [ros-dev] [ros-diffs] [pschweitzer] 65352: [NTOSKRNL] So... Because actual ReactOS mood is to worship hacks instead of looking for proper fixes to have decent behavior: reenable the IopParseDevice hack. But, so far, onl...

by Alex Ionescu

Let me make a simple arrogant comment: Don't try to fix hacks that I spent years trying to fix (and failed). They just can't be fixed :P Best regards, Alex Ionescu On Mon, Nov 10, 2014 at 1:45 AM, <pschweitzer(a)svn.reactos.org> wrote: > Author: pschweitzer > Date: Mon Nov 10 09:45:43 2014 > New Revision: 65352 > > URL: http://svn.reactos.org/svn/reactos?rev=65352&view=rev > Log: > [NTOSKRNL] > So... Because actual ReactOS mood is to worship hacks instead of looking > for proper fixes to have decent behavior: reenable the IopParseDevice hack. > > But, so far, only reenable it for the 1st stage: the most intensive > storage stack stage (unless you start playing with partitions & formating > in 3rd stage). > > CORE-8732 #resolve #comment Bug is now properly hidden with r65352 > > Modified: > trunk/reactos/ntoskrnl/io/iomgr/file.c > > Modified: trunk/reactos/ntoskrnl/io/iomgr/file.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/io/iomgr/file.c?r… > > ============================================================================== > --- trunk/reactos/ntoskrnl/io/iomgr/file.c [iso-8859-1] (original) > +++ trunk/reactos/ntoskrnl/io/iomgr/file.c [iso-8859-1] Mon Nov 10 > 09:45:43 2014 > @@ -404,6 +404,27 @@ > /* Check if we can simply use a dummy file */ > UseDummyFile = ((OpenPacket->QueryOnly) || (OpenPacket->DeleteOnly)); > > + /* FIXME: Small hack still exists, have to check why... > + * This is triggered multiple times by usetup and then once per boot. > + */ > + if (ExpInTextModeSetup && > + !(DirectOpen) && > + !(RemainingName->Length) && > + !(OpenPacket->RelatedFileObject) && > + ((wcsstr(CompleteName->Buffer, L"Harddisk")) || > + (wcsstr(CompleteName->Buffer, L"Floppy"))) && > + !(UseDummyFile)) > + { > + DPRINT1("Using IopParseDevice() hack. Requested invalid > attributes: %lx\n", > + DesiredAccess & ~(SYNCHRONIZE | > + FILE_READ_ATTRIBUTES | > + READ_CONTROL | > + ACCESS_SYSTEM_SECURITY | > + WRITE_OWNER | > + WRITE_DAC)); > + DirectOpen = TRUE; > + } > + > /* Check if this is a direct open */ > if (!(RemainingName->Length) && > !(OpenPacket->RelatedFileObject) && > > >

10 years, 10 months

3
2
0 0

Re: [ros-dev] [ros-diffs] [pschweitzer] 65367: [PARTTEST] Add a dummy application that will open first disk and check first sector for MBR and then will open first partition to check for something known (& not MBR)

by Michael Fritscher

Hi, > + if (Sector->BytesPerSector * Sector->SectorsPerCluster > 32 * 1024) > + { > + return FALSE; > + } FAT supports cluster sizes until 64KB ;-) At least the WinNT series can work with them. Best regards, Michael Fritscher

10 years, 10 months

2
1
0 0

Re: [ros-dev] [ros-diffs] [pschweitzer] 65352: [NTOSKRNL] So... Because actual ReactOS mood is to worship hacks instead of looking for proper fixes to have decent behavior: reenable the IopParseDevice hack. But, so far, onl...

by Aleksey Bragin

Thank you for working on this hack (partial) removal! After all, having it only in the 1st stage is a win over having it enabled all the time. Regards, Aleksey On 10.11.2014 12:45, pschweitzer(a)svn.reactos.org wrote: > Author: pschweitzer > Date: Mon Nov 10 09:45:43 2014 > New Revision: 65352 > > URL: http://svn.reactos.org/svn/reactos?rev=65352&view=rev > Log: > [NTOSKRNL] > So... Because actual ReactOS mood is to worship hacks instead of looking for proper fixes to have decent behavior: reenable the IopParseDevice hack. > > But, so far, only reenable it for the 1st stage: the most intensive storage stack stage (unless you start playing with partitions & formating in 3rd stage). > > CORE-8732 #resolve #comment Bug is now properly hidden with r65352 > > Modified: > trunk/reactos/ntoskrnl/io/iomgr/file.c > > Modified: trunk/reactos/ntoskrnl/io/iomgr/file.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/io/iomgr/file.c?r… > ============================================================================== > --- trunk/reactos/ntoskrnl/io/iomgr/file.c [iso-8859-1] (original) > +++ trunk/reactos/ntoskrnl/io/iomgr/file.c [iso-8859-1] Mon Nov 10 09:45:43 2014 > @@ -404,6 +404,27 @@ > /* Check if we can simply use a dummy file */ > UseDummyFile = ((OpenPacket->QueryOnly) || (OpenPacket->DeleteOnly)); > > + /* FIXME: Small hack still exists, have to check why... > + * This is triggered multiple times by usetup and then once per boot. > + */ > + if (ExpInTextModeSetup && > + !(DirectOpen) && > + !(RemainingName->Length) && > + !(OpenPacket->RelatedFileObject) && > + ((wcsstr(CompleteName->Buffer, L"Harddisk")) || > + (wcsstr(CompleteName->Buffer, L"Floppy"))) && > + !(UseDummyFile)) > + { > + DPRINT1("Using IopParseDevice() hack. Requested invalid attributes: %lx\n", > + DesiredAccess & ~(SYNCHRONIZE | > + FILE_READ_ATTRIBUTES | > + READ_CONTROL | > + ACCESS_SYSTEM_SECURITY | > + WRITE_OWNER | > + WRITE_DAC)); > + DirectOpen = TRUE; > + } > + > /* Check if this is a direct open */ > if (!(RemainingName->Length) && > !(OpenPacket->RelatedFileObject) && > >

10 years, 10 months

2
1
0 0

Re: [ros-dev] [ros-diffs] [hbelusca] 65337: [NTOS:PNPMGR] - Remove an unneeded ExFreePool(DeviceInstance.Buffer); call in IopGetInterfaceDeviceList because at this point DeviceInstance is not yet initialized. Fixes MSVC bui...

by Timo Kreuzer

You add parentheses to conform to coding style (our coding style guidelines do not require it) and on the other hand you convert a 2 line if statement into one line, which does not conform to our coding style? Am 09.11.2014 03:26, schrieb hbelusca(a)svn.reactos.org: > Author: hbelusca > Date: Sun Nov 9 02:26:49 2014 > New Revision: 65337 > > URL: http://svn.reactos.org/svn/reactos?rev=65337&view=rev > Log: > [NTOS:PNPMGR] > - Remove an unneeded ExFreePool(DeviceInstance.Buffer); call in IopGetInterfaceDeviceList because at this point DeviceInstance is not yet initialized. Fixes MSVC build. > - No need to check for DeviceInstance.Buffer being NULL or not (in IopDeviceStatus), because in case it was NULL the IopCaptureUnicodeString call already failed. > - Add some brackets to conform to code style. > > Modified: > trunk/reactos/ntoskrnl/io/pnpmgr/plugplay.c > > Modified: trunk/reactos/ntoskrnl/io/pnpmgr/plugplay.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/io/pnpmgr/plugpla… > ============================================================================== > --- trunk/reactos/ntoskrnl/io/pnpmgr/plugplay.c [iso-8859-1] (original) > +++ trunk/reactos/ntoskrnl/io/pnpmgr/plugplay.c [iso-8859-1] Sun Nov 9 02:26:49 2014 > @@ -199,8 +199,7 @@ > } > _SEH2_EXCEPT(EXCEPTION_EXECUTE_HANDLER) > { > - if (Name.Buffer) > - ExFreePool(Name.Buffer); > + if (Name.Buffer) ExFreePool(Name.Buffer); > Status = _SEH2_GetExceptionCode(); > } > _SEH2_END; >

10 years, 10 months

1
0
0 0

Re: [ros-dev] [ros-diffs] [hbelusca] 65336: [NTVDM]: Use variable-length buffers in DisplayMessage, in case we display a very long message (uses the _vscwprintf CRT function, not available on Win2k. You need to recompile NT...

by Timo Kreuzer

Am 09.11.2014 02:46, schrieb hbelusca(a)svn.reactos.org: > Author: hbelusca > Date: Sun Nov 9 01:46:31 2014 > New Revision: 65336 > > URL: http://svn.reactos.org/svn/reactos?rev=65336&view=rev > Log: > [NTVDM]: Use variable-length buffers in DisplayMessage, in case we display a very long message (uses the _vscwprintf CRT function, not available on Win2k. You need to recompile NTVDM with WIN2K_COMPLIANT define if you want to be able to run it on win2k. In that case DisplayMessage uses a quite large enough buffer for its needs). If somebody knows an alternative to _vscwprintf that does the very same job, and which exists on Win2k, I would be happy to use it instead. Since _vscwprintf will do the whole work already anyway, you could as well directly print it into the static buffer. You could use _vsnwprintf or StringCbPrintfW, which internally uses the former, and use the result to decide whether the buffer was large enough. This will be more performant, since you only need to print once, when the buffer is large enough.

10 years, 10 months

1
0
0 0

Re: [ros-dev] [ros-diffs] [tfaber] 65269: [FASTFAT] - VfatCleanupFile: do not dereference the FCB when closing the volume file object. ObDereferenceObject already causes an IRP_MJ_CLOSE request to be sent, which dereference...

by Thomas Faber

Oh... Jérôme, I only just saw that you added this in r65140... And my change does break the msi tests again. :\ Any idea what's going wrong here? I'm relatively certain my change is correct because vfatFCBInitializeCacheFromVolume takes one reference, and VfatCloseFile invoked via ObDereferenceObject will remove that reference again. So apparently we're leaking a directory reference somewhere else? :( Not sure if your previous investigation into this issue can provide any pointers. Otherwise I'll have to start digging for the leak all over again... Thanks. -Thomas On 2014-11-05 19:52, tfaber(a)svn.reactos.org wrote: > --- trunk/reactos/drivers/filesystems/fastfat/cleanup.c [iso-8859-1] (original) > +++ trunk/reactos/drivers/filesystems/fastfat/cleanup.c [iso-8859-1] Wed Nov 5 18:52:11 2014 > @@ -92,7 +92,6 @@ > pFcb->FileObject = NULL; > CcUninitializeCacheMap(tmpFileObject, NULL, NULL); > ObDereferenceObject(tmpFileObject); > - vfatReleaseFCB(IrpContext->DeviceExt, pFcb); > } > > CcPurgeCacheSection(FileObject->SectionObjectPointer, NULL, 0, FALSE); > >

10 years, 10 months

2
1
0 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev