- Ros-dev - ReactOS.org

Re: [ros-dev] [ros-diffs] [hbelusca] 63610: [WIN32K] There is a bug in win32k (who would have thought that?) that consists in holding a winstation spinlock while running PAGED_CODE MmCopyToCaller function, when building the...

by Alex Ionescu

Win32k.sys is supposed to use MmPageEntireDriver, as such, it should run 100% at passive only. Best regards, Alex Ionescu On Tue, Jun 17, 2014 at 10:01 PM, <hbelusca(a)svn.reactos.org> wrote: > Author: hbelusca > Date: Tue Jun 17 20:01:23 2014 > New Revision: 63610 > > URL: http://svn.reactos.org/svn/reactos?rev=63610&view=rev > Log: > [WIN32K] > There is a bug in win32k (who would have thought that?) that consists in > holding a winstation spinlock while running PAGED_CODE MmCopyToCaller > function, when building the list of desktops of a given window station (the > bug is easily triggerable when calling EnumDesktopsW). Since this lock is > never used in anyplace but in this function, which, by the way, is just a > reader function that fills user buffer, I consider that it is safe to > remove this lock. However I want approval from win32k specialists. Hence I > just disable the code with a define USE_WINSTA_LOCK. If this lock is really > needed, please rewrite the BuildDesktopNameList function !! Otherwise > remove this lock and the associated code !! > This is a blocker for the shutdown code. > > Modified: > trunk/reactos/win32ss/user/ntuser/winsta.c > trunk/reactos/win32ss/user/ntuser/winsta.h > > Modified: trunk/reactos/win32ss/user/ntuser/winsta.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/user/ntuser/winsta… > > ============================================================================== > --- trunk/reactos/win32ss/user/ntuser/winsta.c [iso-8859-1] (original) > +++ trunk/reactos/win32ss/user/ntuser/winsta.c [iso-8859-1] Tue Jun 17 > 20:01:23 2014 > @@ -451,7 +451,9 @@ > /* Initialize the window station */ > RtlZeroMemory(WindowStationObject, sizeof(WINSTATION_OBJECT)); > > +#ifdef USE_WINSTA_LOCK > KeInitializeSpinLock(&WindowStationObject->Lock); > +#endif > InitializeListHead(&WindowStationObject->DesktopListHead); > Status = RtlCreateAtomTable(37, &WindowStationObject->AtomTable); > WindowStationObject->Name = WindowStationName; > @@ -1203,7 +1205,9 @@ > { > NTSTATUS Status; > PWINSTATION_OBJECT WindowStation; > +#ifdef USE_WINSTA_LOCK > KIRQL OldLevel; > +#endif > PLIST_ENTRY DesktopEntry; > PDESKTOP DesktopObject; > DWORD EntryCount; > @@ -1220,7 +1224,9 @@ > return Status; > } > > +#ifdef USE_WINSTA_LOCK > KeAcquireSpinLock(&WindowStation->Lock, &OldLevel); > +#endif > > /* > * Count the required size of buffer. > @@ -1242,7 +1248,9 @@ > Status = MmCopyToCaller(pRequiredSize, &ReturnLength, > sizeof(ULONG)); > if (! NT_SUCCESS(Status)) > { > +#ifdef USE_WINSTA_LOCK > KeReleaseSpinLock(&WindowStation->Lock, OldLevel); > +#endif > ObDereferenceObject(WindowStation); > return STATUS_BUFFER_TOO_SMALL; > } > @@ -1253,7 +1261,9 @@ > */ > if (dwSize < ReturnLength) > { > +#ifdef USE_WINSTA_LOCK > KeReleaseSpinLock(&WindowStation->Lock, OldLevel); > +#endif > ObDereferenceObject(WindowStation); > return STATUS_BUFFER_TOO_SMALL; > } > @@ -1264,7 +1274,9 @@ > Status = MmCopyToCaller(lpBuffer, &EntryCount, sizeof(DWORD)); > if (! NT_SUCCESS(Status)) > { > +#ifdef USE_WINSTA_LOCK > KeReleaseSpinLock(&WindowStation->Lock, OldLevel); > +#endif > ObDereferenceObject(WindowStation); > return Status; > } > @@ -1280,7 +1292,9 @@ > Status = MmCopyToCaller(lpBuffer, DesktopName.Buffer, > DesktopName.Length); > if (! NT_SUCCESS(Status)) > { > +#ifdef USE_WINSTA_LOCK > KeReleaseSpinLock(&WindowStation->Lock, OldLevel); > +#endif > ObDereferenceObject(WindowStation); > return Status; > } > @@ -1288,7 +1302,9 @@ > Status = MmCopyToCaller(lpBuffer, &NullWchar, sizeof(WCHAR)); > if (! NT_SUCCESS(Status)) > { > +#ifdef USE_WINSTA_LOCK > KeReleaseSpinLock(&WindowStation->Lock, OldLevel); > +#endif > ObDereferenceObject(WindowStation); > return Status; > } > @@ -1298,7 +1314,9 @@ > /* > * Clean up > */ > +#ifdef USE_WINSTA_LOCK > KeReleaseSpinLock(&WindowStation->Lock, OldLevel); > +#endif > ObDereferenceObject(WindowStation); > > return STATUS_SUCCESS; > > Modified: trunk/reactos/win32ss/user/ntuser/winsta.h > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/user/ntuser/winsta… > > ============================================================================== > --- trunk/reactos/win32ss/user/ntuser/winsta.h [iso-8859-1] (original) > +++ trunk/reactos/win32ss/user/ntuser/winsta.h [iso-8859-1] Tue Jun 17 > 20:01:23 2014 > @@ -7,11 +7,16 @@ > #define WSS_LOCKED (1) > #define WSS_NOINTERACTIVE (2) > > +// Uncomment for using WinSta spinlock > +// #define USE_WINSTA_LOCK > + > typedef struct _WINSTATION_OBJECT > { > DWORD dwSessionId; > > +#ifdef USE_WINSTA_LOCK > KSPIN_LOCK Lock; > +#endif > UNICODE_STRING Name; > LIST_ENTRY DesktopListHead; > PRTL_ATOM_TABLE AtomTable; > > >

11 years, 2 months

3
5
0 0

Jira comments

by Hermès BÉLUSCA - MAÏTO

Hey guys ! It seems that suddently Jira SVN comments work again. How is it possible? H.

11 years, 2 months

3
3
0 0

[CONSRV] Ensure szMenuStringBack is NULL terminated to prevent possible buffer overread and fix char to wchar_t assignment.

by Vyronas Tsingaras

Is this patch acceptable? Please kindly explain any possible mistakes.

11 years, 2 months

2
1
0 0

Re: [ros-dev] [ros-diffs] [jgardou] 63642: [SETUPAPI_APITEST] - Add a test that shows that SetupDiGetClassDevsExW doesn't fail on non-existing GUID

by Timo Kreuzer

11 years, 2 months

1
0
0 0

CRT changes

by Ged Murphy

Some interesting changes are coming to the CRT which the VS builds will need to prepare for. The obvious one is the %s/%S format changes http://blogs.msdn.com/b/vcblog/archive/2014/06/18/crt-features-fixes-and-bre aking-changes-in-visual-studio-14-ctp1.aspx Ged.

11 years, 2 months

1
0
0 0

Re: [ros-dev] [ros-diffs] [hbelusca] 63610: [WIN32K] There is a bug in win32k (who would have thought that?) that consists in holding a winstation spinlock while running PAGED_CODE MmCopyToCaller function, when building the...

by Timo Kreuzer

11 years, 2 months

1
0
0 0

Re: [ros-dev] [ros-diffs] [hbelusca] 63599: [TASKMGR]: Use the EndTask API to kill tasks.

by Pierre Schweitzer

On 15/06/2014 19:47, hbelusca(a)svn.reactos.org wrote: > + /* Trick: on Windows, pressing the CTRL key forces the task to be ended */ > + BOOL ForceEndTask = !!(GetKeyState(VK_CONTROL) & 0x8000); > + Was it really meant to be '!!'? -- Pierre Schweitzer<pierre at reactos.org> System Administrator ReactOS Foundation

11 years, 3 months

4
4
0 0

Re: [ros-dev] Upgrade complete

by Alexander Rechitskiy

All is down! > Fixed. > > On 15/06/2014 00:56, Alexander Rechitskiy wrote: > >> https://code.reactos.org/ does NOT work >> 15.06.2014, 02:40, "Pierre Schweitzer" <pierre(a)reactos.org>: >>> As a side note, upgrade to Fisheye 3.4.4 didn't fix ONLINE-461 (which was the >>> main reason behind the upgrade). >>> >>> On 15/06/2014 00:36, Zachary Gorden wrote: >>>> Fisheye was upgraded successfully, Jira went off the rails and took us >>>> about three hours to recover from. Please report any data loss as we had to >>>> restore from backups. >>>> >>>> >>>> >>>> _______________________________________________ >>>> Ros-dev mailing list >>>> Ros-dev(a)reactos.org <mailto:Ros-dev@reactos.org> >>>> http://www.reactos.org/mailman/listinfo/ros-dev >>> >>> >>> -- >>> Pierre Schweitzer<pierre at reactos.org> >>> System Administrator >>> ReactOS Foundation >>> , >>> >>> _______________________________________________ >>> Ros-dev mailing list >>> Ros-dev(a)reactos.org <mailto:Ros-dev@reactos.org> >>> http://www.reactos.org/mailman/listinfo/ros-dev >>> >> -- >> Best regards, >> >> _______________________________________________ >> Ros-dev mailing list >> Ros-dev(a)reactos.org >> http://www.reactos.org/mailman/listinfo/ros-dev > > -- > Pierre Schweitzer<pierre at reactos.org> > System Administrator > ReactOS Foundation -- -- Best regards,

11 years, 3 months

1
0
0 0

Upgrade complete

by Zachary Gorden

Fisheye was upgraded successfully, Jira went off the rails and took us about three hours to recover from. Please report any data loss as we had to restore from backups.

11 years, 3 months

3
3
0 0

Fisheye and Jira going down

by Zachary Gorden

We'll be doing an upgrade of Fisheye and hopefully Jira, so expect downtime until the all clear is given.

11 years, 3 months

1
0
0 0

Re: [ros-dev] [ros-diffs] [tkreuzer] 63520: [MCISEQ] Silence a warning [CMAKE] Get rid of -Wtype-limits, it's noisy, it doesn't provide any reasonable benefit and it's almost impossible to "fix" these warnings without huge ...

by Thomas Faber

This helps find logic errors, mostly where the programmer thought the variable was signed but it's actually unsigned, e.g. if (ret < 0) for a function that returns (ULONG)-1. I also don't see how the fix would be complicated in most cases. (x <= 0) becomes (x == 0), (x < 0) becomes (x == (ULONG)-1) or whatever (after a logic review). I know that it'll be problematic if resulting from a macro... but I think it's worth finding a workaround for those cases. Most of the warnings I remember from our code base though (especially ntoskrnl) didn't involve macros and were actually cases of questionable logic... although maybe I recall incorrectly. On 2014-05-31 23:26, tkreuzer(a)svn.reactos.org wrote: > [CMAKE] Get rid of -Wtype-limits, it's noisy, it doesn't provide any reasonable benefit and it's almost impossible to "fix" these warnings without huge haxxory.

11 years, 3 months

2
2
0 0

Status Meeting (May 2014)

by Aleksey Bragin

Hello, Let me invite you to the monthly status meeting taking place first Thursday of this month, 5th of June, 19:00 UTC. And this date is very close to now! The meeting was rescheduled from the usual date because of my trips and my illness. Sorry about that. IRC service will only be started shortly before the meeting. Your participation passwords and server address will be emailed to you shortly before the meeting starts, and they are going to be different once again as they are not stored in any database. Hopefully it's not much of inconvenience. If someone still is not getting passwords sent before a meeting - please email Pierre before the meeting started to get one. Please send agenda proposals to me before the meeting, so that we can start with a proposed agenda. However the most demanded topic is ReactOS fundraising campaign and its outcome :-) Also all developers, please, may I so kindly ask you to prepare a very brief one-two lines message containing two things: 1. What you did since the previous meeting 2. What you are going to do in the coming month This is needed to understand who is working on what, to plan things, etc. Thanks, I hope it's not that much to ask for. Regards, Aleksey Bragin

11 years, 3 months

3
2
0 0

Instanciate TAP device for Virtualisation

by Maxime Daniel

Hi, I'm working on network virtualization support in ReactOS. At this time, PoC works but I reach a point where I need a solution that would allow to add and remove TAP (TAP-Win32 from OpenVPN for exemple) Network Devices from kernel space, without user intervention. The problem right now is that there seems to be impossible in ReactOS to have a proper way or tips and tricks to add/remove TAP devices without rebooting the system. What should be fixed/edit to instanciate of TAP device on the fly on the current implementation (r63193) ? Thanks -- Daniel Maxime Linux version 3.6.9-maxux64 (emy) (gcc version 4.7.3 (Gentoo 4.7.3-r1 p1.4, pie-0.5.5) ) #3 SMP PREEMPT Wed Feb 19 16:40:22 CET 2014 17:15:01 up 1 day, 1:44, 1 user, load average: 0.29, 0.28, 0.35

11 years, 3 months

3
4
0 0

Re: [ros-dev] [ros-diffs] [hbelusca] 63506: [NTOS:CM] Replace a hardcoded value with something more readable.

by Timo Kreuzer

Am 30.05.2014 23:47, schrieb hbelusca(a)svn.reactos.org: > Author: hbelusca > Date: Fri May 30 21:47:22 2014 > New Revision: 63506 > > URL: http://svn.reactos.org/svn/reactos?rev=63506&view=rev > Log: > [NTOS:CM] > Replace a hardcoded value with something more readable. > - RootKey->Type = '20yk'; > + RootKey->Type = CM_KEY_BODY_TYPE; > RootKey->NotifyBlock = NULL; > +// > +#define CM_KEY_BODY_TYPE 0x6B793032 Why not '20yk' ? This hex constant looks fishy.

11 years, 3 months

2
1
0 0

Re: [ros-dev] [ros-diffs] [tkreuzer] 63388: [NTOSKRNL] Fix ending address calculation for the commit path in NtAllocateVirtualMemory like done for the reserve path in r63356. Add a comment about a Windows kernel bug, which ...

by Thomas Faber

On 2014-05-20 23:11, tkreuzer(a)svn.reactos.org wrote: > --- trunk/reactos/ntoskrnl/mm/ARM3/virtual.c [iso-8859-1] (original) > +++ trunk/reactos/ntoskrnl/mm/ARM3/virtual.c [iso-8859-1] Tue May 20 21:11:43 2014 > @@ -4593,8 +4593,8 @@ > // on the user input, and then compute the actual region size once all the > // alignments have been done. > // > + EndingAddress = (((ULONG_PTR)PBaseAddress + PRegionSize - 1) | (PAGE_SIZE - 1)); > StartingAddress = (ULONG_PTR)PAGE_ALIGN(PBaseAddress); > - EndingAddress = (((ULONG_PTR)PBaseAddress + PRegionSize - 1) | (PAGE_SIZE - 1)); > PRegionSize = EndingAddress - StartingAddress + 1; > > // Can you explain this a bit? I don't see any logic change.

11 years, 3 months

1
0
0 0

SVN r63496

by Eric Kohl

>[LSASRV] > >- Just run again the loop if LsarOpenAccount call failed (that also >avoids a call to LsarClose on a NULL handle, that is trapped by the >kdbg if one enabled "set condition * first always"). > >- Free the memory and the opened handles before returning in case of >failure of LsapAddPrivilegeToTokenPrivileges. Maybe this cleaning step >can be done more elegantly. > >Eric, can you please review that? It should be good I think. The change is OK!

11 years, 3 months

1
0
0 0

Re: [ros-dev] [ros-diffs] [akhaldi] 63480: [CMAKE] * Convert the hives from UTF-8 to UTF16 as part of the build process. CORE-7703 CORE-8221

by Thomas Faber

The savior, as always. Thank you! On 2014-05-27 21:42, akhaldi(a)svn.reactos.org wrote: > Author: akhaldi > Date: Tue May 27 19:42:15 2014 > New Revision: 63480 > > URL: http://svn.reactos.org/svn/reactos?rev=63480&view=rev > Log: > [CMAKE] > * Convert the hives from UTF-8 to UTF16 as part of the build process. > CORE-7703 > CORE-8221 > > Modified: > trunk/reactos/boot/bootdata/CMakeLists.txt > trunk/reactos/boot/bootdata/hivecls.inf (contents, props changed) > trunk/reactos/boot/bootdata/hivedef.inf (contents, props changed) > trunk/reactos/boot/bootdata/hivesft.inf (contents, props changed) > trunk/reactos/boot/bootdata/hivesys.inf > trunk/reactos/cmake/CMakeMacros.cmake > > [This mail would be too long, it was shortened to contain the URLs only.] > > Modified: trunk/reactos/boot/bootdata/CMakeLists.txt > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/bootdata/CMakeLists.t… > > Modified: trunk/reactos/boot/bootdata/hivecls.inf > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/bootdata/hivecls.inf?… > > Modified: trunk/reactos/boot/bootdata/hivedef.inf > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/bootdata/hivedef.inf?… > > Modified: trunk/reactos/boot/bootdata/hivesft.inf > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/bootdata/hivesft.inf?… > > Modified: trunk/reactos/boot/bootdata/hivesys.inf > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/bootdata/hivesys.inf?… > > Modified: trunk/reactos/cmake/CMakeMacros.cmake > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/cmake/CMakeMacros.cmake?re… > >

11 years, 3 months

1
0
0 0

Re: [ros-dev] [ros-diffs] [cwittich] 63452: [bootdata] convert hivecls.inf and hivedef.inf to UTF16LE fixes CORE-7614

by Thomas Faber

This is not the right solution. SVN has terrible UTF-16 handling so we should not convert these back to UTF-16. https://jira.reactos.org/browse/CORE-7703 https://jira.reactos.org/browse/CORE-8221 On 2014-05-25 22:17, cwittich(a)svn.reactos.org wrote: > Author: cwittich > Date: Sun May 25 20:17:25 2014 > New Revision: 63452 > > URL: http://svn.reactos.org/svn/reactos?rev=63452&view=rev > Log: > [bootdata] > convert hivecls.inf and hivedef.inf to UTF16LE > fixes CORE-7614 > > Modified: > trunk/reactos/boot/bootdata/hivecls.inf (contents, props changed) > trunk/reactos/boot/bootdata/hivedef.inf (contents, props changed) >

11 years, 3 months

5
4
0 0

Regarding recent FAT32 partition handling work by Eric

by Caemyr

I would like to applaud Eric for his outstanding work with ROS partition handling, which we are able to experience since recently. Eric himself had tested this code including GParted, but i`ve that is not all. 7z is able to read FAT partition image files, but this didn't work at all. Right now i was able to open up ROS vmdk image, created by ReactOS itself and view/extract anything of its contents. I cannot express enough how handy this is going to be, allowing to access ROS vm hard disk contents without the pesky hdd mounting (which never really work reliably for me), transferring anything out of the vm by LAN/Internet or booting other VM with those HDDs co-mounted. Simply I cannot thank you enough for your work. Pic included as proof. -- With best regards Caemyr

11 years, 3 months

2
1
0 0

Re: [ros-dev] [ros-diffs] [cwittich] 63423: [shell32] revert one line of r63414

by Thomas Faber

> --- trunk/reactos/dll/win32/shell32/shlexec.cpp [iso-8859-1] (original) > +++ trunk/reactos/dll/win32/shell32/shlexec.cpp [iso-8859-1] Fri May 23 17:14:39 2014 > @@ -459,7 +459,7 @@ > startup.dwFlags = STARTF_USESHOWWINDOW; > startup.wShowWindow = psei->nShow; > dwCreationFlags = CREATE_UNICODE_ENVIRONMENT; > - if (!(psei->fMask & SEE_MASK_NO_CONSOLE)) > + if (psei->fMask & SEE_MASK_NO_CONSOLE) > dwCreationFlags |= CREATE_NEW_CONSOLE; > startup.lpTitle = (LPWSTR)(psei->fMask & (SEE_MASK_HASLINKNAME | SEE_MASK_HASTITLE) ? psei->lpClass : NULL); This is the opposite of what the documentation says?

11 years, 3 months

2
2
0 0

Re: [ros-dev] [ros-diffs] [akhaldi] 63353: [CMAKE/MSVC] * Define _ALLOW_KEYWORD_MACROS to get the news MSVC toolchain to allow us to redefine inline (it became a keyword). Reported by David Quintana.

by Thomas Faber

Hrm, why not just limit the define to C instead? On 2014-05-18 16:39, akhaldi(a)svn.reactos.org wrote: > Author: akhaldi > Date: Sun May 18 14:39:03 2014 > New Revision: 63353 > > URL: http://svn.reactos.org/svn/reactos?rev=63353&view=rev > Log: > [CMAKE/MSVC] > * Define _ALLOW_KEYWORD_MACROS to get the news MSVC toolchain to allow us to redefine inline (it became a keyword). Reported by David Quintana. > > Modified: > trunk/reactos/CMakeLists.txt > > Modified: trunk/reactos/CMakeLists.txt > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/CMakeLists.txt?rev=63353&r… > ============================================================================== > --- trunk/reactos/CMakeLists.txt [iso-8859-1] (original) > +++ trunk/reactos/CMakeLists.txt [iso-8859-1] Sun May 18 14:39:03 2014 > @@ -62,6 +62,9 @@ > if(MSVC) > if(ARCH STREQUAL "i386") > add_definitions(/D_X86_ /DWIN32 /D_WINDOWS) > + endif() > + if(MSVC_VERSION GREATER 1799) > + add_definitions(/D_ALLOW_KEYWORD_MACROS) > endif() > add_definitions(/Dinline=__inline) > else() > >

11 years, 3 months

1
0
0 0

Re: [ros-dev] [ros-diffs] [hbelusca] 63398: [USETUP] - Fix a bit the translation of yesterday; - Use TEXT_PADDING_BIG instead of hardcoding 3 spaces in the status messages.

by Pierre Schweitzer

On 05/21/2014 02:23 PM, hbelusca(a)svn.reactos.org wrote: > Author: hbelusca > Date: Wed May 21 12:23:04 2014 > New Revision: 63398 > > URL: http://svn.reactos.org/svn/reactos?rev=63398&view=rev > Log: > [USETUP] > - Fix a bit the translation of yesterday; > - Use TEXT_PADDING_BIG instead of hardcoding 3 spaces in the status messages. > > Modified: > trunk/reactos/base/setup/usetup/lang/fr-FR.h > > Modified: trunk/reactos/base/setup/usetup/lang/fr-FR.h > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/setup/usetup/lang/fr-… > ============================================================================== > --- trunk/reactos/base/setup/usetup/lang/fr-FR.h [iso-8859-1] (original) > +++ trunk/reactos/base/setup/usetup/lang/fr-FR.h [iso-8859-1] Wed May 21 12:23:04 2014 > @@ -642,8 +642,8 @@ > { > 0, > 0, > - " Veuillez attendre ...", > - TEXT_TYPE_STATUS, > + "Veuillez attendre ...", > + TEXT_TYPE_STATUS | TEXT_PADDING_BIG > }, > { > 0, It would be better to have "Veuillez patienter..." "Attendre" sounds so weird in that context. > @@ -850,8 +850,8 @@ > { > 0, > 0, > - " Patienter...", > - TEXT_TYPE_STATUS > + "Patienter...", > + TEXT_TYPE_STATUS | TEXT_PADDING_BIG > }, > { > 0, Here, it's likely to be "Patientez..." (to be checked though). -- Pierre Schweitzer <pierre(a)reactos.org> System Administrator ReactOS Foundation

11 years, 3 months

2
1
0 0

New Patchbot is ready

by Colin Finck

The new Linux-based Patchbot is finally live. Do whatever you want with it.

11 years, 3 months

1
0
0 0

Re: [ros-dev] [ros-diffs] [ekohl] 63330: [NTOSKRNL] Partial revert of r63326! The correct partition numbers cause boot failures.

by Alex Ionescu

Lol so maybe you should think twice next time you see "FIXFIX REACTOS HACK" like I originally wrote it ;-) Best regards, Alex Ionescu On Sat, May 17, 2014 at 4:42 PM, <ekohl(a)svn.reactos.org> wrote: > Author: ekohl > Date: Sat May 17 14:42:28 2014 > New Revision: 63330 > > URL: http://svn.reactos.org/svn/reactos?rev=63330&view=rev > Log: > [NTOSKRNL] > Partial revert of r63326! The correct partition numbers cause boot failures. > > Modified: > trunk/reactos/ntoskrnl/fstub/disksup.c > > Modified: trunk/reactos/ntoskrnl/fstub/disksup.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/fstub/disksup.c?r… > ============================================================================== > --- trunk/reactos/ntoskrnl/fstub/disksup.c [iso-8859-1] (original) > +++ trunk/reactos/ntoskrnl/fstub/disksup.c [iso-8859-1] Sat May 17 14:42:28 2014 > @@ -1655,7 +1655,9 @@ > UInt32x32To64(GET_PARTITION_LENGTH(PartitionDescriptor), > SectorSize); > > - PartitionInfo->PartitionNumber = (!IsContainerPartition(PartitionType)) ? i : 0; > + // BUGBUGBUG: The correct partition numbers seem to cause boot failures!!! > +// PartitionInfo->PartitionNumber = (!IsContainerPartition(PartitionType)) ? i : 0; > + PartitionInfo->PartitionNumber = i + 1; > } > else > { > >

11 years, 3 months

2
1
0 0

libusb-win32 - can we use it?

by Alexander Rechitskiy

http://sourceforge.net/apps/trac/libusb-win32/wiki -- Best regards, Alexander Rechitskiy

11 years, 3 months

3
3
0 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev