- Ros-dev - ReactOS.org

MS Console/Terminal stuff (was: "RE: Ros-dev Digest, Vol 177, Issue 2")
by Hermès BÉLUSCA-MAÏTO 08 May '19

08 May '19

Hi, I’m trying to answer point by point. 1. Their license is MIT. At least it allows us to borrow ideas from their code for how to implement stuff in ReactOS’ console/terminal. (I suppose that if one wants to copy entire chunks of code, that I wouldn’t do it, I’m not sure how the licensing of the original ReactOS console GPL code would have to change. But “I’m not a lawyer”. Anyway, copy-pasting stuff is never a good idea.) 2. Yes but again you don’t need to care. It allows us to remain “original” in our way of implementing the things. What’s now “documented” however, is the interface between condrv and conhost (and to kernel32 if my quick reading of the shared headers is correct). This is sufficient. Then the internal implementation one can write for ReactOS is left free, this allows one to have original code and note a dull copy-paste. 3. ReactOS doesn’t use C++ in the console, and won’t use ”WinRT” any time soon in its entire code-base. So forget about any direct import of the MS console code into ROS. Regards, Hermès De : Ros-dev [mailto:ros-dev-bounces@reactos.org] De la part de Biswapriyo Nath Envoyé : mardi 7 mai 2019 20:42 À : ros-dev(a)reactos.org Objet : Re: [ros-dev] Ros-dev Digest, Vol 177, Issue 2 Some queries though: 1. There are many restrictions on how the code can be used. Are developers allowed to import the idea to ReactOS? Also with a different license. 2. The half of the codebase of console subsystem implemented in KernelBase and Kernel32. Those are not open source. Also the main magic happens in ConDrv driver. 3. The project has C++/WinRT code. Does ReactOS have that section? Thank you <3

3 2

Re: [ros-dev] Ros-dev Digest, Vol 177, Issue 2
by Biswapriyo Nath 07 May '19

07 May '19

Some queries though: 1. There are many restrictions on how the code can be used. Are developers allowed to import the idea to ReactOS? Also with a different license. 2. The half of the codebase of console subsystem implemented in KernelBase and Kernel32. Those are not open source. Also the main magic happens in ConDrv driver. 3. The project has C++/WinRT code. Does ReactOS have that section? Thank you <3

1 0

Microsoft open-sources its console / terminal code! (MIT-licensed)
by Hermès BÉLUSCA-MAÏTO 07 May '19

07 May '19

Dear All, Yes you've read correctly! Microsoft released the code of its terminal + the Windows console host (conhost.exe) under MIT license at: https://github.com/microsoft/Terminal I think this is a really great move!! This can definitively help us for: * first, allowing us to improve our existing console code, * and in the future, getting our console architecture Win10-compatible (...) This also means that anybody can contribute back to their code via pull-requests, or at least creating issues. For those using Windows 10, they plan releasing official builds starting June 2019 according to their posts: https://devblogs.microsoft.com/commandline/introducing-windows-terminal/ https://www.hanselman.com/blog/ANewConsoleForWindowsItsTheOpenSourceWindowsT erminal.aspx Best, Hermès

1 0

Re: [ros-dev] [ros-diffs] [reactos] 01/01: [POWERCFG] Fix an exception that occurs when the control panel is closed.
by Thomas Faber 04 May '19

04 May '19

This fix seems odd. I thought HeapFree(NULL) was well-defined and did nothing (despite what MSDN says). Pretty sure Wine uses it everywhere. Am I missing something? On 2019-04-27 19:02, Eric Kohl wrote: > https://git.reactos.org/?p=reactos.git;a=commitdiff;h=ce218f70ec8a758ec6d40… > > commit ce218f70ec8a758ec6d4039690bae29c23289b9d > Author: Eric Kohl <eric.kohl(a)reactos.org> > AuthorDate: Sat Apr 27 19:00:33 2019 +0200 > Commit: Eric Kohl <eric.kohl(a)reactos.org> > CommitDate: Sat Apr 27 19:01:35 2019 +0200 > > [POWERCFG] Fix an exception that occurs when the control panel is closed. > --- > dll/cpl/powercfg/powershemes.c | 16 ++++++++++++---- > 1 file changed, 12 insertions(+), 4 deletions(-) > > diff --git a/dll/cpl/powercfg/powershemes.c b/dll/cpl/powercfg/powershemes.c > index 4fff28a279..7d1441a043 100644 > --- a/dll/cpl/powercfg/powershemes.c > +++ b/dll/cpl/powercfg/powershemes.c > @@ -78,8 +78,12 @@ AddPowerScheme( > dwDescription + sizeof(TCHAR)); > if (pScheme->pszName == NULL || pScheme->pszDescription == NULL) > { > - HeapFree(GetProcessHeap(), 0, pScheme->pszName); > - HeapFree(GetProcessHeap(), 0, pScheme->pszDescription); > + if (pScheme->pszName) > + HeapFree(GetProcessHeap(), 0, pScheme->pszName); > + > + if (pScheme->pszDescription) > + HeapFree(GetProcessHeap(), 0, pScheme->pszDescription); > + > HeapFree(GetProcessHeap(), 0, pScheme); > return NULL; > } > @@ -103,8 +107,12 @@ DeletePowerScheme( > { > RemoveEntryList(&pScheme->ListEntry); > > - HeapFree(GetProcessHeap(), 0, pScheme->pszName); > - HeapFree(GetProcessHeap(), 0, pScheme->pszDescription); > + if (pScheme->pszName) > + HeapFree(GetProcessHeap(), 0, pScheme->pszName); > + > + if (pScheme->pszDescription) > + HeapFree(GetProcessHeap(), 0, pScheme->pszDescription); > + > HeapFree(GetProcessHeap(), 0, pScheme); > } > >

1 0

Proposal for Web App development
by Jatin Kumar 09 Apr '19

09 Apr '19

Hi there, Just got my proposal ready, It would be very kind of you if you can go through my proposal once and tell me of any improvements i should make to it. https://docs.google.com/document/d/1Kmwk2B6PYGypMvEqLR0V-OpZbde_d_tfDBz6Vdw…

1 0

Help required regarding GSOC Application
by Jatin Kumar 09 Apr '19

09 Apr '19

Hey there ! I am really interested to work with your organization.I have been doing web development projects using MERN stack for a while now,And I went through your reactOS GSOC’19 page. I am interested in making the web interface for reactos which can show all GitHub reactos repos, commits, etc using the GitHub API(https://www.reactos.org/wiki/Google_Summer_of_Code_2019_Ideas#Developer… I am Looking forward to work on the same for GSOC this year under your mentorship. Currently I am reading the api documentation and trying to implement some basic stuffs using React and Node.js, till now I have created robust user ineterface with React and am looking forward to add some logics to it in coming hours. Webapp link: https://reactos-web.herokuapp.com/ GitHub repo: https://github.com/AwesomeChap/ReactOS_Web_Interface (Theme I chose in webApp mentioned above is completely customizable : You may think of present theme as Night Mode) kindly review the links. Any suggestion would be appreciated Thanks Jatin Kumar Btech CSE 2nd Year USICT, GGSIPU India

2 2

ReactOS Hackfest 2019 will take place from 15th to 20th August in Berlin
by Colin Finck 09 Apr '19

09 Apr '19

Hi all! The ReactOS Hackfest goes into its fourth round! Join us from Thursday, 15th August to Tuesday, 20th August 2019, just at the same location in Berlin as last year. As every year, check out the https://reactos.org/wiki/ReactOS_Hackfest_2019 and https://reactos.org/wiki/ReactOS_Hackfest_2019/Lists pages on our Wiki and add yourself if you can make it. Hope to see you all in August! Colin

1 0

Code Review and guidence for further application
by Jatin Kumar 09 Apr '19

09 Apr '19

Hey there ! I am really interested to work with your organization.I have been doing web development projects using MERN stack for a while now,And I went through your reactOS GSOC’19 page. I am interested in making the web interface for reactos which can show all GitHub reactos repos, commits, etc using the GitHub API(https://www.reactos.org/wiki/Google_Summer_of_Code_2019_Ideas#Developer… I am Looking forward to work on the same for GSOC this year under your mentorship. Currently I am reading the api documentation and trying to implement some basic stuffs using React and Node.js, till now I have created robust user ineterface with React and am looking forward to add some logics to it in coming hours. Webapp link: https://reactos-web.herokuapp.com/ GitHub repo: https://github.com/AwesomeChap/ReactOS_Web_Interface kindly review the links. Any suggestion would be appreciated Thanks Jatin Kumar Btech CSE 2nd Year USICT, GGSIPU India

2 1

GSOC 2019 - Costin Visan
by costin visan 08 Apr '19

08 Apr '19

Hello! I'm really interested in participating this year at gsoc as part of your team. I'm writting you this email to get your attention and maybe to get a hint for this year's project. I'm in my second year at University Politehnica of Bucharest at the Faculty of Automatic Control and Computers and I study for a degree in Computer Science and Information Technology. I wanna start early this year contributing to the project as I wish to show you that I will be a great addition to your team. If I have caught your attention and you want to communicate me anything, I can be contacted on this mail. - Many thanks, Costin Visan <https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campai…> Virus-free. www.avast.com <https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campai…> <#DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2>

3 2

Re: [ros-dev] [ros-diffs] [reactos] 06/12: [EXT2] Correctly zero memory before using it
by Pierre Schweitzer 01 Apr '19

01 Apr '19

This is 3rd party code. Can you surround it with #ifdef __REACTOS__? Le 01/04/2019 à 17:08, Hervé Poussineau a écrit : > https://git.reactos.org/?p=reactos.git;a=commitdiff;h=76910c358f7197a6b8e28… > > commit 76910c358f7197a6b8e283ea267faf7b5c1812ff > Author: Hervé Poussineau <hpoussin(a)reactos.org> > AuthorDate: Sat Mar 30 23:06:27 2019 +0100 > Commit: Hervé Poussineau <hpoussin(a)reactos.org> > CommitDate: Mon Apr 1 11:38:32 2019 +0200 > > [EXT2] Correctly zero memory before using it > --- > drivers/filesystems/ext2/src/memory.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/filesystems/ext2/src/memory.c b/drivers/filesystems/ext2/src/memory.c > index 8915dfeccb..cf569f40cd 100644 > --- a/drivers/filesystems/ext2/src/memory.c > +++ b/drivers/filesystems/ext2/src/memory.c > @@ -2072,9 +2072,9 @@ Ext2ParseRegistryVolumeParams( > > USHORT i, j, k; > > - RtlZeroMemory(Codepage, CODEPAGE_MAXLEN); > - RtlZeroMemory(Prefix, HIDINGPAT_LEN); > - RtlZeroMemory(Suffix, HIDINGPAT_LEN); > + RtlZeroMemory(Codepage, sizeof(WCHAR) * CODEPAGE_MAXLEN); > + RtlZeroMemory(Prefix, sizeof(WCHAR) * HIDINGPAT_LEN); > + RtlZeroMemory(Suffix, sizeof(WCHAR) * HIDINGPAT_LEN); > RtlZeroMemory(MountPoint, sizeof(USHORT) * 4); > RtlZeroMemory(DrvLetter, sizeof(CHAR) * 4); > > -- Pierre Schweitzer <pierre at reactos.org> System & Network Administrator Senior Kernel Developer ReactOS Deutschland e.V.

1 0

Tibor Popper (Sumi), Google GSoC 2019
by Tibor Popper 24 Mar '19

24 Mar '19

Hello Everyone!! Im Tibor Popper from Hungary, somewhere at middle of Europe :). I want to apply in Google GSoC at this year, also I wanna be co-developer of ReactOS project. I'm really exited about Operating System programming right now, atleast for training myself? I dont really know, but more prefer to make some new functions or fixes for ReactOS to really make this project better, and really useful. Like.: UEFI boot, Kernel expansion, Graphics. Im especially advanced in grafical programming with DirectX 11 / 12, but maybe more with OpenGL 4+. I was developer of video games in some little company, mainly for Windows, with Unreal Engine, Unity, I cant tell about more. I didnt finished University of Pécs, with Engineering IT (BSc), but I have Software Developer occupation. My main programming language is C++, but not limited to others. I have started to look half year before how UEFI works in general to start write EFI programs, but I abandoned this studying, + some OS from sctratch tutorials :) … I really love to make things work! I love optimal and nice looking code, performance, software design, functionality. I love to understand HOW things work, I can take really much time discover these things, like in Physics, also love that too. Greetings, regards, Sumi!

1 0

Re: [ros-dev] [ros-diffs] [reactos] 01/01: [MSI] Allow to pass product key validation check
by Thomas Faber 20 Mar '19

20 Mar '19

This causes a test failure... https://reactos.org/testman/diff.php?id1=41900790&id2=41904063&type=1&strip… On 2019-03-19 23:06, Stanislav Motylkov wrote: > https://git.reactos.org/?p=reactos.git;a=commitdiff;h=8e05f5509c4baa4df9d54… > > commit 8e05f5509c4baa4df9d543620d5da9552c18f25f > Author: Stanislav Motylkov <x86corez(a)gmail.com> > AuthorDate: Mon Mar 18 01:14:46 2019 +0300 > Commit: Hermès BÉLUSCA - MAÏTO <hermes.belusca-maito(a)reactos.org> > CommitDate: Tue Mar 19 23:05:57 2019 +0100 > > [MSI] Allow to pass product key validation check > > CORE-14710 CORE-15864 > --- > dll/win32/msi/action.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/dll/win32/msi/action.c b/dll/win32/msi/action.c > index 3909246869..0eef96a89c 100644 > --- a/dll/win32/msi/action.c > +++ b/dll/win32/msi/action.c > @@ -7448,7 +7448,11 @@ UINT msi_validate_product_id( MSIPACKAGE *package ) > if (key && template) > { > FIXME( "partial stub: template %s key %s\n", debugstr_w(template), debugstr_w(key) ); > +#ifdef __REACTOS__ > + WARN("Product key validation HACK, see CORE-14710\n"); > +#else > r = msi_set_property( package->db, szProductID, key, -1 ); > +#endif > } > msi_free( template ); > msi_free( key ); >

2 1

Re: [ros-dev] [ros-diffs] [reactos] 01/01: [FREETYPE] Fix 3 regressions in one patch
by Pierre Schweitzer 12 Mar '19

12 Mar '19

Hi, This commit broke HEAD; both VBox & KVM regtesters are red. Either fix this commit or revert it. In the meantime, please refrain from pushing to HEAD. Cheers, Pierre Le 11/03/2019 à 20:11, Joachim Henze a écrit : > https://git.reactos.org/?p=reactos.git;a=commitdiff;h=98b7ecd280c0f641d4593… > > commit 98b7ecd280c0f641d4593c8ba792b463a5117550 > Author: Joachim Henze <Joachim.Henze(a)reactos.org> > AuthorDate: Mon Mar 11 20:10:14 2019 +0100 > Commit: Joachim Henze <Joachim.Henze(a)reactos.org> > CommitDate: Mon Mar 11 20:10:14 2019 +0100 > > [FREETYPE] Fix 3 regressions in one patch > > Fixes regression CORE-15785 (Zim Desktop Wiki 0.67 crashed) and > Fixes regression CORE-15755 (NLite 1.4.9.3 used wrong font) > > without reintroducing regression CORE-15558 (AbiWord 2.6.8 font enumeration) > > This is achieved by partial revert of > 0.4.12-dev-320-g > 6e4e5a004c9da6276695d90187fb577812e8892f > and got ack of Katayama Hirofumi MZ. > > Thanks to patches author Doug Lyons. > Test-results: https://reactos.org/testman/compare.php?ids=66264,66267 > --- > win32ss/gdi/ntgdi/freetype.c | 196 +++++++++++++++++++++++++++++++++---------- > 1 file changed, 152 insertions(+), 44 deletions(-) > > diff --git a/win32ss/gdi/ntgdi/freetype.c b/win32ss/gdi/ntgdi/freetype.c > index 7005057a077..4f58f030f27 100644 > --- a/win32ss/gdi/ntgdi/freetype.c > +++ b/win32ss/gdi/ntgdi/freetype.c > @@ -2244,6 +2244,73 @@ IntGetOutlineTextMetrics(PFONTGDI FontGDI, > return Cache->OutlineRequiredSize; > } > > +static PFONTGDI FASTCALL > +FindFaceNameInList(PUNICODE_STRING FaceName, PLIST_ENTRY Head) > +{ > + PLIST_ENTRY Entry; > + PFONT_ENTRY CurrentEntry; > + ANSI_STRING EntryFaceNameA; > + UNICODE_STRING EntryFaceNameW; > + FONTGDI *FontGDI; > + NTSTATUS status; > + > + for (Entry = Head->Flink; Entry != Head; Entry = Entry->Flink) > + { > + CurrentEntry = CONTAINING_RECORD(Entry, FONT_ENTRY, ListEntry); > + > + FontGDI = CurrentEntry->Font; > + ASSERT(FontGDI); > + > + RtlInitAnsiString(&EntryFaceNameA, FontGDI->SharedFace->Face->family_name); > + status = RtlAnsiStringToUnicodeString(&EntryFaceNameW, &EntryFaceNameA, TRUE); > + if (!NT_SUCCESS(status)) > + { > + break; > + } > + > + if ((LF_FACESIZE - 1) * sizeof(WCHAR) < EntryFaceNameW.Length) > + { > + EntryFaceNameW.Length = (LF_FACESIZE - 1) * sizeof(WCHAR); > + EntryFaceNameW.Buffer[LF_FACESIZE - 1] = L'\0'; > + } > + > + if (RtlEqualUnicodeString(FaceName, &EntryFaceNameW, TRUE)) > + { > + RtlFreeUnicodeString(&EntryFaceNameW); > + return FontGDI; > + } > + > + RtlFreeUnicodeString(&EntryFaceNameW); > + } > + > + return NULL; > +} > + > +static PFONTGDI FASTCALL > +FindFaceNameInLists(PUNICODE_STRING FaceName) > +{ > + PPROCESSINFO Win32Process; > + PFONTGDI Font; > + > + /* Search the process local list. > + We do not have to search the 'Mem' list, since those fonts are linked in the PrivateFontListHead */ > + Win32Process = PsGetCurrentProcessWin32Process(); > + IntLockProcessPrivateFonts(Win32Process); > + Font = FindFaceNameInList(FaceName, &Win32Process->PrivateFontListHead); > + IntUnLockProcessPrivateFonts(Win32Process); > + if (NULL != Font) > + { > + return Font; > + } > + > + /* Search the global list */ > + IntLockGlobalFonts(); > + Font = FindFaceNameInList(FaceName, &g_FontListHead); > + IntUnLockGlobalFonts(); > + > + return Font; > +} > + > /* See https://msdn.microsoft.com/en-us/library/bb165625(v=vs.90).aspx */ > static BYTE > CharSetFromLangID(LANGID LangID) > @@ -2670,10 +2737,67 @@ FontFamilyFillInfo(PFONTFAMILYINFO Info, LPCWSTR FaceName, > Info->NewTextMetricEx.ntmFontSig = fs; > } > > +static int FASTCALL > +FindFaceNameInInfo(PUNICODE_STRING FaceName, PFONTFAMILYINFO Info, DWORD InfoEntries) > +{ > + DWORD i; > + UNICODE_STRING InfoFaceName; > + > + for (i = 0; i < InfoEntries; i++) > + { > + RtlInitUnicodeString(&InfoFaceName, Info[i].EnumLogFontEx.elfLogFont.lfFaceName); > + if (RtlEqualUnicodeString(&InfoFaceName, FaceName, TRUE)) > + { > + return i; > + } > + } > + > + return -1; > +} > + > +static BOOLEAN FASTCALL > +FontFamilyInclude(LPLOGFONTW LogFont, PUNICODE_STRING FaceName, > + PFONTFAMILYINFO Info, DWORD InfoEntries) > +{ > + UNICODE_STRING LogFontFaceName; > + > + RtlInitUnicodeString(&LogFontFaceName, LogFont->lfFaceName); > + if (0 != LogFontFaceName.Length && > + !RtlEqualUnicodeString(&LogFontFaceName, FaceName, TRUE)) > + { > + return FALSE; > + } > + > + return FindFaceNameInInfo(FaceName, Info, InfoEntries) < 0; > +} > + > +static BOOL FASTCALL > +FontFamilyFound(PFONTFAMILYINFO InfoEntry, > + PFONTFAMILYINFO Info, DWORD InfoCount) > +{ > + LPLOGFONTW plf1 = &InfoEntry->EnumLogFontEx.elfLogFont; > + LPWSTR pFullName1 = InfoEntry->EnumLogFontEx.elfFullName; > + LPWSTR pFullName2; > + DWORD i; > + > + for (i = 0; i < InfoCount; ++i) > + { > + LPLOGFONTW plf2 = &Info[i].EnumLogFontEx.elfLogFont; > + if (plf1->lfCharSet != plf2->lfCharSet) > + continue; > + > + pFullName2 = Info[i].EnumLogFontEx.elfFullName; > + if (_wcsicmp(pFullName1, pFullName2) != 0) > + continue; > + > + return TRUE; > + } > + return FALSE; > +} > + > static BOOLEAN FASTCALL > GetFontFamilyInfoForList(LPLOGFONTW LogFont, > PFONTFAMILYINFO Info, > - LPCWSTR NominalName, > DWORD *pCount, > DWORD MaxCount, > PLIST_ENTRY Head) > @@ -2700,38 +2824,28 @@ GetFontFamilyInfoForList(LPLOGFONTW LogFont, > { > if (Count < MaxCount) > { > - FontFamilyFillInfo(&Info[Count], NominalName, NULL, FontGDI); > + FontFamilyFillInfo(&Info[Count], NULL, NULL, FontGDI); > } > Count++; > continue; > } > > - FontFamilyFillInfo(&InfoEntry, NominalName, NULL, FontGDI); > + FontFamilyFillInfo(&InfoEntry, NULL, NULL, FontGDI); > > - if (NominalName) > + if (_wcsnicmp(LogFont->lfFaceName, InfoEntry.EnumLogFontEx.elfLogFont.lfFaceName, RTL_NUMBER_OF(LogFont->lfFaceName)-1) != 0 && > + _wcsnicmp(LogFont->lfFaceName, InfoEntry.EnumLogFontEx.elfFullName, RTL_NUMBER_OF(LogFont->lfFaceName)-1) != 0) > { > - RtlStringCchCopyW(InfoEntry.EnumLogFontEx.elfLogFont.lfFaceName, > - RTL_NUMBER_OF(InfoEntry.EnumLogFontEx.elfLogFont.lfFaceName), > - NominalName); > + continue; > } > - else > + > + if (!FontFamilyFound(&InfoEntry, Info, min(Count, MaxCount))) > { > - if (_wcsnicmp(LogFont->lfFaceName, > - InfoEntry.EnumLogFontEx.elfLogFont.lfFaceName, > - RTL_NUMBER_OF(LogFont->lfFaceName) - 1) != 0 && > - _wcsnicmp(LogFont->lfFaceName, > - InfoEntry.EnumLogFontEx.elfFullName, > - RTL_NUMBER_OF(LogFont->lfFaceName) - 1) != 0) > + if (Count < MaxCount) > { > - continue; > + RtlCopyMemory(&Info[Count], &InfoEntry, sizeof(InfoEntry)); > } > + Count++; > } > - > - if (Count < MaxCount) > - { > - RtlCopyMemory(&Info[Count], &InfoEntry, sizeof(InfoEntry)); > - } > - Count++; > } > > *pCount = Count; > @@ -2747,9 +2861,10 @@ GetFontFamilyInfoForSubstitutes(LPLOGFONTW LogFont, > { > PLIST_ENTRY pEntry, pHead = &g_FontSubstListHead; > PFONTSUBST_ENTRY pCurrentEntry; > - PUNICODE_STRING pFromW, pToW; > + PUNICODE_STRING pFromW; > + FONTGDI *FontGDI; > LOGFONTW lf = *LogFont; > - PPROCESSINFO Win32Process = PsGetCurrentProcessWin32Process(); > + UNICODE_STRING NameW; > > for (pEntry = pHead->Flink; pEntry != pHead; pEntry = pEntry->Flink) > { > @@ -2758,32 +2873,25 @@ GetFontFamilyInfoForSubstitutes(LPLOGFONTW LogFont, > pFromW = &pCurrentEntry->FontNames[FONTSUBST_FROM]; > if (LogFont->lfFaceName[0] != UNICODE_NULL) > { > - if (_wcsicmp(LogFont->lfFaceName, pFromW->Buffer) != 0) > + if (!FontFamilyInclude(LogFont, pFromW, Info, min(*pCount, MaxCount))) > continue; /* mismatch */ > } > > - pToW = &pCurrentEntry->FontNames[FONTSUBST_TO]; > - if (RtlEqualUnicodeString(pFromW, pToW, TRUE) && > - pCurrentEntry->CharSets[FONTSUBST_FROM] == > - pCurrentEntry->CharSets[FONTSUBST_TO]) > - { > - continue; > - } > - > IntUnicodeStringToBuffer(lf.lfFaceName, sizeof(lf.lfFaceName), pFromW); > SubstituteFontRecurse(&lf); > - if (LogFont->lfCharSet != DEFAULT_CHARSET && LogFont->lfCharSet != lf.lfCharSet) > - continue; > > - IntLockGlobalFonts(); > - GetFontFamilyInfoForList(&lf, Info, pFromW->Buffer, pCount, MaxCount, &g_FontListHead); > - IntUnLockGlobalFonts(); > + RtlInitUnicodeString(&NameW, lf.lfFaceName); > + FontGDI = FindFaceNameInLists(&NameW); > + if (FontGDI == NULL) > + { > + continue; /* no real font */ > + } > > - IntLockProcessPrivateFonts(Win32Process); > - GetFontFamilyInfoForList(&lf, Info, pFromW->Buffer, pCount, MaxCount, > - &Win32Process->PrivateFontListHead); > - IntUnLockProcessPrivateFonts(Win32Process); > - break; > + if (*pCount < MaxCount) > + { > + FontFamilyFillInfo(&Info[*pCount], pFromW->Buffer, NULL, FontGDI); > + } > + (*pCount)++; > } > > return TRUE; > @@ -5426,7 +5534,7 @@ NtGdiGetFontFamilyInfo(HDC Dc, > /* Enumerate font families in the global list */ > IntLockGlobalFonts(); > Count = 0; > - if (! GetFontFamilyInfoForList(&LogFont, Info, NULL, &Count, Size, &g_FontListHead) ) > + if (! GetFontFamilyInfoForList(&LogFont, Info, &Count, Size, &g_FontListHead) ) > { > IntUnLockGlobalFonts(); > ExFreePoolWithTag(Info, GDITAG_TEXT); > @@ -5437,7 +5545,7 @@ NtGdiGetFontFamilyInfo(HDC Dc, > /* Enumerate font families in the process local list */ > Win32Process = PsGetCurrentProcessWin32Process(); > IntLockProcessPrivateFonts(Win32Process); > - if (! GetFontFamilyInfoForList(&LogFont, Info, NULL, &Count, Size, > + if (! GetFontFamilyInfoForList(&LogFont, Info, &Count, Size, > &Win32Process->PrivateFontListHead)) > { > IntUnLockProcessPrivateFonts(Win32Process); > -- Pierre Schweitzer <pierre at reactos.org> System & Network Administrator Senior Kernel Developer ReactOS Deutschland e.V.

1 0

Proposal for GSOC
by Akshay Patil 07 Mar '19

07 Mar '19

Hello everyone, I am Akshay Patil, a 3rd year undergraduate student studying Computer Science in VIIT, Pune, India. I have been trying React OS for a while now and found it really interesting. I love open source. I want to contribute for the project "*Applications Manager Rapps*" through Google summer of Code 2019. I have been using C++ launguage for 5 years and also made some applications like user control app. I am sure tthat the experience I ganied from last few years will certainly help me in understanding the Rapps Code easily. We will figure out the concrete goals of the project and the decided the plan for the project with the mentor. It'll be great if somebody, could mentor me for this project. Thanks, Akshay Patil

2 1

ReactOS 0.4.11 to be released tomorrow, March 4, 2019 - Press Kit is online!
by Colin Finck 03 Mar '19

03 Mar '19

Hi all! ReactOS 0.4.11 is going to be released tomorrow, Monday, March 4, 2019. The download will be officially available around noon (CEST). A Press Kit for the ReactOS 0.4.11 release is already available: https://download.reactos.org/reactos/ReactOS/0.4.11/ReactOS-0.4.11-PressKit… Feel free to send it to interested parties to let them know about the upcoming release in advance. Best regards, Colin Finck

2 1

Fwd: [ReactOS Chat] Notification in ReactOS on March 1, 2019
by Javier Agustìn Fernàndez Arroyo 01 Mar '19

01 Mar '19

They do! ---------- Forwarded message --------- From: <chat(a)reactos.org> Date: vie., 1 mar. 2019 18:30 Subject: [ReactOS Chat] Notification in ReactOS on March 1, 2019 To: <elhoir(a)gmail.com> You have a new notification. Channel: Town Square @Colin Finck - 17:30 UTC, March 1 @all Mattermost E-Mail notifications should finally work now :) Go To Post <https://chat.reactos.org/reactos/pl/54gbdt6h63rz8j5tqbmtg3wkpc> Any questions at all, mail us any time: feedback(a)mattermost.com Best wishes, The ReactOS Chat Team To change your notification preferences, log in to your team site and go to Account Settings > Notifications.

1 0

Status Meeting (February 2019)
by Colin Finck 26 Feb '19

26 Feb '19

Hi all! Let me invite you to the February 2019 meeting, taking place this Thursday, February 28, 19:00 UTC. It will again happen in the private "Meeting" channel on our Mattermost server at https://chat.reactos.org. The current agenda is as follows: * Status Updates ============== As always, please have your status report ready before the meeting, so that we can get this done quickly. * Google Summer of Code 2019 ========================== Google is about to announce the list of participating organizations today, so we should prepare to spread the word and soon answer lots of questions from interested students. * 0.4.11 ====== Let's quickly update everyone on the state of the 0.4.11 release and the changelog in order to get it out soon. As always, please let me know if you want anything to be added to the agenda. Cheers, Colin

1 0

Gsoc 19
by Ayush Sinha 18 Feb '19

18 Feb '19

Hey there ! I am really interested to work with your organization.I am interested in Web development projects, Went through the reactOS GSOC’19 page. I am interested in making the web interface for reactos which can show all GitHub reactos repos, commits, etc using the GitHub API. (https://www.reactos.org/wiki/Google_Summer_of_Code_2019_Ideas#Developer_Web…) Looking forward to work on the same idea for GSOC’19 under your mentorship. Currently I am reading the api documentation and trying to implement some basic stuffs using nodeJS, till now I have created a web app that can list all reactOs repositories and related information. Webapp link: https://github-userinterface.herokuapp.com/ GitHub repo: https://github.com/ayushsnha/UserInterface-with-Github-RESTapiV3 kindly review the link. All suggestions are welcomed Thanks Ayush Kumar Sinha 2nd year bachelor of cs, VIT University, India

2 1

Fwd: CLT 2019.... And here he is again, going on your nerves ^^
by Daniel Reimer 11 Feb '19

11 Feb '19

Last time. Please add your name, anyone still not done it. I have to confirm on Feb 10th Daniel Reimer <daniel.reimer(a)reactos.org> schrieb am Mo, 21.01.2019 21:49: > Hello and good evening, > > as some of you might already know, we are close to CLT 2019 again: > https://chemnitzer.linux-tage.de/2019/de > > For lazy ones: 16-17.03. in Chemnitz (YES, germany that is) > > As every year I need at least two, better three ppl for maintaining the > booth. This time I will not wait until we really got accepted just to > hear from everyone a nope, or not sure yet way too late in the phase. > This resulted in asking the community for help (which is a good thing > tbh) and that resulted in some bored and feelin useless supporter in the > end. Why? Well, a few days before the whole thing took part I suddently > had enough main/core members and thus he just sat there and had nothing > to do. STILL A BIG SORRY FROM MY SIDE!! > > I don't wanna have this happening once more that year. Thus.... check > the weekend, ways to get there and back home and then reply to the > doodle. Costs to get there are as always a thing we can talk about > compensation and stuff. If you need to talk about CLT stuff, feel free > to reply here of course ^^ > > So... lets hope I have the right link: > https://doodle.com/poll/krmz8ktt8r85m5y4 > > Greetings > > Daniel Reimer

2 1

Please avoid merges to master
by Thomas Faber 28 Jan '19

28 Jan '19

master has been broken for days. Until this issue is fixed, no test results are going to make it to Testman, which means any regressions are going to be extremely hard to track down. Here's the issue to follow: https://jira.reactos.org/browse/CORE-15642 Unless you have something that might fix this, I would ask that you hold off on merging things until this bug is fixed. Thanks, Thomas

1 1

Re: [ros-dev] [ros-diffs] [reactos] 02/02: [MOUNTMGR][MUP] Use global definition of INIT_FUNCTION/INIT_SECTION (Addendum to 71fefa32).
by Michael Fritscher 27 Jan '19

27 Jan '19

Moin, this commit causes https://build.reactos.org/builders/Build%20MSVC_x86/builds/13087/steps/comp… : FAILED: C:\PROGRA~2\MICROS~1.0\VC\bin\cl.exe /nologo -D__RELFILE__="&__FILE__[__FILE__[0] == '.' ? sizeof \"C:/Buildslave/Build_MSVC_x86/build\" - 1 : sizeof REACTOS_SOURCE_DIR]" /Ob0 /Od /GF /Gy /X /Zl /GR- /EHs-c- /GS- /arch:IA32 /FS /W3 /wd4244 /wd4290 /wd4800 /wd4200 /wd4214 /wd4018 /we4013 /we4020 /we4022 /we4047 /we4098 /we4113 /we4129 /we4163 /we4229 /we4700 /we4603 /we4716 /we4028 /we4189 /w14115 /Zi /hotpatch -Idrivers\filters\mountmgr -IC:\Buildslave\Build_MSVC_x86\build\drivers\filters\mountmgr -IC:\Buildslave\Build_MSVC_x86\build\sdk\include -IC:\Buildslave\Build_MSVC_x86\build\sdk\include\psdk -IC:\Buildslave\Build_MSVC_x86\build\sdk\include\dxsdk -Isdk\include -Isdk\include\psdk -Isdk\include\dxsdk -Isdk\include\ddk -Isdk\include\reactos -Isdk\include\reactos\mc -IC:\Buildslave\Build_MSVC_x86\build\sdk\include\crt -IC:\Buildslave\Build_MSVC_x86\build\sdk\include\ddk -IC:\Buildslave\Build_MSVC_x86\build\sdk\include\ndk -IC:\Buildslave\Build_MSVC_x86\build\sdk\include\reactos -IC:\Buildslave\Build_MSVC_x86\build\sdk\include\reactos\libs -DREACTOS_SOURCE_DIR="\"C:/Buildslave/Build_MSVC_x86/build\"" -DREACTOS_BINARY_DIR="\"R:/buildbot/output-VS-i386\"" /FIR:/buildbot/output-VS-i386/drivers/filters/mountmgr/mountmgr.pch /YuR:/buildbot/output-VS-i386/drivers/filters/mountmgr/mountmgr.pch /showIncludes -DDBG=1 -DUSE_COMPILER_EXCEPTIONS -DWIN32 -DWINVER=0x502 -D_M_IX86 -D_SEH_ENABLE_TRACE -D_SETUPAPI_VER=0x502 -D_USE_32BIT_TIME_T -D_WIN32_IE=0x600 -D_WIN32_WINDOWS=0x502 -D_WIN32_WINNT=0x502 -D_WINDOWS -D_WINKD_=1 -D_X86_ -D__REACTOS__ -D__STDC__=1 -D__i386__ -Di386 -Dinline=__inline -Dmountmgr_EXPORTS /Fodrivers\filters\mountmgr\CMakeFiles\mountmgr.dir\mountmgr.c.obj /Fddrivers\filters\mountmgr\CMakeFiles\mountmgr.dir\ /FS -c C:\Buildslave\Build_MSVC_x86\build\drivers\filters\mountmgr\mountmgr.c C:\Buildslave\Build_MSVC_x86\build\drivers\filters\mountmgr\mountmgr.c(1810) : error C2983: 'DriverEntry' : all declarations must have an identical __declspec(code_seg(...)) C:\Buildslave\Build_MSVC_x86\build\drivers\filters\mountmgr\mntmgr.h(179) : see declaration of 'DriverEntry' Best regards, Michael Fritscher On 27.01.19 02:37, Hermès Bélusca-Maïto wrote: > https://git.reactos.org/?p=reactos.git;a=commitdiff;h=53abbb06b532fd052d575… > > commit 53abbb06b532fd052d575231a219ca5683e05514 > Author: Hermès Bélusca-Maïto <hermes.belusca-maito(a)reactos.org> > AuthorDate: Sun Jan 27 02:34:20 2019 +0100 > Commit: Hermès Bélusca-Maïto <hermes.belusca-maito(a)reactos.org> > CommitDate: Sun Jan 27 02:40:11 2019 +0100 > > [MOUNTMGR][MUP] Use global definition of INIT_FUNCTION/INIT_SECTION (Addendum to 71fefa32). > --- > drivers/filesystems/mup/dfs.h | 9 +-------- > drivers/filters/mountmgr/mntmgr.h | 9 ++------- > drivers/filters/mountmgr/mountmgr.c | 4 ++-- > 3 files changed, 5 insertions(+), 17 deletions(-) > > diff --git a/drivers/filesystems/mup/dfs.h b/drivers/filesystems/mup/dfs.h > index d158a055ab..49194bdc7f 100644 > --- a/drivers/filesystems/mup/dfs.h > +++ b/drivers/filesystems/mup/dfs.h > @@ -1,14 +1,7 @@ > #ifndef _DFS_PCH_ > #define _DFS_PCH_ > > -#ifndef INIT_SECTION > -#ifdef __GNUC__ > -#define INIT_SECTION __attribute__((section ("INIT"))) > -#else > -#define INIT_SECTION /* Done via alloc_text for MSC */ > -#endif > -#define INIT_FUNCTION INIT_SECTION > -#endif > +#include <section_attribs.h> > > #define DFS_OPEN_CONTEXT 0xFF444653 > #define DFS_DOWNLEVEL_OPEN_CONTEXT 0x11444653 > diff --git a/drivers/filters/mountmgr/mntmgr.h b/drivers/filters/mountmgr/mntmgr.h > index 4153add678..dacbfa7d69 100644 > --- a/drivers/filters/mountmgr/mntmgr.h > +++ b/drivers/filters/mountmgr/mntmgr.h > @@ -8,12 +8,7 @@ > #include <wdmguid.h> > #include <ndk/psfuncs.h> > #include <ntdddisk.h> > - > -#ifdef __GNUC__ > -#define INIT_SECTION __attribute__((section ("INIT"))) > -#else > -#define INIT_SECTION /* Done via alloc_text for MSC */ > -#endif > +#include <section_attribs.h> > > typedef struct _DEVICE_EXTENSION > { > @@ -233,7 +228,7 @@ HasDriveLetter( > IN PDEVICE_INFORMATION DeviceInformation > ); > > -INIT_SECTION > +INIT_FUNCTION > BOOLEAN > MountmgrReadNoAutoMount( > IN PUNICODE_STRING RegistryPath > diff --git a/drivers/filters/mountmgr/mountmgr.c b/drivers/filters/mountmgr/mountmgr.c > index 0e273b3957..0b2fe8e7ba 100644 > --- a/drivers/filters/mountmgr/mountmgr.c > +++ b/drivers/filters/mountmgr/mountmgr.c > @@ -908,7 +908,7 @@ MountMgrUnload(IN struct _DRIVER_OBJECT *DriverObject) > /* > * @implemented > */ > -INIT_SECTION > +INIT_FUNCTION > BOOLEAN > MountmgrReadNoAutoMount(IN PUNICODE_STRING RegistryPath) > { > @@ -1802,7 +1802,7 @@ MountMgrShutdown(IN PDEVICE_OBJECT DeviceObject, > > /* FUNCTIONS ****************************************************************/ > > -INIT_SECTION > +INIT_FUNCTION > NTSTATUS > NTAPI > DriverEntry(IN PDRIVER_OBJECT DriverObject, >

1 0

New CI investigation
by Victor Perevertkin 24 Jan '19

24 Jan '19

Hi all! I've done some research on what can we do to improve our CI system. First of all, I want to clarify: our CI is consists of two parts: building and testing. I'm assuming here that "build" part is OK for us and doesn't require any improvements in workflow or something like that. So focusing only on "testing" part. I tried to find some solutions similar to our testman, but the things are very bad on this side. - There are some plugins for Jenkins which show a table with test results by each build - Microsoft TFS has functionality for storing tests and doing some analysis on them, but that's a no-go for us - Jetbrains' TeamCity also has this thing and has a license for Open Source I use Jetbrains tools at work and like this company in general :) so I decided make some experiments with it. Some facts: - It has out-of-the-box integration with Jira and Github. It works flawlessly (bonus: you can automatically build and test all PRs from team members, for example) - Integration with GitHub Checks (that green checkmark which for us comes from Travis&Appveyor right now) - Has an interface for filtering test results by module, shows execution time, some statistics etc. - Uses JVM for work :) Both master and slave part - PostgreSQL, MySQL and some built-in DB can be used for storage - Uses own DSL, derived from Kothlin language for configuration (but allows configuring through GUI too) Adopting iso build didn't have any issues, it just works. But testing requires some work: - sysreg2 and rosautotest should be changed to output results in some format which TeamCity understands. It can be jUnit, Google test or teamcity's own format - TeamCity has only three states of test: success, failure or crash. This does not fit with our current scheme based on succeed and failed ok()'s count - TeamCity can't compare test results between random builds like our testman. It only can show "tests which failed in this build, but didn't fail in previous one". But if we want something more, we can use their API While looking into the way how our tests work, I've found that by "test" we mean a function defined my START_TEST macro, which does some reporting to sysreg. But each START_TEST function likely has a couple of further test_* calls, which are not reported in any way. This is a place where the granularity of reporting can be increased :) Attaching some screenshots of how it look like in general. https://drive.google.com/open?id=17r4PSFmsi2tiF97HHbYGiMCOoKR7VMUF So far we have to decide what to do now. An options can be: - Go on with adopting test&build infrastructure to TeamCity - we will migrate to it eventually - We are not going to use TeamCity - somebody should develop a custom web interface to consolidate everything ( https://www.reactos.org/wiki/Google_Summer_of_Code_2019_Ideas#Developer_Web… ) - Just migrate to new BuildBot (can be done with along with previous option) - Don't do anything Looking forward to discuss this on the meeting Cheers, Victor

1 0

Re: [ros-dev] [ros-diffs] [reactos] 01/01: [CDFS] Make windows gcc release build compile, regression CORE-15659
by Pierre Schweitzer 22 Jan '19

22 Jan '19

Your #endif is misplaced. INLINE is part of the original source code. Le 22/01/2019 à 18:50, Joachim Henze a écrit : > https://git.reactos.org/?p=reactos.git;a=commitdiff;h=bccad87f3ccf266be2179… > > commit bccad87f3ccf266be2179d1322e7a422aeb2f3b7 > Author: Joachim Henze <Joachim.Henze(a)reactos.org> > AuthorDate: Tue Jan 22 18:49:51 2019 +0100 > Commit: Joachim Henze <Joachim.Henze(a)reactos.org> > CommitDate: Tue Jan 22 18:49:51 2019 +0100 > > [CDFS] Make windows gcc release build compile, regression CORE-15659 > --- > drivers/filesystems/cdfs/cdprocs.h | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/filesystems/cdfs/cdprocs.h b/drivers/filesystems/cdfs/cdprocs.h > index 1d788b28e1..4cff63837a 100644 > --- a/drivers/filesystems/cdfs/cdprocs.h > +++ b/drivers/filesystems/cdfs/cdprocs.h > @@ -1836,7 +1836,10 @@ CdRaiseStatusEx ( > > #else > > +#ifdef __REACTOS__ > +static // make windows gcc release build compile > INLINE > +#endif > DECLSPEC_NORETURN > VOID > CdRaiseStatusEx( > -- Pierre Schweitzer <pierre at reactos.org> System & Network Administrator Senior Kernel Developer ReactOS Deutschland e.V.

1 0

CLT 2019.... And here he is again, going on your nerves ^^
by Daniel Reimer 21 Jan '19

21 Jan '19

Hello and good evening, as some of you might already know, we are close to CLT 2019 again: https://chemnitzer.linux-tage.de/2019/de For lazy ones: 16-17.03. in Chemnitz (YES, germany that is) As every year I need at least two, better three ppl for maintaining the booth. This time I will not wait until we really got accepted just to hear from everyone a nope, or not sure yet way too late in the phase. This resulted in asking the community for help (which is a good thing tbh) and that resulted in some bored and feelin useless supporter in the end. Why? Well, a few days before the whole thing took part I suddently had enough main/core members and thus he just sat there and had nothing to do. STILL A BIG SORRY FROM MY SIDE!! I don't wanna have this happening once more that year. Thus.... check the weekend, ways to get there and back home and then reply to the doodle. Costs to get there are as always a thing we can talk about compensation and stuff. If you need to talk about CLT stuff, feel free to reply here of course ^^ So... lets hope I have the right link: https://doodle.com/poll/krmz8ktt8r85m5y4 Greetings Daniel Reimer

1 0

Status Meeting (January 2019) - Now on Mattermost!
by Colin Finck 20 Jan '19

20 Jan '19

Hi all! As announced previously (https://reactos.org/pipermail/ros-dev/2019-January/019044.html), we'll be having the January meeting already this Thursday, January 24 in order to have enough time for our GSoC application. The meeting will also take place on our new Mattermost at https://chat.reactos.org for the first time! So let me invite you to this meeting, taking place again at 19:00 UTC. If you haven't tried Mattermost yet, please log in to chat.reactos.org now using your ReactOS.org credentials. Only then I can add you to our new private "Meeting" channel. This one will not be bridged to IRC! I will already start adding people to this channel now, so that the meeting can start on time. If you have the feeling that I forgot about you, please let me know timely. The current agenda is as follows: * Status Updates ============== As always, please have your status report ready before the meeting, so that we can get this done quickly. * Mattermost ========== I need to know your opinion about Mattermost and whether you think that we should continue using it beyond our trial (ending mid- February). This would require an enterprise license for non-profits ($250 per three years). * Google Summer of Code 2019 ========================== The list at https://reactos.org/wiki/Google_Summer_of_Code_2019 still doesn't show a single mentor. And https://reactos.org/wiki/Google_Summer_of_Code_2019_Ideas certainly also needs some polishing. Let's finally make up our minds regarding this year's GSoC, so that we can submit our project application. I would highly appreciate if people updated those Wiki pages before the meeting. This could potentially save us hours of discussions and finding volunteers :) Let me know if you want anything to be added to the agenda. Cheers, Colin

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev