- Ros-dev - ReactOS.org

Re: [ros-dev] [ros-diffs] [hbelusca] 60250: [KERNEL32]: Reenable two dprints to be able to know how programs are launched with which parameters and so on...
by Alex Ionescu 21 Sep '13

21 Sep '13

Please don't do this. There's no reason this has to be on for all applications, and it wasn't before. Use DbgPrintEx for this and setup your filter in the debugger/KDBG appropriately. Best regards, Alex Ionescu On Fri, Sep 20, 2013 at 6:12 PM, <hbelusca(a)svn.reactos.org> wrote: > Author: hbelusca > Date: Fri Sep 20 22:12:08 2013 > New Revision: 60250 > > URL: http://svn.reactos.org/svn/reactos?rev=60250&view=rev > Log: > [KERNEL32]: Reenable two dprints to be able to know how programs are > launched with which parameters and so on... > > Modified: > trunk/reactos/dll/win32/kernel32/client/proc.c > > Modified: trunk/reactos/dll/win32/kernel32/client/proc.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/kernel32/client/… > > ============================================================================== > --- trunk/reactos/dll/win32/kernel32/client/proc.c [iso-8859-1] > (original) > +++ trunk/reactos/dll/win32/kernel32/client/proc.c [iso-8859-1] Fri > Sep 20 22:12:08 2013 > @@ -629,10 +629,10 @@ > > /* Create the Parameter Block */ > ProcessParameters = NULL; > - DPRINT("ImageName: '%wZ'\n", &ImageName); > + DPRINT1("ImageName: '%wZ'\n", &ImageName); > DPRINT("DllPath : '%wZ'\n", &DllPath); > DPRINT("CurDir : '%wZ'\n", &CurrentDirectory); > - DPRINT("CmdLine : '%wZ'\n", &CommandLine); > + DPRINT1("CmdLine : '%wZ'\n", &CommandLine); > DPRINT("Title : '%wZ'\n", &Title); > DPRINT("Desktop : '%wZ'\n", &Desktop); > DPRINT("Shell : '%wZ'\n", &Shell); > > >

2 1

[ros-diffs] [tfaber] 60231: [NPFS] - Release cancel spinlock in NpCancelListeningQueueIrp
by Hermès BÉLUSCA - MAÏTO 20 Sep '13

20 Sep '13

I think a call to IoReleaseCancelSpinLock should be balanced with a call to IoAcquireCancelSpinLock somewhere in the npfs_new code, however, looking at: http://git.reactos.org/?p=reactos.git <http://git.reactos.org/?p=reactos.git&a=search&h=HEAD&st=grep&s=IoAcquireCa ncelSpinLock> &a=search&h=HEAD&st=grep&s=IoAcquireCancelSpinLock I dont see any call to IoAcquireCancelSpinLock in npfs_new. Can someone explain to me, why ? Hermès Author: tfaber Date: Fri Sep 20 06:49:21 2013 New Revision: 60231 URL: http://svn.reactos.org/svn/reactos?rev=60231&view=rev Log: [NPFS] - Release cancel spinlock in NpCancelListeningQueueIrp Modified: trunk/reactos/drivers/filesystems/npfs_new/statesup.c Modified: trunk/reactos/drivers/filesystems/npfs_new/statesup.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/npfs_ne w/statesup.c?rev=60231&r1=60230&r2=60231&view=diff ============================================================================ == --- trunk/reactos/drivers/filesystems/npfs_new/statesup.c [iso-8859-1] (original) +++ trunk/reactos/drivers/filesystems/npfs_new/statesup.c [iso-8859-1] Fri Sep 20 06:49:21 2013 @@ -20,6 +20,8 @@ NpCancelListeningQueueIrp(IN PDEVICE_OBJECT DeviceObject, IN PIRP Irp) { + IoReleaseCancelSpinLock(Irp->CancelIrql); + FsRtlEnterFileSystem(); NpAcquireExclusiveVcb();

2 2

Re: [ros-dev] [ros-diffs] [spetreolle] 60221: [ROSSYM] Enable rossym build on MSVC.
by Timo Kreuzer 20 Sep '13

20 Sep '13

Huh? What's the point? You are aware that rossym requires binaries built with GCC? Am 20.09.2013 00:13, schrieb spetreolle(a)svn.reactos.org: > Author: spetreolle > Date: Thu Sep 19 22:13:46 2013 > New Revision: 60221 > > URL: http://svn.reactos.org/svn/reactos?rev=60221&view=rev > Log: > [ROSSYM] > Enable rossym build on MSVC. > > Removed: > trunk/reactos/lib/rossym/dummy.c > trunk/reactos/lib/rossym_new/dummy.c > Modified: > trunk/reactos/lib/rossym/CMakeLists.txt > trunk/reactos/lib/rossym_new/CMakeLists.txt > > Modified: trunk/reactos/lib/rossym/CMakeLists.txt > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/rossym/CMakeLists.txt?… > ============================================================================== > --- trunk/reactos/lib/rossym/CMakeLists.txt [iso-8859-1] (original) > +++ trunk/reactos/lib/rossym/CMakeLists.txt [iso-8859-1] Thu Sep 19 22:13:46 2013 > @@ -1,19 +1,15 @@ > > -if(MSVC) > - add_library(rossym dummy.c) > -else() > - add_definitions(-D_NTSYSTEM_) > - list(APPEND SOURCE > - delete.c > - find.c > - fromfile.c > - frommem.c > - fromraw.c > - getraw.c > - init.c > - initkm.c > - initum.c > - zwfile.c) > - add_library(rossym ${SOURCE}) > - add_dependencies(rossym psdk bugcodes) > -endif() > +add_definitions(-D_NTSYSTEM_) > +list(APPEND SOURCE > + delete.c > + find.c > + fromfile.c > + frommem.c > + fromraw.c > + getraw.c > + init.c > + initkm.c > + initum.c > + zwfile.c) > +add_library(rossym ${SOURCE}) > +add_dependencies(rossym psdk bugcodes) > > Removed: trunk/reactos/lib/rossym/dummy.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/rossym/dummy.c?rev=602… > ============================================================================== > --- trunk/reactos/lib/rossym/dummy.c [iso-8859-1] (original) > +++ trunk/reactos/lib/rossym/dummy.c (removed) > @@ -1,32 +0,0 @@ > - > -#include <ntddk.h> > -#include <reactos/rossym.h> > - > -#define NDEBUG > -#include <debug.h> > - > -BOOLEAN > -RosSymCreateFromFile(PVOID FileContext, PROSSYM_INFO *RosSymInfo) > -{ > - return FALSE; > -} > - > -VOID > -RosSymDelete(PROSSYM_INFO RosSymInfo) > -{ > -} > - > -BOOLEAN > -RosSymGetAddressInformation(PROSSYM_INFO RosSymInfo, > - ULONG_PTR RelativeAddress, > - ULONG *LineNumber, > - char *FileName, > - char *FunctionName) > -{ > - return FALSE; > -} > - > -VOID > -RosSymInitKernelMode(VOID) > -{ > -} > > Modified: trunk/reactos/lib/rossym_new/CMakeLists.txt > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/rossym_new/CMakeLists.… > ============================================================================== > --- trunk/reactos/lib/rossym_new/CMakeLists.txt [iso-8859-1] (original) > +++ trunk/reactos/lib/rossym_new/CMakeLists.txt [iso-8859-1] Thu Sep 19 22:13:46 2013 > @@ -1,26 +1,22 @@ > > -if(MSVC) > - add_library(rossym dummy.c) > -else() > - add_definitions(-D_NTSYSTEM_) > - list(APPEND SOURCE > - delete.c > - dwarfabbrev.c > - dwarfaranges.c > - dwarfcfa.c > - dwarfget.c > - dwarfinfo.c > - dwarfopen.c > - dwarfpc.c > - dwarfpubnames.c > - find.c > - fromfile.c > - init.c > - initum.c > - pe.c > - zwfile.c) > - add_library(rossym ${SOURCE}) > - add_pch(rossym precomp.h) > - add_dependencies(rossym psdk bugcodes) > - allow_warnings(rossym) > -endif() > +add_definitions(-D_NTSYSTEM_) > +list(APPEND SOURCE > + delete.c > + dwarfabbrev.c > + dwarfaranges.c > + dwarfcfa.c > + dwarfget.c > + dwarfinfo.c > + dwarfopen.c > + dwarfpc.c > + dwarfpubnames.c > + find.c > + fromfile.c > + init.c > + initum.c > + pe.c > + zwfile.c) > +add_library(rossym ${SOURCE}) > +add_pch(rossym precomp.h) > +add_dependencies(rossym psdk bugcodes) > +allow_warnings(rossym) > > Removed: trunk/reactos/lib/rossym_new/dummy.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/rossym_new/dummy.c?rev… > ============================================================================== > --- trunk/reactos/lib/rossym_new/dummy.c [iso-8859-1] (original) > +++ trunk/reactos/lib/rossym_new/dummy.c (removed) > @@ -1,60 +0,0 @@ > - > -#include <ntddk.h> > -#include <reactos/rossym.h> > - > -#define NDEBUG > -#include <debug.h> > - > -BOOLEAN > -RosSymCreateFromFile(PVOID FileContext, PROSSYM_INFO *RosSymInfo) > -{ > - UNIMPLEMENTED; > - return FALSE; > -} > - > -VOID > -RosSymDelete(PROSSYM_INFO RosSymInfo) > -{ > - UNIMPLEMENTED; > -} > - > -VOID > -RosSymFreeInfo(PROSSYM_LINEINFO LineInfo) > -{ > - UNIMPLEMENTED; > -} > - > -BOOLEAN > -RosSymGetAddressInformation(PROSSYM_INFO RosSymInfo, > - ULONG_PTR RelativeAddress, > - PROSSYM_LINEINFO RosSymLineInfo) > -{ > - UNIMPLEMENTED; > - return FALSE; > -} > - > -VOID > -RosSymInit(PROSSYM_CALLBACKS Callbacks) > -{ > - UNIMPLEMENTED; > -} > - > -VOID > -RosSymInitKernelMode(VOID) > -{ > - UNIMPLEMENTED; > -} > - > -BOOLEAN > -RosSymAggregate(PROSSYM_INFO RosSymInfo, PCHAR Type, PROSSYM_AGGREGATE Aggregate) > -{ > - UNIMPLEMENTED; > - return FALSE; > -} > - > -VOID > -RosSymFreeAggregate(PROSSYM_AGGREGATE Aggregate) > -{ > - UNIMPLEMENTED; > -} > - > > >

1 0

Fedroa 19 RosBE bfd.texinfo:325: unknown command `colophon'
by James Tabor 18 Sep '13

18 Sep '13

Hi! Testing our build system 2.0 & 2.1 with Fedora 19, gcc version 4.8.1 20130603 (Red Hat 4.8.1-1) , GNU Make 3.82, from the build log, rm -rf $backupdir; exit $rc ../../../binutils/bfd/doc/bfd.texinfo:325: unknown command `colophon' ../../../binutils/bfd/doc/bfd.texinfo:336: unknown command `cygnus' gmake[3]: *** [bfd.info] Error 1 gmake[3]: Leaving directory `/home/RosBE-Unix-2.1/sources/binutils-build/bfd/do gmake[2]: *** [info-recursive] Error 1 gmake[2]: Leaving directory `/home/RosBE-Unix-2.1/sources/binutils-build/bfd' gmake[1]: *** [all-bfd] Error 2 gmake[1]: Leaving directory `/home/RosBE-Unix-2.1/sources/binutils-build' gmake: *** [all] Error 2 Bug report. http://sourceware.org/bugzilla/show_bug.cgi?id=15183 Possible fix, http://www.mail-archive.com/bug-binutils@gnu.org/msg14429.html Is this a know issue? Thanks, James

2 2

Re: [ros-dev] [ros-diffs] [hbelusca] 60193: [SOFT386] - Put inlined functions in a .inl file, which gets included by the corresponding header file (i.e. fix MSVC builds). - Use enums types instead of "only" INTs...
by Thomas Faber 18 Sep '13

18 Sep '13

On 2013-09-18 01:02, hbelusca(a)svn.reactos.org wrote: > Added: > branches/ntvdm/lib/soft386/common.inl (with props) It's a header file. Can you name it .h please to not break syntax highlight? Thanks.

2 1

Re: [ros-dev] [ros-diffs] [aandrejevic] 60187: [SOFT386] Fix hypothetical bug.
by Timo Kreuzer 18 Sep '13

18 Sep '13

Just out of interest: what's that hypothetical bug? Am 17.09.2013 23:15, schrieb aandrejevic(a)svn.reactos.org: > Author: aandrejevic > Date: Tue Sep 17 21:15:52 2013 > New Revision: 60187 > > URL: http://svn.reactos.org/svn/reactos?rev=60187&view=rev > Log: > [SOFT386] > Fix hypothetical bug. > > > Modified: > branches/ntvdm/include/reactos/libs/soft386/soft386.h > > Modified: branches/ntvdm/include/reactos/libs/soft386/soft386.h > URL: http://svn.reactos.org/svn/reactos/branches/ntvdm/include/reactos/libs/soft… > ============================================================================== > --- branches/ntvdm/include/reactos/libs/soft386/soft386.h [iso-8859-1] (original) > +++ branches/ntvdm/include/reactos/libs/soft386/soft386.h [iso-8859-1] Tue Sep 17 21:15:52 2013 > @@ -159,12 +159,15 @@ > > typedef union _SOFT386_REG > { > - struct > + union > { > - UCHAR LowByte; > - UCHAR HighByte; > + struct > + { > + UCHAR LowByte; > + UCHAR HighByte; > + }; > + USHORT LowWord; > }; > - USHORT LowWord; > ULONG Long; > } SOFT386_REG, *PSOFT386_REG; > > > >

1 0

Regarding jira
by Zachary Gorden 17 Sep '13

17 Sep '13

Timo originally proposed this but I'd like to actually see the proposal implemented. When working on ReactOS, I'd like developers to create tickets in jira that their commits can then reference. For example, Amine's wine syncs could have a ticket with the title "Wine sync with version 1.x.y" or Alex's NPFS rewrite could have a ticket with the title "New NPFS driver" and the relevant commits can have the ticket number in them. This way when time comes for the changelog, all that needs to be done is gather a list of all tickets closed before the branch, no more of the digging through thousands of commit messages crap.

2 1

Contribution to ReactOS
by Loïc Maury 14 Sep '13

14 Sep '13

Hello, I am new to the reactos project. I think I found a task where I can contribute : http://www.reactos.org/wiki/Printing But I don't know if someone else work on this task ? Thank you Loïc Maury

2 1

Bug Assignments
by James Tabor 12 Sep '13

12 Sep '13

Hi All!!! I'm not in the position to handle anymore bug reports other than the only ones I'm working on now. Please do not assign new bugs to me! Thanks, James

1 0

Works on testbots
by Pierre Schweitzer 07 Sep '13

07 Sep '13

Hi, two major improvements have been done to testbots today, linked with commit r59985: http://svn.reactos.org/svn/reactos?view=revision&revision=59985 Thanks to Olaf, the Patch testbot has been extended that way: if you specify parameter name windll with value yes, then ntdll from win2k3 will be used for the tests of your patch. If you specify patch ID: 0, then unpatched revision will be tested. In parallel, I've been working on Linux VMware testbot, that now has a second testbot. This one is triggered on each commit and will test ReactOS trunk with ntdll from win2k3. The results are uploaded to testman. You can see the results with first attempt: http://reactos.org/sites/all/modules/reactos/testman/compare.php?ids=19420,… So far, we didn't include kernel32.dll nor npfs.sys due to the inability of regtests to work with them. This will come later on. Thanks to all for your great work permitting this major step for the ReactOS project. With my best regards, -- Pierre Schweitzer<pierre at reactos.org> System Administrator ReactOS Foundation

1 0

Google Montreal Tech Talk
by Alex Ionescu 06 Sep '13

06 Sep '13

Hey Guys, I'll be in Montreal on October 2nd (Wednesday) giving a tech talk about ReactOS, for about 2 hours. I intend to go over everything from development to infrastructure (translation, testing, etc). Are there any materials and/or suggestions from previous talks available anywhere? Any set of tools/games/apps you recommend I try out? -- Best regards, Alex Ionescu

6 6

Re: [ros-dev] Google Montreal Tech Talk
by Ameer Ali 06 Sep '13

06 Sep '13

Me too have same opinion... Sent from my windows Phone From: Aleksey Bragin Sent: 06-09-2013 AM 01:09 To: ReactOS Development List Subject: Re: [ros-dev] Google Montreal Tech Talk On 05.09.2013 23:00, Sven Barth wrote: > On 05.09.2013 16:36, Александр wrote: >> Tell them about http://www.youtube.com/watch?v=BzJTZY54r0I training >> course called "operating systems" based on Reactos in Moscow State >> Technical University by Aleksey Bragin. Also tell them about 2000 pages >> of Chinese textbook devoted to Reactos 1) >> http://yadi.sk/d/yRbwE6-23NqQu 2) http://yadi.sk/d/CxgVpVzS3G-GQ > > Pity that I understand neither Russian nor Chinese... > > @Aleksey: If you allow I have two small suggestions regarding your > style of lecture based on the linked video (I don't know whether this > already changed since the time of recording though): > - try to look towards your students > - please keep your hands out of your pockets > As a student I definitely prefer presenters that respect these two > points (and yes, I'm aware that this can be hard) > > Regards, > Sven Thanks Sven, I improved after watching the first recorded video of the lecture myself, and tried to "fix" those issues in the next lectures. Next time to practice would be 2014 spring when I am reading the same course to the new 2nd year students. Regards, Aleksey Bragin _______________________________________________ Ros-dev mailing list Ros-dev(a)reactos.org http://www.reactos.org/mailman/listinfo/ros-dev

1 0

Re: [ros-dev] [ros-diffs] [ion] 59985: This commit, in my opinion, marks an important milestone in ReactOS development. One is now able to boot to desktop, launch applications, download through the application manager, play...
by Aleksey Bragin 04 Sep '13

04 Sep '13

I just wanted to say that this is just amazing. Being able to debug ReactOS with "reference" low-level DLLs is great, but being able to debug ReactOS ntdll and kernel32 when running them in reference environment (that is, Windows 2003) is even better! Indeed, I think, having a special testbot for this would be very beneficial. Regards, Aleksey On 04.09.2013 11:28, ion(a)svn.reactos.org wrote: > Author: ion > Date: Wed Sep 4 07:28:15 2013 > New Revision: 59985 > > URL: http://svn.reactos.org/svn/reactos?rev=59985&view=rev > Log: > This commit, in my opinion, marks an important milestone in ReactOS development. One is now able to boot to desktop, launch applications, download through the application manager, play solitaire, minesweeper, launch Task Manager, etc... by using an unmodified Windows 2003 kernel32.dll binary (and, until our NPFS driver is fixed, the unmodified Windows 2003 NPFS driver). Additionally, one is able to achieve the same by booting with an unmodified Windows 2003 ntdll.dll, including a combination of both. The capability to mix-and-match components such as kernel32 and ntdll, at the heart of the system, will allow to better understand apitest failures (just as Wine has long had the capability to use Windows DLLs instead). With these two building blocks, additional Windows 2003 DLLs can be dropped in/tested, etc, and where failures are seen, a likely component can now be blamed. Furthermore, debugging with public symbols for these DLLs is now possible with WinDBG (in fact, this is how many bugs were fixed in this attempt). Many issues already exist when running with this combination FYI, for example, I was not able to launch any installers (tested Firefox and MIRC). This already demonstrates either missing functionality or ReactOS-specific functionality in components which depend on kernel32. I suspect the next step is infrastructure work to get special patchbot/builders to try and report back winetest results, and for additional DLLs to be "ported"/made to work. On a final note, this mixing and matching has benefits on both ends -- it's now likely that ReactOS' ntdll can run on Server 2003, at least far enough to get to Explorer or Task Manager. Running apitests on Server 2003 with and without reactos DLLs should also easily identify if certain DLLs are directly to blame for certain regressions/failures. </end excited rant> > [BASESRV]: Allocate the INI mappings from the right heap. > > Modified: > trunk/reactos/subsystems/win/basesrv/init.c > > Modified: trunk/reactos/subsystems/win/basesrv/init.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win/basesrv/ini… > ============================================================================== > --- trunk/reactos/subsystems/win/basesrv/init.c [iso-8859-1] (original) > +++ trunk/reactos/subsystems/win/basesrv/init.c [iso-8859-1] Wed Sep 4 07:28:15 2013 > @@ -139,7 +139,7 @@ > BaseSrvInitializeIniFileMappings(IN PBASE_STATIC_SERVER_DATA StaticServerData) > { > /* Allocate the mapping blob */ > - BaseSrvIniFileMapping = RtlAllocateHeap(BaseSrvHeap, > + BaseSrvIniFileMapping = RtlAllocateHeap(BaseSrvSharedHeap, > HEAP_ZERO_MEMORY, > sizeof(*BaseSrvIniFileMapping)); > if (BaseSrvIniFileMapping == NULL) > >

2 1

[ros-diffs] [ion] 59868
by James Tabor 04 Sep '13

04 Sep '13

Hi Alex! The stack guards prevent excessive recursions without throwing exceptions and just kills the message loop by returning false. Removing them could regress some misbehaving applications. Only one comes to mind, java installer. Thanks, James

2 1

Re: [ros-dev] [ros-diffs] [akhaldi] 59962: [COMCTL32] * Implement
by Ameer Ali 02 Sep '13

02 Sep '13

an undocumented flag for the rebar control. This flag is used by browseui and is needed to show the explorer window properly. Should be sent Upstream. Brough... MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit U R rite Sent from my linux Phone From: Aleksey Bragin Sent: 02-09-2013 PM 06:54 To: ros-dev(a)reactos.org Subject: Re: [ros-dev] [ros-diffs] [akhaldi] 59962: [COMCTL32] * Implement an undocumented flag for the rebar control. This flag is used by browseui and is needed to show the explorer window properly. Should be sent Upstream. Brough... It would be great to make a testcase and actually submit this to Wine. Regards, Aleksey On 02.09.2013 16:56, akhaldi(a)svn.reactos.org wrote: > Author: akhaldi > Date: Mon Sep 2 12:56:20 2013 > New Revision: 59962 > > URL: http://svn.reactos.org/svn/reactos?rev=59962&view=rev > Log: > [COMCTL32] > * Implement an undocumented flag for the rebar control. This flag is used by browseui and is needed to show the explorer window properly. Should be sent Upstream. Brought to you by Giannis Adamopoulos (Smiley). > * Update the sync diff. > > Modified: > trunk/reactos/dll/win32/comctl32/comctl32_ros.diff > trunk/reactos/dll/win32/comctl32/rebar.c > > Modified: trunk/reactos/dll/win32/comctl32/comctl32_ros.diff > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/comctl32/comctl3… > ============================================================================== > --- trunk/reactos/dll/win32/comctl32/comctl32_ros.diff [iso-8859-1] (original) > +++ trunk/reactos/dll/win32/comctl32/comctl32_ros.diff [iso-8859-1] Mon Sep 2 12:56:20 2013 > @@ -1,8 +1,90 @@ > -Index: commctrl.c > -=================================================================== > ---- commctrl.c (revision 55577) > -+++ commctrl.c (working copy) > -@@ -71,6 +71,19 @@ > +diff -prudN e:\Wine\dlls\comctl32/comctl32.spec e:\reactos\dll\win32\comctl32/comctl32.spec > +--- e:\Wine\dlls\comctl32/comctl32.spec 2011-09-16 23:22:35.964767000 +0100 > ++++ e:\reactos\dll\win32\comctl32/comctl32.spec 2012-06-04 11:26:55.545450700 +0100 > +@@ -15,7 +15,7 @@ > + 11 stdcall -noname DPA_Merge(ptr ptr long ptr ptr long) > + #12 stub Cctl1632_ThunkData32 > + 13 stdcall MakeDragList(long) > +- 14 stdcall LBItemFromPt(long int64 long) > ++ 14 stdcall LBItemFromPt(long double long) #(long int64 long) > + 15 stdcall DrawInsert(long long long) > + 16 stdcall CreateUpDownControl(long long long long long long long long long long long long) > + 17 stdcall InitCommonControls() > +@@ -30,8 +30,8 @@ > + 155 stdcall -noname FindMRUStringA(long str ptr) > + 156 stdcall -noname DelMRUString(long long) > + 157 stdcall -noname CreateMRUListLazyA(ptr long long long) > +-163 stub -noname CreatePage > +-164 stub -noname CreateProxyPage > ++163 stdcall -noname CreatePage(long ptr) > ++164 stdcall -noname CreateProxyPage(long long) > + 167 stdcall -noname AddMRUData(long ptr long) > + 169 stdcall -noname FindMRUData(long ptr long ptr) > + 233 stdcall -noname Str_GetPtrA(str str long) > +@@ -88,13 +88,13 @@ > + 376 stdcall -noname IntlStrEqWorkerA(long str str long) > + 377 stdcall -noname IntlStrEqWorkerW(long wstr wstr long) > + 382 stdcall -noname SmoothScrollWindow(ptr) > +-383 stub -noname DoReaderMode > ++383 stdcall -noname DoReaderMode(ptr) > + 384 stdcall -noname SetPathWordBreakProc(ptr long) > + 385 stdcall -ordinal DPA_EnumCallback(long long long) > + 386 stdcall -ordinal DPA_DestroyCallback(ptr ptr long) > + 387 stdcall -ordinal DSA_EnumCallback(ptr ptr long) > + 388 stdcall -ordinal DSA_DestroyCallback(ptr ptr long) > +-389 stub -noname SHGetProcessDword > ++389 stdcall -noname SHGetProcessDword(long long) > + 390 stdcall -noname ImageList_SetColorTable(ptr long long ptr) > + 400 stdcall -ordinal CreateMRUListW(ptr) > + 401 stdcall -ordinal AddMRUStringW(long wstr) > +@@ -188,6 +188,7 @@ > + @ stdcall PropertySheet(ptr) PropertySheetA > + @ stdcall PropertySheetA(ptr) > + @ stdcall PropertySheetW(ptr) > ++@ stdcall RegisterClassNameW(wstr) > + @ stdcall TaskDialogIndirect(ptr ptr ptr ptr) > + @ stdcall UninitializeFlatSB(long) > + @ stdcall _TrackMouseEvent(ptr) > + > +diff -prudN e:\Wine\dlls\comctl32/commctrl.c e:\reactos\dll\win32\comctl32/commctrl.c > +--- e:\Wine\dlls\comctl32/commctrl.c 2011-11-24 17:55:01.900415100 +0100 > ++++ e:\reactos\dll\win32\comctl32/commctrl.c 2013-01-25 14:12:39.829654200 +0100 > +@@ -52,25 +52,42 @@ > + * -- ICC_WIN95_CLASSES > + */ > + > ++#define WIN32_NO_STATUS > ++#define _INC_WINDOWS > ++#define COM_NO_WINDOWS_H > ++ > + #include <stdarg.h> > +-#include <string.h> > +-#include <stdlib.h> > ++//#include <string.h> > ++//#include <stdlib.h> > + > +-#include "windef.h" > +-#include "winbase.h" > +-#include "wingdi.h" > +-#include "winuser.h" > +-#include "winnls.h" > +-#include "commctrl.h" > +-#include "winerror.h" > +-#include "winreg.h" > ++#include <windef.h> > ++#include <winbase.h> > ++//#include "wingdi.h" > ++//#include "winuser.h" > ++#include <winnls.h> > ++//#include "commctrl.h" > ++//#include "winerror.h" > ++#include <winreg.h> > + #define NO_SHLWAPI_STREAM > +-#include "shlwapi.h" > ++#include <shlwapi.h> > + #include "comctl32.h" > +-#include "wine/debug.h" > ++#include <wine/debug.h> > > WINE_DEFAULT_DEBUG_CHANNEL(commctrl); > > @@ -22,7 +104,7 @@ > > static LRESULT WINAPI COMCTL32_SubclassProc (HWND hWnd, UINT uMsg, WPARAM wParam, LPARAM lParam); > > -@@ -92,6 +105,67 @@ > +@@ -92,6 +109,67 @@ static const WCHAR strCC32SubclassInfo[] > 'C','C','3','2','S','u','b','c','l','a','s','s','I','n','f','o',0 > }; > > @@ -90,7 +172,7 @@ > > /*********************************************************************** > * DllMain [Internal] > -@@ -930,6 +1004,12 @@ > +@@ -930,6 +1008,12 @@ HRESULT WINAPI DllGetVersion (DLLVERSION > HRESULT WINAPI DllInstall(BOOL bInstall, LPCWSTR cmdline) > { > TRACE("(%u, %s): stub\n", bInstall, debugstr_w(cmdline)); > @@ -103,7 +185,7 @@ > return S_OK; > } > > -@@ -1593,12 +1673,114 @@ > +@@ -1593,12 +1677,114 @@ LRESULT WINAPI SetPathWordBreakProc(HWND > * > * Draw text with shadow. > */ > @@ -222,7 +304,7 @@ > } > > /*********************************************************************** > -@@ -1821,3 +1821,15 @@ > +@@ -1639,3 +1825,15 @@ HRESULT WINAPI TaskDialogIndirect(const > if (pfVerificationFlagChecked) *pfVerificationFlagChecked = TRUE; > return S_OK; > } > @@ -239,11 +321,97 @@ > + return TRUE; > +} > > -Index: propsheet.c > -=================================================================== > ---- propsheet.c (revision 38890) > -+++ propsheet.c (working copy) > -@@ -2425,6 +2425,9 @@ > +diff -prudN e:\Wine\dlls\comctl32/listview.c e:\reactos\dll\win32\comctl32/listview.c > +--- e:\Wine\dlls\comctl32/listview.c 2013-03-16 11:54:52.374454400 +0100 > ++++ e:\reactos\dll\win32\comctl32/listview.c 2013-03-17 19:12:46.522399200 +0100 > +@@ -314,6 +314,7 @@ typedef struct tagLISTVIEW_INFO > + COLORREF clrBk; > + COLORREF clrText; > + COLORREF clrTextBk; > ++ BOOL bDefaultBkColor; > + > + /* font */ > + HFONT hDefaultFont; > +@@ -1700,8 +1701,19 @@ static inline BOOL LISTVIEW_GetItemW(con > + /* used to handle collapse main item column case */ > + static inline BOOL LISTVIEW_DrawFocusRect(const LISTVIEW_INFO *infoPtr, HDC hdc) > + { > +- return (infoPtr->rcFocus.left < infoPtr->rcFocus.right) ? > +- DrawFocusRect(hdc, &infoPtr->rcFocus) : FALSE; > ++ BOOL Ret = FALSE; > ++ > ++ if (infoPtr->rcFocus.left < infoPtr->rcFocus.right) > ++ { > ++ DWORD dwOldBkColor, dwOldTextColor; > ++ > ++ dwOldBkColor = SetBkColor(hdc, RGB(255, 255, 255)); > ++ dwOldTextColor = SetBkColor(hdc, RGB(0, 0, 0)); > ++ Ret = DrawFocusRect(hdc, &infoPtr->rcFocus); > ++ SetBkColor(hdc, dwOldBkColor); > ++ SetBkColor(hdc, dwOldTextColor); > ++ } > ++ return Ret; > + } > + > + /* Listview invalidation functions: use _only_ these functions to invalidate */ > +@@ -4734,7 +4746,10 @@ static BOOL LISTVIEW_DrawItem(LISTVIEW_I > + if (infoPtr->uView == LV_VIEW_DETAILS && infoPtr->dwLvExStyle & LVS_EX_GRIDLINES) > + rcLabel.bottom--; > + > +- DrawTextW(hdc, lvItem.pszText, -1, &rcLabel, uFormat); > ++ if ((!(lvItem.state & LVIS_SELECTED) || !infoPtr->bFocus) && (infoPtr->dwLvExStyle & LVS_EX_TRANSPARENTSHADOWTEXT)) > ++ DrawShadowText(hdc, lvItem.pszText, -1, &rcLabel, uFormat, RGB(255, 255, 255), RGB(0, 0, 0), 2, 2); > ++ else > ++ DrawTextW(hdc, lvItem.pszText, -1, &rcLabel, uFormat); > + > + postpaint: > + if (cdsubitemmode & CDRF_NOTIFYPOSTPAINT) > +@@ -5143,7 +5158,11 @@ enddraw: > + > + /* Draw marquee rectangle if appropriate */ > + if (infoPtr->bMarqueeSelect) > ++ { > ++ SetBkColor(hdc, RGB(255, 255, 255)); > ++ SetTextColor(hdc, RGB(0, 0, 0)); > + DrawFocusRect(hdc, &infoPtr->marqueeDrawRect); > ++ } > + > + if (cdmode & CDRF_NOTIFYPOSTPAINT) > + notify_postpaint(infoPtr, &nmlvcd); > +@@ -7952,6 +7971,7 @@ static BOOL LISTVIEW_SetBkColor(LISTVIEW > + { > + TRACE("(color=%x)\n", color); > + > ++ infoPtr->bDefaultBkColor = FALSE; > + if(infoPtr->clrBk != color) { > + if (infoPtr->clrBk != CLR_NONE) DeleteObject(infoPtr->hBkBrush); > + infoPtr->clrBk = color; > +@@ -9362,6 +9382,7 @@ static LRESULT LISTVIEW_NCCreate(HWND hw > + infoPtr->clrText = CLR_DEFAULT; > + infoPtr->clrTextBk = CLR_DEFAULT; > + LISTVIEW_SetBkColor(infoPtr, comctl32_color.clrWindow); > ++ infoPtr->bDefaultBkColor = TRUE; > + > + /* set default values */ > + infoPtr->nFocusedItem = -1; > +@@ -11644,6 +11665,12 @@ LISTVIEW_WindowProc(HWND hwnd, UINT uMsg > + > + case WM_SYSCOLORCHANGE: > + COMCTL32_RefreshSysColors(); > ++ if (infoPtr->bDefaultBkColor) > ++ { > ++ LISTVIEW_SetBkColor(infoPtr, comctl32_color.clrWindow); > ++ infoPtr->bDefaultBkColor = TRUE; > ++ LISTVIEW_InvalidateList(infoPtr); > ++ } > + return 0; > + > + /* case WM_TIMER: */ > + > +diff -prudN e:\Wine\dlls\comctl32/propsheet.c e:\reactos\dll\win32\comctl32/propsheet.c > +--- e:\Wine\dlls\comctl32/propsheet.c 2013-03-02 14:17:59.122793000 +0100 > ++++ e:\reactos\dll\win32\comctl32/propsheet.c 2013-03-16 12:21:47.383897000 +0100 > +@@ -2430,6 +2430,9 @@ static void PROPSHEET_SetWizButtons(HWND > HWND hwndBack = GetDlgItem(hwndDlg, IDC_BACK_BUTTON); > HWND hwndNext = GetDlgItem(hwndDlg, IDC_NEXT_BUTTON); > HWND hwndFinish = GetDlgItem(hwndDlg, IDC_FINISH_BUTTON); > @@ -253,7 +421,7 @@ > > TRACE("%d\n", dwFlags); > > -@@ -2432,17 +2435,6 @@ > +@@ -2437,17 +2440,6 @@ static void PROPSHEET_SetWizButtons(HWND > EnableWindow(hwndNext, FALSE); > EnableWindow(hwndFinish, FALSE); > > @@ -271,7 +439,7 @@ > if (dwFlags & PSWIZB_BACK) > EnableWindow(hwndBack, TRUE); > > -@@ -2472,6 +2464,22 @@ > +@@ -2477,6 +2469,22 @@ static void PROPSHEET_SetWizButtons(HWND > } > else if (!(dwFlags & PSWIZB_DISABLEDFINISH)) > EnableWindow(hwndFinish, TRUE); > @@ -294,20 +462,229 @@ > } > > /****************************************************************************** > -Index: tooltips.c > -=================================================================== > ---- tooltips.c (revision 38890) > -+++ tooltips.c (working copy) > -@@ -2488,8 +2488,33 @@ > +diff -prudN e:\Wine\dlls\comctl32/rebar.c e:\reactos\dll\win32\comctl32/rebar.c > +--- e:\Wine\dlls\comctl32/rebar.c 2013-03-02 14:17:59.125795000 +0100 > ++++ e:\reactos\dll\win32\comctl32/rebar.c 2013-09-02 13:40:15.983276500 +0100 > +@@ -51,7 +51,6 @@ > + * - WM_QUERYNEWPALETTE > + * - WM_RBUTTONDOWN > + * - WM_RBUTTONUP > +- * - WM_SYSCOLORCHANGE > + * - WM_VKEYTOITEM > + * - WM_WININICHANGE > + * Notifications: > + > +@@ -2544,10 +2543,8 @@ REBAR_InsertBandT(REBAR_INFO *infoPtr, I > + > + /* initialize band */ > + memset(lpBand, 0, sizeof(*lpBand)); > +- lpBand->clrFore = infoPtr->clrText == CLR_NONE ? infoPtr->clrBtnText : > +- infoPtr->clrText; > +- lpBand->clrBack = infoPtr->clrBk == CLR_NONE ? infoPtr->clrBtnFace : > +- infoPtr->clrBk; > ++ lpBand->clrFore = infoPtr->clrText; > ++ lpBand->clrBack = infoPtr->clrBk; > + lpBand->iImage = -1; > + > + REBAR_CommonSetupBand(infoPtr->hwndSelf, lprbbi, lpBand); > +@@ -2927,12 +2924,20 @@ REBAR_ShowBand (REBAR_INFO *infoPtr, INT > + > + > static LRESULT > - TOOLTIPS_NotifyFormat (HWND hwnd, WPARAM wParam, LPARAM lParam) > +-REBAR_SizeToRect (REBAR_INFO *infoPtr, const RECT *lpRect) > ++REBAR_SizeToRect (REBAR_INFO *infoPtr, WPARAM flags, RECT *lpRect) > { > -- FIXME ("hwnd=%p wParam=%lx lParam=%lx\n", hwnd, wParam, lParam); > -+ TOOLTIPS_INFO *infoPtr = TOOLTIPS_GetInfoPtr (hwnd); > + if (!lpRect) return FALSE; > + > + TRACE("[%s]\n", wine_dbgstr_rect(lpRect)); > + REBAR_SizeToHeight(infoPtr, get_rect_cy(infoPtr, lpRect)); > ++ > ++ /* Note that this undocumented flag is available on comctl32 v6 or later */ > ++ if ((flags & RBSTR_CHANGERECT) != 0) > ++ { > ++ RECT rcRebar; > ++ GetClientRect(infoPtr->hwndSelf, &rcRebar); > ++ lpRect->bottom = lpRect->top + (rcRebar.bottom - rcRebar.top); > ++ } > + return TRUE; > + } > + > +@@ -3713,7 +3718,7 @@ REBAR_WindowProc (HWND hwnd, UINT uMsg, > + return REBAR_ShowBand (infoPtr, wParam, lParam); > + > + case RB_SIZETORECT: > +- return REBAR_SizeToRect (infoPtr, (LPCRECT)lParam); > ++ return REBAR_SizeToRect (infoPtr, wParam, (LPRECT)lParam); > + > + > + /* Messages passed to parent */ > +@@ -3797,6 +3802,8 @@ REBAR_WindowProc (HWND hwnd, UINT uMsg, > + > + case WM_SYSCOLORCHANGE: > + COMCTL32_RefreshSysColors(); > ++ infoPtr->clrBtnText = comctl32_color.clrBtnText; > ++ infoPtr->clrBtnFace = comctl32_color.clrBtnFace; > + return 0; > + > + /* case WM_VKEYTOITEM: supported according to ControlSpy */ > + > +--- e:\Wine\dlls\comctl32/tests/v6util.h 2011-09-16 23:22:36.002769200 +0100 > ++++ e:\reactos\dll\win32\comctl32/tests/v6util.h 1970-01-01 01:00:00.000000000 +0100 > +@@ -1,142 +0,0 @@ > +-/* > +- * Utility routines for comctl32 v6 tests > +- * > +- * Copyright 2006 Mike McCormack for CodeWeavers > +- * Copyright 2007 George Gov > +- * Copyright 2009 Owen Rudge for CodeWeavers > +- * > +- * This library is free software; you can redistribute it and/or > +- * modify it under the terms of the GNU Lesser General Public > +- * License as published by the Free Software Foundation; either > +- * version 2.1 of the License, or (at your option) any later version. > +- * > +- * This library is distributed in the hope that it will be useful, > +- * but WITHOUT ANY WARRANTY; without even the implied warranty of > +- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > +- * Lesser General Public License for more details. > +- * > +- * You should have received a copy of the GNU Lesser General Public > +- * License along with this library; if not, write to the Free Software > +- * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA > +- */ > +- > +-#define expect(expected, got) ok(got == expected, "Expected %d, got %d\n", expected, got) > +- > +-#ifdef __i386__ > +-#define ARCH "x86" > +-#elif defined __x86_64__ > +-#define ARCH "amd64" > +-#else > +-#define ARCH "none" > +-#endif > +- > +-static const CHAR manifest_name[] = "cc6.manifest"; > +- > +-static const CHAR manifest[] = > +- "<?xml version=\"1.0\" encoding=\"UTF-8\" standalone=\"yes\"?>\n" > +- "<assembly xmlns=\"urn:schemas-microsoft-com:asm.v1\" manifestVersion=\"1.0\">\n" > +- " <assemblyIdentity\n" > +- " type=\"win32\"\n" > +- " name=\"Wine.ComCtl32.Tests\"\n" > +- " version=\"1.0.0.0\"\n" > +- " processorArchitecture=\"" ARCH "\"\n" > +- " />\n" > +- "<description>Wine comctl32 test suite</description>\n" > +- "<dependency>\n" > +- " <dependentAssembly>\n" > +- " <assemblyIdentity\n" > +- " type=\"win32\"\n" > +- " name=\"microsoft.windows.common-controls\"\n" > +- " version=\"6.0.0.0\"\n" > +- " processorArchitecture=\"" ARCH "\"\n" > +- " publicKeyToken=\"6595b64144ccf1df\"\n" > +- " language=\"*\"\n" > +- " />\n" > +- "</dependentAssembly>\n" > +- "</dependency>\n" > +- "</assembly>\n"; > +- > +-static void unload_v6_module(ULONG_PTR cookie, HANDLE hCtx) > +-{ > +- HANDLE hKernel32; > +- BOOL (WINAPI *pDeactivateActCtx)(DWORD, ULONG_PTR); > +- VOID (WINAPI *pReleaseActCtx)(HANDLE); > +- > +- hKernel32 = GetModuleHandleA("kernel32.dll"); > +- pDeactivateActCtx = (void*)GetProcAddress(hKernel32, "DeactivateActCtx"); > +- pReleaseActCtx = (void*)GetProcAddress(hKernel32, "ReleaseActCtx"); > +- if (!pDeactivateActCtx || !pReleaseActCtx) > +- { > +- win_skip("Activation contexts unsupported\n"); > +- return; > +- } > +- > +- pDeactivateActCtx(0, cookie); > +- pReleaseActCtx(hCtx); > +- > +- DeleteFileA(manifest_name); > +-} > +- > +-static BOOL load_v6_module(ULONG_PTR *pcookie, HANDLE *hCtx) > +-{ > +- HANDLE hKernel32; > +- HANDLE (WINAPI *pCreateActCtxA)(ACTCTXA*); > +- BOOL (WINAPI *pActivateActCtx)(HANDLE, ULONG_PTR*); > +- > +- ACTCTXA ctx; > +- BOOL ret; > +- HANDLE file; > +- DWORD written; > +- > +- hKernel32 = GetModuleHandleA("kernel32.dll"); > +- pCreateActCtxA = (void*)GetProcAddress(hKernel32, "CreateActCtxA"); > +- pActivateActCtx = (void*)GetProcAddress(hKernel32, "ActivateActCtx"); > +- if (!(pCreateActCtxA && pActivateActCtx)) > +- { > +- win_skip("Activation contexts unsupported. No version 6 tests possible.\n"); > +- return FALSE; > +- } > +- > +- /* create manifest */ > +- file = CreateFileA( manifest_name, GENERIC_WRITE, 0, NULL, CREATE_ALWAYS, 0, NULL ); > +- if (file != INVALID_HANDLE_VALUE) > +- { > +- ret = (WriteFile( file, manifest, sizeof(manifest)-1, &written, NULL ) && > +- written == sizeof(manifest)-1); > +- CloseHandle( file ); > +- if (!ret) > +- { > +- DeleteFileA( manifest_name ); > +- skip("Failed to fill manifest file. Skipping comctl32 V6 tests.\n"); > +- return FALSE; > +- } > +- else > +- trace("created %s\n", manifest_name); > +- } > +- else > +- { > +- skip("Failed to create manifest file. Skipping comctl32 V6 tests.\n"); > +- return FALSE; > +- } > +- > +- memset(&ctx, 0, sizeof(ctx)); > +- ctx.cbSize = sizeof(ctx); > +- ctx.lpSource = manifest_name; > +- > +- *hCtx = pCreateActCtxA(&ctx); > +- ok(*hCtx != 0, "Expected context handle\n"); > +- > +- ret = pActivateActCtx(*hCtx, pcookie); > +- expect(TRUE, ret); > +- > +- if (!ret) > +- { > +- win_skip("A problem during context activation occurred.\n"); > +- DeleteFileA(manifest_name); > +- } > +- > +- return ret; > +-} > +- > +-#undef expect > +-#undef ARCH > +diff -prudN e:\Wine\dlls\comctl32/tooltips.c e:\reactos\dll\win32\comctl32/tooltips.c > +--- e:\Wine\dlls\comctl32/tooltips.c 2013-03-02 14:17:59.178196600 +0100 > ++++ e:\reactos\dll\win32\comctl32/tooltips.c 2013-03-16 12:24:45.122483600 +0100 > +@@ -2002,7 +2002,32 @@ TOOLTIPS_NCHitTest (const TOOLTIPS_INFO > + static LRESULT > + TOOLTIPS_NotifyFormat (TOOLTIPS_INFO *infoPtr, WPARAM wParam, LPARAM lParam) > + { > +- FIXME ("hwnd=%p wParam=%lx lParam=%lx\n", infoPtr->hwndSelf, wParam, lParam); > + TTTOOL_INFO *toolPtr = infoPtr->tools; > -+ INT nResult; > - > -+ TRACE("hwnd=%p wParam=%lx lParam=%lx\n", hwnd, wParam, lParam); > ++ LRESULT nResult; > ++ > ++ TRACE("infoPtr=%p wParam=%lx lParam=%p\n", infoPtr, wParam, (PVOID)lParam); > + > + if (lParam == NF_QUERY) { > + if (toolPtr->bNotifyUnicode) { > @@ -317,8 +694,8 @@ > + } > + } > + else if (lParam == NF_REQUERY) { > -+ nResult = (INT) SendMessageW (toolPtr->hwnd, WM_NOTIFYFORMAT, > -+ (WPARAM)hwnd, (LPARAM)NF_QUERY); > ++ nResult = SendMessageW (toolPtr->hwnd, WM_NOTIFYFORMAT, > ++ (WPARAM)infoPtr->hwndSelf, (LPARAM)NF_QUERY); > + if (nResult == NFR_ANSI) { > + toolPtr->bNotifyUnicode = FALSE; > + TRACE(" -- WM_NOTIFYFORMAT returns: NFR_ANSI\n"); > @@ -330,14 +707,14 @@ > + } > + return nResult; > + } > + > return 0; > } > - > -Index: treeview.c > -=================================================================== > ---- treeview.c (revision 38890) > -+++ treeview.c (working copy) > -@@ -2830,7 +2830,12 @@ > + > +diff -prudN e:\Wine\dlls\comctl32/treeview.c e:\reactos\dll\win32\comctl32/treeview.c > +--- e:\Wine\dlls\comctl32/treeview.c 2013-03-02 14:17:59.181198600 +0100 > ++++ e:\reactos\dll\win32\comctl32/treeview.c 2013-03-16 12:26:03.285023200 +0100 > +@@ -2921,7 +2921,12 @@ TREEVIEW_Refresh(TREEVIEW_INFO *infoPtr, > } > } > > @@ -351,151 +728,3 @@ > > if (infoPtr->cdmode & CDRF_NOTIFYPOSTPAINT) > infoPtr->cdmode = > -Index: listview.c > -=================================================================== > ---- listview.c (revision 51320) > -+++ listview.c (working copy) > -@@ -315,6 +315,7 @@ > - COLORREF clrBk; > - COLORREF clrText; > - COLORREF clrTextBk; > -+ BOOL bDefaultBkColor; > - > - /* font */ > - HFONT hDefaultFont; > -@@ -1699,8 +1700,19 @@ > - /* used to handle collapse main item column case */ > - static inline BOOL LISTVIEW_DrawFocusRect(const LISTVIEW_INFO *infoPtr, HDC hdc) > - { > -- return (infoPtr->rcFocus.left < infoPtr->rcFocus.right) ? > -- DrawFocusRect(hdc, &infoPtr->rcFocus) : FALSE; > -+ BOOL Ret = FALSE; > -+ > -+ if (infoPtr->rcFocus.left < infoPtr->rcFocus.right) > -+ { > -+ DWORD dwOldBkColor, dwOldTextColor; > -+ > -+ dwOldBkColor = SetBkColor(hdc, RGB(255, 255, 255)); > -+ dwOldTextColor = SetBkColor(hdc, RGB(0, 0, 0)); > -+ Ret = DrawFocusRect(hdc, &infoPtr->rcFocus); > -+ SetBkColor(hdc, dwOldBkColor); > -+ SetBkColor(hdc, dwOldTextColor); > -+ } > -+ return Ret; > - } > - > - /* Listview invalidation functions: use _only_ these functions to invalidate */ > -@@ -4698,7 +4710,10 @@ > - if (infoPtr->uView == LV_VIEW_DETAILS && infoPtr->dwLvExStyle & LVS_EX_GRIDLINES) > - rcLabel.bottom--; > - > -- DrawTextW(hdc, lvItem.pszText, -1, &rcLabel, uFormat); > -+ if ((!(lvItem.state & LVIS_SELECTED) || !infoPtr->bFocus) && (infoPtr->dwLvExStyle & LVS_EX_TRANSPARENTSHADOWTEXT)) > -+ DrawShadowText(hdc, lvItem.pszText, -1, &rcLabel, uFormat, RGB(255, 255, 255), RGB(0, 0, 0), 2, 2); > -+ else > -+ DrawTextW(hdc, lvItem.pszText, -1, &rcLabel, uFormat); > - > - postpaint: > - if (cdsubitemmode & CDRF_NOTIFYPOSTPAINT) > -@@ -5117,7 +5132,11 @@ > - > - /* Draw marquee rectangle if appropriate */ > - if (infoPtr->bMarqueeSelect) > -+ { > -+ SetBkColor(hdc, RGB(255, 255, 255)); > -+ SetTextColor(hdc, RGB(0, 0, 0)); > - DrawFocusRect(hdc, &infoPtr->marqueeDrawRect); > -+ } > - > - if (cdmode & CDRF_NOTIFYPOSTPAINT) > - notify_postpaint(infoPtr, &nmlvcd); > -@@ -7927,6 +7946,7 @@ > - { > - TRACE("(color=%x)\n", color); > - > -+ infoPtr->bDefaultBkColor = FALSE; > - if(infoPtr->clrBk != color) { > - if (infoPtr->clrBk != CLR_NONE) DeleteObject(infoPtr->hBkBrush); > - infoPtr->clrBk = color; > -@@ -9314,6 +9334,7 @@ > - infoPtr->clrText = CLR_DEFAULT; > - infoPtr->clrTextBk = CLR_DEFAULT; > - LISTVIEW_SetBkColor(infoPtr, comctl32_color.clrWindow); > -+ infoPtr->bDefaultBkColor = TRUE; > - > - /* set default values */ > - infoPtr->nFocusedItem = -1; > -@@ -11570,6 +11591,12 @@ > - > - case WM_SYSCOLORCHANGE: > - COMCTL32_RefreshSysColors(); > -+ if (infoPtr->bDefaultBkColor) > -+ { > -+ LISTVIEW_SetBkColor(infoPtr, comctl32_color.clrWindow); > -+ infoPtr->bDefaultBkColor = TRUE; > -+ LISTVIEW_InvalidateList(infoPtr); > -+ } > - return 0; > - > - /* case WM_TIMER: */ > -Index: rebar.c > -=================================================================== > ---- rebar.c (revision 51320) > -+++ rebar.c (working copy) > -@@ -51,7 +51,6 @@ > - * - WM_QUERYNEWPALETTE > - * - WM_RBUTTONDOWN > - * - WM_RBUTTONUP > -- * - WM_SYSCOLORCHANGE > - * - WM_VKEYTOITEM > - * - WM_WININICHANGE > - * Notifications: > -@@ -2540,10 +2539,8 @@ > - > - /* initialize band */ > - memset(lpBand, 0, sizeof(*lpBand)); > -- lpBand->clrFore = infoPtr->clrText == CLR_NONE ? infoPtr->clrBtnText : > -- infoPtr->clrText; > -- lpBand->clrBack = infoPtr->clrBk == CLR_NONE ? infoPtr->clrBtnFace : > -- infoPtr->clrBk; > -+ lpBand->clrFore = infoPtr->clrText; > -+ lpBand->clrBack = infoPtr->clrBk; > - lpBand->iImage = -1; > - > - REBAR_CommonSetupBand(infoPtr->hwndSelf, lprbbi, lpBand); > -@@ -3793,6 +3790,8 @@ > - > - case WM_SYSCOLORCHANGE: > - COMCTL32_RefreshSysColors(); > -+ infoPtr->clrBtnText = comctl32_color.clrBtnText; > -+ infoPtr->clrBtnFace = comctl32_color.clrBtnFace; > - return 0; > - > - /* case WM_VKEYTOITEM: supported according to ControlSpy */ > -Index: monthcal.c > -=================================================================== > ---- monthcal.c (Revision 51719) > -+++ monthcal.c (Arbeitskopie) > -@@ -143,8 +143,8 @@ > - /* empty SYSTEMTIME const */ > - static const SYSTEMTIME st_null; > - /* valid date limits */ > --static const SYSTEMTIME max_allowed_date = { .wYear = 9999, .wMonth = 12, .wDay = 31 }; > --static const SYSTEMTIME min_allowed_date = { .wYear = 1752, .wMonth = 9, .wDay = 14 }; > -+static const SYSTEMTIME max_allowed_date = { 9999, 12, 0, 31, 0, 0, 0, 0 }; > -+static const SYSTEMTIME min_allowed_date = { 1752, 9, 0, 14, 0, 0, 0, 0 }; > - > - /* Prev/Next buttons */ > - enum nav_direction > -Index: comctl32.spec > -=================================================================== > ---- comctl32.spec (revision 56653) > -+++ comctl32.spec (working copy) > -@@ -188,6 +188,7 @@ > - @ stdcall PropertySheet(ptr) PropertySheetA > - @ stdcall PropertySheetA(ptr) > - @ stdcall PropertySheetW(ptr) > -+@ stdcall RegisterClassNameW(wstr) > - @ stdcall TaskDialogIndirect(ptr ptr ptr ptr) > - @ stdcall UninitializeFlatSB(long) > - @ stdcall _TrackMouseEvent(ptr) > > Modified: trunk/reactos/dll/win32/comctl32/rebar.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/comctl32/rebar.c… > ============================================================================== > --- trunk/reactos/dll/win32/comctl32/rebar.c [iso-8859-1] (original) > +++ trunk/reactos/dll/win32/comctl32/rebar.c [iso-8859-1] Mon Sep 2 12:56:20 2013 > @@ -2924,12 +2924,20 @@ > > > static LRESULT > -REBAR_SizeToRect (REBAR_INFO *infoPtr, const RECT *lpRect) > +REBAR_SizeToRect (REBAR_INFO *infoPtr, WPARAM flags, RECT *lpRect) > { > if (!lpRect) return FALSE; > > TRACE("[%s]\n", wine_dbgstr_rect(lpRect)); > REBAR_SizeToHeight(infoPtr, get_rect_cy(infoPtr, lpRect)); > + > + /* Note that this undocumented flag is available on comctl32 v6 or later */ > + if ((flags & RBSTR_CHANGERECT) != 0) > + { > + RECT rcRebar; > + GetClientRect(infoPtr->hwndSelf, &rcRebar); > + lpRect->bottom = lpRect->top + (rcRebar.bottom - rcRebar.top); > + } > return TRUE; > } > > @@ -3710,7 +3718,7 @@ > return REBAR_ShowBand (infoPtr, wParam, lParam); > > case RB_SIZETORECT: > - return REBAR_SizeToRect (infoPtr, (LPCRECT)lParam); > + return REBAR_SizeToRect (infoPtr, wParam, (LPRECT)lParam); > > > /* Messages passed to parent */ > > _______________________________________________ Ros-dev mailing list Ros-dev(a)reactos.org http://www.reactos.org/mailman/listinfo/ros-dev

1 0

Re: [ros-dev] [ros-diffs] [akhaldi] 59962: [COMCTL32] * Implement an undocumented flag for the rebar control. This flag is used by browseui and is needed to show the explorer window properly. Should be sent Upstream. Brough...
by Aleksey Bragin 02 Sep '13

02 Sep '13

It would be great to make a testcase and actually submit this to Wine. Regards, Aleksey On 02.09.2013 16:56, akhaldi(a)svn.reactos.org wrote: > Author: akhaldi > Date: Mon Sep 2 12:56:20 2013 > New Revision: 59962 > > URL: http://svn.reactos.org/svn/reactos?rev=59962&view=rev > Log: > [COMCTL32] > * Implement an undocumented flag for the rebar control. This flag is used by browseui and is needed to show the explorer window properly. Should be sent Upstream. Brought to you by Giannis Adamopoulos (Smiley). > * Update the sync diff. > > Modified: > trunk/reactos/dll/win32/comctl32/comctl32_ros.diff > trunk/reactos/dll/win32/comctl32/rebar.c > > Modified: trunk/reactos/dll/win32/comctl32/comctl32_ros.diff > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/comctl32/comctl3… > ============================================================================== > --- trunk/reactos/dll/win32/comctl32/comctl32_ros.diff [iso-8859-1] (original) > +++ trunk/reactos/dll/win32/comctl32/comctl32_ros.diff [iso-8859-1] Mon Sep 2 12:56:20 2013 > @@ -1,8 +1,90 @@ > -Index: commctrl.c > -=================================================================== > ---- commctrl.c (revision 55577) > -+++ commctrl.c (working copy) > -@@ -71,6 +71,19 @@ > +diff -prudN e:\Wine\dlls\comctl32/comctl32.spec e:\reactos\dll\win32\comctl32/comctl32.spec > +--- e:\Wine\dlls\comctl32/comctl32.spec 2011-09-16 23:22:35.964767000 +0100 > ++++ e:\reactos\dll\win32\comctl32/comctl32.spec 2012-06-04 11:26:55.545450700 +0100 > +@@ -15,7 +15,7 @@ > + 11 stdcall -noname DPA_Merge(ptr ptr long ptr ptr long) > + #12 stub Cctl1632_ThunkData32 > + 13 stdcall MakeDragList(long) > +- 14 stdcall LBItemFromPt(long int64 long) > ++ 14 stdcall LBItemFromPt(long double long) #(long int64 long) > + 15 stdcall DrawInsert(long long long) > + 16 stdcall CreateUpDownControl(long long long long long long long long long long long long) > + 17 stdcall InitCommonControls() > +@@ -30,8 +30,8 @@ > + 155 stdcall -noname FindMRUStringA(long str ptr) > + 156 stdcall -noname DelMRUString(long long) > + 157 stdcall -noname CreateMRUListLazyA(ptr long long long) > +-163 stub -noname CreatePage > +-164 stub -noname CreateProxyPage > ++163 stdcall -noname CreatePage(long ptr) > ++164 stdcall -noname CreateProxyPage(long long) > + 167 stdcall -noname AddMRUData(long ptr long) > + 169 stdcall -noname FindMRUData(long ptr long ptr) > + 233 stdcall -noname Str_GetPtrA(str str long) > +@@ -88,13 +88,13 @@ > + 376 stdcall -noname IntlStrEqWorkerA(long str str long) > + 377 stdcall -noname IntlStrEqWorkerW(long wstr wstr long) > + 382 stdcall -noname SmoothScrollWindow(ptr) > +-383 stub -noname DoReaderMode > ++383 stdcall -noname DoReaderMode(ptr) > + 384 stdcall -noname SetPathWordBreakProc(ptr long) > + 385 stdcall -ordinal DPA_EnumCallback(long long long) > + 386 stdcall -ordinal DPA_DestroyCallback(ptr ptr long) > + 387 stdcall -ordinal DSA_EnumCallback(ptr ptr long) > + 388 stdcall -ordinal DSA_DestroyCallback(ptr ptr long) > +-389 stub -noname SHGetProcessDword > ++389 stdcall -noname SHGetProcessDword(long long) > + 390 stdcall -noname ImageList_SetColorTable(ptr long long ptr) > + 400 stdcall -ordinal CreateMRUListW(ptr) > + 401 stdcall -ordinal AddMRUStringW(long wstr) > +@@ -188,6 +188,7 @@ > + @ stdcall PropertySheet(ptr) PropertySheetA > + @ stdcall PropertySheetA(ptr) > + @ stdcall PropertySheetW(ptr) > ++@ stdcall RegisterClassNameW(wstr) > + @ stdcall TaskDialogIndirect(ptr ptr ptr ptr) > + @ stdcall UninitializeFlatSB(long) > + @ stdcall _TrackMouseEvent(ptr) > + > +diff -prudN e:\Wine\dlls\comctl32/commctrl.c e:\reactos\dll\win32\comctl32/commctrl.c > +--- e:\Wine\dlls\comctl32/commctrl.c 2011-11-24 17:55:01.900415100 +0100 > ++++ e:\reactos\dll\win32\comctl32/commctrl.c 2013-01-25 14:12:39.829654200 +0100 > +@@ -52,25 +52,42 @@ > + * -- ICC_WIN95_CLASSES > + */ > + > ++#define WIN32_NO_STATUS > ++#define _INC_WINDOWS > ++#define COM_NO_WINDOWS_H > ++ > + #include <stdarg.h> > +-#include <string.h> > +-#include <stdlib.h> > ++//#include <string.h> > ++//#include <stdlib.h> > + > +-#include "windef.h" > +-#include "winbase.h" > +-#include "wingdi.h" > +-#include "winuser.h" > +-#include "winnls.h" > +-#include "commctrl.h" > +-#include "winerror.h" > +-#include "winreg.h" > ++#include <windef.h> > ++#include <winbase.h> > ++//#include "wingdi.h" > ++//#include "winuser.h" > ++#include <winnls.h> > ++//#include "commctrl.h" > ++//#include "winerror.h" > ++#include <winreg.h> > + #define NO_SHLWAPI_STREAM > +-#include "shlwapi.h" > ++#include <shlwapi.h> > + #include "comctl32.h" > +-#include "wine/debug.h" > ++#include <wine/debug.h> > > WINE_DEFAULT_DEBUG_CHANNEL(commctrl); > > @@ -22,7 +104,7 @@ > > static LRESULT WINAPI COMCTL32_SubclassProc (HWND hWnd, UINT uMsg, WPARAM wParam, LPARAM lParam); > > -@@ -92,6 +105,67 @@ > +@@ -92,6 +109,67 @@ static const WCHAR strCC32SubclassInfo[] > 'C','C','3','2','S','u','b','c','l','a','s','s','I','n','f','o',0 > }; > > @@ -90,7 +172,7 @@ > > /*********************************************************************** > * DllMain [Internal] > -@@ -930,6 +1004,12 @@ > +@@ -930,6 +1008,12 @@ HRESULT WINAPI DllGetVersion (DLLVERSION > HRESULT WINAPI DllInstall(BOOL bInstall, LPCWSTR cmdline) > { > TRACE("(%u, %s): stub\n", bInstall, debugstr_w(cmdline)); > @@ -103,7 +185,7 @@ > return S_OK; > } > > -@@ -1593,12 +1673,114 @@ > +@@ -1593,12 +1677,114 @@ LRESULT WINAPI SetPathWordBreakProc(HWND > * > * Draw text with shadow. > */ > @@ -222,7 +304,7 @@ > } > > /*********************************************************************** > -@@ -1821,3 +1821,15 @@ > +@@ -1639,3 +1825,15 @@ HRESULT WINAPI TaskDialogIndirect(const > if (pfVerificationFlagChecked) *pfVerificationFlagChecked = TRUE; > return S_OK; > } > @@ -239,11 +321,97 @@ > + return TRUE; > +} > > -Index: propsheet.c > -=================================================================== > ---- propsheet.c (revision 38890) > -+++ propsheet.c (working copy) > -@@ -2425,6 +2425,9 @@ > +diff -prudN e:\Wine\dlls\comctl32/listview.c e:\reactos\dll\win32\comctl32/listview.c > +--- e:\Wine\dlls\comctl32/listview.c 2013-03-16 11:54:52.374454400 +0100 > ++++ e:\reactos\dll\win32\comctl32/listview.c 2013-03-17 19:12:46.522399200 +0100 > +@@ -314,6 +314,7 @@ typedef struct tagLISTVIEW_INFO > + COLORREF clrBk; > + COLORREF clrText; > + COLORREF clrTextBk; > ++ BOOL bDefaultBkColor; > + > + /* font */ > + HFONT hDefaultFont; > +@@ -1700,8 +1701,19 @@ static inline BOOL LISTVIEW_GetItemW(con > + /* used to handle collapse main item column case */ > + static inline BOOL LISTVIEW_DrawFocusRect(const LISTVIEW_INFO *infoPtr, HDC hdc) > + { > +- return (infoPtr->rcFocus.left < infoPtr->rcFocus.right) ? > +- DrawFocusRect(hdc, &infoPtr->rcFocus) : FALSE; > ++ BOOL Ret = FALSE; > ++ > ++ if (infoPtr->rcFocus.left < infoPtr->rcFocus.right) > ++ { > ++ DWORD dwOldBkColor, dwOldTextColor; > ++ > ++ dwOldBkColor = SetBkColor(hdc, RGB(255, 255, 255)); > ++ dwOldTextColor = SetBkColor(hdc, RGB(0, 0, 0)); > ++ Ret = DrawFocusRect(hdc, &infoPtr->rcFocus); > ++ SetBkColor(hdc, dwOldBkColor); > ++ SetBkColor(hdc, dwOldTextColor); > ++ } > ++ return Ret; > + } > + > + /* Listview invalidation functions: use _only_ these functions to invalidate */ > +@@ -4734,7 +4746,10 @@ static BOOL LISTVIEW_DrawItem(LISTVIEW_I > + if (infoPtr->uView == LV_VIEW_DETAILS && infoPtr->dwLvExStyle & LVS_EX_GRIDLINES) > + rcLabel.bottom--; > + > +- DrawTextW(hdc, lvItem.pszText, -1, &rcLabel, uFormat); > ++ if ((!(lvItem.state & LVIS_SELECTED) || !infoPtr->bFocus) && (infoPtr->dwLvExStyle & LVS_EX_TRANSPARENTSHADOWTEXT)) > ++ DrawShadowText(hdc, lvItem.pszText, -1, &rcLabel, uFormat, RGB(255, 255, 255), RGB(0, 0, 0), 2, 2); > ++ else > ++ DrawTextW(hdc, lvItem.pszText, -1, &rcLabel, uFormat); > + > + postpaint: > + if (cdsubitemmode & CDRF_NOTIFYPOSTPAINT) > +@@ -5143,7 +5158,11 @@ enddraw: > + > + /* Draw marquee rectangle if appropriate */ > + if (infoPtr->bMarqueeSelect) > ++ { > ++ SetBkColor(hdc, RGB(255, 255, 255)); > ++ SetTextColor(hdc, RGB(0, 0, 0)); > + DrawFocusRect(hdc, &infoPtr->marqueeDrawRect); > ++ } > + > + if (cdmode & CDRF_NOTIFYPOSTPAINT) > + notify_postpaint(infoPtr, &nmlvcd); > +@@ -7952,6 +7971,7 @@ static BOOL LISTVIEW_SetBkColor(LISTVIEW > + { > + TRACE("(color=%x)\n", color); > + > ++ infoPtr->bDefaultBkColor = FALSE; > + if(infoPtr->clrBk != color) { > + if (infoPtr->clrBk != CLR_NONE) DeleteObject(infoPtr->hBkBrush); > + infoPtr->clrBk = color; > +@@ -9362,6 +9382,7 @@ static LRESULT LISTVIEW_NCCreate(HWND hw > + infoPtr->clrText = CLR_DEFAULT; > + infoPtr->clrTextBk = CLR_DEFAULT; > + LISTVIEW_SetBkColor(infoPtr, comctl32_color.clrWindow); > ++ infoPtr->bDefaultBkColor = TRUE; > + > + /* set default values */ > + infoPtr->nFocusedItem = -1; > +@@ -11644,6 +11665,12 @@ LISTVIEW_WindowProc(HWND hwnd, UINT uMsg > + > + case WM_SYSCOLORCHANGE: > + COMCTL32_RefreshSysColors(); > ++ if (infoPtr->bDefaultBkColor) > ++ { > ++ LISTVIEW_SetBkColor(infoPtr, comctl32_color.clrWindow); > ++ infoPtr->bDefaultBkColor = TRUE; > ++ LISTVIEW_InvalidateList(infoPtr); > ++ } > + return 0; > + > + /* case WM_TIMER: */ > + > +diff -prudN e:\Wine\dlls\comctl32/propsheet.c e:\reactos\dll\win32\comctl32/propsheet.c > +--- e:\Wine\dlls\comctl32/propsheet.c 2013-03-02 14:17:59.122793000 +0100 > ++++ e:\reactos\dll\win32\comctl32/propsheet.c 2013-03-16 12:21:47.383897000 +0100 > +@@ -2430,6 +2430,9 @@ static void PROPSHEET_SetWizButtons(HWND > HWND hwndBack = GetDlgItem(hwndDlg, IDC_BACK_BUTTON); > HWND hwndNext = GetDlgItem(hwndDlg, IDC_NEXT_BUTTON); > HWND hwndFinish = GetDlgItem(hwndDlg, IDC_FINISH_BUTTON); > @@ -253,7 +421,7 @@ > > TRACE("%d\n", dwFlags); > > -@@ -2432,17 +2435,6 @@ > +@@ -2437,17 +2440,6 @@ static void PROPSHEET_SetWizButtons(HWND > EnableWindow(hwndNext, FALSE); > EnableWindow(hwndFinish, FALSE); > > @@ -271,7 +439,7 @@ > if (dwFlags & PSWIZB_BACK) > EnableWindow(hwndBack, TRUE); > > -@@ -2472,6 +2464,22 @@ > +@@ -2477,6 +2469,22 @@ static void PROPSHEET_SetWizButtons(HWND > } > else if (!(dwFlags & PSWIZB_DISABLEDFINISH)) > EnableWindow(hwndFinish, TRUE); > @@ -294,20 +462,229 @@ > } > > /****************************************************************************** > -Index: tooltips.c > -=================================================================== > ---- tooltips.c (revision 38890) > -+++ tooltips.c (working copy) > -@@ -2488,8 +2488,33 @@ > +diff -prudN e:\Wine\dlls\comctl32/rebar.c e:\reactos\dll\win32\comctl32/rebar.c > +--- e:\Wine\dlls\comctl32/rebar.c 2013-03-02 14:17:59.125795000 +0100 > ++++ e:\reactos\dll\win32\comctl32/rebar.c 2013-09-02 13:40:15.983276500 +0100 > +@@ -51,7 +51,6 @@ > + * - WM_QUERYNEWPALETTE > + * - WM_RBUTTONDOWN > + * - WM_RBUTTONUP > +- * - WM_SYSCOLORCHANGE > + * - WM_VKEYTOITEM > + * - WM_WININICHANGE > + * Notifications: > + > +@@ -2544,10 +2543,8 @@ REBAR_InsertBandT(REBAR_INFO *infoPtr, I > + > + /* initialize band */ > + memset(lpBand, 0, sizeof(*lpBand)); > +- lpBand->clrFore = infoPtr->clrText == CLR_NONE ? infoPtr->clrBtnText : > +- infoPtr->clrText; > +- lpBand->clrBack = infoPtr->clrBk == CLR_NONE ? infoPtr->clrBtnFace : > +- infoPtr->clrBk; > ++ lpBand->clrFore = infoPtr->clrText; > ++ lpBand->clrBack = infoPtr->clrBk; > + lpBand->iImage = -1; > + > + REBAR_CommonSetupBand(infoPtr->hwndSelf, lprbbi, lpBand); > +@@ -2927,12 +2924,20 @@ REBAR_ShowBand (REBAR_INFO *infoPtr, INT > + > + > static LRESULT > - TOOLTIPS_NotifyFormat (HWND hwnd, WPARAM wParam, LPARAM lParam) > +-REBAR_SizeToRect (REBAR_INFO *infoPtr, const RECT *lpRect) > ++REBAR_SizeToRect (REBAR_INFO *infoPtr, WPARAM flags, RECT *lpRect) > { > -- FIXME ("hwnd=%p wParam=%lx lParam=%lx\n", hwnd, wParam, lParam); > -+ TOOLTIPS_INFO *infoPtr = TOOLTIPS_GetInfoPtr (hwnd); > + if (!lpRect) return FALSE; > + > + TRACE("[%s]\n", wine_dbgstr_rect(lpRect)); > + REBAR_SizeToHeight(infoPtr, get_rect_cy(infoPtr, lpRect)); > ++ > ++ /* Note that this undocumented flag is available on comctl32 v6 or later */ > ++ if ((flags & RBSTR_CHANGERECT) != 0) > ++ { > ++ RECT rcRebar; > ++ GetClientRect(infoPtr->hwndSelf, &rcRebar); > ++ lpRect->bottom = lpRect->top + (rcRebar.bottom - rcRebar.top); > ++ } > + return TRUE; > + } > + > +@@ -3713,7 +3718,7 @@ REBAR_WindowProc (HWND hwnd, UINT uMsg, > + return REBAR_ShowBand (infoPtr, wParam, lParam); > + > + case RB_SIZETORECT: > +- return REBAR_SizeToRect (infoPtr, (LPCRECT)lParam); > ++ return REBAR_SizeToRect (infoPtr, wParam, (LPRECT)lParam); > + > + > + /* Messages passed to parent */ > +@@ -3797,6 +3802,8 @@ REBAR_WindowProc (HWND hwnd, UINT uMsg, > + > + case WM_SYSCOLORCHANGE: > + COMCTL32_RefreshSysColors(); > ++ infoPtr->clrBtnText = comctl32_color.clrBtnText; > ++ infoPtr->clrBtnFace = comctl32_color.clrBtnFace; > + return 0; > + > + /* case WM_VKEYTOITEM: supported according to ControlSpy */ > + > +--- e:\Wine\dlls\comctl32/tests/v6util.h 2011-09-16 23:22:36.002769200 +0100 > ++++ e:\reactos\dll\win32\comctl32/tests/v6util.h 1970-01-01 01:00:00.000000000 +0100 > +@@ -1,142 +0,0 @@ > +-/* > +- * Utility routines for comctl32 v6 tests > +- * > +- * Copyright 2006 Mike McCormack for CodeWeavers > +- * Copyright 2007 George Gov > +- * Copyright 2009 Owen Rudge for CodeWeavers > +- * > +- * This library is free software; you can redistribute it and/or > +- * modify it under the terms of the GNU Lesser General Public > +- * License as published by the Free Software Foundation; either > +- * version 2.1 of the License, or (at your option) any later version. > +- * > +- * This library is distributed in the hope that it will be useful, > +- * but WITHOUT ANY WARRANTY; without even the implied warranty of > +- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > +- * Lesser General Public License for more details. > +- * > +- * You should have received a copy of the GNU Lesser General Public > +- * License along with this library; if not, write to the Free Software > +- * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA > +- */ > +- > +-#define expect(expected, got) ok(got == expected, "Expected %d, got %d\n", expected, got) > +- > +-#ifdef __i386__ > +-#define ARCH "x86" > +-#elif defined __x86_64__ > +-#define ARCH "amd64" > +-#else > +-#define ARCH "none" > +-#endif > +- > +-static const CHAR manifest_name[] = "cc6.manifest"; > +- > +-static const CHAR manifest[] = > +- "<?xml version=\"1.0\" encoding=\"UTF-8\" standalone=\"yes\"?>\n" > +- "<assembly xmlns=\"urn:schemas-microsoft-com:asm.v1\" manifestVersion=\"1.0\">\n" > +- " <assemblyIdentity\n" > +- " type=\"win32\"\n" > +- " name=\"Wine.ComCtl32.Tests\"\n" > +- " version=\"1.0.0.0\"\n" > +- " processorArchitecture=\"" ARCH "\"\n" > +- " />\n" > +- "<description>Wine comctl32 test suite</description>\n" > +- "<dependency>\n" > +- " <dependentAssembly>\n" > +- " <assemblyIdentity\n" > +- " type=\"win32\"\n" > +- " name=\"microsoft.windows.common-controls\"\n" > +- " version=\"6.0.0.0\"\n" > +- " processorArchitecture=\"" ARCH "\"\n" > +- " publicKeyToken=\"6595b64144ccf1df\"\n" > +- " language=\"*\"\n" > +- " />\n" > +- "</dependentAssembly>\n" > +- "</dependency>\n" > +- "</assembly>\n"; > +- > +-static void unload_v6_module(ULONG_PTR cookie, HANDLE hCtx) > +-{ > +- HANDLE hKernel32; > +- BOOL (WINAPI *pDeactivateActCtx)(DWORD, ULONG_PTR); > +- VOID (WINAPI *pReleaseActCtx)(HANDLE); > +- > +- hKernel32 = GetModuleHandleA("kernel32.dll"); > +- pDeactivateActCtx = (void*)GetProcAddress(hKernel32, "DeactivateActCtx"); > +- pReleaseActCtx = (void*)GetProcAddress(hKernel32, "ReleaseActCtx"); > +- if (!pDeactivateActCtx || !pReleaseActCtx) > +- { > +- win_skip("Activation contexts unsupported\n"); > +- return; > +- } > +- > +- pDeactivateActCtx(0, cookie); > +- pReleaseActCtx(hCtx); > +- > +- DeleteFileA(manifest_name); > +-} > +- > +-static BOOL load_v6_module(ULONG_PTR *pcookie, HANDLE *hCtx) > +-{ > +- HANDLE hKernel32; > +- HANDLE (WINAPI *pCreateActCtxA)(ACTCTXA*); > +- BOOL (WINAPI *pActivateActCtx)(HANDLE, ULONG_PTR*); > +- > +- ACTCTXA ctx; > +- BOOL ret; > +- HANDLE file; > +- DWORD written; > +- > +- hKernel32 = GetModuleHandleA("kernel32.dll"); > +- pCreateActCtxA = (void*)GetProcAddress(hKernel32, "CreateActCtxA"); > +- pActivateActCtx = (void*)GetProcAddress(hKernel32, "ActivateActCtx"); > +- if (!(pCreateActCtxA && pActivateActCtx)) > +- { > +- win_skip("Activation contexts unsupported. No version 6 tests possible.\n"); > +- return FALSE; > +- } > +- > +- /* create manifest */ > +- file = CreateFileA( manifest_name, GENERIC_WRITE, 0, NULL, CREATE_ALWAYS, 0, NULL ); > +- if (file != INVALID_HANDLE_VALUE) > +- { > +- ret = (WriteFile( file, manifest, sizeof(manifest)-1, &written, NULL ) && > +- written == sizeof(manifest)-1); > +- CloseHandle( file ); > +- if (!ret) > +- { > +- DeleteFileA( manifest_name ); > +- skip("Failed to fill manifest file. Skipping comctl32 V6 tests.\n"); > +- return FALSE; > +- } > +- else > +- trace("created %s\n", manifest_name); > +- } > +- else > +- { > +- skip("Failed to create manifest file. Skipping comctl32 V6 tests.\n"); > +- return FALSE; > +- } > +- > +- memset(&ctx, 0, sizeof(ctx)); > +- ctx.cbSize = sizeof(ctx); > +- ctx.lpSource = manifest_name; > +- > +- *hCtx = pCreateActCtxA(&ctx); > +- ok(*hCtx != 0, "Expected context handle\n"); > +- > +- ret = pActivateActCtx(*hCtx, pcookie); > +- expect(TRUE, ret); > +- > +- if (!ret) > +- { > +- win_skip("A problem during context activation occurred.\n"); > +- DeleteFileA(manifest_name); > +- } > +- > +- return ret; > +-} > +- > +-#undef expect > +-#undef ARCH > +diff -prudN e:\Wine\dlls\comctl32/tooltips.c e:\reactos\dll\win32\comctl32/tooltips.c > +--- e:\Wine\dlls\comctl32/tooltips.c 2013-03-02 14:17:59.178196600 +0100 > ++++ e:\reactos\dll\win32\comctl32/tooltips.c 2013-03-16 12:24:45.122483600 +0100 > +@@ -2002,7 +2002,32 @@ TOOLTIPS_NCHitTest (const TOOLTIPS_INFO > + static LRESULT > + TOOLTIPS_NotifyFormat (TOOLTIPS_INFO *infoPtr, WPARAM wParam, LPARAM lParam) > + { > +- FIXME ("hwnd=%p wParam=%lx lParam=%lx\n", infoPtr->hwndSelf, wParam, lParam); > + TTTOOL_INFO *toolPtr = infoPtr->tools; > -+ INT nResult; > - > -+ TRACE("hwnd=%p wParam=%lx lParam=%lx\n", hwnd, wParam, lParam); > ++ LRESULT nResult; > ++ > ++ TRACE("infoPtr=%p wParam=%lx lParam=%p\n", infoPtr, wParam, (PVOID)lParam); > + > + if (lParam == NF_QUERY) { > + if (toolPtr->bNotifyUnicode) { > @@ -317,8 +694,8 @@ > + } > + } > + else if (lParam == NF_REQUERY) { > -+ nResult = (INT) SendMessageW (toolPtr->hwnd, WM_NOTIFYFORMAT, > -+ (WPARAM)hwnd, (LPARAM)NF_QUERY); > ++ nResult = SendMessageW (toolPtr->hwnd, WM_NOTIFYFORMAT, > ++ (WPARAM)infoPtr->hwndSelf, (LPARAM)NF_QUERY); > + if (nResult == NFR_ANSI) { > + toolPtr->bNotifyUnicode = FALSE; > + TRACE(" -- WM_NOTIFYFORMAT returns: NFR_ANSI\n"); > @@ -330,14 +707,14 @@ > + } > + return nResult; > + } > + > return 0; > } > - > -Index: treeview.c > -=================================================================== > ---- treeview.c (revision 38890) > -+++ treeview.c (working copy) > -@@ -2830,7 +2830,12 @@ > + > +diff -prudN e:\Wine\dlls\comctl32/treeview.c e:\reactos\dll\win32\comctl32/treeview.c > +--- e:\Wine\dlls\comctl32/treeview.c 2013-03-02 14:17:59.181198600 +0100 > ++++ e:\reactos\dll\win32\comctl32/treeview.c 2013-03-16 12:26:03.285023200 +0100 > +@@ -2921,7 +2921,12 @@ TREEVIEW_Refresh(TREEVIEW_INFO *infoPtr, > } > } > > @@ -351,151 +728,3 @@ > > if (infoPtr->cdmode & CDRF_NOTIFYPOSTPAINT) > infoPtr->cdmode = > -Index: listview.c > -=================================================================== > ---- listview.c (revision 51320) > -+++ listview.c (working copy) > -@@ -315,6 +315,7 @@ > - COLORREF clrBk; > - COLORREF clrText; > - COLORREF clrTextBk; > -+ BOOL bDefaultBkColor; > - > - /* font */ > - HFONT hDefaultFont; > -@@ -1699,8 +1700,19 @@ > - /* used to handle collapse main item column case */ > - static inline BOOL LISTVIEW_DrawFocusRect(const LISTVIEW_INFO *infoPtr, HDC hdc) > - { > -- return (infoPtr->rcFocus.left < infoPtr->rcFocus.right) ? > -- DrawFocusRect(hdc, &infoPtr->rcFocus) : FALSE; > -+ BOOL Ret = FALSE; > -+ > -+ if (infoPtr->rcFocus.left < infoPtr->rcFocus.right) > -+ { > -+ DWORD dwOldBkColor, dwOldTextColor; > -+ > -+ dwOldBkColor = SetBkColor(hdc, RGB(255, 255, 255)); > -+ dwOldTextColor = SetBkColor(hdc, RGB(0, 0, 0)); > -+ Ret = DrawFocusRect(hdc, &infoPtr->rcFocus); > -+ SetBkColor(hdc, dwOldBkColor); > -+ SetBkColor(hdc, dwOldTextColor); > -+ } > -+ return Ret; > - } > - > - /* Listview invalidation functions: use _only_ these functions to invalidate */ > -@@ -4698,7 +4710,10 @@ > - if (infoPtr->uView == LV_VIEW_DETAILS && infoPtr->dwLvExStyle & LVS_EX_GRIDLINES) > - rcLabel.bottom--; > - > -- DrawTextW(hdc, lvItem.pszText, -1, &rcLabel, uFormat); > -+ if ((!(lvItem.state & LVIS_SELECTED) || !infoPtr->bFocus) && (infoPtr->dwLvExStyle & LVS_EX_TRANSPARENTSHADOWTEXT)) > -+ DrawShadowText(hdc, lvItem.pszText, -1, &rcLabel, uFormat, RGB(255, 255, 255), RGB(0, 0, 0), 2, 2); > -+ else > -+ DrawTextW(hdc, lvItem.pszText, -1, &rcLabel, uFormat); > - > - postpaint: > - if (cdsubitemmode & CDRF_NOTIFYPOSTPAINT) > -@@ -5117,7 +5132,11 @@ > - > - /* Draw marquee rectangle if appropriate */ > - if (infoPtr->bMarqueeSelect) > -+ { > -+ SetBkColor(hdc, RGB(255, 255, 255)); > -+ SetTextColor(hdc, RGB(0, 0, 0)); > - DrawFocusRect(hdc, &infoPtr->marqueeDrawRect); > -+ } > - > - if (cdmode & CDRF_NOTIFYPOSTPAINT) > - notify_postpaint(infoPtr, &nmlvcd); > -@@ -7927,6 +7946,7 @@ > - { > - TRACE("(color=%x)\n", color); > - > -+ infoPtr->bDefaultBkColor = FALSE; > - if(infoPtr->clrBk != color) { > - if (infoPtr->clrBk != CLR_NONE) DeleteObject(infoPtr->hBkBrush); > - infoPtr->clrBk = color; > -@@ -9314,6 +9334,7 @@ > - infoPtr->clrText = CLR_DEFAULT; > - infoPtr->clrTextBk = CLR_DEFAULT; > - LISTVIEW_SetBkColor(infoPtr, comctl32_color.clrWindow); > -+ infoPtr->bDefaultBkColor = TRUE; > - > - /* set default values */ > - infoPtr->nFocusedItem = -1; > -@@ -11570,6 +11591,12 @@ > - > - case WM_SYSCOLORCHANGE: > - COMCTL32_RefreshSysColors(); > -+ if (infoPtr->bDefaultBkColor) > -+ { > -+ LISTVIEW_SetBkColor(infoPtr, comctl32_color.clrWindow); > -+ infoPtr->bDefaultBkColor = TRUE; > -+ LISTVIEW_InvalidateList(infoPtr); > -+ } > - return 0; > - > - /* case WM_TIMER: */ > -Index: rebar.c > -=================================================================== > ---- rebar.c (revision 51320) > -+++ rebar.c (working copy) > -@@ -51,7 +51,6 @@ > - * - WM_QUERYNEWPALETTE > - * - WM_RBUTTONDOWN > - * - WM_RBUTTONUP > -- * - WM_SYSCOLORCHANGE > - * - WM_VKEYTOITEM > - * - WM_WININICHANGE > - * Notifications: > -@@ -2540,10 +2539,8 @@ > - > - /* initialize band */ > - memset(lpBand, 0, sizeof(*lpBand)); > -- lpBand->clrFore = infoPtr->clrText == CLR_NONE ? infoPtr->clrBtnText : > -- infoPtr->clrText; > -- lpBand->clrBack = infoPtr->clrBk == CLR_NONE ? infoPtr->clrBtnFace : > -- infoPtr->clrBk; > -+ lpBand->clrFore = infoPtr->clrText; > -+ lpBand->clrBack = infoPtr->clrBk; > - lpBand->iImage = -1; > - > - REBAR_CommonSetupBand(infoPtr->hwndSelf, lprbbi, lpBand); > -@@ -3793,6 +3790,8 @@ > - > - case WM_SYSCOLORCHANGE: > - COMCTL32_RefreshSysColors(); > -+ infoPtr->clrBtnText = comctl32_color.clrBtnText; > -+ infoPtr->clrBtnFace = comctl32_color.clrBtnFace; > - return 0; > - > - /* case WM_VKEYTOITEM: supported according to ControlSpy */ > -Index: monthcal.c > -=================================================================== > ---- monthcal.c (Revision 51719) > -+++ monthcal.c (Arbeitskopie) > -@@ -143,8 +143,8 @@ > - /* empty SYSTEMTIME const */ > - static const SYSTEMTIME st_null; > - /* valid date limits */ > --static const SYSTEMTIME max_allowed_date = { .wYear = 9999, .wMonth = 12, .wDay = 31 }; > --static const SYSTEMTIME min_allowed_date = { .wYear = 1752, .wMonth = 9, .wDay = 14 }; > -+static const SYSTEMTIME max_allowed_date = { 9999, 12, 0, 31, 0, 0, 0, 0 }; > -+static const SYSTEMTIME min_allowed_date = { 1752, 9, 0, 14, 0, 0, 0, 0 }; > - > - /* Prev/Next buttons */ > - enum nav_direction > -Index: comctl32.spec > -=================================================================== > ---- comctl32.spec (revision 56653) > -+++ comctl32.spec (working copy) > -@@ -188,6 +188,7 @@ > - @ stdcall PropertySheet(ptr) PropertySheetA > - @ stdcall PropertySheetA(ptr) > - @ stdcall PropertySheetW(ptr) > -+@ stdcall RegisterClassNameW(wstr) > - @ stdcall TaskDialogIndirect(ptr ptr ptr ptr) > - @ stdcall UninitializeFlatSB(long) > - @ stdcall _TrackMouseEvent(ptr) > > Modified: trunk/reactos/dll/win32/comctl32/rebar.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/comctl32/rebar.c… > ============================================================================== > --- trunk/reactos/dll/win32/comctl32/rebar.c [iso-8859-1] (original) > +++ trunk/reactos/dll/win32/comctl32/rebar.c [iso-8859-1] Mon Sep 2 12:56:20 2013 > @@ -2924,12 +2924,20 @@ > > > static LRESULT > -REBAR_SizeToRect (REBAR_INFO *infoPtr, const RECT *lpRect) > +REBAR_SizeToRect (REBAR_INFO *infoPtr, WPARAM flags, RECT *lpRect) > { > if (!lpRect) return FALSE; > > TRACE("[%s]\n", wine_dbgstr_rect(lpRect)); > REBAR_SizeToHeight(infoPtr, get_rect_cy(infoPtr, lpRect)); > + > + /* Note that this undocumented flag is available on comctl32 v6 or later */ > + if ((flags & RBSTR_CHANGERECT) != 0) > + { > + RECT rcRebar; > + GetClientRect(infoPtr->hwndSelf, &rcRebar); > + lpRect->bottom = lpRect->top + (rcRebar.bottom - rcRebar.top); > + } > return TRUE; > } > > @@ -3710,7 +3718,7 @@ > return REBAR_ShowBand (infoPtr, wParam, lParam); > > case RB_SIZETORECT: > - return REBAR_SizeToRect (infoPtr, (LPCRECT)lParam); > + return REBAR_SizeToRect (infoPtr, wParam, (LPRECT)lParam); > > > /* Messages passed to parent */ > >

1 0

Paint for ROS
by Hermès BÉLUSCA - MAÏTO 01 Sep '13

01 Sep '13

Nice! @ Benedikt: You have some bug reports on Jira concerning Paint, which need some love :) (CORE-5641, CORE-5645, CORE-5644 and CORE-5954) . I don't know whether your commit fixes one of them. Hermès ---------------------------------------------------------------------------- ---------------------------------------------------------- Author: bfreisen Date: Sun Sep 1 20:13:15 2013 New Revision: 59954 URL: http://svn.reactos.org/svn/reactos?rev=59954&view=rev Log: [PAINT] * Stretch/Skew dialog fully implemented (skewing not yet functional), please check translations * pre Windows Vista MSPaint palette selectable via menu entry * Attributes dialog supports setting width and height in inches and cm also * drawing functions improved * some variables grouped into structs * Changed SendMessage(... WM_PAINT ...) into InvalidateRect(...), this is the way it should be and it fixes half of the repainting bugs Added: [...]

1 0

Re: [ros-dev] Easy job for enhancing our Explorer!
by Ameer Ali 01 Sep '13

01 Sep '13

Hi, I have some great icon with me.... If U request I will give for free Sent from my linux Phone From: Colin Finck Sent: 31-08-2013 PM 03:36 To: ros-dev(a)reactos.org Subject: [ros-dev] Easy job for enhancing our Explorer! Hi all! As suggested in the meeting on Thursday, we need someone to create replacements for all icons used in Windows Explorer. Just have a look at this screenshot of Giannis' recent work to get an idea: http://i.imgur.com/WzxVn7V.png It definitely looks promising, but we obviously can't release it with the XP icons ;) Gladly, the Tango icon library contains a lot of great icons, which may already be suitable for Explorer. Others could be created easily when mixing several icons. For example, the icon for the "Folders" button in Explorer can be created out of two simple folders, and a single folder icon is definitely present in Tango. This only requires basic knowledge of Inkscape (www.inkscape.org). To give you another example: I already needed such "mixed" icons in my PeopleMap. I've released my modified SVG files here: http://svn.reactos.org/svn/web/trunk/resources/peoplemap/?pathrev=700 Apart from the fairly simple Inkscape task, the icons need to be properly converted to ICO files in all required sizes. Giannis or other shell guys can probably tell you about the sizes we need. At least, this requires a proper icon editor with support for 24/32 bit icons (used to be a problem in the past, don't know if it still is). For just creating ICO files out of existing PNG files, I had good experiences with "@icon sushi" (http://www.towofu.net/soft/e-aicon.php). So, there we have it: A job for enhancing our Explorer which doesn't even need a developer! :) If I had time for it, I'd probably do it myself, but I'm pretty sure there are other interested people as well. Cheers, Colin _______________________________________________ Ros-dev mailing list Ros-dev(a)reactos.org http://www.reactos.org/mailman/listinfo/ros-dev

4 3

Easy job for enhancing our Explorer!
by Colin Finck 31 Aug '13

31 Aug '13

Hi all! As suggested in the meeting on Thursday, we need someone to create replacements for all icons used in Windows Explorer. Just have a look at this screenshot of Giannis' recent work to get an idea: http://i.imgur.com/WzxVn7V.png It definitely looks promising, but we obviously can't release it with the XP icons ;) Gladly, the Tango icon library contains a lot of great icons, which may already be suitable for Explorer. Others could be created easily when mixing several icons. For example, the icon for the "Folders" button in Explorer can be created out of two simple folders, and a single folder icon is definitely present in Tango. This only requires basic knowledge of Inkscape (www.inkscape.org). To give you another example: I already needed such "mixed" icons in my PeopleMap. I've released my modified SVG files here: http://svn.reactos.org/svn/web/trunk/resources/peoplemap/?pathrev=700 Apart from the fairly simple Inkscape task, the icons need to be properly converted to ICO files in all required sizes. Giannis or other shell guys can probably tell you about the sizes we need. At least, this requires a proper icon editor with support for 24/32 bit icons (used to be a problem in the past, don't know if it still is). For just creating ICO files out of existing PNG files, I had good experiences with "@icon sushi" (http://www.towofu.net/soft/e-aicon.php). So, there we have it: A job for enhancing our Explorer which doesn't even need a developer! :) If I had time for it, I'd probably do it myself, but I'm pretty sure there are other interested people as well. Cheers, Colin

1 0

Status Meeting (August 2013)
by Aleksey Bragin 29 Aug '13

29 Aug '13

Hello, Let me invite you to the monthly status meeting taking place last Thursday of this month, 29th of August, 19:00 UTC. Put that into your calendars so you don't forget. IRC service will only be started shortly before the meeting. Your participation passwords and server address will be emailed to you shortly before the meeting starts, and they are going to be different once again as they are not stored in any database. Hopefully it's not much of inconvenience. If someone still is not getting passwords sent before a meeting - please email Colin or Pierre before the meeting started to get one. The agenda will be posted shortly before the meeting, suggestions are welcome (send them to me shortly before the meeting starts). Regards, Aleksey Bragin

2 1

Re: [ros-dev] Ros-dev Digest, Vol 108, Issue 10
by "Железов Михаил" 29 Aug '13

29 Aug '13

Я не проверяю этот почтовый ящик. Новый email: mikezhelezov(a)gmail.com. Пожалуйста, не отвечайте на это письмо.

2 1

[ADVAPI32/SERVICES]: Windows services
by Eric Kohl 28 Aug '13

28 Aug '13

>[ADVAPI32/SERVICES]: Windows services (as per MSDN and testing) must always get at least one parameter -- the service name, in the argument vector. However, in ReactOS, unless optional custom parameters were sent (when starting a service), services got 0 parameters and a NULL argument vector. Since services on Windows know this is impossible, many dereference the vector without checking for NULL (including Windows Svchost.exe). Either way, it's bogus for us not ever sending the name as the first parameter. So I fixed ScBuildUnicodeArgsVector to always either pre-pend the service name (if the caller gave us some parameters already), or do use the name as the sole parameter (if the caller sent none). This now works as on Windows, and should greately help with 3rd party service compatibility. >***NOTE THAT I ONLY DID THIS FOR UNICODE. I DID NOT BOTHER TO FIX THE ANSI VERSION. ERIC KOHL, PLEASE REVIEW & FIX AS APPROPRIATE*** Alex, if you have the time to rewrite svchost, you also have the time to fix the little piece of ansi boredom! Finish the things you start!!!! Do not stop right in the middle and leave the boring parts to others!!! FINISH IT YOURSELF!!!! PS: Btw, you might want to have a look at YOUR ntoskrnl rewrite! CM is still unfinished! Finish it before you open yet another can of worms! Regards, Eric

1 0

Re: [ros-dev] Ros-dev Digest, Vol 108, Issue 9
by "Железов Михаил" 28 Aug '13

28 Aug '13

Я не проверяю этот почтовый ящик. Новый email: mikezhelezov(a)gmail.com. Пожалуйста, не отвечайте на это письмо.

1 0

Re: [ros-dev] [ros-diffs] [fireball] 59733: [WIN32K] - Do not use a internal section object structure type, it's just not necessary and win32k should not ever need to access its fields directly.
by Timo Kreuzer 14 Aug '13

14 Aug '13

\o/ And now please also remove the use of the OBJECT_HEADER structure in win32k ;-) Am 14.08.2013 13:02, schrieb fireball(a)svn.reactos.org: > Author: fireball > Date: Wed Aug 14 11:02:08 2013 > New Revision: 59733 > > URL: http://svn.reactos.org/svn/reactos?rev=59733&view=rev > Log: > [WIN32K] > - Do not use a internal section object structure type, it's just not necessary and win32k should not ever need to access its fields directly. > >

1 0

Re: [ros-dev] [ros-diffs] [cgutman] 59704: [CMAKE] - Define i386 on x86 MSVC builds - Probably fixes the infamous MSVC networking issues caused by tcpip.h assuming it was a big-endian platform and never byte-swapping anythi...
by Timo Kreuzer 12 Aug '13

12 Aug '13

I remember some time ago, I ran into a problem with "i386" definition somewhere, because it was used in a structure or something. I would prefer to use standard definitions as much as possible. And in the case of Windows code, I would consider MS to be standard. So IMO we should use _X86_ or _M_IX86 whenever possible. Am 12.08.2013 03:12, schrieb cgutman(a)svn.reactos.org: > Author: cgutman > Date: Mon Aug 12 01:12:25 2013 > New Revision: 59704 > > URL: http://svn.reactos.org/svn/reactos?rev=59704&view=rev > Log: > [CMAKE] > - Define i386 on x86 MSVC builds > - Probably fixes the infamous MSVC networking issues caused by tcpip.h assuming it was a big-endian platform and never byte-swapping anything > [TCPIP][LAN] > - Fix byteswapping on AMD64 and ARM builds too > > Modified: > trunk/reactos/CMakeLists.txt > trunk/reactos/drivers/network/lan/include/net_wh.h > trunk/reactos/drivers/network/tcpip/include/tcpip.h > > Modified: trunk/reactos/CMakeLists.txt > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/CMakeLists.txt?rev=59704&r… > ============================================================================== > --- trunk/reactos/CMakeLists.txt [iso-8859-1] (original) > +++ trunk/reactos/CMakeLists.txt [iso-8859-1] Mon Aug 12 01:12:25 2013 > @@ -142,7 +142,7 @@ > > # Arch Options > if(ARCH STREQUAL "i386") > - add_definitions(-D_M_IX86 -D_X86_ -D__i386__) > + add_definitions(-D_M_IX86 -D_X86_ -D__i386__ -Di386) > elseif(ARCH STREQUAL "amd64") > add_definitions(-D_M_AMD64 -D_AMD64_ -D__x86_64__ -D_WIN64) > elseif(ARCH STREQUAL "arm") > > Modified: trunk/reactos/drivers/network/lan/include/net_wh.h > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/network/lan/includ… > ============================================================================== > --- trunk/reactos/drivers/network/lan/include/net_wh.h [iso-8859-1] (original) > +++ trunk/reactos/drivers/network/lan/include/net_wh.h [iso-8859-1] Mon Aug 12 01:12:25 2013 > @@ -1,6 +1,6 @@ > #pragma once > > -#ifdef i386 > +#if defined(i386) || defined(_AMD64_) || defined(_ARM_) > > /* DWORD network to host byte order conversion for i386 */ > #define DN2H(dw) \ > @@ -26,7 +26,7 @@ > ((((w) & 0xFF00) >> 8) | \ > (((w) & 0x00FF) << 8)) > > -#else /* i386 */ > +#else /* defined(i386) || defined(_AMD64_) || defined(_ARM_) */ > > /* DWORD network to host byte order conversion for other architectures */ > #define DN2H(dw) \ > @@ -44,4 +44,4 @@ > #define WH2N(w) \ > (w) > > -#endif /* i386 */ > +#endif /* defined(i386) || defined(_AMD64_) || defined(_ARM_) */ > > Modified: trunk/reactos/drivers/network/tcpip/include/tcpip.h > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/network/tcpip/incl… > ============================================================================== > --- trunk/reactos/drivers/network/tcpip/include/tcpip.h [iso-8859-1] (original) > +++ trunk/reactos/drivers/network/tcpip/include/tcpip.h [iso-8859-1] Mon Aug 12 01:12:25 2013 > @@ -65,7 +65,7 @@ > #define NDIS_BUFFER_TAG FOURCC('n','b','u','f') > #define NDIS_PACKET_TAG FOURCC('n','p','k','t') > > -#ifdef i386 > +#if defined(i386) || defined(_AMD64_) || defined(_ARM_) > > /* DWORD network to host byte order conversion for i386 */ > #define DN2H(dw) \ > @@ -91,7 +91,7 @@ > ((((w) & 0xFF00) >> 8) | \ > (((w) & 0x00FF) << 8)) > > -#else /* i386 */ > +#else /* defined(i386) || defined(_AMD64_) || defined(_ARM_) */ > > #error Unsupported architecture > > @@ -111,7 +111,7 @@ > #define WH2N(w) \ > (w) > > -#endif /* i386 */ > +#endif /* defined(i386) || defined(_AMD64_) || defined(_ARM_) */ > > /* AF_INET and other things Arty likes to use ;) */ > #define AF_INET 2 > > >

2 1

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev