- Ros-dev - ReactOS.org

by Pierre Schweitzer

Hi, the Linux builder RosBE has been upgraded to latest 2.1. It keeps using ninja for builds. With my best regards, -- Pierre Schweitzer <pierre(a)reactos.org> System Administrator ReactOS Foundation

12 years, 3 months

1
2
0 0

Status Meeting (May 2013)

by Aleksey Bragin

Hello, Let me invite you to the monthly status meeting taking place last Thursday of this month, 30th of May, 19:00 UTC. And that's today! The meeting will be at irc://dev.reactos.org (Port 6667, no SSL) in the channel #meeting, or as Pierre says. Note that the IRC service will only be started shortly before the meeting. Your participation passwords will be emailed to you shortly before the meeting starts, and they are going to be different once again as they are not stored in any database. Hopefully it's not much of inconvenience. If someone still is not getting passwords sent before a meeting - please email Colin or Pierre before the meeting started to get one. The agenda will be posted shortly before the meeting, suggestions are welcome (send them to me shortly before the meeting starts). Regards, Aleksey Bragin

12 years, 3 months

2
1
0 0

MIDL Support

by J. C. Jones

Hi Amine, I am having some problems with the compilation of the .IDL files of psdk. In particular, a two weeks ago, I tried to compile psdk using MIDL instead of WIDL, and there were no warnings or errors. Then, recently, apparently after a WINE sync, I had some problems that are shown below. I notice that there is a file called midl-support in the cmake directory, so I wanted to know if it is true that cmake was also meant to support MIDL. The most interesting error generated by the compiler seems to come from an extraneous backslash in mshtml.idl. I am also curious to know if MIDL should be able to compile the files without problems. Here is what is causing the #define warnings, at least: 1. MIDL.EXE is invoked against msxml.idl 2. msxml.idl #include's msxml2did.h 3. msxml2did.h does #define DISPID_DOM_BASE 1 at line 69 4. msxml.idl #include's xmldom.idl 5. xmldom.idl #include's xmldomid.h 6. xmldomid.h does #define DISPID_DOM_BASE 1 line 22 * there are no #defines to control the flow. Thanks a lot! A.B.T., John 1>------ Build started: Project: psdk, Configuration: Debug Win32 ------ 1> Processing .\mshtml.idl 1> mshtml.idl 1> Processing .\ocidl.idl 1> ocidl.idl 1> Processing .\oleidl.idl 1> oleidl.idl 1> Processing .\objidl.idl 1> objidl.idl 1> Processing .\unknwn.idl 1> unknwn.idl 1> Processing .\wtypes.idl 1> wtypes.idl 1> Processing .\basetsd.h 1> basetsd.h 1> Processing .\guiddef.h 1> guiddef.h 1> Processing .\oaidl.idl 1> oaidl.idl 1> Processing .\servprov.idl 1> servprov.idl 1> Processing .\urlmon.idl 1> urlmon.idl 1> Processing .\msxml.idl 1> msxml.idl 1>.\xmldomdid.h(22): warning C4005: 'DISPID_DOM_BASE' : macro redefinition 1> .\msxml2did.h(69) : see previous definition of 'DISPID_DOM_BASE' 1>.\xmldomdid.h(23): warning C4005: 'DISPID_DOM_COLLECTION_BASE' : macro redefinition 1> .\msxml2did.h(70) : see previous definition of 'DISPID_DOM_COLLECTION_BASE' 1>.\xmldomdid.h(24): warning C4005: 'DISPID_DOM_COLLECTION_MAX' : macro redefinition 1> .\msxml2did.h(71) : see previous definition of 'DISPID_DOM_COLLECTION_MAX' 1>.\xmldomdid.h(26): warning C4005: 'DISPID_DOM_NODE' : macro redefinition 1> .\msxml2did.h(73) : see previous definition of 'DISPID_DOM_NODE' 1>.\xmldomdid.h(27): warning C4005: 'DISPID_DOM_NODE_NODENAME' : macro redefinition 1> .\msxml2did.h(74) : see previous definition of 'DISPID_DOM_NODE_NODENAME' 1>.\xmldomdid.h(28): warning C4005: 'DISPID_DOM_NODE_NODEVALUE' : macro redefinition 1> .\msxml2did.h(75) : see previous definition of 'DISPID_DOM_NODE_NODEVALUE' 1>.\xmldomdid.h(29): warning C4005: 'DISPID_DOM_NODE_NODETYPE' : macro redefinition 1> .\msxml2did.h(76) : see previous definition of 'DISPID_DOM_NODE_NODETYPE' 1>.\xmldomdid.h(30): warning C4005: 'DISPID_DOM_NODE_NODETYPEENUM' : macro redefinition 1> .\msxml2did.h(77) : see previous definition of 'DISPID_DOM_NODE_NODETYPEENUM' 1>.\xmldomdid.h(31): warning C4005: 'DISPID_DOM_NODE_PARENTNODE' : macro redefinition 1> .\msxml2did.h(78) : see previous definition of 'DISPID_DOM_NODE_PARENTNODE' 1>.\xmldomdid.h(32): warning C4005: 'DISPID_DOM_NODE_CHILDNODES' : macro redefinition 1> .\msxml2did.h(79) : see previous definition of 'DISPID_DOM_NODE_CHILDNODES' 1>.\xmldomdid.h(33): warning C4005: 'DISPID_DOM_NODE_FIRSTCHILD' : macro redefinition 1> .\msxml2did.h(80) : see previous definition of 'DISPID_DOM_NODE_FIRSTCHILD' 1>.\xmldomdid.h(34): warning C4005: 'DISPID_DOM_NODE_LASTCHILD' : macro redefinition 1> .\msxml2did.h(81) : see previous definition of 'DISPID_DOM_NODE_LASTCHILD' 1>.\xmldomdid.h(35): warning C4005: 'DISPID_DOM_NODE_PREVIOUSSIBLING' : macro redefinition 1> .\msxml2did.h(82) : see previous definition of 'DISPID_DOM_NODE_PREVIOUSSIBLING' 1>.\xmldomdid.h(36): warning C4005: 'DISPID_DOM_NODE_NEXTSIBLING' : macro redefinition 1> .\msxml2did.h(83) : see previous definition of 'DISPID_DOM_NODE_NEXTSIBLING' 1>.\xmldomdid.h(37): warning C4005: 'DISPID_DOM_NODE_ATTRIBUTES' : macro redefinition 1> .\msxml2did.h(84) : see previous definition of 'DISPID_DOM_NODE_ATTRIBUTES' 1>.\xmldomdid.h(38): warning C4005: 'DISPID_DOM_NODE_INSERTBEFORE' : macro redefinition 1> .\msxml2did.h(85) : see previous definition of 'DISPID_DOM_NODE_INSERTBEFORE' 1>.\xmldomdid.h(39): warning C4005: 'DISPID_DOM_NODE_REPLACECHILD' : macro redefinition 1> .\msxml2did.h(86) : see previous definition of 'DISPID_DOM_NODE_REPLACECHILD' 1>.\xmldomdid.h(40): warning C4005: 'DISPID_DOM_NODE_REMOVECHILD' : macro redefinition 1> .\msxml2did.h(87) : see previous definition of 'DISPID_DOM_NODE_REMOVECHILD' 1>.\xmldomdid.h(41): warning C4005: 'DISPID_DOM_NODE_APPENDCHILD' : macro redefinition 1> .\msxml2did.h(88) : see previous definition of 'DISPID_DOM_NODE_APPENDCHILD' 1>.\xmldomdid.h(42): warning C4005: 'DISPID_DOM_NODE_HASCHILDNODES' : macro redefinition 1> .\msxml2did.h(89) : see previous definition of 'DISPID_DOM_NODE_HASCHILDNODES' 1>.\xmldomdid.h(43): warning C4005: 'DISPID_DOM_NODE_OWNERDOC' : macro redefinition 1> .\msxml2did.h(90) : see previous definition of 'DISPID_DOM_NODE_OWNERDOC' 1>.\xmldomdid.h(44): warning C4005: 'DISPID_DOM_NODE_CLONENODE' : macro redefinition 1> .\msxml2did.h(91) : see previous definition of 'DISPID_DOM_NODE_CLONENODE' 1>.\xmldomdid.h(46): warning C4005: 'DISPID_XMLDOM_NODE' : macro redefinition 1> .\msxml2did.h(93) : see previous definition of 'DISPID_XMLDOM_NODE' 1>.\xmldomdid.h(47): warning C4005: 'DISPID_XMLDOM_NODE_STRINGTYPE' : macro redefinition 1> .\msxml2did.h(94) : see previous definition of 'DISPID_XMLDOM_NODE_STRINGTYPE' 1>.\xmldomdid.h(48): warning C4005: 'DISPID_XMLDOM_NODE_SPECIFIED' : macro redefinition 1> .\msxml2did.h(95) : see previous definition of 'DISPID_XMLDOM_NODE_SPECIFIED' 1>.\xmldomdid.h(49): warning C4005: 'DISPID_XMLDOM_NODE_DEFINITION' : macro redefinition 1> .\msxml2did.h(96) : see previous definition of 'DISPID_XMLDOM_NODE_DEFINITION' 1>.\xmldomdid.h(50): warning C4005: 'DISPID_XMLDOM_NODE_TEXT' : macro redefinition 1> .\msxml2did.h(97) : see previous definition of 'DISPID_XMLDOM_NODE_TEXT' 1>.\xmldomdid.h(51): warning C4005: 'DISPID_XMLDOM_NODE_NODETYPEDVALUE' : macro redefinition 1> .\msxml2did.h(98) : see previous definition of 'DISPID_XMLDOM_NODE_NODETYPEDVALUE' 1>.\xmldomdid.h(52): warning C4005: 'DISPID_XMLDOM_NODE_DATATYPE' : macro redefinition 1> .\msxml2did.h(99) : see previous definition of 'DISPID_XMLDOM_NODE_DATATYPE' 1>.\xmldomdid.h(53): warning C4005: 'DISPID_XMLDOM_NODE_XML' : macro redefinition 1> .\msxml2did.h(100) : see previous definition of 'DISPID_XMLDOM_NODE_XML' 1>.\xmldomdid.h(54): warning C4005: 'DISPID_XMLDOM_NODE_TRANSFORMNODE' : macro redefinition 1> .\msxml2did.h(101) : see previous definition of 'DISPID_XMLDOM_NODE_TRANSFORMNODE' 1>.\xmldomdid.h(55): warning C4005: 'DISPID_XMLDOM_NODE_SELECTNODES' : macro redefinition 1> .\msxml2did.h(102) : see previous definition of 'DISPID_XMLDOM_NODE_SELECTNODES' 1>.\xmldomdid.h(56): warning C4005: 'DISPID_XMLDOM_NODE_SELECTSINGLENODE' : macro redefinition 1> .\msxml2did.h(103) : see previous definition of 'DISPID_XMLDOM_NODE_SELECTSINGLENODE' 1>.\xmldomdid.h(57): warning C4005: 'DISPID_XMLDOM_NODE_PARSED' : macro redefinition 1> .\msxml2did.h(104) : see previous definition of 'DISPID_XMLDOM_NODE_PARSED' 1>.\xmldomdid.h(58): warning C4005: 'DISPID_XMLDOM_NODE_NAMESPACE' : macro redefinition 1> .\msxml2did.h(105) : see previous definition of 'DISPID_XMLDOM_NODE_NAMESPACE' 1>.\xmldomdid.h(59): warning C4005: 'DISPID_XMLDOM_NODE_PREFIX' : macro redefinition 1> .\msxml2did.h(106) : see previous definition of 'DISPID_XMLDOM_NODE_PREFIX' 1>.\xmldomdid.h(60): warning C4005: 'DISPID_XMLDOM_NODE_BASENAME' : macro redefinition 1> .\msxml2did.h(107) : see previous definition of 'DISPID_XMLDOM_NODE_BASENAME' 1>.\xmldomdid.h(61): warning C4005: 'DISPID_XMLDOM_NODE_TRANSFORMNODETOOBJECT' : macro redefinition 1> .\msxml2did.h(108) : see previous definition of 'DISPID_XMLDOM_NODE_TRANSFORMNODETOOBJECT' 1>.\xmldomdid.h(62): warning C4005: 'DISPID_XMLDOM_NODE__TOP' : macro redefinition 1> .\msxml2did.h(109) : see previous definition of 'DISPID_XMLDOM_NODE__TOP' 1>.\xmldomdid.h(64): warning C4005: 'DISPID_DOM_DOCUMENT' : macro redefinition 1> .\msxml2did.h(111) : see previous definition of 'DISPID_DOM_DOCUMENT' 1>.\xmldomdid.h(65): warning C4005: 'DISPID_DOM_DOCUMENT_DOCTYPE' : macro redefinition 1> .\msxml2did.h(112) : see previous definition of 'DISPID_DOM_DOCUMENT_DOCTYPE' 1>.\xmldomdid.h(66): warning C4005: 'DISPID_DOM_DOCUMENT_IMPLEMENTATION' : macro redefinition 1> .\msxml2did.h(113) : see previous definition of 'DISPID_DOM_DOCUMENT_IMPLEMENTATION' 1>.\xmldomdid.h(67): warning C4005: 'DISPID_DOM_DOCUMENT_DOCUMENTELEMENT' : macro redefinition 1> .\msxml2did.h(114) : see previous definition of 'DISPID_DOM_DOCUMENT_DOCUMENTELEMENT' 1>.\xmldomdid.h(68): warning C4005: 'DISPID_DOM_DOCUMENT_CREATEELEMENT' : macro redefinition 1> .\msxml2did.h(115) : see previous definition of 'DISPID_DOM_DOCUMENT_CREATEELEMENT' 1>.\xmldomdid.h(69): warning C4005: 'DISPID_DOM_DOCUMENT_CREATEDOCUMENTFRAGMENT' : macro redefinition 1> .\msxml2did.h(116) : see previous definition of 'DISPID_DOM_DOCUMENT_CREATEDOCUMENTFRAGMENT' 1>.\xmldomdid.h(70): warning C4005: 'DISPID_DOM_DOCUMENT_CREATETEXTNODE' : macro redefinition 1> .\msxml2did.h(117) : see previous definition of 'DISPID_DOM_DOCUMENT_CREATETEXTNODE' 1>.\xmldomdid.h(71): warning C4005: 'DISPID_DOM_DOCUMENT_CREATECOMMENT' : macro redefinition 1> .\msxml2did.h(118) : see previous definition of 'DISPID_DOM_DOCUMENT_CREATECOMMENT' 1>.\xmldomdid.h(72): warning C4005: 'DISPID_DOM_DOCUMENT_CREATECDATASECTION' : macro redefinition 1> .\msxml2did.h(119) : see previous definition of 'DISPID_DOM_DOCUMENT_CREATECDATASECTION' 1>.\xmldomdid.h(73): warning C4005: 'DISPID_DOM_DOCUMENT_CREATEPROCESSINGINSTRUCTION' : macro redefinition 1> .\msxml2did.h(120) : see previous definition of 'DISPID_DOM_DOCUMENT_CREATEPROCESSINGINSTRUCTION' 1>.\xmldomdid.h(74): warning C4005: 'DISPID_DOM_DOCUMENT_CREATEATTRIBUTE' : macro redefinition 1> .\msxml2did.h(121) : see previous definition of 'DISPID_DOM_DOCUMENT_CREATEATTRIBUTE' 1>.\xmldomdid.h(75): warning C4005: 'DISPID_DOM_DOCUMENT_CREATEENTITY' : macro redefinition 1> .\msxml2did.h(122) : see previous definition of 'DISPID_DOM_DOCUMENT_CREATEENTITY' 1>.\xmldomdid.h(76): warning C4005: 'DISPID_DOM_DOCUMENT_CREATEENTITYREFERENCE' : macro redefinition 1> .\msxml2did.h(123) : see previous definition of 'DISPID_DOM_DOCUMENT_CREATEENTITYREFERENCE' 1>.\xmldomdid.h(77): warning C4005: 'DISPID_DOM_DOCUMENT_GETELEMENTSBYTAGNAME' : macro redefinition 1> .\msxml2did.h(124) : see previous definition of 'DISPID_DOM_DOCUMENT_GETELEMENTSBYTAGNAME' 1>.\xmldomdid.h(78): warning C4005: 'DISPID_DOM_DOCUMENT_TOP' : macro redefinition 1> .\msxml2did.h(125) : see previous definition of 'DISPID_DOM_DOCUMENT_TOP' 1>.\xmldomdid.h(80): warning C4005: 'DISPID_XMLDOM_DOCUMENT' : macro redefinition 1> .\msxml2did.h(127) : see previous definition of 'DISPID_XMLDOM_DOCUMENT' 1>.\xmldomdid.h(81): warning C4005: 'DISPID_XMLDOM_DOCUMENT_DOCUMENTNODE' : macro redefinition 1> .\msxml2did.h(128) : see previous definition of 'DISPID_XMLDOM_DOCUMENT_DOCUMENTNODE' 1>.\xmldomdid.h(82): warning C4005: 'DISPID_XMLDOM_DOCUMENT_CREATENODE' : macro redefinition 1> .\msxml2did.h(129) : see previous definition of 'DISPID_XMLDOM_DOCUMENT_CREATENODE' 1>.\xmldomdid.h(83): warning C4005: 'DISPID_XMLDOM_DOCUMENT_CREATENODEEX' : macro redefinition 1> .\msxml2did.h(130) : see previous definition of 'DISPID_XMLDOM_DOCUMENT_CREATENODEEX' 1>.\xmldomdid.h(84): warning C4005: 'DISPID_XMLDOM_DOCUMENT_NODEFROMID' : macro redefinition 1> .\msxml2did.h(131) : see previous definition of 'DISPID_XMLDOM_DOCUMENT_NODEFROMID' 1>.\xmldomdid.h(85): warning C4005: 'DISPID_XMLDOM_DOCUMENT_DOCUMENTNAMESPACES' : macro redefinition 1> .\msxml2did.h(132) : see previous definition of 'DISPID_XMLDOM_DOCUMENT_DOCUMENTNAMESPACES' 1>.\xmldomdid.h(86): warning C4005: 'DISPID_XMLDOM_DOCUMENT_LOAD' : macro redefinition 1> .\msxml2did.h(133) : see previous definition of 'DISPID_XMLDOM_DOCUMENT_LOAD' 1>.\xmldomdid.h(87): warning C4005: 'DISPID_XMLDOM_DOCUMENT_PARSEERROR' : macro redefinition 1> .\msxml2did.h(134) : see previous definition of 'DISPID_XMLDOM_DOCUMENT_PARSEERROR' 1>.\xmldomdid.h(88): warning C4005: 'DISPID_XMLDOM_DOCUMENT_URL' : macro redefinition 1> .\msxml2did.h(135) : see previous definition of 'DISPID_XMLDOM_DOCUMENT_URL' 1>.\xmldomdid.h(89): warning C4005: 'DISPID_XMLDOM_DOCUMENT_ASYNC' : macro redefinition 1> .\msxml2did.h(136) : see previous definition of 'DISPID_XMLDOM_DOCUMENT_ASYNC' 1>.\xmldomdid.h(90): warning C4005: 'DISPID_XMLDOM_DOCUMENT_ABORT' : macro redefinition 1> .\msxml2did.h(137) : see previous definition of 'DISPID_XMLDOM_DOCUMENT_ABORT' 1>.\xmldomdid.h(91): warning C4005: 'DISPID_XMLDOM_DOCUMENT_LOADXML' : macro redefinition 1> .\msxml2did.h(138) : see previous definition of 'DISPID_XMLDOM_DOCUMENT_LOADXML' 1>.\xmldomdid.h(92): warning C4005: 'DISPID_XMLDOM_DOCUMENT_SAVE' : macro redefinition 1> .\msxml2did.h(139) : see previous definition of 'DISPID_XMLDOM_DOCUMENT_SAVE' 1>.\xmldomdid.h(93): warning C4005: 'DISPID_XMLDOM_DOCUMENT_VALIDATE' : macro redefinition 1> .\msxml2did.h(140) : see previous definition of 'DISPID_XMLDOM_DOCUMENT_VALIDATE' 1>.\xmldomdid.h(94): warning C4005: 'DISPID_XMLDOM_DOCUMENT_RESOLVENAMESPACE' : macro redefinition 1> .\msxml2did.h(141) : see previous definition of 'DISPID_XMLDOM_DOCUMENT_RESOLVENAMESPACE' 1>.\xmldomdid.h(95): warning C4005: 'DISPID_XMLDOM_DOCUMENT_PRESERVEWHITESPACE' : macro redefinition 1> .\msxml2did.h(142) : see previous definition of 'DISPID_XMLDOM_DOCUMENT_PRESERVEWHITESPACE' 1>.\xmldomdid.h(96): warning C4005: 'DISPID_XMLDOM_DOCUMENT_ONREADYSTATECHANGE' : macro redefinition 1> .\msxml2did.h(143) : see previous definition of 'DISPID_XMLDOM_DOCUMENT_ONREADYSTATECHANGE' 1>.\xmldomdid.h(97): warning C4005: 'DISPID_XMLDOM_DOCUMENT_ONDATAAVAILABLE' : macro redefinition 1> .\msxml2did.h(144) : see previous definition of 'DISPID_XMLDOM_DOCUMENT_ONDATAAVAILABLE' 1>.\xmldomdid.h(98): warning C4005: 'DISPID_XMLDOM_DOCUMENT_ONTRANSFORMNODE' : macro redefinition 1> .\msxml2did.h(145) : see previous definition of 'DISPID_XMLDOM_DOCUMENT_ONTRANSFORMNODE' 1>.\xmldomdid.h(99): warning C4005: 'DISPID_XMLDOM_DOCUMENT__TOP' : macro redefinition 1> .\msxml2did.h(146) : see previous definition of 'DISPID_XMLDOM_DOCUMENT__TOP' 1>.\xmldomdid.h(101): warning C4005: 'DISPID_DOM_NODELIST' : macro redefinition 1> .\msxml2did.h(148) : see previous definition of 'DISPID_DOM_NODELIST' 1>.\xmldomdid.h(102): warning C4005: 'DISPID_DOM_NODELIST_ITEM' : macro redefinition 1> .\msxml2did.h(149) : see previous definition of 'DISPID_DOM_NODELIST_ITEM' 1>.\xmldomdid.h(103): warning C4005: 'DISPID_DOM_NODELIST_LENGTH' : macro redefinition 1> .\msxml2did.h(150) : see previous definition of 'DISPID_DOM_NODELIST_LENGTH' 1>.\xmldomdid.h(105): warning C4005: 'DISPID_XMLDOM_NODELIST' : macro redefinition 1> .\msxml2did.h(151) : see previous definition of 'DISPID_XMLDOM_NODELIST' 1>.\xmldomdid.h(106): warning C4005: 'DISPID_XMLDOM_NODELIST_NEXTNODE' : macro redefinition 1> .\msxml2did.h(152) : see previous definition of 'DISPID_XMLDOM_NODELIST_NEXTNODE' 1>.\xmldomdid.h(107): warning C4005: 'DISPID_XMLDOM_NODELIST_RESET' : macro redefinition 1> .\msxml2did.h(153) : see previous definition of 'DISPID_XMLDOM_NODELIST_RESET' 1>.\xmldomdid.h(108): warning C4005: 'DISPID_XMLDOM_NODELIST_NEWENUM' : macro redefinition 1> .\msxml2did.h(154) : see previous definition of 'DISPID_XMLDOM_NODELIST_NEWENUM' 1>.\xmldomdid.h(109): warning C4005: 'DISPID_XMLDOM_NODELIST__TOP' : macro redefinition 1> .\msxml2did.h(155) : see previous definition of 'DISPID_XMLDOM_NODELIST__TOP' 1>.\xmldomdid.h(111): warning C4005: 'DISPID_DOM_NAMEDNODEMAP' : macro redefinition 1> .\msxml2did.h(157) : see previous definition of 'DISPID_DOM_NAMEDNODEMAP' 1>.\xmldomdid.h(112): warning C4005: 'DISPID_DOM_NAMEDNODEMAP_GETNAMEDITEM' : macro redefinition 1> .\msxml2did.h(158) : see previous definition of 'DISPID_DOM_NAMEDNODEMAP_GETNAMEDITEM' 1>.\xmldomdid.h(113): warning C4005: 'DISPID_DOM_NAMEDNODEMAP_SETNAMEDITEM' : macro redefinition 1> .\msxml2did.h(159) : see previous definition of 'DISPID_DOM_NAMEDNODEMAP_SETNAMEDITEM' 1>.\xmldomdid.h(114): warning C4005: 'DISPID_DOM_NAMEDNODEMAP_REMOVENAMEDITEM' : macro redefinition 1> .\msxml2did.h(160) : see previous definition of 'DISPID_DOM_NAMEDNODEMAP_REMOVENAMEDITEM' 1>.\xmldomdid.h(116): warning C4005: 'DISPID_XMLDOM_NAMEDNODEMAP' : macro redefinition 1> .\msxml2did.h(161) : see previous definition of 'DISPID_XMLDOM_NAMEDNODEMAP' 1>.\xmldomdid.h(117): warning C4005: 'DISPID_XMLDOM_NAMEDNODEMAP_GETQUALIFIEDITEM' : macro redefinition 1> .\msxml2did.h(162) : see previous definition of 'DISPID_XMLDOM_NAMEDNODEMAP_GETQUALIFIEDITEM' 1>.\xmldomdid.h(118): warning C4005: 'DISPID_XMLDOM_NAMEDNODEMAP_REMOVEQUALIFIEDITEM' : macro redefinition 1> .\msxml2did.h(163) : see previous definition of 'DISPID_XMLDOM_NAMEDNODEMAP_REMOVEQUALIFIEDITEM' 1>.\xmldomdid.h(119): warning C4005: 'DISPID_XMLDOM_NAMEDNODEMAP_NEXTNODE' : macro redefinition 1> .\msxml2did.h(164) : see previous definition of 'DISPID_XMLDOM_NAMEDNODEMAP_NEXTNODE' 1>.\xmldomdid.h(120): warning C4005: 'DISPID_XMLDOM_NAMEDNODEMAP_RESET' : macro redefinition 1> .\msxml2did.h(165) : see previous definition of 'DISPID_XMLDOM_NAMEDNODEMAP_RESET' 1>.\xmldomdid.h(121): warning C4005: 'DISPID_XMLDOM_NAMEDNODEMAP_NEWENUM' : macro redefinition 1> .\msxml2did.h(166) : see previous definition of 'DISPID_XMLDOM_NAMEDNODEMAP_NEWENUM' 1>.\xmldomdid.h(122): warning C4005: 'DISPID_XMLDOM_NAMEDNODEMAP__TOP' : macro redefinition 1> .\msxml2did.h(167) : see previous definition of 'DISPID_XMLDOM_NAMEDNODEMAP__TOP' 1>.\xmldomdid.h(124): warning C4005: 'DISPID_DOM_W3CWRAPPERS' : macro redefinition 1> .\msxml2did.h(169) : see previous definition of 'DISPID_DOM_W3CWRAPPERS' 1>.\xmldomdid.h(126): warning C4005: 'DISPID_DOM_DOCUMENTFRAGMENT' : macro redefinition 1> .\msxml2did.h(171) : see previous definition of 'DISPID_DOM_DOCUMENTFRAGMENT' 1>.\xmldomdid.h(127): warning C4005: 'DISPID_DOM_DOCUMENTFRAGMENT__TOP' : macro redefinition 1> .\msxml2did.h(172) : see previous definition of 'DISPID_DOM_DOCUMENTFRAGMENT__TOP' 1>.\xmldomdid.h(129): warning C4005: 'DISPID_DOM_ELEMENT' : macro redefinition 1> .\msxml2did.h(174) : see previous definition of 'DISPID_DOM_ELEMENT' 1>.\xmldomdid.h(130): warning C4005: 'DISPID_DOM_ELEMENT_GETTAGNAME' : macro redefinition 1> .\msxml2did.h(175) : see previous definition of 'DISPID_DOM_ELEMENT_GETTAGNAME' 1>.\xmldomdid.h(131): warning C4005: 'DISPID_DOM_ELEMENT_GETATTRIBUTES' : macro redefinition 1> .\msxml2did.h(176) : see previous definition of 'DISPID_DOM_ELEMENT_GETATTRIBUTES' 1>.\xmldomdid.h(132): warning C4005: 'DISPID_DOM_ELEMENT_GETATTRIBUTE' : macro redefinition 1> .\msxml2did.h(177) : see previous definition of 'DISPID_DOM_ELEMENT_GETATTRIBUTE' 1>.\xmldomdid.h(133): warning C4005: 'DISPID_DOM_ELEMENT_SETATTRIBUTE' : macro redefinition 1> .\msxml2did.h(178) : see previous definition of 'DISPID_DOM_ELEMENT_SETATTRIBUTE' 1>.\xmldomdid.h(134): warning C4005: 'DISPID_DOM_ELEMENT_REMOVEATTRIBUTE' : macro redefinition 1> .\msxml2did.h(179) : see previous definition of 'DISPID_DOM_ELEMENT_REMOVEATTRIBUTE' 1>.\xmldomdid.h(135): warning C4005: 'DISPID_DOM_ELEMENT_GETATTRIBUTENODE' : macro redefinition 1> .\msxml2did.h(180) : see previous definition of 'DISPID_DOM_ELEMENT_GETATTRIBUTENODE' 1>.\xmldomdid.h(136): warning C4005: 'DISPID_DOM_ELEMENT_SETATTRIBUTENODE' : macro redefinition 1> .\msxml2did.h(181) : see previous definition of 'DISPID_DOM_ELEMENT_SETATTRIBUTENODE' 1>.\xmldomdid.h(137): warning C4005: 'DISPID_DOM_ELEMENT_REMOVEATTRIBUTENODE' : macro redefinition 1> .\msxml2did.h(182) : see previous definition of 'DISPID_DOM_ELEMENT_REMOVEATTRIBUTENODE' 1>.\xmldomdid.h(138): warning C4005: 'DISPID_DOM_ELEMENT_GETELEMENTSBYTAGNAME' : macro redefinition 1> .\msxml2did.h(183) : see previous definition of 'DISPID_DOM_ELEMENT_GETELEMENTSBYTAGNAME' 1>.\xmldomdid.h(139): warning C4005: 'DISPID_DOM_ELEMENT_NORMALIZE' : macro redefinition 1> .\msxml2did.h(184) : see previous definition of 'DISPID_DOM_ELEMENT_NORMALIZE' 1>.\xmldomdid.h(140): warning C4005: 'DISPID_DOM_ELEMENT__TOP' : macro redefinition 1> .\msxml2did.h(185) : see previous definition of 'DISPID_DOM_ELEMENT__TOP' 1>.\xmldomdid.h(142): warning C4005: 'DISPID_DOM_DATA' : macro redefinition 1> .\msxml2did.h(187) : see previous definition of 'DISPID_DOM_DATA' 1>.\xmldomdid.h(143): warning C4005: 'DISPID_DOM_DATA_DATA' : macro redefinition 1> .\msxml2did.h(188) : see previous definition of 'DISPID_DOM_DATA_DATA' 1>.\xmldomdid.h(144): warning C4005: 'DISPID_DOM_DATA_LENGTH' : macro redefinition 1> .\msxml2did.h(189) : see previous definition of 'DISPID_DOM_DATA_LENGTH' 1>.\xmldomdid.h(145): warning C4005: 'DISPID_DOM_DATA_SUBSTRING' : macro redefinition 1> .\msxml2did.h(190) : see previous definition of 'DISPID_DOM_DATA_SUBSTRING' 1>.\xmldomdid.h(146): warning C4005: 'DISPID_DOM_DATA_APPEND' : macro redefinition 1> .\msxml2did.h(191) : see previous definition of 'DISPID_DOM_DATA_APPEND' 1>.\xmldomdid.h(147): warning C4005: 'DISPID_DOM_DATA_INSERT' : macro redefinition 1> .\msxml2did.h(192) : see previous definition of 'DISPID_DOM_DATA_INSERT' 1>.\xmldomdid.h(148): warning C4005: 'DISPID_DOM_DATA_DELETE' : macro redefinition 1> .\msxml2did.h(193) : see previous definition of 'DISPID_DOM_DATA_DELETE' 1>.\xmldomdid.h(149): warning C4005: 'DISPID_DOM_DATA_REPLACE' : macro redefinition 1> .\msxml2did.h(194) : see previous definition of 'DISPID_DOM_DATA_REPLACE' 1>.\xmldomdid.h(150): warning C4005: 'DISPID_DOM_DATA__TOP' : macro redefinition 1> .\msxml2did.h(195) : see previous definition of 'DISPID_DOM_DATA__TOP' 1>.\xmldomdid.h(152): warning C4005: 'DISPID_DOM_ATTRIBUTE' : macro redefinition 1> .\msxml2did.h(197) : see previous definition of 'DISPID_DOM_ATTRIBUTE' 1>.\xmldomdid.h(153): warning C4005: 'DISPID_DOM_ATTRIBUTE_GETNAME' : macro redefinition 1> .\msxml2did.h(198) : see previous definition of 'DISPID_DOM_ATTRIBUTE_GETNAME' 1>.\xmldomdid.h(154): warning C4005: 'DISPID_DOM_ATTRIBUTE_SPECIFIED' : macro redefinition 1> .\msxml2did.h(199) : see previous definition of 'DISPID_DOM_ATTRIBUTE_SPECIFIED' 1>.\xmldomdid.h(155): warning C4005: 'DISPID_DOM_ATTRIBUTE_VALUE' : macro redefinition 1> .\msxml2did.h(200) : see previous definition of 'DISPID_DOM_ATTRIBUTE_VALUE' 1>.\xmldomdid.h(156): warning C4005: 'DISPID_DOM_ATTRIBUTE__TOP' : macro redefinition 1> .\msxml2did.h(201) : see previous definition of 'DISPID_DOM_ATTRIBUTE__TOP' 1>.\xmldomdid.h(158): warning C4005: 'DISPID_DOM_TEXT' : macro redefinition 1> .\msxml2did.h(203) : see previous definition of 'DISPID_DOM_TEXT' 1>.\xmldomdid.h(159): warning C4005: 'DISPID_DOM_TEXT_SPLITTEXT' : macro redefinition 1> .\msxml2did.h(204) : see previous definition of 'DISPID_DOM_TEXT_SPLITTEXT' 1>.\xmldomdid.h(160): warning C4005: 'DISPID_DOM_TEXT_JOINTEXT' : macro redefinition 1> .\msxml2did.h(205) : see previous definition of 'DISPID_DOM_TEXT_JOINTEXT' 1>.\xmldomdid.h(161): warning C4005: 'DISPID_DOM_TEXT__TOP' : macro redefinition 1> .\msxml2did.h(206) : see previous definition of 'DISPID_DOM_TEXT__TOP' 1>.\xmldomdid.h(163): warning C4005: 'DISPID_DOM_PI' : macro redefinition 1> .\msxml2did.h(208) : see previous definition of 'DISPID_DOM_PI' 1>.\xmldomdid.h(164): warning C4005: 'DISPID_DOM_PI_TARGET' : macro redefinition 1> .\msxml2did.h(209) : see previous definition of 'DISPID_DOM_PI_TARGET' 1>.\xmldomdid.h(165): warning C4005: 'DISPID_DOM_PI_DATA' : macro redefinition 1> .\msxml2did.h(210) : see previous definition of 'DISPID_DOM_PI_DATA' 1>.\xmldomdid.h(166): warning C4005: 'DISPID_DOM_PI__TOP' : macro redefinition 1> .\msxml2did.h(211) : see previous definition of 'DISPID_DOM_PI__TOP' 1>.\xmldomdid.h(168): warning C4005: 'DISPID_DOM_DOCUMENTTYPE' : macro redefinition 1> .\msxml2did.h(213) : see previous definition of 'DISPID_DOM_DOCUMENTTYPE' 1>.\xmldomdid.h(169): warning C4005: 'DISPID_DOM_DOCUMENTTYPE_NAME' : macro redefinition 1> .\msxml2did.h(214) : see previous definition of 'DISPID_DOM_DOCUMENTTYPE_NAME' 1>.\xmldomdid.h(170): warning C4005: 'DISPID_DOM_DOCUMENTTYPE_ENTITIES' : macro redefinition 1> .\msxml2did.h(215) : see previous definition of 'DISPID_DOM_DOCUMENTTYPE_ENTITIES' 1>.\xmldomdid.h(171): warning C4005: 'DISPID_DOM_DOCUMENTTYPE_NOTATIONS' : macro redefinition 1> .\msxml2did.h(216) : see previous definition of 'DISPID_DOM_DOCUMENTTYPE_NOTATIONS' 1>.\xmldomdid.h(172): warning C4005: 'DISPID_DOM_DOCUMENTTYPE__TOP' : macro redefinition 1> .\msxml2did.h(217) : see previous definition of 'DISPID_DOM_DOCUMENTTYPE__TOP' 1>.\xmldomdid.h(174): warning C4005: 'DISPID_DOM_NOTATION' : macro redefinition 1> .\msxml2did.h(219) : see previous definition of 'DISPID_DOM_NOTATION' 1>.\xmldomdid.h(175): warning C4005: 'DISPID_DOM_NOTATION_PUBLICID' : macro redefinition 1> .\msxml2did.h(220) : see previous definition of 'DISPID_DOM_NOTATION_PUBLICID' 1>.\xmldomdid.h(176): warning C4005: 'DISPID_DOM_NOTATION_SYSTEMID' : macro redefinition 1> .\msxml2did.h(221) : see previous definition of 'DISPID_DOM_NOTATION_SYSTEMID' 1>.\xmldomdid.h(177): warning C4005: 'DISPID_DOM_NOTATION__TOP' : macro redefinition 1> .\msxml2did.h(222) : see previous definition of 'DISPID_DOM_NOTATION__TOP' 1>.\xmldomdid.h(179): warning C4005: 'DISPID_DOM_ENTITY' : macro redefinition 1> .\msxml2did.h(224) : see previous definition of 'DISPID_DOM_ENTITY' 1>.\xmldomdid.h(180): warning C4005: 'DISPID_DOM_ENTITY_PUBLICID' : macro redefinition 1> .\msxml2did.h(225) : see previous definition of 'DISPID_DOM_ENTITY_PUBLICID' 1>.\xmldomdid.h(181): warning C4005: 'DISPID_DOM_ENTITY_SYSTEMID' : macro redefinition 1> .\msxml2did.h(226) : see previous definition of 'DISPID_DOM_ENTITY_SYSTEMID' 1>.\xmldomdid.h(182): warning C4005: 'DISPID_DOM_ENTITY_NOTATIONNAME' : macro redefinition 1> .\msxml2did.h(227) : see previous definition of 'DISPID_DOM_ENTITY_NOTATIONNAME' 1>.\xmldomdid.h(183): warning C4005: 'DISPID_DOM_ENTITY__TOP' : macro redefinition 1> .\msxml2did.h(228) : see previous definition of 'DISPID_DOM_ENTITY__TOP' 1>.\xmldomdid.h(185): warning C4005: 'DISPID_DOM_IMPLEMENTATION' : macro redefinition 1> .\msxml2did.h(232) : see previous definition of 'DISPID_DOM_IMPLEMENTATION' 1>.\xmldomdid.h(186): warning C4005: 'DISPID_DOM_IMPLEMENTATION_HASFEATURE' : macro redefinition 1> .\msxml2did.h(233) : see previous definition of 'DISPID_DOM_IMPLEMENTATION_HASFEATURE' 1>.\xmldomdid.h(187): warning C4005: 'DISPID_DOM_IMPLEMENTATION__TOP' : macro redefinition 1> .\msxml2did.h(234) : see previous definition of 'DISPID_DOM_IMPLEMENTATION__TOP' 1>.\xmldomdid.h(200): warning C4005: 'DISPID_XMLDOMEVENT' : macro redefinition 1> .\msxml2did.h(273) : see previous definition of 'DISPID_XMLDOMEVENT' 1>.\xmldomdid.h(202): warning C4005: 'DISPID_XMLDOMEVENT_ONDATAAVAILABLE' : macro redefinition 1> .\msxml2did.h(275) : see previous definition of 'DISPID_XMLDOMEVENT_ONDATAAVAILABLE' 1>.\xmldomdid.h(203): warning C4005: 'DISPID_XMLDOMEVENT__TOP' : macro redefinition 1> .\msxml2did.h(276) : see previous definition of 'DISPID_XMLDOMEVENT__TOP' 1>.\xmldsodid.h(22): warning C4005: 'DISPID_XOBJ_MIN' : macro redefinition 1> .\msxmldid.h(22) : see previous definition of 'DISPID_XOBJ_MIN' 1>.\xmldsodid.h(23): warning C4005: 'DISPID_XOBJ_MAX' : macro redefinition 1> .\msxmldid.h(23) : see previous definition of 'DISPID_XOBJ_MAX' 1>.\xmldsodid.h(24): warning C4005: 'DISPID_XOBJ_BASE' : macro redefinition 1> .\msxmldid.h(24) : see previous definition of 'DISPID_XOBJ_BASE' 1>.\xmldsodid.h(26): warning C4005: 'DISPID_XMLDSO' : macro redefinition 1> .\msxml2did.h(332) : see previous definition of 'DISPID_XMLDSO' 1>.\xmldsodid.h(27): warning C4005: 'DISPID_XMLDSO_DOCUMENT' : macro redefinition 1> .\msxml2did.h(333) : see previous definition of 'DISPID_XMLDSO_DOCUMENT' 1>.\xmldsodid.h(28): warning C4005: 'DISPID_XMLDSO_JAVADSOCOMPATIBLE' : macro redefinition 1> .\msxml2did.h(334) : see previous definition of 'DISPID_XMLDSO_JAVADSOCOMPATIBLE' 1> Processing .\dimm.idl 1> dimm.idl 1> Processing .\shtypes.idl 1> shtypes.idl 1> Processing .\dispex.idl 1> dispex.idl 1>.\mshtml.idl(6862): error MIDL2025: syntax error : expecting a type specification near "\" 1>.\mshtml.idl(14759): error MIDL2025: syntax error : expecting ] or , near "progid" 1>.\mshtml.idl(14759): error MIDL2026: cannot recover from earlier syntax errors; aborting compilation ========== Build: 0 succeeded, 1 failed, 0 up-to-date, 0 skipped ========== _____ No virus found in this message. Checked by AVG - www.avg.com Version: 2013.0.3343 / Virus Database: 3184/6360 - Release Date: 05/26/13

12 years, 3 months

1
0
0 0

Re: [ros-dev] [ros-diffs] [ekohl] 59026: [FASTFAT] Reverted revisions 59023, 59022 and 58976.

by Michael Fritscher

Hi, if I read the diff correctly you deleted the line "*pFcb->Attributes = (Attributes | FILE_ATTRIBUTE_ARCHIVE);" during reverting, which was there before your changes... Btw, are you sure that the regressions came direct from your changes? I suspect that you simply triggered a memory corruption, especially because the behavior at the kvm-testbot, but not at the vmware-testbot changed... Best regards, Michael Fritscher > Author: ekohl > Date: Fri May 17 17:52:43 2013 > New Revision: 59026 > > URL: http://svn.reactos.org/svn/reactos?rev=59026&view=rev > Log: > [FASTFAT] > Reverted revisions 59023, 59022 and 58976. > > Modified: > trunk/reactos/drivers/filesystems/fastfat/create.c > > Modified: trunk/reactos/drivers/filesystems/fastfat/create.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/fastfa… > ============================================================================== > --- trunk/reactos/drivers/filesystems/fastfat/create.c [iso-8859-1] > (original) > +++ trunk/reactos/drivers/filesystems/fastfat/create.c [iso-8859-1] Fri > May 17 17:52:43 2013 > @@ -426,7 +426,6 @@ > BOOLEAN Dots; > UNICODE_STRING FileNameU; > UNICODE_STRING PathNameU; > - ULONG Attributes; > > /* Unpack the various parameters. */ > Stack = IoGetCurrentIrpStackLocation (Irp); > @@ -437,9 +436,6 @@ > FileObject = Stack->FileObject; > DeviceExt = DeviceObject->DeviceExtension; > > - Attributes = Stack->Parameters.Create.FileAttributes; > - Attributes &= (FILE_ATTRIBUTE_READONLY | FILE_ATTRIBUTE_HIDDEN | > FILE_ATTRIBUTE_SYSTEM | FILE_ATTRIBUTE_ARCHIVE); > - > /* Check their validity. */ > if (RequestedOptions & FILE_DIRECTORY_FILE && > RequestedDisposition == FILE_SUPERSEDE) > @@ -548,9 +544,11 @@ > RequestedDisposition == FILE_OVERWRITE_IF || > RequestedDisposition == FILE_SUPERSEDE) > { > + ULONG Attributes; > + Attributes = Stack->Parameters.Create.FileAttributes & > ~FILE_ATTRIBUTE_NORMAL; > vfatSplitPathName(&PathNameU, NULL, &FileNameU); > Status = VfatAddEntry (DeviceExt, &FileNameU, &pFcb, ParentFcb, > RequestedOptions, > - (UCHAR)(Attributes | FILE_ATTRIBUTE_ARCHIVE)); > + (UCHAR)(Attributes & FILE_ATTRIBUTE_VALID_FLAGS)); > vfatReleaseFCB (DeviceExt, ParentFcb); > if (NT_SUCCESS (Status)) > { > @@ -690,12 +688,6 @@ > RequestedDisposition == FILE_SUPERSEDE) > { > ExAcquireResourceExclusiveLite(&(pFcb->MainResource), > TRUE); > - if (RequestedDisposition == FILE_OVERWRITE || > - RequestedDisposition == FILE_OVERWRITE_IF) > - *pFcb->Attributes |= (Attributes | FILE_ATTRIBUTE_ARCHIVE); > - else > - *pFcb->Attributes = (Attributes | FILE_ATTRIBUTE_ARCHIVE); > - > Status = VfatSetAllocationSizeInformation (FileObject, > pFcb, > DeviceExt, > > >

12 years, 3 months

1
0
0 0

Re: [ros-dev] [ros-builds] Linux_AMD64_2 VMWPlayer-Test: build failed

by Pierre Schweitzer

Hi, Please note that r59047 broke VMware testbot. It times out in setupapi:install and fails to restart afterwards. Regards, Pierre On 20/05/2013 15:01, buildbot(a)reactos.org wrote: > The Buildbot has detected a failed build on builder Linux_AMD64_2 VMWPlayer-Test while building ReactOS. > Full details are available at: > http://build.reactos.org/builders/Linux_AMD64_2%20VMWPlayer-Test/builds/869 > > Buildbot URL: http://build.reactos.org/ > > Buildslave for this Build: Linux_AMD64_2 > > Build Reason: Triggerable(Linux_AMD64_1 KVM-Test Trigger) > Build Source Stamp: 59050 > Blamelist: > > BUILD FAILED: failed test > > sincerely, > -The Buildbot > > > > -- Pierre Schweitzer<pierre at reactos.org> System Administrator ReactOS Foundation

12 years, 3 months

2
2
0 0

Important Test regressions due to FastFat changes

by victor martinez

The following tests are introducing several bugs/regressions: [ros-diffs] [ekohl] 59021: [SYSSETUP] Enable the restore privilege before the call to NtUnloadKey. Disable it immediately after the call to NtUnloadKey. ekohl at svn.reactos.org ^This one introduces a potential regression at: user32:clipboard From 49216 tests executed, aftwerdars 49208 (-8)shell32:appbar. From 61 test executed, afterwards 58 [ros-diffs] [ekohl] 59022: [FASTFAT] Allow only readonly, hidden, system and archive files attributes to be set for existing files. Other file attributes must be ignored. This fixes several tests. ekohl at svn.reactos.org ^This introduces a whole bunch of regressions easily spoted. ole32:storage32oleaut32:typelibregedit:regeditsetupapi:miscsetupapi:parserEtc,Etc [ros-diffs] [ekohl] 59023: [FASTFAT] Implement a special case for existing files which are opened using the FILE_OVERWRITE or FILE_OVERWRITE_IF file disposition: New file attributes must be ORed with the exist... ekohl at svn.reactos.org ^The following regresses: zz_notepad++_6.1.2:1.installzz_notepad++_6.1.2:2.SaveAsDesktopzz_notepad++_6.1.2:3.OpenDocumentzz_notepad++_6.1.2:4.Ctrl-F.FindDialogzz_notepad++_6.1.2:5.Send_InputAmong others Comparison chart: http://www.reactos.org/sites/all/modules/reactos/testman/compare.php?ids=17…

12 years, 4 months

2
1
0 0

Unexpected downtime

by Pierre Schweitzer

Hi, due to critical load issues on reactos.org, the webserver has been taken down now for an extra maintenance to address the issues. Affected services are the following: reactos.org, doxygen.reactos.org (still reachable but slow), jira.reactos.org (no auth), code.reactos.org (no auth). We cannot provide any ETA for the end of the maintenance. We are sorry for the caused inconveniences. With my best regards, -- Pierre Schweitzer<pierre at reactos.org> System Administrator ReactOS Foundation

12 years, 4 months

1
2
0 0

Re: [ros-dev] [ros-diffs] [ekohl] 59013: [LSASRV] - LsapCheckLogonProcess: Open client process using the PROCESS_DUP_HANDLE access right because we need to duplicate the logon token back into the clients handle table.

by Thomas Faber

On 2013-05-13 15:05, ekohl(a)svn.reactos.org wrote: > Status = NtReplyWaitReceivePort(AuthPortHandle, > (PVOID*)&LogonContext, > - &ReplyMsg->h, > - &RequestMsg.h); > + (PPORT_MESSAGE)ReplyMsg, > + (PPORT_MESSAGE)&RequestMsg); As the Guy Who Officially Hates Casts™, I have to ask: wasn't the previous version better for type safety? With the cast, an additional [or missing] & can slip in and the code will compile without complaint. Best, Thomas

12 years, 4 months

1
0
0 0

Re: [ros-dev] [ros-diffs] [hbelusca] 58971: [FREELDR] - Fix dprints (be careful when "Status" variables are booleans). - Don't fail when trying to load an non-existent KD transport dll.

by Timo Kreuzer

I suggest NEVER to use Status as the name for anything other than NTSTATUS variables. Otherwise problems are almost preprogrammed (seen this multiple times). It Should be called Result or something. This is one of those cases where hungarian notation really makes a difference, Colin. ;-) Am 08.05.2013 19:52, schrieb hbelusca(a)svn.reactos.org: > Author: hbelusca > Date: Wed May 8 17:52:16 2013 > New Revision: 58971 > > URL: http://svn.reactos.org/svn/reactos?rev=58971&view=rev > Log: > [FREELDR] > - Fix dprints (be careful when "Status" variables are booleans). > - Don't fail when trying to load an non-existent KD transport dll. > > Modified: > branches/kd++/boot/freeldr/freeldr/disk/scsiport.c > branches/kd++/boot/freeldr/freeldr/windows/peloader.c > branches/kd++/boot/freeldr/freeldr/windows/winldr.c > > Modified: branches/kd++/boot/freeldr/freeldr/disk/scsiport.c > URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/boot/freeldr/freeldr/d… > ============================================================================== > --- branches/kd++/boot/freeldr/freeldr/disk/scsiport.c [iso-8859-1] (original) > +++ branches/kd++/boot/freeldr/freeldr/disk/scsiport.c [iso-8859-1] Wed May 8 17:52:16 2013 > @@ -1568,7 +1568,7 @@ > ULONG ImportTableSize; > PLDR_DATA_TABLE_ENTRY BootDdDTE, FreeldrDTE; > CHAR NtBootDdPath[MAX_PATH]; > - PVOID ImageBase; > + PVOID ImageBase = NULL; > ULONG (NTAPI *EntryPoint)(IN PVOID DriverObject, IN PVOID RegistryPath); > BOOLEAN Status; > > > Modified: branches/kd++/boot/freeldr/freeldr/windows/peloader.c > URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/boot/freeldr/freeldr/w… > ============================================================================== > --- branches/kd++/boot/freeldr/freeldr/windows/peloader.c [iso-8859-1] (original) > +++ branches/kd++/boot/freeldr/freeldr/windows/peloader.c [iso-8859-1] Wed May 8 17:52:16 2013 > @@ -255,11 +255,12 @@ > return TRUE; > } > > -/* WinLdrLoadImage loads the specified image from the file (it doesn't > - perform any additional operations on the filename, just directly > - calls the file I/O routines), and relocates it so that it's ready > - to be used when paging is enabled. > - Addressing mode: physical > +/* > + * WinLdrLoadImage loads the specified image from the file (it doesn't > + * perform any additional operations on the filename, just directly > + * calls the file I/O routines), and relocates it so that it's ready > + * to be used when paging is enabled. > + * Addressing mode: physical > */ > BOOLEAN > WinLdrLoadImage(IN PCHAR FileName, > @@ -429,7 +430,6 @@ > /* If loading failed - return right now */ > if (Status != ESUCCESS) > return FALSE; > - > > /* Relocate the image, if it needs it */ > if (NtHeaders->OptionalHeader.ImageBase != (ULONG_PTR)VirtualBase) > @@ -756,7 +756,7 @@ > { > CHAR FullDllName[256]; > BOOLEAN Status; > - PVOID BasePA; > + PVOID BasePA = NULL; > > /* Prepare the full path to the file to be loaded */ > strcpy(FullDllName, DirectoryPath); > @@ -781,7 +781,7 @@ > DataTableEntry); > if (!Status) > { > - ERR("WinLdrAllocateDataTableEntry() failed with Status=0x%X\n", Status); > + ERR("WinLdrAllocateDataTableEntry() failed\n"); > return Status; > } > > @@ -791,7 +791,7 @@ > Status = WinLdrScanImportDescriptorTable(ModuleListHead, DirectoryPath, *DataTableEntry); > if (!Status) > { > - ERR("WinLdrScanImportDescriptorTable() failed with Status=0x%X\n", Status); > + ERR("WinLdrScanImportDescriptorTable() failed\n"); > return Status; > } > > > Modified: branches/kd++/boot/freeldr/freeldr/windows/winldr.c > URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/boot/freeldr/freeldr/w… > ============================================================================== > --- branches/kd++/boot/freeldr/freeldr/windows/winldr.c [iso-8859-1] (original) > +++ branches/kd++/boot/freeldr/freeldr/windows/winldr.c [iso-8859-1] Wed May 8 17:52:16 2013 > @@ -237,7 +237,7 @@ > CHAR DllName[1024]; > PCHAR DriverNamePos; > BOOLEAN Status; > - PVOID DriverBase; > + PVOID DriverBase = NULL; > > // Separate the path to file name and directory path > _snprintf(DriverPath, sizeof(DriverPath), "%wZ", FilePath); > @@ -258,7 +258,6 @@ > } > > TRACE("DriverPath: %s, DllName: %s, LPB\n", DriverPath, DllName); > - > > // Check if driver is already loaded > Status = WinLdrCheckForLoadedDll(LoadOrderListHead, DllName, DriverDTE); > @@ -424,7 +423,7 @@ > } > > static > -PVOID > +BOOLEAN > LoadModule( > PLOADER_PARAMETER_BLOCK LoaderBlock, > PCCH Path, > @@ -434,10 +433,10 @@ > BOOLEAN IsKdTransportDll, > ULONG Percentage) > { > + BOOLEAN Status; > CHAR FullFileName[MAX_PATH]; > CHAR ProgressString[256]; > - NTSTATUS Status; > - PVOID BaseAdress; > + PVOID BaseAdress = NULL; > > UiDrawBackdrop(); > sprintf(ProgressString, "Loading %s...", File); > @@ -448,8 +447,12 @@ > strcat(FullFileName, File); > > Status = WinLdrLoadImage(FullFileName, MemoryType, &BaseAdress); > - TRACE("%s loaded with status %d at %p\n", > - File, Status, BaseAdress); > + if (!Status) > + { > + TRACE("Loading %s failed\n", File); > + return FALSE; > + } > + TRACE("%s loaded successfully at %p\n", File, BaseAdress); > > strcpy(FullFileName, "WINDOWS\\SYSTEM32\\"); > strcat(FullFileName, File); > @@ -458,13 +461,13 @@ > * the Kernel Debugger Transport DLL, to make the > * PE loader happy. > */ > - WinLdrAllocateDataTableEntry(&LoaderBlock->LoadOrderListHead, > - (IsKdTransportDll ? "KDCOM.DLL" : File), > - FullFileName, > - BaseAdress, > - Dte); > - > - return BaseAdress; > + Status = WinLdrAllocateDataTableEntry(&LoaderBlock->LoadOrderListHead, > + (IsKdTransportDll ? "KDCOM.DLL" : File), > + FullFileName, > + BaseAdress, > + Dte); > + > + return Status; > } > > static > @@ -679,11 +682,11 @@ > UiDrawBackdrop(); > UiDrawProgressBarCenter(15, 100, "Loading system hive..."); > Status = WinLdrInitSystemHive(LoaderBlock, BootPath); > - TRACE("SYSTEM hive loaded with status %d\n", Status); > + TRACE("SYSTEM hive %s\n", (Status ? "loaded" : "not loaded")); > > /* Load NLS data, OEM font, and prepare boot drivers list */ > Status = WinLdrScanSystemHive(LoaderBlock, BootPath); > - TRACE("SYSTEM hive scanned with status %d\n", Status); > + TRACE("SYSTEM hive %s\n", (Status ? "scanned" : "not scanned")); > > /* Finish loading */ > LoadAndBootWindowsCommon(OperatingSystemVersion, > > >

12 years, 4 months

2
1
0 0

Re: [ros-dev] [ros-diffs] [pschweitzer] 58960: [RTL] Finally reenable RtlAcquirePrivilege

by Jérôme Gardou

Hey Pierre! Nice patch series, that takes ReactOS nearer to being secure. A remark though : > /* > - * enable the SeSystemtimePrivilege privilege > + * Call SetLocalTime twice to ensure correct results > */ > + Ret = SetLocalTime(&SetupData->SystemTime) && > + SetLocalTime(&SetupData->SystemTime); This is a bit confusing, and the comment doesn't really help. Why would calling the function twice ansure correct result ? Also, this is likely to be optimized away by the compiler, or at least produce a report in static code analysers. I know this isn't pure chance. Any hint as to why you wrote it like this ? Cheers Jérôme

12 years, 4 months

4
4
0 0

getdate.exe being pulled from SVN repository

by J. C. Jones

Small nit-pick: .\reactos\reactos\tools\getdate.exe is being pulled from SVN even though it is being generated by getdate.cmd and getdate.c that are both in the same directory? -John

12 years, 4 months

3
3
0 0

Planned services downtime

by Pierre Schweitzer

Hi, on the 3rd of May, from 1PM to 6PM CET, the following services will down due to a power maintenance: -> ISO upload -> ISO download -> Doxygen -> cppcheck -> Linux buildbot -> KVM testbot -> VMware testbot I warmly recommend you don't commit during that period then, as remaining builder, Windows one, won't be able to upload its ISOs. Actually, I could also take the opportunity of such downtime to take SVN (svn, git, buildbot master) server down for maintenance as it will barely harm. I'll keep you informed. I'll push reminders before it happens. Sorry for the services interruption. With my best regards, -- Pierre Schweitzer<pierre at reactos.org> System Administrator ReactOS Foundation

12 years, 4 months

1
4
0 0

reactos.inf

by Stefan Naumann

Hello. I am the guy writing an updater for ReactOS. Recent tests show some difficulties and errors in data from reactos bootcds; mainly reactos.inf: My program reads reactos.inf, puts the filepaths together and copies files to the specified positions in folder-tree (I'm talking about the server's side). It seems that reactos.inf contains pretty weird data; opening reactos.inf with gedit shows it intact; reading it with the program gets the following things out (shortened): " -- 6 -->cache/files/��" should be "cache/files/inf" (with cache/files" beeing the path of all cached files, unpacked from bootcd-ISO. and (in the same context): " -- 5 = system32\drivers\etc -- 6 = inf -- 7 = bin -- �Í = bin\data -- 9 = media -- 10 = Microsoft.NET " ("--" comes from debug-function of my iniparser). Is this intended to be as is or not? Could someone please fix that or let me know whether I should think about doing something differently. I'm working and testing with Xubuntu 13.04 amd64 - always getting latest dbg-BootCD-ISO. Thanks peope. Regards Stefan Naumann

12 years, 4 months

2
4
0 0

Re: [ros-dev] [ros-diffs] [hbelusca] 58902: [FREELDR] - Fix some function parameter types, so to avoid unuseful casts (from pointers to const strings to pointers to strings in particular). - The big thing: make FreeLdr load...

by Timo Kreuzer

I'm not a fan of single line conditional statements. I'd prefer if we had a style rule for that. Any thoughts on that? Am 01.05.2013 19:12, schrieb hbelusca(a)svn.reactos.org: > Author: hbelusca > Date: Wed May 1 17:12:56 2013 > New Revision: 58902 > do > { > - while (*LoadOptions == '/') > - ++LoadOptions; > - > + while (*LoadOptions == '/') ++LoadOptions; > *NewLoadOptions++ = *LoadOptions; > } while (*LoadOptions++); > >

12 years, 4 months

6
7
0 0

Status Meeting (April 2013)

by Aleksey Bragin

Hello, Let me invite you to the monthly status meeting taking place last Thursday of this month, 25th of April, 19:00 UTC. The meeting will be at irc://dev.reactos.org (Port 6667, no SSL) in the channel #meeting, or as Pierre says. Note that the IRC service will only be started shortly before the meeting. Your participation passwords will be emailed to you shortly before the meeting starts, and they are going to be different once again as they are not stored in any database. Hopefully it's not much of inconvenience. If someone still is not getting passwords sent before a meeting - please email Colin or Pierre before the meeting started to get one. The agenda will be posted shortly before the meeting, suggestions are welcome (send them to my email as usual). Regards, Aleksey Bragin

12 years, 4 months

2
1
0 0

Re: [ros-dev] [ros-diffs] [hbelusca] 58824: [KDCOM] - Use the UCHAR type directly instead

by Jérôme Gardou

Hey Hermès ! > + > +long atol(const char *str); > + Shouldn't this belong to some standard header ? Cheers Jérôme

12 years, 4 months

2
1
0 0

5 days unlimited trial of PVS-studio

by Александр

12 years, 5 months

1
0
0 0

Re: [ros-dev] [ros-diffs] [hbelusca] 58770: [REACTOS] Merge of the ros-csrss branch created with a three-fold purpose: - Use the new Windows-compatible Client-Server Runtime Subsystem (csrss + csrsrv) written by Alex Ionesc...

by Ged Murphy

Fantastic work Hermes! Congrats On 15/04/2013 20:32, "hbelusca(a)svn.reactos.org" <hbelusca(a)svn.reactos.org> wrote: >Author: hbelusca >Date: Mon Apr 15 19:32:00 2013 >New Revision: 58770 > >URL: http://svn.reactos.org/svn/reactos?rev=58770&view=rev >Log: >[REACTOS] > >Merge of the ros-csrss branch created with a three-fold purpose: > >- Use the new Windows-compatible Client-Server Runtime Subsystem (csrss + >csrsrv) >written by Alex Ionescu to replace the old hacked one. Also the CSR >client part, >residing in ntdll, is updated. Some work also done on the dlls side, which >communicate with CSR, namely kernel32. > >- Replace our very old win32csr.dll CSR server by the collection >basesrv.dll / >winsrv.dll as it is done under Windows. > >- Since the console subsystem is (for historical purposes on Windows) the >only subsystem which exploits all the possibilities of the CSR, I decided >to >put it in a new CSR dll called 'consrv.dll', even if on Windows it is >included >together with other APIs inside the winsrv dll (since Windows NT 3.1 >release) >(I took the name 'consrv' from the dll where it was included in Windows >NT 3.1 >beta from October 1991). Some work was also done on its internal >architecture >(the external interface is of course unchanged for compatibility reasons) >and a >two-layer approach was developed, using the existing idea of console >functions + >GUI or TUI we already had in win32csr: > * the "console server" which dialogs with the console applications, >and which maintains a list of all the created consoles. > * different "front-ends" corresponding to where you want to output >the information (~= console hardware) (Work-In-Progress). >Another idea would be to make those front-ends dynamically-loadable >(instead >of being compiled inside consrv). >- I also fixed some parts of the console properties dialog box. > >More information can be found in >http://www.reactos.org/archives/public/ros-dev/2013-April/016121.html > >CORE-122 CORE-2510 CORE-7002 #resolve #comment Committed in revision >r58xxx.

12 years, 5 months

2
1
0 0

TR: Future merge of the ros-csrss branch into the trunk

by Hermès BÉLUSCA - MAÏTO

Hello everybody, This message is to remind you that the merge will happen on Monday 15. (of this month) in the evening (~= 19 or 20:00 UTC). Hermès -----Message d'origine----- De : Hermès BÉLUSCA - MAÏTO [mailto:hermes.belusca@sfr.fr] Envoyé : mardi 9 avril 2013 12:48 À : 'ReactOS Development List' Objet : Future merge of the ros-csrss branch into the trunk Hi all ! I'm writing this mail to announce to you that in one week (if everything works as expected till this time) I will be ready to merge my ros-csrss branch into our current codebase. [...]

12 years, 5 months

2
1
0 0

KVM testbot upgraded

by Pierre Schweitzer

Hi guys, the KVM testbot has been upgraded from 0.12.3 to 1.0. This means that you could find new regressions. On testman, the starting revision at which it has been used is: 58727. It's interesting to note that previously the KVM testbot was running headless (no VNC display on ReactOS VM). With newer release, this is impossible. Either ReactOS or KVM locks up because of this. See: http://build.reactos.org/builders/Linux_AMD64_1%20KVM-Test/builds/2710/step… With my best regards, -- Pierre Schweitzer<pierre(a)reactos.org> System Administrator ReactOS Foundation

12 years, 5 months

1
0
0 0

Future merge of the ros-csrss branch into the trunk

by Hermès BÉLUSCA - MAÏTO

Hi all ! I'm writing this mail to announce to you that in one week (if everything works as expected till this time) I will be ready to merge my ros-csrss branch into our current codebase. The ros-csrss branch (http://svn.reactos.org/svn/reactos/branches/ros-csrss/?view=log) was started 5 months ago (October 14, 2012 to be precise) with a three-fold purpose: - Use the new Windows-compatible Client-Server Runtime Subsystem (csrss + csrsrv) written by Alex Ionescu, unused at the moment and which currently lives in trunk/reactos/subsystems/csr/, and as such was a replacement for the older one in trunk/reactos/subsystems/win32/csrss/. This last one was progressively hacked to include functionalities from the new csrss; however most of the old code remained and as such it was a big hack. Also the CSR client part, residing in ntdll, was updated (thanks to comments put by Alex inside it). To communicate between the server-part and the client-part, some messaging protocol is used (thanks to LPC); the used structures were not so up-to-date, but the new ones were in the code, not used. So I could use them instead of the older ones. That meant that some work was needed in ntdll (as previously stated). Disregarding the details (you can see them in the commit log), I also had to rework a little bit on the dlls which communicate with CSR, namely kernel32. - Replacing our very old win32csr.dll csr server by the collection basesrv / winsrv as it is done under Windows. For that I tried to match accurately our existing code with what should exist on Windows according to this list of CSR servers APIs : http://j00ru.vexillium.org/csrss_list/api_list.html . - Since the console subsystem is (for historical purposes on Windows) the only subsystem which exploits all the possibilities of the CSR, much of the work in the branch was done to make it working with the new csrss. Even if on Windows it is included together with other APIs inside the winsrv dll (since Windows NT 3.1 release), I decided to put it in a separate dll, called consrv, on ReactOS (I took the name from the dll where it was included in Windows NT 3.1 beta from October 1991). Also, because I believe that the console subsystem is something that, on Windows, was somewhat neglected (no ANSI control, (almost?)no TTY-like flavour...) I decided to work on its internal architecture (the exterior one being unchanged for compatibility reasons) such as to exacerbate the following things: * the "console server" which dialogs with the console applications, and which maintains a list of all the created consoles. * different "front-ends" corresponding to where you want to output the information (~= console hardware) (it is of course work-in-progress). At the moment only one is working: the GUI console. I have to make the TUI interfacing correctly with the rest of the code (but since it's not used for now, it's not extremely urgent). The idea would be to have also a front-end for serial ports, so that we could interact with the serial port (with Putty if running ROS on a virtual machine, or with a serial console, etc...). And another idea would be to make those front-ends dynamically-loadable (instead of being compiled inside consrv). - I also fixed some parts of the console properties dialog box. Here is the JIRA report for the merge: http://jira.reactos.org/browse/CORE-7002 Here are the test results with revision 58723 (plus comparison with revisions 58722 and 58720): http://old.reactos.org/testman/compare.php?ids=16213,16218,16219,16221 You will see that the ntdll:exception seems to run 24 more tests, but 4 failed compared to non-patched r58723. The errors are "exception.c:821: Test failed: Eip at 0x77f2b2a3 instead of 0079000B". It would be interesting to investigate further on these failings. Also, gdi32:font executes 33 more tests, and 10 more fail, due to the Fixedsys font. A problem, already existing in trunk, remains: http://jira.reactos.org/browse/CORE-6397 (see description inside). You are encouraged to make comments, etc... etc... Cheers, Hermès. ~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~= ~=~= Documentation I've used : ========================= - The oldest trace of CSRSS in NT 3.1 beta (where I've found the existence of csrsrv.dll, which was merged with winsrv.dll in the 3.1 release and the subsequent versions of NT): http://www.logotypes.se/NT310CSRSS.txt - "Windows CSRSS cross-version API Table" http://j00ru.vexillium.org/?p=349 and the subsequent links. - "Windows CSRSS Write Up: the basics (part 1/1)" http://j00ru.vexillium.org/?p=492 - "Windows CSRSS Write Up: Inter-process Communication (part 1/3)" http://j00ru.vexillium.org/?p=502 - "Windows CSRSS Write Up: Inter-process Communication (part 2/3)" http://j00ru.vexillium.org/?p=527 (the messaging system CSR server <--> client is explained here) (the part 3/3 seems to not exist) - "CVE-2011-1281: A story of a Windows CSRSS Privilege Escalation vulnerability" http://j00ru.vexillium.org/?p=893 and http://mysterie.fr/blog/2011/07/31/cve-2011-1281-privilege-escalation-in-csr ss-proof-of-concept/ - Something that would be interesting for console and thread desktops : "Defeating Windows Driver Signature Enforcement #2: CSRSS and thread desktops" http://j00ru.vexillium.org/?p=1393 - " Windows Subsytem Csrss" (in French) http://www.ivanlef0u.tuxfamily.org/?p=188 - "Story of a dumb patch", Cesar Cerrudo, http://www.argeniss.com/research/MSBugPaper.pdf or http://www.scn.rain.com/~neighorn/PDF/MSBugPaper.pdf - CsrWalker : http://forum.sysinternals.com/csrwalker-processes-detection-from-user-mode_t opic15457.html - Concerning console modes flags: https://sites.google.com/site/marckupper/utilities/setconsolemode - Documentation about consoles on MSDN: http://msdn.microsoft.com/en-us/library/windows/desktop/ms682010(v=vs.85).as px - "Custom console hosts on Windows 7 (Hack in the Box Magazine #4)" http://magazine.hitb.org/issues/HITB-Ezine-Issue-004.pdf - "Windows CSRSS Tips & Tricks (Hack in the Box Magazine #5)" http://magazine.hitb.org/issues/HITB-Ezine-Issue-005.pdf - "Win32 Console (Wikipedia)" and the note 3 of the article: http://en.wikipedia.org/wiki/Win32_console#cite_note-3 - Undocumented flags of ConsoleProcess: http://www.catch22.net/tuts/undocumented-createprocess

12 years, 5 months

6
8
0 0

Fwd: [ReactOS] Your organization application has been rejected.

by Amine Khaldi

-------- Original Message -------- Subject: [ReactOS] Your organization application has been rejected. Date: Mon, 08 Apr 2013 18:43:14 +0000 From: no-reply(a)google-melange.appspotmail.com To: amine.khaldi(a)reactos.org Thank you for submitting "ReactOS" organization application to Google Summer of Code 2013. Unfortunately, we were unable to accept your organization's application at this time. Every year we receive many more applications than we are able to accommodate, and we would encourage you to reapply for future instances of the program. If you would like some general feedback on why your organization was not accepted, please consider attending the IRC meeting in #gsoc on Freenode on Friday, April 19, 2013 at 16:00 UTC. Best regards, Google Open Source Programs

12 years, 5 months

1
0
0 0

Linux builder offline

by Pierre Schweitzer

Hi, due to hardware issues, the Linux builder is currently offline. Can't provide any ETA for recovery yet. Sorry for the troubles. With my best regards, -- Pierre Schweitzer<pierre at reactos.org> System Administrator ReactOS Foundation

12 years, 5 months

1
0
0 0

Re: [ros-dev] [ros-diffs] [jgardou] 58660: [MESA32] * Disable SSE optimizations, as they only cause mayhem.

by Timo Kreuzer

What exactly does it cause? And shouldn't we rather fix that, instead of disabling optimizations? mesa is already slow enough. Am 03.04.2013 14:02, schrieb jgardou(a)svn.reactos.org: > Author: jgardou > Date: Wed Apr 3 12:02:58 2013 > New Revision: 58660 > > URL: http://svn.reactos.org/svn/reactos?rev=58660&view=rev > Log: > [MESA32] > * Disable SSE optimizations, as they only cause mayhem. > > Modified: > trunk/reactos/dll/opengl/mesa/src/mesa/CMakeLists.txt > > Modified: trunk/reactos/dll/opengl/mesa/src/mesa/CMakeLists.txt > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/opengl/mesa/src/mesa/C… > ============================================================================== > --- trunk/reactos/dll/opengl/mesa/src/mesa/CMakeLists.txt [iso-8859-1] (original) > +++ trunk/reactos/dll/opengl/mesa/src/mesa/CMakeLists.txt [iso-8859-1] Wed Apr 3 12:02:58 2013 > @@ -33,17 +33,18 @@ > x86/3dnow_xform3.S > x86/3dnow_xform4.S > x86/3dnow_normal.S > - x86/sse_xform1.S > - x86/sse_xform2.S > - x86/sse_xform3.S > - x86/sse_xform4.S > - x86/sse_normal.S > + # x86/sse_xform1.S > + # x86/sse_xform2.S > + # x86/sse_xform3.S > + # x86/sse_xform4.S > + # x86/sse_normal.S > x86/read_rgba_span_x86.S) > add_definitions( > -DUSE_X86_ASM > -DUSE_MMX_ASM > -DUSE_3DNOW_ASM > - -DUSE_SSE_ASM) > + # -DUSE_SSE_ASM > + ) > endif() > > list(APPEND SOURCE > > >

12 years, 5 months

5
6
0 0

Re: [ros-dev] [ros-diffs] [akhaldi] 58662: [PSDK] * Import DEFAULT_UNREACHABLE from Wine.

by Timo Kreuzer

The last definition is not correct, it will not compile. You need "default: (void)0;" or "default: break;" And the thing should also go to ntdef.h Am 03.04.2013 23:17, schrieb akhaldi(a)svn.reactos.org: > Author: akhaldi > Date: Wed Apr 3 21:16:57 2013 > New Revision: 58662 > > URL: http://svn.reactos.org/svn/reactos?rev=58662&view=rev > Log: > [PSDK] > * Import DEFAULT_UNREACHABLE from Wine. > > Modified: > trunk/reactos/include/psdk/winnt.h > > Modified: trunk/reactos/include/psdk/winnt.h > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/psdk/winnt.h?rev=5… > ============================================================================== > --- trunk/reactos/include/psdk/winnt.h [iso-8859-1] (original) > +++ trunk/reactos/include/psdk/winnt.h [iso-8859-1] Wed Apr 3 21:16:57 2013 > @@ -415,6 +415,15 @@ > typedef DWORD FLONG; > > #define C_ASSERT(expr) extern char (*c_assert(void)) [(expr) ? 1 : -1] > + > +/* Eliminate Microsoft C/C++ compiler warning 4715 */ > +#if defined(_MSC_VER) && (_MSC_VER > 1200) > +# define DEFAULT_UNREACHABLE default: __assume(0) > +#elif defined(__clang__) || (defined(__GNUC__) && ((__GNUC__ > 4) || ((__GNUC__ == 4) && (__GNUC_MINOR__ >= 5)))) > +# define DEFAULT_UNREACHABLE default: __builtin_unreachable() > +#else > +# define DEFAULT_UNREACHABLE default: > +#endif > > #include "intrin.h" > > > >

12 years, 5 months

1
0
0 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev