- Ros-dev - ReactOS.org

Notice Of Intent - Visual Studio Build of ReactOS - Take III

by J. C. Jones

Hi All, I had quick chat with Amine and others, and for the time being, I will pick up where I let off in creating a Visual Studio ReactOS.sln with the following features: 1. A single ReactOS.sln file that is interchangeable between Visual Studio 2010 and Visual Studio 2012. 2. A single ReactOS.sln file that incorporates all 800+ .vcxproj files and allows all 800+ project to be viewable within a single session of Visual Studio. 3. No (serious) performance problems with load of the ReactOS.sln file or .vcxproj files. 4. An arrangement in the Solution Workspace that mirrors the structure of the ReactOS repository on disk. 5. The ability to build all applications or drivers by right-clicking, within Solution Workspace, on the folder named applications or drivers and doing clicking Build. 6. Visibility of the lang directories in the Solution Workspace. 7. Visibility of all SVN files in the Solution Workspace, including CMakeLists.txt files. 8. Support for Debug and Release project configurations. 9. Support for x86_32, x86_64, ARM platform configurations. 10. Self-relative paths for all .h's and .libs's so that solution can be moved by the developer on his/her local hard disk without consequence. 11. No need to download any extraneous tools. User should be able to type in SVN URL, either from within Visual Studio, or with Windows Explorer, pull ReactOS repository, load ReactOS.sln, and start editing/compiling/linking, debugging. With the CMakeLists.txt files, the information needed is already present. With Amine's latest work of actually generating the .vcxproj files, things become even easier. However, as I have two other moderate projects going concurrently, one of which I just started, this will take some time. I will provide updates as I go along. Cheers, -John

12 years, 8 months

2
2
0 0

Notice Of Intent - Visual Studio Build of ReactOS

by J. C. Jones

Hi All, Some of you might have seen my recent on the post regarding the build process: http://www.reactos.org/forum/viewtopic.php?f=9&t=12240&start=15 As I mentioned, it would help greatly to lower the barrier-to-entry to less-experienced developers, as well as more experienced developers who might have limited time budgets [Who among us does not have a limited time budget?]. I wanted to send out this message to let everyone know that I intend to use what bit of time that I available right now, at the beginning of January, to tackle this issue head-on. Again, my purpose here is not to step on anyone's toes, but make certain that we never turn away a potentially-valuable contributor simply because they are unnecessarily removed from their development comfort zone. I do realize that there is already on-going work on the build process, and I have no intention of interfering with that. I will wait 24-hours for any objections/reservations from now before making a hard commitment, but frankly, we really to get this done, like right now. Happy New Year. :) -JC

12 years, 8 months

8
33
0 0

Notice Of Intent - Visual Studio Build of ReactOS - Take II

by J. C. Jones

Hi All, I wanted to start fresh since there are several emails/chats going around regarding Visual Studio builds of ReactOS. First, I would like to state something clearly, since there seems to be implicit thoughts to the contrary: Visual Studio is capable of handling a project the size of ReactOS in its entirety in one .sln without any major performance problems, if it is configured correctly. The key phrase is "if it is configured correctly". For example: 1. The performance problem during loading occurs because IntelliSense is being unnecessarily taxed (quite heavily in fact). This is fixed by adding #define WIN32_LEAN_AND_MEAN as appropriate to the IDE settings. 2. The lack of x86_64 and ARM support is occurring because there is a lack of x86_64 and ARM support. :D 3. Some people might look at the Solution Workspace window, see 800 projects, and think, "Wow. That's a lot of projects. I will be scrolling all day long." There is a solution (no pun intended) for that: Don't put 800 projects linearly in the Solution Workspace. Put them in a hierarchy that matches, exactly, the hierarchy of the ReactOS project. 4. That build paths will be broken if the user decides to move his/her ReactOS hierarchy to a different directory after the .sln and .vcxproj files have been generated by cmake, is easily fixed: Use relative paths in the IDE project settings instead. 5. The fact that it is not possible to build, say, just applications, or just drivers, without hunting-and-pecking projects in the Solution Workspace, is related to problem #3: The projects are not yet placed into a hierarchy that mirrors the ReactOS repository. If the projects were placed into a hierarchy that mirrors the ReactOS repository, it would be possible to select, say, drivers, right-click, select Build, and all the drivers will be built depends on what was done in the code, as well as setting proper paths in the IDE. The use would be able to toggle between Debug/Release, x86_32/ARM, and perform the same operation, with expected results. I could go on, but you get the point. It is trivial to set up Visual Studio so that it "behaves properly". I started this effort, and was 10% into the 800 projects, at least setting up the structure, for x86_32, x86_64, and ARM; but I throttled-back because I do not like redundancy of effort, and Amine was already well on his way doing something that was essentially similar. I am confident that, over time, he will solve these problems. In the meantime, I would hope that we keep in mind that the problem is not the tool. The problem is that the tool has not been given a chance to be configured properly. If we configure it properly, these problems go away, and most importantly, when a new developer comes and sees ReactOS in Visual Studio for the first time, what they see makes sense. Let me repeat that: The measure of success here, is not whether it is possible to get Visual Studio to compile ReactOS, although I read some writings about how some wanted the Microsoft compiler over GCC. The measure of success is whether a heavily experience user of Visual Studio sees the IDE for the first time with ReactOS in it, and not start mumbling things like.."Ok.uh... why did they do that.???" By contrast we want them to say: "Wow.800-project solution. Let's see, x86_32, x86_64, ARM support..nice.both Debug and Release present.good good.looks like Solution Workspace mirrors what is on disk..cool.#include paths in IDE project settings are relative to root of solution so I can move solution to another disk if I like.appreciate that.IntelliSense seems to be working correctly.and this livecd thing.I guess right-clicking on that and doing Build does minimum operations necessary to generate a live CD. I wonder what happens when I try to execute the livecd project after built. Wow.that is too awesome!!! Ok. Everything makes sense. I can handle myself from here. Thanks." IMO, we should give Amine time to get the ReactOS repository into this state.. I am re-attaching an image I sent last week about what I would have done for the structure of the Solution Workspace. As you can see from this structure, there is nothing intimidating or inefficient about this structure, and it mirrors what ReactOS veterans see on disk every day. Cheers. -John cid:image001.png@01CDEA11.FFD64AF0

12 years, 8 months

2
1
0 0

Re: [ros-dev] [ros-diffs] [hbelusca] 58154: [REACTOS] Fix the debugging macros introduced in r58132 (for the _FATAL case): do not use exceptions but instead a breakpoint followed by a process termination procedure (or a bug...

by Timo Kreuzer

Why not use NtTerminateProcess() for non-native apps? Am 10.01.2013 02:45, schrieb hbelusca(a)svn.reactos.org: > +/* > + * Declare a target-dependent process termination procedure. > + */ > +#ifndef_NTDDK_ /* User-Mode */ > + #ifndef NTOS_MODE_USER /* Should be Win32 */ > + #ifndef _WIN32 > + #error "Unsupported target." > + #else > + #define TerminateCurrentProcess(Status) TerminateProcess(GetCurrentProcess(), (Status)) > + #endif > + #else /* Native */ > + #ifndef _PSFUNCS_H > + NTSYSCALLAPI > + NTSTATUS > + NTAPI > + NtTerminateProcess( > + IN HANDLE ProcessHandle, > + IN NTSTATUS ExitStatus > + ); > + #endif > + #ifndef NtCurrentProcess > + #define NtCurrentProcess() ((HANDLE)(LONG_PTR)-1) > + #endif > + #define TerminateCurrentProcess(Status) NtTerminateProcess(NtCurrentProcess(), (Status)) > + #endif > +#else /* Kernel-Mode */ > + #include <bugcodes.h> > + #define TerminateCurrentProcess(Status) KeBugCheckEx(CRITICAL_SERVICE_FAILED, (Status), 0, 0, 0) > +#endif > +

12 years, 8 months

2
1
0 0

Re: [ros-dev] [ros-diffs] [hbelusca] 58135: [REACTOS] - Fix the debugging macros I've introduced in r58132; in particular do not use while(true); for forbidding the user to continue execution, but instead raise an exception...

by Timo Kreuzer

I see a problem with this change. A debug breakpoint will always break into the debugger exactly where it is. Like an ASSERT does. But an exception will usually end up in the installed exception handler. This does not really help with figuring out what went wrong. Am 07.01.2013 00:29, schrieb hbelusca(a)svn.reactos.org: > Author: hbelusca > Date: Sun Jan 6 23:29:05 2013 > New Revision: 58135 > > URL: http://svn.reactos.org/svn/reactos?rev=58135&view=rev > Log: > [REACTOS] > - Fix the debugging macros I've introduced in r58132; in particular do not use while(true); for forbidding the user to continue execution, but instead raise an exception with EXCEPTION_NONCONTINUABLE flag (included when called RtlRaiseStatus). > - Adjust the definition of RtlRaiseStatus (in kernel-mode it is ExRaiseStatus which is used). > > Modified: > trunk/reactos/include/reactos/debug.h > > Modified: trunk/reactos/include/reactos/debug.h > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/reactos/debug.h?re… > ============================================================================== > --- trunk/reactos/include/reactos/debug.h [iso-8859-1] (original) > +++ trunk/reactos/include/reactos/debug.h [iso-8859-1] Sun Jan 6 23:29:05 2013 > @@ -15,7 +15,7 @@ > #ifndef __INTERNAL_DEBUG > #define __INTERNAL_DEBUG > > -/* Define DbgPrint/DbgPrintEx/RtlAssert unless the NDK is used */ > +/* Define DbgPrint/DbgPrintEx/RtlAssert/RtlRaiseStatus unless the NDK is used */ > #if !defined(_RTLFUNCS_H) && !defined(_NTDDK_) > > /* Make sure we have basic types (some people include us *before* SDK)... */ > @@ -51,7 +51,27 @@ > PCHAR Message > ); > > +#ifndef _NTDEF_ /* Guard against redefinition from ntdef.h */ > + typedef _Return_type_success_(return >= 0) LONG NTSTATUS; > +#endif > +__analysis_noreturn > +NTSYSAPI > +VOID > +NTAPI > +RtlRaiseStatus( > + _In_ NTSTATUS Status > +); > + > #endif /* !defined(_RTLFUNCS_H) && !defined(_NTDDK_) */ > + > + > +/* Fix usage of RtlRaiseStatus */ > +#if !defined(_RTLFUNCS_H) && defined(_NTDDK_) > + #define RaiseStatus ExRaiseStatus > +#else > + #define RaiseStatus RtlRaiseStatus > +#endif /* !defined(_RTLFUNCS_H) && defined(_NTDDK_) */ > + > > #ifndef assert > #ifndef NASSERT > @@ -136,11 +156,7 @@ > > #endif /* not DBG */ > > -/* > - * These macros are designed to display an optional printf-like > - * user-defined message and to break into the debugger. > - * After that they allow to continue the program execution. > - */ > +/******************************************************************************/ > /* For internal purposes only */ > #define __ERROR_DBGBREAK(...) \ > do { \ > @@ -148,6 +164,18 @@ > DbgBreakPoint(); \ > } while (0) > > +/* For internal purposes only */ > +#define __ERROR_FATAL(Status, ...) \ > +do { \ > + DbgPrint("" __VA_ARGS__); \ > + RaiseStatus((Status)); \ > +} while (0) > + > +/* > + * These macros are designed to display an optional printf-like > + * user-defined message and to break into the debugger. > + * After that they allow to continue the program execution. > + */ > #define ERROR_DBGBREAK(...) \ > do { \ > __NOTICE(ERROR, "\n"); \ > @@ -165,19 +193,18 @@ > * user-defined message and to break into the debugger. > * After that they halt the execution of the current thread. > */ > -#define ERROR_FATAL(...) \ > -do { \ > - __NOTICE(UNRECOVERABLE ERROR, "\n"); \ > - __ERROR_DBGBREAK(__VA_ARGS__); \ > - while (TRUE); \ > +#define ERROR_FATAL(...) \ > +do { \ > + __NOTICE(UNRECOVERABLE ERROR, "\n"); \ > + __ERROR_FATAL(STATUS_ASSERTION_FAILURE, __VA_ARGS__); \ > } while (0) > > #define UNIMPLEMENTED_FATAL(...) \ > do { \ > __NOTICE(UNRECOVERABLE ERROR, "is UNIMPLEMENTED!\n"); \ > - __ERROR_DBGBREAK(__VA_ARGS__); \ > - while (TRUE); \ > -} while (0) > + __ERROR_FATAL(STATUS_NOT_IMPLEMENTED, __VA_ARGS__); \ > +} while (0) > +/******************************************************************************/ > > #define ASSERT_IRQL_LESS_OR_EQUAL(x) ASSERT(KeGetCurrentIrql()<=(x)) > #define ASSERT_IRQL_EQUAL(x) ASSERT(KeGetCurrentIrql()==(x)) > > >

12 years, 8 months

2
4
0 0

Re: [ros-dev] [ros-diffs] [hbelusca] 58110: while (TRUE); (when something is unimplemented) ---> ASSERT(FALSE); // while (TRUE); (unless we deal with a 'noreturn' function), and in some cases, return an adequate value. Part...

by Aleksey Bragin

With all respect, I don't understand many of these changes. Answering between the lines. On 04.01.2013 15:47, hbelusca(a)svn.reactos.org wrote: > NTSTATUS > @@ -643,7 +643,8 @@ > /* FIXME: TODO */ > DPRINT1("You have implemented the KD routines for searching PCI debugger" > "devices, but you have forgotten to implement this routine\n"); > - while (TRUE); > + UNIMPLEMENTED; > + ASSERT(FALSE); // while (TRUE); > } It already prints a mandatory log message that this part is unimplemented. And execution is supposed to stop after printing this message, because it's meaningless to continue (that's why while(TRUE); was put there in the first place). > > static ULONG NTAPI > @@ -678,7 +679,7 @@ > { > /* /PCILOCK is not yet supported */ > UNIMPLEMENTED; > - while (TRUE); > + ASSERT(FALSE); // while (TRUE); > } > #endif > /* Now create the correct resource list based on the supported bus ranges */ It already has UNIMPLEMENTED; and now you added an ASSERT(FALSE); which essentially is the same thing. And if continuation is possible, then just UNIMPLEMENTED would be enough. I'd like some general solution to this. Like, UNIMPLEMENTED_FATAL() or something like that. Any thoughts? Regards, Aleksey Bragin

12 years, 8 months

5
6
0 0

Monthly meeting December 2012 rescheduled

by Aleksey Bragin

Hello! Due to Christmas and New Year holidays this month's status meeting makes little sense. Preliminary it's rescheduled to January, exact dates will be proposed after speaking to our team members. Thank you all for your work in 2012, and bright future awaits us in 2013, I'm sure. Best regards, Aleksey Bragin

12 years, 8 months

5
8
0 0

IPv6 link down

by Pierre Schweitzer

Hi, due to a server move, one IPv6 link is currently down waiting for its replacing link (and for DNS update). Affected services are mainly Jira, Fisheye & Drupal website. We are working on it. Sorry for the inconvenience. IPv4 is all fine on those servers. With my best regards, -- Pierre Schweitzer <pierre(a)reactos.org> System Administrator ReactOS Foundation

12 years, 8 months

2
4
0 0

Re: [ros-dev] [ros-diffs] [tkreuzer] 58101: [WIN32K] Revert the revert from r58091 and apply a correct fix (passed parameters to RECTL_vSetRect() in wrong order)

by Jérôme Gardou

Thank you for looking into this, I am not really available for coding in reactos at the moment. Greetings. Jérôme tkreuzer(a)svn.reactos.org a écrit : > Author: tkreuzer > Date: Wed Jan 2 14:52:34 2013 > New Revision: 58101 > > URL: http://svn.reactos.org/svn/reactos?rev=58101&view=rev > Log: > [WIN32K] > Revert the revert from r58091 and apply a correct fix (passed parameters to RECTL_vSetRect() in wrong order) > > Modified: > trunk/reactos/win32ss/gdi/ntgdi/dib.h > trunk/reactos/win32ss/gdi/ntgdi/dibobj.c > trunk/reactos/win32ss/user/ntuser/clipboard.c > trunk/reactos/win32ss/user/ntuser/misc/file.c > > Modified: trunk/reactos/win32ss/gdi/ntgdi/dib.h > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/gdi/ntgdi/dib.h?re… > ============================================================================== > --- trunk/reactos/win32ss/gdi/ntgdi/dib.h [iso-8859-1] (original) > +++ trunk/reactos/win32ss/gdi/ntgdi/dib.h [iso-8859-1] Wed Jan 2 14:52:34 2013 > @@ -7,8 +7,11 @@ > INT APIENTRY DIB_GetDIBImageBytes (INT width, INT height, INT depth); > HPALETTE FASTCALL DIB_MapPaletteColors(PPALETTE ppal, CONST BITMAPINFO* lpbmi); > HPALETTE FASTCALL BuildDIBPalette (CONST BITMAPINFO *bmi); > + > +/* Those functions permit to tranparently work with a BITMAPCOREINFO structure */ > BITMAPINFO* FASTCALL DIB_ConvertBitmapInfo(CONST BITMAPINFO* bmi, DWORD Usage); > -VOID FASTCALL DIB_FreeConvertedBitmapInfo(BITMAPINFO* converted, BITMAPINFO* orig); > +/* Pass Usage = -1 if you don't want to convert the BITMAPINFO back to BITMAPCOREINFO */ > +VOID FASTCALL DIB_FreeConvertedBitmapInfo(BITMAPINFO* converted, BITMAPINFO* orig, DWORD Usage); > > INT > APIENTRY > > Modified: trunk/reactos/win32ss/gdi/ntgdi/dibobj.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/gdi/ntgdi/dibobj.c… > ============================================================================== > --- trunk/reactos/win32ss/gdi/ntgdi/dibobj.c [iso-8859-1] (original) > +++ trunk/reactos/win32ss/gdi/ntgdi/dibobj.c [iso-8859-1] Wed Jan 2 14:52:34 2013 > @@ -584,7 +584,6 @@ > DWORD compr, size ; > USHORT i; > int bitmap_type; > - RGBTRIPLE* rgbTriples; > RGBQUAD* rgbQuads; > VOID* colorPtr; > > @@ -594,7 +593,6 @@ > return 0; > > colorPtr = (LPBYTE)Info + Info->bmiHeader.biSize; > - rgbTriples = colorPtr; > rgbQuads = colorPtr; > > bitmap_type = DIB_GetBitmapInfo(&Info->bmiHeader, > @@ -643,15 +641,6 @@ > switch(bpp) > { > case 0: /* Only info */ > - if(pbmci) > - { > - pbmci->bmciHeader.bcWidth = (WORD)psurf->SurfObj.sizlBitmap.cx; > - pbmci->bmciHeader.bcHeight = (WORD)((psurf->SurfObj.fjBitmap & BMF_TOPDOWN) ? > - -psurf->SurfObj.sizlBitmap.cy : > - psurf->SurfObj.sizlBitmap.cy); > - pbmci->bmciHeader.bcPlanes = 1; > - pbmci->bmciHeader.bcBitCount = BitsPerFormat(psurf->SurfObj.iBitmapFormat); > - } > Info->bmiHeader.biWidth = psurf->SurfObj.sizlBitmap.cx; > Info->bmiHeader.biHeight = (psurf->SurfObj.fjBitmap & BMF_TOPDOWN) ? > -psurf->SurfObj.sizlBitmap.cy : > @@ -702,16 +691,6 @@ > if(Usage == DIB_RGB_COLORS) > { > ULONG colors = min(psurf->ppal->NumColors, 256); > - > - if(pbmci) > - { > - for(i = 0; i < colors; i++) > - { > - rgbTriples[i].rgbtRed = psurf->ppal->IndexedColors[i].peRed; > - rgbTriples[i].rgbtGreen = psurf->ppal->IndexedColors[i].peGreen; > - rgbTriples[i].rgbtBlue = psurf->ppal->IndexedColors[i].peBlue; > - } > - } > if(colors != 256) Info->bmiHeader.biClrUsed = colors; > for(i = 0; i < colors; i++) > { > @@ -724,10 +703,7 @@ > else > { > for(i = 0; i < 256; i++) > - { > - if(pbmci) ((WORD*)rgbTriples)[i] = i; > ((WORD*)rgbQuads)[i] = i; > - } > } > } > else > @@ -736,7 +712,6 @@ > { > for(i = 0; i < 256; i++) > { > - if(pbmci) ((WORD*)rgbTriples)[i] = i; > ((WORD*)rgbQuads)[i] = i; > } > } > @@ -753,13 +728,6 @@ > } > for (i = 0; i < pDcPal->NumColors; i++) > { > - if (pbmci) > - { > - rgbTriples[i].rgbtRed = pDcPal->IndexedColors[i].peRed; > - rgbTriples[i].rgbtGreen = pDcPal->IndexedColors[i].peGreen; > - rgbTriples[i].rgbtBlue = pDcPal->IndexedColors[i].peBlue; > - } > - > rgbQuads[i].rgbRed = pDcPal->IndexedColors[i].peRed; > rgbQuads[i].rgbGreen = pDcPal->IndexedColors[i].peGreen; > rgbQuads[i].rgbBlue = pDcPal->IndexedColors[i].peBlue; > @@ -772,55 +740,20 @@ > switch (bpp) > { > case 1: > - if (pbmci) > - { > - rgbTriples[0].rgbtRed = rgbTriples[0].rgbtGreen = > - rgbTriples[0].rgbtBlue = 0; > - rgbTriples[1].rgbtRed = rgbTriples[1].rgbtGreen = > - rgbTriples[1].rgbtBlue = 0xff; > - } > - rgbQuads[0].rgbRed = rgbQuads[0].rgbGreen = > - rgbQuads[0].rgbBlue = 0; > + rgbQuads[0].rgbRed = rgbQuads[0].rgbGreen = rgbQuads[0].rgbBlue = 0; > rgbQuads[0].rgbReserved = 0; > - rgbQuads[1].rgbRed = rgbQuads[1].rgbGreen = > - rgbQuads[1].rgbBlue = 0xff; > + rgbQuads[1].rgbRed = rgbQuads[1].rgbGreen = rgbQuads[1].rgbBlue = 0xff; > rgbQuads[1].rgbReserved = 0; > break; > > case 4: > - if (pbmci) > - RtlCopyMemory(rgbTriples, EGAColorsTriples, sizeof(EGAColorsTriples)); > RtlCopyMemory(rgbQuads, EGAColorsQuads, sizeof(EGAColorsQuads)); > - > break; > > case 8: > { > INT r, g, b; > RGBQUAD *color; > - if (pbmci) > - { > - RGBTRIPLE *colorTriple; > - > - RtlCopyMemory(rgbTriples, DefLogPaletteTriples, > - 10 * sizeof(RGBTRIPLE)); > - RtlCopyMemory(rgbTriples + 246, DefLogPaletteTriples + 10, > - 10 * sizeof(RGBTRIPLE)); > - colorTriple = rgbTriples + 10; > - for(r = 0; r <= 5; r++) /* FIXME */ > - { > - for(g = 0; g <= 5; g++) > - { > - for(b = 0; b <= 5; b++) > - { > - colorTriple->rgbtRed = (r * 0xff) / 5; > - colorTriple->rgbtGreen = (g * 0xff) / 5; > - colorTriple->rgbtBlue = (b * 0xff) / 5; > - colorTriple++; > - } > - } > - } > - } > memcpy(rgbQuads, DefLogPaletteQuads, > 10 * sizeof(RGBQUAD)); > memcpy(rgbQuads + 246, DefLogPaletteQuads + 10, > @@ -935,12 +868,7 @@ > > psurfDest = SURFACE_ShareLockSurface(hBmpDest); > > - RECTL_vSetRect(&rcDest, 0, 0, ScanLines, psurf->SurfObj.sizlBitmap.cx); > - > - rcDest.left = 0; > - rcDest.top = 0; > - rcDest.bottom = ScanLines; > - rcDest.right = psurf->SurfObj.sizlBitmap.cx; > + RECTL_vSetRect(&rcDest, 0, 0, psurf->SurfObj.sizlBitmap.cx, ScanLines); > > srcPoint.x = 0; > > @@ -990,7 +918,7 @@ > > if(pDC) DC_UnlockDc(pDC); > if(psurf) SURFACE_ShareUnlockSurface(psurf); > - if(pbmci) DIB_FreeConvertedBitmapInfo(Info, (BITMAPINFO*)pbmci); > + if(pbmci) DIB_FreeConvertedBitmapInfo(Info, (BITMAPINFO*)pbmci, Usage); > > return ScanLines; > } > @@ -1929,10 +1857,51 @@ > /* Frees a BITMAPINFO created with DIB_ConvertBitmapInfo */ > VOID > FASTCALL > -DIB_FreeConvertedBitmapInfo(BITMAPINFO* converted, BITMAPINFO* orig) > -{ > - if(converted != orig) > +DIB_FreeConvertedBitmapInfo(BITMAPINFO* converted, BITMAPINFO* orig, DWORD usage) > +{ > + BITMAPCOREINFO* pbmci; > + if(converted == orig) > + return; > + > + if(usage == -1) > + { > + /* Caller don't want any conversion */ > ExFreePoolWithTag(converted, TAG_DIB); > + return; > + } > + > + /* Perform inverse conversion */ > + pbmci = (BITMAPCOREINFO*)orig; > + > + ASSERT(pbmci->bmciHeader.bcSize == sizeof(BITMAPCOREHEADER)); > + pbmci->bmciHeader.bcBitCount = converted->bmiHeader.biBitCount; > + pbmci->bmciHeader.bcWidth = converted->bmiHeader.biWidth; > + pbmci->bmciHeader.bcHeight = converted->bmiHeader.biHeight; > + pbmci->bmciHeader.bcPlanes = converted->bmiHeader.biPlanes; > + > + if(pbmci->bmciHeader.bcBitCount <= 8) > + { > + UINT numColors = converted->bmiHeader.biClrUsed; > + if(!numColors) numColors = 1 << pbmci->bmciHeader.bcBitCount; > + if(usage == DIB_PAL_COLORS) > + { > + RtlZeroMemory(pbmci->bmciColors, (1 << pbmci->bmciHeader.bcBitCount) * sizeof(WORD)); > + RtlCopyMemory(pbmci->bmciColors, converted->bmiColors, numColors * sizeof(WORD)); > + } > + else > + { > + UINT i; > + RtlZeroMemory(pbmci->bmciColors, (1 << pbmci->bmciHeader.bcBitCount) * sizeof(RGBTRIPLE)); > + for(i=0; i<numColors; i++) > + { > + pbmci->bmciColors[i].rgbtRed = converted->bmiColors[i].rgbRed; > + pbmci->bmciColors[i].rgbtGreen = converted->bmiColors[i].rgbGreen; > + pbmci->bmciColors[i].rgbtBlue = converted->bmiColors[i].rgbBlue; > + } > + } > + } > + /* Now free it, it's not needed anymore */ > + ExFreePoolWithTag(converted, TAG_DIB); > } > > /* EOF */ > > Modified: trunk/reactos/win32ss/user/ntuser/clipboard.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/user/ntuser/clipbo… > ============================================================================== > --- trunk/reactos/win32ss/user/ntuser/clipboard.c [iso-8859-1] (original) > +++ trunk/reactos/win32ss/user/ntuser/clipboard.c [iso-8859-1] Wed Jan 2 14:52:34 2013 > @@ -276,7 +276,7 @@ > UserReleaseDC(NULL, hdc, FALSE); > > if (pConvertedBmi) > - DIB_FreeConvertedBitmapInfo(pConvertedBmi, pBmi); > + DIB_FreeConvertedBitmapInfo(pConvertedBmi, pBmi, -1); > } > > VOID static NTAPI > > Modified: trunk/reactos/win32ss/user/ntuser/misc/file.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/user/ntuser/misc/f… > ============================================================================== > --- trunk/reactos/win32ss/user/ntuser/misc/file.c [iso-8859-1] (original) > +++ trunk/reactos/win32ss/user/ntuser/misc/file.c [iso-8859-1] Wed Jan 2 14:52:34 2013 > @@ -233,7 +233,7 @@ > 0); > > NtGdiDeleteObjectApp(hdc); > - DIB_FreeConvertedBitmapInfo(pConvertedInfo, pbmi); > + DIB_FreeConvertedBitmapInfo(pConvertedInfo, pbmi, -1); > } > else > { > >

12 years, 8 months

1
0
0 0

Re: [ros-dev] [ros-diffs] [hbelusca] 58016: [MSVCRT] Export __crtLCMapStringW and correct __crtLCMapStringA: their prototypes are : int CDECL __crtLCMapStringW(LCID lcid, DWORD mapflags, const wchar_t *src, int srclen, wcha...

by Jérôme Gardou

I think that in the spec files semantics, destination strings are just buffers and should be considered as pointers. hbelusca(a)svn.reactos.org a écrit : > Author: hbelusca > Date: Wed Dec 26 19:26:08 2012 > New Revision: 58016 > > URL: http://svn.reactos.org/svn/reactos?rev=58016&view=rev > Log: > [MSVCRT] > Export __crtLCMapStringW and correct __crtLCMapStringA: their prototypes are : > > int CDECL __crtLCMapStringW(LCID lcid, DWORD mapflags, const wchar_t *src, > int srclen, wchar_t *dst, int dstlen, unsigned int codepage, int xflag) > > and > > int CDECL __crtLCMapStringA(LCID lcid, DWORD mapflags, const char* src, > int srclen, char* dst, int dstlen, unsigned int codepage, int xflag) > > Needed by SVN. > > Modified: > trunk/reactos/dll/win32/msvcrt/msvcrt.spec > > Modified: trunk/reactos/dll/win32/msvcrt/msvcrt.spec > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/msvcrt/msvcrt.sp… > ============================================================================== > --- trunk/reactos/dll/win32/msvcrt/msvcrt.spec [iso-8859-1] (original) > +++ trunk/reactos/dll/win32/msvcrt/msvcrt.spec [iso-8859-1] Wed Dec 26 19:26:08 2012 > @@ -143,8 +143,8 @@ > @ cdecl __crtCompareStringW(long long wstr long wstr long) kernel32.CompareStringW > @ cdecl __crtGetLocaleInfoW(long long ptr long) kernel32.GetLocaleInfoW > @ cdecl __crtGetStringTypeW(long long wstr long ptr) > -@ cdecl __crtLCMapStringA(long long str long ptr long long long) > -# stub __crtLCMapStringW > +@ cdecl __crtLCMapStringA(long long str long str long long long) > +@ cdecl __crtLCMapStringW(long long wstr long wstr long long long) > @ cdecl __daylight() __p__daylight > @ cdecl __dllonexit(ptr ptr ptr) > @ cdecl __doserrno() > >

12 years, 8 months

2
2
0 0

New testbot slave

by Pierre Schweitzer

Hello, starting now a new debug testbot slave is available. It is running VMware Player 5.0.1 under Linux x64. It will run all the ISOs built by the Linux builder. Its results are available at the usual place: http://www.reactos.org/testman with the name: CMake_x86_GCCLin (VMPlayer). With my best regards, -- Pierre Schweitzer <pierre(a)reactos.org> System Administrator ReactOS Foundation

12 years, 8 months

2
1
0 0

Universities collaboration

by Aleksey Bragin

Hello and Merry Christmas! I know there are people from various technical universities around the world subscribed to this list. If you work there, please reply to me, as I'm looking for some collaboration related to Operating Systems theory course and ReactOS. Thank you, Aleksey Bragin P.S. Crossposting to both ros-dev and ros-general is a bad idea, but I'm doing this to reach out all our subscribers. Sorry for inconvinience.

12 years, 8 months

1
0
0 0

Re: [ros-dev] [ros-diffs] [tfaber] 57976: [EXPLORER_NEW] - Add a manifest file to support theming - Formatting fixes - Based on Andrew Green's GSoC branch

by Ged Murphy

Are you planning on resurrecting this branch Thomas? On 23/12/2012 10:25, "tfaber(a)svn.reactos.org" <tfaber(a)svn.reactos.org> wrote: >Author: tfaber >Date: Sun Dec 23 10:25:19 2012 >New Revision: 57976 > >URL: http://svn.reactos.org/svn/reactos?rev=57976&view=rev >Log: >[EXPLORER_NEW] >- Add a manifest file to support theming >- Formatting fixes >- Based on Andrew Green's GSoC branch > >Added: > trunk/reactos/base/shell/explorer-new/explorer.exe.manifest (with >props) >Modified: > trunk/reactos/base/shell/explorer-new/explorer.rc > trunk/reactos/base/shell/explorer-new/taskswnd.c > trunk/reactos/base/shell/explorer-new/trayntfy.c

12 years, 8 months

2
1
0 0

Re: [ros-dev] [ros-builds] Trunk_x86_GCCLin Release: build failed

by Pierre Schweitzer

Fixed as well. Forgot that one, sorry. Le samedi 15 décembre 2012 à 12:48 +0000, buildbot(a)reactos.org a écrit : > The Buildbot has detected a failed build on builder Trunk_x86_GCCLin Release while building ReactOS. > Full details are available at: > http://build.reactos.org/builders/Trunk_x86_GCCLin%20Release/builds/289 > > Buildbot URL: http://build.reactos.org/ > > Buildslave for this Build: Linux_AMD64_1B > > Build Reason: The Periodic scheduler named 'release' triggered this build > Build Source Stamp: HEAD > Blamelist: > > BUILD FAILED: failed compile_1 > > sincerely, > -The Buildbot > > -- Pierre Schweitzer <pierre(a)reactos.org> Systems Administrator ReactOS Foundation

12 years, 9 months

1
0
0 0

Re: [ros-dev] [ros-diffs] [jgardou] 57909: [INCLUDE/CRT] - _CRT_NON_CONFORMING_SWPRINTFS is not relevant for us.

by Timo Kreuzer

The reason for this define is to allow swprintf etc., wich is then an alias for _swprintf, which we do implement. I don't see why this should be disabled. Am 13.12.2012 20:21, schrieb jgardou(a)svn.reactos.org: > Author: jgardou > Date: Thu Dec 13 19:21:30 2012 > New Revision: 57909 > > URL: http://svn.reactos.org/svn/reactos?rev=57909&view=rev > Log: > [INCLUDE/CRT] > - _CRT_NON_CONFORMING_SWPRINTFS is not relevant for us. > > Modified: > trunk/reactos/include/crt/stdio.h > trunk/reactos/include/crt/wchar.h > > Modified: trunk/reactos/include/crt/stdio.h > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/crt/stdio.h?rev=57… > ============================================================================== > --- trunk/reactos/include/crt/stdio.h [iso-8859-1] (original) > +++ trunk/reactos/include/crt/stdio.h [iso-8859-1] Thu Dec 13 19:21:30 2012 > @@ -322,12 +322,14 @@ > #include <vadefs.h> > #endif > > +#if 0 //this is for MSVCRT80 and higher, which we don't use nor implement > #ifdef _CRT_NON_CONFORMING_SWPRINTFS > #ifndef __cplusplus > #define swprintf _swprintf > #define vswprintf _vswprintf > #define _swprintf_l __swprintf_l > #define _vswprintf_l __vswprintf_l > +#endif > #endif > #endif > > > Modified: trunk/reactos/include/crt/wchar.h > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/crt/wchar.h?rev=57… > ============================================================================== > --- trunk/reactos/include/crt/wchar.h [iso-8859-1] (original) > +++ trunk/reactos/include/crt/wchar.h [iso-8859-1] Thu Dec 13 19:21:30 2012 > @@ -561,12 +561,14 @@ > _CRTIMP int __cdecl __swprintf_l(wchar_t *_Dest,const wchar_t *_Format,_locale_t _Plocinfo,...); > _CRTIMP int __cdecl __vswprintf_l(wchar_t *_Dest,const wchar_t *_Format,_locale_t _Plocinfo,va_list _Args); > > +#if 0 //this is for MSVCRT80 and higher, which we don't use nor implement > #ifdef _CRT_NON_CONFORMING_SWPRINTFS > #ifndef __cplusplus > #define swprintf _swprintf > #define vswprintf _vswprintf > #define _swprintf_l __swprintf_l > #define _vswprintf_l __vswprintf_l > +#endif > #endif > #endif > > > >

12 years, 9 months

2
1
0 0

Re: [ros-dev] [ros-builds] Trunk_x86_GCCLin Debug: build failed

by Pierre Schweitzer

Fixed. The needed env variable is now exported. Le vendredi 14 décembre 2012 à 21:56 +0000, buildbot(a)reactos.org a écrit : > The Buildbot has detected a failed build on builder Trunk_x86_GCCLin Debug while building ReactOS. > Full details are available at: > http://build.reactos.org/builders/Trunk_x86_GCCLin%20Debug/builds/2066 > > Buildbot URL: http://build.reactos.org/ > > Buildslave for this Build: Linux_AMD64_1 > > Build Reason: scheduler > Build Source Stamp: 57913 > Blamelist: akhaldi > > BUILD FAILED: failed compile_1 > > sincerely, > -The Buildbot > > -- Pierre Schweitzer <pierre(a)reactos.org> Systems Administrator ReactOS Foundation

12 years, 9 months

1
0
0 0

Re: [ros-dev] [ros-diffs] [tfaber] 57815: [SPIDER] - Only dissolve a stack of cards if they're of the same color - Allow easier recognition of suit in concealed cards - Patch by Marcel Leyendeckers, m dot leyendeckers at gm...

by Timo Kreuzer

YAY! Finally this is fixed! Am 07.12.2012 19:00, schrieb tfaber(a)svn.reactos.org: > Author: tfaber > Date: Fri Dec 7 18:00:30 2012 > New Revision: 57815 > > URL: http://svn.reactos.org/svn/reactos?rev=57815&view=rev > Log: > [SPIDER] > - Only dissolve a stack of cards if they're of the same color > - Allow easier recognition of suit in concealed cards > - Patch by Marcel Leyendeckers, m dot leyendeckers at gmx dot de > CORE-6808 #resolve #comment Committed. Thanks! > > Modified: > trunk/reactos/base/applications/games/spider/spigame.cpp > > Modified: trunk/reactos/base/applications/games/spider/spigame.cpp > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/games/sp… > ============================================================================== > --- trunk/reactos/base/applications/games/spider/spigame.cpp [iso-8859-1] (original) > +++ trunk/reactos/base/applications/games/spider/spigame.cpp [iso-8859-1] Fri Dec 7 18:00:30 2012 > @@ -249,7 +249,8 @@ > int i, max = NUM_ONECOLOR_CARDS - dragcards.NumCards() - 1; > > /* Dragged cards have been checked to be in order, check stack cards */ > - if (stackLookingGood(mystack, max)) > + if (mystack[0].Suit() == dragcard.Suit() && > + stackLookingGood(mystack, max)) > { > CardStack s = stackobj.GetCardStack(); > CardStack f; > @@ -279,8 +280,8 @@ > { > int i, pos; > > - /* Compute the value for yRowStackCardOffset based on the height of the card, so the card number isn't hidden on larger cards */ > - yRowStackCardOffset = (int)(__cardheight / 6.7); > + /* Compute the value for yRowStackCardOffset based on the height of the card, so the card number and suite isn't hidden on larger cards except Ace */ > + yRowStackCardOffset = (int)(__cardheight / 6.4); > > pDeck = SpiderWnd.CreateRegion(0, true, 0, 0, -15, 0); > pDeck->SetFaceDirection(CS_FACE_DOWN, 0); > > >

12 years, 9 months

2
1
0 0

Re: [ros-dev] [ros-diffs] [hbelusca] 57899: [FREELDR] - Use a list of possible operating system method loading to load ReactOS / ROS-Setup / Windows / Linux or booting from a disk / partition ..., instead of using a (huge) ...

by Aleksey Bragin

Great, that if/elseif was really lame and I wanted to fix that since the moment I added Windows boot support. Regards, Aleksey Bragin On 13.12.2012 4:46, hbelusca(a)svn.reactos.org wrote: > Author: hbelusca > Date: Thu Dec 13 00:46:55 2012 > New Revision: 57899 > > URL: http://svn.reactos.org/svn/reactos?rev=57899&view=rev > Log: > [FREELDR] > - Use a list of possible operating system method loading to load ReactOS / ROS-Setup / Windows / Linux or booting from a disk / partition ..., instead of using a (huge) if () else if () ... instruction. > - Modify the corresponding functions to take into account for this new functionality. > - Allow having a live + boot cd if needed, in a elegant way. > > Modified: > trunk/reactos/boot/freeldr/freeldr/arch/i386/custom.c > trunk/reactos/boot/freeldr/freeldr/arch/i386/miscboot.c > trunk/reactos/boot/freeldr/freeldr/bootmgr.c > trunk/reactos/boot/freeldr/freeldr/include/arch/i386/miscboot.h > trunk/reactos/boot/freeldr/freeldr/include/linux.h > trunk/reactos/boot/freeldr/freeldr/include/winldr.h > trunk/reactos/boot/freeldr/freeldr/linuxboot.c > trunk/reactos/boot/freeldr/freeldr/windows/setupldr.c > trunk/reactos/boot/freeldr/freeldr/windows/winldr.c > > Modified: trunk/reactos/boot/freeldr/freeldr/arch/i386/custom.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/arch/… > ============================================================================== > --- trunk/reactos/boot/freeldr/freeldr/arch/i386/custom.c [iso-8859-1] (original) > +++ trunk/reactos/boot/freeldr/freeldr/arch/i386/custom.c [iso-8859-1] Thu Dec 13 00:46:55 2012 > @@ -40,8 +40,8 @@ > "ReactOS", > "Linux" > }; > - ULONG CustomBootMenuCount = sizeof(CustomBootMenuList) / sizeof(CustomBootMenuList[0]); > - ULONG SelectedMenuItem; > + ULONG CustomBootMenuCount = sizeof(CustomBootMenuList) / sizeof(CustomBootMenuList[0]); > + ULONG SelectedMenuItem; > > if (!UiDisplayMenu("Please choose a boot method:", > CustomBootMenuList, > @@ -74,10 +74,11 @@ > > VOID OptionMenuCustomBootDisk(VOID) > { > - CHAR SectionName[100]; > - CHAR BootDriveString[20]; > - ULONG SectionId; > + ULONG_PTR SectionId; > + CHAR SectionName[100]; > + CHAR BootDriveString[20]; > TIMEINFO* TimeInfo; > + OperatingSystemItem OperatingSystem; > > RtlZeroMemory(SectionName, sizeof(SectionName)); > RtlZeroMemory(BootDriveString, sizeof(BootDriveString)); > @@ -111,16 +112,21 @@ > > UiMessageBox(CustomBootPrompt); > > - LoadAndBootDrive(SectionName); > + OperatingSystem.SystemPartition = SectionName; > + OperatingSystem.LoadIdentifier = NULL; > + OperatingSystem.OsLoadOptions = NULL; > + > + LoadAndBootDrive(&OperatingSystem, 0); > } > > VOID OptionMenuCustomBootPartition(VOID) > { > - CHAR SectionName[100]; > - CHAR BootDriveString[20]; > - CHAR BootPartitionString[20]; > - ULONG SectionId; > + ULONG_PTR SectionId; > + CHAR SectionName[100]; > + CHAR BootDriveString[20]; > + CHAR BootPartitionString[20]; > TIMEINFO* TimeInfo; > + OperatingSystemItem OperatingSystem; > > RtlZeroMemory(SectionName, sizeof(SectionName)); > RtlZeroMemory(BootDriveString, sizeof(BootDriveString)); > @@ -166,17 +172,22 @@ > > UiMessageBox(CustomBootPrompt); > > - LoadAndBootPartition(SectionName); > + OperatingSystem.SystemPartition = SectionName; > + OperatingSystem.LoadIdentifier = NULL; > + OperatingSystem.OsLoadOptions = NULL; > + > + LoadAndBootPartition(&OperatingSystem, 0); > } > > VOID OptionMenuCustomBootBootSectorFile(VOID) > { > - CHAR SectionName[100]; > - CHAR BootDriveString[20]; > - CHAR BootPartitionString[20]; > - CHAR BootSectorFileString[200]; > - ULONG SectionId; > + ULONG_PTR SectionId; > + CHAR SectionName[100]; > + CHAR BootDriveString[20]; > + CHAR BootPartitionString[20]; > + CHAR BootSectorFileString[200]; > TIMEINFO* TimeInfo; > + OperatingSystemItem OperatingSystem; > > RtlZeroMemory(SectionName, sizeof(SectionName)); > RtlZeroMemory(BootDriveString, sizeof(BootDriveString)); > @@ -234,19 +245,24 @@ > > UiMessageBox(CustomBootPrompt); > > - LoadAndBootBootSector(SectionName); > + OperatingSystem.SystemPartition = SectionName; > + OperatingSystem.LoadIdentifier = NULL; > + OperatingSystem.OsLoadOptions = NULL; > + > + LoadAndBootBootSector(&OperatingSystem, 0); > } > > VOID OptionMenuCustomBootLinux(VOID) > { > - CHAR SectionName[100]; > - CHAR BootDriveString[20]; > - CHAR BootPartitionString[20]; > - CHAR LinuxKernelString[200]; > - CHAR LinuxInitrdString[200]; > - CHAR LinuxCommandLineString[200]; > - ULONG SectionId; > + ULONG_PTR SectionId; > + CHAR SectionName[100]; > + CHAR BootDriveString[20]; > + CHAR BootPartitionString[20]; > + CHAR LinuxKernelString[200]; > + CHAR LinuxInitrdString[200]; > + CHAR LinuxCommandLineString[200]; > TIMEINFO* TimeInfo; > + OperatingSystemItem OperatingSystem; > > RtlZeroMemory(SectionName, sizeof(SectionName)); > RtlZeroMemory(BootDriveString, sizeof(BootDriveString)); > @@ -331,7 +347,11 @@ > > UiMessageBox(CustomBootPrompt); > > - LoadAndBootLinux(SectionName, "Custom Linux Setup"); > + OperatingSystem.SystemPartition = SectionName; > + OperatingSystem.LoadIdentifier = "Custom Linux Setup"; > + OperatingSystem.OsLoadOptions = NULL; > + > + LoadAndBootLinux(&OperatingSystem, 0); > } > > VOID OptionMenuReboot(VOID) > > Modified: trunk/reactos/boot/freeldr/freeldr/arch/i386/miscboot.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/arch/… > ============================================================================== > --- trunk/reactos/boot/freeldr/freeldr/arch/i386/miscboot.c [iso-8859-1] (original) > +++ trunk/reactos/boot/freeldr/freeldr/arch/i386/miscboot.c [iso-8859-1] Thu Dec 13 00:46:55 2012 > @@ -19,21 +19,24 @@ > > #include <freeldr.h> > > -VOID LoadAndBootBootSector(PCSTR OperatingSystemName) > +VOID > +LoadAndBootBootSector(IN OperatingSystemItem* OperatingSystem, > + IN USHORT OperatingSystemVersion) > { > + ULONG_PTR SectionId; > + PCSTR SectionName = OperatingSystem->SystemPartition; > + CHAR FileName[260]; > PFILE FilePointer; > + ULONG BytesRead; > CHAR SettingName[80]; > - ULONG SectionId; > - CHAR FileName[260]; > - ULONG BytesRead; > > // Find all the message box settings and run them > - UiShowMessageBoxesInSection(OperatingSystemName); > + UiShowMessageBoxesInSection(SectionName); > > // Try to open the operating system section in the .ini file > - if (!IniOpenSection(OperatingSystemName, &SectionId)) > - { > - sprintf(SettingName, "Section [%s] not found in freeldr.ini.\n", OperatingSystemName); > + if (!IniOpenSection(SectionName, &SectionId)) > + { > + sprintf(SettingName, "Section [%s] not found in freeldr.ini.\n", SectionName); > UiMessageBox(SettingName); > return; > } > @@ -79,22 +82,25 @@ > ChainLoadBiosBootSectorCode(); > } > > -VOID LoadAndBootPartition(PCSTR OperatingSystemName) > +VOID > +LoadAndBootPartition(IN OperatingSystemItem* OperatingSystem, > + IN USHORT OperatingSystemVersion) > { > + ULONG_PTR SectionId; > + PCSTR SectionName = OperatingSystem->SystemPartition; > CHAR SettingName[80]; > CHAR SettingValue[80]; > - ULONG SectionId; > PARTITION_TABLE_ENTRY PartitionTableEntry; > UCHAR DriveNumber; > ULONG PartitionNumber; > > // Find all the message box settings and run them > - UiShowMessageBoxesInSection(OperatingSystemName); > + UiShowMessageBoxesInSection(SectionName); > > // Try to open the operating system section in the .ini file > - if (!IniOpenSection(OperatingSystemName, &SectionId)) > - { > - sprintf(SettingName, "Section [%s] not found in freeldr.ini.\n", OperatingSystemName); > + if (!IniOpenSection(SectionName, &SectionId)) > + { > + sprintf(SettingName, "Section [%s] not found in freeldr.ini.\n", SectionName); > UiMessageBox(SettingName); > return; > } > @@ -151,20 +157,23 @@ > ChainLoadBiosBootSectorCode(); > } > > -VOID LoadAndBootDrive(PCSTR OperatingSystemName) > +VOID > +LoadAndBootDrive(IN OperatingSystemItem* OperatingSystem, > + IN USHORT OperatingSystemVersion) > { > + ULONG_PTR SectionId; > + PCSTR SectionName = OperatingSystem->SystemPartition; > CHAR SettingName[80]; > CHAR SettingValue[80]; > - ULONG SectionId; > UCHAR DriveNumber; > > // Find all the message box settings and run them > - UiShowMessageBoxesInSection(OperatingSystemName); > + UiShowMessageBoxesInSection(SectionName); > > // Try to open the operating system section in the .ini file > - if (!IniOpenSection(OperatingSystemName, &SectionId)) > - { > - sprintf(SettingName, "Section [%s] not found in freeldr.ini.\n", OperatingSystemName); > + if (!IniOpenSection(SectionName, &SectionId)) > + { > + sprintf(SettingName, "Section [%s] not found in freeldr.ini.\n", SectionName); > UiMessageBox(SettingName); > return; > } > > Modified: trunk/reactos/boot/freeldr/freeldr/bootmgr.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/bootm… > ============================================================================== > --- trunk/reactos/boot/freeldr/freeldr/bootmgr.c [iso-8859-1] (original) > +++ trunk/reactos/boot/freeldr/freeldr/bootmgr.c [iso-8859-1] Thu Dec 13 00:46:55 2012 > @@ -24,7 +24,90 @@ > CHAR reactos_arc_hardware_data[HW_MAX_ARC_HEAP_SIZE] = {0}; > CHAR reactos_arc_strings[32][256]; > > -ULONG GetDefaultOperatingSystem(OperatingSystemItem* OperatingSystemList, ULONG OperatingSystemCount) > +typedef > +VOID > +(*OS_LOADING_METHOD)(IN OperatingSystemItem* OperatingSystem, > + IN USHORT OperatingSystemVersion); > + > +struct > +{ > + CHAR BootType[80]; > + USHORT OperatingSystemVersion; > + OS_LOADING_METHOD Load; > +} OSLoadingMethods[] = > +{ > +#ifdef FREELDR_REACTOS_SETUP > + {"ReactOSSetup", 0 , LoadReactOSSetup }, > +#endif > + > +#ifdef _M_IX86 > + {"BootSector" , 0 , LoadAndBootBootSector}, > + {"Drive" , 0 , LoadAndBootDrive }, > + {"Partition" , 0 , LoadAndBootPartition }, > + > + {"Linux" , 0 , LoadAndBootLinux }, > + > + {"Windows" , 0 , LoadAndBootWindows }, > + {"WindowsNT40" , _WIN32_WINNT_NT4 , LoadAndBootWindows }, > +#endif > + {"Windows2003" , _WIN32_WINNT_WS03, LoadAndBootWindows }, > + > +// {"Not found" , 0 , NULL } > +}; > + > +VOID LoadOperatingSystem(IN OperatingSystemItem* OperatingSystem) > +{ > + ULONG_PTR SectionId; > + PCSTR SectionName = OperatingSystem->SystemPartition; > + CHAR BootType[80]; > + ULONG i; > + > + // Try to open the operating system section in the .ini file > + if (IniOpenSection(SectionName, &SectionId)) > + { > + // Try to read the boot type > + IniReadSettingByName(SectionId, "BootType", BootType, sizeof(BootType)); > + } > + else > + { > + BootType[0] = ANSI_NULL; > + } > + > + if (BootType[0] == ANSI_NULL && SectionName[0] != ANSI_NULL) > + { > + // Try to infere the boot type value > +#ifdef _M_IX86 > + ULONG FileId; > + if (ArcOpen((PSTR)SectionName, OpenReadOnly, &FileId) == ESUCCESS) > + { > + ArcClose(FileId); > + strcpy(BootType, "BootSector"); > + } > + else > +#endif > + { > + strcpy(BootType, "Windows"); > + } > + } > + > + // Install the drive mapper according to this section drive mappings > +#if defined(_M_IX86) && !defined(_MSC_VER) > + DriveMapMapDrivesInSection(SectionName); > +#endif > + > + // Loop through the OS loading method table and find a suitable OS to boot > + for (i = 0; i < sizeof(OSLoadingMethods) / sizeof(OSLoadingMethods[0]); ++i) > + { > + if (_stricmp(BootType, OSLoadingMethods[i].BootType) == 0) > + { > + OSLoadingMethods[i].Load(OperatingSystem, > + OSLoadingMethods[i].OperatingSystemVersion); > + return; > + } > + } > +} > + > +ULONG GetDefaultOperatingSystem(OperatingSystemItem* OperatingSystemList, ULONG OperatingSystemCount) > { > CHAR DefaultOSText[80]; > PCSTR DefaultOSName; > @@ -105,17 +188,14 @@ > > VOID RunLoader(VOID) > { > - CHAR SettingValue[80]; > - CHAR BootType[80]; > ULONG_PTR SectionId; > ULONG OperatingSystemCount; > OperatingSystemItem* OperatingSystemList; > - PCSTR *OperatingSystemDisplayNames; > - PCSTR SectionName; > - ULONG i; > + PCSTR* OperatingSystemDisplayNames; > ULONG DefaultOperatingSystem; > LONG TimeOut; > ULONG SelectedOperatingSystem; > + ULONG i; > > // FIXME: if possible, only detect and register ARC devices... > if (!MachHwDetect()) > @@ -206,78 +286,8 @@ > > TimeOut = -1; > > - // Try to open the operating system section in the .ini file > - SettingValue[0] = ANSI_NULL; > - SectionName = OperatingSystemList[SelectedOperatingSystem].SystemPartition; > - if (IniOpenSection(SectionName, &SectionId)) > - { > - // Try to read the boot type > - IniReadSettingByName(SectionId, "BootType", BootType, sizeof(BootType)); > - } > - else > - BootType[0] = ANSI_NULL; > - > - if (BootType[0] == ANSI_NULL && SectionName[0] != ANSI_NULL) > - { > - // Try to infere boot type value > -#ifdef _M_IX86 > - ULONG FileId; > - if (ArcOpen((CHAR*)SectionName, OpenReadOnly, &FileId) == ESUCCESS) > - { > - ArcClose(FileId); > - strcpy(BootType, "BootSector"); > - } > - else > -#endif > - { > - strcpy(BootType, "Windows"); > - } > - } > - > - // Get OS setting value > - IniOpenSection("Operating Systems", &SectionId); > - IniReadSettingByName(SectionId, SectionName, SettingValue, sizeof(SettingValue)); > - > - // Install the drive mapper according to this sections drive mappings > -#if defined(_M_IX86) && !defined(_MSC_VER) > - DriveMapMapDrivesInSection(SectionName); > -#endif > - > -#ifdef FREELDR_REACTOS_SETUP > - // WinLdr-style boot > - LoadReactOSSetup(); > -#elif defined(_M_IX86) > - if (_stricmp(BootType, "Windows") == 0) > - { > - LoadAndBootWindows(SectionName, SettingValue, 0); > - } > - else if (_stricmp(BootType, "WindowsNT40") == 0) > - { > - LoadAndBootWindows(SectionName, SettingValue, _WIN32_WINNT_NT4); > - } > - else if (_stricmp(BootType, "Windows2003") == 0) > - { > - LoadAndBootWindows(SectionName, SettingValue, _WIN32_WINNT_WS03); > - } > - else if (_stricmp(BootType, "Linux") == 0) > - { > - LoadAndBootLinux(SectionName, OperatingSystemDisplayNames[SelectedOperatingSystem]); > - } > - else if (_stricmp(BootType, "BootSector") == 0) > - { > - LoadAndBootBootSector(SectionName); > - } > - else if (_stricmp(BootType, "Partition") == 0) > - { > - LoadAndBootPartition(SectionName); > - } > - else if (_stricmp(BootType, "Drive") == 0) > - { > - LoadAndBootDrive(SectionName); > - } > -#else > - LoadAndBootWindows(SectionName, SettingValue, _WIN32_WINNT_WS03); > -#endif > + // Load the chosen operating system > + LoadOperatingSystem(&OperatingSystemList[SelectedOperatingSystem]); > } > > reboot: > > Modified: trunk/reactos/boot/freeldr/freeldr/include/arch/i386/miscboot.h > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/inclu… > ============================================================================== > --- trunk/reactos/boot/freeldr/freeldr/include/arch/i386/miscboot.h [iso-8859-1] (original) > +++ trunk/reactos/boot/freeldr/freeldr/include/arch/i386/miscboot.h [iso-8859-1] Thu Dec 13 00:46:55 2012 > @@ -19,6 +19,12 @@ > > #pragma once > > -VOID LoadAndBootBootSector(PCSTR OperatingSystemName); > -VOID LoadAndBootPartition(PCSTR OperatingSystemName); > -VOID LoadAndBootDrive(PCSTR OperatingSystemName); > +VOID > +LoadAndBootBootSector(IN OperatingSystemItem* OperatingSystem, > + IN USHORT OperatingSystemVersion); > +VOID > +LoadAndBootPartition(IN OperatingSystemItem* OperatingSystem, > + IN USHORT OperatingSystemVersion); > +VOID > +LoadAndBootDrive(IN OperatingSystemItem* OperatingSystem, > + IN USHORT OperatingSystemVersion); > > Modified: trunk/reactos/boot/freeldr/freeldr/include/linux.h > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/inclu… > ============================================================================== > --- trunk/reactos/boot/freeldr/freeldr/include/linux.h [iso-8859-1] (original) > +++ trunk/reactos/boot/freeldr/freeldr/include/linux.h [iso-8859-1] Thu Dec 13 00:46:55 2012 > @@ -18,6 +18,7 @@ > */ > > #include <fs.h> > +#include <oslist.h> > > #ifndef __LINUX_H > #define __LINUX_H > @@ -129,7 +130,9 @@ > VOID BootNewLinuxKernel(VOID); // Implemented in linux.S > VOID BootOldLinuxKernel(ULONG KernelSize); // Implemented in linux.S > > -VOID LoadAndBootLinux(PCSTR OperatingSystemName, PCSTR Description); > +VOID > +LoadAndBootLinux(IN OperatingSystemItem* OperatingSystem, > + IN USHORT OperatingSystemVersion); > > BOOLEAN LinuxParseIniSection(PCSTR OperatingSystemName); > BOOLEAN LinuxReadBootSector(PFILE LinuxKernelFile); > > Modified: trunk/reactos/boot/freeldr/freeldr/include/winldr.h > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/inclu… > ============================================================================== > --- trunk/reactos/boot/freeldr/freeldr/include/winldr.h [iso-8859-1] (original) > +++ trunk/reactos/boot/freeldr/freeldr/include/winldr.h [iso-8859-1] Thu Dec 13 00:46:55 2012 > @@ -80,9 +80,8 @@ > // ReactOS Loading Functions > // > /////////////////////////////////////////////////////////////////////////////////////// > -VOID LoadAndBootWindows(PCSTR OperatingSystemName, > - PSTR SettingsValue, > - USHORT OperatingSystemVersion); > +VOID LoadAndBootWindows(IN OperatingSystemItem* OperatingSystem, > + IN USHORT OperatingSystemVersion); > > // conversion.c > PVOID VaToPa(PVOID Va); > @@ -179,7 +178,9 @@ > LPCSTR BootPath, > BOOLEAN Setup); > > -VOID LoadReactOSSetup(VOID); > +VOID > +LoadReactOSSetup(IN OperatingSystemItem* OperatingSystem, > + IN USHORT OperatingSystemVersion); > > VOID > WinLdrSetupMachineDependent(PLOADER_PARAMETER_BLOCK LoaderBlock); > > Modified: trunk/reactos/boot/freeldr/freeldr/linuxboot.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/linux… > ============================================================================== > --- trunk/reactos/boot/freeldr/freeldr/linuxboot.c [iso-8859-1] (original) > +++ trunk/reactos/boot/freeldr/freeldr/linuxboot.c [iso-8859-1] Thu Dec 13 00:46:55 2012 > @@ -72,8 +72,12 @@ > return TRUE; > } > > -VOID LoadAndBootLinux(PCSTR OperatingSystemName, PCSTR Description) > -{ > +VOID > +LoadAndBootLinux(IN OperatingSystemItem* OperatingSystem, > + IN USHORT OperatingSystemVersion) > +{ > + PCSTR SectionName = OperatingSystem->SystemPartition; > + PCSTR Description = OperatingSystem->LoadIdentifier; > PFILE LinuxKernel = 0; > PFILE LinuxInitrdFile = 0; > CHAR TempString[260]; > @@ -93,7 +97,7 @@ > UiDrawProgressBarCenter(0, 100, LinuxBootDescription); > > // Parse the .ini file section > - if (!LinuxParseIniSection(OperatingSystemName)) > + if (!LinuxParseIniSection(SectionName)) > { > goto LinuxBootFailed; > } > @@ -235,18 +239,18 @@ > LinuxCommandLineSize = 0; > } > > -BOOLEAN LinuxParseIniSection(PCSTR OperatingSystemName) > -{ > - CHAR SettingName[260]; > - ULONG SectionId; > +BOOLEAN LinuxParseIniSection(PCSTR SectionName) > +{ > + ULONG_PTR SectionId; > + CHAR SettingName[260]; > > // Find all the message box settings and run them > - UiShowMessageBoxesInSection(OperatingSystemName); > + UiShowMessageBoxesInSection(SectionName); > > // Try to open the operating system section in the .ini file > - if (!IniOpenSection(OperatingSystemName, &SectionId)) > - { > - sprintf(SettingName, "Section [%s] not found in freeldr.ini.\n", OperatingSystemName); > + if (!IniOpenSection(SectionName, &SectionId)) > + { > + sprintf(SettingName, "Section [%s] not found in freeldr.ini.\n", SectionName); > UiMessageBox(SettingName); > return FALSE; > } > > Modified: trunk/reactos/boot/freeldr/freeldr/windows/setupldr.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/windo… > ============================================================================== > --- trunk/reactos/boot/freeldr/freeldr/windows/setupldr.c [iso-8859-1] (original) > +++ trunk/reactos/boot/freeldr/freeldr/windows/setupldr.c [iso-8859-1] Thu Dec 13 00:46:55 2012 > @@ -133,7 +133,9 @@ > } while (InfFindNextLine(&InfContext, &InfContext)); > } > > -VOID LoadReactOSSetup(VOID) > +VOID > +LoadReactOSSetup(IN OperatingSystemItem* OperatingSystem, > + IN USHORT OperatingSystemVersion) > { > CHAR FileName[512]; > CHAR BootPath[512]; > > Modified: trunk/reactos/boot/freeldr/freeldr/windows/winldr.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/windo… > ============================================================================== > --- trunk/reactos/boot/freeldr/freeldr/windows/winldr.c [iso-8859-1] (original) > +++ trunk/reactos/boot/freeldr/freeldr/windows/winldr.c [iso-8859-1] Thu Dec 13 00:46:55 2012 > @@ -456,22 +456,28 @@ > } > > VOID > -LoadAndBootWindows(PCSTR OperatingSystemName, > - PSTR SettingsValue, > - USHORT OperatingSystemVersion) > -{ > +LoadAndBootWindows(IN OperatingSystemItem* OperatingSystem, > + IN USHORT OperatingSystemVersion) > +{ > + ULONG_PTR SectionId; > + PCSTR SectionName = OperatingSystem->SystemPartition; > + CHAR SettingsValue[80]; > BOOLEAN HasSection; > - char BootPath[MAX_PATH]; > + CHAR BootPath[MAX_PATH]; > CHAR FileName[MAX_PATH]; > CHAR BootOptions[256]; > PCHAR File; > BOOLEAN Status; > - ULONG_PTR SectionId; > PLOADER_PARAMETER_BLOCK LoaderBlock; > + > + // Get OS setting value > + SettingsValue[0] = ANSI_NULL; > + IniOpenSection("Operating Systems", &SectionId); > + IniReadSettingByName(SectionId, SectionName, SettingsValue, sizeof(SettingsValue)); > > // Open the operating system section > // specified in the .ini file > - HasSection = IniOpenSection(OperatingSystemName, &SectionId); > + HasSection = IniOpenSection(SectionName, &SectionId); > > UiDrawBackdrop(); > UiDrawProgressBarCenter(1, 100, "Loading NT..."); > @@ -480,7 +486,7 @@ > if (!HasSection || > !IniReadSettingByName(SectionId, "SystemPath", BootPath, sizeof(BootPath))) > { > - strcpy(BootPath, OperatingSystemName); > + strcpy(BootPath, SectionName); > } > > /* Special case for LiveCD */ > @@ -499,7 +505,7 @@ > if (!HasSection || !IniReadSettingByName(SectionId, "Options", BootOptions, sizeof(BootOptions))) > { > /* Get options after the title */ > - const CHAR*p = SettingsValue; > + PCSTR p = SettingsValue; > while (*p == ' ' || *p == '"') > p++; > while (*p != '\0' && *p != '"') > >

12 years, 9 months

1
0
0 0

Re: [ros-dev] [ros-diffs] [pschweitzer] 57792: [NTOSKRNL] ExFreePool -> ExFreePoolWithTag

by Aleksey Bragin

On 04.12.2012 2:15, pschweitzer(a)svn.reactos.org wrote: > - ExFreePool(SharedRange); > + ExFreePoolWithTag(SharedRange, 'FSRA'); > /* We need to rebuild the list of shared ranges. */ > DPRINT("Removing the lock entry %wZ (%08x%08x:%08x%08x)\n", > &FileObject->FileName, > @@ -1287,7 +1287,7 @@ > SharedRange = CONTAINING_RECORD(SharedEntry, LOCK_SHARED_RANGE, Entry); > SharedEntry = SharedEntry->Flink; > RemoveEntryList(SharedEntry); > - ExFreePool(SharedRange); > + ExFreePoolWithTag(SharedRange, 'FSRA'); > } > while ((Entry = RtlGetElementGenericTable(&InternalInfo->RangeTable, 0)) != NULL) > { > > It would be a good idea to add this to TAG_ list of defines.

12 years, 9 months

1
0
0 0

24pullrequests.com

by Александр

12 years, 9 months

3
2
0 0

Re: [ros-dev] [ros-diffs] [hbelusca] 57780: [CPORTLIB/FREELDR] GetByte --> Wait for data (with timeout) and get it if available. PollByte --> Check for data, get it if available, and return immediately.

by Timo Kreuzer

You are aware that this changes the behavior? Polling previously only checked, if data is available, but didn't read it from the port. But afaics it's only relvenat for WinLdrPortPollOnly, which seems to be unused anyway. Am 29.11.2012 00:16, schrieb hbelusca(a)svn.reactos.org: > Author: hbelusca > Date: Wed Nov 28 23:16:01 2012 > New Revision: 57780 > > URL: http://svn.reactos.org/svn/reactos?rev=57780&view=rev > Log: > [CPORTLIB/FREELDR] > GetByte --> Wait for data (with timeout) and get it if available. > PollByte --> Check for data, get it if available, and return immediately. > > Modified: > trunk/reactos/boot/freeldr/freeldr/comm/rs232.c > trunk/reactos/boot/freeldr/freeldr/windows/headless.c > trunk/reactos/include/reactos/libs/cportlib/cportlib.h > trunk/reactos/lib/cportlib/cport.c > > Modified: trunk/reactos/boot/freeldr/freeldr/comm/rs232.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/comm/… > ============================================================================== > --- trunk/reactos/boot/freeldr/freeldr/comm/rs232.c [iso-8859-1] (original) > +++ trunk/reactos/boot/freeldr/freeldr/comm/rs232.c [iso-8859-1] Wed Nov 28 23:16:01 2012 > @@ -100,7 +100,7 @@ > if (PortInitialized == FALSE) > return FALSE; > > - return (CpGetByte(&Rs232ComPort, ByteReceived, FALSE, FALSE) == CP_GET_SUCCESS); > + return (CpGetByte(&Rs232ComPort, ByteReceived, TRUE) == CP_GET_SUCCESS); > } > > /* > @@ -109,12 +109,7 @@ > if (PortInitialized == FALSE) > return FALSE; > > - while ((READ_PORT_UCHAR (SER_LSR(Rs232PortBase)) & SR_LSR_DR) == 0) > - ; > - > - *ByteReceived = READ_PORT_UCHAR (SER_RBR(Rs232PortBase)); > - > - return TRUE; > + return (CpGetByte(&Rs232ComPort, ByteReceived, FALSE) == CP_GET_SUCCESS); > } > */ > > > Modified: trunk/reactos/boot/freeldr/freeldr/windows/headless.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/windo… > ============================================================================== > --- trunk/reactos/boot/freeldr/freeldr/windows/headless.c [iso-8859-1] (original) > +++ trunk/reactos/boot/freeldr/freeldr/windows/headless.c [iso-8859-1] Wed Nov 28 23:16:01 2012 > @@ -143,7 +143,7 @@ > WinLdrPortGetByte(IN ULONG PortId, > OUT PUCHAR Data) > { > - return CpGetByte(&Port[PortId], Data, TRUE, FALSE) == CP_GET_SUCCESS; > + return CpGetByte(&Port[PortId], Data, TRUE) == CP_GET_SUCCESS; > } > > BOOLEAN > @@ -151,7 +151,7 @@ > { > UCHAR Dummy; > > - return CpGetByte(&Port[PortId], &Dummy, FALSE, TRUE) == CP_GET_SUCCESS; > + return CpGetByte(&Port[PortId], &Dummy, FALSE) == CP_GET_SUCCESS; > } > > VOID > > Modified: trunk/reactos/include/reactos/libs/cportlib/cportlib.h > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/reactos/libs/cport… > ============================================================================== > --- trunk/reactos/include/reactos/libs/cportlib/cportlib.h [iso-8859-1] (original) > +++ trunk/reactos/include/reactos/libs/cportlib/cportlib.h [iso-8859-1] Wed Nov 28 23:16:01 2012 > @@ -69,8 +69,7 @@ > CpGetByte( > IN PCPPORT Port, > OUT PUCHAR Byte, > - IN BOOLEAN Wait, > - IN BOOLEAN Poll > + IN BOOLEAN Wait > ); > > VOID > > Modified: trunk/reactos/lib/cportlib/cport.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/cportlib/cport.c?rev=5… > ============================================================================== > --- trunk/reactos/lib/cportlib/cport.c [iso-8859-1] (original) > +++ trunk/reactos/lib/cportlib/cport.c [iso-8859-1] Wed Nov 28 23:16:01 2012 > @@ -255,8 +255,7 @@ > NTAPI > CpGetByte(IN PCPPORT Port, > OUT PUCHAR Byte, > - IN BOOLEAN Wait, > - IN BOOLEAN Poll) > + IN BOOLEAN Wait) > { > UCHAR Lsr; > ULONG LimitCount = Wait ? TIMEOUT_COUNT : 1; > @@ -278,9 +277,6 @@ > return CP_GET_ERROR; > } > > - /* If only polling was requested by caller, return now */ > - if (Poll) return CP_GET_SUCCESS; > - > /* Otherwise read the byte and return it */ > *Byte = READ_PORT_UCHAR(Port->Address + RECEIVE_BUFFER_REGISTER); > > > >

12 years, 9 months

2
1
0 0

November Status Meeting Tomorrow

by Aleksey Bragin

Hello, Let me invite you to the monthly status meeting taking place last Thursday of this month, 29th of November, 19:00 UTC. The meeting will be at irc://dev.reactos.org (Port 6667, no SSL) in the channel #meeting, or as Pierre/Colin say. Note that the IRC service will only be started shortly before the meeting. Your participation passwords will be emailed to you shortly before the meeting starts, and they are going to be different once again as they are not stored in any database. Hopefully it's not much of inconvenience. If someone still is not getting passwords sent before a meeting - please email Colin or Pierre before the meeting started to get one. The agenda will be posted shortly before the meeting, suggestions are welcome (send them to my email as usual). Hot topics would include progress made during this month, contracts updates, release plans (if any), web site progress (if any). With the best regards, Aleksey Bragin

12 years, 9 months

4
4
0 0

Re: [ros-dev] [ros-general] Services downtime

by Colin Finck

Hi all, Pierre Schweitzer <pierre(a)reactos.org> wrote: > due to a hardware migration ongoing on one of our hypervisors, the > following services are currently down: The server upgrade went successfully and everything is back to normal now. Cheers, Colin

12 years, 10 months

1
0
0 0

Server upgrade next Friday

by Colin Finck

Hi all, Several ReactOS services will be moved to a new server next Friday. As this migration highly depends on our hosting provider, the downtime may be up to 24 hours. Affected services include: - ns1.reactos.org - playground.reactos.org - jira.reactos.org The upgrade will improve reliability and adds resources for additional services in the future. Of course, you will be informed once the migration is over. Cheers, Colin

12 years, 10 months

2
3
0 0

Re: [ros-dev] [ros-diffs] [hbelusca] 57701: [CSRSRV] - Use a variable ServerDll instead of using each time CsrLoadedServerDll[i], as it is done in some other places. - Clean the code (remove extra-parentheses). - Zero-out t...

by Alex Ionescu

Would you mind not "cleaning up formatting" by going against our coding style and doing the very thing I even taught you not to do during your initial patches/code reviews? Thanks. Best regards, Alex Ionescu On Tue, Nov 13, 2012 at 1:08 PM, <hbelusca(a)svn.reactos.org> wrote: > - if ((ServerDll) && (ServerDll->HardErrorCallback)) > + if (ServerDll && ServerDll->HardErrorCallback) >

12 years, 10 months

4
5
0 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev