- Ros-dev - ReactOS.org

Re: [ros-dev] [ros-diffs] [akhaldi] 56731: [CMAKE/MIDL] * Alter the way we handle the dlldata generation with midl. This works around the warnings we get about multiple rules to generate proxy.dlldata.c. * Brought to yo by ...
by Timo Kreuzer 16 Jun '12

16 Jun '12

Did you test dependency checking? Am 14.06.2012 13:06, schrieb akhaldi(a)svn.reactos.org: > Author: akhaldi > Date: Thu Jun 14 11:06:23 2012 > New Revision: 56731 > > URL:http://svn.reactos.org/svn/reactos?rev=56731&view=rev > Log: > [CMAKE/MIDL] > * Alter the way we handle the dlldata generation with midl. This works around the warnings we get about multiple rules to generate proxy.dlldata.c. > * Brought to yo by Peter Kummel. > > Modified: > trunk/reactos/cmake/midl-support.cmake > > Modified: trunk/reactos/cmake/midl-support.cmake > URL:http://svn.reactos.org/svn/reactos/trunk/reactos/cmake/midl-support.cma… > ============================================================================== > --- trunk/reactos/cmake/midl-support.cmake [iso-8859-1] (original) > +++ trunk/reactos/cmake/midl-support.cmake [iso-8859-1] Thu Jun 14 11:06:23 2012 > @@ -38,16 +38,17 @@ > get_includes(_includes) > get_defines(_defines) > set(_chain_dependency "") > + set_source_files_properties(${CMAKE_CURRENT_BINARY_DIR}/proxy.dlldata.c PROPERTIES GENERATED TRUE) > foreach(_idl_file ${ARGN}) > get_filename_component(_name_we ${_idl_file} NAME_WE) > add_custom_command( > - OUTPUT ${_name_we}_p.c ${_name_we}_p.h proxy.dlldata.c > + OUTPUT ${_name_we}_p.c ${_name_we}_p.h > COMMAND midl ${_includes} ${_defines} ${IDL_FLAGS} /client none /server none /proxy ${_name_we}_p.c /h ${_name_we}_p.h /dlldata proxy.dlldata.c ${CMAKE_CURRENT_SOURCE_DIR}/${_idl_file} > DEPENDS ${CMAKE_CURRENT_SOURCE_DIR}/${_idl_file} ${_chain_dependency}) > list(APPEND _chain_dependency ${CMAKE_CURRENT_BINARY_DIR}/${_name_we}_p.c) > list(APPEND _chain_dependency ${CMAKE_CURRENT_BINARY_DIR}/${_name_we}_p.h) > + set_source_files_properties(${CMAKE_CURRENT_BINARY_DIR}/proxy.dlldata.c PROPERTIES OBJECT_DEPENDS ${CMAKE_CURRENT_SOURCE_DIR}/${_idl_file}) > endforeach() > - set_source_files_properties(${CMAKE_CURRENT_BINARY_DIR}/proxy.dlldata.c PROPERTIES GENERATED TRUE) > endfunction() > > function(add_rpc_files _type) > > >

1 0

Re: [ros-dev] buildbot exception in ReactOS on Windows_AMD64_1 VBox-Test
by caemyr＠myopera.com 07 Jun '12

07 Jun '12

Looks like the crash had locked up the VM hard: loader.c:1019: Test failed: wrong section data (..\..\dll\ntdll\ldr\ldrutils.c:1322) LDR: LdrpMapDll Relocating Image Name C:\DOCUME~1\ADMINI~1\LOCALS~1\Temp\ldr3C.tmp (10000000 -> 00011000) (..\..\dll\ntdll\ldr\ldrutils.c:1361) Overlapping DLL: Dynamically Allocated Memory loader.c:599: Test failed: got 0x4 != expected 0x1 loader.c:601: Test failed: 0x4 != PAGE_EXECUTE_WRITECOPY loader.c:627: Test failed: got 0x4 != expected 0x1 loader.c:629: Test failed: 0x4 != PAGE_EXECUTE_WRITECOPY loader.c:645: Test failed: got 0x4 != expected 0x1 loader.c:647: Test failed: 0x4 != PAGE_EXECUTE_WRITECOPY (..\..\ntoskrnl\mm\ARM3\expool.c:274) Entry BlockSize 2, tag fPsR. NextEntry PreviousSize 0, tag *** Fatal System Error: 0x00000019 (0x00000005,0xB0A0EB18,0x00000116,0xB0A0EB08) [7hEntered debugger on embedded INT3 at 0x0008:0x8091ba34. kdb:> bt Eip: <NTOSKRNL.EXE:11ba35 (..\..\lib\rtl\i386\debug_asm.S:46 (_RtlpBreakWithStatusInstruction@0))> Frames: <NTOSKRNL.EXE:80445 (../../ntoskrnl/ke/bug.c:1081 (KeBugCheckWithTf@24))> <NTOSKRNL.EXE:80581 (../../ntoskrnl/ke/bug.c:1405 (KeBugCheckEx@20))> <NTOSKRNL.EXE:964e2 (../../ntoskrnl/mm/ARM3/expool.c:211 (ExpCheckPoolHeader@4))> <NTOSKRNL.EXE:966d3 (../../ntoskrnl/mm/ARM3/expool.c:303 (ExpCheckPoolBlocks@4))> <NTOSKRNL.EXE:96fa5 (../../ntoskrnl/mm/ARM3/expool.c:2215 (ExFreePoolWithTag@8))> <NTOSKRNL.EXE:9755a (../../ntoskrnl/mm/ARM3/expool.c:2359 (ExFreePool@4))> <NTOSKRNL.EXE:bf8da (../../ntoskrnl/mm/freelist.c:556 (MmDereferencePage@4))> <NTOSKRNL.EXE:bf541 (../../ntoskrnl/mm/balance.c:130 (MmReleasePageMemoryConsumer@8))> <NTOSKRNL.EXE:473b (../../ntoskrnl/cc/view.c:913 (CcFreeCachePage))> <NTOSKRNL.EXE:c1501 (../../ntoskrnl/mm/marea.c:745 (MmFreeMemoryArea@16))> <NTOSKRNL.EXE:413c (../../ntoskrnl/cc/view.c:962 (CcRosInternalFreeCacheSegment))> <NTOSKRNL.EXE:6f3d (../../ntoskrnl/cc/view.c:1145 (CcRosDeleteFileCache@8))> <NTOSKRNL.EXE:755f (../../ntoskrnl/cc/view.c:1210 (CcRosDereferenceCache@4))> <NTOSKRNL.EXE:cb47c (../../ntoskrnl/mm/section.c:2672 (MmpDeleteSection@4))> <NTOSKRNL.EXE:da087 (../../ntoskrnl/ob/oblife.c:211 (ObpDeleteObject@8))> <NTOSKRNL.EXE:da11b (../../ntoskrnl/ob/oblife.c:238 (ObpReapObject@4))> <NTOSKRNL.EXE:41e42 (../../ntoskrnl/ex/work.c:162 (ExpWorkerThreadEntryPoint@4))> <NTOSKRNL.EXE:f2ca9 (../../ntoskrnl/ps/thread.c:156 (PspSystemThreadStartup@8))> <NTOSKRNL.EXE:103c27 (../../ntoskrnl/ke/i386/thrdini.c:78 (KiThreadStartup@0))> <NTOSKRNL.EXE:f2c4f (../../ntoskrnl/ps/thread.c:625 (PsCreateSystemThread@28))>--- Press q to abort, any other key to continue --- <f88b3db8> <NTOSKRNL.EXE:85cc0 (../../ntoskrnl/ke/queue.c:401 (KeRemoveQueue@12))> <NTOSKRNL.EXE:41df0 (../../ntoskrnl/ex/work.c:145 (ExpWorkerThreadEntryPoint@4))> <NTOSKRNL.EXE:f2ca9 (../../ntoskrnl/ps/thread.c:156 (PspSystemThreadStartup@8))> <NTOSKRNL.EXE:103c27 (../../ntoskrnl/ke/i386/thrdini.c:78 (KiThreadStartup@0))> <NTOSKRNL.EXE:f2c4f (../../ntoskrnl/ps/thread.c:625 (PsCreateSystemThread@28))> <f88b7db8> <NTOSKRNL.EXE:85cc0 (../../ntoskrnl/ke/queue.c:401 (KeRemoveQueue@12))> <NTOSKRNL.EXE:41df0 (../../ntoskrnl/ex/work.c:145 (ExpWorkerThreadEntryPoint@4))> <NTOSKRNL.EXE:f2ca9 (../../ntoskrnl/ps/thread.c:156 (PspSystemThreadStartup@8))> <NTOSKRNL.EXE:103c27 (../../ntoskrnl/ke/i386/thrdini.c:78 (KiThreadStartup@0))> <NTOSKRNL.EXE:f2c4f (../../ntoskrnl/ps/thread.c:625 (PsCreateSystemThread@28))> <f88bbdb8> <NTOSKRNL.EXE:85cc0 (../../ntoskrnl/ke/queue.c:401 (KeRemoveQueue@12))> <NTOSKRNL.EXE:41df0 (../../ntoskrnl/ex/work.c:145 (ExpWorkerThreadEntryPoint@4))> <NTOSKRNL.EXE:f2ca9 (../../ntoskrnl/ps/thread.c:156 (PspSystemThreadStartup@8))> <NTOSKRNL.EXE:103c27 (../../ntoskrnl/ke/i386/thrdini.c:78 (KiThreadStartup@0))> <NTOSKRNL.EXE:f2c4f (../../ntoskrnl/ps/thread.c:625 (PsCreateSystemThread@28))> <f889bdb8> <NTOSKRNL.EXE:85cc0 (../../ntoskrnl/ke/queue.c:401 (KeRemoveQueue@12))> <NTOSKRNL.EXE:41df0 (../../ntoskrnl/ex/work.c:145 (ExpWorkerThreadEntryPoint@4))>--- Press q to abort, any other key to continue --- <NTOSKRNL.EXE:f2ca9 (../../ntoskrnl/ps/thread.c:156 (PspSystemThreadStartup@8))> <NTOSKRNL.EXE:103c27 (../../ntoskrnl/ke/i386/thrdini.c:78 (KiThreadStartup@0))> <NTOSKRNL.EXE:f2c4f (../../ntoskrnl/ps/thread.c:625 (PsCreateSystemThread@28))> <415c6d6d> Couldn't access memory at 0x5C6C6E76! kdb:> On Thu, Jun 7, 2012, at 06:23 PM, buildbot(a)reactos.org wrote: > The Buildbot has finished a build on builder Windows_AMD64_1 VBox-Test > while building ReactOS. > Full details are available at: > http://build.reactos.org/builders/Windows_AMD64_1%20VBox-Test/builds/5866 > > Buildbot URL: http://build.reactos.org/ > > Buildslave for this Build: Windows_AMD64_2 > > Build Reason: Triggerable(Windows_AMD64_1 VBox-Test Trigger) > Build Source Stamp: 56702 > Blamelist: ekohl > > BUILD FAILED: exception test > > sincerely, > -The Buildbot > -- With best regards Caemyr

1 0

Debug log problems
by Aleksey Bragin 07 Jun '12

07 Jun '12

Hello, it's time for my periodical rant about debug log mess again. The example below is made using latest VirtualBox 3. Suggestions and questions: 1. usbohci - it's left on intentionally to better aid debugging? Allright, however I think these lines (/srv/buildbot_cmake/full_cmake/build/drivers/usb/usbohci/hardware.cpp:1199) Waiting 0 milliseconds for port power up (/srv/buildbot_cmake/full_cmake/build/drivers/usb/usbohci/hardware.cpp:1145) Enabling status change repeated 8 times is a little bit too much. Same about libusb listing statuses of all ports. Which goes on yet another time with EHCI controller. 2. What are these lines? Repeated 14 times (/srv/buildbot_cmake/full_cmake/build/ntoskrnl/mm/ARM3/sysldr.c:2959) ZwOpenFile failed with status 0xc000003a 3. What happened to the floppy driver? (/srv/buildbot_cmake/full_cmake/build/ntoskrnl/io/iomgr/driver.c:1579) '\Driver\FLOPPY' initialization failed, status (0xc000000e) (/srv/buildbot_cmake/full_cmake/build/ntoskrnl/io/iomgr/driver.c:61) Deleting driver object '\Driver\FLOPPY' (/srv/buildbot_cmake/full_cmake/build/ntoskrnl/io/iomgr/driver.c:87) HACK: Not unloading the driver image due to critical bugs! (/srv/buildbot_cmake/full_cmake/build/ntoskrnl/io/iomgr/driver.c:1961) IopInitializeDriver() failed (Status c000000e) (/srv/buildbot_cmake/full_cmake/build/ntoskrnl/mm/ARM3/sysldr.c:935) Leaking driver: floppy.sys Fix it? Don't enable it in trunk builds if it's buggy and not fixed? 4. These lines repeated 20 times. (/srv/buildbot_cmake/full_cmake/build/dll/ntdll/ldr/ldrapi.c:811) NtCreateSection() failed (Status 0xc0000022). Why creating section in LdrpVerifyImageMatchesChecksum() failes now? 5. Win32 stage. (/srv/buildbot_cmake/full_cmake/build/win32ss/user/ntuser/winsta.c:208) err: Invalid window station handle (/srv/buildbot_cmake/full_cmake/build/win32ss/user/ntuser/ntuser.c:161) err: Enter NtUserInitialize(0, 00000000, 00000000) (/srv/buildbot_cmake/full_cmake/build/win32ss/user/ntuser/display.c:79) err: InitDisplayDriver (\Device\Video0, \Registry\Machine\System\CurrentControlSet\Hardware Profiles\Current\System\CurrentControlSet\Services\VBE\Device0); What happens here? It's a normal bootup, everyone should see this. Why is invalid window station handle being passed, why do we need NtUserInitialize to produce ERR debug print, along with InitDisplayDriver. Are those errors? If not, then why the hell are they being printed? If yes, then I don't see any info about actual errors. 6. (/srv/buildbot_cmake/full_cmake/build/win32ss/user/ntuser/window.c:2416) err: DestroyWindow AOW AOW? ORLY? 7. MASSIVE portcls spam. I won't even count lines. (/srv/buildbot_cmake/full_cmake/build/drivers/wdm/audio/backpln/portcls/undoc.cpp:281) Calling Node 16 MajorTarget B01EF750 MinorTarget 00000000 PropertySet {45ffaaa0-6e1b-11d0-bcf2-444553540000} PropertyId 4 PropertyFlags 10000200 InstanceSize 0 ValueSize 40 Handler FB24E58A PropertyRequest FF55B5F8 PropertyItemFlags 203 PropertyItemId 4 A few pages of that stuff. Is it really useful for everyone, including automated testing systems? 8. A work queue deadlock. Not a good thing at all (/srv/buildbot_cmake/full_cmake/build/ntoskrnl/ex/work.c:351) EX: Work Queue Deadlock detected: 1 (/srv/buildbot_cmake/full_cmake/build/ntoskrnl/ex/work.c:353) Dynamic threads queued 2 9. ??? All that resulted from my desire to just compare logs attached to the bug report. New log is totally unreadable, I had to spend time figuring out where actually that Live Essentials app was started, what problems it shows, etc. Best regards, Aleksey.

8 11

ReactOS fundraising campaign
by Javier Agustìn Fernàndez Arroyo 06 Jun '12

06 Jun '12

Hello, I can see donations have slowed down too much.... so, reaching 30,000 € goal seems ... quite impossible at the short-term... So, i wanted to ask... what about hiring devs for months? i know its a short period of time, but i feel ReactOS needs it ( and them, also, speaking about devs) asap :)

4 5

Re: [ros-dev] [ros-builds] Trunk_x86_GCCLin Debug: build failed
by Pierre Schweitzer 04 Jun '12

04 Jun '12

Hi, it appears that one of our servers has decided to definitely give up today. A temporary solution has been deployed to ensure ISOs are still stored properly. But, as a side effect, for the moment: - doxygen is not reachable any longer; - cppcheck run is not reachable any longer; - ISOs are not reachable any longer. We're working to get this back as quick as possible. Sorry for the inconvenience. With my best regards, Le samedi 02 juin 2012 à 04:04 +0000, buildbot(a)reactos.org a écrit : > The Buildbot has detected a failed build on builder Trunk_x86_GCCLin Debug while building ReactOS. > Full details are available at: > http://build.reactos.org/builders/Trunk_x86_GCCLin%20Debug/builds/876 > > Buildbot URL: http://build.reactos.org/ > > Buildslave for this Build: Linux_AMD64_1 > > Build Reason: scheduler > Build Source Stamp: 56689 > Blamelist: jimtabor > > BUILD FAILED: failed shell > > sincerely, > -The Buildbot > > -- Pierre Schweitzer <pierre(a)reactos.org> Systems Administrator ReactOS Foundation

1 2

Monthly meeting - May 2012
by Aleksey Bragin 31 May '12

31 May '12

Hello, Let me invite you to the monthly status meeting taking place last Thursday of this month, 31st of May, 19:00 UTC. The meeting will be at irc://fezile.reactos.org (Port 6667, no SSL) in the channel #meeting. Note that the IRC service will only be started shortly before the meeting. Your participation passwords will be emailed to you shortly before the meeting starts. If someone still is not getting passwords sent before a meeting - please email Colin or Pierre before the meeting started to get one. In order to save time, let's choose who is going to be the minute taker on the upcoming meeting. As usual, volunteers are welcome. An agenda for the meeting is being worked on now and will be posted later. Please email me your suggestions before the meeting so that the resulting agenda could be compiled beforehand. With the best regards, Aleksey Bragin.

6 9

saeid hoveizi
by saeid 25 May '12

25 May '12

hi. I'm a software engineering student last semester. My final project is translation of an open source o/s to Persian( farsi ). i see reactos and download its source code and Introduce the project to svn buti cant build it. please help me or send some useful tutorials.

1 0

[ros-diffs] [jimtabor] 56655: - Add RegisterClassNameW to ComCtl32.
by James Tabor 24 May '12

24 May '12

Forgot to add this to the next line, patch is based on Nikolay Sivov patch, http://www.winehq.org/pipermail/wine-patches/2009-December/082963.html .

1 0

Re: [ros-dev] [ros-builds] Trunk_x86_GCCLin Debug: build failed
by Pierre Schweitzer 23 May '12

23 May '12

This was due to a short outage on our side. Problem fixed and build re-queued. Sorry for the inconvenience. Le mercredi 23 mai 2012 à 20:25 +0000, buildbot(a)reactos.org a écrit : > The Buildbot has detected a failed build on builder Trunk_x86_GCCLin Debug while building ReactOS. > Full details are available at: > http://build.reactos.org/builders/Trunk_x86_GCCLin%20Debug/builds/838 > > Buildbot URL: http://build.reactos.org/ > > Buildslave for this Build: Linux_AMD64_1 > > Build Reason: scheduler > Build Source Stamp: 56652 > Blamelist: jimtabor > > BUILD FAILED: failed shell > > sincerely, > -The Buildbot > > -- Pierre Schweitzer <pierre(a)reactos.org> Systems Administrator ReactOS Foundation

1 0

Core developer
by none ofyourbussines 16 May '12

16 May '12

What does it take to be a core developer? Oh and MS-DOS® support can be very good and windows has ms-dos® support too!

9 23

Re: [ros-dev] [ros-builds] Trunk_x86_GCCLin Release: build failed
by Pierre Schweitzer 15 May '12

15 May '12

Hi, we are currently experiencing a downtime on our storage network. We are actively working to get this back as soon as possible. As a side effect, SVN is currently in read-only to prevent any further build to be lost. We are sorry for the inconvenience. With my best regards, On Tue, 2012-05-15 at 12:51 +0000, buildbot(a)reactos.org wrote: > The Buildbot has detected a failed build on builder Trunk_x86_GCCLin Release while building ReactOS. > Full details are available at: > http://build.reactos.org/builders/Trunk_x86_GCCLin%20Release/builds/73 > > Buildbot URL: http://build.reactos.org/ > > Buildslave for this Build: Linux_AMD64_1B > > Build Reason: The Periodic scheduler named 'release' triggered this build > Build Source Stamp: HEAD > Blamelist: > > BUILD FAILED: failed shell > > sincerely, > -The Buildbot > > -- Pierre Schweitzer <pierre(a)reactos.org> System Administrator ReactOS Foundation

1 1

Disappeared thread in forum
by Sven Barth 10 May '12

10 May '12

Hello together! Is it just me or did the complete thread "Feedback 0.3.14" (or so) on the forum by another Sven (I don't remember his full username) disappear from yesterday to today? Even in the "my posts" view my two posts that I have done in that thread aren't listed. Also it seems that the youngest "no working reinstall driver button" thread by naums disappeared as well. They don't appear to have been moved (there is no reference to a moved thread), but they are simply gone. Is this a known problem? Were they somehow hidden? Regards, Sven

3 2

Msdos support
by none ofyourbussines 08 May '12

08 May '12

Dos code skeleton: Dos equ 21h Ret Dos: ;code

1 0

[ros-diffs] [tkreuzer] 56478: [WIN32K] A pointer is not a handle.
by James Tabor 03 May '12

03 May '12

This is wrong, please read co_IntGetPeekMessage,,, @@ -1727,8 +1727,8 @@ 3: handle to the window whose messages are to be retrieved. */ if ( ( !Window || // 1 - ( Window == HWND_BOTTOM && CurrentMessage->Msg.hwnd == NULL ) || // 2 - ( Window != HWND_BOTTOM && Window->head.h == CurrentMessage->Msg.hwnd ) ) && // 3 + ( Window->head.h == HWND_BOTTOM && CurrentMessage->Msg.hwnd == NULL ) || // 2 + ( Window->head.h != HWND_BOTTOM && Window->head.h == CurrentMessage->Msg.hwnd ) ) && // 3 ( ( ( MsgFilterLow == 0 && MsgFilterHigh == 0 ) && CurrentMessage->QS_Flags & QSflags ) || ( MsgFilterLow <= CurrentMessage->Msg.message && MsgFilterHigh >= CurrentMessage->Msg.message ) ) ) { @@ -1790,8 +1790,8 @@ 3: handle to the window whose messages are to be retrieved. */ if ( ( !Window || // 1 - ( Window == HWND_BOTTOM && CurrentMessage->Msg.hwnd == NULL ) || // 2 - ( Window != HWND_BOTTOM && Window->head.h == CurrentMessage->Msg.hwnd ) ) && // 3 + ( Window->head.h == HWND_BOTTOM && CurrentMessage->Msg.hwnd == NULL ) || // 2 + ( Window->head.h != HWND_BOTTOM && Window->head.h == CurrentMessage->Msg.hwnd ) ) && // 3 ( ( ( MsgFilterLow == 0 && MsgFilterHigh == 0 ) && CurrentMessage->QS_Flags & QSflags ) || ( MsgFilterLow <= CurrentMessage->Msg.message && MsgFilterHigh >= CurrentMessage->Msg.message ) ) ) {

2 2

mail
by none ofyourbussines 30 Apr '12

30 Apr '12

My email was hacked so I got a new one reinstalled my computer operating system and got AVG® it will never happen again

2 1

Re: [ros-dev] [ros-diffs] [tkreuzer] 56442: [PSEH] Fix a serious bug in PSEH that could lead to stack corruption and was causing CSRSS to crash, when large amounts of text were output on the console. Background: PSEH used _...
by Alex Ionescu 29 Apr '12

29 Apr '12

Runner-up to Arty's patch of the year. Best regards, Alex Ionescu On Sun, Apr 29, 2012 at 3:00 AM, <tkreuzer(a)svn.reactos.org> wrote: > Author: tkreuzer > Date: Sat Apr 28 20:00:09 2012 > New Revision: 56442 > > URL: http://svn.reactos.org/svn/reactos?rev=56442&view=rev > Log: > [PSEH] > Fix a serious bug in PSEH that could lead to stack corruption and was causing CSRSS to crash, when large amounts of text were output on the console. > Background: PSEH used __builtin_alloca to allocate an SEH registration frame on the stack on demand, ie only for the first try level. But there are some nasty things with __builtin_alloca: First it DOES NOT - as one might think - free the allocated memory, once the allocation "goes out of scope", like with local variables, but only on function exit. Therefore it cannot normally be used inside a loop. The trick that PSEH used to "fix" this problem, was to save the stack pointer and reset it back at the end. This is quite problematic, since the rest of the code might assume that the stack pointer is still where it was left off after the allocation. The other thing is that __builtin_alloca() can allocate the memory whenever it likes to. It can allocate everything on function entry or not allocate anything at all, when other stack variables that went out of scope have left enough space to be reused. In csrss it now happened that the allocation was done before the stack pointer was saved, > so the memory could not be freed by restoring the old stack pointer value. That lead to slowly eating up the stack since the code was inside a loop. > The allocation is now replaced with a variable sized array. The variable stays in scope until the _SEH2_END and will be automaticall cleaned up by the compiler. This also makes saving and restoring the stack pointer obsolete. > Reliability++ > > Modified: > trunk/reactos/include/reactos/libs/pseh/pseh2.h > > Modified: trunk/reactos/include/reactos/libs/pseh/pseh2.h > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/reactos/libs/pseh/… > ============================================================================== > --- trunk/reactos/include/reactos/libs/pseh/pseh2.h [iso-8859-1] (original) > +++ trunk/reactos/include/reactos/libs/pseh/pseh2.h [iso-8859-1] Sat Apr 28 20:00:09 2012 > @@ -192,7 +192,6 @@ > if(_SEHTopTryLevel) \ > { \ > _SEH2LeaveFrame(); \ > - __asm__ __volatile__("mov %0, %%esp" : : "g" (_SEHStackPointer)); \ > } > > #define __SEH_END_SCOPE_CHAIN \ > @@ -219,16 +218,14 @@ > static const int _SEH2ScopeKind = 0; \ > volatile _SEH2TryLevel_t _SEHTryLevel; \ > volatile _SEH2HandleTryLevel_t _SEHHandleTryLevel; \ > - void * _SEHStackPointer; \ > + _SEH2Frame_t _SEH2Frame[_SEHTopTryLevel ? 1 : 0]; \ > volatile _SEH2TryLevel_t * _SEH2TryLevelP; \ > _SEH2Frame_t * const _SEH2FrameP = _SEHTopTryLevel ? \ > - ({ __asm__ __volatile__("mov %%esp, %0" : "=g" (_SEHStackPointer)); __builtin_alloca(sizeof(_SEH2Frame_t)); }) : \ > - _SEHCurFrameP; \ > + _SEH2Frame : _SEHCurFrameP; \ > \ > (void)_SEH2ScopeKind; \ > (void)_SEHTryLevel; \ > (void)_SEHHandleTryLevel; \ > - (void)_SEHStackPointer; \ > (void)_SEH2FrameP; \ > (void)_SEH2TryLevelP; \ > \ > >

1 0

Re: [ros-dev] [ros-diffs] [arty] 56441: [NTOSKRNL] Remove PAGEOPs and use the argument to pass relevant information where needed, including generally a section page table entry or a PFN_NUMBER. In its place, the code looks ...
by Alex Ionescu 28 Apr '12

28 Apr '12

Patch of the Year. Best regards, Alex Ionescu On Sat, Apr 28, 2012 at 10:56 AM, <arty(a)svn.reactos.org> wrote: > Author: arty > Date: Sat Apr 28 02:56:31 2012 > New Revision: 56441 > > URL: http://svn.reactos.org/svn/reactos?rev=56441&view=rev > Log: > [NTOSKRNL] > Remove PAGEOPs and use the argument to pass relevant information where > needed, > including generally a section page table entry or a PFN_NUMBER. > > In its place, the code looks for an MM_WAIT_ENTRY in the appropriate place > and > waits, returning STATUS_MM_RESTART_OPERATION. Rather than copying the > pagein > and CoW operations in the PAGEOP contention case, we just punt back and > restart > the operation, resulting in simpler code. > > Modified: > trunk/reactos/ntoskrnl/CMakeLists.txt > trunk/reactos/ntoskrnl/cache/section/sptab.c > trunk/reactos/ntoskrnl/include/internal/mm.h > trunk/reactos/ntoskrnl/mm/mminit.c > trunk/reactos/ntoskrnl/mm/rmap.c > trunk/reactos/ntoskrnl/mm/section.c > > Modified: trunk/reactos/ntoskrnl/CMakeLists.txt > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/CMakeLists.txt?re… > > ============================================================================== > --- trunk/reactos/ntoskrnl/CMakeLists.txt [iso-8859-1] (original) > +++ trunk/reactos/ntoskrnl/CMakeLists.txt [iso-8859-1] Sat Apr 28 02:56:31 > 2012 > @@ -229,7 +229,6 @@ > mm/mmfault.c > mm/mminit.c > mm/pagefile.c > - mm/pageop.c > mm/region.c > mm/rmap.c > mm/section.c > > Modified: trunk/reactos/ntoskrnl/cache/section/sptab.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/cache/section/spt… > > ============================================================================== > --- trunk/reactos/ntoskrnl/cache/section/sptab.c [iso-8859-1] (original) > +++ trunk/reactos/ntoskrnl/cache/section/sptab.c [iso-8859-1] Sat Apr 28 > 02:56:31 2012 > @@ -215,8 +215,9 @@ > ASSERT(!Entry || IS_SWAP_FROM_SSE(Entry)); > MmDeleteSectionAssociation(PFN_FROM_SSE(OldEntry)); > } else if (IS_SWAP_FROM_SSE(Entry)) { > - ASSERT(!IS_SWAP_FROM_SSE(OldEntry)); > - if (OldEntry) > + ASSERT(!IS_SWAP_FROM_SSE(OldEntry) || > + SWAPENTRY_FROM_SSE(OldEntry) == MM_WAIT_ENTRY); > + if (OldEntry && SWAPENTRY_FROM_SSE(OldEntry) != MM_WAIT_ENTRY) > MmDeleteSectionAssociation(PFN_FROM_SSE(OldEntry)); > } else if (IS_SWAP_FROM_SSE(OldEntry)) { > ASSERT(!IS_SWAP_FROM_SSE(Entry)); > > Modified: trunk/reactos/ntoskrnl/include/internal/mm.h > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/include/internal/… > > ============================================================================== > --- trunk/reactos/ntoskrnl/include/internal/mm.h [iso-8859-1] (original) > +++ trunk/reactos/ntoskrnl/include/internal/mm.h [iso-8859-1] Sat Apr 28 > 02:56:31 2012 > @@ -49,7 +49,6 @@ > struct _KTRAP_FRAME; > struct _EPROCESS; > struct _MM_RMAP_ENTRY; > -struct _MM_PAGEOP; > typedef ULONG_PTR SWAPENTRY; > > // > @@ -83,12 +82,6 @@ > #define MM_CORE_DUMP_TYPE_NONE (0x0) > #define MM_CORE_DUMP_TYPE_MINIMAL (0x1) > #define MM_CORE_DUMP_TYPE_FULL (0x2) > - > -#define MM_PAGEOP_PAGEIN (1) > -#define MM_PAGEOP_PAGEOUT (2) > -#define MM_PAGEOP_PAGESYNCH (3) > -#define MM_PAGEOP_ACCESSFAULT (4) > -#define MM_PAGEOP_CHANGEPROTECT (5) > > /* Number of list heads to use */ > #define MI_FREE_POOL_LISTS 4 > @@ -415,37 +408,6 @@ > extern MMPFNLIST MmModifiedPageListHead; > extern MMPFNLIST MmModifiedNoWritePageListHead; > > -typedef struct _MM_PAGEOP > -{ > - /* Type of operation. */ > - ULONG OpType; > - /* Number of threads interested in this operation. */ > - ULONG ReferenceCount; > - /* Event that will be set when the operation is completed. */ > - KEVENT CompletionEvent; > - /* Status of the operation once it is completed. */ > - NTSTATUS Status; > - /* TRUE if the operation was abandoned. */ > - BOOLEAN Abandoned; > - /* The memory area to be affected by the operation. */ > - PMEMORY_AREA MArea; > - ULONG Hash; > - struct _MM_PAGEOP* Next; > - struct _ETHREAD* Thread; > - /* > - * These fields are used to identify the operation if it is against a > - * virtual memory area. > - */ > - HANDLE Pid; > - PVOID Address; > - /* > - * These fields are used to identify the operation if it is against a > - * section mapping. > - */ > - PMM_SECTION_SEGMENT Segment; > - ULONGLONG Offset; > -} MM_PAGEOP, *PMM_PAGEOP; > - > typedef struct _MM_MEMORY_CONSUMER > { > ULONG PagesUsed; > @@ -937,7 +899,7 @@ > PMMSUPPORT AddressSpace, > PMEMORY_AREA MemoryArea, > PVOID Address, > - struct _MM_PAGEOP* PageOp > + PFN_NUMBER Page > ); > > NTSTATUS > @@ -973,7 +935,7 @@ > PMMSUPPORT AddressSpace, > PMEMORY_AREA MArea, > PVOID Address, > - PMM_PAGEOP PageOp > + PFN_NUMBER Page > ); > > /* kmap.c > ********************************************************************/ > @@ -1006,38 +968,6 @@ > PVOID > FASTCALL > MmSafeReadPtr(PVOID Source); > - > -/* pageop.c > ******************************************************************/ > - > -VOID > -NTAPI > -MmReleasePageOp(PMM_PAGEOP PageOp); > - > -PMM_PAGEOP > -NTAPI > -MmGetPageOp( > - PMEMORY_AREA MArea, > - HANDLE Pid, > - PVOID Address, > - PMM_SECTION_SEGMENT Segment, > - ULONGLONG Offset, > - ULONG OpType, > - BOOLEAN First > -); > - > -PMM_PAGEOP > -NTAPI > -MmCheckForPageOp( > - PMEMORY_AREA MArea, > - HANDLE Pid, > - PVOID Address, > - PMM_SECTION_SEGMENT Segment, > - ULONGLONG Offset > -); > - > -VOID > -NTAPI > -MmInitializePageOp(VOID); > > /* process.c > *****************************************************************/ > > @@ -1657,7 +1587,7 @@ > PMMSUPPORT AddressSpace, > PMEMORY_AREA MemoryArea, > PVOID Address, > - struct _MM_PAGEOP *PageOp > + ULONG_PTR Entry > ); > > NTSTATUS > > Modified: trunk/reactos/ntoskrnl/mm/mminit.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/mminit.c?rev=5… > > ============================================================================== > --- trunk/reactos/ntoskrnl/mm/mminit.c [iso-8859-1] (original) > +++ trunk/reactos/ntoskrnl/mm/mminit.c [iso-8859-1] Sat Apr 28 02:56:31 > 2012 > @@ -419,7 +419,6 @@ > MiInitializeUserPfnBitmap(); > MmInitializeMemoryConsumer(MC_USER, MmTrimUserMemory); > MmInitializeRmapList(); > - MmInitializePageOp(); > MmInitSectionImplementation(); > MmInitPagingFile(); > > > Modified: trunk/reactos/ntoskrnl/mm/rmap.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/rmap.c?rev=564… > > ============================================================================== > --- trunk/reactos/ntoskrnl/mm/rmap.c [iso-8859-1] (original) > +++ trunk/reactos/ntoskrnl/mm/rmap.c [iso-8859-1] Sat Apr 28 02:56:31 2012 > @@ -52,7 +52,6 @@ > ULONG Type; > PVOID Address; > PEPROCESS Process; > - PMM_PAGEOP PageOp; > ULONGLONG Offset; > NTSTATUS Status = STATUS_SUCCESS; > > @@ -126,17 +125,20 @@ > Type = MemoryArea->Type; > if (Type == MEMORY_AREA_SECTION_VIEW) > { > + ULONG Entry; > Offset = MemoryArea->Data.SectionData.ViewOffset.QuadPart + > ((ULONG_PTR)Address - > (ULONG_PTR)MemoryArea->StartingAddress); > + > + MmLockSectionSegment(MemoryArea->Data.SectionData.Segment); > > /* > * Get or create a pageop > */ > - PageOp = MmGetPageOp(MemoryArea, NULL, 0, > - MemoryArea->Data.SectionData.Segment, > - Offset, MM_PAGEOP_PAGEOUT, TRUE); > - if (PageOp == NULL) > - { > + Entry = MmGetPageEntrySectionSegment > + (MemoryArea->Data.SectionData.Segment, (PLARGE_INTEGER)&Offset); > + if (Entry && IS_SWAP_FROM_SSE(Entry) && SWAPENTRY_FROM_SSE(Entry) > == MM_WAIT_ENTRY) > + { > + MmUnlockSectionSegment(MemoryArea->Data.SectionData.Segment); > MmUnlockAddressSpace(AddressSpace); > if (Address < MmSystemRangeStart) > { > @@ -145,17 +147,19 @@ > } > return(STATUS_UNSUCCESSFUL); > } > + > + MmSetPageEntrySectionSegment(MemoryArea->Data.SectionData.Segment, > (PLARGE_INTEGER)&Offset, MAKE_SWAP_SSE(MM_WAIT_ENTRY)); > > /* > * Release locks now we have a page op. > */ > + MmUnlockSectionSegment(MemoryArea->Data.SectionData.Segment); > MmUnlockAddressSpace(AddressSpace); > > /* > * Do the actual page out work. > */ > - Status = MmPageOutSectionView(AddressSpace, MemoryArea, > - Address, PageOp); > + Status = MmPageOutSectionView(AddressSpace, MemoryArea, Address, > Entry); > } > else if (Type == MEMORY_AREA_CACHE) > { > > Modified: trunk/reactos/ntoskrnl/mm/section.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/section.c?rev=… > > ============================================================================== > --- trunk/reactos/ntoskrnl/mm/section.c [iso-8859-1] (original) > +++ trunk/reactos/ntoskrnl/mm/section.c [iso-8859-1] Sat Apr 28 02:56:31 > 2012 > @@ -127,6 +127,7 @@ > BOOLEAN WasDirty; > BOOLEAN Private; > PEPROCESS CallingProcess; > + ULONG_PTR SectionEntry; > } > MM_SECTION_PAGEOUT_CONTEXT; > > @@ -704,43 +705,6 @@ > return nStatus; > } > > -/* Note: Mmsp prefix denotes "Memory Manager Section Private". */ > - > -/* > - * FUNCTION: Waits in kernel mode up to ten seconds for an MM_PAGEOP > event. > - * ARGUMENTS: PMM_PAGEOP which event we should wait for. > - * RETURNS: Status of the wait. > - */ > -static NTSTATUS > -MmspWaitForPageOpCompletionEvent(PMM_PAGEOP PageOp) > -{ > - LARGE_INTEGER Timeout; > -#ifdef __GNUC__ /* TODO: Use other macro to check for suffix to use? */ > - > - Timeout.QuadPart = -100000000LL; // 10 sec > -#else > - > - Timeout.QuadPart = -100000000; // 10 sec > -#endif > - > - return KeWaitForSingleObject(&PageOp->CompletionEvent, 0, KernelMode, > FALSE, &Timeout); > -} > - > - > -/* > - * FUNCTION: Sets the page op completion event and releases the page op. > - * ARGUMENTS: PMM_PAGEOP. > - * RETURNS: In shorter time than it takes you to even read this > - * description, so don't even think about geting a mug of > coffee. > - */ > -static void > -MmspCompleteAndReleasePageOp(PMM_PAGEOP PageOp) > -{ > - KeSetEvent(&PageOp->CompletionEvent, IO_NO_INCREMENT, FALSE); > - MmReleasePageOp(PageOp); > -} > - > - > /* > * FUNCTION: Waits in kernel mode indefinitely for a file object lock. > * ARGUMENTS: PFILE_OBJECT to wait for. > @@ -831,12 +795,12 @@ > PMM_SECTION_SEGMENT Segment, > PLARGE_INTEGER Offset, > BOOLEAN Dirty, > - BOOLEAN PageOut) > -{ > - ULONG_PTR Entry; > + BOOLEAN PageOut, > + ULONG_PTR *InEntry) > +{ > + ULONG_PTR Entry = InEntry ? *InEntry : > MmGetPageEntrySectionSegment(Segment, Offset); > BOOLEAN IsDirectMapped = FALSE; > > - Entry = MmGetPageEntrySectionSegment(Segment, Offset); > if (Entry == 0) > { > DPRINT1("Entry == 0 for MmUnsharePageEntrySectionSegment\n"); > @@ -844,7 +808,7 @@ > } > if (SHARE_COUNT_FROM_SSE(Entry) == 0) > { > - DPRINT1("Zero share count for unshare\n"); > + DPRINT1("Zero share count for unshare (Seg %p Offset %x Page > %x)\n", Segment, Offset->LowPart, PFN_FROM_SSE(Entry)); > KeBugCheck(MEMORY_MANAGEMENT); > } > if (IS_SWAP_FROM_SSE(Entry)) > @@ -913,10 +877,14 @@ > * page without a rmap entry. > */ > MmSetPageEntrySectionSegment(Segment, Offset, Entry); > + if (InEntry) *InEntry = Entry; > + MiSetPageEvent(NULL, NULL); > } > else > { > MmSetPageEntrySectionSegment(Segment, Offset, 0); > + if (InEntry) *InEntry = 0; > + MiSetPageEvent(NULL, NULL); > if (!IsDirectMapped) > { > MmReleasePageMemoryConsumer(MC_USER, Page); > @@ -946,7 +914,9 @@ > } > } > MmSetPageEntrySectionSegment(Segment, Offset, > MAKE_SWAP_SSE(SavedSwapEntry)); > + if (InEntry) *InEntry = MAKE_SWAP_SSE(SavedSwapEntry); > MmSetSavedSwapEntryPage(Page, 0); > + MiSetPageEvent(NULL, NULL); > } > MmReleasePageMemoryConsumer(MC_USER, Page); > } > @@ -959,7 +929,10 @@ > } > else > { > - MmSetPageEntrySectionSegment(Segment, Offset, Entry); > + if (InEntry) > + *InEntry = Entry; > + else > + MmSetPageEntrySectionSegment(Segment, Offset, Entry); > } > return(SHARE_COUNT_FROM_SSE(Entry) > 0); > } > @@ -1232,7 +1205,6 @@ > ULONG_PTR Entry; > ULONG_PTR Entry1; > ULONG Attributes; > - PMM_PAGEOP PageOp; > PMM_REGION Region; > BOOLEAN HasSwapEntry; > PVOID PAddress; > @@ -1270,7 +1242,7 @@ > * Lock the segment > */ > MmLockSectionSegment(Segment); > - > + Entry = MmGetPageEntrySectionSegment(Segment, &Offset); > /* > * Check if this page needs to be mapped COW > */ > @@ -1286,111 +1258,41 @@ > } > > /* > - * Get or create a page operation descriptor > - */ > - PageOp = MmGetPageOp(MemoryArea, NULL, 0, Segment, Offset.LowPart, > MM_PAGEOP_PAGEIN, FALSE); > - if (PageOp == NULL) > - { > - DPRINT1("MmGetPageOp failed\n"); > - KeBugCheck(MEMORY_MANAGEMENT); > - } > - > - /* > * Check if someone else is already handling this fault, if so wait > * for them > */ > - if (PageOp->Thread != PsGetCurrentThread()) > + if (Entry && IS_SWAP_FROM_SSE(Entry) && SWAPENTRY_FROM_SSE(Entry) == > MM_WAIT_ENTRY) > { > MmUnlockSectionSegment(Segment); > MmUnlockAddressSpace(AddressSpace); > - Status = MmspWaitForPageOpCompletionEvent(PageOp); > + MiWaitForPageEvent(NULL, NULL); > + MmLockAddressSpace(AddressSpace); > + DPRINT("Address 0x%.8X\n", Address); > + return(STATUS_MM_RESTART_OPERATION); > + } > + > + HasSwapEntry = MmIsPageSwapEntry(Process, Address); > + > + if (HasSwapEntry) > + { > + SWAPENTRY SwapEntry; > /* > - * Check for various strange conditions > + * Is it a wait entry? > */ > - if (Status != STATUS_SUCCESS) > - { > - DPRINT1("Failed to wait for page op, status = %x\n", Status); > - KeBugCheck(MEMORY_MANAGEMENT); > - } > - if (PageOp->Status == STATUS_PENDING) > - { > - DPRINT1("Woke for page op before completion\n"); > - KeBugCheck(MEMORY_MANAGEMENT); > - } > - MmLockAddressSpace(AddressSpace); > - /* > - * If this wasn't a pagein then restart the operation > - */ > - if (PageOp->OpType != MM_PAGEOP_PAGEIN) > - { > - MmspCompleteAndReleasePageOp(PageOp); > - DPRINT("Address 0x%.8X\n", Address); > - return(STATUS_MM_RESTART_OPERATION); > - } > - > - /* > - * If the thread handling this fault has failed then we don't retry > - */ > - if (!NT_SUCCESS(PageOp->Status)) > - { > - Status = PageOp->Status; > - MmspCompleteAndReleasePageOp(PageOp); > - DPRINT("Address 0x%.8X\n", Address); > - return(Status); > - } > - MmLockSectionSegment(Segment); > - /* > - * If the completed fault was for another address space then set the > - * page in this one. > - */ > - if (!MmIsPagePresent(Process, Address)) > - { > - Entry = MmGetPageEntrySectionSegment(Segment, &Offset); > - HasSwapEntry = MmIsPageSwapEntry(Process, (PVOID)PAddress); > - > - if (PAGE_FROM_SSE(Entry) == 0 || HasSwapEntry) > - { > - /* > - * The page was a private page in another or in our address > space > - */ > - MmUnlockSectionSegment(Segment); > - MmspCompleteAndReleasePageOp(PageOp); > - return(STATUS_MM_RESTART_OPERATION); > - } > - > - Page = PFN_FROM_SSE(Entry); > - > - MmSharePageEntrySectionSegment(Segment, &Offset); > - > - /* FIXME: Should we call MmCreateVirtualMappingUnsafe if > - * (Section->AllocationAttributes & SEC_PHYSICALMEMORY) is true? > - */ > - Status = MmCreateVirtualMapping(Process, > - PAddress, > - Attributes, > - &Page, > - 1); > - if (!NT_SUCCESS(Status)) > - { > - DPRINT1("Unable to create virtual mapping\n"); > - KeBugCheck(MEMORY_MANAGEMENT); > - } > - MmInsertRmap(Page, Process, Address); > - } > - MmUnlockSectionSegment(Segment); > - PageOp->Status = STATUS_SUCCESS; > - MmspCompleteAndReleasePageOp(PageOp); > - DPRINT("Address 0x%.8X\n", Address); > - return(STATUS_SUCCESS); > - } > - > - HasSwapEntry = MmIsPageSwapEntry(Process, Address); > - if (HasSwapEntry) > - { > + MmGetPageFileMapping(Process, Address, &SwapEntry); > + > + if (SwapEntry == MM_WAIT_ENTRY) > + { > + MmUnlockSectionSegment(Segment); > + MmUnlockAddressSpace(AddressSpace); > + MiWaitForPageEvent(NULL, NULL); > + MmLockAddressSpace(AddressSpace); > + return STATUS_MM_RESTART_OPERATION; > + } > + > /* > * Must be private page we have swapped out. > */ > - SWAPENTRY SwapEntry; > > /* > * Sanity check > @@ -1445,8 +1347,7 @@ > /* > * Finish the operation > */ > - PageOp->Status = STATUS_SUCCESS; > - MmspCompleteAndReleasePageOp(PageOp); > + MiSetPageEvent(Process, Address); > DPRINT("Address 0x%.8X\n", Address); > return(STATUS_SUCCESS); > } > @@ -1476,8 +1377,7 @@ > /* > * Cleanup and release locks > */ > - PageOp->Status = STATUS_SUCCESS; > - MmspCompleteAndReleasePageOp(PageOp); > + MiSetPageEvent(Process, Address); > DPRINT("Address 0x%.8X\n", Address); > return(STATUS_SUCCESS); > } > @@ -1518,8 +1418,7 @@ > /* > * Cleanup and release locks > */ > - PageOp->Status = STATUS_SUCCESS; > - MmspCompleteAndReleasePageOp(PageOp); > + MiSetPageEvent(Process, Address); > DPRINT("Address 0x%.8X\n", Address); > return(STATUS_SUCCESS); > } > @@ -1539,6 +1438,7 @@ > /* > * Release all our locks and read in the page from disk > */ > + MmSetPageEntrySectionSegment(Segment, &Offset, > MAKE_SWAP_SSE(MM_WAIT_ENTRY)); > MmUnlockSectionSegment(Segment); > MmUnlockAddressSpace(AddressSpace); > > @@ -1573,11 +1473,64 @@ > * Cleanup and release locks > */ > MmLockAddressSpace(AddressSpace); > - PageOp->Status = Status; > - MmspCompleteAndReleasePageOp(PageOp); > + MiSetPageEvent(Process, Address); > DPRINT("Address 0x%.8X\n", Address); > return(Status); > } > + > + /* > + * Mark the offset within the section as having valid, in-memory > + * data > + */ > + MmLockAddressSpace(AddressSpace); > + MmLockSectionSegment(Segment); > + Entry = MAKE_SSE(Page << PAGE_SHIFT, 1); > + MmSetPageEntrySectionSegment(Segment, &Offset, Entry); > + MmUnlockSectionSegment(Segment); > + > + Status = MmCreateVirtualMapping(Process, > + PAddress, > + Attributes, > + &Page, > + 1); > + if (!NT_SUCCESS(Status)) > + { > + DPRINT1("Unable to create virtual mapping\n"); > + KeBugCheck(MEMORY_MANAGEMENT); > + } > + MmInsertRmap(Page, Process, Address); > + > + MiSetPageEvent(Process, Address); > + DPRINT("Address 0x%.8X\n", Address); > + return(STATUS_SUCCESS); > + } > + else if (IS_SWAP_FROM_SSE(Entry)) > + { > + SWAPENTRY SwapEntry; > + > + SwapEntry = SWAPENTRY_FROM_SSE(Entry); > + > + /* > + * Release all our locks and read in the page from disk > + */ > + MmUnlockSectionSegment(Segment); > + > + MmUnlockAddressSpace(AddressSpace); > + MI_SET_USAGE(MI_USAGE_SECTION); > + if (Process) MI_SET_PROCESS2(Process->ImageFileName); > + if (!Process) MI_SET_PROCESS2("Kernel Section"); > + Status = MmRequestPageMemoryConsumer(MC_USER, TRUE, &Page); > + if (!NT_SUCCESS(Status)) > + { > + KeBugCheck(MEMORY_MANAGEMENT); > + } > + > + Status = MmReadFromSwapPage(SwapEntry, Page); > + if (!NT_SUCCESS(Status)) > + { > + KeBugCheck(MEMORY_MANAGEMENT); > + } > + > /* > * Relock the address space and segment > */ > @@ -1591,76 +1544,7 @@ > Entry1 = MmGetPageEntrySectionSegment(Segment, &Offset); > if (Entry != Entry1) > { > - DPRINT1("Someone changed ppte entry while we slept\n"); > - KeBugCheck(MEMORY_MANAGEMENT); > - } > - > - /* > - * Mark the offset within the section as having valid, in-memory > - * data > - */ > - Entry = MAKE_SSE(Page << PAGE_SHIFT, 1); > - MmSetPageEntrySectionSegment(Segment, &Offset, Entry); > - MmUnlockSectionSegment(Segment); > - > - Status = MmCreateVirtualMapping(Process, > - PAddress, > - Attributes, > - &Page, > - 1); > - if (!NT_SUCCESS(Status)) > - { > - DPRINT1("Unable to create virtual mapping\n"); > - KeBugCheck(MEMORY_MANAGEMENT); > - } > - MmInsertRmap(Page, Process, Address); > - > - PageOp->Status = STATUS_SUCCESS; > - MmspCompleteAndReleasePageOp(PageOp); > - DPRINT("Address 0x%.8X\n", Address); > - return(STATUS_SUCCESS); > - } > - else if (IS_SWAP_FROM_SSE(Entry)) > - { > - SWAPENTRY SwapEntry; > - > - SwapEntry = SWAPENTRY_FROM_SSE(Entry); > - > - /* > - * Release all our locks and read in the page from disk > - */ > - MmUnlockSectionSegment(Segment); > - > - MmUnlockAddressSpace(AddressSpace); > - MI_SET_USAGE(MI_USAGE_SECTION); > - if (Process) MI_SET_PROCESS2(Process->ImageFileName); > - if (!Process) MI_SET_PROCESS2("Kernel Section"); > - Status = MmRequestPageMemoryConsumer(MC_USER, TRUE, &Page); > - if (!NT_SUCCESS(Status)) > - { > - KeBugCheck(MEMORY_MANAGEMENT); > - } > - > - Status = MmReadFromSwapPage(SwapEntry, Page); > - if (!NT_SUCCESS(Status)) > - { > - KeBugCheck(MEMORY_MANAGEMENT); > - } > - > - /* > - * Relock the address space and segment > - */ > - MmLockAddressSpace(AddressSpace); > - MmLockSectionSegment(Segment); > - > - /* > - * Check the entry. No one should change the status of a page > - * that has a pending page-in. > - */ > - Entry1 = MmGetPageEntrySectionSegment(Segment, &Offset); > - if (Entry != Entry1) > - { > - DPRINT1("Someone changed ppte entry while we slept\n"); > + DPRINT1("Someone changed ppte entry while we slept (%x vs > %x)\n", Entry, Entry1); > KeBugCheck(MEMORY_MANAGEMENT); > } > > @@ -1687,8 +1571,7 @@ > KeBugCheck(MEMORY_MANAGEMENT); > } > MmInsertRmap(Page, Process, Address); > - PageOp->Status = STATUS_SUCCESS; > - MmspCompleteAndReleasePageOp(PageOp); > + MiSetPageEvent(Process, Address); > DPRINT("Address 0x%.8X\n", Address); > return(STATUS_SUCCESS); > } > @@ -1715,8 +1598,7 @@ > KeBugCheck(MEMORY_MANAGEMENT); > } > MmInsertRmap(Page, Process, Address); > - PageOp->Status = STATUS_SUCCESS; > - MmspCompleteAndReleasePageOp(PageOp); > + MiSetPageEvent(Process, Address); > DPRINT("Address 0x%.8X\n", Address); > return(STATUS_SUCCESS); > } > @@ -1735,7 +1617,6 @@ > NTSTATUS Status; > PVOID PAddress; > LARGE_INTEGER Offset; > - PMM_PAGEOP PageOp; > PMM_REGION Region; > ULONG_PTR Entry; > PEPROCESS Process = MmGetAddressSpaceOwner(AddressSpace); > @@ -1799,46 +1680,29 @@ > /* > * Get or create a pageop > */ > - PageOp = MmGetPageOp(MemoryArea, NULL, 0, Segment, Offset.LowPart, > - MM_PAGEOP_ACCESSFAULT, FALSE); > - if (PageOp == NULL) > - { > - DPRINT1("MmGetPageOp failed\n"); > - KeBugCheck(MEMORY_MANAGEMENT); > - } > - > + MmLockSectionSegment(Segment); > + Entry = MmGetPageEntrySectionSegment(Segment, &Offset); > + > /* > * Wait for any other operations to complete > */ > - if (PageOp->Thread != PsGetCurrentThread()) > - { > - MmUnlockAddressSpace(AddressSpace); > - Status = MmspWaitForPageOpCompletionEvent(PageOp); > - /* > - * Check for various strange conditions > - */ > - if (Status == STATUS_TIMEOUT) > - { > - DPRINT1("Failed to wait for page op, status = %x\n", Status); > - KeBugCheck(MEMORY_MANAGEMENT); > - } > - if (PageOp->Status == STATUS_PENDING) > - { > - DPRINT1("Woke for page op before completion\n"); > - KeBugCheck(MEMORY_MANAGEMENT); > - } > - /* > - * Restart the operation > - */ > - MmLockAddressSpace(AddressSpace); > - MmspCompleteAndReleasePageOp(PageOp); > - DPRINT("Address 0x%.8X\n", Address); > - return(STATUS_MM_RESTART_OPERATION); > + if (Entry == SWAPENTRY_FROM_SSE(MM_WAIT_ENTRY)) > + { > + MmUnlockSectionSegment(Segment); > + MmUnlockAddressSpace(AddressSpace); > + MiWaitForPageEvent(NULL, NULL); > + /* > + * Restart the operation > + */ > + MmLockAddressSpace(AddressSpace); > + DPRINT("Address 0x%.8X\n", Address); > + return(STATUS_MM_RESTART_OPERATION); > } > > /* > * Release locks now we have the pageop > */ > + MmUnlockSectionSegment(Segment); > MmUnlockAddressSpace(AddressSpace); > > /* > @@ -1890,11 +1754,10 @@ > MmDeleteRmap(OldPage, Process, PAddress); > MmInsertRmap(NewPage, Process, PAddress); > MmLockSectionSegment(Segment); > - MmUnsharePageEntrySectionSegment(Section, Segment, &Offset, FALSE, > FALSE); > + MmUnsharePageEntrySectionSegment(Section, Segment, &Offset, FALSE, > FALSE, NULL); > MmUnlockSectionSegment(Segment); > > - PageOp->Status = STATUS_SUCCESS; > - MmspCompleteAndReleasePageOp(PageOp); > + MiSetPageEvent(Process, Address); > DPRINT("Address 0x%.8X\n", Address); > return(STATUS_SUCCESS); > } > @@ -1904,7 +1767,7 @@ > { > MM_SECTION_PAGEOUT_CONTEXT* PageOutContext; > BOOLEAN WasDirty; > - PFN_NUMBER Page; > + PFN_NUMBER Page = 0; > > PageOutContext = (MM_SECTION_PAGEOUT_CONTEXT*)Context; > if (Process) > @@ -1928,7 +1791,8 @@ > PageOutContext->Segment, > &PageOutContext->Offset, > PageOutContext->WasDirty, > - TRUE); > + TRUE, > + &PageOutContext->SectionEntry); > MmUnlockSectionSegment(PageOutContext->Segment); > } > if (Process) > @@ -1940,21 +1804,17 @@ > { > MmReleasePageMemoryConsumer(MC_USER, Page); > } > - > - DPRINT("PhysicalAddress %x, Address %x\n", Page << PAGE_SHIFT, > Address); > } > > NTSTATUS > NTAPI > MmPageOutSectionView(PMMSUPPORT AddressSpace, > MEMORY_AREA* MemoryArea, > - PVOID Address, > - PMM_PAGEOP PageOp) > + PVOID Address, ULONG_PTR Entry) > { > PFN_NUMBER Page; > MM_SECTION_PAGEOUT_CONTEXT Context; > SWAPENTRY SwapEntry; > - ULONG_PTR Entry; > ULONGLONG FileOffset; > NTSTATUS Status; > PFILE_OBJECT FileObject; > @@ -1973,6 +1833,7 @@ > */ > Context.Segment = MemoryArea->Data.SectionData.Segment; > Context.Section = MemoryArea->Data.SectionData.Section; > + Context.SectionEntry = Entry; > Context.CallingProcess = Process; > > Context.Offset.QuadPart = (ULONG_PTR)Address - > (ULONG_PTR)MemoryArea->StartingAddress > @@ -1983,6 +1844,8 @@ > > FileObject = Context.Section->FileObject; > DirectMapped = FALSE; > + > + MmLockSectionSegment(Context.Segment); > > #ifndef NEWCC > if (FileObject != NULL && > @@ -2035,16 +1898,14 @@ > { > DPRINT("Cannot page out locked section page: 0x%p (RefCount: %d)\n", > Page, MmGetReferenceCountPage(Page)); > - PageOp->Status = STATUS_UNSUCCESSFUL; > - MmspCompleteAndReleasePageOp(PageOp); > + MmSetPageEntrySectionSegment(Context.Segment, &Context.Offset, > Entry); > + MmUnlockSectionSegment(Context.Segment); > return STATUS_UNSUCCESSFUL; > } > > /* > * Prepare the context structure for the rmap delete call. > */ > - MmLockSectionSegment(Context.Segment); > - Entry = MmGetPageEntrySectionSegment(Context.Segment, &Context.Offset); > MmUnlockSectionSegment(Context.Segment); > Context.WasDirty = FALSE; > if (Context.Segment->Image.Characteristics & > IMAGE_SCN_CNT_UNINITIALIZED_DATA || > @@ -2077,9 +1938,12 @@ > } > > MmDeleteAllRmaps(Page, (PVOID)&Context, MmPageOutDeleteMapping); > - MmLockSectionSegment(Context.Segment); > - Entry = MmGetPageEntrySectionSegment(Context.Segment, &Context.Offset); > - MmUnlockSectionSegment(Context.Segment); > + > + /* Since we passed in a surrogate, we'll get back the page entry > + * state in our context. This is intended to make intermediate > + * decrements of share count not release the wait entry. > + */ > + Entry = Context.SectionEntry; > > /* > * If this wasn't a private page then we should have reduced the entry > to > @@ -2117,8 +1981,7 @@ > MmSetPageEntrySectionSegment(Context.Segment, &Context.Offset, > MAKE_SWAP_SSE(SwapEntry)); > MmUnlockSectionSegment(Context.Segment); > MmReleasePageMemoryConsumer(MC_USER, Page); > - PageOp->Status = STATUS_SUCCESS; > - MmspCompleteAndReleasePageOp(PageOp); > + MiSetPageEvent(NULL, NULL); > return(STATUS_SUCCESS); > } > } > @@ -2140,8 +2003,7 @@ > MmUnlockSectionSegment(Context.Segment); > } > MmReleasePageMemoryConsumer(MC_USER, Page); > - PageOp->Status = STATUS_SUCCESS; > - MmspCompleteAndReleasePageOp(PageOp); > + MiSetPageEvent(NULL, NULL); > return(STATUS_SUCCESS); > } > } > @@ -2165,8 +2027,7 @@ > KeBugCheckEx(MEMORY_MANAGEMENT, Status, (ULONG_PTR)Bcb, > (ULONG_PTR)FileOffset, (ULONG_PTR)Address); > } > #endif > - PageOp->Status = STATUS_SUCCESS; > - MmspCompleteAndReleasePageOp(PageOp); > + MiSetPageEvent(NULL, NULL); > return(STATUS_SUCCESS); > } > else if (!Context.WasDirty && !DirectMapped && !Context.Private) > @@ -2178,13 +2039,12 @@ > KeBugCheckEx(MEMORY_MANAGEMENT, SwapEntry, Page, > (ULONG_PTR)Process, (ULONG_PTR)Address); > } > MmReleasePageMemoryConsumer(MC_USER, Page); > - PageOp->Status = STATUS_SUCCESS; > - MmspCompleteAndReleasePageOp(PageOp); > + MiSetPageEvent(NULL, NULL); > return(STATUS_SUCCESS); > } > else if (!Context.WasDirty && Context.Private && SwapEntry != 0) > { > - DPRINT1("Not dirty and private and not swapped (%p:%p)\n", Process, > Address); > + DPRINT("Not dirty and private and not swapped (%p:%p)\n", Process, > Address); > MmSetSavedSwapEntryPage(Page, 0); > MmLockAddressSpace(AddressSpace); > Status = MmCreatePageFileMapping(Process, > @@ -2197,8 +2057,7 @@ > KeBugCheckEx(MEMORY_MANAGEMENT, Status, (ULONG_PTR)Process, > (ULONG_PTR)Address, SwapEntry); > } > MmReleasePageMemoryConsumer(MC_USER, Page); > - PageOp->Status = STATUS_SUCCESS; > - MmspCompleteAndReleasePageOp(PageOp); > + MiSetPageEvent(NULL, NULL); > return(STATUS_SUCCESS); > } > > @@ -2253,8 +2112,7 @@ > MmUnlockSectionSegment(Context.Segment); > } > MmUnlockAddressSpace(AddressSpace); > - PageOp->Status = STATUS_UNSUCCESSFUL; > - MmspCompleteAndReleasePageOp(PageOp); > + MiSetPageEvent(NULL, NULL); > return(STATUS_PAGEFILE_QUOTA); > } > } > @@ -2299,8 +2157,7 @@ > MmSetPageEntrySectionSegment(Context.Segment, &Context.Offset, > Entry); > } > MmUnlockAddressSpace(AddressSpace); > - PageOp->Status = STATUS_UNSUCCESSFUL; > - MmspCompleteAndReleasePageOp(PageOp); > + MiSetPageEvent(NULL, NULL); > return(STATUS_UNSUCCESSFUL); > } > > @@ -2308,12 +2165,13 @@ > * Otherwise we have succeeded. > */ > DPRINT("MM: Wrote section page 0x%.8X to swap!\n", Page << PAGE_SHIFT); > - MmLockSectionSegment(Context.Segment); > MmSetSavedSwapEntryPage(Page, 0); > if (Context.Segment->Flags & MM_PAGEFILE_SEGMENT || > Context.Segment->Image.Characteristics & IMAGE_SCN_MEM_SHARED) > { > + MmLockSectionSegment(Context.Segment); > MmSetPageEntrySectionSegment(Context.Segment, &Context.Offset, > MAKE_SWAP_SSE(SwapEntry)); > + MmUnlockSectionSegment(Context.Segment); > } > else > { > @@ -2323,9 +2181,11 @@ > if (Context.Private) > { > MmLockAddressSpace(AddressSpace); > + MmLockSectionSegment(Context.Segment); > Status = MmCreatePageFileMapping(Process, > Address, > SwapEntry); > + MmUnlockSectionSegment(Context.Segment); > MmUnlockAddressSpace(AddressSpace); > if (!NT_SUCCESS(Status)) > { > @@ -2335,13 +2195,15 @@ > } > else > { > + MmLockAddressSpace(AddressSpace); > + MmLockSectionSegment(Context.Segment); > Entry = MAKE_SWAP_SSE(SwapEntry); > MmSetPageEntrySectionSegment(Context.Segment, &Context.Offset, > Entry); > - } > - > - MmUnlockSectionSegment(Context.Segment); > - PageOp->Status = STATUS_SUCCESS; > - MmspCompleteAndReleasePageOp(PageOp); > + MmUnlockSectionSegment(Context.Segment); > + MmUnlockAddressSpace(AddressSpace); > + } > + > + MiSetPageEvent(NULL, NULL); > return(STATUS_SUCCESS); > } > > @@ -2350,7 +2212,7 @@ > MmWritePageSectionView(PMMSUPPORT AddressSpace, > PMEMORY_AREA MemoryArea, > PVOID Address, > - PMM_PAGEOP PageOp) > + ULONG PageEntry) > { > LARGE_INTEGER Offset; > PROS_SECTION_OBJECT Section; > @@ -2447,12 +2309,16 @@ > */ > if (DirectMapped && !Private) > { > + LARGE_INTEGER SOffset; > ASSERT(SwapEntry == 0); > + SOffset.QuadPart = Offset.QuadPart + Segment->Image.FileOffset; > #ifndef NEWCC > - CcRosMarkDirtyCacheSegment(Bcb, (ULONG)(Offset.QuadPart + > Segment->Image.FileOffset)); > + CcRosMarkDirtyCacheSegment(Bcb, Offset.LowPart); > #endif > - PageOp->Status = STATUS_SUCCESS; > - MmspCompleteAndReleasePageOp(PageOp); > + MmLockSectionSegment(Segment); > + MmSetPageEntrySectionSegment(Segment, &Offset, PageEntry); > + MmUnlockSectionSegment(Segment); > + MiSetPageEvent(NULL, NULL); > return(STATUS_SUCCESS); > } > > @@ -2465,8 +2331,7 @@ > if (SwapEntry == 0) > { > MmSetDirtyAllRmaps(Page); > - PageOp->Status = STATUS_UNSUCCESSFUL; > - MmspCompleteAndReleasePageOp(PageOp); > + MiSetPageEvent(NULL, NULL); > return(STATUS_PAGEFILE_QUOTA); > } > MmSetSavedSwapEntryPage(Page, SwapEntry); > @@ -2481,8 +2346,7 @@ > DPRINT1("MM: Failed to write to swap page (Status was 0x%.8X)\n", > Status); > MmSetDirtyAllRmaps(Page); > - PageOp->Status = STATUS_UNSUCCESSFUL; > - MmspCompleteAndReleasePageOp(PageOp); > + MiSetPageEvent(NULL, NULL); > return(STATUS_UNSUCCESSFUL); > } > > @@ -2490,8 +2354,7 @@ > * Otherwise we have succeeded. > */ > DPRINT("MM: Wrote section page 0x%.8X to swap!\n", Page << PAGE_SHIFT); > - PageOp->Status = STATUS_SUCCESS; > - MmspCompleteAndReleasePageOp(PageOp); > + MiSetPageEvent(NULL, NULL); > return(STATUS_SUCCESS); > } > > @@ -4039,8 +3902,6 @@ > PBCB Bcb; > LARGE_INTEGER Offset; > SWAPENTRY SavedSwapEntry; > - PMM_PAGEOP PageOp; > - NTSTATUS Status; > PROS_SECTION_OBJECT Section; > PMM_SECTION_SEGMENT Segment; > PMMSUPPORT AddressSpace; > @@ -4057,27 +3918,18 @@ > Section = MemoryArea->Data.SectionData.Section; > Segment = MemoryArea->Data.SectionData.Segment; > > - PageOp = MmCheckForPageOp(MemoryArea, NULL, NULL, Segment, > Offset.LowPart); > - > - while (PageOp) > + Entry = MmGetPageEntrySectionSegment(Segment, &Offset); > + while (Entry && IS_SWAP_FROM_SSE(Entry) && SWAPENTRY_FROM_SSE(Entry) > == MM_WAIT_ENTRY) > { > MmUnlockSectionSegment(Segment); > MmUnlockAddressSpace(AddressSpace); > > - Status = MmspWaitForPageOpCompletionEvent(PageOp); > - if (Status != STATUS_SUCCESS) > - { > - DPRINT1("Failed to wait for page op, status = %x\n", Status); > - KeBugCheck(MEMORY_MANAGEMENT); > - } > + MiWaitForPageEvent(NULL, NULL); > > MmLockAddressSpace(AddressSpace); > MmLockSectionSegment(Segment); > - MmspCompleteAndReleasePageOp(PageOp); > - PageOp = MmCheckForPageOp(MemoryArea, NULL, NULL, Segment, > Offset.LowPart); > - } > - > - Entry = MmGetPageEntrySectionSegment(Segment, &Offset); > + Entry = MmGetPageEntrySectionSegment(Segment, &Offset); > + } > > /* > * For a dirty, datafile, non-private page mark it as dirty in the > @@ -4136,7 +3988,7 @@ > else > { > MmDeleteRmap(Page, Process, Address); > - MmUnsharePageEntrySectionSegment(Section, Segment, &Offset, > Dirty, FALSE); > + MmUnsharePageEntrySectionSegment(Section, Segment, &Offset, > Dirty, FALSE, NULL); > } > } > } > @@ -4208,9 +4060,7 @@ > PMEMORY_AREA MemoryArea; > PMMSUPPORT AddressSpace; > PROS_SECTION_OBJECT Section; > - PMM_PAGEOP PageOp; > - ULONG_PTR Offset; > - PVOID ImageBaseAddress = 0; > + PVOID ImageBaseAddress = 0; > > DPRINT("Opening memory area Process %x BaseAddress %x\n", > Process, BaseAddress); > @@ -4232,40 +4082,6 @@ > } > > MemoryArea->DeleteInProgress = TRUE; > - > - while (MemoryArea->PageOpCount) > - { > - Offset = PAGE_ROUND_UP((ULONG_PTR)MemoryArea->EndingAddress - > (ULONG_PTR)MemoryArea->StartingAddress); > - > - while (Offset) > - { > - Offset -= PAGE_SIZE; > - PageOp = MmCheckForPageOp(MemoryArea, NULL, NULL, > - MemoryArea->Data.SectionData.Segment, > - Offset + > MemoryArea->Data.SectionData.ViewOffset.QuadPart); > - if (PageOp) > - { > - MmUnlockAddressSpace(AddressSpace); > - Status = MmspWaitForPageOpCompletionEvent(PageOp); > - if (Status != STATUS_SUCCESS) > - { > - DPRINT1("Failed to wait for page op, status = %x\n", > Status); > - KeBugCheck(MEMORY_MANAGEMENT); > - } > - MmLockAddressSpace(AddressSpace); > - MmspCompleteAndReleasePageOp(PageOp); > - MemoryArea = MmLocateMemoryAreaByAddress(AddressSpace, > - BaseAddress); > - if (MemoryArea == NULL || > - MemoryArea->Type != MEMORY_AREA_SECTION_VIEW) > - { > - MmUnlockAddressSpace(AddressSpace); > - return STATUS_NOT_MAPPED_VIEW; > - } > - break; > - } > - } > - } > > Section = MemoryArea->Data.SectionData.Section; > > > >

2 1

mail
by none ofyourbussines 27 Apr '12

27 Apr '12

To project admin: My email you said post was annoying The I looked at email records I was not online then it w as job of a hacker but it is fixed now

4 3

Monthly meeting - April 2012
by Aleksey Bragin 27 Apr '12

27 Apr '12

Hello, Let me invite you to the monthly status meeting taking place last Thursday of this month, 26th of April, 19:00 UTC. The meeting will be at irc://fezile.reactos.org (Port 6667, no SSL) in the channel #meeting. Note that the IRC service will only be started shortly before the meeting. Your participation passwords will be emailed to you shortly before the meeting starts. If someone still is not getting passwords sent before a meeting - please email Colin or Pierre before the meeting started to get one. In order to save time, let's choose who is going to be the minute taker on the upcoming meeting. Volunteers welcome. An agenda for the meeting will be posted when the meeting starts. Please email me your suggestions before the meeting so that the resulting agenda could be compiled beforehand. With the best regards, Aleksey Bragin.

9 13

April 2012 Meeting Minutes
by Amine Khaldi 27 Apr '12

27 Apr '12

April 2012 Meeting Minutes 2012-04-26 19:00 UTC Fezile, #meeting Proceedings =========== * Meeting started at 19:20 UTC by Amine Khaldi. * Point 1: The state of Trunk ----------------------------- * Amine Khaldi mentioned that we still have several regressions to get fixed. Olaf Siejka stressed the fact that developers should actually look into these regressions and fix them, and wondered about the optimal selection process to ensure this. * Timo Kreuzer suggested that we should assign these regressions, to increase the possibility of having them fixed. He explained that the selection should be by the guilty revision first (the revision that triggers the regression), and the author of that revision should at least take a look, and if it's *really* not his fault and he can't fix it, then he can assign it back to ros-bugs. * Amine Khaldi mentioned that at the moment there is no way to know what developers are working on exactly, until they commit, and suggested using bug reports to document the development, so that commits will mention them at the end. * Amine also suggested the following process for the regressions: We assign those regressions to the author of the guilty revision, the developer investigates the regression. If he's able to fix the bug, he changes the bug status to "Assigned" which means he now owns this bug. If he can't fix it, he will document his finding so far (a comment in the bug report) and he assigns the bug to any other developer that he thinks he can fix this, and so on. * Everyone agreed, as a result, that we should assign regressions, and that developers should look at what's assigned to them. * Point 2: Overview of the Atlassian tools ------------------------------------------ * Amine Khaldi gave an overview of what we plan to do with Atlassian products (Jira, FishEye, Crucible, Bamboo..etc) in case people didn't go to their website to read about them and watch their videos (http://www.atlassian.com/). * Olaf Siejka asked about an ETA for the Atlassian tools adoption. Aleksey Bragin mentioned that this will happen in the coming two weeks. * Point 3: Discussing a possible change in the release cycle ------------------------------------------------------------ * Alexander Rechitskiy presented some links from the KDE project about their svn guidelines, commit policy, release schedule, minor point releases...etc. * After a lengthy discussion, the team decided to continue the already started efforts to improve efficiency and minimize regressions (like leveraging Patchbot, the recent major Testman improvements...etc). * Meeting closed at 21:26 UTC by Amine Khaldi. * Minutes written by Amine Khaldi.

1 0

2nd Boot Regional Settings Crash
by James Tabor 27 Apr '12

27 Apr '12

Hi! Did anyone notices this? I think someone on IRC tried to point this out to me..... Tested: rundll32.exe shell32.dll,Control_RunDLL input.dll from the cmd line and it works. user32/windows/message.c:1441) CallWindowProcW Unicode Failed! Msg 273 WndProc 71C25AC8 Entered debugger on first-chance exception (Exception Code: 0xc0000005) (Page Fault) Memory at 0x71C2D810 could not be written: Page protection violation. kdb:> bt Eip: <kernel32.dll:ea7f> client/proc.c:2709 (CreateProcessInternalW@48) Frames: <kernel32.dll:fbd8> client/proc.c:3299 (CreateProcessW@40) <syssetup.DLL:4a9c> syssetup/wizard.c:837 (RunControlPanelApplet) <syssetup.DLL:5c4e> syssetup/wizard.c:914 (LocalePageDlgProc@16) RunControlPanelApplet(hwndDlg, L"rundll32.exe shell32.dll,Control_RunDLL input.dll,@1"); <user32.dll:4dfdc> windows/message.c:1407 (@IntCallWindowProcW@28) <user32.dll:4fd7e> windows/message.c:1747 (CallWindowProcW@20) <user32.dll:36184> windows/dialog.c:1701 (DefDlgProcW@16) <user32.dll:4dfdc> windows/message.c:1407 (@IntCallWindowProcW@28) <user32.dll:4e735> windows/message.c:1667 (IntCallMessageProc@24) <user32.dll:4ea2f> windows/message.c:2266 (SendMessageW@16) <user32.dll:3b57> controls/button.c:424 (ButtonWndProc_common@20) <user32.dll:42a2> controls/button.c:612 (ButtonWndProcW@16) <user32.dll:4dfdc> windows/message.c:1407 (@IntCallWindowProcW@28) <user32.dll:4e735> windows/message.c:1667 (IntCallMessageProc@24) <user32.dll:4fa2b> windows/message.c:1916 (DispatchMessageW@4) <user32.dll:35a65> windows/dialog.c:2591 (IsDialogMessageW@8) <syssetup.DLL:6612> syssetup/wizard.c:2408 (InstallWizard) <syssetup.DLL:2448> syssetup/install.c:957 (InstallReactOS@4) <setup.exe:10cc> <setup.exe:21dc> <setup.exe:149b>--- Press q to abort, any other key to continue --- <setup.exe:14fd> <kernel32.dll:fc4a> <00000000>

2 1

Re: [ros-dev] [ros-diffs] [tkreuzer] 56356: [NTOSKRNL] Fix SepGet*FromDescriptor, returning NULL, when the relative offset is 0. Fixes VMware tools installer.
by Ged Murphy 18 Apr '12

18 Apr '12

> Author: tkreuzer > [NTOSKRNL] > Fix SepGet*FromDescriptor, returning NULL, when the relative offset is 0. > Fixes VMware tools installer. Someone buy that man a beer!

4 3

Does CMake take longer than rbuild
by Marvin Zhang 13 Apr '12

13 Apr '12

Hi guys, I have compiled the whole project and just want to copy ntoskrnl. Here is what I execute: --------------------------------------------------------------------- D:\ReactOS\src\ReactOS-0.3.14-CLT2012>make ntoskrnl_install [COPY] Z:\ReactOS\system32\ntoskrnl.exe Total Build Time: 00:02:04 --------------------------------------------------------------------- I don't know why it takes more than 2 minutes. Is it correct? Thanks.

4 5

The ReactOS Foundation takes part in the IPv6 Launch Day
by Pierre Schweitzer 11 Apr '12

11 Apr '12

Hi, this year, the 6th of June will be once again a special day. This will be the one, the Internet Society has chosen to launch IPv6: http://www.worldipv6launch.org/. It means that starting with this day, all the participant will enable IPv6 and provide it the days, months, years after. The ReactOS Foundation will take part in this event. Currently some services and servers are already available in IPv6, but are not fully maintained. Starting with the 6th of June, major ReactOS services and servers will be available for everybody with IPv6. A roadmap for IPv6 deployment can be found on the ReactOS wiki at: https://www.reactos.org/wiki/IPv6. You will be able to follow all the progress with IPv6. This means that after the 6th of June, any ReactOS developer will be able to work with an IPv6 only on our infrastructure. The transition will be done smoothly. With my best regards, -- Pierre Schweitzer <pierre(a)reactos.org> Systems Administrator ReactOS Foundation

1 0

I'd like to hear about your plans for 0.4.0
by Brent Newland 07 Apr '12

07 Apr '12

I've posted a topic on the Forums to discuss the roadmap to 0.4.0 (whatever it may be). ReactOS has been on the 0.3.x branch for almost six years, and there's been talk of 0.4, so I'd like to hear from any developers on what plans or goals you might have for 0.4.0, whenever it comes out (within 1-2 years?) If you don't currently have any concrete goals or plans (which I've heard is a possibility), then perhaps it would be a good time to start a dialog between developers and the community so we can start to get an idea of what your (ReactOS) expectations are, and what's in store. http://www.reactos.org/forum/viewtopic.php?f=2&t=11114 It could also give you something to point people to when people ask about 0.4.

2 1

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev