- Ros-dev - ReactOS.org

Re: [ros-dev] iso.reactos.org migrated to new server
by hermes.belusca＠sfr.fr 05 Dec '18

05 Dec '18

<span style="font-family:arial,helvetica,sans-serif; font-size:12px">‌</span>Hi,<br> <br> In case this happens to be indeed a problem, the additional stuff to add to the build scripts would be to upload these bootcdregtest ISOs to iso.reactos.org, while using now the local copy on the build machine network.<br> <br> Best,<br> Hermes <div class="gl_quote" style="margin-top: 20px; padding-top: 5px;">De : "Colin Finck"<br> A : "'ReactOS Development List'"<br> Envoyé: mercredi 5 décembre 2018 20:01<br> Objet : [ros-dev] iso.reactos.org migrated to new server<br>   <div class="gl_quoted">Hi all!<br> <br> iso.reactos.org, the file server used by our build machines and the<br> source for https://reactos.org/getbuilds, has been migrated to new<br> hardware at a different location today.<br> <br> You should experience better transfer rates due to the increased<br> bandwidth, and a higher availability. The new hardware also offers more<br> disk space and redundancy to keep our precious ISOs absolutely safe :)<br> <br> Unfortunately, the new iso.reactos.org is no longer right next to the<br> build machines. This has several consequences: If I had left the build<br> scripts as-is, the build machines would have uploaded the bootcdregtest<br> ISOs to iso.reactos.org, just to download them multiple times for each<br> Testbot a minute later. This would be an excessive waste of ISP<br> bandwidth and would have delayed the entire testing process.<br> Therefore, I changed the build scripts to keep the bootcdregtest ISOs<br> within the local build machine network. However, the downside is that<br> bootcdregtest ISOs are no longer available via iso.reactos.org.<br> <br> Please let me know if this is a problem for you and needs a solution.<br> In the past, bootcdregtest ISOs were only available for a week and not<br> accessible via GetBuilds either, so I have no idea how popular they are.<br> <br> <br> Cheers,<br> <br> Colin<br> <br> _______________________________________________ Ros-dev mailing list Ros-dev(a)reactos.org http://reactos.org/mailman/listinfo/ros-dev</div> <div class="gl_quoted"> </div> </div>

1 0

"[shell32] Shell dialog issues" .- CORE-10481
by Javier Agustìn Fernàndez Arroyo 02 Dec '18

02 Dec '18

Are you sure its better to follow Win behavior on this? I think its a enhancement, specially if there are many open windows at a given time.... it saves time!

4 4

ReactOS 0.5 Planning
by Colin Finck 30 Nov '18

30 Nov '18

Hi all! Planning the ReactOS 0.5 release and establishing a new roadmap was one of the points on the agenda of yesterday's meeting. This is still an ongoing process. Please make up your minds about what a ReactOS 0.5 release must offer in your opinion and write it down to https://reactos.org/wiki/0.5.0 To get a realistic roadmap, it is important that we define a responsible person for each task. It should be the person having the most in-depth knowledge about the status of the affected ReactOS components. Don't worry, we won't put any pressure on you to complete the task soon. But we need someone who can give a detailed report about the current status. If nobody can be the responsible person for a certain task, having it for 0.5 is not realistic and it eventually needs to be removed from the roadmap. But that's for later! Let's first add all points we consider important until the end of the year. If you can already add yourself as the responsible person, even better! :) Cheers, Colin

5 4

Google Summer of Code 2019
by Colin Finck 29 Nov '18

29 Nov '18

Hi all! While there is still some time until the February 6, 2019 application deadline for projects, we should already begin planning our GSoC participation now! As today's meeting already has a long agenda, I delibereately didn't add GSoC to it. But I've already created https://reactos.org/wiki/Google_Summer_of_Code_2019 and https://reactos.org/wiki/Google_Summer_of_Code_2019_Ideas Please decide whether you want to be a GSoC org admin or mentor and add your ideas to the list or remove deprecated ones. My experience from the Mentor Summit tells me that proper planning and advertising can make a huge difference for our 2019 participation and will certainly get us more students :) Cheers, Colin

4 3

Re: [ros-dev] Status Meeting (November 2018)
by Can Tasan 29 Nov '18

29 Nov '18

While there's a discussion of 0.5 release plan, here are some candidate topics: * MM/CC work, to reduce BSoDs and enable further development * PNP work. vgal has done some work on both HAL and PNP to fix device issues. Also many Windows Server 2003 drivers are usable now. Progressing this and finally integrating into ReactOS is essential at some point. * Driver issues * System corruption after hard resets or BSoDs * Further Win32 work to get many programs usable (I can extensively test Word 2003 if there's help!) * Getting rid of old fastfat (and progressing NTFS further?) * Robust networking (adding WPA support, fixing bugs...) * Installer support for old programs and WoW16 (there's two resources: Win3mu is now open-source and otya128's winevdm) * Further DirectX work (or just syncs from Wine) and some video work to get more games playable? * Sound? * And other things you add or I forgot. Best regards, Can

1 0

Status Meeting (November 2018)
by Colin Finck 29 Nov '18

29 Nov '18

Hi all! Let me invite you to the November 2018 meeting, taking place next Thursday, November 29, 2018 at 19:00 UTC. Invited members will again receive their credentials shortly before the meeting. This will be the first meeting since August and I hope we get some more topics than just the obligatory Status Reports. Please send your proposals by replying to this mail. Best regards, Colin

5 9

Re: [ros-dev] Status Meeting (November 2018)
by Serge Gautherie 29 Nov '18

29 Nov '18

On 29/11/2018 00:35, Thomas Mueller wrote: > My hard drives are all partitioned GPT, and lack of support for USB and GPT has kept me away from doing anything regarding ReactOS. Where would I put it? Meantime solution: in a virtual machine. --

1 0

Re: [ros-dev] Status Meeting (November 2018)
by hermes.belusca＠sfr.fr 28 Nov '18

28 Nov '18

<span style="font-family:arial,helvetica,sans-serif; font-size:12px">‌</span>Hi!<br> <br> Usually when we talk about ReactOS 0.5, we implicitly think that it will enter beta state there.<br> So unless you consider this to not completely hold anymore, we can look at what remains to be done/fixed (importantly) so that we may qualify as going into beta state.<br> (And yes, USB and storage sound strongly as prerequisites for 0.5 in my opinion).<br> <br> Best,<br> Hermes <div class="gl_quote" style="margin-top: 20px; padding-top: 5px;">De : "Ged Murphy"<br> A : "'ReactOS Development List'"<br> Envoyé: mercredi 28 novembre 2018 17:42<br> Objet : Re: [ros-dev] Status Meeting (November 2018)<br>   <div class="gl_quoted"><meta http-equiv="Content-Type" content="text/html; charset=utf-8"><meta name="Generator" content="Microsoft Word 15 (filtered medium)"> <style type="text/css"> </style>  <div class="WordSection1"> <p class="MsoNormal"><span style="mso-fareast-language:EN-US">Some potential talking points:</span></p> <p class="MsoNormal"><span style="mso-fareast-language:EN-US"> </span></p> <ul style="margin-top:0cm" type="disc"> <li class="MsoListParagraph" style="margin-left:0cm;mso-list:l0 level1 lfo1"><span style="mso-fareast-language:EN-US">Selecting a new coordinator</span></li> <li class="MsoListParagraph" style="margin-left:0cm;mso-list:l0 level1 lfo1"><span style="mso-fareast-language:EN-US">Version bump to 0.5</span></li> <li class="MsoListParagraph" style="margin-left:0cm;mso-list:l0 level1 lfo1"><span style="mso-fareast-language:EN-US">USB / Storage (perhaps linked to a 0.5 release)</span></li> <li class="MsoListParagraph" style="margin-left:0cm;mso-list:l0 level1 lfo1"><span style="mso-fareast-language:EN-US">Mattermost</span></li> <li class="MsoListParagraph" style="margin-left:0cm;mso-list:l0 level1 lfo1"><span style="mso-fareast-language:EN-US">New website progress</span></li> </ul> <p class="MsoNormal"><span style="mso-fareast-language:EN-US"> </span></p> <p class="MsoNormal"><span style="mso-fareast-language:EN-US"> </span></p> <p class="MsoNormal"><strong><span lang="EN-US">From:</span></strong><span lang="EN-US"> Ros-dev <ros-dev-bounces(a)reactos.org> <strong>On Behalf Of </strong>Mark Jansen<br> <strong>Sent:</strong> Wednesday, 28 November 2018 16:13<br> <strong>To:</strong> ReactOS Development List <ros-dev(a)reactos.org><br> <strong>Subject:</strong> Re: [ros-dev] Status Meeting (November 2018)</span></p> <p class="MsoNormal"> </p> <div> <div> <p class="MsoNormal">We can discuss this if you are present, but I don't see the value in discussing it without you.</p> </div> <div> <p class="MsoNormal">We have seen before that something discussed without the initiator being present is time not well spent, since it is a bit hard to argue with only one side of the argument present</p> </div> <div> <p class="MsoNormal"> </p> </div> <div> <p class="MsoNormal"> </p> </div> </div> <div> <p class="MsoNormal"> </p> <div> <p class="MsoNormal">Op 26 nov. 2018 12:15 schreef <a href="mailto:hermes.belusca@sfr.fr">hermes.belusca(a)sfr.fr</a>:</p> <blockquote style="border:none;border-left:solid #CCCCCC 1.0pt;padding:0cm 0cm 0cm 6.0pt;margin-left:4.8pt;margin-right:0cm"> <p class="MsoNormal">Hello,<br> <br> I may not be available as it's the day when I'm going somewhere for a conference; it just depends at which time I arrive at destination.<br> <br> For the meeting we may talk about the best way we can move to delivering all-in-one ReactOS ISOs (containing livecd + installation in both text and GUI modes), and which changes this could imply for our infrastructure (buildbots/website...).<br> <br> Best regards,<br> Hermes</p> <div style="margin-top:15.0pt"> <p class="MsoNormal">De : "Javier Agustìn Fernàndez Arroyo"<br> A : "ReactOS Development List"<br> Envoyé: samedi 24 novembre 2018 22:06<br> Objet : Re: [ros-dev] Status Meeting (November 2018)<br>  </p> <div> <div> <p class="MsoNormal">I'm at work but I will do my best to attend!</p> </div> <p class="MsoNormal"> </p> <div> <div> <p class="MsoNormal">El sáb., 24 nov. 2018 21:38, Colin Finck <<a href="mailto:colin@reactos.org">colin(a)reactos.org</a>> escribió:</p> </div> <blockquote style="border:none;border-left:solid #CCCCCC 1.0pt;padding:0cm 0cm 0cm 6.0pt;margin-left:4.8pt;margin-right:0cm"> <p class="MsoNormal">Hi all!<br> <br> Let me invite you to the November 2018 meeting, taking place next<br> Thursday, November 29, 2018 at 19:00 UTC.<br> Invited members will again receive their credentials shortly before the<br> meeting.<br> <br> This will be the first meeting since August and I hope we get some more<br> topics than just the obligatory Status Reports. Please send your<br> proposals by replying to this mail.<br> <br> <br> Best regards,<br> <br> Colin<br> <br> _______________________________________________<br> Ros-dev mailing list<br> <a href="mailto:Ros-dev@reactos.org">Ros-dev(a)reactos.org</a><br> <a href="http://reactos.org/mailman/listinfo/ros-dev">http://reactos.org/mailman/listinfo/ros-dev</a></p> </blockquote> </div> <p class="MsoNormal"><br> <br> <br> _______________________________________________<br> Ros-dev mailing list<br> <a href="mailto:Ros-dev@reactos.org">Ros-dev(a)reactos.org</a><br> <a href="http://reactos.org/mailman/listinfo/ros-dev">http://reactos.org/mailman/listinfo/ros-dev</a></p> </div> <div> <p class="MsoNormal"> </p> </div> </div> </blockquote> </div> <p class="MsoNormal"> </p> </div> </div> <br> <br> <br> _______________________________________________<br> Ros-dev mailing list<br> Ros-dev(a)reactos.org<br> http://reactos.org/mailman/listinfo/ros-dev</div> <div class="gl_quoted"> </div> </div>

6 5

Re: [ros-dev] Status Meeting (November 2018)
by hermes.belusca＠sfr.fr 28 Nov '18

28 Nov '18

Hello,<br> <br> I may not be available as it's the day when I'm going somewhere for a conference; it just depends at which time I arrive at destination.<br> <br> For the meeting we may talk about the best way we can move to delivering all-in-one ReactOS ISOs (containing livecd + installation in both text and GUI modes), and which changes this could imply for our infrastructure (buildbots/website...).<br> <br> Best regards,<br> Hermes <div class="gl_quote" style="margin-top: 20px; padding-top: 5px;">De : "Javier Agustìn Fernàndez Arroyo"<br> A : "ReactOS Development List"<br> Envoyé: samedi 24 novembre 2018 22:06<br> Objet : Re: [ros-dev] Status Meeting (November 2018)<br>   <div class="gl_quoted"> <div dir="auto">I'm at work but I will do my best to attend!</div>   <div class="gmail_quote"> <div dir="ltr">El sáb., 24 nov. 2018 21:38, Colin Finck <<a href="mailto:colin@reactos.org">colin(a)reactos.org</a>> escribió:</div> <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi all!<br> <br> Let me invite you to the November 2018 meeting, taking place next<br> Thursday, November 29, 2018 at 19:00 UTC.<br> Invited members will again receive their credentials shortly before the<br> meeting.<br> <br> This will be the first meeting since August and I hope we get some more<br> topics than just the obligatory Status Reports. Please send your<br> proposals by replying to this mail.<br> <br> <br> Best regards,<br> <br> Colin<br> <br> _______________________________________________<br> Ros-dev mailing list<br> <a href="mailto:Ros-dev@reactos.org" rel="noreferrer" target="_blank">Ros-dev(a)reactos.org</a><br> <a href="http://reactos.org/mailman/listinfo/ros-dev" rel="noreferrer noreferrer" target="_blank">http://reactos.org/mailman/listinfo/ros-dev</a></blockquote> </div> <br> <br> <br> _______________________________________________<br> Ros-dev mailing list<br> Ros-dev(a)reactos.org<br> http://reactos.org/mailman/listinfo/ros-dev</div> <div class="gl_quoted"> </div> </div>

4 3

Website and JIRA Migration on Friday
by Colin Finck 23 Nov '18

23 Nov '18

Hi all, Our last 3 servers are finally being migrated on Friday morning (UTC). Expect downtimes for the following services during this period: * https://reactos.org * https://jira.reactos.org * https://lam.reactos.org As always, I will try my best to keep the downtimes low and let you know when everything is over. Best regards, Colin Finck

1 1

Git/SVN Server migrated
by Colin Finck 20 Nov '18

20 Nov '18

Hi all! Another server has been migrated to new hardware and software today! I'm talking about our Git/SVN Server, which also serves BuildBot, Doxygen, download.reactos.org, etc. The anticipated and actual downtime has been so low again that I didn't even have to announce the migration in advance. Some remarks though: * If you had file server upload access to svn.reactos.org *and still need it*, please let me know and I can recreate your account. Have your SSH public key ready. Note that I plan to set up an easier and more official file sharing service for ReactOS soon. * For obvious reasons, the Mumble server at mumble.reactos.org has not been migrated and is now officially shut down. I'm looking forward to finally set up the Mattermost instance once all existing VMs have been migrated (5 done, 3 to go). * git.reactos.org is no longer accessible via the git:// protocol. If you have any URLs using that, please change them to https://. Cheers, Colin

1 0

Re: [ros-dev] [ros-diffs] 03/03: [OLE32] The CoDisconnectContext() stub added in 6a2f9673 (PR #1044) is actually Vista+. Caught by Thomas Faber.
by Pierre Schweitzer 18 Nov '18

18 Nov '18

I'm not sure I understand this commit, nor the PR that was merged before. This is a synced module, for a Vista+ export... What's the point of this? It would have been better to sync with Wine and have this patch upstream. Le 18/11/2018 à 21:03, Hermès Bélusca-Maïto a écrit : > https://git.reactos.org/?p=reactos.git;a=commitdiff;h=2d320f5a8daf4627458e8… > > commit 2d320f5a8daf4627458e81f0ffd51bdd8f60d120 > Author: Hermès Bélusca-Maïto <hermes.belusca-maito(a)reactos.org> > AuthorDate: Sun Nov 18 21:05:32 2018 +0100 > Commit: Hermès Bélusca-Maïto <hermes.belusca-maito(a)reactos.org> > CommitDate: Sun Nov 18 21:06:22 2018 +0100 > > [OLE32] The CoDisconnectContext() stub added in 6a2f9673 (PR #1044) is actually Vista+. Caught by Thomas Faber. > --- > dll/win32/ole32/ole32.spec | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/dll/win32/ole32/ole32.spec b/dll/win32/ole32/ole32.spec > index d4ed1163d4..97667918e9 100644 > --- a/dll/win32/ole32/ole32.spec > +++ b/dll/win32/ole32/ole32.spec > @@ -23,7 +23,7 @@ > # CoCreateObjectInContext > # CoDeactivateObject > @ stdcall -stub CoDisableCallCancellation(ptr) > -@ stdcall -stub CoDisconnectContext(long) > +@ stdcall -stub -version=0x600+ CoDisconnectContext(long) > @ stdcall CoDisconnectObject(ptr long) > @ stdcall CoDosDateTimeToFileTime(long long ptr) kernel32.DosDateTimeToFileTime > @ stdcall -stub CoEnableCallCancellation(ptr) > -- Pierre Schweitzer <pierre at reactos.org> System & Network Administrator Senior Kernel Developer ReactOS Deutschland e.V.

1 0

Last SVN repo finally converted to Git
by Colin Finck 16 Nov '18

16 Nov '18

Hi all! Having converted the last ReactOS SVN repository (press-media) to Git today, we can finally call the entire Git migration done :) Well, probably it felt done for you for a long time, but I still struggled with that last repository until today. As I'm also about to migrate the Git/SVN server soon, I can finally tell you about the long-term availability of the old SVN repositories: * Access to svn.reactos.org over the svn:// protocol will soon be suspended. * Read-only access to the press-media, project-tools, reactos, and web SVN repositories at https://svn.reactos.org will be maintained. This allows you to continue looking up old SVN history whenever Git's log has problems tracking a file move. * Access to ViewVC at https://svn.reactos.org/svn and https://svn.reactos.org/viewcvs will be suspended as well. One less tool for us to maintain. Of course, I will again let you know when the actual migration is happening (or already over :)). Cheers, Colin

1 0

no replies about making reactos accessible for the blind
by Dick 15 Nov '18

15 Nov '18

Hi, I did not receive anny replies about my question to make reactos accessible for the blind. I would really suggest to do that while building the os, instead of doign it when the whole system is fully built.

6 21

Mail server downtime tomorrow
by Colin Finck 14 Nov '18

14 Nov '18

Hi all! Our mail server will be shut down for migration TOMORROW, WEDNESDAY, NOVEMBER 14, AROUND 9:00 UTC This will result in a temporary downtime for the following services: * @reactos.org E-Mail addresses * Mailing lists * https://iserv.reactos.org The migration has already been prepared and simulated, so I expect the downtime to be low and the entire process to only take a few minutes. I will let you know when everything is back up again. We look forward to improve the performance, reliability, and especially maintainability through this migration. This probably just sounds like a pile of buzzwords to you, but there are hardly other words to describe a move from HDDs to SSDs, data replication on even more disks, and gaining independence from a single hypervisor hardware ;) Cheers, Colin

1 1

Duplicated include in reactos/base/shell/filebrowser/filebrowser.c
by Manuel Oppermann 13 Nov '18

13 Nov '18

1 0

Distinguish between Windows and ReactOS
by Nick Surfer 06 Nov '18

06 Nov '18

Hello all. Sorry if this mail is off topic of the mail-list, but am not sure which one is right for my question. I am writing a program which needs to know exact environment in which it is running. In case of Windows I simply use GetVersionEx and then analyze dwMajorVersion + dwMinorVersion which is enough for my case (then I know which WIN API calls I should use). But I stuck how to recognize that my program runs in ReactOS. I failed to find any docs about it. Any help is appreciated. P.S. I am not well experienced in WIN API, so if someone gives me an example it will be great.

3 3

reactos & debug mode issue
by Javier Agustìn Fernàndez Arroyo 06 Nov '18

06 Nov '18

Hello all, I have just noticed that ReactOS, when in debug configuration, will only boot if an output console is set up. Won't boot if minicom (for example) is not running... Is that expected?

2 1

reports about Win7+ apps
by Javier Agustìn Fernàndez Arroyo 05 Nov '18

05 Nov '18

hello all, im planning to use ReactOS at a foundation here in Madrid, which is dedicated to people with intellectual disabilities he point is, they are using mostly Windows 10, so they are using Win10 apps are bug reports about Win10 apps acceptable?

3 5

ReactOS 0.4.10 to be released tomorrow, November 6, 2018 - Press Kit is online!
by Colin Finck 05 Nov '18

05 Nov '18

Hi all! ReactOS 0.4.10 will be released tomorrow, Tuesday, November 6, 2018! The download will be officially available around noon (CEST). A Press Kit for the ReactOS 0.4.10 release is already available: https://download.reactos.org/reactos/ReactOS/0.4.10/ReactOS-0.4.10-PressKit… Feel free to send it to interested parties to let them know about the upcoming release in advance. Best regards, Colin Finck

1 0

nvda and reactos
by Dick 30 Oct '18

30 Oct '18

Hi, I think it would be much better to implement accessibillity for visualy impared people when building an os, than having to find ways to make that possible when everything is built and running. Nvda is a good opensource screenreader for windows The only big problem is, it heavily depends on msaa and iaccessible which will not be included in reactos i suppose. So: what would be the way to make this os accessible for the blind? I am not a programmer at all so maybe i say stupid things. The most simple way i could think of is, creating a textmode environment. In this case i do not mean just a command prompt, like dos, but the full functions but without graphical interface(like the browser browsh, www.brow.sh) can do using a headless-firefox to open pages without needing anny graphical interface(in monochrome mode it displays just text, but is able to stream youtube/everything firefox can handle). If something like that can be created in reactos, the only thing needed is to make the windows binaries of brltty work and much of the accessibility would be ready to use, as long as every graphic element is banned from the screen otherwise blrtty will display just lines with ??????????????? on the braille display. I am curious to know if some things can be done to make reactos accesible for the blind. best regards, Dick

1 0

DbgCom release note.
by Neo Love 30 Oct '18

30 Oct '18

Greetings fellow developers... After a rather long hiatus (I actually came close to death), I went back to the DbgCom source and merged some improvements that are now in the RosIDE I'm working on. Most notably a Preferences settings dialog, but also some improved performance in the message list painting, and various bug fixes. The first time you run DbgCom, be sure to execute the Preferences dialog, and Ok the settings, so they get stored in the registry. I will make the source dependencies available shortly, they just need to be cleaned up a bit, since there is currently some hackery in there that I don't want to publish. I'll notify you on the ROSBE-100 page. You'll find DbgCom here: https://jira.reactos.org/browse/ROSBE-100 Well, that's it I guess. Best Regards / Love

1 0

Pen width support
by katahiromz 29 Oct '18

29 Oct '18

Can somebody read this codes? https://gist.github.com/katahiromz/36f7135d3afe9fe6d2b7b28816be0f30 Thanks. katahiromz

1 0

Re: [ros-dev] [ros-diffs] 03/04: [KERNEL32] Directly use UnhandledExceptionFilter in BaseProcessStartup
by Alex Ionescu 28 Oct '18

28 Oct '18

Same here! This will break things. We should not be overriding the proper handling of the exception filters. Best regards, Alex Ionescu On Sun, Oct 28, 2018 at 9:03 AM Mark Jansen <mark.jansen(a)reactos.org> wrote: > > https://git.reactos.org/?p=reactos.git;a=commitdiff;h=824e5dba51aca08204045… > > commit 824e5dba51aca08204045e440be9c253a8469ac2 > Author: Mark Jansen <mark.jansen(a)reactos.org> > AuthorDate: Sat Oct 20 15:38:21 2018 +0200 > Commit: Mark Jansen <mark.jansen(a)reactos.org> > CommitDate: Sun Oct 28 13:01:38 2018 +0100 > > [KERNEL32] Directly use UnhandledExceptionFilter in BaseProcessStartup > --- > dll/win32/kernel32/client/proc.c | 29 +---------------------------- > 1 file changed, 1 insertion(+), 28 deletions(-) > > diff --git a/dll/win32/kernel32/client/proc.c > b/dll/win32/kernel32/client/proc.c > index dbd5c10d0f..f36219457b 100644 > --- a/dll/win32/kernel32/client/proc.c > +++ b/dll/win32/kernel32/client/proc.c > @@ -445,33 +445,6 @@ BasepSxsCloseHandles(IN PBASE_MSG_SXS_HANDLES Handles) > } > } > > -static > -LONG BaseExceptionFilter(EXCEPTION_POINTERS *ExceptionInfo) > -{ > - LONG ExceptionDisposition = EXCEPTION_EXECUTE_HANDLER; > - LPTOP_LEVEL_EXCEPTION_FILTER RealFilter; > - RealFilter = RtlDecodePointer(GlobalTopLevelExceptionFilter); > - > - if (RealFilter != NULL) > - { > - _SEH2_TRY > - { > - ExceptionDisposition = RealFilter(ExceptionInfo); > - } > - _SEH2_EXCEPT(EXCEPTION_EXECUTE_HANDLER) > - { > - } > - _SEH2_END; > - } > - if ((ExceptionDisposition == EXCEPTION_CONTINUE_SEARCH || > ExceptionDisposition == EXCEPTION_EXECUTE_HANDLER) && > - RealFilter != UnhandledExceptionFilter) > - { > - ExceptionDisposition = UnhandledExceptionFilter(ExceptionInfo); > - } > - > - return ExceptionDisposition; > -} > - > VOID > WINAPI > BaseProcessStartup(PPROCESS_START_ROUTINE lpStartAddress) > @@ -489,7 +462,7 @@ BaseProcessStartup(PPROCESS_START_ROUTINE > lpStartAddress) > /* Call the Start Routine */ > ExitThread(lpStartAddress()); > } > - _SEH2_EXCEPT(BaseExceptionFilter(_SEH2_GetExceptionInformation())) > + > _SEH2_EXCEPT(UnhandledExceptionFilter(_SEH2_GetExceptionInformation())) > { > /* Get the Exit code from the SEH Handler */ > if (!BaseRunningInServerProcess) > >

1 0

Re: [ros-dev] [ros-diffs] 02/04: [KERNEL32] Use the default UnhandledExceptionFilter in BaseThreadStartup. This should allow unhandled exceptions in a thread to trigger our crash reporter, instead of killing the process directly.
by Alex Ionescu 28 Oct '18

28 Oct '18

Uhh, this change is not correct. It overrides the proper handling of exception filtering -- please revert. Best regards, Alex Ionescu On Sun, Oct 28, 2018 at 9:03 AM Mark Jansen <mark.jansen(a)reactos.org> wrote: > > https://git.reactos.org/?p=reactos.git;a=commitdiff;h=40549483f60aa00e9fc95… > > commit 40549483f60aa00e9fc952ba831027028f6df107 > Author: Mark Jansen <mark.jansen(a)reactos.org> > AuthorDate: Thu Oct 18 22:07:37 2018 +0200 > Commit: Mark Jansen <mark.jansen(a)reactos.org> > CommitDate: Sun Oct 28 13:01:38 2018 +0100 > > [KERNEL32] Use the default UnhandledExceptionFilter in > BaseThreadStartup. > This should allow unhandled exceptions in a thread to trigger our > crash reporter, > instead of killing the process directly. > --- > dll/win32/kernel32/client/thread.c | 25 +------------------------ > 1 file changed, 1 insertion(+), 24 deletions(-) > > diff --git a/dll/win32/kernel32/client/thread.c > b/dll/win32/kernel32/client/thread.c > index 8fc5a7ad61..2ff0102483 100644 > --- a/dll/win32/kernel32/client/thread.c > +++ b/dll/win32/kernel32/client/thread.c > @@ -26,29 +26,6 @@ BasepNotifyCsrOfThread(IN HANDLE ThreadHandle, > > /* FUNCTIONS > ******************************************************************/ > > -static > -LONG BaseThreadExceptionFilter(EXCEPTION_POINTERS * ExceptionInfo) > -{ > - LONG ExceptionDisposition = EXCEPTION_EXECUTE_HANDLER; > - LPTOP_LEVEL_EXCEPTION_FILTER RealFilter; > - > - RealFilter = RtlDecodePointer(GlobalTopLevelExceptionFilter); > - if (RealFilter != NULL) > - { > - _SEH2_TRY > - { > - ExceptionDisposition = RealFilter(ExceptionInfo); > - } > - _SEH2_EXCEPT(EXCEPTION_EXECUTE_HANDLER) > - { > - ExceptionDisposition = > UnhandledExceptionFilter(ExceptionInfo); > - } > - _SEH2_END; > - } > - > - return ExceptionDisposition; > -} > - > __declspec(noreturn) > VOID > WINAPI > @@ -68,7 +45,7 @@ BaseThreadStartup(IN LPTHREAD_START_ROUTINE > lpStartAddress, > /* Get the exit code from the Thread Start */ > ExitThread((lpStartAddress)((PVOID)lpParameter)); > } > - > _SEH2_EXCEPT(BaseThreadExceptionFilter(_SEH2_GetExceptionInformation())) > + > _SEH2_EXCEPT(UnhandledExceptionFilter(_SEH2_GetExceptionInformation())) > { > /* Get the Exit code from the SEH Handler */ > if (!BaseRunningInServerProcess) > >

1 0

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev