- Ros-dev - ReactOS.org

Re: [ros-dev] [ros-diffs] [tkreuzer] 53695: [HAL] Implement lazy irql for APIC. This is useful for VMs, since APIC usually has high overhead due to the need of invoking the hypervisor on every irql raise and lower. With laz...

by Alex Ionescu

http://blogs.technet.com/b/askperf/archive/2010/07/23/windows-xp-guests-exh… Windows does have APIC Lazy IRQL, Microsoft are not idiots. Best regards, Alex Ionescu On Mon, Sep 12, 2011 at 2:46 AM, <tkreuzer(a)svn.reactos.org> wrote: > Author: tkreuzer > Date: Mon Sep 12 09:46:20 2011 > New Revision: 53695 > > URL: http://svn.reactos.org/svn/reactos?rev=53695&view=rev > Log: > [HAL] > Implement lazy irql for APIC. This is useful for VMs, since APIC usually > has high overhead due to the need of invoking the hypervisor on every irql > raise and lower. With lazy irql we avoid that until absolutely neccessary. > Note that we misuse the PCR's IRR field to save the current hardware irql. > Its a huge performance boost (some parts take half the time), making APIC > performance close to PIC performance on VBox. This is something that Windows > doesn't have :) > > Modified: > trunk/reactos/hal/halx86/apic/apic.c > trunk/reactos/hal/halx86/apic/rtctimer.c > > Modified: trunk/reactos/hal/halx86/apic/apic.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/hal/halx86/apic/apic.c?rev… > > ============================================================================== > --- trunk/reactos/hal/halx86/apic/apic.c [iso-8859-1] (original) > +++ trunk/reactos/hal/halx86/apic/apic.c [iso-8859-1] Mon Sep 12 09:46:20 > 2011 > @@ -17,6 +17,8 @@ > > #include "apic.h" > void HackEoi(void); > + > +#define APIC_LAZY_IRQL > > /* GLOBALS > ********************************************************************/ > > @@ -105,6 +107,46 @@ > > VOID > FORCEINLINE > +ApicWriteIORedirectionEntry( > + UCHAR Index, > + IOAPIC_REDIRECTION_REGISTER ReDirReg) > +{ > + IOApicWrite(IOAPIC_REDTBL + 2 * Index, ReDirReg.Long0); > + IOApicWrite(IOAPIC_REDTBL + 2 * Index + 1, ReDirReg.Long1); > +} > + > +IOAPIC_REDIRECTION_REGISTER > +FORCEINLINE > +ApicReadIORedirectionEntry( > + UCHAR Index) > +{ > + IOAPIC_REDIRECTION_REGISTER ReDirReg; > + > + ReDirReg.Long0 = IOApicRead(IOAPIC_REDTBL + 2 * Index); > + ReDirReg.Long1 = IOApicRead(IOAPIC_REDTBL + 2 * Index + 1); > + > + return ReDirReg; > +} > + > +VOID > +FORCEINLINE > +ApicRequestInterrupt(IN UCHAR Vector) > +{ > + APIC_COMMAND_REGISTER CommandRegister; > + > + /* Setup the command register */ > + CommandRegister.Long0 = 0; > + CommandRegister.Vector = Vector; > + CommandRegister.MessageType = APIC_MT_Fixed; > + CommandRegister.TriggerMode = APIC_TGM_Edge; > + CommandRegister.DestinationShortHand = APIC_DSH_Self; > + > + /* Write the low dword to send the interrupt */ > + ApicWrite(APIC_ICR0, CommandRegister.Long0); > +} > + > +VOID > +FORCEINLINE > ApicSendEOI(void) > { > //ApicWrite(APIC_EOI, 0); > @@ -125,6 +167,12 @@ > { > #ifdef _M_AMD64 > return (KIRQL)__readcr8(); > +#elif defined(APIC_LAZY_IRQL) > + // HACK: some magic to Sync VBox's APIC registers > + ApicRead(APIC_VER); > + > + /* Return the field in the PCR */ > + return (KIRQL)__readfsbyte(FIELD_OFFSET(KPCR, Irql)); > #else > // HACK: some magic to Sync VBox's APIC registers > ApicRead(APIC_VER); > @@ -136,16 +184,42 @@ > > VOID > FORCEINLINE > -ApicSetCurrentIrql(KIRQL Irql) > +ApicRaiseIrql(KIRQL Irql) > { > #ifdef _M_AMD64 > __writecr8(Irql); > +#elif defined(APIC_LAZY_IRQL) > + __writefsbyte(FIELD_OFFSET(KPCR, Irql), Irql); > #else > /* Convert IRQL and write the TPR */ > ApicWrite(APIC_TPR, IrqlToTpr(Irql)); > #endif > } > > +VOID > +FORCEINLINE > +ApicLowerIrql(KIRQL Irql) > +{ > +#ifdef _M_AMD64 > + __writecr8(Irql); > +#elif defined(APIC_LAZY_IRQL) > + __writefsbyte(FIELD_OFFSET(KPCR, Irql), Irql); > + > + /* Is the new Irql lower than set in the TPR? */ > + if (Irql < KeGetPcr()->IRR) > + { > + /* Save the new hard IRQL in the IRR field */ > + KeGetPcr()->IRR = Irql; > + > + /* Need to lower it back */ > + ApicWrite(APIC_TPR, IrqlToTpr(Irql)); > + } > +#else > + /* Convert IRQL and write the TPR */ > + ApicWrite(APIC_TPR, IrqlToTpr(Irql)); > +#endif > +} > + > UCHAR > FASTCALL > HalpIrqToVector(UCHAR Irq) > @@ -171,6 +245,13 @@ > HalpVectorToIrq(UCHAR Vector) > { > return HalpVectorToIndex[Vector]; > +} > + > +VOID > +NTAPI > +HalpSendEOI(VOID) > +{ > + ApicSendEOI(); > } > > VOID > @@ -311,31 +392,10 @@ > ApicWrite(APIC_ERRLVTR, LvtEntry.Long); > > /* Set the IRQL from the PCR */ > - ApicSetCurrentIrql(KeGetPcr()->Irql); > -} > - > - > -VOID > -FORCEINLINE > -ApicWriteIORedirectionEntry( > - UCHAR Index, > - IOAPIC_REDIRECTION_REGISTER ReDirReg) > -{ > - IOApicWrite(IOAPIC_REDTBL + 2 * Index, ReDirReg.Long0); > - IOApicWrite(IOAPIC_REDTBL + 2 * Index + 1, ReDirReg.Long1); > -} > - > -IOAPIC_REDIRECTION_REGISTER > -FORCEINLINE > -ApicReadIORedirectionEntry( > - UCHAR Index) > -{ > - IOAPIC_REDIRECTION_REGISTER ReDirReg; > - > - ReDirReg.Long0 = IOApicRead(IOAPIC_REDTBL + 2 * Index); > - ReDirReg.Long1 = IOApicRead(IOAPIC_REDTBL + 2 * Index + 1); > - > - return ReDirReg; > + ApicWrite(APIC_TPR, IrqlToTpr(KeGetPcr()->Irql)); > + > + /* Save the new hard IRQL in the IRR field */ > + KeGetPcr()->IRR = KeGetPcr()->Irql; > } > > UCHAR > @@ -486,6 +546,9 @@ > __writeeflags(EFlags); > } > > + > +/* SOFTWARE INTERRUPT TRAPS > ***************************************************/ > + > VOID > DECLSPEC_NORETURN > FASTCALL > @@ -493,17 +556,25 @@ > { > KPROCESSOR_MODE ProcessorMode; > KIRQL OldIrql; > - ASSERT(ApicGetCurrentIrql() < APC_LEVEL); > ASSERT(ApicGetProcessorIrql() == APC_LEVEL); > > /* Enter trap */ > KiEnterInterruptTrap(TrapFrame); > > +#ifdef APIC_LAZY_IRQL > + if (!HalBeginSystemInterrupt(APC_LEVEL, APC_VECTOR, &OldIrql)) > + { > + /* "Spurious" interrupt, exit the interrupt */ > + KiEoiHelper(TrapFrame); > + } > +#else > /* Save the old IRQL */ > OldIrql = ApicGetCurrentIrql(); > + ASSERT(OldIrql < APC_LEVEL); > +#endif > > /* Raise to APC_LEVEL */ > - ApicSetCurrentIrql(APC_LEVEL); > + ApicRaiseIrql(APC_LEVEL); > > /* End the interrupt */ > ApicSendEOI(); > @@ -521,7 +592,7 @@ > _disable(); > > /* Restore the old IRQL */ > - ApicSetCurrentIrql(OldIrql); > + ApicLowerIrql(OldIrql); > > /* Exit the interrupt */ > KiEoiHelper(TrapFrame); > @@ -534,17 +605,25 @@ > HalpDispatchInterruptHandler(IN PKTRAP_FRAME TrapFrame) > { > KIRQL OldIrql; > - ASSERT(ApicGetCurrentIrql() < DISPATCH_LEVEL); > ASSERT(ApicGetProcessorIrql() == DISPATCH_LEVEL); > > /* Enter trap */ > KiEnterInterruptTrap(TrapFrame); > > - /* Save the old IRQL */ > +#ifdef APIC_LAZY_IRQL > + if (!HalBeginSystemInterrupt(DISPATCH_LEVEL, DISPATCH_VECTOR, > &OldIrql)) > + { > + /* "Spurious" interrupt, exit the interrupt */ > + KiEoiHelper(TrapFrame); > + } > +#else > + /* Get the current IRQL */ > OldIrql = ApicGetCurrentIrql(); > + ASSERT(OldIrql < DISPATCH_LEVEL); > +#endif > > /* Raise to DISPATCH_LEVEL */ > - ApicSetCurrentIrql(DISPATCH_LEVEL); > + ApicRaiseIrql(DISPATCH_LEVEL); > > /* End the interrupt */ > ApicSendEOI(); > @@ -555,37 +634,23 @@ > _disable(); > > /* Restore the old IRQL */ > - ApicSetCurrentIrql(OldIrql); > + ApicLowerIrql(OldIrql); > > /* Exit the interrupt */ > KiEoiHelper(TrapFrame); > } > #endif > > -VOID > -NTAPI > -HalpSendEOI(VOID) > -{ > - ApicSendEOI(); > -} > - > -/* PUBLIC FUNCTIONS > ***********************************************************/ > + > +/* SOFTWARE INTERRUPTS > ********************************************************/ > + > > VOID > FASTCALL > HalRequestSoftwareInterrupt(IN KIRQL Irql) > { > - APIC_COMMAND_REGISTER CommandRegister; > - > - /* Setup the command register */ > - CommandRegister.Long0 = 0; > - CommandRegister.Vector = IrqlToTpr(Irql); > - CommandRegister.MessageType = APIC_MT_Fixed; > - CommandRegister.TriggerMode = APIC_TGM_Edge; > - CommandRegister.DestinationShortHand = APIC_DSH_Self; > - > - /* Write the low dword to send the interrupt */ > - ApicWrite(APIC_ICR0, CommandRegister.Long0); > + /* Convert irql to vector and request an interrupt */ > + ApicRequestInterrupt(IrqlToTpr(Irql)); > } > > VOID > @@ -595,6 +660,9 @@ > { > /* Nothing to do */ > } > + > + > +/* SYSTEM INTERRUPTS > **********************************************************/ > > BOOLEAN > NTAPI > @@ -678,11 +746,37 @@ > IN UCHAR Vector, > OUT PKIRQL OldIrql) > { > + KIRQL CurrentIrql; > + > /* Get the current IRQL */ > - *OldIrql = ApicGetCurrentIrql(); > + CurrentIrql = ApicGetCurrentIrql(); > + > +#ifdef APIC_LAZY_IRQL > + /* Check if this interrupt is allowed */ > + if (CurrentIrql >= Irql) > + { > + /* It is not, set the real Irql in the TPR! */ > + ApicWrite(APIC_TPR, IrqlToTpr(CurrentIrql)); > + > + /* Save the new hard IRQL in the IRR field */ > + KeGetPcr()->IRR = CurrentIrql; > + > + /* End this interrupt */ > + ApicSendEOI(); > + > + // FIXME: level interrupts > + /* Re-request the interrupt to be handled later */ > + ApicRequestInterrupt(Vector); > + > + /* Pretend it was a spurious interrupt */ > + return FALSE; > + } > +#endif > + /* Save the current IRQL */ > + *OldIrql = CurrentIrql; > > /* Set the new IRQL */ > - ApicSetCurrentIrql(Irql); > + ApicRaiseIrql(Irql); > > /* Turn on interrupts */ > _enable(); > @@ -701,9 +795,11 @@ > ApicSendEOI(); > > /* Restore the old IRQL */ > - ApicSetCurrentIrql(OldIrql); > -} > - > + ApicLowerIrql(OldIrql); > +} > + > + > +/* IRQL MANAGEMENT > ************************************************************/ > > KIRQL > NTAPI > @@ -726,8 +822,8 @@ > KeBugCheck(IRQL_NOT_LESS_OR_EQUAL); > } > #endif > - /* Convert the new IRQL to a TPR value and write the register */ > - ApicSetCurrentIrql(OldIrql); > + /* Set the new IRQL */ > + ApicLowerIrql(OldIrql); > } > > KIRQL > @@ -748,7 +844,7 @@ > } > #endif > /* Convert the new IRQL to a TPR value and write the register */ > - ApicSetCurrentIrql(NewIrql); > + ApicRaiseIrql(NewIrql); > > /* Return old IRQL */ > return OldIrql; > > Modified: trunk/reactos/hal/halx86/apic/rtctimer.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/hal/halx86/apic/rtctimer.c… > > ============================================================================== > --- trunk/reactos/hal/halx86/apic/rtctimer.c [iso-8859-1] (original) > +++ trunk/reactos/hal/halx86/apic/rtctimer.c [iso-8859-1] Mon Sep 12 > 09:46:20 2011 > @@ -111,7 +111,7 @@ > KiEnterInterruptTrap(TrapFrame); > > /* Start the interrupt */ > - if (HalBeginSystemInterrupt(CLOCK_LEVEL, PRIMARY_VECTOR_BASE, &Irql)) > + if (HalBeginSystemInterrupt(CLOCK_LEVEL, HalpClockVector, &Irql)) > { > /* Read register C, so that the next interrupt can happen */ > HalpReadCmos(RTC_REGISTER_C);; > > >

14 years

2
1
0 0

Re: [ros-dev] [ros-diffs] [fireball] 53635: - Downgrade some DPRINT1s to DPRINTs.

by Alex Ionescu

For the stuff that was obviously designed to warn at least once, have you filled out bug reports for all these missing features, or do you think that someone will now remember all this missing code? Best regards, Alex Ionescu On Thu, Sep 8, 2011 at 9:28 AM, <fireball(a)svn.reactos.org> wrote: > Author: fireball > Date: Thu Sep 8 08:28:41 2011 > New Revision: 53635 > > URL: http://svn.reactos.org/svn/reactos?rev=53635&view=rev > Log: > - Downgrade some DPRINT1s to DPRINTs. > > Modified: > trunk/reactos/dll/ntdll/ldr/ldrapi.c > trunk/reactos/dll/ntdll/ldr/ldrinit.c > trunk/reactos/ntoskrnl/mm/ARM3/procsup.c > trunk/reactos/subsystems/win32/csrss/csrsrv/api/process.c > trunk/reactos/subsystems/win32/csrss/csrsrv/api/wapi.c > > Modified: trunk/reactos/dll/ntdll/ldr/ldrapi.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/dll/ntdll/ldr/ldrapi.c?rev… > > ============================================================================== > --- trunk/reactos/dll/ntdll/ldr/ldrapi.c [iso-8859-1] (original) > +++ trunk/reactos/dll/ntdll/ldr/ldrapi.c [iso-8859-1] Thu Sep 8 08:28:41 > 2011 > @@ -1542,8 +1542,8 @@ > NTAPI > LdrUnloadAlternateResourceModule(IN PVOID BaseAddress) > { > - static BOOLEAN WarnedOnce = FALSE; > - if (WarnedOnce == FALSE) { UNIMPLEMENTED; WarnedOnce = TRUE; } > + //static BOOLEAN WarnedOnce = FALSE; > + //if (WarnedOnce == FALSE) { UNIMPLEMENTED; WarnedOnce = TRUE; } > return FALSE; > } > > > Modified: trunk/reactos/dll/ntdll/ldr/ldrinit.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/dll/ntdll/ldr/ldrinit.c?re… > > ============================================================================== > --- trunk/reactos/dll/ntdll/ldr/ldrinit.c [iso-8859-1] (original) > +++ trunk/reactos/dll/ntdll/ldr/ldrinit.c [iso-8859-1] Thu Sep 8 08:28:41 > 2011 > @@ -728,7 +728,7 @@ > > /* Clear it */ > //Kernel32ProcessInitPostImportfunction = NULL; > - UNIMPLEMENTED; > + //UNIMPLEMENTED; > } > > /* No root entry? return */ > @@ -1988,7 +1988,7 @@ > if (NtHeader->OptionalHeader.Subsystem == IMAGE_SUBSYSTEM_WINDOWS_GUI) > { > /* Load kernel32 and call BasePostImportInit... */ > - DPRINT1("Unimplemented codepath!\n"); > + DPRINT("Unimplemented codepath!\n"); > } > > /* Walk the IAT and load all the DLLs */ > @@ -2095,7 +2095,7 @@ > { > /* Check for Application Compatibility Goo */ > //LdrQueryApplicationCompatibilityGoo(hKey); > - DPRINT1("Querying app compat hacks is missing!\n"); > + DPRINT("Querying app compat hacks is missing!\n"); > } > > /* > > Modified: trunk/reactos/ntoskrnl/mm/ARM3/procsup.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/ARM3/procsup.c… > > ============================================================================== > --- trunk/reactos/ntoskrnl/mm/ARM3/procsup.c [iso-8859-1] (original) > +++ trunk/reactos/ntoskrnl/mm/ARM3/procsup.c [iso-8859-1] Thu Sep 8 > 08:28:41 2011 > @@ -590,7 +590,7 @@ > ViewShare, > MEM_TOP_DOWN, > PAGE_READONLY); > - DPRINT1("NLS Tables at: %p\n", TableBase); > + DPRINT("NLS Tables at: %p\n", TableBase); > if (!NT_SUCCESS(Status)) > { > /* Cleanup and exit */ > @@ -602,7 +602,7 @@ > // Allocate the PEB > // > Status = MiCreatePebOrTeb(Process, sizeof(PEB), (PULONG_PTR)&Peb); > - DPRINT1("PEB at: %p\n", Peb); > + DPRINT("PEB at: %p\n", Peb); > if (!NT_SUCCESS(Status)) > { > /* Cleanup and exit */ > > Modified: trunk/reactos/subsystems/win32/csrss/csrsrv/api/process.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/csrss/csr… > > ============================================================================== > --- trunk/reactos/subsystems/win32/csrss/csrsrv/api/process.c [iso-8859-1] > (original) > +++ trunk/reactos/subsystems/win32/csrss/csrsrv/api/process.c [iso-8859-1] > Thu Sep 8 08:28:41 2011 > @@ -105,7 +105,7 @@ > PROCESS_ALL_ACCESS, > &ObjectAttributes, > &ClientId); > - DPRINT1("CSR Process: %p Handle: %p\n", pProcessData, > pProcessData->Process); > + DPRINT("CSR Process: %p Handle: %p\n", pProcessData, > pProcessData->Process); > if (!NT_SUCCESS(Status)) > { > ProcessData[hash] = pProcessData->next; > > Modified: trunk/reactos/subsystems/win32/csrss/csrsrv/api/wapi.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/csrss/csr… > > ============================================================================== > --- trunk/reactos/subsystems/win32/csrss/csrsrv/api/wapi.c [iso-8859-1] > (original) > +++ trunk/reactos/subsystems/win32/csrss/csrsrv/api/wapi.c [iso-8859-1] Thu > Sep 8 08:28:41 2011 > @@ -278,8 +278,8 @@ > /* Check if we have a process */ > if (CsrProcess) > { > - /* Map the sectio into this process */ > - DPRINT1("CSR Process Handle: %p. CSR Process: %p\n", > CsrProcess->Process, CsrProcess); > + /* Map the section into this process */ > + DPRINT("CSR Process Handle: %p. CSR Process: %p\n", > CsrProcess->Process, CsrProcess); > Status = NtMapViewOfSection(CsrSrvSharedSection, > CsrProcess->Process, > &CsrSrvSharedSectionBase, > @@ -520,7 +520,7 @@ > Status = CsrSrvAttachSharedSection(ProcessData, ConnectInfo); > if (NT_SUCCESS(Status)) > { > - DPRINT1("Connection ok\n"); > + DPRINT("Connection ok\n"); > AllowConnection = TRUE; > } > else > > >

14 years

2
7
0 0

Re: [ros-dev] [ros-diffs] [tfaber] 53688: [NTOSKRNL][RTL][DOC] - Fix incorrect loop boundaries in the ARM version of MmCreateProcessAddressSpace. Spotted by Vincenzo Cotugno and cppcheck - Correct outdated wineimport.cmd UR...

by Alex Ionescu

Sorry but these kinds of fixes are not "readability fixes", in fact they make things more obtuse. (*MdlPages << PAGE_SHIFT)) could be interpreted as *(MdlPages << PAGE_SHIFT). while ((*MdlPages) << PAGE_SHIFT) Makes it clear what is happening. In general, all operations affecting the contents of a *dereference should be in parens. Best regards, Alex Ionescu On Sun, Sep 11, 2011 at 7:47 AM, <tfaber(a)svn.reactos.org> wrote: > - ((*MdlPages) << PAGE_SHIFT)); > + (*MdlPages << PAGE_SHIFT)); >

14 years

1
0
0 0

PVS-Studio analysis of ReactOS code: error explanations in English

by Minas Abrahamyan

Hi all, Andrey Karpov of "SiProVer" Ltd (www.viva64.com/ ), the authors of PVS-Studio, a statical source code analyzer/checker wrote (in Russian, this translation is conducted by me): "Have checked source code of ReactOS with PVS-Studio, I fulfilled three wishes of mine at once: Firstly, for a long time I wanted to write an article about ordinary project. It is not so interesting to check source code of such projects as Chromium, It is of too high quality and resources are spending for keeping this level of quality, resources which are unavailable to ordinary projects. Secondly, ReactOS appears to be a good example of project, for which high need of statical analysis of source code can be shown, especially as project being developed with distributed team of developers with diversely different experience. Thirdly, I got confirmation of PVS-Studio getting better and better and more useful all along the way..." Full text of original Russian article is here: http://habrahabr.ru/blogs/os/127493/ titled on Russian as "PVS-Studio: analysing ReactOS operating system source code". Evgeniy Ryzhkov of "SiProVer" adds: "Soon we will translate and publish article on English. But if you have questions now - we are ready for discussion. If some of English-speaking comrades of ReactOS would like to work with errors list, generated with PVS-Studio we have prepared for them translation of errors explanations, here it is: http://www.viva64.com/external-pictures/txt/PVS-Studio-vs-ReactOS-en-unicod… ". Original article refers to long list of generated errors with manually added explanations for errors found by their static checker, so this is translated version of that list. --- Looking backward to few applied patches, it turns out that not all of them were absolutely useful, some patches were reversed, etc. But nevertheless, I think it makes sense to use this tool. They promised to donate some version of PVS-Studio to project, and it is to ROS developers to decide is it worth of taking. What I would suggest: anybody working with some module or part of code can take corresponding part of messages (or in future, possibly check with tool only these parts of interest) and work with them. Also Karpov gave good advise to check newly written code, since it is still of interest to developer: write and time for time test with it. P.S. Disclaimer: I am not in any connection with "SiProVer" Regards, M.A.

14 years

1
0
0 0

Re: [ros-dev] [ros-diffs] [akhaldi] 53653: [SHELL32] * Reintegrate the c++ shell32 branch. Exemplary team-work.. kudos ! * Better code quality, more tests run with less failures... and more. * Dedicated to everyone who help...

by Ged Murphy

Nice work guys. It was great to watch you pull this together as a team. Hopefully there's more to come :) -----Original Message----- From: ros-diffs-bounces(a)reactos.org [mailto:ros-diffs-bounces@reactos.org] On Behalf Of akhaldi(a)svn.reactos.org Sent: 09 September 2011 11:55 To: ros-diffs(a)reactos.org Subject: [ros-diffs] [akhaldi] 53653: [SHELL32] * Reintegrate the c++ shell32 branch. Exemplary team-work.. kudos ! * Better code quality, more tests run with less failures... and more. * Dedicated to everyone who help... Author: akhaldi Date: Fri Sep 9 10:55:09 2011 New Revision: 53653 URL: http://svn.reactos.org/svn/reactos?rev=53653&view=rev Log: [SHELL32] * Reintegrate the c++ shell32 branch. Exemplary team-work.. kudos ! * Better code quality, more tests run with less failures... and more. * Dedicated to everyone who helped ;)

14 years

1
0
0 0

Re: [ros-dev] [ros-diffs] [fireball] 53596: [NTOS/CONFIG] - Remove unnecessary assignments. Spotted by PVS and Dmitry Chapyshev. This may change the behaviour of that codepath, so test results are going to be observed.

by Alex Ionescu

Uhhhh... Am I really the *only* one who sees a problem here? ChildList = &Kcb->ValueCache; - ChildList = (PCACHED_CHILD_LIST)&KeyNode->ValueList; Best regards, Alex Ionescu On Mon, Sep 5, 2011 at 10:54 AM, <fireball(a)svn.reactos.org> wrote: > Author: fireball > Date: Mon Sep 5 09:54:20 2011 > New Revision: 53596 > > URL: http://svn.reactos.org/svn/reactos?rev=53596&view=rev > Log: > [NTOS/CONFIG] > - Remove unnecessary assignments. Spotted by PVS and Dmitry Chapyshev. This > may change the behaviour of that codepath, so test results are going to be > observed. > > Modified: > trunk/reactos/ntoskrnl/config/cmvalche.c > > Modified: trunk/reactos/ntoskrnl/config/cmvalche.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/config/cmvalche.c… > > ============================================================================== > --- trunk/reactos/ntoskrnl/config/cmvalche.c [iso-8859-1] (original) > +++ trunk/reactos/ntoskrnl/config/cmvalche.c [iso-8859-1] Mon Sep 5 > 09:54:20 2011 > @@ -49,7 +49,6 @@ > PHHIVE Hive; > PCACHED_CHILD_LIST ChildList; > HCELL_INDEX CellToRelease; > - PCM_KEY_NODE KeyNode; > > /* Set defaults */ > *ValueListToRelease = HCELL_NIL; > @@ -58,8 +57,6 @@ > /* Get the hive and value cache */ > Hive = Kcb->KeyHive; > ChildList = &Kcb->ValueCache; > - KeyNode = (PCM_KEY_NODE)HvGetCell(Hive, Kcb->KeyCell); > - ChildList = (PCACHED_CHILD_LIST)&KeyNode->ValueList; > > /* Check if the value is cached */ > if (CmpIsValueCached(ChildList->ValueList)) > @@ -212,7 +209,6 @@ > BOOLEAN IndexIsCached; > ULONG i = 0; > HCELL_INDEX Cell = HCELL_NIL; > - PCM_KEY_NODE KeyNode; > > /* Set defaults */ > *CellToRelease = HCELL_NIL; > @@ -221,8 +217,6 @@ > /* Get the hive and child list */ > Hive = Kcb->KeyHive; > ChildList = &Kcb->ValueCache; > - KeyNode = (PCM_KEY_NODE)HvGetCell(Hive, Kcb->KeyCell); > - ChildList = (PCACHED_CHILD_LIST)&KeyNode->ValueList; > > /* Check if the child list has any entries */ > if (ChildList->Count != 0) > > >

14 years

3
8
0 0

Re: [ros-dev] [ros-diffs] [fireball] 53599: [NTOS] - Fix IoCheckEaBufferValidity (IntEaLength must be signed, otherwise loop exiting condition may not trigger). - SEH-protect ObQueryNameString (by Dmitry Chapyshev's request).

by Alex Ionescu

Good to know we are now changing good, working code, on people's "request". Best regards, Alex Ionescu On Mon, Sep 5, 2011 at 4:05 PM, <fireball(a)svn.reactos.org> wrote: > Author: fireball > Date: Mon Sep 5 15:05:56 2011 > New Revision: 53599 > > URL: http://svn.reactos.org/svn/reactos?rev=53599&view=rev > Log: > [NTOS] > - Fix IoCheckEaBufferValidity (IntEaLength must be signed, otherwise loop > exiting condition may not trigger). > - SEH-protect ObQueryNameString (by Dmitry Chapyshev's request). > > Modified: > trunk/reactos/ntoskrnl/io/iomgr/util.c > trunk/reactos/ntoskrnl/ob/obname.c > > Modified: trunk/reactos/ntoskrnl/io/iomgr/util.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/io/iomgr/util.c?r… > > ============================================================================== > --- trunk/reactos/ntoskrnl/io/iomgr/util.c [iso-8859-1] (original) > +++ trunk/reactos/ntoskrnl/io/iomgr/util.c [iso-8859-1] Mon Sep 5 15:05:56 > 2011 > @@ -166,7 +166,8 @@ > OUT PULONG ErrorOffset) > { > PFILE_FULL_EA_INFORMATION EaBufferEnd; > - ULONG NextEaBufferOffset, IntEaLength; > + ULONG NextEaBufferOffset; > + LONG IntEaLength; > > PAGED_CODE(); > > > Modified: trunk/reactos/ntoskrnl/ob/obname.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ob/obname.c?rev=5… > > ============================================================================== > --- trunk/reactos/ntoskrnl/ob/obname.c [iso-8859-1] (original) > +++ trunk/reactos/ntoskrnl/ob/obname.c [iso-8859-1] Mon Sep 5 15:05:56 > 2011 > @@ -986,6 +986,7 @@ > ULONG NameSize; > PWCH ObjectName; > BOOLEAN ObjectIsNamed; > + NTSTATUS Status = STATUS_SUCCESS; > > /* Get the Kernel Meta-Structures */ > ObjectHeader = OBJECT_TO_OBJECT_HEADER(Object); > @@ -994,28 +995,57 @@ > /* Check if a Query Name Procedure is available */ > if (ObjectHeader->Type->TypeInfo.QueryNameProcedure) > { > - /* Call the procedure */ > + /* Call the procedure inside SEH */ > ObjectIsNamed = ((LocalInfo) && (LocalInfo->Name.Length > 0)); > - return ObjectHeader->Type->TypeInfo.QueryNameProcedure(Object, > + > + _SEH2_TRY > + { > + Status = > ObjectHeader->Type->TypeInfo.QueryNameProcedure(Object, > > ObjectIsNamed, > > ObjectNameInfo, > Length, > > ReturnLength, > KernelMode); > + } > + _SEH2_EXCEPT(EXCEPTION_EXECUTE_HANDLER) > + { > + /* Return the exception code */ > + Status = _SEH2_GetExceptionCode(); > + } > + _SEH2_END; > + > + return Status; > } > > /* Check if the object doesn't even have a name */ > if (!(LocalInfo) || !(LocalInfo->Name.Buffer)) > { > - /* We're returning the name structure */ > - *ReturnLength = sizeof(OBJECT_NAME_INFORMATION); > - > - /* Check if we were given enough space */ > - if (*ReturnLength > Length) return STATUS_INFO_LENGTH_MISMATCH; > - > - /* Return an empty buffer */ > - RtlInitEmptyUnicodeString(&ObjectNameInfo->Name, NULL, 0); > - return STATUS_SUCCESS; > + Status = STATUS_SUCCESS; > + > + _SEH2_TRY > + { > + /* We're returning the name structure */ > + *ReturnLength = sizeof(OBJECT_NAME_INFORMATION); > + > + /* Check if we were given enough space */ > + if (*ReturnLength > Length) > + { > + Status = STATUS_INFO_LENGTH_MISMATCH; > + } > + else > + { > + /* Return an empty buffer */ > + RtlInitEmptyUnicodeString(&ObjectNameInfo->Name, NULL, 0); > + } > + } > + _SEH2_EXCEPT(EXCEPTION_EXECUTE_HANDLER) > + { > + /* Return the exception code */ > + Status = _SEH2_GetExceptionCode(); > + } > + _SEH2_END; > + > + return Status; > } > > /* > @@ -1025,126 +1055,136 @@ > * enough right at the beginning, not work our way through > * and find out at the end > */ > - if (Object == ObpRootDirectoryObject) > - { > - /* Size of the '\' string */ > - NameSize = sizeof(OBJ_NAME_PATH_SEPARATOR); > - } > - else > - { > - /* Get the Object Directory and add name of Object */ > - ParentDirectory = LocalInfo->Directory; > - NameSize = sizeof(OBJ_NAME_PATH_SEPARATOR) + > LocalInfo->Name.Length; > - > - /* Loop inside the directory to get the top-most one (meaning > root) */ > - while ((ParentDirectory != ObpRootDirectoryObject) && > (ParentDirectory)) > - { > - /* Get the Name Information */ > - LocalInfo = OBJECT_HEADER_TO_NAME_INFO( > - OBJECT_TO_OBJECT_HEADER(ParentDirectory)); > - > - /* Add the size of the Directory Name */ > - if (LocalInfo && LocalInfo->Directory) > - { > - /* Size of the '\' string + Directory Name */ > - NameSize += sizeof(OBJ_NAME_PATH_SEPARATOR) + > - LocalInfo->Name.Length; > - > - /* Move to next parent Directory */ > - ParentDirectory = LocalInfo->Directory; > - } > - else > - { > - /* Directory with no name. We append "...\" */ > - NameSize += sizeof(L"...") + > sizeof(OBJ_NAME_PATH_SEPARATOR); > - break; > - } > - } > - } > - > - /* Finally, add the name of the structure and the null char */ > - *ReturnLength = NameSize + > - sizeof(OBJECT_NAME_INFORMATION) + > - sizeof(UNICODE_NULL); > - > - /* Check if we were given enough space */ > - if (*ReturnLength > Length) return STATUS_INFO_LENGTH_MISMATCH; > - > - /* > - * Now we will actually create the name. We work backwards because > - * it's easier to start off from the Name we have and walk up the > - * parent directories. We use the same logic as Name Length > calculation. > - */ > - LocalInfo = OBJECT_HEADER_TO_NAME_INFO(ObjectHeader); > - ObjectName = (PWCH)((ULONG_PTR)ObjectNameInfo + *ReturnLength); > - *--ObjectName = UNICODE_NULL; > - > - /* Check if the object is actually the Root directory */ > - if (Object == ObpRootDirectoryObject) > - { > - /* This is already the Root Directory, return "\\" */ > - *--ObjectName = OBJ_NAME_PATH_SEPARATOR; > - ObjectNameInfo->Name.Length = (USHORT)NameSize; > - ObjectNameInfo->Name.MaximumLength = (USHORT)(NameSize + > - > sizeof(UNICODE_NULL)); > - ObjectNameInfo->Name.Buffer = ObjectName; > - return STATUS_SUCCESS; > - } > - else > - { > - /* Start by adding the Object's Name */ > - ObjectName = (PWCH)((ULONG_PTR)ObjectName - > - LocalInfo->Name.Length); > - RtlCopyMemory(ObjectName, > - LocalInfo->Name.Buffer, > - LocalInfo->Name.Length); > - > - /* Now parse the Parent directories until we reach the top */ > - ParentDirectory = LocalInfo->Directory; > - while ((ParentDirectory != ObpRootDirectoryObject) && > (ParentDirectory)) > - { > - /* Get the name information */ > - LocalInfo = OBJECT_HEADER_TO_NAME_INFO( > - OBJECT_TO_OBJECT_HEADER(ParentDirectory)); > - > - /* Add the "\" */ > + _SEH2_TRY > + { > + if (Object == ObpRootDirectoryObject) > + { > + /* Size of the '\' string */ > + NameSize = sizeof(OBJ_NAME_PATH_SEPARATOR); > + } > + else > + { > + /* Get the Object Directory and add name of Object */ > + ParentDirectory = LocalInfo->Directory; > + NameSize = sizeof(OBJ_NAME_PATH_SEPARATOR) + > LocalInfo->Name.Length; > + > + /* Loop inside the directory to get the top-most one (meaning > root) */ > + while ((ParentDirectory != ObpRootDirectoryObject) && > (ParentDirectory)) > + { > + /* Get the Name Information */ > + LocalInfo = OBJECT_HEADER_TO_NAME_INFO( > + OBJECT_TO_OBJECT_HEADER(ParentDirectory)); > + > + /* Add the size of the Directory Name */ > + if (LocalInfo && LocalInfo->Directory) > + { > + /* Size of the '\' string + Directory Name */ > + NameSize += sizeof(OBJ_NAME_PATH_SEPARATOR) + > + LocalInfo->Name.Length; > + > + /* Move to next parent Directory */ > + ParentDirectory = LocalInfo->Directory; > + } > + else > + { > + /* Directory with no name. We append "...\" */ > + NameSize += sizeof(L"...") + > sizeof(OBJ_NAME_PATH_SEPARATOR); > + break; > + } > + } > + } > + > + /* Finally, add the name of the structure and the null char */ > + *ReturnLength = NameSize + > + sizeof(OBJECT_NAME_INFORMATION) + > + sizeof(UNICODE_NULL); > + > + /* Check if we were given enough space */ > + if (*ReturnLength > Length) _SEH2_YIELD(return > STATUS_INFO_LENGTH_MISMATCH); > + > + /* > + * Now we will actually create the name. We work backwards because > + * it's easier to start off from the Name we have and walk up the > + * parent directories. We use the same logic as Name Length > calculation. > + */ > + LocalInfo = OBJECT_HEADER_TO_NAME_INFO(ObjectHeader); > + ObjectName = (PWCH)((ULONG_PTR)ObjectNameInfo + *ReturnLength); > + *--ObjectName = UNICODE_NULL; > + > + /* Check if the object is actually the Root directory */ > + if (Object == ObpRootDirectoryObject) > + { > + /* This is already the Root Directory, return "\\" */ > + *--ObjectName = OBJ_NAME_PATH_SEPARATOR; > + ObjectNameInfo->Name.Length = (USHORT)NameSize; > + ObjectNameInfo->Name.MaximumLength = (USHORT)(NameSize + > + > sizeof(UNICODE_NULL)); > + ObjectNameInfo->Name.Buffer = ObjectName; > + _SEH2_YIELD(return STATUS_SUCCESS); > + } > + else > + { > + /* Start by adding the Object's Name */ > + ObjectName = (PWCH)((ULONG_PTR)ObjectName - > + LocalInfo->Name.Length); > + RtlCopyMemory(ObjectName, > + LocalInfo->Name.Buffer, > + LocalInfo->Name.Length); > + > + /* Now parse the Parent directories until we reach the top */ > + ParentDirectory = LocalInfo->Directory; > + while ((ParentDirectory != ObpRootDirectoryObject) && > (ParentDirectory)) > + { > + /* Get the name information */ > + LocalInfo = OBJECT_HEADER_TO_NAME_INFO( > + OBJECT_TO_OBJECT_HEADER(ParentDirectory)); > + > + /* Add the "\" */ > + *(--ObjectName) = OBJ_NAME_PATH_SEPARATOR; > + > + /* Add the Parent Directory's Name */ > + if (LocalInfo && LocalInfo->Name.Buffer) > + { > + /* Add the name */ > + ObjectName = (PWCH)((ULONG_PTR)ObjectName - > + > LocalInfo->Name.Length); > + RtlCopyMemory(ObjectName, > + LocalInfo->Name.Buffer, > + LocalInfo->Name.Length); > + > + /* Move to next parent */ > + ParentDirectory = LocalInfo->Directory; > + } > + else > + { > + /* Directory without a name, we add "..." */ > + ObjectName = (PWCH)((ULONG_PTR)ObjectName - > + sizeof(L"...") + > + sizeof(UNICODE_NULL)); > + RtlCopyMemory(ObjectName, > + L"...", > + sizeof(L"...") + sizeof(UNICODE_NULL)); > + break; > + } > + } > + > + /* Add Root Directory Name */ > *(--ObjectName) = OBJ_NAME_PATH_SEPARATOR; > - > - /* Add the Parent Directory's Name */ > - if (LocalInfo && LocalInfo->Name.Buffer) > - { > - /* Add the name */ > - ObjectName = (PWCH)((ULONG_PTR)ObjectName - > - LocalInfo->Name.Length); > - RtlCopyMemory(ObjectName, > - LocalInfo->Name.Buffer, > - LocalInfo->Name.Length); > - > - /* Move to next parent */ > - ParentDirectory = LocalInfo->Directory; > - } > - else > - { > - /* Directory without a name, we add "..." */ > - ObjectName = (PWCH)((ULONG_PTR)ObjectName - > - sizeof(L"...") + > sizeof(UNICODE_NULL)); > - RtlCopyMemory(ObjectName, > - L"...", > - sizeof(L"...") + sizeof(UNICODE_NULL)); > - break; > - } > - } > - > - /* Add Root Directory Name */ > - *(--ObjectName) = OBJ_NAME_PATH_SEPARATOR; > - ObjectNameInfo->Name.Length = (USHORT)NameSize; > - ObjectNameInfo->Name.MaximumLength = (USHORT)(NameSize + > - > sizeof(UNICODE_NULL)); > - ObjectNameInfo->Name.Buffer = ObjectName; > - } > + ObjectNameInfo->Name.Length = (USHORT)NameSize; > + ObjectNameInfo->Name.MaximumLength = > + (USHORT)(NameSize + sizeof(UNICODE_NULL)); > + ObjectNameInfo->Name.Buffer = ObjectName; > + } > + } > + _SEH2_EXCEPT(EXCEPTION_EXECUTE_HANDLER) > + { > + /* Return the exception code */ > + Status = _SEH2_GetExceptionCode(); > + } > + _SEH2_END; > > /* Return success */ > - return STATUS_SUCCESS; > + return Status; > } > > VOID > > >

14 years

2
1
0 0

Re: [ros-dev] [ros-diffs] [tkreuzer] 53600: [HAL] - Use functions instead of macros for irq<->vector<->irql translation, this will be neccessary, once apic support is there - Disable mp hal in rbuild for now, its broken anyway

by Alex Ionescu

There are already hal private dispatch table functions to deal with this. Please see older HAL commits and the changes in ke/i386/interrupt.c & friends. Best regards, Alex Ionescu On Mon, Sep 5, 2011 at 4:20 PM, <tkreuzer(a)svn.reactos.org> wrote: > Author: tkreuzer > Date: Mon Sep 5 15:20:07 2011 > New Revision: 53600 > > URL: http://svn.reactos.org/svn/reactos?rev=53600&view=rev > Log: > [HAL] > - Use functions instead of macros for irq<->vector<->irql translation, this > will be neccessary, once apic support is there > - Disable mp hal in rbuild for now, its broken anyway > > Modified: > trunk/reactos/hal/halx86/directory.rbuild > trunk/reactos/hal/halx86/include/hal.h > trunk/reactos/hal/halx86/include/halirq.h > trunk/reactos/hal/halx86/up/pic.c > > Modified: trunk/reactos/hal/halx86/directory.rbuild > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/hal/halx86/directory.rbuil… > > ============================================================================== > --- trunk/reactos/hal/halx86/directory.rbuild [iso-8859-1] (original) > +++ trunk/reactos/hal/halx86/directory.rbuild [iso-8859-1] Mon Sep 5 > 15:20:07 2011 > @@ -13,9 +13,9 @@ > <xi:include href="hal.rbuild" /> > <xi:include href="halacpi.rbuild" /> > <xi:include href="halxbox.rbuild" /> > - <if property="BUILD_MP" value="1"> > +  > </if> > > <if property="ARCH" value="amd64"> > > Modified: trunk/reactos/hal/halx86/include/hal.h > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/hal/halx86/include/hal.h?r… > > ============================================================================== > --- trunk/reactos/hal/halx86/include/hal.h [iso-8859-1] (original) > +++ trunk/reactos/hal/halx86/include/hal.h [iso-8859-1] Mon Sep 5 15:20:07 > 2011 > @@ -55,13 +55,11 @@ > #define TAG_BUS_HANDLER 'BusH' > > /* Internal HAL Headers */ > -#include "apic.h" > #include "bus.h" > #include "halirq.h" > #include "haldma.h" > #include "halp.h" > #include "mps.h" > -#include "ioapic.h" > #include "halacpi.h" > > /* EOF */ > > Modified: trunk/reactos/hal/halx86/include/halirq.h > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/hal/halx86/include/halirq.… > > ============================================================================== > --- trunk/reactos/hal/halx86/include/halirq.h [iso-8859-1] (original) > +++ trunk/reactos/hal/halx86/include/halirq.h [iso-8859-1] Mon Sep 5 > 15:20:07 2011 > @@ -4,29 +4,19 @@ > > #pragma once > > -#ifdef CONFIG_SMP > +UCHAR > +FASTCALL > +HalpIrqToVector(UCHAR Irq); > > -#define FIRST_DEVICE_VECTOR (0x30) > -#define FIRST_SYSTEM_VECTOR (0xef) > +KIRQL > +FASTCALL > +HalpVectorToIrql(UCHAR Vector); > > -#define IRQ_BASE FIRST_DEVICE_VECTOR > -#define NR_IRQS (FIRST_SYSTEM_VECTOR - > FIRST_DEVICE_VECTOR) > +UCHAR > +FASTCALL > +HalpVectorToIrq(UCHAR Vector); > > -/* > - * FIXME: > - * This does not work if we have more than 24 IRQs (ie. more than one > I/O APIC) > - */ > -#define VECTOR2IRQ(vector) (23 - (vector - IRQ_BASE) / 8) > -#define VECTOR2IRQL(vector) (PROFILE_LEVEL - VECTOR2IRQ(vector)) > -#define IRQ2VECTOR(irq) (((23 - (irq)) * 8) + > FIRST_DEVICE_VECTOR) > +#define VECTOR2IRQ(vector) HalpVectorToIrq(vector) > +#define VECTOR2IRQL(vector) HalpVectorToIrql(vector) > +#define IRQ2VECTOR(irq) HalpIrqToVector(irq) > > -#else > - > -#define IRQ_BASE (0x30) > -#define NR_IRQS (16) > - > -#define VECTOR2IRQ(vector) ((vector) - IRQ_BASE) > -#define VECTOR2IRQL(vector) (PROFILE_LEVEL - VECTOR2IRQ(vector)) > -#define IRQ2VECTOR(irq) ((irq) + IRQ_BASE) > - > -#endif > > Modified: trunk/reactos/hal/halx86/up/pic.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/hal/halx86/up/pic.c?rev=53… > > ============================================================================== > --- trunk/reactos/hal/halx86/up/pic.c [iso-8859-1] (original) > +++ trunk/reactos/hal/halx86/up/pic.c [iso-8859-1] Mon Sep 5 15:20:07 2011 > @@ -512,6 +512,27 @@ > __writeeflags(EFlags); > } > > +UCHAR > +FASTCALL > +HalpIrqToVector(UCHAR Irq) > +{ > + return (PRIMARY_VECTOR_BASE + Irq); > +} > + > +UCHAR > +FASTCALL > +HalpVectorToIrq(UCHAR Vector) > +{ > + return (Vector - PRIMARY_VECTOR_BASE); > +} > + > +KIRQL > +FASTCALL > +HalpVectorToIrql(UCHAR Vector) > +{ > + return (PROFILE_LEVEL - (Vector - PRIMARY_VECTOR_BASE)); > +} > + > /* IRQL MANAGEMENT > ************************************************************/ > > /* > > >

14 years

1
0
0 0

Re: [ros-dev] [ros-diffs] [dchapyshev] 53519: - Fix multiple typos and bugs, found by PVS-Studio

by Alex Ionescu

A lot of these are in 3rdparty/wine DLLs. Were these bugs reported to the appropriate projects? Best regards, Alex Ionescu On Thu, Sep 1, 2011 at 4:30 PM, <dchapyshev(a)svn.reactos.org> wrote: > Author: dchapyshev > Date: Thu Sep 1 15:30:19 2011 > New Revision: 53519 > > URL: http://svn.reactos.org/svn/reactos?rev=53519&view=rev > Log: > - Fix multiple typos and bugs, found by PVS-Studio > > Modified: > trunk/reactos/base/applications/sndrec32/sndrec32.cpp > trunk/reactos/base/system/smss/client.c > trunk/reactos/dll/cpl/desk/screensaver.c > trunk/reactos/dll/win32/browseui/bandsite.cpp > trunk/reactos/dll/win32/glu32/libnurbs/internals/mapdesc.cc > trunk/reactos/dll/win32/oleaut32/typelib2.c > trunk/reactos/dll/win32/rsaenh/sha2.c > trunk/reactos/dll/win32/shell32/pidl.c > trunk/reactos/drivers/storage/ide/uniata/id_dma.cpp > trunk/reactos/ntoskrnl/config/cmcontrl.c > trunk/reactos/subsystems/win32/win32k/eng/gradient.c > trunk/reactos/subsystems/win32/win32k/objects/bitblt.c > > Modified: trunk/reactos/base/applications/sndrec32/sndrec32.cpp > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/sndrec32… > > ============================================================================== > --- trunk/reactos/base/applications/sndrec32/sndrec32.cpp [iso-8859-1] > (original) > +++ trunk/reactos/base/applications/sndrec32/sndrec32.cpp [iso-8859-1] Thu > Sep 1 15:30:19 2011 > @@ -766,7 +766,7 @@ > isnew = TRUE; > display_dur = TRUE; > > - ZeroMemory( file_path, MAX_PATH ); > + ZeroMemory( file_path, MAX_PATH * sizeof(TCHAR) ); > > EnableWindow( slider, FALSE ); > > > Modified: trunk/reactos/base/system/smss/client.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/base/system/smss/client.c?… > > ============================================================================== > --- trunk/reactos/base/system/smss/client.c [iso-8859-1] (original) > +++ trunk/reactos/base/system/smss/client.c [iso-8859-1] Thu Sep 1 > 15:30:19 2011 > @@ -441,7 +441,7 @@ > */ > RtlCopyMemory > (SmpClientDirectory.CandidateClient->ProgramName, > ProgramName, > - SM_SB_NAME_MAX_LENGTH); > + SM_SB_NAME_MAX_LENGTH * > sizeof(WCHAR)); > } > } else { > DPRINT1("SM: %s: CandidateClient %p pending!\n", > __FUNCTION__, > > Modified: trunk/reactos/dll/cpl/desk/screensaver.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/dll/cpl/desk/screensaver.c… > > ============================================================================== > --- trunk/reactos/dll/cpl/desk/screensaver.c [iso-8859-1] (original) > +++ trunk/reactos/dll/cpl/desk/screensaver.c [iso-8859-1] Thu Sep 1 > 15:30:19 2011 > @@ -450,7 +450,7 @@ > lpBackSlash = _tcsrchr(szSearchPath, _T('\\')); > if (lpBackSlash != NULL) > { > - lpBackSlash = '\0'; > + *lpBackSlash = '\0'; > SearchScreenSavers(hwndScreenSavers, szSearchPath, pData); > } > } > > Modified: trunk/reactos/dll/win32/browseui/bandsite.cpp > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/browseui/bandsit… > > ============================================================================== > --- trunk/reactos/dll/win32/browseui/bandsite.cpp [iso-8859-1] (original) > +++ trunk/reactos/dll/win32/browseui/bandsite.cpp [iso-8859-1] Thu Sep 1 > 15:30:19 2011 > @@ -719,7 +719,7 @@ > if (fRebarWindow == NULL) > return E_FAIL; > > - if (IsEqualIID(pguidCmdGroup, IID_IDeskBand)) > + if (IsEqualIID(*pguidCmdGroup, IID_IDeskBand)) > { > switch (nCmdID) > { > > Modified: trunk/reactos/dll/win32/glu32/libnurbs/internals/mapdesc.cc > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/glu32/libnurbs/i… > > ============================================================================== > --- trunk/reactos/dll/win32/glu32/libnurbs/internals/mapdesc.cc > [iso-8859-1] (original) > +++ trunk/reactos/dll/win32/glu32/libnurbs/internals/mapdesc.cc > [iso-8859-1] Thu Sep 1 15:30:19 2011 > @@ -90,7 +90,7 @@ > } > > void > -Mapdesc::identify( REAL dest[MAXCOORDS][MAXCOORDS] ) > +Mapdesc::identify( REAL (&dest)[MAXCOORDS][MAXCOORDS] ) > { > memset( dest, 0, sizeof( dest ) ); > for( int i=0; i != hcoords; i++ ) > > Modified: trunk/reactos/dll/win32/oleaut32/typelib2.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/oleaut32/typelib… > > ============================================================================== > --- trunk/reactos/dll/win32/oleaut32/typelib2.c [iso-8859-1] (original) > +++ trunk/reactos/dll/win32/oleaut32/typelib2.c [iso-8859-1] Thu Sep 1 > 15:30:19 2011 > @@ -317,7 +317,7 @@ > while (offset != -1) { > guidentry = (MSFT_GuidEntry > *)&This->typelib_segment_data[MSFT_SEG_GUID][offset]; > > - if (IsEqualGUID(guidentry, guid)) return offset; > + if (IsEqualGUID(*guidentry, guid)) return offset; > > offset = guidentry->next_hash; > } > > Modified: trunk/reactos/dll/win32/rsaenh/sha2.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/rsaenh/sha2.c?re… > > ============================================================================== > --- trunk/reactos/dll/win32/rsaenh/sha2.c [iso-8859-1] (original) > +++ trunk/reactos/dll/win32/rsaenh/sha2.c [iso-8859-1] Thu Sep 1 15:30:19 > 2011 > @@ -563,7 +563,7 @@ > } > > /* Clean up state data: */ > - MEMSET_BZERO(context, sizeof(context)); > + MEMSET_BZERO(context, sizeof(*context)); > usedspace = 0; > } > > @@ -584,7 +584,7 @@ > } > *buffer = 0; > } else { > - MEMSET_BZERO(context, sizeof(context)); > + MEMSET_BZERO(context, sizeof(*context)); > } > MEMSET_BZERO(digest, SHA256_DIGEST_LENGTH); > return buffer; > @@ -893,7 +893,7 @@ > } > > /* Zero out state data */ > - MEMSET_BZERO(context, sizeof(context)); > + MEMSET_BZERO(context, sizeof(*context)); > } > > char *SHA512_End(SHA512_CTX* context, char buffer[]) { > @@ -913,7 +913,7 @@ > } > *buffer = 0; > } else { > - MEMSET_BZERO(context, sizeof(context)); > + MEMSET_BZERO(context, sizeof(*context)); > } > MEMSET_BZERO(digest, SHA512_DIGEST_LENGTH); > return buffer; > @@ -968,7 +968,7 @@ > } > > /* Zero out state data */ > - MEMSET_BZERO(context, sizeof(context)); > + MEMSET_BZERO(context, sizeof(*context)); > } > > char *SHA384_End(SHA384_CTX* context, char buffer[]) { > @@ -988,7 +988,7 @@ > } > *buffer = 0; > } else { > - MEMSET_BZERO(context, sizeof(context)); > + MEMSET_BZERO(context, sizeof(*context)); > } > MEMSET_BZERO(digest, SHA384_DIGEST_LENGTH); > return buffer; > > Modified: trunk/reactos/dll/win32/shell32/pidl.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shell32/pidl.c?r… > > ============================================================================== > --- trunk/reactos/dll/win32/shell32/pidl.c [iso-8859-1] (original) > +++ trunk/reactos/dll/win32/shell32/pidl.c [iso-8859-1] Thu Sep 1 15:30:19 > 2011 > @@ -1157,7 +1157,7 @@ > if (len < sizeof(WIN32_FIND_DATAW)) > return E_INVALIDARG; > > - ZeroMemory(pfd, sizeof (WIN32_FIND_DATAA)); > + ZeroMemory(pfd, sizeof (WIN32_FIND_DATAW)); > _ILGetFileDateTime( pidl, &(pfd->ftLastWriteTime)); > pfd->dwFileAttributes = _ILGetFileAttributes(pidl, NULL, 0); > pfd->nFileSizeLow = _ILGetFileSize ( pidl, NULL, 0); > > Modified: trunk/reactos/drivers/storage/ide/uniata/id_dma.cpp > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/storage/ide/uniata… > > ============================================================================== > --- trunk/reactos/drivers/storage/ide/uniata/id_dma.cpp [iso-8859-1] > (original) > +++ trunk/reactos/drivers/storage/ide/uniata/id_dma.cpp [iso-8859-1] Thu > Sep 1 15:30:19 2011 > @@ -1607,7 +1607,7 @@ > { 0xc2, 0x82, 0x042, 0x8a, 0x4a, 0x0a } }; > static const UCHAR cmd_wdma_modes[] = { 0x87, 0x32, 0x3f }; > static const UCHAR cmd_pio_modes[] = { 0xa9, 0x57, 0x44, 0x32, > 0x3f }; > - ULONG treg = 0x54 + (dev < 3) ? (dev << 1) : 7; > + ULONG treg = 0x54 + ((dev < 3) ? (dev << 1) : 7); > > udmamode = min(udmamode, 5); > /* enable UDMA mode */ > > Modified: trunk/reactos/ntoskrnl/config/cmcontrl.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/config/cmcontrl.c… > > ============================================================================== > --- trunk/reactos/ntoskrnl/config/cmcontrl.c [iso-8859-1] (original) > +++ trunk/reactos/ntoskrnl/config/cmcontrl.c [iso-8859-1] Thu Sep 1 > 15:30:19 2011 > @@ -118,7 +118,7 @@ > if (!SystemHiveData) return; > > /* Initialize the Hive View List and the security cache */ > - RtlZeroMemory(SystemHive, sizeof(SystemHive)); > + RtlZeroMemory(SystemHive, sizeof(*SystemHive)); > CmpInitHiveViewList((PCMHIVE)SystemHive); > CmpInitSecurityCache((PCMHIVE)SystemHive); > > > Modified: trunk/reactos/subsystems/win32/win32k/eng/gradient.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/en… > > ============================================================================== > --- trunk/reactos/subsystems/win32/win32k/eng/gradient.c [iso-8859-1] > (original) > +++ trunk/reactos/subsystems/win32/win32k/eng/gradient.c [iso-8859-1] Thu > Sep 1 15:30:19 2011 > @@ -298,7 +298,7 @@ > #define SMALLER(a,b) (a->y < b->y) || (a->y == b->y && a->x < b->x) > #define SWAP(a,b,c) c = a;\ > a = b;\ > - a = c > + b = c > #define NLINES 3 > BOOL FASTCALL > IntEngGradientFillTriangle( > > Modified: trunk/reactos/subsystems/win32/win32k/objects/bitblt.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/ob… > > ============================================================================== > --- trunk/reactos/subsystems/win32/win32k/objects/bitblt.c [iso-8859-1] > (original) > +++ trunk/reactos/subsystems/win32/win32k/objects/bitblt.c [iso-8859-1] Thu > Sep 1 15:30:19 2011 > @@ -667,7 +667,7 @@ > MaskPoint.y = YOriginMask; > IntLPtoDP(DCMask, &MaskPoint, 1); > MaskPoint.x += DCMask->ptlDCOrig.x; > - MaskPoint.y += DCMask->ptlDCOrig.x; > + MaskPoint.y += DCMask->ptlDCOrig.y; > } > > /* Perform the bitblt operation */ > > >

14 years

4
5
0 0

Re: [ros-dev] [ros-diffs] [tkreuzer] 53399: [VMWINST] Fix amd64 build [NTDLL] add missing amd64 specific exports [MSVCRT*] Fix mangled c++ exports for amd64 [OLEAUT32] Add amd64 adm stub for call_method, fix MSVC/amd64 buil...

by Jérôme Gardou

Le 23/08/2011 10:58, tkreuzer(a)svn.reactos.org a écrit : > Author: tkreuzer > Date: Tue Aug 23 08:58:15 2011 > New Revision: 53399 > > URL: http://svn.reactos.org/svn/reactos?rev=53399&view=rev > Log: > [VMWINST] Fix amd64 build > What about : [VMWINST] Get rid of this useless relic. I mean it's something we have to maintain, it was written for antediluvian vmware versions, and I see no reason to have such a thing. I may as well write an application to install specific ATI card drivers, or intel chipset drivers...

14 years

7
12
0 0

Re: [ros-dev] [ros-diffs] [jgardou] 53547: [VGA_NEW] - fix some warnings

by Alex Ionescu

These changes are wrong :( Please use the correct compiler flag instead (-mrtd) Best regards, Alex Ionescu On Sat, Sep 3, 2011 at 5:09 PM, <jgardou(a)svn.reactos.org> wrote: > Author: jgardou > Date: Sat Sep 3 16:09:34 2011 > New Revision: 53547 > > URL: http://svn.reactos.org/svn/reactos?rev=53547&view=rev > Log: > [VGA_NEW] > - fix some warnings > > Modified: > trunk/reactos/drivers/video/miniport/vga_new/vga.c > > Modified: trunk/reactos/drivers/video/miniport/vga_new/vga.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/video/miniport/vga… > > ============================================================================== > --- trunk/reactos/drivers/video/miniport/vga_new/vga.c [iso-8859-1] > (original) > +++ trunk/reactos/drivers/video/miniport/vga_new/vga.c [iso-8859-1] Sat Sep > 3 16:09:34 2011 > @@ -19,6 +19,7 @@ > // > > VP_STATUS > +NTAPI > VgaFindAdapter( > PVOID HwDeviceExtension, > PVOID HwContext, > @@ -28,11 +29,13 @@ > ); > > BOOLEAN > +NTAPI > VgaInitialize( > PVOID HwDeviceExtension > ); > > BOOLEAN > +NTAPI > VgaStartIO( > PVOID HwDeviceExtension, > PVIDEO_REQUEST_PACKET RequestPacket > @@ -102,6 +105,7 @@ > ); > > VP_STATUS > +NTAPI > GetDeviceDataCallback( > PVOID HwDeviceExtension, > PVOID Context, > @@ -130,7 +134,6 @@ > #pragma alloc_text(PAGE,VgaSetColorLookup) > #endif > > - > > //--------------------------------------------------------------------------- > ULONG > // eVb: 1.3 [GCC] - Add NTAPI for GCC support > @@ -303,9 +306,10 @@ > return initializationStatus; > > } // end DriverEntry() > - > + > > //--------------------------------------------------------------------------- > VP_STATUS > +NTAPI > VgaFindAdapter( > PVOID HwDeviceExtension, > PVOID HwContext, > @@ -383,7 +387,7 @@ > if ((ConfigInfo->AdapterInterfaceType == Internal) && > (VideoPortGetDeviceData(HwDeviceExtension, > VpControllerData, > - &GetDeviceDataCallback, > + GetDeviceDataCallback, > VgaAccessRange) != NO_ERROR)) > { > return ERROR_INVALID_PARAMETER; > @@ -485,9 +489,10 @@ > > > } // VgaFindAdapter() > - > + > > //--------------------------------------------------------------------------- > BOOLEAN > +NTAPI > VgaInitialize( > PVOID HwDeviceExtension > ) > @@ -527,9 +532,10 @@ > return TRUE; > > } // VgaInitialize() > - > + > > //--------------------------------------------------------------------------- > BOOLEAN > +NTAPI > VgaStartIO( > PVOID HwDeviceExtension, > PVIDEO_REQUEST_PACKET RequestPacket > @@ -1440,8 +1446,9 @@ > return ERROR_INVALID_PARAMETER; > > } // end VgaSetColorLookup() > - > + > VP_STATUS > +NTAPI > GetDeviceDataCallback( > PVOID HwDeviceExtension, > PVOID Context, > > >

14 years

4
11
0 0

Re: [ros-dev] [ros-diffs] [jgardou] 53551: - revert r53547, although setting explicitly something which is default isn't a "wrong change" per se.

by Alex Ionescu

It is when it breaks the easyness to sync this code with it's original source and do diffs, sorry for not being clear. I believe the whole driver was carefully commented in the locations where it differs from the original source, and this would've added extra burden. Best regards, Alex Ionescu On Sat, Sep 3, 2011 at 5:44 PM, <jgardou(a)svn.reactos.org> wrote: > Author: jgardou > Date: Sat Sep 3 16:44:49 2011 > New Revision: 53551 > > URL: http://svn.reactos.org/svn/reactos?rev=53551&view=rev > Log: > - revert r53547, although setting explicitly something which is default > isn't a "wrong change" per se. > > Modified: > trunk/reactos/drivers/video/miniport/vga_new/vga.c > > Modified: trunk/reactos/drivers/video/miniport/vga_new/vga.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/video/miniport/vga… > > ============================================================================== > --- trunk/reactos/drivers/video/miniport/vga_new/vga.c [iso-8859-1] > (original) > +++ trunk/reactos/drivers/video/miniport/vga_new/vga.c [iso-8859-1] Sat Sep > 3 16:44:49 2011 > @@ -19,7 +19,6 @@ > // > > VP_STATUS > -NTAPI > VgaFindAdapter( > PVOID HwDeviceExtension, > PVOID HwContext, > @@ -29,13 +28,11 @@ > ); > > BOOLEAN > -NTAPI > VgaInitialize( > PVOID HwDeviceExtension > ); > > BOOLEAN > -NTAPI > VgaStartIO( > PVOID HwDeviceExtension, > PVIDEO_REQUEST_PACKET RequestPacket > @@ -105,7 +102,6 @@ > ); > > VP_STATUS > -NTAPI > GetDeviceDataCallback( > PVOID HwDeviceExtension, > PVOID Context, > @@ -134,6 +130,7 @@ > #pragma alloc_text(PAGE,VgaSetColorLookup) > #endif > > + > > //--------------------------------------------------------------------------- > ULONG > // eVb: 1.3 [GCC] - Add NTAPI for GCC support > @@ -306,10 +303,9 @@ > return initializationStatus; > > } // end DriverEntry() > - > + > > //--------------------------------------------------------------------------- > VP_STATUS > -NTAPI > VgaFindAdapter( > PVOID HwDeviceExtension, > PVOID HwContext, > @@ -387,7 +383,7 @@ > if ((ConfigInfo->AdapterInterfaceType == Internal) && > (VideoPortGetDeviceData(HwDeviceExtension, > VpControllerData, > - GetDeviceDataCallback, > + &GetDeviceDataCallback, > VgaAccessRange) != NO_ERROR)) > { > return ERROR_INVALID_PARAMETER; > @@ -489,10 +485,9 @@ > > > } // VgaFindAdapter() > - > + > > //--------------------------------------------------------------------------- > BOOLEAN > -NTAPI > VgaInitialize( > PVOID HwDeviceExtension > ) > @@ -532,10 +527,9 @@ > return TRUE; > > } // VgaInitialize() > - > + > > //--------------------------------------------------------------------------- > BOOLEAN > -NTAPI > VgaStartIO( > PVOID HwDeviceExtension, > PVIDEO_REQUEST_PACKET RequestPacket > @@ -1446,9 +1440,8 @@ > return ERROR_INVALID_PARAMETER; > > } // end VgaSetColorLookup() > - > + > VP_STATUS > -NTAPI > GetDeviceDataCallback( > PVOID HwDeviceExtension, > PVOID Context, > > >

14 years

1
0
0 0

Re: [ros-dev] [ros-diffs] [cmihail] 53543: [shell32.dll] - Fix bug related to correct error code returning in delete_files. The value of 1026 was revealed to be returned by windows 2003 server. Score several passed winetest...

by Jérôme Gardou

Hello Claudiu! I notice some weird tab/spaces modifications here. Regards. Jérôme. Le 03/09/2011 16:20, cmihail(a)svn.reactos.org a écrit : > Author: cmihail > Date: Sat Sep 3 14:20:03 2011 > New Revision: 53543 > > URL: http://svn.reactos.org/svn/reactos?rev=53543&view=rev > Log: > [shell32.dll] > - Fix bug related to correct error code returning in delete_files. The value of 1026 was revealed to be returned by windows 2003 server. Score several passed winetests. > - Fix a bug in ShellLink::SetShowCmd and score one more passed winetest > > Modified: > branches/shell32_new-bringup/dll/win32/shell32/shelllink.cpp > branches/shell32_new-bringup/dll/win32/shell32/shlfileop.cpp > >

14 years

2
1
0 0

Re: [ros-dev] [ros-diffs] [rharabien] 53542: [FREELDR] - Introduce WINE-like debug macros ERR, FIXME, WARN and TRACE - Always show ERR and FIXME information - WARN and TRACE are enabled by DebugPrintMask in debug.c as befor...

by Alex Ionescu

And the bug was...? Best regards, Alex Ionescu On Sat, Sep 3, 2011 at 11:56 AM, <rharabien(a)svn.reactos.org> wrote: > Author: rharabien > Date: Sat Sep 3 10:56:36 2011 > New Revision: 53542 > > URL: http://svn.reactos.org/svn/reactos?rev=53542&view=rev > Log: > [FREELDR] > - Introduce WINE-like debug macros ERR, FIXME, WARN and TRACE > - Always show ERR and FIXME information > - WARN and TRACE are enabled by DebugPrintMask in debug.c as before > - Thanks to new macros find bug in CMake livecd creation and fix it > > Modified: > trunk/reactos/boot/freeldr/freeldr/CMakeLists.txt > trunk/reactos/boot/freeldr/freeldr/arch/amd64/winldr.c > trunk/reactos/boot/freeldr/freeldr/arch/i386/drivemap.c > trunk/reactos/boot/freeldr/freeldr/arch/i386/hardware.c > trunk/reactos/boot/freeldr/freeldr/arch/i386/hwacpi.c > trunk/reactos/boot/freeldr/freeldr/arch/i386/hwapm.c > trunk/reactos/boot/freeldr/freeldr/arch/i386/hwpci.c > trunk/reactos/boot/freeldr/freeldr/arch/i386/i386disk.c > trunk/reactos/boot/freeldr/freeldr/arch/i386/i386vid.c > trunk/reactos/boot/freeldr/freeldr/arch/i386/pcdisk.c > trunk/reactos/boot/freeldr/freeldr/arch/i386/pcmem.c > trunk/reactos/boot/freeldr/freeldr/arch/i386/pcvideo.c > trunk/reactos/boot/freeldr/freeldr/arch/i386/winldr.c > trunk/reactos/boot/freeldr/freeldr/arch/i386/xboxdisk.c > trunk/reactos/boot/freeldr/freeldr/arch/i386/xboxhw.c > trunk/reactos/boot/freeldr/freeldr/cache/blocklist.c > trunk/reactos/boot/freeldr/freeldr/cache/cache.c > trunk/reactos/boot/freeldr/freeldr/debug.c > trunk/reactos/boot/freeldr/freeldr/disk/disk.c > trunk/reactos/boot/freeldr/freeldr/disk/partition.c > trunk/reactos/boot/freeldr/freeldr/disk/scsiport.c > trunk/reactos/boot/freeldr/freeldr/freeldr.c > trunk/reactos/boot/freeldr/freeldr/fs/ext2.c > trunk/reactos/boot/freeldr/freeldr/fs/fat.c > trunk/reactos/boot/freeldr/freeldr/fs/fs.c > trunk/reactos/boot/freeldr/freeldr/fs/iso.c > trunk/reactos/boot/freeldr/freeldr/fs/ntfs.c > trunk/reactos/boot/freeldr/freeldr/fs/pxe.c > trunk/reactos/boot/freeldr/freeldr/include/debug.h > trunk/reactos/boot/freeldr/freeldr/inifile/inifile.c > trunk/reactos/boot/freeldr/freeldr/inifile/parse.c > trunk/reactos/boot/freeldr/freeldr/linuxboot.c > trunk/reactos/boot/freeldr/freeldr/mm/meminit.c > trunk/reactos/boot/freeldr/freeldr/mm/mm.c > trunk/reactos/boot/freeldr/freeldr/reactos/binhive.c > trunk/reactos/boot/freeldr/freeldr/reactos/registry.c > trunk/reactos/boot/freeldr/freeldr/ui/ui.c > trunk/reactos/boot/freeldr/freeldr/windows/conversion.c > trunk/reactos/boot/freeldr/freeldr/windows/peloader.c > trunk/reactos/boot/freeldr/freeldr/windows/setupldr.c > trunk/reactos/boot/freeldr/freeldr/windows/winldr.c > trunk/reactos/boot/freeldr/freeldr/windows/wlmemory.c > trunk/reactos/boot/freeldr/freeldr/windows/wlregistry.c > > [This mail would be too long, it was shortened to contain the URLs only.] > > Modified: trunk/reactos/boot/freeldr/freeldr/CMakeLists.txt > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/CMake… > > Modified: trunk/reactos/boot/freeldr/freeldr/arch/amd64/winldr.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/arch/… > > Modified: trunk/reactos/boot/freeldr/freeldr/arch/i386/drivemap.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/arch/… > > Modified: trunk/reactos/boot/freeldr/freeldr/arch/i386/hardware.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/arch/… > > Modified: trunk/reactos/boot/freeldr/freeldr/arch/i386/hwacpi.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/arch/… > > Modified: trunk/reactos/boot/freeldr/freeldr/arch/i386/hwapm.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/arch/… > > Modified: trunk/reactos/boot/freeldr/freeldr/arch/i386/hwpci.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/arch/… > > Modified: trunk/reactos/boot/freeldr/freeldr/arch/i386/i386disk.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/arch/… > > Modified: trunk/reactos/boot/freeldr/freeldr/arch/i386/i386vid.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/arch/… > > Modified: trunk/reactos/boot/freeldr/freeldr/arch/i386/pcdisk.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/arch/… > > Modified: trunk/reactos/boot/freeldr/freeldr/arch/i386/pcmem.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/arch/… > > Modified: trunk/reactos/boot/freeldr/freeldr/arch/i386/pcvideo.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/arch/… > > Modified: trunk/reactos/boot/freeldr/freeldr/arch/i386/winldr.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/arch/… > > Modified: trunk/reactos/boot/freeldr/freeldr/arch/i386/xboxdisk.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/arch/… > > Modified: trunk/reactos/boot/freeldr/freeldr/arch/i386/xboxhw.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/arch/… > > Modified: trunk/reactos/boot/freeldr/freeldr/cache/blocklist.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/cache… > > Modified: trunk/reactos/boot/freeldr/freeldr/cache/cache.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/cache… > > Modified: trunk/reactos/boot/freeldr/freeldr/debug.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/debug… > > Modified: trunk/reactos/boot/freeldr/freeldr/disk/disk.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/disk/… > > Modified: trunk/reactos/boot/freeldr/freeldr/disk/partition.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/disk/… > > Modified: trunk/reactos/boot/freeldr/freeldr/disk/scsiport.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/disk/… > > Modified: trunk/reactos/boot/freeldr/freeldr/freeldr.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/freel… > > Modified: trunk/reactos/boot/freeldr/freeldr/fs/ext2.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/fs/ex… > > Modified: trunk/reactos/boot/freeldr/freeldr/fs/fat.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/fs/fa… > > Modified: trunk/reactos/boot/freeldr/freeldr/fs/fs.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/fs/fs… > > Modified: trunk/reactos/boot/freeldr/freeldr/fs/iso.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/fs/is… > > Modified: trunk/reactos/boot/freeldr/freeldr/fs/ntfs.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/fs/nt… > > Modified: trunk/reactos/boot/freeldr/freeldr/fs/pxe.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/fs/px… > > Modified: trunk/reactos/boot/freeldr/freeldr/include/debug.h > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/inclu… > > Modified: trunk/reactos/boot/freeldr/freeldr/inifile/inifile.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/inifi… > > Modified: trunk/reactos/boot/freeldr/freeldr/inifile/parse.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/inifi… > > Modified: trunk/reactos/boot/freeldr/freeldr/linuxboot.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/linux… > > Modified: trunk/reactos/boot/freeldr/freeldr/mm/meminit.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/mm/me… > > Modified: trunk/reactos/boot/freeldr/freeldr/mm/mm.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/mm/mm… > > Modified: trunk/reactos/boot/freeldr/freeldr/reactos/binhive.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/react… > > Modified: trunk/reactos/boot/freeldr/freeldr/reactos/registry.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/react… > > Modified: trunk/reactos/boot/freeldr/freeldr/ui/ui.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/ui/ui… > > Modified: trunk/reactos/boot/freeldr/freeldr/windows/conversion.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/windo… > > Modified: trunk/reactos/boot/freeldr/freeldr/windows/peloader.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/windo… > > Modified: trunk/reactos/boot/freeldr/freeldr/windows/setupldr.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/windo… > > Modified: trunk/reactos/boot/freeldr/freeldr/windows/winldr.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/windo… > > Modified: trunk/reactos/boot/freeldr/freeldr/windows/wlmemory.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/windo… > > Modified: trunk/reactos/boot/freeldr/freeldr/windows/wlregistry.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/windo… > > >

14 years

2
1
0 0

Re: [ros-dev] [ros-diffs] [cmihail] 53541: [shell32.dll] - Don't do some parameter checks, even if MSDN says they're incompatible. Winetests with windows 2003 server as reference tells us msdn lies. (Spotted by Victor Marti...

by Alex Ionescu

Just because the checks aren't in THIS api doesn't mean MSDN lies. Best regards, Alex Ionescu On Sat, Sep 3, 2011 at 11:55 AM, <cmihail(a)svn.reactos.org> wrote: > Author: cmihail > Date: Sat Sep 3 10:55:51 2011 > New Revision: 53541 > > URL: http://svn.reactos.org/svn/reactos?rev=53541&view=rev > Log: > [shell32.dll] > - Don't do some parameter checks, even if MSDN says they're incompatible. > Winetests with windows 2003 server as reference tells us msdn lies. (Spotted > by Victor Martinez) > > Modified: > branches/shell32_new-bringup/dll/win32/shell32/shell32_main.cpp > > Modified: branches/shell32_new-bringup/dll/win32/shell32/shell32_main.cpp > URL: > http://svn.reactos.org/svn/reactos/branches/shell32_new-bringup/dll/win32/s… > > ============================================================================== > --- branches/shell32_new-bringup/dll/win32/shell32/shell32_main.cpp > [iso-8859-1] (original) > +++ branches/shell32_new-bringup/dll/win32/shell32/shell32_main.cpp > [iso-8859-1] Sat Sep 3 10:55:51 2011 > @@ -330,9 +330,6 @@ > (flags & SHGFI_PIDL)? "pidl" : debugstr_w(path), > dwFileAttributes, > psfi, psfi->dwAttributes, sizeofpsfi, flags); > > - if ( (flags & SHGFI_USEFILEATTRIBUTES) && > - (flags & (SHGFI_ATTRIBUTES|SHGFI_EXETYPE|SHGFI_PIDL))) > - return FALSE; > if (!path) > return FALSE; > > > >

14 years

2
1
0 0

Re: [ros-dev] [ros-diffs] [cmihail] 53537: [shell32.dll] [FORMATTING] - Format the code to a more acceptable level. This is just for my sanity while sifting through it.

by Timo Kreuzer

Am 03.09.2011 02:08, schrieb cmihail(a)svn.reactos.org: > Author: cmihail > Date: Sat Sep 3 00:08:11 2011 > New Revision: 53537 > > URL:http://svn.reactos.org/svn/reactos?rev=53537&view=rev > Log: > [shell32.dll] > [FORMATTING] > - Format the code to a more acceptable level. This is just for my sanity while sifting through it. > /* skip the remaining spaces */ > - while (*cs==0x0009 || *cs==0x0020) { > + while (*cs==0x0009 || *cs==0x0020) > + { > cs++; > } > if (*cs==0) > Please don't mix tabs and spaces or we'll end up looking like GNU style ;-) Since the file already uses spaces (as we use almost everywhere), please stick to that here. Regards, Timo

14 years

3
2
0 0

Re: [ros-dev] [ros-diffs] [akhaldi] 53527: [WIN32K] * Remove some useless asserts considering cLockObj is DWORD.

by Alex Ionescu

These asserts are not useless. A DWORD can also underflow (due to a bug), hence the point of these ASSERTs -- the only bug is that the ASSERT should cast to LONG. Best regards, Alex Ionescu On Fri, Sep 2, 2011 at 9:23 AM, <akhaldi(a)svn.reactos.org> wrote: > Author: akhaldi > Date: Fri Sep 2 09:23:20 2011 > New Revision: 53527 > > URL: http://svn.reactos.org/svn/reactos?rev=53527&view=rev > Log: > [WIN32K] > * Remove some useless asserts considering cLockObj is DWORD. > > Modified: > trunk/reactos/subsystems/win32/win32k/ntuser/menu.c > trunk/reactos/subsystems/win32/win32k/ntuser/monitor.c > trunk/reactos/subsystems/win32/win32k/ntuser/window.c > > Modified: trunk/reactos/subsystems/win32/win32k/ntuser/menu.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/nt… > > ============================================================================== > --- trunk/reactos/subsystems/win32/win32k/ntuser/menu.c [iso-8859-1] > (original) > +++ trunk/reactos/subsystems/win32/win32k/ntuser/menu.c [iso-8859-1] Fri > Sep 2 09:23:20 2011 > @@ -74,7 +74,6 @@ > return NULL; > } > > - ASSERT(Menu->head.cLockObj >= 0); > return Menu; > } > > @@ -137,11 +136,8 @@ > { > PMENU_OBJECT Menu = UserGetMenuObject(hMenu); > if (Menu) > - { > - ASSERT(Menu->head.cLockObj >= 0); > - > Menu->head.cLockObj++; > - } > + > return Menu; > } > > > Modified: trunk/reactos/subsystems/win32/win32k/ntuser/monitor.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/nt… > > ============================================================================== > --- trunk/reactos/subsystems/win32/win32k/ntuser/monitor.c [iso-8859-1] > (original) > +++ trunk/reactos/subsystems/win32/win32k/ntuser/monitor.c [iso-8859-1] Fri > Sep 2 09:23:20 2011 > @@ -93,8 +93,6 @@ > return NULL; > } > > - ASSERT(Monitor->head.cLockObj >= 0); > - > return Monitor; > } > > > Modified: trunk/reactos/subsystems/win32/win32k/ntuser/window.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/nt… > > ============================================================================== > --- trunk/reactos/subsystems/win32/win32k/ntuser/window.c [iso-8859-1] > (original) > +++ trunk/reactos/subsystems/win32/win32k/ntuser/window.c [iso-8859-1] Fri > Sep 2 09:23:20 2011 > @@ -61,11 +61,8 @@ > > Window = UserGetWindowObject(hWnd); > if (Window) > - { > - ASSERT(Window->head.cLockObj >= 0); > - > Window->head.cLockObj++; > - } > + > return Window; > } > > @@ -86,8 +83,6 @@ > EngSetLastError(ERROR_INVALID_WINDOW_HANDLE); > return NULL; > } > - > - ASSERT(Window->head.cLockObj >= 0); > > return Window; > } > > >

14 years

3
2
0 0

Re: [ros-dev] [ros-diffs] [dchapyshev] 53516: - Fix typos, found by PVS-Studio

by Thomas Faber

Hey again, On 2011-09-01 15:18, dchapyshev(a)svn.reactos.org wrote: > --- trunk/reactos/dll/win32/netshell/lanstatusui.c [iso-8859-1] (original) > +++ trunk/reactos/dll/win32/netshell/lanstatusui.c [iso-8859-1] Thu Sep 1 13:18:22 2011 > @@ -179,7 +179,7 @@ > pContext->Status = 3; > } > } > - else if (IfEntry.dwOperStatus == MIB_IF_OPER_STATUS_UNREACHABLE || MIB_IF_OPER_STATUS_DISCONNECTED) > + else if (IfEntry.dwOperStatus == MIB_IF_OPER_STATUS_UNREACHABLE | MIB_IF_OPER_STATUS_DISCONNECTED) > { > if (pContext->Status != 4) > { > this should more likely be else if (IfEntry.dwOperStatus == MIB_IF_OPER_STATUS_UNREACHABLE || IfEntry.dwOperStatus == MIB_IF_OPER_STATUS_DISCONNECTED) Some nice fixes right there by the way. :) *hopes this might fix some evil bugs that have been lurking* ;) Thanks, Tom

14 years

1
0
0 0

Re: [ros-dev] [ros-diffs] [dchapyshev] 53513: - Fix wrong macros usage, found by PVS-Studio

by Thomas Faber

Hi, On 2011-09-01 14:34, dchapyshev(a)svn.reactos.org wrote: > --- trunk/reactos/lib/rtl/bitmap.c [iso-8859-1] (original) > +++ trunk/reactos/lib/rtl/bitmap.c [iso-8859-1] Thu Sep 1 12:34:51 2011 > @@ -339,7 +339,7 @@ > } > > /* Set all full ULONGs */ > - RtlFillMemoryUlong(Buffer, NumberToSet >> 3, MAXULONG); > + RtlFillMemoryUlong(Buffer, MAXULONG, NumberToSet >> 3); > Buffer += NumberToSet >> 5; > > /* Set what's left */ > > This is wrong. We don't want to fill 4GB of memory :) Regards, Tom

14 years

1
0
0 0

Re: [ros-dev] [ros-diffs] [jgardou] 53503: [WINETESTS/RPCRT4] Until now, rpcrt4 winetests where badly broken : client calls remotely forwarded to serverside functions which called... client side functions. One has to wonder...

by Aleksey Bragin

This breaks RBUILD-based build. More precisely these lines: +  + <define name="s_IServer_v0_0_s_ifspec">IServer_v0_0_s_ifspec</redefine> it seems to be already defined by something. WBR, Aleksey Bragin. -----Original Message----- From: jgardou(a)svn.reactos.org Sent: Wednesday, August 31, 2011 12:49 AM To: ros-diffs(a)reactos.org Subject: [ros-diffs] [jgardou] 53503: [WINETESTS/RPCRT4] Until now, rpcrt4 winetests where badly broken : client calls remotely forwarded to serverside functions which called... client side functions. One has to wonder... Author: jgardou Date: Tue Aug 30 20:49:31 2011 New Revision: 53503 URL: http://svn.reactos.org/svn/reactos?rev=53503&view=rev Log: [WINETESTS/RPCRT4] Until now, rpcrt4 winetests where badly broken : client calls remotely forwarded to serverside functions which called... client side functions. One has to wonder how testbot survived the operation - Cmake : fix that - rbuild : add a hack keeping the old behaviour, because I don't know how to make this right Modified: trunk/rostests/winetests/rpcrt4/CMakeLists.txt trunk/rostests/winetests/rpcrt4/rpcrt4.rbuild trunk/rostests/winetests/rpcrt4/server.c Modified: trunk/rostests/winetests/rpcrt4/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/rostests/winetests/rpcrt4/CMakeLis… ============================================================================== --- trunk/rostests/winetests/rpcrt4/CMakeLists.txt [iso-8859-1] (original) +++ trunk/rostests/winetests/rpcrt4/CMakeLists.txt [iso-8859-1] Tue Aug 30 20:49:31 2011 @@ -5,9 +5,16 @@ add_definitions( -D__ROS_LONG64__ -D_DLL -D__USE_CRTIMP) + +if(MSVC) + set(IDL_FLAGS ${IDL_FLAGS} /prefix server s_) +else() + set(IDL_FLAGS ${IDL_FLAGS} --prefix-server=s_) +endif() add_rpc_files(client server.idl) add_rpc_files(server server.idl) +unset(IDL_FLAGS) list(APPEND SOURCE cstub.c Modified: trunk/rostests/winetests/rpcrt4/rpcrt4.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/rostests/winetests/rpcrt4/rpcrt4.r… ============================================================================== --- trunk/rostests/winetests/rpcrt4/rpcrt4.rbuild [iso-8859-1] (original) +++ trunk/rostests/winetests/rpcrt4/rpcrt4.rbuild [iso-8859-1] Tue Aug 30 20:49:31 2011 @@ -12,6 +12,8 @@ <include root="intermediate" base="rpcrt4_winetest">.</include> <define name="__ROS_LONG64__" /> <redefine name="_WIN32_WINNT">0x0500</redefine> +  + <define name="s_IServer_v0_0_s_ifspec">IServer_v0_0_s_ifspec</redefine> <library>wine</library> <library>pseh</library> <library>ole32</library> Modified: trunk/rostests/winetests/rpcrt4/server.c URL: http://svn.reactos.org/svn/reactos/trunk/rostests/winetests/rpcrt4/server.c… ============================================================================== --- trunk/rostests/winetests/rpcrt4/server.c [iso-8859-1] (original) +++ trunk/rostests/winetests/rpcrt4/server.c [iso-8859-1] Tue Aug 30 20:49:31 2011 @@ -1542,12 +1542,12 @@ if (pRpcServerRegisterIfEx) { trace("Using RpcServerRegisterIfEx\n"); - status = pRpcServerRegisterIfEx(IServer_v0_0_s_ifspec, NULL, NULL, + status = pRpcServerRegisterIfEx(s_IServer_v0_0_s_ifspec, NULL, NULL, RPC_IF_ALLOW_CALLBACKS_WITH_NO_AUTH, RPC_C_LISTEN_MAX_CALLS_DEFAULT, NULL); } else - status = RpcServerRegisterIf(IServer_v0_0_s_ifspec, NULL, NULL); + status = RpcServerRegisterIf(s_IServer_v0_0_s_ifspec, NULL, NULL); ok(status == RPC_S_OK, "RpcServerRegisterIf failed with status %d\n", status); status = RpcServerListen(1, 20, TRUE); ok(status == RPC_S_OK, "RpcServerListen failed with status %d\n", status);

14 years

1
0
0 0

Re: [ros-dev] [ros-diffs] [tkreuzer] 53496: [HAL] We cannot make any assumptions about the latency whith which the timer interrupt fires after a rollover, since VBox (other VMs probably as well) doesn't always meet this. Ad...

by Alex Ionescu

Funny how Windows works without these hacks. Let's hide more bugs :D Best regards, Alex Ionescu On Tue, Aug 30, 2011 at 12:01 PM, <tkreuzer(a)svn.reactos.org> wrote: > Author: tkreuzer > Date: Tue Aug 30 12:01:01 2011 > New Revision: 53496 > > URL: http://svn.reactos.org/svn/reactos?rev=53496&view=rev > Log: > [HAL] > We cannot make any assumptions about the latency whith which the timer > interrupt fires after a rollover, since VBox (other VMs probably as well) > doesn't always meet this. Add another check to KeQueryPerformanceCounter > that gracefully handles missing interrupts. Also raise to DISPATCH_LEVEL, > since the function is not reentrant. > > Modified: > trunk/reactos/hal/halx86/generic/timer.c > > Modified: trunk/reactos/hal/halx86/generic/timer.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/hal/halx86/generic/timer.c… > > ============================================================================== > --- trunk/reactos/hal/halx86/generic/timer.c [iso-8859-1] (original) > +++ trunk/reactos/hal/halx86/generic/timer.c [iso-8859-1] Tue Aug 30 > 12:01:01 2011 > @@ -253,6 +253,7 @@ > { > LARGE_INTEGER CurrentPerfCounter; > ULONG CounterValue, ClockDelta; > + KIRQL OldIrql; > > /* If caller wants performance frequency, return hardcoded value */ > if (PerformanceFrequency) PerformanceFrequency->QuadPart = > PIT_FREQUENCY; > @@ -262,6 +263,10 @@ > > /* Check if interrupts are disabled */ > if(!(__readeflags() & EFLAGS_INTERRUPT_MASK)) return HalpPerfCounter; > + > + /* Raise irql to DISPATCH_LEVEL */ > + OldIrql = KeGetCurrentIrql(); > + if (OldIrql < DISPATCH_LEVEL) KfRaiseIrql(DISPATCH_LEVEL); > > do > { > @@ -287,13 +292,21 @@ > /* Add the clock delta */ > CurrentPerfCounter.QuadPart += ClockDelta; > > - /* This must be true unless HalpPerfCounter has changed sign, > - which takes approximately 245,118 years */ > - ASSERT(CurrentPerfCounter.QuadPart >= HalpLastPerfCounter.QuadPart); > + /* Check if the value is smaller then before, this means, we somehow > + missed an interrupt. This is a sign that the timer interrupt > + is very inaccurate. Probably a virtual machine. */ > + if (CurrentPerfCounter.QuadPart < HalpLastPerfCounter.QuadPart) > + { > + /* We missed an interrupt. Assume we will receive it later */ > + CurrentPerfCounter.QuadPart += HalpCurrentRollOver; > + } > > /* Update the last counter value */ > HalpLastPerfCounter = CurrentPerfCounter; > > + /* Restore previous irql */ > + if (OldIrql < DISPATCH_LEVEL) KfLowerIrql(OldIrql); > + > /* Return the result */ > return CurrentPerfCounter; > } > > >

14 years

2
1
0 0

ReactOS unattended.inf

by Mario Gzuk

Hi, I am the maintainer of uranos (http://uranos.sf.net) and want to implement the unattended setup of ReactOS into uranos. I read that you have implemented a answer file into ReactOS. Because of uranos does all the parts which is done by the txtinstaller from ReactOS (partition disk, write mbr, copy files and so on) from a linux boot environment - I want to know if it is possible to place the unattended.inf into the filesystem so the ReactOS is read the file in the first GUI boot. Thank you! Cheers mario

14 years

3
5
0 0

Re: [ros-dev] [ros-diffs] [tkreuzer] 53494: [INTRIN] - add __nop()

by Alex Ionescu

Can you also add __noop please? Best regards, Alex Ionescu On Mon, Aug 29, 2011 at 11:10 PM, <tkreuzer(a)svn.reactos.org> wrote: > Author: tkreuzer > Date: Mon Aug 29 23:10:04 2011 > New Revision: 53494 > > URL: http://svn.reactos.org/svn/reactos?rev=53494&view=rev > Log: > [INTRIN] > - add __nop() > > Modified: > trunk/reactos/include/crt/mingw32/intrin_x86.h > > Modified: trunk/reactos/include/crt/mingw32/intrin_x86.h > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/include/crt/mingw32/intrin… > > ============================================================================== > --- trunk/reactos/include/crt/mingw32/intrin_x86.h [iso-8859-1] (original) > +++ trunk/reactos/include/crt/mingw32/intrin_x86.h [iso-8859-1] Mon Aug 29 > 23:10:04 2011 > @@ -1505,11 +1505,18 @@ > __asm__ __volatile__("sidt %0" : : "m"(*(short*)Destination) : > "memory"); > } > > +/*** Misc operations ***/ > + > __INTRIN_INLINE void _mm_pause(void) > { > __asm__ __volatile__("pause" : : : "memory"); > } > > +__INTRIN_INLINE void __nop(void) > +{ > + __asm__ __volatile__("nop"); > +} > + > #ifdef __cplusplus > } > #endif > > >

14 years

2
1
0 0

Re: [ros-dev] [ros-diffs] [jgardou] 53481: [WIDL] - reenable -Oif flag, it's too good to be disabled With this commit, advapi32:service winetest suffers only 2 failures.

by Jérôme Gardou

Feel free to disable it again if probems occur. "Probable bugs" are hard to test alone, so I'm waiting for test bot to confirm this fixes things without breaking others. Regards. Jérôme. Le 28/08/2011 17:37, jgardou(a)svn.reactos.org a écrit : > Author: jgardou > Date: Sun Aug 28 15:37:01 2011 > New Revision: 53481 > > URL: http://svn.reactos.org/svn/reactos?rev=53481&view=rev > Log: > [WIDL] > - reenable -Oif flag, it's too good to be disabled > With this commit, advapi32:service winetest suffers only 2 failures. > > Modified: > trunk/reactos/cmake/idl-support.cmake > trunk/reactos/tools/rbuild/backend/mingw/rules.mak > > Modified: trunk/reactos/cmake/idl-support.cmake > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/cmake/idl-support.cmake?re… > ============================================================================== > --- trunk/reactos/cmake/idl-support.cmake [iso-8859-1] (original) > +++ trunk/reactos/cmake/idl-support.cmake [iso-8859-1] Sun Aug 28 15:37:01 2011 > @@ -22,8 +22,8 @@ > set(IDL_HEADER_ARG -h -o) #.h > set(IDL_HEADER_ARG2 -h -H) #.h > set(IDL_TYPELIB_ARG -t -o) #.tlb > - set(IDL_SERVER_ARG -s -o) #.c for server library > - set(IDL_CLIENT_ARG -c -o) #.c for stub client library > + set(IDL_SERVER_ARG -Oif -s -o) #.c for server library > + set(IDL_CLIENT_ARG -Oif -c -o) #.c for stub client library > set(IDL_PROXY_ARG -p -o) > set(IDL_INTERFACE_ARG -u -o) > if(ARCH MATCHES i386) > @@ -169,6 +169,6 @@ > list(APPEND IID_SOURCES ${NAME}_i.c) > endforeach() > add_library(${TARGET} ${IID_SOURCES}) > - add_dependencies(${TARGET} psdk) > + add_dependencies(${TARGET} psdk) > set_target_properties(${TARGET} PROPERTIES EXCLUDE_FROM_ALL TRUE) > endfunction() > > Modified: trunk/reactos/tools/rbuild/backend/mingw/rules.mak > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/tools/rbuild/backend/mingw… > ============================================================================== > --- trunk/reactos/tools/rbuild/backend/mingw/rules.mak [iso-8859-1] (original) > +++ trunk/reactos/tools/rbuild/backend/mingw/rules.mak [iso-8859-1] Sun Aug 28 15:37:01 2011 > @@ -264,7 +264,7 @@ > > ${call RBUILD_intermediate_path_noext,$(2)}_c: $(2) $(3) $$(widl_TARGET) | ${call RBUILD_intermediate_dir,$(2)} > $$(ECHO_WIDL) > - $$(Q)$$(widl_TARGET) ${call RBUILD_midlflags,$(1),$(4),-I${call RBUILD_dir,$(2)}} -h -H ${call RBUILD_intermediate_path_noext,$(2)}_c.h -c -C ${call RBUILD_intermediate_path_noext,$(2)}_c.c $(2) > + $$(Q)$$(widl_TARGET) ${call RBUILD_midlflags,$(1),$(4),-I${call RBUILD_dir,$(2)}} -Oif -h -H ${call RBUILD_intermediate_path_noext,$(2)}_c.h -c -C ${call RBUILD_intermediate_path_noext,$(2)}_c.c $(2) > $${checkpoint} $$@>$(NUL) > > ${call RBUILD_CC,$(1),${call RBUILD_intermediate_path_noext,$(2)}_c.c,,,${call RBUILD_intermediate_path_noext,$(2)}_c.o} > @@ -280,7 +280,7 @@ > > ${call RBUILD_intermediate_path_noext,$(2)}_s: $(2) $(3) $$(widl_TARGET) | ${call RBUILD_intermediate_dir,$(2)} > $$(ECHO_WIDL) > - $$(Q)$$(widl_TARGET) ${call RBUILD_midlflags,$(1),$(4),-I${call RBUILD_dir,$(2)}} -h -H ${call RBUILD_intermediate_path_noext,$(2)}_s.h -s -S ${call RBUILD_intermediate_path_noext,$(2)}_s.c $(2) > + $$(Q)$$(widl_TARGET) ${call RBUILD_midlflags,$(1),$(4),-I${call RBUILD_dir,$(2)}} -Oif -h -H ${call RBUILD_intermediate_path_noext,$(2)}_s.h -s -S ${call RBUILD_intermediate_path_noext,$(2)}_s.c $(2) > $${checkpoint} $$@>$(NUL) > > ${call RBUILD_CC,$(1),${call RBUILD_intermediate_path_noext,$(2)}_s.c,,,${call RBUILD_intermediate_path_noext,$(2)}_s.o} > >

14 years

3
2
0 0

(no subject)

by Dimas FranK

I want to do some testing on physical machines until now was doing the vbox will charge the machine a good desepenho memory and I'll need to spend sitema ospedeiro vbox and the problem and that the machines do not have a serial port was taking a look at these wiki but did not see exact references on how to get the debug log on the cable network vbox but works well for the network that will be with you http://www.reactos.org/wiki/Debugging http://www.reactos.org/wiki/ReactOS_Remote_Debugger#TCP.2FIP_.28QEMU_only.29

14 years

3
2
0 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev