- Ros-dev - ReactOS.org

Buildbot issue
by Pierre Schweitzer 24 May '11

24 May '11

Hi, it appears that Linux buildbot is running a bad issue and is looping on building. If anyone can have a look? To prevent flood on IRC, I silent bot and removed voice. Thanks in advance

3 4

Re: [ros-dev] [ros-diffs] [osiejka] 51874: [RPCSS] Addenum. This change slipped past in commit 51873. Fix name of irot header include, which should be irot.h and not irot_s.h. Fixes rpcss build in MSVC.
by Ged Murphy 24 May '11

24 May '11

That was very confusing :) -----Original Message----- From: ros-diffs-bounces(a)reactos.org [mailto:ros-diffs-bounces@reactos.org] On Behalf Of osiejka(a)svn.reactos.org Sent: 23 May 2011 22:49 To: ros-diffs(a)reactos.org Subject: [ros-diffs] [osiejka] 51874: [RPCSS] Addenum. This change slipped past in commit 51873. Fix name of irot header include, which should be irot.h and not irot_s.h. Fixes rpcss build in MSVC. Author: osiejka Date: Mon May 23 21:49:12 2011 New Revision: 51874 URL: http://svn.reactos.org/svn/reactos?rev=51874&view=rev Log: [RPCSS] Addenum. This change slipped past in commit 51873. Fix name of irot header include, which should be irot.h and not irot_s.h. Fixes rpcss build in MSVC. Modified: trunk/reactos/base/services/rpcss/irotp.c Modified: trunk/reactos/base/services/rpcss/irotp.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/services/rpcss/irotp.… ============================================================================== --- trunk/reactos/base/services/rpcss/irotp.c [iso-8859-1] (original) +++ trunk/reactos/base/services/rpcss/irotp.c [iso-8859-1] Mon May 23 21:49:12 2011 @@ -1,5 +1,5 @@ /* - * Running Object Table + * Running Object Table * * Copyright 2007 Robert Shearman *

2 1

Missing header in rpcss
by Olaf Siejka 22 May '11

22 May '11

It was spotted by MSVC build: P:\Trunk_slave\MSVC-trunk\build\base\services\rpcss\irotp.c(28) : fatal error C1083: Cannot open include file: 'irot_s.h': No such file or directory LINK : fatal error LNK1104: cannot open file 'CMakeFiles/rpcss.dir/irotp.c.obj' In base\services\rpcss\irotp.c:28 we see: #include "irot_s.h" This file is not present in ReactOS trunk. In WINE's RPCSS http://source.winehq.org/git/wine.git/blob/HEAD:/programs/rpcss/irotp.c :28 we have: #include "irot.h" which is also missing, and listed in .gitignore: http://source.winehq.org/git/wine.git/blob?f=.gitignore 260 programs/rpcss/irot.h 261 programs/rpcss/irot_s.c I think we can safely clean it up, perhaps adding proper line to ros-diff, but i would like to ask you guys for confirmation. Regards

2 3

Re: [ros-dev] [ros-diffs] [jimtabor] 51835: [Win32k|User32] - Move creation of the scrollbar Gray brush from user32 to win32k. - Noticed a color and pattern (patchy white pattern) difference when using GreCreateBitmap and i...
by Timo Kreuzer 22 May '11

22 May '11

Hi, I suspect its an alignment issue, since GreCreateBitmap requires 32bit alignment, while CreateBitmap uses 16 bit alignment. So changing + static const WORD wPattern55AA[] = { 0x5555, 0xaaaa, 0x5555, 0xaaaa, 0x5555, 0xaaaa, 0x5555, 0xaaaa }; to + static const DWORD wPattern55AA[] = { 0x5555, 0xaaaa, 0x5555, 0xaaaa, 0x5555, 0xaaaa, 0x5555, 0xaaaa }; Should do the trick. Am 21.05.2011 08:34, schrieb jimtabor(a)svn.reactos.org: > Author: jimtabor > Date: Sat May 21 06:34:02 2011 > New Revision: 51835 > > URL: http://svn.reactos.org/svn/reactos?rev=51835&view=rev > Log: > [Win32k|User32] > - Move creation of the scrollbar Gray brush from user32 to win32k. > - Noticed a color and pattern (patchy white pattern) difference when using GreCreateBitmap and it did not work the same as the main function. Correcting this fixed the Gray brush. Someone from YAROTOWS needs to look into this. > > Modified: > trunk/reactos/dll/win32/user32/windows/defwnd.c > trunk/reactos/subsystems/win32/win32k/include/brush.h > trunk/reactos/subsystems/win32/win32k/ntuser/ntuser.c > trunk/reactos/subsystems/win32/win32k/objects/bitmaps.c > trunk/reactos/subsystems/win32/win32k/objects/brush.c > > Modified: trunk/reactos/dll/win32/user32/windows/defwnd.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/d… > ============================================================================== > --- trunk/reactos/dll/win32/user32/windows/defwnd.c [iso-8859-1] (original) > +++ trunk/reactos/dll/win32/user32/windows/defwnd.c [iso-8859-1] Sat May 21 06:34:02 2011 > @@ -927,8 +927,8 @@ > HBRUSH > DefWndControlColor(HDC hDC, UINT ctlType) > { > - if (CTLCOLOR_SCROLLBAR == ctlType) > - { > + if (ctlType == CTLCOLOR_SCROLLBAR) > + { > HBRUSH hb = GetSysColorBrush(COLOR_SCROLLBAR); > COLORREF bk = GetSysColor(COLOR_3DHILIGHT); > SetTextColor(hDC, GetSysColor(COLOR_3DFACE)); > @@ -938,37 +938,24 @@ > * we better use 0x55aa bitmap brush to make scrollbar's background > * look different from the window background. > */ > - if (bk == GetSysColor(COLOR_WINDOW)) > - { > - static const WORD wPattern55AA[] = > - { > - 0x5555, 0xaaaa, 0x5555, 0xaaaa, > - 0x5555, 0xaaaa, 0x5555, 0xaaaa > - }; > - static HBITMAP hPattern55AABitmap = NULL; > - static HBRUSH hPattern55AABrush = NULL; > - if (hPattern55AABrush == NULL) > - { > - hPattern55AABitmap = CreateBitmap(8, 8, 1, 1, wPattern55AA); > - hPattern55AABrush = CreatePatternBrush(hPattern55AABitmap); > - } > - return hPattern55AABrush; > - } > - UnrealizeObject(hb); > + if ( bk == GetSysColor(COLOR_WINDOW)) > + return gpsi->hbrGray; > + > + UnrealizeObject( hb ); > return hb; > - } > + } > > SetTextColor(hDC, GetSysColor(COLOR_WINDOWTEXT)); > > - if ((CTLCOLOR_EDIT == ctlType) || (CTLCOLOR_LISTBOX == ctlType)) > - { > + if ((ctlType == CTLCOLOR_EDIT) || (ctlType == CTLCOLOR_LISTBOX)) > + { > SetBkColor(hDC, GetSysColor(COLOR_WINDOW)); > - } > + } > else > - { > + { > SetBkColor(hDC, GetSysColor(COLOR_3DFACE)); > return GetSysColorBrush(COLOR_3DFACE); > - } > + } > > return GetSysColorBrush(COLOR_WINDOW); > } > > Modified: trunk/reactos/subsystems/win32/win32k/include/brush.h > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/in… > ============================================================================== > --- trunk/reactos/subsystems/win32/win32k/include/brush.h [iso-8859-1] (original) > +++ trunk/reactos/subsystems/win32/win32k/include/brush.h [iso-8859-1] Sat May 21 06:34:02 2011 > @@ -129,3 +129,5 @@ > VOID FASTCALL FreeObjectAttr(PVOID); > > BOOL FASTCALL IntGdiSetBrushOwner(PBRUSH,DWORD); > +BOOL FASTCALL GreSetBrushOwner(HBRUSH,DWORD); > + > > Modified: trunk/reactos/subsystems/win32/win32k/ntuser/ntuser.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/nt… > ============================================================================== > --- trunk/reactos/subsystems/win32/win32k/ntuser/ntuser.c [iso-8859-1] (original) > +++ trunk/reactos/subsystems/win32/win32k/ntuser/ntuser.c [iso-8859-1] Sat May 21 06:34:02 2011 > @@ -92,6 +92,8 @@ > HANDLE hPowerRequestEvent, > HANDLE hMediaRequestEvent) > { > + static const WORD wPattern55AA[] = { 0x5555, 0xaaaa, 0x5555, 0xaaaa, 0x5555, 0xaaaa, 0x5555, 0xaaaa }; > + HBITMAP hPattern55AABitmap = NULL; > NTSTATUS Status; > > // Set W32PF_Flags |= (W32PF_READSCREENACCESSGRANTED | W32PF_IOWINSTA) > @@ -125,6 +127,14 @@ > > CsrInit(); > > + if (gpsi->hbrGray == NULL) > + { > + hPattern55AABitmap = GreCreateBitmap(8, 8, 1, 1, (LPBYTE)wPattern55AA); > + gpsi->hbrGray = IntGdiCreatePatternBrush(hPattern55AABitmap); > + GreDeleteObject(hPattern55AABitmap); > + GreSetBrushOwner(gpsi->hbrGray, GDI_OBJ_HMGR_PUBLIC); > + } > + > return STATUS_SUCCESS; > } > > > Modified: trunk/reactos/subsystems/win32/win32k/objects/bitmaps.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/ob… > ============================================================================== > --- trunk/reactos/subsystems/win32/win32k/objects/bitmaps.c [iso-8859-1] (original) > +++ trunk/reactos/subsystems/win32/win32k/objects/bitmaps.c [iso-8859-1] Sat May 21 06:34:02 2011 > @@ -154,15 +154,23 @@ > IN UINT cBitsPixel, > IN OPTIONAL PVOID pvBits) > { > + HBITMAP hbmp; > /* Call the extended function */ > - return GreCreateBitmapEx(nWidth, > + hbmp = GreCreateBitmapEx(nWidth, > nHeight, > 0, /* auto width */ > BitmapFormat(cBitsPixel * cPlanes, BI_RGB), > 0, /* no bitmap flags */ > 0, /* auto size */ > - pvBits, > - DDB_SURFACE /* DDB */); > + NULL, > + DDB_SURFACE /* DDB */); > + if (pvBits&& hbmp) > + { > + PSURFACE psurf = SURFACE_ShareLockSurface(hbmp); > + UnsafeSetBitmapBits(psurf, 0, pvBits); > + SURFACE_ShareUnlockSurface(psurf); > + } > + return hbmp; > } > > HBITMAP > > Modified: trunk/reactos/subsystems/win32/win32k/objects/brush.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/ob… > ============================================================================== > --- trunk/reactos/subsystems/win32/win32k/objects/brush.c [iso-8859-1] (original) > +++ trunk/reactos/subsystems/win32/win32k/objects/brush.c [iso-8859-1] Sat May 21 06:34:02 2011 > @@ -59,6 +59,19 @@ > GDIOBJ_vSetObjectOwner(&pbr->BaseObject, ulOwner); > > return TRUE; > +} > + > +BOOL > +FASTCALL > +GreSetBrushOwner(HBRUSH hBrush, ULONG ulOwner) > +{ > + BOOL Ret; > + PBRUSH pbrush; > + > + pbrush = BRUSH_ShareLockBrush(hBrush); > + Ret = IntGdiSetBrushOwner(pbrush, ulOwner); > + BRUSH_ShareUnlockBrush(pbrush); > + return Ret; > } > > BOOL > > >

5 7

unsubscribe
by He Junyan 21 May '11

21 May '11

2 1

shell32 vs. shell32_new
by Gregor Schneider 19 May '11

19 May '11

Hi ros-dev, I've seen shell32_new being added into trunk by r51768, but haven't heard of anything else about it. From what I can see it changes shell32 from C to C++, which looks like a good move. Problematic seems to me that it is completely out of sync with trunk's shell32 (judging from the translations alone). It might also be annoying for merging future patches, since the C to C++ move changes the code substantially. So are there any plans concering shell32_new? Do I have to merge all code changes in C and C++ or is shell32(_old) going to be dumped anytime soon? Best regards, Gregor

2 1

Re: [ros-dev] [ros-diffs] [ekohl] 51813: [MSPORTS] - Implement a simple class installer that assigns the friendly name "Serial Port (COMx)" to all serial ports. - Enable the class installer in ports.inf. - Add parallel port...
by Alex Ionescu 18 May '11

18 May '11

The source code for msports is already available in the DDK. -- Best regards, Alex Ionescu On 2011-05-17, at 3:24 PM, ekohl(a)svn.reactos.org wrote: > Author: ekohl > Date: Tue May 17 19:24:19 2011 > New Revision: 51813 > > URL: http://svn.reactos.org/svn/reactos?rev=51813&view=rev > Log: > [MSPORTS] > - Implement a simple class installer that assigns the friendly name "Serial Port (COMx)" to all serial ports. > - Enable the class installer in ports.inf. > - Add parallel port installer configuration to ports.inf (disabled). > > Added: > trunk/reactos/dll/win32/msports/ (with props) > trunk/reactos/dll/win32/msports/CMakeLists.txt (with props) > trunk/reactos/dll/win32/msports/classinst.c (with props) > trunk/reactos/dll/win32/msports/msports.c (with props) > trunk/reactos/dll/win32/msports/msports.rbuild (with props) > trunk/reactos/dll/win32/msports/msports.rc (with props) > trunk/reactos/dll/win32/msports/msports.spec (with props) > Modified: > trunk/reactos/baseaddress.cmake > trunk/reactos/baseaddress.rbuild > trunk/reactos/boot/bootdata/packages/reactos.dff > trunk/reactos/dll/win32/CMakeLists.txt > trunk/reactos/dll/win32/win32.rbuild > trunk/reactos/media/inf/ports.inf > > Modified: trunk/reactos/baseaddress.cmake > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/baseaddress.cmake?rev=5181… > ============================================================================== > --- trunk/reactos/baseaddress.cmake [iso-8859-1] (original) > +++ trunk/reactos/baseaddress.cmake [iso-8859-1] Tue May 17 19:24:19 2011 > @@ -49,6 +49,7 @@ > set(baseaddress_netid 0x5f660000) > set(baseaddress_ntprint 0x5f6a0000) > set(baseaddress_mssip32 0x60430000) > +set(baseaddress_msports 0x60450000) > set(baseaddress_msisip 0x60b10000) > set(baseaddress_inseng 0x61000000) > set(baseaddress_qedit 0x611c0000) > > Modified: trunk/reactos/baseaddress.rbuild > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/baseaddress.rbuild?rev=518… > ============================================================================== > --- trunk/reactos/baseaddress.rbuild [iso-8859-1] (original) > +++ trunk/reactos/baseaddress.rbuild [iso-8859-1] Tue May 17 19:24:19 2011 > @@ -52,6 +52,7 @@ > <property name="BASEADDRESS_NETID" value="0x5f660000" /> > <property name="BASEADDRESS_NTPRINT" value="0x5f6a0000" /> > <property name="BASEADDRESS_MSSIP32" value="0x60430000" /> > + <property name="BASEADDRESS_MSPORTS" value="0x60450000" /> > <property name="BASEADDRESS_MSISIP" value="0x60b10000" /> > <property name="BASEADDRESS_INSENG" value="0x61000000" /> > <property name="BASEADDRESS_QEDIT" value="0x611c0000" /> > > Modified: trunk/reactos/boot/bootdata/packages/reactos.dff > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/bootdata/packages/rea… > ============================================================================== > --- trunk/reactos/boot/bootdata/packages/reactos.dff [iso-8859-1] (original) > +++ trunk/reactos/boot/bootdata/packages/reactos.dff [iso-8859-1] Tue May 17 19:24:19 2011 > @@ -357,6 +357,7 @@ > dll\win32\msisip\msisip.dll 1 > dll\win32\msisys.ocx\msisys.ocx 1 > dll\win32\msnet32\msnet32.dll 1 > +dll\win32\msports\msports.dll 1 > dll\win32\msrle32\msrle32.dll 1 > dll\win32\mssign32\mssign32.dll 1 > dll\win32\mssip32\mssip32.dll 1 > > Modified: trunk/reactos/dll/win32/CMakeLists.txt > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/CMakeLists.txt?r… > ============================================================================== > --- trunk/reactos/dll/win32/CMakeLists.txt [iso-8859-1] (original) > +++ trunk/reactos/dll/win32/CMakeLists.txt [iso-8859-1] Tue May 17 19:24:19 2011 > @@ -99,6 +99,7 @@ > add_subdirectory(msisip) > add_subdirectory(msisys.ocx) > #add_subdirectory(msnet32) #to be deleted in trunk. > +add_subdirectory(msports) > add_subdirectory(msrle32) > add_subdirectory(mssign32) > add_subdirectory(mssip32) > > Propchange: trunk/reactos/dll/win32/msports/ > ------------------------------------------------------------------------------ > --- bugtraq:logregex (added) > +++ bugtraq:logregex Tue May 17 19:24:19 2011 > @@ -1,0 +1,2 @@ > +([Ii]ssue|[Bb]ug)s? #?(\d+)(,? ?#?(\d+))*(,? ?(and |or )?#?(\d+))? > +(\d+) > > Propchange: trunk/reactos/dll/win32/msports/ > ------------------------------------------------------------------------------ > bugtraq:message = See issue #%BUGID% for more details. > > Propchange: trunk/reactos/dll/win32/msports/ > ------------------------------------------------------------------------------ > bugtraq:url = http://www.reactos.org/bugzilla/show_bug.cgi?id=%BUGID% > > Propchange: trunk/reactos/dll/win32/msports/ > ------------------------------------------------------------------------------ > tsvn:logminsize = 10 > > Added: trunk/reactos/dll/win32/msports/CMakeLists.txt > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/msports/CMakeLis… > ============================================================================== > --- trunk/reactos/dll/win32/msports/CMakeLists.txt (added) > +++ trunk/reactos/dll/win32/msports/CMakeLists.txt [iso-8859-1] Tue May 17 19:24:19 2011 > @@ -1,0 +1,24 @@ > + > +set_unicode() > + > +spec2def(msports.dll msports.spec) > + > +list(APPEND SOURCE > + classinst.c > + msports.c > + parallel.c > + serial.c > + msports.rc > + ${CMAKE_CURRENT_BINARY_DIR}/msports_stubs.c > + ${CMAKE_CURRENT_BINARY_DIR}/msports.def) > + > +add_library(msports SHARED ${SOURCE}) > + > +set_module_type(msports win32dll) > + > +target_link_libraries(msports wine) > + > +add_importlibs(msports comctl32 setupapi advapi32 user32 kernel32 ntdll) > + > +add_cd_file(TARGET msports DESTINATION reactos/system32 FOR all) > +add_importlib_target(msports.spec) > > Propchange: trunk/reactos/dll/win32/msports/CMakeLists.txt > ------------------------------------------------------------------------------ > svn:eol-style = native > > Propchange: trunk/reactos/dll/win32/msports/CMakeLists.txt > ------------------------------------------------------------------------------ > svn:keywords = author date id revision > > Added: trunk/reactos/dll/win32/msports/classinst.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/msports/classins… > ============================================================================== > --- trunk/reactos/dll/win32/msports/classinst.c (added) > +++ trunk/reactos/dll/win32/msports/classinst.c [iso-8859-1] Tue May 17 19:24:19 2011 > @@ -1,0 +1,250 @@ > +/* > + * PROJECT: ReactOS system libraries > + * LICENSE: GPL - See COPYING in the top level directory > + * FILE: dlls\win32\msports\classinst.c > + * PURPOSE: Ports class installer > + * PROGRAMMERS: Copyright 2011 Eric Kohl > + */ > + > +#include <windows.h> > +#include <setupapi.h> > +#include <wine/debug.h> > + > +WINE_DEFAULT_DEBUG_CHANNEL(msports); > + > + > +typedef enum _PORT_TYPE > +{ > + UnknownPort, > + ParallelPort, > + SerialPort > +} PORT_TYPE; > + > + > +static DWORD > +InstallSerialPort(IN HDEVINFO DeviceInfoSet, > + IN PSP_DEVINFO_DATA DeviceInfoData) > +{ > + LPWSTR pszFriendlyName = L"Serial Port (COMx)"; > + > + TRACE("InstallSerialPort(%p, %p)\n", > + DeviceInfoSet, DeviceInfoData); > + > + /* Install the device */ > + if (!SetupDiInstallDevice(DeviceInfoSet, > + DeviceInfoData)) > + { > + return GetLastError(); > + } > + > + /* Set the friendly name for the device */ > + SetupDiSetDeviceRegistryPropertyW(DeviceInfoSet, > + DeviceInfoData, > + SPDRP_FRIENDLYNAME, > + (LPBYTE)pszFriendlyName, > + (wcslen(pszFriendlyName) + 1) * sizeof(WCHAR)); > + > + return ERROR_SUCCESS; > +} > + > + > +static DWORD > +InstallParallelPort(IN HDEVINFO DeviceInfoSet, > + IN PSP_DEVINFO_DATA DeviceInfoData) > +{ > + FIXME("InstallParallelPort(%p, %p)\n", > + DeviceInfoSet, DeviceInfoData); > + return ERROR_DI_DO_DEFAULT; > +} > + > + > +VOID > +InstallDeviceData(IN HDEVINFO DeviceInfoSet, > + IN PSP_DEVINFO_DATA DeviceInfoData OPTIONAL) > +{ > + HKEY hKey = NULL; > + HINF hInf = INVALID_HANDLE_VALUE; > + SP_DRVINFO_DATA DriverInfoData; > + PSP_DRVINFO_DETAIL_DATA DriverInfoDetailData; > + WCHAR InfSectionWithExt[256]; > + BYTE buffer[2048]; > + DWORD dwRequired; > + > + TRACE("InstallDeviceData()\n"); > + > + hKey = SetupDiCreateDevRegKeyW(DeviceInfoSet, > + DeviceInfoData, > + DICS_FLAG_GLOBAL, > + 0, > + DIREG_DRV, > + NULL, > + NULL); > + if (hKey == NULL) > + goto done; > + > + DriverInfoData.cbSize = sizeof(SP_DRVINFO_DATA); > + if (!SetupDiGetSelectedDriverW(DeviceInfoSet, > + DeviceInfoData, > + &DriverInfoData)) > + { > + goto done; > + } > + > + DriverInfoDetailData = (PSP_DRVINFO_DETAIL_DATA)buffer; > + DriverInfoDetailData->cbSize = sizeof(SP_DRVINFO_DETAIL_DATA); > + if (!SetupDiGetDriverInfoDetailW(DeviceInfoSet, > + DeviceInfoData, > + &DriverInfoData, > + DriverInfoDetailData, > + 2048, > + &dwRequired)) > + { > + if (GetLastError() != ERROR_INSUFFICIENT_BUFFER) > + goto done; > + } > + > + TRACE("Inf file name: %S\n", DriverInfoDetailData->InfFileName); > + > + hInf = SetupOpenInfFileW(DriverInfoDetailData->InfFileName, > + NULL, > + INF_STYLE_WIN4, > + NULL); > + if (hInf == INVALID_HANDLE_VALUE) > + goto done; > + > + TRACE("Section name: %S\n", DriverInfoDetailData->SectionName); > + > + SetupDiGetActualSectionToInstallW(hInf, > + DriverInfoDetailData->SectionName, > + InfSectionWithExt, > + 256, > + NULL, > + NULL); > + > + TRACE("InfSectionWithExt: %S\n", InfSectionWithExt); > + > + SetupInstallFromInfSectionW(NULL, > + hInf, > + InfSectionWithExt, > + SPINST_REGISTRY, > + hKey, > + NULL, > + 0, > + NULL, > + NULL, > + NULL, > + NULL); > + > + TRACE("Done\n"); > + > +done:; > + if (hKey != NULL) > + RegCloseKey(hKey); > + > + if (hInf != INVALID_HANDLE_VALUE) > + SetupCloseInfFile(hInf); > +} > + > + > + > +PORT_TYPE > +GetPortType(IN HDEVINFO DeviceInfoSet, > + IN PSP_DEVINFO_DATA DeviceInfoData) > +{ > + HKEY hKey = NULL; > + DWORD dwSize; > + DWORD dwType = 0; > + BYTE bData = 0; > + PORT_TYPE PortType = UnknownPort; > + LONG lError; > + > + TRACE("GetPortType()\n"); > + > + hKey = SetupDiCreateDevRegKeyW(DeviceInfoSet, > + DeviceInfoData, > + DICS_FLAG_GLOBAL, > + 0, > + DIREG_DRV, > + NULL, > + NULL); > + if (hKey == NULL) > + { > + goto done; > + } > + > + dwSize = sizeof(BYTE); > + lError = RegQueryValueExW(hKey, > + L"PortSubClass", > + NULL, > + &dwType, > + &bData, > + &dwSize); > + > + TRACE("lError: %ld\n", lError); > + TRACE("dwSize: %lu\n", dwSize); > + TRACE("dwType: %lu\n", dwType); > + > + if (lError == ERROR_SUCCESS && > + dwSize == sizeof(BYTE) && > + dwType == REG_BINARY) > + { > + if (bData == 0) > + PortType = ParallelPort; > + else > + PortType = SerialPort; > + } > + > +done:; > + if (hKey != NULL) > + RegCloseKey(hKey); > + > + TRACE("GetPortType() returns %u \n", PortType); > + > + return PortType; > +} > + > + > +static DWORD > +InstallPort(IN HDEVINFO DeviceInfoSet, > + IN PSP_DEVINFO_DATA DeviceInfoData) > +{ > + PORT_TYPE PortType; > + > + InstallDeviceData(DeviceInfoSet, DeviceInfoData); > + > + PortType = GetPortType(DeviceInfoSet, DeviceInfoData); > + switch (PortType) > + { > + case ParallelPort: > + return InstallParallelPort(DeviceInfoSet, DeviceInfoData); > + > + case SerialPort: > + return InstallSerialPort(DeviceInfoSet, DeviceInfoData); > + > + default: > + return ERROR_DI_DO_DEFAULT; > + } > +} > + > + > +DWORD > +WINAPI > +PortsClassInstaller(IN DI_FUNCTION InstallFunction, > + IN HDEVINFO DeviceInfoSet, > + IN PSP_DEVINFO_DATA DeviceInfoData OPTIONAL) > +{ > + TRACE("PortsClassInstaller(%lu, %p, %p)\n", > + InstallFunction, DeviceInfoSet, DeviceInfoData); > + > + switch (InstallFunction) > + { > + case DIF_INSTALLDEVICE: > + return InstallPort(DeviceInfoSet, DeviceInfoData); > + > + default: > + TRACE("Install function %u ignored\n", InstallFunction); > + return ERROR_DI_DO_DEFAULT; > + } > +} > + > +/* EOF */ > > Propchange: trunk/reactos/dll/win32/msports/classinst.c > ------------------------------------------------------------------------------ > svn:eol-style = native > > Propchange: trunk/reactos/dll/win32/msports/classinst.c > ------------------------------------------------------------------------------ > svn:keywords = author date id revision > > Added: trunk/reactos/dll/win32/msports/msports.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/msports/msports.… > ============================================================================== > --- trunk/reactos/dll/win32/msports/msports.c (added) > +++ trunk/reactos/dll/win32/msports/msports.c [iso-8859-1] Tue May 17 19:24:19 2011 > @@ -1,0 +1,33 @@ > +/* > + * PROJECT: Ports installer library > + * LICENSE: GPL - See COPYING in the top level directory > + * FILE: dll/win32/msports/msports.c > + * PURPOSE: Library main function > + * COPYRIGHT: Copyright 2011 Eric Kohl > + */ > + > +#include <windows.h> > +#include <wine/debug.h> > + > + > +WINE_DEFAULT_DEBUG_CHANNEL(msports); > + > + > +BOOL > +WINAPI > +DllMain(HINSTANCE hinstDll, > + DWORD dwReason, > + LPVOID reserved) > +{ > + switch (dwReason) > + { > + case DLL_PROCESS_ATTACH: > + TRACE("DLL_PROCESS_ATTACH\n"); > + DisableThreadLibraryCalls(hinstDll); > + break; > + } > + > + return TRUE; > +} > + > +/* EOF */ > > Propchange: trunk/reactos/dll/win32/msports/msports.c > ------------------------------------------------------------------------------ > svn:eol-style = native > > Propchange: trunk/reactos/dll/win32/msports/msports.c > ------------------------------------------------------------------------------ > svn:keywords = author date id revision > > Added: trunk/reactos/dll/win32/msports/msports.rbuild > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/msports/msports.… > ============================================================================== > --- trunk/reactos/dll/win32/msports/msports.rbuild (added) > +++ trunk/reactos/dll/win32/msports/msports.rbuild [iso-8859-1] Tue May 17 19:24:19 2011 > @@ -1,0 +1,11 @@ > +<module name="msports" type="win32dll" baseaddress="${BASEADDRESS_MSPORTS}" installbase="system32" installname="msports.dll" unicode="yes"> > + <include base="msports">.</include> > + <importlibrary definition="msports.spec" /> > + <library>wine</library> > + <library>kernel32</library> > + <library>advapi32</library> > + <library>setupapi</library> > + <file>classinst.c</file> > + <file>msports.c</file> > + <file>msports.rc</file> > +</module> > > Propchange: trunk/reactos/dll/win32/msports/msports.rbuild > ------------------------------------------------------------------------------ > svn:eol-style = native > > Propchange: trunk/reactos/dll/win32/msports/msports.rbuild > ------------------------------------------------------------------------------ > svn:keywords = author date id revision > > Added: trunk/reactos/dll/win32/msports/msports.rc > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/msports/msports.… > ============================================================================== > --- trunk/reactos/dll/win32/msports/msports.rc (added) > +++ trunk/reactos/dll/win32/msports/msports.rc [iso-8859-1] Tue May 17 19:24:19 2011 > @@ -1,0 +1,7 @@ > +#include <windows.h> > + > +#define REACTOS_VERSION_DLL > +#define REACTOS_STR_FILE_DESCRIPTION "Ports Class Installer\0" > +#define REACTOS_STR_INTERNAL_NAME "msports\0" > +#define REACTOS_STR_ORIGINAL_FILENAME "msports.dll\0" > +#include <reactos/version.rc> > > Propchange: trunk/reactos/dll/win32/msports/msports.rc > ------------------------------------------------------------------------------ > svn:eol-style = native > > Propchange: trunk/reactos/dll/win32/msports/msports.rc > ------------------------------------------------------------------------------ > svn:keywords = author date id revision > > Added: trunk/reactos/dll/win32/msports/msports.spec > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/msports/msports.… > ============================================================================== > --- trunk/reactos/dll/win32/msports/msports.spec (added) > +++ trunk/reactos/dll/win32/msports/msports.spec [iso-8859-1] Tue May 17 19:24:19 2011 > @@ -1,0 +1,12 @@ > +@ stub ComDBClaimNextFreePort > +@ stub ComDBClaimPort > +@ stub ComDBClose > +@ stub ComDBGetCurrentPortUsage > +@ stub ComDBOpen > +@ stub ComDBReleasePort > +@ stub ComDBResizeDatabase > +@ stdcall LibMain(ptr long ptr) DllMain > +@ stub ParallelPortPropPageProvider > +@ stdcall PortsClassInstaller(long ptr ptr) > +@ stub SerialDisplayAdvancedSettings > +@ stub SerialPortPropPageProvider > > Propchange: trunk/reactos/dll/win32/msports/msports.spec > ------------------------------------------------------------------------------ > svn:eol-style = native > > Propchange: trunk/reactos/dll/win32/msports/msports.spec > ------------------------------------------------------------------------------ > svn:keywords = author date id revision > > Modified: trunk/reactos/dll/win32/win32.rbuild > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/win32.rbuild?rev… > ============================================================================== > --- trunk/reactos/dll/win32/win32.rbuild [iso-8859-1] (original) > +++ trunk/reactos/dll/win32/win32.rbuild [iso-8859-1] Tue May 17 19:24:19 2011 > @@ -295,6 +295,9 @@ > <directory name="msnet32"> > <xi:include href="msnet32/msnet32.rbuild" /> > </directory> > +<directory name="msports"> > + <xi:include href="msports/msports.rbuild" /> > +</directory> > <directory name="msrle32"> > <xi:include href="msrle32/msrle32.rbuild" /> > </directory> > > Modified: trunk/reactos/media/inf/ports.inf > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/media/inf/ports.inf?rev=51… > ============================================================================== > Binary files - no diff available. > >

2 2

msports commit (51813) - CMakeLists.txt references nonexistent files
by Adam 18 May '11

18 May '11

When I was trying to build trunk (using Cmake) the configure.cmd did not complete. Host tools were OK but reactos directory was not. I tracked the issue to /dll/win32/msports/CMakeLists.txt which contained references to two nonexistent files (serial.c and parallel.c) and commenting them out allowed the build to continue (albeit with an error at the very end) there.

1 0

Re: [ros-dev] [ros-diffs] [tkreuzer] 51748: [NTOSKRNL] Patch by Paolo Bonzini <bonzini [at] gnu [dot] org> Fix implementation of ExInterlockedAddLargeStatistic The old version wasn't really atomic. See issue #6223 for more ...
by Alex Ionescu 15 May '11

15 May '11

Congrats on once again breaking another key part of Windows compatibility. This function is DOCUMENTED to tear. It was DESIGNED that way on purpose. Utter failure, once more. Best regards, Alex Ionescu On Sat, May 14, 2011 at 12:29 PM, <tkreuzer(a)svn.reactos.org> wrote: > Author: tkreuzer > Date: Sat May 14 19:29:42 2011 > New Revision: 51748 > > URL: http://svn.reactos.org/svn/reactos?rev=51748&view=rev > Log: > [NTOSKRNL] > Patch by Paolo Bonzini <bonzini [at] gnu [dot] org> > Fix implementation of ExInterlockedAddLargeStatistic > The old version wasn't really atomic. > > See issue #6223 for more details. > > Modified: > trunk/reactos/ntoskrnl/ex/i386/fastinterlck_asm.S > > Modified: trunk/reactos/ntoskrnl/ex/i386/fastinterlck_asm.S > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ex/i386/fastinter… > > ============================================================================== > --- trunk/reactos/ntoskrnl/ex/i386/fastinterlck_asm.S [iso-8859-1] > (original) > +++ trunk/reactos/ntoskrnl/ex/i386/fastinterlck_asm.S [iso-8859-1] Sat May > 14 19:29:42 2011 > @@ -4,8 +4,9 @@ > * FILE: ntoskrnl/ex/i386/fastinterlck_asm.S > * PURPOSE: FASTCALL Interlocked Functions > * PROGRAMMERS: Alex Ionescu (alex(a)relsoft.net) > - */ > - > + * Paolo Bonzini <bonzini [at] gnu [dot] org> > + */ > + > /* INCLUDES > ******************************************************************/ > > #include <asm.inc> > @@ -31,25 +32,55 @@ > */ > PUBLIC @ExInterlockedAddLargeStatistic@8 > @ExInterlockedAddLargeStatistic@8: > - > -#ifdef CONFIG_SMP > - /* Do the addition */ > - lock add [ecx], edx > - > - /* Check for carry bit and return */ > - jb .l1 > - ret > - > -.l1: > - /* Add carry */ > - lock adc dword ptr [ecx+4], 0 > -#else > - /* Do the addition and add the carry */ > - add dword ptr [ecx], edx > - adc dword ptr [ecx+4], 0 > -#endif > - /* Return */ > - ret > + push ebp > + push ebx > + mov ebp, ecx > + > +Again: > + /* Load comparand in eax for cmpxchg */ > + mov eax, [ebp] > + > + /* Compute low word of the result in ebx */ > + mov ebx, edx > + add ebx, eax > + > + /* Carry needs cmpxchg8b */ > + jc Slow > + > + /* Fast path still needs to be atomic, so use cmpxchg and retry if it > fails > + * Hopefully it will still get through this path :) */ > + LOCK cmpxchg [ecx], ebx > + jnz Again > + > + /* Thats it */ > + pop ebx > + pop ebp > + ret > + > +Slow: > + /* Save increment across cmpxchg8b */ > + push edx > + > + /* Finish loading comparand in edx:eax */ > + mov edx, [ebp+4] > + > + /* Result in ecx:ebx (we know there's carry) */ > + lea ecx, [edx+1] > + > + /* Do a full exchange */ > + LOCK cmpxchg8b [ebp] > + > + /* restore increment */ > + pop edx > + > + /* Need to retry */ > + jnz Again > + > + /* Thats it */ > + pop ebx > + pop ebp > + ret > + > > /*ULONG > *FASTCALL > > >

2 4

Current patch review assignment
by Olaf Siejka 15 May '11

15 May '11

Hiya Attached, you will find a rough draft of current patch assignment proposals. I`m trying to keep it in realtime, so several of those are already in place. As usual, please comment if you find you shouldn't be reviewing assigned patch. Best regards

1 0

Compatibility List moderation
by Javier Agustìn Fernàndez Arroyo 09 May '11

09 May '11

Speaking about bug reports drama, im still watching how there are several people that are still sending totally useless compatibility test results to ROS database... I want to ask for a moderation system for that, and i would want to offer myself to moderate new incoming results, such as Wine system....

4 5

Re: [ros-dev] [EVENTVWR/EVENTLOG] Fix a double off-by-one bug
by Love Nystrom 08 May '11

08 May '11

Hi Eric, Sounds like you got it licked, the right way. Good job ! Best Regards L. 2011/5/6 <ros-dev-request(a)reactos.org> > From: Eric Kohl <eric.kohl(a)t-online.de> > To: ReactOS Development List <ros-dev(a)reactos.org> > Date: Thu, 05 May 2011 22:41:24 +0200 > Subject: Re: [ros-dev] [EVENTVWR/EVENTLOG] Fix a double off-by-one bug > Hi Love, > > I just committed a fix for the calculation of the available number of event > records. It addresses the issues you mentioned. > > And this is how it works: > When a new log file is created, the first (or oldest) record gets the > record number 1. With each new event record the record number is incremented > by 1. To get the number of records in the log file we need to subtract the > OldestRecordNumber from the CurrentRecordNumber. If the log file is empty > the OldestRecordNumber will be 0. In this case we will return 0 for the > number of event records. > > Now we call clear a filled log file and fill it with new records. The > oldest record will not be record number 1 but we can still return the true > number of records in the log file. > > > Regards > Eric >

1 0

Re: [ros-dev] [freeldr] Add PXE "filesystem" (Aleksey Bragin)
by Love Nystrom 08 May '11

08 May '11

Hi Aleksey, I'm sorry if my opinion came across as critique of the work as such. It was definitely not intended that way. I have great respect for all your efforts. Just a point about unfortunate choice of AT&T syntax. I would gladly volunteer to translate all old AT&T code to Intel. After all, I do have 25 years of expertise in assembly coding. It's just that I'm completely bogged down by R.L and have no time. But if it can wait, just leave it be, and I'll do it later. I'm sure Timo has enough to do with other issues already. I abbreviated the pro's and con's to just two points, of which the 2nd applies just to gcc's inline asm syntax. Translating non-inline AT&T to Intel is fairly straight forward. InvalidateHarshMode(TRUE); No offence taken. Best Regards L. On 2011-05-05 14.58, "Aleksey Bragin" <aleksey(a)reactos.org> wrote: > SetHarshMode(TRUE); > > Your opinion would be interesting if it was motivated by your knowledge and experience in writing assembly > in both AT&T and Intel syntax, so that you could provide us pros and cons of each approach by your judgement. > > Or, if you would be author of that code part in ReactOS. > > Otherwise, I’m afraid, it’s just criticizing a very good work, didn’t even noticing the great PXE milestone, > but nitpicking to a syntax. Don’t join complaints if you can’t fix it. (Timo’s point is valid because that’s him who actually > converts this stuff!) > > SetHarshMode(FALSE); > > WBR, > Aleksey.

2 1

ReactOS YouTube Channel
by Adam 08 May '11

08 May '11

I noticed this YouTube channel here - http://www.youtube.com/reactosorg - and apparently it seems to have 3 videos about ReactOS on it. Nothing seems to be uploaded to it for a little over 1 year and I was wondering perhaps it wouldn't be a bad idea to upload some videos about various events to it. I suspect a major issue with the lack of developers is lack of publicity and I think this seems like a good opportunity. (note I am not sure if it is the official ReactOS channel or not - if not time to make one - apparently it seems the person who made the channel is displaying the Age as 16 years old)

2 1

Apologies
by Olaf Siejka 07 May '11

07 May '11

I am sorry to Vicmarcal for outbursting on ros-dev. The reason for that was yet another pointless bugreport, after my requestes, passed several times, regarding bug reports quality. Sorry, Vicmarcal, as well as those who had to witness it. Regards

3 2

Vicmarcal - are you mad?
by Olaf Siejka 06 May '11

06 May '11

Bugzilla is crowded with untouched bugs for so long, and you HAVE to add more crud to it? Bugs like no.6214, very usefull as we can see below: "1)Download ClickToDesktop 2)Run in ReactOS 3)Click on the desktop to hide. It doesn't work. Apps just lost the focus. Nothing appears in the DebugLog." Now that is informative... Why dont you get back doing something useful for a change?

8 13

Re: [ros-dev] [EVENTVWR/EVENTLOG] Fix a double off-by-one bug
by Love Nystrom 05 May '11

05 May '11

Hi Gabriel, Eric, Isn't the real issue why LogFile->Header.CurrentRecordNumber is off by one ? If that is found and fixed, this patch will make the error re-emerge as an off by -1. And if CurrentRecordNumber is actually used as the next *pending* record number, the identifier is somewhat mis-leading .. ? Just my penny to the pot Best Regards L. ---------- Forwarded message ---------- > From: Gabriel ilardi <gabrielilardi(a)hotmail.it> > To: ros-dev <ros-dev(a)reactos.org> > Date: Mon, 2 May 2011 21:50:03 +0200 > Subject: Re: [ros-dev] [ros-diffs] [ekohl] 51558: [EVENTVWR/EVENTLOG] Fix a > double off-by-one bug: - The eventlog service was reporting one event more > than was available (+1). - The event viewer did not display the latest event > from... > Great work on event service and event viewer... keep it up Eric :) > > > > Date: Mon, 2 May 2011 19:38:24 +0000 > > To: ros-diffs(a)reactos.org > > From: ekohl(a)svn.reactos.org > > Subject: [ros-diffs] [ekohl] 51558: [EVENTVWR/EVENTLOG] Fix a double > off-by-one bug: - The eventlog service was reporting one event more than was > available (+1). - The event viewer did not display the latest event from... > > > > Author: ekohl > > Date: Mon May 2 19:38:23 2011 > > New Revision: 51558 > > > > URL: http://svn.reactos.org/svn/reactos?rev=51558&view=rev > > Log: > > [EVENTVWR/EVENTLOG] > > Fix a double off-by-one bug: > > - The eventlog service was reporting one event more than was available > (+1). > > - The event viewer did not display the latest event from the eventlog > service (-1). > > > > See issue #6182 for more details. > > > > Modified: > > trunk/reactos/base/applications/mscutils/eventvwr/eventvwr.c > > trunk/reactos/base/services/eventlog/rpc.c > > > > Modified: trunk/reactos/base/applications/mscutils/eventvwr/eventvwr.c > > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… > > > ============================================================================== > > --- trunk/reactos/base/applications/mscutils/eventvwr/eventvwr.c > [iso-8859-1] (original) > > +++ trunk/reactos/base/applications/mscutils/eventvwr/eventvwr.c > [iso-8859-1] Mon May 2 19:38:23 2011 > > @@ -503,7 +503,7 @@ > > HWND hwndDlg; > > HANDLE hEventLog; > > EVENTLOGRECORD *pevlr; > > - DWORD dwRead, dwNeeded, dwThisRecord, dwTotalRecords = 0, > dwCurrentRecord = 1, dwRecordsToRead = 0, dwFlags, dwMaxLength; > > + DWORD dwRead, dwNeeded, dwThisRecord, dwTotalRecords = 0, > dwCurrentRecord = 0, dwRecordsToRead = 0, dwFlags, dwMaxLength; > > LPWSTR lpSourceName; > > LPWSTR lpComputerName; > > LPSTR lpData; > > > > Modified: trunk/reactos/base/services/eventlog/rpc.c > > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/base/services/eventlog/rpc… > > > ============================================================================== > > --- trunk/reactos/base/services/eventlog/rpc.c [iso-8859-1] (original) > > +++ trunk/reactos/base/services/eventlog/rpc.c [iso-8859-1] Mon May 2 > 19:38:23 2011 > > @@ -199,6 +199,7 @@ > > DWORD *NumberOfRecords) > > { > > PLOGHANDLE lpLogHandle; > > + DWORD dwRecords; > > > > lpLogHandle = ElfGetLogHandleEntryByHandle(LogHandle); > > if (!lpLogHandle) > > @@ -206,7 +207,9 @@ > > return STATUS_INVALID_HANDLE; > > } > > > > - *NumberOfRecords = lpLogHandle->LogFile->Header.CurrentRecordNumber; > > + dwRecords = lpLogHandle->LogFile->Header.CurrentRecordNumber; > > + > > + *NumberOfRecords = (dwRecords > 0) ? (dwRecords - 1) : 0; > > > > return STATUS_SUCCESS; > > } > > > > >

2 1

Re: [ros-dev] [freeldr] Add PXE "filesystem" (Ged Murphy)
by Love Nystrom 05 May '11

05 May '11

Hi Ged, Yes of course I read Hervé's mail. I did not suggest that he should go about porting existing code, I just expressed my opinion that we shouldn't use AT&T for new code. As for porting the existing freeldr AT&T code, I guess I could, eventually, when I get time, if I can just get a firm enough grip on the AT&T directive voodoo, which is obscure. But in the short run, no, sorry, I'm really bogged down by RL :( (It's even hard to try and keep up with the mailing list) You wouldn't happen to have a good pointer for that obscure AT&T string voodoo? Best Regards L. On Tue, May 3, 2011 at 11:12 PM, <ros-dev-request(a)reactos.org> wrote: > Send Ros-dev mailing list submissions to > ros-dev(a)reactos.org > > To subscribe or unsubscribe via the World Wide Web, visit > http://www.reactos.org/mailman/listinfo/ros-dev > or, via email, send a message with subject or body 'help' to > ros-dev-request(a)reactos.org > > You can reach the person managing the list at > ros-dev-owner(a)reactos.org > > When replying, please edit your Subject line so it is more specific > than "Re: Contents of Ros-dev digest..." > > Today's Topics: > > 1. Re: [EVENTVWR/EVENTLOG] Fix a double off-by-one bug (Love Nystrom) > 2. Re: [freeldr] Add PXE "filesystem" (Love Nystrom) > 3. Re: [freeldr] Add PXE "filesystem" (Ged Murphy) > > > ---------- Forwarded message ---------- > From: Love Nystrom <love.nystrom(a)gmail.com> > To: ros-dev(a)reactos.org > Date: Tue, 3 May 2011 21:52:40 +0700 > Subject: Re: [ros-dev] [EVENTVWR/EVENTLOG] Fix a double off-by-one bug > > Hi Gabriel, Eric, > > Isn't the real issue why LogFile->Header.CurrentRecordNumber is off by one > ? > If that is found and fixed, this patch will make the error re-emerge as an > off by -1. > And if CurrentRecordNumber is actually used as the next *pending* record > number, > the identifier is somewhat mis-leading .. ? > > Just my penny to the pot > Best Regards > L. > > ---------- Forwarded message ---------- >> From: Gabriel ilardi <gabrielilardi(a)hotmail.it> >> To: ros-dev <ros-dev(a)reactos.org> >> Date: Mon, 2 May 2011 21:50:03 +0200 >> Subject: Re: [ros-dev] [ros-diffs] [ekohl] 51558: [EVENTVWR/EVENTLOG] Fix >> a double off-by-one bug: - The eventlog service was reporting one event more >> than was available (+1). - The event viewer did not display the latest event >> from... >> Great work on event service and event viewer... keep it up Eric :) >> >> >> > Date: Mon, 2 May 2011 19:38:24 +0000 >> > To: ros-diffs(a)reactos.org >> > From: ekohl(a)svn.reactos.org >> > Subject: [ros-diffs] [ekohl] 51558: [EVENTVWR/EVENTLOG] Fix a double >> off-by-one bug: - The eventlog service was reporting one event more than was >> available (+1). - The event viewer did not display the latest event from... >> > >> > Author: ekohl >> > Date: Mon May 2 19:38:23 2011 >> > New Revision: 51558 >> > >> > URL: http://svn.reactos.org/svn/reactos?rev=51558&view=rev >> > Log: >> > [EVENTVWR/EVENTLOG] >> > Fix a double off-by-one bug: >> > - The eventlog service was reporting one event more than was available >> (+1). >> > - The event viewer did not display the latest event from the eventlog >> service (-1). >> > >> > See issue #6182 for more details. >> > >> > Modified: >> > trunk/reactos/base/applications/mscutils/eventvwr/eventvwr.c >> > trunk/reactos/base/services/eventlog/rpc.c >> > >> > Modified: trunk/reactos/base/applications/mscutils/eventvwr/eventvwr.c >> > URL: >> http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… >> > >> ============================================================================== >> > --- trunk/reactos/base/applications/mscutils/eventvwr/eventvwr.c >> [iso-8859-1] (original) >> > +++ trunk/reactos/base/applications/mscutils/eventvwr/eventvwr.c >> [iso-8859-1] Mon May 2 19:38:23 2011 >> > @@ -503,7 +503,7 @@ >> > HWND hwndDlg; >> > HANDLE hEventLog; >> > EVENTLOGRECORD *pevlr; >> > - DWORD dwRead, dwNeeded, dwThisRecord, dwTotalRecords = 0, >> dwCurrentRecord = 1, dwRecordsToRead = 0, dwFlags, dwMaxLength; >> > + DWORD dwRead, dwNeeded, dwThisRecord, dwTotalRecords = 0, >> dwCurrentRecord = 0, dwRecordsToRead = 0, dwFlags, dwMaxLength; >> > LPWSTR lpSourceName; >> > LPWSTR lpComputerName; >> > LPSTR lpData; >> > >> > Modified: trunk/reactos/base/services/eventlog/rpc.c >> > URL: >> http://svn.reactos.org/svn/reactos/trunk/reactos/base/services/eventlog/rpc… >> > >> ============================================================================== >> > --- trunk/reactos/base/services/eventlog/rpc.c [iso-8859-1] (original) >> > +++ trunk/reactos/base/services/eventlog/rpc.c [iso-8859-1] Mon May 2 >> 19:38:23 2011 >> > @@ -199,6 +199,7 @@ >> > DWORD *NumberOfRecords) >> > { >> > PLOGHANDLE lpLogHandle; >> > + DWORD dwRecords; >> > >> > lpLogHandle = ElfGetLogHandleEntryByHandle(LogHandle); >> > if (!lpLogHandle) >> > @@ -206,7 +207,9 @@ >> > return STATUS_INVALID_HANDLE; >> > } >> > >> > - *NumberOfRecords = lpLogHandle->LogFile->Header.CurrentRecordNumber; >> > + dwRecords = lpLogHandle->LogFile->Header.CurrentRecordNumber; >> > + >> > + *NumberOfRecords = (dwRecords > 0) ? (dwRecords - 1) : 0; >> > >> > return STATUS_SUCCESS; >> > } >> > >> > >> > > > > ---------- Forwarded message ---------- > From: Love Nystrom <love.nystrom(a)gmail.com> > To: ros-dev(a)reactos.org > Date: Tue, 3 May 2011 22:35:30 +0700 > Subject: Re: [ros-dev] [freeldr] Add PXE "filesystem" > > Hi Hervé, > > No disrespect for your work, but I'm inclined to concur with Timo regrading > AT&T vs. Intel. > > Even though I usually preach "don't fix it if it isn't broken', I really > think that AT&T syntax > is broken by design, and we should use only Intel assembly, which is *much* > clearer. > After all, we're programming Intel CPU's, not AT&T telephone switchboards > ;) > > 1) AT&T does not conform with Intel instruction reference. > Intel syntax conforms with the instruction reference. > > 2) AT&T has a lot of quaint obscure directive voodoo. > What little directives exist in Intel is clear and concise. > > Eventually, I hope we'll get rid of all backwards & muddy AT&T assembly, > but until then I think we should at least not use it for new code. > > Best Regards > L. > > > ---------- Forwarded message ---------- >> From: "Hervé Poussineau" <hpoussin(a)reactos.org> >> To: ReactOS Development List <ros-dev(a)reactos.org> >> Date: Mon, 02 May 2011 19:33:19 +0200 >> Subject: Re: [ros-dev] [ros-diffs] [hpoussin] 51517: [freeldr] Add PXE >> "filesystem" >> Hi, >> >> The file is in AT&T syntax, as all asm files in >> reactos/boot/freeldr/freeldr/arch/i386/ , except fathelp.asm >> Sorry, I won't "fix" it, so you'll have to find someone to do it. >> >> Regards, >> >> Hervé >> >> Timo Kreuzer a écrit : >> >>> >>> Why did you write the asm code in AT&T syntax? Its both ugly and breaks >>> compilation with MSVC. >>> I've spent quite some time converting all asm code to MSVC friendly intel >>> syntax. >>> Could you please fix that? >>> >>> Regards, >>> Timo >>> >>> Am 01.05.2011 10:11, schrieb hpoussin(a)svn.reactos.org: >>> >>>> Author: hpoussin >>>> Date: Sun May 1 08:11:43 2011 >>>> New Revision: 51517 >>>> >>>> URL: http://svn.reactos.org/svn/reactos?rev=51517&view=rev >>>> Log: >>>> [freeldr] Add PXE "filesystem" >>>> >>>> Added: >>>> trunk/reactos/boot/freeldr/freeldr/arch/i386/i386pxe.S (with >>>> props) >>>> trunk/reactos/boot/freeldr/freeldr/fs/pxe.c (with props) >>>> trunk/reactos/boot/freeldr/freeldr/include/arch/i386/pxe.h (with >>>> props) >>>> trunk/reactos/boot/freeldr/freeldr/include/fs/pxe.h (with props) >>>> Modified: >>>> trunk/reactos/boot/freeldr/freeldr/arch/i386/machpc.c >>>> trunk/reactos/boot/freeldr/freeldr/arch/i386/pcdisk.c >>>> trunk/reactos/boot/freeldr/freeldr/freeldr_base.rbuild >>>> trunk/reactos/boot/freeldr/freeldr/freeldr_base64k.rbuild >>>> trunk/reactos/boot/freeldr/freeldr/fs/fs.c >>>> trunk/reactos/boot/freeldr/freeldr/include/arch/i386/hardware.h >>>> trunk/reactos/boot/freeldr/freeldr/include/arch/i386/machpc.h >>>> trunk/reactos/boot/freeldr/freeldr/include/freeldr.h >>>> >>>> Added: trunk/reactos/boot/freeldr/freeldr/arch/i386/i386pxe.S >>>> URL: >>>> http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/arch/… >>>> ============================================================================== >>>> >>>> --- trunk/reactos/boot/freeldr/freeldr/arch/i386/i386pxe.S (added) >>>> +++ trunk/reactos/boot/freeldr/freeldr/arch/i386/i386pxe.S [iso-8859-1] >>>> Sun May 1 08:11:43 2011 >>>> @@ -1,0 +1,97 @@ >>>> +/* >>>> + * FreeLoader >>>> + * Copyright (C) 2011 Hervé Poussineau >>>> + * >>>> + * This program is free software; you can redistribute it and/or >>>> modify >>>> + * it under the terms of the GNU General Public License as published >>>> by >>>> + * the Free Software Foundation; either version 2 of the License, or >>>> + * (at your option) any later version. >>>> + * >>>> + * This program is distributed in the hope that it will be useful, >>>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of >>>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >>>> + * GNU General Public License for more details. >>>> + * >>>> + * You should have received a copy of the GNU General Public License >>>> along >>>> + * with this program; if not, write to the Free Software Foundation, >>>> Inc., >>>> + * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. >>>> + */ >>>> + >>>> + .text >>>> + .code16 >>>> + >>>> +#define ASM >>>> + >>>> +#include<arch.h> >>>> + >>>> +/* >>>> + * U16 PxeCallApi(U16 Segment, U16 Offset, U16 Service, VOID >>>> *Parameter); >>>> + * >>>> + * RETURNS: >>>> + */ >>>> +_pxe_function: >>>> + .word 0 >>>> +_pxe_entry_point: >>>> + .long 0 >>>> +_pxe_buffer_segment: >>>> + .word0 >>>> +_pxe_buffer_offset: >>>> + .word0 >>>> +_pxe_result: >>>> + .word 0 >>>> + >>>> +EXTERN(_PxeCallApi) >>>> + .code32 >>>> + pushl %ebp >>>> + movl %esp,%ebp >>>> + >>>> + >>>> >>> > > > ---------- Forwarded message ---------- > From: "Ged Murphy" <gedmurphy(a)gmail.com> > To: "'ReactOS Development List'" <ros-dev(a)reactos.org> > Date: Tue, 3 May 2011 17:12:03 +0100 > Subject: Re: [ros-dev] [freeldr] Add PXE "filesystem" > > Did you read Herve’s email?? > > Are you volunteering to convert all the files he mentioned into intel > syntax? > > > > > > *From:* ros-dev-bounces(a)reactos.org [mailto:ros-dev-bounces@reactos.org] *On > Behalf Of *Love Nystrom > *Sent:* 03 May 2011 16:36 > *To:* ros-dev(a)reactos.org > *Subject:* Re: [ros-dev] [freeldr] Add PXE "filesystem" > > > > > > Hi Hervé, > > > > No disrespect for your work, but I'm inclined to concur with Timo regrading > AT&T vs. Intel. > > > > Even though I usually preach "don't fix it if it isn't broken', I really > think that AT&T syntax > > is broken by design, and we should use only Intel assembly, which is *much* > clearer. > > After all, we're programming Intel CPU's, not AT&T telephone switchboards > ;) > > > > 1) AT&T does not conform with Intel instruction reference. > > Intel syntax conforms with the instruction reference. > > > > 2) AT&T has a lot of quaint obscure directive voodoo. > > What little directives exist in Intel is clear and concise. > > > > Eventually, I hope we'll get rid of all backwards & muddy AT&T assembly, > > but until then I think we should at least not use it for new code. > > > > Best Regards > > L. > > > > > > ---------- Forwarded message ---------- > From: "Hervé Poussineau" <hpoussin(a)reactos.org> > To: ReactOS Development List <ros-dev(a)reactos.org> > Date: Mon, 02 May 2011 19:33:19 +0200 > Subject: Re: [ros-dev] [ros-diffs] [hpoussin] 51517: [freeldr] Add PXE > "filesystem" > Hi, > > The file is in AT&T syntax, as all asm files in > reactos/boot/freeldr/freeldr/arch/i386/ , except fathelp.asm > Sorry, I won't "fix" it, so you'll have to find someone to do it. > > Regards, > > Hervé > > Timo Kreuzer a écrit : > > > Why did you write the asm code in AT&T syntax? Its both ugly and breaks > compilation with MSVC. > I've spent quite some time converting all asm code to MSVC friendly intel > syntax. > Could you please fix that? > > Regards, > Timo > > Am 01.05.2011 10:11, schrieb hpoussin(a)svn.reactos.org: > > Author: hpoussin > Date: Sun May 1 08:11:43 2011 > New Revision: 51517 > > URL: http://svn.reactos.org/svn/reactos?rev=51517&view=rev > Log: > [freeldr] Add PXE "filesystem" > > Added: > trunk/reactos/boot/freeldr/freeldr/arch/i386/i386pxe.S (with props) > trunk/reactos/boot/freeldr/freeldr/fs/pxe.c (with props) > trunk/reactos/boot/freeldr/freeldr/include/arch/i386/pxe.h (with > props) > trunk/reactos/boot/freeldr/freeldr/include/fs/pxe.h (with props) > Modified: > trunk/reactos/boot/freeldr/freeldr/arch/i386/machpc.c > trunk/reactos/boot/freeldr/freeldr/arch/i386/pcdisk.c > trunk/reactos/boot/freeldr/freeldr/freeldr_base.rbuild > trunk/reactos/boot/freeldr/freeldr/freeldr_base64k.rbuild > trunk/reactos/boot/freeldr/freeldr/fs/fs.c > trunk/reactos/boot/freeldr/freeldr/include/arch/i386/hardware.h > trunk/reactos/boot/freeldr/freeldr/include/arch/i386/machpc.h > trunk/reactos/boot/freeldr/freeldr/include/freeldr.h > > Added: trunk/reactos/boot/freeldr/freeldr/arch/i386/i386pxe.S > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/arch/… > ============================================================================== > > --- trunk/reactos/boot/freeldr/freeldr/arch/i386/i386pxe.S (added) > +++ trunk/reactos/boot/freeldr/freeldr/arch/i386/i386pxe.S [iso-8859-1] Sun > May 1 08:11:43 2011 > @@ -1,0 +1,97 @@ > +/* > + * FreeLoader > + * Copyright (C) 2011 Hervé Poussineau > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License as published by > + * the Free Software Foundation; either version 2 of the License, or > + * (at your option) any later version. > + * > + * This program is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + * GNU General Public License for more details. > + * > + * You should have received a copy of the GNU General Public License > along > + * with this program; if not, write to the Free Software Foundation, > Inc., > + * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. > + */ > + > + .text > + .code16 > + > +#define ASM > + > +#include<arch.h> > + > +/* > + * U16 PxeCallApi(U16 Segment, U16 Offset, U16 Service, VOID *Parameter); > + * > + * RETURNS: > + */ > +_pxe_function: > + .word 0 > +_pxe_entry_point: > + .long 0 > +_pxe_buffer_segment: > + .word0 > +_pxe_buffer_offset: > + .word0 > +_pxe_result: > + .word 0 > + > +EXTERN(_PxeCallApi) > + .code32 > + pushl %ebp > + movl %esp,%ebp > + > + > > > > _______________________________________________ > Ros-dev mailing list > Ros-dev(a)reactos.org > http://www.reactos.org/mailman/listinfo/ros-dev >

3 2

Re: [ros-dev] [freeldr] Add PXE "filesystem"
by Love Nystrom 04 May '11

04 May '11

Hi Hervé, No disrespect for your work, but I'm inclined to concur with Timo regrading AT&T vs. Intel. Even though I usually preach "don't fix it if it isn't broken', I really think that AT&T syntax is broken by design, and we should use only Intel assembly, which is *much* clearer. After all, we're programming Intel CPU's, not AT&T telephone switchboards ;) 1) AT&T does not conform with Intel instruction reference. Intel syntax conforms with the instruction reference. 2) AT&T has a lot of quaint obscure directive voodoo. What little directives exist in Intel is clear and concise. Eventually, I hope we'll get rid of all backwards & muddy AT&T assembly, but until then I think we should at least not use it for new code. Best Regards L. ---------- Forwarded message ---------- > From: "Hervé Poussineau" <hpoussin(a)reactos.org> > To: ReactOS Development List <ros-dev(a)reactos.org> > Date: Mon, 02 May 2011 19:33:19 +0200 > Subject: Re: [ros-dev] [ros-diffs] [hpoussin] 51517: [freeldr] Add PXE > "filesystem" > Hi, > > The file is in AT&T syntax, as all asm files in > reactos/boot/freeldr/freeldr/arch/i386/ , except fathelp.asm > Sorry, I won't "fix" it, so you'll have to find someone to do it. > > Regards, > > Hervé > > Timo Kreuzer a écrit : > >> >> Why did you write the asm code in AT&T syntax? Its both ugly and breaks >> compilation with MSVC. >> I've spent quite some time converting all asm code to MSVC friendly intel >> syntax. >> Could you please fix that? >> >> Regards, >> Timo >> >> Am 01.05.2011 10:11, schrieb hpoussin(a)svn.reactos.org: >> >>> Author: hpoussin >>> Date: Sun May 1 08:11:43 2011 >>> New Revision: 51517 >>> >>> URL: http://svn.reactos.org/svn/reactos?rev=51517&view=rev >>> Log: >>> [freeldr] Add PXE "filesystem" >>> >>> Added: >>> trunk/reactos/boot/freeldr/freeldr/arch/i386/i386pxe.S (with props) >>> trunk/reactos/boot/freeldr/freeldr/fs/pxe.c (with props) >>> trunk/reactos/boot/freeldr/freeldr/include/arch/i386/pxe.h (with >>> props) >>> trunk/reactos/boot/freeldr/freeldr/include/fs/pxe.h (with props) >>> Modified: >>> trunk/reactos/boot/freeldr/freeldr/arch/i386/machpc.c >>> trunk/reactos/boot/freeldr/freeldr/arch/i386/pcdisk.c >>> trunk/reactos/boot/freeldr/freeldr/freeldr_base.rbuild >>> trunk/reactos/boot/freeldr/freeldr/freeldr_base64k.rbuild >>> trunk/reactos/boot/freeldr/freeldr/fs/fs.c >>> trunk/reactos/boot/freeldr/freeldr/include/arch/i386/hardware.h >>> trunk/reactos/boot/freeldr/freeldr/include/arch/i386/machpc.h >>> trunk/reactos/boot/freeldr/freeldr/include/freeldr.h >>> >>> Added: trunk/reactos/boot/freeldr/freeldr/arch/i386/i386pxe.S >>> URL: >>> http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/arch/… >>> ============================================================================== >>> >>> --- trunk/reactos/boot/freeldr/freeldr/arch/i386/i386pxe.S (added) >>> +++ trunk/reactos/boot/freeldr/freeldr/arch/i386/i386pxe.S [iso-8859-1] >>> Sun May 1 08:11:43 2011 >>> @@ -1,0 +1,97 @@ >>> +/* >>> + * FreeLoader >>> + * Copyright (C) 2011 Hervé Poussineau >>> + * >>> + * This program is free software; you can redistribute it and/or modify >>> + * it under the terms of the GNU General Public License as published by >>> + * the Free Software Foundation; either version 2 of the License, or >>> + * (at your option) any later version. >>> + * >>> + * This program is distributed in the hope that it will be useful, >>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of >>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >>> + * GNU General Public License for more details. >>> + * >>> + * You should have received a copy of the GNU General Public License >>> along >>> + * with this program; if not, write to the Free Software Foundation, >>> Inc., >>> + * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. >>> + */ >>> + >>> + .text >>> + .code16 >>> + >>> +#define ASM >>> + >>> +#include<arch.h> >>> + >>> +/* >>> + * U16 PxeCallApi(U16 Segment, U16 Offset, U16 Service, VOID >>> *Parameter); >>> + * >>> + * RETURNS: >>> + */ >>> +_pxe_function: >>> + .word 0 >>> +_pxe_entry_point: >>> + .long 0 >>> +_pxe_buffer_segment: >>> + .word0 >>> +_pxe_buffer_offset: >>> + .word0 >>> +_pxe_result: >>> + .word 0 >>> + >>> +EXTERN(_PxeCallApi) >>> + .code32 >>> + pushl %ebp >>> + movl %esp,%ebp >>> + >>> + >>> >>

3 2

Re: [ros-dev] [ros-diffs] [ekohl] 51558: [EVENTVWR/EVENTLOG] Fix a double off-by-one bug: - The eventlog service was reporting one event more than was available (+1). - The event viewer did not display the latest event from...
by Gabriel ilardi 02 May '11

02 May '11

Great work on event service and event viewer... keep it up Eric :) > Date: Mon, 2 May 2011 19:38:24 +0000 > To: ros-diffs(a)reactos.org > From: ekohl(a)svn.reactos.org > Subject: [ros-diffs] [ekohl] 51558: [EVENTVWR/EVENTLOG] Fix a double off-by-one bug: - The eventlog service was reporting one event more than was available (+1). - The event viewer did not display the latest event from... > > Author: ekohl > Date: Mon May 2 19:38:23 2011 > New Revision: 51558 > > URL: http://svn.reactos.org/svn/reactos?rev=51558&view=rev > Log: > [EVENTVWR/EVENTLOG] > Fix a double off-by-one bug: > - The eventlog service was reporting one event more than was available (+1). > - The event viewer did not display the latest event from the eventlog service (-1). > > See issue #6182 for more details. > > Modified: > trunk/reactos/base/applications/mscutils/eventvwr/eventvwr.c > trunk/reactos/base/services/eventlog/rpc.c > > Modified: trunk/reactos/base/applications/mscutils/eventvwr/eventvwr.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… > ============================================================================== > --- trunk/reactos/base/applications/mscutils/eventvwr/eventvwr.c [iso-8859-1] (original) > +++ trunk/reactos/base/applications/mscutils/eventvwr/eventvwr.c [iso-8859-1] Mon May 2 19:38:23 2011 > @@ -503,7 +503,7 @@ > HWND hwndDlg; > HANDLE hEventLog; > EVENTLOGRECORD *pevlr; > - DWORD dwRead, dwNeeded, dwThisRecord, dwTotalRecords = 0, dwCurrentRecord = 1, dwRecordsToRead = 0, dwFlags, dwMaxLength; > + DWORD dwRead, dwNeeded, dwThisRecord, dwTotalRecords = 0, dwCurrentRecord = 0, dwRecordsToRead = 0, dwFlags, dwMaxLength; > LPWSTR lpSourceName; > LPWSTR lpComputerName; > LPSTR lpData; > > Modified: trunk/reactos/base/services/eventlog/rpc.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/services/eventlog/rpc… > ============================================================================== > --- trunk/reactos/base/services/eventlog/rpc.c [iso-8859-1] (original) > +++ trunk/reactos/base/services/eventlog/rpc.c [iso-8859-1] Mon May 2 19:38:23 2011 > @@ -199,6 +199,7 @@ > DWORD *NumberOfRecords) > { > PLOGHANDLE lpLogHandle; > + DWORD dwRecords; > > lpLogHandle = ElfGetLogHandleEntryByHandle(LogHandle); > if (!lpLogHandle) > @@ -206,7 +207,9 @@ > return STATUS_INVALID_HANDLE; > } > > - *NumberOfRecords = lpLogHandle->LogFile->Header.CurrentRecordNumber; > + dwRecords = lpLogHandle->LogFile->Header.CurrentRecordNumber; > + > + *NumberOfRecords = (dwRecords > 0) ? (dwRecords - 1) : 0; > > return STATUS_SUCCESS; > } > >

1 0

Re: [ros-dev] [ros-diffs] [hpoussin] 51517: [freeldr] Add PXE "filesystem"
by Timo Kreuzer 02 May '11

02 May '11

Why did you write the asm code in AT&T syntax? Its both ugly and breaks compilation with MSVC. I've spent quite some time converting all asm code to MSVC friendly intel syntax. Could you please fix that? Regards, Timo Am 01.05.2011 10:11, schrieb hpoussin(a)svn.reactos.org: > Author: hpoussin > Date: Sun May 1 08:11:43 2011 > New Revision: 51517 > > URL: http://svn.reactos.org/svn/reactos?rev=51517&view=rev > Log: > [freeldr] Add PXE "filesystem" > > Added: > trunk/reactos/boot/freeldr/freeldr/arch/i386/i386pxe.S (with props) > trunk/reactos/boot/freeldr/freeldr/fs/pxe.c (with props) > trunk/reactos/boot/freeldr/freeldr/include/arch/i386/pxe.h (with props) > trunk/reactos/boot/freeldr/freeldr/include/fs/pxe.h (with props) > Modified: > trunk/reactos/boot/freeldr/freeldr/arch/i386/machpc.c > trunk/reactos/boot/freeldr/freeldr/arch/i386/pcdisk.c > trunk/reactos/boot/freeldr/freeldr/freeldr_base.rbuild > trunk/reactos/boot/freeldr/freeldr/freeldr_base64k.rbuild > trunk/reactos/boot/freeldr/freeldr/fs/fs.c > trunk/reactos/boot/freeldr/freeldr/include/arch/i386/hardware.h > trunk/reactos/boot/freeldr/freeldr/include/arch/i386/machpc.h > trunk/reactos/boot/freeldr/freeldr/include/freeldr.h > > Added: trunk/reactos/boot/freeldr/freeldr/arch/i386/i386pxe.S > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/arch/… > ============================================================================== > --- trunk/reactos/boot/freeldr/freeldr/arch/i386/i386pxe.S (added) > +++ trunk/reactos/boot/freeldr/freeldr/arch/i386/i386pxe.S [iso-8859-1] Sun May 1 08:11:43 2011 > @@ -1,0 +1,97 @@ > +/* > + * FreeLoader > + * Copyright (C) 2011 Hervé Poussineau > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License as published by > + * the Free Software Foundation; either version 2 of the License, or > + * (at your option) any later version. > + * > + * This program is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + * GNU General Public License for more details. > + * > + * You should have received a copy of the GNU General Public License along > + * with this program; if not, write to the Free Software Foundation, Inc., > + * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. > + */ > + > + .text > + .code16 > + > +#define ASM > + > +#include<arch.h> > + > +/* > + * U16 PxeCallApi(U16 Segment, U16 Offset, U16 Service, VOID *Parameter); > + * > + * RETURNS: > + */ > +_pxe_function: > + .word 0 > +_pxe_entry_point: > + .long 0 > +_pxe_buffer_segment: > + .word0 > +_pxe_buffer_offset: > + .word0 > +_pxe_result: > + .word 0 > + > +EXTERN(_PxeCallApi) > + .code32 > + pushl %ebp > + movl %esp,%ebp > + > +

2 1

Re: [ros-dev] [ros-diffs] [rharabien] 51510: [COMCTL32] * Properly support WM_SYSCOLORCHANGE in ListView controls with default background. Should be sent to Wine (tm)
by Ged Murphy 01 May '11

01 May '11

There's little point in (tm)ing these wine changes, if they don't get sent to wine or properly documented, then will definitely be overwritten by the next wine sync. On 30 April 2011 22:41, <rharabien(a)svn.reactos.org> wrote: > Author: rharabien > Date: Sat Apr 30 21:41:15 2011 > New Revision: 51510 > > URL: http://svn.reactos.org/svn/reactos?rev=51510&view=rev > Log: > [COMCTL32] > * Properly support WM_SYSCOLORCHANGE in ListView controls with default background. Should be sent to Wine (tm) > > Modified: > trunk/reactos/dll/win32/comctl32/listview.c > > Modified: trunk/reactos/dll/win32/comctl32/listview.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/comctl32/listvie… > ============================================================================== > --- trunk/reactos/dll/win32/comctl32/listview.c [iso-8859-1] (original) > +++ trunk/reactos/dll/win32/comctl32/listview.c [iso-8859-1] Sat Apr 30 21:41:15 2011 > @@ -315,6 +315,7 @@ > COLORREF clrBk; > COLORREF clrText; > COLORREF clrTextBk; > + BOOL bDefaultBkColor; > > /* font */ > HFONT hDefaultFont; > @@ -7870,7 +7871,8 @@ > static BOOL LISTVIEW_SetBkColor(LISTVIEW_INFO *infoPtr, COLORREF clrBk) > { > TRACE("(clrBk=%x)\n", clrBk); > - > + > + infoPtr->bDefaultBkColor = FALSE; > if(infoPtr->clrBk != clrBk) { > if (infoPtr->clrBk != CLR_NONE) DeleteObject(infoPtr->hBkBrush); > infoPtr->clrBk = clrBk; > @@ -9263,6 +9265,7 @@ > infoPtr->clrText = CLR_DEFAULT; > infoPtr->clrTextBk = CLR_DEFAULT; > LISTVIEW_SetBkColor(infoPtr, comctl32_color.clrWindow); > + infoPtr->bDefaultBkColor = TRUE; > > /* set default values */ > infoPtr->nFocusedItem = -1; > @@ -11525,6 +11528,11 @@ > > case WM_SYSCOLORCHANGE: > COMCTL32_RefreshSysColors(); > + if (infoPtr->bDefaultBkColor) > + { > + LISTVIEW_SetBkColor(infoPtr, comctl32_color.clrWindow); > + infoPtr->bDefaultBkColor = TRUE; > + } > return 0; > > /* case WM_TIMER: */ > > >

1 0

Fwd: [NOTEPAD] Patch by Edijs Kolesnikovics: Write default font, weight and point...
by Jérôme Gardou 29 Apr '11

29 Apr '11

SaveDword(hKey, _T("iPointSize"), Globals.lfFont.lfHeight); shouldn't it be SaveDword(hKey, _T("iPointSize"), PointSizeFromHeight(Globals.lfFont.lfHeight)); Also, this would permit to simplify code a bit :-) http://cia.vc/stats/project/ReactOS/.message/3522f92

1 0

Regular meeting
by Aleksey Bragin 29 Apr '11

29 Apr '11

Hello, I want to remind you of the regular meeting, Thursday the 28th at 20:00 UTC at freenode #reactos-meeting. The suggested meeting agenda is: - Status of our GSoC participation - Current ReactOS work. Developers saying what they are working on - Action List proposal - Status of the upcoming LinuxTag event preparations - Website revamp. Current status, who is working, who is willing to help If nobody else volunteers, Amine would be ready to take the minute taker position again in this meeting and I would lead the meeting. In case I am late, Amine will open the up meeting and I will join as soon as I get online. The current list of ReactOS members is as follows. Only these people will be able to participate in the discussions and votings, please tell us if we have forgotten anybody or if you want to be added to this list: - Giannis Adamopoulos (smiley1_) - Johannes Anderwald (janderwald) - Javier Agustìn Fernàndez Arroyo (elhoir) - Maciej Bialas (niski) - Aleksey Bragin (abragin) - Colin Finck (Colin_Finck) - Danny Götte (dangerground) - Cameron Gutman (aicom) - Ziliang Guo (ZWabbit) - Rafal Harabien (rafalh) - Kamil Hornicek (Pigglesworth) - Amine Khaldi (AmineKhaldi) - Timo Kreuzer (tkreuzer) - Matthias Kupfer (Collibri) - Michael Martin (mjmartin) - Victor Martinez (vicmarcal) - Roel Messiant (Mephisto) - Andrew Munger (WaxDragon) - Ged Murphy (GedMurphy) - Sylvain Petreolle (Usurp) - Hervé Poussineau (hpoussin) - Daniel Reimer (dreimer) - Pierre Schweitzer (HeisSpiter) - Samuel Serapion (encoded) - Olaf Siejka (Caemyr) - James Tabor (jimtabor) - Art Yerkes (arty) Everybody may join the meeting channel as a non-participating observer though. See you at the meeting today, Aleksey Bragin.

6 6

April Meeting Minutes
by Amine Khaldi 29 Apr '11

29 Apr '11

April Meeting Minutes 2011-04-28 20:05 UTC Freenode, #reactos-meeting Participants ============ Adam Stachowicz Aleksey Bragin Amine Khaldi Art Yerkes Daniel Reimer Gabriel Ilardi Ged Murphy Giannis Adamopoulos Gregor Schneider Hervé Poussineau James Tabor Javier Agustìn Fernàndez Arroyo Johannes Anderwald Maciej Białas Matthias Kupfer Olaf Siejka Pierre Schweitzer Rafał Harabień Samuel Serapion Timo Kreuzer Victor Martinez Ziliang Guo Proceedings =========== ○ Meeting called to order at 20:05 UTC by Aleksey Bragin ○ Point 1 in the agenda: GSoC status update =========================================== ■ Amine mentioned that ReactOS has 6 slots this year, and that a great care was put in the accepted projects selection with focus on UI and stability, with the goal to release 0.4 shortly after a successful GSoC. He also mentioned that the students will be granted commit access to official branches, so that the community can follow their progress. Ged and Amine asked the present members to do their best to help the students in any way, not leaving them only to their mentors, and asked the students not to hesitate to request help from anyone. ○ Point 2: Current ReactOS work =============================== ■ Amine: GSoC related tasks and coordination, CMake branch regression tracking and fixing, with the help of Igor and Rafał, still into the website revamp and the ideas around it. ■ Olaf: He has just updated VBox testbot to VBox 4.0.6, and with the great help of Fireball and hackdog he finally got sysreg for it done as well. Olaf also mentioned that our stdio problem of sysreg turned into another less visible one, VBox serial output problem, typically for heavy text output on virtual com via pipes.. The log is very good, but sometimes short parts of text are relocated, like in http://www.reactos.org/testman/detail.php?id=1763684. As a result of these efforts, test repetitions should be more rare. He also suggested to try to run it via com0com once Fireball signs the 64bit driver. Another thing Olaf was working on is trying to shorten the patch queue (http://www.reactos.org/wiki/Bug_Filters) and separate WIP patches from the ready for review patches, and he also began committing translations. ■ Matthias: He is working on patches and minor bug-fixes, with focus on win32 and win32k (espacially alt-tab). All the other ReactOS related tasks have nothing to do with developing. ■ Gregor: He mentioned that he doesn't have as much time as last year, since he works full time now, so he can only offer to help cleaning up bugzilla from time to time, committing patches, reviewing etc. Expect patches to random components from him, but he can't offer much irc activity. He's going through application patches currently. ■ Daniel: Not much time lately. He still hopes to get a new RosBE done in short term. ■ Javier: He tries to introduce new people to #reactos-es, and plans to work more on translations and to also blog about ReactOS in Spanish. ■ Samuel: He is already working on secur32 and started msv1_0. ■ Aleksey: He's trying to finish the ldr rewrite and commit it. Two blocker bugs are preventing him to do this: the first being the DLLs registration failures in the 2nd stage, and the other one is a random Firefox installer hang during file unpacking. When that's done, he plans to move on to organize the massive winesync of the tree, simultaneously trying to fix the remaining heap regressions (with someone?). The main problem is that he's traveling quite often during this time range, and thus can't work on ReactOS as he usually did, so any problem gets longer to solve. He will also continue working on arwinss after those tasks above are complete. ■ Gabriel: He keeps the forum clean on a daily basis (Spam mainly), and he also does small updates to the wiki, Bugzilla maintenance, committing translations and small patches, testing ReactOS and patches. He also added the svn log to the front page of the website and is currently giving some support to a guy that was interested in using ReactOS in his company. ■ Jim: He's mainly working on bug-fixing, especially keyboard messages and message in general. ■ Rafał: He's currently studying for his exams in May, and fixing random bugs from bugzilla during his breaks. He'll eventually help in CMake. ■ Giannis: He started researching his GSoC project and doing some tests. In the meantime he's trying to sort out any work that he started lately but not completed. ■ Johannes: He's mainly working on USB, planning to reach Mike's (mjmartin) driver state in the next few days, as most of the code written now is based on his implementation. He mentioned that today was good day for USB as lots of code got working. His initial goal is to get mass storage working with Win XP (thats the bulk and control transfers), then jump to hub driver and later the USB class driver, but he couldn't really say how long this will take. ■ Timo: He is focusing on his GSoC project. ■ Victor: He was busy this month with real life, but he's trying to create a Testing Forum Team, he hopes to start on it in the upcoming days. He also helps with the website revamp, and he's now preparing for the trip to Berlin for the LinuxTage event. ○ Point 3: Action List proposal =============================== ■ Amine referred to http://www.reactos.org/pipermail/ros-dev/2011-April/014148.html for context, and asked the members whether they have any comments/suggestions about it. Nothing came up, so we proceeded to the next point of this meeting. ○ Point 4: Status of the upcoming LinuxTag event preparations ============================================================= ■ Matthias mentioned that the booth is booked and tables and furniture are ordered/reserved. Due to the lack of interest we have only 4 persons as booth personnel. He will ask whether or not we need a day in advance for preparation of booth, and he prefers to setup the booth on first day, as long we don't have to set up a lot of things. Therefore, he hasn't booked a hotel yet. His preferred hotel is too expensive, and as long as we have some changes in persons he thinks it's easier to book single rooms with a price around 50-70€ per night. ■ A brief discussion went on between Victor, Matthias and Gregor about booking, sharing rooms, what to bring...etc ○ Point 5: Website revamp. Current status, who is working, who is willing to help ================================================================================= ■ Ziliang mentioned that he's porting content over, trimming a lot of stuff in terms of the 'About' and 'Why ReactOS' sections. He merged some parts into the dev FAQ from the general FAQ, and got the location of the Drupal install from Danny, so that he can start dropping in test modules which will allow us to test main page layouts. ■ The rest of the discussion was just a reiteration of what's already in the website revamp collaborative document. ○ Meeting ended at 23:10 UTC. ○ Minutes submitted by Amine Khaldi.

3 3

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev