- Ros-dev - ReactOS.org

Test_KVM_AHK is temporarily offline
by Sylvain Petreolle 26 Oct '18

26 Oct '18

Hello all. My family is at home and I need to shut down the AHK bot until the end of the week. See you later on Ros ;-) Kind regards, Sylvain Petreolle

1 0

New member
by Никита 13 Oct '18

13 Oct '18

2 1

Upcoming Google Summer of Code Mentor Summit
by Colin Finck 09 Oct '18

09 Oct '18

Hi all, As announced, I'll be travelling to California this Thursday to attend the Google Summer of Code Mentor Summit from Friday to Sunday. I'll be using this opportunity to spread the word about ReactOS, our experiences with GSoC, and learning from other projects' experiences. I'm especially interested to hear how others are acquiring talented students and managing their list of task ideas over the year. Let's hope this will help us to get more than 1 student next year and efficiently collect a list of GSoC ideas continuously instead of preparing it shortly before the deadline ;) Is there anything else you want me to talk about during the summit? Cheers, Colin

2 1

Add InitializeProcThreadAttributeList function
by Biswapriyo Nath 06 Oct '18

06 Oct '18

I found that this function `InitializeProcThreadAttributeList()` is added with GetProcAddress but not with the real function. I can provide the real function from Windows 10. The function hasn't any imported function, just conatins some arithmatic operations. I don't know how to contribute and not familiar with ReactOS repo. So, I can only provide a c file.

1 0

Re: [ros-dev] [ros-diffs] 01/01: [SERVICES] Fix timeout when a service is stopped
by Pierre Schweitzer 05 Oct '18

05 Oct '18

Hey Eric, What's the purpose of that "Sleep(2000);"? Is it a debug leftover? Cheers, Pierre Le 05/10/2018 à 08:43, Eric Kohl a écrit : > https://git.reactos.org/?p=reactos.git;a=commitdiff;h=f6d81f225747e4b1b3716… > > commit f6d81f225747e4b1b3716e9ca8629f77dcc52b1a > Author: Eric Kohl <eric.kohl(a)reactos.org> > AuthorDate: Fri Oct 5 08:41:23 2018 +0200 > Commit: Eric Kohl <eric.kohl(a)reactos.org> > CommitDate: Fri Oct 5 08:41:23 2018 +0200 > > [SERVICES] Fix timeout when a service is stopped > > RSetServiceStatus: Send the stop command for the dispatcher thread from a separate thread. > > Fixes CORE-15064 > --- > base/system/services/rpcserver.c | 59 ++++++++++++++++++++++++++++++++++------ > 1 file changed, 50 insertions(+), 9 deletions(-) > > diff --git a/base/system/services/rpcserver.c b/base/system/services/rpcserver.c > index 7f251c8760..8e383a5bdc 100644 > --- a/base/system/services/rpcserver.c > +++ b/base/system/services/rpcserver.c > @@ -1671,6 +1671,43 @@ ScmIsValidServiceState(DWORD dwCurrentState) > } > > > +static > +DWORD > +WINAPI > +ScmStopThread( > + _In_ PVOID pParam) > +{ > + PSERVICE pService; > + > + DPRINT("ScmStopThread(%p)\n", pParam); > + > + pService = (PSERVICE)pParam; > + > + if (pService->lpImage->dwImageRunCount != 0) > + return 0; > + > + Sleep(2000); > + > + /* Lock the service database exclusively */ > + ScmLockDatabaseExclusive(); > + > + /* Stop the dispatcher thread */ > + ScmControlService(pService->lpImage->hControlPipe, > + L"", > + (SERVICE_STATUS_HANDLE)pService, > + SERVICE_CONTROL_STOP); > + > + /* Remove the service image */ > + ScmRemoveServiceImage(pService->lpImage); > + > + /* Unlock the service database */ > + ScmUnlockDatabase(); > + > + DPRINT("ScmStopThread done!\n"); > + return 0; > +} > + > + > /* Function 7 */ > DWORD > WINAPI > @@ -1683,6 +1720,8 @@ RSetServiceStatus( > DWORD dwPreviousType; > LPCWSTR lpLogStrings[2]; > WCHAR szLogBuffer[80]; > + HANDLE hStopThread = NULL; > + DWORD dwStopThreadId; > UINT uID; > > DPRINT("RSetServiceStatus() called\n"); > @@ -1762,15 +1801,17 @@ RSetServiceStatus( > /* If we just stopped the last running service... */ > if (lpService->lpImage->dwImageRunCount == 0) > { > - /* Stop the dispatcher thread */ > - ScmControlService(lpService->lpImage->hControlPipe, > - L"", > - (SERVICE_STATUS_HANDLE)lpService, > - SERVICE_CONTROL_STOP); > - > - /* Remove the service image */ > - ScmRemoveServiceImage(lpService->lpImage); > - lpService->lpImage = NULL; > + /* Run the stop thread to stop the service dispatcher */ > + hStopThread = CreateThread(NULL, > + 0, > + (LPTHREAD_START_ROUTINE)ScmStopThread, > + (LPVOID)lpService, > + 0, > + &dwStopThreadId); > + if (hStopThread != NULL) > + { > + CloseHandle(hStopThread); > + } > } > } > > -- Pierre Schweitzer <pierre at reactos.org> System & Network Administrator Senior Kernel Developer ReactOS Deutschland e.V.

1 0

WidenPath
by katahiromz 29 Sep '18

29 Sep '18

About NTGDI Should we use PATHOBJ for WidenPath and FlattenPath?

2 1

Unused bandwidth at home
by Javier Agustìn Fernàndez Arroyo 24 Sep '18

24 Sep '18

Hello all, I have just set optical fiber up at my home. The thing is, im completely sure it will be infra-used Is there anything in ROS i might do for help with that?

1 0

Re: [ros-dev] [ros-diffs] 01/01: [ADVAPI32][SERVICES] Add (dummy) password encryption/decryption functions to CreateServiceA/W and ChangeServiceConfigA/W in order to prepare to pass encrypted passwords to the service manager
by Pierre Schweitzer 18 Sep '18

18 Sep '18

Hi Eric, For security reason, when freeing your password buffers (see below), you shouldn't be using ZeroMemory() before free, but SecureZeroMemory() to zero the buffer. The first one can be optimized (and thus removed) by the compiler. The second cannot. Cheers, Pierre Le 17/09/2018 à 16:36, Eric Kohl a écrit : > https://git.reactos.org/?p=reactos.git;a=commitdiff;h=5e2c4657ca10dea1154cb… > > commit 5e2c4657ca10dea1154cb43f16ee6962999ac7a4 > Author: Eric Kohl <eric.kohl(a)reactos.org> > AuthorDate: Mon Sep 17 16:34:48 2018 +0200 > Commit: Eric Kohl <eric.kohl(a)reactos.org> > CommitDate: Mon Sep 17 16:34:48 2018 +0200 > > [ADVAPI32][SERVICES] Add (dummy) password encryption/decryption functions to CreateServiceA/W and ChangeServiceConfigA/W in order to prepare to pass encrypted passwords to the service manager > --- > base/system/services/config.c | 24 ++++++++ > base/system/services/rpcserver.c | 49 ++++++++++++++-- > base/system/services/services.h | 7 +++ > dll/win32/advapi32/service/scm.c | 123 ++++++++++++++++++++++++++++++++------- > 4 files changed, 177 insertions(+), 26 deletions(-) > > diff --git a/base/system/services/rpcserver.c b/base/system/services/rpcserver.c > index aa64233350..454181bb66 100644 > --- a/base/system/services/rpcserver.c > +++ b/base/system/services/rpcserver.c > @@ -2216,12 +2232,23 @@ RChangeServiceConfigW( > dwError = ERROR_SUCCESS; > > if (dwError != ERROR_SUCCESS) > + { > + DPRINT1("ScmSetServicePassword failed (Error %lu)\n", dwError); > goto done; > + } > } > } > } > > done: > + if (lpClearTextPassword != NULL) > + { > + /* Wipe and release the password buffer */ > + ZeroMemory(lpClearTextPassword, > + (wcslen(lpClearTextPassword) + 1) * sizeof(WCHAR)); > + HeapFree(GetProcessHeap(), 0, lpClearTextPassword); > + } > + > if (hServiceKey != NULL) > RegCloseKey(hServiceKey); > > @@ -2612,6 +2645,14 @@ done: > if (hServiceKey != NULL) > RegCloseKey(hServiceKey); > > + if (lpClearTextPassword != NULL) > + { > + /* Wipe and release the password buffer */ > + ZeroMemory(lpClearTextPassword, > + (wcslen(lpClearTextPassword) + 1) * sizeof(WCHAR)); > + HeapFree(GetProcessHeap(), 0, lpClearTextPassword); > + } > + > if (dwError == ERROR_SUCCESS) > { > DPRINT("hService %p\n", hServiceHandle); -- Pierre Schweitzer <pierre at reactos.org> System & Network Administrator Senior Kernel Developer ReactOS Deutschland e.V.

2 1

Re: [ros-dev] Win8 theme for ReactOS?
by theUser BL 10 Sep '18

10 Sep '18

> Isn't it fun that ppl simply don't understand a "NO" I give 'em in the > forums?! Thats only a comment of ONE developer. If your medical doctor syas you anything, do you never asks a second doctor again for the same thing, to see if he was right? > I even explained why and that GreenteaOS is not more than > stolen ROS code (*) The only problem you have had is, that he have removed the name "ReactOS" everywhere. But it is still al under the same license like ReactOS. > filled with questionable code sources like the > betaarchive forums. So "NO" means go on the other dev's nerves for a > ugly theme violating our and MS's copyrights? Why is an Win8-theme violating MS-copyright but - changing the color of WineMine to Microsofts WinMine - copying the XP explorer.exe 1:1, only the images on it are different - having a Look And Feel VERY similar to Win2000 - etc is all ok? Greetings theuserbl

3 2

Win8 theme for ReactOS?
by theUser BL 09 Sep '18

09 Sep '18

A while ago I have asked in the forum, if the modified Lautus-theme of GreenteaOS could beintegrated in ReactOS https://www.reactos.org/forum/viewtopic.php?f=2&t=16788 Sadly the theme is called in GreenteaOS Lautus, too. Here the source of it https://github.com/GreenteaOS/Deprecated/tree/master/third-party/reactos/me… But it looks like Windows 8. Here a screenshot of the Greentea Windows 8 like theme on ReactOS. Choose one link. I have uploaded it multiple times on multiple places, because some picture-uploading-sides delete its files from time to time https://image.ibb.co/gTsPkU/Virtual_Box_React_OS_0_4_9_08_09_2018_16_22_18.… http://img4host.net/upload/081642005b93dfb8c233a.png https://img3.picload.org/image/dlpgdlow/virtualbox_reactos0.4.9_08_09_.png https://cdn3.imggmi.com/uploads/2018/9/8/e016c5a6842640ac5f7436ee2e9b04e7-f… https://i.imgur.com/mCUvsLy.png EmuandCo is against the integration of the Win8-theme in ReactOS. But he is the only ReactOS-developer in the ReactOS-forum. So I now also ask here, what the other developers thinking about it. Greetings theuserbl

5 4

Contribution for Tracing APIs
by Biswapriyo Nath 05 Sep '18

05 Sep '18

I've some working code for event tracing APIs like StartTrace, OpenTrace, ControlTrace etc. Those works in Windows 10 but are not present in ReactOS Advapi.dll. How can I add those APIs?

2 3

Virtual consoles using ntvdm
by Javier Agustìn Fernàndez Arroyo 04 Sep '18

04 Sep '18

A crazy idea .. What about implementing some kind of virtual consoles, just like Linux? The point is, using ntvdm subsystem, we could allow only console (DOS) apps to run in there. And some kind of "you are running a console. Switch to desktop to run this app!" Message is anyone tried to run another stuff What do you think? A side effect could be, allow remote connections, etc ... :)

2 1

Valve support for ReactOS?
by Javier Agustìn Fernàndez Arroyo 31 Aug '18

31 Aug '18

i was thinking about Valve's Linux support (Steam play) and i was wondering about asking them to support ReactOS via development... Since Windows XP/2k3 are being abandoned, maybe ReactOS could still run Steam games... if they support it. what do you think?

6 6

Broken booting since commit ae11022712db7a5a1e818e33a5f4052eac7e8e3c
by David Quintana (gigaherz) 30 Aug '18

30 Aug '18

I believe from the testbot log, that my commit made some DLLs grow out of their assigned memory allocation, but I don't know how to update the dll address mappings. Help appreciated.

2 2

Status Meeting (August 2018)
by Colin Finck 28 Aug '18

28 Aug '18

Hi all! Let me invite you to the August 2018 meeting, taking place this Thursday, August 30, 2018 at 19:00 UTC. Invited members will again receive their credentials shortly before the meeting. The current agenda is: 1. Status Reports (extended) Note that this is the first meeting after both GSoC and the Hackfest. Participants in either effort are encouraged to also report their related work, what they liked and didn't like about GSoC/ Hackfest, and what we could do better next time. As always, I'm open for additional proposals. I also have to announce that I will definitely be unavailable during the entire September, so someone else has to invite for and lead the September meeting. Best regards, Colin

1 0

Test_VBox finally fixed - but a flawed test remains
by Colin Finck 27 Aug '18

27 Aug '18

Hi all, I took some time during Hackfest to upgrade our Test_VBox Testbot to Ubuntu 18.04, which finally brings us VirtualBox 5.2.x support for sysreg2. Pierre also worked on the relevant BuildBot scripts to improve their reliability. This has resulted in https://github.com/reactos/buildbot_config/commit/388a831eb5ccf67535d8cbd6d… and since using that script, the infamous "IVirtualBox object is null" bug hasn't occurred again :) The upgrade from VirtualBox 4.3.40 to 5.2.10 also resulted in unbearably slow serial port output at first, but this could be fixed by https://github.com/reactos/sysreg2/commit/a4eb4a4551618b4af4dc1985ad8c55fe0…. Have a look at this commit if you encounter a slow serial port output in one of the latest VirtualBox versions with either operating system. This only leaves a funnily flawed WINE test left, which currently causes the entire regression testing process to come to a standstill: https://jira.reactos.org/browse/CORE-14975 Cheers, Colin

2 1

Discussions on ENIW
by Erkin Alp Güney 21 Aug '18

21 Aug '18

|My proposed architecture diagram for ENIW: Linux app systemd <> systemd2svchost Windows userland ------ User-mode Linux kernel ------- SVCHOST Windows services ENIW.SYS Windows personalities Kernel-mode drivers for everything -------------------------- NTOSKRNL.EXE ----------------------------------- ENIW is a component to implement WSL-like functionality named after WINE and its bacronym is ENIW never imitated WSL. systemd2svchost is a service translator to run systemd units as svchost services. Forum thread: <https://www.reactos.org/forum/viewtopic.php?f=9&t=17434> JIRA ticket: <https://jira.reactos.org/browse/CORE-13613> Yours, faihfully Erkin Alp |

2 6

Re: [ros-dev] [ros-diffs] 01/01: [NTOS:MM] Fix paged pool expansion
by Pierre Schweitzer 20 Aug '18

20 Aug '18

Hi Timo et al., To make the issue wider known than just me comment on GitHub. That commit introduced a regression. Le 20/08/2018 à 18:07, Timo Kreuzer a écrit : > https://git.reactos.org/?p=reactos.git;a=commitdiff;h=c219be9409af429909b14… > > commit c219be9409af429909b1433da536516b3c3ab823 > Author: Timo Kreuzer <timo.kreuzer(a)reactos.org> > AuthorDate: Sun Feb 4 19:20:56 2018 +0100 > Commit: Timo Kreuzer <timo.kreuzer(a)reactos.org> > CommitDate: Mon Aug 20 18:07:35 2018 +0200 > > [NTOS:MM] Fix paged pool expansion > --- > ntoskrnl/mm/ARM3/pool.c | 11 ++++++++--- > 1 file changed, 8 insertions(+), 3 deletions(-) > > diff --git a/ntoskrnl/mm/ARM3/pool.c b/ntoskrnl/mm/ARM3/pool.c > index 7cebabe818..113a7aa981 100644 > --- a/ntoskrnl/mm/ARM3/pool.c > +++ b/ntoskrnl/mm/ARM3/pool.c > @@ -561,10 +565,11 @@ MiAllocatePoolPages(IN POOL_TYPE PoolType, > MiInitializePfnForOtherProcess(PageFrameNumber, > (PMMPTE)PointerPde, > MmSystemPageDirectory[(PointerPde - MiAddressToPde(NULL)) / PDE_COUNT]); > +#endif > > /* Write the actual PDE now */ > -// MI_WRITE_VALID_PDE(PointerPde, TempPde); > -#endif > + MI_WRITE_VALID_PDE(PointerPde, TempPde); > + That little change for x86 actually breaks VBox support. It hits an ASSERT during 3rd stage: *** Assertion failed: PointerPde->u.Hard.Valid == 0 *** Source File: /srv/buildbot/Build_GCCLin_x86/build/ntoskrnl/mm/ARM3/miarm.h, line 975 See testbots for instance: https://build.reactos.org/builders/Test%20VBox/builds/8625/steps/test/logs/… Cheers, Pierre -- Pierre Schweitzer <pierre at reactos.org> System & Network Administrator Senior Kernel Developer ReactOS Deutschland e.V.

1 0

Re: [ros-dev] [ros-diffs] 01/01: [CONFIGURE] Added support for new VS 19.15.x
by Pierre Schweitzer 16 Aug '18

16 Aug '18

Formatting is inconsistent now. Tab vs space issue. Le 16/08/2018 à 17:14, Oleksandr Shaposhnikov a écrit : > https://git.reactos.org/?p=reactos.git;a=commitdiff;h=c8d51bb87a92457f7356f… > > commit c8d51bb87a92457f7356fb6cd3488cd0db3b4b5c > Author: Oleksandr Shaposhnikov <sanchaez(a)hotmail.com> > AuthorDate: Thu Aug 16 18:11:53 2018 +0300 > Commit: Oleksandr Shaposhnikov <sanchaez(a)hotmail.com> > CommitDate: Thu Aug 16 18:13:54 2018 +0300 > > [CONFIGURE] Added support for new VS 19.15.x > --- > configure.cmd | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/configure.cmd b/configure.cmd > index 70b0f48211..bacc75a743 100755 > --- a/configure.cmd > +++ b/configure.cmd > @@ -71,6 +71,7 @@ if defined ROS_ARCH ( > cl 2>&1 | find "19.12." > NUL && set VS_VERSION=15 > cl 2>&1 | find "19.13." > NUL && set VS_VERSION=15 > cl 2>&1 | find "19.14." > NUL && set VS_VERSION=15 > + cl 2>&1 | find "19.15." > NUL && set VS_VERSION=15 > if not defined VS_VERSION ( > echo Error: Visual Studio version too old ^(before 10 ^(2010^)^) or version detection failed. > goto quit > -- Pierre Schweitzer <pierre at reactos.org> System & Network Administrator Senior Kernel Developer ReactOS Deutschland e.V.

1 0

Re: [ros-dev] [ros-diffs] 01/01: [HAL] Remove misleading debug prints about USB controllers.
by Alex Ionescu 13 Aug '18

13 Aug '18

Why are these misleading? These are checks that Windows does that we are missing. Guys, open PRs for changes like these ffs. Best regards, Alex Ionescu On Wed, Aug 8, 2018 at 7:14 PM Thomas Faber <thomas.faber(a)reactos.org> wrote: > > https://git.reactos.org/?p=reactos.git;a=commitdiff;h=1ed0f9ab576f094b27e11… > > commit 1ed0f9ab576f094b27e11ba374738ecabc00e2e6 > Author: Thomas Faber <thomas.faber(a)reactos.org> > AuthorDate: Wed Aug 8 19:58:56 2018 +0200 > Commit: Thomas Faber <thomas.faber(a)reactos.org> > CommitDate: Wed Aug 8 20:08:38 2018 +0200 > > [HAL] Remove misleading debug prints about USB controllers. > --- > hal/halx86/legacy/bussupp.c | 26 -------------------------- > 1 file changed, 26 deletions(-) > > diff --git a/hal/halx86/legacy/bussupp.c b/hal/halx86/legacy/bussupp.c > index a37d875ede..4d20396560 100644 > --- a/hal/halx86/legacy/bussupp.c > +++ b/hal/halx86/legacy/bussupp.c > @@ -1128,32 +1128,6 @@ HalpInitializePciBus(VOID) > } > } > > - /* Check if this is a USB controller */ > - if ((PciData->BaseClass == PCI_CLASS_SERIAL_BUS_CTLR) && > - (PciData->SubClass == PCI_SUBCLASS_SB_USB)) > - { > - /* Check if this is an OHCI controller */ > - if (PciData->ProgIf == 0x10) > - { > - DbgPrint("\tDevice is an OHCI (USB) PCI Expansion > Card. Turn off Legacy USB in your BIOS!\n\n"); > - continue; > - } > - > - /* Check for Intel UHCI controller */ > - if (PciData->VendorID == 0x8086) > - { > - DbgPrint("\tDevice is an Intel UHCI (USB) > Controller. Turn off Legacy USB in your BIOS!\n\n"); > - continue; > - } > - > - /* Check for VIA UHCI controller */ > - if (PciData->VendorID == 0x1106) > - { > - DbgPrint("\tDevice is a VIA UHCI (USB) > Controller. Turn off Legacy USB in your BIOS!\n\n"); > - continue; > - } > - } > - > /* Now check the registry for chipset hacks */ > Status = HalpGetChipHacks(PciData->VendorID, > PciData->DeviceID, > >

1 0

Re: [ros-dev] [ros-diffs] 01/04: [REACTOS] RtlAssert(): use "%lu" as LineNumber format.
by Michael Fritscher 09 Aug '18

09 Aug '18

Moin, On 08.08.2018 22:05, Serge Gautherie wrote: > https://git.reactos.org/?p=reactos.git;a=commitdiff;h=97d3b3ce3349fa87d01ee… > > commit 97d3b3ce3349fa87d01ee29d0d08ff2ca8618a7d > Author: Serge Gautherie <reactos-git_serge_171003(a)gautherie.fr> > AuthorDate: Thu Jun 21 05:05:50 2018 +0200 > Commit: Hermès Bélusca-Maïto <hermes.belusca-maito(a)reactos.org> > CommitDate: Wed Aug 8 21:24:07 2018 +0200 > > [REACTOS] RtlAssert(): use "%lu" as LineNumber format. > --- ... > - if (NULL != Message) > - { > - DbgPrint("Assertion \'%s\' failed at %s line %d: %s\n", > - (PCHAR)FailedAssertion, > - (PCHAR)FileName, > - LineNumber, > - Message); > - } > - else > - { > - DbgPrint("Assertion \'%s\' failed at %s line %d\n", > - (PCHAR)FailedAssertion, > - (PCHAR)FileName, > - LineNumber); > - } > - > - //DbgBreakPoint(); > + if (Message != NULL) > + { > + DbgPrint("Assertion \'%s\' failed at %s line %u: %s\n", > + (PCHAR)FailedAssertion, > + (PCHAR)FileName, > + LineNumber, > + Message); > + } > + else > + { > + DbgPrint("Assertion \'%s\' failed at %s line %u\n", > + (PCHAR)FailedAssertion, > + (PCHAR)FileName, > + LineNumber); > + } > + > + //DbgBreakPoint(); > } > > // DECLSPEC_NORETURN > here no %lu, but only %u? Best regards, Michael Fritscher

2 1

Re: [ros-dev] [ros-diffs] 01/01: [WLNOTIFY] Add sens service stubs
by Ged Murphy 08 Aug '18

08 Aug '18

Hi Eric, Do you plan on implementing sysntfy which sens is dependent upon from win7, or do you plan to stick with the XP way via winlogon? If so, I have some undocumented notes and code on sysntfy which might be of some use. Ged. -----Original Message----- From: Ros-diffs <ros-diffs-bounces(a)reactos.org> On Behalf Of Eric Kohl Sent: Tuesday, 07 August 2018 21:57 To: ros-diffs(a)reactos.org Subject: [ros-diffs] 01/01: [WLNOTIFY] Add sens service stubs https://git.reactos.org/?p=reactos.git;a=commitdiff;h=fb5d5ecd64e1e47701e92… commit fb5d5ecd64e1e47701e922e08fd97b29a1d418be Author: Eric Kohl <eric.kohl(a)reactos.org> AuthorDate: Tue Aug 7 22:56:33 2018 +0200 Commit: Eric Kohl <eric.kohl(a)reactos.org> CommitDate: Tue Aug 7 22:56:33 2018 +0200 [WLNOTIFY] Add sens service stubs --- dll/win32/wlnotify/CMakeLists.txt | 1 + dll/win32/wlnotify/{test.c => senssvc.c} | 56 +++++++++++++++++--------------- dll/win32/wlnotify/test.c | 2 +- dll/win32/wlnotify/wlnotify.spec | 24 +++++++------- 4 files changed, 43 insertions(+), 40 deletions(-) diff --git a/dll/win32/wlnotify/CMakeLists.txt b/dll/win32/wlnotify/CMakeLists.txt index 1db47fffe2..6cbf00ce86 100644 --- a/dll/win32/wlnotify/CMakeLists.txt +++ b/dll/win32/wlnotify/CMakeLists.txt @@ -3,6 +3,7 @@ spec2def(wlnotify.dll wlnotify.spec ADD_IMPORTLIB) list(APPEND SOURCE schedsvc.c + senssvc.c test.c wlnotify.c precomp.h) diff --git a/dll/win32/wlnotify/test.c b/dll/win32/wlnotify/senssvc.c similarity index 86% copy from dll/win32/wlnotify/test.c copy to dll/win32/wlnotify/senssvc.c index e3911d3b75..e238a849a9 100644 --- a/dll/win32/wlnotify/test.c +++ b/dll/win32/wlnotify/senssvc.c @@ -1,12 +1,13 @@ /* * PROJECT: ReactOS system libraries * LICENSE: GPL - See COPYING in the top level directory - * FILE: dll/win32/wlnotify/test.c - * PURPOSE: Winlogon notifications - * PROGRAMMER: Eric Kohl + * FILE: dll/win32/wlnotify/senssvc.c + * PURPOSE: SENS service logon notifications + * PROGRAMMER: Eric Kohl <eric.kohl(a)reactos.org> */ #include "precomp.h" +#include <winsvc.h> #define _NDEBUG #include <debug.h> @@ -14,10 +15,10 @@ VOID WINAPI -TestLogonEvent( +SensDisconnectEvent( PWLX_NOTIFICATION_INFO pInfo) { - DPRINT("TestLogonEvent\n"); + DPRINT("SensDisconnectEvent\n"); DPRINT("Size: %lu\n", pInfo->Size); DPRINT("Flags: %lx\n", pInfo->Flags); DPRINT("UserName: %S\n", pInfo->UserName); @@ -31,10 +32,10 @@ TestLogonEvent( VOID WINAPI -TestLogoffEvent( +SensLockEvent( PWLX_NOTIFICATION_INFO pInfo) { - DPRINT("TestLogoffEvent\n"); + DPRINT("SensLockEvent\n"); DPRINT("Size: %lu\n", pInfo->Size); DPRINT("Flags: %lx\n", pInfo->Flags); DPRINT("UserName: %S\n", pInfo->UserName); @@ -48,10 +49,10 @@ TestLogoffEvent( VOID WINAPI -TestLockEvent( +SensLogoffEvent( PWLX_NOTIFICATION_INFO pInfo) { - DPRINT("TestLockEvent\n"); + DPRINT("SensLogoffEvent\n"); DPRINT("Size: %lu\n", pInfo->Size); DPRINT("Flags: %lx\n", pInfo->Flags); DPRINT("UserName: %S\n", pInfo->UserName); @@ -65,10 +66,10 @@ TestLockEvent( VOID WINAPI -TestUnlockEvent( +SensLogonEvent( PWLX_NOTIFICATION_INFO pInfo) { - DPRINT("TestUnlockEvent\n"); + DPRINT("SensLogonEvent\n"); DPRINT("Size: %lu\n", pInfo->Size); DPRINT("Flags: %lx\n", pInfo->Flags); DPRINT("UserName: %S\n", pInfo->UserName); @@ -82,10 +83,10 @@ TestUnlockEvent( VOID WINAPI -TestStartupEvent( +SensPostShellEvent( PWLX_NOTIFICATION_INFO pInfo) { - DPRINT("TestStartupEvent\n"); + DPRINT("SensPostShellEvent\n"); DPRINT("Size: %lu\n", pInfo->Size); DPRINT("Flags: %lx\n", pInfo->Flags); DPRINT("UserName: %S\n", pInfo->UserName); @@ -99,10 +100,10 @@ TestStartupEvent( VOID WINAPI -TestShutdownEvent( +SensReconnectEvent( PWLX_NOTIFICATION_INFO pInfo) { - DPRINT("TestShutdownEvent\n"); + DPRINT("SensReconnectEvent\n"); DPRINT("Size: %lu\n", pInfo->Size); DPRINT("Flags: %lx\n", pInfo->Flags); DPRINT("UserName: %S\n", pInfo->UserName); @@ -116,10 +117,10 @@ TestShutdownEvent( VOID WINAPI -TestStartScreenSaverEvent( +SensShutdownEvent( PWLX_NOTIFICATION_INFO pInfo) { - DPRINT("TestStartScreenSaverEvent\n"); + DPRINT("SensShutdownEvent\n"); DPRINT("Size: %lu\n", pInfo->Size); DPRINT("Flags: %lx\n", pInfo->Flags); DPRINT("UserName: %S\n", pInfo->UserName); @@ -133,10 +134,10 @@ TestStartScreenSaverEvent( VOID WINAPI -TestStopScreenSaverEvent( +SensStartScreenSaverEvent( PWLX_NOTIFICATION_INFO pInfo) { - DPRINT("TestStopScreenSaverEvent\n"); + DPRINT("SensStartScreenSaverEvent\n"); DPRINT("Size: %lu\n", pInfo->Size); DPRINT("Flags: %lx\n", pInfo->Flags); DPRINT("UserName: %S\n", pInfo->UserName); @@ -150,10 +151,10 @@ TestStopScreenSaverEvent( VOID WINAPI -TestStartShellEvent( +SensStartShellEvent( PWLX_NOTIFICATION_INFO pInfo) { - DPRINT("TestStartShellEvent\n"); + DPRINT("SensStartShellEvent\n"); DPRINT("Size: %lu\n", pInfo->Size); DPRINT("Flags: %lx\n", pInfo->Flags); DPRINT("UserName: %S\n", pInfo->UserName); @@ -167,10 +168,10 @@ TestStartShellEvent( VOID WINAPI -TestPostShellEvent( +SensStartupEvent( PWLX_NOTIFICATION_INFO pInfo) { - DPRINT("TestStartShellEvent\n"); + DPRINT("SensStartupEvent\n"); DPRINT("Size: %lu\n", pInfo->Size); DPRINT("Flags: %lx\n", pInfo->Flags); DPRINT("UserName: %S\n", pInfo->UserName); @@ -181,12 +182,13 @@ TestPostShellEvent( DPRINT("pStatusCallback: %p\n", pInfo->pStatusCallback); } + VOID WINAPI -TestDisconnectEvent( +SensStopScreenSaverEvent( PWLX_NOTIFICATION_INFO pInfo) { - DPRINT("TestDisconnectEvent\n"); + DPRINT("SensStopScreenSaverEvent\n"); DPRINT("Size: %lu\n", pInfo->Size); DPRINT("Flags: %lx\n", pInfo->Flags); DPRINT("UserName: %S\n", pInfo->UserName); @@ -200,10 +202,10 @@ TestDisconnectEvent( VOID WINAPI -TestReconnectEvent( +SensUnlockEvent( PWLX_NOTIFICATION_INFO pInfo) { - DPRINT("TestReconnectEvent\n"); + DPRINT("SensUnlockEvent\n"); DPRINT("Size: %lu\n", pInfo->Size); DPRINT("Flags: %lx\n", pInfo->Flags); DPRINT("UserName: %S\n", pInfo->UserName); diff --git a/dll/win32/wlnotify/test.c b/dll/win32/wlnotify/test.c index e3911d3b75..8f8705547a 100644 --- a/dll/win32/wlnotify/test.c +++ b/dll/win32/wlnotify/test.c @@ -170,7 +170,7 @@ WINAPI TestPostShellEvent( PWLX_NOTIFICATION_INFO pInfo) { - DPRINT("TestStartShellEvent\n"); + DPRINT("TestPostShellEvent\n"); DPRINT("Size: %lu\n", pInfo->Size); DPRINT("Flags: %lx\n", pInfo->Flags); DPRINT("UserName: %S\n", pInfo->UserName); diff --git a/dll/win32/wlnotify/wlnotify.spec b/dll/win32/wlnotify/wlnotify.spec index 737448d4d9..2eb0b647c1 100644 --- a/dll/win32/wlnotify/wlnotify.spec +++ b/dll/win32/wlnotify/wlnotify.spec @@ -5,18 +5,18 @@ ;@ stub SCardSuspendCertProp @ stdcall SchedEventLogoff(ptr) @ stdcall SchedStartShell(ptr) -;@ stub SensDisconnectEvent -;@ stub SensLockEvent -;@ stub SensLogoffEvent -;@ stub SensLogonEvent -;@ stub SensPostShellEvent -;@ stub SensReconnectEvent -;@ stub SensShutdownEvent -;@ stub SensStartScreenSaverEvent -;@ stub SensStartShellEvent -;@ stub SensStartupEvent -;@ stub SensStopScreenSaverEvent -;@ stub SensUnlockEvent +@ stdcall SensDisconnectEvent(ptr) +@ stdcall SensLockEvent(ptr) +@ stdcall SensLogoffEvent(ptr) +@ stdcall SensLogonEvent(ptr) +@ stdcall SensPostShellEvent(ptr) +@ stdcall SensReconnectEvent(ptr) +@ stdcall SensShutdownEvent(ptr) +@ stdcall SensStartScreenSaverEvent(ptr) @ stdcall +SensStartShellEvent(ptr) @ stdcall SensStartupEvent(ptr) @ stdcall +SensStopScreenSaverEvent(ptr) @ stdcall SensUnlockEvent(ptr) ;@ stub ShowNotificationBallonW @ stdcall TestDisconnectEvent(ptr) @ stdcall TestLockEvent(ptr)

1 0

Postponing the July Meeting
by Colin Finck 02 Aug '18

02 Aug '18

Hi all! Looking at the calendar, it would be time for the July Meeting today. However, I didn't receive any agenda proposals and also forgot to announce it in the course of releasing 0.4.9. So I suggest we postpone the meeting to next week's Thursday, August 2. Please send agenda proposals by then. That meeting also allows us to handle last-minute planning regarding the Hackfest. Best regards, Colin

4 6

Re: [ros-dev] Postponing the July Meeting
by Giannis Adamopoulos 02 Aug '18

02 Aug '18

Hi, I really like this idea. Actually i was thinking something similar about user mode apps like paint or even the file browser of the shell which can be used from windows xp to windows 10. (You need just these three files from us: filebrowser.exe, rshell.dll and browseui.dll). Ged Murphy <gedmurphy.maillists(a)gmail.com> wrote on Wed, August 1st, 2018, 11:30 PM: > We could keep components in the reactos git project and just create a new repo for them, however it might still get lost/overshadowed slightly by the main reactos codebase. Another option would be to create a new separate project with one\multiple repos. This would allow us to truly separate components from the reactos project and try to generate interest on their own merit. > > We'd need to maximize their visibility by adding a good README.rd files with plenty of buzzwords for the google crawler bot to pick up. > > If it was successful and we decide to do more, then we'd need to come up with a format as to how to best manage multiple components. > Do we have individual repos for each component, which allows dedicated README.rd files? This would give maximum flexibility and allow us to have a separate README.rd for each component. > Do we bundle everything into one repo similar to how the WDK samples are setup? This is easier to manage, but less convenient for end users, and won't be as visible for people to find in google searches. > > Ged. > > > -----Original Message----- > From: Ros-dev <ros-dev-bounces(a)reactos.org> On Behalf Of Hermès BÉLUSCA-MAÏTO > Sent: Wednesday, 01 August 2018 20:20 > To: 'ReactOS Development List' <ros-dev(a)reactos.org> > Subject: Re: [ros-dev] Postponing the July Meeting > > Hi, > > This sounds interesting, for potential developers wanting just to work on some module, but not wanting to deal with the whole OS thing. > Would this mean that we also have to think about git submodules? Because (in the case of the NTFS driver for example) it would be in a different git repo, and then it would have to be automatically downloaded and updated whenever one of the core ROS dev updates his own ROS git repo. > > Cheers, > Hermes > > > -----Message d'origine----- > > De : Ros-dev [mailto:ros-dev-bounces@reactos.org] De la part de Ged > > Murphy Envoyé : mercredi 1 août 2018 20:16 À : 'ReactOS Development > > List' > > Objet : Re: [ros-dev] Postponing the July Meeting > > > > I have an item for the agenda. I'd like to discuss the possibility of > > moving some of our drivers out of the main repo and into something more convenient. > > > > In case I don't make the meeting, I'll put forward some of my reasons here: > > > > This thought has come about due to the btrfs driver which we use from > > Mark Harmstone. Mark's project receives quite a bit of interest on > > github, and I'm assuming one of the reasons is that it's so easy to > > find and build. Searching for 'btrfs windows' lists his project as the > > top hit in google, and building is as simple as cloning, opening the > > project in VS and clicking build (assuming you have the > > WDK) > > > > I'm wondering if we did the same thing to some of our drivers, we > > might generate more interest in them. A good example would be our NTFS driver. > > When searching for open source NTFS solutions you're only really given > > Linux and Max options. The reactos driver is buried deep in the search > > list, and you only see it if you know what you're looking for. Next if > > you want to build it, you need to clone the main reactos repo, install > > the build tools, setup and build the environment, build the tool > > chain, build the linkers libs, etc, etc. There are so many barriers > > for people who aren't part of the reactos development team that the chance of getting anyone interested in it are practically zero. > > > > This process would be much simpler if the code was available to clone > > as a separate project, and could simply build with the WDK and VS. > > There's then a chance that it might start to generate interest, and > > people may start working on it instead of it just bit-rotting deep in our main repo. > > > > If we're going to do that, why not consider others too. Network cards, > > sound stack, USB, boot loaders, printer drivers, directx, etc, There's > > lots of things that people might be interested in working on and using > > if they weren't tied to the reactos code base. We obviously benefit > > from any external interest, and simply pull/import it back into the reactos project. > > > > Ged. > > > > > > > > -----Original Message----- > > From: Ros-dev <ros-dev-bounces(a)reactos.org> On Behalf Of Colin Finck > > Sent: Thursday, 26 July 2018 17:58 > > To: 'ReactOS Development List' <ros-dev(a)reactos.org> > > Subject: [ros-dev] Postponing the July Meeting > > > > Hi all! > > > > Looking at the calendar, it would be time for the July Meeting today. > > However, I didn't receive any agenda proposals and also forgot to > > announce it in the course of releasing 0.4.9. > > So I suggest we postpone the meeting to next week's Thursday, August 2. > > > > Please send agenda proposals by then. > > That meeting also allows us to handle last-minute planning regarding > > the Hackfest. > > > > Best regards, > > > > Colin > > > > > > > > _______________________________________________ > > Ros-dev mailing list > > Ros-dev(a)reactos.org > > http://www.reactos.org/mailman/listinfo/ros-dev > > > _______________________________________________ > Ros-dev mailing list > Ros-dev(a)reactos.org > http://www.reactos.org/mailman/listinfo/ros-dev > > > _______________________________________________ > Ros-dev mailing list > Ros-dev(a)reactos.org > http://www.reactos.org/mailman/listinfo/ros-dev

2 1

Repetitive "shell submit results failed" errors when running testbot manually
by Hermès BÉLUSCA - MAÏTO 01 Aug '18

01 Aug '18

Hello! I repeatedly get an error "shell submit results failed" while trying to run testbot on a PR  patch, see for example https://build.reactos.org/builders/Test%20KVM/builds/20818 and as a result I cannot obtain the results under reactos.org/testman . Can someone investigate what is going on? Regards, Hermes

2 1

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev