- Ros-dev - ReactOS.org

Rose server will be down for hardware maintenance

by Colin Finck

Hi all, After ongoing sudden crashes on our third server Rose (currently only serving the BuildBot and primary DNS), I highly suspect a hardware failure. This is why I'll let the hosting provider conduct a hardware stress test tomorrow and eventually replace broken parts. So don't be surprised if these services are down tomorrow. I'll do my best to get them up reliably again as soon as possible. Cheers, Colin

15 years, 1 month

1
1
0 0

Flash player regressed?

by Javier Agustìn Fernàndez Arroyo

could anyone take a look at this? http://www.reactos.org/compat/?show=version&id=839 i have sent a private message to the user asking for a debug log and a bug report...

15 years, 1 month

1
0
0 0

ReactOS & the Opensource World Conference (Malaga, 2010)

by victor martinez

Opensource World Conference (Malaga, 2010), is accepting papers for the meeting that is going to take place on 27/28 October. "The Open Source World Conference (OSWC) is probably the most important European event related to open source technologies. Following six editions of this conference organized by the regional governments of Andalusia and Extremadura in collaboration with the most important companies in the sector, this conference has become a unique event open to everyone interested in the field of software innovation, from users, social agents and developers, through to business leaders, investors and members of public administrations." Andalusia and Extremadura governments are pushing quite hard toward the Opensource administration.They are working together to use just Opensource apps and OSes in their Universities and Administrations. Actually they have created some Opensource OSes as Guadalinex(a Linux distro) and some opensource organizations to push and support opensource ideas. In this conference companies and investors will meet, so maybe we can find some kind of Companies or Government support. Projects, this year, will be elected by votes. Other projects are pushing quite hard. So as this is not another OpenSource meeting but THE OpenSource meeting, I want you to push and vote. We made in Sourceforge Awards and we can do it again. Creating an user takes less than 1 minute: http://www.opensourceworldconference.com/malaga10/?q=en/user/register Vote "5-star" in this page(after Login): http://www.opensourceworldconference.com/malaga10/?q=node/953 I promise to make my best PR to find in this meeting any ReactOS opportunity. If there is any, I will find it. :) _________________________________________________________________ Accede a tu Hotmail en un solo clic ¡Descárgate Internet Explorer 8 y empieza a disfrutar de todas las ventajas! http://www.ayudartepodria.com/

15 years, 1 month

1
0
0 0

Re: [ros-dev] [ros-diffs] [akhaldi] 48293: [CMAKE] - Add dxsdk interfaces to build.

by Timo Kreuzer

> +MACRO (MACRO_ADD_DXSDK_INTERFACES) > + > + FOREACH(_in_FILE ${ARGN}) > + > + GET_FILENAME_COMPONENT(FILE ${_in_FILE} NAME_WE) > + > + ADD_CUSTOM_COMMAND( > + OUTPUT ${REACTOS_BINARY_DIR}/include/dxsdk/${FILE}.h > + COMMAND native-widl -I${REACTOS_SOURCE_DIR}/include/dxsdk -I. -I${REACTOS_SOURCE_DIR}/include -I${REACTOS_SOURCE_DIR}/include/psdk -m32 --win32 -h -H ${REACTOS_BINARY_DIR}/include/dxsdk/${FILE}.h ${REACTOS_SOURCE_DIR}/include/dxsdk/${FILE}.idl > + DEPENDS native-widl > + ) > + > + SET_SOURCE_FILES_PROPERTIES( > + ${REACTOS_BINARY_DIR}/include/dxsdk/${FILE}.h > + PROPERTIES > + GENERATED TRUE > + ) > + > + LIST(APPEND DXSDK_HEADERS ${REACTOS_BINARY_DIR}/include/dxsdk/${FILE}.h) > + > + ENDFOREACH(_in_FILE ${ARGN}) > + > +ENDMACRO (MACRO_ADD_DXSDK_INTERFACES) > + > +file(GLOB_RECURSE SOURCE "*.idl") > + > +LIST(REMOVE_ITEM SOURCE ${REACTOS_SOURCE_DIR}/include/dxsdk/axcore.idl) > +LIST(REMOVE_ITEM SOURCE ${REACTOS_SOURCE_DIR}/include/dxsdk/axextend.idl) > +LIST(REMOVE_ITEM SOURCE ${REACTOS_SOURCE_DIR}/include/dxsdk/devenum.idl) > +LIST(REMOVE_ITEM SOURCE ${REACTOS_SOURCE_DIR}/include/dxsdk/dshowasf.idl) > +LIST(REMOVE_ITEM SOURCE ${REACTOS_SOURCE_DIR}/include/dxsdk/dyngraph.idl) > +LIST(REMOVE_ITEM SOURCE ${REACTOS_SOURCE_DIR}/include/dxsdk/vmrender.idl) > + > +MACRO_ADD_DXSDK_INTERFACES(${SOURCE}) > + > +ADD_CUSTOM_TARGET(dxsdk ALL DEPENDS ${DXSDK_HEADERS}) > Beautiful!

15 years, 1 month

1
0
0 0

Freetype Patented Hinting

by Ros Arm

Hello, A recent CMAKE commit has made me notice that a NOSWPAT option determines if FreeType hinting should be used or not. Please note that the Apple patent on the technology recently expired, and this option is not needed anymore, as hinting should always be enabled. -r

15 years, 1 month

3
2
0 0

ReactOS x64 edition

by Timo Kreuzer

Hi, I'd like to announce that as of r48278, you can build a full x64 bootcd (including rostests, not rosapps) from trunk. That means from now on, I can quickly see when someone breaks 64 bit compatibility: http://reactos.ath.cx:8081/waterfall So please don't cast PVOID to ULONG ;-) Regards, Timo PS: no, it doesn't boot to desktop

15 years, 1 month

3
2
0 0

freeldr as PE file

by Timo Kreuzer

Hi I'd like to propose a small change: converting freeldr into a PE file. The current freeldr / setupldr are raw binaries, which makes them easy to handle for the bootsector but it disqualifies them from proper debugging with gdb. A solution is to convert them into PE format. As there is no space to implement a real PE loader in the bootsector, the image must not use a .bss section, this can easily be done with a linker script. I have this working in my WC. With the result we can use gdb for debugging freeldr including symbols. The only thing still to solve is how to remove rsym data from the files, without stripping all symbols. Rsym data makes the file twice as big, too big to be loaded in to real mode memory. Any objections / suggestions? Regards, Timo

15 years, 1 month

2
3
0 0

Re: [ros-dev] [ros-diffs] [cgutman] 48221: - Fix epic naming fail (DhcpEnabled -> EnableDH

by Johannes Anderwald

> - DWORD Error = ERROR_SUCCESS, DhcpEnabled; > + DWORD Error = ERROR_SUCCESS, DhcpEnabled, Length; > [...] > + Error = RegQueryValueEx(AdapterKey, "EnableDHCP", NULL, NULL, (LPBYTE)&DhcpEnabled, &Length); IMO Length needs to be initialized first > + > + if (Error != ERROR_SUCCESS || Length != sizeof(DWORD)) > DhcpEnabled = 1; > > CloseHandle(AdapterKey); regards Johannes [1] http://msdn.microsoft.com/en-us/library/ms724911%28VS.85%29.aspx

15 years, 1 month

1
0
0 0

Re: [ros-dev] [ros-diffs] [dreimer] 48036: Bug 5501: [PATCH] Adding Wing32support by Carlo Bramini

by Aleksey Bragin

What's that massive reactos.dff change introduced with this rev? -------------------------------------------------- From: <dreimer(a)svn.reactos.org> Sent: Wednesday, July 14, 2010 2:59 PM To: <ros-diffs(a)reactos.org> Subject: [ros-diffs] [dreimer] 48036: Bug 5501: [PATCH] Adding Wing32support by Carlo Bramini > Author: dreimer > Date: Wed Jul 14 10:59:32 2010 > New Revision: 48036 > > URL: http://svn.reactos.org/svn/reactos?rev=48036&view=rev > Log: > Bug 5501: [PATCH] Adding Wing32 support by Carlo Bramini > > Added: > trunk/reactos/dll/win32/wing32/ > trunk/reactos/dll/win32/wing32/wing32.c (with props) > trunk/reactos/dll/win32/wing32/wing32.rbuild (with props) > trunk/reactos/dll/win32/wing32/wing32.spec (with props) > Modified: > trunk/reactos/boot/bootdata/packages/reactos.dff > trunk/reactos/dll/win32/win32.rbuild

15 years, 2 months

5
4
0 0

ReactOS compatibility Database --- Still testing in 0.3.11

by Javier Agustìn Fernàndez Arroyo

Hi all, im visiting the compatibility database page frequently, and im still seeing people testing applications against 0.3.1 .... 0.3.11 is too old currently, there have been tons of bugfixes, new features, and overall changes that affect many applications since 0.3.11 release. Lots of them have changed their behavior into ReactOS since those changes. What i want to say is, compatibility with 0.3.11 is quite meaningful right now, due to massive changes in ReactOS lately. Lets use HEAD revisions to test new apps, and report bugs against it :) cheers!

15 years, 2 months

1
0
0 0

[ros-diffs] [jgardou] 47802: Merge 47800 from yarotows branch.

by James Tabor

Jérôme, Need to go through your commit list and check and see which ones need to be pushed to the trunk. So far as I see (read), the changes look good. Thanks, James

15 years, 3 months

3
3
0 0

Build process changes...

by Timo Kreuzer

After Olaf's mentioning of increased buildtimes I'd like to throw 2 different, independent and major changes to our build process into discussion. One is about rbuild and one is about the file layout. I'd like to start with the rbuild related topic. What I suggest only for consideration, is a move away from rbuild and instead using CMake. CMake is available for Windows and *nix, for Windows both as commandline ans as a lightweight gui tool. It is capable of translating a portable buildfile format into different makefile formats, including nmake and project files for VS and CodeBlocks. It seems incredibly fast compared to rbuild and probably provides every feature we ever need. Although the syntax is a tiny bit more complex than rbuild files, it's much better than writing makefiles. Adding support for building with MSVC should be relatively easy. It's not really a suggestion, as I'm not sure about all the details, but I think it's worth reviewing and taking into consideration. The second thing is about the file layout. I will post a seperate mail soon. Regards, Timo

15 years, 3 months

9
11
0 0

Removing the autoregister feature from rbuild

by Eric Kohl

Hi! I want to remove the "autoregister" feature from rbuild. Let me explain why I want to do this. The "autoregister" feature in rbuild is used to automatically add dlls to the syssetup.inf file which require an ole server registration. The ole servers in these dlls will then be registered in the 2nd setup stage. The gain of adding the ole server dlls to syssetup.inf automatically is almost non existant as a developer needs to add an 'autoregister' element to the rbuild file of the dll. For example: <autoregister infsection="OleControlDlls" type="DllInstall" /> The corresponding line in the 'OleControlsDll' section of syssetup.inf is: 11,,comctl32.dll,2 Please remember that the line above only needs to be added once. Now, what do we loose by generating syssetup.inf automatically? Right now it is only the comments in this file as it is parsed and serialized by the inflib library. OTOH, my future plans for syssetup.inf are severely hampered by the way rbuild handles syssetup.inf because rbuild is not able to create or modify a Unicode version of syssetup.inf. But, a Unicode version of syssetup.inf is required in order to replace the hard-coded creation of the start menu and desktop links in syssetup.dll by a configurable, localizable and Windows compatible inf-based method. And finally since Timo suggested to replace rbuild by cmake: The autoregister feature would surely be one of the victims of this change. So why not drop this almost useless feature now? What do you think? Regards, Eric

15 years, 3 months

5
4
0 0

WHY YOU'VE MADE ROS_SECTION_OBJECT RATHER THAN SECTION?

by Mariusz Gliwiński

Recently, I've been watching MiLoadImageSection(). It takes PVOID casted to ROS_SECTION_OBJECT parameter. Why is that? Furthermore, it isn't really a same definition as on MS Windows (XP). Why You've made this difference? -- Pozdrawiam, Mariusz Gliwiński

15 years, 3 months

1
0
0 0

Re: [ros-dev] [ros-diffs] [cgutman] 47761: [FBTUSB] - Import the FreeBT USB generic bluetooth driver (abandoned) - Some slight modifications to make it build - WMI is currently commented out because our WMI headers are lacking (particularly wmistr.h)

by Ged Murphy

Not again. Why on earth do we need a bluetooth driver when we don't even have a stable OS to run it on? On 12 June 2010 13:46, Aleksey Bragin <aleksey(a)reactos.org> wrote: > Even though it's abandoned, I feel it's going to be abandoned in our source > tree too. > > WBR, > Aleksey Bragin. > > > On Jun 12, 2010, at 4:29 AM, cgutman(a)svn.reactos.org wrote: > > Author: cgutman >> Date: Sat Jun 12 00:29:09 2010 >> New Revision: 47761 >> >> URL: http://svn.reactos.org/svn/reactos?rev=47761&view=rev >> Log: >> [FBTUSB] >> - Import the FreeBT USB generic bluetooth driver (abandoned) >> - Some slight modifications to make it build >> - WMI is currently commented out because our WMI headers are lacking >> (particularly wmistr.h) >> - Not building by default for now >> > > > _______________________________________________ > Ros-dev mailing list > Ros-dev(a)reactos.org > http://www.reactos.org/mailman/listinfo/ros-dev >

15 years, 3 months

5
5
0 0

Re: [ros-dev] [ros-diffs] [cgutman] 47761: [FBTUSB] - Import the FreeBT USB generic bluetooth driver (abandoned) - Some slight modifications to make it build - WMI is currently commented out because our WMI headers are lacking (particularly wmistr.h) - Not building by default for now

by Aleksey Bragin

Even though it's abandoned, I feel it's going to be abandoned in our source tree too. WBR, Aleksey Bragin. On Jun 12, 2010, at 4:29 AM, cgutman(a)svn.reactos.org wrote: > Author: cgutman > Date: Sat Jun 12 00:29:09 2010 > New Revision: 47761 > > URL: http://svn.reactos.org/svn/reactos?rev=47761&view=rev > Log: > [FBTUSB] > - Import the FreeBT USB generic bluetooth driver (abandoned) > - Some slight modifications to make it build > - WMI is currently commented out because our WMI headers are > lacking (particularly wmistr.h) > - Not building by default for now

15 years, 3 months

1
0
0 0

Re: [ros-dev] [ros-diffs] [cgutman] 47761: [FBTUSB] - Import the FreeBT USB generic bluetooth driver (abandoned) - Some slight modifications to make it build - WMI is currently commented out because our WMI headers are lacking (particularly wmistr.h) - Not bui

by Ged Murphy

On 12 June 2010 01:29, <cgutman(a)svn.reactos.org> wrote: > > - WMI is currently commented out because our WMI headers are lacking > (particularly wmistr.h > WMI is completely missing from reactos in every way

15 years, 3 months

1
0
0 0

Re: [ros-dev] [ros-diffs] [fireball] 47757: - Merge in changes from Wine-1.1.44 related to supporting the ETO_PDY flag. Unregresses the text rendering in FF 3.5. Thanks to Jan Roeloffzen for help finding this problem and suggesting the right solution.

by Aleksey Bragin

I beg my pardon, I accidentally pasted wrong name there. The real thanks goes to Maarten Kroese (nickname Drazic in the Freenode network). WBR, Aleksey Bragin. On Jun 12, 2010, at 12:19 AM, fireball(a)svn.reactos.org wrote: > Author: fireball > Date: Fri Jun 11 20:18:59 2010 > New Revision: 47757 > > URL: http://svn.reactos.org/svn/reactos?rev=47757&view=rev > Log: > - Merge in changes from Wine-1.1.44 related to supporting the > ETO_PDY flag. Unregresses the text rendering in FF 3.5. Thanks to > Jan Roeloffzen for help finding this problem and suggesting the > right solution. > > Modified: > branches/arwinss/reactos/dll/win32/winent.drv/font.c > branches/arwinss/reactos/subsystems/win32/win32k/gre/font.c

15 years, 3 months

1
0
0 0

Re: [ros-dev] I have a lot of Questions

by Ged Murphy

Hi Ian, Your help would be very much welcome and appreciated. You've actually come at a very good time. Our whole backend, known as RosCMS has just been rewritten and is now at version 4. It's a content management system similar to Joomla, but written to better serve the needs of this project. Whilst the backend is now running and stable, the frontend needs a complete rewrite. We had a design contest a few months ago and this was the winning design : http://img200.imageshack.us/img200/7833/reactoswebsitedesign4.png So far no one has had the time to make a start on it, so we're still running on the now outdated site. What we need is for someone to get involved in bringing this new layout to life. It's probably best if you join the IRC channel and chat to our web designer. He's called Danny and he goes by the nick of DangerGround in IRC. He should be able to give you more info and guidance on what is required. I'm posting this mail to the ros-dev mailing list so he and our other web guys can pick it up. You can continue to converse with me via private mail if you prefer to. Regards, Ged Murphy. From: Ian Hilton [mailto:ian7hilton@gmail.com] Sent: 04 June 2010 02:13 To: dev-interest(a)reactos.org Subject: I have a lot of Questions Hi My name is Ian Joseph Hilton I am a freshman in community college. I consider myself a website developer of sorts in training, and for the past year or so been familiarizing myself with website coding. I have been mostly using Google based programs as my platform, and have so far just barely stuck my toe in the water in attempting to write extensions for Google's chrome browser. My main project is what I call Titanways Teaching (or Tutoring) In Terrific And New ways and was my High school Exhibition project required by the state of California to graduate, and it has got moderate attention. the link is here : http://sites.google.com/site/titanwayssite/ I know what you must be thinking by now most likely that I have lack of what you need and as my Uncle who currently writes programs for Medical Equipment says I need at least two years or so to be taken seriously and not laughed, but it never hurts to ask some things and worst comes to worse I learn some things to point me in new directions which is always great. Anyway I of course have been aware of your ReactOS project for a few years and only recently has it occurred to me that I should inquire somethings regarding it. Note I have not been "Tainted" at all as whatever you are talking about with Microsoft's source code totally goes over my head. I do use XP as my operating system However on a Toshiba NB 305 net-book. This is because a lot of my programs I am satisfied with run on this operating system. My point to that is my net-book has further taught me terms like debugging as not every program will run on it without a little help by doing various things like editing a config file to fit its 1024x600 resolution frame. I has also used Linux Ubuntu and am familiar with Macintosh interface via that is the main platform students use at general educational institutions. Now to get right to the point, right now I might not know much but if there is anyway in the future that I may offer assistance in any form I would be happy to, and also any helpful training or guidance you can point me in in regards to coding website components for ReactOS would be even better. I use mostly opensource alternatives to windows programs anyway such as Open Office.org as I kinda share that feeling with you that Microsoft kinda took a monopolistic view to its commercial applications. I wish to ask how compatible is it currently with opensource apps that run on Java platforms if it is integrated with as well as the web browsers that it is compatible with? I have been familiarizing myself with all three of the basic website rendering engines Trident, Gecko, and Web-kit via the experimental triple engine browser being developed by a Japanese software Company and is known as Lunascape. I also want to know if this OS can support docking software such as Object dock or Rocket-dock and if not what would I say need to do to learn how to make that kind of thing a possibility. I will conclude by saying once again right now you may view me as inexperienced but that I am quickly learning and any pointers I take gratefully and with interest in consideration. High Regards to you, Ian P.S. will be taking Computer Classes in future semesters however it is my opinion that the best in the field should try to learn from scratch ,and so I am going to start by attempting to teach myself to write programs in C/C++ coding and see where that leads

15 years, 3 months

2
1
0 0

Re: [ros-dev] [ros-diffs] [tkreuzer] 47561: revert 47559 and 47560 (once again... sigh)

by Ged Murphy

Windows buildbot! :) -----Original Message----- From: ros-diffs-bounces(a)reactos.org [mailto:ros-diffs-bounces@reactos.org] On Behalf Of tkreuzer(a)svn.reactos.org Sent: 04 June 2010 01:50 To: ros-diffs(a)reactos.org Subject: [ros-diffs] [tkreuzer] 47561: revert 47559 and 47560 (once again... sigh) Author: tkreuzer Date: Fri Jun 4 02:49:33 2010 New Revision: 47561 URL: http://svn.reactos.org/svn/reactos?rev=47561&view=rev Log: revert 47559 and 47560 (once again... sigh)

15 years, 3 months

2
1
0 0

Communication Problems re 47514 & co.

by Ros Arm

Hello, First I was asked if a certain developer could talk to me regarding ARM3. I said yes, never heard back, and then saw commits done to pfnlist.c. While interesting and useful code, some communication would've been nice in order to talk about the goals, since much of that code is in flux (I feel bad when someone improves a function that I will later remove, as two of the improved functions are only temporary -- the changes to the other functions will remain, obviously). Normally, this would not have been a problem, if not for the strange formatting and the fact this code was now broken and causing a boot regression. I showed up in the #reactos-dev channel and instructed developers on how to fix the problem: remove the entire function and use MiInsertPageInFreeList instead, or fix MiInitializePagingLists to perform its work at DISPATCH_LEVEL instead, by acquiring the PFN lock as it should do. None of this was done, instead "janderwald", in 47514, "Fixed" the ASSERT by saying "Any IRQL lower than DISPATCH_LEVEL" is okay. Janderwald, whoever you are, do you even understand this code? Are you even a kernel-mode developer? Does it make to you that the code would need to assert for low IRQL? The whole point is to validate that the PFN lock is being held. Even if you are not a kernel-mode dev, isn't it clear that all the other assertions are also checking for DISPATCH_LEVEL+? And even if that's not clear, I had written down the solution in the #reactos-dev channel, expecting that probably not many people would figure it out. So I guess some lessons to learn for this project: 1) If you modify someone's code, make sure you test your changes (and preferably don't mess up the formatting) so their code is not now blamed for a boot regression. 2) If someone tells you how to fix their code after it's been messed up, apply the fix. 3) If you choose to roll your own fix, write something useful instead of breaking the function (logic-wise) even more. Again, I'm afraid the problem is most of you are students and don't have work ethics of real employees -- this seems to be the root of many problems this project has had since the last 2 years I've been watching and working on the ARM port. Next steps: - Janderwald: remove your ASSERT hack. Either 1) Remove the ASSERT (stop checking for an invariant that doesn't happen) or 2) Fix the caller (so the invariant holds) - Arthur: changes are appreciated, but let's talk more so you don't end up improving dead code. Carry on! -r

15 years, 3 months

2
2
0 0

Some proposals for roadmap

by Javier Agustìn Fernàndez Arroyo

hello, i have thinking about an easy way to show people the ReactOS roadmap, and there came to my mind two projects where i have submitted some bug reports before joining ReactOS. They use the "milestone" field in their bug reports for the roadmaps, and its a quite clean way to show it, IMO Here are the links Is there any way to do something similar using Bugzilla? (none of these 2 projects use this Bug Management System) http://www.kdenlive.org/mantis/roadmap_page.php http://developer.pidgin.im/roadmap

15 years, 3 months

2
1
0 0

Testbots fail to boot ReactOS since 47510

by Olaf Siejka

Since arty's commit in rev 47510, one of his asserts is being triggered in bot qemu and vbox. This practically lock down both testbots as they cannot cont it. I have two requests: - Could you all refrain from commiting until this problem is resolved? - If this issue is not to be fixed soon enough, can this particular assert be commented out for the time being? Debug log below: WARNING: HalStopProfileInterrupt at hal\halx86\generic\profil.c:24 is UNIMPLEMENTED! Assertion 'KeGetCurrentIrql() == DISPATCH_LEVEL' failed at ARMÂł::PFNLIST line 61 Entered debugger on embedded INT3 at 0x0008:0x808e9b7e. kdb:> bt Eip: <808e9b7f (DbgBreakPoint)> Frames: <8089840f (ARM┬│::PFNLIST:61 (MiInsertInListTail@8))> <808a26cd (ntoskrnl/mm/freelist.c:499 (MmInitializePageList@0))> <8089088b (ARM┬│::INIT:X86:521 (MiInitMachineDependent@4))> <80896a61 (ARM┬│::INIT:1846 (MmArmInitSystem@8))> <808a51f7 (ntoskrnl/mm/mminit.c:388 (MmInitSystem@8))> <8084404b (ntoskrnl/ex/init.c:1008 (ExpInitializeExecutive@8))> <8080450b (ntoskrnl/ke/i386/kiinit.c:564 (KiInitializeKernel@24))> <8080467e (ntoskrnl/include//internal/arch/../i386/ke.h:235 (KiSystemStartupBootStack@0))> <0000000e> Entered debugger on last-chance exception (Exception Code: 0xc0000005) (Page Fault) Memory at 0x0007767C could not be read: Page not present. *** Fatal System Error: 0x0000001e (0xC0000005,0x80877985,0x80967DC0,0x00000000) Entered debugger on embedded INT3 at 0x0008:0x808e9b84.

15 years, 3 months

1
0
0 0

Re: [ros-dev] [ros-diffs] [janderwald] 47509: [NPFS] - Add more buffer checks - Clear DO_DEVICE_INITIALIZING flag

by Ged Murphy

janderwald(a)svn.reactos.org wrote: > + DeviceObject->Flags &= ~DO_DEVICE_INITIALIZING; This is done by the IO manager for any device objects created in DriverEntry If it's not then we have a bug, but I'm fairly sure it does otherwise we wouldn't be able to open devices from umode :) Ged.

15 years, 3 months

1
0
0 0

Re: [ros-dev] [ros-diffs] [tkreuzer] 47484: - add explicit braces to avoid ambiguous 'else' - fix deprecated conversion from string constant to 'char*'

by Ged Murphy

This is Wine code, it'll get lost in the next sync On 31 May 2010 05:13, <tkreuzer(a)svn.reactos.org> wrote: > Author: tkreuzer > Date: Mon May 31 06:13:40 2010 > New Revision: 47484 > > URL: http://svn.reactos.org/svn/reactos?rev=47484&view=rev > Log: > - add explicit braces to avoid ambiguous 'else' > - fix deprecated conversion from string constant to 'char*' > > Modified: > trunk/reactos/dll/win32/browseui/internettoolbar.cpp > > Modified: trunk/reactos/dll/win32/browseui/internettoolbar.cpp > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/browseui/interne… > > ============================================================================== > --- trunk/reactos/dll/win32/browseui/internettoolbar.cpp [iso-8859-1] > (original) > +++ trunk/reactos/dll/win32/browseui/internettoolbar.cpp [iso-8859-1] Mon > May 31 06:13:40 2010 > @@ -414,10 +414,16 @@ > { > SMINFO *infoPtr = (SMINFO *)lParam; > if ((infoPtr->dwMask & SMIM_FLAGS) != 0) > + { > if (psmd->uId == FCIDM_MENU_FAVORITES) > + { > infoPtr->dwFlags |= > SMIF_DROPCASCADE; > - else{ > - infoPtr->dwFlags |= > SMIF_TRACKPOPUP;} > + } > + else > + { > + infoPtr->dwFlags |= > SMIF_TRACKPOPUP; > + } > + } > if ((infoPtr->dwMask & SMIM_ICON) != 0) > infoPtr->iIcon = -1; > } > @@ -1213,7 +1219,7 @@ > CComPtr<IObjectWithSite> > objectWithSite; > CComPtr<IContextMenu> contextMenu; > CMINVOKECOMMANDINFO > commandInfo; > - char > *searchGUID = "{169A0691-8DF9-11d1-A1C4-00C04FD75D13}"; > + const char > *searchGUID = "{169A0691-8DF9-11d1-A1C4-00C04FD75D13}"; > HRESULT > hResult; > > // TODO: Query shell if this command is enabled first > > >

15 years, 3 months

2
2
0 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev