- Ros-dev - ReactOS.org

USetup meets NewInfLib
by Roel Messiant 28 Apr '10

28 Apr '10

Hey, This one's mostly for Eric Kohl. Newinflib seems to be causing some issues for usetup, accessing memory it shouldn't. Attached are some patches that solve this. The newinflib one fixes some pointer arithmetic, which ended up lying about a buffer size. This was already fixed in the host code, so I just applied the same fix to the ros code. The usetup patch is a hackfix. The issue here is that usetup fetches a line from a section, but the line is blank. Usetup treats it as a data line, and reading the data from it results in NULL .. which usetup tries to dereference. I just hackfixed that one because the code hasn't changed, so it must've worked fine with the previous inflib. So the question end up as: is newinflib wrong here by not trying to skip the blank line, or should usetup keep in mind such lines can exist.. or some third option? WBR, Roel Messiant PS: I know patches belong in bugzilla, but the perceived urgency on my side won the decision on where to post them.

2 1

I need help fixing rbuild and testing builds on *nix machines!
by Eric Kohl 27 Apr '10

27 Apr '10

Hi! In order to fix bug #2482 I needed to make inflib Unicode-aware. My local ReactOS setup is curently able to build Boot-CD and Live-CD using Unicode hive*.inf files. Rbuild is the only tool that still uses the original inflib. Could someone who knows more about C++ and STL than I do have a look at rbuild and make it work with the new inflib? I can provide a patch that includes newinflib (Unicode-aware inflib) and my changes to usetup and mkhive. I also need someone who can test the whole patch on a *nix machine. Any volunters? Regards, Eric

3 4

Live-CD broken!
by Eric Kohl 25 Apr '10

25 Apr '10

Hi! Could someone who is building ReactOS on a Linuy system have a look at why mkhive fails when Live-CD is built? Unfortunately I don't have a Linux system for testing. Thanks in advance! Eric

1 0

Re: [ros-dev] Regression since rev. 46042 from sir_richard
by mrnobo1024 25 Apr '10

25 Apr '10

This bug is a lot older than that, I can't remember thread list ever not being crash-prone. From 0.3.11 livecd: ←[7h♣Entered debugger on embedded INT3 at 0x0008:0x808c6fb6. kdb:> proc list PID State Filename *0x00000004 In Memory System 0x00000044 In Memory smss.exe 0x0000007c In Memory csrss.exe 0x000000a0 In Memory winlogon.exe 0x000000bc In Memory services.exe 0x000000c4 In Memory lsass.exe 0x000000f0 In Memory eventlog.exe 0x0000010c In Memory spoolsv.exe 0x00000120 In Memory dhcp.exe 0x0000013c In Memory rpcss.exe 0x00000180 In Memory umpnpmgr.exe 0x00000290 In Memory explorer.exe kdb:> proc attach 0xa0 Attached to process 0x000000a0, thread 0x000000a4. kdb:> thread list TID State Prior. Affinity EBP EIP *0x000000a4 Waiting 8 0x00000001 0x0063fecc 0x7c90697a Assertion 'TempPte.u.Long != 0' failed at ARM┬│::PAGFAULT line 161 Entered debugger on embedded INT3 at 0x0008:0x808c6fb6. *** Fatal System Error: 0x0000001e (0x80000003,0x808C6FB6,0x80957048,0x00000000) Entered debugger on embedded INT3 at 0x0008:0x808c6fbc.

2 1

Regression since rev. 46042 from sir_richard
by Olaf Siejka 25 Apr '10

25 Apr '10

Revision 46042: [KERNEL32/CSRSS]: Register new Win32 threads with CSRSS. Add a bunch of lookup, creation, allocation, hashing and CSR thread management routines from the unused CSRSRV in trunk. [CSRSS]: Bang in the new thread support in a bunch of places, including creating static server threads. It's very hacked and handle duplication doesn't work 100% reliably, but it gets the job done. [CSRSS]: Add CsrGetProcessLuid, CsrImpersonateClient, CsrRevertToSelf, CsrShutdownProcesses, CsrFindProcessForShutdown required for user-mode shutdown. Right now we are able to reliably enumerate user apps (in the user LUID) and then service/system apps (in the LOCAL SYSTEM LUID). triggers regression described here: http://www.reactos.org/bugzilla/show_bug.cgi?id=5318 (KDBG: Thread list command ASSERTs after attaching to process with PID A0 or higher)

1 0

Re: [ros-dev] [ros-diffs] [sir_richard] 46977: [NTOS]: Enable MmPageEntireDriver by implementing MiSetPagingOfDriver. [NTOS]: Call MiEnablePagingOfDriver from MmLoadSystemImage and implement it. All the work is done other than actually enabling paging, which requi
by Gabriel ilardi 24 Apr '10

24 Apr '10

Hi, After this commit ac97 doesn't install anymore, device wizard remains in a loop and the debug log shows: (drivers/wdm/audio/filters/kmixer/kmixer.c:99) KMixer.sys loaded (drivers/wdm/audio/filters/kmixer/kmixer.c:48) KMix_InstallDevice called (drivers/wdm/audio/filters/kmixer/kmixer.c:83) KMix_InstallDevice result 0 (ntoskrnl/io/pnpmgr/pnpmgr.c:202) Warning: Starting a device node without DNF_ADDED Thanks. Gabriel. > Date: Wed, 21 Apr 2010 14:06:01 +0000 > To: ros-diffs(a)reactos.org > From: sir_richard(a)svn.reactos.org > Subject: [ros-diffs] [sir_richard] 46977: [NTOS]: Enable MmPageEntireDriver by implementing MiSetPagingOfDriver. [NTOS]: Call MiEnablePagingOfDriver from MmLoadSystemImage and implement it. All the work is done other than actually enabling paging, which requires system working set support. [NTOS]: Implement MiWriteProtectSystemImage and MiComputeDriverProtection. All the work is done other than actually setting the bits on the pages, since I wanted to avoid too many changes. [NTOS]: MmCheckSystemImage returns STATUS_INVALID_IMAGE_PROTECT, not STATUS_INVALID_IMAGE_FORMAT, so the branch in MmLoadSystemImage needs to check for the correct status code. [NTOS]: Support FLG_SHOW_LDR_SNAPS for the kernel loader. > _________________________________________________________________ Messenger e Hotmail in tasca. Provali sul tuo cellulare! http://new.windowslivemobile.msn.com/it-it/Default.aspx

1 0

[ros-diffs] [tkreuzer] 46998: Disable gdi batch for SelectObject with fonts. Fixes font regression.
by James Tabor 23 Apr '10

23 Apr '10

Not surprised! I guess ReactOS new polices are for hiding the real issues and not fixing them and revert all the correct code. Since the kernel rewrites and the new order of coding, these oddities have now surfaced. The TEB, is inaccessible from kernel mode as in bug 5265 and 5314, and the strange processes access issues in bug 5310. This revert silliness will result in moving the project back to post windows 95 architecture (arwinss). ReactOS is about moving forward and taking chances with innovations from learned information then moving away to make it work even better. Personally, I hope someone will take up where this left off and move on. Good luck! Reference: http://www.reactos.org/bugzilla/show_bug.cgi?id=5265 http://www.reactos.org/bugzilla/show_bug.cgi?id=5310 http://www.reactos.org/bugzilla/show_bug.cgi?id=5314

3 3

Re: [ros-dev] ShellExecuteEx
by Love Nystrom 23 Apr '10

23 Apr '10

Gregor Schneider <grschneider(a)gmail.com> wrote: > That made me think: what happens to this field if the ShellExecuteEx > call succeeds and the flag SEE_MASK_NOCLOSEPROCESS is not set? Since > this check was thought to forward the actual result of the execution i > switched to a simpler and (in my eyes) more reliable code. Plus the > original code did not use the flag noted in the specification. > The link you provided on the other hand makes it look like > ShellExecuteEx always sets this field indendent of any flags passed to > the function. > > To find out the truth one would have to write test cases. It might > well be that the implementation we use is partially incorrect. > Especially when looking at testman (it works again :-O ) @ > shell32_winetest shlexec which still has some failures. Hi Greg, Perhaps You already know, but let's spell it out anyway: hInstApp inherits it's traits from WinExec and LoadModule. WinExec used to be declared HINSTANCE WinExec( LPCSTR CmdLine, UINT CmdShow ), and LoadModule also returned a HINSTANCE. At that time they did return the instance handle, i.e the load address, and it was safe to use these low values as error codes, because they were impossible load addresses (they still are). Even though WinExec/LoadModule's signatures have changed, and we've been given CreateProcess to exert better control, somewhere in the bowels of Microsoft's code I'm convinced it still percolates down to basically the same code to load/launch a module, so the traits remain. And since the shell APIs are mostly just alternate wrappings for standard Win32 APIs, it percolates to there as well. I don't think we need to bother with test cases for this, we could apply some common sense instead. A quick test shows that both WinExec and LoadModule actually just return 33 when they succeed, so we could(/should?) let hInstApp always reflect load status the same way that WinExec/LoadModule does, regardless of the flags. That's the most polite to users of ShellExecuteEx. Then they can error branch on either one. In case of doubt, always wear both belt and suspenders ;) if (ShellExecuteExW( &sei ) == FALSE) return E_FAIL; if ((INT) sei.hInstApp <= 32) return E_UNEXPECTED; Best Regards // Love victor martinez <vicmarcal(a)hotmail.com <mailto:vicmarcal@hotmail.com>> wrote: > > - if (sei.hInstApp <= (HINSTANCE)32) > + if ((INT)sei.hInstApp <= 32) > > As you see i am just learning, so thanks in advance. > To enlighten You: If you look at the assembly listing, You'll see that those two variants generate exactly the same code. Best Regards // Love

1 0

Re: [ros-dev] [ros-diffs] [tkreuzer] 46998: Disable gdi batch for SelectObject with fonts. Fixes font regression.
by Gabriel ilardi 23 Apr '10

23 Apr '10

Hi Jim, Please don't take this personal, the code has been #iffed out not reverted. I agree with you that we should keep good code, problem is that lately someone introduces a regression with new or modified code (even correct), and the regression stays there forever, we should try to avoid such a case. In this specific case we know the gdibatch code introduced that regression, so my suggestion is: do the commit anyway with a specific roadmap to fix the regression or disable it temporary until the regression is fixed. Perception is really important, what's gonna think about ros someone that tried it before, now after a new release tries it again and sees that what was working before doesn't work anymore or works worse than it did, your references are a good example of this scenario, but see also: 4461 Regression: Notepad Lite doesn't install 4677 Regression: Can't restore minimized windows 4948 Regression: Can't close locale dialog 5276 Regression: shell about dialog doesn't display header bitmap And there are more... I'm not gonna blame win32k only here as regressions are not its exclusivity, it's funny that before uniata we were suggesting people to rename uniata to atapi to test in boxes with sata controllers, now we do the oposite (atapi -> uniata )to let people test in pata. I've mentioned in ros-dev also that ros takes more than 2 minutes in my virtual machine to install when it tooks some seconds before (two hd attached to the primary channel), I'm not able to test ros so frequently now because of this. I've also mentioned that AC97 stopped working, has regressed for several reasons several revisions away, now I'm not being prompted anymore for its driver as 46998... We can't keep working like this, testers should work in a coordinated way with developers, both of them are important, there aren't many skilled testers to be honest just take a look at bugzilla... Sometimes I test and see regressions and don't know what to do anymore, stop testing, tell ros-dev, bug the dev, give up... Gabriel. > Date: Thu, 22 Apr 2010 20:47:52 -0500 > From: jimtabor.rosdev(a)gmail.com > To: ros-dev(a)reactos.org > Subject: [ros-dev] [ros-diffs] [tkreuzer] 46998: Disable gdi batch for SelectObject with fonts. Fixes font regression. > > Not surprised! > > I guess ReactOS new polices are for hiding the real issues and not > fixing them and revert all the correct code. Since the kernel rewrites > and the new order of coding, these oddities have now surfaced. The > TEB, is inaccessible from kernel mode as in bug 5265 and 5314, and the > strange processes access issues in bug 5310. This revert silliness > will result in moving the project back to post windows 95 architecture > (arwinss). ReactOS is about moving forward and taking chances with > innovations from learned information then moving away to make it work > even better. Personally, I hope someone will take up where this left > off and move on. > > Good luck! > > Reference: > > http://www.reactos.org/bugzilla/show_bug.cgi?id=5265 > http://www.reactos.org/bugzilla/show_bug.cgi?id=5310 > http://www.reactos.org/bugzilla/show_bug.cgi?id=5314 > > _______________________________________________ > Ros-dev mailing list > Ros-dev(a)reactos.org > http://www.reactos.org/mailman/listinfo/ros-dev _________________________________________________________________ Messenger e Hotmail in tasca. Provali sul tuo cellulare! http://new.windowslivemobile.msn.com/it-it/Default.aspx

1 0

Re: [ros-dev] [ros-diffs] [cgutman] 46983: [NTOSKRNL] - Replace the broken CM_RESOURCE_LIST_SIZE with a better function that actually works with resource lists that have device-specific data in them (fixes missing device specific data when resources
by Andrew Faulds 22 Apr '10

22 Apr '10

Isn't that just a audio driver regression not an Install wizard one? "Starting a device node without DNF_ADDED" On 22 April 2010 14:09, Gabriel ilardi <gabrielilardi(a)hotmail.it> wrote: > Hi, > Device installation wizard has regressed again, now if you try to install > the AC97 driver, it remains in a loop, and ros slows down at the point of > being unusabe, > the debug log shows: > > (ntoskrnl/io/pnpmgr/pnpmgr.c:190) Warning: Starting a device node without > DNF_ADDED or DNF_ENUMERATED (Root\LEGACY_kmixer\0000) > > Thanks, > > Gabriel. > > > Date: Wed, 21 Apr 2010 22:33:12 +0000 > > To: ros-diffs(a)reactos.org > > From: cgutman(a)svn.reactos.org > > Subject: [ros-diffs] [cgutman] 46983: [NTOSKRNL] - Replace the broken > CM_RESOURCE_LIST_SIZE with a better function that actually works with > resource lists that have device-specific data in them (fixes missing device > specific data when resources are retrieved with IoGetDeviceProperty) - > Separate the resource code out of pnpmgr.c and into pnpres.c - Simplify > resource assigning to simply calling one function, IopAssignDeviceResources, > which takes care of the registry configuration, translation, etc. - Set the > DNF_NEED_ENUMERATION_ONLY flag only AFTER the device is actually started not > before - Set DNF_START_FAILED if IRP_MN_START_DEVICE fails - Fix a bug in > IoReportDetectedDevice that wrote the AllocConfig value to wrong place > > > > Author: cgutman > > Date: Thu Apr 22 00:33:11 2010 > > New Revision: 46983 > > > > URL: http://svn.reactos.org/svn/reactos?rev=46983&view=rev > > Log: > > [NTOSKRNL] > > - Replace the broken CM_RESOURCE_LIST_SIZE with a better function that > actually works with resource lists that have device-specific data in them > (fixes missing device specific data when resources are retrieved with > IoGetDeviceProperty) > > - Separate the resource code out of pnpmgr.c and into pnpres.c > > - Simplify resource assigning to simply calling one function, > IopAssignDeviceResources, which takes care of the registry configuration, > translation, etc. > > - Set the DNF_NEED_ENUMERATION_ONLY flag only AFTER the device is > actually started not before > > - Set DNF_START_FAILED if IRP_MN_START_DEVICE fails > > - Fix a bug in IoReportDetectedDevice that wrote the AllocConfig value to > wrong place > > > > Added: > > trunk/reactos/ntoskrnl/io/pnpmgr/pnpres.c (with props) > > Modified: > > trunk/reactos/ntoskrnl/include/internal/io.h > > trunk/reactos/ntoskrnl/io/pnpmgr/pnpmgr.c > > trunk/reactos/ntoskrnl/io/pnpmgr/pnpreport.c > > trunk/reactos/ntoskrnl/ntoskrnl-generic.rbuild > > ------------------------------ > Condividi le tue emozioni e proteggi la tua privacy. Chiacchiera su > Messenger <http://www.windowslive.it/importaAmici.aspx> > > _______________________________________________ > Ros-dev mailing list > Ros-dev(a)reactos.org > http://www.reactos.org/mailman/listinfo/ros-dev > -- Andrew Faulds (andrewros) http://ajf.me/

1 0

Improvement: Foxit Reader 2.1
by victor martinez 22 Apr '10

22 Apr '10

After asking in ReactOS-dev what is the antonym of "Regression" (thanks DosX for telling me :) ), I am glad to show you an "IMPROVEMENT". It´s easy to complain about Regressions but we should try to show our little improvements. Congrats to our Devs because their efforts :) == Foxit Reader 2.1 is much more usable. 0.3.11 screenshot vs Trunk screenshot.== Screenshot: http://img696.imageshack.us/img696/8839/foxit2.jpg _________________________________________________________________ Tus datos personales, más seguros con Internet Explorer 8. http://www.microsoft.com/spain/windows/internet-explorer/default.aspx

2 1

Re: [ros-dev] [ros-diffs] [cgutman] 46983: [NTOSKRNL] - Replace the broken CM_RESOURCE_LIST_SIZE with a better function that actually works with resource lists that have device-specific data in them (fixes missing device specific data when resources are retrieved
by Gabriel ilardi 22 Apr '10

22 Apr '10

Hi, Device installation wizard has regressed again, now if you try to install the AC97 driver, it remains in a loop, and ros slows down at the point of being unusabe, the debug log shows: (ntoskrnl/io/pnpmgr/pnpmgr.c:190) Warning: Starting a device node without DNF_ADDED or DNF_ENUMERATED (Root\LEGACY_kmixer\0000) Thanks, Gabriel. > Date: Wed, 21 Apr 2010 22:33:12 +0000 > To: ros-diffs(a)reactos.org > From: cgutman(a)svn.reactos.org > Subject: [ros-diffs] [cgutman] 46983: [NTOSKRNL] - Replace the broken CM_RESOURCE_LIST_SIZE with a better function that actually works with resource lists that have device-specific data in them (fixes missing device specific data when resources are retrieved with IoGetDeviceProperty) - Separate the resource code out of pnpmgr.c and into pnpres.c - Simplify resource assigning to simply calling one function, IopAssignDeviceResources, which takes care of the registry configuration, translation, etc. - Set the DNF_NEED_ENUMERATION_ONLY flag only AFTER the device is actually started not before - Set DNF_START_FAILED if IRP_MN_START_DEVICE fails - Fix a bug in IoReportDetectedDevice that wrote the AllocConfig value to wrong place > > Author: cgutman > Date: Thu Apr 22 00:33:11 2010 > New Revision: 46983 > > URL: http://svn.reactos.org/svn/reactos?rev=46983&view=rev > Log: > [NTOSKRNL] > - Replace the broken CM_RESOURCE_LIST_SIZE with a better function that actually works with resource lists that have device-specific data in them (fixes missing device specific data when resources are retrieved with IoGetDeviceProperty) > - Separate the resource code out of pnpmgr.c and into pnpres.c > - Simplify resource assigning to simply calling one function, IopAssignDeviceResources, which takes care of the registry configuration, translation, etc. > - Set the DNF_NEED_ENUMERATION_ONLY flag only AFTER the device is actually started not before > - Set DNF_START_FAILED if IRP_MN_START_DEVICE fails > - Fix a bug in IoReportDetectedDevice that wrote the AllocConfig value to wrong place > > Added: > trunk/reactos/ntoskrnl/io/pnpmgr/pnpres.c (with props) > Modified: > trunk/reactos/ntoskrnl/include/internal/io.h > trunk/reactos/ntoskrnl/io/pnpmgr/pnpmgr.c > trunk/reactos/ntoskrnl/io/pnpmgr/pnpreport.c > trunk/reactos/ntoskrnl/ntoskrnl-generic.rbuild _________________________________________________________________ Messenger e Hotmail in tasca. Provali sul tuo cellulare! http://new.windowslivemobile.msn.com/it-it/Default.aspx

1 0

test/fix building fastfat_new
by Alexey Komarov 22 Apr '10

22 Apr '10

Hi. Can somebody test/fix building fastfat_new? It seems, that it's problem with headers. Log: [CC] drivers\filesystems\fastfat_new\fastio.c [CC] drivers\filesystems\fastfat_new\fcb.c cc1.exe: warnings being treated as errors drivers\filesystems\fastfat_new\fcb.c: In function 'FatFindFcb': drivers\filesystems\fastfat_new\fcb.c:85: error: implicit declaration of functio n 'RtlLeftChild' drivers\filesystems\fastfat_new\fcb.c:85: error: assignment makes pointer from i nteger without a cast drivers\filesystems\fastfat_new\fcb.c:90: error: implicit declaration of functio n 'RtlRightChild' drivers\filesystems\fastfat_new\fcb.c:90: error: assignment makes pointer from i nteger without a cast drivers\filesystems\fastfat_new\fcb.c:95: error: implicit declaration of functio n 'RtlSplay' drivers\filesystems\fastfat_new\fcb.c:95: error: assignment makes pointer from i nteger without a cast drivers\filesystems\fastfat_new\fcb.c: In function 'FatInsertName': drivers\filesystems\fastfat_new\fcb.c:904: error: implicit declaration of functi on 'RtlInitializeSplayLinks' drivers\filesystems\fastfat_new\fcb.c:946: error: implicit declaration of functi on 'RtlInsertAsLeftChild' drivers\filesystems\fastfat_new\fcb.c:963: error: implicit declaration of functi on 'RtlInsertAsRightChild' drivers\filesystems\fastfat_new\fcb.c: In function 'FatRemoveNames': drivers\filesystems\fastfat_new\fcb.c:993: error: implicit declaration of functi on 'RtlDelete' drivers\filesystems\fastfat_new\fcb.c:993: error: assignment makes pointer from integer without a cast drivers\filesystems\fastfat_new\fcb.c:1002: error: assignment makes pointer from integer without a cast make.exe: *** [obj-i386\drivers\filesystems\fastfat_new\fcb_fastfatn.o] Error 1 WBR, Alexey Komarov.

2 1

0.3.12 Changelog opened.
by victor martinez 21 Apr '10

21 Apr '10

Hi, i am happy of telling you that "0.3.12 Changelog" has been opened to recive all your commits in an ordered way. 0.3.11 was released on 16 December(2009), more than 4 months ago, this means a huge number of commits that we have to order before we can make attempts to create a 0.3.12 release. The link is(as usual): http://www.reactos.org/wiki/ChangeLog-0.3.12 I hope opening the Changelog before trying to release will help to solve the Changelog bottleneck and will give us more time to create it. Let´s move towards 0.3.12... Thanks for your minute :) _________________________________________________________________ Recibe un SMS de tu Hotmail vayas donde vayas. ¡Date de alta! http://home.mobile.live.com/MobileAttach.mvc/?mkt=es-es

3 2

[ros-diff]rev 46907.gschneider[SHELL32] - Simplify checks for success of ShellExecuteEx
by victor martinez 19 Apr '10

19 Apr '10

Hi, i have been giving a look to this patch and i have some doubts(just learning :) ) The code is: @@ -1298,8 +1298,8 @@ static HRESULT WINAPI ICPanel_IContextMenu2_InvokeCommand( sei.hwnd = lpcmi->hwnd; sei.nShow = SW_SHOWNORMAL; sei.lpVerb = L"open"; - ShellExecuteExW(&sei); - if (sei.hInstApp <= (HINSTANCE)32) + + if (ShellExecuteExW(&sei) == FALSE) return E_FAIL; MSDN says that if ShellExecuteExW fails it sets hInstApp to a value lower than 32 and,also, returns FALSE. (MSDN: http://msdn.microsoft.com/en-us/library/bb762154(VS.85).aspx ) So both lines of codes(buggy and patched) are,at first sight,doing the same.Just using a different way. The Commit says: - Simplify checks for success of ShellExecuteEx, field hInst may be an unreliable indicator according to http://msdn.microsoft.com/en-us/library/bb759784%28v=VS.85%29.aspx Why is it unreliable? :) I am not saying it is reliable, just that i dont find the reason there...my skills are limited.. :( I have just found: "Although hInstApp is declared as an HINSTANCE for compatibility with 16-bit Windows applications, it is not a true HINSTANCE. It can be cast only to an int and compared to either 32 or the following SE_ERR_XXX error codes ". So my question is: Is the Bug in the cast to (HINSTANCE) instead to (INT)?I mean,do this solve the bug too?: - if (sei.hInstApp <= (HINSTANCE)32) + if ((INT)sei.hInstApp <= 32) As you see i am just learning, so thanks in advance. And yes, i prefer the new way that patch is using.Using the returned the value seems much more logic than using a "collateral damage". :) Btw, thanks Gregor for your hunting-fixing week ;) _________________________________________________________________ ¡Citas! ¡Ligues! ¿Salimos? ¿Cómo es tu pareja ideal? Búscala en el sitio nº1… ¡Regístrate ya! http://contactos.es.msn.com/?mtcmk=015352

2 2

Commit by sir_richard :: r46904 reactos/ntoskrnl/mm/ARM3/miarm.h
by breakoutbox 19 Apr '10

19 Apr '10

Hello, "[NTOS]: 1MB is not 1000 * 1KB... " http://en.wikipedia.org/wiki/Megabyte 1 KB = 1000 byte (decimal) 1 KiB = 1024 byte (binary) 1 MB = 1000 KB 1 MiB = 1024 KiB Would be nice if ReactOS goes across the border and also uses the modern SI unit definitions ;-) If in code definitions or shown as text to the user .. Cheers, Peter

7 11

[ros-diffs] [fireball] 46914: - Get rid of the last hardcoded screen size. - Remove unnecessary function declaration. See issue #5304 for more details.
by James Tabor 18 Apr '10

18 Apr '10

For one that bitches about trunk being broken all the time and punish everyone trying to get it fixed! Why not push this much effort to help fix the same issue in trunk.... Or is it done so truck stays broken?

2 1

Re: [ros-dev] [ros-diffs] [mpiulachs] 46862: My first commit in a very long time. I'm releasing the source code of my C# implementation of Rbuild by popular demand :) I would have preferred to release the code under a BSD licence but there is a small
by Sir Gallantmon (ニール・ゴンパ) 18 Apr '10

18 Apr '10

Does this work under Mono? AFAIK, Mono supports C# 3.5 and C# 4.0 language features.... so...? On Sat, Apr 17, 2010 at 7:56 AM, Aleksey Bragin <aleksey(a)reactos.org> wrote: > Official URL for that component is http://dev.skybound.ca/download.aspx > Just for reference, it indeed crashes when running the HTML report backend, > I'm investigating this in the free time. > > WBR, > Aleksey. > > > On Apr 14, 2010, at 6:41 PM, Ged Murphy wrote: > > It partially works. >> Can't build the designer due to a Skybound.VisualStyles dependency. I >> assume we get that from here? >> http://windowsclient.net/downloads/folders/controlgallery/entry1590.aspx >> >> It then crashes when running the html report >> >> Just in case you were interested.... >> >> Ged. >> >> -----Original Message----- >> From: ros-diffs-bounces(a)reactos.org [mailto:ros-diffs-bounces@reactos.org] >> On Behalf Of mpiulachs(a)svn.reactos.org >> Sent: 13 April 2010 23:00 >> To: ros-diffs(a)reactos.org >> Subject: [ros-diffs] [mpiulachs] 46862: My first commit in a very long >> time. I'm releasing the source code of my C# implementation of Rbuild by >> popular demand :) I would have preferred to release the code under a BSD >> licence but there is a small portion of ancient >> >> Author: mpiulachs >> Date: Tue Apr 13 23:59:21 2010 >> New Revision: 46862 >> >> URL: http://svn.reactos.org/svn/reactos?rev=46862&view=rev >> Log: >> My first commit in a very long time. I'm releasing the source code of my >> C# implementation of Rbuild by popular demand :) I would have preferred to >> release the code under a BSD licence but there is a small portion of ancient >> Nant GPL code that would have been to be rewritten first. >> >> There are two executables (SysGen.Designer) and (SysGen.Make) >> >> SysGen.Designer is a windows forms tool that allows to generate customized >> reactos images, it is similar in concept to Windows CE Platfom Builder. >> SysGen.Make is the actual Rbuild clone, It has three main parts, the .rbuild >> file parser + in-memory tree representation, the backends , and the auto >> generated files. The Mingw backend used to work 1'5 years ago and produced a >> 100% valid makefile.auto but have to be updated to be able to build a recent >> revision. Rewriting parts of it to take advantage of C# 3.5 extension >> methods would probably reduce the code by 50%. The other two parts are quite >> stable. >> >> This code was only a proof of concept and was never intended to be >> released so there is a ton of unpolished code and hacks required by the >> current C++ implementation that should be removed. >> >> How to test it: >> >> Select SysGen.Make as the Start-up Project in Visual Studio and edit >> Program.cs to point to the correct path to ReactOS-i386.rbuild Edit >> SysGenEngine.cs:639 to enable/disable specific backends, The HtmlBackend in >> \SysGen.BuildEngine\Backends\Html\HtmlBackend.cs is a very simple >> illustration of how powerful this framework is. >> >> Happy hacking! >> >> >> >> >> _______________________________________________ >> Ros-dev mailing list >> Ros-dev(a)reactos.org >> http://www.reactos.org/mailman/listinfo/ros-dev >> > > > _______________________________________________ > Ros-dev mailing list > Ros-dev(a)reactos.org > http://www.reactos.org/mailman/listinfo/ros-dev >

3 3

"make cb" broken
by Alexey Komarov 18 Apr '10

18 Apr '10

C:\ros\trunk\reactos>make cb [RBUILD] cb Reading build files...done Creating Code::Blocks workspace: ReactOS_auto.workspace make.exe: *** [cb] Error -1073741819 Total Build Time: 00:01:58 Can somebody fix it? (RosBE - 1.5, host - WinXP) WBR, Alexey Komarov.

3 2

Re: [ros-dev] [ros-diffs] [mpiulachs] 46862: My first commit in a very long time. I'm releasing the source code of my C# implementation of Rbuild by popular demand :) I would have preferred to release the code under a BSD licence but there is a small portion of anc
by Ged Murphy 17 Apr '10

17 Apr '10

It partially works. Can't build the designer due to a Skybound.VisualStyles dependency. I assume we get that from here? http://windowsclient.net/downloads/folders/controlgallery/entry1590.aspx It then crashes when running the html report Just in case you were interested.... Ged. -----Original Message----- From: ros-diffs-bounces(a)reactos.org [mailto:ros-diffs-bounces@reactos.org] On Behalf Of mpiulachs(a)svn.reactos.org Sent: 13 April 2010 23:00 To: ros-diffs(a)reactos.org Subject: [ros-diffs] [mpiulachs] 46862: My first commit in a very long time. I'm releasing the source code of my C# implementation of Rbuild by popular demand :) I would have preferred to release the code under a BSD licence but there is a small portion of ancient Author: mpiulachs Date: Tue Apr 13 23:59:21 2010 New Revision: 46862 URL: http://svn.reactos.org/svn/reactos?rev=46862&view=rev Log: My first commit in a very long time. I'm releasing the source code of my C# implementation of Rbuild by popular demand :) I would have preferred to release the code under a BSD licence but there is a small portion of ancient Nant GPL code that would have been to be rewritten first. There are two executables (SysGen.Designer) and (SysGen.Make) SysGen.Designer is a windows forms tool that allows to generate customized reactos images, it is similar in concept to Windows CE Platfom Builder. SysGen.Make is the actual Rbuild clone, It has three main parts, the .rbuild file parser + in-memory tree representation, the backends , and the auto generated files. The Mingw backend used to work 1'5 years ago and produced a 100% valid makefile.auto but have to be updated to be able to build a recent revision. Rewriting parts of it to take advantage of C# 3.5 extension methods would probably reduce the code by 50%. The other two parts are quite stable. This code was only a proof of concept and was never intended to be released so there is a ton of unpolished code and hacks required by the current C++ implementation that should be removed. How to test it: Select SysGen.Make as the Start-up Project in Visual Studio and edit Program.cs to point to the correct path to ReactOS-i386.rbuild Edit SysGenEngine.cs:639 to enable/disable specific backends, The HtmlBackend in \SysGen.BuildEngine\Backends\Html\HtmlBackend.cs is a very simple illustration of how powerful this framework is. Happy hacking!

2 1

Re: [ros-dev] [ros-diffs] [cgutman] 46876: [PCMCIA] - Add a mostly stubbed PCMCIA driver - pcmcia.c is complete but fdo.c and pdo.c are completely unimplemented
by Ged Murphy 16 Apr '10

16 Apr '10

I don't mean to sound like a broken record, and I also understand that the project allows people to work on whatever they want to. But with the project in such a state at the moment, is a pcmcia bus driver really the best thing to be working on? I'm all for project freedom, but you would hope people to have the diligence to work on areas which might help to stop the project from failing. Maybe I just don't get it anymore and I'm behind the times, but what happened to the days when people used to work on important things? Your nagging ex-dev, Ged. -----Original Message----- From: ros-diffs-bounces(a)reactos.org [mailto:ros-diffs-bounces@reactos.org] On Behalf Of cgutman(a)svn.reactos.org Sent: 15 April 2010 02:59 To: ros-diffs(a)reactos.org Subject: [ros-diffs] [cgutman] 46876: [PCMCIA] - Add a mostly stubbed PCMCIA driver - pcmcia.c is complete but fdo.c and pdo.c are completely unimplemented Author: cgutman Date: Thu Apr 15 03:59:15 2010 New Revision: 46876 URL: http://svn.reactos.org/svn/reactos?rev=46876&view=rev Log: [PCMCIA] - Add a mostly stubbed PCMCIA driver - pcmcia.c is complete but fdo.c and pdo.c are completely unimplemented Added: trunk/reactos/drivers/bus/pcmcia/ trunk/reactos/drivers/bus/pcmcia/fdo.c (with props) trunk/reactos/drivers/bus/pcmcia/pcmcia.c (with props) trunk/reactos/drivers/bus/pcmcia/pcmcia.h (with props) trunk/reactos/drivers/bus/pcmcia/pcmcia.rbuild (with props) trunk/reactos/drivers/bus/pcmcia/pcmcia.rc (with props) trunk/reactos/drivers/bus/pcmcia/pdo.c (with props) Modified: trunk/reactos/drivers/bus/directory.rbuild

11 26

Re: [ros-dev] [ros-diffs] [aicom] 46798: [NTOSKRNL] - Create registry values for legacy drivers
by Gabriel ilardi 16 Apr '10

16 Apr '10

Hi, This revision introduces some regressions: - device manager list is empty - network connections is empty too, - it also breaks vbox guest additions installation on vbox version 3.0.12. See bug 5294 for more details: http://www.reactos.org/bugzilla/show_bug.cgi?id=5294 Thanks. Gabriel. [NTOSKRNL] - Create registry values for legacy drivers - Handle raw devices properly - Don't set DNF_STARTED before actually calling IopStartDevice - Don't set DNF_STARTED for legacy drivers inside IopCreateDeviceNode - Fixes missing entries in Device Manager for raw devices _________________________________________________________________ Naviga al sicuro. Scarica gratis Internet Explorer 8 per MSN http://www.microsoft.com/italy/windows/internet-explorer/msn.aspx

1 0

Regressions and bugs
by Gabriel ilardi 15 Apr '10

15 Apr '10

Hi team, I don't know why, but it seems that bugzilla and ros-bugs is being ignored, except for some exceptions where I've seen regressions fixed lately. IMHO it's extremely important the perception people have about us when they test ros, if ros improved overall but that's not noticeable to the end user the final perception will be bad, now if we want a cooler release than 0.3.11 and older revisions, people should feel the improvement. I'm gonna make a short sum up of what I think it should be fixed or tried to at least to accomplish that (this list contains not only regressions but bugs that would improve the ros perception for the average user): I hope we can all work as a team to try and fix these issues, I can only offer my help testing as that's the thing I know best atm. GUI perception: 642 hotkeys not supported: Wouldn't it be cool to hit Win+R to run, Start menu appearing when hitting win, etc.? copy paste files with the keyboard... I'd also add here, we need to be able to switch applications with alt-tab, I remember johannes did something related to this long ago. 969 Minimized windows are shown on the desktop, no need to mention that this reminds me of win 3.11, good old times, but that was long ago... 1603 can't exit rename state 2320 clock doesn't show properly (partially shown), this exists since I remember too. 2322 Hide inactive icons doesn't work, please remove this... option :) 2328 Shell doesn't restart upon its failure 2428 non stop scrolling hangs entire gui, aka "if you do dir /s in real hardware go have a good breakfast" 2788 unwanted multiple selection while doing a right click on the desktop, ugly when you have multiple icons on your desktop and launch them because of this 3101 our remote dekstop can't be used, you can't change settings 3171 focus doesn't change back to parent window 3212 different keyboard responses, also keyboard doesn't work correctly with dinput see bug 4405 4379 hovering the mouse over the start menu spoils the text 4847 File copying dialog is missing 4915 Control panel: Keyboard doesn't work after opening and closing an applet 4960 ReactOS restarts at the beginning of 2nd stage if you hit ESC Explorer has all kind of visual glitches you can imagine and even more. keyboard layout issues: it's language dependent when it shouldn't be, changing keyboard layout doesn't work, kb layout tools dont' work, wrong keyboard layout in cmd see 3317, 2132, 2133, 2178, 2952, see also profiles problems below Visual/Graphic bugs: There are tons of these, I'll name a few, luckily we have Arwinss. 3624 worksoft navigator can't be minimized. 3680 Blinking text while installing vc2008 redist package 4051 Command Prompt icon showed through a window General: Users need to save a file to the desktop and see it has been created, see bug 1249 and also 2821. Winamp main window is unclicable, this has existed since I rememer, bug 1239. taskmgr shows still processes that have been killed, see bug 1567. 2393 you need to move the mouse to make firefox work (thanks arwinss for this too). Profiles: They are messed, %TEMP% has some issues see bugs 2482, 2972, also 4008 and 4102, all users desktop icons don't appear in user's desktop 4289, also bug 4444. 2622 console doesn't support scrolling at all. 2978 we can't search it regedit, it doesn't work and hangs the app. 3225 3dtext screensaver shows garbled text 3429 can't select any color in comdlg32 color dialog, since I remember too... 3559 Double-click on application icon does not close application. 3781 Tab Key does not work for "SysIPAddress32" controls 3883 screensaver doesn't start automatically 3966 can't hit enter on a selected item to open it 4049 changing screen resolutions requires restart, thanks Timo aka yaratows master! :) 4066 Notepad, uses two different fonts / highlighted text invisible 4106 Wrong text spacing in popup menus / icons after show a font in control applet / Remote Desktop 4185 [PATCH] Netstat produces b*llshit, should we apply the patch ? 4377 Notepad: Find command doesn't work right. 4380 Real Hardware: mouse wheel doesn't work 4383 Can't delete many items from Desktop at once using the mouse 4501 When closing one window, Firefox gets restored if it was minimized 4560 explorer mouse rectangle doesn't work anymore (I'm not sure it ever worked, it does work in arwinss) 4676 Unable to restore down a maximised window 4779 K-Meleon popup menus dont work 4835 Regression: Memory usage continuously decreases in task manager even though memory usage doesn't change (HACKFIXED) 5005 Foxit reader, program starts automatically instead of the installation wizard 5030 Changing color depth resets the wallpaper to none 5059 mIRC 6.35 server list with unusable scrollbar 5066 PATCH : Incorrect sending of mouse messages, can someone take a look ? 5099 [metabug]ReactOS new loader doesnt work with more than 3584 MB of RAM, let's not forget this one 5100 and 5101 too Regressions: 3716 Livecd networking does not work in qemu 3727 Regression: roscalc problems with keyboard input etc. 4461 Regression: Notepad Lite 4568 Regression: Startup Folder stopped working (see profiles and environment vars too) 4677 Regression: Can't restore minimized windows 4811 Recent AbiWord toolbar regression: comctl32 sync r42706 4926 Regression: Tworld and DosBox don't work 4948 [Regression] Can't close locale settings dialog on 2nd stage of setup 4951 [Regression] 'whois' hangs 5035 Regression: Abiword - Fonts listbox isn't shown properly 5276 Regression: shell about dialog doesn't display header bitmap 5294 Regression: Device manager list is empty x-chat used to work, it looked bad, now it doesn't even start, there's no specific regression bug filed for this, see bug 1176 Features needed: USB keyboard and mouse are a must nowadays, ps/2 won't last much longer..., bug 1041, also ps/2 doesn't work if you unplug it and replug it later bug 1395. Installation/USetup needs to be able to handle bootmgrs, and other partitions when they are present, at least give you the possibility to wipe everything up. also 2564 ros doesn't mount logical units on extended partitions, see also 2733, 4368, 4614, 5270 VGA/VBE bug 2073 ros does not work on vga display. See also 2286, 4354, 4447, 4192 Several uniata issues in real hw 4591, 4995 We need drag & drop a wokring clipboard Last but not least there's a regression not filed yet to my knowledge: (subsystems/win32/win32k/ntuser/vis.c:75) ATM the Current Window or Parent is dead! (subsystems/win32/win32k/ntuser/vis.c:75) ATM the Current Window or Parent is dead! (subsystems/win32/win32k/ntuser/windc.c:738) Not POWNED or CLASSDC hwndCurrent -> 20168 Assertion 'FALSE' failed at subsystems/win32/win32k/ntuser/windc.c line 739 PuTTYEntered debugger on embedded INT3 at 0x0008:0x808e5e5e. kdb:> bt Eip: <ntoskrnl.exe:e5e5f (lib/rtl/i386/debug_asm.S:33 (DbgBreakPoint@0))> Frames: <win32k.sys:7b79e (subsystems/win32/win32k/ntuser/windc.c:739 (@DceFreeWindowDCE@4))> <win32k.sys:7f69c (subsystems/win32/win32k/ntuser/window.c:488 (co_UserFreeWindow))> <win32k.sys:7fab7 (subsystems/win32/win32k/ntuser/window.c:2747 (@co_UserDestroyWindow@4))> <win32k.sys:7faed (subsystems/win32/win32k/ntuser/window.c:2771 (NtUserDestroyWindow@4))> <ntoskrnl.exe:6fb7 (ntoskrnl/ke/i386/traphdlr.c:1564 (@KiSystemServiceHandler@8))> <ntoskrnl.exe:e041d (ntoskrnl/ke/i386/trap.s:127 (KiInterruptTemplateDispatch))> <ntdll.dll:7ac5> <user32.dll:47ed1> <user32.dll:48063> <ntdll.dll:7a1d> <explorer.exe:16ded> <explorer.exe:436c6> <user32.dll:47ed1> <user32.dll:4851d> <user32.dll:48768> <user32.dll:2cf50> <user32.dll:2dd16> <user32.dll:2eaad> <user32.dll:2eb70> <user32.dll:3b92d> <explorer.exe:16e2a>--- Press q to abort, any other key to continue --- <explorer.exe:436c6> <user32.dll:47ed1> <user32.dll:4851d> <user32.dll:48768> <user32.dll:4bfa2> <user32.dll:4c06b> <user32.dll:2d5ed> <user32.dll:2eaad> <user32.dll:2eb70> <user32.dll:3b92d> <explorer.exe:16e2a> <explorer.exe:436c6> <user32.dll:47ed1> <user32.dll:4851d> <user32.dll:48a5b> <explorer.exe:4296c> <explorer.exe:4dd23> <explorer.exe:51c4b> <explorer.exe:60ad9> <explorer.exe:60906> <explorer.exe:60968> <kernel32.dll:2ef7b> --- Press q to abort, any other key to continue --- <00000000> kdb:> I'll be back, promise ;). _________________________________________________________________ Più di 20 giochi su Messenger. Scoprili tutti! http://www.messenger.it/raccoltaGiochi.aspx

6 5

[ros-diffs] [mpiulachs] 46862: My first commit in a very long time. I'm releasing the source code of my C# implementation of Rbuild by popular demand :) I would have preferred to release the code under a BSD licence but there is a small portion of an
by Gabriel ilardi 14 Apr '10

14 Apr '10

Hi Marc, Cool, thanks! It's nice to see you back, hope to see more commits too ;) Gabriel. _________________________________________________________________ Più di 20 giochi su Messenger. Scoprili tutti! http://www.messenger.it/raccoltaGiochi.aspx

1 0

Re: [ros-dev] Roadmap I'm sticking to
by victor martinez 10 Apr '10

10 Apr '10

Hi, Well..I have been here just for a year and a half, and it is pretty obvious that we are not following any "direction" to achieve something in common.We are making progress in our own,sometimes without telling to the others and sometimes introducing regressions 1week before a release thanks to a critical rewrite. Or We are disappearing without telling to anyone. We==Testers&&Developers&&Translators&&Designers&&TheCommunity. I will use this email to state,mainly, that i want to be part of a team with an objective, so i offer all my testing help (including those parts i hate to test) to achieve a common goal.I offer my Testing time as Real Testing time and not as a Hobbie. Maybe we should try to discuss how to reach that goal,and decide(all of us) which is the best way to have something working. I dont know if the correct approach is called Arwinss,Yarotows,WTF!(Want To Finish!) or whatever.The real approach is the final User. And the final User "demands" a workable OS asap.We are making this as a hobbie, but also trying to give a product to the mass(I hope). We are not acting as a Community,neither me. The time to find a way has arrived imo.It´s quite discouraging finding this mess. Discouraging for testers and Discouraging for Devs. In the latest half year we have lost some Testers because lack of motivation.And it is called "Road to Nowhere". Devs arrives to ReactOS Project and they seem to leave quite easy,why?. I hope this time we can all sit and try to find a real solution,deciding which is the Goal (a Hobbie,an OS?),which is the way(comfortable?difficult?no way?hiring internal devs?hiring external devs?knocking sponsors doors?),and which things are needed to complete it(money?motivation?a Bugzilla Testing Week?a RSOC(ReactOS Summer Of Code)?). Summing up, finding a WHOLE solution to this project called ReactOS. I think it is not just matter of a Roadmap. No having a Roadmap(or Milestones) is just the result, not the root of the problems. Thanks for the 3 minutes. _________________________________________________________________ Recibe un SMS de tu Hotmail vayas donde vayas. ¡Date de alta! http://home.mobile.live.com/MobileAttach.mvc/?mkt=es-es

11 15

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev