- Ros-dev - ReactOS.org

Re: [ros-dev] [ros-diffs] [jimtabor] 46006: - [User32_winetest] - Win : Remove test_capture from service. This is related to TrackMouseEvent issues which use SetCapture.
by Aleksey Bragin 09 Mar '10

09 Mar '10

I was blamed for doing this the other day. So do we skip tests or don't? If yes, they must be marked as skipped, not silently ignored. WBR, Aleksey Bragin. On Mar 8, 2010, at 11:52 PM, jimtabor(a)svn.reactos.org wrote: > Author: jimtabor > Date: Mon Mar 8 21:52:04 2010 > New Revision: 46006 > > URL: http://svn.reactos.org/svn/reactos?rev=46006&view=rev > Log: > - [User32_winetest] > - Win : Remove test_capture from service. This is related to > TrackMouseEvent issues which use SetCapture. > > Modified: > trunk/rostests/winetests/user32/win.c > > Modified: trunk/rostests/winetests/user32/win.c > URL: http://svn.reactos.org/svn/reactos/trunk/rostests/winetests/ > user32/win.c?rev=46006&r1=46005&r2=46006&view=diff > ====================================================================== > ======== > --- trunk/rostests/winetests/user32/win.c [iso-8859-1] (original) > +++ trunk/rostests/winetests/user32/win.c [iso-8859-1] Mon Mar 8 > 21:52:04 2010 > @@ -5979,7 +5979,7 @@ > test_capture_1(); > test_capture_2(); > test_capture_3(hwndMain, hwndMain2); > - test_capture_4(); > +// test_capture_4(); > > test_CreateWindow(); > test_parent_owner(); > >

1 0

ros-diffs] [sir_richard] 46027: [WIN32K]: Stub-plement NtUserSetInformationThread for UserInitiateShutdown and UserEndShutdown. I think we're supposed to notify Winlogon at some point, and check for races. Part of new shutdown code.
by James Tabor 09 Mar '10

09 Mar '10

Hi, Look for ntuser/defwnd.c and read the beginning of the file that deals with shutdown messages, it passes all the wine tests. If you need something, just ask, I will implement it. Thanks, James

1 0

Re: [ros-dev] [ros-diffs] [cgutman] 46011: [CMBATT] - Add initial cmbatt driver which mostly stubs - All it does right now is register a battery device with the battc driver [BATTC] - Add a nearly complete battc driver (the only stuff missing is WMI) - Tested with
by Ged Murphy 09 Mar '10

09 Mar '10

cgutman(a)svn.reactos.org wrote: > +BCLASSAPI > +NTSTATUS > +DDKAPI > +BatteryClassSystemControl(PVOID ClassData, > + PWMILIB_CONTEXT WmiLibContext, > + PDEVICE_OBJECT DeviceObject, > + PIRP Irp, > + PSYSCTL_IRP_DISPOSITION Disposition) > +{ > + NTSTATUS Status; > + > + UNIMPLEMENTED > + > + /* FIXME: Uncomment when WmiCompleteRequest is implemented */ > +#if 0 > + Status = STATUS_WMI_GUID_NOT_FOUND; > + WmiCompleteRequest(DeviceObject, > + Irp, > + Status, > + 0, > + IO_NO_INCREMENT); > +#else > + Irp->IoStatus.Status = Status = STATUS_WMI_GUID_NOT_FOUND; > + Irp->IoStatus.Information = 0; > + > + IoCompleteRequest(Irp, IO_NO_INCREMENT); > +#endif > + > + return Status; > +} > + This isn't how WMI works at all

1 0

Trunk lockage
by Aleksey Bragin 09 Mar '10

09 Mar '10

Hi, trunk is locked until (at least) debug buildslave is back online. Also, it's a good occasion to actually FIX all those hanging tests (fix, hackfix, anyotherwaytofix) which lead to buildslaves timewaste (compare: 4 minutes to build and 1 hour to test). This is unbearable. Test results should be available within minutes, and allow easy tracking of failures. WBR, Aleksey Bragin.

9 9

Buildbot currently broken
by Sylvain Petreolle 07 Mar '10

07 Mar '10

Hello, The buildbot slaves are currently offline due to a boot problem and won't be brought back up until monday. Please don't commit to trunk and branches until that. Kind regards, Sylvain Petreolle

1 0

Re: [ros-dev] [ros-diffs] [evb] 45873: - Add new unified VGA/VBE miniport driver. Based on NT4 DDK Cirrus Miniport Driver Sample with my modifications (marked with // eVb) to change Cirrus parts to VGA parts if needed. Also add VBE suppor which is not in Cirru
by Steven Edwards 05 Mar '10

05 Mar '10

Does the EULA allow you to redistribute sample code without stipulations? I seem to recall certain versions of the DDK requiring that derivative works be used only with a Windows OS. Can you please send me a copy of the EULA for the DDK? Thanks Steven On Fri, Mar 5, 2010 at 12:22 PM, <evb(a)svn.reactos.org> wrote: > Author: evb > Date: Fri Mar 5 18:22:18 2010 > New Revision: 45873 > > URL: http://svn.reactos.org/svn/reactos?rev=45873&view=rev > Log: > - Add new unified VGA/VBE miniport driver. Based on NT4 DDK Cirrus Miniport Driver Sample with my modifications (marked with // eVb) to change Cirrus parts to VGA parts if needed. Also add VBE suppor which is not in Cirrus driver, but exists in Windows VGA miniport. -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

4 7

Re: [ros-dev] [ros-diffs] [hpoussin] 45809: [hal] Add a mini-HAL static library Mostly the same thing as the real one, except interrupts and DMA
by Timo Kreuzer 04 Mar '10

04 Mar '10

While the idea of sharing code between hal and freeldr is good, I think the current approach is not the best. so far it caused recompilation for a lot of hal code and added a lot of support code and only very few shared code. I would suggest to implement an x86 Hw / Bios library, containing the shared code and using it from hal and freeldr. This is IMO cleaner then implementing ExAllocatePool etc in freeldr. And can't we use RTL's heap instead of bget in freeldr? Just my 2 cents, Timo hpoussin(a)svn.reactos.org schrieb: > Author: hpoussin > Date: Wed Mar 3 22:56:52 2010 > New Revision: 45809 > > URL: http://svn.reactos.org/svn/reactos?rev=45809&view=rev > Log: > [hal] Add a mini-HAL static library > Mostly the same thing as the real one, except interrupts and DMA > > Modified: > trunk/reactos/hal/halx86/generic/bios.c > trunk/reactos/hal/halx86/generic/bus/halbus.c > trunk/reactos/hal/halx86/generic/bus/pcibus.c > trunk/reactos/hal/halx86/generic/bus/pcidata.c > trunk/reactos/hal/halx86/generic/display.c > trunk/reactos/hal/halx86/generic/dma.c > trunk/reactos/hal/halx86/generic/halinit.c > trunk/reactos/hal/halx86/generic/misc.c > trunk/reactos/hal/halx86/generic/pic.c > trunk/reactos/hal/halx86/generic/reboot.c > trunk/reactos/hal/halx86/generic/systimer.S > trunk/reactos/hal/halx86/generic/timer.c > trunk/reactos/hal/halx86/generic/usage.c > trunk/reactos/hal/halx86/hal_generic.rbuild > trunk/reactos/hal/halx86/include/hal.h > > Modified: trunk/reactos/hal/halx86/generic/bios.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/hal/halx86/generic/bios.c?… > ============================================================================== > --- trunk/reactos/hal/halx86/generic/bios.c [iso-8859-1] (original) > +++ trunk/reactos/hal/halx86/generic/bios.c [iso-8859-1] Wed Mar 3 22:56:52 2010 > @@ -196,6 +196,7 @@ > > /* V86 TRAP HANDLERS **********************************************************/ > > +#ifndef _MINIHAL_ > VOID > FASTCALL > DECLSPEC_NORETURN > @@ -234,6 +235,7 @@ > longjmp(HalpSavedContext, 1); > UNREACHABLE; > } > +#endif > > /* V8086 ENTER ****************************************************************/ > > @@ -497,6 +499,7 @@ > HalpFlushTLB(); > } > > +#ifndef _MINIHAL_ > VOID > NTAPI > HalpSwitchToRealModeTrapHandlers(VOID) > @@ -517,6 +520,7 @@ > // > KeRegisterInterruptHandler(6, HalpTrap06); > } > +#endif > > VOID > NTAPI > @@ -626,6 +630,7 @@ > HalpFlushTLB(); > } > > +#ifndef _MINIHAL_ > BOOLEAN > NTAPI > HalpBiosDisplayReset(VOID) > @@ -695,5 +700,6 @@ > __writeeflags(Flags); > return TRUE; > } > +#endif > > /* EOF */ > > Modified: trunk/reactos/hal/halx86/generic/bus/halbus.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/hal/halx86/generic/bus/hal… > ============================================================================== > --- trunk/reactos/hal/halx86/generic/bus/halbus.c [iso-8859-1] (original) > +++ trunk/reactos/hal/halx86/generic/bus/halbus.c [iso-8859-1] Wed Mar 3 22:56:52 2010 > @@ -27,8 +27,10 @@ > KdReleasePciDeviceforDebugging = HalpReleasePciDeviceForDebugging; > > /* Register memory functions */ > +#ifndef _MINIHAL_ > KdMapPhysicalMemory64 = HalpMapPhysicalMemory64; > KdUnmapVirtualAddress = HalpUnmapVirtualAddress; > +#endif > > /* Register ACPI stub */ > KdCheckPowerButton = HalpCheckPowerButton; > > Modified: trunk/reactos/hal/halx86/generic/bus/pcibus.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/hal/halx86/generic/bus/pci… > ============================================================================== > --- trunk/reactos/hal/halx86/generic/bus/pcibus.c [iso-8859-1] (original) > +++ trunk/reactos/hal/halx86/generic/bus/pcibus.c [iso-8859-1] Wed Mar 3 22:56:52 2010 > @@ -702,6 +702,7 @@ > NTAPI > HalpQueryPciRegistryInfo(VOID) > { > +#ifndef _MINIHAL_ > WCHAR NameBuffer[8]; > OBJECT_ATTRIBUTES ObjectAttributes; > UNICODE_STRING KeyName, ConfigName, IdentName; > @@ -924,6 +925,9 @@ > > /* Return it */ > return PciRegistryInfo; > +#else > + return NULL; > +#endif > } > > VOID > > Modified: trunk/reactos/hal/halx86/generic/bus/pcidata.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/hal/halx86/generic/bus/pci… > ============================================================================== > --- trunk/reactos/hal/halx86/generic/bus/pcidata.c [iso-8859-1] (original) > +++ trunk/reactos/hal/halx86/generic/bus/pcidata.c [iso-8859-1] Wed Mar 3 22:56:52 2010 > @@ -14,6 +14,7 @@ > > /* GLOBALS *******************************************************************/ > > +#ifndef _MINIHAL_ > CHAR ClassTable[3922] = > { > 0x43, 0x20, 0x30, 0x30, 0x20, 0x20, 0x55, 0x6E, 0x63, 0x6C, 0x61, 0x73, 0x73, 0x69, 0x66, 0x69, > @@ -40415,3 +40416,4 @@ > 0x20, 0x49, 0x6C, 0x6C, 0x65, 0x67, 0x61, 0x6C, 0x20, 0x56, 0x65, 0x6E, 0x64, 0x6F, 0x72, 0x20, > 0x49, 0x44, 0x00, > }; > +#endif > > Modified: trunk/reactos/hal/halx86/generic/display.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/hal/halx86/generic/display… > ============================================================================== > --- trunk/reactos/hal/halx86/generic/display.c [iso-8859-1] (original) > +++ trunk/reactos/hal/halx86/generic/display.c [iso-8859-1] Wed Mar 3 22:56:52 2010 > @@ -31,8 +31,10 @@ > NTAPI > HalDisplayString(IN PCH String) > { > +#ifndef _MINIHAL_ > /* Call the Inbv driver */ > InbvDisplayString(String); > +#endif > } > > /* > > Modified: trunk/reactos/hal/halx86/generic/dma.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/hal/halx86/generic/dma.c?r… > ============================================================================== > --- trunk/reactos/hal/halx86/generic/dma.c [iso-8859-1] (original) > +++ trunk/reactos/hal/halx86/generic/dma.c [iso-8859-1] Wed Mar 3 22:56:52 2010 > @@ -75,11 +75,15 @@ > #define NDEBUG > #include <debug.h> > > +#ifndef _MINIHAL_ > static KEVENT HalpDmaLock; > static LIST_ENTRY HalpDmaAdapterList; > static PADAPTER_OBJECT HalpEisaAdapter[8]; > +#endif > static BOOLEAN HalpEisaDma; > +#ifndef _MINIHAL_ > static PADAPTER_OBJECT HalpMasterAdapter; > +#endif > > static const ULONG_PTR HalpEisaPortPage[8] = { > FIELD_OFFSET(DMA_PAGE, Channel0), > @@ -92,6 +96,7 @@ > FIELD_OFFSET(DMA_PAGE, Channel7) > }; > > +#ifndef _MINIHAL_ > static DMA_OPERATIONS HalpDmaOperations = { > sizeof(DMA_OPERATIONS), > (PPUT_DMA_ADAPTER)HalPutDmaAdapter, > @@ -111,6 +116,7 @@ > NULL /*(PBUILD_SCATTER_GATHER_LIST)HalBuildScatterGatherList*/, > NULL /*(PBUILD_MDL_FROM_SCATTER_GATHER_LIST)HalBuildMdlFromScatterGatherList*/ > }; > +#endif > > #define MAX_MAP_REGISTERS 64 > > @@ -118,6 +124,7 @@ > > /* FUNCTIONS *****************************************************************/ > > +#ifndef _MINIHAL_ > VOID > HalpInitDma(VOID) > { > @@ -154,6 +161,7 @@ > */ > HalGetDmaAdapter = HalpGetDmaAdapter; > } > +#endif > > /** > * @name HalpGetAdapterMaximumPhysicalAddress > @@ -185,6 +193,7 @@ > return HighestAddress; > } > > +#ifndef _MINIHAL_ > /** > * @name HalpGrowMapBuffers > * > @@ -428,6 +437,7 @@ > > return AdapterObject; > } > +#endif > > /** > * @name HalpDmaInitializeEisaAdapter > @@ -564,6 +574,7 @@ > return TRUE; > } > > +#ifndef _MINIHAL_ > /** > * @name HalGetAdapter > * > @@ -896,6 +907,7 @@ > Length, > CacheEnabled ? MmCached : MmNonCached); > } > +#endif > > /** > * @name HalpDmaGetDmaAlignment > @@ -984,6 +996,7 @@ > return Count; > } > > +#ifndef _MINIHAL_ > /** > * @name HalpGrowMapBufferWorker > * > @@ -1893,6 +1906,7 @@ > */ > return PhysicalAddress; > } > +#endif > > /** > * @name HalFlushCommonBuffer > > Modified: trunk/reactos/hal/halx86/generic/halinit.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/hal/halx86/generic/halinit… > ============================================================================== > --- trunk/reactos/hal/halx86/generic/halinit.c [iso-8859-1] (original) > +++ trunk/reactos/hal/halx86/generic/halinit.c [iso-8859-1] Wed Mar 3 22:56:52 2010 > @@ -91,8 +91,10 @@ > KeBugCheckEx(MISMATCHED_HAL, 1, Prcb->MajorVersion, 1, 0); > } > > +#ifndef _MINIHAL_ > /* Initialize the PICs */ > HalpInitializePICs(TRUE); > +#endif > > /* Force initial PIC state */ > KfRaiseIrql(KeGetCurrentIrql()); > @@ -107,9 +109,17 @@ > HalQuerySystemInformation = HaliQuerySystemInformation; > HalSetSystemInformation = HaliSetSystemInformation; > HalInitPnpDriver = NULL; // FIXME: TODO > +#ifndef _MINIHAL_ > HalGetDmaAdapter = HalpGetDmaAdapter; > +#else > + HalGetDmaAdapter = NULL; > +#endif > HalGetInterruptTranslator = NULL; // FIXME: TODO > +#ifndef _MINIHAL_ > HalResetDisplay = HalpBiosDisplayReset; > +#else > + HalResetDisplay = NULL; > +#endif > HalHaltSystem = HaliHaltSystem; > > /* Register IRQ 2 */ > @@ -125,8 +135,10 @@ > /* Setup busy waiting */ > HalpCalibrateStallExecution(); > > +#ifndef _MINIHAL_ > /* Initialize the clock */ > HalpInitializeClock(); > +#endif > > /* > * We could be rebooting with a pending profile interrupt, > @@ -142,6 +154,7 @@ > /* Initialize bus handlers */ > HalpInitBusHandler(); > > +#ifndef _MINIHAL_ > /* Enable IRQ 0 */ > HalpEnableInterruptHandler(IDT_DEVICE, > 0, > @@ -160,6 +173,7 @@ > > /* Initialize DMA. NT does this in Phase 0 */ > HalpInitDma(); > +#endif > > /* Do some HAL-specific initialization */ > HalpInitPhase1(); > > Modified: trunk/reactos/hal/halx86/generic/misc.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/hal/halx86/generic/misc.c?… > ============================================================================== > --- trunk/reactos/hal/halx86/generic/misc.c [iso-8859-1] (original) > +++ trunk/reactos/hal/halx86/generic/misc.c [iso-8859-1] Wed Mar 3 22:56:52 2010 > @@ -28,6 +28,7 @@ > return; > } > > +#ifndef _MINIHAL_ > PVOID > NTAPI > HalpMapPhysicalMemory64(IN PHYSICAL_ADDRESS PhysicalAddress, > @@ -51,6 +52,7 @@ > // > MmUnmapIoSpace(VirtualAddress, NumberPages << PAGE_SHIFT); > } > +#endif > > VOID > NTAPI > @@ -122,6 +124,7 @@ > NTAPI > HalHandleNMI(IN PVOID NmiInfo) > { > +#ifndef _MINIHAL_ > SYSTEM_CONTROL_PORT_B_REGISTER SystemControl; > > // > @@ -202,6 +205,7 @@ > // Halt the system > // > InbvDisplayString("\n*** The system has halted ***\n"); > +#endif > > // > // Enter the debugger if possible > > Modified: trunk/reactos/hal/halx86/generic/pic.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/hal/halx86/generic/pic.c?r… > ============================================================================== > --- trunk/reactos/hal/halx86/generic/pic.c [iso-8859-1] (original) > +++ trunk/reactos/hal/halx86/generic/pic.c [iso-8859-1] Wed Mar 3 22:56:52 2010 > @@ -14,6 +14,7 @@ > > /* GLOBALS ********************************************************************/ > > +#ifndef _MINIHAL_ > /* > * This table basically keeps track of level vs edge triggered interrupts. > * Windows has 250+ entries, but it seems stupid to replicate that since the PIC > @@ -1335,3 +1336,28 @@ > } > } > > +#else > + > +KIRQL > +NTAPI > +KeGetCurrentIrql(VOID) > +{ > + return PASSIVE_LEVEL; > +} > + > +VOID > +FASTCALL > +KfLowerIrql( > + IN KIRQL OldIrql) > +{ > +} > + > +KIRQL > +FASTCALL > +KfRaiseIrql( > + IN KIRQL NewIrql) > +{ > + return NewIrql; > +} > + > +#endif > > Modified: trunk/reactos/hal/halx86/generic/reboot.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/hal/halx86/generic/reboot.… > ============================================================================== > --- trunk/reactos/hal/halx86/generic/reboot.c [iso-8859-1] (original) > +++ trunk/reactos/hal/halx86/generic/reboot.c [iso-8859-1] Wed Mar 3 22:56:52 2010 > @@ -98,8 +98,10 @@ > case HalHaltRoutine: > case HalRebootRoutine: > > +#ifndef _MINIHAL_ > /* Acquire the display */ > InbvAcquireDisplayOwnership(); > +#endif > > /* Call the internal reboot function */ > HalpReboot(); > > Modified: trunk/reactos/hal/halx86/generic/systimer.S > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/hal/halx86/generic/systime… > ============================================================================== > --- trunk/reactos/hal/halx86/generic/systimer.S [iso-8859-1] (original) > +++ trunk/reactos/hal/halx86/generic/systimer.S [iso-8859-1] Wed Mar 3 22:56:52 2010 > @@ -329,6 +329,7 @@ > ret > .endfunc > > +#ifndef _MINIHAL_ > .globl _KeStallExecutionProcessor@4 > .func KeStallExecutionProcessor@4 > _KeStallExecutionProcessor@4: > @@ -359,6 +360,7 @@ > /* Return */ > ret 4 > .endfunc > +#endif > > .global _KeQueryPerformanceCounter@4 > .func KeQueryPerformanceCounter@4 > > Modified: trunk/reactos/hal/halx86/generic/timer.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/hal/halx86/generic/timer.c… > ============================================================================== > --- trunk/reactos/hal/halx86/generic/timer.c [iso-8859-1] (original) > +++ trunk/reactos/hal/halx86/generic/timer.c [iso-8859-1] Wed Mar 3 22:56:52 2010 > @@ -109,6 +109,7 @@ > HalpCurrentRollOver = RollOver; > } > > +#ifndef _MINIHAL_ > VOID > FASTCALL > HalpClockInterruptHandler(IN PKTRAP_FRAME TrapFrame) > @@ -160,6 +161,7 @@ > /* Spurious, just end the interrupt */ > KiEoiHelper(TrapFrame); > } > +#endif > > > /* PUBLIC FUNCTIONS ***********************************************************/ > > Modified: trunk/reactos/hal/halx86/generic/usage.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/hal/halx86/generic/usage.c… > ============================================================================== > --- trunk/reactos/hal/halx86/generic/usage.c [iso-8859-1] (original) > +++ trunk/reactos/hal/halx86/generic/usage.c [iso-8859-1] Wed Mar 3 22:56:52 2010 > @@ -63,6 +63,7 @@ > HalpIDTUsage[SystemVector].BusReleativeVector = BusVector; > } > > +#ifndef _MINIHAL_ > VOID > NTAPI > HalpEnableInterruptHandler(IN UCHAR Flags, > @@ -87,6 +88,7 @@ > /* Enable the interrupt */ > HalEnableSystemInterrupt(SystemVector, Irql, Mode); > } > +#endif > > /* > * @unimplemented > > Modified: trunk/reactos/hal/halx86/hal_generic.rbuild > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/hal/halx86/hal_generic.rbu… > ============================================================================== > --- trunk/reactos/hal/halx86/hal_generic.rbuild [iso-8859-1] (original) > +++ trunk/reactos/hal/halx86/hal_generic.rbuild [iso-8859-1] Wed Mar 3 22:56:52 2010 > @@ -35,4 +35,41 @@ > <pch>hal.h</pch> > </directory> > </module> > + <module name="mini_hal" type="objectlibrary"> > + <include>include</include> > + <include base="ntoskrnl">include</include> > + <define name="_NTHAL_" /> > + <define name="_NTSYSTEM_" /> > + <define name="_MINIHAL_" /> > + <directory name="generic"> > + <directory name="bus"> > + <file>bushndlr.c</file> > + <file>isabus.c</file> > + <file>halbus.c</file> > + <file>pcibus.c</file> > + <file>pcidata.c</file> > + <file>sysbus.c</file> > + </directory> > + <file>beep.c</file> > + <file>bios.c</file> > + <file>cmos.c</file> > + <file>dma.c</file> > + <file>display.c</file> > + <file>drive.c</file> > + <file>misc.c</file> > + <file>pic.c</file> > + <file>portio.c</file> > + <file>processor.c</file> > + <file>profil.c</file> > + <file>reboot.c</file> > + <file>spinlock.c</file> > + <file>sysinfo.c</file> > + <file>systimer.S</file> > + <file>timer.c</file> > + <file>usage.c</file> > + </directory> > + <directory name="up"> > + <file>halinit_up.c</file> > + </directory> > + </module> > </group> > > Modified: trunk/reactos/hal/halx86/include/hal.h > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/hal/halx86/include/hal.h?r… > ============================================================================== > --- trunk/reactos/hal/halx86/include/hal.h [iso-8859-1] (original) > +++ trunk/reactos/hal/halx86/include/hal.h [iso-8859-1] Wed Mar 3 22:56:52 2010 > @@ -17,8 +17,12 @@ > #undef _NTHAL_ > #undef DECLSPEC_IMPORT > #define DECLSPEC_IMPORT > +#ifndef _MINIHAL_ > #undef NTSYSAPI > #define NTSYSAPI __declspec(dllimport) > +#else > +#undef _NTSYSTEM_ > +#endif > > /* IFS/DDK/NDK Headers */ > #include <ntifs.h> > > > >

1 0

Re: [ros-dev] [ros-diffs] [cgutman] 45775: - Initialize the ACPI table (the exact same we do it in KiRosFrldrLpbToNtLpb) - Fixes ACPI detection when booted in Windows-compatible mode
by Aleksey Bragin 04 Mar '10

04 Mar '10

I think this breaks real Windows bootloading support. WBR, Aleksey Bragin. On Mar 3, 2010, at 5:38 AM, cgutman(a)svn.reactos.org wrote: > Author: cgutman > Date: Wed Mar 3 03:38:56 2010 > New Revision: 45775 > > URL: http://svn.reactos.org/svn/reactos?rev=45775&view=rev > Log: > - Initialize the ACPI table (the exact same we do it in > KiRosFrldrLpbToNtLpb) > - Fixes ACPI detection when booted in Windows-compatible mode > > Modified: > trunk/reactos/boot/freeldr/freeldr/windows/winldr.c > > Modified: trunk/reactos/boot/freeldr/freeldr/windows/winldr.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/ > freeldr/windows/winldr.c?rev=45775&r1=45774&r2=45775&view=diff > ====================================================================== > ======== > --- trunk/reactos/boot/freeldr/freeldr/windows/winldr.c > [iso-8859-1] (original) > +++ trunk/reactos/boot/freeldr/freeldr/windows/winldr.c > [iso-8859-1] Wed Mar 3 03:38:56 2010 > @@ -37,6 +37,7 @@ > > extern BOOLEAN UseRealHeap; > extern ULONG LoaderPagesSpanned; > +extern BOOLEAN AcpiPresent; > > BOOLEAN > WinLdrCheckForLoadedDll(IN OUT PLOADER_PARAMETER_BLOCK WinLdrBlock, > @@ -195,6 +196,13 @@ > Extension->MajorVersion = (VersionToBoot & 0xFF00) >> 8; > Extension->MinorVersion = VersionToBoot & 0xFF; > Extension->Profile.Status = 2; > + > + /* Check if ACPI is present */ > + if (AcpiPresent) > + { > + /* See KiRosFrldrLpbToNtLpb for details */ > + Extension->AcpiTable = (PVOID)1; > + } > > /* Load drivers database */ > strcpy(MiscFiles, BootPath); > >

1 0

Wine Gecko Installer @ 2nd boot
by James Tabor 03 Mar '10

03 Mar '10

Hi! I guess we need to vendor drop and add to our build this missing component. James

3 3

Re: [ros-dev] [ros-diffs] [sir_richard] 45777: [NTOS]: Do the "funny message" (not really funny, my apologies) shenanigans after the system components have shutdown, and reset the display and call the HAL at least at DPC level (should probably do it
by WaxDragon 03 Mar '10

03 Mar '10

Axe them. On Mar 3, 2010 3:51 AM, "Christoph von Wittich" <Christoph(a)apiviewer.de> wrote: remove++ Am 03.03.2010 09:31, schrieb Ged Murphy: > sir_richard(a)svn.reactos.org wrote: > >> Did you know the "funny messages" take up more storage sp...

1 0

Re: [ros-dev] [ros-diffs] [sir_richard] 45777: [NTOS]: Do the "funny message" (not really funny, my apologies) shenanigans after the system components have shutdown, and reset the display and call the HAL at least at DPC level (should probably do it
by Olaf Siejka 03 Mar '10

03 Mar '10

This space can be used better by ACPI finally working, not to mention tha ACPI will render it useless anyway. remove++ 2010/3/3 Christoph von Wittich <Christoph(a)apiviewer.de> > remove++ > > Am 03.03.2010 09:31, schrieb Ged Murphy: > > sir_richard(a)svn.reactos.org wrote: > > > >> Did you know the "funny messages" take up more storage space than an > average embedded micro-controller OS? > > > > I've never liked these and I think they should be removed. > > They aren't funny and I'm not 12 years old.... > > > > Ged. > > > > > > > > > > > > _______________________________________________ > > Ros-dev mailing list > > Ros-dev(a)reactos.org > > http://www.reactos.org/mailman/listinfo/ros-dev > > > _______________________________________________ > Ros-dev mailing list > Ros-dev(a)reactos.org > http://www.reactos.org/mailman/listinfo/ros-dev >

1 0

Re: [ros-dev] [ros-diffs] [sir_richard] 45777: [NTOS]: Do the "funny message" (not really funny, my apologies) shenanigans after the system components have shutdown, and reset the display and call the HAL at least at DPC level (should probably do it at HIGH IRQL, r
by Ged Murphy 03 Mar '10

03 Mar '10

sir_richard(a)svn.reactos.org wrote: > Did you know the "funny messages" take up more storage space than an average embedded micro-controller OS? I've never liked these and I think they should be removed. They aren't funny and I'm not 12 years old.... Ged.

3 3

Time to Branch for Release
by James Tabor 02 Mar '10

02 Mar '10

FYI, I've tested Firefox 3.6, SeaMonkey 2.0.3, OOo 2.4.3, AbiWord 2.6.8 and bot tests are okay with Qemu and Hardware at rev 45734. James

4 6

Re: [ros-dev] [ros-diffs] [janderwald] 45759: [KSPROXY] - Implement IPersistPropertyBag interface - Implement IKsObject interface - Implement enumerating supported property/method/event set from driver and loading the corresponding ksproxy plugins
by Ged Murphy 02 Mar '10

02 Mar '10

janderwald(a)svn.reactos.org wrote: > - OutputDebugString("UNIMPLEMENTED\n"); > + OutputDebugStringW(L"UNIMPLEMENTED\n"); Why the change? This is one of the few functions when it's better to use the A version as the W version calls the A Ged.

1 0

Re: [ros-dev] Ros-dev Digest, Vol 67, Issue 2
by ODD Death 02 Mar '10

02 Mar '10

Most Visual Basic 6 and Visual C++ applications are working fine, i have tested FLV CAP but having problems in socket binding...

1 0

Problem with _IO_STACK_LOCATION defines in winddk.h
by Wiljan Derks 26 Feb '10

26 Feb '10

I am trying to build 64 drivers using gcc. I actually got a driver working now but had to fix a problem in winddk.h winddk.h has the following line just before "typedef struct _IO_STACK_LOCATION": #include <pshpack4.h> That causes gcc to ignore the "POINTER_ALIGNMENT" attributes used inside this struct. So it does not align these fields to the next 8 byte multiple as required for 64 bit. I now removed the "#include <pshpack4.h>" and the "#include <poppack.h>" at the end and that make the structure work properly on 64 bit for at least the iocontrol. Wiljan

1 0

ReactOS, Andrew Faulds has invited you to open a Google mail account
by Andrew Faulds 26 Feb '10

26 Feb '10

I've been using Google Mail and thought you might like to try it out. Here's an invitation to create an account. ----------------------------------------------------------------------- Andrew Faulds has invited you to open a free Google Mail account. To accept this invitation and register for your account, visit http://mail.google.com/mail/a-e6777bd09-b4d66660a7-cc7400ade44d27c3 Once you create your account, Andrew Faulds will be notified with your new email address so you can stay in touch with Google Mail! If you haven't already heard about Google Mail, it's a new search-based webmail service that offers: - Over 2,700 megabytes (two gigabytes) of free storage - Built-in Google search that instantly finds any message you want - Automatic arrangement of messages and related replies into "conversations" - Powerful spam protection using innovative Google technology - No large, annoying ads--just small text ads and related pages that are relevant to the content of your messages To learn more about Google Mail before registering, visit: http://mail.google.com/mail/help/intl/en_GB/benefits.html We're still working every day to improve Google Mail, so we might ask for your comments and suggestions periodically. We hope you'll like Google Mail. We do. And, it's only going to get better. Thanks, The Google Mail Team (If clicking the URLs in this message does not work, copy and paste them into the address bar of your browser).

1 0

Real HW Regression. Richard, this is for you
by Daniel Reimer 26 Feb '10

26 Feb '10

Hi, first my congratz to the great work you do recently. HAL really needed your attention :-D But... I stumbled over a nice regression last night. I wanted to install HEAD on the Notebook we will use on Chemnitzer Linux Tage to show ROS and failed to get to 1st stage at all. After some regression testing I tracked this down to this range: r45319 still works up to 3rd stage. r45324 fails to even get in 1st stage. The 5 revs in between dont build at all, because r45324 was a build fix for r45320 and this one was a biiig rewrite by Richard. The screen stays black and when I blindly type "CONT" , I get: ***STOP: 0x0000007B (0xF1BCDB60,0xC0000034,0x00000000,0x00000000) Its a really big problem to get more output from it because it has no Serial Ports at all. We tried to set /DEBUG DEBUGPORT=SCREEN /SOS but nothing shows up. So if someone finds a possible reason for that regression or a nice way to get the needed debuggin Information, plz tell me. It would be very important to get ROS run on it again. Machine is a: Acer Extensa 4100 wmli / Aspire 1690 wmli Acer Crane Mainboard Intel Pentium III Mobile CPU ATI Mobility Radeon X700 1 GB DDR RAM Thx for the help.

1 0

Is Sound Support added
by Arko Provo Mukherjee 25 Feb '10

25 Feb '10

Hi Gurus, Like to know whether we have Sound Support for React OS. If not is there any development going on for this? Can you give me the contact of the person who is working on incorporating / maintaining sound support in React OS? Kind Regards Arko

2 3

Trunk is broken
by Gabriel ilardi 24 Feb '10

24 Feb '10

Hi all, Just that this doesn't get lost, trunk's broken in two ways: 1) after 45640 you get the "CMP_WaitNoPending..." in 2nd stage in vbox being unable to proceed. Bug 4142: http://www.reactos.org/bugzilla/show_bug.cgi?id=4142 2) after 45645 installation stops at 1st stage with an assert: Assertion 'GuardedMutex->Owner != Thread' failed at ntoskrnl\include\/internal/k e_x.h line 1596 Entered debugger on embedded INT3 at 0x0008:0x808dc52e. kdb:> PuTTYbt Eip: <ntoskrnl.exe:dc52f (lib\rtl\i386\debug_asm.S:33 (DbgBreakPoint@0))> Frames: <ntoskrnl.exe:9aaa4 (ntoskrnl/include//internal/ke_x.h:1596 (MmNotPresentFault@1 2))> <ntoskrnl.exe:9b6e3 (ntoskrnl/mm/mmfault.c:298 (MmAccessFault@16))> <ntoskrnl.exe:66fb (ntoskrnl/ke/i386/traphdlr.c:1132 (@KiTrap0EHandler@4))> <ntoskrnl.exe:1b21c (ntoskrnl/cc/view.c:463 (CcRosLookupCacheSegment@8))> <ntoskrnl.exe:ac31a (ntoskrnl/mm/section.c:1251 (MmNotPresentFaultSectionView@16 ))> <ntoskrnl.exe:9adb9 (ntoskrnl/mm/mmfault.c:219 (MmNotPresentFault@12))> <ntoskrnl.exe:9b6e3 (ntoskrnl/mm/mmfault.c:298 (MmAccessFault@16))> <ntoskrnl.exe:66fb (ntoskrnl/ke/i386/traphdlr.c:1132 (@KiTrap0EHandler@4))> <b085a008> <ntoskrnl.exe:601e <ntoskrnl.exe:6412 (ntoskrnl/ke/i386/traphdlr.c:1517 (@KiFastC allEntryHandler@8))> <00000000> kdb:> Thanks. _________________________________________________________________ La tua privacy è al sicuro con Internet Explorer 8. Scopri di più http://www.microsoft.com/italy/windows/internet-explorer/features/browse-pr…

5 4

Hive Corruption
by James Tabor 23 Feb '10

23 Feb '10

FYI! I noticed a strange bug when working with OOo 2.4.3 after installing and running writer, then closing it, there was a random crash! This resulted in a hive corruption crash leaving the system unbootable! The only change I did was svn up trunk to the current revision 45668. Last revision was something bootable before 45640. The changes I've commit have been tested for over two weeks and some new ones this week. Thanks, James

1 0

[ros-diffs] [tkreuzer] 45659: [GDI32] - Quickfix the region leak, by commenting out the user mode part in DeleteRegion. Thanks to Caemyr for finding the guilty revision.
by James Tabor 22 Feb '10

22 Feb '10

Thanks Caemyr!!!! Kick Ass!!! Wow,,,, that means GdiBatch has been turned off? I'll look into that soon as I get back. Thanks, James

1 0

Re: [ros-dev] [ros-diffs] [ekohl] 45640: Partially revert patches 45626 and 45633. Several services do not report their status to the service manager properly. Therefore we must not use any code that relies on service status information as part of the setup and boo
by Ged Murphy 22 Feb '10

22 Feb '10

Are these our services and if so do you have a note of which ones? -----Original Message----- From: ros-diffs-bounces(a)reactos.org [mailto:ros-diffs-bounces@reactos.org] On Behalf Of ekohl(a)svn.reactos.org Sent: 20 February 2010 23:11 To: ros-diffs(a)reactos.org Subject: [ros-diffs] [ekohl] 45640: Partially revert patches 45626 and 45633. Several services do not report their status to the service manager properly. Therefore we must not use any code that relies on service status information as part of the setup and boot pr Author: ekohl Date: Sun Feb 21 00:10:53 2010 New Revision: 45640 URL: http://svn.reactos.org/svn/reactos?rev=45640&view=rev Log: Partially revert patches 45626 and 45633. Several services do not report their status to the service manager properly. Therefore we must not use any code that relies on service status information as part of the setup and boot processes as long as these issues have not been fixed. The service manager still needs to provide fake information about the service status. Modified: trunk/reactos/base/system/services/database.c trunk/reactos/dll/win32/syssetup/install.c Modified: trunk/reactos/base/system/services/database.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/system/services/datab… ============================================================================== --- trunk/reactos/base/system/services/database.c [iso-8859-1] (original) +++ trunk/reactos/base/system/services/database.c [iso-8859-1] Sun Feb 21 00:10:53 2010 @@ -1054,7 +1054,7 @@ { Group->ServicesRunning = TRUE; } - Service->Status.dwCurrentState = SERVICE_START_PENDING; + Service->Status.dwCurrentState = SERVICE_RUNNING; } #if 0 else Modified: trunk/reactos/dll/win32/syssetup/install.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/syssetup/install… ============================================================================== --- trunk/reactos/dll/win32/syssetup/install.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/syssetup/install.c [iso-8859-1] Sun Feb 21 00:10:53 2010 @@ -473,34 +473,17 @@ static BOOL EnableUserModePnpManager(VOID) { - SERVICE_STATUS_PROCESS ServiceStatus; SC_HANDLE hSCManager = NULL; SC_HANDLE hService = NULL; - DWORD dwStartTickCount; - DWORD dwOldCheckPoint; - DWORD BytesNeeded = 0; - DWORD dwWaitTime; - DWORD dwMaxWait; - HANDLE hEvent; BOOL ret = FALSE; - hEvent = OpenEventW(EVENT_ALL_ACCESS, - FALSE, - L"SC_AutoStartComplete"); - if (hEvent == NULL) - goto cleanup; - - WaitForSingleObject(hEvent, INFINITE); - - hSCManager = OpenSCManager(NULL, - NULL, - SC_MANAGER_CONNECT); + hSCManager = OpenSCManager(NULL, NULL, 0); if (hSCManager == NULL) goto cleanup; hService = OpenServiceW(hSCManager, L"PlugPlay", - SERVICE_CHANGE_CONFIG | SERVICE_START | SERVICE_QUERY_STATUS); + SERVICE_CHANGE_CONFIG | SERVICE_START); if (hService == NULL) goto cleanup; @@ -515,69 +498,9 @@ ret = StartServiceW(hService, 0, NULL); if (!ret) - { - /* If the service is already running, just return TRUE */ - ret = GetLastError() == ERROR_SERVICE_ALREADY_RUNNING; goto cleanup; - } - - ret = QueryServiceStatusEx(hService, - SC_STATUS_PROCESS_INFO, - (LPBYTE)&ServiceStatus, - sizeof(SERVICE_STATUS_PROCESS), - &BytesNeeded); - if (!ret) - goto cleanup; - - /* We don't want to wait for more than 30 seconds */ - dwMaxWait = 30000; - dwStartTickCount = GetTickCount(); - - /* Loop until it's running */ - while (ServiceStatus.dwCurrentState != SERVICE_RUNNING) - { - dwOldCheckPoint = ServiceStatus.dwCheckPoint; - dwWaitTime = ServiceStatus.dwWaitHint / 10; - - /* Get the latest status info */ - if (!QueryServiceStatusEx(hService, - SC_STATUS_PROCESS_INFO, - (LPBYTE)&ServiceStatus, - sizeof(SERVICE_STATUS_PROCESS), - &BytesNeeded)) - { - /* Something went wrong... */ - break; - } - - /* Is the service making progress? */ - if (ServiceStatus.dwCheckPoint > dwOldCheckPoint) - { - /* It is, get the latest tickcount to reset the max wait time */ - dwStartTickCount = GetTickCount(); - dwOldCheckPoint = ServiceStatus.dwCheckPoint; - } - else - { - /* It's not, make sure we haven't exceeded our wait time */ - if (GetTickCount() >= dwStartTickCount + dwMaxWait) - { - /* We have, give up */ - break; - } - } - - /* Adjust the wait hint times */ - if (dwWaitTime < 200) - dwWaitTime = 200; - else if (dwWaitTime > 10000) - dwWaitTime = 10000; - - /* Wait before trying again */ - Sleep(dwWaitTime); - } - - ret = ServiceStatus.dwCurrentState == SERVICE_RUNNING; + + ret = TRUE; cleanup: if (hSCManager != NULL)

2 1

Re: [ros-dev] [ros-diffs] [ekohl] 45637: [SERVICES] Disable a number of debug messages in the service manager.
by Aleksey Bragin 22 Feb '10

22 Feb '10

On Feb 20, 2010, at 11:52 PM, ekohl(a)svn.reactos.org wrote: > Author: ekohl > Date: Sat Feb 20 21:52:14 2010 > New Revision: 45637 > > URL: http://svn.reactos.org/svn/reactos?rev=45637&view=rev > Log: > [SERVICES] > Disable a number of debug messages in the service manager. > - DPRINT1("RpcServerUseProtseqEpW() failed (Status %lx)\n", > Status); > + DPRINT("RpcServerUseProtseqEpW() failed (Status %lx)\n", > Status); > - DPRINT1("RpcServerRegisterIf() failed (Status %lx)\n", > Status); > + DPRINT("RpcServerRegisterIf() failed (Status %lx)\n", > Status); ..etc Why disable critical failures notifications? Or they are not so critical?

2 1

Test Bot Crash
by James Tabor 21 Feb '10

21 Feb '10

I'm aware of the crash and it should have updated on the next commit. I'll add the ros hack back to the gdi32 font.c test when I get back. James

2 2

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev