- Ros-dev - ReactOS.org

Re: [ros-dev] [ros-diffs] 01/01: [NULL] Additions for the Null driver.
by Alex Ionescu 27 Apr '18

27 Apr '18

1) I thought certain MDL fast I/O routines can get called at DISPATCH_LEVEL 2) For perf reasons, causing a page-fault in the middle of a "fast I/O" is probably a bad idea. That being said -- these concerns seem silly since we are talking about the "Null" driver which... is entirely PAGED_CODE and clearly neither #1 or #2 are actual issues. In Windows, the fast I/o table is part of the DEVICE_OBJECT itself. Not sure why our driver allocates a separate pool allocation to begin with. Best regards, Alex Ionescu On Mon, Apr 23, 2018 at 1:30 AM, Ged Murphy <gedmurphy.maillists(a)gmail.com> wrote: > They're pagable in NT6, I don't know whether that's the case in NT5. > > Change looks good to me, I'm not really sure why Alex used NNP? > Perhaps our kernel does/did things slightly differently back when he wrote > the Null driver? > > Ged. > > -----Original Message----- > From: Ros-dev <ros-dev-bounces(a)reactos.org> On Behalf Of Thomas Faber > Sent: Monday, 23 April 2018 07:49 > To: Hermès Bélusca-Maïto <hermes.belusca-maito(a)reactos.org> > Cc: ros-dev(a)reactos.org > Subject: Re: [ros-dev] [ros-diffs] 01/01: [NULL] Additions for the Null > driver. > > On 2018-04-22 22:23, Hermès Bélusca-Maïto wrote: > > diff --git a/drivers/base/null/null.c b/drivers/base/null/null.c index > > 610e886ddd..0d4ed541de 100644 > > --- a/drivers/base/null/null.c > > +++ b/drivers/base/null/null.c > > @@ -181,26 +199,16 @@ DriverEntry(IN PDRIVER_OBJECT DriverObject, > > DriverObject->MajorFunction[IRP_MJ_READ] = NullDispatch; > > DriverObject->MajorFunction[IRP_MJ_LOCK_CONTROL] = NullDispatch; > > DriverObject->MajorFunction[IRP_MJ_QUERY_INFORMATION] = > > NullDispatch; > > + DriverObject->DriverUnload = NullUnload; > > > > - /* Allocate the fast I/O dispatch table */ > > - FastIoDispatch = ExAllocatePoolWithTag(NonPagedPool, > > - sizeof(FAST_IO_DISPATCH), > > - 'llun'); > > - if (!FastIoDispatch) > > - { > > - /* Failed, cleanup */ > > - IoDeleteDevice(DeviceObject); > > - return STATUS_INSUFFICIENT_RESOURCES; > > - } > > - > > - /* Initialize it */ > > - RtlZeroMemory(FastIoDispatch, sizeof(FAST_IO_DISPATCH)); > > - FastIoDispatch->SizeOfFastIoDispatch = sizeof(FAST_IO_DISPATCH); > > + /* Initialize the fast I/O dispatch table */ > > + RtlZeroMemory(&FastIoDispatch, sizeof(FastIoDispatch)); > > + FastIoDispatch.SizeOfFastIoDispatch = sizeof(FastIoDispatch); > > > > /* Setup our pointers */ > > - FastIoDispatch->FastIoRead = NullRead; > > - FastIoDispatch->FastIoWrite = NullWrite; > > - DriverObject->FastIoDispatch = FastIoDispatch; > > + FastIoDispatch.FastIoRead = NullRead; > > + FastIoDispatch.FastIoWrite = NullWrite; > > + DriverObject->FastIoDispatch = &FastIoDispatch; > > > Are you sure FAST_IO_DISPATCH is allowed to be pageable? It seems to only > be used at low IRQLs, so it seems logical. However I see it allocated > nonpaged everywhere else and can't seem to find definitive documentation on > the subject. > (And yes, most filesystem drivers use a static structure, but those > drivers don't use MmPageEntireDriver) > > Thanks, > Thomas > > _______________________________________________ > Ros-dev mailing list > Ros-dev(a)reactos.org > http://www.reactos.org/mailman/listinfo/ros-dev > > > _______________________________________________ > Ros-dev mailing list > Ros-dev(a)reactos.org > http://www.reactos.org/mailman/listinfo/ros-dev >

1 0

Status Meeting (April 2018)
by Colin Finck 26 Apr '18

26 Apr '18

Hi all! Let me invite you to the April 2018 meeting, taking place this Thursday, April 26, 2018 at 19:00 UTC. There have been no requests for additional agenda points yet and I'm not aware of any developments of the outstanding points of last meeting, so right now the agenda only includes the Status Updates. If there is something you want discussed this month, please reply to this mail. As waiting for every developer's Status Report still wastes too much time each month, I'm asking everyone to prepare a short text in advance. Unlike previous meetings, let's all try to post our status updates simultaneously this time and let the IRC server handle the congestion. This may make some reports harder to read, but we should be able to move on much quicker. Best regards, Colin

1 1

Re: [ros-dev] [ros-diffs] 01/01: [NULL] Additions for the Null driver.
by Thomas Faber 23 Apr '18

23 Apr '18

On 2018-04-22 22:23, Hermès Bélusca-Maïto wrote: > diff --git a/drivers/base/null/null.c b/drivers/base/null/null.c > index 610e886ddd..0d4ed541de 100644 > --- a/drivers/base/null/null.c > +++ b/drivers/base/null/null.c > @@ -181,26 +199,16 @@ DriverEntry(IN PDRIVER_OBJECT DriverObject, > DriverObject->MajorFunction[IRP_MJ_READ] = NullDispatch; > DriverObject->MajorFunction[IRP_MJ_LOCK_CONTROL] = NullDispatch; > DriverObject->MajorFunction[IRP_MJ_QUERY_INFORMATION] = NullDispatch; > + DriverObject->DriverUnload = NullUnload; > > - /* Allocate the fast I/O dispatch table */ > - FastIoDispatch = ExAllocatePoolWithTag(NonPagedPool, > - sizeof(FAST_IO_DISPATCH), > - 'llun'); > - if (!FastIoDispatch) > - { > - /* Failed, cleanup */ > - IoDeleteDevice(DeviceObject); > - return STATUS_INSUFFICIENT_RESOURCES; > - } > - > - /* Initialize it */ > - RtlZeroMemory(FastIoDispatch, sizeof(FAST_IO_DISPATCH)); > - FastIoDispatch->SizeOfFastIoDispatch = sizeof(FAST_IO_DISPATCH); > + /* Initialize the fast I/O dispatch table */ > + RtlZeroMemory(&FastIoDispatch, sizeof(FastIoDispatch)); > + FastIoDispatch.SizeOfFastIoDispatch = sizeof(FastIoDispatch); > > /* Setup our pointers */ > - FastIoDispatch->FastIoRead = NullRead; > - FastIoDispatch->FastIoWrite = NullWrite; > - DriverObject->FastIoDispatch = FastIoDispatch; > + FastIoDispatch.FastIoRead = NullRead; > + FastIoDispatch.FastIoWrite = NullWrite; > + DriverObject->FastIoDispatch = &FastIoDispatch; Are you sure FAST_IO_DISPATCH is allowed to be pageable? It seems to only be used at low IRQLs, so it seems logical. However I see it allocated nonpaged everywhere else and can't seem to find definitive documentation on the subject. (And yes, most filesystem drivers use a static structure, but those drivers don't use MmPageEntireDriver) Thanks, Thomas

2 1

Re: [ros-dev] [ros-diffs] 01/01: [WINLOGON] Clean up part 2 - Replace the UNICODE_STRING usMessage by a PWSTR pszMessage. - Use the "%02d:%02d:%02d" time format and get rid of the safe string printf because the string will NEVER be longer than 8 characters. - Rename the timer id constant because it is NOT a resource id. - Rename variables according to the coding style.
by Thomas Faber 06 Apr '18

06 Apr '18

Hey Eric, On 2018-04-02 12:58, Eric Kohl wrote: > - RtlStringCbPrintfW(strbuf, sizeof(strbuf), L"%d:%d:%d", hours, minutes, seconds); > + swprintf(szBuffer, L"%02d:%02d:%02d", iHours, iMinutes, iSeconds); Unfortunately I must disagree with this change. Buffer overflows are a big enough threat that code review and static analysis are not generally considered sufficient to protect against them. So it's best practice for new code to always verify sizes at run-time, and never to use s(w)print. Best regards, Thomas PS: from what I see, iHours can be as large as 1193046, which won't fit in 2 digits

7 7

Re: [ros-dev] [ros-diffs] 02/08: [NTOSKRNL] Forbid processes without the Tcb prvilege to perform a user-mode hard-error BSOD.
by Alex Ionescu 02 Apr '18

02 Apr '18

So to be clear, while the kernel still has tons of incompatible code and issues to barely run as a Win2003-compatible kernel, whenever there's an NT design decision you disagree with, you're going to be rewriting the little bit of code that _does work well_ to work contrary to how NT works? Did I get that right? Good luck. Best regards, Alex Ionescu On Mon, Apr 2, 2018 at 6:48 AM, Hermès BÉLUSCA-MAÏTO <hermes.belusca(a)sfr.fr> wrote: > Yes, to only allow programs that REALLY REALLY REALLY REALLY ….. need to > do so to trigger the hard-error “shutdown” BSOD from user-mode to do so, > and these programs would better be only those that run only in SYSTEM > rights, and more exactly these include CSRSS, WINLOGON and SMSS when > something very bad happen to them. > > I would not appreciate, for example, that when I run a program under a > not-so privileged account (like, some random user account) that has just > the shutdown privilege to shut the computer down properly, that this > program suddently “BSODS” my machine. > > To these programs, I say “f$ck these!” > > > > Regards, > > Hermès > > > > *De :* Ros-dev [mailto:ros-dev-bounces@reactos.org] *De la part de* Alex > Ionescu > *Envoyé :* lundi 2 avril 2018 04:20 > *À :* ReactOS Development List; Hermès Bélusca-Maïto > *Cc :* Linda Wang > *Objet :* Re: [ros-dev] [ros-diffs] 02/08: [NTOSKRNL] Forbid processes > without the Tcb prvilege to perform a user-mode hard-error BSOD. > > > > Is there a point to this blatant behavior change? > > > Best regards, > Alex Ionescu > > > > On Sun, Apr 1, 2018 at 3:04 PM, Hermès Bélusca-Maïto < > hermes.belusca-maito(a)reactos.org> wrote: > > https://git.reactos.org/?p=reactos.git;a=commitdiff;h= > f0729b30bb79d6f538cf2b9578ff8ebe7989f8d3 > > commit f0729b30bb79d6f538cf2b9578ff8ebe7989f8d3 > Author: Hermès Bélusca-Maïto <hermes.belusca-maito(a)reactos.org> > AuthorDate: Sun Apr 1 14:46:19 2018 +0200 > Commit: Hermès Bélusca-Maïto <hermes.belusca-maito(a)reactos.org> > CommitDate: Sun Apr 1 22:39:31 2018 +0200 > > [NTOSKRNL] Forbid processes without the Tcb prvilege to perform a > user-mode hard-error BSOD. > --- > ntoskrnl/ex/harderr.c | 14 ++++++++++++-- > 1 file changed, 12 insertions(+), 2 deletions(-) > > diff --git a/ntoskrnl/ex/harderr.c b/ntoskrnl/ex/harderr.c > index 84f409a1bb..a5200e3e74 100644 > --- a/ntoskrnl/ex/harderr.c > +++ b/ntoskrnl/ex/harderr.c > @@ -132,8 +132,18 @@ ExpRaiseHardError(IN NTSTATUS ErrorStatus, > /* Check if this error will shutdown the system */ > if (ValidResponseOptions == OptionShutdownSystem) > { > - /* Check for privilege */ > - if (!SeSinglePrivilegeCheck(SeShutdownPrivilege, PreviousMode)) > + /* > + * Check if we have the privileges. > + * > + * NOTE: In addition to the Shutdown privilege we also check > whether > + * the caller has the Tcb privilege. The purpose is to allow only > + * SYSTEM processes to "shutdown" the system on hard errors (BSOD) > + * while forbidding regular processes to do so. This behaviour > differs > + * from Windows, where any user-mode process, as soon as it has > the > + * Shutdown privilege, can trigger a hard-error BSOD. > + */ > + if (!SeSinglePrivilegeCheck(SeTcbPrivilege, PreviousMode) || > + !SeSinglePrivilegeCheck(SeShutdownPrivilege, PreviousMode)) > { > /* No rights */ > *Response = ResponseNotHandled; > > > > _______________________________________________ > Ros-dev mailing list > Ros-dev(a)reactos.org > http://www.reactos.org/mailman/listinfo/ros-dev > >

1 0

Re: [ros-dev] [ros-diffs] 01/01: [WINLOGON] Clean up part 2 - Replace the UNICODE_STRING usMessage by a PWSTR pszMessage. - Use the "%02d:%02d:%02d" time format and get rid of the safe string printf because the string will NEVER be longer than 8 character
by Hermès BÉLUSCA-MAÏTO 02 Apr '18

02 Apr '18

If I remember correctly you can make shutdowns delayed of many days on Windows (using the InitiateSystemShutdown(Ex) function), in which case the 2-digit hour won't work at all. Best, Hermès > -----Message d'origine----- > De : Ros-dev [mailto:ros-dev-bounces@reactos.org] De la part de Thomas > Faber > Envoyé : lundi 2 avril 2018 14:13 > À : Eric Kohl > Cc : ros-dev(a)reactos.org > Objet : Re: [ros-dev] [ros-diffs] 01/01: [WINLOGON] Clean up part 2 - Replace > the UNICODE_STRING usMessage by a PWSTR pszMessage. - Use the > "%02d:%02d:%02d" time format and get rid of the safe string printf because > the string will NEVER be longer than 8 character > > Hey Eric, > > On 2018-04-02 12:58, Eric Kohl wrote: > > - RtlStringCbPrintfW(strbuf, sizeof(strbuf), L"%d:%d:%d", hours, minutes, > seconds); > > + swprintf(szBuffer, L"%02d:%02d:%02d", iHours, iMinutes, > > + iSeconds); > > Unfortunately I must disagree with this change. > > Buffer overflows are a big enough threat that code review and static analysis > are not generally considered sufficient to protect against them. > So it's best practice for new code to always verify sizes at run-time, and > never to use s(w)print. > > Best regards, > Thomas > > PS: from what I see, iHours can be as large as 1193046, which won't > fit in 2 digits > > _______________________________________________ > Ros-dev mailing list > Ros-dev(a)reactos.org > http://www.reactos.org/mailman/listinfo/ros-dev

2 1

Re: [ros-dev] [ros-diffs] 02/08: [NTOSKRNL] Forbid processes without the Tcb prvilege to perform a user-mode hard-error BSOD.
by Alex Ionescu 02 Apr '18

02 Apr '18

Is there a point to this blatant behavior change? Best regards, Alex Ionescu On Sun, Apr 1, 2018 at 3:04 PM, Hermès Bélusca-Maïto < hermes.belusca-maito(a)reactos.org> wrote: > https://git.reactos.org/?p=reactos.git;a=commitdiff;h= > f0729b30bb79d6f538cf2b9578ff8ebe7989f8d3 > > commit f0729b30bb79d6f538cf2b9578ff8ebe7989f8d3 > Author: Hermès Bélusca-Maïto <hermes.belusca-maito(a)reactos.org> > AuthorDate: Sun Apr 1 14:46:19 2018 +0200 > Commit: Hermès Bélusca-Maïto <hermes.belusca-maito(a)reactos.org> > CommitDate: Sun Apr 1 22:39:31 2018 +0200 > > [NTOSKRNL] Forbid processes without the Tcb prvilege to perform a > user-mode hard-error BSOD. > --- > ntoskrnl/ex/harderr.c | 14 ++++++++++++-- > 1 file changed, 12 insertions(+), 2 deletions(-) > > diff --git a/ntoskrnl/ex/harderr.c b/ntoskrnl/ex/harderr.c > index 84f409a1bb..a5200e3e74 100644 > --- a/ntoskrnl/ex/harderr.c > +++ b/ntoskrnl/ex/harderr.c > @@ -132,8 +132,18 @@ ExpRaiseHardError(IN NTSTATUS ErrorStatus, > /* Check if this error will shutdown the system */ > if (ValidResponseOptions == OptionShutdownSystem) > { > - /* Check for privilege */ > - if (!SeSinglePrivilegeCheck(SeShutdownPrivilege, PreviousMode)) > + /* > + * Check if we have the privileges. > + * > + * NOTE: In addition to the Shutdown privilege we also check > whether > + * the caller has the Tcb privilege. The purpose is to allow only > + * SYSTEM processes to "shutdown" the system on hard errors (BSOD) > + * while forbidding regular processes to do so. This behaviour > differs > + * from Windows, where any user-mode process, as soon as it has > the > + * Shutdown privilege, can trigger a hard-error BSOD. > + */ > + if (!SeSinglePrivilegeCheck(SeTcbPrivilege, PreviousMode) || > + !SeSinglePrivilegeCheck(SeShutdownPrivilege, PreviousMode)) > { > /* No rights */ > *Response = ResponseNotHandled; > >

3 2

d2d1 in ReactOS
by Giovanni Mascellani 30 Mar '18

30 Mar '18

Dear ReactOS developers, I am nosing inside Wine and ReactOS code to understand something of their inner workings. I wanted to compare the code of d2d1.dll, but apparently ReactOS does not have it. Is this intentional, is it just still to be implemented, or is there any other explanation? Thanks and all the best, Giovanni. -- Giovanni Mascellani <g.mascellani(a)gmail.com> Postdoc researcher - Université Libre de Bruxelles

2 1

Status Meeting (March 2018)
by Colin Finck 29 Mar '18

29 Mar '18

Hi all! With GSoC and 0.4.8 approaching, and many interesting things going on, it's finally time for a monthly meeting again. Let me invite you to the March 2018 meeting, taking place next Thursday, March 29, 2018. Time will be 19:00 UTC as always. The agenda so far includes: - Status Updates ==> Please prepare a short text what you did since January, so we can finish this quickly! - GSoC - 0.4.8 Status und Release Planning - Hackfest 2018? Please let me know if you want anything else to be added to the agenda. Just as the last few times, the meeting will take place on a custom IRC server. The required credentials will be sent shortly before the meeting to a group of ReactOS members. If you think you belong to this group, but didn't get a mail last time, please also let me know in advance. See you on Thursday! Colin

3 4

GSoC 2018: Proposal for Review
by Abhishek Singh Bisht 22 Mar '18

22 Mar '18

Hello there, Here I have attached my proposal for the GSoC 2018 project regarding the search shell extension for ReactOS. Kindly let me know if any changes are required, before submitting it to Google. Thanks, Abhishek

2 1

GSoc Proposal (WebSite)
by Вова Титаренко 22 Mar '18

22 Mar '18

*GSoc ProposalProject: Developer Web InterfaceAuthor: Volodymyr Tytarenkobovatitar(a)gmail.com <bovatitar(a)gmail.com>General info:Full name: Volodymyr TytarenkoLanguages: 1. Russian (Fluently)2. Ukrainian (Fluently)3. Polish (Fluently)4. English (Intermediate)Timezone: (GMT+1) WarsawReactOS account: titarIRC Nickname: titarAbout me:I am second year student in Poland. I study informatics at University of Silesia in the specialty of developing web application. Programming is my passion. I started programming from the age of 15 and now i have 4 games for android, several programs on java for my needs and a lot of projects for freelanceTime Commitment:The main important thing, what can obligations my time in summer it’s a my University exams in June, but its only around 10 days, and i believe i will have a few exemption from the exam, because last time i had only 1 exam out of 6. Second thing it’s a 1 week holiday in end of July or start August, but it’s not 100%. I can spend 5-6 hours per day on this project including holidays.Technical skills:FrontEnd: HTML5, CSS, JavaScript and MithrillJS (arround 20)BackEnd: PHPDataBase: MySQLUX, UI, WebDesign, GitWork with different public API: GitHub, Telegram, Instagram, Facebook, VK, different weather api and other.I have experience Designing api for my own projects.My test design for a similar task (Custom ERP and CRM):Proposed Project:Develop a web system of managing and showing commits, builds, PRs and other informations for developers of ReactOS.I really want to work on a Website for ReactOS. I believe that I have enough knowledge to contribute to the operating system ReactOs in this way.Milestones: 1. Design basic interface and basic functionality. 2. Develop basic website with Integration githubAPI.3. Gradual increase of site functionality from the list of ideas reactos.org <http://reactos.org>Developing a website with the provision that at every moment we need to have a fully working website, gradually adding new features I hereby swear that I have not used nor seen the source code to any version of the Windows operating system nor any Microsoft product that may be related to the proposed project that is under a license incompatible with contribution to ReactOS, including but not limited to the leaked Windows 2000 source code and the Windows Research Kernel.*

2 1

GSoC 2018
by Abhishek Singh Bisht 22 Mar '18

22 Mar '18

Hi there, I am interested in a couple of projects under System enhancement, that I found on your projects list: 1) NT6 Recycle Bin Project 2) Search Shell extension 3) WebKit based MSHTML implementation Kindly help me choose one, if I could get some more information regarding the projects, it would be really helpful and I can go ahead with the proposal. Also, I have performed a complete build of ReactOS Live CD, and Boot CD and gave it a test run. I found it lacking a decent browser, tried to run iexplore.exe but it still couldn’t load any web pages. I might be able to create something to help improve on this. Looking forward to contribute to this reactOS. Thanks, Abhishek

4 3

ReactOS
by Кирилл Печкарев 18 Mar '18

18 Mar '18

Hello, I am a 3rd year student of Nosov MSTU, studying in the direction of Information and Computer science. I would like to develop components to support Wi-Fi, this is the third item from the list left on the site (https://habrahabr.ru/company/reactos/blog/351382/) Language know on average, can use greater part of his features. Experience in development is available since I combine study and work, I work in Department on creation of MES decisions. Fast learner, willing to allocate to the project 1-2 hours a day, maybe more( according to circumstances)

2 1

ReactOS
by Кирилл Печкарев 18 Mar '18

18 Mar '18

Здравствуйте, я студент 3 курса МГТУ им Носова, учусь на направлении Информатика и Вычислительная техника. Хотел бы заниматься разработкой компонентов для поддержки Wi-Fi, это третий пункт из списка оставленном на сайте (https://habrahabr.ru/company/reactos/blog/351382/) Язык знаю на среднем уровне, могу использовать большую часть его особенностей. Опыт в разработке имеется, т.к. совмещаю учебу и работу, работаю в отделе по созданию MES решений. Быстро учусь, готов выделять проекту 1-2 часа в день, возможно больше( по обстоятельствам)

1 0

Yet another GSoC proposal
by Victor Perevertkin 15 Mar '18

15 Mar '18

Hi all! I am a student and I want to try to participate in gsoc this year. I follow ReactOS news for 4 years, I think (and even reported a few bugs). I am a web developer but some time ago I started to study ASM and C (but no C++ yet) in my university and found it very interesting for me. I want to learn more about OSDev and maybe join your team finally :) There are some thoughts about what I want to do for ROS during this summer. 1. Make ReactOS boot from btrfs. As far as I understand, freeldr does not support btrfs and this code must be written. And boot sector ofc I prefer this task the most (as for now). But maybe you will dispel my dreams by saying that it requires too much effort for summer internship :) 2. I've already talked with Thomas Faber on IRC and he said that there are some drivers that are in need of being (re)written. NICs and bluetooth drivers may be interesting to me but I'm not sure if I can get through it. So I'm asking your advice. Are this things doable for a student? Maybe there are some other interesting low-level things for a GSoC'er? Do you have mentors for them? Basically, I want something low-level which doesn't require deep knowledge of NT internals. Thanks! Victor Perevertkin

1 0

Re: [ros-dev] [ros-diffs] 01/01: improve SHGetFileInfo (#118)
by Pierre Schweitzer 16 Feb '18

16 Feb '18

For the record, the commit doesn't match our contributing rules and should be avoided in the future. Reference: https://github.com/reactos/reactos/blob/master/.gitmessage Le 16/02/2018 à 12:00, Katayama Hirofumi MZ a écrit : > https://git.reactos.org/?p=reactos.git;a=commitdiff;h=338799bf8bf98698f3e4c… > > commit 338799bf8bf98698f3e4c1c2b885d724a9a929da > Author: Katayama Hirofumi MZ <katayama.hirofumi.mz(a)gmail.com> > AuthorDate: Fri Feb 16 20:00:08 2018 +0900 > Commit: Ged Murphy <gedmurphy(a)reactos.org> > CommitDate: Fri Feb 16 11:00:08 2018 +0000 > > improve SHGetFileInfo (#118) > > This patch reduces failures of SHGetFileInfo function. CORE-7159 > * improve WideByteToWideChar calls > * fix bugs related to file attributes and SHGFI_EXETYPE > * SHGFI_USEFILEATTRIBUTES and SHGFI_ICON fix > * s/sizeof(temppsfi)/0/ > --- > dll/win32/shell32/wine/shell32_main.c | 81 +++++++++++++++++++++-------------- > 1 file changed, 49 insertions(+), 32 deletions(-) > > diff --git a/dll/win32/shell32/wine/shell32_main.c b/dll/win32/shell32/wine/shell32_main.c > index b5638f0582..e64ef7f6fb 100644 > --- a/dll/win32/shell32/wine/shell32_main.c > +++ b/dll/win32/shell32/wine/shell32_main.c > @@ -3,6 +3,7 @@ > * > * Copyright 1998 Marcus Meissner > * Copyright 1998 Juergen Schmied (jsch) * <juergen.schmied(a)metronet.de> > + * Copyright 2017 Katayama Hirofumi MZ <katayama.hirofumi.mz(a)gmail.com> > * > * This library is free software; you can redistribute it and/or > * modify it under the terms of the GNU Lesser General Public > @@ -433,7 +434,7 @@ DWORD_PTR WINAPI SHGetFileInfoW(LPCWSTR path,DWORD dwFileAttributes, > { > psfi->szDisplayName[0] = '\0'; > psfi->szTypeName[0] = '\0'; > - psfi->iIcon = 0; > + psfi->hIcon = NULL; > } > > if (!(flags & SHGFI_PIDL)) > @@ -449,12 +450,24 @@ DWORD_PTR WINAPI SHGetFileInfoW(LPCWSTR path,DWORD dwFileAttributes, > lstrcpynW(szFullPath, path, MAX_PATH); > } > } > + else > + { > + SHGetPathFromIDListW((LPITEMIDLIST)path, szFullPath); > + } > > if (flags & SHGFI_EXETYPE) > { > - if (flags != SHGFI_EXETYPE) > - return 0; > - return shgfi_get_exe_type(szFullPath); > + if (!(flags & SHGFI_SYSICONINDEX)) > + { > + if (flags & SHGFI_USEFILEATTRIBUTES) > + { > + return TRUE; > + } > + else if (GetFileAttributesW(szFullPath) != INVALID_FILE_ATTRIBUTES) > + { > + return shgfi_get_exe_type(szFullPath); > + } > + } > } > > /* > @@ -488,6 +501,8 @@ DWORD_PTR WINAPI SHGetFileInfoW(LPCWSTR path,DWORD dwFileAttributes, > (LPCITEMIDLIST*)&pidlLast ); > if (SUCCEEDED(hr)) > pidlLast = ILClone(pidlLast); > + else > + hr = S_OK; > ILFree(pidl); > } > else > @@ -505,8 +520,18 @@ DWORD_PTR WINAPI SHGetFileInfoW(LPCWSTR path,DWORD dwFileAttributes, > psfi->dwAttributes = 0xffffffff; > } > if (psfParent) > - IShellFolder_GetAttributesOf( psfParent, 1, (LPCITEMIDLIST*)&pidlLast, > - &(psfi->dwAttributes) ); > + { > + IShellFolder_GetAttributesOf(psfParent, 1, (LPCITEMIDLIST*)&pidlLast, > + &(psfi->dwAttributes)); > + } > + } > + > + if (flags & SHGFI_USEFILEATTRIBUTES) > + { > + if (flags & SHGFI_ICON) > + { > + psfi->dwAttributes = 0; > + } > } > > /* get the displayname */ > @@ -516,7 +541,7 @@ DWORD_PTR WINAPI SHGetFileInfoW(LPCWSTR path,DWORD dwFileAttributes, > { > lstrcpyW (psfi->szDisplayName, PathFindFileNameW(szFullPath)); > } > - else > + else if (psfParent) > { > STRRET str; > hr = IShellFolder_GetDisplayNameOf( psfParent, pidlLast, > @@ -618,7 +643,7 @@ DWORD_PTR WINAPI SHGetFileInfoW(LPCWSTR path,DWORD dwFileAttributes, > ret = FALSE; > } > } > - else > + else if (psfParent) > { > hr = IShellFolder_GetUIObjectOf(psfParent, 0, 1, > (LPCITEMIDLIST*)&pidlLast, &IID_IExtractIconW, > @@ -694,7 +719,7 @@ DWORD_PTR WINAPI SHGetFileInfoW(LPCWSTR path,DWORD dwFileAttributes, > } > } > } > - else > + else if (psfParent) > { > if (!(PidlToSicIndex(psfParent, pidlLast, !(flags & SHGFI_SMALLICON), > uGilFlags, &(psfi->iIcon)))) > @@ -769,33 +794,25 @@ DWORD_PTR WINAPI SHGetFileInfoA(LPCSTR path,DWORD dwFileAttributes, > pathW = temppath; > } > > - if (psfi && (flags & SHGFI_ATTR_SPECIFIED)) > - temppsfi.dwAttributes=psfi->dwAttributes; > + if (psfi) > + { > + temppsfi.hIcon = psfi->hIcon; > + temppsfi.iIcon = psfi->iIcon; > + temppsfi.dwAttributes = psfi->dwAttributes; > > - if (psfi == NULL) > - ret = SHGetFileInfoW(pathW, dwFileAttributes, NULL, 0, flags); > - else > ret = SHGetFileInfoW(pathW, dwFileAttributes, &temppsfi, sizeof(temppsfi), flags); > + psfi->hIcon = temppsfi.hIcon; > + psfi->iIcon = temppsfi.iIcon; > + psfi->dwAttributes = temppsfi.dwAttributes; > > - if (psfi) > - { > - if(flags & SHGFI_ICON) > - psfi->hIcon=temppsfi.hIcon; > - if(flags & (SHGFI_SYSICONINDEX|SHGFI_ICON|SHGFI_ICONLOCATION)) > - psfi->iIcon=temppsfi.iIcon; > - if(flags & SHGFI_ATTRIBUTES) > - psfi->dwAttributes=temppsfi.dwAttributes; > - if(flags & (SHGFI_DISPLAYNAME|SHGFI_ICONLOCATION)) > - { > - WideCharToMultiByte(CP_ACP, 0, temppsfi.szDisplayName, -1, > - psfi->szDisplayName, sizeof(psfi->szDisplayName), NULL, NULL); > - } > - if(flags & SHGFI_TYPENAME) > - { > - WideCharToMultiByte(CP_ACP, 0, temppsfi.szTypeName, -1, > - psfi->szTypeName, sizeof(psfi->szTypeName), NULL, NULL); > - } > + WideCharToMultiByte(CP_ACP, 0, temppsfi.szDisplayName, -1, > + psfi->szDisplayName, sizeof(psfi->szDisplayName), NULL, NULL); > + > + WideCharToMultiByte(CP_ACP, 0, temppsfi.szTypeName, -1, > + psfi->szTypeName, sizeof(psfi->szTypeName), NULL, NULL); > } > + else > + ret = SHGetFileInfoW(pathW, dwFileAttributes, NULL, 0, flags); > > HeapFree(GetProcessHeap(), 0, temppath); > > -- Pierre Schweitzer <pierre at reactos.org> System & Network Administrator Senior Kernel Developer ReactOS Deutschland e.V.

1 0

Re: [ros-dev] [ros-diffs] 01/01: [NTOS:KE] Replace "Fatal System Error" with "BugCheck"
by Alex Ionescu 11 Feb '18

11 Feb '18

This changes documented/external behavior. What is the point of this change? Best regards, Alex Ionescu On Wed, Feb 7, 2018 at 1:22 PM, Serge Gautherie <reactos-git_serge_171003(a)gautherie.fr> wrote: > https://git.reactos.org/?p=reactos.git;a=commitdiff;h=6ece4e9fc22d664ea2485… > > commit 6ece4e9fc22d664ea2485d04303e8ae10047f21f > Author: Serge Gautherie <reactos-git_serge_171003(a)gautherie.fr> > AuthorDate: Wed Feb 7 06:29:02 2018 +0100 > Commit: Pierre Schweitzer <pierre(a)reactos.org> > CommitDate: Wed Feb 7 22:22:28 2018 +0100 > > [NTOS:KE] Replace "Fatal System Error" with "BugCheck" > --- > ntoskrnl/ke/bug.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/ntoskrnl/ke/bug.c b/ntoskrnl/ke/bug.c > index a92acb1bab..2127d7207c 100644 > --- a/ntoskrnl/ke/bug.c > +++ b/ntoskrnl/ke/bug.c > @@ -1070,8 +1070,8 @@ KeBugCheckWithTf(IN ULONG BugCheckCode, > if ((BugCheckCode != MANUALLY_INITIATED_CRASH) && (KdDebuggerEnabled)) > { > /* Crash on the debugger console */ > - DbgPrint("\n*** Fatal System Error: 0x%08lx\n" > - " (0x%p,0x%p,0x%p,0x%p)\n\n", > + DbgPrint("\n*** BugCheck: 0x%08lx\n" > + " (0x%p,0x%p,0x%p,0x%p)\n\n", > KiBugCheckData[0], > KiBugCheckData[1], > KiBugCheckData[2], >

4 4

Re: [ros-dev] Chemnitz Linux Tage, who will come by and support the booth?
by Daniel Reimer 11 Feb '18

11 Feb '18

Hello once more. Thanks for the single answer I got asking to take part. But I need one more booth supporter, preferred are team members. You have time till today evening to answer, otherwise I am not sure if I should blindly reply with the yes aka we will take part in CLT the team behind it is waiting for. In the end I reply and no one shows up. It is up to you. I got my holidays accepted last year already for being able to take part. What about the rest of the team who did not reply with a good reason not to take part already? Greetings Daniel Daniel Reimer <daniel.reimer(a)reactos.org> schrieb am Sa, 03.02.2018 14:54: > Hey guys, > > as every year, I need volunteers for the booth on Chemnitzer Linux Tage > (https://chemnitzer.linux-tage.de/2018/en). > > This year it's on March 10-11. Anyone who has some spare time for it? I > need at least two ppl for these days, otherwise I have to cancel it. > > Greetings > > Daniel > > > _______________________________________________ > Ros-dev mailing list > Ros-dev(a)reactos.org > http://www.reactos.org/mailman/listinfo/ros-dev

1 0

RFC: Change Rapps 'Size' field
by Mark Jansen 08 Feb '18

08 Feb '18

Hello, I'd like to propose a change for the 'Size' field: Currently this is a localized, pre-formatted field. By changing this to the actual size in bytes: - We can use StrFormatByteSizeW to format it locale dependent (without the need to manually translate it) - We can use this value to display the progress bar, in case the download itself does not provide this value (for example, web.archive does not provide this). For backwards compatibility we should probably add this as another field, so that the 'old' rapps can still read the 'Size' field. Regards, Mark

3 3

Chemnitz Linux Tage, who will come by and support the booth?
by Daniel Reimer 03 Feb '18

03 Feb '18

Hey guys, as every year, I need volunteers for the booth on Chemnitzer Linux Tage (https://chemnitzer.linux-tage.de/2018/en). This year it's on March 10-11. Anyone who has some spare time for it? I need at least two ppl for these days, otherwise I have to cancel it. Greetings Daniel

2 1

Dynamic libxml2/zlib
by Thomas Faber 03 Feb '18

03 Feb '18

Hey Amine, seeing https://jira.reactos.org/browse/CORE-14288 just prompted me to look into static vs dynamic 3rd party libraries, zlib and libxml2 in particular. We use zlib in a bunch of modules these days, and libxml2 is large and used in two, so I'm thinking we should make them dynamic. I just did the experiment for libxml2 and it resulted in at least 0.5MB binary size reduction and 2MB build folder size reduction, so clearly seems worth it.[1] I'll do the test for zlib as well to make sure that's also an improvement. However I was thinking there might be a reason why we build those statically right now. Do you (or anyone else) recall anything that makes switching to dynamic a bad idea? Thanks! -Thomas [1] Raw results: Static libxml2 (MSVC debug with RTC): msxml3.dll - 1887 KB libxslt.dll - 1142 KB libxml2.lib - 4953 KB (build dir only) Dynamic libxml2 (MSVC debug with RTC): msxml3.dll - 799 KB libxslt.dll - 259 KB libxml2.dll - 1592 KB libxml2.lib - 371 KB (build dir only) Static libxml2 (GCC debug with -O1): msxml3.dll - 3856 KB libxslt.dll - 2776 KB liblibxml2.a - 48 KB (build dir only) Dynamic libxml2 (GCC debug with -O1): msxml3.dll - 1505 KB libxslt.dll - 429 KB libxml2.dll - 2553 KB

2 1

Fwd: Re: [ros-diffs] 01/01: [WTSAPI32] Sync with Wine 3.0. CORE-14225
by Erkin Alp Güney 22 Jan '18

22 Jan '18

Aka project Doors! > In the long term, we could leverage the power of Git and fork the WINE > repository on GitHub. We could then apply Wine-Staging patches and our > own changes to that repository. Syncing with upstream would now be > possible by merging commits instead of overwriting files. In the end, > DLLs from that repository could be blindly imported into the ReactOS > repo again. No more maintaining of "wininet_ros.diff" and the like > > I hope we can have a solution before branching for 0.4.8. Otherwise, > I suspect that we will lose many features of 0.4.7 and the recent > history. For instance, DXTn support just got enabled in ReactOS, but it > has always been based on Wine-Staging code. > > > As James used to say: WINE Is Not Enough!

1 0

Re: [ros-dev] [ros-diffs] 01/01: [WTSAPI32] Sync with Wine 3.0. CORE-14225
by Ged Murphy 22 Jan '18

22 Jan '18

Is this really a sync up? It takes implemented functions are returns them to stubs -----Original Message----- From: Ros-diffs [mailto:ros-diffs-bounces@reactos.org] On Behalf Of Amine Khaldi Sent: 21 January 2018 21:02 To: ros-diffs(a)reactos.org Subject: [ros-diffs] 01/01: [WTSAPI32] Sync with Wine 3.0. CORE-14225 https://git.reactos.org/?p=reactos.git;a=commitdiff;h=90f14ccef3d9d344b7021… commit 90f14ccef3d9d344b7021407b4c59a7234a19614 Author: Amine Khaldi <amine.khaldi(a)reactos.org> AuthorDate: Sun Jan 21 22:01:34 2018 +0100 Commit: Amine Khaldi <amine.khaldi(a)reactos.org> CommitDate: Sun Jan 21 22:01:34 2018 +0100 [WTSAPI32] Sync with Wine 3.0. CORE-14225 --- dll/win32/wtsapi32/wtsapi32.c | 95 ++++--------------------------------------- media/doc/README.WINE | 2 +- 2 files changed, 10 insertions(+), 87 deletions(-) diff --git a/dll/win32/wtsapi32/wtsapi32.c b/dll/win32/wtsapi32/wtsapi32.c index a7f4c873d9..92a7396f54 100644 --- a/dll/win32/wtsapi32/wtsapi32.c +++ b/dll/win32/wtsapi32/wtsapi32.c @@ -28,9 +28,6 @@ WINE_DEFAULT_DEBUG_CHANNEL(wtsapi); -/* FIXME: Inspect */ -#define GetCurrentProcessToken() ((HANDLE)~(ULONG_PTR)3) - /************************************************************ * WTSCloseServer (WTSAPI32.@) @@ -99,13 +96,8 @@ BOOL WINAPI WTSEnumerateProcessesA(HANDLE hServer, DWORD Reserved, DWORD Version BOOL WINAPI WTSEnumerateProcessesW(HANDLE hServer, DWORD Reserved, DWORD Version, PWTS_PROCESS_INFOW* ppProcessInfo, DWORD* pCount) { - WTS_PROCESS_INFOW *processInfo; - SYSTEM_PROCESS_INFORMATION *spi; - ULONG size = 0x4000; - void *buf = NULL; - NTSTATUS status; - DWORD count; - WCHAR *name; + FIXME("Stub %p 0x%08x 0x%08x %p %p\n", hServer, Reserved, Version, + ppProcessInfo, pCount); if (!ppProcessInfo || !pCount || Reserved != 0 || Version != 1) { @@ -113,71 +105,9 @@ BOOL WINAPI WTSEnumerateProcessesW(HANDLE hServer, DWORD Reserved, DWORD Version return FALSE; } - if (hServer != WTS_CURRENT_SERVER_HANDLE) - { - SetLastError(ERROR_CALL_NOT_IMPLEMENTED); - return FALSE; - } - - do - { - size *= 2; - HeapFree(GetProcessHeap(), 0, buf); - buf = HeapAlloc(GetProcessHeap(), 0, size); - if (!buf) - { - SetLastError(ERROR_OUTOFMEMORY); - return FALSE; - } - status = NtQuerySystemInformation(SystemProcessInformation, buf, size, NULL); - } - while (status == STATUS_INFO_LENGTH_MISMATCH); - - if (status != STATUS_SUCCESS) - { - HeapFree(GetProcessHeap(), 0, buf); - SetLastError(RtlNtStatusToDosError(status)); - return FALSE; - } - - spi = buf; - count = size = 0; - for (;;) - { - size += sizeof(WTS_PROCESS_INFOW) + spi->ProcessName.Length + sizeof(WCHAR); - count++; - if (spi->NextEntryOffset == 0) break; - spi = (SYSTEM_PROCESS_INFORMATION *)(((PCHAR)spi) + spi->NextEntryOffset); - } - - processInfo = HeapAlloc(GetProcessHeap(), 0, size); - if (!processInfo) - { - HeapFree(GetProcessHeap(), 0, buf); - SetLastError(ERROR_OUTOFMEMORY); - return FALSE; - } - name = (WCHAR *)&processInfo[count]; - - *ppProcessInfo = processInfo; - *pCount = count; - - spi = buf; - while (count--) - { - processInfo->SessionId = 0; - processInfo->ProcessId = HandleToUlong(spi->UniqueProcessId); - processInfo->pProcessName = name; - processInfo->pUserSid = NULL; - memcpy( name, spi->ProcessName.Buffer, spi->ProcessName.Length ); - name[ spi->ProcessName.Length/sizeof(WCHAR) ] = 0; - - processInfo++; - name += (spi->ProcessName.Length + sizeof(WCHAR))/sizeof(WCHAR); - spi = (SYSTEM_PROCESS_INFORMATION *)(((PCHAR)spi) + spi->NextEntryOffset); - } + *pCount = 0; + *ppProcessInfo = NULL; - HeapFree(GetProcessHeap(), 0, buf); return TRUE; } @@ -241,7 +171,9 @@ BOOL WINAPI WTSEnumerateSessionsW(HANDLE hServer, DWORD Reserved, DWORD Version, */ void WINAPI WTSFreeMemory(PVOID pMemory) { - HeapFree(GetProcessHeap(), 0, pMemory); + static int once; + + if (!once++) FIXME("Stub %p\n", pMemory); } /************************************************************ @@ -314,16 +246,7 @@ BOOL WINAPI WTSQuerySessionInformationW( BOOL WINAPI WTSQueryUserToken(ULONG session_id, PHANDLE token) { FIXME("%u %p\n", session_id, token); - - if (!token) - { - SetLastError(ERROR_INVALID_PARAMETER); - return FALSE; - } - - return DuplicateHandle(GetCurrentProcess(), GetCurrentProcessToken(), - GetCurrentProcess(), token, - 0, FALSE, DUPLICATE_SAME_ACCESS); + return FALSE; } /************************************************************ @@ -357,7 +280,7 @@ BOOL WINAPI WTSRegisterSessionNotification(HWND hWnd, DWORD dwFlags) } /************************************************************ - * WTSRegisterSessionNotification (WTSAPI32.@) + * WTSRegisterSessionNotificationEx (WTSAPI32.@) */ BOOL WINAPI WTSRegisterSessionNotificationEx(HANDLE hServer, HWND hWnd, DWORD dwFlags) { diff --git a/media/doc/README.WINE b/media/doc/README.WINE index f366990215..69bf99b9c6 100644 --- a/media/doc/README.WINE +++ b/media/doc/README.WINE @@ -212,7 +212,7 @@ reactos/dll/win32/wmi # Synced to WineStaging-2.9 reactos/dll/win32/wmiutils # Synced to WineStaging-2.9 reactos/dll/win32/wmvcore # Synced to Wine-3.0 reactos/dll/win32/wshom.ocx # Synced to Wine-3.0 -reactos/dll/win32/wtsapi32 # Synced to WineStaging-2.9 +reactos/dll/win32/wtsapi32 # Synced to Wine-3.0 reactos/dll/win32/wuapi # Synced to WineStaging-2.9 reactos/dll/win32/xinput1_1 # Synced to WineStaging-2.9 reactos/dll/win32/xinput1_2 # Synced to WineStaging-2.9

2 1

Making bluescreens more useful
by Thomas Faber 14 Jan '18

14 Jan '18

We often get bug reports with just a screenshot of a bluescreen; we then go ahead and tell people that bluescreens are basically useless, they should get a debug log and a backtrace, and also remember to tell us what version they're using. Since there's actually no reason why bluescreens need to be useless, I thought I'd try to change that. I've attached an example. The source for this quick PoC can be found at https://github.com/ThFabba/reactos/commit/6a9f172b76bd11f763598c16e5d47299e… Thoughts?

12 16

Re: [ros-dev] Making bluescreens more useful
by Hermès BÉLUSCA - MAÏTO 13 Jan '18

13 Jan '18

2 1

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev