- Ros-dev - ReactOS.org

Re: [ros-dev] [ros-diffs] [mjmartin] 41269: - IopCreateDriver: Change MajorFunction routines back to internal function IopInvalidDeviceRequest for ones that were set to NULL in the Drivers DriverEntry. Windows does it and so shall we.
by Alex Ionescu 03 Jun '09

03 Jun '09

I must say that I protest to all the recent I/O changes, and in my opinion, they are all wrong and badly researched, and have hacked what was once good code. Best regards, Alex Ionescu On Wed, Jun 3, 2009 at 2:48 AM, <mjmartin(a)svn.reactos.org> wrote: > Author: mjmartin > Date: Wed Jun 3 13:48:33 2009 > New Revision: 41269 > > URL: http://svn.reactos.org/svn/reactos?rev=41269&view=rev > Log: > - IopCreateDriver: Change MajorFunction routines back to internal function IopInvalidDeviceRequest for ones that were set to NULL in the Drivers DriverEntry. Windows does it and so shall we. > > Modified: > trunk/reactos/ntoskrnl/io/iomgr/driver.c > > Modified: trunk/reactos/ntoskrnl/io/iomgr/driver.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/io/iomgr/driver.c… > ============================================================================== > --- trunk/reactos/ntoskrnl/io/iomgr/driver.c [iso-8859-1] (original) > +++ trunk/reactos/ntoskrnl/io/iomgr/driver.c [iso-8859-1] Wed Jun 3 13:48:33 2009 > @@ -1302,7 +1302,7 @@ > RtlZeroMemory(DriverObject, ObjectSize); > DriverObject->Type = IO_TYPE_DRIVER; > DriverObject->Size = sizeof(DRIVER_OBJECT); > - DriverObject->Flags = DRVO_BUILTIN_DRIVER; > + DriverObject->Flags = DRVO_LEGACY_DRIVER;//DRVO_BUILTIN_DRIVER; > DriverObject->DriverExtension = (PDRIVER_EXTENSION)(DriverObject + 1); > DriverObject->DriverExtension->DriverObject = DriverObject; > DriverObject->DriverInit = InitializationFunction; > @@ -1398,6 +1398,14 @@ > { > /* Returns to caller the object */ > *pDriverObject = DriverObject; > + } > + > + /* Loop all Major Functions */ > + for (i = 0; i <= IRP_MJ_MAXIMUM_FUNCTION; i++) > + { > + /* Set each function that was set to NULL to internal routine */ > + if (!DriverObject->MajorFunction[i]) > + DriverObject->MajorFunction[i] = IopInvalidDeviceRequest; > } > > /* Return the Status */ > >

3 2

Re: [ros-dev] [ros-diffs] [cgutman] 41213: - Export and hackplement NdisSetTimerEx - Implementation is #ifed out currently but I may enable it later - Hopefully somebody can think of a better way to do it than the current code
by Alex Ionescu 02 Jun '09

02 Jun '09

There's nothing ugly about this -- this is exactly what the field is for. Best regards, Alex Ionescu On Sat, May 30, 2009 at 4:07 PM, <cgutman(a)svn.reactos.org> wrote: > Author: cgutman > Date: Sun May 31 03:07:13 2009 > New Revision: 41213 > > URL: http://svn.reactos.org/svn/reactos?rev=41213&view=rev > Log: > - Export and hackplement NdisSetTimerEx > - Implementation is #ifed out currently but I may enable it later > - Hopefully somebody can think of a better way to do it than the current code > > Modified: > trunk/reactos/drivers/network/ndis/ndis.def > trunk/reactos/drivers/network/ndis/ndis/time.c > > Modified: trunk/reactos/drivers/network/ndis/ndis.def > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/network/ndis/ndis.… > ============================================================================== > --- trunk/reactos/drivers/network/ndis/ndis.def [iso-8859-1] (original) > +++ trunk/reactos/drivers/network/ndis/ndis.def [iso-8859-1] Sun May 31 03:07:13 2009 > @@ -257,6 +257,7 @@ > NdisSetPacketPoolProtocolId@8 > ;NdisSetProtocolFilter ? > NdisSetTimer@8 > +NdisSetTimerEx@12 > NdisSetupDmaTransfer@24 > NdisSystemProcessorCount@0 > NdisTerminateWrapper@8 > > Modified: trunk/reactos/drivers/network/ndis/ndis/time.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/network/ndis/ndis/… > ============================================================================== > --- trunk/reactos/drivers/network/ndis/ndis/time.c [iso-8859-1] (original) > +++ trunk/reactos/drivers/network/ndis/ndis/time.c [iso-8859-1] Sun May 31 03:07:13 2009 > @@ -243,5 +243,26 @@ > KeSetTimer (&Timer->Timer, Timeout, &Timer->Dpc); > } > > +VOID > +EXPORT > +NdisSetTimerEx( > + IN PNDIS_TIMER Timer, > + IN UINT MillisecondsToDelay, > + IN PVOID FunctionContext) > +{ > +#if 0 > + /* FIXME: I'm not sure how to this in a nice way > + * We can't store the function context anywhere in NDIS_TIMER > + * so I'm forced to do this > + */ > + > + Timer->Dpc.DeferredContext = FunctionContext; > + > + NdisSetTimer(Timer, MillisecondsToDelay); > +#else > + UNIMPLEMENTED > +#endif > +} > + > /* EOF */ > > >

1 0

ReactOS debug on bochs
by Fan Zhang 01 Jun '09

01 Jun '09

Hi I download a very early edtion of reactos(0.0.21), I think it would be easy to understand for me. I disable the NDEBUG macro, so I can catch the debug info. By default, I use the /DEBUGPORT=SCREEN, and the log info is printed on the screen. Then I changed to /DEBUGPORT=BOCHS, but there is no any info on the bochs console. Could you tell me how to catch the log on the bochs? Fan Zhang

1 0

Re: [ros-dev] [ros-diffs] [spetreolle] 41204: ChangeDisplaySettingsA and ChangeDisplaySettingsW should reset dmDriverExtra to 0.
by Ged 30 May '09

30 May '09

This seems very strange -----Original Message----- From: ros-diffs-bounces(a)reactos.org [mailto:ros-diffs-bounces@reactos.org] On Behalf Of spetreolle(a)svn.reactos.org Sent: 30 May 2009 13:23 To: ros-diffs(a)reactos.org Subject: [ros-diffs] [spetreolle] 41204: ChangeDisplaySettingsA and ChangeDisplaySettingsW should reset dmDriverExtra to 0. Author: spetreolle Date: Sat May 30 16:23:20 2009 New Revision: 41204 URL: http://svn.reactos.org/svn/reactos?rev=41204&view=rev Log: ChangeDisplaySettingsA and ChangeDisplaySettingsW should reset dmDriverExtra to 0. Modified: trunk/reactos/dll/win32/user32/misc/display.c Modified: trunk/reactos/dll/win32/user32/misc/display.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/misc/disp… ============================================================================== --- trunk/reactos/dll/win32/user32/misc/display.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/user32/misc/display.c [iso-8859-1] Sat May 30 16:23:20 2009 @@ -493,7 +493,10 @@ LPDEVMODEA lpDevMode, DWORD dwflags) { - return ChangeDisplaySettingsExA ( NULL, lpDevMode, NULL, dwflags, 0 ); + LONG Status = ChangeDisplaySettingsExA ( NULL, lpDevMode, NULL, dwflags, 0 ); + if(lpDevMode) + lpDevMode->dmDriverExtra = 0; + return Status; } @@ -533,5 +536,8 @@ LPDEVMODEW lpDevMode, DWORD dwflags) { - return ChangeDisplaySettingsExW ( NULL, lpDevMode, NULL, dwflags, 0 ); -} + LONG Status = ChangeDisplaySettingsExW ( NULL, lpDevMode, NULL, dwflags, 0 ); + if(lpDevMode) + lpDevMode->dmDriverExtra = 0; + return Status; +}

2 2

Re: [ros-dev] [ros-diffs] [dgorbachev] 41153: Do not assign twice to the same variable.
by Ged 27 May '09

27 May '09

Did you mean to remove IRP_MJ_CLEANUP? -----Original Message----- From: ros-diffs-bounces(a)reactos.org [mailto:ros-diffs-bounces@reactos.org] On Behalf Of dgorbachev(a)svn.reactos.org Sent: 27 May 2009 21:27 To: ros-diffs(a)reactos.org Subject: [ros-diffs] [dgorbachev] 41153: Do not assign twice to the same variable. Author: dgorbachev Date: Thu May 28 00:27:09 2009 New Revision: 41153 URL: http://svn.reactos.org/svn/reactos?rev=41153&view=rev Log: Do not assign twice to the same variable. Modified: trunk/reactos/drivers/storage/ide/pciide/pciide.c trunk/reactos/ntoskrnl/io/iomgr/rawfs.c Modified: trunk/reactos/drivers/storage/ide/pciide/pciide.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/storage/ide/pciide… ============================================================================== --- trunk/reactos/drivers/storage/ide/pciide/pciide.c [iso-8859-1] (original) +++ trunk/reactos/drivers/storage/ide/pciide/pciide.c [iso-8859-1] Thu May 28 00:27:09 2009 @@ -104,7 +104,7 @@ ControllerProperties->SupportedTransferMode[0][0] = ControllerProperties->SupportedTransferMode[0][1] = ControllerProperties->SupportedTransferMode[1][0] = - ControllerProperties->SupportedTransferMode[1][0] = + ControllerProperties->SupportedTransferMode[1][1] = PIO_MODE0 | PIO_MODE1 | PIO_MODE2 | PIO_MODE3 | PIO_MODE4 | SWDMA_MODE0 | SWDMA_MODE1 | SWDMA_MODE2 | MWDMA_MODE0 | MWDMA_MODE1 | MWDMA_MODE2 | Modified: trunk/reactos/ntoskrnl/io/iomgr/rawfs.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/io/iomgr/rawfs.c?… ============================================================================== --- trunk/reactos/ntoskrnl/io/iomgr/rawfs.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/io/iomgr/rawfs.c [iso-8859-1] Thu May 28 00:27:09 2009 @@ -1082,7 +1082,6 @@ DriverObject->MajorFunction[IRP_MJ_QUERY_INFORMATION] = DriverObject->MajorFunction[IRP_MJ_SET_INFORMATION] = DriverObject->MajorFunction[IRP_MJ_QUERY_VOLUME_INFORMATION] = - DriverObject->MajorFunction[IRP_MJ_CLEANUP] = DriverObject->MajorFunction[IRP_MJ_FILE_SYSTEM_CONTROL] = DriverObject->MajorFunction[IRP_MJ_DEVICE_CONTROL] = (PDRIVER_DISPATCH)RawDispatch;

2 1

Re: [ros-dev] [ros-diffs] [dchapyshev] 41115: - Stubimplement SPI_GETFONTSMOOTHINGTYPE/SPI_SETFONTSMOOTHINGTYPE
by Timo Kreuzer 25 May '09

25 May '09

Ok before you go on in this area, I am currently working on a complete rewrite of sysparams stuff. It should hopefully be ready this week and should fix almost all winetests and additional tests in this area. Regards, Timo dchapyshev(a)svn.reactos.org schrieb: > Author: dchapyshev > Date: Mon May 25 17:08:57 2009 > New Revision: 41115 > > URL: http://svn.reactos.org/svn/reactos?rev=41115&view=rev > Log: > - Stubimplement SPI_GETFONTSMOOTHINGTYPE/SPI_SETFONTSMOOTHINGTYPE > > Modified: > trunk/reactos/subsystems/win32/win32k/ntuser/sysparams.c > > Modified: trunk/reactos/subsystems/win32/win32k/ntuser/sysparams.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/nt… > ============================================================================== > --- trunk/reactos/subsystems/win32/win32k/ntuser/sysparams.c [iso-8859-1] (original) > +++ trunk/reactos/subsystems/win32/win32k/ntuser/sysparams.c [iso-8859-1] Mon May 25 17:08:57 2009 > @@ -699,6 +699,22 @@ > { > ASSERT(pvParam); > *((BOOL*)pvParam) = IntIsFontRenderingEnabled(); > + break; > + } > + case SPI_SETFONTSMOOTHINGTYPE: > + { > + if (*((UINT*)pvParam) == FE_FONTSMOOTHINGCLEARTYPE) > + { > + DPRINT1("ReactOS does not support ClearType smoothing but it is returned TRUE\n"); > + } > + bChanged = TRUE; > + break; > + } > + case SPI_GETFONTSMOOTHINGTYPE: > + { > + /* We do not support ClearType. Only standard smoothing */ > + DPRINT1("ReactOS does not support ClearType smoothing. Returned FE_FONTSMOOTHINGSTANDARD\n"); > + *((UINT*)pvParam) = FE_FONTSMOOTHINGSTANDARD; > break; > } > case SPI_GETICONTITLELOGFONT: > > >

1 0

Re: [ros-dev] [ros-diffs] [dchapyshev] 41113: - Disable Wow64* functions for x86 build
by Timo Kreuzer 25 May '09

25 May '09

BTW: there's a way to do this in normal spec files. It would be @ stdcall -arch=x86_64 Wow64EnableWow64FsRedirection(long) i386, x86_64, sparc, alpha and powerpc are supported Multiple architectures can be sperated with comma. Timo dchapyshev(a)svn.reactos.org schrieb: > Author: dchapyshev > Date: Mon May 25 15:01:16 2009 > New Revision: 41113 > > URL: http://svn.reactos.org/svn/reactos?rev=41113&view=rev > Log: > - Disable Wow64* functions for x86 build > > Modified: > trunk/reactos/dll/win32/kernel32/kernel32.pspec > > Modified: trunk/reactos/dll/win32/kernel32/kernel32.pspec > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/kernel32/kernel3… > ============================================================================== > --- trunk/reactos/dll/win32/kernel32/kernel32.pspec [iso-8859-1] (original) > +++ trunk/reactos/dll/win32/kernel32/kernel32.pspec [iso-8859-1] Mon May 25 15:01:16 2009 > @@ -950,9 +950,11 @@ > @ stdcall WaitNamedPipeW (wstr long) > @ stdcall WideCharToMultiByte(long long wstr long ptr long ptr ptr) > @ stdcall WinExec(str long) > +#ifdef _M_AMD64 > @ stdcall Wow64EnableWow64FsRedirection(long) > @ stdcall Wow64DisableWow64FsRedirection(long) > @ stdcall Wow64RevertWow64FsRedirection(long) > +#endif > @ stdcall WriteConsoleA(long ptr long ptr ptr) > @ stdcall WriteConsoleInputA(long ptr long ptr) > @ stdcall WriteConsoleInputVDMA(long long long long) > > >

1 0

WineHQ vs ReactOS Winetest Comparator.WIRECo
by victor martinez 25 May '09

25 May '09

Hi.. I have had an idea which i want to share with you, so we can discuss if it is interesting or stupid enough. Right now we have a Winetests comparator called TestMan thanks to the efforts of Colin and Lone_Rifle. This script compares the Winetest results of different revisions. It is really helpful to find regressions(Thanks Lone_rifle to be supervising them from time to time :) ). My idea is about creating/adding a new script which compares the winetest results of a ReactOS revision vs the result of the WineHQ winetests. Of course just in those functions/modules that we have full-synced with Wine. Why? Lets imagine that our Wininit:FTP functions are synced(as they are).That means that the code of those functions are the same in Wine and in ReactOS. That means that Bugs present in that code will be present in ReactOS too.These could be called the Expected bugs.ReactOS should fail in these tests since Wine functions are bugged: call them Expected Fails. But sometimes ReactOS is showing more fails than the Expected Fails( in synced code).Why? Well, these synced functions use other deeper functions which arent synced with Wine and which is own ReactOS code.And, of course,which can have Bugs.If these deeper functions arent working properlly then affects the synced functions which uses them and then you will see extra tests failing. Lets give a small example. Wininit:FTP is synced with Wine. WineHQ reports 6 failures : http://test.winehq.org/data/b175a43fb8439a33a686512935597d4c43c19733/wine_w… ReactOS latest rev reports 19 failures: http://79.99.5.181/testman/detail.php?id=141321 These 13 extra failures arent expected.We expect just 6 Expected Fails (which seems to be related with Bugs in Wine code), so this 13 extra failures are related with deeper functions (which are ReactOS own code). So the New Script would check the failures in WineHQ and in ReactOS rev and warn when the number of failures is higher than the number of Expected failures,showing also the differences, so the New Script can easily point our Devs towards ReactOS bugs, helping he "hunting" giving "clues" to them. If my reasoning is wrong,or i am missing something,please tell me. :) How much useful would be this Script?Is it interesting enough for Developing purposes?or Is it a waste of time/efforts? Note: The ie is Bugzilled.It´s curious,since doing a small Timing trick you can have the 6 Expected Fails instead the 19 failures. http://www.reactos.org/bugzilla/show_bug.cgi?id=4533 Vicmarcal _________________________________________________________________ ¡Acelera con la Fórmula 1! Juega y demuestra lo que sabes con MSN Deportes http://msn.es.predictorpro.com/grand-prix/overview.aspx?season=8

1 0

Re: [ros-dev] Silverblade
by Olaf Siejka 25 May '09

25 May '09

Well mate, pity to hear that! As you well know, one cannot simply leave this project! So everyone`s gonna be glad to see you lurking around! Best regards

1 0

Re: [ros-dev] [ros-diffs] [tkreuzer] 41106: MmGrowKernelStack: go back to the ASSERT and add a fixed check
by Alex Ionescu 25 May '09

25 May '09

Sorry for not replying to e-mails about this -- I was on vacation on a cruise. When I'm back to Montreal I'll write a driver to test if this is correct or not -- but definitely this is better. Best regards, Alex Ionescu On Mon, May 25, 2009 at 1:17 AM, <tkreuzer(a)svn.reactos.org> wrote: > Author: tkreuzer > Date: Mon May 25 03:17:48 2009 > New Revision: 41106 > > URL: http://svn.reactos.org/svn/reactos?rev=41106&view=rev > Log: > MmGrowKernelStack: go back to the ASSERT and add a fixed check > > Modified: > trunk/reactos/ntoskrnl/mm/procsup.c > > Modified: trunk/reactos/ntoskrnl/mm/procsup.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/procsup.c?rev=… > ============================================================================== > --- trunk/reactos/ntoskrnl/mm/procsup.c [iso-8859-1] (original) > +++ trunk/reactos/ntoskrnl/mm/procsup.c [iso-8859-1] Mon May 25 03:17:48 2009 > @@ -258,11 +258,15 @@ > { > PETHREAD Thread = PsGetCurrentThread(); > > - /* Make sure we have reserved space for our grow */ > - if (((PCHAR)Thread->Tcb.StackBase - (PCHAR)Thread->Tcb.StackLimit) > > - (KERNEL_LARGE_STACK_SIZE + PAGE_SIZE)) > - { > - return STATUS_NO_MEMORY; > + /* Make sure the stack did not overflow */ > + ASSERT(((PCHAR)Thread->Tcb.StackBase - (PCHAR)Thread->Tcb.StackLimit) <= > + (KERNEL_LARGE_STACK_SIZE + PAGE_SIZE)); > + > + /* Check if we have reserved space for our grow */ > + if ((PCHAR)Thread->Tcb.StackBase - (PCHAR)Thread->Tcb.StackLimit + > + KERNEL_STACK_SIZE > KERNEL_LARGE_STACK_SIZE) > + { > + return STATUS_STACK_OVERFLOW; > } > > /* > >

1 0

Re: [ros-dev] [ros-diffs] [cwittich] 41093: sync RegQueryValueExA, RegQueryValueA, RegQueryValueW and RegSetValueExA to wine patch by Giannis Adamopoulos <johnyadams at hotmail dot com> See issue #4528 for more details.
by Ged 25 May '09

25 May '09

Is this really right? I haven't checked the call chain in Windows, but 'A' functions generally call their 'W' counterpart to do the work. Ged. -----Original Message----- From: ros-diffs-bounces(a)reactos.org [mailto:ros-diffs-bounces@reactos.org] On Behalf Of cwittich(a)svn.reactos.org Sent: 24 May 2009 09:45 To: ros-diffs(a)reactos.org Subject: [ros-diffs] [cwittich] 41093: sync RegQueryValueExA, RegQueryValueA, RegQueryValueW and RegSetValueExA to wine patch by Giannis Adamopoulos <johnyadams at hotmail dot com> See issue #4528 for more details. Author: cwittich Date: Sun May 24 12:45:05 2009 New Revision: 41093 URL: http://svn.reactos.org/svn/reactos?rev=41093&view=rev Log: sync RegQueryValueExA, RegQueryValueA, RegQueryValueW and RegSetValueExA to wine patch by Giannis Adamopoulos <johnyadams at hotmail dot com> See issue #4528 for more details. Modified: trunk/reactos/dll/win32/advapi32/reg/reg.c Modified: trunk/reactos/dll/win32/advapi32/reg/reg.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/advapi32/reg/reg… ============================================================================== --- trunk/reactos/dll/win32/advapi32/reg/reg.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/advapi32/reg/reg.c [iso-8859-1] Sun May 24 12:45:05 2009 @@ -3964,110 +3964,96 @@ * * @implemented */ -LONG WINAPI -RegQueryValueExA(HKEY hKey, - LPCSTR lpValueName, - LPDWORD lpReserved, - LPDWORD lpType, - LPBYTE lpData, - LPDWORD lpcbData) -{ - UNICODE_STRING ValueName; - UNICODE_STRING ValueData; - ANSI_STRING AnsiString; - LONG ErrorCode; - DWORD Length; - DWORD Type; - - TRACE("hKey 0x%X lpValueName %s lpData 0x%X lpcbData %d\n", - hKey, lpValueName, lpData, lpcbData ? *lpcbData : 0); - - if (lpData != NULL && lpcbData == NULL) - { - return ERROR_INVALID_PARAMETER; - } - - if (lpData) - { - ValueData.Length = 0; - ValueData.MaximumLength = (*lpcbData + 1) * sizeof(WCHAR); - ValueData.Buffer = RtlAllocateHeap(ProcessHeap, - 0, - ValueData.MaximumLength); - if (!ValueData.Buffer) - { - return ERROR_OUTOFMEMORY; - } - } - else - { - ValueData.Buffer = NULL; - ValueData.Length = 0; - ValueData.MaximumLength = 0; - - if (lpcbData) - *lpcbData = 0; - } - - RtlCreateUnicodeStringFromAsciiz(&ValueName, - (LPSTR)lpValueName); - - Length = (lpcbData == NULL) ? 0 : *lpcbData * sizeof(WCHAR); - ErrorCode = RegQueryValueExW(hKey, - ValueName.Buffer, - lpReserved, - &Type, - (lpData == NULL) ? NULL : (LPBYTE)ValueData.Buffer, - &Length); - TRACE("ErrorCode %lu\n", ErrorCode); - RtlFreeUnicodeString(&ValueName); - - if (ErrorCode == ERROR_SUCCESS || - ErrorCode == ERROR_MORE_DATA) - { - if (lpType != NULL) - { - *lpType = Type; - } - - if ((Type == REG_SZ) || (Type == REG_MULTI_SZ) || (Type == REG_EXPAND_SZ)) - { - if (ErrorCode == ERROR_SUCCESS && ValueData.Buffer != NULL) +LSTATUS WINAPI RegQueryValueExA( HKEY hkey, LPCSTR name, LPDWORD reserved, LPDWORD type, + LPBYTE data, LPDWORD count ) +{ + NTSTATUS status; + ANSI_STRING nameA; + DWORD total_size, datalen = 0; + char buffer[256], *buf_ptr = buffer; + KEY_VALUE_PARTIAL_INFORMATION *info = (KEY_VALUE_PARTIAL_INFORMATION *)buffer; + static const int info_size = offsetof( KEY_VALUE_PARTIAL_INFORMATION, Data ); + + TRACE("(%p,%s,%p,%p,%p,%p=%d)\n", + hkey, debugstr_a(name), reserved, type, data, count, count ? *count : 0 ); + + if ((data && !count) || reserved) return ERROR_INVALID_PARAMETER; + + status = MapDefaultKey( (PHANDLE)&hkey, hkey); + if (!NT_SUCCESS(status)) + { + return RtlNtStatusToDosError(status); + } + + if (count) datalen = *count; + if (!data && count) *count = 0; + + /* this matches Win9x behaviour - NT sets *type to a random value */ + if (type) *type = REG_NONE; + + RtlInitAnsiString( &nameA, name ); + if ((status = RtlAnsiStringToUnicodeString( &NtCurrentTeb()->StaticUnicodeString, + &nameA, FALSE ))) + return RtlNtStatusToDosError(status); + + status = NtQueryValueKey( hkey, &NtCurrentTeb()->StaticUnicodeString, + KeyValuePartialInformation, buffer, sizeof(buffer), &total_size ); + if (status && status != STATUS_BUFFER_OVERFLOW) goto done; + + /* we need to fetch the contents for a string type even if not requested, + * because we need to compute the length of the ASCII string. */ + if (data || is_string(info->Type)) + { + /* retry with a dynamically allocated buffer */ + while (status == STATUS_BUFFER_OVERFLOW) + { + if (buf_ptr != buffer) HeapFree( GetProcessHeap(), 0, buf_ptr ); + if (!(buf_ptr = HeapAlloc( GetProcessHeap(), 0, total_size ))) { - RtlInitAnsiString(&AnsiString, NULL); - AnsiString.Buffer = (LPSTR)lpData; - AnsiString.MaximumLength = *lpcbData; - ValueData.Length = Length; - ValueData.MaximumLength = ValueData.Length + sizeof(WCHAR); - RtlUnicodeStringToAnsiString(&AnsiString, &ValueData, FALSE); + status = STATUS_NO_MEMORY; + goto done; } - - Length = Length / sizeof(WCHAR); - } - else if (ErrorCode == ERROR_SUCCESS && ValueData.Buffer != NULL) - { - if (*lpcbData < Length) + info = (KEY_VALUE_PARTIAL_INFORMATION *)buf_ptr; + status = NtQueryValueKey( hkey, &NtCurrentTeb()->StaticUnicodeString, + KeyValuePartialInformation, buf_ptr, total_size, &total_size ); + } + + if (status) goto done; + + if (is_string(info->Type)) + { + DWORD len; + + RtlUnicodeToMultiByteSize( &len, (WCHAR *)(buf_ptr + info_size), + total_size - info_size ); + if (data && len) { - ErrorCode = ERROR_MORE_DATA; + if (len > datalen) status = STATUS_BUFFER_OVERFLOW; + else + { + RtlUnicodeToMultiByteN( (char*)data, len, NULL, (WCHAR *)(buf_ptr + info_size), + total_size - info_size ); + /* if the type is REG_SZ and data is not 0-terminated + * and there is enough space in the buffer NT appends a \0 */ + if (len < datalen && data[len-1]) data[len] = 0; + } } - else - { - RtlMoveMemory(lpData, ValueData.Buffer, Length); - } - } - - if (lpcbData != NULL) - { - *lpcbData = Length; - } - } - - if (ValueData.Buffer != NULL) - { - RtlFreeHeap(ProcessHeap, 0, ValueData.Buffer); - } - - return ErrorCode; + total_size = len + info_size; + } + else if (data) + { + if (total_size - info_size > datalen) status = STATUS_BUFFER_OVERFLOW; + else memcpy( data, buf_ptr + info_size, total_size - info_size ); + } + } + else status = STATUS_SUCCESS; + + if (type) *type = info->Type; + if (count) *count = total_size - info_size; + + done: + if (buf_ptr != buffer) HeapFree( GetProcessHeap(), 0, buf_ptr ); + return RtlNtStatusToDosError(status); } @@ -4098,7 +4084,6 @@ (count && data) ? *count : 0 ); if ((data && !count) || reserved) return ERROR_INVALID_PARAMETER; - //if (!(hkey = get_special_root_hkey( hkey ))) return ERROR_INVALID_HANDLE; status = MapDefaultKey(&hkey, hkeyorg); if (!NT_SUCCESS(status)) @@ -4162,93 +4147,27 @@ * * @implemented */ -LONG WINAPI -RegQueryValueA(HKEY hKey, - LPCSTR lpSubKey, - LPSTR lpValue, - PLONG lpcbValue) -{ - WCHAR SubKeyNameBuffer[MAX_PATH+1]; - UNICODE_STRING SubKeyName; - UNICODE_STRING Value; - ANSI_STRING AnsiString; - LONG ValueSize; - LONG ErrorCode; - - TRACE("hKey 0x%X lpSubKey %s lpValue %p lpcbValue %d\n", - hKey, lpSubKey, lpValue, lpcbValue ? *lpcbValue : 0); - - if (lpValue != NULL && - lpcbValue == NULL) - { - return ERROR_INVALID_PARAMETER; - } - - RtlInitUnicodeString(&SubKeyName, - NULL); - RtlInitUnicodeString(&Value, - NULL); - if (lpSubKey != NULL && - strlen(lpSubKey) != 0) - { - RtlInitAnsiString(&AnsiString, - (LPSTR)lpSubKey); - SubKeyName.Buffer = &SubKeyNameBuffer[0]; - SubKeyName.MaximumLength = sizeof(SubKeyNameBuffer); - RtlAnsiStringToUnicodeString(&SubKeyName, - &AnsiString, - FALSE); - } - - if (lpValue != NULL) - { - ValueSize = *lpcbValue * sizeof(WCHAR); - Value.MaximumLength = ValueSize; - Value.Buffer = RtlAllocateHeap(ProcessHeap, - 0, - ValueSize); - if (Value.Buffer == NULL) - { - return ERROR_OUTOFMEMORY; - } - } - else - { - ValueSize = 0; - } - - ErrorCode = RegQueryValueW(hKey, - (LPCWSTR)SubKeyName.Buffer, - Value.Buffer, - &ValueSize); - if (ErrorCode == ERROR_SUCCESS) - { - if (lpValue != NULL) - { - Value.Length = ValueSize; - RtlInitAnsiString(&AnsiString, - NULL); - AnsiString.Buffer = lpValue; - AnsiString.MaximumLength = *lpcbValue; - RtlUnicodeStringToAnsiString(&AnsiString, - &Value, - FALSE); - *lpcbValue = ValueSize; - } - else if (lpcbValue != NULL) - { - *lpcbValue = ValueSize; - } - } - - if (Value.Buffer != NULL) - { - RtlFreeHeap(ProcessHeap, - 0, - Value.Buffer); - } - - return ErrorCode; +LSTATUS WINAPI RegQueryValueA( HKEY hkey, LPCSTR name, LPSTR data, LPLONG count ) +{ + DWORD ret; + HKEY subkey = hkey; + + TRACE("(%p,%s,%p,%d)\n", hkey, debugstr_a(name), data, count ? *count : 0 ); + + if (name && name[0]) + { + if ((ret = RegOpenKeyA( hkey, name, &subkey )) != ERROR_SUCCESS) return ret; + } + ret = RegQueryValueExA( subkey, NULL, NULL, NULL, (LPBYTE)data, (LPDWORD)count ); + if (subkey != hkey) RegCloseKey( subkey ); + if (ret == ERROR_FILE_NOT_FOUND) + { + /* return empty string if default value not found */ + if (data) *data = 0; + if (count) *count = 1; + ret = ERROR_SUCCESS; + } + return ret; } @@ -4257,75 +4176,42 @@ * * @implemented */ -LONG WINAPI -RegQueryValueW(HKEY hKey, - LPCWSTR lpSubKey, - LPWSTR lpValue, - PLONG lpcbValue) -{ - OBJECT_ATTRIBUTES ObjectAttributes; - UNICODE_STRING SubKeyString; - HANDLE KeyHandle; - HANDLE RealKey; - LONG ErrorCode; - BOOL CloseRealKey; - NTSTATUS Status; - - TRACE("hKey 0x%X lpSubKey %S lpValue %p lpcbValue %d\n", - hKey, lpSubKey, lpValue, lpcbValue ? *lpcbValue : 0); - if (hKey == NULL) +LSTATUS WINAPI RegQueryValueW( HKEY hkey, LPCWSTR name, LPWSTR data, LPLONG count ) +{ + DWORD ret; + HKEY subkey = hkey; + + TRACE("(%p,%s,%p,%d)\n", hkey, debugstr_w(name), data, count ? *count : 0 ); + if (hkey == NULL) { return ERROR_INVALID_HANDLE; } - Status = MapDefaultKey(&KeyHandle, - hKey); - if (!NT_SUCCESS(Status)) - { - return RtlNtStatusToDosError(Status); - } - - if (lpSubKey != NULL && - wcslen(lpSubKey) != 0) - { - RtlInitUnicodeString(&SubKeyString, - (LPWSTR)lpSubKey); - InitializeObjectAttributes(&ObjectAttributes, - &SubKeyString, - OBJ_CASE_INSENSITIVE, - KeyHandle, - NULL); - Status = NtOpenKey(&RealKey, - KEY_QUERY_VALUE, - &ObjectAttributes); - if (!NT_SUCCESS(Status)) - { - ErrorCode = RtlNtStatusToDosError(Status); - goto Cleanup; - } - - CloseRealKey = TRUE; - } - else - { - RealKey = hKey; - CloseRealKey = FALSE; - } - - ErrorCode = RegQueryValueExW(RealKey, - NULL, - NULL, - NULL, - (LPBYTE)lpValue, - (LPDWORD)lpcbValue); - if (CloseRealKey) - { - NtClose(RealKey); - } - -Cleanup: - ClosePredefKey(KeyHandle); - - return ErrorCode; + if (name && name[0]) + { + ret = RegOpenKeyW( hkey, name, &subkey); + if (ret != ERROR_SUCCESS) + { + return ret; + } + } + + ret = RegQueryValueExW( subkey, NULL, NULL, NULL, (LPBYTE)data, (LPDWORD)count ); + + if (subkey != hkey) + { + RegCloseKey( subkey ); + } + + if (ret == ERROR_FILE_NOT_FOUND) + { + /* return empty string if default value not found */ + if (data) + *data = 0; + if (count) + *count = sizeof(WCHAR); + ret = ERROR_SUCCESS; + } + return ret; } @@ -4806,86 +4692,43 @@ * * @implemented */ -LONG WINAPI -RegSetValueExA(HKEY hKey, - LPCSTR lpValueName, - DWORD Reserved, - DWORD dwType, - CONST BYTE* lpData, - DWORD cbData) -{ - UNICODE_STRING ValueName; - LPWSTR pValueName; - ANSI_STRING AnsiString; - UNICODE_STRING Data; - LONG ErrorCode; - LPBYTE pData; - DWORD DataSize; - - if (lpValueName != NULL && - strlen(lpValueName) != 0) - { - RtlCreateUnicodeStringFromAsciiz(&ValueName, - (PSTR)lpValueName); - } - else - { - ValueName.Buffer = NULL; - } - - pValueName = (LPWSTR)ValueName.Buffer; - - if (((dwType == REG_SZ) || - (dwType == REG_MULTI_SZ) || - (dwType == REG_EXPAND_SZ)) && - (cbData != 0)) - { - /* NT adds one if the caller forgot the NULL-termination character */ - if (lpData[cbData - 1] != '\0') - { - cbData++; - } - - RtlInitAnsiString(&AnsiString, - NULL); - AnsiString.Buffer = (PSTR)lpData; - AnsiString.Length = cbData - 1; - AnsiString.MaximumLength = cbData; - RtlAnsiStringToUnicodeString(&Data, - &AnsiString, - TRUE); - pData = (LPBYTE)Data.Buffer; - DataSize = cbData * sizeof(WCHAR); - } - else - { - RtlInitUnicodeString(&Data, - NULL); - pData = (LPBYTE)lpData; - DataSize = cbData; - } - - ErrorCode = RegSetValueExW(hKey, - pValueName, - Reserved, - dwType, - pData, - DataSize); - if (pValueName != NULL) - { - RtlFreeHeap(ProcessHeap, - 0, - ValueName.Buffer); - } - - if (Data.Buffer != NULL) - { - RtlFreeHeap(ProcessHeap, - 0, - Data.Buffer); - } - - return ErrorCode; +LSTATUS WINAPI RegSetValueExA( HKEY hkey, LPCSTR name, DWORD reserved, DWORD type, + CONST BYTE *data, DWORD count ) +{ + ANSI_STRING nameA; + WCHAR *dataW = NULL; + NTSTATUS status; + + if (count && is_string(type)) + { + /* if user forgot to count terminating null, add it (yes NT does this) */ + if (data[count-1] && !data[count]) count++; + } + + status = MapDefaultKey( (PHANDLE)&hkey, hkey); + if (!NT_SUCCESS(status)) + { + return RtlNtStatusToDosError(status); + } + + if (is_string( type )) /* need to convert to Unicode */ + { + DWORD lenW; + RtlMultiByteToUnicodeSize( &lenW, (const char *)data, count ); + if (!(dataW = HeapAlloc( GetProcessHeap(), 0, lenW ))) return ERROR_OUTOFMEMORY; + RtlMultiByteToUnicodeN( dataW, lenW, NULL, (const char *)data, count ); + count = lenW; + data = (BYTE *)dataW; + } + + RtlInitAnsiString( &nameA, name ); + if (!(status = RtlAnsiStringToUnicodeString( &NtCurrentTeb()->StaticUnicodeString, + &nameA, FALSE ))) + { + status = NtSetValueKey( hkey, &NtCurrentTeb()->StaticUnicodeString, 0, type, (PVOID)data, count ); + } + HeapFree( GetProcessHeap(), 0, dataW ); + return RtlNtStatusToDosError( status ); }

3 4

Re: [ros-dev] [ros-diffs] [cgutman] 41090: - MajorFunction has IRP_MJ_MAXIMUM_FUNCTION positions - Sorry for so many commits on the same function
by Alex Ionescu 24 May '09

24 May '09

May I ask, why not use simple C for this?: DriverBlock->DriverObject->MajorFunction = MajorFunctions; Or if that doesn't work, use a casting trick... Best regards, Alex Ionescu On Sun, May 24, 2009 at 2:49 AM, <cgutman(a)svn.reactos.org> wrote: > Author: cgutman > Date: Sun May 24 04:49:02 2009 > New Revision: 41090 > > URL: http://svn.reactos.org/svn/reactos?rev=41090&view=rev > Log: > - MajorFunction has IRP_MJ_MAXIMUM_FUNCTION positions > - Sorry for so many commits on the same function > > Modified: > trunk/reactos/drivers/network/ndis/ndis/miniport.c > > Modified: trunk/reactos/drivers/network/ndis/ndis/miniport.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/network/ndis/ndis/… > ============================================================================== > --- trunk/reactos/drivers/network/ndis/ndis/miniport.c [iso-8859-1] (original) > +++ trunk/reactos/drivers/network/ndis/ndis/miniport.c [iso-8859-1] Sun May 24 04:49:02 2009 > @@ -2788,7 +2788,7 @@ > return NDIS_STATUS_RESOURCES; > } > > - for (i = 0; i < IRP_MJ_MAXIMUM_FUNCTION; i++) > + for (i = 0; i <= IRP_MJ_MAXIMUM_FUNCTION; i++) > DriverBlock->DriverObject->MajorFunction[i] = MajorFunctions[i]; > > DriverBlock->DriverObject->MajorFunction[IRP_MJ_PNP] = NdisIDispatchPnp; > >

2 1

Re: [ros-dev] [ros-diffs] [cwittich] 41096: fix secur32 main winetest crash by returning 0 packages in EmumSecurityPackagesA/W
by Timo Kreuzer 24 May '09

24 May '09

What is the reason we don't sync wine's secur32? Thanks, Timo cwittich(a)svn.reactos.org schrieb: > Author: cwittich > Date: Sun May 24 13:40:15 2009 > New Revision: 41096 > > URL: http://svn.reactos.org/svn/reactos?rev=41096&view=rev > Log: > fix secur32 main winetest crash by returning 0 packages in EmumSecurityPackagesA/W > > Modified: > trunk/reactos/dll/win32/secur32/sspi.c > >

1 0

I have left ReactOS
by Andrew Greenwood 23 May '09

23 May '09

Hi, This mail is a little bit late as I didn't find time to write it earlier. Basically, I've decided that I do not want to continue working on ReactOS. I just don't find it "fun" or interesting to do any more. I spent months trying to get my head around Kernel Streaming and its associated components, how they fit together let alone how they actually function. And really, it's not enjoyable. I don't fully understand Windows kernel-mode coding, and coding the sound system really isn't as straightforward a task as I had originally anticipated. It has become more of a chore over time. Considering I made the switch from Windows to Linux around 2005 and have rarely actually needed to use Windows at home since then, there doesn't seem to be any benefit for me to put my time into working on ReactOS. Also I never really seemed to get very far with sound... I see Janderwald has taken up the challenge on this and is making good progress on it. I had been considering leaving a few months ago, but stuck around for our gathering in Brussels, which was great (aside from the restaurant which seemed like it was going to cook its customers, and the overly-smiley waiter who didn't fully explain what "special sauce" contained...) To be honest I think putting the hybrid CD together for that to be my best and also most hacky achievement for ReactOS. Starflow produced all the fliers/badges/etc. and I think altogether, FOSDEM was a success. And I hope it sparked interest for other people to join the project. I intend on working on some of my own projects from this point on (possibly audio related still...) All the best for the future, Andrew Greenwood

7 7

[ros-diffs] [dchapyshev] 41068: - Sync comctl32 with Wine 1.1.22 (without listview.c. Somebody help to sync listview! Now after sync listview there is a bug: http://opendn.org/listview.png)
by James Tabor 23 May '09

23 May '09

Hi all! What is missing with this? Do we need to fix User32? Did we not sync user32 controls? Edit, Combo, etc...? Thanks, James

1 0

Re: [ros-dev] [ros-diffs] [tkreuzer] 41046: #if out an unused static funtion. Don't know if it's still useful. Ged?
by Ged 23 May '09

23 May '09

I have the code to complete this functionality locally, I just haven't committed it yet as it's not tested. Thanks for the conflict :-P -----Original Message----- From: ros-diffs-bounces(a)reactos.org [mailto:ros-diffs-bounces@reactos.org] On Behalf Of tkreuzer(a)svn.reactos.org Sent: 22 May 2009 23:18 To: ros-diffs(a)reactos.org Subject: [ros-diffs] [tkreuzer] 41046: #if out an unused static funtion. Don't know if it's still useful. Ged? Author: tkreuzer Date: Sat May 23 02:17:55 2009 New Revision: 41046 URL: http://svn.reactos.org/svn/reactos?rev=41046&view=rev Log: #if out an unused static funtion. Don't know if it's still useful. Ged? Modified: branches/ros-amd64-bringup/reactos/base/applications/mscutils/servman/propsheet_depends.c Modified: branches/ros-amd64-bringup/reactos/base/applications/mscutils/servman/propsheet_depends.c URL: http://svn.reactos.org/svn/reactos/branches/ros-amd64-bringup/reactos/base/… ============================================================================== --- branches/ros-amd64-bringup/reactos/base/applications/mscutils/servman/propsheet_depends.c [iso-8859-1] (original) +++ branches/ros-amd64-bringup/reactos/base/applications/mscutils/servman/propsheet_depends.c [iso-8859-1] Sat May 23 02:17:55 2009 @@ -50,6 +50,7 @@ return TreeView_InsertItem(hTreeView, &tvins); } +#if 0 // FIXME: What is this good for? static VOID AddServiceDependency(PSERVICEPROPSHEET dlgInfo, HWND hTreeView, @@ -123,6 +124,7 @@ } } +#endif static VOID AddServiceDependent(HWND hTreeView,

2 1

Re: [ros-dev] [ros-diffs] [dchapyshev] 41042: - Formatting fix. No code change
by Aleksey Bragin 23 May '09

23 May '09

I hope you asked James and Timo, who may have uncommitted patches to this file (which would fail to apply now). WBR, Aleksey Bragin. On May 22, 2009, at 4:50 PM, dchapyshev(a)svn.reactos.org wrote: > Author: dchapyshev > Date: Fri May 22 16:50:31 2009 > New Revision: 41042 > > URL: http://svn.reactos.org/svn/reactos?rev=41042&view=rev > Log: > - Formatting fix. No code change > > Modified: > trunk/reactos/subsystems/win32/win32k/ntuser/hook.c >

3 2

Network source code
by Timo Kreuzer 22 May '09

22 May '09

2 1

Re: [ros-dev] [ros-diffs] [sedwards] 40919: imported the MT snapshot of the GPL tftp-server for win32 from sourceforge. Minor changes such as formatting and renaming the files, totally untested except for building, will be used later to serve up Reac
by Steven Edwards 20 May '09

20 May '09

On Thu, May 14, 2009 at 2:52 PM, KJK::Hyperion <hackbunny(a)reactos.org> wrote: > Ged wrote: >> Another unix like addition? >> Do we really need this and the previous telnet server in our source? > > to be fair, Windows does provide a command line TFTP client/server. So > far, I've only seen it used for malware spreading, but it's there and we > should provide one too Where I work we use dhcpd/tftp and PXEboot on both Linux and Windows to do automagical deployment services. The end goal with all of this is a ReactOS deployment system from a single image that can provision ReactOS thinkclients/diskless workstations without the need of a Linux or Windows host. Pushing out a freeldr or grub+freeldr or even pxelinux+grub+freeldr image with a blob containing a ROS ramdisk should be pretty simple using isc-dhcpd/tftp on Linux but I'm more interested in the infrastructure side of things right now. Currently the dhcpd with PXE support is the only part we are really missing. We COULD do it from Linux or Windows right now, but I want to get all the infrastructure in place where we don't need any other OS. Thanks -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

10 16

Re: [ros-dev] runtime time function question in freeldr
by Zhang Fan 20 May '09

20 May '09

Thank you for your answer. But I'm still perplexd. pushl %eax //at that time ,%eax=0? so BootMain will receive NULL parameter? call _BootMain --- On Wed, 5/20/09, pay7n(a)o2.pl <pay7n(a)o2.pl> wrote: > From: pay7n(a)o2.pl <pay7n(a)o2.pl> > Subject: Re: [ros-dev] runtime time function question in freeldr > To: "ReactOS Development List" <ros-dev(a)reactos.org> > Date: Wednesday, May 20, 2009, 3:18 AM > This is not an Intel syntax. > Operands in memory operations have inverted order: > > mov src, dest > > not > > mov dest, src > > thus eax == 0 > > > Zhang Fan pisze: > > Hi everybody, > > I'm a newbie of ReactOS, and I've just looked a piece > of code in freeldr module. I found some runtime function > such as strstr(). I want to know if the run time lib should > be initialized, and where the initialized code. > > Another question is that a piece of code in arch.S > > > > > > EXTERN(RealEntryPoint) > > > > //.... > > .code32 > > > > /* Zero BootDrive and BootPartition > */ > > xorl %eax,%eax > > movl > %eax,(_BootDrive) > > movl > %eax,(_BootPartition) > > > > /* Store the boot drive */ > > movb > %dl,(_BootDrive) > > > > /* Store the boot partition */ > > movb > %dh,(_BootPartition) > > > > /* GO! */ > > pushl %eax > > call _BootMain > > > > At there, I think %eax should equal zero, and BootMain > will call CmdLineParse(),and CmdLineParse will call > strstr(). So it cause strstr will receive a NULL parameter. > Is it right? > > > > Thank you. > > > > Fan Zhang > > > > > > > > > > _______________________________________________ > > Ros-dev mailing list > > Ros-dev(a)reactos.org > > http://www.reactos.org/mailman/listinfo/ros-dev > > > > _______________________________________________ > Ros-dev mailing list > Ros-dev(a)reactos.org > http://www.reactos.org/mailman/listinfo/ros-dev >

1 0

runtime time function question in freeldr
by Zhang Fan 19 May '09

19 May '09

Hi everybody, I'm a newbie of ReactOS, and I've just looked a piece of code in freeldr module. I found some runtime function such as strstr(). I want to know if the run time lib should be initialized, and where the initialized code. Another question is that a piece of code in arch.S EXTERN(RealEntryPoint) //.... .code32 /* Zero BootDrive and BootPartition */ xorl %eax,%eax movl %eax,(_BootDrive) movl %eax,(_BootPartition) /* Store the boot drive */ movb %dl,(_BootDrive) /* Store the boot partition */ movb %dh,(_BootPartition) /* GO! */ pushl %eax call _BootMain At there, I think %eax should equal zero, and BootMain will call CmdLineParse(),and CmdLineParse will call strstr(). So it cause strstr will receive a NULL parameter. Is it right? Thank you. Fan Zhang

2 1

Re: [ros-dev] [ros-diffs] [tkreuzer] 40963: MmGrowKernelStack: Don't assert, but fail, when the kernel stack can't grow any more. Fixes a crash with recursive user calls. See issue #4060 for more details.
by Alex Ionescu 19 May '09

19 May '09

The code SHOULD assert. This is a hack. Best regards, Alex Ionescu On Sun, May 17, 2009 at 11:51 PM, <tkreuzer(a)svn.reactos.org> wrote: > Author: tkreuzer > Date: Mon May 18 01:51:31 2009 > New Revision: 40963 > > URL: http://svn.reactos.org/svn/reactos?rev=40963&view=rev > Log: > MmGrowKernelStack: Don't assert, but fail, when the kernel stack can't grow > any more. Fixes a crash with recursive user calls. > See issue #4060 for more details. > > Modified: > trunk/reactos/ntoskrnl/mm/procsup.c > > Modified: trunk/reactos/ntoskrnl/mm/procsup.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/procsup.c?rev=… > > ============================================================================== > --- trunk/reactos/ntoskrnl/mm/procsup.c [iso-8859-1] (original) > +++ trunk/reactos/ntoskrnl/mm/procsup.c [iso-8859-1] Mon May 18 01:51:31 > 2009 > @@ -259,8 +259,11 @@ > PETHREAD Thread = PsGetCurrentThread(); > > /* Make sure we have reserved space for our grow */ > - ASSERT(((PCHAR)Thread->Tcb.StackBase - (PCHAR)Thread->Tcb.StackLimit) > <= > - (KERNEL_LARGE_STACK_SIZE + PAGE_SIZE)); > + if (((PCHAR)Thread->Tcb.StackBase - (PCHAR)Thread->Tcb.StackLimit) > > + (KERNEL_LARGE_STACK_SIZE + PAGE_SIZE)) > + { > + return STATUS_NO_MEMORY; > + } > > /* > * We'll give you three more pages. > >

5 6

Re: [ros-dev] [ros-diffs] [janderwald] 40967: - Play default logon sound when logging on - Due to unknown issues, this only works at the 2nd login ATM
by Ged 18 May '09

18 May '09

This shouldn't be in here. I can't tell you where it should be as I've never looked, but it's not userinit's responsibility to play logon music. -----Original Message----- From: ros-diffs-bounces(a)reactos.org [mailto:ros-diffs-bounces@reactos.org] On Behalf Of janderwald(a)svn.reactos.org Sent: 18 May 2009 16:41 To: ros-diffs(a)reactos.org Subject: [ros-diffs] [janderwald] 40967: - Play default logon sound when logging on - Due to unknown issues, this only works at the 2nd login ATM Author: janderwald Date: Mon May 18 19:41:00 2009 New Revision: 40967 URL: http://svn.reactos.org/svn/reactos?rev=40967&view=rev Log: - Play default logon sound when logging on - Due to unknown issues, this only works at the 2nd login ATM Modified: trunk/reactos/base/system/userinit/userinit.c Modified: trunk/reactos/base/system/userinit/userinit.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/system/userinit/useri… ============================================================================== --- trunk/reactos/base/system/userinit/userinit.c [iso-8859-1] (original) +++ trunk/reactos/base/system/userinit/userinit.c [iso-8859-1] Mon May 18 19:41:00 2009 @@ -591,6 +591,51 @@ WARN("RegOpenKeyEx() failed with error %lu\n", rc); } +static VOID +PlayLogonSound() +{ + HKEY hKey; + WCHAR szBuffer[MAX_PATH] = {0}; + WCHAR szDest[MAX_PATH]; + DWORD dwSize = sizeof(szBuffer); + HMODULE hLibrary; + typedef BOOL WINAPI (*PLAYSOUNDW)(LPCWSTR,HMODULE,DWORD); + PLAYSOUNDW Play; + + if (RegOpenKeyExW(HKEY_CURRENT_USER, L"AppEvents\\Schemes\\Apps\\.Default\\WindowsLogon\\.Current", 0, KEY_READ, &hKey) != ERROR_SUCCESS) + { + return; + } + + if (RegQueryValueExW(hKey, NULL, NULL, NULL, (LPBYTE)szBuffer, &dwSize) != ERROR_SUCCESS) + { + RegCloseKey(hKey); + return; + } + + + RegCloseKey(hKey); + + if (!szBuffer[0]) + return; + + + szBuffer[MAX_PATH-1] = L'\0'; + if (ExpandEnvironmentStringsW(szBuffer, szDest, MAX_PATH)) + { + hLibrary = LoadLibraryW(L"winmm.dll"); + if (hLibrary) + { + Play = (PLAYSOUNDW)GetProcAddress(hLibrary, "PlaySoundW"); + if (Play) + { + Play(szDest, NULL, SND_FILENAME); + } + FreeLibrary(hLibrary); + } + } +} + static VOID SetUserSettings(VOID) { @@ -640,6 +685,7 @@ SetUserSettings(); StartShell(); NotifyLogon(); + PlayLogonSound(); return 0; }

1 0

I want to develop the kernel of ReactOS, how do i join????
by Joshua Bailey 18 May '09

18 May '09

Hello mailing list folks! While Xiaoming wouldn't be able to have commit access, would he be able to contribute in other ways not related to coding, i.e., hardware or software testing? Just curious. Mr. Ionescu, I probably would have tried to tell Xiaoming what I know about the rules, too, even though I'm not a developer. Actually, the FAQ is pretty clear in regards to ReactOS only using clean-room reverse engineering. http://www.reactos.org/en/about_userfaq.html. I would have just referred him to this, if you or another developer hadn't jumped in to give a more precise answer. I usually leave it up to the devs to answer questions, but I try to answer questions if I can when no developer is at hand at the moment. I hope that doesn't mean I have a drug problem. :) To be honest, I was pretty confused myself about who could do what if they had seen Windows source code beforehand. I know the current position is that seeing source code != no ReactOS programming for you, but then again there was the whole debate a few years back about whether the devs at the top had seen any Windows source code and I'm still not sure how that got resolved. I had alternately heard that people who had seen source code couldn't contribute, or if they had they could only code stuff whose Windows equivalents they hadn't seen the source code to, so it's not something that was just made up. I'm not trying to restart old flame wars, but the fact is that the policy regarding Windows source code hasn't always been so clear, which may have left some people (myself included) confused. While I personally wouldn't have replied assuming the same level of authority as a developer, I don't think us ordinary folks should be blamed if we've gotten a little confused about this througout the course of the past few years. I don't mean to start off here on a bad note, but I get irritated because on the forums someone asks a simple question, someone answers, the devs get angry because they feel someone overstepped their authority, even thought the devs tend to give a terse answer with no explanation. The newbie scared of asking anything else about the project because folks get so angry with one another, and figures it's not worth the trouble of getting involved. By the way, if the formatting here looks like it was written by a crackhead, it's because this is my first time posting on the mailing list. (I'm more active on the forums.) Then again, my hometown inspired The Wire, so who knows. :P -Joshua Bailey

3 2

Re: [ros-dev] [ros-diffs] [fireball] 40961: - Initialize IoCountOperations variable to FALSE by default. Spotted by Dmitry Chapyshev & winetests.
by Alex Ionescu 18 May '09

18 May '09

Um, there's a serious compiler/linker/loader bug if that value is not already FALSE by default. Best regards, Alex Ionescu On Sun, May 17, 2009 at 6:46 PM, <fireball(a)svn.reactos.org> wrote: > Author: fireball > Date: Sun May 17 20:46:58 2009 > New Revision: 40961 > > URL: http://svn.reactos.org/svn/reactos?rev=40961&view=rev > Log: > - Initialize IoCountOperations variable to FALSE by default. Spotted by > Dmitry Chapyshev & winetests. > > Modified: > trunk/reactos/ntoskrnl/io/iomgr/iomgr.c > > Modified: trunk/reactos/ntoskrnl/io/iomgr/iomgr.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/io/iomgr/iomgr.c?… > > ============================================================================== > --- trunk/reactos/ntoskrnl/io/iomgr/iomgr.c [iso-8859-1] (original) > +++ trunk/reactos/ntoskrnl/io/iomgr/iomgr.c [iso-8859-1] Sun May 17 > 20:46:58 2009 > @@ -31,7 +31,7 @@ > POBJECT_TYPE IoFileObjectType = NULL; > extern POBJECT_TYPE IoControllerObjectType; > extern UNICODE_STRING NtSystemRoot; > -BOOLEAN IoCountOperations; > +BOOLEAN IoCountOperations = FALSE; > ULONG IoReadOperationCount = 0; > LARGE_INTEGER IoReadTransferCount = {{0, 0}}; > ULONG IoWriteOperationCount = 0; > >

2 1

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev