Ros-dev

ros-dev@reactos.org

5790 discussions

Re: [ros-dev] [ros-diffs] [jimtabor] 60683: [Win32ss] - Prevent a potential kernel exception.
by Alex Ionescu 16 Oct '13

16 Oct '13

Jim, this and your other patch can never happen. It's ListEntry that can be NULL, but Property will never be (in fact, it will be negative number). Also, ListEntry should never be NULL anyway, otherwise it means the list head is corrupted. Containing record is just math...not a dereference. -- Best regards, Alex Ionescu -----Original Message----- From: ros-diffs-bounces(a)reactos.org [mailto:ros-diffs-bounces@reactos.org] On Behalf Of jimtabor(a)svn.reactos.org Sent: Tuesday, October 15, 2013 3:17 PM To: ros-diffs(a)reactos.org Subject: [ros-diffs] [jimtabor] 60683: [Win32ss] - Prevent a potential kernel exception. Author: jimtabor Date: Tue Oct 15 22:16:31 2013 New Revision: 60683 URL: http://svn.reactos.org/svn/reactos?rev=60683&view=rev Log: [Win32ss] - Prevent a potential kernel exception. Modified: trunk/reactos/win32ss/user/ntuser/prop.c Modified: trunk/reactos/win32ss/user/ntuser/prop.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/user/ntuser/prop.c… ============================================================================== --- trunk/reactos/win32ss/user/ntuser/prop.c [iso-8859-1] (original) +++ trunk/reactos/win32ss/user/ntuser/prop.c [iso-8859-1] Tue Oct 15 22:16:31 2013 @@ -21,6 +21,7 @@ while (ListEntry != &Window->PropListHead) { Property = CONTAINING_RECORD(ListEntry, PROPERTY, PropListEntry); + if (!Property) break; if (Property->Atom == Atom) { return(Property);

1 0

Re: [ros-dev] [ros-diffs] [jimtabor] 60682: [Win32ss] - Prevent a potential kernel exception.
by Thomas Faber 16 Oct '13

16 Oct '13

On 2013-10-16 00:14, jimtabor(a)svn.reactos.org wrote: > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/user/user32/window… > ============================================================================== > --- trunk/reactos/win32ss/user/user32/windows/prop.c [iso-8859-1] (original) > +++ trunk/reactos/win32ss/user/user32/windows/prop.c [iso-8859-1] Tue Oct 15 22:14:48 2013 > @@ -53,6 +53,7 @@ > for (i = 0; i < pWnd->PropListItems; i++ ) > { > Property = CONTAINING_RECORD(ListEntry, PROPERTY, PropListEntry); > + if (!Property) break; > if (Property->Atom == Atom) > { > return(Property); > > That can't happen unless the list is corrupt. And even if the list contains a null pointer (which it's not supposed to), ListEntry would be NULL, not Property.

2 1

Re: [ros-dev] reactos.org is down
by Ameer Ali 16 Oct '13

16 Oct '13

Sorry Sent from my Windows Phone From: Aleksey Bragin Sent: 14-10-2013 PM 02:41 To: ReactOS Development List Subject: Re: [ros-dev] reactos.org is down Z, don't take that too seriously ;-) Regards, Aleksey Bragin On 14.10.2013 7:12, Zachary Gorden wrote: > Please refrain from making demands of a non-profit, volunteer driven > project. It's impolite bordering towards insulting to the people > working on the project. > > On Sun, Oct 13, 2013 at 7:45 PM, Ameer Ali <ameerali.ma(a)gmail.com> wrote: >> Again its happening....pls don't repeat.. >> >> Sent from my Windows Phone >> ________________________________ >> From: Pierre Schweitzer >> Sent: 14-10-2013 AM 02:58 >> To: ros-dev(a)reactos.org >> Subject: Re: [ros-dev] reactos.org is down >> >> We're back online. >> >> On 13/10/2013 22:51, Pierre Schweitzer wrote: >> >> The faulty server is being replaced at the moment. >> >> On 13/10/2013 19:52, Pierre Schweitzer wrote: >> >> Hi, >> >> this is known issue (which has been handled 13 minutes after it >> happened - just for the record ;-)). Unfortunately, so far, it is not >> going very well. >> >> This affects: www.reactos.org, jira.reactos.org, dev.reactos.org, >> code.reactos.org, ns1.reactos.org (use NS2 for the moment). >> >> We're sorry for the caused inconvenience. >> >> With my best regards, >> Pierre >> >> On 13/10/2013 18:20, ????????? wrote: >> >> reactos.org is down >> -- >> ? ?????????? ???????????, ?????????. >> _______________________________________________ Ros-dev mailing list Ros-dev(a)reactos.org http://www.reactos.org/mailman/listinfo/ros-dev

1 0

Re: [ros-dev] [ros-diffs] [hbelusca] 60678: [USETUP] - Fix translations of booloader installation menu (see rev.48703). ACHTUNG ACHTUNG!! Greek and Spanish people, please review the translation fix and provide patches if ne...
by Timo Kreuzer 16 Oct '13

16 Oct '13

Am 15.10.2013 18:45, schrieb hbelusca(a)svn.reactos.org: > ACHTUNG ACHTUNG!! Greek and Spanish people, ... Wrong language ;-)

3 3

Re: [ros-dev] Branches status & cleanup
by Ameer Ali 14 Oct '13

14 Oct '13

Good work buddies... Sent from my Windows Phone From: Aleksey Bragin Sent: 09-10-2013 PM 06:37 To: ReactOS Development List Subject: Re: [ros-dev] Branches status & cleanup If he starts from the latter, then he would have more than enough money to fund all ReactOS development and buy Microsoft Corp. :D Regards, Aleksey On 09.10.2013 16:55, Hermès BÉLUSCA - MAÏTO wrote: > Tip: order your priorities !! > > -----Message d'origine----- > De : ros-dev-bounces(a)reactos.org [mailto:ros-dev-bounces@reactos.org] De la > part de Timo Kreuzer > Envoyé : mercredi 9 octobre 2013 11:08 > À : ReactOS Development List > Objet : Re: [ros-dev] Branches status & cleanup > > Am 09.10.2013 10:18, schrieb Thomas Faber: >> On 2013-10-07 23:03, Aleksey Bragin wrote: >>> GSoC_2011 >>> Five subbranches. What's their status? Were they all merged? >> - Claudiu's and mine are fully merged. >> - According to SVN I took the explorer_new fixes from Andrew's into >> trunk last year ... I'll recheck whether that was everything. >> - Timo's is unmerged and has some unmet dependencies IIRC. >> - Giannis merged most or all of his, but he should know best if there's >> anything useful in there still. > Please keep my GSoC branch, it contains code for the font engine rewrite, > which is still WIP and I plan to continue on it after the DIB rewrite branch > is finished. (And after I fixed PSEH3, implemented PSEH for C++ and CLANG, > fixed a dozen Jira issues, rewrote Mm and Cc and found a cure for cancer.) > _______________________________________________ Ros-dev mailing list Ros-dev(a)reactos.org http://www.reactos.org/mailman/listinfo/ros-dev

2 1

Re: [ros-dev] reactos.org is down
by Ameer Ali 14 Oct '13

14 Oct '13

Again its happening....pls don't repeat.. Sent from my Windows Phone ------------------------------ From: Pierre Schweitzer Sent: 14-10-2013 AM 02:58 To: ros-dev(a)reactos.org Subject: Re: [ros-dev] reactos.org is down We're back online. On 13/10/2013 22:51, Pierre Schweitzer wrote: The faulty server is being replaced at the moment. On 13/10/2013 19:52, Pierre Schweitzer wrote: Hi, this is known issue (which has been handled 13 minutes after it happened - just for the record ;-)). Unfortunately, so far, it is not going very well. This affects: www.reactos.org, jira.reactos.org, dev.reactos.org,code.reactos.org, ns1.reactos.org (use NS2 for the moment). We're sorry for the caused inconvenience. With my best regards, Pierre On 13/10/2013 18:20, ????????? wrote: reactos.org is down -- ? ?????????? ???????????, ?????????. _______________________________________________ Ros-dev mailing listRos-dev@reactos.orghttp://www.reactos.org/mailman/listinfo/ros-dev _______________________________________________ Ros-dev mailing listRos-dev@reactos.orghttp://www.reactos.org/mailman/listinfo/ros-dev _______________________________________________ Ros-dev mailing listRos-dev@reactos.orghttp://www.reactos.org/mailman/listinfo/ros-dev -- Pierre Schweitzer<pierre at reactos.org> System Administrator ReactOS Foundation

3 2

reactos.org is down
by Александр 13 Oct '13

13 Oct '13

2 3

Branches status & cleanup
by Aleksey Bragin 09 Oct '13

09 Oct '13

Hello! I would like to inject more life into our branches and hence need to remove as much dead bodies from that area as possible. And I need your feedback! Please comment on that list. like - needs to be merged, useless, could be deleted. aicom-hardware-fun "Branch for my hardware support work and other stuff". Last commit 17th of May, 2010. Bring back Cromwell as a temporary USB stack until mjmartin finishes the new one, Implement missing storage stack drivers (storport, ataport, etc), Work more on the PnP manager. Obsolete? aicom-network-branch Last commit was 4th of August, 2011. Another branch for networking fixes. "If someone wants to delete aicom-network-fixes, they are welcome to" alex-network-branch Last commit was 24th of December, 2006. Some parts are still not merged. What a shame! arty-newcc New CC implementation by arty. It stays. arty-stable Arty - do you need it? No problem in keeping it, if you need it. arwinss Aleksey - do you need it? Yes I do!! :-) audio-bringup Johannes? Last commit 26 of April, 2011. c++-bringup Very promising name and just one commit by jgardou, 8th of March, 2012. Jerome? cmake-bringup I think we switched to CMake already. Any reason to keep this branch? dib_rewrite Timo's great work. GSoC_2011 Five subbranches. What's their status? Were they all merged? icu4ros-bringup Empty branch. Amine, would you comment whether it's necessary? iut-mmc Pierre? jcatena-branch MSVC work. Needed? kd++ By Hermes. I think, it's needed. lean-explorer Lean explorer by Martin Fuchs. Last touched in 2006. nocc Special "nocc" cache manager. It stays. nslookup I guess lsuggs gave up on that. But the idea was nice. ntvdm We all know [TheFlash]. Stable progress. Good work. nyadav-audio-branch Last commit dates to year 2011. Nyadav? olpc One awesome Laptop Per one awesome Child. We can keep it a bit more for historical reasons. pierre-fsd Pierre's presumably great work. reactx GreatLord's work on DirectX. Status unknown. Sylvain? ros-amd64-bringup Timo - is it still relevant, or did you already merge it in trunk? ros-csrss Last commit says "Ready for merging (TM) :)". ORLY? :-) shell32_new-bringup Mr. Mihail, you around? Anyone knows state of that work? sspi-bringup Samuel? What's with that branch? tcp-rewrite-branch LWIP. I think it's integrated into trunk long time ago? Last commit - year 2010 the-real-msvc KJK's work which stopped in 2008. Anyone could comment whether there is anything we haven't achieved with CMake yet? Tree-restructure-test Playground for restructuring the tree. "Let's reshuflle the files and directories and that makes our OS more stable and usable". Last commit was almost exactly 3 years ago. usb-bringup-trunk Johannes? Still need that? vs_jc jjones? Do you plan to continue working on that? wlan-bringup Cameron, how's it going?

7 11

Re: [ros-dev] Branches status & cleanup
by Hermès BÉLUSCA - MAÏTO 08 Oct '13

08 Oct '13

And the problems that were present at that time (rbuild to cmake migration etc...) are solved now... H. -----Message d'origine----- De : ros-dev-bounces(a)reactos.org [mailto:ros-dev-bounces@reactos.org] De la part de Ged Murphy Envoyé : mardi 8 octobre 2013 19:38 À : 'ReactOS Development List' Objet : Re: [ros-dev] Branches status & cleanup Yes! This is such an obvious improvement, I'm surprised it's still not widely accepted. An epic mail from Timo explaining the current tree layout https://www.reactos.org/archives/public/ros-dev/2010-July/013278.html For anyone still interested in reading our rants, here's the start of the original mailing list convo https://www.reactos.org/archives/public/ros-dev/2010-July/013257.html -----Original Message----- From: ros-dev-bounces(a)reactos.org [mailto:ros-dev-bounces@reactos.org] On Behalf Of Hermès BÉLUSCA - MAÏTO Sent: 08 October 2013 17:47 To: 'ReactOS Development List' Subject: [SPAM]Re: [ros-dev] Branches status & cleanup > Tree-restructure-test > Playground for restructuring the tree. "Let's reshuflle the files and directories and that makes our OS more stable and usable". Last commit was almost exactly 3 years ago. I'm personally very interested in this thing (cf. http://www.reactos.org/forum/viewtopic.php?p=102258&sid=ef8d6c9a27f9e3800b7d ff87afdc5919 and OF COURSE http://www.reactos.org/wiki/Techwiki:File_Layout ) which aims at bringing modularity. Cheers, Hermès. _______________________________________________ Ros-dev mailing list Ros-dev(a)reactos.org http://www.reactos.org/mailman/listinfo/ros-dev

1 0

Re: [ros-dev] [ros-diffs] [aandrejevic] 60485: [SOFT386] Change the license of Soft386 to GPLv2. The previous license was also GPLv2, but it had a runtime linking exception. The new license is the original GPLv2 with no exc...
by Aleksey Bragin 03 Oct '13

03 Oct '13

You are implementing part of ReactOS so you can't just silently relicense your code in one commit to a license which is incompatible with ReactOS aims and goals. At the very least, I would appreciate a discussion with our team regarding this before doing such commits. Please revert. The runtime linking exception was added for a reason, not for amusement or RMS trolling. RMS is unhappy either way (not that I care about his opinion :). Regards, Aleksey Bragin On 01.10.2013 2:01, aandrejevic(a)svn.reactos.org wrote: > Author: aandrejevic > Date: Mon Sep 30 22:01:38 2013 > New Revision: 60485 > > URL: http://svn.reactos.org/svn/reactos?rev=60485&view=rev > Log: > [SOFT386] > Change the license of Soft386 to GPLv2. The previous license was also > GPLv2, but it had a runtime linking exception. The new license is the > original GPLv2 with no exceptions. > > > Added: > branches/ntvdm/lib/soft386/COPYING (with props) > Modified: > branches/ntvdm/lib/soft386/common.c > branches/ntvdm/lib/soft386/common.h > branches/ntvdm/lib/soft386/common.inl > branches/ntvdm/lib/soft386/opcodes.c > branches/ntvdm/lib/soft386/opcodes.h > branches/ntvdm/lib/soft386/opgroups.c > branches/ntvdm/lib/soft386/opgroups.h > branches/ntvdm/lib/soft386/soft386.c >

5 4

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev