Ros-dev

ros-dev@reactos.org

5788 discussions

Re: [ros-dev] [ros-diffs] [ekohl] 59013: [LSASRV] - LsapCheckLogonProcess: Open client process using the PROCESS_DUP_HANDLE access right because we need to duplicate the logon token back into the clients handle table.

by Thomas Faber

On 2013-05-13 15:05, ekohl(a)svn.reactos.org wrote: > Status = NtReplyWaitReceivePort(AuthPortHandle, > (PVOID*)&LogonContext, > - &ReplyMsg->h, > - &RequestMsg.h); > + (PPORT_MESSAGE)ReplyMsg, > + (PPORT_MESSAGE)&RequestMsg); As the Guy Who Officially Hates Casts™, I have to ask: wasn't the previous version better for type safety? With the cast, an additional [or missing] & can slip in and the code will compile without complaint. Best, Thomas

11 years, 8 months

Re: [ros-dev] [ros-diffs] [hbelusca] 58971: [FREELDR] - Fix dprints (be careful when "Status" variables are booleans). - Don't fail when trying to load an non-existent KD transport dll.

by Timo Kreuzer

I suggest NEVER to use Status as the name for anything other than NTSTATUS variables. Otherwise problems are almost preprogrammed (seen this multiple times). It Should be called Result or something. This is one of those cases where hungarian notation really makes a difference, Colin. ;-) Am 08.05.2013 19:52, schrieb hbelusca(a)svn.reactos.org: > Author: hbelusca > Date: Wed May 8 17:52:16 2013 > New Revision: 58971 > > URL: http://svn.reactos.org/svn/reactos?rev=58971&view=rev > Log: > [FREELDR] > - Fix dprints (be careful when "Status" variables are booleans). > - Don't fail when trying to load an non-existent KD transport dll. > > Modified: > branches/kd++/boot/freeldr/freeldr/disk/scsiport.c > branches/kd++/boot/freeldr/freeldr/windows/peloader.c > branches/kd++/boot/freeldr/freeldr/windows/winldr.c > > Modified: branches/kd++/boot/freeldr/freeldr/disk/scsiport.c > URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/boot/freeldr/freeldr/d… > ============================================================================== > --- branches/kd++/boot/freeldr/freeldr/disk/scsiport.c [iso-8859-1] (original) > +++ branches/kd++/boot/freeldr/freeldr/disk/scsiport.c [iso-8859-1] Wed May 8 17:52:16 2013 > @@ -1568,7 +1568,7 @@ > ULONG ImportTableSize; > PLDR_DATA_TABLE_ENTRY BootDdDTE, FreeldrDTE; > CHAR NtBootDdPath[MAX_PATH]; > - PVOID ImageBase; > + PVOID ImageBase = NULL; > ULONG (NTAPI *EntryPoint)(IN PVOID DriverObject, IN PVOID RegistryPath); > BOOLEAN Status; > > > Modified: branches/kd++/boot/freeldr/freeldr/windows/peloader.c > URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/boot/freeldr/freeldr/w… > ============================================================================== > --- branches/kd++/boot/freeldr/freeldr/windows/peloader.c [iso-8859-1] (original) > +++ branches/kd++/boot/freeldr/freeldr/windows/peloader.c [iso-8859-1] Wed May 8 17:52:16 2013 > @@ -255,11 +255,12 @@ > return TRUE; > } > > -/* WinLdrLoadImage loads the specified image from the file (it doesn't > - perform any additional operations on the filename, just directly > - calls the file I/O routines), and relocates it so that it's ready > - to be used when paging is enabled. > - Addressing mode: physical > +/* > + * WinLdrLoadImage loads the specified image from the file (it doesn't > + * perform any additional operations on the filename, just directly > + * calls the file I/O routines), and relocates it so that it's ready > + * to be used when paging is enabled. > + * Addressing mode: physical > */ > BOOLEAN > WinLdrLoadImage(IN PCHAR FileName, > @@ -429,7 +430,6 @@ > /* If loading failed - return right now */ > if (Status != ESUCCESS) > return FALSE; > - > > /* Relocate the image, if it needs it */ > if (NtHeaders->OptionalHeader.ImageBase != (ULONG_PTR)VirtualBase) > @@ -756,7 +756,7 @@ > { > CHAR FullDllName[256]; > BOOLEAN Status; > - PVOID BasePA; > + PVOID BasePA = NULL; > > /* Prepare the full path to the file to be loaded */ > strcpy(FullDllName, DirectoryPath); > @@ -781,7 +781,7 @@ > DataTableEntry); > if (!Status) > { > - ERR("WinLdrAllocateDataTableEntry() failed with Status=0x%X\n", Status); > + ERR("WinLdrAllocateDataTableEntry() failed\n"); > return Status; > } > > @@ -791,7 +791,7 @@ > Status = WinLdrScanImportDescriptorTable(ModuleListHead, DirectoryPath, *DataTableEntry); > if (!Status) > { > - ERR("WinLdrScanImportDescriptorTable() failed with Status=0x%X\n", Status); > + ERR("WinLdrScanImportDescriptorTable() failed\n"); > return Status; > } > > > Modified: branches/kd++/boot/freeldr/freeldr/windows/winldr.c > URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/boot/freeldr/freeldr/w… > ============================================================================== > --- branches/kd++/boot/freeldr/freeldr/windows/winldr.c [iso-8859-1] (original) > +++ branches/kd++/boot/freeldr/freeldr/windows/winldr.c [iso-8859-1] Wed May 8 17:52:16 2013 > @@ -237,7 +237,7 @@ > CHAR DllName[1024]; > PCHAR DriverNamePos; > BOOLEAN Status; > - PVOID DriverBase; > + PVOID DriverBase = NULL; > > // Separate the path to file name and directory path > _snprintf(DriverPath, sizeof(DriverPath), "%wZ", FilePath); > @@ -258,7 +258,6 @@ > } > > TRACE("DriverPath: %s, DllName: %s, LPB\n", DriverPath, DllName); > - > > // Check if driver is already loaded > Status = WinLdrCheckForLoadedDll(LoadOrderListHead, DllName, DriverDTE); > @@ -424,7 +423,7 @@ > } > > static > -PVOID > +BOOLEAN > LoadModule( > PLOADER_PARAMETER_BLOCK LoaderBlock, > PCCH Path, > @@ -434,10 +433,10 @@ > BOOLEAN IsKdTransportDll, > ULONG Percentage) > { > + BOOLEAN Status; > CHAR FullFileName[MAX_PATH]; > CHAR ProgressString[256]; > - NTSTATUS Status; > - PVOID BaseAdress; > + PVOID BaseAdress = NULL; > > UiDrawBackdrop(); > sprintf(ProgressString, "Loading %s...", File); > @@ -448,8 +447,12 @@ > strcat(FullFileName, File); > > Status = WinLdrLoadImage(FullFileName, MemoryType, &BaseAdress); > - TRACE("%s loaded with status %d at %p\n", > - File, Status, BaseAdress); > + if (!Status) > + { > + TRACE("Loading %s failed\n", File); > + return FALSE; > + } > + TRACE("%s loaded successfully at %p\n", File, BaseAdress); > > strcpy(FullFileName, "WINDOWS\\SYSTEM32\\"); > strcat(FullFileName, File); > @@ -458,13 +461,13 @@ > * the Kernel Debugger Transport DLL, to make the > * PE loader happy. > */ > - WinLdrAllocateDataTableEntry(&LoaderBlock->LoadOrderListHead, > - (IsKdTransportDll ? "KDCOM.DLL" : File), > - FullFileName, > - BaseAdress, > - Dte); > - > - return BaseAdress; > + Status = WinLdrAllocateDataTableEntry(&LoaderBlock->LoadOrderListHead, > + (IsKdTransportDll ? "KDCOM.DLL" : File), > + FullFileName, > + BaseAdress, > + Dte); > + > + return Status; > } > > static > @@ -679,11 +682,11 @@ > UiDrawBackdrop(); > UiDrawProgressBarCenter(15, 100, "Loading system hive..."); > Status = WinLdrInitSystemHive(LoaderBlock, BootPath); > - TRACE("SYSTEM hive loaded with status %d\n", Status); > + TRACE("SYSTEM hive %s\n", (Status ? "loaded" : "not loaded")); > > /* Load NLS data, OEM font, and prepare boot drivers list */ > Status = WinLdrScanSystemHive(LoaderBlock, BootPath); > - TRACE("SYSTEM hive scanned with status %d\n", Status); > + TRACE("SYSTEM hive %s\n", (Status ? "scanned" : "not scanned")); > > /* Finish loading */ > LoadAndBootWindowsCommon(OperatingSystemVersion, > > >

11 years, 8 months

Re: [ros-dev] [ros-diffs] [pschweitzer] 58960: [RTL] Finally reenable RtlAcquirePrivilege

by Jérôme Gardou

Hey Pierre! Nice patch series, that takes ReactOS nearer to being secure. A remark though : > /* > - * enable the SeSystemtimePrivilege privilege > + * Call SetLocalTime twice to ensure correct results > */ > + Ret = SetLocalTime(&SetupData->SystemTime) && > + SetLocalTime(&SetupData->SystemTime); This is a bit confusing, and the comment doesn't really help. Why would calling the function twice ansure correct result ? Also, this is likely to be optimized away by the compiler, or at least produce a report in static code analysers. I know this isn't pure chance. Any hint as to why you wrote it like this ? Cheers Jérôme

11 years, 8 months

getdate.exe being pulled from SVN repository

by J. C. Jones

Small nit-pick: .\reactos\reactos\tools\getdate.exe is being pulled from SVN even though it is being generated by getdate.cmd and getdate.c that are both in the same directory? -John

11 years, 8 months

Planned services downtime

by Pierre Schweitzer

Hi, on the 3rd of May, from 1PM to 6PM CET, the following services will down due to a power maintenance: -> ISO upload -> ISO download -> Doxygen -> cppcheck -> Linux buildbot -> KVM testbot -> VMware testbot I warmly recommend you don't commit during that period then, as remaining builder, Windows one, won't be able to upload its ISOs. Actually, I could also take the opportunity of such downtime to take SVN (svn, git, buildbot master) server down for maintenance as it will barely harm. I'll keep you informed. I'll push reminders before it happens. Sorry for the services interruption. With my best regards, -- Pierre Schweitzer<pierre at reactos.org> System Administrator ReactOS Foundation

11 years, 8 months

reactos.inf

by Stefan Naumann

Hello. I am the guy writing an updater for ReactOS. Recent tests show some difficulties and errors in data from reactos bootcds; mainly reactos.inf: My program reads reactos.inf, puts the filepaths together and copies files to the specified positions in folder-tree (I'm talking about the server's side). It seems that reactos.inf contains pretty weird data; opening reactos.inf with gedit shows it intact; reading it with the program gets the following things out (shortened): " -- 6 -->cache/files/��" should be "cache/files/inf" (with cache/files" beeing the path of all cached files, unpacked from bootcd-ISO. and (in the same context): " -- 5 = system32\drivers\etc -- 6 = inf -- 7 = bin -- �Í = bin\data -- 9 = media -- 10 = Microsoft.NET " ("--" comes from debug-function of my iniparser). Is this intended to be as is or not? Could someone please fix that or let me know whether I should think about doing something differently. I'm working and testing with Xubuntu 13.04 amd64 - always getting latest dbg-BootCD-ISO. Thanks peope. Regards Stefan Naumann

11 years, 8 months

Re: [ros-dev] [ros-diffs] [hbelusca] 58902: [FREELDR] - Fix some function parameter types, so to avoid unuseful casts (from pointers to const strings to pointers to strings in particular). - The big thing: make FreeLdr load...

by Timo Kreuzer

I'm not a fan of single line conditional statements. I'd prefer if we had a style rule for that. Any thoughts on that? Am 01.05.2013 19:12, schrieb hbelusca(a)svn.reactos.org: > Author: hbelusca > Date: Wed May 1 17:12:56 2013 > New Revision: 58902 > do > { > - while (*LoadOptions == '/') > - ++LoadOptions; > - > + while (*LoadOptions == '/') ++LoadOptions; > *NewLoadOptions++ = *LoadOptions; > } while (*LoadOptions++); > >

11 years, 8 months

Status Meeting (April 2013)

by Aleksey Bragin

Hello, Let me invite you to the monthly status meeting taking place last Thursday of this month, 25th of April, 19:00 UTC. The meeting will be at irc://dev.reactos.org (Port 6667, no SSL) in the channel #meeting, or as Pierre says. Note that the IRC service will only be started shortly before the meeting. Your participation passwords will be emailed to you shortly before the meeting starts, and they are going to be different once again as they are not stored in any database. Hopefully it's not much of inconvenience. If someone still is not getting passwords sent before a meeting - please email Colin or Pierre before the meeting started to get one. The agenda will be posted shortly before the meeting, suggestions are welcome (send them to my email as usual). Regards, Aleksey Bragin

11 years, 8 months

Re: [ros-dev] [ros-diffs] [hbelusca] 58824: [KDCOM] - Use the UCHAR type directly instead

by Jérôme Gardou

Hey Hermès ! > + > +long atol(const char *str); > + Shouldn't this belong to some standard header ? Cheers Jérôme

11 years, 8 months

5 days unlimited trial of PVS-studio

by Александр

11 years, 9 months

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev