Ros-dev

ros-dev@reactos.org

5788 discussions

Re: [ros-dev] [ros-general] Services downtime

by Colin Finck

Hi all, Pierre Schweitzer <pierre(a)reactos.org> wrote: > due to a hardware migration ongoing on one of our hypervisors, the > following services are currently down: The server upgrade went successfully and everything is back to normal now. Cheers, Colin

11 years, 10 months

Server upgrade next Friday

by Colin Finck

Hi all, Several ReactOS services will be moved to a new server next Friday. As this migration highly depends on our hosting provider, the downtime may be up to 24 hours. Affected services include: - ns1.reactos.org - playground.reactos.org - jira.reactos.org The upgrade will improve reliability and adds resources for additional services in the future. Of course, you will be informed once the migration is over. Cheers, Colin

11 years, 10 months

Re: [ros-dev] [ros-diffs] [hbelusca] 57701: [CSRSRV] - Use a variable ServerDll instead of using each time CsrLoadedServerDll[i], as it is done in some other places. - Clean the code (remove extra-parentheses). - Zero-out t...

by Alex Ionescu

Would you mind not "cleaning up formatting" by going against our coding style and doing the very thing I even taught you not to do during your initial patches/code reviews? Thanks. Best regards, Alex Ionescu On Tue, Nov 13, 2012 at 1:08 PM, <hbelusca(a)svn.reactos.org> wrote: > - if ((ServerDll) && (ServerDll->HardErrorCallback)) > + if (ServerDll && ServerDll->HardErrorCallback) >

11 years, 10 months

Re: [ros-dev] [ros-diffs] [pschweitzer] 57674: [DOXYGEN] ReactOS is not C only. Enable support builtin STL.

by Timo Kreuzer

We have 90 % C. So disabling OPTIMIZE_OUTPUT_FOR_C will probably result in worse readable output for 90% of the code. Am 05.11.2012 12:14, schrieb pschweitzer(a)svn.reactos.org: > Author: pschweitzer > Date: Mon Nov 5 11:13:59 2012 > New Revision: 57674 > > URL: http://svn.reactos.org/svn/reactos?rev=57674&view=rev > Log: > [DOXYGEN] > ReactOS is not C only. > Enable support builtin STL. > > Modified: > trunk/reactos/Doxyfile > > Modified: trunk/reactos/Doxyfile > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/Doxyfile?rev=57674&r1=5767… > ============================================================================== > --- trunk/reactos/Doxyfile [iso-8859-1] (original) > +++ trunk/reactos/Doxyfile [iso-8859-1] Mon Nov 5 11:13:59 2012 > @@ -196,7 +196,7 @@ > # For instance, some of the names that are used will be different. The list > # of all members will be omitted, etc. > > -OPTIMIZE_OUTPUT_FOR_C = YES > +OPTIMIZE_OUTPUT_FOR_C = NO > > # Set the OPTIMIZE_OUTPUT_JAVA tag to YES if your project consists of Java > # sources only. Doxygen will then generate output that is more tailored for > @@ -236,7 +236,7 @@ > # func(std::string) {}). This also make the inheritance and collaboration > # diagrams that involve STL classes more complete and accurate. > > -BUILTIN_STL_SUPPORT = NO > +BUILTIN_STL_SUPPORT = YES > > # If you use Microsoft's C++/CLI language, you should set this option to YES to > # enable parsing support. > > >

11 years, 10 months

[ros-diffs] [jgardou] 57679: [USER32] - Avoid more rounding issues and hopefully fix MSC build

by James Tabor

Hi, BE AWARE this is port synced from wine and please notate changes so it will not get lost on the next sync! James

11 years, 10 months

Meeting rescheduled!

by Aleksey Bragin

Hello, the meeting is rescheduled to 1st of November, as I don't see a point to do a meeting if zwabbit, caemyr and other can not attend. 1st of November will also be thursday, just one week late. Sorry for inconvenience. And it's time for agenda proposals already, please send them in to my email address as usual. Thanks. Best regards, Aleksey Bragin.

11 years, 10 months

Re: [ros-dev] [ros-diffs] [hbelusca] 57526: [BOOTDATA-CMAKE] Add a bin\data directory for holding data files which can be used for tests.

by Hermès BÉLUSCA - MAÏTO

OK, I didn't know that ! I will revert this modification as soon as possible. Regards, Hermès BÉLUSCA - MAÏTO -----Message d'origine----- De : ros-dev-bounces(a)reactos.org [mailto:ros-dev-bounces@reactos.org] De la part de Sylvain Petreolle Envoyé : mercredi 10 octobre 2012 18:10 À : ReactOS Development List Objet : Re: [ros-dev] [ros-diffs] [hbelusca] 57526: [BOOTDATA-CMAKE] Add a bin\data directory for holding data files which can be used for tests. +1. You don't need to add the directory in PATH even if the helper is into bin\data. Kind regards, Sylvain Petreolle ----- Mail original ----- > De : Timo Kreuzer <timo.kreuzer(a)web.de> À : ros-dev(a)reactos.org Cc : > Envoyé le : Mercredi 10 octobre 2012 9h52 Objet : Re: [ros-dev] > [ros-diffs] [hbelusca] 57526: [BOOTDATA-CMAKE] Add a bin\data directory for holding data files which can be used for tests. > > > Why is it in the PATH variable? > Why not just put the test data in the bin folder? > > Am 10.10.2012 00:00, schrieb hbelusca(a)svn.reactos.org: >> Author: hbelusca >> Date: Tue Oct 9 22:00:47 2012 >> New Revision: 57526 >> >> URL: http://svn.reactos.org/svn/reactos?rev=57526&view=rev >> Log: >> [BOOTDATA-CMAKE] >> Add a bin\data directory for holding data files which can be used >> for > tests. >> >> Modified: >> trunk/reactos/boot/bootdata/hivesys_amd64.inf >> trunk/reactos/boot/bootdata/hivesys_arm.inf >> trunk/reactos/boot/bootdata/hivesys_i386.inf >> trunk/reactos/boot/bootdata/packages/reactos.dff.in >> trunk/reactos/cmake/CMakeMacros.cmake >> >> Modified: trunk/reactos/boot/bootdata/hivesys_amd64.inf >> URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/boot/bootdata/hivesys > _amd64.inf?rev=57526&r1=57525&r2=57526&view=diff >> > ====================================================================== > ======== >> --- trunk/reactos/boot/bootdata/hivesys_amd64.inf [iso-8859-1] >> (original) +++ trunk/reactos/boot/bootdata/hivesys_amd64.inf >> [iso-8859-1] Tue Oct 9 > 22:00:47 2012 >> @@ -1200,7 +1200,7 @@ >> ; System environment settings >> HKLM,"SYSTEM\CurrentControlSet\Control\Session > Manager\Environment","ComSpec",0x00020000,"%SystemRoot%\system32\cmd.exe" >> -HKLM,"SYSTEM\CurrentControlSet\Control\Session > Manager\Environment","Path",0x00020000,"%SystemRoot%\bin;%SystemRoot%\system 32;%SystemRoot%;%SystemRoot%\system32\wbem" >> +HKLM,"SYSTEM\CurrentControlSet\Control\Session > Manager\Environment","Path",0x00020000,"%SystemRoot%\bin;%SystemRoot%\bin\da ta;%SystemRoot%\system32;%SystemRoot%;%SystemRoot%\system32\wbem" >> HKLM,"SYSTEM\CurrentControlSet\Control\Session > Manager\Environment","windir",0x00020000,"%SystemRoot%" >> HKLM,"SYSTEM\CurrentControlSet\Control\Session > Manager\Environment","TEMP",0x00020000,"%SystemDrive%\TEMP" >> HKLM,"SYSTEM\CurrentControlSet\Control\Session > Manager\Environment","TMP",0x00020000,"%SystemDrive%\TEMP" >> >> Modified: trunk/reactos/boot/bootdata/hivesys_arm.inf >> URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/boot/bootdata/hivesys > _arm.inf?rev=57526&r1=57525&r2=57526&view=diff >> > ====================================================================== > ======== >> --- trunk/reactos/boot/bootdata/hivesys_arm.inf [iso-8859-1] >> (original) +++ trunk/reactos/boot/bootdata/hivesys_arm.inf >> [iso-8859-1] Tue Oct 9 > 22:00:47 2012 >> @@ -755,7 +755,7 @@ >> ; System environment settings >> HKLM,"SYSTEM\CurrentControlSet\Control\Session > Manager\Environment","ComSpec",0x00020000,"%SystemRoot%\system32\cmd.exe" >> -HKLM,"SYSTEM\CurrentControlSet\Control\Session > Manager\Environment","Path",0x00020000,"%SystemRoot%\bin;%SystemRoot%\system 32;%SystemRoot%;%SystemRoot%\system32\wbem" >> +HKLM,"SYSTEM\CurrentControlSet\Control\Session > Manager\Environment","Path",0x00020000,"%SystemRoot%\bin;%SystemRoot%\bin\da ta;%SystemRoot%\system32;%SystemRoot%;%SystemRoot%\system32\wbem" >> HKLM,"SYSTEM\CurrentControlSet\Control\Session > Manager\Environment","windir",0x00020000,"%SystemRoot%" >> HKLM,"SYSTEM\CurrentControlSet\Control\Session > Manager\Environment","TEMP",0x00020000,"%SystemDrive%\TEMP" >> HKLM,"SYSTEM\CurrentControlSet\Control\Session > Manager\Environment","TMP",0x00020000,"%SystemDrive%\TEMP" >> >> Modified: trunk/reactos/boot/bootdata/hivesys_i386.inf >> URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/boot/bootdata/hivesys > _i386.inf?rev=57526&r1=57525&r2=57526&view=diff >> > ====================================================================== > ======== >> --- trunk/reactos/boot/bootdata/hivesys_i386.inf [iso-8859-1] >> (original) +++ trunk/reactos/boot/bootdata/hivesys_i386.inf >> [iso-8859-1] Tue Oct 9 > 22:00:47 2012 >> @@ -1200,7 +1200,7 @@ >> ; System environment settings >> HKLM,"SYSTEM\CurrentControlSet\Control\Session > Manager\Environment","ComSpec",0x00020000,"%SystemRoot%\system32\cmd.exe" >> -HKLM,"SYSTEM\CurrentControlSet\Control\Session > Manager\Environment","Path",0x00020000,"%SystemRoot%\bin;%SystemRoot%\system 32;%SystemRoot%;%SystemRoot%\system32\wbem" >> +HKLM,"SYSTEM\CurrentControlSet\Control\Session > Manager\Environment","Path",0x00020000,"%SystemRoot%\bin;%SystemRoot%\bin\da ta;%SystemRoot%\system32;%SystemRoot%;%SystemRoot%\system32\wbem" >> HKLM,"SYSTEM\CurrentControlSet\Control\Session > Manager\Environment","windir",0x00020000,"%SystemRoot%" >> HKLM,"SYSTEM\CurrentControlSet\Control\Session > Manager\Environment","TEMP",0x00020000,"%SystemDrive%\TEMP" >> HKLM,"SYSTEM\CurrentControlSet\Control\Session > Manager\Environment","TMP",0x00020000,"%SystemDrive%\TEMP" >> >> Modified: trunk/reactos/boot/bootdata/packages/reactos.dff.in >> URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/boot/bootdata/package > s/reactos.dff.in?rev=57526&r1=57525&r2=57526&view=diff >> > ====================================================================== > ======== >> --- trunk/reactos/boot/bootdata/packages/reactos.dff.in [iso-8859-1] > (original) >> +++ trunk/reactos/boot/bootdata/packages/reactos.dff.in [iso-8859-1] >> Tue > Oct 9 22:00:47 2012 >> @@ -21,12 +21,13 @@ >> 5 = system32\drivers\etc >> 6 = inf >> 7 = bin >> -8 = media >> -9 = Microsoft.NET >> -10 = Microsoft.NET\Framework >> -11 = Microsoft.NET\Framework\v1.0.3705 >> -12 = Microsoft.NET\Framework\v1.1.4322 >> -13 = Microsoft.NET\Framework\v2.0.50727 >> +8 = bin\data >> +9 = media >> +10 = Microsoft.NET >> +11 = Microsoft.NET\Framework >> +12 = Microsoft.NET\Framework\v1.0.3705 >> +13 = Microsoft.NET\Framework\v1.1.4322 >> +14 = Microsoft.NET\Framework\v2.0.50727 >> .InfEnd >> @@ -59,4 +60,4 @@ >> modules\optional\wine_gecko-1.0.0-x86.cab 4 optional >> boot\bootdata\bootcdregtest\AHKAppTests.cmd 7 > optional >> -modules\wallpaper\Angelus_02_ROSWP.bmp > 4 optional >> +modules\wallpaper\Angelus_02_ROSWP.bmp 4 optional >> >> Modified: trunk/reactos/cmake/CMakeMacros.cmake >> URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/cmake/CMakeMacros.cma > ke?rev=57526&r1=57525&r2=57526&view=diff >> > ====================================================================== > ======== >> --- trunk/reactos/cmake/CMakeMacros.cmake [iso-8859-1] (original) >> +++ trunk/reactos/cmake/CMakeMacros.cmake [iso-8859-1] Tue Oct 9 >> 22:00:47 > 2012 >> @@ -97,18 +97,20 @@ >> set(${var} 6) >> elseif(${dir} STREQUAL reactos/bin) >> set(${var} 7) >> + elseif(${dir} STREQUAL reactos/bin/data) + set(${var} >> 8) >> elseif(${dir} STREQUAL reactos/media) >> - set(${var} 8) >> + set(${var} 9) >> elseif(${dir} STREQUAL reactos/Microsoft.NET) >> - set(${var} 9) >> + set(${var} 10) >> elseif(${dir} STREQUAL reactos/Microsoft.NET/Framework) >> - set(${var} 10) >> + set(${var} 11) >> elseif(${dir} STREQUAL >> reactos/Microsoft.NET/Framework/v1.0.3705) >> - set(${var} 11) >> + set(${var} 12) >> elseif(${dir} STREQUAL >> reactos/Microsoft.NET/Framework/v1.1.4322) >> - set(${var} 12) >> + set(${var} 13) >> elseif(${dir} STREQUAL >> reactos/Microsoft.NET/Framework/v2.0.50727) >> - set(${var} 13) >> + set(${var} 14) >> else() >> message(ERROR "Wrong destination: ${dir}") >> endif() >> >> >> > > > _______________________________________________ > Ros-dev mailing list > Ros-dev(a)reactos.org > http://www.reactos.org/mailman/listinfo/ros-dev > _______________________________________________ Ros-dev mailing list Ros-dev(a)reactos.org http://www.reactos.org/mailman/listinfo/ros-dev

11 years, 11 months

Re: [ros-dev] [ros-diffs] [hbelusca] 57526: [BOOTDATA-CMAKE] Add a bin\data directory for holding data files which can be used for tests.

by Timo Kreuzer

Why is it in the PATH variable? Why not just put the test data in the bin folder? Am 10.10.2012 00:00, schrieb hbelusca(a)svn.reactos.org: > Author: hbelusca > Date: Tue Oct 9 22:00:47 2012 > New Revision: 57526 > > URL: http://svn.reactos.org/svn/reactos?rev=57526&view=rev > Log: > [BOOTDATA-CMAKE] > Add a bin\data directory for holding data files which can be used for tests. > > Modified: > trunk/reactos/boot/bootdata/hivesys_amd64.inf > trunk/reactos/boot/bootdata/hivesys_arm.inf > trunk/reactos/boot/bootdata/hivesys_i386.inf > trunk/reactos/boot/bootdata/packages/reactos.dff.in > trunk/reactos/cmake/CMakeMacros.cmake > > Modified: trunk/reactos/boot/bootdata/hivesys_amd64.inf > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/bootdata/hivesys_amd6… > ============================================================================== > --- trunk/reactos/boot/bootdata/hivesys_amd64.inf [iso-8859-1] (original) > +++ trunk/reactos/boot/bootdata/hivesys_amd64.inf [iso-8859-1] Tue Oct 9 22:00:47 2012 > @@ -1200,7 +1200,7 @@ > > ; System environment settings > HKLM,"SYSTEM\CurrentControlSet\Control\Session Manager\Environment","ComSpec",0x00020000,"%SystemRoot%\system32\cmd.exe" > -HKLM,"SYSTEM\CurrentControlSet\Control\Session Manager\Environment","Path",0x00020000,"%SystemRoot%\bin;%SystemRoot%\system32;%SystemRoot%;%SystemRoot%\system32\wbem" > +HKLM,"SYSTEM\CurrentControlSet\Control\Session Manager\Environment","Path",0x00020000,"%SystemRoot%\bin;%SystemRoot%\bin\data;%SystemRoot%\system32;%SystemRoot%;%SystemRoot%\system32\wbem" > HKLM,"SYSTEM\CurrentControlSet\Control\Session Manager\Environment","windir",0x00020000,"%SystemRoot%" > HKLM,"SYSTEM\CurrentControlSet\Control\Session Manager\Environment","TEMP",0x00020000,"%SystemDrive%\TEMP" > HKLM,"SYSTEM\CurrentControlSet\Control\Session Manager\Environment","TMP",0x00020000,"%SystemDrive%\TEMP" > > Modified: trunk/reactos/boot/bootdata/hivesys_arm.inf > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/bootdata/hivesys_arm.… > ============================================================================== > --- trunk/reactos/boot/bootdata/hivesys_arm.inf [iso-8859-1] (original) > +++ trunk/reactos/boot/bootdata/hivesys_arm.inf [iso-8859-1] Tue Oct 9 22:00:47 2012 > @@ -755,7 +755,7 @@ > > ; System environment settings > HKLM,"SYSTEM\CurrentControlSet\Control\Session Manager\Environment","ComSpec",0x00020000,"%SystemRoot%\system32\cmd.exe" > -HKLM,"SYSTEM\CurrentControlSet\Control\Session Manager\Environment","Path",0x00020000,"%SystemRoot%\bin;%SystemRoot%\system32;%SystemRoot%;%SystemRoot%\system32\wbem" > +HKLM,"SYSTEM\CurrentControlSet\Control\Session Manager\Environment","Path",0x00020000,"%SystemRoot%\bin;%SystemRoot%\bin\data;%SystemRoot%\system32;%SystemRoot%;%SystemRoot%\system32\wbem" > HKLM,"SYSTEM\CurrentControlSet\Control\Session Manager\Environment","windir",0x00020000,"%SystemRoot%" > HKLM,"SYSTEM\CurrentControlSet\Control\Session Manager\Environment","TEMP",0x00020000,"%SystemDrive%\TEMP" > HKLM,"SYSTEM\CurrentControlSet\Control\Session Manager\Environment","TMP",0x00020000,"%SystemDrive%\TEMP" > > Modified: trunk/reactos/boot/bootdata/hivesys_i386.inf > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/bootdata/hivesys_i386… > ============================================================================== > --- trunk/reactos/boot/bootdata/hivesys_i386.inf [iso-8859-1] (original) > +++ trunk/reactos/boot/bootdata/hivesys_i386.inf [iso-8859-1] Tue Oct 9 22:00:47 2012 > @@ -1200,7 +1200,7 @@ > > ; System environment settings > HKLM,"SYSTEM\CurrentControlSet\Control\Session Manager\Environment","ComSpec",0x00020000,"%SystemRoot%\system32\cmd.exe" > -HKLM,"SYSTEM\CurrentControlSet\Control\Session Manager\Environment","Path",0x00020000,"%SystemRoot%\bin;%SystemRoot%\system32;%SystemRoot%;%SystemRoot%\system32\wbem" > +HKLM,"SYSTEM\CurrentControlSet\Control\Session Manager\Environment","Path",0x00020000,"%SystemRoot%\bin;%SystemRoot%\bin\data;%SystemRoot%\system32;%SystemRoot%;%SystemRoot%\system32\wbem" > HKLM,"SYSTEM\CurrentControlSet\Control\Session Manager\Environment","windir",0x00020000,"%SystemRoot%" > HKLM,"SYSTEM\CurrentControlSet\Control\Session Manager\Environment","TEMP",0x00020000,"%SystemDrive%\TEMP" > HKLM,"SYSTEM\CurrentControlSet\Control\Session Manager\Environment","TMP",0x00020000,"%SystemDrive%\TEMP" > > Modified: trunk/reactos/boot/bootdata/packages/reactos.dff.in > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/bootdata/packages/rea… > ============================================================================== > --- trunk/reactos/boot/bootdata/packages/reactos.dff.in [iso-8859-1] (original) > +++ trunk/reactos/boot/bootdata/packages/reactos.dff.in [iso-8859-1] Tue Oct 9 22:00:47 2012 > @@ -21,12 +21,13 @@ > 5 = system32\drivers\etc > 6 = inf > 7 = bin > -8 = media > -9 = Microsoft.NET > -10 = Microsoft.NET\Framework > -11 = Microsoft.NET\Framework\v1.0.3705 > -12 = Microsoft.NET\Framework\v1.1.4322 > -13 = Microsoft.NET\Framework\v2.0.50727 > +8 = bin\data > +9 = media > +10 = Microsoft.NET > +11 = Microsoft.NET\Framework > +12 = Microsoft.NET\Framework\v1.0.3705 > +13 = Microsoft.NET\Framework\v1.1.4322 > +14 = Microsoft.NET\Framework\v2.0.50727 > > .InfEnd > > @@ -59,4 +60,4 @@ > modules\optional\wine_gecko-1.0.0-x86.cab 4 optional > boot\bootdata\bootcdregtest\AHKAppTests.cmd 7 optional > > -modules\wallpaper\Angelus_02_ROSWP.bmp 4 optional > +modules\wallpaper\Angelus_02_ROSWP.bmp 4 optional > > Modified: trunk/reactos/cmake/CMakeMacros.cmake > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/cmake/CMakeMacros.cmake?re… > ============================================================================== > --- trunk/reactos/cmake/CMakeMacros.cmake [iso-8859-1] (original) > +++ trunk/reactos/cmake/CMakeMacros.cmake [iso-8859-1] Tue Oct 9 22:00:47 2012 > @@ -97,18 +97,20 @@ > set(${var} 6) > elseif(${dir} STREQUAL reactos/bin) > set(${var} 7) > + elseif(${dir} STREQUAL reactos/bin/data) > + set(${var} 8) > elseif(${dir} STREQUAL reactos/media) > - set(${var} 8) > + set(${var} 9) > elseif(${dir} STREQUAL reactos/Microsoft.NET) > - set(${var} 9) > + set(${var} 10) > elseif(${dir} STREQUAL reactos/Microsoft.NET/Framework) > - set(${var} 10) > + set(${var} 11) > elseif(${dir} STREQUAL reactos/Microsoft.NET/Framework/v1.0.3705) > - set(${var} 11) > + set(${var} 12) > elseif(${dir} STREQUAL reactos/Microsoft.NET/Framework/v1.1.4322) > - set(${var} 12) > + set(${var} 13) > elseif(${dir} STREQUAL reactos/Microsoft.NET/Framework/v2.0.50727) > - set(${var} 13) > + set(${var} 14) > else() > message(ERROR "Wrong destination: ${dir}") > endif() > > >

11 years, 11 months

Re: [ros-dev] [ros-diffs] [ekohl] 57517: [LSASRV] Implement lookup of accounts in the account domain of the SAM database. The advapi32 security winetest shows proper domain and account names for the administrator and guest ...

by Alex Ionescu

Eric, with my rewrite, you can call RtlEqualPrefixSid instead of using LsapIsPrefixSid. The code should be the same Best regards, Alex Ionescu On Sun, Oct 7, 2012 at 7:33 PM, <ekohl(a)svn.reactos.org> wrote: > LsapIsPrefixSid

11 years, 11 months

Re: [ros-dev] [ros-diffs] [ekohl] 57503: [LSASRV] - Make LsarLookupNames, LsarLookupNames2 and LsarLookupNames4 call LsapLookupNames and convert the results where this is needed. - Split the lookup code in LsapLookupSids in...

by Timo Kreuzer

Looks like this revision breaks advapi32:security test (crash) and iphlpapi:iphlpapi (cancelled) http://reactos.org/testman/compare.php?ids=13887,13888 Am 06.10.2012 21:37, schrieb ekohl(a)svn.reactos.org: > Author: ekohl > Date: Sat Oct 6 19:37:10 2012 > New Revision: 57503 > > URL:http://svn.reactos.org/svn/reactos?rev=57503&view=rev > Log: > [LSASRV] > - Make LsarLookupNames, LsarLookupNames2 and LsarLookupNames4 call LsapLookupNames and convert the results where this is needed. > - Split the lookup code in LsapLookupSids into separate functions. > > Modified: > trunk/reactos/dll/win32/lsasrv/lsarpc.c > trunk/reactos/dll/win32/lsasrv/lsasrv.h > trunk/reactos/dll/win32/lsasrv/sids.c > > Modified: trunk/reactos/dll/win32/lsasrv/lsarpc.c > URL:http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/lsasrv/lsarp… > ============================================================================== > --- trunk/reactos/dll/win32/lsasrv/lsarpc.c [iso-8859-1] (original) > +++ trunk/reactos/dll/win32/lsasrv/lsarpc.c [iso-8859-1] Sat Oct 6 19:37:10 2012 > @@ -550,89 +550,53 @@ > LSAP_LOOKUP_LEVEL LookupLevel, > DWORD *MappedCount) > { > - SID_IDENTIFIER_AUTHORITY IdentifierAuthority = {SECURITY_NT_AUTHORITY}; > - static const UNICODE_STRING DomainName = RTL_CONSTANT_STRING(L"DOMAIN"); > - PLSAPR_REFERENCED_DOMAIN_LIST OutputDomains = NULL; > - PLSA_TRANSLATED_SID OutputSids = NULL; > - ULONG OutputSidsLength; > + LSAPR_TRANSLATED_SIDS_EX2 TranslatedSidsEx2; > ULONG i; > - PSID Sid; > - ULONG SidLength; > NTSTATUS Status; > > - TRACE("LsarLookupNames(%p, %lu, %p, %p, %p, %d, %p)\n", > + TRACE("(%p %lu %p %p %p %d %p)\n", > PolicyHandle, Count, Names, ReferencedDomains, TranslatedSids, > LookupLevel, MappedCount); > > - TranslatedSids->Entries = Count; > + TranslatedSids->Entries = 0; > TranslatedSids->Sids = NULL; > *ReferencedDomains = NULL; > > - OutputSidsLength = Count * sizeof(LSA_TRANSLATED_SID); > - OutputSids = MIDL_user_allocate(OutputSidsLength); > - if (OutputSids == NULL) > - { > + if (Count == 0) > + return STATUS_NONE_MAPPED; > + > + TranslatedSidsEx2.Entries = 0; > + TranslatedSidsEx2.Sids = NULL; > + > + Status = LsapLookupNames(Count, > + Names, > + ReferencedDomains, > + &TranslatedSidsEx2, > + LookupLevel, > + MappedCount, > + 0, > + 0); > + if (!NT_SUCCESS(Status)) > + return Status; > + > + TranslatedSids->Entries = TranslatedSidsEx2.Entries; > + TranslatedSids->Sids = MIDL_user_allocate(TranslatedSids->Entries * sizeof(LSA_TRANSLATED_SID)); > + if (TranslatedSids->Sids == NULL) > + { > + MIDL_user_free(TranslatedSidsEx2.Sids); > + MIDL_user_free(*ReferencedDomains); > + *ReferencedDomains = NULL; > return STATUS_INSUFFICIENT_RESOURCES; > } > > - RtlZeroMemory(OutputSids, OutputSidsLength); > - > - OutputDomains = MIDL_user_allocate(sizeof(LSAPR_REFERENCED_DOMAIN_LIST)); > - if (OutputDomains == NULL) > - { > - MIDL_user_free(OutputSids); > - return STATUS_INSUFFICIENT_RESOURCES; > - } > - > - OutputDomains->Entries = Count; > - OutputDomains->Domains = MIDL_user_allocate(Count * sizeof(LSA_TRUST_INFORMATION)); > - if (OutputDomains->Domains == NULL) > - { > - MIDL_user_free(OutputDomains); > - MIDL_user_free(OutputSids); > - return STATUS_INSUFFICIENT_RESOURCES; > - } > - > - Status = RtlAllocateAndInitializeSid(&IdentifierAuthority, > - 2, > - SECURITY_BUILTIN_DOMAIN_RID, > - DOMAIN_ALIAS_RID_ADMINS, > - 0, 0, 0, 0, 0, 0, > - &Sid); > - if (!NT_SUCCESS(Status)) > - { > - MIDL_user_free(OutputDomains->Domains); > - MIDL_user_free(OutputDomains); > - MIDL_user_free(OutputSids); > - return Status; > - } > - > - SidLength = RtlLengthSid(Sid); > - > - for (i = 0; i < Count; i++) > - { > - OutputDomains->Domains[i].Sid = MIDL_user_allocate(SidLength); > - RtlCopyMemory(OutputDomains->Domains[i].Sid, Sid, SidLength); > - > - OutputDomains->Domains[i].Name.Buffer = MIDL_user_allocate(DomainName.MaximumLength); > - OutputDomains->Domains[i].Name.Length = DomainName.Length; > - OutputDomains->Domains[i].Name.MaximumLength = DomainName.MaximumLength; > - RtlCopyMemory(OutputDomains->Domains[i].Name.Buffer, DomainName.Buffer, DomainName.MaximumLength); > - } > - > - for (i = 0; i < Count; i++) > - { > - OutputSids[i].Use = SidTypeWellKnownGroup; > - OutputSids[i].RelativeId = DOMAIN_USER_RID_ADMIN; //DOMAIN_ALIAS_RID_ADMINS; > - OutputSids[i].DomainIndex = i; > - } > - > - *ReferencedDomains = OutputDomains; > - > - *MappedCount = Count; > - > - TranslatedSids->Entries = Count; > - TranslatedSids->Sids = OutputSids; > + for (i = 0; i < TranslatedSidsEx2.Entries; i++) > + { > + TranslatedSids->Sids[i].Use = TranslatedSidsEx2.Sids[i].Use; > + TranslatedSids->Sids[i].RelativeId = LsapGetRelativeIdFromSid(TranslatedSidsEx2.Sids[i].Sid); > + TranslatedSids->Sids[i].DomainIndex = TranslatedSidsEx2.Sids[i].DomainIndex; > + } > + > + MIDL_user_free(TranslatedSidsEx2.Sids); > > return STATUS_SUCCESS; > } > @@ -658,14 +622,11 @@ > /* FIXME: Fail, if there is an invalid SID in the SidEnumBuffer */ > > TranslatedNames->Entries = SidEnumBuffer->Entries; > - TranslatedNames->Names = MIDL_user_allocate(SidEnumBuffer->Entries * sizeof(LSAPR_TRANSLATED_NAME)); > - if (TranslatedNames->Names == NULL) > - return STATUS_INSUFFICIENT_RESOURCES; > - > + TranslatedNames->Names = NULL; > *ReferencedDomains = NULL; > > TranslatedNamesEx.Entries = SidEnumBuffer->Entries; > - TranslatedNamesEx.Names = NULL;; > + TranslatedNamesEx.Names = NULL; > > Status = LsapLookupSids(SidEnumBuffer, > ReferencedDomains, > @@ -675,9 +636,16 @@ > 0, > 0); > if (!NT_SUCCESS(Status)) > + return Status; > + > + TranslatedNames->Entries = SidEnumBuffer->Entries; > + TranslatedNames->Names = MIDL_user_allocate(SidEnumBuffer->Entries * sizeof(LSAPR_TRANSLATED_NAME)); > + if (TranslatedNames->Names == NULL) > { > MIDL_user_free(TranslatedNamesEx.Names); > - return Status; > + MIDL_user_free(*ReferencedDomains); > + *ReferencedDomains = NULL; > + return STATUS_INSUFFICIENT_RESOURCES; > } > > for (i = 0; i < TranslatedNamesEx.Entries; i++) > @@ -1977,8 +1945,56 @@ > DWORD LookupOptions, > DWORD ClientRevision) > { > - UNIMPLEMENTED; > - return STATUS_NOT_IMPLEMENTED; > + LSAPR_TRANSLATED_SIDS_EX2 TranslatedSidsEx2; > + ULONG i; > + NTSTATUS Status; > + > + TRACE("(%p %lu %p %p %p %d %p %lu %lu)\n", > + PolicyHandle, Count, Names, ReferencedDomains, TranslatedSids, > + LookupLevel, MappedCount, LookupOptions, ClientRevision); > + > + TranslatedSids->Entries = 0; > + TranslatedSids->Sids = NULL; > + *ReferencedDomains = NULL; > + > + if (Count == 0) > + return STATUS_NONE_MAPPED; > + > + TranslatedSidsEx2.Entries = 0; > + TranslatedSidsEx2.Sids = NULL; > + > + Status = LsapLookupNames(Count, > + Names, > + ReferencedDomains, > + &TranslatedSidsEx2, > + LookupLevel, > + MappedCount, > + LookupOptions, > + ClientRevision); > + if (!NT_SUCCESS(Status)) > + return Status; > + > + TranslatedSids->Entries = TranslatedSidsEx2.Entries; > + TranslatedSids->Sids = MIDL_user_allocate(TranslatedSids->Entries * sizeof(LSA_TRANSLATED_SID)); > + if (TranslatedSids->Sids == NULL) > + { > + MIDL_user_free(TranslatedSidsEx2.Sids); > + MIDL_user_free(*ReferencedDomains); > + *ReferencedDomains = NULL; > + return STATUS_INSUFFICIENT_RESOURCES; > + } > + > + for (i = 0; i < TranslatedSidsEx2.Entries; i++) > + { > + TranslatedSids->Sids[i].Use = TranslatedSidsEx2.Sids[i].Use; > + TranslatedSids->Sids[i].RelativeId = LsapGetRelativeIdFromSid(TranslatedSidsEx2.Sids[i].Sid); > + TranslatedSids->Sids[i].DomainIndex = TranslatedSidsEx2.Sids[i].DomainIndex; > + TranslatedSids->Sids[i].Flags = TranslatedSidsEx2.Sids[i].Flags; > + } > + > + MIDL_user_free(TranslatedSidsEx2.Sids); > + > + return STATUS_SUCCESS; > } > > > @@ -2081,7 +2097,7 @@ > { > NTSTATUS Status; > > - TRACE("LsarLookupNames3(%p, %lu, %p, %p, %p, %d, %p, %lu, %lu)\n", > + TRACE("(%p %lu %p %p %p %d %p %lu %lu)\n", > PolicyHandle, Count, Names, ReferencedDomains, TranslatedSids, > LookupLevel, MappedCount, LookupOptions, ClientRevision); > > @@ -2223,8 +2239,29 @@ > DWORD LookupOptions, > DWORD ClientRevision) > { > - UNIMPLEMENTED; > - return STATUS_NOT_IMPLEMENTED; > + NTSTATUS Status; > + > + TRACE("(%p %lu %p %p %p %d %p %lu %lu)\n", > + RpcHandle, Count, Names, ReferencedDomains, TranslatedSids, > + LookupLevel, MappedCount, LookupOptions, ClientRevision); > + > + TranslatedSids->Entries = 0; > + TranslatedSids->Sids = NULL; > + *ReferencedDomains = NULL; > + > + if (Count == 0) > + return STATUS_NONE_MAPPED; > + > + Status = LsapLookupNames(Count, > + Names, > + ReferencedDomains, > + TranslatedSids, > + LookupLevel, > + MappedCount, > + LookupOptions, > + ClientRevision); > + > + return Status; > } > > > > Modified: trunk/reactos/dll/win32/lsasrv/lsasrv.h > URL:http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/lsasrv/lsasr… > ============================================================================== > --- trunk/reactos/dll/win32/lsasrv/lsasrv.h [iso-8859-1] (original) > +++ trunk/reactos/dll/win32/lsasrv/lsasrv.h [iso-8859-1] Sat Oct 6 19:37:10 2012 > @@ -192,6 +192,9 @@ > NTSTATUS > LsapInitSids(VOID); > > +ULONG > +LsapGetRelativeIdFromSid(PSID Sid); > + > NTSTATUS > LsapLookupNames(DWORD Count, > PRPC_UNICODE_STRING Names, > > Modified: trunk/reactos/dll/win32/lsasrv/sids.c > URL:http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/lsasrv/sids.… > ============================================================================== > --- trunk/reactos/dll/win32/lsasrv/sids.c [iso-8859-1] (original) > +++ trunk/reactos/dll/win32/lsasrv/sids.c [iso-8859-1] Sat Oct 6 19:37:10 2012 > @@ -808,6 +808,18 @@ > } > > > +ULONG > +LsapGetRelativeIdFromSid(PSID Sid_) > +{ > + PISID Sid = Sid_; > + > + if (Sid->SubAuthorityCount != 0) > + return Sid->SubAuthority[Sid->SubAuthorityCount - 1]; > + > + return 0; > +} > + > + > NTSTATUS > LsapLookupNames(DWORD Count, > PRPC_UNICODE_STRING Names, > @@ -824,10 +836,6 @@ > PRPC_UNICODE_STRING AccountNames = NULL; > ULONG SidsBufferLength; > ULONG DomainIndex; > -// ULONG DomainSidLength; > -// ULONG AccountSidLength; > -// PSID DomainSid; > -// PSID AccountSid; > ULONG i; > ULONG Mapped = 0; > NTSTATUS Status = STATUS_SUCCESS; > @@ -1006,84 +1014,29 @@ > } > > > -NTSTATUS > -LsapLookupSids(PLSAPR_SID_ENUM_BUFFER SidEnumBuffer, > - PLSAPR_REFERENCED_DOMAIN_LIST *ReferencedDomains, > - PLSAPR_TRANSLATED_NAMES_EX TranslatedNames, > - LSAP_LOOKUP_LEVEL LookupLevel, > - DWORD *MappedCount, > - DWORD LookupOptions, > - DWORD ClientRevision) > -{ > - PLSAPR_REFERENCED_DOMAIN_LIST DomainsBuffer = NULL; > - PLSAPR_TRANSLATED_NAME_EX NamesBuffer = NULL; > - ULONG NamesBufferLength; > +static NTSTATUS > +LsapLookupWellKnownSids(PLSAPR_SID_ENUM_BUFFER SidEnumBuffer, > + PLSAPR_TRANSLATED_NAME_EX NamesBuffer, > + PLSAPR_REFERENCED_DOMAIN_LIST DomainsBuffer, > + PULONG Mapped) > +{ > + PWELL_KNOWN_SID ptr, ptr2; > + LPWSTR SidString = NULL; > ULONG DomainIndex; > ULONG i; > - ULONG Mapped = 0; > NTSTATUS Status = STATUS_SUCCESS; > > - PWELL_KNOWN_SID ptr, ptr2; > - > - SID_IDENTIFIER_AUTHORITY IdentifierAuthority = {SECURITY_NT_AUTHORITY}; > - static const UNICODE_STRING DomainName = RTL_CONSTANT_STRING(L"DOMAIN"); > - static const UNICODE_STRING AdminName = RTL_CONSTANT_STRING(L"Administrator"); > - PSID AdminsSid = NULL; > - ULONG SidLength; > - > - > - NamesBufferLength = SidEnumBuffer->Entries * sizeof(LSAPR_TRANSLATED_NAME_EX); > - NamesBuffer = MIDL_user_allocate(NamesBufferLength); > - if (NamesBuffer == NULL) > - { > - Status = STATUS_INSUFFICIENT_RESOURCES; > - goto done; > - } > - > - DomainsBuffer = MIDL_user_allocate(sizeof(LSAPR_REFERENCED_DOMAIN_LIST)); > - if (DomainsBuffer == NULL) > - { > - Status = STATUS_INSUFFICIENT_RESOURCES; > - goto done; > - } > - > - DomainsBuffer->Domains = MIDL_user_allocate(SidEnumBuffer->Entries * sizeof(LSA_TRUST_INFORMATION)); > - if (DomainsBuffer->Domains == NULL) > - { > - Status = STATUS_INSUFFICIENT_RESOURCES; > - goto done; > - } > - > - DomainsBuffer->Entries = 0; > - DomainsBuffer->MaxEntries = SidEnumBuffer->Entries; > - > - /* Initialize all name entries */ > for (i = 0; i < SidEnumBuffer->Entries; i++) > { > - NamesBuffer[i].Use = SidTypeUnknown; > - NamesBuffer[i].Name.Length = 0; > - NamesBuffer[i].Name.MaximumLength = 0; > - NamesBuffer[i].Name.Buffer = NULL; > - NamesBuffer[i].DomainIndex = -1; > - NamesBuffer[i].Flags = 0; > - } > - > - > - Status = RtlAllocateAndInitializeSid(&IdentifierAuthority, > - 2, > - SECURITY_BUILTIN_DOMAIN_RID, > - DOMAIN_ALIAS_RID_ADMINS, > - 0, 0, 0, 0, 0, 0, > - &AdminsSid); > - if (!NT_SUCCESS(Status)) > - goto done; > - > - > - SidLength = RtlLengthSid(AdminsSid); > - > - > - for (i = 0; i < SidEnumBuffer->Entries; i++) > - { > + /* Ignore SIDs which are already mapped */ > + if (NamesBuffer[i].Use != SidTypeUnknown) > + continue; > + > + ConvertSidToStringSidW(SidEnumBuffer->SidInfo[i].Sid, &SidString); > + TRACE("Unmapped SID: %S\n", SidString); > + LocalFree(SidString); > + SidString = NULL; > + > ptr = LsapLookupWellKnownSid(SidEnumBuffer->SidInfo[i].Sid); > if (ptr != NULL) > { > @@ -1106,13 +1059,83 @@ > NamesBuffer[i].DomainIndex = DomainIndex; > } > > - Mapped++; > + TRACE("Mapped to: %wZ\n", &NamesBuffer[i].Name); > + > + (*Mapped)++; > + } > + } > + > + return Status; > +} > + > + > +static NTSTATUS > +LsapLookupLocalDomainSids(PLSAPR_SID_ENUM_BUFFER SidEnumBuffer, > + PLSAPR_TRANSLATED_NAME_EX NamesBuffer, > + PLSAPR_REFERENCED_DOMAIN_LIST DomainsBuffer, > + PULONG Mapped) > +{ > + LPWSTR SidString = NULL; > + ULONG i; > + > + for (i = 0; i < SidEnumBuffer->Entries; i++) > + { > + /* Ignore SIDs which are already mapped */ > + if (NamesBuffer[i].Use != SidTypeUnknown) > continue; > - } > + > + ConvertSidToStringSidW(SidEnumBuffer->SidInfo[i].Sid, &SidString); > + TRACE("Unmapped SID: %S\n", SidString); > + LocalFree(SidString); > + SidString = NULL; > + } > + > + return STATUS_SUCCESS; > +} > + > + > +static NTSTATUS > +LsapLookupUnknownSids(PLSAPR_SID_ENUM_BUFFER SidEnumBuffer, > + PLSAPR_TRANSLATED_NAME_EX NamesBuffer, > + PLSAPR_REFERENCED_DOMAIN_LIST DomainsBuffer, > + PULONG Mapped) > +{ > + SID_IDENTIFIER_AUTHORITY IdentifierAuthority = {SECURITY_NT_AUTHORITY}; > + static const UNICODE_STRING DomainName = RTL_CONSTANT_STRING(L"DOMAIN"); > + static const UNICODE_STRING AdminName = RTL_CONSTANT_STRING(L"Administrator"); > + PSID AdminsSid = NULL; > + LPWSTR SidString = NULL; > + ULONG SidLength; > + ULONG DomainIndex; > + ULONG i; > + NTSTATUS Status; > + > + Status = RtlAllocateAndInitializeSid(&IdentifierAuthority, > + 2, > + SECURITY_BUILTIN_DOMAIN_RID, > + DOMAIN_ALIAS_RID_ADMINS, > + 0, 0, 0, 0, 0, 0, > + &AdminsSid); > + if (!NT_SUCCESS(Status)) > + goto done; > + > + SidLength = RtlLengthSid(AdminsSid); > + > + for (i = 0; i < SidEnumBuffer->Entries; i++) > + { > + /* Ignore SIDs which are already mapped */ > + if (NamesBuffer[i].Use != SidTypeUnknown) > + continue; > + > + > + ConvertSidToStringSidW(SidEnumBuffer->SidInfo[i].Sid, &SidString); > + TRACE("Unmapped SID: %S\n", SidString); > + LocalFree(SidString); > + SidString = NULL; > > > /* Hack: Map the SID to the Admin Account if it is not a well-known SID */ > - NamesBuffer[i].Use = SidTypeWellKnownGroup; > + NamesBuffer[i].Use = SidTypeUser; > NamesBuffer[i].Flags = 0; > NamesBuffer[i].Name.Length = AdminName.Length; > NamesBuffer[i].Name.MaximumLength = AdminName.MaximumLength; > @@ -1126,16 +1149,103 @@ > if (NT_SUCCESS(Status)) > NamesBuffer[i].DomainIndex = DomainIndex; > > - Mapped++; > - continue; > - > - > + TRACE("Mapped to: %wZ\n", &NamesBuffer[i].Name); > + > + (*Mapped)++; > } > > done: > if (AdminsSid != NULL) > RtlFreeSid(AdminsSid); > > + return Status; > +} > + > + > +NTSTATUS > +LsapLookupSids(PLSAPR_SID_ENUM_BUFFER SidEnumBuffer, > + PLSAPR_REFERENCED_DOMAIN_LIST *ReferencedDomains, > + PLSAPR_TRANSLATED_NAMES_EX TranslatedNames, > + LSAP_LOOKUP_LEVEL LookupLevel, > + DWORD *MappedCount, > + DWORD LookupOptions, > + DWORD ClientRevision) > +{ > + PLSAPR_REFERENCED_DOMAIN_LIST DomainsBuffer = NULL; > + PLSAPR_TRANSLATED_NAME_EX NamesBuffer = NULL; > + ULONG NamesBufferLength; > + ULONG i; > + ULONG Mapped = 0; > + NTSTATUS Status = STATUS_SUCCESS; > + > + NamesBufferLength = SidEnumBuffer->Entries * sizeof(LSAPR_TRANSLATED_NAME_EX); > + NamesBuffer = MIDL_user_allocate(NamesBufferLength); > + if (NamesBuffer == NULL) > + { > + Status = STATUS_INSUFFICIENT_RESOURCES; > + goto done; > + } > + > + DomainsBuffer = MIDL_user_allocate(sizeof(LSAPR_REFERENCED_DOMAIN_LIST)); > + if (DomainsBuffer == NULL) > + { > + Status = STATUS_INSUFFICIENT_RESOURCES; > + goto done; > + } > + > + DomainsBuffer->Domains = MIDL_user_allocate(SidEnumBuffer->Entries * sizeof(LSA_TRUST_INFORMATION)); > + if (DomainsBuffer->Domains == NULL) > + { > + Status = STATUS_INSUFFICIENT_RESOURCES; > + goto done; > + } > + > + DomainsBuffer->Entries = 0; > + DomainsBuffer->MaxEntries = SidEnumBuffer->Entries; > + > + /* Initialize all name entries */ > + for (i = 0; i < SidEnumBuffer->Entries; i++) > + { > + NamesBuffer[i].Use = SidTypeUnknown; > + NamesBuffer[i].Name.Length = 0; > + NamesBuffer[i].Name.MaximumLength = 0; > + NamesBuffer[i].Name.Buffer = NULL; > + NamesBuffer[i].DomainIndex = -1; > + NamesBuffer[i].Flags = 0; > + } > + > + /* Look-up all well-known SIDs */ > + Status = LsapLookupWellKnownSids(SidEnumBuffer, > + NamesBuffer, > + DomainsBuffer, > + &Mapped); > + if (!NT_SUCCESS(Status)) > + goto done; > + > + if (Mapped == SidEnumBuffer->Entries) > + goto done; > + > + /* Look-up all Domain SIDs */ > + Status = LsapLookupLocalDomainSids(SidEnumBuffer, > + NamesBuffer, > + DomainsBuffer, > + &Mapped); > + if (!NT_SUCCESS(Status)) > + goto done; > + > + if (Mapped == SidEnumBuffer->Entries) > + goto done; > + > + /* Map unknown SIDs */ > + Status = LsapLookupUnknownSids(SidEnumBuffer, > + NamesBuffer, > + DomainsBuffer, > + &Mapped); > + if (!NT_SUCCESS(Status)) > + goto done; > + > +done: > + TRACE("done Status: %lx Mapped: %lu\n", Status, Mapped); > > if (!NT_SUCCESS(Status)) > { > > >

11 years, 11 months

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev