It seems that any crash in APITESTS on vbox testbot is causing
rosautotest to redo from start. We can see this in stdio log:
http://build.reactos.org/builders/Windows_AMD64_1%20VBox-Test/builds/6323/s…
(just search for "restarting" word). APITESTS are repated and such log
as a whole is messing up testman, which is treating it like two
submissions for the same revision. It accepts the first one (incomplete
due to crash) and rejects the second one, reporting a duplicate: "ERROR!
submit(13111, 518, ...) - We already have a result for this test suite
in this test run! "Windows_AMD64_1 VBox-Test""
As we all know, we should expect tests to fail and even crash (this is
what they are designed for), hence the error is in rosautotest and
testman.
Rosautotest, strangely, is affected only on vbox, on kvm the apitest
crash is not causing a restart of test run. Winetests, if i recall
correctly, were never affected in such way.
Testman should not reject a submission after its saved up and revision -
blocked.
I am aware that some will be tempted to comment out the test in
question, but this is not a proper solution to this situation. Other
apitest will crash in the future, bringing the whole thing back. Same as
with regressions, lack of tests due to such issue, will bite us back in
the future, when least expected and most needed. This is why I humbly
request this issue to be solved properly, once and for all.
With best regards
----- Original message -----
From: buildbot(a)reactos.org
To: caemyr(a)myopera.com
Subject: buildbot failure in ReactOS on Windows_AMD64_1 VBox-Test
Date: Tue, 14 Aug 2012 00:23:24 +0000
The Buildbot has finished a build on builder Windows_AMD64_1 VBox-Test
while building ReactOS.
Full details are available at:
http://build.reactos.org/builders/Windows_AMD64_1%20VBox-Test/builds/6324
Buildbot URL: http://build.reactos.org/
Buildslave for this Build: Windows_AMD64_2
Build Reason: Triggerable(Windows_AMD64_1 VBox-Test Trigger)
Build Source Stamp: 57075
Blamelist: akhaldi
BUILD FAILED: failed Cleanup
sincerely,
-The Buildbot
--
With best regards
Caemyr
http://www.reactos.org/bugzilla/show_bug.cgi?id=6035
--- Comment #7 from hbelusca <hermes.belusca(a)sfr.fr> 2012-08-09 14:02:29 CET ---
According to Edijs, the confirmation message box isn't in top-most position
with respect to the Abiword's window :
[15:57:09] <Edijus> hbelusca: When save changes dialog appears, change focus to
explorer or some other window.
http://www.reactos.org/bugzilla/show_bug.cgi?id=6035
[15:57:26] <Edijus> hbelusca: Save changes dialog is not top most. Report it,
please. :)
[15:59:47] <hbelusca> Edijus: you mean that the confirmation message box of
Abiword can "disappear" (ie. go behind another window) ?!
[16:00:25] <Edijus> hbelusca: Yeah. Check if it reported or not, before
reporting.
[16:00:32] <Edijus> Thanks.
--
Configure bugmail: http://www.reactos.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.
_______________________________________________
Ros-bugs mailing list
Ros-bugs(a)reactos.org
http://www.reactos.org/mailman/listinfo/ros-bugs
The ReactOS Project is proud to announce the first of the development
contracts that will be funded by the recent donation campaign. Edijs
Kolesnikovics joined the ReactOS development team very recently and
has been working extensively with Amine Khaldi and Olaf Siejka to
create an application test suite based around the AutoHotkey (AHK)
automation system. AutoHotkey is a tool for scripting keyboard and
mouse actions in order to automate running of programs on Windows.
While the current test suites exercise a considerable amount of
functionality, the true test for ReactOS remains when it is used to
run applications. As such, Edijs has been working to create tests
using AHK to run a variety of applications, starting with those on the
Golden Apps list. The basic framework is already in place along with a
few tests, but much more can be done to expand the selection of
applications tested. As such, the Foundation has elected to grant
Edijs a development contract to develop additional tests. The project
congratulates Edijs on a job well done so far, and would also like to
thank Amine, Olaf, and the AHK developers for their help mentoring and
advising Edijs.
Contract Details
Time: 84 hours minimum
Wage: €168
Expected Duration: 1 month
Objective: Within the designated time period, develop as many AHK test
scripts for applications to be used with the automated regression
testing as possible. The intended goal is to have at least all
remaining Golden Apps testable. This project seeks to help developers
catch regressions more quickly so that stabilizing ReactOS for
releases becomes less time consuming. This task will be monitored by
Amine Khaldi.
Sidenote: Due to a variety of circumstances unrelated to the donation
campaign, Edijs' contract wage is significantly lower than what would
be the standard contract wage for the project.
While this works for us, we should consider trying to get this feature
back. When it's considered for removal, then they obviously "fixed"
something now that noone needs (and that makes absolutely no sense at
all), while the feature as it was before is very useful to compile 3rd
party code for Windows.
One possibility (since we compile gcc ourselves anyway), is finding out
where they "fixed" it and revert that revision for our builds. If they
completely remove it, we rename the option and send the old code in as a
new feature for MSVC compatibility ;-)
Am 29.07.2012 03:49, schrieb akhaldi(a)svn.reactos.org:
> Author: akhaldi
> Date: Sun Jul 29 01:49:24 2012
> New Revision: 56973
>
> URL: http://svn.reactos.org/svn/reactos?rev=56973&view=rev
> Log:
> [CLASSPNP]
> * Explicitly mark the functions as stdcall (NTAPI).. -mrtd changes the default calling convention, but name-decoration isn't affected by this. The -mrtd feature has its origin in some older linux-code-mode, and it's considered for removal in GCC 4.8.
> * Fix some warnings.
>
> Modified:
> trunk/reactos/drivers/storage/classpnp/CMakeLists.txt
> trunk/reactos/drivers/storage/classpnp/autorun.c
> trunk/reactos/drivers/storage/classpnp/class.c
> trunk/reactos/drivers/storage/classpnp/classp.h
> trunk/reactos/drivers/storage/classpnp/classwmi.c
> trunk/reactos/drivers/storage/classpnp/clntirp.c
> trunk/reactos/drivers/storage/classpnp/create.c
> trunk/reactos/drivers/storage/classpnp/dictlib.c
> trunk/reactos/drivers/storage/classpnp/lock.c
> trunk/reactos/drivers/storage/classpnp/obsolete.c
> trunk/reactos/drivers/storage/classpnp/power.c
> trunk/reactos/drivers/storage/classpnp/retry.c
> trunk/reactos/drivers/storage/classpnp/utils.c
> trunk/reactos/drivers/storage/classpnp/xferpkt.c
>
Hello,
Let me invite you to the monthly status meeting taking place last
Thursday of this month, 26th of July, 19:00 UTC.
The meeting will be at irc://fezile.reactos.org (Port 6667, no SSL) in
the channel #meeting. Note that the IRC service will only be started
shortly before the meeting. Your participation passwords will be emailed
to you shortly before the meeting starts.
If someone still is not getting passwords sent before a meeting - please
email Colin or Pierre before the meeting started to get one.
In order to save time, let's choose who is going to be the minute taker
on the upcoming meeting. As usual, volunteers are welcome.
he agenda will be posted shortly before the meeting, suggestions are
welcome (send them to my email as usual).
With the best regards,
Aleksey Bragin.