Ros-dev

ros-dev@reactos.org

2 participants
5791 discussions

Regarding Meeting
by Neeraj Yadav 27 May '11

27 May '11

Hi, I am a GSoC student working on Audio Mixer Project.Unfortunately, I was not able to contact my mentor/administrator during community bonding period.I have disappointed whole of the community and you have every right to be angry and I am really sorry for my act.But I request you all to reconsider the following points : 1. Firstly, Why would one disappear during community bonding period without any reason ? It is the easiest part of the whole program for a student in which they have to just talk to the community, which I think they have already been doing for not less than a month, then what is the problem in being in contact for another month. In my opinion a smart student who just wanted his initial payment would have disappeared after the community bonding period.Instead of coming back at the time of actual work. 2. Some of you think that I was waiting for initial payment and then reappeared when i did not get it, I would like to say that I appeared without even knowing that my project has been discontinued, neither had anyone got his welcome package upto that time.Nothing regarding my project discontinuation had been reported in Melange.How could i get even a slightest idea about my project's termination. 3. Some of you think that it is going to hurt the reputation of organisation for next year's selection at GSoC, I would like to admit that terminating my project will straightaway decrease project completion rate of ReactOS organisation to 80% and it may further reduce if some students actually do not complete the project which is considered too bad for an organisation.And believe me next year's sole criterion for organisation selection will be this success rate. 4.Problems occur to every organisation and Google understands it very well and it doesn't affect the organisation's reputation that much.All that matters is the success rate. 5. I talked to Google and they just want an email of consent from my mentor and its not too late.I have filled all my forms in due time. 6. My project would have automatically been discontinued if I failed for Mid-term Evaluation.But no one gets benefit if my project is discontinued earlier.Take a chance guys, If I complete my project it will be good for both me and community if not terminating my project at both 7. In case above explanations do not satisfy you and if you think this is only money I am after, I am ready to deposit $500 as security which is equal to the initial payment.[or whatever amount you say] This issue can be discussed in today's meeting.I am ready to answer all of your questions.I hope you will think about it with a cool mind keeping the anger/ego apart. -- Regards Neeraj Yadav Undergraduate Student Indian Institute of Technology, Delhi

3 3

Thomas Krenn Support
by Matthias Kupfer 26 May '11

26 May '11

HI folks, the German company Thomas Krenn AG (Server Hardware) announced on LinuxTag an open source support programme for open source projectes, that register during LinuxTag. So I've use this chance and made the first step and registered ReactOS. Now we need some arguments what kind of hardware do we need and why resp. for what purpose. Devs please take a look at thomas-krenn.com and select a usefull set of hardware and describe what is usefull for. I think we should define specific tasks, not "upgrade exisiting hardware", but e.g. "New continuous integration server". Please send the description and the ID of the basket to me. The prices are: 1st: hardware for 2500 € (excluding VAT) 2nd: hardware for 1500 € (excluding VAT) 3rd: hardware for 1000 € (excluding VAT) 4th: hardware for 800 € (excluding VAT) 5th: hardware for 700 € (excluding VAT) They told me at the booth the chances increase with the detailed description of the intended use of the selected hardware (maybe combined with neediness). Best regards Matthias -- Matthias Kupfer phone +49 371 236 46 52 Wilhelm-Firl-Straße 21 mobile +49 160 859 43 54 09122 Chemnitz, Germany

5 5

Fezile Server planned shut-down.
by Jan Blomqvist Kinander 26 May '11

26 May '11

Hi, I will have to take down the Fezile server for a short period of time in about 2 weeks due to a move of the server room to a fireproof, fairly burglarproof security room (brickswork with steeldoor, no windows). However, it is beeing remodelled right now, and then the aircondition, ethernet lines and power is going to be installed, so I guess two weeks. I have some computers to move so the power down may take some time, but I will try to make the move as fast as possible. During this time I will try to prepare for a ReactOS LAN behind the Fezile server on the second and third LAN adapter, for example for build testing on real hardware or another build bot. Yours sincerely, Jaix Bly (Jan Blomqvist Kinander)

1 0

Status meeting
by Aleksey Bragin 26 May '11

26 May '11

Hello, I want to remind you of the monthly status meeting taking place today, Thursday the 26th of May at 20:00 UTC at freenode #reactos-meeting. The suggested (subject to change and addition before meeting starts) meeting agenda is: - Status of our GSoC participation - Current ReactOS work. Developers reporting their status. Those who don’t attend will be able to read up the meeting minutes later. See you at the meeting today! WBR, Aleksey Bragin.

3 3

Getbuilds not functioning
by Olaf Siejka 25 May '11

25 May '11

Hiya Our nightly builds repository is not working and people cannot download anything from it. Is it a known issue? Any idea when it might be fixed? Best regards

3 2

Reminder to GSoC students (and everyone else) about commit format
by Zachary Gorden 24 May '11

24 May '11

Commit messages should include the component name that your commit changes. Messages like the following: [nyadav] 51882: Fix a Deadlock (nyadav(a)svn.reactos.org) will result in me coming after you when I need to do the changelog for the next release. Messages should be formatted like this: [tkreuzer] 51885: [WIN32K] - Fix the bitmap alignment issue that caused broken scrollbar pattern (tkreuzer(a)svn.reactos.org) Z98

1 0

Buildbot issue
by Pierre Schweitzer 24 May '11

24 May '11

Hi, it appears that Linux buildbot is running a bad issue and is looping on building. If anyone can have a look? To prevent flood on IRC, I silent bot and removed voice. Thanks in advance

3 4

Re: [ros-dev] [ros-diffs] [osiejka] 51874: [RPCSS] Addenum. This change slipped past in commit 51873. Fix name of irot header include, which should be irot.h and not irot_s.h. Fixes rpcss build in MSVC.
by Ged Murphy 24 May '11

24 May '11

That was very confusing :) -----Original Message----- From: ros-diffs-bounces(a)reactos.org [mailto:ros-diffs-bounces@reactos.org] On Behalf Of osiejka(a)svn.reactos.org Sent: 23 May 2011 22:49 To: ros-diffs(a)reactos.org Subject: [ros-diffs] [osiejka] 51874: [RPCSS] Addenum. This change slipped past in commit 51873. Fix name of irot header include, which should be irot.h and not irot_s.h. Fixes rpcss build in MSVC. Author: osiejka Date: Mon May 23 21:49:12 2011 New Revision: 51874 URL: http://svn.reactos.org/svn/reactos?rev=51874&view=rev Log: [RPCSS] Addenum. This change slipped past in commit 51873. Fix name of irot header include, which should be irot.h and not irot_s.h. Fixes rpcss build in MSVC. Modified: trunk/reactos/base/services/rpcss/irotp.c Modified: trunk/reactos/base/services/rpcss/irotp.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/services/rpcss/irotp.… ============================================================================== --- trunk/reactos/base/services/rpcss/irotp.c [iso-8859-1] (original) +++ trunk/reactos/base/services/rpcss/irotp.c [iso-8859-1] Mon May 23 21:49:12 2011 @@ -1,5 +1,5 @@ /* - * Running Object Table + * Running Object Table * * Copyright 2007 Robert Shearman *

2 1

Missing header in rpcss
by Olaf Siejka 22 May '11

22 May '11

It was spotted by MSVC build: P:\Trunk_slave\MSVC-trunk\build\base\services\rpcss\irotp.c(28) : fatal error C1083: Cannot open include file: 'irot_s.h': No such file or directory LINK : fatal error LNK1104: cannot open file 'CMakeFiles/rpcss.dir/irotp.c.obj' In base\services\rpcss\irotp.c:28 we see: #include "irot_s.h" This file is not present in ReactOS trunk. In WINE's RPCSS http://source.winehq.org/git/wine.git/blob/HEAD:/programs/rpcss/irotp.c :28 we have: #include "irot.h" which is also missing, and listed in .gitignore: http://source.winehq.org/git/wine.git/blob?f=.gitignore 260 programs/rpcss/irot.h 261 programs/rpcss/irot_s.c I think we can safely clean it up, perhaps adding proper line to ros-diff, but i would like to ask you guys for confirmation. Regards

2 3

Re: [ros-dev] [ros-diffs] [jimtabor] 51835: [Win32k|User32] - Move creation of the scrollbar Gray brush from user32 to win32k. - Noticed a color and pattern (patchy white pattern) difference when using GreCreateBitmap and i...
by Timo Kreuzer 22 May '11

22 May '11

Hi, I suspect its an alignment issue, since GreCreateBitmap requires 32bit alignment, while CreateBitmap uses 16 bit alignment. So changing + static const WORD wPattern55AA[] = { 0x5555, 0xaaaa, 0x5555, 0xaaaa, 0x5555, 0xaaaa, 0x5555, 0xaaaa }; to + static const DWORD wPattern55AA[] = { 0x5555, 0xaaaa, 0x5555, 0xaaaa, 0x5555, 0xaaaa, 0x5555, 0xaaaa }; Should do the trick. Am 21.05.2011 08:34, schrieb jimtabor(a)svn.reactos.org: > Author: jimtabor > Date: Sat May 21 06:34:02 2011 > New Revision: 51835 > > URL: http://svn.reactos.org/svn/reactos?rev=51835&view=rev > Log: > [Win32k|User32] > - Move creation of the scrollbar Gray brush from user32 to win32k. > - Noticed a color and pattern (patchy white pattern) difference when using GreCreateBitmap and it did not work the same as the main function. Correcting this fixed the Gray brush. Someone from YAROTOWS needs to look into this. > > Modified: > trunk/reactos/dll/win32/user32/windows/defwnd.c > trunk/reactos/subsystems/win32/win32k/include/brush.h > trunk/reactos/subsystems/win32/win32k/ntuser/ntuser.c > trunk/reactos/subsystems/win32/win32k/objects/bitmaps.c > trunk/reactos/subsystems/win32/win32k/objects/brush.c > > Modified: trunk/reactos/dll/win32/user32/windows/defwnd.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/d… > ============================================================================== > --- trunk/reactos/dll/win32/user32/windows/defwnd.c [iso-8859-1] (original) > +++ trunk/reactos/dll/win32/user32/windows/defwnd.c [iso-8859-1] Sat May 21 06:34:02 2011 > @@ -927,8 +927,8 @@ > HBRUSH > DefWndControlColor(HDC hDC, UINT ctlType) > { > - if (CTLCOLOR_SCROLLBAR == ctlType) > - { > + if (ctlType == CTLCOLOR_SCROLLBAR) > + { > HBRUSH hb = GetSysColorBrush(COLOR_SCROLLBAR); > COLORREF bk = GetSysColor(COLOR_3DHILIGHT); > SetTextColor(hDC, GetSysColor(COLOR_3DFACE)); > @@ -938,37 +938,24 @@ > * we better use 0x55aa bitmap brush to make scrollbar's background > * look different from the window background. > */ > - if (bk == GetSysColor(COLOR_WINDOW)) > - { > - static const WORD wPattern55AA[] = > - { > - 0x5555, 0xaaaa, 0x5555, 0xaaaa, > - 0x5555, 0xaaaa, 0x5555, 0xaaaa > - }; > - static HBITMAP hPattern55AABitmap = NULL; > - static HBRUSH hPattern55AABrush = NULL; > - if (hPattern55AABrush == NULL) > - { > - hPattern55AABitmap = CreateBitmap(8, 8, 1, 1, wPattern55AA); > - hPattern55AABrush = CreatePatternBrush(hPattern55AABitmap); > - } > - return hPattern55AABrush; > - } > - UnrealizeObject(hb); > + if ( bk == GetSysColor(COLOR_WINDOW)) > + return gpsi->hbrGray; > + > + UnrealizeObject( hb ); > return hb; > - } > + } > > SetTextColor(hDC, GetSysColor(COLOR_WINDOWTEXT)); > > - if ((CTLCOLOR_EDIT == ctlType) || (CTLCOLOR_LISTBOX == ctlType)) > - { > + if ((ctlType == CTLCOLOR_EDIT) || (ctlType == CTLCOLOR_LISTBOX)) > + { > SetBkColor(hDC, GetSysColor(COLOR_WINDOW)); > - } > + } > else > - { > + { > SetBkColor(hDC, GetSysColor(COLOR_3DFACE)); > return GetSysColorBrush(COLOR_3DFACE); > - } > + } > > return GetSysColorBrush(COLOR_WINDOW); > } > > Modified: trunk/reactos/subsystems/win32/win32k/include/brush.h > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/in… > ============================================================================== > --- trunk/reactos/subsystems/win32/win32k/include/brush.h [iso-8859-1] (original) > +++ trunk/reactos/subsystems/win32/win32k/include/brush.h [iso-8859-1] Sat May 21 06:34:02 2011 > @@ -129,3 +129,5 @@ > VOID FASTCALL FreeObjectAttr(PVOID); > > BOOL FASTCALL IntGdiSetBrushOwner(PBRUSH,DWORD); > +BOOL FASTCALL GreSetBrushOwner(HBRUSH,DWORD); > + > > Modified: trunk/reactos/subsystems/win32/win32k/ntuser/ntuser.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/nt… > ============================================================================== > --- trunk/reactos/subsystems/win32/win32k/ntuser/ntuser.c [iso-8859-1] (original) > +++ trunk/reactos/subsystems/win32/win32k/ntuser/ntuser.c [iso-8859-1] Sat May 21 06:34:02 2011 > @@ -92,6 +92,8 @@ > HANDLE hPowerRequestEvent, > HANDLE hMediaRequestEvent) > { > + static const WORD wPattern55AA[] = { 0x5555, 0xaaaa, 0x5555, 0xaaaa, 0x5555, 0xaaaa, 0x5555, 0xaaaa }; > + HBITMAP hPattern55AABitmap = NULL; > NTSTATUS Status; > > // Set W32PF_Flags |= (W32PF_READSCREENACCESSGRANTED | W32PF_IOWINSTA) > @@ -125,6 +127,14 @@ > > CsrInit(); > > + if (gpsi->hbrGray == NULL) > + { > + hPattern55AABitmap = GreCreateBitmap(8, 8, 1, 1, (LPBYTE)wPattern55AA); > + gpsi->hbrGray = IntGdiCreatePatternBrush(hPattern55AABitmap); > + GreDeleteObject(hPattern55AABitmap); > + GreSetBrushOwner(gpsi->hbrGray, GDI_OBJ_HMGR_PUBLIC); > + } > + > return STATUS_SUCCESS; > } > > > Modified: trunk/reactos/subsystems/win32/win32k/objects/bitmaps.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/ob… > ============================================================================== > --- trunk/reactos/subsystems/win32/win32k/objects/bitmaps.c [iso-8859-1] (original) > +++ trunk/reactos/subsystems/win32/win32k/objects/bitmaps.c [iso-8859-1] Sat May 21 06:34:02 2011 > @@ -154,15 +154,23 @@ > IN UINT cBitsPixel, > IN OPTIONAL PVOID pvBits) > { > + HBITMAP hbmp; > /* Call the extended function */ > - return GreCreateBitmapEx(nWidth, > + hbmp = GreCreateBitmapEx(nWidth, > nHeight, > 0, /* auto width */ > BitmapFormat(cBitsPixel * cPlanes, BI_RGB), > 0, /* no bitmap flags */ > 0, /* auto size */ > - pvBits, > - DDB_SURFACE /* DDB */); > + NULL, > + DDB_SURFACE /* DDB */); > + if (pvBits&& hbmp) > + { > + PSURFACE psurf = SURFACE_ShareLockSurface(hbmp); > + UnsafeSetBitmapBits(psurf, 0, pvBits); > + SURFACE_ShareUnlockSurface(psurf); > + } > + return hbmp; > } > > HBITMAP > > Modified: trunk/reactos/subsystems/win32/win32k/objects/brush.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/ob… > ============================================================================== > --- trunk/reactos/subsystems/win32/win32k/objects/brush.c [iso-8859-1] (original) > +++ trunk/reactos/subsystems/win32/win32k/objects/brush.c [iso-8859-1] Sat May 21 06:34:02 2011 > @@ -59,6 +59,19 @@ > GDIOBJ_vSetObjectOwner(&pbr->BaseObject, ulOwner); > > return TRUE; > +} > + > +BOOL > +FASTCALL > +GreSetBrushOwner(HBRUSH hBrush, ULONG ulOwner) > +{ > + BOOL Ret; > + PBRUSH pbrush; > + > + pbrush = BRUSH_ShareLockBrush(hBrush); > + Ret = IntGdiSetBrushOwner(pbrush, ulOwner); > + BRUSH_ShareUnlockBrush(pbrush); > + return Ret; > } > > BOOL > > >

5 7

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev