Ros-dev

ros-dev@reactos.org

5790 discussions

[ros-diffs] [jgardou] 46698: [WIN32K] Unlock surface when deleting DC
by James Tabor 03 Apr '10

03 Apr '10

Since no one is listening (reading) to me about this issue and the response I receive is "WTF are you talking about"! Let me explain one more time..... In reference to commit 46679, I attempted to provide the project an example on how information contexts (IC) are created and removed. Works as a toggle between switching flags and moving the pdc->dclevel.pSurface pointer to and from pdc->pSurfInfo. The name of pSurfInfo should give a good clue. I was surprised when no one on IRC knew anything about this and it explains why the yarotows branch is not taking this into consideration. Remember my rant? Building code from broke code creates more broken code! Thus, increasing the amount of wasted time rewriting it. --- branches/reactos-yarotows/subsystems/win32/win32k/objects/dclife.c [iso-8859-1] (original) +++ branches/reactos-yarotows/subsystems/win32/win32k/objects/dclife.c [iso-8859-1] Sat Apr 3 18:42:04 2010 @@ -377,6 +377,9 @@ PATH_Delete(pdc->dclevel.hPath); + if(pdc->dclevel.pSurface) + SURFACE_ShareUnlockSurface(pdc->dclevel.pSurface); + PDEVOBJ_vRelease(pdc->ppdev) ; return TRUE; __________ Need to check for DC_TYPE_INFO and sometimes for DC_FLAG_TEMPINFODC. Quick check for pSurfInfo if NULL might be helpful too. I'm keeping track of yarotows and I see some needed merging into trunk (head, main branch) soon. 46630 is a good start. Thanks, James Referance: [ros-diffs] [jimtabor] 46679: [Win32k] - Implement MakeInfoDC and support functions. Dedicated to Timo. http://www.reactos.org/archives/public/ros-diffs/2010-April/036412.html

1 0

Re: [ros-dev] [ros-diffs] [jgardou] 46505: svn will drive me nuts, part 1/x
by Ged Murphy 03 Apr '10

03 Apr '10

This is not a valid commit message... -----Original Message----- From: ros-diffs-bounces(a)reactos.org [mailto:ros-diffs-bounces@reactos.org] On Behalf Of jgardou(a)svn.reactos.org Sent: 27 March 2010 23:28 To: ros-diffs(a)reactos.org Subject: [ros-diffs] [jgardou] 46505: svn will drive me nuts, part 1/x Author: jgardou Date: Sun Mar 28 00:28:24 2010 New Revision: 46505 URL: http://svn.reactos.org/svn/reactos?rev=46505&view=rev Log: svn will drive me nuts, part 1/x Added: branches/reactos-yarotows/drivers/bus/acpi/eval.c (with props) branches/reactos-yarotows/drivers/bus/acpi/interface.c (with props) branches/reactos-yarotows/drivers/storage/scsiport/scsiport.pspec (with props) branches/reactos-yarotows/drivers/storage/scsiport/stubs.c (with props) branches/reactos-yarotows/hal/halx86/up/pic.c (with props) branches/reactos-yarotows/hal/halx86/up/processor.c (with props) branches/reactos-yarotows/include/dxsdk/bdatif.idl branches/reactos-yarotows/include/ndk/peb_teb.h (with props) Modified: branches/reactos-yarotows/ (props changed) branches/reactos-yarotows/drivers/bus/acpi/cmbatt/cmbpnp.c branches/reactos-yarotows/drivers/bus/acpi/compbatt/compbatt.c branches/reactos-yarotows/drivers/bus/acpi/compbatt/compbatt.h branches/reactos-yarotows/drivers/bus/acpi/compbatt/comppnp.c branches/reactos-yarotows/media/inf/machine.inf branches/reactos-yarotows/ntoskrnl/io/pnpmgr/pnpmgr.c [This mail would be too long, it was shortened to contain the URLs only.] Modified: branches/reactos-yarotows/drivers/bus/acpi/cmbatt/cmbpnp.c URL: http://svn.reactos.org/svn/reactos/branches/reactos-yarotows/drivers/bus/ac… Modified: branches/reactos-yarotows/drivers/bus/acpi/compbatt/compbatt.c URL: http://svn.reactos.org/svn/reactos/branches/reactos-yarotows/drivers/bus/ac… Modified: branches/reactos-yarotows/drivers/bus/acpi/compbatt/compbatt.h URL: http://svn.reactos.org/svn/reactos/branches/reactos-yarotows/drivers/bus/ac… Modified: branches/reactos-yarotows/drivers/bus/acpi/compbatt/comppnp.c URL: http://svn.reactos.org/svn/reactos/branches/reactos-yarotows/drivers/bus/ac… Added: branches/reactos-yarotows/drivers/bus/acpi/eval.c URL: http://svn.reactos.org/svn/reactos/branches/reactos-yarotows/drivers/bus/ac… Added: branches/reactos-yarotows/drivers/bus/acpi/interface.c URL: http://svn.reactos.org/svn/reactos/branches/reactos-yarotows/drivers/bus/ac… Added: branches/reactos-yarotows/drivers/storage/scsiport/scsiport.pspec URL: http://svn.reactos.org/svn/reactos/branches/reactos-yarotows/drivers/storag… Added: branches/reactos-yarotows/drivers/storage/scsiport/stubs.c URL: http://svn.reactos.org/svn/reactos/branches/reactos-yarotows/drivers/storag… Added: branches/reactos-yarotows/hal/halx86/up/pic.c URL: http://svn.reactos.org/svn/reactos/branches/reactos-yarotows/hal/halx86/up/… Added: branches/reactos-yarotows/hal/halx86/up/processor.c URL: http://svn.reactos.org/svn/reactos/branches/reactos-yarotows/hal/halx86/up/… Added: branches/reactos-yarotows/include/dxsdk/bdatif.idl URL: http://svn.reactos.org/svn/reactos/branches/reactos-yarotows/include/dxsdk/… Added: branches/reactos-yarotows/include/ndk/peb_teb.h URL: http://svn.reactos.org/svn/reactos/branches/reactos-yarotows/include/ndk/pe… Modified: branches/reactos-yarotows/media/inf/machine.inf URL: http://svn.reactos.org/svn/reactos/branches/reactos-yarotows/media/inf/mach… Modified: branches/reactos-yarotows/ntoskrnl/io/pnpmgr/pnpmgr.c URL: http://svn.reactos.org/svn/reactos/branches/reactos-yarotows/ntoskrnl/io/pn…

2 1

Re: [ros-dev] [ros-diffs] [tkreuzer] 46677: Remove svn:mergeinfo property from several files
by Colin Finck 02 Apr '10

02 Apr '10

tkreuzer(a)svn.reactos.org wrote: > Remove svn:mergeinfo property from several files We should rather try to eliminate the root of these constant merge artifacts, which seem to be the remaining svn:keywords properties. As these ones instruct Subversion to update the revision number in the affected files, they probably also include the revision numbers of merges maintained by svn:mergeinfo. I've already removed some svn:keywords properties in the same files (for example in r41694), but I believe that this doesn't help much unless the properties are also removed in all branches we use for merging. Cheers, Colin

1 0

Re: [ros-dev] [ros-diffs] [sir_richard] 46613: [HALACPI]: Implement beginning of HAL ACPI support (HalpSetupAcpiPhase0). Tested on VMWare, where it found the FACP, SRAT, RSDT and MCFG and the ACPI Timer at 1008H. BOOT and DBGP are not found (optional features). [HA
by Ged Murphy 31 Mar '10

31 Mar '10

sir_richard(a)svn.reactos.org wrote: > [HALACPI]: Support depends on boot loader creating the ACPI BIOS Multi Node structure in > MultiFunctionAdapter in the hardware tree. It seems that FreeLdr does this (wow!) correctly! Oh ye of little faith :)

1 0

fastcall bug
by Steven Edwards 30 Mar '10

30 Mar '10

Hi, Have you guys seen this? http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41013 Is it really a problem? The discussion came up on wine-devel. Thanks -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

7 6

testcd is broken
by Timo Kreuzer 30 Mar '10

30 Mar '10

Hi, The testcd is broken. And no, it's not due to the header merge. This time it broke in r46574 (hal changes) Now please don't blame sir richard, instead someone please free some disk space on the testbot. Regards, Timo

1 0

TestCD build broken
by Olaf Siejka 27 Mar '10

27 Mar '10

Since rev. 46466, rostests build is broken. No iso are generated. Just in case anyone cares. http://build.reactos.org:8010/builders/x86_(Debug)/builds/4846/steps/compil…

1 0

Re: [ros-dev] [ros-diffs] [jimtabor] 46349: - Hack fix for gdibatch, please retest Acrobat reader 7.
by Aleksey Bragin 23 Mar '10

23 Mar '10

Forget what I said about acpi hack being nasty the other day. After looking at this one.... Aleksey. -------------------------------------------------- From: <jimtabor(a)svn.reactos.org> Sent: Tuesday, March 23, 2010 4:34 AM To: <ros-diffs(a)reactos.org> Subject: [ros-diffs] [jimtabor] 46349: - Hack fix for gdibatch,please retest Acrobat reader 7. > Author: jimtabor > Date: Tue Mar 23 02:34:30 2010 > New Revision: 46349 > > URL: http://svn.reactos.org/svn/reactos?rev=46349&view=rev > Log: > - Hack fix for gdibatch, please retest Acrobat reader 7. > > Modified: > trunk/reactos/subsystems/win32/win32k/objects/gdibatch.c > > Modified: trunk/reactos/subsystems/win32/win32k/objects/gdibatch.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/ob… > ============================================================================== > --- trunk/reactos/subsystems/win32/win32k/objects/gdibatch.c [iso-8859-1] > (original) > +++ trunk/reactos/subsystems/win32/win32k/objects/gdibatch.c [iso-8859-1] > Tue Mar 23 02:34:30 2010 > @@ -72,7 +72,7 @@ > { > pdcattr = dc->pdcattr; > } > - // The thread is approaching the end of sunset. > + // FYI! The thread is approaching the end of sunset. > switch(pHdr->Cmd) > { > case GdiBCPatBlt: // Highest pri first! > @@ -139,6 +139,7 @@ > APIENTRY > NtGdiFlushUserBatch(VOID) > { > + BOOL Hit; > PTEB pTeb = NtCurrentTeb(); > ULONG GdiBatchCount = pTeb->GdiBatchCount; > > @@ -160,8 +161,26 @@ > } > > // No need to init anything, just go! > - for (; GdiBatchCount > 0; GdiBatchCount--) > - { > + for (Hit = FALSE; GdiBatchCount > 0; GdiBatchCount--) > + { /* > + Looks like a hack, > + feels like a hack, > + you're right it's a hack, > + due to the lack, > + of kernel thread locking when it is in sunset! > + */ > + _SEH2_TRY > + { > + ((PGDIBATCHHDR)pHdr)->Cmd = ((PGDIBATCHHDR)pHdr)->Cmd; > + } > + _SEH2_EXCEPT(EXCEPTION_EXECUTE_HANDLER) > + { > + Hit = TRUE; > + } > + _SEH2_END; > + > + if (Hit) break; > + > // Process Gdi Batch! > pHdr += GdiFlushUserBatch(pDC, (PGDIBATCHHDR) pHdr); > } > >

1 0

Re: [ros-dev] OT - Which Editor/IDE people use for ReactOS
by WaxDragon 19 Mar '10

19 Mar '10

*points and laughs at the old man. VIM all the way, baby! On Mar 17, 2010 6:55 PM, "James Tabor" <jimtabor.rosdev(a)gmail.com> wrote: Hi! I guess it depends on how old some of us are. I use UNIX/Joe since I've used WordStar in the past. Sometimes G/Kedit too.Visual C++ on windows. Not OT at all, James On Tue, Mar 16, 2010 at 12:44 PM, Deepak Gupta <mailmeatdkg(a)gmail.com> wrote: > I have been browsin... _______________________________________________ Ros-dev mailing list Ros-dev(a)reactos.org http://www....

5 4

OT - Which Editor/IDE people use for ReactOS
by Deepak Gupta 19 Mar '10

19 Mar '10

I have been browsing through reactos sources (mainly boot and ntoskrnl). I was wondering which Editor/IDE people use for reactos sources. I am currently using gVim along with ctags to browse through the sources. Any suggestions which could be more helpful. Regards Deepak Gupta

6 7

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev